gcc-plugins: randstruct: Update code comment in relayout_struct()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Sat, 25 Nov 2023 21:49:12 +0000 (15:49 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Dec 2023 17:45:35 +0000 (18:45 +0100)
commit d71f22365a9caca82d424f3a33445de46567e198 upstream.

Update code comment to clarify that the only element whose layout is
not randomized is a proper C99 flexible-array member. This update is
complementary to commit 1ee60356c2dc ("gcc-plugins: randstruct: Only
warn about true flexible arrays")

Signed-off-by: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/ZWJr2MWDjXLHE8ap@work
Fixes: 1ee60356c2dc ("gcc-plugins: randstruct: Only warn about true flexible arrays")
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
scripts/gcc-plugins/randomize_layout_plugin.c

index 910bd21..746ff2d 100644 (file)
@@ -339,8 +339,7 @@ static int relayout_struct(tree type)
 
        /*
         * enforce that we don't randomize the layout of the last
-        * element of a struct if it's a 0 or 1-length array
-        * or a proper flexible array
+        * element of a struct if it's a proper flexible array
         */
        if (is_flexible_array(newtree[num_fields - 1])) {
                has_flexarray = true;