cifs: fix return of uninitialized rc in dfs_cache_update_tgthint()
authorPaulo Alcantara <pc@cjr.nz>
Wed, 18 Jan 2023 16:36:31 +0000 (13:36 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Feb 2023 07:06:33 +0000 (08:06 +0100)
[ Upstream commit d6a49e8c4ca4d399ed65ac219585187fc8c2e2b1 ]

Fix this by initializing rc to 0 as cache_refresh_path() would not set
it in case of success.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202301190004.bEHvbKG6-lkp@intel.com/
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/dfs_cache.c

index 4302dc7..3bc1d34 100644 (file)
@@ -1050,10 +1050,10 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
                             const struct nls_table *cp, int remap, const char *path,
                             const struct dfs_cache_tgt_iterator *it)
 {
-       int rc;
-       const char *npath;
-       struct cache_entry *ce;
        struct cache_dfs_tgt *t;
+       struct cache_entry *ce;
+       const char *npath;
+       int rc = 0;
 
        npath = dfs_cache_canonical_path(path, cp, remap);
        if (IS_ERR(npath))