ASoC: SOF: ipc4-loader: remove the CPC check warnings
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Mon, 15 Jan 2024 09:22:09 +0000 (11:22 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:35:58 +0000 (15:35 -0800)
[ Upstream commit ab09fb9c629ed3aaea6a82467f08595dbc549726 ]

Warnings related to missing data in firmware manifest have
proven to be too verbose. This relates to description of
DSP module cost expressed in cycles per chunk (CPC). If
a matching value is not found in the manifest, kernel will
pass a zero value and DSP firmware will use a conservative
value in its place.

Downgrade the warnings to dev_dbg().

Fixes: d8a2c9879349 ("ASoC: SOF: ipc4-loader/topology: Query the CPC value from manifest")
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://msgid.link/r/20240115092209.7184-3-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/sof/ipc4-loader.c

index eaa0476..4d37e89 100644 (file)
@@ -479,13 +479,10 @@ void sof_ipc4_update_cpc_from_manifest(struct snd_sof_dev *sdev,
                msg = "No CPC match in the firmware file's manifest";
 
 no_cpc:
-       dev_warn(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
-                fw_module->man4_module_entry.name,
-                &fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
-                basecfg->obs);
-       dev_warn_once(sdev->dev, "Please try to update the firmware.\n");
-       dev_warn_once(sdev->dev, "If the issue persists, file a bug at\n");
-       dev_warn_once(sdev->dev, "https://github.com/thesofproject/sof/issues/\n");
+       dev_dbg(sdev->dev, "%s (UUID: %pUL): %s (ibs/obs: %u/%u)\n",
+               fw_module->man4_module_entry.name,
+               &fw_module->man4_module_entry.uuid, msg, basecfg->ibs,
+               basecfg->obs);
 }
 
 const struct sof_ipc_fw_loader_ops ipc4_loader_ops = {