drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active 36/245636/1
authorMaxime Ripard <maxime@cerno.tech>
Mon, 12 Oct 2020 04:26:40 +0000 (13:26 +0900)
committerHoegeun Kwon <hoegeun.kwon@samsung.com>
Tue, 13 Oct 2020 08:58:18 +0000 (17:58 +0900)
The HVS has three FIFOs that can be assigned to a number of PixelValves
through a mux.

However, changing that FIFO requires that we disable and then enable the
pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not
just the active ones.

Fixes: 87ebcd42fb7b ("drm/vc4: crtc: Assign output to channel automatically")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
[hoegeun.kwon: Needed to fix page flip issue of dual hdmi.]
Signed-off-by: Hoegeun Kwon <hoegeun.kwon@samsung.com>
Change-Id: Id418d321e3cfc9b992bd1868e8084d9f8694a46e

drivers/gpu/drm/vc4/vc4_kms.c

index 2502405..96aadcb 100644 (file)
@@ -613,7 +613,7 @@ vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
                bool is_assigned = false;
                unsigned int channel;
 
-               if (!crtc_state->active || vc4->firmware_kms)
+               if (!crtc_state->enable || vc4->firmware_kms)
                        continue;
 
                /*