netfilter: xt_owner: bail out with EINVAL in case of unsupported flags 09/209209/1 accepted/tizen/unified/20190705.110609 submit/tizen/20190705.061120
authorPablo Neira Ayuso <pablo@netfilter.org>
Fri, 7 Jun 2019 14:37:30 +0000 (16:37 +0200)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Wed, 3 Jul 2019 10:01:50 +0000 (19:01 +0900)
Reject flags that are not supported with EINVAL.

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
[sw0312.kim: backport from mainline to apply supplementary groups on netfilter]
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Change-Id: I92f1bd37788cc71088112770bb1b4071dfe8f3fd

include/uapi/linux/netfilter/xt_owner.h
net/netfilter/xt_owner.c

index 9e98c09..5108df4 100644 (file)
@@ -11,6 +11,11 @@ enum {
        XT_OWNER_SUPPL_GROUPS = 1 << 3,
 };
 
+#define XT_OWNER_MASK  (XT_OWNER_UID |         \
+                        XT_OWNER_GID |         \
+                        XT_OWNER_SOCKET |      \
+                        XT_OWNER_SUPPL_GROUPS)
+
 struct xt_owner_match_info {
        __u32 uid_min, uid_max;
        __u32 gid_min, gid_max;
index acff455..67c7616 100644 (file)
@@ -25,6 +25,9 @@ static int owner_check(const struct xt_mtchk_param *par)
        struct xt_owner_match_info *info = par->matchinfo;
        struct net *net = par->net;
 
+       if (info->match & ~XT_OWNER_MASK)
+               return -EINVAL;
+
        /* Only allow the common case where the userns of the writer
         * matches the userns of the network namespace.
         */