Fixed wrong argument usage for geolocation permission popup
authorJihoon Chung <jihoon.chung@samsaung.com>
Tue, 1 Oct 2013 08:18:08 +0000 (17:18 +0900)
committerHoseon LEE <hoseon46.lee@samsung.com>
Mon, 14 Oct 2013 11:19:27 +0000 (20:19 +0900)
[Issue#]   N/A
[Problem]  Fail to set "allow"/"deny" even though user selects button
           on the permision request popup
[Cause]    Wrong argument passed to "SecurityOriginSupportUtil::getResult" API.
           - Wrong Usage : popup evas_object
           - Right Usage : button evas_object
[Solution] Change argument to correct evas_object for "button".

[SCMRequest] N/A

Change-Id: I6b02599837d5680747a9a2337cf3d6f29ef41c12

src/view/webkit/view_logic_geolocation_support.cpp

index 7c6921b..4648863 100644 (file)
@@ -101,16 +101,17 @@ void setPermissionResult(PermissionData* permData, Result result)
 void popupCallback(void* data, Evas_Object* obj, void* eventInfo)
 {
     _D("called");
-    DPL_UNUSED_PARAM(eventInfo);
 
-    Assert(data);
     Assert(obj);
+    Assert(data);
 
-    PermissionData* permData = static_cast<PermissionData*>(data);
-    Evas_Object* popup = getPopup(obj);
-    setPermissionResult(permData, getResult(popup));
+    DPL_UNUSED_PARAM(eventInfo);
 
+    PermissionData* permData = static_cast<PermissionData*>(data);
+    setPermissionResult(permData, getResult(obj));
     delete permData;
+
+    Evas_Object* popup = getPopup(obj);
     evas_object_hide(popup);
     evas_object_del(popup);
 }