src/net/quic/quic_packet_generator_test.cc

   1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
   2 // Use of this source code is governed by a BSD-style license that can be
   3 // found in the LICENSE file.
   4
   5 #include "net/quic/quic_packet_generator.h"
   6
   7 #include <string>
   8
   9 #include "net/quic/crypto/crypto_protocol.h"
  10 #include "net/quic/crypto/null_encrypter.h"
  11 #include "net/quic/crypto/quic_decrypter.h"
  12 #include "net/quic/crypto/quic_encrypter.h"
  13 #include "net/quic/quic_utils.h"
  14 #include "net/quic/test_tools/quic_test_utils.h"
  15 #include "net/quic/test_tools/simple_quic_framer.h"
  16 #include "testing/gmock/include/gmock/gmock.h"
  17 #include "testing/gtest/include/gtest/gtest.h"
  18
  19 using base::StringPiece;
  20 using std::string;
  21 using testing::InSequence;
  22 using testing::Return;
  23 using testing::SaveArg;
  24 using testing::StrictMock;
  25 using testing::_;
  26
  27 namespace net {
  28 namespace test {
  29 namespace {
  30
  31 class MockDelegate : public QuicPacketGenerator::DelegateInterface {
  32  public:
  33   MockDelegate() {}
  34   virtual ~MockDelegate() {}
  35
  36   MOCK_METHOD3(ShouldGeneratePacket,
  37                bool(TransmissionType transmission_type,
  38                     HasRetransmittableData retransmittable,
  39                     IsHandshake handshake));
  40   MOCK_METHOD0(CreateAckFrame, QuicAckFrame*());
  41   MOCK_METHOD0(CreateFeedbackFrame, QuicCongestionFeedbackFrame*());
  42   MOCK_METHOD0(CreateStopWaitingFrame, QuicStopWaitingFrame*());
  43   MOCK_METHOD1(OnSerializedPacket, bool(const SerializedPacket& packet));
  44   MOCK_METHOD2(CloseConnection, void(QuicErrorCode, bool));
  45
  46   void SetCanWriteAnything() {
  47     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION, _, _))
  48         .WillRepeatedly(Return(true));
  49     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION,
  50                                             NO_RETRANSMITTABLE_DATA, _))
  51         .WillRepeatedly(Return(true));
  52   }
  53
  54   void SetCanNotWrite() {
  55     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION, _, _))
  56         .WillRepeatedly(Return(false));
  57     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION,
  58                                             NO_RETRANSMITTABLE_DATA, _))
  59         .WillRepeatedly(Return(false));
  60   }
  61
  62   // Use this when only ack and feedback frames should be allowed to be written.
  63   void SetCanWriteOnlyNonRetransmittable() {
  64     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION, _, _))
  65         .WillRepeatedly(Return(false));
  66     EXPECT_CALL(*this, ShouldGeneratePacket(NOT_RETRANSMISSION,
  67                                             NO_RETRANSMITTABLE_DATA, _))
  68         .WillRepeatedly(Return(true));
  69   }
  70
  71  private:
  72   DISALLOW_COPY_AND_ASSIGN(MockDelegate);
  73 };
  74
  75 // Simple struct for describing the contents of a packet.
  76 // Useful in conjunction with a SimpleQuicFrame for validating
  77 // that a packet contains the expected frames.
  78 struct PacketContents {
  79   PacketContents()
  80       : num_ack_frames(0),
  81         num_connection_close_frames(0),
  82         num_feedback_frames(0),
  83         num_goaway_frames(0),
  84         num_rst_stream_frames(0),
  85         num_stop_waiting_frames(0),
  86         num_stream_frames(0),
  87         fec_group(0) {
  88   }
  89
  90   size_t num_ack_frames;
  91   size_t num_connection_close_frames;
  92   size_t num_feedback_frames;
  93   size_t num_goaway_frames;
  94   size_t num_rst_stream_frames;
  95   size_t num_stop_waiting_frames;
  96   size_t num_stream_frames;
  97
  98   QuicFecGroupNumber fec_group;
  99 };
 100
 101 }  // namespace
 102
 103 class QuicPacketGeneratorTest : public ::testing::Test {
 104  protected:
 105   QuicPacketGeneratorTest()
 106       : framer_(QuicSupportedVersions(), QuicTime::Zero(), false),
 107         creator_(42, &framer_, &random_, false),
 108         generator_(&delegate_, NULL, &creator_),
 109         packet_(0, PACKET_1BYTE_SEQUENCE_NUMBER, NULL, 0, NULL),
 110         packet2_(0, PACKET_1BYTE_SEQUENCE_NUMBER, NULL, 0, NULL),
 111         packet3_(0, PACKET_1BYTE_SEQUENCE_NUMBER, NULL, 0, NULL),
 112         packet4_(0, PACKET_1BYTE_SEQUENCE_NUMBER, NULL, 0, NULL),
 113         packet5_(0, PACKET_1BYTE_SEQUENCE_NUMBER, NULL, 0, NULL) {
 114   }
 115
 116   ~QuicPacketGeneratorTest() {
 117     delete packet_.packet;
 118     delete packet_.retransmittable_frames;
 119     delete packet2_.packet;
 120     delete packet2_.retransmittable_frames;
 121     delete packet3_.packet;
 122     delete packet3_.retransmittable_frames;
 123     delete packet4_.packet;
 124     delete packet4_.retransmittable_frames;
 125     delete packet5_.packet;
 126     delete packet5_.retransmittable_frames;
 127   }
 128
 129   QuicAckFrame* CreateAckFrame() {
 130     // TODO(rch): Initialize this so it can be verified later.
 131     return new QuicAckFrame(MakeAckFrame(0, 0));
 132   }
 133
 134   QuicCongestionFeedbackFrame* CreateFeedbackFrame() {
 135     QuicCongestionFeedbackFrame* frame = new QuicCongestionFeedbackFrame;
 136     frame->type = kFixRate;
 137     frame->fix_rate.bitrate = QuicBandwidth::FromBytesPerSecond(42);
 138     return frame;
 139   }
 140
 141   QuicStopWaitingFrame* CreateStopWaitingFrame() {
 142     QuicStopWaitingFrame* frame = new QuicStopWaitingFrame();
 143     frame->entropy_hash = 0;
 144     frame->least_unacked = 0;
 145     return frame;
 146   }
 147
 148   QuicRstStreamFrame* CreateRstStreamFrame() {
 149     return new QuicRstStreamFrame(1, QUIC_STREAM_NO_ERROR, 0);
 150   }
 151
 152   QuicGoAwayFrame* CreateGoAwayFrame() {
 153     return new QuicGoAwayFrame(QUIC_NO_ERROR, 1, string());
 154   }
 155
 156   void CheckPacketContains(const PacketContents& contents,
 157                            const SerializedPacket& packet) {
 158     size_t num_retransmittable_frames = contents.num_connection_close_frames +
 159         contents.num_goaway_frames + contents.num_rst_stream_frames +
 160         contents.num_stream_frames;
 161     size_t num_frames = contents.num_feedback_frames + contents.num_ack_frames +
 162         contents.num_stop_waiting_frames + num_retransmittable_frames;
 163
 164     if (num_retransmittable_frames == 0) {
 165       ASSERT_TRUE(packet.retransmittable_frames == NULL);
 166     } else {
 167       ASSERT_TRUE(packet.retransmittable_frames != NULL);
 168       EXPECT_EQ(num_retransmittable_frames,
 169                 packet.retransmittable_frames->frames().size());
 170     }
 171
 172     ASSERT_TRUE(packet.packet != NULL);
 173     ASSERT_TRUE(simple_framer_.ProcessPacket(*packet.packet));
 174     EXPECT_EQ(num_frames, simple_framer_.num_frames());
 175     EXPECT_EQ(contents.num_ack_frames, simple_framer_.ack_frames().size());
 176     EXPECT_EQ(contents.num_connection_close_frames,
 177               simple_framer_.connection_close_frames().size());
 178     EXPECT_EQ(contents.num_feedback_frames,
 179               simple_framer_.feedback_frames().size());
 180     EXPECT_EQ(contents.num_goaway_frames,
 181               simple_framer_.goaway_frames().size());
 182     EXPECT_EQ(contents.num_rst_stream_frames,
 183               simple_framer_.rst_stream_frames().size());
 184     EXPECT_EQ(contents.num_stream_frames,
 185               simple_framer_.stream_frames().size());
 186     EXPECT_EQ(contents.num_stop_waiting_frames,
 187               simple_framer_.stop_waiting_frames().size());
 188     EXPECT_EQ(contents.fec_group, simple_framer_.header().fec_group);
 189   }
 190
 191   void CheckPacketHasSingleStreamFrame(const SerializedPacket& packet) {
 192     ASSERT_TRUE(packet.retransmittable_frames != NULL);
 193     EXPECT_EQ(1u, packet.retransmittable_frames->frames().size());
 194     ASSERT_TRUE(packet.packet != NULL);
 195     ASSERT_TRUE(simple_framer_.ProcessPacket(*packet.packet));
 196     EXPECT_EQ(1u, simple_framer_.num_frames());
 197     EXPECT_EQ(1u, simple_framer_.stream_frames().size());
 198   }
 199
 200   void CheckPacketIsFec(const SerializedPacket& packet,
 201                         QuicPacketSequenceNumber fec_group) {
 202     ASSERT_TRUE(packet.retransmittable_frames == NULL);
 203     ASSERT_TRUE(packet.packet != NULL);
 204     ASSERT_TRUE(simple_framer_.ProcessPacket(*packet.packet));
 205     EXPECT_TRUE(simple_framer_.header().fec_flag);
 206     EXPECT_EQ(fec_group, simple_framer_.fec_data().fec_group);
 207   }
 208
 209   IOVector CreateData(size_t len) {
 210     data_array_.reset(new char[len]);
 211     memset(data_array_.get(), '?', len);
 212     IOVector data;
 213     data.Append(data_array_.get(), len);
 214     return data;
 215   }
 216
 217   QuicFramer framer_;
 218   MockRandom random_;
 219   QuicPacketCreator creator_;
 220   StrictMock<MockDelegate> delegate_;
 221   QuicPacketGenerator generator_;
 222   SimpleQuicFramer simple_framer_;
 223   SerializedPacket packet_;
 224   SerializedPacket packet2_;
 225   SerializedPacket packet3_;
 226   SerializedPacket packet4_;
 227   SerializedPacket packet5_;
 228
 229  private:
 230   scoped_ptr<char[]> data_array_;
 231 };
 232
 233 class MockDebugDelegate : public QuicPacketGenerator::DebugDelegateInterface {
 234  public:
 235   MOCK_METHOD1(OnFrameAddedToPacket,
 236                void(const QuicFrame&));
 237 };
 238
 239 TEST_F(QuicPacketGeneratorTest, ShouldSendAck_NotWritable) {
 240   delegate_.SetCanNotWrite();
 241
 242   generator_.SetShouldSendAck(false, false);
 243   EXPECT_TRUE(generator_.HasQueuedFrames());
 244 }
 245
 246 TEST_F(QuicPacketGeneratorTest, ShouldSendAck_WritableAndShouldNotFlush) {
 247   StrictMock<MockDebugDelegate> debug_delegate;
 248
 249   generator_.set_debug_delegate(&debug_delegate);
 250   delegate_.SetCanWriteOnlyNonRetransmittable();
 251   generator_.StartBatchOperations();
 252
 253   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 254   EXPECT_CALL(debug_delegate, OnFrameAddedToPacket(_)).Times(1);
 255
 256   generator_.SetShouldSendAck(false, false);
 257   EXPECT_TRUE(generator_.HasQueuedFrames());
 258 }
 259
 260 TEST_F(QuicPacketGeneratorTest, ShouldSendAck_WritableAndShouldFlush) {
 261   delegate_.SetCanWriteOnlyNonRetransmittable();
 262
 263   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 264   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 265       DoAll(SaveArg<0>(&packet_), Return(true)));
 266
 267   generator_.SetShouldSendAck(false, false);
 268   EXPECT_FALSE(generator_.HasQueuedFrames());
 269
 270   PacketContents contents;
 271   contents.num_ack_frames = 1;
 272   CheckPacketContains(contents, packet_);
 273 }
 274
 275 TEST_F(QuicPacketGeneratorTest,
 276        ShouldSendAckWithFeedback_WritableAndShouldNotFlush) {
 277   delegate_.SetCanWriteOnlyNonRetransmittable();
 278   generator_.StartBatchOperations();
 279
 280   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 281   EXPECT_CALL(delegate_, CreateFeedbackFrame()).WillOnce(
 282       Return(CreateFeedbackFrame()));
 283
 284   generator_.SetShouldSendAck(true, false);
 285   EXPECT_TRUE(generator_.HasQueuedFrames());
 286 }
 287
 288 TEST_F(QuicPacketGeneratorTest,
 289        ShouldSendAckWithFeedback_WritableAndShouldFlush) {
 290   delegate_.SetCanWriteOnlyNonRetransmittable();
 291
 292   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 293   EXPECT_CALL(delegate_, CreateFeedbackFrame()).WillOnce(
 294       Return(CreateFeedbackFrame()));
 295   EXPECT_CALL(delegate_, CreateStopWaitingFrame()).WillOnce(
 296       Return(CreateStopWaitingFrame()));
 297
 298   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 299       DoAll(SaveArg<0>(&packet_), Return(true)));
 300
 301   generator_.SetShouldSendAck(true, true);
 302   EXPECT_FALSE(generator_.HasQueuedFrames());
 303
 304   PacketContents contents;
 305   contents.num_ack_frames = 1;
 306   contents.num_feedback_frames = 1;
 307   contents.num_stop_waiting_frames = 1;
 308   CheckPacketContains(contents, packet_);
 309 }
 310
 311 TEST_F(QuicPacketGeneratorTest, AddControlFrame_NotWritable) {
 312   delegate_.SetCanNotWrite();
 313
 314   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 315   EXPECT_TRUE(generator_.HasQueuedFrames());
 316 }
 317
 318 TEST_F(QuicPacketGeneratorTest, AddControlFrame_OnlyAckWritable) {
 319   delegate_.SetCanWriteOnlyNonRetransmittable();
 320
 321   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 322   EXPECT_TRUE(generator_.HasQueuedFrames());
 323 }
 324
 325 TEST_F(QuicPacketGeneratorTest, AddControlFrame_WritableAndShouldNotFlush) {
 326   delegate_.SetCanWriteAnything();
 327   generator_.StartBatchOperations();
 328
 329   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 330   EXPECT_TRUE(generator_.HasQueuedFrames());
 331 }
 332
 333 TEST_F(QuicPacketGeneratorTest, AddControlFrame_NotWritableBatchThenFlush) {
 334   delegate_.SetCanNotWrite();
 335   generator_.StartBatchOperations();
 336
 337   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 338   EXPECT_TRUE(generator_.HasQueuedFrames());
 339   generator_.FinishBatchOperations();
 340   EXPECT_TRUE(generator_.HasQueuedFrames());
 341
 342   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 343       DoAll(SaveArg<0>(&packet_), Return(true)));
 344   generator_.FlushAllQueuedFrames();
 345   EXPECT_FALSE(generator_.HasQueuedFrames());
 346
 347   PacketContents contents;
 348   contents.num_rst_stream_frames = 1;
 349   CheckPacketContains(contents, packet_);
 350 }
 351
 352 TEST_F(QuicPacketGeneratorTest, AddControlFrame_WritableAndShouldFlush) {
 353   delegate_.SetCanWriteAnything();
 354
 355   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 356       DoAll(SaveArg<0>(&packet_), Return(true)));
 357
 358   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 359   EXPECT_FALSE(generator_.HasQueuedFrames());
 360
 361   PacketContents contents;
 362   contents.num_rst_stream_frames = 1;
 363   CheckPacketContains(contents, packet_);
 364 }
 365
 366 TEST_F(QuicPacketGeneratorTest, ConsumeData_NotWritable) {
 367   delegate_.SetCanNotWrite();
 368
 369   QuicConsumedData consumed = generator_.ConsumeData(1, MakeIOVector("foo"), 2,
 370                                                      true, NULL);
 371   EXPECT_EQ(0u, consumed.bytes_consumed);
 372   EXPECT_FALSE(consumed.fin_consumed);
 373   EXPECT_FALSE(generator_.HasQueuedFrames());
 374 }
 375
 376 TEST_F(QuicPacketGeneratorTest, ConsumeData_WritableAndShouldNotFlush) {
 377   delegate_.SetCanWriteAnything();
 378   generator_.StartBatchOperations();
 379
 380   QuicConsumedData consumed = generator_.ConsumeData(1, MakeIOVector("foo"), 2,
 381                                                      true, NULL);
 382   EXPECT_EQ(3u, consumed.bytes_consumed);
 383   EXPECT_TRUE(consumed.fin_consumed);
 384   EXPECT_TRUE(generator_.HasQueuedFrames());
 385 }
 386
 387 TEST_F(QuicPacketGeneratorTest, ConsumeData_WritableAndShouldFlush) {
 388   delegate_.SetCanWriteAnything();
 389
 390   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 391       DoAll(SaveArg<0>(&packet_), Return(true)));
 392   QuicConsumedData consumed = generator_.ConsumeData(1, MakeIOVector("foo"), 2,
 393                                                      true, NULL);
 394   EXPECT_EQ(3u, consumed.bytes_consumed);
 395   EXPECT_TRUE(consumed.fin_consumed);
 396   EXPECT_FALSE(generator_.HasQueuedFrames());
 397
 398   PacketContents contents;
 399   contents.num_stream_frames = 1;
 400   CheckPacketContains(contents, packet_);
 401 }
 402
 403 TEST_F(QuicPacketGeneratorTest,
 404        ConsumeDataMultipleTimes_WritableAndShouldNotFlush) {
 405   delegate_.SetCanWriteAnything();
 406   generator_.StartBatchOperations();
 407
 408   generator_.ConsumeData(1, MakeIOVector("foo"), 2, true, NULL);
 409   QuicConsumedData consumed = generator_.ConsumeData(3, MakeIOVector("quux"), 7,
 410                                                      false, NULL);
 411   EXPECT_EQ(4u, consumed.bytes_consumed);
 412   EXPECT_FALSE(consumed.fin_consumed);
 413   EXPECT_TRUE(generator_.HasQueuedFrames());
 414 }
 415
 416 TEST_F(QuicPacketGeneratorTest, ConsumeData_BatchOperations) {
 417   delegate_.SetCanWriteAnything();
 418   generator_.StartBatchOperations();
 419
 420   generator_.ConsumeData(1, MakeIOVector("foo"), 2, true, NULL);
 421   QuicConsumedData consumed = generator_.ConsumeData(3, MakeIOVector("quux"), 7,
 422                                                      false, NULL);
 423   EXPECT_EQ(4u, consumed.bytes_consumed);
 424   EXPECT_FALSE(consumed.fin_consumed);
 425   EXPECT_TRUE(generator_.HasQueuedFrames());
 426
 427   // Now both frames will be flushed out.
 428   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 429       DoAll(SaveArg<0>(&packet_), Return(true)));
 430   generator_.FinishBatchOperations();
 431   EXPECT_FALSE(generator_.HasQueuedFrames());
 432
 433   PacketContents contents;
 434   contents.num_stream_frames = 2;
 435   CheckPacketContains(contents, packet_);
 436 }
 437
 438 TEST_F(QuicPacketGeneratorTest, ConsumeDataFEC) {
 439   delegate_.SetCanWriteAnything();
 440
 441   // Send FEC every two packets.
 442   creator_.options()->max_packets_per_fec_group = 2;
 443
 444   {
 445     InSequence dummy;
 446     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 447         DoAll(SaveArg<0>(&packet_), Return(true)));
 448     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 449         DoAll(SaveArg<0>(&packet2_), Return(true)));
 450     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 451         DoAll(SaveArg<0>(&packet3_), Return(true)));
 452     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 453         DoAll(SaveArg<0>(&packet4_), Return(true)));
 454     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 455         DoAll(SaveArg<0>(&packet5_), Return(true)));
 456   }
 457
 458   // Send enough data to create 3 packets: two full and one partial.
 459   size_t data_len = 2 * kDefaultMaxPacketSize + 100;
 460   QuicConsumedData consumed =
 461       generator_.ConsumeData(3, CreateData(data_len), 0, true, NULL);
 462   EXPECT_EQ(data_len, consumed.bytes_consumed);
 463   EXPECT_TRUE(consumed.fin_consumed);
 464   EXPECT_FALSE(generator_.HasQueuedFrames());
 465
 466   CheckPacketHasSingleStreamFrame(packet_);
 467   CheckPacketHasSingleStreamFrame(packet2_);
 468   CheckPacketIsFec(packet3_, 1);
 469
 470   CheckPacketHasSingleStreamFrame(packet4_);
 471   CheckPacketIsFec(packet5_, 4);
 472 }
 473
 474 TEST_F(QuicPacketGeneratorTest, ConsumeDataSendsFecAtEnd) {
 475   delegate_.SetCanWriteAnything();
 476
 477   // Send FEC every six packets.
 478   creator_.options()->max_packets_per_fec_group = 6;
 479
 480   {
 481     InSequence dummy;
 482     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 483         DoAll(SaveArg<0>(&packet_), Return(true)));
 484     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 485         DoAll(SaveArg<0>(&packet2_), Return(true)));
 486     EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 487         DoAll(SaveArg<0>(&packet3_), Return(true)));
 488   }
 489
 490   // Send enough data to create 2 packets: one full and one partial.
 491   size_t data_len = 1 * kDefaultMaxPacketSize + 100;
 492   QuicConsumedData consumed =
 493       generator_.ConsumeData(3, CreateData(data_len), 0, true, NULL);
 494   EXPECT_EQ(data_len, consumed.bytes_consumed);
 495   EXPECT_TRUE(consumed.fin_consumed);
 496   EXPECT_FALSE(generator_.HasQueuedFrames());
 497
 498   CheckPacketHasSingleStreamFrame(packet_);
 499   CheckPacketHasSingleStreamFrame(packet2_);
 500   CheckPacketIsFec(packet3_, 1);
 501 }
 502
 503 TEST_F(QuicPacketGeneratorTest, ConsumeData_FramesPreviouslyQueued) {
 504   // Set the packet size be enough for two stream frames with 0 stream offset,
 505   // but not enough for a stream frame of 0 offset and one with non-zero offset.
 506   creator_.options()->max_packet_length =
 507       NullEncrypter().GetCiphertextSize(0) +
 508       GetPacketHeaderSize(creator_.options()->send_connection_id_length,
 509                           true,
 510                           creator_.options()->send_sequence_number_length,
 511                           NOT_IN_FEC_GROUP) +
 512       // Add an extra 3 bytes for the payload and 1 byte so BytesFree is larger
 513       // than the GetMinStreamFrameSize.
 514       QuicFramer::GetMinStreamFrameSize(framer_.version(), 1, 0, false,
 515                                         NOT_IN_FEC_GROUP) + 3 +
 516       QuicFramer::GetMinStreamFrameSize(framer_.version(), 1, 0, true,
 517                                         NOT_IN_FEC_GROUP) + 1;
 518   delegate_.SetCanWriteAnything();
 519   {
 520      InSequence dummy;
 521      EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 522          DoAll(SaveArg<0>(&packet_), Return(true)));
 523      EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 524          DoAll(SaveArg<0>(&packet2_), Return(true)));
 525   }
 526   generator_.StartBatchOperations();
 527   // Queue enough data to prevent a stream frame with a non-zero offset from
 528   // fitting.
 529   QuicConsumedData consumed = generator_.ConsumeData(1, MakeIOVector("foo"), 0,
 530                                                      false, NULL);
 531   EXPECT_EQ(3u, consumed.bytes_consumed);
 532   EXPECT_FALSE(consumed.fin_consumed);
 533   EXPECT_TRUE(generator_.HasQueuedFrames());
 534
 535   // This frame will not fit with the existing frame, causing the queued frame
 536   // to be serialized, and it will not fit with another frame like it, so it is
 537   // serialized by itself.
 538   consumed = generator_.ConsumeData(1, MakeIOVector("bar"), 3, true, NULL);
 539   EXPECT_EQ(3u, consumed.bytes_consumed);
 540   EXPECT_TRUE(consumed.fin_consumed);
 541   EXPECT_FALSE(generator_.HasQueuedFrames());
 542
 543   PacketContents contents;
 544   contents.num_stream_frames = 1;
 545   CheckPacketContains(contents, packet_);
 546   CheckPacketContains(contents, packet2_);
 547 }
 548
 549 TEST_F(QuicPacketGeneratorTest, NotWritableThenBatchOperations) {
 550   delegate_.SetCanNotWrite();
 551
 552   generator_.SetShouldSendAck(true, false);
 553   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 554   EXPECT_TRUE(generator_.HasQueuedFrames());
 555
 556   delegate_.SetCanWriteAnything();
 557
 558   generator_.StartBatchOperations();
 559
 560   // When the first write operation is invoked, the ack and feedback
 561   // frames will be returned.
 562   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 563   EXPECT_CALL(delegate_, CreateFeedbackFrame()).WillOnce(
 564       Return(CreateFeedbackFrame()));
 565
 566   // Send some data and a control frame
 567   generator_.ConsumeData(3, MakeIOVector("quux"), 7, false, NULL);
 568   generator_.AddControlFrame(QuicFrame(CreateGoAwayFrame()));
 569
 570   // All five frames will be flushed out in a single packet.
 571   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 572       DoAll(SaveArg<0>(&packet_), Return(true)));
 573   generator_.FinishBatchOperations();
 574   EXPECT_FALSE(generator_.HasQueuedFrames());
 575
 576   PacketContents contents;
 577   contents.num_ack_frames = 1;
 578   contents.num_goaway_frames = 1;
 579   contents.num_feedback_frames = 1;
 580   contents.num_rst_stream_frames = 1;
 581   contents.num_stream_frames = 1;
 582   CheckPacketContains(contents, packet_);
 583 }
 584
 585 TEST_F(QuicPacketGeneratorTest, NotWritableThenBatchOperations2) {
 586   delegate_.SetCanNotWrite();
 587
 588   generator_.SetShouldSendAck(true, false);
 589   generator_.AddControlFrame(QuicFrame(CreateRstStreamFrame()));
 590   EXPECT_TRUE(generator_.HasQueuedFrames());
 591
 592   delegate_.SetCanWriteAnything();
 593
 594   generator_.StartBatchOperations();
 595
 596   // When the first write operation is invoked, the ack and feedback
 597   // frames will be returned.
 598   EXPECT_CALL(delegate_, CreateAckFrame()).WillOnce(Return(CreateAckFrame()));
 599   EXPECT_CALL(delegate_, CreateFeedbackFrame()).WillOnce(
 600       Return(CreateFeedbackFrame()));
 601
 602   {
 603     InSequence dummy;
 604   // All five frames will be flushed out in a single packet
 605   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 606       DoAll(SaveArg<0>(&packet_), Return(true)));
 607   EXPECT_CALL(delegate_, OnSerializedPacket(_)).WillOnce(
 608       DoAll(SaveArg<0>(&packet2_), Return(true)));
 609   }
 610
 611   // Send enough data to exceed one packet
 612   size_t data_len = kDefaultMaxPacketSize + 100;
 613   QuicConsumedData consumed =
 614       generator_.ConsumeData(3, CreateData(data_len), 0, true, NULL);
 615   EXPECT_EQ(data_len, consumed.bytes_consumed);
 616   EXPECT_TRUE(consumed.fin_consumed);
 617   generator_.AddControlFrame(QuicFrame(CreateGoAwayFrame()));
 618
 619   generator_.FinishBatchOperations();
 620   EXPECT_FALSE(generator_.HasQueuedFrames());
 621
 622   // The first packet should have the queued data and part of the stream data.
 623   PacketContents contents;
 624   contents.num_ack_frames = 1;
 625   contents.num_feedback_frames = 1;
 626   contents.num_rst_stream_frames = 1;
 627   contents.num_stream_frames = 1;
 628   CheckPacketContains(contents, packet_);
 629
 630   // The second should have the remainder of the stream data.
 631   PacketContents contents2;
 632   contents2.num_goaway_frames = 1;
 633   contents2.num_stream_frames = 1;
 634   CheckPacketContains(contents2, packet2_);
 635 }
 636
 637 }  // namespace test
 638 }  // namespace net