1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
5 #include "chrome/browser/extensions/error_console/error_console.h"
7 #include "base/files/file_path.h"
8 #include "base/prefs/pref_service.h"
9 #include "base/strings/string16.h"
10 #include "base/strings/stringprintf.h"
11 #include "base/strings/utf_string_conversions.h"
12 #include "chrome/browser/extensions/extension_browsertest.h"
13 #include "chrome/browser/extensions/extension_toolbar_model.h"
14 #include "chrome/browser/profiles/profile.h"
15 #include "chrome/common/pref_names.h"
16 #include "chrome/common/url_constants.h"
17 #include "chrome/test/base/ui_test_utils.h"
18 #include "extensions/browser/extension_error.h"
19 #include "extensions/common/constants.h"
20 #include "extensions/common/error_utils.h"
21 #include "extensions/common/extension.h"
22 #include "extensions/common/extension_urls.h"
23 #include "extensions/common/feature_switch.h"
24 #include "extensions/common/manifest_constants.h"
25 #include "net/test/embedded_test_server/embedded_test_server.h"
26 #include "testing/gtest/include/gtest/gtest.h"
30 using base::UTF8ToUTF16;
32 namespace extensions {
36 const char kTestingPage[] = "/extensions/test_file.html";
37 const char kAnonymousFunction[] = "(anonymous function)";
38 const char* kBackgroundPageName =
39 extensions::kGeneratedBackgroundPageFilename;
40 const int kNoFlags = 0;
42 const StackTrace& GetStackTraceFromError(const ExtensionError* error) {
43 CHECK(error->type() == ExtensionError::RUNTIME_ERROR);
44 return (static_cast<const RuntimeError*>(error))->stack_trace();
47 // Verify that a given |frame| has the proper source and function name.
48 void CheckStackFrame(const StackFrame& frame,
49 const std::string& source,
50 const std::string& function) {
51 EXPECT_EQ(base::UTF8ToUTF16(source), frame.source);
52 EXPECT_EQ(base::UTF8ToUTF16(function), frame.function);
55 // Verify that all properties of a given |frame| are correct. Overloaded because
56 // we commonly do not check line/column numbers, as they are too likely
58 void CheckStackFrame(const StackFrame& frame,
59 const std::string& source,
60 const std::string& function,
62 size_t column_number) {
63 CheckStackFrame(frame, source, function);
64 EXPECT_EQ(line_number, frame.line_number);
65 EXPECT_EQ(column_number, frame.column_number);
68 // Verify that all properties of a given |error| are correct.
69 void CheckError(const ExtensionError* error,
70 ExtensionError::Type type,
71 const std::string& id,
72 const std::string& source,
74 const std::string& message) {
76 EXPECT_EQ(type, error->type());
77 EXPECT_EQ(id, error->extension_id());
78 EXPECT_EQ(base::UTF8ToUTF16(source), error->source());
79 EXPECT_EQ(from_incognito, error->from_incognito());
80 EXPECT_EQ(base::UTF8ToUTF16(message), error->message());
83 // Verify that all properties of a JS runtime error are correct.
84 void CheckRuntimeError(const ExtensionError* error,
85 const std::string& id,
86 const std::string& source,
88 const std::string& message,
89 logging::LogSeverity level,
91 size_t expected_stack_size) {
93 ExtensionError::RUNTIME_ERROR,
99 const RuntimeError* runtime_error = static_cast<const RuntimeError*>(error);
100 EXPECT_EQ(level, runtime_error->level());
101 EXPECT_EQ(context, runtime_error->context_url());
102 EXPECT_EQ(expected_stack_size, runtime_error->stack_trace().size());
105 void CheckManifestError(const ExtensionError* error,
106 const std::string& id,
107 const std::string& message,
108 const std::string& manifest_key,
109 const std::string& manifest_specific) {
111 ExtensionError::MANIFEST_ERROR,
113 // source is always the manifest for ManifestErrors.
114 base::FilePath(kManifestFilename).AsUTF8Unsafe(),
115 false, // manifest errors are never from incognito.
118 const ManifestError* manifest_error =
119 static_cast<const ManifestError*>(error);
120 EXPECT_EQ(base::UTF8ToUTF16(manifest_key), manifest_error->manifest_key());
121 EXPECT_EQ(base::UTF8ToUTF16(manifest_specific),
122 manifest_error->manifest_specific());
127 class ErrorConsoleBrowserTest : public ExtensionBrowserTest {
129 ErrorConsoleBrowserTest() : error_console_(NULL) { }
130 virtual ~ErrorConsoleBrowserTest() { }
133 // A helper class in order to wait for the proper number of errors to be
134 // caught by the ErrorConsole. This will run the MessageLoop until a given
135 // number of errors are observed.
138 // ErrorObserver observer(3, error_console);
139 // <Cause three errors...>
140 // observer.WaitForErrors();
141 // <Perform any additional checks...>
142 class ErrorObserver : public ErrorConsole::Observer {
144 ErrorObserver(size_t errors_expected, ErrorConsole* error_console)
145 : errors_observed_(0),
146 errors_expected_(errors_expected),
148 error_console_(error_console) {
149 error_console_->AddObserver(this);
151 virtual ~ErrorObserver() {
153 error_console_->RemoveObserver(this);
156 // ErrorConsole::Observer implementation.
157 virtual void OnErrorAdded(const ExtensionError* error) OVERRIDE {
159 if (errors_observed_ >= errors_expected_) {
161 base::MessageLoopForUI::current()->Quit();
165 virtual void OnErrorConsoleDestroyed() OVERRIDE {
166 error_console_ = NULL;
169 // Spin until the appropriate number of errors have been observed.
170 void WaitForErrors() {
171 if (errors_observed_ < errors_expected_) {
173 content::RunMessageLoop();
179 size_t errors_observed_;
180 size_t errors_expected_;
183 ErrorConsole* error_console_;
185 DISALLOW_COPY_AND_ASSIGN(ErrorObserver);
188 // The type of action which we take after we load an extension in order to
191 // Navigate to a (non-chrome) page to allow a content script to run.
193 // Simulate a browser action click.
194 ACTION_BROWSER_ACTION,
195 // Navigate to the new tab page.
197 // Do nothing (errors will be caused by a background script,
198 // or by a manifest/loading warning).
202 virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
203 ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
205 // We need to enable the ErrorConsole FeatureSwitch in order to collect
206 // errors. This should be enabled on any channel <= Dev, but let's make
207 // sure (in case a test is running on, e.g., a beta channel).
208 FeatureSwitch::error_console()->SetOverrideValue(
209 FeatureSwitch::OVERRIDE_ENABLED);
212 virtual void SetUpOnMainThread() OVERRIDE {
213 ExtensionBrowserTest::SetUpOnMainThread();
215 // Errors are only kept if we have Developer Mode enabled.
216 profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
218 error_console_ = ErrorConsole::Get(profile());
219 CHECK(error_console_);
221 test_data_dir_ = test_data_dir_.AppendASCII("error_console");
224 const GURL& GetTestURL() {
225 if (test_url_.is_empty()) {
226 CHECK(embedded_test_server()->InitializeAndWaitUntilReady());
227 test_url_ = embedded_test_server()->GetURL(kTestingPage);
232 // Load the extension at |path|, take the specified |action|, and wait for
233 // |expected_errors| errors. Populate |extension| with a pointer to the loaded
235 void LoadExtensionAndCheckErrors(
236 const std::string& path,
238 size_t errors_expected,
240 const Extension** extension) {
241 ErrorObserver observer(errors_expected, error_console_);
243 LoadExtensionWithFlags(test_data_dir_.AppendASCII(path), flags);
244 ASSERT_TRUE(*extension);
247 case ACTION_NAVIGATE: {
248 ui_test_utils::NavigateToURL(browser(), GetTestURL());
251 case ACTION_BROWSER_ACTION: {
252 ExtensionToolbarModel::Get(profile())->ExecuteBrowserAction(
253 *extension, browser(), NULL, true);
256 case ACTION_NEW_TAB: {
257 ui_test_utils::NavigateToURL(browser(),
258 GURL(chrome::kChromeUINewTabURL));
267 observer.WaitForErrors();
269 // We should only have errors for a single extension, or should have no
270 // entries, if no errors were expected.
271 ASSERT_EQ(errors_expected > 0 ? 1u : 0u,
272 error_console()->get_num_entries_for_test());
275 error_console()->GetErrorsForExtension((*extension)->id()).size());
278 ErrorConsole* error_console() { return error_console_; }
280 // The URL used in testing for simple page navigations.
283 // Weak reference to the ErrorConsole.
284 ErrorConsole* error_console_;
287 // Test to ensure that we are successfully reporting manifest errors as an
288 // extension is installed.
289 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, ReportManifestErrors) {
290 const Extension* extension = NULL;
291 // We expect two errors - one for an invalid permission, and a second for
293 LoadExtensionAndCheckErrors("manifest_warnings",
294 ExtensionBrowserTest::kFlagIgnoreManifestWarnings,
299 const ErrorList& errors =
300 error_console()->GetErrorsForExtension(extension->id());
302 // Unfortunately, there's not always a hard guarantee of order in parsing the
303 // manifest, so there's not a definitive order in which these errors may
304 // occur. As such, we need to determine which error corresponds to which
306 const ExtensionError* permissions_error = NULL;
307 const ExtensionError* unknown_key_error = NULL;
308 const char kFakeKey[] = "not_a_real_key";
309 for (size_t i = 0; i < errors.size(); ++i) {
310 ASSERT_EQ(ExtensionError::MANIFEST_ERROR, errors[i]->type());
311 std::string utf8_key = base::UTF16ToUTF8(
312 (static_cast<const ManifestError*>(errors[i]))->manifest_key());
313 if (utf8_key == manifest_keys::kPermissions)
314 permissions_error = errors[i];
315 else if (utf8_key == kFakeKey)
316 unknown_key_error = errors[i];
318 ASSERT_TRUE(permissions_error);
319 ASSERT_TRUE(unknown_key_error);
321 const char kFakePermission[] = "not_a_real_permission";
322 CheckManifestError(permissions_error,
324 ErrorUtils::FormatErrorMessage(
325 manifest_errors::kPermissionUnknownOrMalformed,
327 manifest_keys::kPermissions,
330 CheckManifestError(unknown_key_error,
332 ErrorUtils::FormatErrorMessage(
333 manifest_errors::kUnrecognizedManifestKey,
339 // Test that we do not store any errors unless the Developer Mode switch is
340 // toggled on the profile.
341 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
342 DontStoreErrorsWithoutDeveloperMode) {
343 profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
345 const Extension* extension = NULL;
346 // Same test as ReportManifestErrors, except we don't expect any errors since
347 // we disable Developer Mode.
348 LoadExtensionAndCheckErrors("manifest_warnings",
349 ExtensionBrowserTest::kFlagIgnoreManifestWarnings,
354 // Now if we enable developer mode, the errors should be reported...
355 profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, true);
356 EXPECT_EQ(2u, error_console()->GetErrorsForExtension(extension->id()).size());
358 // ... and if we disable it again, all errors which we were holding should be
360 profile()->GetPrefs()->SetBoolean(prefs::kExtensionsUIDeveloperMode, false);
361 EXPECT_EQ(0u, error_console()->GetErrorsForExtension(extension->id()).size());
364 // Load an extension which, upon visiting any page, first sends out a console
365 // log, and then crashes with a JS TypeError.
366 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest,
367 ContentScriptLogAndRuntimeError) {
368 const Extension* extension = NULL;
369 LoadExtensionAndCheckErrors(
370 "content_script_log_and_runtime_error",
372 2u, // Two errors: A log message and a JS type error.
376 std::string script_url = extension->url().Resolve("content_script.js").spec();
378 const ErrorList& errors =
379 error_console()->GetErrorsForExtension(extension->id());
381 // The first error should be a console log.
382 CheckRuntimeError(errors[0],
384 script_url, // The source should be the content script url.
385 false, // Not from incognito.
386 "Hello, World!", // The error message is the log.
388 GetTestURL(), // Content scripts run in the web page.
391 const StackTrace& stack_trace1 = GetStackTraceFromError(errors[0]);
392 CheckStackFrame(stack_trace1[0],
394 "logHelloWorld", // function name
396 11u /* column number */ );
398 CheckStackFrame(stack_trace1[1],
404 // The second error should be a runtime error.
405 CheckRuntimeError(errors[1],
408 false, // not from incognito
409 "Uncaught TypeError: "
410 "Cannot set property 'foo' of undefined",
411 logging::LOG_ERROR, // JS errors are always ERROR level.
415 const StackTrace& stack_trace2 = GetStackTraceFromError(errors[1]);
416 CheckStackFrame(stack_trace2[0],
423 // Catch an error from a BrowserAction; this is more complex than a content
424 // script error, since browser actions are routed through our own code.
425 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BrowserActionRuntimeError) {
426 const Extension* extension = NULL;
427 LoadExtensionAndCheckErrors(
428 "browser_action_runtime_error",
430 1u, // One error: A reference error from within the browser action.
431 ACTION_BROWSER_ACTION,
434 std::string script_url = extension->url().Resolve("browser_action.js").spec();
436 const ErrorList& errors =
437 error_console()->GetErrorsForExtension(extension->id());
439 std::string event_bindings_str =
440 base::StringPrintf("extensions::%s", kEventBindings);
442 std::string event_dispatch_to_listener_str =
443 base::StringPrintf("Event.publicClass.%s [as dispatchToListener]",
450 false, // not incognito
451 "Error in event handler for browserAction.onClicked: baz is not defined\n"
452 "Stack trace: ReferenceError: baz is not defined",
454 extension->url().Resolve(kBackgroundPageName),
457 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
459 CheckStackFrame(stack_trace[0], script_url, kAnonymousFunction);
460 CheckStackFrame(stack_trace[1],
461 "extensions::SafeBuiltins",
462 std::string("Function.target.") + kAnonymousFunction);
464 stack_trace[2], event_bindings_str, "EventImpl.dispatchToListener");
465 CheckStackFrame(stack_trace[3],
466 "extensions::SafeBuiltins",
467 std::string("Function.target.") + kAnonymousFunction);
468 CheckStackFrame(stack_trace[4], "extensions::utils",
469 event_dispatch_to_listener_str);
470 CheckStackFrame(stack_trace[5], event_bindings_str, "EventImpl.dispatch_");
471 CheckStackFrame(stack_trace[6], event_bindings_str, "dispatchArgs");
472 CheckStackFrame(stack_trace[7], event_bindings_str, "dispatchEvent");
475 // Test that we can catch an error for calling an API with improper arguments.
476 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadAPIArgumentsRuntimeError) {
477 const Extension* extension = NULL;
478 LoadExtensionAndCheckErrors(
479 "bad_api_arguments_runtime_error",
481 1, // One error: call an API with improper arguments.
485 const ErrorList& errors =
486 error_console()->GetErrorsForExtension(extension->id());
488 std::string schema_utils_str =
489 base::StringPrintf("extensions::%s", kSchemaUtils);
494 schema_utils_str, // API calls are checked in schemaUtils.js.
495 false, // not incognito
496 "Uncaught Error: Invocation of form "
497 "tabs.get(string, function) doesn't match definition "
498 "tabs.get(integer tabId, function callback)",
500 extension->url().Resolve(kBackgroundPageName),
503 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
504 ASSERT_EQ(1u, stack_trace.size());
505 CheckStackFrame(stack_trace[0],
510 // Test that we catch an error when we try to call an API method without
512 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadAPIPermissionsRuntimeError) {
513 const Extension* extension = NULL;
514 LoadExtensionAndCheckErrors(
515 "bad_api_permissions_runtime_error",
517 1, // One error: we try to call addUrl() on chrome.history without
518 // permission, which results in a TypeError.
522 std::string script_url = extension->url().Resolve("background.js").spec();
524 const ErrorList& errors =
525 error_console()->GetErrorsForExtension(extension->id());
531 false, // not incognito
532 "Uncaught TypeError: Cannot read property 'addUrl' of undefined",
534 extension->url().Resolve(kBackgroundPageName),
537 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
538 ASSERT_EQ(1u, stack_trace.size());
539 CheckStackFrame(stack_trace[0],
545 // Test that if there is an error in an HTML page loaded by an extension (most
546 // common with apps), it is caught and reported by the ErrorConsole.
547 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, BadExtensionPage) {
548 const Extension* extension = NULL;
549 LoadExtensionAndCheckErrors(
550 "bad_extension_page",
552 1, // One error: the page will load JS which has a reference error.
557 // Test that extension errors that go to chrome.runtime.lastError are caught
558 // and reported by the ErrorConsole.
559 IN_PROC_BROWSER_TEST_F(ErrorConsoleBrowserTest, CatchesLastError) {
560 const Extension* extension = NULL;
561 LoadExtensionAndCheckErrors(
562 "trigger_last_error",
564 1, // One error, which is sent through last error when trying to remove
565 // a non-existent permisison.
569 const ErrorList& errors =
570 error_console()->GetErrorsForExtension(extension->id());
571 ASSERT_EQ(1u, errors.size());
573 std::string script_url = extension->url().Resolve("background.js").spec();
579 false, // not incognito
580 "Unchecked runtime.lastError while running permissions.remove: "
581 "'foobar' is not a recognized permission.",
583 extension->url().Resolve(kBackgroundPageName),
586 const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
587 ASSERT_EQ(1u, stack_trace.size());
588 CheckStackFrame(stack_trace[0],
594 } // namespace extensions