Fix build on unified-X platform

- Disable v8_enable_static_roots according to 'https://groups.google.com/g/v8-reviews/c/GIhTcy8qMe4?pli=1'
- Fix minor changes with std::move and lvalues in v8/src/base
- Move -fconcepts flag to 'cflags_cc' instead of 'cflags'

Change-Id: Ib82c8333750d86a0ccc3a01f95c13c9d5d4d5a2d
Signed-off-by: Daniil Ruban <intx82@gmail.com>

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 812f071..9e7ff32 100644 (file)
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -510,7 +510,8 @@ config("compiler") {
     if (!is_clang) {
       # Use pipes for communicating between sub-processes. Faster.
       # (This flag doesn't do anything with Clang.)
-      cflags += [ "-pipe", "-fconcepts", "-flax-vector-conversions" ]
+      cflags += [ "-pipe", "-flax-vector-conversions" ]
+      cflags_cc += [ "-fconcepts" ]
     }
 
     ldflags += [

diff --git a/v8/BUILD.gn b/v8/BUILD.gn
index 6d10a4e..f44bb58 100644 (file)
--- a/v8/BUILD.gn
+++ b/v8/BUILD.gn
@@ -131,7 +131,7 @@ declare_args() {
   v8_enable_snapshot_native_code_counters = ""
 
   # Use pre-generated static root pointer values from static-roots.h.
-  v8_enable_static_roots = ""
+  v8_enable_static_roots = false
 
   # Mode used by gen-static-roots.py to have a heap layout which is identical
   # to when v8_enable_static_roots is enabled.

diff --git a/v8/src/base/optional.h b/v8/src/base/optional.h
index d24a686..d34fc84 100644 (file)
--- a/v8/src/base/optional.h
+++ b/v8/src/base/optional.h
@@ -632,7 +632,7 @@ class OPTIONAL_DECLSPEC_EMPTY_BASES Optional
                   "U must be convertible to T");
     return storage_.is_populated_
                ? std::move(storage_.value_)
-               : static_cast<T>(std::forward<U>(default_value));
+               : default_value;
   }
 
   void swap(Optional& other) {