Fix build warning in third party modules 02/307702/6
authorDongHyun Song <dh81.song@samsung.com>
Tue, 12 Mar 2024 08:59:20 +0000 (17:59 +0900)
committerDongHyun Song <dh81.song@samsung.com>
Thu, 14 Mar 2024 02:43:15 +0000 (02:43 +0000)
Fix build warnings related to Tizen features in third party modules

Change-Id: I7a830f11889acf9d4cc675aabd18e9a0c439f535
Signed-off-by: DongHyun Song <dh81.song@samsung.com>
third_party/blink/renderer/core/exported/web_view_impl.h
third_party/blink/renderer/platform/fonts/font_palette.h
third_party/blink/renderer/platform/widget/widget_base.h
third_party/blink/renderer/platform/widget/widget_base_client.h

index b830376..9de841d 100644 (file)
@@ -549,8 +549,9 @@ class CORE_EXPORT WebViewImpl final : public WebView,
   WebSettingsImpl* SettingsImpl();
 
 #if BUILDFLAG(IS_TIZEN)
-  virtual void PauseScheduledTasks();
-  virtual void UnpauseScheduledTasks();
+  // WebView
+  void PauseScheduledTasks() override;
+  void UnpauseScheduledTasks() override;
 #endif
 
   BrowserControls& GetBrowserControls();
index c6024fe..04509d5 100644 (file)
@@ -36,10 +36,8 @@ class PLATFORM_EXPORT FontPalette : public RefCounted<FontPalette> {
     Color color;
 
     FontPaletteOverride(){}
-    FontPaletteOverride(int index, Color color) {
-      index = index;
-      color = color;
-    }
+    FontPaletteOverride(int index, Color color)
+        : index(index), color(color) {}
     bool operator==(const FontPaletteOverride& other) const {
       return index == other.index && color == other.color;
     }
index 32cb498..a416c0c 100644 (file)
@@ -172,7 +172,7 @@ class PLATFORM_EXPORT WidgetBase : public mojom::blink::Widget,
 #endif
 
 #if BUILDFLAG(IS_TIZEN_TV)
-  void SetTranslatedURL(const WTF::String& url);
+  void SetTranslatedURL(const WTF::String& url) override;
   void SetParentalRatingResult(const WTF::String& url, bool is_pass) override;
 #endif
 
index 270a84b..0aa127e 100644 (file)
@@ -195,7 +195,7 @@ class WidgetBaseClient {
   virtual bool IsMouseDownEventSwallowed() { return false; }
   virtual void SuspendNetworkLoading() {}
   virtual void ResumeNetworkLoading() {}
-  virtual void SetFloatVideoWindowState(bool enabled) {};
+  virtual void SetFloatVideoWindowState(bool enabled) {}
 #endif  // IS_TIZEN_TV
 #endif  // IS_EFL