[M120 Migration] Fix coverity issue 33/307933/2
authorManjeet <manjeet.1@partner.samsung.com>
Thu, 14 Mar 2024 10:32:13 +0000 (16:02 +0530)
committerDae-Hyun Ko <dhyuna.ko@samsung.com>
Tue, 19 Mar 2024 07:52:23 +0000 (07:52 +0000)
This patch combine two patches.
First patch will fix coverity issue for CID 1677057.
Second patch will fix couple of coverity issues for [WRTJS].

https://review.tizen.org/gerrit/291078/
https://review.tizen.org/gerrit/290957/

Change-Id: I7b7ee36f33afdac473f4533c2131c591a2fe69ba
Signed-off-by: Manjeet <manjeet.1@partner.samsung.com>
tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.cc
tizen_src/chromium_impl/content/browser/context_menu/context_menu_controller_base.h
tizen_src/ewk/efl_integration/wrt/wrt_dynamicplugin.cc
tizen_src/ewk/efl_integration/wrt/wrt_widget_host.cc

index 14517c1..0fdf255 100644 (file)
@@ -639,7 +639,8 @@ const char* ContextMenuControllerBase::GetSelectedText() {
   if (!rwhva())
     return "";
 
-  return base::UTF16ToUTF8(rwhva()->GetSelectedText()).c_str();
+  selected_text_ = base::UTF16ToUTF8(rwhva()->GetSelectedText());
+  return selected_text_.c_str();
 }
 
 }  // namespace content
index 8e02d82..247f3a7 100644 (file)
@@ -138,6 +138,7 @@ class ContextMenuControllerBase {
   Evas_Object* list_ = nullptr;
   Ecore_Timer* restore_timer_ = nullptr;
   ContextMenuStatusTag context_menu_status_ = NONE;
+  std::string selected_text_;
 };
 
 }  // namespace content
index e430b91..01544d4 100644 (file)
@@ -28,6 +28,7 @@ WrtDynamicPlugin::WrtDynamicPlugin()
     : DynamicPlugin(),
       url_parser_(0),
       set_widget_info_(0),
+      database_attach_(0),
       on_IPC_message_(0) {}
 
 bool WrtDynamicPlugin::Init(const std::string& injected_bundle_path) {
index cf488f7..6fa53a8 100644 (file)
@@ -104,7 +104,7 @@ void WrtWidgetHost::GetUrlForRequest(
       return;
 #endif
 
-  std::move(callback).Run(GURL());
+  std::move(callbacks_[callback_id]).Run(GURL());
   callbacks_.erase(callback_id);
 }