remove repetition code in SetZOrderGroupI api
authorDae young Ryu <karzia@samsung.com>
Mon, 23 Sep 2013 02:29:58 +0000 (11:29 +0900)
committerDae young Ryu <karzia@samsung.com>
Mon, 23 Sep 2013 02:29:58 +0000 (11:29 +0900)
Change-Id: I58766f0c78598314e4c74b70b78378db7ceb525d
Signed-off-by: Dae young Ryu <karzia@samsung.com>
src/ui/animations/FUiAnim_VisualElementImpl.cpp

index a2739da..1eaeca4 100644 (file)
@@ -1472,12 +1472,21 @@ _VisualElementImpl::SetZOrderGroupI(int zOrderGroup)
        else
        {
                _zOrderGroup = zOrderGroup;
-       }
 
-       if(IS_MODEL(this) && IS_NEEDED_UPDATE_PRESENTATION(this))
-       {
-               __pPresentation->SetZOrderGroupProperty(_zOrderGroup);
+               if(likely(__pPresentation))
+               {
+                       __pPresentation->_zOrderGroup = zOrderGroup;
+               }
        }
+
+//     if(IS_MODEL(this) && IS_NEEDED_UPDATE_PRESENTATION(this))
+//     {
+//             //__pPresentation->SetZOrderGroupProperty(_zOrderGroup);
+//             if(likely(__pPresentation))
+//             {
+//                     __pPresentation->_zOrderGroup = zOrderGroup;
+//             }
+//     }
        return r;
 }
 
@@ -6893,7 +6902,7 @@ _VisualElementImpl::CheckIfAnimatable(const String& property) const
 
        for (int i = 0; i < static_cast< int >(sizeof(supportedProperties) / sizeof(supportedProperties[0])); i++)
        {
-               //if (wcscmp(property.GetPointer(), supportedProperties[i]) == 0)
+
                if (property.GetPointer() == (*supportedProperties[i])->GetPointer() || property == **supportedProperties[i])
                {
                        return true;
@@ -6911,38 +6920,6 @@ _VisualElementImpl::CreateAnimationForPropertyI(const Tizen::Base::String& prope
                return null;
        }
 
-#if 0
-       if (property.CompareTo(String(VePropBounds)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropOpacity)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropChildrenOpacity)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropShowState)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropTransform)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropChildrenTransform)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else if (property.CompareTo(String(VePropZPosition)) == 0)
-       {
-               //ToDo: default implementation
-       }
-       else
-               return null;
-#endif
        VisualElementPropertyAnimation* pAnimation = new (std::nothrow) VisualElementPropertyAnimation();
        SysTryReturn(NID_UI_ANIM, pAnimation != null, null, E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] Memory allocation failed.");