Fix prevent issues(IO)
authorSunwook Bae <sunwook45.bae@samsung.com>
Fri, 5 Apr 2013 01:06:55 +0000 (10:06 +0900)
committerGerrit Code Review <gerrit2@kim11>
Fri, 5 Apr 2013 01:05:36 +0000 (10:05 +0900)
Change-Id: Ib22bbfceb119c9ff2cbb9b25ff3369d8da4983df
Signed-off-by: Sunwook Bae <sunwook45.bae@samsung.com>
src/io/FIo_MessagePortProxy.cpp
src/server/io/FIo_IpcServer.cpp

index 4cc91b7..57a7217 100644 (file)
@@ -125,7 +125,7 @@ OnMessageReceived(int id, const char* remote_app_id, const char* remote_port, bo
                SysTryCatch(NID_IO, pMap != null, , E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
 
                result r = pMap->Construct();
-               SysTryCatch(NID_IO, r == E_SUCCESS, , E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
+               SysTryCatch(NID_IO, r == E_SUCCESS, delete pMap, E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
 
                SysLog(NID_IO, "bundle to map");
 
@@ -176,7 +176,7 @@ OnTrustedMessageReceived(int id, const char* remote_app_id, const char* remote_p
                SysTryCatch(NID_IO, pMap != null, , E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
 
                result r = pMap->Construct();
-               SysTryCatch(NID_IO, r == E_SUCCESS, , E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
+               SysTryCatch(NID_IO, r == E_SUCCESS, delete pMap, E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] The memory is insufficient.");
 
                bundle_foreach(data, ConvertBundleToMap, pMap);
 
@@ -498,6 +498,7 @@ _MessagePortProxy::ConvertMapToBundleN(const HashMap* pMap)
                                {
                                        SysLog(NID_IO, "Not supported");
 
+                                       bundle_free(b);
                                        return null;
                                }
                        }
@@ -506,6 +507,7 @@ _MessagePortProxy::ConvertMapToBundleN(const HashMap* pMap)
                {
                        SysLog(NID_IO, "Not supported");
 
+                       bundle_free(b);
                        return null;
                }
        }
index 24a0d53..f6f9f83 100644 (file)
@@ -217,7 +217,9 @@ _IpcServer::Construct(const String& name, const _IIpcServerEventListener& listen
        SysTryCatch(NID_IO, ret == 0, r = E_SYSTEM, E_SYSTEM, "[E_SYSTEM] Failed to change permission of a socket(%d, %s): %s", serverSocket,
                           socketName.c_str(), strerror(errno));
 
-       listen(serverSocket, 15);
+       ret = listen(serverSocket, 15);
+       SysTryCatch(NID_IO, ret == 0, r = E_SYSTEM, E_SYSTEM, "[E_SYSTEM] Failed to listen the socket(%d, %s): %s", serverSocket,
+                          socketName.c_str(), strerror(errno));
 
        pGIOChannel = g_io_channel_unix_new(serverSocket);
        SysTryCatch(NID_IO, pGIOChannel != null, , E_OUT_OF_MEMORY, "[E_OUT_OF_MEMORY] Not enough memory.");