Fix logical error unsigned variable compares with negative value 88/139388/1
authorJihoon Kim <jihoon48.kim@samsung.com>
Tue, 18 Jul 2017 10:25:07 +0000 (19:25 +0900)
committerJihoon Kim <jihoon48.kim@samsung.com>
Tue, 18 Jul 2017 22:41:13 +0000 (22:41 +0000)
Expression 'type < 0' is always false , which may be caused by a logical error

Change-Id: Ia5c0c56972e43e96636efb3de60b2a2fd2d16d51
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
(cherry picked from commit 5381c90889fa2af853054b815cd3cec6562905e3)

src/sclcoreui-efl.cpp

index 6caa4da..bea0d01 100644 (file)
@@ -652,7 +652,7 @@ set_transient_for_isf_setting_window(Evas_Object *window)
 
 sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }
 
@@ -730,7 +730,7 @@ sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 
 bool CSCLCoreUIEFL::show_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }