Fix logical error unsigned variable compares with negative value 24/139324/1
authorJihoon Kim <jihoon48.kim@samsung.com>
Tue, 18 Jul 2017 10:25:07 +0000 (19:25 +0900)
committerJihoon Kim <jihoon48.kim@samsung.com>
Tue, 18 Jul 2017 10:25:12 +0000 (19:25 +0900)
Expression 'type < 0' is always false , which may be caused by a logical error

Change-Id: Ia5c0c56972e43e96636efb3de60b2a2fd2d16d51
Signed-off-by: Jihoon Kim <jihoon48.kim@samsung.com>
src/sclcoreui-efl.cpp

index 0c4cfbc..415bfa6 100644 (file)
@@ -674,7 +674,7 @@ set_transient_for_isf_setting_window(Evas_Object *window)
 
 sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }
 
@@ -752,7 +752,7 @@ sclwindow CSCLCoreUIEFL::create_option_window(SCLOptionWindowType type)
 
 bool CSCLCoreUIEFL::show_option_window(SCLOptionWindowType type)
 {
-    if (type < 0 || type >= OPTION_WINDOW_TYPE_MAX) {
+    if (type >= OPTION_WINDOW_TYPE_MAX) {
         return SCLWINDOW_INVALID;
     }