platform/core/uifw/dali-toolkit.git
5 months agoDALi Version 2.2.52 03/301203/1 dali_2.2.52
Adam Bialogonski [Fri, 10 Nov 2023 07:42:48 +0000 (07:42 +0000)]
DALi Version 2.2.52

Change-Id: I1b00dd7c940c418fbeba87c71b93bd82ef5192f0

5 months agoMerge changes I1b1abc2c,I47083821,Icbe72d36,I6292beb0,I14b750ac, ... into devel/master
Adeel Kazmi [Thu, 9 Nov 2023 17:21:25 +0000 (17:21 +0000)]
Merge changes I1b1abc2c,I47083821,Icbe72d36,I6292beb0,I14b750ac, ... into devel/master

* changes:
  Test harness sync
  Limited joint/weight attributes to 4 sets
  Added vertex color test to model primitive
  Add macro defs to shader regen
  Adding debug to shader defs
  Updated model loader to handle multiple attr sets
  Switched joints to use UBO with larger size in PBR shader

5 months agoMerge "(Vector) Support EncodedImageBuffer can use for vector image" into devel/master
Eunki Hong [Wed, 8 Nov 2023 04:56:41 +0000 (04:56 +0000)]
Merge "(Vector) Support EncodedImageBuffer can use for vector image" into devel/master

5 months agoTest harness sync 52/301052/1
David Steele [Tue, 7 Nov 2023 17:25:49 +0000 (17:25 +0000)]
Test harness sync

Change-Id: I1b1abc2c020803afec166955fd52b928f57530d8

5 months agoLimited joint/weight attributes to 4 sets 46/301046/1
David Steele [Mon, 6 Nov 2023 18:00:49 +0000 (18:00 +0000)]
Limited joint/weight attributes to 4 sets

Total number of supported joints per vertex = 16.

Change-Id: I4708382167d98f94b8d8f9fdf534972b85213c33

5 months agoAdded vertex color test to model primitive 45/301045/1
David Steele [Mon, 6 Nov 2023 13:43:13 +0000 (13:43 +0000)]
Added vertex color test to model primitive

Modifying model loading to reduce shader churn
Changed ShaderManager to return shader option
Added debug across shader generation

Change-Id: Icbe72d36bc92e8e2d7735a1c13a0be73eab79312
Signed-off-by: David Steele <david.steele@samsung.com>
5 months agoAdd macro defs to shader regen 47/300847/2
David Steele [Thu, 2 Nov 2023 18:13:02 +0000 (18:13 +0000)]
Add macro defs to shader regen

Change-Id: I6292beb044c8f634e5d528f465a8e16444bc58e4

5 months agoAdding debug to shader defs 51/300651/3
David Steele [Mon, 30 Oct 2023 19:09:12 +0000 (19:09 +0000)]
Adding debug to shader defs

Change-Id: I14b750acdabb4ba6d96d9b1ab1ab259998e7e15f

5 months agoUpdated model loader to handle multiple attr sets 49/293049/5
David Steele [Thu, 18 May 2023 17:13:00 +0000 (18:13 +0100)]
Updated model loader to handle multiple attr sets

Modified GLTF parser for attributes to create attribute sets
for joints/weights/texcoords/colors

Added macro definitions to ShaderOptions, fixed hash to account for
macro/def strings.

Changed shader manager to create shader with extra attributes

Change-Id: Iabe2772eaf767ca3055dd415752c5a612942f0a4

5 months agoSwitched joints to use UBO with larger size in PBR shader 18/300018/5
David Steele [Fri, 13 Oct 2023 14:47:48 +0000 (15:47 +0100)]
Switched joints to use UBO with larger size in PBR shader

Change-Id: I816ff07f89cbbc1983dac65e6472892692f8d138

5 months ago(AnimatedVector) Get marker informations 40/301040/1
Eunki, Hong [Tue, 7 Nov 2023 11:13:41 +0000 (20:13 +0900)]
(AnimatedVector) Get marker informations

Let we make API to get marker informations from json file.
Marker information contains name, and pair of frame, start and end.

Change-Id: I21b91368addff66d41a66c14fc8e86076470ddc7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
5 months agoMerge "Do not trace image decoding process" into devel/master
Eunki Hong [Mon, 6 Nov 2023 07:55:44 +0000 (07:55 +0000)]
Merge "Do not trace image decoding process" into devel/master

5 months agoDo not trace image decoding process 18/300918/1
Eunki, Hong [Mon, 6 Nov 2023 05:01:35 +0000 (14:01 +0900)]
Do not trace image decoding process

It will be re-open when we can control the log level of trace filter.

Change-Id: I3c374d34e5e602ed9bdce3228656565f15f40511
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
5 months agoRemove observer from mLoadQueue when we request to remove observer 06/300706/4
Eunki, Hong [Wed, 1 Nov 2023 04:18:13 +0000 (13:18 +0900)]
Remove observer from mLoadQueue when we request to remove observer

That might be happen during ResourceReady signal observing

- Add
- Remove

If than, the added request added in mLoadQueue 2 times.
and Remove request try to remove observe there (but will be failed actually.)

So, the visual get LoadCompleted signal twice.

It might have some logical problem in AnimatedImageVisual.
So let we keep ensure that 1-observer can only emit only 1-time.

Change-Id: I3eee087118cf62761709b8416fe09cf52094d156
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
5 months ago(Vector) Support EncodedImageBuffer can use for vector image 97/300597/10
Eunki Hong [Sat, 28 Oct 2023 16:17:50 +0000 (01:17 +0900)]
(Vector) Support EncodedImageBuffer can use for vector image

Support to append extension when we use imagetype

For example, if EncodedImageBuffer has VECTOR_IMAGE type, we will generate url
"enbuf://3.svg" So we can use it directly by ImageView -> SvgVisual

And also, let we support Remote animated vector image.
(Since we can load animated vector image by raw buffer.)

Change-Id: I09fd214021507cd8d29bbd3c3720d4427f5eedd7
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
5 months agoPrint image decoding process log level as release 96/300896/2
Eunki Hong [Sun, 5 Nov 2023 14:41:11 +0000 (23:41 +0900)]
Print image decoding process log level as release

Change-Id: I0f397d1db3975f4aaead4b6ba15d87532fd344c3
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Support glTF extention: KHR_mesh_quantization" into devel/master
Adeel Kazmi [Fri, 3 Nov 2023 17:19:11 +0000 (17:19 +0000)]
Merge "Support glTF extention: KHR_mesh_quantization" into devel/master

6 months agoSupport glTF extention: KHR_mesh_quantization 22/300522/6
Richard Huang [Thu, 26 Oct 2023 14:10:53 +0000 (15:10 +0100)]
Support glTF extention: KHR_mesh_quantization

Change-Id: I23fd7f3f481590f5716452813666cb31161bc8ae

6 months agoMerge "DALi Version 2.2.51" into devel/master
Adeel Kazmi [Fri, 3 Nov 2023 11:14:19 +0000 (11:14 +0000)]
Merge "DALi Version 2.2.51" into devel/master

6 months agoDALi Version 2.2.51 81/300881/1 dali_2.2.51
Richard Huang [Fri, 3 Nov 2023 10:57:53 +0000 (10:57 +0000)]
DALi Version 2.2.51

Change-Id: Ib5f22d0063657d6992e74e19ee15c34234e216cc

6 months agoRegister some text property one time. + Shrink custom property count 76/300876/1
Eunki, Hong [Fri, 3 Nov 2023 07:42:30 +0000 (16:42 +0900)]
Register some text property one time. + Shrink custom property count

Change-Id: Ib9508a59dcbeed74d2b9ac5ddd69dbaffd100762
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Apply premultiply when external texture use mask" into devel/master
sunghyun kim [Wed, 1 Nov 2023 07:33:34 +0000 (07:33 +0000)]
Merge "Apply premultiply when external texture use mask" into devel/master

6 months agoMerge "(AnimatedVector) Sync AnimatedVectorRenderer for UTC" into devel/master
Eunki Hong [Wed, 1 Nov 2023 06:43:47 +0000 (06:43 +0000)]
Merge "(AnimatedVector) Sync AnimatedVectorRenderer for UTC" into devel/master

6 months agoApply premultiply when external texture use mask 02/300702/3
sunghyun kim [Wed, 1 Nov 2023 03:53:31 +0000 (12:53 +0900)]
Apply premultiply when external texture use mask

when external texture has alpha value and use mask, premultiply is not
applied.
add that patch to fix this issue

Change-Id: I9103c7a6185ea8c044a3fdfa00a5fc5a5376fe87

6 months agoMerge "Fix unclear naming of member variable and function of FixedImageCache" into...
Seungho BAEK [Mon, 30 Oct 2023 08:27:51 +0000 (08:27 +0000)]
Merge "Fix unclear naming of member variable and function of FixedImageCache" into devel/master

6 months ago(AnimatedVector) Sync AnimatedVectorRenderer for UTC 00/300600/2
Eunki Hong [Sat, 28 Oct 2023 17:27:35 +0000 (02:27 +0900)]
(AnimatedVector) Sync AnimatedVectorRenderer for UTC

Apply newly added API - Load(const Dali::Vector<uint8_t>&) in toolkit utc

Change-Id: I31d0886fed3371507a84d4887b12243a3fec2d85
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoFix unclear naming of member variable and function of FixedImageCache 89/300489/2
seungho baek [Thu, 26 Oct 2023 05:49:29 +0000 (14:49 +0900)]
Fix unclear naming of member variable and function of FixedImageCache

 - Some naming of member variable and function have not changed after some logic is changed.
 - In current implementation, FixedImageCache not use a concept of front frame.
 - This patch fixed such a unclear naming and fixed parameters to match the naming too.

Change-Id: I43baf87b2cb67941aa89e8fd6aadce33c4495565
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
6 months agoAdd some more logs for images 57/300557/7
Eunki, Hong [Fri, 27 Oct 2023 05:04:05 +0000 (14:04 +0900)]
Add some more logs for images

 - Print the size of loaded image
 - Print url for SVG and Lottie
 - Change the name of VisualUrl property (for line coverage)

Change-Id: I271407112975249c06175875e9430996139f44e4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Remove the duplicated call with Focused call" into devel/master
Seoyeon Kim [Mon, 30 Oct 2023 00:24:45 +0000 (00:24 +0000)]
Merge "Remove the duplicated call with Focused call" into devel/master

6 months agoMerge "Support NativeImageInterface can generate url" into devel/master
Eunki Hong [Fri, 27 Oct 2023 10:30:43 +0000 (10:30 +0000)]
Merge "Support NativeImageInterface can generate url" into devel/master

6 months agoDALi Version 2.2.50 77/300577/1 dali_2.2.50
David Steele [Fri, 27 Oct 2023 09:35:34 +0000 (10:35 +0100)]
DALi Version 2.2.50

Change-Id: I1ccc9f25a084dbefb87acfd8325bb9b338606a57

6 months agoRemove the duplicated call with Focused call 55/300555/1
Seoyeon Kim [Fri, 27 Oct 2023 05:35:03 +0000 (14:35 +0900)]
Remove the duplicated call with Focused call

- To call `Activate()` of IME is already called in `OnKeyInputFocusGained()`
 and `OnKeyInputFocusGained()` is called by `OnTap()`.
- So, IME activate call is called twice unnecessarily.

- Also, IME properties did not be set in `OnTap`,
  so the normal layout of input panel shows first,
 and then another type of input panel shows again. (Issue)
- Fix this issue to erase to call `Activate` in `OnTap()`.

Change-Id: Ie18b35042b0b7878efd0a8fe3fbbd5da1d3e6def
Signed-off-by: Seoyeon Kim <seoyeon2.kim@samsung.com>
6 months agoSupport NativeImageInterface can generate url 05/300505/2
Eunki Hong [Thu, 26 Oct 2023 08:20:54 +0000 (17:20 +0900)]
Support NativeImageInterface can generate url

Previously, we only support to generate url only by native image source.
But now, there was some usage to generate url from NativeImageQueue.

Unfortunatly, NativeImageQueue is devel api. So, let we just support
NativeImageInterface instead of NativeImageQueue directly.

Change-Id: I722cc599b6f3d7ddfe7d0727e5a2efcb4c4fb0fb
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoEnsure blendshape weight between [0..1] 22/300422/1
Eunki Hong [Tue, 24 Oct 2023 14:05:43 +0000 (23:05 +0900)]
Ensure blendshape weight between [0..1]

Let we ensure the blendshape weight is between 0 and 1.
So ignore cases when weight value is bigger than 1, less than 0.

Change-Id: I3bdd0a3f59498654e6e7ac65a4a2e665a58a9fcc
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoFix minor coverity issues (phase 2) 91/300391/1
Eunki Hong [Mon, 23 Oct 2023 11:34:24 +0000 (20:34 +0900)]
Fix minor coverity issues (phase 2)

 - Move std::string
 - Move std::function
 - Move some Property::Map if possible

Change-Id: I1400f02aa30e37b71a8d731d108bdf41acd88e1c
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoFix randomly failed UTC (2) 53/300353/1
Eunki, Hong [Mon, 23 Oct 2023 03:18:10 +0000 (12:18 +0900)]
Fix randomly failed UTC (2)

Change-Id: I1a7470c05fc2bb65910a643e7da5d4868c44c3f7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoFix randomly failed UTC 21/300321/1
Eunki Hong [Sat, 21 Oct 2023 14:35:34 +0000 (23:35 +0900)]
Fix randomly failed UTC

- UtcDaliModelResourceCacheCheck
There was some logical error for that UTC.

- UtcDaliAnimatedImageVisualMultiImage01
It was possible that some AsyncTask can be processed
without event trigger. It is impossible to resolved now.
Until we make toolkit-async-task-manager, just block this UTC.

Change-Id: Id0e3a944d9dc83261180ef1a96faab754626133c
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Remove Rasterize task when svg load failed" into devel/master
Eunki Hong [Fri, 20 Oct 2023 09:19:34 +0000 (09:19 +0000)]
Merge "Remove Rasterize task when svg load failed" into devel/master

6 months agoDALi Version 2.2.49 94/300294/1 dali_2.2.49
Adeel Kazmi [Fri, 20 Oct 2023 06:07:49 +0000 (07:07 +0100)]
DALi Version 2.2.49

Change-Id: Iff66d95be44e2194a361751108e0173bfd691f2d

6 months agoRemove Rasterize task when svg load failed 28/300228/1
Eunki, Hong [Thu, 19 Oct 2023 04:10:38 +0000 (13:10 +0900)]
Remove Rasterize task when svg load failed

Since RasterizeTask's IsReady return false; that task will not be removed
forever.

To avoid this useless task keeping, let we remove that task when svg load
failed.

Change-Id: I856fb5c88eac2234253b513b5ba9f772ffd41eba
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Fix ZWJ issue" into devel/master
Bowon Ryu [Thu, 19 Oct 2023 02:30:20 +0000 (02:30 +0000)]
Merge "Fix ZWJ issue" into devel/master

6 months agoFix ZWJ issue 25/300125/4
Bowon Ryu [Tue, 17 Oct 2023 06:36:03 +0000 (15:36 +0900)]
Fix ZWJ issue

Added ZWJ sequence to solve the issue of ZWJ not working.
this patch processes ZWJ as one sequnce.
and this condition has been merged with the previous emoji logic.

Added exception handling in editable environment.
Removed unnecessary variables related to emoji.

Change-Id: Id7825732d96c3e87a8c93b6c2e8d57e057eb7435
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 months agoLet we use default white IBL image even environment info not exist 30/300130/1
Eunki, Hong [Tue, 17 Oct 2023 07:38:13 +0000 (16:38 +0900)]
Let we use default white IBL image even environment info not exist

When we use ModelNode without model url, we don't follow
environment map load task. So default IBL texture can be 'empty'.

In this case, the PBR shader what dali use default, might do some
strange behaviour.

To guard this cases, let we make all Dali::Scene3D::Model use
non-empty default textures.

Change-Id: I47cd1f5b89f812b2a35c5f4cb5dfb1084b5760a3
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoFix minor coverity issues 80/300080/2
Eunki Hong [Mon, 16 Oct 2023 11:19:10 +0000 (20:19 +0900)]
Fix minor coverity issues

1. Remove std::string copy
2. Remove Property::Array copy

Change-Id: I9b45c0ff87588a6f79d8ae4a109909c7c016dbdf
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoMerge "DALi Version 2.2.48" into devel/master
Adeel Kazmi [Fri, 13 Oct 2023 13:22:14 +0000 (13:22 +0000)]
Merge "DALi Version 2.2.48" into devel/master

6 months agoDALi Version 2.2.48 00/300000/1 dali_2.2.48
Adam Bialogonski [Fri, 13 Oct 2023 10:06:44 +0000 (11:06 +0100)]
DALi Version 2.2.48

Change-Id: If68564f4b8690d7fdff4f5c3d59e586586c3b07e

6 months agoMerge "Add color tag for text markup anchor" into devel/master
Bowon Ryu [Fri, 13 Oct 2023 06:52:58 +0000 (06:52 +0000)]
Merge "Add color tag for text markup anchor" into devel/master

6 months agoAdd color tag for text markup anchor 48/299948/2
Bowon Ryu [Thu, 12 Oct 2023 11:51:14 +0000 (20:51 +0900)]
Add color tag for text markup anchor

"<a color='blue' clicked-color='red' href='https://www.tizen.org'>TIZEN</a>"

user can set color and clicked color in the anchor tag.
if not set, default color is applied.

Change-Id: I6ed67b3ae4bec414e306d46bc2b70d4c7a87cdf7
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 months agoFix gcc-13 compile error (std::vector include) 50/299950/1
Eunki Hong [Thu, 12 Oct 2023 13:18:47 +0000 (22:18 +0900)]
Fix gcc-13 compile error (std::vector include)

Change-Id: I33ce58c0ee7862d2c5086b3f933128b38a3860ad
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Destroy removal visuals after idler" into devel/master
David Steele [Thu, 12 Oct 2023 10:28:45 +0000 (10:28 +0000)]
Merge "Destroy removal visuals after idler" into devel/master

6 months agoMerge "Keep reference when member callback excute + Make NPatchData as RefObject...
David Steele [Thu, 12 Oct 2023 10:24:28 +0000 (10:24 +0000)]
Merge "Keep reference when member callback excute + Make NPatchData as RefObject" into devel/master

6 months agoDestroy removal visuals after idler 95/299895/3
Eunki, Hong [Wed, 11 Oct 2023 12:53:00 +0000 (21:53 +0900)]
Destroy removal visuals after idler

There was some bug when visual destructor called during
it's emit ResourceReady.

To avoid this case, Let we keep visuals more long term,
and Discard + Destroy after some idler called.

To avoid multiple Idler callback register,
let we make that idler callback in VisualFactory.

Change-Id: Id47083b158f91bb81666d6f2100811dedb0d70f1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Add TextFitArray to text label" into devel/master
Bowon Ryu [Thu, 12 Oct 2023 04:30:21 +0000 (04:30 +0000)]
Merge "Add TextFitArray to text label" into devel/master

6 months agoKeep reference when member callback excute + Make NPatchData as RefObject 68/299868/2
Eunki, Hong [Wed, 11 Oct 2023 08:04:44 +0000 (17:04 +0900)]
Keep reference when member callback excute + Make NPatchData as RefObject

Some CallbackBase didn't hold the reference of itself.
So it was possible to call destructor of itself during it's
API was running.

It might makes some unknown issues. So let we keep reference
for some issue-comes known APIs : SvgVisual, NPatchData, and lottie

It future, we should discard visuals rather than delate it directly.

Change-Id: Ibeab31bc309869aa7c2ee65cbff8789e7bb2a721
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
6 months agoMerge "Update test harness to use matching build system" into devel/master
David Steele [Tue, 10 Oct 2023 10:28:01 +0000 (10:28 +0000)]
Merge "Update test harness to use matching build system" into devel/master

6 months agoAdd TextFitArray to text label 57/299557/4
Bowon Ryu [Thu, 5 Oct 2023 02:29:45 +0000 (11:29 +0900)]
Add TextFitArray to text label

Add a new function to satisfy the UX that
operates TextFit by considering the PointSize and MinLineSize of the text.

For example, TextFit should be able to find the one that
fits among [PointSize 24 + MinLineSize 40] or [PointSize 28 + MinLineSize 44].

But the previous TextFit only considers PointSize.

TextFitArray can solve this problem,
and this implemented it to respond to additional requirements without modifying the API.

Simple usage:
std::vector<DevelTextLabel::FitOption> fitOptions;
fitOptions.push_back(DevelTextLabel::FitOption(24, 40));
fitOptions.push_back(DevelTextLabel::FitOption(28, 44));
DevelTextLabel::SetTextFitArray(textLabel, true, fitOptions);

Change-Id: Ib608465c8f4c96c56e471f14064e4e2d24377a8f
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
6 months agoSafety check for control set/get property 98/299298/3
Eunki Hong [Mon, 25 Sep 2023 10:21:00 +0000 (19:21 +0900)]
Safety check for control set/get property

Since some workerthread can access and try to get/set control's visual,
we might need to assert if worker thread try to use them.

Note : Current logic might got error if someone try to change API before
app create, but less care for now.

Change-Id: I68cb0ff5b822721a73c4fd40f4b86d21ddf1759f
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
6 months agoMerge "(WebView) Set display area and Change Visual when WebView relayout" into devel...
Eunki Hong [Tue, 10 Oct 2023 01:48:09 +0000 (01:48 +0000)]
Merge "(WebView) Set display area and Change Visual when WebView relayout" into devel/master

7 months agoDALi Version 2.2.47 00/299700/1 dali_2.2.47
David Steele [Fri, 6 Oct 2023 12:10:11 +0000 (13:10 +0100)]
DALi Version 2.2.47

Change-Id: I2b52489372e6b17b9cca2a4b6d587d2b91ac60cd

7 months agoUpdate test harness to use matching build system 49/299549/2
David Steele [Wed, 4 Oct 2023 16:34:08 +0000 (17:34 +0100)]
Update test harness to use matching build system

Change-Id: Ie78bf75496f7fb097afe487ad3a9650d9765ccf3

7 months agoMerge "(visual-base-impl) Reduce cyclomatic complexity" into devel/master
Adeel Kazmi [Fri, 29 Sep 2023 13:07:41 +0000 (13:07 +0000)]
Merge "(visual-base-impl) Reduce cyclomatic complexity" into devel/master

7 months agoDALi Version 2.2.46 62/299462/1 dali_2.2.46
Richard Huang [Fri, 29 Sep 2023 11:27:40 +0000 (12:27 +0100)]
DALi Version 2.2.46

Change-Id: I1a50e964f0a5bcb1a6d383e1a4cfe505976124e6

7 months ago(visual-base-impl) Reduce cyclomatic complexity 61/299461/1
Adeel Kazmi [Fri, 29 Sep 2023 11:27:17 +0000 (12:27 +0100)]
(visual-base-impl) Reduce cyclomatic complexity

Change-Id: I37a1f691aa8d3669ec6d08177231e29a748138f9

7 months agoReduce Cyclomatic complexity in some text related files 46/299446/2
Adeel Kazmi [Thu, 28 Sep 2023 16:53:15 +0000 (17:53 +0100)]
Reduce Cyclomatic complexity in some text related files

Change-Id: If598f647cd4a1824f67a0e8a033d4ecf9856eb0e

7 months agoMerge "Add GetHeightForWidth for text visual model" into devel/master
Bowon Ryu [Tue, 26 Sep 2023 08:21:03 +0000 (08:21 +0000)]
Merge "Add GetHeightForWidth for text visual model" into devel/master

7 months agoMerge "Make NPatchData always use shared pointer" into devel/master
Eunki Hong [Tue, 26 Sep 2023 07:06:19 +0000 (07:06 +0000)]
Merge "Make NPatchData always use shared pointer" into devel/master

7 months agoAdd GetHeightForWidth for text visual model 36/299336/1
Bowon Ryu [Tue, 26 Sep 2023 06:50:50 +0000 (15:50 +0900)]
Add GetHeightForWidth for text visual model

Use visual model's GetHeightForWidth instead of GetLayoutSize.

In the case of text label,
the height of the layout is used when returning the cached value of GetHeightForWidth.

But, this value is the height of the layout that has been Ellipsis processed.
It's not the height of the entire Text.

So, the intended height cannot be obtained.

This patch simply stores calculated values.

Change-Id: I0494fb476964fb1207d35e3c8e6eb25ece972025
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 months agoRevert "Fix GetHeightForWidth for text controller" 35/299335/1
Bowon Ryu [Tue, 26 Sep 2023 06:50:32 +0000 (15:50 +0900)]
Revert "Fix GetHeightForWidth for text controller"

This reverts commit da9f7b93ae00d0aa64a959549ed9da3469a49e46.

Change-Id: I9dbcb715d65c97ff40ba9746caab50ce7231c1af

7 months agoMerge "Fix GetHeightForWidth for text controller" into devel/master
Bowon Ryu [Tue, 26 Sep 2023 06:13:33 +0000 (06:13 +0000)]
Merge "Fix GetHeightForWidth for text controller" into devel/master

7 months agoMake NPatchData always use shared pointer 13/299313/1
Eunki Hong [Tue, 26 Sep 2023 00:48:45 +0000 (09:48 +0900)]
Make NPatchData always use shared pointer

Let we keep NPatchData user always use shared_ptr instead of raw pointer.
In this case, NPatchData itself will be safe enought even if
NPatchData removed from NPatchLoader cache.

Change-Id: I27db855888bc21c7a7282a9e1114945f3f0e758d
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
7 months ago(WebView) Set display area and Change Visual when WebView relayout 07/299107/5
Eunki, Hong [Wed, 20 Sep 2023 02:05:43 +0000 (11:05 +0900)]
(WebView) Set display area and Change Visual when WebView relayout

Previously, we change display area after only at PropertyNotification time.
It will wait until 1 frame rendered.

If we change web view size by event side, the display area applied lately.

This patch make we change update area when OnRelayout, so we can apply
changeness more faster timing.

--

And also, Let we change visual when the size of webview changed.
If so, it can be reduce some flickering effect while change the udpate area.

Change-Id: Ia7d6becc11160d88353f62bbdb43f75764550b67
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months agoReduce LOC of ImageVisual 09/299309/1
Adeel Kazmi [Mon, 25 Sep 2023 16:18:19 +0000 (17:18 +0100)]
Reduce LOC of ImageVisual

Change-Id: Ib6ace96a0fafb6f14e35bacb29e9eeac50431883

7 months agoFix GetHeightForWidth for text controller 04/299204/3
Bowon Ryu [Thu, 21 Sep 2023 10:06:54 +0000 (19:06 +0900)]
Fix GetHeightForWidth for text controller

In the case of text label,
the height of the layout is used when returning the cached value of GetHeightForWidth.

But, this value is the height of the layout that has been Ellipsis processed.
It's not the height of the entire Text.

So, the intended height cannot be obtained.

This patch simply stores calculated values.

Change-Id: Ia5d06bdac39556776749de3e3078a3a7e230c36c
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 months agoMerge "Remove NPatchLoader observer when they request remove" into devel/master
Eunki Hong [Mon, 25 Sep 2023 05:15:17 +0000 (05:15 +0000)]
Merge "Remove NPatchLoader observer when they request remove" into devel/master

7 months agoMerge "ImageVisualShaderFactory refactoring" into devel/master
Seungho BAEK [Mon, 25 Sep 2023 03:12:41 +0000 (03:12 +0000)]
Merge "ImageVisualShaderFactory refactoring" into devel/master

7 months agoRemove NPatchLoader observer when they request remove 69/299269/1
Eunki, Hong [Mon, 25 Sep 2023 01:39:55 +0000 (10:39 +0900)]
Remove NPatchLoader observer when they request remove

Since we make remove NPatchData later, the observer was disconnected lately.
It might make some unusual behavior.

Change-Id: I794f22e21964962428f353ee84a9340687274808
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months agoDALi Version 2.2.45 48/299248/1 dali_2.2.45
Adeel Kazmi [Fri, 22 Sep 2023 14:12:10 +0000 (15:12 +0100)]
DALi Version 2.2.45

Change-Id: I972f5a6a463788d17b24a105d0b7c725b7ae22af

7 months agoMerge "Export the symbol for Physics::Integraiton::GetPhysicsWorld" into devel/master
David Steele [Thu, 21 Sep 2023 16:48:03 +0000 (16:48 +0000)]
Merge "Export the symbol for Physics::Integraiton::GetPhysicsWorld" into devel/master

7 months agoMerge "Make ImageVisual::Property::PIXEL_AREA animatable" into devel/master
Eunki Hong [Thu, 21 Sep 2023 15:41:13 +0000 (15:41 +0000)]
Merge "Make ImageVisual::Property::PIXEL_AREA animatable" into devel/master

7 months agoExport the symbol for Physics::Integraiton::GetPhysicsWorld 15/299215/1
Richard Huang [Thu, 21 Sep 2023 15:36:23 +0000 (16:36 +0100)]
Export the symbol for Physics::Integraiton::GetPhysicsWorld

Change-Id: Ica8e9689c98aef9ce77c838fa3b778c53ca213e2

7 months agoMake ImageVisual::Property::PIXEL_AREA animatable 20/299120/1
Eunki, Hong [Wed, 20 Sep 2023 06:47:59 +0000 (15:47 +0900)]
Make ImageVisual::Property::PIXEL_AREA animatable

Since PixelArea was not animatable for visual side,
we cannot animate some cases who register image visual hardly.

This patch make we allow to animate PixelArea at ImageVisual,
instead of ImageView directly.

Change-Id: Ib00b771a2db938cf8ece17ffa4566c7b0b9bb800
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months agoImageVisualShaderFactory refactoring 87/299087/2
seungho baek [Tue, 19 Sep 2023 07:36:33 +0000 (16:36 +0900)]
ImageVisualShaderFactory refactoring

 ImageVisualShaderFactory::GetShader method is too long and complex.
 The method uses same logic for two different purpose in a method
 that makes difficult to understand.
 And the method also has too many braces depth.

 This patch moves some features that to create shaderType and
 to retrive shaderPreFix to ImageVisualShaderFeatureBuilder.
 Now ImageVisualShaderFeatureBuilder manages all responsibility
 to define shader codes following its options.
 And slides some codes for readability and it make possible remove
 unnecessary comments.

Change-Id: I09a725d4e101cb65badffe3a897572971e2c336b
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
7 months agoAllow to send ResourceReady signal unlimited 16/298716/5
Eunki Hong [Tue, 12 Sep 2023 23:57:23 +0000 (08:57 +0900)]
Allow to send ResourceReady signal unlimited

Previously we miss callback when ResourceReady called continusouly.
Let we use IdleCallbackManager system with return value, so we can
re-install Idle callback.

Change-Id: I56d73545ae7d8a122c8bead396affd4e962f7bb8
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
7 months agoPrevent copy calls from repeat events of ctrl + c 73/298973/1
Bowon Ryu [Mon, 18 Sep 2023 03:08:11 +0000 (12:08 +0900)]
Prevent copy calls from repeat events of ctrl + c

now, even if user hold down ctrl + c on text controller,
copy will only be called once.

The patch below was added for this behavior.
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-core/+/298930/
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/298931/

Change-Id: I521f4ad3baa5270f5fde0e484e27885b9a75e077
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 months agoMerge "Update expected value of UtcDaliGetMirroredText" into devel/master
Bowon Ryu [Mon, 18 Sep 2023 01:40:59 +0000 (01:40 +0000)]
Merge "Update expected value of UtcDaliGetMirroredText" into devel/master

7 months agoMerge "Added integration api to physics" into devel/master
Adeel Kazmi [Fri, 15 Sep 2023 13:13:56 +0000 (13:13 +0000)]
Merge "Added integration api to physics" into devel/master

7 months agoDALi Version 2.2.44 44/298944/1 dali_2.2.44
Adam Bialogonski [Fri, 15 Sep 2023 11:24:35 +0000 (12:24 +0100)]
DALi Version 2.2.44

Change-Id: I7eda2c8ee4d88d36949f639785bc311b24d6a133

7 months agoAdded integration api to physics 20/298620/6
David Steele [Mon, 11 Sep 2023 17:37:30 +0000 (18:37 +0100)]
Added integration api to physics

Changed locking mechanism to enable NUI ScopedAccessor

Added 2nd user data to cpBody (for our ref, as c#
ref uses 1st user data)

Change-Id: Idf3ef1a172a03cbdbf587ef8993c787e1fa7c633

7 months agoUpdate expected value of UtcDaliGetMirroredText 60/298860/1
Bowon Ryu [Thu, 14 Sep 2023 09:16:24 +0000 (18:16 +0900)]
Update expected value of UtcDaliGetMirroredText

The text direction determination logic has been changed,
https://review.tizen.org/gerrit/#/c/platform/core/uifw/dali-adaptor/+/298855/

so the result of GetMirroredText() may different from the previous one,
especially when dealing with mixed LTR + RTL text.
(and particulary when brackets are involved)

Update the TC with the coreect values.

Change-Id: I678211880250035caea4d6142e69fd427268b1ff
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
7 months agoMerge "Change the SENSITVE value of accessibility" into devel/master
Wonsik Jung [Thu, 14 Sep 2023 08:19:30 +0000 (08:19 +0000)]
Merge "Change the SENSITVE value of accessibility" into devel/master

7 months agoMerge "Support FastTrackUploading for YUV images" into devel/master
Eunki Hong [Thu, 14 Sep 2023 08:17:02 +0000 (08:17 +0000)]
Merge "Support FastTrackUploading for YUV images" into devel/master

7 months agoFix Shadow issue 66/298766/4
seungho baek [Wed, 13 Sep 2023 08:02:06 +0000 (17:02 +0900)]
Fix Shadow issue

 - When Model is added after shadow is set, the model cannot used for shadow

Change-Id: Iaec0f3e389068342cef9b2769e060e69832354ee
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
7 months agoSupport FastTrackUploading for YUV images 99/298299/14
Eunki, Hong [Tue, 5 Sep 2023 08:10:11 +0000 (17:10 +0900)]
Support FastTrackUploading for YUV images

Let we support YUV image case without additional image loading
or image operation.

Instead, let we think that FastTrackUploading will use
YUV format always if DALI_LOAD_IMAGE_YUV_PLANES=1.
And then, revert as standard shader if we are not use
YUV case actually.

To support this feature. let we make unified YUV + RGB shader can use
standard rgb image color for special case.
After load completed, we can determine the type of shader.

Change-Id: Ia4ffa288e705af751e722cd1440de2a014ad19b4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months ago[Scene3D] Cache image load result so models can share it. 88/298188/15
Eunki Hong [Sun, 3 Sep 2023 06:05:44 +0000 (15:05 +0900)]
[Scene3D] Cache image load result so models can share it.

Let we cache the PixelData and Texture so various models can use it.

We cache the model resources, and let we use them same resources.
But if some seperated models using same images, we cannot cache about it.

There are relative usecase occured + Unity support this kind of cache system,
let we also cache images + textures locally.

---

First, we can cache url --> PixelData.
This caching might occured on multi threading system. So we have to lock the mutex
when we try to access this kind of pixeldata access.

Second, we can cache PixelData --> Texture.
This caching should be occured only for main thread.

---

We support Garbage Collect system to avoid full-iterating cached resources.
During GC, we should remove Texture first, and then PixelData.
(Since PixelData can be the key of Texture.)

Currenly, we will call GC only of ModelCache reference count become 0.

Change-Id: I5e89f214593503fa9e8b2290c3859f2674ff7048
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
7 months agoEnsure all thrid-party code is removed from coverage calculations 19/298619/2
Adeel Kazmi [Mon, 11 Sep 2023 16:23:35 +0000 (17:23 +0100)]
Ensure all thrid-party code is removed from coverage calculations

Change-Id: I41e6e105680f38de8369d40145895750a37e6ef4

7 months agoFix coverity issue on chipmunk-physics-debug 07/298607/1
Eunki Hong [Mon, 11 Sep 2023 10:22:26 +0000 (19:22 +0900)]
Fix coverity issue on chipmunk-physics-debug

- Uninitialized value for mDebugOptions
- Unreached code line

Change-Id: Ida0e45195346c6d5d83702f905f29ffce4dde526
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
7 months agoMerge "Register PixelArea property only if required." into devel/master
Eunki Hong [Mon, 11 Sep 2023 03:04:36 +0000 (03:04 +0000)]
Merge "Register PixelArea property only if required." into devel/master

7 months agoMerge "Apply fittingMode lazy when resource is not ready" into devel/master
sunghyun kim [Mon, 11 Sep 2023 00:55:26 +0000 (00:55 +0000)]
Merge "Apply fittingMode lazy when resource is not ready" into devel/master

7 months agoRegister PixelArea property only if required. 95/298495/3
Eunki, Hong [Fri, 8 Sep 2023 00:01:15 +0000 (09:01 +0900)]
Register PixelArea property only if required.

Since we were try to register uPixelArea property for every image-visual,
The Shader try to send PropertResetter very frequencly.

Since we only need to register that property only 1 time +
We can control pixel area by Renderer,
Let we register uPixelArea property only 1 times for creation.

And also, there was some useless uPixelArea usage on text-visual.
Let we just remove it.

Change-Id: Ib784e0088243f2a70f8556ae0dc9fa7c957b5aa2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
7 months agoMerge changes I0729e532,I6b908dda,I8aad01f7 into devel/master
David Steele [Fri, 8 Sep 2023 16:43:23 +0000 (16:43 +0000)]
Merge changes I0729e532,I6b908dda,I8aad01f7 into devel/master

* changes:
  Added debug renderer for Chipmunk
  Changing hit test to pass in optional filter
  Bug fixes for 2d physics