ImageVisualShaderFactory refactoring 87/299087/2
authorseungho baek <sbsh.baek@samsung.com>
Tue, 19 Sep 2023 07:36:33 +0000 (16:36 +0900)
committerseungho baek <sbsh.baek@samsung.com>
Wed, 20 Sep 2023 01:25:21 +0000 (10:25 +0900)
commit31514a8a1ad1da1af27f6f4cf5e289dc133f658e
tree775cc1450281e7ff0b0c3372b71832473bf94298
parenta5b90e510f5924e04a8c961a960ac526938c834a
ImageVisualShaderFactory refactoring

 ImageVisualShaderFactory::GetShader method is too long and complex.
 The method uses same logic for two different purpose in a method
 that makes difficult to understand.
 And the method also has too many braces depth.

 This patch moves some features that to create shaderType and
 to retrive shaderPreFix to ImageVisualShaderFeatureBuilder.
 Now ImageVisualShaderFeatureBuilder manages all responsibility
 to define shader codes following its options.
 And slides some codes for readability and it make possible remove
 unnecessary comments.

Change-Id: I09a725d4e101cb65badffe3a897572971e2c336b
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
12 files changed:
automated-tests/src/dali-toolkit-internal/CMakeLists.txt
automated-tests/src/dali-toolkit-internal/utc-Dali-ImageVisualShaderFeatureBuilder.cpp [new file with mode: 0644]
dali-toolkit/internal/file.list
dali-toolkit/internal/visuals/animated-image/animated-image-visual.cpp
dali-toolkit/internal/visuals/animated-vector-image/animated-vector-image-visual.cpp
dali-toolkit/internal/visuals/image-visual-shader-factory.cpp
dali-toolkit/internal/visuals/image-visual-shader-factory.h
dali-toolkit/internal/visuals/image-visual-shader-feature-builder.cpp [new file with mode: 0644]
dali-toolkit/internal/visuals/image-visual-shader-feature-builder.h [new file with mode: 0644]
dali-toolkit/internal/visuals/image/image-visual.cpp
dali-toolkit/internal/visuals/npatch/npatch-visual.cpp
dali-toolkit/internal/visuals/svg/svg-visual.cpp