Fix svace issue on text-geometry (unsigned int < 0) 20/268020/1
authorEunki, Hong <eunkiki.hong@samsung.com>
Wed, 15 Dec 2021 02:48:46 +0000 (11:48 +0900)
committerEunki, Hong <eunkiki.hong@samsung.com>
Wed, 15 Dec 2021 02:49:57 +0000 (11:49 +0900)
CharacterIndex type is unsigned int. So it cannot be negative

Change-Id: I9f9c6868f103ee45695a4fd87dc4cafd0819f471
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
dali-toolkit/internal/text/text-geometry.cpp

index e599922..9fa5ad1 100644 (file)
@@ -67,15 +67,9 @@ void GetTextGeometry(ModelPtr textModel, CharacterIndex startIndex, CharacterInd
   const CharacterIndex* const     glyphToCharacterBuffer         = visualModel->mGlyphsToCharacters.Begin();
   const CharacterDirection* const modelCharacterDirectionsBuffer = (0u != logicalModel->mCharacterDirections.Count()) ? logicalModel->mCharacterDirections.Begin() : NULL;
 
-  if((startIndex < 0 && endIndex < 0) || (startIndex >= logicalModel->mText.Count() && endIndex >= logicalModel->mText.Count()))
+  if(startIndex >= logicalModel->mText.Count() && endIndex >= logicalModel->mText.Count())
     return;
 
-  if(startIndex < 0)
-    startIndex = 0;
-
-  if(endIndex < 0)
-    endIndex = 0;
-
   if(startIndex >= logicalModel->mText.Count())
     startIndex = logicalModel->mText.Count() - 1;