upgrade-scripts: Fix to invoke as an error when untar fails 16/300016/3
authorSangYoun Kwak <sy.kwak@samsung.com>
Fri, 13 Oct 2023 11:15:22 +0000 (20:15 +0900)
committerSangYoun Kwak <sy.kwak@samsung.com>
Mon, 30 Oct 2023 06:47:59 +0000 (15:47 +0900)
Previously, if the untaring of any delta file from the delta.tar.gz
fails, then the script ignored it and continued to the next delta file.
This may cause some delta files to be not applied which causes the
failure of the FOTA as a result.
To prevent this, the log message was changed to 'Error' from 'Info" and
'exit_error' was used instead of 'continue'.

Change-Id: Idffe1387a58b9a358f717bae4a334405b8946da4
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
scripts/upgrade-support/upgrade-common.inc

index 2829dc3..e11a0cf 100644 (file)
@@ -206,8 +206,8 @@ upgrade_images() {
                fi
 
                if ! /bin/tar tf "$DELTA_TAR" "$DELTA_NAME"; then
-                       flog "[Info] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME"
-                       continue
+                       flog "[Error] There is no delta $DELTA_NAME for label $LABEL_NAME from part $PART_NAME"
+                       exit_error
                fi
 
                local NEXT_PARTITION="$(/usr/bin/blkid-print "$EMMC_DEVICE" "$PART_NAME" "$NEXT_AB" |\