Fix segfault

seat can be NULL but it is used in _is_valid_switch_user_dbus_request()
without NULL check.

Signed-off-by: Suchang Woo <suchang.woo@samsung.com>
Change-Id: I56ab152b49230f862d5d83e82ac6eef4863deafe

diff --git a/src/daemon/tlm-dbus-observer.c b/src/daemon/tlm-dbus-observer.c
index 3569ce3..e1c0c40 100644 (file)
--- a/src/daemon/tlm-dbus-observer.c
+++ b/src/daemon/tlm-dbus-observer.c
@@ -419,6 +419,7 @@ _is_valid_switch_user_dbus_request(
         TlmDbusRequest *dbus_request,
         TlmSeat *seat)
 {
+    g_return_val_if_fail (seat && TLM_IS_SEAT(seat), FALSE);
     gboolean ret = TRUE;
     gchar *occupying_username = tlm_seat_get_occupying_username(seat);
     if (0 == g_strcmp0(dbus_request->username,occupying_username)) {
@@ -489,8 +490,9 @@ _process_request (
             goto _finished;
         }
 
-        if (req->seat && req->seat != seat) {
-            g_object_unref(req->seat);
+        if (req->seat != seat) {
+            if (req->seat)
+                g_object_unref(req->seat);
             req->seat = seat;
             g_object_ref(req->seat);
         }