platform/core/multimedia/pulseaudio-modules-tizen.git
2 years agotizenaudio-sink: Reset pollfd's revents after use 18/271418/3 accepted/tizen_6.5_unified tizen_6.5 accepted/tizen/6.5/unified/20220311.132414 submit/tizen_6.5/20220309.181244
jungsup lee [Mon, 21 Feb 2022 04:17:50 +0000 (13:17 +0900)]
tizenaudio-sink: Reset pollfd's revents after use

revents should be cleared after handling POLLERR. mainloop send a lot of
async message to I/O thread that is stucking on writing pcm. After that,
I/O thread couldn't call poll api because of handling asyncq message.

[Version] 13.0.83
[Issue Type] Bug fix

Change-Id: I96908d8b0d4a997b9ab417e9b3d1a96cd6e862ac
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
2 years agodevice-manager: Add null check in handle_device_connected() 43/271643/1 accepted/tizen/6.5/unified/20220224.125822 submit/tizen_6.5/20220224.051938
Sangchul Lee [Wed, 23 Feb 2022 05:40:50 +0000 (14:40 +0900)]
device-manager: Add null check in handle_device_connected()

When the last parameter of handle_device_connected() is NULL,
it gets the required structure again from the list referring to
device-map.json. The result is checked now to avoid unwanted
assertion by other functions.

[Version] 13.0.82
[Issue Type] Improvement

Change-Id: Id3c07d579b1d273386a6eab2e6618abf27baabf8
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
2 years agostream-manager: Deactivate ducking for audio HAL when stream ducking is removed 15/268615/2 accepted/tizen/6.5/unified/20220105.120550 submit/tizen_6.5/20211228.085152 submit/tizen_6.5/20220104.113219
Jeongmo Yang [Tue, 28 Dec 2021 05:36:01 +0000 (14:36 +0900)]
stream-manager: Deactivate ducking for audio HAL when stream ducking is removed

Previously, deactivation ducking for audio HAL could be missed.

[Version] 13.0.81
[Issue Type] Bug fix

Change-Id: Ide1206dc98f1dd354cb23e6c8cf06361a1d815e3
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
2 years agoMerge branch 'tizen' into tizen_6.5 53/266153/1 accepted/tizen/6.5/unified/20211111.224902 submit/tizen_6.5/20211109.050749
Seungbae Shin [Mon, 8 Nov 2021 09:26:09 +0000 (18:26 +0900)]
Merge branch 'tizen' into tizen_6.5

Change-Id: Id7f26f35500ef53a47b9407f2fa049b1343206dc

2 years agodevice-manager: use container dedicated device-map json 10/265710/2 accepted/tizen/unified/20211101.140211 submit/tizen/20211029.025659 submit/tizen/20211101.022013
Seungbae Shin [Wed, 27 Oct 2021 10:48:01 +0000 (19:48 +0900)]
device-manager: use container dedicated device-map json

[Version] 13.0.80
[Issue Type] Container

Change-Id: If81c7aed340369e451980142d7c677ff22053f98

2 years agoFix coverity issues (CHECKED_RETURN / PW.PARAMETER_HIDDEN) 01/265501/2 accepted/tizen/unified/20211029.132606 submit/tizen/20211021.035233
Seungbae Shin [Thu, 21 Oct 2021 02:33:28 +0000 (11:33 +0900)]
Fix coverity issues (CHECKED_RETURN / PW.PARAMETER_HIDDEN)

+ Fix minor aarch64 build warning

[Version] 13.0.79
[Issue Type] Build

Change-Id: Ie7ed49cf73beb95ce5db332d6595aa6c6def27ab

2 years agotizenaudio-sink: Print log when snd_pcm_avail() return small value continuously 99/265299/2 submit/tizen/20211015.121039
jungsup lee [Thu, 14 Oct 2021 08:33:19 +0000 (17:33 +0900)]
tizenaudio-sink: Print log when snd_pcm_avail() return small value continuously

[Version] 13.0.78
[Issue Type] Debugging

Change-Id: I982d1ee7cf7a5d0546902aec9f7a498278b4014a

2 years agoFix DEREF_OF_NULL.RET.PROC.STAT 99/264599/4 submit/tizen/20210927.080426 submit/tizen/20210928.015557 submit/tizen/20210929.043812 submit/tizen/20211005.003737
Jaechul Lee [Mon, 27 Sep 2021 05:58:18 +0000 (14:58 +0900)]
Fix DEREF_OF_NULL.RET.PROC.STAT

[Version] 13.0.77
[Issue Type] VD svace DF210918-00186

Change-Id: I21b72e6fd96ab07521cb807bc26c44e148c00162
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agoFix aarch64 build warnings 74/264574/2
Seungbae Shin [Fri, 24 Sep 2021 12:27:12 +0000 (21:27 +0900)]
Fix aarch64 build warnings

Fixes following warnings:

- cast to pointer from integer of different size [-Wint-to-pointer-cast]
- format '%llu' expects argument of type 'long long unsigned int', but argument 9 has type 'pa_usec_t' {aka 'long unsigned int'} [-Wformat=]
- format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]

[Version] 13.0.76
[Issue Type] Build

Change-Id: I55a043c48107c3a3c6bf71cbb8b81f54c504180d

2 years agosound-player: fix memory leak in case of stopping playback 09/264509/3 accepted/tizen/6.5/unified/20211028.123509 accepted/tizen/unified/20210926.235653 submit/tizen/20210924.075945 submit/tizen_6.5/20211028.162401 tizen_6.5.m2_release
Seungbae Shin [Thu, 23 Sep 2021 12:25:03 +0000 (21:25 +0900)]
sound-player: fix memory leak in case of stopping playback

eos signal with the cause must be sent to client to make proper subscription release

[Version] 13.0.75
[Issue Type] Bug fix

Change-Id: Id318f1a4d18eafeea4e343eef6c02ee63ca2960f

2 years agotizenaudio-sink2/source2: Fix frames_to_write calculation 77/263677/3
Jaechul Lee [Wed, 8 Sep 2021 04:49:32 +0000 (13:49 +0900)]
tizenaudio-sink2/source2: Fix frames_to_write calculation

[Version] 13.0.74
[Issue Type] Bug fix

Change-Id: Ida9fcab0c380fc71125f64dc90d8a186840f40ae
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agodevice-manager: Fix svace defect (DEREF_OF_NULL.RET.PROC.STAT) 55/263855/1 accepted/tizen/unified/20210913.123311 submit/tizen/20210913.003246
Seungbae Shin [Mon, 13 Sep 2021 00:16:49 +0000 (09:16 +0900)]
device-manager: Fix svace defect (DEREF_OF_NULL.RET.PROC.STAT)

[Version] 13.0.73
[Issue Type] Svace

Change-Id: If07027bfc1f37a296aedf440e03fa04040c42ad1

2 years agodevice-manager-dbus: always place bt-sco device at first in device list 79/263679/3 submit/tizen/20210910.035514
jungsup lee [Wed, 8 Sep 2021 04:54:40 +0000 (13:54 +0900)]
device-manager-dbus: always place bt-sco device at first in device list

[Version] 13.0.72
[Issue Type] Improvement

Change-Id: I15efd7b12c48a3278ad64e9fdb7a2f409cf4183f

2 years agoMerge "device-manager: Support to load sink2/source2" into tizen accepted/tizen/unified/20210907.015403 submit/tizen/20210906.133545
jaechul lee [Mon, 6 Sep 2021 06:33:40 +0000 (06:33 +0000)]
Merge "device-manager: Support to load sink2/source2" into tizen

2 years agosupport external bt-sco device for tv 07/255207/8 accepted/tizen/unified/20210829.234912 submit/tizen/20210827.174915
Seungbae Shin [Mon, 15 Mar 2021 07:45:23 +0000 (16:45 +0900)]
support external bt-sco device for tv

[Version] 13.0.71
[Issue Type] Improvement

Change-Id: Ic9d3d00c5a48e319203468550efa5fb40f6f243d

2 years agodevice-manager: Support to load sink2/source2 02/262502/9
Jaechul Lee [Thu, 12 Aug 2021 05:45:46 +0000 (14:45 +0900)]
device-manager: Support to load sink2/source2

pulseaudio tries to load tizenaudio-sink2/source2 instead of
tizenaudio-sink/source if 'tizen2' keyword is found in device-map file.

[Version] 13.0.71
[Issue Type] Improvement

Change-Id: Ie9c67f4888fb628961811d906e4d6c396700b14e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agotizenaudio-source2: Use hardware interrupt for capture 54/262354/2
Jaechul Lee [Mon, 9 Aug 2021 03:41:48 +0000 (12:41 +0900)]
tizenaudio-source2: Use hardware interrupt for capture

* Remove unused arguments
* Use fixed latency
* Use poll event

[Version] 13.0.70
[Issue Type] Improvement

Change-Id: I8be80005a1f8f5ec0e126c76fc54253e2510ea17
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agotizenaudio-sink2: Use hardware interrupt for playback 89/262189/5
Jaechul Lee [Wed, 4 Aug 2021 01:01:56 +0000 (10:01 +0900)]
tizenaudio-sink2: Use hardware interrupt for playback

 * Remove unused arguments (block_msec, max_request_msec)
 * Use fixed latency
 * Use poll event

[Version] 13.0.69
[Issue Type] Improvement

Change-Id: I404474e0da9837df6fc202cc793af0b5d2c6d799
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agodevice-manager: remove checking module arguments 92/262192/5
Jaechul Lee [Fri, 30 Jul 2021 04:45:30 +0000 (13:45 +0900)]
device-manager: remove checking module arguments

The comparison of the mod args would be failed if unknown args in
device-manager are added like 'echo=1' and it doesn't need to check
module args validation because each module already checks it.

All arguments would be parsed in case of passing NULL.

[Version] 13.0.68
[Issue Type] Improvement

Change-Id: I2be900ef82ecdedc5c181bdc919cd439d0a4b67d
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agoAdd module-tizenaudio-sink2/source2 57/262057/3
Jaechul Lee [Mon, 2 Aug 2021 05:47:18 +0000 (14:47 +0900)]
Add module-tizenaudio-sink2/source2

module-tizenaudio-sink2/source2 that are copies of
tizenaudio-sink/source without AEC parts were added for a experimental
functionality such as mmap, echo cancel, and non-interleave.

Change-Id: I09588a5d90737da6e2ee9c8b3fd574db012e71f5
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
2 years agostream-manager-dbus: Add rpi playback route method handler 36/259036/7 accepted/tizen/unified/20210708.131533 submit/tizen/20210705.072009 submit/tizen/20210707.025110
Seungbae Shin [Mon, 31 May 2021 07:23:04 +0000 (16:23 +0900)]
stream-manager-dbus: Add rpi playback route method handler

[Version] 13.0.67
[Issue Type] Internal feature

Change-Id: Iff4048c39bb7601066f21b58a2176a50377c96b9

2 years agofixup! tizenaudio-sink/source: write or read by calculated period size instead of... 01/260601/1 accepted/tizen/unified/20210630.005909 submit/tizen/20210629.123758
Seungbae Shin [Tue, 29 Jun 2021 12:35:46 +0000 (21:35 +0900)]
fixup! tizenaudio-sink/source: write or read by calculated period size instead of fixed time.

[Version] 13.0.66
[Issue Type] Bug

Change-Id: I59f0fe0901e6f07a9a071cd29f08e681162dc527

2 years agotizenaudio-sink/source: write or read by calculated period size instead of fixed... 10/259410/6 accepted/tizen/unified/20210614.061633 submit/tizen/20210611.074839
Seungbae Shin [Mon, 17 May 2021 08:57:49 +0000 (17:57 +0900)]
tizenaudio-sink/source: write or read by calculated period size instead of fixed time.

As this code is workaround code for supporting various hw model such as qualcomm board,
will be refactored soon by using parameters given at loading time.

In addition, use _hal_sysconfdir instead of _sysconfdir macro in spec

[Version] 13.0.65
[Issue Type] Bring-up

Change-Id: I96fef562cd7af2a67d3bed90b5db9f4def3edad4

2 years agoFix SVACE defect (MEMORY_LEAK.EX) 27/259627/1 accepted/tizen/unified/20210614.061509 submit/tizen/20210610.091033
Seungbae Shin [Thu, 10 Jun 2021 08:40:50 +0000 (17:40 +0900)]
Fix SVACE defect (MEMORY_LEAK.EX)

[Version] 13.0.64
[Issue Type] Svace

Change-Id: I1535c4d0f48d2be2e6c4fc54c2b30a6c668dd59e

2 years agostream/device-manager: use PA_DEFAULT_CONFIG_DIR instead of hardcoding for configurat... 14/259114/1 accepted/tizen/unified/20210608.131606 submit/tizen/20210604.030216
Seungbae Shin [Tue, 1 Jun 2021 07:55:06 +0000 (16:55 +0900)]
stream/device-manager: use PA_DEFAULT_CONFIG_DIR instead of hardcoding for configuration path

[Version] 13.0.63
[Issue Type] New HAL

Change-Id: I9e5072c5db449a699b231275883608a55f77f288

3 years agodevice-manager: enhance some if-else cascaded statements 43/257543/2 submit/tizen/20210428.113701
Seungbae Shin [Tue, 27 Apr 2021 11:12:24 +0000 (20:12 +0900)]
device-manager: enhance some if-else cascaded statements

[Version] 13.0.62
[Issue Type] Revise

Change-Id: I9f8ac0a13e3ee0ed92530f466537e7290e4e16e0

3 years agoaec-manager: Add audio AEC manager 53/257053/11 accepted/tizen/unified/20210426.002345 submit/tizen/20210423.033332 submit/tizen/20210423.060829 submit/tizen/20210423.064540
Jaechul Lee [Mon, 29 Mar 2021 05:17:04 +0000 (14:17 +0900)]
aec-manager: Add audio AEC manager

added new feature

[Version] 13.0.61
[Issue Type] New feature

Change-Id: I401390836ee34ea4444180e9725febd1720ac4a4
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agotizenaudio-policy: Apply new loopback module management 04/256504/3 accepted/tizen/unified/20210413.021247 submit/tizen/20210412.112307
Sangchul Lee [Tue, 6 Apr 2021 02:24:46 +0000 (11:24 +0900)]
tizenaudio-policy: Apply new loopback module management

Comparing with the previous logic, it is now possible to
load multiple loopback modules.
 - Each loopback module can be loaded per parent id.
 - Loading trigger point is moved from route_change_hook_cb()
   to select_device_by_manual_routing()

It relates to VPR-402.

[Version] 13.0.60
[Issue Type] New feature

Change-Id: I516f541a1af0548b99c2f3c80e98e12756776117
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agotizenaudio-policy: Preparation for new loopback module management 64/255464/7
Sangchul Lee [Thu, 18 Mar 2021 23:58:42 +0000 (08:58 +0900)]
tizenaudio-policy: Preparation for new loopback module management

[Version] 13.0.59
[Issue Type] Improvement

Change-Id: I1fa78fdc41913f0db7e8d08b0ebe4d4c33b21c62
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager: Pass parent id when calling callback for selecting sink or source 88/255388/6 submit/tizen/20210329.110345
Sangchul Lee [Wed, 17 Mar 2021 04:22:30 +0000 (13:22 +0900)]
stream-manager: Pass parent id when calling callback for selecting sink or source

It is also fixed to pass parent_id as unsigned integer to
STREAM CONNECTION CHANGED callback.

[Version] 13.0.58
[Issue Type] Improvement

Change-Id: I64d300df0c7cc3f68fa97d6bffb809e38421801f
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager: handle ramp finished task only at the main thread 37/255837/5 accepted/tizen/unified/20210401.105903 submit/tizen/20210325.153451
Seungbae Shin [Wed, 24 Mar 2021 07:08:00 +0000 (16:08 +0900)]
stream-manager: handle ramp finished task only at the main thread

Sometimes sd handle is accessed simultaneously in different thread, which may leads to memory corruption.

This patch makes to handle ramp finish task directly only if inside of main thread.
Otherwise, request a message to make it handle from the main thread.
To avoid possible deadlock, request by posting(async) instead of send(sync).

[Version] 13.0.57
[Issue Type] Bug fix

Change-Id: I178dbc5b29adccc6f74e41b7e105681c3fd570d0

3 years agoRevert "stream-manager: handle ramp finished task at core mainloop" 72/255772/1
Seungbae Shin [Tue, 23 Mar 2021 11:30:55 +0000 (20:30 +0900)]
Revert "stream-manager: handle ramp finished task at core mainloop"

[Version] 13.0.56
[Issue Type] Revert

This reverts commit 5e4cb76033a4a929c90b4dfb57e69c42ec3f58cc.

Change-Id: I04b5587085b31c29ed57dabac3c42ccc0b4f9869

3 years agostream-manager: handle ramp finished task at core mainloop 32/255532/6 accepted/tizen/unified/20210321.225639 submit/tizen/20210319.091643
Seungbae Shin [Fri, 19 Mar 2021 05:34:21 +0000 (14:34 +0900)]
stream-manager: handle ramp finished task at core mainloop

Sometimes sd handle is accessed simultaneously, which may leads to memory corruption.

[Version] 13.0.55
[Issue Type] Bug fix

Change-Id: I214c58c1ccde292c918033aaded695f6b59324ef

3 years agoAdd support for notifying stream connection information to the policy implementation 55/255455/3
Sangchul Lee [Thu, 18 Mar 2021 12:19:13 +0000 (21:19 +0900)]
Add support for notifying stream connection information to the policy implementation

[Version] 13.0.54
[Issue Type] New feature

Change-Id: I63ebdd3e62a40d54b04e0ac83f1654015e6095cb
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager: Rename enum and function 54/255454/1
Sangchul Lee [Thu, 18 Mar 2021 11:32:50 +0000 (20:32 +0900)]
stream-manager: Rename enum and function

Incorrect names are revised generically to embrace the actual doing
in the function.

[Version] 13.0.53
[Issue Type] Rename

Change-Id: I2860404667916d7487131fccc02de4fa141f7074
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager: Apply designated initializers to arrays 53/255453/1
Sangchul Lee [Thu, 18 Mar 2021 11:23:31 +0000 (20:23 +0900)]
stream-manager: Apply designated initializers to arrays

[Version] 13.0.52
[Issue Type] Refactoring

Change-Id: If23ef59b2702618943f2029bd4bcaf35015bba3d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager-dbus: remove unnessary dbus_launch_mdnsd() 43/255343/1 accepted/tizen/unified/20210319.140940 submit/tizen/20210318.035923
Seungbae Shin [Wed, 17 Mar 2021 07:05:44 +0000 (16:05 +0900)]
stream-manager-dbus: remove unnessary dbus_launch_mdnsd()

mdnsd is changed to launch by socket activation

[Version] 13.0.51
[Issue Type] Dependancy

Change-Id: Id957b580d877c802d282fe746248564998552b20

3 years agostream-manager-dbus: Update mute vconf only after internal set is successful 65/255265/1
Sangchul Lee [Tue, 16 Mar 2021 05:36:54 +0000 (14:36 +0900)]
stream-manager-dbus: Update mute vconf only after internal set is successful

[Version] 13.0.50
[Issue Type] Bug fix

Change-Id: Id58f2d54e5a88c583f87ab2ecaa56823b36fd8b3
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agostream-manager-dbus: fix improper null handling on handle_get_current_volume_type() 88/254688/1 accepted/tizen/unified/20210308.233744 submit/tizen/20210308.104642
Seungbae Shin [Mon, 8 Mar 2021 08:47:34 +0000 (17:47 +0900)]
stream-manager-dbus: fix improper null handling on handle_get_current_volume_type()

[Version] 13.0.49
[Issue Type] Bug fix

Change-Id: I067eeadf9deabcc17676df254984437920765be4

3 years agostream-manager-dbus: update volume vconf only after internal set is successful 10/254510/5 accepted/tizen/unified/20210308.070954 submit/tizen/20210305.042519
Seungbae Shin [Thu, 4 Mar 2021 04:02:13 +0000 (13:02 +0900)]
stream-manager-dbus: update volume vconf only after internal set is successful

[Version] 13.0.48
[Issue Type] Bug fix

Change-Id: I9238bbe1602b43f1ac1c56ef0029d248ddb56a22

3 years agostream-manager-dbus: Skip virtual stream for ducking streams 98/253398/2 accepted/tizen/unified/20210215.130924 submit/tizen/20210210.091601
Jeongmo Yang [Tue, 9 Feb 2021 11:52:10 +0000 (20:52 +0900)]
stream-manager-dbus: Skip virtual stream for ducking streams

- The ducking state is never changed because of virtual stream.

[Version] 13.0.47
[Issue Type] Bug fix

Change-Id: I545f381f8868c40eaa8562bcdf4f6ae3afecfb63
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
3 years agohal-interface: Use hal audio api 62/252162/10 accepted/tizen/unified/20210204.134540 submit/tizen/20210203.005915 submit/tizen/20210204.010649
Jaechul Lee [Mon, 25 Jan 2021 05:25:32 +0000 (14:25 +0900)]
hal-interface: Use hal audio api

+ remove minor build warning

[Version] 13.0.46
[Issue Type] Enhancement

Change-Id: Iac9337a9c6f654723eb956f7f7a6b2a85deef8d6
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agodevice-manager: handle rtsp device 21/251021/1
jungsup lee [Tue, 5 Jan 2021 06:01:46 +0000 (15:01 +0900)]
device-manager: handle rtsp device

handle rtsp device as network type device

[Version] 13.0.45
[Issue Type] Update

Change-Id: I90e4965c34db184f6177b19cf6e1874a13175723
Signed-off-by: jungsup lee <jungsup4.lee@samsung.com>
3 years agotizenaudio-policy: unload modules safely when daemon is on shutdown 92/250792/3 accepted/tizen/unified/20210105.125821 submit/tizen/20210105.055441
Seungbae Shin [Mon, 4 Jan 2021 15:52:21 +0000 (00:52 +0900)]
tizenaudio-policy: unload modules safely when daemon is on shutdown

[Version] 13.0.44
[Issue Type] Bug

Change-Id: Ib92c5cbff8bb48b40eef5685dc5549894a58cdd8

3 years agostream-manager: Revise conditions to invoke ducking state changed signal 94/250494/5 accepted/tizen/unified/20201229.124645 submit/tizen/20201229.083746
Sangchul Lee [Mon, 28 Dec 2020 08:56:16 +0000 (17:56 +0900)]
stream-manager: Revise conditions to invoke ducking state changed signal

In sink_input_ramp_finish_cb(), it is fixed to send the signal only if
the previous state of stream ducking is DUCKING or UNDUCKING.

Some logs are revised for easy debugging.

[Version] 13.0.43
[Issue Type] Improvement

Change-Id: Ib857d6146afe3279436fa155bf18b0d45e9d1909
Signed-off-by: Sangchul Lee <sangchul1011@gmail.com>
3 years agotizenaudio-policy: Set use_internal_codec value of combine sink 83/250283/7
Sangchul Lee [Wed, 23 Dec 2020 05:21:38 +0000 (14:21 +0900)]
tizenaudio-policy: Set use_internal_codec value of combine sink

When a stream is finished, routing path should be updated for one
of remaining streams. If one of them is using internal audio codec
with a combine sink, it should also be updated for the stream.

This patch sets the use_internal_codec value of the combine sink to
true when loading the module if needed.

A function to load the combine module is added and applied.

[Version] 13.0.42
[Issue Type] Bug fix / Refactoring

Change-Id: I02950f4df59535039409b9c75c627dc770c66462
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agotone-player: Fix asan defect (stack-buffer-underflow) 23/249423/4 accepted/tizen/unified/20201214.124445 submit/tizen/20201211.093130 submit/tizen/20201214.041034
Seungbae Shin [Fri, 11 Dec 2020 08:50:16 +0000 (17:50 +0900)]
tone-player: Fix asan defect (stack-buffer-underflow)

==pulseaudio==799==ERROR: AddressSanitizer: stack-buffer-underflow on address 0xbdc65da0 at pc 0xb5c397ad bp 0xbdc60db0 sp 0xbdc60e00
READ of size 22 at 0xbdc65da0 thread T0
    #0 0xb5c397aa in printf_common(void*, char const*, std::__va_list) (/usr/lib/libasan.so+0x757aa)
    #1 0xb5c3b11c in vsnprintf (/usr/lib/libasan.so+0x7711c)
    #2 0xb58ca3ba in pa_vsnprintf (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x4a3ba)
    #3 0xb58ddcd8 in pa_log_levelv_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5dcd8)
    #4 0xb58dd5c6 in pa_log_level_meta (/usr/lib/pulseaudio/libpulsecommon-13.0.so+0x5d5c6)
    #5 0xb2e262d8 in module_tone_player_LTX_pa__init (/usr/lib/pulse-13.0/modules/module-tone-player.so+0x22d8)
    #6 0xb5ab7072 in pa_module_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x56072)
    #7 0xb5a9818e in pa_cli_command_load (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3718e)
    #8 0xb5aa06b2 in pa_cli_command_execute_line_stateful (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x3f6b2)
    #9 0xb5aa11c4 in pa_cli_command_execute_file_stream (/usr/lib/pulseaudio/libpulsecore-13.0.so+0x401c4)
    #10 0x1810a in main (/usr/bin/pulseaudio+0x1810a)
    #11 0xb5440c80 in __libc_start_main (/lib/libc.so.6+0x1ac80)

[Version] 13.0.41
[Issue Type] Bug

Change-Id: Ib0c1987d14ac42d47b7e6036b12c1313b275b151

3 years agotizenaudio-policy: Add max_latency_msec to 100ms 22/249222/2 accepted/tizen/unified/20201210.124558 submit/tizen/20201209.044713
Jaechul Lee [Wed, 9 Dec 2020 03:39:58 +0000 (12:39 +0900)]
tizenaudio-policy: Add max_latency_msec to 100ms

This patch improves the latency of null-src

[Version] 13.0.40
[Issue Type] Improvement

Change-Id: Idf6b2c985dd400a04f71ae5892ed6bd6517612fb
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agostream-manager: Invoke ramp finish hook when ducking stream is corked 05/248005/2 accepted/tizen/unified/20201120.125446 submit/tizen/20201120.012041
Sangchul Lee [Thu, 19 Nov 2020 06:37:20 +0000 (15:37 +0900)]
stream-manager: Invoke ramp finish hook when ducking stream is corked

If a user corks a stream that ducking is in progress, it can not get
a ramp finish callback from the pulseaudio core. It leads to invalid
state of the stream ducking handle, therefore it is fixed to trigger
the callback forcedly when this situation happens.

[Version] 13.0.39
[Issue Type] Bug fix

Change-Id: Icbe7d4ce2d70fcbfbba9afb2555a38308df18349
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agoAdd null-sink argument norewinds=1 69/246769/2
Jaechul Lee [Wed, 4 Nov 2020 05:20:36 +0000 (14:20 +0900)]
Add null-sink argument norewinds=1

null-sink takes almost 2 seconds when starting to play sound.

[Version] 13.0.38
[Issue Type] Improvement

Change-Id: If53a67c1f822f032f8f3590566b4eaa3b6265d7c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agoFix various improper memory handling bugs 37/246437/3 accepted/tizen/unified/20201102.124206 submit/tizen/20201102.025704
Seungbae Shin [Thu, 29 Oct 2020 08:51:05 +0000 (17:51 +0900)]
Fix various improper memory handling bugs

- memory leaks due to missing message unref
- memory leaks due to missing dbus string array free.
- potential memory corruption due to passing different size of data type.
- use-after-free of string retrieved by dbus_message_iter_get_basic()
- use duplicated string for strtok_r()

[Version] 13.0.37
[Issue Type] Bug

Change-Id: I6dea62168cef2fd1387f1e1a3ffc37eb2fe47fa5

3 years agostream-manager-dbus: use pa dbus wrapper function if possible 27/246427/10 accepted/tizen/unified/20201102.124303 submit/tizen/20201030.093526
Seungbae Shin [Thu, 29 Oct 2020 07:34:37 +0000 (16:34 +0900)]
stream-manager-dbus: use pa dbus wrapper function if possible

[Version] 13.0.36
[Issue Type] Revise

Change-Id: Ib30dd5934fa4a2554652feb550937d15a2fa177f

3 years agodevice-manager-dbus: use pa dbus wrapper function if possible 48/246348/4
Seungbae Shin [Wed, 28 Oct 2020 11:17:32 +0000 (20:17 +0900)]
device-manager-dbus: use pa dbus wrapper function if possible

[Version] 13.0.35
[Issue Type] Revise

Change-Id: I926a1860bc43b789ae5cf5490973f92b9ddd6cbd

3 years agodevice-manager-dbus: fix crash of getting empty supported samplerates/formats 68/246268/1 accepted/tizen/unified/20201029.124849 submit/tizen/20201028.023739
Seungbae Shin [Tue, 27 Oct 2020 11:08:46 +0000 (20:08 +0900)]
device-manager-dbus: fix crash of getting empty supported samplerates/formats

[Version] 13.0.34
[Issue Type] Bug

Change-Id: I8faab3479f9bf2daa87d0f818b50f1a95e96caeb

3 years agoFix build warnings 86/242986/7 accepted/tizen/6.0/unified/20201030.114646 accepted/tizen/6.0/unified/hotfix/20201103.003317 accepted/tizen/unified/20200904.035455 submit/tizen/20200902.103308 submit/tizen/20200903.061740 submit/tizen_6.0/20201029.205104 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
Seungbae Shin [Wed, 2 Sep 2020 08:35:14 +0000 (17:35 +0900)]
Fix build warnings

[Version] 13.0.33
[Issue Type] Build

Change-Id: Idf96facb42ef0260e96ac1d1af4e9ec131c999a7

3 years agoFix SVACE defect(DEREF_OF_NULL.RET.STAT) 15/242615/5 accepted/tizen/unified/20200829.113359 submit/tizen/20200828.155654
Seungbae Shin [Fri, 28 Aug 2020 08:54:19 +0000 (17:54 +0900)]
Fix SVACE defect(DEREF_OF_NULL.RET.STAT)

[Version] 13.0.32
[Issue Type] Vulnerability

Change-Id: Ideb267ce415c92c51702558cfdba9cb8cb0bc179

3 years agoFix Coverity defects 21/242521/1 accepted/tizen/unified/20200828.121501 submit/tizen/20200827.104847
Seungbae Shin [Thu, 27 Aug 2020 10:28:52 +0000 (19:28 +0900)]
Fix Coverity defects

 - Unchecked return value (CHECKED_RETURN)
 - String not null terminated (STRING_NULL)

[Version] 13.0.31
[Issue Type] Vulnerability

Change-Id: I0e4b8c824c0d6dd9efe71d34d3576aa81453aa83

3 years agofixup! tizenaudio-publish: publish only built-in devices 74/241974/1 accepted/tizen/unified/20200824.134513 submit/tizen/20200821.074009 submit/tizen/20200824.023231
Seungbae Shin [Fri, 21 Aug 2020 07:31:03 +0000 (16:31 +0900)]
fixup! tizenaudio-publish: publish only built-in devices

adjust log level for ignoring publish

[Version] 13.0.30
[Issue Type] Update

Change-Id: I0476c340de9b4bffc13bf9734bd837fd5f169f92

3 years agofixup! tizenaudio-discover: ignore local services 76/241876/4
Seungbae Shin [Thu, 20 Aug 2020 10:07:32 +0000 (19:07 +0900)]
fixup! tizenaudio-discover: ignore local services

skip discovered from localhost(127.0.0.1)

[Version] 13.0.29
[Issue Type] Update

Change-Id: I5faa7ae58b5ebfa8dae5a8c68ba64ff2309096f4

3 years agostream-manager-dbus: launch mdnsd when remote publish/discover 32/241432/4
Seungbae Shin [Thu, 20 Aug 2020 06:17:38 +0000 (15:17 +0900)]
stream-manager-dbus: launch mdnsd when remote publish/discover

[Version] 13.0.28
[Issue Type] Update

Change-Id: I0a63ba5c5636e249f640337b25bfd698c18311d9

3 years agostream-manager: add publish/discover/set_permission interfaces 73/241273/9
Jaechul Lee [Wed, 19 Aug 2020 02:48:15 +0000 (11:48 +0900)]
stream-manager: add publish/discover/set_permission interfaces

method name     : SetRemotePermission
method argument : [in] string for type
                  [in] unsigned  for index
                  [in] boolean for allowed
return value    : None

method name     : DiscoverRemoteDevice
method argument : [in] boolean for enable
return value    : None

method name     : PublishLocalDevice
method argument : [in] boolean for enable
return value    : None

[Version] 13.0.27
[Issue Type] New feature

Change-Id: I6ab4a388410dcf4d9480bdc1aaaaa7202a199a9f
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agostream-manager: add restriction for accessing denied remote device 92/241192/7
Seungbae Shin [Tue, 18 Aug 2020 11:10:32 +0000 (20:10 +0900)]
stream-manager: add restriction for accessing denied remote device

includes minor code refactoring

[Version] 13.0.26
[Issue Type] Update

Change-Id: I1d77ff249192bde15b861c9a9d481e3564b791d6

3 years agodevice-manager: handle tunnel device 89/241189/6
Seungbae Shin [Tue, 18 Aug 2020 10:36:53 +0000 (19:36 +0900)]
device-manager: handle tunnel device

tunnel device will be registered(unregistered) when the remote access permission is allowed(denied).
tunnel device will be a network type device

[Version] 13.0.25
[Issue Type] Update

Change-Id: I897fcb5a74ee55c60112e5a9d956c909aae736d0

3 years agotizenaudio-publish: publish only built-in devices 84/238684/4 accepted/tizen/unified/20200817.134629 submit/tizen/20200814.044955
Seungbae Shin [Mon, 13 Jul 2020 02:13:47 +0000 (11:13 +0900)]
tizenaudio-publish: publish only built-in devices

[Version] 13.0.24
[Issue Type] Update

Change-Id: I69753da561c813c80c35df7690d4efc1efc48a43

3 years agotizenaudio-discover: use new tunnel module 85/238685/4
Seungbae Shin [Tue, 14 Jul 2020 11:24:16 +0000 (20:24 +0900)]
tizenaudio-discover: use new tunnel module

[Version] 13.0.23
[Issue Type] Update

Change-Id: I42946234489dffb5e936d49ce7a6eb46aec5dcaa

3 years agotizenaudio-discover: ignore local services 82/238682/5
Seungbae Shin [Mon, 13 Jul 2020 02:12:18 +0000 (11:12 +0900)]
tizenaudio-discover: ignore local services

[Version] 13.0.22
[Issue Type] Update

Change-Id: I6e8f334e6a16f5f4367c002ea5bd5809dc6b561b

3 years agoAdd module-tizenaudio-discover / module-tizenaudio-publish for remote audio feature 25/229025/17
Seungbae Shin [Mon, 23 Mar 2020 11:22:54 +0000 (20:22 +0900)]
Add module-tizenaudio-discover / module-tizenaudio-publish for remote audio feature

module-tizenaudio-discover : based on module-zeroconf-discover with mDNSResponder porting
module-tizenaudio-publish  : based on module-bonjour-publish with minor changes

[Version] 13.0.21
[Issue Type] New feature

Change-Id: Id47dad038bfae487bbe57a09aaece674b30f9008

3 years agoExclude ringbacktone stream from changing call active routing logic 27/237127/3 accepted/tizen/unified/20200710.114034 submit/tizen/20200709.084332
Sangchul Lee [Thu, 25 Jun 2020 07:05:26 +0000 (16:05 +0900)]
Exclude ringbacktone stream from changing call active routing logic

stream_is_call_family() is also renamed to
is_stream_related_call_active_routing()

[Version] 13.0.20
[Issue Type] Bug fix

Change-Id: Iedee8a5c2e655d4bf4c9f0275c0ed8c0c5450621
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agoAdd Tizen_HW_Touch.ogg at /usr/share/sound/mm-sound directory 61/234661/3 accepted/tizen/unified/20200623.080530 submit/tizen/20200619.020710 submit/tizen/20200623.011651
Jaechul Lee [Thu, 28 May 2020 01:53:46 +0000 (10:53 +0900)]
Add Tizen_HW_Touch.ogg at /usr/share/sound/mm-sound directory

This file is moved from libmm-sound because sound_server doesn't exist.

[Version] 13.0.19
[Issue Type] None

Change-Id: I14801824c87c4388addfbb465092d04b965e2bb9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agotone-player: Add sink_input_detach callback 13/234513/5 accepted/tizen/unified/20200615.135431 submit/tizen/20200608.021130 submit/tizen/20200610.005134 submit/tizen/20200610.094452 submit/tizen/20200611.012834 submit/tizen/20200611.075746
Jaechul Lee [Wed, 27 May 2020 01:41:01 +0000 (10:41 +0900)]
tone-player: Add sink_input_detach callback

sink_input_detach_cb function was added to synchronize I/O and main
thread. This commit fixes the unlink issue(f8cde9099) completely.

In additional, handle_sound_stop returns invalid param error when it is
called with invalid handle.

[Version] 13.0.18
[Issue Type] Bug fix

Change-Id: I1f2ede6c0acc6728e1055317124815db3dbd859c
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agostream-manager: Select new proper device even if sink or source of new data is set 45/233745/2 accepted/tizen/unified/20200601.051755 submit/test/20200612.071313 submit/tizen/20200529.085112
Sangchul Lee [Tue, 19 May 2020 01:32:38 +0000 (10:32 +0900)]
stream-manager: Select new proper device even if sink or source of new data is set

In tizen policy, selecting device is performed in tizenaudio-policy
module. The previous codes skip selecting the device logic if sink or
source of new data is defined(probably aka default sink/source) in
somewhere before the codes. This patch set it regardless of this matter.

We need to be aware of this modification for possible issues regarding
it. If the skip logic is needed anyway later, we may put that in
another place.

[Version] 13.0.17
[Issue Type] Bug fix

Change-Id: I92df553b259d8ae1ff9de6c29723ccbb78bfaee6
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
3 years agotone-player: Adds unlinked variable when a stream is stopped 68/233668/2
Jaechul Lee [Mon, 18 May 2020 06:44:24 +0000 (15:44 +0900)]
tone-player: Adds unlinked variable when a stream is stopped

Unlink messages is sent twice in a row in I/O thread. So, it make
sink_input_kill function call twice without a guard on TM1.

[Version] 13.0.16
[Issue Type] Bugs

Change-Id: Ibbe3041a64107ce4fdcf842658a472aad3c23d02
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
3 years agotone-player: Adds new tone playback APIs 29/231429/12 submit/tizen/20200512.012802
Jaechul Lee [Fri, 3 Apr 2020 00:32:53 +0000 (09:32 +0900)]
tone-player: Adds new tone playback APIs

These new APIs will be used by capi-media-tone-player.

  server          : org.pulseaudio.Server
  object path     : /org/pulseaudio/TonePlayer
  interface       : org.pulseaudio.TonePlayer

  method name     : TonePlay
  method argument : [in] unsigned int for tone index
                    [in] signed int for duration
                    [in] signed int for client pid
                    [in] string for role
                    [in] signed int for parent id
                    [out] unsigned int for stream index
  return value    : None

  method name     : ToneStop
  method argument : [in] unsigned int for stream index
  return value    : None

[Version] 13.0.15
[Issue Type] Improvement

Change-Id: I090e917e26697250bb187b0d2df8cd6042875354
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoFix resource leaks when pulseaudio is terminated 79/232379/2
Jaechul Lee [Mon, 4 May 2020 01:31:10 +0000 (10:31 +0900)]
Fix resource leaks when pulseaudio is terminated

This resource leak makes abort signal in core_free function and then
spends times to make unnecessary crash dump.

Change-Id: Iccc7cdce2e60985f73a819e83cf7f4887cfdaac9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agoChanges PA_PCM_DUMP_PA_* to PA_PCM_DUMP_* 46/232046/1
Jaechul Lee [Tue, 28 Apr 2020 01:27:38 +0000 (10:27 +0900)]
Changes PA_PCM_DUMP_PA_* to PA_PCM_DUMP_*

Change-Id: Ie02cdb0a276b0f440057bb6b1124e1d5076f3124
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agotizenaudio-policy: Removes unused pcm dump define 55/231655/2
Jaechul Lee [Thu, 23 Apr 2020 08:12:13 +0000 (17:12 +0900)]
tizenaudio-policy: Removes unused pcm dump define

[Version] 13.0.14
[Issue Type] None

Change-Id: I83e01e8eeb120ad76f68d7f9070e1e40f0543be9
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agosound-player: Fix memory leak in stop APIs 13/231413/2 accepted/tizen/unified/20200422.215421 submit/tizen/20200422.064310
Jaechul Lee [Wed, 22 Apr 2020 01:32:41 +0000 (10:32 +0900)]
sound-player: Fix memory leak in stop APIs

Every time stop APIs called, memory leak found. The reason why
sink_input's userdata that has wrapper structure such as
memblockq_stream, file_stream should be freed.

[Version] 13.0.13
[Issue Type] Bug

Change-Id: I221a6ace56b4c57f288c263c6e3b5fe5abf5e38a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agosound-player: Adds error return for not supported media type 32/230132/5 accepted/tizen/unified/20200417.152647 submit/tizen/20200417.044433
Jaechul Lee [Wed, 8 Apr 2020 06:06:48 +0000 (15:06 +0900)]
sound-player: Adds error return for not supported media type

added checking not support media type error and checking invalid handle
in sound_stop function. in this case, sound_server returns
org.tizen.multimedia.audio.InvalidState and it changes to INVALID_OPERATION

[Version] 13.0.12
[Issue Type] Add

Change-Id: I35db85891d6c54f6af09449668e09ea01c09ff7a
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agostream-manager: Check role/route_type functions to skip process are revised 39/229539/2 accepted/tizen/unified/20200408.131511 submit/tizen/20200406.030837 submit/tizen/20200407.002130 submit/tizen/20200408.002613
Sangchul Lee [Wed, 1 Apr 2020 23:43:22 +0000 (08:43 +0900)]
stream-manager: Check role/route_type functions to skip process are revised

check_role_to_skip()/check_route_type_to_skip() are renamed to
is_invalid_role()/is_invalid_route_type() respectively.

Specific conditions inside of the previous functions are
moved out of the new renamed functions.

[Version] 13.0.10
[Issue Type] Refactoring

Change-Id: Ie6ec2e0a3b42078d1265e15ef35db240daad2111
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoRemove unused header files 04/229304/3 submit/tizen/20200403.080755
Jaechul Lee [Tue, 31 Mar 2020 05:11:34 +0000 (14:11 +0900)]
Remove unused header files

symdef.h isn't used anymore.
backport mainline commit d9624e038 for removing unused code

[Version] 13.0.10
[Issue Type] Refactoring

Change-Id: Id249e22d1cdf41a37b331d89bcdaefc1f5a4e67e
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agosound-player: Adds new sound playback APIs 01/228901/11
Jaechul Lee [Thu, 26 Mar 2020 08:13:48 +0000 (17:13 +0900)]
sound-player: Adds new sound playback APIs

These new APIs will be used by capi-media-wav-player.

  server          : org.pulseaudio.Server
  object path     : /org/pulseaudio/SoundPlayer
  interface       : org.pulseaudio.SoundPlayer

  method name     : SoundPlay
  method argument : [in] string for input filename
                    [in] signed int for loop count
                    [in] signed int for client pid
                    [in] string for role
                    [in] signed int for parent id
                    [out] signed int for stream index
  return value    : None

  method name     : SoundStop
  method argument : [in] signed int for stream index
  return value    : None

  signal aname     : EOS
  signal argument  : [out] signed int for stream index
  return value    : None

[Version] 13.0.9
[Issue Type] Add

Change-Id: Ifff7fc327a8fdd47595c9411b983e97b9623b259
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agostream-manager: Add conditions not to notify stream connection/disconnection twice 27/229427/1
Sangchul Lee [Wed, 1 Apr 2020 00:02:46 +0000 (09:02 +0900)]
stream-manager: Add conditions not to notify stream connection/disconnection twice

This notification invokes HAL function for stream connection changed.
There were cases that this functions is invoked twice unintentionally
according to the scenario related to calling cork/uncork from client
side. For example, gstreamer pulsesink and playbacks from sound-server.

It is now fixed to trigger the notification one at a time properly.

[Version] 13.0.8
[Issue Type] Improvement

Change-Id: I1ef748ad514c87e01034e4f5bd8fc9b1083be34b
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agosound-player: add stop / stop_all operation for simple playbacks 22/227322/12 accepted/tizen/unified/20200323.172915 submit/tizen/20200323.095035
Seungbae Shin [Wed, 11 Mar 2020 07:36:57 +0000 (16:36 +0900)]
sound-player: add stop / stop_all operation for simple playbacks

[Version] 13.0.7
[Issue Type] Add

Change-Id: I9b9e1653496f77d24c0aab0d7b3e093b547e080f

4 years agopoweroff: Changes the file permission to 644 98/228098/3
Jaechul Lee [Thu, 19 Mar 2020 04:24:09 +0000 (13:24 +0900)]
poweroff: Changes the file permission to 644

removed unnecessary permissions.

Change-Id: I729f31ccdfa748c0dfc0a8b9484940962ead4b69
Signed-off-by: Jaechul Lee <jcsing.lee@samsung.com>
4 years agostream-manager-dbus: Send signal for ducking immediately when duration is 0 17/227817/7 accepted/tizen/unified/20200318.130518 submit/tizen/20200317.075627
Jeongmo Yang [Mon, 16 Mar 2020 11:15:09 +0000 (20:15 +0900)]
stream-manager-dbus: Send signal for ducking immediately when duration is 0

- sink_input_ramp_finish_cb is not called when duration is 0

[Version] 13.0.6
[Profile] Common
[Issue Type] Bug fix

Change-Id: I292d620472a57b13ecaa6b69d81206e289552a6b
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoreplace source SET_STATE handlers with callbacks 33/227733/2 submit/tizen/20200316.105549
Seungbae Shin [Mon, 16 Mar 2020 05:58:32 +0000 (14:58 +0900)]
replace source SET_STATE handlers with callbacks

[Version] 13.0.5
[Issue Type] Bug / Upgrade

Change-Id: I46b2885d566b8ebcdc555d28260f4ce25f7fe7d2

4 years agoreplace sink SET_STATE handlers with callbacks 44/227544/1 accepted/tizen/unified/20200315.214844 submit/tizen/20200313.024309
Seungbae Shin [Thu, 12 Mar 2020 12:21:17 +0000 (21:21 +0900)]
replace sink SET_STATE handlers with callbacks

[Version] 13.0.4
[Issue Type] Bug / Upgrade

Change-Id: Ic762a7ea4262b4d661a6a85191a00e0e45f884a3

4 years agoFix coverty defects (CHECKED_RETURN) 99/226999/2 accepted/tizen/unified/20200310.151112 submit/tizen/20200309.034736 submit/tizen/20200309.095617
Seungbae Shin [Mon, 9 Mar 2020 03:01:40 +0000 (12:01 +0900)]
Fix coverty defects (CHECKED_RETURN)

[Version] 13.0.2
[Issue Type] Vulnerability

Change-Id: Ifc9ef1f508155b34c06a8b14b5cd27fde67ae35d

4 years agoRemove module-hw-keysound which is no longer supported 04/225804/2 accepted/tizen/unified/20200304.123928 submit/tizen/20200303.010146
Seungbae Shin [Mon, 24 Feb 2020 11:49:58 +0000 (20:49 +0900)]
Remove module-hw-keysound which is no longer supported

[Version] 13.0.2
[Issue Type] Dependencies

Change-Id: I2eb24577bd68fe6ce6cadb84b90ba3c63c057e00

4 years agofixup! stream-manager: Fix svace defects (CHECK_AFTER_OVERFLOW / UNREACHABLE_CODE) 98/224498/3 submit/tizen/20200224.103343
Seungbae Shin [Tue, 11 Feb 2020 05:31:18 +0000 (14:31 +0900)]
fixup! stream-manager: Fix svace defects (CHECK_AFTER_OVERFLOW / UNREACHABLE_CODE)

+ remove minor warning

Change-Id: Icca68a8fc1e1369208c3e6a91a74e1b099e05a84

4 years agoAdapt codes for PulseAudio 13.0 88/222888/3 submit/tizen/20200211.115824
Sangchul Lee [Tue, 21 Jan 2020 07:03:42 +0000 (16:03 +0900)]
Adapt codes for PulseAudio 13.0

[Version] 13.0.1
[Issue Type] Update

Change-Id: I6524931df89b70d573b209eb6a4479cd6b7adafc
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agostream-manager: Improve sending ducking state changed signal 97/223797/1 submit/tizen/20200205.062641 submit/tizen/20200206.023537
Sangchul Lee [Tue, 4 Feb 2020 03:39:32 +0000 (12:39 +0900)]
stream-manager: Improve sending ducking state changed signal

If two or more ducking requests have been activated to the same
target stream type during ducking operation, ducking state changed
signal should be emitted for each ducking request handle respectively.
Previously, it did not work well. It is now fixed.

Note that these ducking state changed signals will be emitted at the
same time when the sink-input's ramp finish hook is called in the
thread context as soon as the final ducking operation has been done.

[Version] 11.1.97
[Issue Type] Bug fix

Change-Id: I3de608a7053c6c61e74ff67af271d2972f5149a1
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agostream-manager: Fix svace defects (CHECK_AFTER_OVERFLOW / UNREACHABLE_CODE) 30/223630/3 accepted/tizen/unified/20200203.125727 submit/tizen/20200203.035951
Seungbae Shin [Fri, 31 Jan 2020 09:47:09 +0000 (18:47 +0900)]
stream-manager: Fix svace defects (CHECK_AFTER_OVERFLOW / UNREACHABLE_CODE)

[Version] 11.1.96
[Profile] Common
[Issue Type] Svace

Change-Id: If8546bafff603b9a4443f0452f5533627f991009

4 years agostream-manager: Update volume for all channels 76/223476/1
Jeongmo Yang [Wed, 29 Jan 2020 03:49:53 +0000 (12:49 +0900)]
stream-manager: Update volume for all channels

[Version] 11.1.95
[Profile] Common
[Issue Type] Update

Change-Id: I28f1ef5d696d800e96b5ffadcd5e8ccf8653769a
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agostream-manager: Change ratio from 1.0 to previoulsy set value 44/222544/1 accepted/tizen/unified/20200116.102954 submit/tizen/20200116.065956
Jeongmo Yang [Thu, 16 Jan 2020 03:26:59 +0000 (12:26 +0900)]
stream-manager: Change ratio from 1.0 to previoulsy set value

[Version] 11.1.94
[Profile] Common
[Issue Type] Bug fix

Change-Id: I8daa4c574b6366225635d028354038a505892193
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agostream-manager-volume: Fix for iniparser upgrade 53/221953/3 accepted/tizen/unified/20200113.130551 submit/tizen/20200110.100453
Seungbae Shin [Wed, 8 Jan 2020 10:33:02 +0000 (19:33 +0900)]
stream-manager-volume: Fix for iniparser upgrade

iniparser_getstring() will returns 'const char *' type

[Version] 11.1.93
[Issue Type] Update

Change-Id: If7f243f770c26c524ae00aa3c84af97cdcc6f77e

4 years agotizenaudio-policy: Add support for the preemptive device routing 08/221108/7
Sangchul Lee [Fri, 20 Dec 2019 03:04:57 +0000 (12:04 +0900)]
tizenaudio-policy: Add support for the preemptive device routing

This new feature is only able to be applid to two routing types below.
 - STREAM_ROUTE_TYPE_AUTO, STREAM_ROUTE_TYPE_AUTO_LAST_CONNECTED

If user sets the preemptive device to a specific stream role, this device
has priority over all other devices that can be selected by the policy of
the stream role. Once it is set to a particular stream role, audio routing
of all other streams with the same stream role will be affected.

  server          : org.pulseaudio.Server
  object path     : /org/pulseaudio/StreamManager
  interface       : org.pulseaudio.StreamManager

  method name     : SetStreamPreemptiveDevice
  method argument : [in] string for stream type (e.g. 'media')
                    [in] string for io direction ('in' or 'out')
                    [in] unsigned int for device id
  return value    : string for return message
                    - success                   : STREAM_MANAGER_RETURN_OK
                    - invalid argument error    : STREAM_MANAGER_RETURN_ERROR_INVALID_ARGUMENT
                    - policy error              : STREAM_MANAGER_RETURN_ERROR_POLICY
                    - internal error            : STREAM_MANAGER_RETURN_ERROR_INTERNAL

  method name     : GetStreamPreemptiveDevice
  method argument : [in] string for stream type (e.g. 'media')
                    [out] unsigned int for input device id
                    [out] unsigned int for output device id
  return value    : string for return message
                    - success                   : STREAM_MANAGER_RETURN_OK
                    - internal error            : STREAM_MANAGER_RETURN_ERROR_INTERNAL

[Version] 11.1.92
[Issue Type] New feature

Change-Id: I12dd1d8d5463426331955a4f7a3799b551685a4d
Signed-off-by: Sangchul Lee <sc11.lee@samsung.com>
4 years agoValidate duckding state with command in handle_activate_ducking() 41/218341/2 accepted/tizen/unified/20191122.053253 submit/tizen/20191122.024811
Jeongmo Yang [Thu, 21 Nov 2019 10:32:52 +0000 (19:32 +0900)]
Validate duckding state with command in handle_activate_ducking()

[Version] 11.1.91
[Profile] Common
[Issue Type] Improvement

Change-Id: I07ff4491f2adc53d623cab82cfb779aeb60e943a
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agoFix coverity issue - Unchecked return value 22/218022/1 accepted/tizen/unified/20191119.083904 submit/tizen/20191119.015812
Jeongmo Yang [Tue, 19 Nov 2019 01:33:42 +0000 (10:33 +0900)]
Fix coverity issue - Unchecked return value

[Version] 11.1.90
[Profile] Common
[Issue Type] Coverity

Change-Id: I337ad24b87cff98b9ce0160fac28ce7728e42bbb
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
4 years agofixup! Add ducking state to prevent invalid operation. 98/217998/2 accepted/tizen/unified/20191118.234456 submit/tizen/20191118.103834
Jeongmo Yang [Mon, 18 Nov 2019 10:33:17 +0000 (19:33 +0900)]
fixup! Add ducking state to prevent invalid operation.

Add missed string for error

Change-Id: Ieab3be9b2f2889c9187e8f1345bcd662f1c3aec3
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>