Fix Coverity issue

Change-Id: I16df6ee24bff0454db0f06a28a5c640a20e1bd0e
Signed-off-by: Hyunsoo Park <hance.park@samsung.com>

diff --git a/packaging/libmm-streamrecorder.spec b/packaging/libmm-streamrecorder.spec
index 3c0dc89..857a356 100644 (file)
--- a/packaging/libmm-streamrecorder.spec
+++ b/packaging/libmm-streamrecorder.spec
@@ -1,6 +1,6 @@
 Name:       libmm-streamrecorder
 Summary:    Media Stream Recorder library
-Version:    0.0.35
+Version:    0.0.36
 Release:    0
 Group:      Multimedia/Other
 License:    Apache-2.0

diff --git a/src/mm_streamrecorder_util.c b/src/mm_streamrecorder_util.c
index 6666ed5..dd2a782 100644 (file)
--- a/src/mm_streamrecorder_util.c
+++ b/src/mm_streamrecorder_util.c
@@ -130,7 +130,7 @@ int _mmstreamrecorder_get_pixel_format(GstCaps *caps)
 {
        const GstStructure *structure;
        const char *media_type = NULL;
-       MMPixelFormatType type = 0;
+       MMPixelFormatType type = MM_PIXEL_FORMAT_INVALID;
        unsigned int fourcc = 0;
        GstVideoInfo media_info;
 
@@ -150,9 +150,12 @@ int _mmstreamrecorder_get_pixel_format(GstCaps *caps)
        } else if (!strcmp(media_type, "video/x-raw-yuv")) {
                _mmstreamrec_dbg_log("It is yuv.");
                gst_video_info_init(&media_info);
-               gst_video_info_from_caps(&media_info, caps);
-               fourcc = gst_video_format_to_fourcc(GST_VIDEO_INFO_FORMAT(&media_info));
-               type = _mmstreamrecorder_get_pixtype(fourcc);
+               if (gst_video_info_from_caps(&media_info, caps)) {
+                       fourcc = gst_video_format_to_fourcc(GST_VIDEO_INFO_FORMAT(&media_info));
+                       type = _mmstreamrecorder_get_pixtype(fourcc);
+               } else {
+                       _mmstreamrec_dbg_err("Getting media_info is failed");
+               }
        } else if (!strcmp(media_type, "video/x-raw-rgb")) {
                _mmstreamrec_dbg_log("It is rgb.");
                type = MM_PIXEL_FORMAT_RGB888;
@@ -163,6 +166,7 @@ int _mmstreamrecorder_get_pixel_format(GstCaps *caps)
 
        _mmstreamrec_dbg_log("Type [%d]", type);
 
+error:
        gst_caps_unref(caps);
        caps = NULL;