[0.6.240] Fix coverity issues

- Missing unlock, Double free

Change-Id: Ied1781d04f3177a36762658c07e704a69edba382

diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec
index f226d39..5c303a2 100644 (file)
--- a/packaging/libmm-player.spec
+++ b/packaging/libmm-player.spec
@@ -1,6 +1,6 @@
 Name:       libmm-player
 Summary:    Multimedia Framework Player Library
-Version:    0.6.239
+Version:    0.6.240
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0

diff --git a/src/mm_player_gst.c b/src/mm_player_gst.c
index 906be79..89d50f3 100644 (file)
--- a/src/mm_player_gst.c
+++ b/src/mm_player_gst.c
@@ -509,7 +509,7 @@ static gboolean
 __mmplayer_handle_streaming_error(mmplayer_t *player, GstMessage *message)
 {
        LOGD("\n");
-       MMMessageParamType msg_param;
+       MMMessageParamType msg_param = {0, };
        gchar *msg_src_element = NULL;
        GstStructure *s = NULL;
        guint error_id = 0;
@@ -765,7 +765,7 @@ __mmplayer_gst_extract_tag_from_msg(mmplayer_t *player, GstMessage *msg)
                        if (!gst_buffer_map(buffer, &info, GST_MAP_READ)) {\
                                LOGD("failed to get image data from tag");\
                                gst_sample_unref(sample);\
-                               return FALSE;\
+                               break;\
                        } \
                        SECURE_LOGD("update album cover data : %p, size : %zu", info.data, info.size);\
                        MMPLAYER_FREEIF(player->album_art);\

diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c
index 6b19906..8396f5f 100644 (file)
--- a/src/mm_player_priv.c
+++ b/src/mm_player_priv.c
@@ -3772,6 +3772,7 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player)
        LOGD("adding created elements to bin");
        if (!_mmplayer_gst_element_add_bucket_to_bin(GST_BIN(textbin[MMPLAYER_T_BIN].gst), element_bucket)) {
                LOGE("failed to add elements");
+               g_list_free(element_bucket);
                goto ERROR;
        }
 
@@ -3783,6 +3784,7 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player)
        LOGD("Linking elements in the bucket by added order.");
        if (_mmplayer_gst_element_link_bucket(element_bucket) == -1) {
                LOGE("failed to link elements");
+               g_list_free(element_bucket);
                goto ERROR;
        }
 
@@ -3817,7 +3819,6 @@ __mmplayer_gst_create_plain_text_elements(mmplayer_t *player)
        return MM_ERROR_NONE;
 
 ERROR:
-       g_list_free(element_bucket);
 
        if (!player->play_subtitle && textbin[MMPLAYER_T_FAKE_SINK].gst) {
                LOGE("remove textbin sink from sink list");