[0.6.293] Fix Svace/Coverity issues

- Svace : DEREF_OF_NULL.RET.ALLOC
- Coverity : Overflowed constant

Change-Id: Id83869a3875e974fd2b93a8eaa0f5434c1ddc9f1

diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec
index 45873ee..a3f3342 100644 (file)
--- a/packaging/libmm-player.spec
+++ b/packaging/libmm-player.spec
@@ -1,6 +1,6 @@
 Name:       libmm-player
 Summary:    Multimedia Framework Player Library
-Version:    0.6.292
+Version:    0.6.293
 Release:    0
 Group:      Multimedia/Libraries
 License:    Apache-2.0

diff --git a/src/mm_player_gst.c b/src/mm_player_gst.c
index 8747a9b..5b342bc 100644 (file)
--- a/src/mm_player_gst.c
+++ b/src/mm_player_gst.c
@@ -785,6 +785,11 @@ __mmplayer_gst_extract_tag_from_msg(mmplayer_t *player, GstMessage *msg)
                if (gst_tag_list_get_date_time(tag_list, gsttag, &datetime)) {\
                        if (datetime != NULL) {\
                                string = g_strdup_printf("%d", gst_date_time_get_year(datetime));\
+                               if (string == NULL) {\
+                                       LOGD("failed to get year from tag");\
+                                       gst_date_time_unref(datetime);\
+                                       break;\
+                               } \
                                mm_player_set_attribute((MMHandleType)player, NULL,\
                                                playertag, string, strlen(string), NULL); \
                                SECURE_LOGD("metainfo year : %s", string);\

diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c
index 855943e..3689bed 100644 (file)
--- a/src/mm_player_priv.c
+++ b/src/mm_player_priv.c
@@ -4261,9 +4261,9 @@ __mmplayer_update_subtitle(GstElement *object, GstBuffer *buffer, GstPad *pad, g
                LOGI("subtitle duration is invalid, subtitle duration change "
                        "GST_CLOCK_TIME_NONE -> %" GST_TIME_FORMAT, GST_TIME_ARGS(duration));
        }
-       msg.subtitle.duration = GST_TIME_AS_MSECONDS(duration);
+       msg.subtitle.duration = (unsigned long)GST_TIME_AS_MSECONDS(duration);
 
-       LOGD("update subtitle : [%ld msec] %s", msg.subtitle.duration, (char *)msg.data);
+       LOGD("update subtitle : [%lu msec] %s", msg.subtitle.duration, (char *)msg.data);
 
        MMPLAYER_POST_MSG(player, MM_MESSAGE_UPDATE_SUBTITLE, &msg);
        gst_buffer_unmap(buffer, &mapinfo);