platform/core/multimedia/libmedia-service.git
3 years agoFix tainted data and minor change 43/244143/3 accepted/tizen_6.0_unified_hotfix tizen_6.0_hotfix accepted/tizen/6.0/unified/20201030.121137 accepted/tizen/6.0/unified/hotfix/20201103.002736 accepted/tizen/unified/20200917.055759 submit/tizen/20200916.012329 submit/tizen/20200917.004955 submit/tizen_6.0/20201029.205103 submit/tizen_6.0_hotfix/20201102.192504 submit/tizen_6.0_hotfix/20201103.114804 tizen_6.0.m2_release
jiyong.min [Tue, 15 Sep 2020 08:13:19 +0000 (17:13 +0900)]
Fix tainted data and minor change

  - Add to check return value of fread due to tainted data
  - Add to check minimum value of '((x[0] << 8) | (x[1]))'
  - minor change. change 'long' and 'gsize' to 'size_t'

Change-Id: Ib71be1c7caeea8c99cb6194734599930d4d64bc1

3 years agoVersion Up (0.4.12 -> 0.4.13) 05/243805/1 accepted/tizen/unified/20200911.043214 submit/tizen/20200910.074805
Minje Ahn [Thu, 10 Sep 2020 07:18:21 +0000 (16:18 +0900)]
Version Up (0.4.12 -> 0.4.13)

Change-Id: I008604ae4701bda6b05e375497bde392640ef92f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFix external storage related code 74/243774/1
Minje Ahn [Thu, 10 Sep 2020 04:34:25 +0000 (13:34 +0900)]
Fix external storage related code

Fixed an issue where media was visible even when external storage was unmounted.

Change-Id: If9a41404970cfb7d9a90e6c8db60abf5d1268312
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRollback media-scan-extractor-v2 63/243663/1 accepted/tizen/unified/20200910.123942 submit/tizen/20200909.063454
Minje Ahn [Wed, 9 Sep 2020 03:27:22 +0000 (12:27 +0900)]
Rollback media-scan-extractor-v2

Rollback __msc_check_extract_stop_status() for performance issue.

Change-Id: Id9c704d1ce798903fb7d00fc55a30c2bd0347583
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoUse GPtrArray in ms_get_null_scan_folder_list() 87/240387/1 accepted/tizen/unified/20200811.050323 submit/tizen/20200807.062206
Minje Ahn [Thu, 6 Aug 2020 03:56:30 +0000 (12:56 +0900)]
Use GPtrArray in ms_get_null_scan_folder_list()

Change-Id: I731d525fc6616cae931611bdf6c9601065ec5027
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoMerge get_extract_list() and update_one_extract_item() 84/239784/2 accepted/tizen/unified/20200804.142414 submit/tizen/20200803.055908
Minje Ahn [Wed, 29 Jul 2020 23:09:07 +0000 (08:09 +0900)]
Merge get_extract_list() and update_one_extract_item()

This patch only affects media-scanner-v2.

Change-Id: I1df8babba20335f2982ab7e5f9512a0051ab0483
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove query_do_update_list() 66/238966/1 accepted/tizen/unified/20200724.124245 submit/tizen/20200722.015458
Minje Ahn [Tue, 21 Jul 2020 01:01:06 +0000 (10:01 +0900)]
Remove query_do_update_list()

Modified update_one_extract_item() function to update DB directly.
So there is no need to call query_do_update_list() for update.
This patch only affects media-scanner-v2.

Change-Id: I1bacc8ad90eb97bd32fd95fe2b1ab127c3a65670
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove unnecessary plugin API 74/238474/2 accepted/tizen/unified/20200717.124754 submit/tizen/20200715.035035
Minje Ahn [Tue, 14 Jul 2020 08:00:42 +0000 (17:00 +0900)]
Remove unnecessary plugin API

1. Remove plugin APIs that are no longer used.
2. Remove unnecessary parameters.

Change-Id: I51df4617e62361189646bcc84684af66d2473e66
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoAdjust space 23/238123/1 accepted/tizen/unified/20200709.212819 submit/tizen/20200709.031615
Minje Ahn [Wed, 8 Jul 2020 23:27:24 +0000 (08:27 +0900)]
Adjust space

Change-Id: I339d7d81ad6728df2291534dd12a562e4328b334
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoCorrect indentation 23/237523/2 accepted/tizen/unified/20200706.133932 submit/tizen/20200702.014328 submit/tizen/20200705.232724
Minje Ahn [Wed, 1 Jul 2020 05:37:27 +0000 (14:37 +0900)]
Correct indentation

Change-Id: Ic7a094f60c7fad8acbf886cf09b1769ee7396c8c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove plugin API for folder batch insertion 94/237294/5 accepted/tizen/unified/20200630.131151 submit/tizen/20200630.065716
Minje Ahn [Mon, 29 Jun 2020 01:21:28 +0000 (10:21 +0900)]
Remove plugin API for folder batch insertion

This patch changes media-scanner-v2 to write directly to media.db.
It makes better performance than bulk insert through IPC.

Change-Id: Ic8c54363a9f9e7366a2506e57f1e9ab7834bc9f1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove -Wno-deprecated-declarations option 87/236787/4 accepted/tizen/unified/20200624.130230 submit/tizen/20200623.070108
hj kim [Mon, 22 Jun 2020 05:56:55 +0000 (14:56 +0900)]
Remove -Wno-deprecated-declarations option

Change-Id: Ic23d360d919d9319fdae088a315b518152f11bbe

3 years agoMerge "Use g_date_time_new_from_iso8601() instead" into tizen
hj kim [Tue, 23 Jun 2020 07:05:32 +0000 (07:05 +0000)]
Merge "Use g_date_time_new_from_iso8601() instead" into tizen

3 years agoMerge "media_svc_refresh_item cleanup" into tizen
hj kim [Tue, 23 Jun 2020 07:05:20 +0000 (07:05 +0000)]
Merge "media_svc_refresh_item cleanup" into tizen

3 years agoUse g_date_time_new_from_iso8601() instead 84/236784/2
Minje Ahn [Mon, 22 Jun 2020 05:34:21 +0000 (14:34 +0900)]
Use g_date_time_new_from_iso8601() instead

g_time_val_from_iso8601 has been deprecated since version 2.62 and should not be used in newly-written code.
GTimeVal is not year-2038-safe. Use g_date_time_new_from_iso8601() instead.

Change-Id: I7835be133dd868d8fafc3f90e52f2ecafc295020
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoRemove document image 94/236294/1
Minje Ahn [Tue, 16 Jun 2020 06:17:00 +0000 (15:17 +0900)]
Remove document image

Change-Id: I655291333e696e4fef3e1274f17dfa77267e4697
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agomedia_svc_refresh_item cleanup 67/235467/1
Minje Ahn [Thu, 4 Jun 2020 23:15:28 +0000 (08:15 +0900)]
media_svc_refresh_item cleanup

Change-Id: I24022821a1163915d34a1bd30e2b955744103d00
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFix memory leak 32/235232/2 accepted/tizen/unified/20200604.164549 submit/tizen/20200603.011259
Minje Ahn [Wed, 3 Jun 2020 02:30:49 +0000 (11:30 +0900)]
Fix memory leak

Fix memory leak for below:
https://review.tizen.org/gerrit/c/platform/core/multimedia/libmedia-service/+/235209

Change-Id: I1c53f8d7885b82a22d77c763dbad9797726f3972
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFix folder scanning error 09/235209/2
Minje Ahn [Tue, 2 Jun 2020 23:07:25 +0000 (08:07 +0900)]
Fix folder scanning error

Fixed an issue where validity was not normally updated when the modification time of the file was changed.

Change-Id: Iddb6288fab3c921a23d54bac809ee3c9601a5fc8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
3 years agoFix thumbnail format PNG to JPG for improve performace 64/233764/5 accepted/tizen/unified/20200601.051622 submit/tizen/20200529.021017
Minje Ahn [Tue, 19 May 2020 04:26:46 +0000 (13:26 +0900)]
Fix thumbnail format PNG to JPG for improve performace

PNG needs more time when encoding/decoding.

Change-Id: I312d0d62924f28c612baadc1bb94d886530e0b26
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove getting of xmp data 89/231589/1 accepted/tizen/unified/20200423.161052 submit/tizen/20200423.080104
Minje Ahn [Thu, 23 Apr 2020 00:34:34 +0000 (09:34 +0900)]
Improve getting of xmp data

Change-Id: Icf42af7e90d32155912f3bdb3e38ebaf1cb75b2b
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoCheck size before allocation 16/231416/1 accepted/tizen/unified/20200422.215425 submit/tizen/20200422.001719
Minje Ahn [Wed, 22 Apr 2020 01:51:00 +0000 (10:51 +0900)]
Check size before allocation

Change-Id: Ie50555a55b2d8abc35321ccafd344b7416ac595f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange resize function to create rotated thumbnail 73/230973/1 accepted/tizen/unified/20200420.142655 submit/tizen/20200416.091150 submit/tizen/20200419.223245
Minje Ahn [Thu, 16 Apr 2020 08:41:35 +0000 (17:41 +0900)]
Change resize function to create rotated thumbnail

Change-Id: I9085abe318e3243ae06fd32ab1b5d228c3ca73b3
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse g_new instead of calloc 86/230386/1 accepted/tizen/unified/20200411.115615 submit/tizen/20200410.073041
Minje Ahn [Thu, 9 Apr 2020 23:33:42 +0000 (08:33 +0900)]
Use g_new instead of calloc

Change-Id: I6e1f3a1f885c7fc8b3fee4024634d750d5535d35
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRename db related define 65/230265/3 accepted/tizen/unified/20200410.015550 submit/tizen/20200409.074448
Minje Ahn [Thu, 9 Apr 2020 05:04:33 +0000 (14:04 +0900)]
Rename db related define

Change-Id: I9c12d2e14b1ef6aef53c939337e467a771debf00
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse g_free instead of macro 55/230255/1
Minje Ahn [Thu, 9 Apr 2020 04:07:41 +0000 (13:07 +0900)]
Use g_free instead of macro

Change-Id: I600ed5f86d2027f8866e759ae8ff78254d244cca
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange function name 14/229414/3 accepted/tizen/unified/20200402.155619 accepted/tizen/unified/20200403.153132 submit/tizen/20200401.074846 submit/tizen/20200403.035052
Minje Ahn [Wed, 1 Apr 2020 03:17:35 +0000 (12:17 +0900)]
Change function name

Change-Id: I1d83a7faf9c02d50b76869a28efbc0dfb43fac06
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix format error 33/228833/1 accepted/tizen/unified/20200331.030833 submit/tizen/20200325.234531
hj kim [Thu, 26 Mar 2020 04:03:30 +0000 (13:03 +0900)]
Fix format error

Change-Id: Iae6a18a8b9324429ae288d27b7dab74e44d42b8d

4 years agoFix format error 04/228804/1
hj kim [Thu, 26 Mar 2020 01:03:23 +0000 (10:03 +0900)]
Fix format error

Change-Id: I70cd604721fdbe275d4a22c02eb80bcf0e7e4264

4 years agoMove some struct and enum defines from header file 36/228636/5
hj kim [Tue, 24 Mar 2020 08:29:12 +0000 (17:29 +0900)]
Move some struct and enum defines from header file

Change-Id: I92d05bb314633d358b98c0d78477c1d4a607e472

4 years agoRearrange included header files 34/228634/7
hj kim [Tue, 24 Mar 2020 08:03:12 +0000 (17:03 +0900)]
Rearrange included header files

Change-Id: I2996c759ab5ecdc6768642e448d5a772415edd9d

4 years agoApply tizen coding rule for static API 25/228625/8
hj kim [Tue, 24 Mar 2020 07:39:00 +0000 (16:39 +0900)]
Apply tizen coding rule for static API

Change-Id: Ia2089d9bbd9dea4b5d268e7c54c1e6d88dc29f95

4 years agoFix underflow issue. 86/228686/8
hj kim [Wed, 25 Mar 2020 00:28:10 +0000 (09:28 +0900)]
Fix underflow issue.

Change-Id: Ie42cec442f8c57668b77d8d0682e556787e6c98e

4 years agoMove some #define from header file 24/228624/1
hj kim [Tue, 24 Mar 2020 07:34:21 +0000 (16:34 +0900)]
Move some #define from header file

Change-Id: I5b04e3a32a090733f234f5ed26a28b546bca15b8

4 years agoFolder related functions cleanup 68/227768/2 accepted/tizen/unified/20200320.074815 submit/tizen/20200317.020149 submit/tizen/20200319.005828 submit/tizen/20200320.001353
Minje Ahn [Mon, 16 Mar 2020 08:19:40 +0000 (17:19 +0900)]
Folder related functions cleanup

1. Remove duplicate query
2. Use check function instead of get_folder_id()
3. Improve parent folder checking function

Change-Id: Ieb06a829f6890401c3ccf75c775aa2da844bd1d8
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse new image thumbnail extracting APIs provided by libmedia-thumbnail 03/227403/7 accepted/tizen/unified/20200318.130543 submit/tizen/20200316.031954
hj kim [Thu, 12 Mar 2020 00:48:18 +0000 (09:48 +0900)]
Use new image thumbnail extracting APIs provided by libmedia-thumbnail

Change-Id: I3b8c5879a645e98ee99dd7ba21c8f08c83dd2b59

4 years agoUse new video thumbnail extracting API provided by libmedia-thumbnail and Remove... 36/226836/11
hj kim [Fri, 6 Mar 2020 01:39:52 +0000 (10:39 +0900)]
Use new video thumbnail extracting API provided by libmedia-thumbnail and Remove related codes.

Duplicated thumbnail extracing codes were unified into libmedia-thumbnail.

Change-Id: Ied325bbf74c669dba153fd3a34474e9538ad34e8

4 years agoMerge "check src before doing g_strlcpy and g_strlcat" into tizen accepted/tizen/unified/20200315.214848 submit/tizen/20200313.001656 submit/tizen/20200313.040349
hj kim [Fri, 13 Mar 2020 06:37:21 +0000 (06:37 +0000)]
Merge "check src before doing g_strlcpy and g_strlcat" into tizen

4 years agouuid related fuctions cleanup 09/227609/1
Minje Ahn [Fri, 13 Mar 2020 06:05:17 +0000 (15:05 +0900)]
uuid related fuctions cleanup

Change-Id: Ibf6c1c4a9d80e5edc66ef1b47ea7c80506410e4e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agocheck src before doing g_strlcpy and g_strlcat 92/227592/7
hj kim [Fri, 13 Mar 2020 04:15:59 +0000 (13:15 +0900)]
check src before doing g_strlcpy and g_strlcat

if src is NULL, get " GLib-CRITICAL **: g_strlcpy: assertion 'src != NULL' failed"

Change-Id: Ia14aec3378bb7dd45b26b740ae4a8ff53054a092

4 years agoFolder related functions cleanup 63/227563/2
Minje Ahn [Fri, 13 Mar 2020 00:59:11 +0000 (09:59 +0900)]
Folder related functions cleanup

Change-Id: Ief056a3f17116ebfff3fd8ada38f55f432676018

4 years agoCode cleanup 43/227443/1
Minje Ahn [Thu, 12 Mar 2020 04:07:00 +0000 (13:07 +0900)]
Code cleanup

1. Simplify media existence check function
2. Initialize the noti list after publish

Change-Id: I08ae9955eb1b7adcfdd02c73aa22e1188a118f08
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoMove static variable into function 81/227281/2 accepted/tizen/unified/20200312.234345 submit/tizen/20200311.070630
hj kim [Wed, 11 Mar 2020 05:25:57 +0000 (14:25 +0900)]
Move static variable into function

Change-Id: I48ab0ca93bef283470bd4e1007e71086fbafbe31

4 years agoFix wrong error value check 70/227270/2
hj kim [Wed, 11 Mar 2020 04:49:48 +0000 (13:49 +0900)]
Fix wrong error value check

Change-Id: I64632bc46092b3fcafc98dba4eca778f089c5aad

4 years agoChanged default thumbnail format to png 75/227275/3
Minje Ahn [Wed, 11 Mar 2020 05:08:00 +0000 (14:08 +0900)]
Changed default thumbnail format to png

Change to save thumbnails as png, regardless of the format of the original image.

Change-Id: I828a21f72b8c4a836c3f55c23b3966cfbc20819b
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unnecessary return value 85/227185/3
Minje Ahn [Tue, 10 Mar 2020 08:22:43 +0000 (17:22 +0900)]
Remove unnecessary return value

Change-Id: I8d14b3f36ea480f899fa0e34aea6d5031552ee25
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove default setting function 68/226868/7 accepted/tizen/unified/20200311.130942 submit/tizen/20200310.032628
Minje Ahn [Fri, 6 Mar 2020 05:12:15 +0000 (14:12 +0900)]
Remove default setting function

1. To fix memory leak
2. To fix the behavior of updating metadata

Change-Id: I3b6e870788ee3af4f561107beb41bd5eb72226e1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove function to get storage id 58/226758/3 submit/tizen/20200306.013725
Minje Ahn [Thu, 5 Mar 2020 07:09:42 +0000 (16:09 +0900)]
Improve function to get storage id

Change-Id: I2e52a2b5a86f58fe2e921bccbd192754b3915bdd
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove parent path validation function 16/226716/3
Minje Ahn [Thu, 5 Mar 2020 04:48:46 +0000 (13:48 +0900)]
Improve parent path validation function

Added len +1 to get the external root path.
 - USB root : MEDIA_ROOT_PATH_EXTERNAL/{storage-uuid}/
 - MMC root : MEDIA_ROOT_PATH_EXTERNAL/SDCard{port_num}/

Change-Id: I983f9a69bf3a3434766a511e7724e24e9ddf11fd
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove VD commercial storage type 74/226674/1
Minje Ahn [Thu, 5 Mar 2020 00:42:45 +0000 (09:42 +0900)]
Remove VD commercial storage type

Change-Id: I49095359214d8c81353a7643aaf323bb40e68dba
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unnecessary triggers 21/226621/1 accepted/tizen/unified/20200305.123304 submit/tizen/20200305.003258
Minje Ahn [Wed, 4 Mar 2020 07:18:30 +0000 (16:18 +0900)]
Remove unnecessary triggers

Change-Id: Ib4499f19d4a85b119e825dfcfafadaa850b08b41
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unused columns 03/226603/1
Minje Ahn [Wed, 4 Mar 2020 06:02:59 +0000 (15:02 +0900)]
Remove unused columns

Change-Id: I093349bd9f5dc47e65af9d966509883a4c6ea3e1
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove VD commercial media type 94/226594/2
Minje Ahn [Wed, 4 Mar 2020 05:22:45 +0000 (14:22 +0900)]
Remove VD commercial media type

Change-Id: I643c46f2484c3fd1a56ba130bce8404c6158201d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove sync_status 85/226585/2
Minje Ahn [Wed, 4 Mar 2020 04:45:34 +0000 (13:45 +0900)]
Remove sync_status

Remove 'sync_status' that is MCD commercial column
"sync_status" was used to indicate whether the content information between mobile and wearable has been synced.

Change-Id: Ied19046667a41ee388dc3a15ff11c4004f53b221
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unused parameter 18/225818/1 accepted/tizen/unified/20200225.224349 submit/tizen/20200224.234052
Minje Ahn [Mon, 24 Feb 2020 23:53:04 +0000 (08:53 +0900)]
Remove unused parameter

Change-Id: I779835497c2d528a0aefbe484422e469833424d2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix resource leak for 'file_name_pinyin' 17/225817/2
jiyong.min [Mon, 24 Feb 2020 23:12:38 +0000 (08:12 +0900)]
Fix resource leak for 'file_name_pinyin'

Change-Id: I0f2c0b3b10f3eff9aaff25a757fc770686b1d927

4 years agoUpdate package version to 0.4.9 12/225312/1 accepted/tizen/unified/20200219.130118 submit/tizen/20200219.055438
Minje Ahn [Wed, 19 Feb 2020 04:27:47 +0000 (13:27 +0900)]
Update package version to 0.4.9

Change-Id: Iabe149d5d73a3971e3d6051de460bb298864a58f
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse transaction for scanner requests 94/225294/1
Minje Ahn [Wed, 19 Feb 2020 01:26:21 +0000 (10:26 +0900)]
Use transaction for scanner requests

To improve scanning performance, use transaction for scanner requests

Change-Id: I5e129af02df886f972a1cca15d28e33603105537
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove indexes from the media table 92/225292/1
Minje Ahn [Wed, 19 Feb 2020 01:05:34 +0000 (10:05 +0900)]
Remove indexes from the media table

Remove because it takes a long time to update the index

Change-Id: I81627bbfac1895b750b6de7cb874bacb9826eaab
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix to limit the length of query list 85/224585/3 accepted/tizen/unified/20200213.121441 submit/tizen/20200213.061057
Minje Ahn [Wed, 12 Feb 2020 00:17:49 +0000 (09:17 +0900)]
Fix to limit the length of query list

To reduce memory occupancy, Change to run updates per BATCH_ITEM_COUNT_MAX.

Change-Id: I3aa59b592f0a47d5d6e70ed33d1319bc7fbf8e4a
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoMerge query list 84/224584/1
Minje Ahn [Wed, 12 Feb 2020 00:11:17 +0000 (09:11 +0900)]
Merge query list

To reduce memory occupancy, merge insert_item_list, update_meta_list, set_validity_list into scanner_list(New list).

Change-Id: Ic51656b6be32f9f7141d0deafe3d076156ac1f2d
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange noti_list to a list instead of an array 81/224481/3 accepted/tizen/unified/20200212.125825 submit/tizen/20200211.050031
Minje Ahn [Tue, 11 Feb 2020 01:32:05 +0000 (10:32 +0900)]
Change noti_list to a list instead of an array

Change-Id: I2233c8da4220989df4fa4514c8fbf26141f30a45
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix thumbnail generation bug 00/224400/1 accepted/tizen/unified/20200210.131715 submit/tizen/20200210.083804
Minje Ahn [Mon, 10 Feb 2020 08:23:34 +0000 (17:23 +0900)]
Fix thumbnail generation bug

Fix a bug that caused the db updates to fail when creating thumbnails of media in external storage

Change-Id: I2c0e01c0deb44fe607b1e416155bfc7bd14c3ef7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoPrevent albumart resize for performance 80/224180/3 accepted/tizen/unified/20200207.122432 submit/tizen/20200206.031941
Minje Ahn [Fri, 7 Feb 2020 02:46:58 +0000 (11:46 +0900)]
Prevent albumart resize for performance

Change-Id: I7cbe3637d7b457135226dd13d12fc0b5964f98a6
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix exception handling 79/224179/1
Minje Ahn [Fri, 7 Feb 2020 02:42:19 +0000 (11:42 +0900)]
Fix exception handling

Change-Id: I224474f434477a551a2c909eddb52112b57e62db
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange to always extract mime type 59/224159/3
Minje Ahn [Thu, 6 Feb 2020 23:38:53 +0000 (08:38 +0900)]
Change to always extract mime type

Change-Id: Idebbe548ea12c0ff9bb0aa5b9fae8e7c2bf3ac93
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUse 'switch-case' instead 'if-else' 69/224069/1
Minje Ahn [Thu, 6 Feb 2020 05:41:34 +0000 (14:41 +0900)]
Use 'switch-case' instead 'if-else'

Change for better performance

Change-Id: I3abf229d2031e8fc13c78e549664f945f293d317
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove record date exception handling 49/223549/6
Minje Ahn [Fri, 31 Jan 2020 00:20:07 +0000 (09:20 +0900)]
Improve record date exception handling

Change-Id: I49aa5c63454e61fab4e3da7445c91671835e0fc7
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoCode cleanup 46/223546/4
Minje Ahn [Thu, 30 Jan 2020 23:49:21 +0000 (08:49 +0900)]
Code cleanup

1. Improve image metadata extraction function
2. Reduce function call related to metadata of integer type
3. Separate GPS metadata extraction function (ExifTag enum set issue)

Change-Id: I664bb02c3b0180abe9145f2a74561e59c159763c
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove gps getting function 92/223492/4
Minje Ahn [Thu, 30 Jan 2020 08:23:35 +0000 (17:23 +0900)]
Remove gps getting function

Call mm_file_get_attrs directly

Change-Id: I59bfbc1237eb28a6e628d113b96678e7bdaa0f34
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unnecessary return value 89/223489/3
Minje Ahn [Thu, 30 Jan 2020 08:16:25 +0000 (17:16 +0900)]
Remove unnecessary return value

Change-Id: I2d769f6a5d5c74c7bc17ab095ba23de0b098e226
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoClean up code for db upgrade 97/222997/3 accepted/tizen/unified/20200130.214725 submit/tizen/20200122.230050 submit/tizen/20200130.013933
Minje Ahn [Wed, 22 Jan 2020 04:56:48 +0000 (13:56 +0900)]
Clean up code for db upgrade

Change-Id: Ib3d524e969a6bc4673ea13c6160c9387ae44d571
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove unused 'err_attr_name' for 'mm_file_get_attrs' 50/222850/4 submit/tizen/20200122.012604
jiyong.min [Tue, 21 Jan 2020 00:10:14 +0000 (09:10 +0900)]
Remove unused 'err_attr_name' for 'mm_file_get_attrs'

Change-Id: Ib58ff35975aed257c5fb6ddd27a8dd515d492af7

4 years agoCode cleanup 46/222846/3
Minje Ahn [Mon, 20 Jan 2020 23:23:52 +0000 (08:23 +0900)]
Code cleanup

1. Use g_strdup instead.
2. Change trigger naming. ({trigger_name}_{event_table} -> {trigger_name})
   - Fixes due to deleting external storage.
3. Remove unnecessary fields

Change-Id: I12ce305854d59b3a161dadee11fc24fc5c4fe0e2
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange the traversal method 02/222802/3
Minje Ahn [Mon, 20 Jan 2020 06:33:07 +0000 (15:33 +0900)]
Change the traversal method

Use next instead of nth_data

Change-Id: Id25fe72122a5812b420f247ed42e2f34401ae519
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove memory deallocation 43/222743/3
Minje Ahn [Mon, 20 Jan 2020 00:28:41 +0000 (09:28 +0900)]
Improve memory deallocation

Improve deallocation functions for g_slist and g_hash_table

Change-Id: I96cab6064897e7a57b0d20352b32095da3c5f09e
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove table creation function 20/222520/2 accepted/tizen/unified/20200117.120757 submit/tizen/20200117.014021
Minje Ahn [Thu, 16 Jan 2020 00:16:59 +0000 (09:16 +0900)]
Improve table creation function

Use Gstring instead

Change-Id: I8e13f40b91e428fb58fa0daedc92e599da9ffbbf
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove view creation function 14/222514/2
Minje Ahn [Wed, 15 Jan 2020 23:20:08 +0000 (08:20 +0900)]
Improve view creation function

Use Gstring instead

Change-Id: I6586bffaa8b9e23c97c396c2ac2bb4a394306920
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoVersion up 31/222631/1
hj kim [Fri, 17 Jan 2020 01:16:22 +0000 (10:16 +0900)]
Version up

Change-Id: Ia236308b27abb830d272c9b0f941eafb826ed909

4 years agoUnify duplicated code regarding view table 68/222568/3
hj kim [Thu, 16 Jan 2020 07:22:07 +0000 (16:22 +0900)]
Unify duplicated code regarding view table

Change-Id: I54e7e7a9e2af8155fb049167e787c006a71e7424

4 years agoUnify duplicated code regarding tmp table 40/222540/2
hj kim [Thu, 16 Jan 2020 02:17:34 +0000 (11:17 +0900)]
Unify duplicated code regarding tmp table

Change-Id: If227a516afdf63bf61ef8b73402db8c535772662

4 years agounify dulicated code regarding db view and remove media_view related code. (media_vie... 48/222448/2
hj kim [Wed, 15 Jan 2020 05:08:02 +0000 (14:08 +0900)]
unify dulicated code regarding db view and remove media_view related code. (media_view is not needed anymore)

Change-Id: Ie538b8bc65dce404ef3715def2d0a95f0f48441f

4 years agoMerge all storage tables 12/216912/1 accepted/tizen/unified/20191114.042548 submit/tizen/20191113.015717
Minje Ahn [Tue, 5 Nov 2019 01:09:13 +0000 (10:09 +0900)]
Merge all storage tables

Change-Id: I9cacdf6fe6ca5bcbe28a7122e0c949ec270fe7c5
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoChange path information to secure log 99/215499/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.023825 accepted/tizen/5.5/unified/mobile/hotfix/20201027.083637 accepted/tizen/unified/20191011.015340 accepted/tizen/unified/20191014.062517 submit/tizen/20191008.062147 submit/tizen/20191010.061714 submit/tizen_5.5/20191031.000003 submit/tizen_5.5_mobile_hotfix/20201026.185103 tizen_5.5.m2_release
jiyong.min [Thu, 10 Oct 2019 00:24:21 +0000 (09:24 +0900)]
Change path information to secure log

Change-Id: I9a0691cdbcd3591338b2bff4f11f40f5f0457364

4 years agoChange error type 02/215402/1
Minje Ahn [Tue, 8 Oct 2019 02:07:42 +0000 (11:07 +0900)]
Change error type

Use MS_MEDIA_ERR_DB_INTERNAL instead MS_MEDIA_ERR_DB_UPDATE_FAIL for reduce error type

Change-Id: I1c310405e3ed6e859ed3b5d1667a047cc7b1bace
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove SQLITE_PERM check 96/215296/1 accepted/tizen/unified/20191007.234915 submit/tizen/20191007.065948
Minje Ahn [Mon, 7 Oct 2019 00:20:45 +0000 (09:20 +0900)]
Remove SQLITE_PERM check

Change-Id: If1d721cc0bd4adb5e6a9282d6d8eec435ccbcb99
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoDelete meaningless error types 18/215118/1 accepted/tizen/unified/20191004.003604 submit/tizen/20191002.013808
Minje Ahn [Tue, 1 Oct 2019 23:28:00 +0000 (08:28 +0900)]
Delete meaningless error types

Change-Id: I6dcf712db60f687000df22004863cecda168dabc
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoFix bug (TFDF-4925) 33/213933/1 accepted/tizen/unified/20190917.041350 submit/tizen/20190917.004518
Minje Ahn [Tue, 17 Sep 2019 00:25:34 +0000 (09:25 +0900)]
Fix bug (TFDF-4925)

Call the upgrade function twice.

Change-Id: Idad1ea30340cd89174b628c9977b4e3a1b597aed
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUpdate code of checking parameter 79/213879/1 accepted/tizen/unified/20190916.111559 submit/tizen/20190916.065445
hj kim [Mon, 16 Sep 2019 06:53:38 +0000 (15:53 +0900)]
Update code of checking parameter

Change-Id: Iecb2fc0c8ba5a2f19aa0bab41f1982e208f825ad

4 years agoFix Coverity issues 71/213871/2
hj kim [Mon, 16 Sep 2019 06:03:05 +0000 (15:03 +0900)]
Fix Coverity issues

Change-Id: I29e746aaac9510defc329782c6c8e1751ed3ddb8

4 years agoModify g_array in media_svc_update_item_meta 30/213730/1
Minje Ahn [Wed, 11 Sep 2019 00:30:33 +0000 (09:30 +0900)]
Modify g_array in media_svc_update_item_meta

Change-Id: Ic729f88232bc244e80093797847eb14a7a802551
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoUpdate __media_svc_db_upgrade to reduce Cyclomatic Complexity 10/213610/2 accepted/tizen/unified/20190910.043230 submit/tizen/20190910.020543
hj kim [Mon, 9 Sep 2019 06:57:20 +0000 (15:57 +0900)]
Update __media_svc_db_upgrade to reduce Cyclomatic Complexity

Change-Id: I80e294187da2b11acc4eb9efb0194392b17b908b

4 years agoUpdate _media_svc_extract_image_metadata to reduce Cyclomatic Complexity 01/213601/3
hj kim [Mon, 9 Sep 2019 06:14:43 +0000 (15:14 +0900)]
Update _media_svc_extract_image_metadata to reduce Cyclomatic Complexity

Change-Id: Ifb384a55bc657c17ccbd7044f17a4aba515786d9

4 years agoUpdate _media_svc_create_thumbnail to reduce Cyclomatic Complexity 95/213595/2
hj kim [Mon, 9 Sep 2019 05:44:41 +0000 (14:44 +0900)]
Update _media_svc_create_thumbnail to reduce Cyclomatic Complexity

Change-Id: Ie6bbbffa29083b45a32d6e5bb9b8fedabe7d92de

4 years agoChange GArray to GPtrArray 32/213332/4
Minje Ahn [Wed, 4 Sep 2019 08:33:16 +0000 (17:33 +0900)]
Change GArray to GPtrArray

Change-Id: Ibf280ac4790f0606a37b80a16ddc13a59c7cd53a
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove batch db thread 09/213309/2 accepted/tizen/unified/20190909.010905 submit/tizen/20190905.232826
Minje Ahn [Wed, 4 Sep 2019 06:38:05 +0000 (15:38 +0900)]
Remove batch db thread

Use db update thread instead

Change-Id: Ibe93aca44d2f3954c838221c6a52df1778f0ab38
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoModify the media type classification method 71/213171/2 accepted/tizen/unified/20190904.224439 submit/tizen/20190903.022206
Minje Ahn [Mon, 2 Sep 2019 07:42:49 +0000 (16:42 +0900)]
Modify the media type classification method

if-else to switch-case

Change-Id: I290d966434b5272855d93a37555cbffc9d290b12
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoImprove msc_metadata_update 67/212967/5
Minje Ahn [Thu, 29 Aug 2019 03:09:13 +0000 (12:09 +0900)]
Improve msc_metadata_update

Change-Id: Iee34dfa43a7e77b60a2de0f93a0c01a5d4a26631
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoRemove G_SAFE_FREE 14/213014/2
Minje Ahn [Thu, 29 Aug 2019 08:16:38 +0000 (17:16 +0900)]
Remove G_SAFE_FREE

Change-Id: Icf1728faa7ea6237e56a8c69b675faa59aff0627
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>
4 years agoAdd for upgrade tizen 4.0 to 5.5 22/211922/1 accepted/tizen/unified/20190816.112301 submit/tizen/20190816.014658
Minje Ahn [Mon, 12 Aug 2019 04:49:56 +0000 (13:49 +0900)]
Add for upgrade tizen 4.0 to 5.5

Change-Id: Id1b57ba2df4d045a11ac15b2627552c485348caa
Signed-off-by: Minje Ahn <minje.ahn@samsung.com>