Enable diagnostics for .NET app

In the previous implementation, COMPlus_EnableDiagnostics is set to 0 to avoid creating clr-debug-pipe file.
But, from coreclr 3.1.0, that environment setting also affects the creation of diagnostics socket file.

To enable diagnostics at candidate process, set COMPlus_EnableDiagnostics to 1.

diff --git a/NativeLauncher/launcher/lib/dotnet_launcher.cc b/NativeLauncher/launcher/lib/dotnet_launcher.cc
index d9d14bc..5dc2304 100644 (file)
--- a/NativeLauncher/launcher/lib/dotnet_launcher.cc
+++ b/NativeLauncher/launcher/lib/dotnet_launcher.cc
@@ -380,9 +380,9 @@ int CoreRuntime::initialize(LaunchMode launchMode, bool useDlog, const char* roo
        putenv(const_cast<char *>("UNW_ARM_UNWIND_METHOD=6"));
 #endif // __arm__
 
-       // Disable debug pipes and semaphores creation in case of non-standlone mode
-       if (launchMode == LaunchMode::loader)
-               putenv(const_cast<char *>("COMPlus_EnableDiagnostics=0"));
+       // Enable diagnostics.
+       // clr create clr-debug-pipe-xxx and dotnet-diagnostics-xxx file under /tmp dir.
+       putenv(const_cast<char *>("COMPlus_EnableDiagnostics=1"));
 
        // Write Debug.WriteLine to stderr
        putenv(const_cast<char *>("COMPlus_DebugWriteToStdErr=1"));