d2d-conv-manager: fix svace_2.2 issues 69/104669/1 accepted/tizen/common/20161215.165737 accepted/tizen/mobile/20161215.073957 accepted/tizen/tv/20161215.074015 accepted/tizen/wearable/20161215.074037 submit/tizen/20161215.011749
authorHongkuk, Son <hongkuk.son@samsung.com>
Wed, 14 Dec 2016 04:49:41 +0000 (13:49 +0900)
committerHongkuk Son <hongkuk.son@samsung.com>
Wed, 14 Dec 2016 05:05:46 +0000 (21:05 -0800)
UNINIT.LOCAL_VAR.EX
UNREACHABLE_CODE

Signed-off-by: Hongkuk, Son <hongkuk.son@samsung.com>
Change-Id: Ib354678063945081170e66eba20e58297ace2a5d

daemon/service_provider/RemoteAppControlServiceProvider.cpp

index 059b7fe..3000181 100755 (executable)
@@ -590,10 +590,10 @@ void conv::RemoteAppControlServiceProvider::__iotcon_request_cb(iotcon_resource_
        return;
 
 CATCH:
-       iotcon_attributes_h attributes;
-       iotcon_representation_h responseRep;
+       iotcon_attributes_h attributes = NULL;
+       iotcon_representation_h responseRep = NULL;
        iotcon_representation_create(&responseRep);
-       iotcon_attributes_h responseAttributes;
+       iotcon_attributes_h responseAttributes = NULL;
        iotcon_attributes_create(&responseAttributes);
 
        if (reqRep != NULL) {
@@ -974,10 +974,7 @@ CATCH:
                if (appctl_request_char) {
                        payload.set(NULL, CONV_JSON_APP_CONTROL_REQUEST, appctl_request_char);
                }
-               if (appcontrol_result == IOTCON_ERROR_NONE) {
-                       payload.set(NULL, CONV_JSON_APP_CONTROL_RESULT, resultStr.c_str());
-               }
-               payload.set(NULL, CONV_JSON_APP_CONTROL_RESULT, resultStr.c_str());
+
                result.set(NULL, CONV_JSON_DESCRIPTION, cb_info.requestObj->getDescription());
                result.set(NULL, CONV_JSON_PAYLOAD, payload);