Fix bugs reported by static analyzer 77/189577/1 accepted/tizen_5.0_unified tizen_5.0 accepted/tizen/5.0/unified/20181102.015001 accepted/tizen/unified/20180919.142033 submit/tizen/20180919.090201 submit/tizen_5.0/20181101.000003
authorYu <jiung.yu@samsung.com>
Wed, 19 Sep 2018 01:47:30 +0000 (10:47 +0900)
committerYu <jiung.yu@samsung.com>
Wed, 19 Sep 2018 01:47:46 +0000 (10:47 +0900)
Change-Id: I0907ab7eabfd26acbdd44aea18ad768e9627d651
Signed-off-by: Yu jiung <jiung.yu@samsung.com>
packaging/asp-manager.spec
src/asp-manager.c
src/session/asp-p2p-conn.c
src/tech/asp-tech-p2p.c

index 56c0cd9..f45ec6e 100755 (executable)
@@ -1,6 +1,6 @@
 Name:       asp-manager
 Summary:    ASP(application service platform) manager
-Version:    0.0.32
+Version:    0.0.33
 Release:    1
 Group:      Network & Connectivity/Other
 License:    Apache-2.0
index 30aff54..04d08a7 100755 (executable)
@@ -66,7 +66,8 @@ static void __session_request_cb(gint32 error_code, guint8 *session_mac,
 
        if (info_length != 0) {
                session_info_str = g_try_malloc0(info_length + 1);
-               memcpy(session_info_str, session_info, info_length);
+               if (session_info_str)
+                       memcpy(session_info_str, session_info, info_length);
        }
 
        g_snprintf(session_mac_str, MACSTR_LEN + 1, MACSTR, MAC2STR(session_mac));
index 41ec6e0..bfb4f13 100644 (file)
@@ -108,7 +108,8 @@ void asp_p2p_conn_connect_session(const guint8 *session_mac, guint32 session_id,
        params.network_config = network_config;
        if (info_length != 0) {
                params.session_information = g_try_malloc0(info_length + 1);
-               memcpy(params.session_information, session_info, info_length);
+               if (params.session_information)
+                       memcpy(params.session_information, session_info, info_length);
        }
 
        res = asp_tech_connect_session(ASP_TECH_P2P, &params);
index a9970c6..7d763c0 100755 (executable)
@@ -470,7 +470,8 @@ void asp_tech_p2p_process_session_request(GDBusConnection *connection,
                        info_length = strlen(str);
                        g_free(session_info);
                        session_info = g_try_malloc0(info_length + 1);
-                       memcpy(session_info, str, info_length);
+                       if (session_info)
+                               memcpy(session_info, str, info_length);
                } else {
                                ;/* Do Nothing */
                }