Fix coverity issues

Resource leak: CID-108716, 108555, 77542, 76528

Change-Id: I695f8f4c534a0e2ba70c12b4eba0a6e4ec07cc59
Signed-off-by: Cheoleun Moon <chleun.moon@samsung.com>

diff --git a/packaging/asp-manager.spec b/packaging/asp-manager.spec
index c3144d5..4980947 100755 (executable)
--- a/packaging/asp-manager.spec
+++ b/packaging/asp-manager.spec
@@ -1,6 +1,6 @@
 Name:       asp-manager
 Summary:    ASP(application service platform) manager
-Version:    0.0.27
+Version:    0.0.28
 Release:    1
 Group:      Network & Connectivity/Other
 License:    Apache-2.0

diff --git a/src/asp-manager-gdbus.c b/src/asp-manager-gdbus.c
index eb7550b..57b13c9 100755 (executable)
--- a/src/asp-manager-gdbus.c
+++ b/src/asp-manager-gdbus.c
@@ -1175,7 +1175,6 @@ void asp_manager_gdbus_notify_search_result(guint32 search_id,
                g_variant_builder_add(builder, "{sv}", "instance_name", g_variant_new("s", instance_name));
        if (service_info_map != NULL) {
                g_variant_builder_add(builder, "{sv}", "service_info", __g_hash_table_to_g_variant(service_info_map));
-               g_hash_table_unref(service_info_map);
        }
        g_variant_builder_add(builder, "{sv}", "service_status", g_variant_new("y", service_status));
 

diff --git a/src/session/asp-coordination-protocol.c b/src/session/asp-coordination-protocol.c
index 4358b13..0d85ca3 100644 (file)
--- a/src/session/asp-coordination-protocol.c
+++ b/src/session/asp-coordination-protocol.c
@@ -153,6 +153,7 @@ gboolean asp_coordination_protocol_destroy()
        ret_val = g_socket_close(coordination_protocol_socket, &error);
        g_object_unref(coordination_protocol_socket);
        g_source_destroy(source);
+       g_clear_error(&error);
 
        return ret_val;
 }
@@ -282,6 +283,7 @@ static gboolean asp_coordination_protocol_read_cb(GIOChannel *src,
        }
 
        g_object_unref(read_sock_addr);
+       g_clear_error(&error);
 
        return TRUE;
 }

diff --git a/src/tech/asp-tech-infra.c b/src/tech/asp-tech-infra.c
index 67c3e90..5f0d3a4 100644 (file)
--- a/src/tech/asp-tech-infra.c
+++ b/src/tech/asp-tech-infra.c
@@ -200,6 +200,7 @@ static void _search_result_cb(dnssd_service_state_e service_state,
        event.search_result.service_info = service_info_map;
        asp_manager_event(NULL, ASP_EVENT_SEARCH_RESULT, &event);
 
+       g_hash_table_unref(service_info_map);
        g_free(service_device_name);
        g_free(service_mac);
 }

diff --git a/src/tech/asp-tech-p2p.c b/src/tech/asp-tech-p2p.c
index 6e0999c..b5dde85 100755 (executable)
--- a/src/tech/asp-tech-p2p.c
+++ b/src/tech/asp-tech-p2p.c
@@ -409,7 +409,7 @@ void asp_tech_p2p_process_search_result(GDBusConnection *connection,
 
        g_free(device_name);
        g_free(instance_name);
-       g_hash_table_remove_all(service_info_map);
+       g_hash_table_unref(service_info_map);
        g_variant_iter_free(iter);
 
        __ASP_LOG_FUNC_EXIT__;