Fix wrong condition checking 26/127626/1
authorSangyoon Jang <s89.jang@samsung.com>
Fri, 28 Apr 2017 06:00:29 +0000 (15:00 +0900)
committerSangyoon Jang <s89.jang@samsung.com>
Fri, 28 Apr 2017 06:00:29 +0000 (15:00 +0900)
Change-Id: I7032b82c9ca82efca7362ca77cbf153db55075ed
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
src/pkgmgrinfo_archiveinfo.c

index 0a8c2b8..fef594f 100644 (file)
@@ -91,7 +91,7 @@ API int pkgmgrinfo_archiveinfo_get_pkgid(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->pkgid)) {
+       if (info == NULL || strlen(info->pkgid) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -107,7 +107,7 @@ API int pkgmgrinfo_archiveinfo_get_type(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->pkg_type)) {
+       if (info == NULL || strlen(info->pkg_type) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -123,7 +123,7 @@ API int pkgmgrinfo_archiveinfo_get_version(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->version)) {
+       if (info == NULL || strlen(info->version) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }
@@ -139,7 +139,7 @@ API int pkgmgrinfo_archiveinfo_get_api_version(pkgmgrinfo_archiveinfo_h handle,
        package_manager_pkg_detail_info_t *info =
                (package_manager_pkg_detail_info_t *)handle;
 
-       if (info == NULL || strlen(info->api_version)) {
+       if (info == NULL || strlen(info->api_version) == 0) {
                _LOGE("invalid parameter");
                return PMINFO_R_EINVAL;
        }