Rewrite pkgmgrinfo_pkginfo_compare_pkg/app_cert_info 23/55123/8
authorSangyoon Jang <s89.jang@samsung.com>
Tue, 22 Dec 2015 05:07:35 +0000 (14:07 +0900)
committerSangyoon Jang <s89.jang@samsung.com>
Wed, 23 Dec 2015 05:59:32 +0000 (14:59 +0900)
NOTE: this patch may not working when try to compare local package and
global package, but the local/global cert info db will be unified.
after unifying local/global db, it will work.

Change-Id: I274d6e2a1bf274eac53c65fd471e785a36c4cae1
Signed-off-by: Sangyoon Jang <s89.jang@samsung.com>
src/pkgmgrinfo_certinfo.c

index e273e1e..cb7e9dc 100644 (file)
@@ -41,149 +41,109 @@ typedef struct _pkgmgr_cert_x {
        int cert_id;
 } pkgmgr_cert_x;
 
-static int __cert_cb(void *data, int ncols, char **coltxt, char **colname)
-{
-       pkgmgr_cert_x *info = (pkgmgr_cert_x *)data;
-       int i = 0;
-
-       for(i = 0; i < ncols; i++)
-       {
-               if (strcmp(colname[i], "author_signer_cert") == 0) {
-                       if (coltxt[i])
-                               info->cert_id = atoi(coltxt[i]);
-                       else
-                               info->cert_id = 0;
-               } else if (strcmp(colname[i], "package") == 0) {
-                       if (coltxt[i])
-                               info->pkgid= strdup(coltxt[i]);
-                       else
-                               info->pkgid = NULL;
-               } else
-                       continue;
-       }
-       return 0;
-}
-
-static int __validate_cb(void *data, int ncols, char **coltxt, char **colname)
+API int pkgmgrinfo_pkginfo_create_certinfo(pkgmgrinfo_certinfo_h *handle)
 {
-       int *p = (int*)data;
-       *p = atoi(coltxt[0]);
-       return 0;
+       retvm_if(handle == NULL, PMINFO_R_EINVAL, "Argument supplied to hold return value is NULL\n");
+       pkgmgr_certinfo_x *certinfo = NULL;
+       certinfo = calloc(1, sizeof(pkgmgr_certinfo_x));
+       *handle = NULL;
+       retvm_if(certinfo == NULL, PMINFO_R_ERROR, "Malloc Failed\n");
+       *handle = (void *)certinfo;
+       return PMINFO_R_OK;
 }
 
-API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id, const char *rhs_package_id, uid_t uid, pkgmgrinfo_cert_compare_result_type_e *compare_result)
+static int _pkginfo_compare_certinfo(sqlite3 *db, const char *l_pkgid,
+               const char *r_pkgid,
+               pkgmgrinfo_cert_compare_result_type_e *result)
 {
-       int ret = PMINFO_R_OK;
-       char query[MAX_QUERY_LEN] = {'\0'};
-       char *error_message = NULL;
-       sqlite3_stmt *stmt = NULL;
-       char *lhs_certinfo = NULL;
-       char *rhs_certinfo = NULL;
-       int lcert;
-       int rcert;
-       int exist;
+       static const char query[] =
+               "SELECT author_signer_cert FROM package_cert_info "
+               "WHERE package=?";
+       int ret;
+       sqlite3_stmt *stmt;
+       const char *pkgid[2];
+       int certid[2] = {-1, };
        int i;
-       int is_global = 0;
-       *compare_result = PMINFO_CERT_COMPARE_ERROR;
-
-       retvm_if(lhs_package_id == NULL, PMINFO_R_EINVAL, "lhs package ID is NULL");
-       retvm_if(rhs_package_id == NULL, PMINFO_R_EINVAL, "rhs package ID is NULL");
-       retvm_if(compare_result == NULL, PMINFO_R_EINVAL, "Argument supplied to hold return value is NULL");
 
-       ret = __open_cert_db(uid, true);
-       if (ret != 0) {
-               ret = PMINFO_R_ERROR;
-               goto err;
-       }
-       _check_create_cert_db(GET_DB(cert_db));
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_cert_info where package='%s')", lhs_package_id);
-       if (SQLITE_OK !=
-           sqlite3_exec(GET_DB(cert_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                      error_message);
-               ret = PMINFO_R_ERROR;
-               goto err;
-       }
-       lcert = exist;
-
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_cert_info where package='%s')", rhs_package_id);
-       if (SQLITE_OK !=
-               sqlite3_exec(GET_DB(cert_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                          error_message);
-               ret = PMINFO_R_ERROR;
-               goto err;
+       ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL);
+       if (ret != SQLITE_OK) {
+               _LOGE("prepare error: %s", sqlite3_errmsg(db));
+               return PMINFO_R_ERROR;
        }
-       rcert = exist;
 
-       if (uid == GLOBAL_USER || uid == ROOT_UID) {
-               snprintf(query, MAX_QUERY_LEN, "select cert_info from package_cert_index_info where cert_id=(select author_signer_cert from package_cert_info where package=?)");
-               is_global = 1;
-       } else
-               snprintf(query, MAX_QUERY_LEN, "select cert_info from package_cert_index_info where cert_id=(select author_signer_cert from package_cert_info where package=?) and for_all_users=(select for_all_users from package_cert_info where package=?)");
-       if (SQLITE_OK != sqlite3_prepare_v2(GET_DB(cert_db), query, strlen(query), &stmt, NULL)) {
-               _LOGE("sqlite3_prepare_v2 error: %s", sqlite3_errmsg(GET_DB(cert_db)));
-               ret = PMINFO_R_ERROR;
-               goto err;
-       }
+       pkgid[0] = l_pkgid;
+       pkgid[1] = r_pkgid;
+       for (i = 0; i < 2; i++) {
+               ret = sqlite3_bind_text(stmt, 1, pkgid[i], -1, SQLITE_STATIC);
+               if (ret != SQLITE_OK) {
+                       _LOGE("bind error: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
+               }
 
-       for (i = 1; i <= 2 - is_global; i++) {
-               if (SQLITE_OK != sqlite3_bind_text(stmt, i, lhs_package_id, -1, SQLITE_STATIC)) {
-                       _LOGE("sqlite3_bind_text error: %s", sqlite3_errmsg(GET_DB(cert_db)));
-                       ret = PMINFO_R_ERROR;
-                       goto err;
+               ret = sqlite3_step(stmt);
+               if (ret == SQLITE_ROW) {
+                       _save_column_int(stmt, 0, &certid[i]);
+               } else if (ret != SQLITE_DONE) {
+                       _LOGE("step error: %s", sqlite3_errmsg(db));
+                       sqlite3_finalize(stmt);
+                       return PMINFO_R_ERROR;
                }
-       }
-       if (SQLITE_ROW != sqlite3_step(stmt) || sqlite3_column_text(stmt, 0) == NULL) {
-               _LOGE("sqlite3_step error: %s", sqlite3_errmsg(GET_DB(cert_db)));
-               ret = PMINFO_R_ERROR;
-               goto err;
+
+               sqlite3_reset(stmt);
+               sqlite3_clear_bindings(stmt);
        }
 
-       lhs_certinfo = strdup((const char *)sqlite3_column_text(stmt, 0));
-       sqlite3_reset(stmt);
-       sqlite3_clear_bindings(stmt);
+       if (certid[0] == -1 && certid[1] == -1)
+               *result = PMINFO_CERT_COMPARE_BOTH_NO_CERT;
+       else if (certid[0] == -1)
+               *result = PMINFO_CERT_COMPARE_LHS_NO_CERT;
+       else if (certid[1] == -1)
+               *result = PMINFO_CERT_COMPARE_RHS_NO_CERT;
+       else if (certid[0] == certid[1])
+               *result = PMINFO_CERT_COMPARE_MATCH;
+       else
+               *result = PMINFO_CERT_COMPARE_MISMATCH;
 
-       for (i = 1; i <= 2 - is_global; i++) {
-               if (SQLITE_OK != sqlite3_bind_text(stmt, i, rhs_package_id, -1, SQLITE_STATIC)) {
-                       _LOGE("sqlite3_bind_text error: %s", sqlite3_errmsg(GET_DB(cert_db)));
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-       }
-       if (SQLITE_ROW != sqlite3_step(stmt) || sqlite3_column_text(stmt, 0) == NULL) {
-               _LOGE("sqlite3_step error: %s", sqlite3_errmsg(GET_DB(cert_db)));
-               ret = PMINFO_R_ERROR;
-               goto err;
+       sqlite3_finalize(stmt);
+
+       return PMINFO_R_OK;
+}
+
+API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id,
+               const char *rhs_package_id, uid_t uid,
+               pkgmgrinfo_cert_compare_result_type_e *compare_result)
+{
+       int ret;
+       sqlite3 *db;
+       const char *dbpath;
+
+       if (lhs_package_id == NULL || rhs_package_id == NULL ||
+                       compare_result == NULL) {
+               _LOGE("invalid parameter");
+               return PMINFO_R_EINVAL;
        }
 
-       rhs_certinfo = strdup((const char *)sqlite3_column_text(stmt, 0));
+       dbpath = getUserPkgCertDBPathUID(uid);
+       if (dbpath == NULL)
+               return PMINFO_R_ERROR;
 
-       if ((lcert == 0) || (rcert == 0)) {
-               if ((lcert == 0) && (rcert == 0))
-                       *compare_result = PMINFO_CERT_COMPARE_BOTH_NO_CERT;
-               else if (lcert == 0)
-                       *compare_result = PMINFO_CERT_COMPARE_LHS_NO_CERT;
-               else if (rcert == 0)
-                       *compare_result = PMINFO_CERT_COMPARE_RHS_NO_CERT;
-       } else {
-               if (lhs_certinfo && rhs_certinfo && !strcmp(lhs_certinfo, rhs_certinfo))
-                       *compare_result = PMINFO_CERT_COMPARE_MATCH;
-               else
-                       *compare_result = PMINFO_CERT_COMPARE_MISMATCH;
+       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL);
+       if (ret != SQLITE_OK) {
+               _LOGE("failed to open db: %d", ret);
+               return PMINFO_R_ERROR;
        }
 
-err:
-       if (stmt)
-               sqlite3_finalize(stmt);
-       if (lhs_certinfo)
-               free(lhs_certinfo);
-       if (rhs_certinfo)
-               free(rhs_certinfo);
-       sqlite3_free(error_message);
-       __close_cert_db();
+       if (_pkginfo_compare_certinfo(db, lhs_package_id, rhs_package_id,
+                               compare_result)) {
+               _LOGE("failed to compare certinfo");
+               sqlite3_close_v2(db);
+               return PMINFO_R_ERROR;
+       }
 
-       return ret;
+       sqlite3_close_v2(db);
+
+       return PMINFO_R_OK;
 }
 
 API int pkgmgrinfo_pkginfo_compare_pkg_cert_info(const char *lhs_package_id, const char *rhs_package_id, pkgmgrinfo_cert_compare_result_type_e *compare_result)
@@ -191,231 +151,106 @@ API int pkgmgrinfo_pkginfo_compare_pkg_cert_info(const char *lhs_package_id, con
        return pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(lhs_package_id, rhs_package_id, GLOBAL_USER, compare_result);
 }
 
-API int pkgmgrinfo_pkginfo_compare_app_cert_info(const char *lhs_app_id, const char *rhs_app_id, pkgmgrinfo_cert_compare_result_type_e *compare_result)
+static int _pkginfo_get_pkgid_from_appid(uid_t uid, const char *appid,
+               char **pkgid)
 {
-       int ret = PMINFO_R_OK;
-       char query[MAX_QUERY_LEN] = {'\0'};
-       char *error_message = NULL;
-       pkgmgr_cert_x *info;
-       int exist;
-       char *lpkgid = NULL;
-       char *rpkgid = NULL;
-       const char* user_pkg_parser = getUserPkgParserDBPath();
-
-       retvm_if(lhs_app_id == NULL, PMINFO_R_EINVAL, "lhs app ID is NULL");
-       retvm_if(rhs_app_id == NULL, PMINFO_R_EINVAL, "rhs app ID is NULL");
-       retvm_if(compare_result == NULL, PMINFO_R_EINVAL, "Argument supplied to hold return value is NULL");
-
-       info = (pkgmgr_cert_x *)calloc(1, sizeof(pkgmgr_cert_x));
-       retvm_if(info == NULL, PMINFO_R_ERROR, "Out of Memory!!!");
-
-       ret = db_util_open_with_options(user_pkg_parser, &GET_DB(manifest_db),
-                                       SQLITE_OPEN_READONLY, NULL);
+       static const char query[] =
+               "SELECT package FROM package_app_info WHERE app_id=?";
+       int ret;
+       sqlite3 *db;
+       const char *dbpath;
+       sqlite3_stmt *stmt;
+
+       dbpath = getUserPkgParserDBPathUID(uid);
+       if (dbpath == NULL)
+               return PMINFO_R_ERROR;
+
+       ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL);
        if (ret != SQLITE_OK) {
-               _LOGE("connect db [%s] failed!\n", user_pkg_parser);
-               ret = PMINFO_R_ERROR;
-               goto err;
+               _LOGE("failed to open db: %d", ret);
+               return PMINFO_R_ERROR;
        }
 
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_app_info where app_id='%s')", lhs_app_id);
-       if (SQLITE_OK !=
-           sqlite3_exec(GET_DB(manifest_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                      error_message);
-               ret = PMINFO_R_ERROR;
-               goto err;
+       ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL);
+       if (ret != SQLITE_OK) {
+               _LOGE("prepare error: %s", sqlite3_errmsg(db));
+               sqlite3_close_v2(db);
+               return PMINFO_R_ERROR;
        }
 
-       if (exist == 0) {
-               lpkgid = NULL;
-       } else {
-               snprintf(query, MAX_QUERY_LEN, "select package from package_app_info where app_id='%s' ", lhs_app_id);
-               if (SQLITE_OK !=
-                       sqlite3_exec(GET_DB(manifest_db), query, __cert_cb, (void *)info, &error_message)) {
-                       _LOGE("Don't execute query = %s error message = %s\n", query,
-                                  error_message);
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               lpkgid = strdup(info->pkgid);
-               if (lpkgid == NULL) {
-                       _LOGE("Out of Memory\n");
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               free(info->pkgid);
-               info->pkgid = NULL;
+       ret = sqlite3_bind_text(stmt, 1, appid, -1, SQLITE_STATIC);
+       if (ret != SQLITE_OK) {
+               _LOGE("bind error: %s", sqlite3_errmsg(db));
+               sqlite3_finalize(stmt);
+               sqlite3_close_v2(db);
+               return PMINFO_R_ERROR;
        }
 
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_app_info where app_id='%s')", rhs_app_id);
-       if (SQLITE_OK !=
-           sqlite3_exec(GET_DB(manifest_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                      error_message);
+       ret = sqlite3_step(stmt);
+       if (ret == SQLITE_ROW) {
+               _save_column_str(stmt, 0, (const char **)pkgid);
+               ret = PMINFO_R_OK;
+       } else if (ret == SQLITE_DONE) {
+               _LOGE("cannot find pkgid of app %s", appid);
+               ret = PMINFO_R_ENOENT;
+       } else {
+               _LOGE("step error: %s", sqlite3_errmsg(db));
                ret = PMINFO_R_ERROR;
-               goto err;
        }
 
-       if (exist == 0) {
-               rpkgid = NULL;
-       } else {
-               snprintf(query, MAX_QUERY_LEN, "select package from package_app_info where app_id='%s' ", rhs_app_id);
-               if (SQLITE_OK !=
-                       sqlite3_exec(GET_DB(manifest_db), query, __cert_cb, (void *)info, &error_message)) {
-                       _LOGE("Don't execute query = %s error message = %s\n", query,
-                                  error_message);
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               rpkgid = strdup(info->pkgid);
-               if (rpkgid == NULL) {
-                       _LOGE("Out of Memory\n");
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               free(info->pkgid);
-               info->pkgid = NULL;
-       }
-       ret = pkgmgrinfo_pkginfo_compare_pkg_cert_info(lpkgid, rpkgid, compare_result);
- err:
-       if (error_message)
-               sqlite3_free(error_message);
-       __close_manifest_db();
-       if (info) {
-               if (info->pkgid) {
-                       free(info->pkgid);
-                       info->pkgid = NULL;
-               }
-               free(info);
-               info = NULL;
-       }
-       if (lpkgid) {
-               free(lpkgid);
-               lpkgid = NULL;
-       }
-       if (rpkgid) {
-               free(rpkgid);
-               rpkgid = NULL;
-       }
+       sqlite3_finalize(stmt);
+       sqlite3_close_v2(db);
+
        return ret;
 }
 
-API int pkgmgrinfo_pkginfo_compare_usr_app_cert_info(const char *lhs_app_id, const char *rhs_app_id, uid_t uid, pkgmgrinfo_cert_compare_result_type_e *compare_result)
+API int pkgmgrinfo_pkginfo_compare_usr_app_cert_info(const char *lhs_app_id,
+               const char *rhs_app_id, uid_t uid,
+               pkgmgrinfo_cert_compare_result_type_e *compare_result)
 {
-       int ret = PMINFO_R_OK;
-       char query[MAX_QUERY_LEN] = {'\0'};
-       char *error_message = NULL;
-       pkgmgr_cert_x *info;
-       int exist;
-       char *lpkgid = NULL;
-       char *rpkgid = NULL;
-
-       retvm_if(lhs_app_id == NULL, PMINFO_R_EINVAL, "lhs app ID is NULL");
-       retvm_if(rhs_app_id == NULL, PMINFO_R_EINVAL, "rhs app ID is NULL");
-       retvm_if(compare_result == NULL, PMINFO_R_EINVAL, "Argument supplied to hold return value is NULL");
-
-       info = (pkgmgr_cert_x *)calloc(1, sizeof(pkgmgr_cert_x));
-       retvm_if(info == NULL, PMINFO_R_ERROR, "Out of Memory!!!");
-
-       ret = __open_manifest_db(uid, true);
-       if (ret != SQLITE_OK) {
-               _LOGE("connect db [%s] failed!\n", getUserPkgParserDBPathUID(uid));
-               ret = PMINFO_R_ERROR;
-               goto err;
-       }
+       int ret;
+       char *l_pkgid = NULL;
+       char *r_pkgid = NULL;
 
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_app_info where app_id='%s')", lhs_app_id);
-       if (SQLITE_OK !=
-           sqlite3_exec(GET_DB(manifest_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                      error_message);
-               ret = PMINFO_R_ERROR;
-               goto err;
+       if (lhs_app_id == NULL || rhs_app_id == NULL ||
+                       compare_result == NULL) {
+               _LOGE("invalid parameter");
+               return PMINFO_R_EINVAL;
        }
 
-       if (exist == 0) {
-               lpkgid = NULL;
-       } else {
-               snprintf(query, MAX_QUERY_LEN, "select package from package_app_info where app_id='%s' ", lhs_app_id);
-               if (SQLITE_OK !=
-                       sqlite3_exec(GET_DB(manifest_db), query, __cert_cb, (void *)info, &error_message)) {
-                       _LOGE("Don't execute query = %s error message = %s\n", query,
-                                  error_message);
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               lpkgid = strdup(info->pkgid);
-               if (lpkgid == NULL) {
-                       _LOGE("Out of Memory\n");
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               free(info->pkgid);
-               info->pkgid = NULL;
-       }
+       ret = _pkginfo_get_pkgid_from_appid(uid, lhs_app_id, &l_pkgid);
+       if (ret == PMINFO_R_ENOENT && uid != GLOBAL_USER)
+               ret = _pkginfo_get_pkgid_from_appid(GLOBAL_USER, lhs_app_id,
+                               &l_pkgid);
 
-       snprintf(query, MAX_QUERY_LEN, "select exists(select * from package_app_info where app_id='%s')", rhs_app_id);
-       if (SQLITE_OK !=
-           sqlite3_exec(GET_DB(manifest_db), query, __validate_cb, (void *)&exist, &error_message)) {
-               _LOGE("Don't execute query = %s error message = %s\n", query,
-                      error_message);
-               ret = PMINFO_R_ERROR;
-               goto err;
-       }
+       if (ret != PMINFO_R_OK)
+               return ret;
 
-       if (exist == 0) {
-               rpkgid = NULL;
-       } else {
-               snprintf(query, MAX_QUERY_LEN, "select package from package_app_info where app_id='%s' ", rhs_app_id);
-               if (SQLITE_OK !=
-                       sqlite3_exec(GET_DB(manifest_db), query, __cert_cb, (void *)info, &error_message)) {
-                       _LOGE("Don't execute query = %s error message = %s\n", query,
-                                  error_message);
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               rpkgid = strdup(info->pkgid);
-               if (rpkgid == NULL) {
-                       _LOGE("Out of Memory\n");
-                       ret = PMINFO_R_ERROR;
-                       goto err;
-               }
-               free(info->pkgid);
-               info->pkgid = NULL;
-       }
-       ret = pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(lpkgid, rpkgid, uid, compare_result);
- err:
-       if (error_message)
-               sqlite3_free(error_message);
-       __close_manifest_db();
-       if (info) {
-               if (info->pkgid) {
-                       free(info->pkgid);
-                       info->pkgid = NULL;
-               }
-               free(info);
-               info = NULL;
-       }
-       if (lpkgid) {
-               free(lpkgid);
-               lpkgid = NULL;
-       }
-       if (rpkgid) {
-               free(rpkgid);
-               rpkgid = NULL;
+       ret = _pkginfo_get_pkgid_from_appid(uid, rhs_app_id, &r_pkgid);
+       if (ret == PMINFO_R_ENOENT && uid != GLOBAL_USER)
+               ret = _pkginfo_get_pkgid_from_appid(GLOBAL_USER, rhs_app_id,
+                               &r_pkgid);
+
+       if (ret != PMINFO_R_OK) {
+               free(l_pkgid);
+               return ret;
        }
+
+       ret = pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(l_pkgid, r_pkgid,
+                       uid, compare_result);
+
+       free(l_pkgid);
+       free(r_pkgid);
+
        return ret;
 }
 
-API int pkgmgrinfo_pkginfo_create_certinfo(pkgmgrinfo_certinfo_h *handle)
+API int pkgmgrinfo_pkginfo_compare_app_cert_info(const char *lhs_app_id,
+               const char *rhs_app_id,
+               pkgmgrinfo_cert_compare_result_type_e *compare_result)
 {
-       retvm_if(handle == NULL, PMINFO_R_EINVAL, "Argument supplied to hold return value is NULL\n");
-       pkgmgr_certinfo_x *certinfo = NULL;
-       certinfo = calloc(1, sizeof(pkgmgr_certinfo_x));
-       *handle = NULL;
-       retvm_if(certinfo == NULL, PMINFO_R_ERROR, "Malloc Failed\n");
-       *handle = (void *)certinfo;
-       return PMINFO_R_OK;
+       return pkgmgrinfo_pkginfo_compare_usr_app_cert_info(lhs_app_id,
+                       rhs_app_id, GLOBAL_USER, compare_result);
 }
 
 static int _pkginfo_get_cert(sqlite3 *db, int cert_id[],