Fix pkginfo/appinfo

- Fix return value.
- Add invalid argument log.

Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>

diff --git a/src/appinfo_internal.c b/src/appinfo_internal.c
index b4c5b32..f16785c 100644 (file)
--- a/src/appinfo_internal.c
+++ b/src/appinfo_internal.c
@@ -663,7 +663,7 @@ API int appinfo_internal_filter_get_list(sqlite3 *db,
   int ret;
 
   if (db == NULL || filter == NULL || appinfo_list == NULL) {
-    // TODO: add log
+    LOGE("Invalid argument");
     return PMINFO_R_EINVAL;
   }
 

diff --git a/src/pkginfo_internal.c b/src/pkginfo_internal.c
index 0feda4f..4b5dace 100644 (file)
--- a/src/pkginfo_internal.c
+++ b/src/pkginfo_internal.c
@@ -626,7 +626,7 @@ API int pkginfo_internal_filter_get_list(
        int ret;
 
        if (filter == NULL || pkginfo_list == NULL) {
-               // TODO: print error log
+               LOGE("Invalid argument");
                return PMINFO_R_EINVAL;
        }
 
@@ -636,7 +636,7 @@ API int pkginfo_internal_filter_get_list(
                ret = _pkginfo_get_packages(db, GLOBAL_USER, locale, filter,
                                PMINFO_PKGINFO_GET_ALL, pkginfo_list);
 
-       return PMINFO_R_OK;
+       return ret;
 }
 
 API int get_query_result(sqlite3 *db, const char *query,