Remove check ucol_strength_value == UCOL_PRIMARY 79/100379/1
authorMyoungJune Park <mj2004.park@samsung.com>
Mon, 28 Nov 2016 04:18:50 +0000 (13:18 +0900)
committerMyoungJune Park <mj2004.park@samsung.com>
Mon, 28 Nov 2016 04:19:05 +0000 (13:19 +0900)
In case UCOL_PRIMARY = 0, the if-statement get out of its body.
it's buggy.

Change-Id: I0e61e21741da19f0b1e1ca1d0badedd5c993591a
Signed-off-by: MyoungJune Park <mj2004.park@samsung.com>
collation.c

index a09925a..799db55 100644 (file)
@@ -424,14 +424,12 @@ static int __db_util_collation_create(sqlite3* db_handle, char* locale, char* co
        }
 #endif
 
-       if(ucol_strength_value == UCOL_PRIMARY) {
-               icu_symbol.icu_ucol_setStrength(ucol, ucol_strength_value);
-               if (U_FAILURE(status)) {
-                       DB_UTIL_TRACE_ERROR("ucol_setStrength fail : %d \n", status);
-                       return DB_UTIL_ERR_ICU;
-               } else {
-                       DB_UTIL_TRACE_DEBUG("ucol_setStrength success \n");
-               }
+       icu_symbol.icu_ucol_setStrength(ucol, ucol_strength_value);
+       if (U_FAILURE(status)) {
+               DB_UTIL_TRACE_ERROR("ucol_setStrength fail : %d \n", status);
+               return DB_UTIL_ERR_ICU;
+       } else {
+               DB_UTIL_TRACE_DEBUG("ucol_setStrength success \n");
        }
 
        if(utf_type == DB_UTIL_COL_UTF8) {