platform/core/appfw/aul-1.git
9 months agoAdd a new internal function for getting proc group info 46/296246/7
Hwankyu Jhun [Mon, 24 Jul 2023 07:53:05 +0000 (16:53 +0900)]
Add a new internal function for getting proc group info

aul_proc_group_foreach() is added to retrieves the process group information.

Adds:
 - aul_proc_group_info_get_leader_pid()
 - aul_proc_group_info_get_sub_pids()
 - aul_proc_group_info_destroy()
 - aul_proc_group_foreach()
 - aul_proc_group_get()

Change-Id: I07f699088cf4c6e4eaf251df5df8153e2d8e1ea4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
9 months agoRelease version 0.57.5 72/296172/1 accepted/tizen/unified/20230725.012955
Hwankyu Jhun [Fri, 21 Jul 2023 02:02:27 +0000 (11:02 +0900)]
Release version 0.57.5

Changes:
 - Modify error code of aul socket

Change-Id: Ief046450219bc70895c876b07dab686bd86f9985
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
9 months agoModify error code of aul socket 70/296170/1
Hwankyu Jhun [Fri, 21 Jul 2023 01:39:14 +0000 (10:39 +0900)]
Modify error code of aul socket

When the amd socket is not ready, the errno value is ENOENT.
After calling aul_error_convert() function, the error is changed to AUL_R_ENOAPP.
It means the application is not found error. The error should be AUL_E_ECOMM.
This patch changes the error code to -ECOMMM.

Change-Id: Ic6d66d85bb4e37e41366a40bbe2abc1980b98dee
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoRelease version 0.57.4 72/295372/1 accepted/tizen/unified/20230710.013107
Hwankyu Jhun [Thu, 6 Jul 2023 07:09:32 +0000 (16:09 +0900)]
Release version 0.57.4

Changes:
 - Fix bugs about boot sequence parser plugin

Change-Id: Id472a8961ac1103b7672fcab699383897c60911d
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoFix bugs about boot sequence parser plugin 69/295369/1
Hwankyu Jhun [Thu, 6 Jul 2023 06:57:18 +0000 (15:57 +0900)]
Fix bugs about boot sequence parser plugin

The condition of if statements are wrong. If the value is not 'true' or 'false',
the parser plugin should set the default value.

Change-Id: I41b44aa90779d4bc74711d955ce9fcdea03264a1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoRelease version 0.57.3 44/295144/1 accepted/tizen_unified_dev accepted/tizen/unified/20230705.063716 accepted/tizen/unified/dev/20230726.115720
Hwankyu Jhun [Mon, 3 Jul 2023 08:29:08 +0000 (08:29 +0000)]
Release version 0.57.3

Changes:
 - Fixed the build error using gcc 13

Change-Id: I7881b500eb9aa71b9c00b69d79276d943a28e686
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoFixed the build error using gcc 13 31/295131/1
Hwankyu Jhun [Mon, 3 Jul 2023 06:57:56 +0000 (06:57 +0000)]
Fixed the build error using gcc 13

- Change 'requires' variable to 'requires_dep'
- Remove unnecessary std::move call

Change-Id: Ic729513e31934da69f93cd7537a212f435bfbd5c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoRelease version 0.57.2 73/294673/1 accepted/tizen/unified/20230623.160708
Hwankyu Jhun [Fri, 23 Jun 2023 01:27:38 +0000 (01:27 +0000)]
Release version 0.57.2

Changes:
 - Ssparate the registration from the constructor

Change-Id: Id46a9b1b46cba2615ad97fa414d55fb429d28022
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoSsparate the registration from the constructor 71/294671/2
Hwankyu Jhun [Thu, 22 Jun 2023 23:55:34 +0000 (23:55 +0000)]
Ssparate the registration from the constructor

To prevent segmantation fault issue, this patch separates the app com
registration from the app event constructor.
If the main thread accesses the resource of the derived class when
calling the constructor of the base class in the sub thread,
the segmentation fault issue is occurred as below:

--------------------------------------------------------------------------------
 Thread 33 (LWP 4401):
 #0  0xb5368646 in bundle_free (b=0xabfb0270)
 #1  0xb5369538 in tizen_base::Bundle::~Bundle
 #2  0xb53c9c1e in (anonymous namespace)::AppComCreate
 #3  0xb53c9df8 in aul_app_com_create_async
 #4  0xb53a1630 in aul::AppEvent::AppEvent
 #5  0xb53a17ae in (anonymous namespace)::AppEventStub::AppEventStub

 Thread 1 (LWP 4189):
 #0  0xb5398b74 in aul::AppEvent::OnAppStatusCb
 #1  0xb53c6bd8 in (anonymous namespace)::AppComConnection::Invoke
--------------------------------------------------------------------------------

Change-Id: I045046f64c1f33dcb4ada22ebbc21cffe97b86c7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoRelease version 0.57.1 53/294553/1
Hwankyu Jhun [Wed, 21 Jun 2023 06:01:00 +0000 (06:01 +0000)]
Release version 0.57.1

Changes:
 - Fix a static analysis issue
 - Fix wrong gsource deletion

Change-Id: I2e07d7b49ca686b3178cd2759afe7e292e81b7b2
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoFix wrong gsource deletion 26/294526/1
Hwankyu Jhun [Tue, 20 Jun 2023 23:49:54 +0000 (23:49 +0000)]
Fix wrong gsource deletion

While terminating the worker thread, the worker thread tries to remove
the anr timer source. In this time, the g_source_remove() was called.
It makes an error. This patch uses the g_source_destroy() instead of
the g_source_remove(). Before calling the g_source_destroy(), the worker
finds the source using the source id with the GMainContext.

Change-Id: Iee25a57b0b9036d028c0974187f013eb3e99b864
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoFix a static analysis issue 77/294477/2
Changgyu Choi [Tue, 20 Jun 2023 04:24:48 +0000 (13:24 +0900)]
Fix a static analysis issue

Changes:
 - Adds checking whether root is nullptr or not.

Change-Id: I694e8f0f696e9c4d4097adc876e7f868988458c8
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
10 months agoRelease version 0.57.0 36/294436/1 accepted/tizen/unified/20230621.023252
Changgyu Choi [Mon, 19 Jun 2023 08:07:41 +0000 (17:07 +0900)]
Release version 0.57.0

Changes:
 - Add a new internal API

Change-Id: I6b7f53f63715849239c0d36dff10bb053579edf6
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
10 months agoAdd a new internal API 46/294246/8
Changgyu Choi [Fri, 16 Jun 2023 04:09:55 +0000 (13:09 +0900)]
Add a new internal API

This is for receiving app dead event with exit status.

Adds:
 - aul_listen_app_dead_signal_v2()

Change-Id: I29e1614c63d71ee35e31ca66b3ac9930e900b48c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
10 months agoRelease version 0.56.2 28/294028/1 accepted/tizen/unified/20230613.170812
Hwankyu Jhun [Mon, 12 Jun 2023 02:05:08 +0000 (02:05 +0000)]
Release version 0.56.2

Changes:
 - Send ping before adding the watchdog timer

Change-Id: I218568dd36777d9d338e75fac819ee804b5def4c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
10 months agoSend ping before adding the watchdog timer 25/294025/1
Hwankyu Jhun [Mon, 12 Jun 2023 01:35:56 +0000 (01:35 +0000)]
Send ping before adding the watchdog timer

Before adding the watchdog timer, AUL library sends the ping request to
AMD to notify.

Change-Id: Ieeabfcb88848e428e7b9a94c3f3b66fa93415fbd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoRelease version 0.56.1 93/293793/1 accepted/tizen/unified/20230606.140923
Hwankyu Jhun [Mon, 5 Jun 2023 06:33:05 +0000 (06:33 +0000)]
Release version 0.56.1

Changes:
 - Move function definition to aul header

Change-Id: Ia11582c901901655fb0c297e05afe0ae96d0d15b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoMove function definition to aul header 92/293792/1
Hwankyu Jhun [Mon, 5 Jun 2023 06:16:16 +0000 (06:16 +0000)]
Move function definition to aul header

To export the function, the aul_send_launch_request_for_uid() function
is moved to the aul.h file.

Change-Id: I2808d3f3b445cac770a1aec040b0a9c324a2c96c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoRelease version 0.56.0 71/293371/1 accepted/tizen/unified/20230601.162949
Hwankyu Jhun [Thu, 25 May 2023 04:48:15 +0000 (04:48 +0000)]
Release version 0.56.0

Changes:
 - Modify aul_rpc_port_usr_exist() function
 - Change tizen version from 7.5 to 8.0
 - Modify CPU inheritance feature
 - Add new internal APIs

Change-Id: Ifcc9639e8db69e2d963456a5a63f863d4bc15b9f
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoAdd new internal APIs 81/293281/9
Hwankyu Jhun [Tue, 23 May 2023 23:31:27 +0000 (23:31 +0000)]
Add new internal APIs

Adds:
 - aul_app_get_appid_bypid_async()
 - aul_terminate_pid_async_v2()
 - aul_terminate_app_async()
 - aul_kill_pid_async()

Change-Id: I1b7eafd0044fce8cfea8dbab4ecb01e6b715509b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoModify CPU inheritance feature 99/292899/1
Hwankyu Jhun [Wed, 17 May 2023 00:15:34 +0000 (00:15 +0000)]
Modify CPU inheritance feature

If the request is APP_SEND_LAUNCH_REQUEST or APP_SEND_RESUME_REQUEST,
the cpu inheritance should continue until the result event is received.
This patch separates the cpu inheritance class from the aul sock code.
The class is added to the ErrorInfo to inherit the CPU boosting.

Change-Id: Ife5c6a07957af7c8fbcbda51701b150b656a6c56
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
11 months agoChange tizen version from 7.5 to 8.0 53/292853/1
Changgyu Choi [Tue, 16 May 2023 01:51:41 +0000 (10:51 +0900)]
Change tizen version from 7.5 to 8.0

Changes:
 - AUL_K_SOCKET_TIMEOUT
 - AUL_K_MOUNT_RES_PKGIDS
 - AUL_K_HINT_SCREEN_POS_X
 - AUL_K_HINT_SCREEN_POS_Y
 - AUL_K_HINT_SCREEN_WIDTH
 - AUL_K_HINT_SCREEN_HEIGHT

Change-Id: I2651ab3c646ce8115ce61307b4feecfd83a5cbc4
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
12 months agoModify aul_rpc_port_usr_exist() function 50/292250/2
Hwankyu Jhun [Tue, 2 May 2023 08:07:47 +0000 (08:07 +0000)]
Modify aul_rpc_port_usr_exist() function

To avoid delay issue, the function uses access() function instead of
IPC with AMD.

Change-Id: Ifa096ad1ff66e09d21e4373dd214707681c38a45
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
12 months agoRelease version 0.55.1 68/291768/1
Hwankyu Jhun [Fri, 21 Apr 2023 04:45:25 +0000 (04:45 +0000)]
Release version 0.55.1

Changes:
 - Fix build error for gcc 12.2.0

Change-Id: Id26e47184c00efcaf22dbb300c5d14418e9003a8
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
12 months agoFix build error for gcc 12.2.0 46/291746/1
Hwankyu Jhun [Fri, 21 Apr 2023 00:36:55 +0000 (00:36 +0000)]
Fix build error for gcc 12.2.0

- Add missing header inclusion

Change-Id: I39433e4fea56e040d17f9bb61c60d3da7ea92da9
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoRelease version 0.55.0 51/290651/1 accepted/tizen/unified/20230331.225108
ilho kim [Thu, 30 Mar 2023 07:20:55 +0000 (16:20 +0900)]
Release version 0.55.0

Changes:
 - Add APIs for getting path related Resource Control

Change-Id: I4670792b770b6c33ae2fdd447a345fb33059c76b
Signed-off-by: ilho kim <ilho159.kim@samsung.com>
13 months agoAdd APIs for getting path related Resource Control 71/290171/4
ilho kim [Tue, 21 Mar 2023 05:35:38 +0000 (14:35 +0900)]
Add APIs for getting path related Resource Control

- add aul_get_app_res_control_allowed_resource_path()
- add aul_get_app_res_control_global_resource_path()

Change-Id: I70ff0a2f98f100ef8198090d4b3ec3f8eb81599f
Signed-off-by: ilho kim <ilho159.kim@samsung.com>
13 months agoRelease version 0.54.5 71/289571/1 accepted/tizen/unified/20230314.093348
Hwankyu Jhun [Fri, 10 Mar 2023 01:01:31 +0000 (01:01 +0000)]
Release version 0.54.5

Changes:
 - Modify aul_app_event_destroy() function

Change-Id: I97a283eab23336c0029c70832fe7231060cd8094
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoModify aul_app_event_destroy() function 67/289567/1
Hwankyu Jhun [Thu, 9 Mar 2023 23:12:15 +0000 (23:12 +0000)]
Modify aul_app_event_destroy() function

If the caller thread ID is equal to the caller process ID,
the function releases the handle immediately. If it's not,
the function uses glib idler to avoid thread safe issues.

Change-Id: Id8272fb15be06459bab153932c4e1c0a9115fbf6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoRelease version 0.54.4 80/289480/1 accepted/tizen/unified/20230310.062636
Hwankyu Jhun [Wed, 8 Mar 2023 23:55:34 +0000 (23:55 +0000)]
Release version 0.54.4

Changes:
 - Modify aul_app_com_leave function

Change-Id: I98fb3ae46ea0e0fe0383ae489813004f80adcc8c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
13 months agoModify aul_app_com_leave function 76/289476/1
Hwankyu Jhun [Wed, 8 Mar 2023 10:15:22 +0000 (10:15 +0000)]
Modify aul_app_com_leave function

Some program goes to the sleep state immediately after calling
the aul_app_com_leave() function. In this case, the main thread of the
process will be blocked. It causes increasing memory usage.
To avoid the issue, the aul_app_com_leave() function sends the
APP_COM_LEAVE command to the amd to deregister the event.

Change-Id: Ic3d27b8c4151955094887fea59ed25cda08d2faf
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
14 months agoRelease version 0.54.3 43/289143/1 accepted/tizen/unified/20230303.162736
Hwankyu Jhun [Thu, 2 Mar 2023 04:31:11 +0000 (04:31 +0000)]
Release version 0.54.3

Changes:
 - Fix typo

Change-Id: I1fb12c2b000e4c0a2f6a5cb63f59fb8c2b5d84fe
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
14 months agoFix typo 42/289142/1
Hwankyu Jhun [Thu, 2 Mar 2023 04:25:28 +0000 (04:25 +0000)]
Fix typo

The header guard should be "__AUL_PROC_GROUP_H__".

Change-Id: Ifc8ef3012e8896ade6765b10c60938549d1344e6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
14 months agoRelease version 0.54.2 39/289139/1 accepted/tizen/unified/20230302.131106
Changgyu Choi [Thu, 2 Mar 2023 03:33:55 +0000 (12:33 +0900)]
Release version 0.54.2

Changes:
 - Fix unittest about APP_COM_LEAVE changes

Change-Id: I80b5e67f0041201f0fcf84b93c5f64cfb25bb124
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
14 months agoFix unittest about APP_COM_LEAVE changes 37/289137/1
Changgyu Choi [Thu, 2 Mar 2023 03:27:17 +0000 (12:27 +0900)]
Fix unittest about APP_COM_LEAVE changes

Change-Id: Ia44bcfe4169248a2d58744147de2f148df5f29e0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
14 months agoRelease version 0.54.1 35/288935/1
Changgyu Choi [Fri, 24 Feb 2023 12:26:58 +0000 (21:26 +0900)]
Release version 0.54.1

Changes:
 - Change APP_COM_LEAVE request to async

Change-Id: Iec314e94f6f2f6890e95267182637f822c68d70f
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
14 months agoChange APP_COM_LEAVE request to async 20/288920/1
Changgyu Choi [Fri, 24 Feb 2023 12:13:41 +0000 (21:13 +0900)]
Change APP_COM_LEAVE request to async

Change-Id: Ide3fa434d17c9f24e16c7ad6d7444752857c8ba0
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
14 months agoRelease version 0.54.0 17/288717/1
Changgyu Choi [Wed, 22 Feb 2023 04:31:49 +0000 (13:31 +0900)]
Release version 0.54.0

Changes:
 - Add get/set window position api
 - Fix static analysis issues

Change-Id: If8c8a774fd35710f5d73b471e3da113f58ce776b
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
14 months agoFix static analysis issues 06/288706/2
Changgyu Choi [Wed, 22 Feb 2023 02:23:37 +0000 (11:23 +0900)]
Fix static analysis issues

DataToBundle() can throw std::invalid_argument exception.

Change-Id: Id3432c0ec0137b2f43bc5bd7fda9bb917e4e4b90
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
15 months agoAdd get/set window position api 20/286920/8
SukhyungKang [Tue, 17 Jan 2023 01:27:08 +0000 (10:27 +0900)]
Add get/set window position api

Change-Id: I34623f70a1c92f498b8e5674d074ed90182d409a
Signed-off-by: SukhyungKang <shine.kang@samsung.com>
15 months agoRelease version 0.53.4 40/287640/1 accepted/tizen/unified/20230206.093821 accepted/tizen/unified/20230206.093936
Hwankyu Jhun [Thu, 2 Feb 2023 01:31:53 +0000 (01:31 +0000)]
Release version 0.53.4

Changes:
 - Fix static analysis issue

Change-Id: Icd7246ccbd7272fdbf4200a4d0b855482ea2b915
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoFix static analysis issue 38/287638/1
Hwankyu Jhun [Thu, 2 Feb 2023 01:24:10 +0000 (01:24 +0000)]
Fix static analysis issue

Type:
 - Wrapper object use after free

Change-Id: I59d1606ec71b4329df15ca41f65d3fe68f4d7522
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoRelease version 0.53.3 76/287276/1 accepted/tizen/unified/20230127.161059
Hwankyu Jhun [Thu, 26 Jan 2023 06:52:46 +0000 (06:52 +0000)]
Release version 0.53.3

Changes:
 - Fix double close issue

Change-Id: I199a895bf6920c491b61a8e2966d6a7facc08c11
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoFix double close issue 73/287273/2
Hwankyu Jhun [Thu, 26 Jan 2023 06:08:56 +0000 (06:08 +0000)]
Fix double close issue

When calling the g_io_channel_unref() function, the socket fd is closed
by the glib. The AUL library has a problem that is a double close issue.
This patch is to fix the issue.

+------------------------------------------------------------------------------+
| [__AUL_WORKER__] close(188)                                                  |
| close backtrace() returned 9 addesses                                        |
| [ 0] close /lib/libinterceptor.so(close+0x4d) [0xb60da72a]                   |
| [ 1] ? /lib/libglib-2.0.so.0(+0x430c00ea) [0xb0a620ea]                       |
| [ 2] g_io_channel_shutdown /lib/libglib-2.0.so.0(g_io_channel_shutdown+0x75) |
|      [0xb0aa49f2]                                                            |
| [ 3] ? /lib/libaul.so.0(+0x43c0df00) [0xae66ff00]                            |
| [ 4] g_list_foreach /lib/libglib-2.0.so.0(g_list_foreach+0x13) [0xb0a99080]  |
| [ 5] g_list_free_full /lib/libglib-2.0.so.0(g_list_free_full+0x9)            |
|      [0xb0a9dc0e]                                                            |
| [ 6] ? /lib/libaul.so.0(+0x43c0e284) [0xae670284]                            |
| [ 7] ? /lib/libglib-2.0.so.0(+0x430dbc42) [0xb0a7dc42]                       |
| [ 8] ? /lib/libpthread.so.0(+0x430174c4) [0xb5d044c4]                        |
+------------------------------------------------------------------------------+
| [__MAIN__] close(188)                                                        |
| close backtrace() returned 13 addesses                                       |
| [ 0] close /lib/libinterceptor.so(close+0x4d) [0xb60da72a]                   |
| [ 1] aul_sock_destroy_server /lib/libaul.so.0(aul_sock_destroy_server+0x2e3) |
|      [0xae67302c]                                                            |
| [ 2] aul_finalize /lib/libaul.so.0(aul_finalize+0x15) [0xae673196]           |
| [ 3] _ZN9tizen_cpp11AppCoreBase11OnTerminateEv                               |
|      /lib/libapp-core-cpp.so.1(_ZN9tizen_cpp11AppCoreBase11OnTerminateEv+0x5)|
| [0xae22d046]                                                           |
| [__MAIN__] EBADF occurs. fd(188)                                             |
+------------------------------------------------------------------------------+

Change-Id: Id465eefae87653d2acb706875732ec176ce95bb1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoRelease version 0.53.2 63/286663/1 accepted/tizen/unified/20230116.060905
Hwankyu Jhun [Wed, 11 Jan 2023 10:30:43 +0000 (10:30 +0000)]
Release version 0.53.2

Changes:
 - Add appsvc alias feature for tv profile
 - Make a cache for getting appsvc alias appid

Change-Id: I1d67168659d5e5f0ad26fa5d7528cad113b15cf2
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoMake a cache for getting appsvc alias appid 59/286659/4
Hwankyu Jhun [Wed, 11 Jan 2023 09:38:04 +0000 (09:38 +0000)]
Make a cache for getting appsvc alias appid

To reduce the file access, the aul library stores the alias info to the memory.

Change-Id: I34d2b66aafe84723ebb7e63d477127a30ba8b60c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoAdd appsvc alias feature for tv profile 56/286656/1
Hwankyu Jhun [Wed, 11 Jan 2023 09:05:45 +0000 (09:05 +0000)]
Add appsvc alias feature for tv profile

If the profile is tv, the library does not check whether the alias appid
exists or not.

Change-Id: I504d6970a334664633a6aff4dee456cee8691653
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoRelease version 0.53.1 31/286631/1 accepted/tizen/unified/20230111.174602
Hwankyu Jhun [Wed, 11 Jan 2023 00:13:08 +0000 (00:13 +0000)]
Release version 0.53.1

Changes:
 - Check process group ID for getting appid and pkgid

Change-Id: I7aac65f0ea4e0309c71ea7d6238bb51a2e297eab
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoCheck process group ID for getting appid and pkgid 30/286630/1
Hwankyu Jhun [Tue, 10 Jan 2023 23:56:50 +0000 (23:56 +0000)]
Check process group ID for getting appid and pkgid

The web engine is running as a child process of the web app.
If the web engine calls AUL APIs, the request is delivered to AMD.
Because, the process ID is not equal to the web app.
After this patch is applied, AUL API checks whether the process group ID
is equal to the process ID or not. Before executing an application,
the child process of the launchpad-process-pool calls the setsid() to
run the process in a new session. In that time, the process group is separated
from the launchpad-process-pool. Checking the process group ID can reduce
the IPC between AMD and the caller process.

Change-Id: I3746046c36328ecacc27c6cda16afbe44c1e1cfd
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
15 months agoRelease version 0.53.0 18/286518/1 accepted/tizen/unified/20230110.164128
Hwankyu Jhun [Mon, 9 Jan 2023 07:40:15 +0000 (07:40 +0000)]
Release version 0.53.0

Changes:
 - Add a new aul key for res-controla

Change-Id: I97b9cdbbb12a2c990a227eddc978dd91c94dbb27
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoAdd a new aul key for res-control 04/284504/4
Sangyoon Jang [Fri, 18 Nov 2022 07:08:21 +0000 (16:08 +0900)]
Add a new aul key for res-control

This key represents resource packages which will be mounted.

Change-Id: I88458ca382781ddc667d95c4cc275a251271c95d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
16 months agoRelease version 0.52.0 89/286289/2 accepted/tizen/unified/20230105.154701
Changgyu Choi [Tue, 3 Jan 2023 06:30:13 +0000 (15:30 +0900)]
Release version 0.52.0

Changes:
 - Apply aul request with timeout

Change-Id: I329135537ad857cee70249edfc170862a0ea00e4
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoMerge "Apply aul request with timeout" into tizen
Changgyu Choi [Tue, 3 Jan 2023 06:25:11 +0000 (06:25 +0000)]
Merge "Apply aul request with timeout" into tizen

16 months agoApply aul request with timeout 07/285307/18
Changgyu Choi [Fri, 9 Dec 2022 02:04:11 +0000 (11:04 +0900)]
Apply aul request with timeout

Some apps want to set aul request timeout.
If there is a timeout value in the bundle, it changes the socket timeout to that value.

Change-Id: Ic8fd03dbce72ebed3ebc669f4ac11e2776eeaa6d
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoRelease version 0.51.0 84/286284/1 accepted/tizen/7.0/unified/20230105.155139 accepted/tizen/unified/20230104.172222
Hwankyu Jhun [Tue, 3 Jan 2023 06:23:20 +0000 (06:23 +0000)]
Release version 0.51.0

Changes:
 - Add new internal functions for candidate processes

Change-Id: Iddf5f004d9c2a8557936918b64c44c3f8e9d49b4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoAdd new internal functions for candidate processes 70/286270/2
Hwankyu Jhun [Tue, 3 Jan 2023 04:43:25 +0000 (04:43 +0000)]
Add new internal functions for candidate processes

To initialize aul worker thread in the loader process,
the aul_launch_worker_init() is added.

Adds:
 - aul_launch_worker_init()
 - aul_launch_worker_fini()

Change-Id: I6d2707f16f7f82a0a98b79369c37b46909746eff
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
16 months agoRelease version 0.50.8 96/286196/1 accepted/tizen/7.0/unified/20230102.132433 accepted/tizen/unified/20230102.132008
Changgyu Choi [Fri, 30 Dec 2022 04:35:51 +0000 (13:35 +0900)]
Release version 0.50.8

Changes:
 - Refactor app_signal.cc
 - Fix static analysis issues

Change-Id: I5f7da94cc8ad9b30e4924e3bee908eb3ebf62d96
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoFix static analysis issues 79/286179/2
Changgyu Choi [Fri, 30 Dec 2022 01:31:04 +0000 (10:31 +0900)]
Fix static analysis issues

To prevent int to size_t casting, this patch changes vec_max_size type
to size_t.

Change-Id: I3655d6e63c4d8b1daf1a3137923b85fb269e664c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoRefactor app_signal.cc 93/286093/6
Changgyu Choi [Tue, 27 Dec 2022 11:12:30 +0000 (20:12 +0900)]
Refactor app_signal.cc

This is for the multi threading environment.
If some sub-threads unsubscribe the event, there is room for problems due to race condition.
This patch is changed to maintain the Event object without destruction after creation.

Change-Id: Ieefca296875c14e33d195d2809bc5134485915a5
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoRelease version 0.50.7 96/285896/1 accepted/tizen/7.0/unified/20221223.170219 accepted/tizen/unified/20221227.170631
Changgyu Choi [Thu, 22 Dec 2022 06:27:06 +0000 (15:27 +0900)]
Release version 0.50.7

Changes:
 - Fix library path for aarch64

Change-Id: I9ec7d8cdd734e0bc26d12dbf2384c0bbe8264fd4
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
16 months agoFix library path for aarch64 84/285884/1
Changgyu Choi [Thu, 22 Dec 2022 05:51:35 +0000 (14:51 +0900)]
Fix library path for aarch64

Change-Id: I3f7f03fc8fb861efab7afdbe02e856962067c8c7
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
17 months agoRelease version 0.50.6 88/284188/1 accepted/tizen/7.0/unified/20221115.022319 accepted/tizen/unified/20221115.022410
Changgyu Choi [Fri, 11 Nov 2022 07:10:27 +0000 (16:10 +0900)]
Release version 0.50.6

Changes:
 - Add AUL_SVC_RET_ETIMEOUT error

Change-Id: I2e1222ed14ead6e333666103cd9287aea6112077
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
17 months agoAdd AUL_SVC_RET_ETIMEOUT error 79/284079/2
Changgyu Choi [Wed, 9 Nov 2022 08:46:59 +0000 (17:46 +0900)]
Add AUL_SVC_RET_ETIMEOUT error

Currently, app_control_send_launch_request() has returned REJECTED error
even though timeout.
After applying this patch, app receive APP_CONTROL_ERROR_TIMED_OUT when
app_control_send_launch_request() occurs time out.

Change-Id: I2b32627cd1c6189d97834d926009720b55e49a6c
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
17 months agoRelease version 0.50.5 99/283999/1 accepted/tizen/7.0/unified/20221109.171217 accepted/tizen/7.0/unified/20221110.061606 accepted/tizen/unified/20221109.171121
Hwankyu Jhun [Tue, 8 Nov 2022 08:21:30 +0000 (08:21 +0000)]
Release version 0.50.5

Changes:
 - Modify sequence number generation

Change-Id: I0c506b25a2b2ffbcfd2295a4ff96507149e8b113
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
17 months agoModify sequence number generation 95/283995/1
Hwankyu Jhun [Tue, 8 Nov 2022 08:02:08 +0000 (08:02 +0000)]
Modify sequence number generation

To avoid duplication of sequence number, AUL uses uuid to generate.

Change-Id: Ic6072e3aa1efeadc0adfdc948b75f1f236e0c2a0
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoRelease version 0.50.4 85/283685/1 accepted/tizen/unified/20221108.163848
Hwankyu Jhun [Wed, 2 Nov 2022 01:54:10 +0000 (01:54 +0000)]
Release version 0.50.4

Changes:
 - Refactor status API
 - Add unit tests for watch control API
 - Add unit tests for launcher service API
 - Refactor watch control API
 - Refactor launcher service API

Change-Id: Ib19ab89b17bed6cc03f6ea4139ef9223d243ad9a
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoRefactor launcher service API 61/283661/1
Hwankyu Jhun [Tue, 1 Nov 2022 05:43:42 +0000 (05:43 +0000)]
Refactor launcher service API

The launcher service API is implemented using C++ language.

Change-Id: I153e79142f1cda1f6a4eb145ab2f1b47f4df9e74
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoRefactor watch control API 48/283648/2
Hwankyu Jhun [Tue, 1 Nov 2022 02:46:43 +0000 (02:46 +0000)]
Refactor watch control API

The watch control API is refactored using C++ language.

Change-Id: I474c034f4998bfdf8483406ba157d3b97dbb4ade
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoAdd unit tests for launcher service API 43/283643/2
Hwankyu Jhun [Tue, 1 Nov 2022 00:40:11 +0000 (00:40 +0000)]
Add unit tests for launcher service API

To refactor launcher service API, unit tests are added.

Change-Id: I2c1604a60e6bfcb380f6d58b52032d756570f7d1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoAdd unit tests for watch control API 19/283619/2
Hwankyu Jhun [Mon, 31 Oct 2022 10:32:41 +0000 (10:32 +0000)]
Add unit tests for watch control API

To refactor watch control API, unit tests are added

Change-Id: If1517e2d70e90f65897165430acbcde010e82a08
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoRefactor status API 27/283127/3
Hwankyu Jhun [Tue, 18 Oct 2022 10:34:23 +0000 (10:34 +0000)]
Refactor status API

The status API is implmented using C++ language.

Change-Id: Ia1930ea1565b7710e266a224f02826486df54bb6
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoRelease version 0.50.3 85/283085/1
Changgyu Choi [Tue, 18 Oct 2022 02:26:07 +0000 (11:26 +0900)]
Release version 0.50.3

Changes:
 - Fix static analysis issues

Change-Id: I50e945c8afd52b439bced253a2627c3267d25d49
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
18 months agoFix static analysis issues 28/283028/1
Changgyu Choi [Mon, 17 Oct 2022 03:10:10 +0000 (12:10 +0900)]
Fix static analysis issues

Change-Id: Ib109973cdd9d97062c9dd3dce7703a513f78fe87
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
19 months agoRelease version 0.50.2 42/282542/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/hotfix/20221116.104958 accepted/tizen/unified/20221006.065329 accepted/tizen/unified/20221006.065404 tizen_7.0_m2_release
Hwankyu Jhun [Wed, 5 Oct 2022 08:31:43 +0000 (08:31 +0000)]
Release version 0.50.2

Changes:
 - Consider 64-bit environment

Change-Id: I379d706592f25a80acf00ec33beeab1bb01b1322
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoConsider 64-bit environment 33/282533/1
Hwankyu Jhun [Wed, 5 Oct 2022 06:44:18 +0000 (06:44 +0000)]
Consider 64-bit environment

The kPathLibAulServer should be changed to /usr/lib64/ if the package is
building for aarch64 or x86_64 architecture.

Change-Id: I997fc4bf9b3d3a16cab53eaba302dd85685ad012
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoRelease version 0.50.1 19/282119/1 accepted/tizen/unified/20220928.144434
Hwankyu Jhun [Tue, 27 Sep 2022 06:55:05 +0000 (06:55 +0000)]
Release version 0.50.1

Changes:
 - Fix static analysis issue
 - Use modified tizen_base::Parcel
 - Fix static analysis issues

Change-Id: I09d83e4cac3eba3b146a9c73e2b8d2e9e49495b1
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoFix static analysis issues 07/282107/2
Hwankyu Jhun [Tue, 27 Sep 2022 06:13:25 +0000 (06:13 +0000)]
Fix static analysis issues

The following issues are fixed:
 - ODR_VIOLATION

Change-Id: I21535974477d97dd9c93eb570870557202d8f897
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoUse modified tizen_base::Parcel 50/281950/2
Hwankyu Jhun [Fri, 23 Sep 2022 10:41:39 +0000 (10:41 +0000)]
Use modified tizen_base::Parcel

To improve the performance of the parcel creation, the implementation of
the Parcel is changed. It uses malloc() instead of std::vector.

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/base/bundle/+/281779/

Change-Id: I19b804a5be94dd814a83a1067f3924e1085ccece
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoFix static analysis issue 81/282081/1
Hwankyu Jhun [Tue, 27 Sep 2022 02:08:15 +0000 (02:08 +0000)]
Fix static analysis issue

This patch fixes 'use after free' case. The bundle instance is moved
using std::move().

Change-Id: I3e00efdb42038c1a324e3a687678829e6a5b3eaa
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoRelease version 0.50.0 19/280919/1 accepted/tizen/unified/20220908.013408
Changgyu Choi [Wed, 7 Sep 2022 00:27:20 +0000 (09:27 +0900)]
Release version 0.50.0

Changes:
 - Add aul_package_pre_event_send()

Change-Id: I0cb9a95fbd6bc446fc693b670ff4efca3d52fc92
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
20 months agoAdd aul_package_pre_event_send() 92/280292/8
Changgyu Choi [Fri, 26 Aug 2022 08:18:39 +0000 (17:18 +0900)]
Add aul_package_pre_event_send()

This api send signal to amd before sending pkg event to listeners.
amd should reload appinfo before some apps that is listening pkg event.

Change-Id: I82b4d8f8a8e5d1a93ee8d1e7aa13f81df34a077d
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
20 months agoRelease version 0.49.8 74/280574/1 accepted/tizen/unified/20220902.020127 submit/tizen/20220901.022344
Hwankyu Jhun [Thu, 1 Sep 2022 01:57:55 +0000 (01:57 +0000)]
Release version 0.49.8

Changes:
 - Check packet header length

Change-Id: Ia193665c94ed60fdc5f041c1277daaeb7280adcc
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoCheck packet header length 69/280569/2
Hwankyu Jhun [Thu, 1 Sep 2022 01:28:50 +0000 (01:28 +0000)]
Check packet header length

To check whether the packet is valid or not, the packet length should be checked.

Change-Id: I64063aa17c61e6fb43f2ad3f544ca79e44dce665
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRelease version 0.49.7 75/280275/1 accepted/tizen/unified/20220830.032659 submit/tizen/20220826.060801
Hwankyu Jhun [Fri, 26 Aug 2022 05:28:25 +0000 (05:28 +0000)]
Release version 0.49.7

Changes:
 - Remove unused API
 - Fix unit tests
 - Add unit tests for status API
 - Refactor app com API
 - Fix metadata-profile.xml

Change-Id: I22484a502f57b4a50ed45fd3a244813759ae2cd7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix metadata-profile.xml 56/280256/2
Hwankyu Jhun [Fri, 26 Aug 2022 01:32:03 +0000 (01:32 +0000)]
Fix metadata-profile.xml

If the published value is 'Y', it means the metadata is opened in officially.

Change-Id: Iaa9e65081fbd5d958cc4d615d01c43ee85134056
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRefactor app com API 79/280179/1
Hwankyu Jhun [Thu, 25 Aug 2022 04:01:49 +0000 (04:01 +0000)]
Refactor app com API

To refactor app com API, unit tests are added.
The app com API is refactored using the AppRequest class.

Change-Id: Ieeafb5f9aeb461dfc38ca06decc943a2c01ce9dc
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoAdd unit tests for status API 26/280126/3
Hwankyu Jhun [Wed, 24 Aug 2022 07:13:11 +0000 (07:13 +0000)]
Add unit tests for status API

To refactor status API, unit tests are added.

Change-Id: I874f9ebc719b11feb30a679076bae59b7dec0bb7
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix unit tests 58/280058/2
Hwankyu Jhun [Tue, 23 Aug 2022 05:25:00 +0000 (05:25 +0000)]
Fix unit tests

The socket option check and the bundle data check are added.

Change-Id: If8a758b4e741a65660e8b267855b4150445a4d43
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRemove unused API 70/280070/1
Hwankyu Jhun [Tue, 23 Aug 2022 06:44:07 +0000 (06:44 +0000)]
Remove unused API

The aul_running_list_update() function is removed. It's not used.

Change-Id: I00c2ef15e3b9028c3bf115b416a6427001bb9557
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRelease version 0.49.6 43/280043/1 accepted/tizen/unified/20220826.001808 submit/tizen/20220823.004739 submit/tizen/20220824.234308
Hwankyu Jhun [Tue, 23 Aug 2022 00:45:14 +0000 (00:45 +0000)]
Release version 0.49.6

Changes:
 - Fix a bug of refactoring complication
 - Fix wrong implementation of pkginfo API

Change-Id: I98955701fd21a02ef614eae8d022c02c1a6fc977
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix wrong implementation of pkginfo API 85/279985/5
Hwankyu Jhun [Mon, 22 Aug 2022 04:07:25 +0000 (04:07 +0000)]
Fix wrong implementation of pkginfo API

The socket option of some requests have to be AUL_SOCK_NONE and AUL_SOCK_BUNDLE.
The application ID that is set to the bundle will be removed while creating
the AppRequest instance. To set the application ID to the bundle properly, we
should use the AppRequest::SetAppId() method.

Change-Id: I43cadc2aa633b8afa55375d2461e69c98467c525
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix a bug of refactoring complication 87/279987/2
Hwankyu Jhun [Mon, 22 Aug 2022 05:11:25 +0000 (05:11 +0000)]
Fix a bug of refactoring complication

The function returns AUL_R_OK when the function call is successful.
The daemon sends the process ID if the request is successful.

Change-Id: If3f167bb9150e03af6fe7c967988e8a6c3b6f561
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRelease version 0.49.5 84/279884/1 accepted/tizen/unified/20220821.211113 submit/tizen/20220819.013532 submit/tizen/20220819.071124
Hwankyu Jhun [Fri, 19 Aug 2022 01:28:37 +0000 (01:28 +0000)]
Release version 0.49.5

Changes:
 - Fix double close issue

Change-Id: I56a7f4a5eedc8e959085896d286c8909e888fcb4
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix double close issue 81/279881/1
Hwankyu Jhun [Fri, 19 Aug 2022 00:48:12 +0000 (00:48 +0000)]
Fix double close issue

When calling g_io_channel_shutdown(), the file descriptor is closed.
Calling the close in the __destroy_client_channel() is not needed.

Change-Id: I443253f29c000adcdae87f74c415b00de75223af
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRelease version 0.49.4 78/279878/1 submit/tizen/20220819.000528
Hwankyu Jhun [Thu, 18 Aug 2022 23:47:16 +0000 (23:47 +0000)]
Release version 0.49.4

Changes:
 - Refactor App Group API

Change-Id: Id1fcdf19161efe25006c373874068d2ba9336058
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRefactor App Group API 32/279632/3
Hwankyu Jhun [Fri, 12 Aug 2022 10:45:39 +0000 (19:45 +0900)]
Refactor App Group API

The app group API is implemented using C++ language.

Change-Id: I8047911920e0c6d3b70582621e2f85abef278c6b
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoRelease version 0.49.3 20/279620/1 accepted/tizen/unified/20220817.153847 submit/tizen/20220812.091125 submit/tizen/20220815.221956
Changgyu Choi [Fri, 12 Aug 2022 09:10:04 +0000 (18:10 +0900)]
Release version 0.49.3

Changes:
 - Fix coding style
 - Add unit tests for App group API
 - Fix wrong exception handling
 - Fix static analysis issues
 - Fix fd leak
 - Restore to remove virtual keywords

Change-Id: I779d9085f5404dff682882836e8d1c82ec9dacb1
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
20 months agoRestore to remove virtual keywords 17/279617/2
Changgyu Choi [Fri, 12 Aug 2022 08:57:06 +0000 (17:57 +0900)]
Restore to remove virtual keywords

Change-Id: Iaaf70682e8f0ff0ab4659d49ecd0d9ed5494616a
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
20 months agoFix fd leak 04/279604/2
Hwankyu Jhun [Fri, 12 Aug 2022 06:57:04 +0000 (15:57 +0900)]
Fix fd leak

When IO error occurs, AUL has to close the file descriptor and release
the io job resource of aul worker.

Change-Id: Ic612531f3a2fa53efa9fe55556b770369731769c
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
20 months agoFix static analysis issues 96/279596/4
Changgyu Choi [Fri, 12 Aug 2022 06:05:38 +0000 (15:05 +0900)]
Fix static analysis issues

Changes:
 - Removes unnecessary virtual keywords.
 - Fix to wrong print errno.
 - Fix dereference case before checking nullptr.
 - Fix to use variable after using std::move().
 - Removes unnecessary const keyword.

Change-Id: I72e4076f9f3ca3a5daef8afe484c021008d39d00
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>