platform/core/appfw/app-installers.git
16 months agoAdd log for debugging 68/285468/3
Sangyoon Jang [Tue, 13 Dec 2022 08:03:11 +0000 (17:03 +0900)]
Add log for debugging

For debug performance issue

Change-Id: If11b670ae8db7f070d2508a6a49527690aa235cf
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
16 months agoFix app2sd library path 82/285882/2
Sangyoon Jang [Thu, 22 Dec 2022 05:48:33 +0000 (14:48 +0900)]
Fix app2sd library path

Use macro instead of hardcoded path.

Change-Id: I23248a2f4681044216633a45543abe23f00c9ff6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
16 months agoChange the file remove to a virtual function in recovery 86/285886/1
Ilho Kim [Thu, 22 Dec 2022 06:00:01 +0000 (15:00 +0900)]
Change the file remove to a virtual function in recovery

Change-Id: I33cf3ba4141c5599dfe44c73a4c13847e16f49e0
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
16 months agoSkip the security registration if it is unnecessary 46/285846/2
Ilho Kim [Fri, 16 Dec 2022 03:06:30 +0000 (12:06 +0900)]
Skip the security registration if it is unnecessary

If recovery occurs due to termination of update
before security registration performed with information
about a new package in the update case
the security registration for the original package is skiped
because it is unnecessary

Change-Id: Ic1ac7f0f4ba213c73d61dd1819f543fb28d0b768
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
16 months agoBlock different type installation with same pkgid 78/285178/2
Ilho Kim [Wed, 7 Dec 2022 08:13:41 +0000 (17:13 +0900)]
Block different type installation with same pkgid

Change-Id: Ia33f3be69f1441b5ec79c0a0d9a5fe9f9eca9062
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
17 months agoRelease version 1.34.22 31/284131/1
Sangyoon Jang [Thu, 10 Nov 2022 07:32:25 +0000 (16:32 +0900)]
Release version 1.34.22

Changes:
 - Fix build error

Change-Id: I7ca4b7964f307d2e75424b20b57b9bc1f3681d6c
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
17 months agoFix build error 30/284130/1
Sangyoon Jang [Thu, 10 Nov 2022 07:25:10 +0000 (16:25 +0900)]
Fix build error

lambda-expression in unevaluated context only available with '-std=c++2a' or '-std=gnu++2a'

Change-Id: I0248a386e0899fb3db9181417106de1edcdddd87
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
17 months agoRelease version 1.34.21 12/284112/1
Sangyoon Jang [Thu, 10 Nov 2022 02:40:35 +0000 (11:40 +0900)]
Release version 1.34.21

Changes:
 - Remove duplicate api call of clear cache memory
 - Merge SmokeTestHelperRunner into BackendInterface
 - Add RunFunc to Subprocess for just executing function
 - Move GetLightUserList() to user_util.h
 - Fix getting light user list

Change-Id: I9547975ff2e971901256ee7ad2abaed7fb0a6824
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
17 months agoFix getting light user list 10/284110/3
Sangyoon Jang [Thu, 10 Nov 2022 01:35:25 +0000 (10:35 +0900)]
Fix getting light user list

Get light user list by subsession directory name instead of using
sessiond API because of performance issue.

Change-Id: I16fdddae01045424cbf10fe87aa08facaa7680dd
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
17 months agoMove GetLightUserList() to user_util.h 09/284109/1
Sangyoon Jang [Thu, 10 Nov 2022 00:34:59 +0000 (09:34 +0900)]
Move GetLightUserList() to user_util.h

Change-Id: Ie58b1fbda5936b4c7172cb09609c0b7290da90df
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
18 months agoAdd RunFunc to Subprocess for just executing function 66/283266/4
Ilho Kim [Fri, 14 Oct 2022 01:15:28 +0000 (10:15 +0900)]
Add RunFunc to Subprocess for just executing function

TestRollbackAfterEachStep function use RunFunc
to make the smoke test's main process lighter

Change-Id: I8ce453645d0581be69847f96b79578492838e07d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
18 months agoMerge SmokeTestHelperRunner into BackendInterface 65/283265/2
Ilho Kim [Thu, 13 Oct 2022 10:19:25 +0000 (19:19 +0900)]
Merge SmokeTestHelperRunner into BackendInterface

Change-Id: I1c3984c0d891d876980dc77f949939f57d42c40c
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
18 months agoRemove duplicate api call of clear cache memory 30/283130/3
Ilho Kim [Tue, 18 Oct 2022 11:20:59 +0000 (20:20 +0900)]
Remove duplicate api call of clear cache memory

After ther installeation is complete
The SendFinish function call the api

Change-Id: I3c912aec2d70c446b934eecf562dff7a86b8860b
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
18 months agoRelease version 1.34.20 62/283162/1
Hwankyu Jhun [Wed, 19 Oct 2022 08:12:10 +0000 (08:12 +0000)]
Release version 1.34.20

Changes:
 - Modify sending AUL signal

Change-Id: Ie8b085d16dd322f782901a44127a26eacfba2f0f
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
18 months agoModify sending AUL signal 42/282942/1
Hwankyu Jhun [Thu, 13 Oct 2022 10:43:10 +0000 (10:43 +0000)]
Modify sending AUL signal

Currently, the installer sends all events to AMD. AMD only needs
'start', 'error' and 'end' events.
This patch modifies sending events.

Change-Id: Ia436b72762dff3c66d7162df830b9bb23509759e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
19 months agoRelease version 1.34.19 46/281946/1 accepted/tizen_7.0_unified_hotfix tizen_7.0_hotfix accepted/tizen/7.0/unified/20221110.060011 accepted/tizen/7.0/unified/hotfix/20221116.104942 accepted/tizen/unified/20220928.020826 tizen_7.0_m2_release
Ilho Kim [Fri, 23 Sep 2022 10:29:41 +0000 (19:29 +0900)]
Release version 1.34.19

Changes:
 - Fix Recovery of ReadonlyUpdateInstall package's update

Change-Id: I3bc59f0439ab3dc98cc7c1ab6311e854f9bef77e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoFix Recovery of ReadonlyUpdateInstall package's update 56/281756/1
Ilho Kim [Wed, 21 Sep 2022 10:35:03 +0000 (19:35 +0900)]
Fix Recovery of ReadonlyUpdateInstall package's update

Fix that the package system attribute is changed
when recovery is performed becuase the installer is terminated during
the update of the ReadonlyUpdateInstalled package

Change-Id: I23d2afb9a73864f0da286bdb430cd792f583b833
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoRelease version 1.34.18 42/281642/1 accepted/tizen/unified/20220921.091809
Sangyoon Jang [Tue, 20 Sep 2022 06:39:12 +0000 (15:39 +0900)]
Release version 1.34.18

Changes:
 - Fix static analysis issue

Change-Id: I8d3cddd146792caedb64488da64517f72bdad54b
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
19 months agoFix static analysis issue 25/281525/1
Sangyoon Jang [Tue, 20 Sep 2022 02:13:15 +0000 (11:13 +0900)]
Fix static analysis issue

Change-Id: I2c7e53e9479bd7d8f121d0eb02a505b24450e211
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
19 months agoRelease version 1.34.17 03/281203/1 accepted/tizen/unified/20220915.173213 accepted/tizen/unified/20220916.022102 accepted/tizen/unified/20220916.022140
Ilho Kim [Wed, 14 Sep 2022 07:17:27 +0000 (16:17 +0900)]
Release version 1.34.17

Changes:
 - Run MountInstall when xml file is not exist
 - Implement recovery of ReadonlyUpdateUninstall
 - Fix RecoverStorageDirectories

Change-Id: Ifbd8b82555211b75c682ba1a103d1ce69617d093
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoFix RecoverStorageDirectories 02/281202/1
Ilho Kim [Wed, 14 Sep 2022 06:44:32 +0000 (15:44 +0900)]
Fix RecoverStorageDirectories

Because security has been registered again during recovery
security registration should also be performed for the shared data paths

Change-Id: Ic0ed4eca2bd0288fdc533ca4c4092344c918daee
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoImplement recovery of ReadonlyUpdateUninstall 59/281159/4
Ilho Kim [Tue, 13 Sep 2022 12:51:59 +0000 (21:51 +0900)]
Implement recovery of ReadonlyUpdateUninstall

Change-Id: Ibf742a8003f5d0148d98845360b15e84c0fcd1f7
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoRun MountInstall when xml file is not exist 54/281054/1
Ilho Kim [Thu, 8 Sep 2022 11:18:28 +0000 (20:18 +0900)]
Run MountInstall when xml file is not exist

Change-Id: If5af96808e4bb5bd37ad92e91adcec237af2e9db
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoRelease version 1.34.16 20/280920/1 accepted/tizen/unified/20220908.013411
Changgyu Choi [Wed, 7 Sep 2022 00:28:23 +0000 (09:28 +0900)]
Release version 1.34.16

Changes:
 - Modify to generate SIGKILL instead of SIGSEGV in StepCrash
 - Add pre sending pkg event to amd

Change-Id: I25f24cd83a7c780458ce42f6f7827624090cb852
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
19 months agoMerge "Add pre sending pkg event to amd" into tizen
Changgyu Choi [Wed, 7 Sep 2022 00:25:41 +0000 (00:25 +0000)]
Merge "Add pre sending pkg event to amd" into tizen

19 months agoAdd pre sending pkg event to amd 93/280293/7
Changgyu Choi [Fri, 26 Aug 2022 08:21:21 +0000 (17:21 +0900)]
Add pre sending pkg event to amd

Requires:
 - https://review.tizen.org/gerrit/c/platform/core/appfw/aul-1/+/280292

Change-Id: I91c1baac158b81ed48cd27ebfab315dc4e794933
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
19 months agoModify to generate SIGKILL instead of SIGSEGV in StepCrash 27/280127/4
Ilho Kim [Wed, 24 Aug 2022 07:12:02 +0000 (16:12 +0900)]
Modify to generate SIGKILL instead of SIGSEGV in StepCrash

When performing the smoke test
many processes are terminated due to SIGSEGV and coredump is generated
this can cause a lot of load on the system, so it is replaced with SIGKILL

Change-Id: I54d8820097ba2c0a48d48d2185f0277b70f993f2
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
19 months agoRelease version 1.34.15 82/280582/1 accepted/tizen/unified/20220905.124722 submit/tizen/20220901.023331
Sangyoon Jang [Thu, 1 Sep 2022 02:29:12 +0000 (11:29 +0900)]
Release version 1.34.15

Changes:
 - Fix validating light user name

Change-Id: Id1fea31f5ea5283d1f2862fb6e53e41492410bc8
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
19 months agoFix validating light user name 73/280573/1
Sangyoon Jang [Thu, 1 Sep 2022 01:56:01 +0000 (10:56 +0900)]
Fix validating light user name

Comparing an array to null is always true.

Change-Id: I095222187dc6bbc9dbf188227265381e589b1005
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
20 months agoRelease version 1.34.14 44/280144/1 accepted/tizen/unified/20220825.135043 submit/tizen/20220824.085933
Ilho Kim [Wed, 24 Aug 2022 08:57:21 +0000 (17:57 +0900)]
Release version 1.34.14

Changes:
 - Add exception handling to StepSignature
 - Implement undo of RemovePerUserStorageDirectories
 - Add parameter to StepRemovePerUserStorageDirectories

Change-Id: I05ec0cfd7c852fedba6427b0adfb1a39fc6f322d
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
20 months agoAdd parameter to StepRemovePerUserStorageDirectories 40/280140/1
Ilho Kim [Tue, 5 Jul 2022 12:24:03 +0000 (21:24 +0900)]
Add parameter to StepRemovePerUserStorageDirectories

This step's undo operation use StepCreateStorageDirectories
and StepCreateStorageDirectories can be execute with additional parameter

Change-Id: I86d80ede3df46985342daaa8e8c8bcbcdaf68083
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
20 months agoImplement undo of RemovePerUserStorageDirectories 39/280139/1
Ilho Kim [Thu, 30 Jun 2022 06:16:28 +0000 (15:16 +0900)]
Implement undo of RemovePerUserStorageDirectories

If the uninstallation is failed after this step,
there is a problem that the user directory remains erased
so recreate the user directories removed by this step

Change-Id: Ic346217ab1cb971645bff44653027e545a430923
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
20 months agoAdd exception handling to StepSignature 25/280125/1
Ilho Kim [Wed, 24 Aug 2022 07:06:17 +0000 (16:06 +0900)]
Add exception handling to StepSignature

If StepSignature's precheck fails, the variable 'signature_' is not initialized

Change-Id: Ie605111e8572e6d7ccf5e8e161fa5e6f29b13dee
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
20 months agoRelease version 1.34.13 06/279306/1 accepted/tizen/unified/20220808.135354 submit/tizen/20220805.083656
Ilho Kim [Fri, 5 Aug 2022 08:33:56 +0000 (17:33 +0900)]
Release version 1.34.13

Changes:
 - Fix error log correctly
 - Clear memory db before sending the finish signal

Change-Id: I39946e21090395a778e20a24d88438fe14733636
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
20 months agoClear memory db before sending the finish signal 86/279286/1
Ilho Kim [Fri, 5 Aug 2022 06:13:12 +0000 (15:13 +0900)]
Clear memory db before sending the finish signal

Because installer can write to db during undo or clear operation
such as UninstallSteps, the client who received the finish signal
may take the wrong package information

Change-Id: I62d674e4b37692fabdee45287c99dce202616b87
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoFix error log correctly 67/278867/3
Ilho Kim [Wed, 27 Jul 2022 06:01:57 +0000 (15:01 +0900)]
Fix error log correctly

Change-Id: Ib17f39cd72f89c170de841563e3074c5594afd66
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoRelease version 1.34.12 08/278008/1 accepted/tizen/unified/20220719.014541 accepted/tizen/unified/20220720.064031 accepted/tizen/unified/20220720.141510 submit/tizen/20220718.045828 submit/tizen/20220718.115742 submit/tizen/20220719.015501 submit/tizen/20220720.014058
Ilho Kim [Mon, 18 Jul 2022 05:08:40 +0000 (14:08 +0900)]
Release version 1.34.12

Changes:
 - Skip default light user when getting light user list

Change-Id: I80bf220a40812840db7215fd6f15d89cce08880f
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoSkip default light user when getting light user list 99/277999/3
Ilho Kim [Mon, 18 Jul 2022 02:43:09 +0000 (11:43 +0900)]
Skip default light user when getting light user list

subsession_get_user_list also returns the empty string
which is the value of the default user, so it should be ignored

Change-Id: I36cd76310fc42ef620eb23592c726eb0c975ec7e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoRelease version 1.34.11 70/277870/1 accepted/tizen/unified/20220715.141246 submit/tizen/20220714.071350
Ilho Kim [Thu, 14 Jul 2022 07:09:35 +0000 (16:09 +0900)]
Release version 1.34.11

Changes:
 - Fix light user directory path

Change-Id: Ibbdd04c4edf4b8be526f71c4e640960149b6f262
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoFix light user directory path 16/277116/4
Ilho Kim [Fri, 1 Jul 2022 01:39:03 +0000 (10:39 +0900)]
Fix light user directory path

Change from "subsessions" to "subsession"

Change-Id: I833940b590955e6f17f1e68faeb6b0070fb0a967
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
21 months agoRelease version 1.34.10 03/277603/1 accepted/tizen/unified/20220712.010752 submit/tizen/20220708.124830
Changgyu Choi [Mon, 11 Jul 2022 04:14:57 +0000 (13:14 +0900)]
Release version 1.34.10

Changes:
 - Apply to change interface of sessiond API

Change-Id: I57a4f40879700433899636afd3d1e1189bbd5912
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
21 months agoApply to change interface of sessiond API 97/277597/1
Changgyu Choi [Mon, 11 Jul 2022 03:45:49 +0000 (12:45 +0900)]
Apply to change interface of sessiond API

Sessiond API changed session_user key to char array.
This patch applies the changes.

Change-Id: I4b7bc3c29578a3319afa5ed0558c7b8803ec2d36
Signed-off-by: Changgyu Choi <changyu.choi@samsung.com>
22 months agoRelease version 1.34.9 06/276306/1 accepted/tizen/unified/20220614.211545 submit/tizen/20220614.081005
Ilho Kim [Tue, 14 Jun 2022 08:04:34 +0000 (17:04 +0900)]
Release version 1.34.9

Changes:
 - Fix StepRecoverChangeOwner

Change-Id: I001df388cc177736c0c0cd96b74ac1fdaf16b87e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
22 months agoFix StepRecoverChangeOwner 04/276304/1
Ilho Kim [Tue, 14 Jun 2022 07:44:48 +0000 (16:44 +0900)]
Fix StepRecoverChangeOwner

To get user's app_rw directory
the parameter uid passed to GetRootAppPath should be user's uid

Change-Id: I1c9a30e1f3989b7b8ff70717c16fbe1c89f714d3
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
22 months agoRelease version 1.34.8 54/275954/1 accepted/tizen/unified/20220608.140113 submit/tizen/20220531.074151
Ilho Kim [Tue, 7 Jun 2022 08:46:09 +0000 (17:46 +0900)]
Release version 1.34.8

Changes:
 - Add mac override capability to package recovery service

Change-Id: I425bd79319dd2c2360e4e37a611feb98ed297c16
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
23 months agoAdd mac override capability to package recovery service 83/275683/1
Ilho Kim [Mon, 30 May 2022 05:53:01 +0000 (14:53 +0900)]
Add mac override capability to package recovery service

Change-Id: I450fdb7c8697a986b0db68cf5ea375265df38ab4
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
23 months agoRelease version 1.34.7 45/275145/1 submit/tizen/20220602.063759
Sangyoon Jang [Tue, 17 May 2022 07:41:50 +0000 (16:41 +0900)]
Release version 1.34.7

Changes:
 - Fix static analysis issue
 - Change initdb tool behavior
 - Revert "Revert "Change package version comparsion behavior""

Change-Id: I2d514e7371e17aa86e15b528bc5cc2e9cb20617d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
23 months agoRevert "Revert "Change package version comparsion behavior"" 33/275133/1
Sangyoon Jang [Tue, 17 May 2022 06:14:50 +0000 (15:14 +0900)]
Revert "Revert "Change package version comparsion behavior""

This reverts commit 6eb8a73e1466d86daa9a1bdc695179af43039b57.

Change-Id: I1cfdb754b59ba1df5cb8bcb6e4e6fc7331e4aae6

23 months agoChange initdb tool behavior 24/274524/2
Junghyun Yeon [Mon, 2 May 2022 00:30:51 +0000 (09:30 +0900)]
Change initdb tool behavior

Initdb will be executed even one of installation has failed.

Change-Id: I9c2c78674c7fd89a7b6f7592e2f963fddc228331
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix static analysis issue 27/274227/1
Ilho Kim [Mon, 25 Apr 2022 04:43:01 +0000 (13:43 +0900)]
Fix static analysis issue

- Fix incorrect error log
- Fix memory leak

Change-Id: I5e4a1face1d4f2387454eb5fbb3504325cfb77d6
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoRelease version 1.34.6 53/274153/1 accepted/tizen/unified/20220425.055037 accepted/tizen/unified/20220426.132140 submit/tizen/20220422.070818 submit/tizen/20220423.050208 submit/tizen/20220423.124820 submit/tizen/20220425.070152
Junghyun Yeon [Fri, 22 Apr 2022 06:39:21 +0000 (15:39 +0900)]
Release version 1.34.6

Changes:
 - Implement lightuser feature

Change-Id: Ic4b49378647ae1d48887889756377482945be7aa
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoImplement lightuser feature 18/274018/4
Junghyun Yeon [Wed, 20 Apr 2022 05:25:58 +0000 (14:25 +0900)]
Implement lightuser feature

- Add directory creation/deletion/clear logic for light user.

Change-Id: Ic8fc3dae52da1a2bbcc3257846ad4a527c1a6353
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.34.5 33/272733/1 accepted/tizen/unified/20220324.134412 submit/tizen/20220323.085347
Sangyoon Jang [Wed, 23 Mar 2022 08:30:00 +0000 (17:30 +0900)]
Release version 1.34.5

Changes:
 - Keep system and update value for undo operation

Change-Id: Ib66ab4ee67ee49580a0571fdf9bc253ebabb9854
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoKeep system and update value for undo operation 02/271902/1
Sangyoon Jang [Thu, 3 Mar 2022 05:05:46 +0000 (14:05 +0900)]
Keep system and update value for undo operation

These value must be set for undo operation.

Change-Id: I5d2896b82c535489bd8795b2357bf6a4cfa3153f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRelease version 1.34.4 20/271820/1 accepted/tizen/unified/20220303.131815 submit/tizen/20220302.045443 submit/tizen/20220302.053619
Junghyun Yeon [Wed, 2 Mar 2022 04:31:49 +0000 (13:31 +0900)]
Release version 1.34.4

Changes:
 - Fix static analysis issue

Change-Id: Idbd2b28ff035889e6689f4978c0d4b2076ac7460
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix static analysis issue 13/271813/1
Junghyun Yeon [Wed, 2 Mar 2022 01:38:44 +0000 (10:38 +0900)]
Fix static analysis issue

Change-Id: I23eec4277dcdd6519f9dd0b05b16f24dddb9b857
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.34.3 56/271656/1 accepted/tizen/unified/20220225.151832 submit/tizen/20220224.064209
Sangyoon Jang [Thu, 24 Feb 2022 06:41:09 +0000 (15:41 +0900)]
Release version 1.34.3

Changes:
 - Revert "Change package version comparsion behavior"

Change-Id: Ic65334aac5ac01fb33ee2c0f6d6dcd18e0aeebd4
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRevert "Change package version comparsion behavior" 54/271654/1
Sangyoon Jang [Thu, 24 Feb 2022 06:33:02 +0000 (15:33 +0900)]
Revert "Change package version comparsion behavior"

This reverts commit ee680e185d6019ad0eaa702aa1766787048e92fd.

Revert this patch temporarily due to image creation failure.

Change-Id: I072e1309ced346ada1f5d4d3790811b059713b76

2 years agoRelease version 1.34.2 01/271601/1 submit/tizen/20220223.084514
Sangyoon Jang [Wed, 23 Feb 2022 08:41:36 +0000 (17:41 +0900)]
Release version 1.34.2

Changes:
 - Change package version comparsion behavior
 - Fix typo in update plugin info error message
 - Add shared directory creation logic
 - Fix a variable name
 - Fix static analysis issue

Change-Id: I7028f70a0d288ed3ccea9d218ebf07bb3da7ece9
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoMerge "Fix static analysis issue" into tizen
Sangyoon Jang [Wed, 23 Feb 2022 08:38:59 +0000 (08:38 +0000)]
Merge "Fix static analysis issue" into tizen

2 years agoFix static analysis issue 80/271580/1
Ilho Kim [Wed, 23 Feb 2022 06:38:43 +0000 (15:38 +0900)]
Fix static analysis issue

Fix unchecked return value

Change-Id: I0537dd92eb24034e273025bce52cd999c17abf77
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix static analysis issue 52/271452/1
Sangyoon Jang [Mon, 21 Feb 2022 11:47:10 +0000 (20:47 +0900)]
Fix static analysis issue

Fix TOCTOU problem.

Change-Id: I0c0591a86a7a86a9df6ba34bc629ca0010cf192f
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoFix a variable name 22/271422/1
Sangyoon Jang [Mon, 21 Feb 2022 04:50:09 +0000 (13:50 +0900)]
Fix a variable name

The variable name for PkgmgrSignal 'ps' seems more proper than 'pi'.

Change-Id: I58d2e64e1ddc1adc614fcd25a095f60b270d5801
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoAdd shared directory creation logic 07/270207/1
Junghyun Yeon [Wed, 26 Jan 2022 10:24:52 +0000 (19:24 +0900)]
Add shared directory creation logic

- Sometimes exception occured at current_path() due to absence of skel/pkgid/shared.

Change-Id: I695abe33fcf790a6dfdd9af6e114dfff3ea5b5e3
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix typo in update plugin info error message 76/270076/1
Ilho Kim [Tue, 25 Jan 2022 05:56:34 +0000 (14:56 +0900)]
Fix typo in update plugin info error message

Change-Id: I64826a53a939ba416e5227d48001f9585bd0b979
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoChange package version comparsion behavior 72/269372/1
Junghyun Yeon [Thu, 13 Jan 2022 08:25:34 +0000 (17:25 +0900)]
Change package version comparsion behavior

Dotnet version will not be compared anymore

Change-Id: I01b3834139f67fee0e379ff3ababbadbd09c87fd
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.34.1 07/269207/1 accepted/tizen/unified/20220112.121658 submit/tizen/20220111.094849
Junghyun Yeon [Tue, 11 Jan 2022 09:20:51 +0000 (18:20 +0900)]
Release version 1.34.1

Changes:
 - Add boost_filesystem namespace at exists()

Change-Id: Id4f0f5f0285fee8c958c1caa0e705dd4eb770e3e
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoAdd boost_filesystem namespace at exists() 74/268574/2
Sangyoon Jang [Mon, 27 Dec 2021 05:51:57 +0000 (14:51 +0900)]
Add boost_filesystem namespace at exists()

Change-Id: I9c2c00e39efd01e09d827170c41d230fa88135c5
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRelease version 1.34.0 46/268746/1 accepted/tizen/unified/20220103.130106 submit/tizen/20211231.044548
Junghyun Yeon [Fri, 31 Dec 2021 04:41:49 +0000 (13:41 +0900)]
Release version 1.34.0

Changes:
 - Fix build error

Change-Id: I15092396d575bc227daa1c82e2d7237f80494a86
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix build error 40/268740/2
Junghyun Yeon [Fri, 31 Dec 2021 01:53:41 +0000 (10:53 +0900)]
Fix build error

Fix build error caused by boost library upgrade.

Change-Id: If9f8f4ac384b12d39dfd14acb3fc62f17f0ac573
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.33.13 99/268099/1 accepted/tizen/6.5/unified/20211217.122017 accepted/tizen/unified/20211217.122030 submit/tizen/20211216.065705 submit/tizen_6.5/20211216.065717
Ilho Kim [Thu, 16 Dec 2021 06:54:07 +0000 (15:54 +0900)]
Release version 1.33.13

Changes:
 - Add return value checking routine
 - Fix remove user package in StepRemovePrivSharedres

Change-Id: I78ae79c3ae4084d1ac012d235947bc99506abb44
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix remove user package in StepRemovePrivSharedres 90/268090/3
Ilho Kim [Thu, 16 Dec 2021 05:42:09 +0000 (14:42 +0900)]
Fix remove user package in StepRemovePrivSharedres

SendUninstallRequest return PMINFO_R_OK when operation success
this patch correct the wrong conditional check when uninstall of user package

Change-Id: Ic5f4059771927c357c9cc659339f1e38b9be96a3
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoAdd return value checking routine 14/267214/3
Junghyun Yeon [Tue, 30 Nov 2021 01:38:28 +0000 (10:38 +0900)]
Add return value checking routine

Change-Id: I69ad2e55a54b2750155852f20404f2b716df2c24
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.33.12 49/267349/1 accepted/tizen/6.5/unified/20211205.214036 accepted/tizen/unified/20211203.125436 submit/tizen/20211202.053321 submit/tizen_6.5/20211202.053401
Ilho Kim [Thu, 2 Dec 2021 05:23:40 +0000 (14:23 +0900)]
Release version 1.33.12

Changes:
 - Fix error message typo in StepRecoverParserPlugin
 - Fix usage of backup manifest in recover parser plugin

Change-Id: I311d665de6533aa3ab9eea81017092d2448c56dd
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix usage of backup manifest in recover parser plugin 94/267294/1
Ilho Kim [Wed, 1 Dec 2021 04:55:59 +0000 (13:55 +0900)]
Fix usage of backup manifest in recover parser plugin

When in RecoverInstall mode and ReadonlyUpdateInstall in RecoverUpgrade mode
Fix the problem of misusing the backup manifest in the recover parser plugin

Change-Id: I569b9c96c457ba39ec1bb482cd21440f52980563
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix error message typo in StepRecoverParserPlugin 45/267245/1
Ilho Kim [Tue, 30 Nov 2021 08:05:58 +0000 (17:05 +0900)]
Fix error message typo in StepRecoverParserPlugin

Change-Id: Iaf63915f3e523eb049f76391755acde4e79fdebf
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoRelease version 1.33.11 91/266191/1 accepted/tizen/unified/20211125.144721 submit/tizen/20211109.054832 submit/tizen/20211110.041159 submit/tizen/20211111.071430 submit/tizen/20211112.055141 submit/tizen/20211124.080956
Junghyun Yeon [Tue, 9 Nov 2021 05:38:18 +0000 (14:38 +0900)]
Release version 1.33.11

Changes:
 - Fix StepRemovePrivSharedres
 - Fix log backup logic
 - Change file log behavior

Change-Id: I564fe25914656e66390a48038ebe409b76bce14d
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoChange file log behavior 58/265958/1
Junghyun Yeon [Tue, 2 Nov 2021 10:35:39 +0000 (19:35 +0900)]
Change file log behavior

Adjust permission and SMACK label to let
platform privileged applications could access it.
Also, create empty installer history log file to
apply proper SMACK label to it.

Change-Id: Icb85e3fbb2f0e69ae5b8e8ad6e1a94eedee576da
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix log backup logic 50/265950/1
Junghyun Yeon [Tue, 2 Nov 2021 08:26:27 +0000 (17:26 +0900)]
Fix log backup logic

Rotation logic was not working properly because
std::remove() with file which is not exists will return negative integer.

Change-Id: I2f1b1b792e306024af4545e4586fb5069a0330d9
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix StepRemovePrivSharedres 76/265476/1
Junghyun Yeon [Wed, 20 Oct 2021 08:43:38 +0000 (17:43 +0900)]
Fix StepRemovePrivSharedres

Installer will tries to remove privileged sharedres directory itself
when installer unable to send request to server such as pkg recovery.

Change-Id: If3de55eb19e5e1db18f2313f506fb42a7aee8208
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.33.10 97/263897/1 accepted/tizen/6.5/unified/20211028.095230 accepted/tizen/unified/20210914.085037 submit/tizen/20210913.073852 submit/tizen_6.5/20211028.162101 tizen_6.5.m2_release
Junghyun Yeon [Mon, 13 Sep 2021 07:19:30 +0000 (16:19 +0900)]
Release version 1.33.10

Changes:
 - Fix static analysis issue

Change-Id: I4633414e4d2f07da1965cf597d7bc194e6111b4f
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix static analysis issue 60/263860/1
Junghyun Yeon [Mon, 13 Sep 2021 01:27:51 +0000 (10:27 +0900)]
Fix static analysis issue

Change-Id: I62449d9b4df01b5ce14fdf24373a2989c5648819
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.33.9 19/263519/1 accepted/tizen/unified/20210908.011430 submit/tizen/20210906.013143 submit/tizen/20210907.080459
Junghyun Yeon [Mon, 6 Sep 2021 01:30:36 +0000 (10:30 +0900)]
Release version 1.33.9

Changes:
 - Cleanup codes with clean code principle
 - Add Steps for handling privileged shared resources

Change-Id: Ia07b2416b708915f4b5e50b11e7423212c74f6b6
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoAdd Steps for handling privileged shared resources 21/263321/3
Junghyun Yeon [Tue, 31 Aug 2021 07:40:53 +0000 (16:40 +0900)]
Add Steps for handling privileged shared resources

Add new steps responsible for removing privileged shared resources
while uninstall and its recovery requests.

Change-Id: Iec89a431e415b6abc84c2bf6409fc30445818536
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoCleanup codes with clean code principle 98/261798/5
Junghyun Yeon [Mon, 26 Jul 2021 11:06:50 +0000 (20:06 +0900)]
Cleanup codes with clean code principle

- Extract codes into functions to reduce function size.
- Apply early-return policy to reduce indentation depth.
- Integrate duplicate operation logic into one function.
- Remove unnecessary comments.
- Add blank lines for readability.

Change-Id: I5e9cca6e1854dbe781daf5099cc29a5103369698
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoRelease version 1.33.8 37/260937/1 accepted/tizen/unified/20210712.131308 submit/tizen/20210707.235102
Ilho Kim [Wed, 7 Jul 2021 07:47:08 +0000 (16:47 +0900)]
Release version 1.33.8

Changes:
 - Fix update failure of rpk package
 - Print step name when failed at process()
 - Set installer index at InstallerRunner

Change-Id: Icf2ce7bc3e30b80478b80f73a7505cb146a02033
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoSet installer index at InstallerRunner 60/259860/5
Sangyoon Jang [Wed, 16 Jun 2021 05:57:49 +0000 (14:57 +0900)]
Set installer index at InstallerRunner

InstallerFactory doesn't need to set index itself.

Change-Id: Ibe46849ec871ee356ea6e14320cacd00eee14b95
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoPrint step name when failed at process() 59/259859/4
Sangyoon Jang [Wed, 16 Jun 2021 05:52:21 +0000 (14:52 +0900)]
Print step name when failed at process()

Change-Id: I5da03d1ce517ddea1bd5cc9a3d07c00eb1b69796
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoFix update failure of rpk package 07/260107/1
Sangyoon Jang [Fri, 18 Jun 2021 11:11:12 +0000 (20:11 +0900)]
Fix update failure of rpk package

The rpk package doesn't contain shared directory, we don't need to check
free space for backup this directory.

Change-Id: Ie9cd4b1743487b4ac240891bb6a56645f3941903
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRelease version 1.33.7 82/259982/1 accepted/tizen/unified/20210621.214619 submit/tizen/20210617.070222 submit/tizen/20210618.082001 submit/tizen/20210620.232502 submit/tizen/20210621.070948
Ilho Kim [Thu, 17 Jun 2021 06:51:01 +0000 (15:51 +0900)]
Release version 1.33.7

Changes:
 - Fix StepCreateResControlDirectoires
 - Add keep-rwdata check routine for ReadonlyUpdateUninstall
 - Fix StepRevmoeUserData
 - Implement parsing res-control
 - Create directory for res control if necessary

Change-Id: I8258297fc91676ed8d016a93882accc9ca07bf12
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoCreate directory for res control if necessary 81/259381/5
Ilho Kim [Thu, 3 Jun 2021 07:00:17 +0000 (16:00 +0900)]
Create directory for res control if necessary

Create directories used for res control when a application has res control

Change-Id: I9707db1705c97f0b458126fc466c696f41ce69d8
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoImplement parsing res-control 82/258682/8
Ilho Kim [Mon, 24 May 2021 07:25:47 +0000 (16:25 +0900)]
Implement parsing res-control

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/appfw/tpk-manifest-handlers/+/258681/

Change-Id: Ie09bd3f2a30cbc4f8d45e4992e6b0ec4a22d69ab
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix StepRevmoeUserData 07/259907/2
Sangyoon Jang [Wed, 16 Jun 2021 09:09:18 +0000 (18:09 +0900)]
Fix StepRevmoeUserData

Use directory_iterator instead of recursive_directory_iterator.
recursive_directory_iterator may access files already removed, and this
causes exception.

Change-Id: Idee057b214d0b624710edda75ed33027e357918d
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoAdd keep-rwdata check routine for ReadonlyUpdateUninstall 08/259908/1
Junghyun Yeon [Wed, 16 Jun 2021 09:44:09 +0000 (18:44 +0900)]
Add keep-rwdata check routine for ReadonlyUpdateUninstall

Change-Id: I908cd718c5cabce6d86e32d00d4380a9513b0e4b
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoFix StepCreateResControlDirectoires 12/259712/1
Sangyoon Jang [Thu, 10 Jun 2021 11:30:47 +0000 (20:30 +0900)]
Fix StepCreateResControlDirectoires

Do not create "work" directory. This directory is not necessary for
read-only overlay mount.

Change-Id: I67c89b377fa269994220e47ad08a2957468ae6b6
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoRelease version 1.33.6 38/259638/1 accepted/tizen/unified/20210611.013656 submit/tizen/20210610.095123
Ilho Kim [Thu, 10 Jun 2021 09:34:02 +0000 (18:34 +0900)]
Release version 1.33.6

Changes:
 - Give inheritance attribute of Signature class
 - Add virtual destructor of class Signature
 - Add functions for classes inherits this class
 - Fix static analysis issues

Change-Id: I9ffcdf792ec017ecb3a7922aa77a8f57f55032fd
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoFix static analysis issues 76/259576/2
Ilho Kim [Thu, 10 Jun 2021 01:32:26 +0000 (10:32 +0900)]
Fix static analysis issues

 - Fix memory leak
 - Add try-catch statement to main
 - Fix Uninitialized scalar field

Change-Id: If270567d9e33f77ca771badbf1de7f32a14d47da
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>
2 years agoAdd functions for classes inherits this class 26/256526/3
Junghyun Yeon [Tue, 6 Apr 2021 08:33:01 +0000 (17:33 +0900)]
Add functions for classes inherits this class

- Add ExtractPackageArchive() as virtual function.
- Define RemoveTmpDir() and implement it.

Change-Id: I9a62c629dff3434e186f9b56f618e41255f66625
Signed-off-by: Junghyun Yeon <jungh.yeon@samsung.com>
2 years agoAdd virtual destructor of class Signature 57/258957/2
Sangyoon Jang [Fri, 28 May 2021 08:13:46 +0000 (17:13 +0900)]
Add virtual destructor of class Signature

Change-Id: I45b71af5bd915accae9628e425e40bdee36d5dae
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
2 years agoGive inheritance attribute of Signature class 62/258862/3
DongHyun Song [Thu, 27 May 2021 04:02:42 +0000 (13:02 +0900)]
Give inheritance attribute of Signature class

This patch will provide inherit-ability to child class for its purpose.

Change-Id: I0cef392af11082051a97f33942c1958d175442c2
Signed-off-by: DongHyun Song <dh81.song@samsung.com>