Fix static analysis issues

In InstallWithStorage function vconf_get and vconf_set function
can be failed so the return value need to be checked

Change-Id: I215799aa5f2e4a73474dc97c89acb8da1551f7db
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/test/smoke_tests/common/smoke_utils.cc b/test/smoke_tests/common/smoke_utils.cc
index 50f3187..75ce7eb 100644 (file)
--- a/test/smoke_tests/common/smoke_utils.cc
+++ b/test/smoke_tests/common/smoke_utils.cc
@@ -805,15 +805,29 @@ BackendInterface::CommandResult BackendInterface::InstallWithStorage(
       LOG(ERROR) << "Unknown storage type";
       break;
   }
-  vconf_get_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT,
-      &default_storage);
-  vconf_set_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT, storage);
+  if (vconf_get_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT,
+      &default_storage) != 0) {
+    LOG(ERROR) << "Failed to get value of "
+        "VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT";
+    return BackendInterface::CommandResult::ERROR;
+  }
+  if (vconf_set_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT,
+      storage) != 0) {
+    LOG(ERROR) << "Failed to set value of "
+        "VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT";
+    return BackendInterface::CommandResult::ERROR;
+  }
 
   const char* argv[] = {"", "-i", path.c_str(), "-u", uid_str_.c_str()};
   BackendInterface::CommandResult result = CallBackend(SIZEOFARRAY(argv), argv);
 
-  vconf_set_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT,
-      default_storage);
+  if (vconf_set_int(VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT,
+      default_storage) != 0) {
+    LOG(ERROR) << "Failed to set value of "
+        "VCONFKEY_SETAPPL_DEFAULT_MEM_INSTALL_APPLICATIONS_INT";
+    return BackendInterface::CommandResult::ERROR;
+  }
+
   return result;
 }