Fix static analysis issue 38/243538/1
authorSangyoon Jang <jeremy.jang@samsung.com>
Tue, 8 Sep 2020 03:18:22 +0000 (12:18 +0900)
committerSangyoon Jang <jeremy.jang@samsung.com>
Tue, 8 Sep 2020 03:18:22 +0000 (12:18 +0900)
Change-Id: I2f1c2634150246f48f8293794c117a7a1a58832e
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
src/common/utils/user_util.cc

index d030ba4..47858ef 100644 (file)
@@ -125,15 +125,13 @@ bool IsAdminUser(uid_t uid) {
 }
 
 boost::optional<gid_t> GetGidByGroupName(const char* groupname) {
-  boost::optional<gid_t> result;
   char buf[kGRBufSize];
   struct group entry;
   struct group* ge;
   int ret = getgrnam_r(groupname, &entry, buf, sizeof(buf), &ge);
   if (ret || ge == nullptr)
     return {};
-  result = entry.gr_gid;
-  return result;
+  return entry.gr_gid;
 }
 
 std::string GetUsernameByUid(uid_t user) {
@@ -157,15 +155,13 @@ boost::optional<uid_t> GetUidByUserName(const char* username) {
 }
 
 boost::optional<gid_t> GetGidByUid(uid_t uid) {
-  boost::optional<gid_t> result;
   struct passwd pwd;
   struct passwd* pwd_result;
   char buf[kPWBufSize];
   int ret = getpwuid_r(uid, &pwd, buf, sizeof(buf), &pwd_result);
   if (ret != 0 || pwd_result == nullptr)
     return {};
-  result = pwd.pw_gid;
-  return result;
+  return pwd.pw_gid;
 }
 
 std::string GetGroupNameByGid(gid_t gid) {