Rafal Walczyna [Tue, 29 Oct 2019 12:58:14 +0000 (13:58 +0100)]
[filesystem] Fix getAllStorages
Fixed bug which causes to show duplicated values of internal
and external storages
[verification] Filesystem and Archive tct - 100% pass.
Change-Id: Ic087583a906eecfa040d97cb903f4c99838c6591
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I99c57c205dd95970412c98430b9998c773a94917
[version] 2.36
Change-Id: I99c7c0258b677468f6a163e03a7807411dbbde56
[Bluetooth] Fixed issues related to BLE
[Bug/Fix]
1. Prevent possible crash in case of invalid data passed from native
2. Prevent type mismatch exception in JS in case of LE devices advertising
serviceData.
[Verification] tct passrate 100%
Checked in chrome console and le device with serviceData.
Change-Id: Iecc9929a77a1acfd1b33eb325ea287011b9a6096
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44
[version] 2.35
Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting
Used: ./code_format src/ -c -js
Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots
Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.
[Verification] TCT Archive passed with 100% p.r.
Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.
Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.
Verification: TCT - 100 % pass.
Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
[Application] Fixed path of getAppSharedURI
Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy
New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner users 4096 Jul 18 13:06 .
drwxr-xr-x 5 owner users 4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw 58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner users 4096 Jul 18 13:06 trusted
Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res
[Verification] Checked manually in chrome console
TCT Application 100% passrate
Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09
Arkadiusz Pietraszek [Fri, 12 Jul 2019 11:47:35 +0000 (13:47 +0200)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0
[Verification] TCT passrate 100%.
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch
Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.
Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.
Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.34
Change-Id: Idd416b0d826a58f7bbc72edb07d4570aa3319212
Arkadiusz Pietraszek [Thu, 27 Jun 2019 09:14:58 +0000 (11:14 +0200)]
[Mediacontroller] Setter fixes for shuffleMode, repeatMode end position in MediaControllerPlaybackInfo
Previous implementation intended to check for null and undefined and in reality didn't allow for setting 'false' or '0' values.
Change-Id: I03194e81d5d0bd5ef97a88d01a014f758a6ca49d
[version] 2.33
Change-Id: I2a04c187950845b460b398c9b16ad963c4c2330f
Arkadiusz Pietraszek [Wed, 3 Apr 2019 11:09:04 +0000 (13:09 +0200)]
[Project] JS code formatting
All project *.js files were formatted with eslint tool, to eliminate CodingRule_Auto negative marks.
Additionally Prettier tool was used for unified line breaking rules.
In few cases, the tool did not break line for very long object definitions e.g.
HumanActivityRecorderPressureData.prototype.constructor = HumanActivityRecorderPressureData;
in such cases, line was broken manually and flag // prettier-ignore was added to ignore next node.
Change-Id: I537435c652abad22364421fc4c5ebddd411defbf
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I0d282d007e89b4c761fa74d9b0737ca35c29ec57
[Content] isFavorite added to editableAttributes array
[Bug] Since 2.3 isFavorite is an editableAttribute, which was missing
in editableAttributes array. Now added it there.
[Verification] Code compiles without errors.
Change-Id: Ib5266a66920f0050fd5c25287602514bc4ea3762
Piotr Kosko [Wed, 17 Apr 2019 10:35:16 +0000 (10:35 +0000)]
Merge "[Project][Codeformat] Added prettier as partial formatter for JS" into tizen_3.0
Piotr Kosko [Wed, 17 Apr 2019 10:34:30 +0000 (10:34 +0000)]
Merge "[Project][code_formatter] Added u options and changed JS formatting and validating tools" into tizen_3.0
[Project][Codeformat] Added prettier as partial formatter for JS
[Feature] Existing solution check the format using eslint and fix
some issues with predefined rules (which match the requirements
of review.tizen.org CodingRule_Auto bot rules.
However the tool checks the validity, it does not provide auto
formating of too long lines issues.
To ensure such feature, the new tool was introduced and executed before
eslint validation.
Thanks to prettier, the line breaks are unified and handled the same
way in whole project.
Change-Id: I077036521307ef28fda5388ecab01b8d850ad3e3
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8f28e19de69751b7b92328491366aa0b8c7c6847
[version] 2.32
Change-Id: Idb24a1afa087aa101cebcfde7d46d283d459c956
[Filesystem] listFiles method of File ignores files without access
[Bug] Files with invalid SMACK labels (not allowed to be accessed by app)
caused exception about missing member ("location is required argument").
Fix ignores the files that cannot be accessed.
[Verification] Manually checked with Chrome console and trying to list files
with invalid SMACK label. Files are being ignored.
100% passrate for filesystem module.
Change-Id: I48ed83ebbba5d0c6cfa0e597f083a7a1abce17fa
Arkadiusz Pietraszek [Wed, 27 Mar 2019 14:29:37 +0000 (15:29 +0100)]
[Project][code_formatter] Added u options and changed JS formatting and validating tools
Now eslint is used to format js files.
Not all issues can be fixed by eslint, so it prints list of issues for user to fix.
All 'u' options in formatter format appropriate files, that was changed from last commit.
Since files to format are not commited, this script backs up those files.
[Verification] Script executes without errors and proper files are chosen to format. Formated .js files have 4 spaces of indentation.
Change-Id: I10509ce3f639b25cca7e68e95e7c9419d9d82304
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 12:42:20 +0000 (13:42 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201889/
Change-Id: Ic48f0740da9c73ef676d30eedf72226c7f4d5699
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Dawid Juszczak [Wed, 20 Mar 2019 11:19:48 +0000 (12:19 +0100)]
[messaging] fixed bug with foldersupdate callback
foldersupdated callback in method addFoldersChangeListener was not
invoked when renamed folder
[Verification] Tested on device, works fine. Also tested with new
testcase added in commit:
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/201880/
Change-Id: I26f3ae8991218e97d1a55cf6a0abffba622ed25f
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I7bdf58474ccd556f444f93dee7856566a65373b6
[version] 2.31
Change-Id: Ic8c3ade13866c7e55ee660346c3a79103f29d006
[Archive][Exif] Added checking return value of fseek
SVACE issues: 246302, 246317
Change-Id: If4f803b9db18c352912290b25df706a21cd07853
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ifadc8944744fa1fe4e944670a51c184f1c36c228
[version] 2.30
Change-Id: I701491ee275a9540c9ddb821f420898629a3f5ca
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Wed, 19 Dec 2018 18:05:20 +0000 (19:05 +0100)]
[Messaging] Prevent crash on getMessageServices call
Calling tizen.messaging.getMessageServices() multiple times at
short intervals used to cause a crash, due to race condition, occurring
between different threads, modifying the same MessagingManager
instance's fields.
The fix moves execution of the underlying implementation to the main
thread - it is not called concurrently. The function execution time
is typically below 2 ms, so moving it to the main thread should
not worsen user experience.
[Verification] tct-tizen-messaging-email-tests pass rate: 100%
tct-tizen-messaging-sms-tests pass rate: 100%
tct-tizen-messaging-mms-tests pass rate: 100%
A code snippet, that used to cause a crash, does not
cause crash now:
for (var i = 0; i < 1000; ++i) {
tizen.messaging.getMessageServices('messaging.email',
s=>{console.log(s);},
e=>{console.error(e);});
}
Change-Id: I2f140281e64aeffea1ad9ca15f99ee38378693d3
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Wed, 5 Dec 2018 09:18:08 +0000 (10:18 +0100)]
[MessagePort] Fixed issue with removeMessagePortListener without any added earlier
If any listener was added before remove then error was thrown
'Cannot read property length of undefined'
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I96000345ae483a9fa2c0b50a6be0ece427ce8e1b
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I3142680c3588c1287d4dc23af6aee9832ebe6cd0
[version] 2.29
Change-Id: I27c09aef9adc3ba125477521e95a85633b0e702d
[Common] Added missing return statement
[Bug] When parsing invalid message, exception is catched, but the control
is not finished. Going to following lines, other exception would be raised.
We need to finish execution for invalid message.
[Verification] Code compiles without errors.
Change-Id: I65784e775b9a765332c4a1f0a19b8184e896872c
Signed-off-by: Piotr Kosko/Native/Web API (SWP) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
Piotr Kosko [Tue, 23 Oct 2018 05:30:19 +0000 (07:30 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I1095cde2fdf145ec952fb0ce220837705982086f
Piotr Kosko [Mon, 22 Oct 2018 12:16:20 +0000 (14:16 +0200)]
[version] 2.28
Change-Id: Icfae075f33085630150a69087c7dc8ccd78c9697
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 19 Oct 2018 10:03:02 +0000 (12:03 +0200)]
[Messaging] Refactor MessageConversation related code
Refactoring was requested to get rid of duplicated and unnecessary
code.
[Verification] TCT pass rate: 100%
Change-Id: Iee2eacf50ca89ea60e89b283d3aac24111cfd5e5
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Pawel Wasowski [Fri, 24 Aug 2018 16:12:09 +0000 (18:12 +0200)]
[Messaging] Fix sorting and filtering issues in findConversations
The commit fixes the following problems of email service's findConversations:
- conversations sorted with regard to timestamp, subject, to, from attributes
were ordered incorrectly
- an attempt to sort results with regard to unreadMessages, isRead, cc,
bcc, lastMessageId attributes resulted in throwing a JS exception
- unreadMessages attribute value depended on the offset argument value
- filtering by unreadMessages, did not work
The commit changes also the method of creation of MessageConversation
from database records. It may be quicker than the previous one,
that unnecessarily retrieved numerous messages from the database several times.
[Verification] TCT Pass rate: 100%
Several filters and sort modes were tested manually,
with Chrome DevTools.
Change-Id: I6196e316ff2b1477c909d528859ef980237454b6
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 12:11:27 +0000 (14:11 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Iaff2d9c208f5291dfac1eacb23070b8c4f3f10f2
Piotr Kosko [Tue, 2 Oct 2018 12:08:07 +0000 (14:08 +0200)]
[version] 2.27
Change-Id: I7aa0f9e1384347db1d0b045ef46542fcd5e8c7a2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 2 Oct 2018 11:25:19 +0000 (13:25 +0200)]
[Archive][Exif] Added missing error checking
[Verification] Code compiles without errors.
Change-Id: I588a1d08f4dea4a19038653b2889a1daa5b45673
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 07:20:56 +0000 (09:20 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: I8dd955cb6c74b1323acfb5c8839733517c70e053
Piotr Kosko [Thu, 20 Sep 2018 07:01:37 +0000 (09:01 +0200)]
[version] 2.26
Change-Id: Ibb8feb4665aee4761dc2592147bdd41743bed13d
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Thu, 20 Sep 2018 06:40:06 +0000 (08:40 +0200)]
[Bluetooth] Fixing the memory releasing issue
[Verification] Code compiles without errors.
TCT passrate 100%.
Change-Id: I4a7b516635b7d2a3bfc96359fa4d51543b0eb4e0
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Mon, 27 Aug 2018 08:03:57 +0000 (10:03 +0200)]
[Alarm] Fix printing deprecation warnings on TV profile
AlarmAbsolute(date, period) constructor is not marked
as deprecated on TV profile.
[Verification]
Tested in chrome console
Change-Id: I1b3de7ad9d38c4bf4f8e55f8e8309e86b106e2f1
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Piotr Kosko [Thu, 16 Aug 2018 08:43:39 +0000 (10:43 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ic220dd064ebbb7187462bf78fde154cea2a19b66
Piotr Kosko [Thu, 16 Aug 2018 08:42:15 +0000 (10:42 +0200)]
[version] 2.25
Change-Id: If58254886f7fa6188e597e4d20dcb30f0ef60234
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Pawel Kaczmarczyk [Thu, 9 Aug 2018 08:40:58 +0000 (10:40 +0200)]
[HAM][Notification][Alarm] Add missing deprecation warnings since Tizen 4.0
[Verification]
tct-humanactivitymonitor-tizen-tests auto 100%
tct-notification-tizen-tests auto 100%
tct-alarm-tizen-tests auto 100%
Change-Id: I8d0de96c0d6a2ca8a009a25a7c1373dc4064ec36
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Wed, 8 Aug 2018 12:32:16 +0000 (14:32 +0200)]
[SystemInfo][Bluetooth][Push] Add misssing deprecation warnings since Tizen 3.0
[Verification]
Code compiles
tct-systeminfo-tizen-tests passrate 100%
Change-Id: I41db5325ac94ca042069551a41161e5b968e51d3
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Wed, 18 Jul 2018 13:45:45 +0000 (15:45 +0200)]
[HAM] Fix throwing exceptions for getHumanActivityData
[Bug] getHumanActivityData method accepts only 'PEDOMETER'
and 'HRM' values of HumanActivityType enum as type
parameter. Any other value should cause NotSupportedError,
but implementation leaded to UnknownError instead.
[Verification] AutoTCT 100% passrate
Change-Id: Id5145d76f8957527e28f42c9b1c3141b11b8e5ca
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Pawel Kaczmarczyk [Thu, 26 Jul 2018 07:05:03 +0000 (09:05 +0200)]
[NFC] Minor fixes
[Bugs]
1. In special cases records objects were created as empty
2. If NFCPeerDetectCallback or NFCTagDetectCallback did
not have defined function to call on action an TypeError
would be thrown.
[Verification] tct-nfc-tizen-tests passrate 100%
Change-Id: I32d6cbdc05c491f42100580a1cfe021c4c877bfc
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Lukasz Bardeli [Thu, 12 Jul 2018 08:08:07 +0000 (10:08 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ib0a0675b868f145f94825b3b209ed779e648df73
Lukasz Bardeli [Thu, 12 Jul 2018 05:38:20 +0000 (07:38 +0200)]
[version] 2.24
Change-Id: I612a9ec9977025efbbb35fa2c58e4c3ec8226b79
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Kaczmarczyk [Tue, 10 Jul 2018 13:35:36 +0000 (15:35 +0200)]
[HRM] Fix for resetting pedometer data after calling start
[Bug] Pedometer properties were not reset
back to zero after calling start again.
[Verification] Auto TCT passrate 100%
Manual (wearable and mobile emulators) 100%
Change-Id: I4b961a5c05224accb7ff482c570b3dd3aa352bb4
Signed-off-by: Pawel Kaczmarczyk <p.kaczmarczy@samsung.com>
Szymon Jastrzebski [Wed, 27 Jun 2018 10:21:48 +0000 (12:21 +0200)]
[MediaController] Replacing old functions with new equivalent
The part of Native API has been removed and needs to be replaced with new
one.
Related to Native ACR-1235
[Verification] Code successfully built. MC TCT M&A 100%
Change-Id: Iad47da5f58bd99a3505248b9f9a25e45cb7048db
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Arkadiusz Pietraszek [Mon, 4 Jun 2018 09:55:34 +0000 (11:55 +0200)]
[Mediacontroller] Added flags for setting shuffle and repeat modes
shuffle_mode_ and repeat_mode_ initial values are not determined.
Added flags enables to determine if it was already set.
Without it following TCT cases failed regardles of initial value:
MediaControllerPlaybackInfoChangeCallback_onrepeatmodechanged
MediaControllerPlaybackInfoChangeCallback_onshufflemodechanged
when run second time on target device.
First run might result in success as well as in block.
Verification: TCT pass rate: 100%
Change-Id: I71ef1a8ab4f7c86bb6f9adc9b05fc6f192bd0d96
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Szymon Jastrzebski [Thu, 21 Dec 2017 06:32:11 +0000 (07:32 +0100)]
[MediaController] Fix for bug onChange events
In server side, all onchange*request events should be fired only after
requesting server state change from client side.
Clients should receive on*changed events only after server state change.
[Verification] TCT passed 100%
Change-Id: I85e5eda12acf6de74bc653a9ccc8a283862eeb16
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Szymon Jastrzebski [Wed, 13 Dec 2017 09:31:43 +0000 (10:31 +0100)]
[MediaController] Refactoring internal implementation into dedicated CAPI
[Verification] TCT pass rates: 100% A 100% M
Change-Id: Id01a8988a122d0055f662eabe066a4b3f35bb48b
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Fri, 18 May 2018 12:05:34 +0000 (14:05 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/humanactivitymonitor/humanactivitymonitor_manager.cc
Change-Id: I782f99a7d436a786ee41d6fb0e37f4404e401813
Piotr Kosko [Fri, 18 May 2018 11:44:31 +0000 (13:44 +0200)]
[version] 2.23
Change-Id: I7634bdecaab795b4f9db8b76ecc92a8ee00da755
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Wed, 16 May 2018 12:29:03 +0000 (14:29 +0200)]
[humanactivitymonitor] Fixing rRinterval value in heartRate data
rRinterval was always 0. This value is now available, but measurement
is not present in unified builds. It was tested on R765 and R600 with
solis binaries and it worked fine.
[verification] AutoTCT - 100% pass
Change-Id: I3c181c53e0832f429774f86277bcaeda4708c0b7
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Rafal Walczyna [Wed, 16 May 2018 12:29:03 +0000 (14:29 +0200)]
[humanactivitymonitor] Fixing rRinterval value in heartRate data
rRinterval was always 0. This value is now available, but measurement
is not present in unified builds. It was tested on R765 and R600 with
solis binaries and it worked fine.
[verification] AutoTCT - 100% pass
Change-Id: I3c181c53e0832f429774f86277bcaeda4708c0b7
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Lukasz Bardeli [Thu, 10 May 2018 06:43:35 +0000 (08:43 +0200)]
[Iotcon] Prevent iotcon from call timeout after found resource
In ResourceFoundCallback after some resource was found, timeout will
never be called.
[Verification] Code compiles without error. TCT tests passrate 100%
Change-Id: I96ca592eb94e14c374b6eab99ca1956108f37154
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Thu, 10 May 2018 06:43:35 +0000 (08:43 +0200)]
[Iotcon] Prevent iotcon from call timeout after found resource
In ResourceFoundCallback after some resource was found, timeout will
never be called.
[Verification] Code compiles without error. TCT tests passrate 100%
Change-Id: I96ca592eb94e14c374b6eab99ca1956108f37154
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Piotr Kosko [Tue, 8 May 2018 07:16:04 +0000 (09:16 +0200)]
[version] 2.23
Change-Id: I2721525833d99e46d09ffa8d34ad7b3f7c2eecf2
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 8 May 2018 05:53:49 +0000 (07:53 +0200)]
[Filesystem][Alarm] Fix coverity/SVACE issues
[Bug] Fixed Coverity issues: 119865, 119863.
Fixed SVACE issue: 345864
Issues were related to not reachable code (invalid returned value was checked)
in Alarm module and not checking returned values in Filesystem module.
SVACE issue 345864 is related to the same problem as Coverity 119863.
[Verification] Code compiles without errors.
TCT passrate for Alarm and Filesystem - 100%.
Change-Id: I315d0aed94f8efef13d37a73b313ef455fb3b00e
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 25 Apr 2018 10:47:11 +0000 (12:47 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Change-Id: Ib7b5158b9a129d63575e2f0b5eac142343d76e0b
Piotr Kosko [Wed, 25 Apr 2018 10:42:27 +0000 (12:42 +0200)]
[version] 2.22
Change-Id: I75c3fdd794b62946720fc5cb537c437ab33843bd
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 24 Apr 2018 10:40:19 +0000 (12:40 +0200)]
[Filesystem] Fixing file filter
[Bug]
1. FileFilter name was not matching '%' wildcard on the beginning of filename
2. wildcard escaping need to be done by using '\\%' not '\%' - proper comment
added in code to ease future investigations.
[Verification] Code compiles successfully.
TCT passrate is 100%.
Below code:
var filter = "piotr\\%kosko%";
function onsuccess(files) {
console.log("There are " + files.length + " in the selected folder");
for (var i =0; i < files.length; ++i) { console.log(files[i].name) }
}
function onerror(error) {
console.log("The error " + error.message +
" occurred when listing the files in the selected folder");
}
tizen.filesystem.resolve("documents", function(dir) {
dir.listFiles(onsuccess, onerror, {name: filter});
}, function(e) { console.log("Error " + e.message);}, "r");
for filter "piotr\\%kosko%" filters file:
piotr%koskoTest
for filter "%kosko%" filter files:
piotrkoskoTest
piotrkosko
piotrTestkoskoTest
kosko
piotr%koskoTest
piotr%kosko
Change-Id: If7e6c3c3ad97a3d01a800916ba73c5f7749ae0cb
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Rafal Walczyna [Mon, 23 Apr 2018 12:14:56 +0000 (14:14 +0200)]
[common] Coverity issues fix
[Feature] Fixed coverity issues with below ids:
112270, 112248, 112261, 112244, 110974, 106503, 110555,
105980, 110371, 108240, 105141, 110066, 109641, 109341,
109028, 108310, 106161, 105761, 105746, 108409, 108493,
106299, 106009, 105130, 105410
[Verification] 100% passrate for modules:
alarm, bluetooth, contact, content, email, filesystem,
humanactivitymonitor, mms, sms, voice-control
Change-Id: Ic32295ee12e9a8830d2e071e003a0045d0c5355e
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Szymon Jastrzebski [Thu, 1 Mar 2018 11:40:18 +0000 (12:40 +0100)]
[Power] Fix for casting void* into int
This bug caused to fail building on 64-bits architecture.
[Verification] Power M&A TCT 100% (TM1).
The code is build-able for 64-bits arch.
Change-Id: I3600a753956f448ca0938655cf1873e9ba057754
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 08:49:16 +0000 (10:49 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/application/application_manager.cc
src/power/power.gyp
Change-Id: Ib9baaf8221cc99b01cfe8343b0e36a197c669941
Piotr Kosko [Wed, 18 Apr 2018 08:28:21 +0000 (10:28 +0200)]
[version] 2.21
Change-Id: Id7ba90815fd7970998c28343c0b1e5cce6fac32f
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:51:51 +0000 (06:51 +0000)]
Merge "[IoTcon] Fix query creation for requests" into tizen_3.0
Rafal Walczyna [Tue, 17 Apr 2018 12:39:23 +0000 (14:39 +0200)]
[IoTcon] Fix query creation for requests
[Bug] query was not created properly when there was no
resource interface set
[Verification] 100% passrate on TM1
Change-Id: Iea1db9418fe10e9fad56a9bb7de1c34c95cbc5dd
Signed-off-by: Rafal Walczyna <r.walczyna@partner.samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:11:18 +0000 (08:11 +0200)]
[Spec] Fixing build dependency
[Verification] Code compiles without errors.
Change-Id: I7bc3f9c4ed440ab00822366c49843228be626b62
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Wed, 18 Apr 2018 06:05:48 +0000 (08:05 +0200)]
[Spec] Fixing build dependency
[Verification] Code compiles without errors.
Change-Id: I7bc3f9c4ed440ab00822366c49843228be626b62
Signed-off-by: Piotr Kosko <p.kosko@samsung.com>
Piotr Kosko [Tue, 17 Apr 2018 12:56:43 +0000 (12:56 +0000)]
Merge "[Power] Prevent override of power level locked with Web API" into tizen_3.0
Piotr Kosko [Tue, 17 Apr 2018 12:54:29 +0000 (12:54 +0000)]
Merge "[Power] Refactoring module" into tizen_3.0
Piotr Kosko [Tue, 17 Apr 2018 11:13:37 +0000 (11:13 +0000)]
Merge "[Application] Add removing event_handler in destructor." into tizen_4.0
Lukasz Bardeli [Tue, 17 Apr 2018 09:07:51 +0000 (11:07 +0200)]
[Application] Add removing event_handler in destructor.
Removing all event_handler from events while closing application.
Without removing event_handler it is possible that native api will call
event with destroyed data. This fix is to prevent such situation
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I94d1fbb85ad47ca6dbcba6c56cd043521952860e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Lukasz Bardeli [Tue, 17 Apr 2018 08:45:24 +0000 (10:45 +0200)]
[Application] Add removing event_handler in destructor.
Removing all event_handler from events while closing application.
Without removing event_handler it is possible that native api will call
event with destroyed data. This fix is to prevent such situation
[Verification] Code compiles without error. TCT passrate 100%
Change-Id: I94d1fbb85ad47ca6dbcba6c56cd043521952860e
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
Pawel Wasowski [Wed, 4 Apr 2018 16:33:30 +0000 (18:33 +0200)]
[Power] Prevent override of power level locked with Web API
Chromium used to override power level locked by Web API with its own
settings. The level set by Web API was not restored.
From now on, Chromium will not override power level lock, after receiving
"__DisableChromiumInternalPowerLock" message from the Web API
and will be able to control the locked power level,
after receiving "__EnableChromiumInternalPowerLock" message.
Change-Id: Ia14f873766e26bd02ae7eecb182c69e0b6af00e8
Signed-off-by: Pawel Wasowski <p.wasowski2@partner.samsung.com>
Szymon Jastrzebski [Tue, 10 Oct 2017 06:56:25 +0000 (08:56 +0200)]
[Power] Refactoring module
Previous implementation depended partly on Deviced functions through the
dbus interface. Currently, the implementation uses only DeviceD Native API
(except the ReleaseBrightness and SetBrightness methods).
TheReleaseBrightness is still not wrapped into the Native C DeviceD API).
[Verification] TCT pass: A/M - 100%.
Change-Id: I03124c0d332bf03cd5481ac2b38c9e5c9a534063
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
Piotr Kosko [Mon, 16 Apr 2018 07:57:46 +0000 (07:57 +0000)]
Merge "[Power] Prevent override of power level locked with Web API" into tizen_4.0
Piotr Kosko [Mon, 16 Apr 2018 07:43:11 +0000 (07:43 +0000)]
Merge "[Power] Refactoring module" into tizen_4.0
Piotr Kosko [Fri, 6 Apr 2018 09:04:22 +0000 (11:04 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0
Conflicts:
src/download/download_instance.cc
src/download/download_instance.h
Change-Id: Idd927480881807d231e7edf17319e092e8ded81c
Piotr Kosko [Fri, 6 Apr 2018 07:29:15 +0000 (09:29 +0200)]
[version] 2.20
Change-Id: I8c11218bf7cb61b4dcc530a205e7a4bfc1d94be9