Fix memory leak 11/215411/1 submit/tizen/20191008.024317 submit/tizen/20191008.063144
authorjinwang.an <jinwang.an@samsung.com>
Tue, 8 Oct 2019 02:36:03 +0000 (11:36 +0900)
committerjinwang.an <jinwang.an@samsung.com>
Tue, 8 Oct 2019 02:36:03 +0000 (11:36 +0900)
Change-Id: Ica5169f35d0d062d7cdf27dcb2c4006fdc50d7b5
Signed-off-by: jinwang.an <jinwang.an@samsung.com>
src/system_setting_platform.c

index 0f51563..174d697 100644 (file)
@@ -93,7 +93,7 @@ static void dl_font_config_set_notification();
 int system_setting_get_incoming_call_ringtone(system_settings_key_e key, void **value)
 {
        SETTING_TRACE_BEGIN;
-       char *vconf_value;
+       char *vconf_value = NULL;
        if (system_setting_vconf_get_value_string(VCONFKEY_SETAPPL_CALL_RINGTONE_PATH_STR, &vconf_value)) {
                return SYSTEM_SETTINGS_ERROR_IO_ERROR;
        }
@@ -105,6 +105,7 @@ int system_setting_get_incoming_call_ringtone(system_settings_key_e key, void **
                *value = vconf_value;
        } else { /* not zero on errro */
                *value = vconf_get_str(VCONFKEY_SETAPPL_CALL_RINGTONE_DEFAULT_PATH_STR);
+               free(vconf_value);
        }
 
        /**value = vconf_value; */
@@ -115,7 +116,7 @@ int system_setting_get_incoming_call_ringtone(system_settings_key_e key, void **
 int system_setting_get_email_alert_ringtone(system_settings_key_e key, void **value)
 {
        SETTING_TRACE_BEGIN;
-       char *vconf_value;
+       char *vconf_value = NULL;
        if (system_setting_vconf_get_value_string(VCONFKEY_SETAPPL_NOTI_MSG_RINGTONE_PATH_STR, &vconf_value)) {
                return SYSTEM_SETTINGS_ERROR_IO_ERROR;
        }
@@ -127,6 +128,7 @@ int system_setting_get_email_alert_ringtone(system_settings_key_e key, void **va
                *value = vconf_value;
        } else { /* not zero on errro */
                *value = vconf_get_str(VCONFKEY_SETAPPL_NOTI_RINGTONE_DEFAULT_PATH_STR);
+               free(vconf_value);
        }
 
        return SYSTEM_SETTINGS_ERROR_NONE;
@@ -262,6 +264,7 @@ int system_setting_get_lockscreen_app(system_settings_key_e key, void **value)
        }
 
        if (pkg_name && strcmp(pkg_name, "com.samsung.lockscreen") == 0 && locktype == SETTING_SCREEN_LOCK_TYPE_PASSWORD) {
+               free(pkg_name);
                return SYSTEM_SETTINGS_ERROR_LOCKSCREEN_APP_PASSWORD_MODE;
        }