Print error log when check_privilege() failed

Change-Id: I19e48476e1da830a4da32f9860acdaf80497b529
Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>

diff --git a/src/package_info.c b/src/package_info.c
index 742cf61..52e2952 100644 (file)
--- a/src/package_info.c
+++ b/src/package_info.c
@@ -394,7 +394,7 @@ API int package_info_get_tep_name(package_info_h package_info, char **name)
 
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        if (pkgmgrinfo_pkginfo_get_tep_name(package_info->pkgmgr_pkginfo, &tepname_tmp) != PMINFO_R_OK)
                /* just return error without error log, because most of packages doesn't use tep */

diff --git a/src/package_manager.c b/src/package_manager.c
index 6d8f22e..adcdc0d 100644 (file)
--- a/src/package_manager.c
+++ b/src/package_manager.c
@@ -329,7 +329,7 @@ API int package_manager_request_set_event_cb(package_manager_request_h request,
 
        ret = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (ret != PACKAGE_MANAGER_ERROR_NONE)
-               return ret;
+               return package_manager_error(ret, __FUNCTION__, NULL);
 
        return __reset_user_request_callback(request, callback, user_data);
 }
@@ -1310,7 +1310,7 @@ API int package_manager_create(package_manager_h *manager)
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        struct package_manager_s *package_manager = NULL;
 
@@ -1656,7 +1656,7 @@ API int package_manager_set_event_cb(package_manager_h manager,
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        if (package_manager_validate_handle(manager)) {
                return
@@ -1773,7 +1773,7 @@ API int package_manager_get_package_id_by_app_id(const char *app_id, char **pack
 
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        if (app_id == NULL || package_id == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
@@ -1810,7 +1810,7 @@ API int package_manager_get_package_info(const char *package_id, package_info_h
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        retval = package_info_get_package_info(package_id, package_info);
 
@@ -1826,7 +1826,7 @@ API int package_manager_foreach_package_info(package_manager_package_info_cb cal
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        retval = package_info_foreach_package_info(callback, user_data);
 
@@ -1870,7 +1870,7 @@ API int package_manager_is_preload_package_by_app_id(const char *app_id, bool *p
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        pkgmgrinfo_appinfo_h pkgmgrinfo_appinfo = NULL;
        pkgmgrinfo_pkginfo_h pkgmgrinfo_pkginfo = NULL;
@@ -1920,7 +1920,7 @@ API int package_manager_get_permission_type(const char *app_id, package_manager_
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        pkgmgrinfo_appinfo_h pkgmgrinfo_appinfo = NULL;
        pkgmgrinfo_permission_type permission = 0;
@@ -2185,7 +2185,7 @@ API int package_manager_filter_create(package_manager_filter_h *handle)
 
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        if (handle == NULL) {
                return
@@ -2272,7 +2272,7 @@ API int package_manager_filter_count(package_manager_filter_h handle, int *count
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        if ((handle == NULL) || (count == NULL))
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
@@ -2292,7 +2292,7 @@ API int package_manager_filter_foreach_package_info(package_manager_filter_h han
        int retval;
        retval = check_privilege(PRIVILEGE_PACKAGE_MANAGER_INFO);
        if (retval != PACKAGE_MANAGER_ERROR_NONE)
-               return retval;
+               return package_manager_error(retval, __FUNCTION__, NULL);
 
        retval = package_info_filter_foreach_package_info(handle, callback, user_data);
 
@@ -2742,7 +2742,7 @@ API int package_manager_res_event_info_get_error_code(
 
        ret = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
        if (ret != PACKAGE_MANAGER_ERROR_NONE)
-               return ret;
+               return package_manager_error(ret, __FUNCTION__, NULL);
 
        if (handle == NULL || error == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
@@ -2821,7 +2821,7 @@ API int package_manager_res_event_info_foreach_path(
 
        ret = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
        if (ret != PACKAGE_MANAGER_ERROR_NONE)
-               return ret;
+               return package_manager_error(ret, __FUNCTION__, NULL);
 
        if (handle == NULL || callback == NULL)
                return package_manager_error(PACKAGE_MANAGER_ERROR_INVALID_PARAMETER, __FUNCTION__, NULL);
@@ -2856,7 +2856,7 @@ API int package_manager_get_priv_shared_res_path(const char *package_id, char **
 
        ret = check_privilege(PRIVILEGE_PACKAGE_MANAGER_ADMIN);
        if (ret != PACKAGE_MANAGER_ERROR_NONE)
-               return ret;
+               return package_manager_error(ret, __FUNCTION__, NULL);
 
        if (package_id == NULL || path == NULL)
                return package_manager_error(