Fix coverity issue - Unchecked return value 79/260879/2 accepted/tizen/unified/20210707.070908 submit/tizen/20210706.083607
authorJeongmo Yang <jm80.yang@samsung.com>
Tue, 6 Jul 2021 08:01:12 +0000 (17:01 +0900)
committerJeongmo Yang <jm80.yang@samsung.com>
Tue, 6 Jul 2021 08:33:04 +0000 (17:33 +0900)
[Version] 0.6.18
[Issue Type] Coverity

Change-Id: I335336489d9e0781c47541b4fa13ca71c1980083
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>
packaging/capi-media-codec.spec
src/media_codec_port_gst.c

index db1277c..1c1d0ba 100644 (file)
@@ -4,7 +4,7 @@
 
 Name:       capi-media-codec
 Summary:    A Media Codec library in Tizen Native API
-Version:    0.6.17
+Version:    0.6.18
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0
index 6465c59..9455e22 100644 (file)
@@ -2474,26 +2474,24 @@ GstMCBuffer *__mc_gst_make_media_packet(mc_gst_core_t *core, GstBuffer *buffer)
        void *data = NULL;
        gint size = 0;
 
-
-       mcbuffer = (GstMCBuffer *)g_malloc0(sizeof(*mcbuffer));
-
-       if (mcbuffer == NULL) {
-               LOGE("malloc fail");
-               return NULL;
-       }
-
        mem = gst_buffer_peek_memory(buffer, 0);
 
        if (gst_is_tizen_memory(mem)) {
                data = (void *)gst_tizen_memory_get_surface(mem);
                size = tbm_surface_internal_get_size((tbm_surface_h)data);
        } else {
-               gst_memory_map(mem, &map, GST_MAP_READ);
+               if (!gst_memory_map(mem, &map, GST_MAP_READ)) {
+                       LOGE("gst_memory_map failed for buffer[%p]", buffer);
+                       return NULL;
+               }
+
                data = map.data;
                size = map.size;
                gst_memory_unmap(mem, &map);
        }
 
+       mcbuffer = g_new0(GstMCBuffer, 1);
+
        mcbuffer->buffer = buffer;
        mcbuffer->core = core;
        mcbuffer->buf_size = size;