Fix returned value's in connection_profile_get_dhcp_lease_duration 68/142568/2 accepted/tizen/4.0/unified/20170828.223656 accepted/tizen/unified/20170811.021103 submit/tizen/20170808.043745 submit/tizen/20170809.085632 submit/tizen_4.0/20170828.100002
authorAbhishek Sansanwal <abhishek.s94@samsung.com>
Fri, 4 Aug 2017 09:21:33 +0000 (14:51 +0530)
committerAbhishek Sansanwal <abhishek.s94@samsung.com>
Fri, 4 Aug 2017 09:38:33 +0000 (15:08 +0530)
Description: Return invalid parameter in case the
passed address of dhcp_lease_duration in NULL.
Return not supported in case CAPI is called
for IPV6 address family.

Change-Id: Iafe92b2714c9044f23665d5135e949133bb0b7c0
Signed-off-by: Abhishek Sansanwal <abhishek.s94@samsung.com>
src/connection_profile.c

index e617348..7f54484 100755 (executable)
@@ -691,11 +691,18 @@ EXPORT_API int connection_profile_get_dhcp_lease_duration(
        CHECK_FEATURE_SUPPORTED(TELEPHONY_FEATURE, WIFI_FEATURE, TETHERING_BLUETOOTH_FEATURE, ETHERNET_FEATURE);
 
        if (!(_connection_libnet_check_profile_validity(profile)) ||
-           (address_family != CONNECTION_ADDRESS_FAMILY_IPV4)) {
+           (address_family != CONNECTION_ADDRESS_FAMILY_IPV4 &&
+               address_family != CONNECTION_ADDRESS_FAMILY_IPV6) ||
+               dhcp_lease_duration == NULL) {
                CONNECTION_LOG(CONNECTION_ERROR, "Invalid parameter");
                return CONNECTION_ERROR_INVALID_PARAMETER;
        }
 
+       if (address_family == CONNECTION_ADDRESS_FAMILY_IPV6) {
+               CONNECTION_LOG(CONNECTION_ERROR, "Not supported");
+               return CONNECTION_ERROR_ADDRESS_FAMILY_NOT_SUPPORTED;
+       }
+
        net_profile_info_t *profile_info = profile;
        net_dev_info_t *net_info = __profile_get_net_info(profile_info);
        if (net_info == NULL)