Fix coverity defects

- Operator precedence logic error
- Unchecked return value

[Version] 0.5.52
[Issue Type] Coverity

Change-Id: Ic1aa27763faa7139d3e9074cb774422edf444e60

diff --git a/packaging/capi-media-audio-io.spec b/packaging/capi-media-audio-io.spec
index 523dd6b..4d5f9ca 100644 (file)
--- a/packaging/capi-media-audio-io.spec
+++ b/packaging/capi-media-audio-io.spec
@@ -1,6 +1,6 @@
 Name:           capi-media-audio-io
 Summary:        An Audio Input & Audio Output library in Tizen Native API
-Version:        0.5.51
+Version:        0.5.52
 Release:        0
 Group:          Multimedia/API
 License:        Apache-2.0

diff --git a/src/cpp/CAudioIO.cpp b/src/cpp/CAudioIO.cpp
index 0d7bc43..0907dcf 100644 (file)
--- a/src/cpp/CAudioIO.cpp
+++ b/src/cpp/CAudioIO.cpp
@@ -227,7 +227,7 @@ void CAudioIO::setStreamInfo(sound_stream_info_h stream_info) {
     if (mDirection == CAudioInfo::EAudioDirection::AUDIO_DIRECTION_IN) {
         int device_id;
 
-        if ((errorCode = sound_manager_get_echo_cancel_reference_device(stream_info, &device_id) != SOUND_MANAGER_ERROR_NONE))
+        if ((errorCode = sound_manager_get_echo_cancel_reference_device(stream_info, &device_id)) != SOUND_MANAGER_ERROR_NONE)
             THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "Can't get reference device [ret:%d]", errorCode); //LCOV_EXCL_LINE
 
         if (device_id != SOUND_MANAGER_STREAM_NO_REFERENCE_DEVICE)

diff --git a/test/audio_io_test.c b/test/audio_io_test.c
index 2175b06..2904167 100644 (file)
--- a/test/audio_io_test.c
+++ b/test/audio_io_test.c
@@ -367,7 +367,8 @@ out:
        }
 
        if (device_list)
-               sound_manager_free_device_list(device_list);
+               if (sound_manager_free_device_list(device_list) != SOUND_MANAGER_ERROR_NONE)
+                       printf("fail to free device list\n");
 
        pthread_exit(0);