powerpc: 512x: Fix mpc5121_clk_get()
authorRichard Weinberger <richard@nod.at>
Mon, 26 Mar 2012 09:01:29 +0000 (09:01 +0000)
committerAnatolij Gustschin <agust@denx.de>
Sun, 9 Sep 2012 19:36:05 +0000 (21:36 +0200)
If try_module_get() fails, mpc5121_clk_get() might return
a wrong clock.

Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Anatolij Gustschin <agust@denx.de>
arch/powerpc/platforms/512x/clock.c

index 1d8700f..9f771e0 100644 (file)
@@ -54,14 +54,16 @@ static DEFINE_MUTEX(clocks_mutex);
 static struct clk *mpc5121_clk_get(struct device *dev, const char *id)
 {
        struct clk *p, *clk = ERR_PTR(-ENOENT);
-       int dev_match = 0;
-       int id_match = 0;
+       int dev_match;
+       int id_match;
 
        if (dev == NULL || id == NULL)
                return clk;
 
        mutex_lock(&clocks_mutex);
        list_for_each_entry(p, &clocks, node) {
+               dev_match = id_match = 0;
+
                if (dev == p->dev)
                        dev_match++;
                if (strcmp(id, p->name) == 0)