tegra: simplify use of devm_ioremap_resource
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 14 Aug 2013 09:11:10 +0000 (11:11 +0200)
committerStephen Warren <swarren@nvidia.com>
Thu, 15 Aug 2013 22:04:42 +0000 (16:04 -0600)
Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Warren <swarren@nvidia.com>
drivers/iommu/tegra-smmu.c
drivers/memory/tegra20-mc.c
drivers/memory/tegra30-mc.c

index f6f120e..e066560 100644 (file)
@@ -1177,8 +1177,6 @@ static int tegra_smmu_probe(struct platform_device *pdev)
                struct resource *res;
 
                res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-               if (!res)
-                       return -ENODEV;
                smmu->regs[i] = devm_ioremap_resource(&pdev->dev, res);
                if (IS_ERR(smmu->regs[i]))
                        return PTR_ERR(smmu->regs[i]);
index 0548eea..7cd82b8 100644 (file)
@@ -218,8 +218,6 @@ static int tegra20_mc_probe(struct platform_device *pdev)
                struct resource *res;
 
                res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-               if (!res)
-                       return -ENODEV;
                mc->regs[i] = devm_ioremap_resource(&pdev->dev, res);
                if (IS_ERR(mc->regs[i]))
                        return PTR_ERR(mc->regs[i]);
index 58d2979..ef79345 100644 (file)
@@ -340,8 +340,6 @@ static int tegra30_mc_probe(struct platform_device *pdev)
                struct resource *res;
 
                res = platform_get_resource(pdev, IORESOURCE_MEM, i);
-               if (!res)
-                       return -ENODEV;
                mc->regs[i] = devm_ioremap_resource(&pdev->dev, res);
                if (IS_ERR(mc->regs[i]))
                        return PTR_ERR(mc->regs[i]);