pinctrl: imx: do not fail when parsing a function fails
authorSascha Hauer <s.hauer@pengutronix.de>
Fri, 9 Aug 2013 12:20:53 +0000 (14:20 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 15 Aug 2013 20:13:21 +0000 (22:13 +0200)
When parsing a function fails this is no reason to make the whole
driver fail. Just continue with the next function.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/pinctrl-imx.c

index b8077d9..81ffb17 100644 (file)
@@ -550,7 +550,6 @@ static int imx_pinctrl_probe_dt(struct platform_device *pdev,
 {
        struct device_node *np = pdev->dev.of_node;
        struct device_node *child;
-       int ret;
        u32 nfuncs = 0;
        u32 i = 0;
 
@@ -577,13 +576,8 @@ static int imx_pinctrl_probe_dt(struct platform_device *pdev,
        if (!info->groups)
                return -ENOMEM;
 
-       for_each_child_of_node(np, child) {
-               ret = imx_pinctrl_parse_functions(child, info, i++);
-               if (ret) {
-                       dev_err(&pdev->dev, "failed to parse function\n");
-                       return ret;
-               }
-       }
+       for_each_child_of_node(np, child)
+               imx_pinctrl_parse_functions(child, info, i++);
 
        return 0;
 }