thermal: exynos: fix error return code
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 29 Dec 2013 22:47:38 +0000 (23:47 +0100)
committerZhang Rui <rui.zhang@intel.com>
Thu, 2 Jan 2014 01:54:45 +0000 (09:54 +0800)
Set the return variable to an error code as done elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
drivers/thermal/samsung/exynos_tmu.c

index 32f38b9..0d96a51 100644 (file)
@@ -205,6 +205,7 @@ static int exynos_tmu_initialize(struct platform_device *pdev)
 skip_calib_data:
        if (pdata->max_trigger_level > MAX_THRESHOLD_LEVS) {
                dev_err(&pdev->dev, "Invalid max trigger level\n");
+               ret = -EINVAL;
                goto out;
        }