Remove unnecessary repetition of initializing feedback library.
authorSanghyup Lee <sh53.lee@samsung.com>
Thu, 25 Jul 2013 02:03:01 +0000 (11:03 +0900)
committerSanghyup Lee <sh53.lee@samsung.com>
Fri, 26 Jul 2013 00:50:09 +0000 (09:50 +0900)
[Title] Remove unnecessary repetition of initializing feedback library.
[Issue#] N/A
[Problem] N/A
[Cause] We don't need to initialize feedback library each time.
[Solution] Move initialize method into getHandle method that called only one time. and remove deinitialize.

Change-Id: I07152592eed156f5c5ffcc648802fe7946a7004d

Source/WebCore/platform/efl/tizen/TizenLinkEffect.cpp

index 6158a09..87faff3 100644 (file)
@@ -32,9 +32,7 @@
 
 namespace WebCore {
 
-static int (*feedback_initialize)();
 static int (*feedback_play)(int);
-static int (*feedback_deinitialize)();
 
 static void* getHandle()
 {
@@ -42,7 +40,7 @@ static void* getHandle()
     if (!handle)
         return 0;
 
-    feedback_initialize = (int(*)(void))dlsym(handle, "feedback_initialize");
+    int (*feedback_initialize)() = (int(*)(void))dlsym(handle, "feedback_initialize");
     if (!feedback_initialize) {
         dlclose(handle);
         return 0;
@@ -54,12 +52,7 @@ static void* getHandle()
         return 0;
     }
 
-    feedback_deinitialize = (int(*)(void))dlsym(handle, "feedback_deinitialize");
-    if (!feedback_deinitialize) {
-        dlclose(handle);
-        return 0;
-    }
-
+    feedback_initialize();
     return handle;
 }
 
@@ -70,9 +63,7 @@ void TizenLinkEffect::playLinkEffect()
     if (!handle)
         return;
 
-    feedback_initialize();
     feedback_play(FEEDBACK_PATTERN_TAP);
-    feedback_deinitialize();
 }
 
 }