projects / framework / web / webkit-efl.git / commitdiff
? search:
summary | shortlog | log | commit | commitdiff | tree
raw | patch | inline | side by side (parent: 85ee0c1)
Remove security concerned logs
authorJihye Kang <jye.kang@samsung.com>
Fri, 12 Apr 2013 08:33:09 +0000 (17:33 +0900)
committerGerrit Code Review <gerrit2@kim11>
Fri, 12 Apr 2013 09:05:59 +0000 (18:05 +0900)
[Title] Remove security concerned logs
[Issue#] N/A
[Problem] Fails on LoggingChecker while testing html5 APIs
[Cause] url is printed by log
[Solution] remove logs printing url

Change-Id: If55249cdb4c34f104bc6066c1ed658f290a49a54

Source/WebKit2/UIProcess/API/efl/ewk_context.cpp patch | blob | history
Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp patch | blob | history
Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp patch | blob | history

diff --git a/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp b/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
index 045ed3b..89b9a5e 100755 (executable)
--- a/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
+++ b/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
@@ -840,7 +840,6 @@ Eina_Bool ewk_context_application_cache_delete(Ewk_Context* ewkContext, Ewk_Secu
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> securityOriginRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
@@ -940,7 +939,6 @@ Eina_Bool ewk_context_application_cache_usage_for_origin_get(Ewk_Context* ewkCon
     EINA_SAFETY_ON_NULL_RETURN_VAL(callback, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     Ewk_Context_Callback_Context* context = new Ewk_Context_Callback_Context;
     context->webApplicationCacheUsageForOriginCallback = callback;
     context->userData = userData;
@@ -1071,7 +1069,6 @@ Eina_Bool ewk_context_local_file_system_delete(Ewk_Context* ewkContext, Ewk_Secu
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> originRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
@@ -1117,7 +1114,6 @@ Ewk_Security_Origin* ewk_context_web_database_exceeded_quota_security_origin_get
 #if ENABLE(TIZEN_SQL_DATABASE)
     EINA_SAFETY_ON_NULL_RETURN_VAL(exceededQuota, 0);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(exceededQuota->origin));
     return exceededQuota->origin;
 #else
     return 0;
@@ -1227,7 +1223,6 @@ Eina_Bool ewk_context_web_database_delete(Ewk_Context* ewkContext, Ewk_Security_
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> originRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
@@ -1301,7 +1296,6 @@ Eina_Bool ewk_context_web_database_quota_for_origin_get(Ewk_Context* ewkContext,
     EINA_SAFETY_ON_NULL_RETURN_VAL(callback, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     Ewk_Context_Callback_Context* context = new Ewk_Context_Callback_Context;
     context->webDatabaseQuotaCallback = callback;
     context->userData = userData;
@@ -1338,7 +1332,6 @@ Eina_Bool ewk_context_web_database_quota_for_origin_set(Ewk_Context* ewkContext,
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s) quota(%d)", ewk_security_origin_host_get(origin), quota);
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> originRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
@@ -1358,7 +1351,6 @@ Eina_Bool ewk_context_web_database_usage_for_origin_get(Ewk_Context* ewkContext,
     EINA_SAFETY_ON_NULL_RETURN_VAL(callback, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     Ewk_Context_Callback_Context* context = new Ewk_Context_Callback_Context;
     context->webDatabaseQuotaCallback = callback;
     context->userData = userData;
@@ -1420,7 +1412,6 @@ Eina_Bool ewk_context_web_storage_origin_delete(Ewk_Context* ewkContext, Ewk_Sec
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkContext, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKStringRef> protocolRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_protocol_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> securityOriginRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
@@ -1494,7 +1485,6 @@ Eina_Bool ewk_context_web_storage_usage_for_origin_get(Ewk_Context* ewkContext,
     EINA_SAFETY_ON_NULL_RETURN_VAL(callback, false);
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, false);
 
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(origin));
     Ewk_Context_Callback_Context* context = new Ewk_Context_Callback_Context;
     context->webStorageUsageCallback = callback;
     context->userData = userData;
diff --git a/Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp b/Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp
index 1841a82..2da5316 100755 (executable)
--- a/Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp
+++ b/Source/WebKit2/UIProcess/API/efl/ewk_notification.cpp
@@ -177,7 +177,6 @@ const char* ewk_notification_icon_url_get(const Ewk_Notification* ewkNotificatio
 {
 #if ENABLE(TIZEN_NOTIFICATIONS)
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkNotification, 0);
-    TIZEN_LOGI("icon url (%s)", ewkNotification->iconURL);
 
     return ewkNotification->iconURL;
 #else
@@ -231,7 +230,6 @@ const Ewk_Security_Origin* ewk_notification_permission_request_origin_get(const
 {
 #if ENABLE(TIZEN_NOTIFICATIONS)
     EINA_SAFETY_ON_NULL_RETURN_VAL(permissionRequest, 0);
-    TIZEN_LOGI("host(%s)", ewk_security_origin_host_get(permissionRequest->origin));
 
     return permissionRequest->origin;
 #else
@@ -253,7 +251,6 @@ void ewk_notification_permission_request_set(Ewk_Notification_Permission_Request
     WKRetainPtr<WKStringRef> hostRef(AdoptWK, WKStringCreateWithUTF8CString(ewk_security_origin_host_get(origin)));
     WKRetainPtr<WKSecurityOriginRef> securityOriginRef(AdoptWK, WKSecurityOriginCreate(protocolRef.get(), hostRef.get(), ewk_security_origin_port_get(origin)));
     WKNotificationManagerRef notificationManagerRef = WKContextGetNotificationManager(ewk_view_context_get(permissionRequest->ewkView)->wkContext());
-    TIZEN_LOGI("host(%s)", ewk_security_origin_host_get(origin));
 
     WKNotificationManagerProviderDidUpdateNotificationPolicy(notificationManagerRef, securityOriginRef.get(), static_cast<bool>(allowed));
 
@@ -318,7 +315,6 @@ const Ewk_Security_Origin* ewk_notification_security_origin_get(const Ewk_Notifi
 {
 #if ENABLE(TIZEN_NOTIFICATIONS)
     EINA_SAFETY_ON_NULL_RETURN_VAL(ewkNotification, 0);
-    TIZEN_LOGI("host (%s)", ewk_security_origin_host_get(ewkNotification->securityOrigin));
 
     return ewkNotification->securityOrigin;
 #else
diff --git a/Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp b/Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp
index e556aad..a565181 100644 (file)
--- a/Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp
+++ b/Source/WebKit2/UIProcess/API/efl/ewk_security_origin.cpp
@@ -55,7 +55,6 @@ void deleteSecurityOrigin(Ewk_Security_Origin* origin)
 const char* ewk_security_origin_host_get(const Ewk_Security_Origin* origin)
 {
     EINA_SAFETY_ON_NULL_RETURN_VAL(origin, 0);
-    TIZEN_LOGI("host (%s)", origin->host);
 
     return origin->host;
 }
Domain: Web Framework / Uncategorized;