Tools/ChangeLog-2012-05-22

   1 2012-05-21  Gavin Barraclough  <barraclough@apple.com>
   2
   3         Disable private names by default in WebCore
   4         https://bugs.webkit.org/show_bug.cgi?id=87088
   5
   6         Reviewed by Geoff Garen.
   7
   8         r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
   9         These are probably not yet ready to be web-facing, so disabling by default in WebCore.
  10         Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
  11
  12         * DumpRenderTree/mac/DumpRenderTree.mm:
  13         (resetDefaultsToConsistentValues):
  14             - Enable private name support in DRT.
  15         * WebKitTestRunner/TestController.cpp:
  16         (WTR::TestController::resetStateToConsistentValues):
  17             - Enable private name support in WKTR.
  18
  19 2012-05-22  Martin Robinson  <mrobinson@igalia.com>
  20
  21         Fix a small syntax error in the GTK+ API test runner.
  22
  23         Reviewed by Gustavo Noronha Silva.
  24
  25         * gtk/run-api-tests:
  26         (TestRunner._setup_testing_environment): When reporting the error use
  27         the correct Python format string syntax.
  28
  29 2012-05-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
  30
  31         [GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
  32         https://bugs.webkit.org/show_bug.cgi?id=86962
  33
  34         Reviewed by Gustavo Noronha Silva.
  35
  36         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  37         (LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.
  38
  39 2012-05-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
  40
  41         [EFL][DRT] Key modifier bit flags have enum type.
  42         https://bugs.webkit.org/show_bug.cgi?id=86838
  43
  44         Reviewed by Antonio Gomes.
  45
  46         Refactoring. Key modifier flags are unsigned int.
  47         Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers
  48         at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift)
  49         would have been out of EvasKeyModifier enum.
  50
  51         * DumpRenderTree/efl/EventSender.cpp:
  52         (KeyEventInfo::KeyEventInfo):
  53         (KeyEventInfo):
  54         (MouseEventInfo::MouseEventInfo):
  55         (MouseEventInfo):
  56         (setEvasModifiers):
  57         (modifiersFromJSValue):
  58         (mouseDownCallback):
  59         (mouseUpCallback):
  60         (keyPadNameFromJSValue):
  61         (keyNameFromJSValue):
  62         (createKeyEventInfo):
  63         (sendKeyDown):
  64
  65 2012-05-22  Takashi Sakamoto  <tasak@google.com>
  66
  67         Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
  68         https://bugs.webkit.org/show_bug.cgi?id=86694
  69
  70         Modify keyDown to create left- and right- control, shift, and alt
  71         keyevent for a test to check that keyLocation property can have
  72         DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
  73         DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.
  74
  75         Reviewed by Alexey Proskuryakov.
  76
  77         * DumpRenderTree/chromium/EventSender.cpp:
  78         (EventSender::keyDown):
  79         * DumpRenderTree/mac/EventSendingController.mm:
  80         (-[EventSendingController keyDown:withModifiers:withLocation:]):
  81
  82 2012-05-22  Christophe Dumez  <christophe.dumez@intel.com>
  83
  84         [EFL] EFL's DRT needs to print information about received Web Intents
  85         https://bugs.webkit.org/show_bug.cgi?id=86864
  86
  87         Reviewed by Adam Barth.
  88
  89         Catch "intent,new" signal in EFL's DumpRenderTree and dump information
  90         about the intent. This output is expected by several webintents test
  91         cases.
  92
  93         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  94         (DumpRenderTreeChrome::createView):
  95         (DumpRenderTreeChrome::onFrameCreated):
  96         (DumpRenderTreeChrome::onFrameIntentNew):
  97         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  98         (DumpRenderTreeChrome):
  99
 100 2012-05-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 101
 102         [EFL] Add support to enable/disable DOM paste
 103         https://bugs.webkit.org/show_bug.cgi?id=85040
 104
 105         Reviewed by Gustavo Noronha Silva.
 106
 107         Enable JavascriptCanAccessClipboard setting on each test startup so
 108         that test cases which rely on clipboard can be unskipped.
 109
 110         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 111         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 112
 113 2012-05-22  Hugo Parente Lima  <hugo.lima@openbossa.org>
 114
 115         [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
 116         https://bugs.webkit.org/show_bug.cgi?id=87044
 117
 118         Reviewed by Alexis Menard.
 119
 120         Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent
 121
 122         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
 123         (WTR::EventSenderProxy::keyDown):
 124
 125 2012-05-22  Zan Dobersek  <zandobersek@gmail.com>
 126
 127         [Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
 128         https://bugs.webkit.org/show_bug.cgi?id=86284
 129
 130         Reviewed by Martin Robinson.
 131
 132         Paint the current dirty regions of the web view once more before
 133         dumping pixel results.
 134
 135         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 136         (dump):
 137
 138 2012-05-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
 139
 140         GCC 4.7 and C++11 support.
 141         https://bugs.webkit.org/show_bug.cgi?id=86465
 142
 143         Reviewed by Darin Adler.
 144
 145         Update detection of C++11 mode in GCC.
 146
 147         * qmake/mkspecs/features/unix/default_post.prf:
 148
 149 2012-05-22  Hao Zheng  <zhenghao@chromium.org>
 150
 151         [chromium] WebViewHost should use ENABLE guards for some features.
 152         https://bugs.webkit.org/show_bug.cgi?id=87087
 153
 154         Reviewed by Kent Tamura.
 155
 156         These features are disabled on OS(ANDROID) and so shouldn't be
 157         compiled when the feature is off.
 158
 159         * DumpRenderTree/chromium/WebViewHost.cpp:
 160         (WebViewHost::reset):
 161         * DumpRenderTree/chromium/WebViewHost.h:
 162         (WebViewHost):
 163
 164 2012-05-21  Christophe Dumez  <christophe.dumez@intel.com>
 165
 166         [EFL] EFL's DumpRenderTree does not print didReceiveTitle messages
 167         https://bugs.webkit.org/show_bug.cgi?id=85971
 168
 169         Reviewed by Antonio Gomes.
 170
 171         Listen for the "title,changed" signal on the frames instead of the
 172         view so that we get notified for other frame than the main one.
 173         Print out the didReceiveTitle messages which are expected if
 174         LayoutTestController's dumpFrameLoadCallbacks() returns true.
 175
 176         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 177         (DumpRenderTreeChrome::createView):
 178         (DumpRenderTreeChrome::onFrameTitleChanged):
 179         (DumpRenderTreeChrome::onFrameCreated):
 180         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
 181         (DumpRenderTreeChrome):
 182
 183 2012-05-21  Raphael Kubo da Costa  <rakuco@webkit.org>
 184
 185         [EFL] Unreviewed, reverting r116461.
 186
 187         r116461 caused a regression in the pixel tests, as scrollbars
 188         stopped being rendered in the PNGs.
 189
 190         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
 191         (createBitmapContextFromWebView):
 192
 193 2012-05-21  Brady Eidson  <beidson@apple.com>
 194
 195         <rdar://problem/11460336> and https://bugs.webkit.org/show_bug.cgi?id=87061
 196         WKPageGetScaleFactor can return 0.0 after a session is restored
 197
 198         Reviewed by Beth Dakin.
 199
 200         Loads a simple page, creates a session from it, restores that session, then
 201         queries the page scale factor for the appropriate value of 1.0.
 202
 203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 204         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Added.
 205         (TestWebKitAPI):
 206         (TestWebKitAPI::didFinishLoadForFrame):
 207         (TestWebKitAPI::setPageLoaderClient):
 208         (TestWebKitAPI::createSessionState):
 209         (TestWebKitAPI::TEST):
 210
 211 2012-05-21  Hugo Parente Lima  <hugo.lima@openbossa.org>
 212
 213         [WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp
 214         https://bugs.webkit.org/show_bug.cgi?id=87047
 215
 216         Reviewed by Alexis Menard.
 217
 218         * WebKitTestRunner/TestController.cpp:
 219         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 220
 221 2012-05-21  Dirk Pranke  <dpranke@chromium.org>
 222
 223         webkitpy: clean up the TestExpectations constructor
 224         https://bugs.webkit.org/show_bug.cgi?id=86926
 225
 226         Reviewed by Ojan Vafai.
 227
 228         The TestExpectations constructor was attempting to pretend
 229         it didn't need to get stuff from the Port, and as a result we
 230         had a complicated constructor with a bunch of arguments, and
 231         calling it was too complicated (although it made testing a
 232         little easier and simplified the style checker).
 233
 234         This patch has the constructor pull all the data it needs from
 235         the port directly, and allows us to delete a bunch of code.
 236
 237         * Scripts/webkitpy/layout_tests/controllers/manager.py:
 238         (Manager.parse_expectations):
 239         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 240         (ManagerTest.test_update_summary_with_result):
 241         (ResultSummaryTest.get_result_summary):
 242         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 243         (TestExpectations.__init__):
 244         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
 245         (parse_exp):
 246         (SkippedTests.check):
 247         (RemoveConfigurationsTest.test_remove):
 248         (test_remove_line):
 249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 250         (lint):
 251         (run):
 252         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 253         (LintTest.test_all_configurations.FakePort.__init__):
 254         (LintTest.test_all_configurations.FakePort.test_expectations):
 255         (LintTest.test_all_configurations.FakePort.skipped_layout_tests):
 256         (LintTest.test_all_configurations.FakePort):
 257         (LintTest.test_all_configurations.FakePort.all_test_configurations):
 258         (LintTest.test_all_configurations.FakePort.configuration_specifier_macros):
 259         (LintTest.test_all_configurations.FakePort.path_from_webkit_base):
 260         (LintTest.test_all_configurations.FakePort.get_option):
 261         (LintTest.test_all_configurations.FakeFactory.__init__):
 262         (LintTest.test_all_configurations.FakeFactory.all_port_names):
 263         (LintTest.test_all_configurations):
 264         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
 265         (Testprinter.get_result_summary):
 266         * Scripts/webkitpy/style/checkers/test_expectations.py:
 267         (TestExpectationsChecker.check_test_expectations):
 268         * Scripts/webkitpy/tool/commands/queries.py:
 269         (PrintExpectations._model):
 270         * Scripts/webkitpy/tool/commands/rebaseline.py:
 271         (RebaselineTest._update_expectations_file):
 272         (RebaselineExpectations._expectations):
 273
 274 2012-05-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 275
 276         [GTK] DRT support for layoutTestController.setSerializeHTTPLoads
 277         https://bugs.webkit.org/show_bug.cgi?id=86653
 278
 279         Reviewed by Gustavo Noronha Silva.
 280
 281         Add missing implementation setSerializeHTTPLoads to allow
 282         testing resource load order.
 283
 284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 285         (resetDefaultsToConsistentValues):
 286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 287         (LayoutTestController::setSerializeHTTPLoads):
 288
 289 2012-05-21  Elliot Poger  <epoger@chromium.org>
 290
 291         add skia_test_expectations override file to chromium NRWT
 292         https://bugs.webkit.org/show_bug.cgi?id=86749
 293
 294         Reviewed by Dirk Pranke
 295
 296         * Scripts/webkitpy/layout_tests/port/base.py:
 297         (Port.test_expectations_overrides):
 298         * Scripts/webkitpy/layout_tests/port/chromium.py:
 299         (ChromiumPort.test_expectations_overrides):
 300         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 301         (ChromiumPortTest.test_overrides_and_builder_names):
 302
 303 2012-05-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 304
 305         webkitdirs.pm: Fix undefined CXXFLAGS variable
 306         https://bugs.webkit.org/show_bug.cgi?id=87000
 307
 308         Reviewed by Martin Robinson.
 309
 310         Fixes a warning on Autotools and CMake buildsystem when
 311         CXXFLAGS is not defined.
 312
 313         * Scripts/webkitdirs.pm:
 314         (runAutogenForAutotoolsProjectIfNecessary):
 315         (generateBuildSystemFromCMakeProject):
 316
 317 2012-05-21  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 318
 319         Move setEditingBehavior() from layoutTestController to window.internals
 320         https://bugs.webkit.org/show_bug.cgi?id=42689
 321
 322         Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
 323
 324         Remove code that implements setEditingBehavior() for each platform. Note that
 325         During the InternalsObject reset the behavior is changed back to the platform
 326         default.
 327
 328         Qt and Chromium ports set a default editing behavior for running tests different
 329         from the platform default, so they still keep code for resetting to the desired
 330         editing behavior. Other ports use the their defaults, that are restored by
 331         internals object.
 332
 333         * DumpRenderTree/LayoutTestController.cpp:
 334         (LayoutTestController::staticFunctions):
 335         * DumpRenderTree/LayoutTestController.h:
 336         (LayoutTestController):
 337         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
 338         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
 339         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 340         * DumpRenderTree/chromium/LayoutTestController.cpp:
 341         (LayoutTestController::LayoutTestController):
 342         * DumpRenderTree/chromium/LayoutTestController.h:
 343         (LayoutTestController):
 344         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 345         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 346         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 347         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 348         * DumpRenderTree/mac/DumpRenderTree.mm:
 349         (resetDefaultsToConsistentValues):
 350         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 351         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 352         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
 353         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 354         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 355         (LayoutTestController):
 356         * DumpRenderTree/win/DumpRenderTree.cpp:
 357         (resetDefaultsToConsistentValues):
 358         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 359         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 360
 361 2012-05-21  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 362
 363         [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
 364         https://bugs.webkit.org/show_bug.cgi?id=86837
 365
 366         Reviewed by Kenneth Rohde Christiansen.
 367
 368         * DumpRenderTree/efl/EventSender.cpp:
 369         (keyNameFromJSValue): Added ESC key handling.
 370
 371 2012-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 372
 373         [GTK] Add GCancellable parameter to all methods using gio async pattern
 374         https://bugs.webkit.org/show_bug.cgi?id=86843
 375
 376         Reviewed by Gustavo Noronha Silva.
 377
 378         * MiniBrowser/gtk/BrowserWindow.c:
 379         (browser_window_load_uri):
 380
 381 2012-05-20  Daniel Bates  <dbates@webkit.org>
 382
 383         svn-apply cannot apply patches to files that contain space
 384         characters in their path
 385         https://bugs.webkit.org/show_bug.cgi?id=85742
 386
 387         Reviewed by Eric Seidel.
 388
 389         Fixes an issue where svn-apply cannot apply a patch to a file
 390         if there is a space in its file path.
 391
 392         The regular expression we were using to fix up +++/--- lines
 393         was too strict; it only matched file paths that contained non-
 394         whitespace characters. Instead, it's sufficient to match file
 395         paths whose characters aren't in the set {\t, \n, \r}.
 396
 397         * Scripts/VCSUtils.pm:
 398         (parseSvnDiffHeader):
 399         (runCommand): Added.
 400         * Scripts/svn-apply:
 401         (scmWillDeleteFile): Modified to call runCommand() so as to
 402         handle querying git for a file whose path may contain a space
 403         character.
 404         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
 405           - Added test case "new file with spaces in its name".
 406         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
 407
 408 2012-05-20  Daniel Bates  <dbates@webkit.org>
 409
 410         svn-apply fails to apply a patch that moves files from directory A to A/B
 411         https://bugs.webkit.org/show_bug.cgi?id=86973
 412
 413         Reviewed by Eric Seidel.
 414
 415         Fixes an issue where svn-apply fails to apply a patch that moves files in a
 416         directory A to some sub-directory B in A with a Git checkout of WebKit.
 417
 418         Currently, svn-apply only creates new directories along a file system path that
 419         it hasn't already processed. That is, if svn-apply creates/traverses all the
 420         intermediate directories along the path A/B then it will assume the directory A/B
 421         exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
 422         When moving a file F in directory A to directory A/B using a Git checkout, Git
 423         may remove directory A if F is the last file in A. Therefore, svn-apply will fail
 424         to create sub-directory B in A (since A no longer exists).
 425
 426         * Scripts/svn-apply:
 427         (addDirectoriesIfNeeded):
 428
 429 2012-05-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 430
 431         [Chromium] Print layout test result on buildbot
 432         https://bugs.webkit.org/show_bug.cgi?id=86965
 433
 434         Reviewed by Eric Seidel.
 435
 436         * Scripts/run-webkit-tests: Add chrome-bot to buildbot user list.
 437         (runningOnBuildBot):
 438
 439 2012-05-19  Kevin Ollivier  <kevino@theolliviers.com>
 440
 441         [wx] Unreviewed build fix. Don't stop the build if a build system update check fails.
 442
 443         * waf/build/build_utils.py:
 444         (download_if_newer):
 445
 446 2012-05-19  Ryosuke Niwa  <rniwa@webkit.org>
 447
 448         Build fix. Sometimes --suffixes isn't supplied.
 449
 450         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 451         (GardeningHTTPRequestHandler.rebaseline):
 452         (GardeningHTTPRequestHandler.optimizebaselines):
 453
 454 2012-05-19  Ryosuke Niwa  <rniwa@webkit.org>
 455
 456         Add "Lion" -> "mac-lion" to the builder port map.
 457
 458         * Scripts/webkitpy/layout_tests/port/builders.py:
 459
 460 2012-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
 461
 462         Unreviewed, rolling out r117675.
 463         http://trac.webkit.org/changeset/117675
 464         https://bugs.webkit.org/show_bug.cgi?id=86938
 465
 466         Broke builds. You can't initialize members by members
 467         themselves (Requested by rniwa on #webkit).
 468
 469         * DumpRenderTree/chromium/LayoutTestController.cpp:
 470         (LayoutTestController::numberOfPages):
 471         * DumpRenderTree/chromium/WebViewHost.cpp:
 472         (WebViewHost::printPage):
 473
 474 2012-05-18  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
 475
 476         [chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
 477         https://bugs.webkit.org/show_bug.cgi?id=86684
 478
 479         Reviewed by Darin Fisher.
 480
 481         * DumpRenderTree/chromium/LayoutTestController.cpp:
 482         (LayoutTestController::numberOfPages):
 483         * DumpRenderTree/chromium/WebViewHost.cpp:
 484         (WebViewHost::printPage):
 485
 486 2012-05-18  Raphael Kubo da Costa  <rakuco@webkit.org>
 487
 488         [EFL][DRT] Make it possible to enable CSS Grid Layout.
 489         https://bugs.webkit.org/show_bug.cgi?id=86921
 490
 491         Reviewed by Tony Chang.
 492
 493         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 494         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 495         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 496         (LayoutTestController::overridePreference):
 497
 498 2012-05-18  Dirk Pranke  <dpranke@chromium.org>
 499
 500         scm.add() doesn't work properly with svn 1.7
 501         https://bugs.webkit.org/show_bug.cgi?id=86779
 502
 503         Reviewed by Eric Seidel.
 504
 505         Re-land the change in r117526 with a fix to maintain
 506         compatibility with SVN 1.4.4 (yay Leopard!); turns out
 507         that "svn info foo" works correctly in 1.4.4 but
 508         "svn info" from the directory "foo" doesn't if foo is
 509         not part of a checkout. in_working_directory() and
 510         value_from_svn_info() were using the arguments inconsistently,
 511         leading to weird errors.
 512
 513         * Scripts/webkitpy/common/checkout/scm/scm.py:
 514         (SCM):
 515         (SCM.in_working_directory):
 516         * Scripts/webkitpy/common/checkout/scm/svn.py:
 517         (SVN):
 518         (SVN.in_working_directory):
 519
 520 2012-05-18  Levi Weintraub  <leviw@chromium.org>
 521
 522         Unreviewed. Moving myself from committer to reviewer.
 523
 524         * Scripts/webkitpy/common/config/committers.py:
 525
 526 2012-05-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 527
 528         [EFL] Buildbot output does not print result stats anymore
 529         https://bugs.webkit.org/show_bug.cgi?id=85366
 530
 531         Reviewed by Ryosuke Niwa.
 532
 533         Make run-webkit-tests pass --verbose to new-run-webkit-tests
 534         on EFL Debug bot.
 535
 536         * Scripts/run-webkit-tests:
 537         (runningOnBuildBot):
 538
 539 2012-05-18  Tony Chang  <tony@chromium.org>
 540
 541         remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
 542         https://bugs.webkit.org/show_bug.cgi?id=86767
 543
 544         Reviewed by Ojan Vafai.
 545
 546         * DumpRenderTree/chromium/LayoutTestController.cpp:
 547         (LayoutTestController::overridePreference):
 548         * DumpRenderTree/chromium/WebPreferences.cpp:
 549         (WebPreferences::reset):
 550         (WebPreferences::applyTo):
 551         * DumpRenderTree/chromium/WebPreferences.h:
 552         (WebPreferences):
 553         * Scripts/webkitperl/FeatureList.pm:
 554
 555 2012-05-18  Hugo Parente Lima  <hugo.lima@openbossa.org>
 556
 557         [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
 558         https://bugs.webkit.org/show_bug.cgi?id=86731
 559
 560         Reviewed by Simon Hausmann.
 561
 562         Set the page visibility on a single page instead of on all pages
 563         from the page group.
 564
 565         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 566         (WTR::LayoutTestController::setPageVisibility):
 567         (WTR::LayoutTestController::resetPageVisibility):
 568
 569 2012-05-18  Yi Shen  <yi.4.shen@nokia.com>
 570
 571         REGRESSION (r102553): Smart links do not work
 572         https://bugs.webkit.org/show_bug.cgi?id=85463
 573
 574         Reviewed by Ryosuke Niwa.
 575
 576         Add LayoutTestController::setAutomaticLinkDetectionEnabled().
 577
 578         * DumpRenderTree/LayoutTestController.cpp:
 579         (setAutomaticLinkDetectionEnabledCallback):
 580         (LayoutTestController::staticFunctions):
 581         * DumpRenderTree/LayoutTestController.h:
 582         (LayoutTestController):
 583         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 584         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 585         * DumpRenderTree/chromium/LayoutTestController.cpp:
 586         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 587         * DumpRenderTree/chromium/LayoutTestController.h:
 588         (LayoutTestController):
 589         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 590         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 591         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 592         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 593         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 594         (LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.
 595         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 596         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 597         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 598         (LayoutTestController):
 599         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 600         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 601         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 602         (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
 603
 604 2012-05-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 605
 606         [EFL] Add shortcut to dump Security Origin and Web Database information
 607         https://bugs.webkit.org/show_bug.cgi?id=86521
 608
 609         Reviewed by Gustavo Noronha Silva.
 610
 611         Added key combination (CTRL+s) to dump information about the
 612         security origin and databases of the main frame. Useful for API
 613         testing and debugging.
 614
 615         * EWebLauncher/main.c:
 616         (on_key_down):
 617
 618 2012-05-18  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 619
 620         [EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
 621         https://bugs.webkit.org/show_bug.cgi?id=86101
 622
 623         Reviewed by Ryosuke Niwa.
 624
 625         Add missing implementation setSerializeHTTPLoads to allow
 626         testing resource load order.
 627
 628         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 629         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 630         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 631         (LayoutTestController::setSerializeHTTPLoads):
 632
 633 2012-05-18  Jochen Eisinger  <jochen@chromium.org>
 634
 635         [chromium] plumb the frame for which a drag was initiated to the WebViewClient
 636
 637         https://bugs.webkit.org/show_bug.cgi?id=86670
 638
 639         Reviewed by Kent Tamura.
 640
 641         * DumpRenderTree/chromium/WebViewHost.cpp:
 642         (WebViewHost::startDragging):
 643         * DumpRenderTree/chromium/WebViewHost.h:
 644         (WebViewHost):
 645
 646 2012-05-18  Christophe Dumez  <christophe.dumez@intel.com>
 647
 648         [EFL] appcache tests are flaky
 649         https://bugs.webkit.org/show_bug.cgi?id=86619
 650
 651         Reviewed by Ryosuke Niwa.
 652
 653         Correctly set the application cache database path in EFL's
 654         DumpRenderTree initialization code.
 655
 656         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 657         (DumpRenderTreeChrome::initialize):
 658
 659 2012-05-17  Raphael Kubo da Costa  <rakuco@webkit.org>
 660
 661         [EFL][DRT] Call resetInternalsObject() after each test.
 662         https://bugs.webkit.org/show_bug.cgi?id=86793
 663
 664         Reviewed by Antonio Gomes.
 665
 666         We need to reset the internals object's settings after running
 667         each test so that there are no interferences between each test's
 668         results.
 669
 670         * DumpRenderTree/efl/DumpRenderTree.cpp:
 671         (runTest):
 672
 673 2012-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>
 674
 675         Unreviewed, rolling out r117526.
 676         http://trac.webkit.org/changeset/117526
 677         https://bugs.webkit.org/show_bug.cgi?id=86801
 678
 679         broke Chromium Mac 10.5 layout test canaries (Requested by
 680         pkasting on #webkit).
 681
 682         * Scripts/webkitpy/common/checkout/scm/scm.py:
 683         (SCM):
 684         (SCM.in_working_directory):
 685         * Scripts/webkitpy/common/checkout/scm/svn.py:
 686         (SVN):
 687         (SVN.in_working_directory):
 688
 689 2012-05-17  Dirk Pranke  <dpranke@chromium.org>
 690
 691         scm.add() doesn't work properly with svn 1.7
 692         https://bugs.webkit.org/show_bug.cgi?id=86779
 693
 694         Reviewed by Ojan Vafai.
 695
 696         The code relied on '.svn' directories being present
 697         in order to tell if a directory had already been added to the
 698         repository; this is no longer true in SVN 1.7.
 699
 700         * Scripts/webkitpy/common/checkout/scm/scm.py:
 701         (SCM):
 702         (SCM.in_working_directory):
 703         * Scripts/webkitpy/common/checkout/scm/svn.py:
 704         (SVN):
 705         (SVN.in_working_directory):
 706
 707 2012-05-17  Jon Lee  <jonlee@apple.com>
 708
 709         Update Apple buildbots to prioritize latest changelists
 710         https://bugs.webkit.org/show_bug.cgi?id=86766
 711
 712         Reviewed by Brady Eidson.
 713
 714         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 715         (pickLatestBuild): Function to get the most pick the most recent build request.
 716         (loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
 717         use the pickLatestBuild function when choosing which request to build next.
 718
 719 2012-05-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
 720
 721         [Qt] Fix MiniBrowser by using correct syntax for qrc URLs
 722         https://bugs.webkit.org/show_bug.cgi?id=86761
 723
 724         Reviewed by Alexis Menard.
 725
 726         * MiniBrowser/qt/BrowserWindow.cpp:
 727         (BrowserWindow::BrowserWindow):
 728         (BrowserWindow::updateVisualMockTouchPoints):
 729
 730 2012-05-17  Thiago Marcos P. Santos  <thiago.santos@intel.com>
 731
 732         [EFL] Add API for Web Database handling
 733         https://bugs.webkit.org/show_bug.cgi?id=85178
 734
 735         Reviewed by Antonio Gomes.
 736
 737         Use the newly introduced Web Database API in EFL's DRT.
 738
 739         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 740         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
 741         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 742         (LayoutTestController::clearAllDatabases):
 743
 744 2012-05-17  Dan Bernstein  <mitz@apple.com>
 745
 746         REGRESSION (r117428): WebKit API/SPI was removed
 747         https://bugs.webkit.org/show_bug.cgi?id=86748
 748
 749         Reverted r117428.
 750
 751         * DumpRenderTree/LayoutTestController.cpp:
 752         (setDomainRelaxationForbiddenForURLSchemeCallback):
 753         (LayoutTestController::staticFunctions):
 754         * DumpRenderTree/LayoutTestController.h:
 755         (LayoutTestController):
 756         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 757         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 758         * DumpRenderTree/chromium/LayoutTestController.cpp:
 759         (LayoutTestController::LayoutTestController):
 760         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 761         * DumpRenderTree/chromium/LayoutTestController.h:
 762         (LayoutTestController):
 763         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 764         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 765         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 766         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 767         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 768         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 769         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 770         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 771         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 772         (LayoutTestController):
 773         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 774         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 775         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 776         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
 777
 778 2012-05-17  Li Yin  <li.yin@intel.com>
 779
 780         [chromium] run-webkit-tests can't work on ubuntu 12.04
 781         https://bugs.webkit.org/show_bug.cgi?id=86565
 782
 783         Reviewed by Kent Tamura.
 784
 785         On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
 786         into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf
 787
 788         * DumpRenderTree/chromium/TestShellLinux.cpp:
 789         (checkAndLoadFontFile):
 790         (setupFontconfig):
 791
 792 2012-05-17  Elliot Poger  <epoger@chromium.org>
 793
 794         Add setting of additional_expectations option to
 795         chromium_unittest.test_overrides_and_builder_names(),
 796         so we can test order in which the base and chromium expectations files
 797         are combined.
 798
 799         https://bugs.webkit.org/show_bug.cgi?id=86642
 800
 801         Reviewed by Dirk Pranke.
 802
 803         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 804         (ChromiumPortTest.test_overrides_and_builder_names):
 805
 806 2012-05-17  Balazs Kelemen  <kbalazs@webkit.org>
 807
 808         [Qt] Web process hangs while waiting for plugin process connection during layouttests
 809         https://bugs.webkit.org/show_bug.cgi?id=86620
 810
 811         Reviewed by Csaba Osztrogonác.
 812
 813         Reenable TestNetscapePlugin with Qt 4.
 814
 815         * Tools.pro:
 816
 817 2012-05-17  Hugo Parente Lima  <hugo.lima@openbossa.org>
 818
 819         [Qt][WK2] fast/events/page-visibility-* tests fail
 820         https://bugs.webkit.org/show_bug.cgi?id=83263
 821
 822         Reviewed by Kenneth Rohde Christiansen.
 823
 824         Handle "preview" state and avoid string conversion.
 825
 826         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 827         (WTR::LayoutTestController::setPageVisibility):
 828
 829 2012-05-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 830
 831         Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
 832         https://bugs.webkit.org/show_bug.cgi?id=86704
 833
 834         Reviewed by Eric Seidel.
 835
 836         Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
 837         cross-port way through the InternalSettings interface.
 838
 839         * DumpRenderTree/LayoutTestController.cpp:
 840         (LayoutTestController::staticFunctions):
 841         * DumpRenderTree/LayoutTestController.h:
 842         (LayoutTestController):
 843         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
 844         * DumpRenderTree/chromium/LayoutTestController.cpp:
 845         (LayoutTestController::LayoutTestController):
 846         * DumpRenderTree/chromium/LayoutTestController.h:
 847         (LayoutTestController):
 848         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
 849         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
 850         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 851         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 852         * DumpRenderTree/qt/LayoutTestControllerQt.h:
 853         (LayoutTestController):
 854         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
 855         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
 856
 857 2012-05-17  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
 858
 859         [EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
 860         https://bugs.webkit.org/show_bug.cgi?id=84835
 861
 862         Reviewed by Eric Seidel.
 863
 864         Added editing callbacks implementation.
 865
 866         * DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
 867         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
 868         (DumpRenderTreeChrome::createView):
 869         * DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
 870         (dumpPath):
 871         (dumpRange):
 872         (insertActionString):
 873         (selectionAffinityString):
 874         (shouldBeginEditing):
 875         (shouldEndEditing):
 876         (shouldInsertNode):
 877         (shouldInsertText):
 878         (shouldDeleteRange):
 879         (shouldChangeSelectedRange):
 880         (shouldApplyStyle):
 881         (editingBegan):
 882         (userChangedContents):
 883         (editingEnded):
 884         (selectionChanged):
 885         (connectEditingCallbacks):
 886         * DumpRenderTree/efl/EditingCallbacks.h: Added.
 887
 888 2012-05-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 889
 890         Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
 891
 892         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 893         (DumpRenderTreeChrome::initialize):
 894
 895 2012-05-17  Kentaro Hara  <haraken@chromium.org>
 896
 897         [Performance test] In perftest.py, do not include 'description' in 'results'
 898         https://bugs.webkit.org/show_bug.cgi?id=86696
 899
 900         Reviewed by Csaba Osztrogoná.
 901
 902         'results' in perftest.py should not include any data that is not expected
 903         by the perf bot server. We do not need to send 'description' to the perf bot
 904         server since 'description' is always the same.
 905
 906         Thus this patch just removes 'description' from 'results'.
 907
 908         * Scripts/webkitpy/performance_tests/perftest.py:
 909         (PerfTest.parse_output):
 910         (PerfTest.output_statistics):
 911         (ChromiumStylePerfTest.parse_output):
 912         (PageLoadingPerfTest.run):
 913
 914 2012-05-17  Kentaro Hara  <haraken@chromium.org>
 915
 916         [Performance test] Always fill results['description'] in perftest.py
 917         https://bugs.webkit.org/show_bug.cgi?id=86696
 918
 919         Reviewed by Ryosuke Niwa.
 920
 921         This is a follow-up patch for r117397 to fix perf bot failures.
 922         This patch fills results['description'] always.
 923
 924         * Scripts/webkitpy/performance_tests/perftest.py:
 925         (PageLoadingPerfTest.run):
 926
 927 2012-05-16  Kentaro Hara  <haraken@chromium.org>
 928
 929         [Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
 930         https://bugs.webkit.org/show_bug.cgi?id=86696
 931
 932         Reviewed by Ryosuke Niwa.
 933
 934         We want to add some description for each PerfTestRunner.run and
 935         PerfTestRunner.runPerSecond, so that people can know what each
 936         run is testing.
 937
 938         Output example:
 939
 940         $ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
 941         Running Bindings/first-child.html (1 of 1)
 942         DESCRIPTION: Benchmark for DOM attributes that return a Node object.
 943         RESULT Bindings: first-child= 788.359076534 runs/s
 944         median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s
 945
 946         * Scripts/webkitpy/performance_tests/perftest.py:
 947         (PerfTest):
 948         (PerfTest.parse_output):
 949         (PerfTest.output_statistics):
 950
 951 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
 952
 953         [EFL] appcache tests are flaky
 954         https://bugs.webkit.org/show_bug.cgi?id=86619
 955
 956         Reviewed by Gustavo Noronha Silva.
 957
 958         Correctly set the application cache database path in EFL's
 959         DumpRenderTree initialization code.
 960
 961         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 962         (DumpRenderTreeChrome::initialize):
 963
 964 2012-05-16  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 965
 966         Add new build slave for EFL port.
 967         https://bugs.webkit.org/show_bug.cgi?id=86567
 968
 969         Reviewed by Ryosuke Niwa.
 970
 971         Add a build slave for EFL 32-bit linux build.
 972
 973         * BuildSlaveSupport/build.webkit.org-config/config.json:
 974
 975 2012-05-16  Kihong Kwon  <kihong.kwon@samsung.com>
 976
 977         [EFL] Support for Battery Status API on the WebKit-Efl
 978         https://bugs.webkit.org/show_bug.cgi?id=83254
 979
 980         Reviewed by Chang Shu.
 981
 982         Add e_dbus libraries to jhbuild's modules list.
 983
 984         * efl/jhbuild.modules:
 985
 986 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
 987
 988         [EFL] Rounding errors on 32-bit machines causes tests to fail
 989         https://bugs.webkit.org/show_bug.cgi?id=86194
 990
 991         Reviewed by Martin Robinson.
 992
 993         Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
 994         point values between 32-bit and 64-bit architectures.
 995         Same flags are already used by Qt and GTK ports.
 996
 997         * Scripts/webkitdirs.pm:
 998         (determineArchitecture):
 999         (generateBuildSystemFromCMakeProject):
1000
1001 2012-05-16  Balazs Kelemen  <kbalazs@webkit.org>
1002
1003         [Qt] Web process hangs while waiting for plugin process connection during layouttests
1004         https://bugs.webkit.org/show_bug.cgi?id=86620
1005
1006         Reviewed by Csaba Osztrogonác.
1007
1008         Temporary workaround not to fail layout tests.
1009
1010         * Tools.pro: Disable TestNetscapePlugin.
1011
1012 2012-05-16  Dinu Jacob  <dinu.jacob@nokia.com>
1013
1014         Add didFinishProgress BundleUIClient callback
1015         https://bugs.webkit.org/show_bug.cgi?id=86541
1016
1017         Reviewed by Kenneth Rohde Christiansen.
1018
1019         Added support for dumpProgressFinishedCallback.
1020
1021         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1023         (WTR::InjectedBundlePage::InjectedBundlePage):
1024         (WTR::InjectedBundlePage::didFinishProgress):
1025         (WTR):
1026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1027         (InjectedBundlePage):
1028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1029         (WTR::LayoutTestController::LayoutTestController):
1030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1031         (WTR::LayoutTestController::dumpProgressFinishedCallback):
1032         (WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
1033         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
1034         (LayoutTestController):
1035
1036 2012-05-15  Pierre Rossi  <pierre.rossi@gmail.com>
1037
1038         [Qt] Enable SVG Fonts by default
1039         https://bugs.webkit.org/show_bug.cgi?id=86463
1040
1041         Reviewed by Nikolas Zimmermann.
1042
1043         * qmake/mkspecs/features/features.pri:
1044
1045 2012-05-16  Christophe Dumez  <christophe.dumez@intel.com>
1046
1047         [EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
1048         https://bugs.webkit.org/show_bug.cgi?id=85585
1049
1050         Reviewed by Gustavo Noronha Silva.
1051
1052         Implement setApplicationCacheOriginQuota in EFL's
1053         LayoutTestController.
1054
1055         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1056         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1057         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1058         (onExceededApplicationCacheQuota):
1059         (drtViewAdd):
1060         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1061         (LayoutTestController::setApplicationCacheOriginQuota):
1062
1063 2012-05-16  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1064
1065         [EFL] EFL's LayoutTestController  evaluateScriptInIsolatedWorld implementation
1066         https://bugs.webkit.org/show_bug.cgi?id=83776
1067
1068         Reviewed by Tor Arne Vestbø.
1069
1070         Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
1071
1072         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1073         (LayoutTestController::evaluateScriptInIsolatedWorld):
1074
1075 2012-05-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1076
1077         Unreviewed. Add myself as a committer.
1078
1079         * Scripts/webkitpy/common/config/committers.py:
1080
1081 2012-05-15  Kangil Han  <kangil.han@samsung.com>
1082
1083         [EFL][DRT] Fix eventSender key providing
1084         https://bugs.webkit.org/show_bug.cgi?id=84710
1085
1086         Reviewed by Andreas Kling.
1087
1088         Currently eventSender doesn't provide key event correctly.
1089         For example, 'Right' will be visible when 'right arrow' key event is fired.
1090         Given circumstance, nothing has to be shown.
1091         Therefore, this patch fixed incorrectly provided key event.
1092
1093         * DumpRenderTree/efl/EventSender.cpp:
1094         (KeyEventInfo::KeyEventInfo):
1095         (KeyEventInfo):
1096         (keyPadNameFromJSValue):
1097         (keyNameFromJSValue):
1098         (createKeyEventInfo):
1099         (sendKeyDown):
1100
1101 2012-05-15  Dan Bernstein  <mitz@apple.com>
1102
1103         Fixed a typo.
1104
1105         * Scripts/copy-webkitlibraries-to-product-directory:
1106
1107 2012-05-15  Kihong Kwon  <kihong.kwon@samsung.com>
1108
1109         [EFL] Enable Fullscreen API
1110         https://bugs.webkit.org/show_bug.cgi?id=85870
1111
1112         Reviewed by Antonio Gomes.
1113
1114         Enable full screen api feature on the EFL port.
1115         There are two failed test cases under LayoutTests/fullscreen.
1116         They are going to be fixed with other patch.
1117
1118         * Scripts/webkitperl/FeatureList.pm:
1119
1120 2012-05-15  James Robinson  <jamesr@chromium.org>
1121
1122         [chromium] Chromium port never sets USE(CG) so code behind it is dead
1123         https://bugs.webkit.org/show_bug.cgi?id=86537
1124
1125         Reviewed by Adrienne Walker.
1126
1127         Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
1128
1129         * DumpRenderTree/chromium/WebViewHost.cpp:
1130         (WebViewHost::paintRect):
1131
1132 2012-05-15  James Robinson  <jamesr@chromium.org>
1133
1134         [chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
1135         https://bugs.webkit.org/show_bug.cgi?id=86536
1136
1137         Reviewed by Adam Barth.
1138
1139         Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.
1140
1141         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1142         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1143         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1144         * DumpRenderTree/chromium/WebViewHost.cpp:
1145         (WebViewHost::paintPagesWithBoundaries):
1146
1147 2012-05-15  James Robinson  <jamesr@chromium.org>
1148
1149         [chromium] Unreviewed build fix.
1150
1151         Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
1152         component build, at least on linux.  This restores Tools/DumpRenderTree to its pre-r117166 state.
1153
1154         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1155         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1156         (TestWebPlugin::initialize):
1157
1158 2012-05-15  Elliot Poger  <epoger@google.com>
1159
1160         add unit test for NRWT's --additional-expectations option
1161         https://bugs.webkit.org/show_bug.cgi?id=86501
1162
1163         Reviewed by Ojan Vafai.
1164
1165         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1166         (PortTest.test_additional_expectations):
1167
1168 2012-05-15  James Robinson  <jamesr@chromium.org>
1169
1170         [chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
1171         https://bugs.webkit.org/show_bug.cgi?id=86524
1172
1173         Reviewed by Adam Barth.
1174
1175         Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.
1176
1177         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1178         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1179         (TestWebPlugin::initialize):
1180
1181 2012-05-15  Jessie Berlin  <jberlin@apple.com>
1182
1183         WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
1184         going into the PageCache.
1185         https://bugs.webkit.org/show_bug.cgi?id=85891
1186
1187         Reviewed by Brady Eidson.
1188
1189         Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
1190         better than using pages with unload handlers because we may find a way to make pages with
1191         unload handlers cacheable in the future.
1192
1193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1194         Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.
1195
1196         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
1197         (TestWebKitAPI::TEST):
1198         Set the cache model to kWKCacheModelDocumentViewer.
1199
1200         * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
1201         * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
1202
1203 2012-05-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1204
1205         [Qt] Add infra for testing double-tap to zoom functionality etc
1206         https://bugs.webkit.org/show_bug.cgi?id=86474
1207
1208         Reviewed by Simon Hausmann.
1209
1210         The WebViewportInfo class was renamed to QWebKitTest in preparation
1211         of becoming a separate module. Adapt the use API.
1212
1213         * MiniBrowser/qt/qml/BrowserWindow.qml:
1214         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1215
1216 2012-05-15  Csaba Osztrogonác  <ossy@webkit.org>
1217
1218         Introduce ENABLE_CSS_VARIABLES compile flag.
1219         https://bugs.webkit.org/show_bug.cgi?id=86338
1220
1221         Reviewed by Hajime Morita.
1222
1223         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
1224         (WebKitPortTest.test_skipped_directories_for_symbols):
1225
1226 2012-05-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1227
1228         Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout
1229
1230         https://bugs.webkit.org/show_bug.cgi?id=85809
1231
1232         webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
1233         output to stdout, but StreamWriter will by default always encode the object that's
1234         passed to write(). This blows up when the object is a raw string, already encoded
1235         as utf8, and does not match the default behavior of sys.stdout.
1236
1237         To solve this in one place, instead of every single call-site that might write
1238         raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
1239         passing them on to StreamWriter.write(). This has the benefit of also making the
1240         stacktrace easy to read in the case where this assumption does not hold.
1241
1242         The source of this particular bug was that Executive.run_and_throw_if_fail() will
1243         tee the output of the subprocess, and in the case of running prepare-ChangeLog this
1244         might produce non-ascii output, which gets written directly to sys.stdout as raw
1245         utf8-encoded strings.
1246
1247         Reviewed by Dirk Pranke.
1248
1249         * Scripts/webkit-patch:
1250
1251 2012-05-15  Tomasz Morawski  <t.morawski@samsung.com>
1252
1253         [EFL][DRT] Split ewk_private.h file to multiple private files.
1254         https://bugs.webkit.org/show_bug.cgi?id=84572
1255
1256         Reviewed by Antonio Gomes.
1257
1258         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1259
1260 2012-05-15  Michael Brüning  <michael.bruning@nokia.com>
1261
1262         [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
1263         https://bugs.webkit.org/show_bug.cgi?id=83576
1264
1265         Reviewed by Simon Hausmann.
1266
1267         Set the PlatformWebView for the Qt port to accept all SSL certificates.
1268
1269         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1270         (WTR::PlatformWebView::PlatformWebView):
1271
1272 2012-05-14  Luke Macpherson  <macpherson@chromium.org>
1273
1274         Introduce ENABLE_CSS_VARIABLES compile flag.
1275         https://bugs.webkit.org/show_bug.cgi?id=86338
1276
1277         Reviewed by Dimitri Glazkov.
1278
1279         Add a configuration option for CSS Variables support, disabling it by default.
1280
1281         * Scripts/webkitperl/FeatureList.pm:
1282         * Scripts/webkitpy/layout_tests/port/webkit.py:
1283         (WebKitPort._missing_symbol_to_skipped_tests):
1284         * qmake/mkspecs/features/features.pri:
1285
1286 2012-05-14  Nate Chapin  <japhet@chromium.org>
1287
1288         Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.
1289
1290         Reviewed by Adam Barth.
1291
1292         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1293         (callDeletePlugin):
1294         (pluginHasProperty):
1295         (pluginHasMethod):
1296         (pluginGetProperty):
1297         (pluginSetProperty):
1298         (pluginInvoke):
1299
1300 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1301
1302         Re-enable "drt mode" on chromium-mac-leopard
1303         https://bugs.webkit.org/show_bug.cgi?id=83076
1304
1305         Unreviewed, build fix (change?).
1306
1307         This change is another attempt to gather data on
1308         the flakiness and timeouts we're seeing on Mac SL
1309         now that we have another bot.
1310
1311         * Scripts/webkitpy/layout_tests/port/chromium.py:
1312         (ChromiumDriver.__init__):
1313
1314 2012-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1315
1316         Unreviewed, rolling out r116981.
1317         http://trac.webkit.org/changeset/116981
1318         https://bugs.webkit.org/show_bug.cgi?id=86402
1319
1320         Caused compositing and mathml tests to fail. (Requested by
1321         rakuco on #webkit).
1322
1323         * Scripts/webkitpy/layout_tests/port/efl.py:
1324         (EflPort._path_to_webcore_library):
1325
1326 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1327
1328         Fix regressions in garden-o-matic after r116988.
1329
1330         Unreviewed, build fix.
1331
1332         I had a typo in a field name in checkout.js, and unfortunately
1333         the unittests had the same typo :(.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1336         (.):
1337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1338
1339 2012-05-14  Dirk Pranke  <dpranke@chromium.org>
1340
1341         garden-o-matic should specify which types of baselines to rebaseline
1342         https://bugs.webkit.org/show_bug.cgi?id=86242
1343
1344         Reviewed by Adam Barth.
1345
1346         This change modifies garden-o-matic so that we are explicit
1347         about whether to rebaseline the text file, the image file, or
1348         both. This should prevent us from pulling incorrect or
1349         unexpected baselines off the bots.
1350
1351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1352         (.):
1353         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1354         (.):
1355         * Scripts/webkitpy/tool/commands/rebaseline.py:
1356         (AbstractRebaseliningCommand):
1357         (AbstractRebaseliningCommand.__init__):
1358         (RebaselineTest):
1359         (RebaselineTest._rebaseline_test_and_update_expectations):
1360         (RebaselineTest.execute):
1361         (OptimizeBaselines):
1362         (OptimizeBaselines._optimize_baseline):
1363         (OptimizeBaselines.execute):
1364         (AnalyzeBaselines):
1365         (AnalyzeBaselines._analyze_baseline):
1366         (AnalyzeBaselines.execute):
1367         (RebaselineExpectations._rebaseline_port):
1368         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1369         (GardeningHTTPRequestHandler.rebaseline):
1370         (GardeningHTTPRequestHandler.optimizebaselines):
1371         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1372         (GardeningServerTest.test_rebaseline):
1373         (GardeningServerTest.test_rebaseline_new_port):
1374         (GardeningServerTest.test_optimizebaselines):
1375
1376 2012-05-14  Kangil Han  <kangil.han@samsung.com>
1377
1378         [EFL][DRT] Fix WebCore library path
1379         https://bugs.webkit.org/show_bug.cgi?id=86355
1380
1381         Reviewed by Dirk Pranke.
1382
1383         Currently EFL DRT uses wrong WebCore library path when running DRT.
1384         This patch simply adjusted it.
1385
1386         * Scripts/webkitpy/layout_tests/port/efl.py:
1387         (EflPort._path_to_webcore_library):
1388
1389 2012-05-14  Wei James  <james.wei@intel.com>
1390
1391         [Chromium] ImageDiff should be build for host on Android
1392         https://bugs.webkit.org/show_bug.cgi?id=82039
1393
1394         Reviewed by Adam Barth.
1395
1396         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1397
1398 2012-05-14  Joone Hur  <joone@webkit.org>
1399
1400         Unreviewed. Updating email for committers.py script.
1401
1402         * Scripts/webkitpy/common/config/committers.py:
1403
1404 2012-05-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1405
1406         Unreviewed. Fix make distcheck.
1407
1408         * GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
1409         * gtk/run-api-tests:
1410         (TestRunner._lookup_atspi2_binary): Handle the case when
1411         pkg_config_file_variable() return None.
1412
1413 2012-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1414
1415         Unreviewed, rolling out r116935.
1416         http://trac.webkit.org/changeset/116935
1417         https://bugs.webkit.org/show_bug.cgi?id=86373
1418
1419         Something is still broken (Requested by Ossy on #webkit).
1420
1421         * Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
1422         * Scripts/webkitpy/style/checkers/png.py:
1423         (PNGChecker.check):
1424         (PNGChecker):
1425         (PNGChecker._config_file_path):
1426         * Scripts/webkitpy/tool/commands/download.py:
1427         (Land):
1428         * Scripts/webkitpy/tool/steps/__init__.py:
1429         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
1430         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
1431
1432 2012-05-14  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1433
1434         [Qt] Doesn't build with ENABLE_INSPECTOR=0
1435         https://bugs.webkit.org/show_bug.cgi?id=85056
1436
1437         Reviewed by Tor Arne Vestbø.
1438
1439         * WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
1440         * qmake/mkspecs/features/features.prf:
1441         * qmake/mkspecs/features/features.pri:
1442
1443 2012-05-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1444
1445         [Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted
1446         https://bugs.webkit.org/show_bug.cgi?id=86222
1447
1448         The WebView QML api for dialogs is based on delegates for each dialog, which
1449         are implemented as components. Since there's no explicit API to show the dialog,
1450         the natural place to allow the dialog to choose how to display itself is in
1451         Component.onCompleted.
1452
1453         The issue was that we were using QQmlComponent::create() when instantiating the
1454         component, at which point the component did not have a parent or it's attached
1455         WebView property set. That meant that we had to do some ugly workaround in our
1456         test, using a 1ms timer, to get a callback once the parent was there.
1457
1458         We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
1459         pair, which allows us to set the relevant properties before triggering the
1460         Component.onCompleted callback. We were already doing this for the context
1461         menus (except for setting the parent, which we did afterwards).
1462
1463         Reviewed by Simon Hausmann.
1464
1465         * MiniBrowser/qt/qml/BrowserWindow.qml:
1466         * MiniBrowser/qt/qml/Dialog.qml:
1467
1468 2012-05-14  Balazs Ankes  <bank@inf.u-szeged.hu>
1469
1470         webkit-patch land should automatically add svn:mime-type for .png files
1471         https://bugs.webkit.org/show_bug.cgi?id=75825
1472         I refactored the png.py to avoid code duplication.
1473
1474         Reviewed by Dirk Pranke.
1475
1476         * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
1477         (check):
1478         (_config_file_path):
1479         (errorstr_autoprop):
1480         (errorstr_png):
1481         * Scripts/webkitpy/style/checkers/png.py:
1482         (PNGChecker.check):
1483         * Scripts/webkitpy/tool/commands/download.py:
1484         (Land):
1485         * Scripts/webkitpy/tool/steps/__init__.py:
1486         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
1487         (AddSvnMimetypeForPng):
1488         (AddSvnMimetypeForPng.__init__):
1489         (AddSvnMimetypeForPng.run):
1490         (AddSvnMimetypeForPng._check_pngs):
1491         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
1492         (MockSCMDetector):
1493         (MockSCMDetector.__init__):
1494         (MockSCMDetector.display_name):
1495         (AddSvnMimetypeForPngTest):
1496         (AddSvnMimetypeForPngTest.test_run):
1497
1498 2012-05-14  David Kilzer  <ddkilzer@apple.com>
1499
1500         webkit-patch apply-attachment is very slow for big patches
1501         https://bugs.webkit.org/show_bug.cgi?id=74929
1502
1503         Add "excludefield=attachmentdata" to the URL everywhere
1504         "ctype=xml" is used to exclude this field from the XML.
1505
1506         Reviewed by Adam Barth.
1507
1508         * Scripts/prepare-ChangeLog:
1509         (fetchBugDescriptionFromURL):
1510         * Scripts/webkitpy/common/config/urls.py:
1511         * Scripts/webkitpy/common/config/urls_unittest.py:
1512         (URLsTest.test_parse_bug_id):
1513         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1514         (Bugzilla.bug_url_for_bug_id):
1515
1516 2012-05-13  Ryosuke Niwa  <rniwa@webkit.org>
1517
1518         performance tests should be able to measure runs/sec rather than time
1519         https://bugs.webkit.org/show_bug.cgi?id=86021
1520
1521         Reviewed by Ojan Vafai.
1522
1523         Allow " runs/s" or " ms" to appear after numerical values in tests.
1524
1525         * Scripts/webkitpy/performance_tests/perftest.py:
1526         (PerfTest):
1527
1528 2012-05-12  Tim Horton  <timothy_horton@apple.com>
1529
1530         run-safari and co. should support --guard-malloc command line argument
1531         https://bugs.webkit.org/show_bug.cgi?id=86287
1532
1533         Reviewed by Dan Bernstein.
1534
1535         Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
1536         setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.
1537
1538         Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
1539         in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
1540         tends to be harmless.
1541
1542         Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.
1543
1544         * Scripts/old-run-webkit-tests:
1545         * Scripts/webkitdirs.pm:
1546         (appendToEnvironmentVariableList):
1547         (setUpGuardMallocIfNeeded):
1548         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
1549         (runMacWebKitApp):
1550         (execMacWebKitAppForDebugging):
1551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1552         (parse_args):
1553
1554 2012-05-11  Ojan Vafai  <ojan@chromium.org>
1555
1556         Add previous/next buttons the garden-o-matics perf panel
1557         https://bugs.webkit.org/show_bug.cgi?id=86280
1558
1559         Reviewed by Dimitri Glazkov.
1560
1561         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
1562         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
1563         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
1564
1565 2012-05-11  Kevin Ollivier  <kevino@theolliviers.com>
1566
1567         [wx] Unreviewed build fix. Fix memory exhausted errors from 32-bit ld on *nix.
1568
1569         * waf/build/settings.py:
1570         (common_configure):
1571
1572 2012-05-11  Dirk Pranke  <dpranke@chromium.org>
1573
1574         webkit-patch rebaseline should fetch stale expectations :)
1575         https://bugs.webkit.org/show_bug.cgi?id=86231
1576
1577         Unreviewed, build fix.
1578
1579         This change reverts r115492 and goes back to fetching individual
1580         baselines from the layout tests directory, rather than fetching
1581         entire zip files. The performance hit over networks for people
1582         far away from the bots has turned out to be severe, so we need a
1583         better solution to this.
1584
1585         * Scripts/webkitpy/tool/commands/rebaseline.py:
1586         (RebaselineTest._results_url):
1587         (RebaselineTest._file_name_for_expected_result):
1588         (RebaselineTest._rebaseline_test):
1589         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1590         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
1591         (test_rebaseline_updates_expectations_file):
1592         (test_rebaseline_test):
1593         (test_rebaseline_and_copy_test):
1594         (test_rebaseline_and_copy_test_no_existing_result):
1595         (test_rebaseline_and_copy_test_with_lion_result):
1596         (test_rebaseline_and_copy_no_overwrite_test):
1597
1598 2012-05-11  Christophe Dumez  <christophe.dumez@intel.com>
1599
1600         [GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
1601         https://bugs.webkit.org/show_bug.cgi?id=86198
1602
1603         Reviewed by Martin Robinson.
1604
1605         Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
1606         Mincho / Gothic fonts to display Japanese and Chinese characters.
1607
1608         * gtk/jhbuild.modules:
1609
1610 2012-05-11  Christophe Dumez  <christophe.dumez@intel.com>
1611
1612         [EFL][DRT] SVG Batik test fails to display Chinese characters
1613         https://bugs.webkit.org/show_bug.cgi?id=84461
1614
1615         Reviewed by Martin Robinson.
1616
1617         Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
1618         new Kochi Mincho / Gothic fonts to display Japanese and Chinese
1619         characters.
1620
1621         * DumpRenderTree/efl/CMakeLists.txt:
1622         * efl/jhbuild.modules:
1623
1624 2012-05-11  Philippe Normand  <pnormand@igalia.com>
1625
1626         Unreviewed, GTK 64-bit Debug bot fix attempt.
1627
1628         * Scripts/webkitpy/layout_tests/port/gtk.py:
1629         (GtkPort._get_gdb_output): Ignore unicode decoding errors when
1630         processing gdb output.
1631
1632 2012-05-11  Gustavo Noronha Silva  <gns@gnome.org>
1633
1634         REGRESSION(r116205): [GTK]: build no longer supports thin archives
1635         https://bugs.webkit.org/show_bug.cgi?id=86207
1636
1637         * GNUmakefile.am: link libWebCoreModules to DRT.
1638
1639 2012-05-10  Ojan Vafai  <ojan@chromium.org>
1640
1641         Add a perf tab to garden-o-matic
1642         https://bugs.webkit.org/show_bug.cgi?id=86169
1643
1644         Reviewed by Dimitri Glazkov.
1645
1646         This is a first stab at making it easier to view the Chromium WebKit canary
1647         perf graphs. For now, it's just a couple select elements and an iframe.
1648
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
1656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
1657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1658         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1660
1661 2012-05-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1662
1663         Move resumeAnimations to use Internals interface
1664         https://bugs.webkit.org/show_bug.cgi?id=86063
1665
1666         Reviewed by Alexey Proskuryakov.
1667
1668         Remove resumeAnimations functions, because it is able to work in the
1669         cross-port way through the Internals interface.
1670
1671         * DumpRenderTree/LayoutTestController.cpp:
1672         (LayoutTestController::staticFunctions):
1673         * DumpRenderTree/LayoutTestController.h:
1674         (LayoutTestController):
1675         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1676         * DumpRenderTree/chromium/LayoutTestController.cpp:
1677         (LayoutTestController::LayoutTestController):
1678         * DumpRenderTree/chromium/LayoutTestController.h:
1679         (LayoutTestController):
1680         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1681         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1682         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1683         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1684         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1685         (LayoutTestController):
1686         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1687         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1688         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1689         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1690         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1691         (LayoutTestController):
1692
1693 2012-05-10  Alexey Proskuryakov  <ap@apple.com>
1694
1695         Crash in 3rd party WebKit apps that disable cache at a wrong time
1696         https://bugs.webkit.org/show_bug.cgi?id=86027
1697         <rdar://problem/10615880>
1698
1699         Reviewed by Antti Koivisto.
1700
1701         Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
1702         but for disabling the cache instead of triggering a prune.
1703
1704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1705         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
1706         * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.
1707         (-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1708         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
1709         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
1710         (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
1711         (TestWebKitAPI::TEST):
1712
1713 2012-05-10  Anders Carlsson  <andersca@apple.com>
1714
1715         WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
1716         https://bugs.webkit.org/show_bug.cgi?id=86164
1717         <rdar://problem/9551196>
1718
1719         Reviewed by Sam Weinig.
1720
1721         Update for WK2 API changes.
1722
1723         * MiniBrowser/mac/BrowserWindowController.m:
1724         (-[BrowserWindowController awakeFromNib]):
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::TestController::createOtherPage):
1727         (WTR::TestController::initialize):
1728
1729 2012-05-10  Dirk Pranke  <dpranke@chromium.org>
1730
1731         nrwt: [chromium] fix path to asan symbolize script
1732         https://bugs.webkit.org/show_bug.cgi?id=86161
1733
1734         Reviewed by Abhishek Arya.
1735
1736         * Scripts/webkitpy/layout_tests/port/chromium.py:
1737         (ChromiumPort._get_crash_log):
1738
1739 2012-05-10  Lei Zhang  <thestig@chromium.org>
1740
1741         [chromium] Set Valgrind environment variables for layout tests.
1742         https://bugs.webkit.org/show_bug.cgi?id=86156
1743
1744         Reviewed by Dirk Pranke.
1745
1746         * Scripts/webkitpy/layout_tests/port/chromium.py:
1747         (ChromiumPort.setup_environ_for_server):
1748
1749 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
1750
1751         [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
1752         https://bugs.webkit.org/show_bug.cgi?id=86145
1753
1754         Reviewed by Dirk Pranke.
1755
1756         The GTK+ and EFL ports use jhbuild to build a few base libraries
1757         which are then used when building the port itself. Programs such
1758         as DRT and ImageDiff are then supposed to be run with the
1759         `run-with-jhbuild' wrapper so that the libraries are properly
1760         found and loaded.
1761
1762         This was already the case for DumpRenderTree (EflPort defines the
1763         'wrapper' option for that), but it was not possible to do the same
1764         with ImageDiff so far.
1765
1766         The code which created the ImageDiff command-line call has been
1767         moved to a separate method, _image_diff_command, which is then
1768         overridden by EflPort to add the jhbuild wrapper.
1769
1770         * Scripts/webkitpy/layout_tests/port/efl.py:
1771         (EflPort.__init__):
1772         (EflPort._image_diff_command):
1773         * Scripts/webkitpy/layout_tests/port/webkit.py:
1774         (WebKitPort):
1775         (WebKitPort._image_diff_command):
1776         (WebKitPort._start_image_diff_process):
1777
1778 2012-05-10  Zan Dobersek  <zandobersek@gmail.com>
1779
1780         [GTK] ENABLE_IFRAME_SEAMLESS support
1781         https://bugs.webkit.org/show_bug.cgi?id=85843
1782
1783         Reviewed by Eric Seidel.
1784
1785         Add the iframe-seamless option to the options list. This makes it
1786         possible to enable the iframe seamless support through build-webkit
1787         script. Enabled by default for all the ports.
1788
1789         * Scripts/webkitperl/FeatureList.pm:
1790
1791 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
1792
1793         [EFL][webkitpy] Do not redefine check_build() in EflPort.
1794         https://bugs.webkit.org/show_bug.cgi?id=86124
1795
1796         Reviewed by Dirk Pranke.
1797
1798         Remove an old FIXME and do not redefine check_build in EflPort;
1799         once build-dumprendertree recognizes --efl, we can use the
1800         check_build implementation in WebKitPort.
1801
1802         * Scripts/build-dumprendertree:
1803         * Scripts/webkitpy/layout_tests/port/efl.py:
1804         (EflPort.check_build):
1805
1806 2012-05-10  Tommy Widenflycht  <tommyw@google.com>
1807
1808         [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
1809         https://bugs.webkit.org/show_bug.cgi?id=86087
1810
1811         Reviewed by Adam Barth.
1812
1813         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
1814         (MockExtraData):
1815         (WebKit):
1816         (WebKit::WebUserMediaClientMock::requestUserMedia):
1817
1818 2012-05-10  Varun Jain  <varunjain@google.com>
1819
1820         [chromium] Trigger context menu for long press gesture
1821         https://bugs.webkit.org/show_bug.cgi?id=85919
1822
1823         Reviewed by Adam Barth.
1824
1825         * DumpRenderTree/chromium/EventSender.cpp:
1826         (EventSender::EventSender):
1827         (EventSender::gestureLongPress):
1828         (EventSender::gestureEvent):
1829         * DumpRenderTree/chromium/EventSender.h:
1830         (EventSender):
1831
1832 2012-05-10  Takashi Toyoshima  <toyoshim@chromium.org>
1833
1834         don't use autoinstall to import pywebsocket but check it in WebKit directly.
1835         https://bugs.webkit.org/show_bug.cgi?id=86107
1836
1837         Reviewed by Adam Barth.
1838
1839         This change removes pywebsocket from webkitpy's autoinstall list and
1840         imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
1841
1842         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1843         (PyWebSocket._prepare_config):
1844         * Scripts/webkitpy/thirdparty/__init__.py:
1845         (AutoinstallImportHook.find_module):
1846         (AutoinstallImportHook._install_irc):
1847         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1848         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
1849         (ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
1850         (ThirdpartyTest):
1851         (ThirdpartyTest.test_import_hook):
1852         * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
1853         * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Added.
1854         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
1855         (ConnectionTerminatedException):
1856         (InvalidFrameException):
1857         (BadOperationException):
1858         (UnsupportedFrameException):
1859         (InvalidUTF8Exception):
1860         (StreamBase):
1861         (StreamBase.__init__):
1862         (StreamBase._read):
1863         (StreamBase._write):
1864         (StreamBase.receive_bytes):
1865         (StreamBase._read_until):
1866         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
1867         (for):
1868         (StreamHixie75):
1869         (StreamHixie75.for):
1870         (StreamHixie75.__init__):
1871         (StreamHixie75.send_message):
1872         (StreamHixie75._read_payload_length_hixie75):
1873         (StreamHixie75.receive_message):
1874         (StreamHixie75._send_closing_handshake):
1875         (StreamHixie75.close_connection):
1876         (StreamHixie75.send_ping):
1877         * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
1878         (Frame):
1879         (Frame.__init__):
1880         (create_length_header):
1881         (create_header):
1882         (_build_frame):
1883         (_filter_and_format_frame_object):
1884         (create_binary_frame):
1885         (create_text_frame):
1886         (FragmentedFrameBuilder):
1887         (FragmentedFrameBuilder.to):
1888         (FragmentedFrameBuilder.__init__):
1889         (FragmentedFrameBuilder.build):
1890         (_create_control_frame):
1891         (create_ping_frame):
1892         (create_pong_frame):
1893         (create_close_frame):
1894         (StreamOptions):
1895         (StreamOptions.__init__):
1896         (Stream):
1897         (Stream.for):
1898         (Stream.__init__):
1899         (Stream._receive_frame):
1900         (Stream._receive_frame_as_frame_object):
1901         (Stream.send_message):
1902         (Stream.receive_message):
1903         (Stream._send_closing_handshake):
1904         (Stream.close_connection):
1905         (Stream.send_ping):
1906         (Stream._send_pong):
1907         (Stream._drain_received_data):
1908         * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
1909         (is_control_opcode):
1910         (ExtensionParameter):
1911         (ExtensionParameter.__init__):
1912         (ExtensionParameter.name):
1913         (ExtensionParameter.add_parameter):
1914         (ExtensionParameter.get_parameters):
1915         (ExtensionParameter.get_parameter_names):
1916         (ExtensionParameter.has_parameter):
1917         (ExtensionParameter.get_parameter_value):
1918         * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
1919         (DispatchException):
1920         (DispatchException.__init__):
1921         (_default_passive_closing_handshake_handler):
1922         (_normalize_path):
1923         (_create_path_to_resource_converter):
1924         (_create_path_to_resource_converter.converter):
1925         (_enumerate_handler_file_paths):
1926         (_HandlerSuite):
1927         (_HandlerSuite.__init__):
1928         (_source_handler_file):
1929         (_extract_handler):
1930         (Dispatcher):
1931         (Dispatcher.maintains):
1932         (Dispatcher.__init__):
1933         (Dispatcher.add_resource_path_alias):
1934         (Dispatcher.source_warnings):
1935         (Dispatcher.do_extra_handshake):
1936         (Dispatcher.transfer_data):
1937         (Dispatcher.passive_closing_handshake):
1938         (Dispatcher.get_handler_suite):
1939         (Dispatcher._source_handler_files_in_dir):
1940         * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
1941         (ExtensionProcessorInterface):
1942         (ExtensionProcessorInterface.get_extension_response):
1943         (ExtensionProcessorInterface.setup_stream_options):
1944         (DeflateStreamExtensionProcessor):
1945         (DeflateStreamExtensionProcessor.__init__):
1946         (DeflateStreamExtensionProcessor.get_extension_response):
1947         (DeflateStreamExtensionProcessor.setup_stream_options):
1948         (DeflateFrameExtensionProcessor):
1949         (DeflateFrameExtensionProcessor.__init__):
1950         (DeflateFrameExtensionProcessor.get_extension_response):
1951         (DeflateFrameExtensionProcessor.setup_stream_options):
1952         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
1953         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.__init__):
1954         (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
1955         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
1956         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.__init__):
1957         (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
1958         (DeflateFrameExtensionProcessor.set_response_window_bits):
1959         (DeflateFrameExtensionProcessor.set_response_no_context_takeover):
1960         (DeflateFrameExtensionProcessor.enable_outgoing_compression):
1961         (DeflateFrameExtensionProcessor.disable_outgoing_compression):
1962         (DeflateFrameExtensionProcessor._outgoing_filter):
1963         (DeflateFrameExtensionProcessor._incoming_filter):
1964         (get_extension_processor):
1965         (get_extension_processor.is):
1966         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Added.
1967         (try):
1968         (do_handshake):
1969         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
1970         (AbortedByUserException):
1971         (HandshakeException):
1972         (HandshakeException.__init__):
1973         (VersionException):
1974         (VersionException.__init__):
1975         (get_default_port):
1976         (validate_subprotocol):
1977         (parse_host_header):
1978         (format_header):
1979         (build_location):
1980         (get_mandatory_header):
1981         (validate_mandatory_header):
1982         (check_request_line):
1983         (check_header_lines):
1984         (parse_token_list):
1985         (_parse_extension_param):
1986         (_parse_extension):
1987         (parse_extensions):
1988         (format_extensions):
1989         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
1990         (Handshaker):
1991         (Handshaker.performs):
1992         (Handshaker.__init__):
1993         (Handshaker.do_handshake):
1994         (Handshaker._set_resource):
1995         (Handshaker._set_origin):
1996         (Handshaker._set_location):
1997         (Handshaker._set_subprotocol):
1998         (Handshaker._set_protocol_version):
1999         (Handshaker._sendall):
2000         (Handshaker._send_handshake):
2001         (Handshaker._check_header_lines):
2002         (Handshaker._check_first_lines):
2003         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
2004         (compute_accept):
2005         (Handshaker):
2006         (Handshaker.__init__):
2007         (Handshaker._validate_connection_header):
2008         (Handshaker.do_handshake):
2009         (Handshaker._get_origin):
2010         (Handshaker._check_version):
2011         (Handshaker._set_protocol):
2012         (Handshaker._parse_extensions):
2013         (Handshaker._validate_key):
2014         (Handshaker._get_key):
2015         (Handshaker._send_handshake):
2016         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
2017         (Handshaker):
2018         (Handshaker.__init__):
2019         (Handshaker.do_handshake):
2020         (Handshaker._set_resource):
2021         (Handshaker._set_subprotocol):
2022         (Handshaker._set_location):
2023         (Handshaker._set_origin):
2024         (Handshaker._set_protocol_version):
2025         (Handshaker._set_challenge_response):
2026         (Handshaker._get_key_value):
2027         (Handshaker._get_challenge):
2028         (Handshaker._send_handshake):
2029         * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
2030         (ApacheLogHandler):
2031         (ApacheLogHandler.__init__):
2032         (ApacheLogHandler.emit):
2033         (_configure_logging):
2034         (_parse_option):
2035         (_create_dispatcher):
2036         (headerparserhandler):
2037         * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
2038         (_is_char):
2039         (_is_ctl):
2040         (ParsingState):
2041         (ParsingState.__init__):
2042         (peek):
2043         (consume):
2044         (consume_string):
2045         (consume_lws):
2046         (consume_lwses):
2047         (consume_token):
2048         (consume_token_or_quoted_string):
2049         (quote_if_necessary):
2050         (parse_uri):
2051         * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
2052         (MemorizingFile):
2053         (MemorizingFile.__init__):
2054         (MemorizingFile.__getattribute__):
2055         (MemorizingFile.readline):
2056         (MemorizingFile.get_memorized_lines):
2057         * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
2058         (close_connection):
2059         (send_message):
2060         (receive_message):
2061         (send_ping):
2062         (MessageReceiver):
2063         (MessageReceiver.receives):
2064         (MessageReceiver.provides):
2065         (MessageReceiver.should):
2066         (MessageReceiver.__init__):
2067         (MessageReceiver.run):
2068         (MessageReceiver.receive):
2069         (MessageReceiver.receive_nowait):
2070         (MessageReceiver.stop):
2071         (MessageSender):
2072         (MessageSender.sends):
2073         (MessageSender.provides):
2074         (MessageSender.should):
2075         (MessageSender.__init__):
2076         (MessageSender.run):
2077         (MessageSender.send):
2078         (MessageSender.send_nowait):
2079         * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
2080         (_StandaloneConnection):
2081         (_StandaloneConnection.__init__):
2082         (_StandaloneConnection.get_local_addr):
2083         (_StandaloneConnection.get_remote_addr):
2084         (_StandaloneConnection.write):
2085         (_StandaloneConnection.read):
2086         (_StandaloneConnection.get_memorized_lines):
2087         (_StandaloneRequest):
2088         (_StandaloneRequest.__init__):
2089         (_StandaloneRequest.get_uri):
2090         (_StandaloneRequest.get_method):
2091         (_StandaloneRequest.is_https):
2092         (_StandaloneRequest._drain_received_data):
2093         (_StandaloneSSLConnection):
2094         (_StandaloneSSLConnection.for):
2095         (_StandaloneSSLConnection.__init__):
2096         (_StandaloneSSLConnection.__getattribute__):
2097         (_StandaloneSSLConnection.__setattr__):
2098         (_StandaloneSSLConnection.makefile):
2099         (WebSocketServer):
2100         (WebSocketServer.__init__):
2101         (WebSocketServer._create_sockets):
2102         (WebSocketServer.server_bind):
2103         (WebSocketServer.server_activate):
2104         (WebSocketServer.server_close):
2105         (WebSocketServer.fileno):
2106         (WebSocketServer.handle_error):
2107         (WebSocketServer.get_request):
2108         (WebSocketServer.serve_forever):
2109         (WebSocketServer.shutdown):
2110         (WebSocketRequestHandler):
2111         (WebSocketRequestHandler.setup):
2112         (WebSocketRequestHandler.setup.SocketServer):
2113         (WebSocketRequestHandler.__init__):
2114         (WebSocketRequestHandler.parse_request):
2115         (WebSocketRequestHandler.log_request):
2116         (WebSocketRequestHandler.log_error):
2117         (WebSocketRequestHandler.is_cgi):
2118         (_configure_logging):
2119         (_alias_handlers):
2120         (_build_option_parser):
2121         (ThreadMonitor):
2122         (ThreadMonitor.__init__):
2123         (ThreadMonitor.run):
2124         (_parse_args_and_config):
2125         (_main):
2126         (_main.if):
2127         (_main.if.__check_script):
2128         * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/__init___unittest.py.
2129         * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
2130         (get_stack_trace):
2131         (prepend_message_to_exception):
2132         (__translate_interp):
2133         (get_script_interp):
2134         (wrap_popen3_for_win):
2135         (wrap_popen3_for_win.__wrap_popen3):
2136         (hexify):
2137         (get_class_logger):
2138         (NoopMasker):
2139         (NoopMasker.__init__):
2140         (NoopMasker.mask):
2141         (RepeatedXorMasker):
2142         (RepeatedXorMasker.__init__):
2143         (RepeatedXorMasker.mask):
2144         (DeflateRequest):
2145         (DeflateRequest.for):
2146         (DeflateRequest.__init__):
2147         (DeflateRequest.__getattribute__):
2148         (DeflateRequest.__setattr__):
2149         (_Deflater):
2150         (_Deflater.__init__):
2151         (_Deflater.compress_and_flush):
2152         (_Inflater):
2153         (_Inflater.__init__):
2154         (_Inflater.decompress):
2155         (_Inflater.append):
2156         (_Inflater.reset):
2157         (_RFC1979Deflater):
2158         (_RFC1979Deflater.that):
2159         (_RFC1979Deflater.__init__):
2160         (_RFC1979Deflater.filter):
2161         (_RFC1979Inflater):
2162         (_RFC1979Inflater.for):
2163         (_RFC1979Inflater.__init__):
2164         (_RFC1979Inflater.filter):
2165         (DeflateSocket):
2166         (DeflateSocket.for):
2167         (DeflateSocket.__init__):
2168         (DeflateSocket.recv):
2169         (DeflateSocket.sendall):
2170         (DeflateSocket.send):
2171         (DeflateConnection):
2172         (DeflateConnection.for):
2173         (DeflateConnection.__init__):
2174         (DeflateConnection.get_remote_addr):
2175         (DeflateConnection.put_bytes):
2176         (DeflateConnection.read):
2177         (DeflateConnection.write):
2178         (_is_ewouldblock_errno):
2179         (drain_received_data):
2180
2181 2012-05-10  Raphael Kubo da Costa  <rakuco@webkit.org>
2182
2183         [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
2184         https://bugs.webkit.org/show_bug.cgi?id=86117
2185
2186         Reviewed by Adam Barth.
2187
2188         Simplify the code used to wrap driver calls with jhbuild: we can
2189         just define the 'wrapper' option instead of having to create a
2190         Driver class just for that.
2191
2192         * Scripts/webkitpy/layout_tests/port/efl.py:
2193         (EflPort.__init__):
2194         (EflPort._port_flag_for_scripts):
2195
2196 2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2197
2198         Unreviewed, rolling out r116633.
2199         http://trac.webkit.org/changeset/116633
2200         https://bugs.webkit.org/show_bug.cgi?id=86093
2201
2202         Breaks EFL tests (Requested by kov on #webkit).
2203
2204         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2205         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2206         * DumpRenderTree/efl/EventSender.cpp:
2207         (keyDownCallback):
2208         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2209         (LayoutTestController::setTabKeyCyclesThroughElements):
2210
2211 2012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2212
2213         [EFL] Memory leaks found in EFL DRT
2214         https://bugs.webkit.org/show_bug.cgi?id=85889
2215
2216         Reviewed by Gustavo Noronha Silva.
2217
2218         Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
2219         created with JSStringCreateWithUTF8CString.
2220
2221         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2222         (DumpRenderTreeChrome::onWindowObjectCleared):
2223         * DumpRenderTree/efl/EventSender.cpp:
2224         (modifiersFromJSValue):
2225
2226 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
2227
2228         [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
2229         https://bugs.webkit.org/show_bug.cgi?id=82864
2230
2231         Reviewed by Gustavo Noronha Silva.
2232
2233         Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
2234         in order to unskip fast/events/keypress-insert-tab.html
2235
2236         * DumpRenderTree/efl/EventSender.cpp:
2237         (keyDownCallback):
2238         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2239         (LayoutTestController::setTabKeyCyclesThroughElements):
2240
2241 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
2242
2243         [EFL][DRT] EventSender - set delayed event information if it was not set before
2244         https://bugs.webkit.org/show_bug.cgi?id=85972
2245
2246         Reviewed by Gustavo Noronha Silva.
2247
2248         Reset delayed event information if it is missing.
2249
2250         * DumpRenderTree/efl/EventSender.cpp:
2251         (feedOrQueueMouseEvent):
2252
2253 2012-05-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2254
2255         WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
2256         https://bugs.webkit.org/show_bug.cgi?id=85806
2257
2258         The m_pendingAPIRequestURL member is used (presumably) to mask over the async
2259         nature of WebKit2, so that starting a load of a URL will reflect that URL
2260         immedeatly from activeURL, even if the request has not been passed over to
2261         the web process yet and reflected there.
2262
2263         This works well, except in the case of the initial request, where the main
2264         frame creation happens on the web process side and is notified back to the
2265         UI process. Until we've recived the notification we don't know about the main
2266         frame, and this race condition will potentially give us an empty url instead
2267         of the pending request.
2268
2269         To solve this we always return the pending API request if it's set, even
2270         when there's no mainframe yet (that we known about).
2271
2272         Reviewed by Simon Hausmann.
2273
2274         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2275
2276 2012-05-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2277
2278         [EFL][DRT] Clear added user style sheets before a new testcase execution.
2279         https://bugs.webkit.org/show_bug.cgi?id=84792
2280
2281         Reviewed Gustavo Noronha Silva.
2282
2283         The added user style sheets from the previous testcases are cleared in order to avoid
2284         flaky results.
2285
2286         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2287         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2288
2289 2012-05-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2290
2291         Move suspendAnimations to use Internals interface.
2292         https://bugs.webkit.org/show_bug.cgi?id=85986
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         Remove suspendAnimations functions, because it is able to work in the
2297         cross-port way through the Internals interface
2298
2299         * DumpRenderTree/LayoutTestController.cpp:
2300         (LayoutTestController::staticFunctions):
2301         * DumpRenderTree/LayoutTestController.h:
2302         (LayoutTestController):
2303         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2304         * DumpRenderTree/chromium/LayoutTestController.cpp:
2305         (LayoutTestController::LayoutTestController):
2306         * DumpRenderTree/chromium/LayoutTestController.h:
2307         (LayoutTestController):
2308         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2310         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2312         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2313         (LayoutTestController):
2314         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2315         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2316
2317 2012-05-09  Kent Tamura  <tkent@chromium.org>
2318
2319         [Chromium] Attempt to fix an Android build error.
2320         https://bugs.webkit.org/show_bug.cgi?id=86045
2321
2322         * DumpRenderTree/DumpRenderTree.gypi:
2323
2324 2012-05-09  Ojan Vafai  <ojan@chromium.org>
2325
2326         Don't show partytime if there are non-layout test failures.
2327         https://bugs.webkit.org/show_bug.cgi?id=86056
2328
2329         Reviewed by Dimitri Glazkov.
2330
2331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2332         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
2333         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2334
2335 2012-05-09  Hayato Ito  <hayato@chromium.org>
2336
2337         Improve a warning message for a reftest having an unused expectation file.
2338         https://bugs.webkit.org/show_bug.cgi?id=85975
2339
2340         Reviewed by Adam Barth.
2341
2342         The current warning message is not intuitive. It might be better to update the message
2343         so that it encourage users to remove unused expectation files.
2344
2345         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2346         (SingleTestRunner.__init__):
2347
2348 2012-05-09  Ojan Vafai  <ojan@chromium.org>
2349
2350         Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
2351         https://bugs.webkit.org/show_bug.cgi?id=86043
2352
2353         Reviewed by Adam Barth.
2354
2355         -Get rid of the gtest iframe.
2356         -Cover all non-layout test problems. Before we wouldn't catch compile failures
2357         or gtest failures since they were not on the webkit testing bots.
2358         -Include the list of failing steps next to the builder name. This is a lot less
2359         cluttered than you'd expect and already helped me find a compile failure early.
2360
2361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2364         Delete unused map.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2367         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2369         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2371         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2373
2374 2012-05-09  Jessie Berlin  <jberlin@apple.com>
2375
2376         Crash using the new WKBundleDOMWindowExtensions APIs.
2377         https://bugs.webkit.org/show_bug.cgi?id=85888
2378
2379         Reviewed by Brady Eidson.
2380
2381         Cached frames can live slightly longer than the page, but most clients unregister themselves
2382         and do other cleanup in the willDestroyPage callback, making them miss the
2383         willDestroyGlobalObjectForDOMWindowExtension callbacks.
2384
2385         The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
2386         test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
2387         to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
2388
2389         Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
2390         pages that don't go into the page cache.
2391
2392         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2393         Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
2394         and simple-iframe-unload.html
2395
2396         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2397         (TestWebKitAPI):
2398         Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
2399         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2400         Do not bother to keep track of the live extension count - all of them are expected to be
2401         live until the test completes.
2402         (TestWebKitAPI::TEST):
2403         Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
2404         message failures will be clearer.
2405         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2406         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
2407         Clean up the BundleDOMWindowExtensions.
2408         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
2409         Add an ASSERT_NOT_REACHED.
2410
2411         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
2412         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2413         Keep track of the messages received so they can be checked at the end of the test.
2414         (TestWebKitAPI::TEST):
2415         Navigate to uncacheable pages and back.
2416         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
2417         (DOMWindowExtensionNoCache):
2418         (TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
2419         Set up all the states for each BundleDOMWindowExtension.
2420         (TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
2421         Tell the UI Process about the states of the BundleDOMWindowExtensions.
2422         (TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
2423         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
2424         (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
2425         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
2426         Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
2427         (TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
2428         (TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
2429         (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
2430         (TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
2431         ASSERT that these pages not going into the page cache are not getting disconnected to go into
2432         the page cache.
2433         (TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
2434         Ditto about getting reconnected when coming out of the page cache.
2435         (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
2436         Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
2437         (TestWebKitAPI::didFinishLoadForFrameCallback):
2438         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
2439         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
2440         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
2441         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
2442
2443         * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
2444         * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
2445
2446 2012-05-09  Adam Barth  <abarth@webkit.org>
2447
2448         [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
2449         https://bugs.webkit.org/show_bug.cgi?id=86045
2450
2451         Reviewed by Eric Seidel.
2452
2453         * DumpRenderTree/DumpRenderTree.gypi:
2454
2455 2012-05-09  Adam Barth  <abarth@webkit.org>
2456
2457         [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
2458         https://bugs.webkit.org/show_bug.cgi?id=86041
2459
2460         Reviewed by Eric Seidel.
2461
2462         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2463
2464 2012-05-09  Adam Barth  <abarth@webkit.org>
2465
2466         [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
2467         https://bugs.webkit.org/show_bug.cgi?id=86040
2468
2469         Reviewed by Kent Tamura.
2470
2471         * DumpRenderTree/chromium/TestShell.cpp:
2472         (TestShell::dumpImage):
2473
2474 2012-05-09  Raphael Kubo da Costa  <rakuco@webkit.org>
2475
2476         [EFL] Build fix after r116464.
2477
2478         `ulong' is a type defined by glibc, so it is not very
2479         portable. Use `unsigned long' instead.
2480
2481         * DumpRenderTree/efl/EventSender.cpp:
2482         (DelayedEvent::DelayedEvent):
2483         (DelayedEvent):
2484         (leapForwardCallback):
2485
2486 2012-05-09  Adam Barth  <abarth@webkit.org>
2487
2488         [Chromium] LayoutTestController should use ENABLE guards for some features
2489         https://bugs.webkit.org/show_bug.cgi?id=86030
2490
2491         Reviewed by Eric Seidel.
2492
2493         These features are disabled on OS(ANDROID) and so shouldn't be compiled
2494         when the feature is off.
2495
2496         * DumpRenderTree/chromium/LayoutTestController.cpp:
2497         (LayoutTestController::LayoutTestController):
2498         * DumpRenderTree/chromium/LayoutTestController.h:
2499         (LayoutTestController):
2500         * DumpRenderTree/chromium/TestShell.h:
2501         (TestShell):
2502
2503 2012-05-09  Tom Zakrajsek  <tomz@codeaurora.org>
2504
2505         Fix overzealous re-opened since blocked by... message
2506         https://bugs.webkit.org/show_bug.cgi?id=86020
2507
2508         Reviewed by Adam Barth.
2509
2510         Changed CreateBug behavior to only re-open a blocked bug if it
2511         was RESOLVED.  Also had to update the test infrastructure slightly
2512         to allow for distinct mock commit revisions, so one could point
2513         to a RESOLVED bug for testing while another pointed to an OPEN bug.
2514
2515         Also moved default created mock bug to be 60001 instead of 50004
2516         which already exists as a reference mock bug.
2517
2518         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2519         (MockCheckout.__init__):
2520         (MockCheckout.commit_info_for_revision):
2521         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2522         (MockBugzilla.create_bug):
2523         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2524         * Scripts/webkitpy/tool/commands/download_unittest.py:
2525         (test_create_rollout_resolved):
2526         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2527         (FailureReasonTest.test_blame_line_for_revision):
2528         * Scripts/webkitpy/tool/steps/createbug.py:
2529         (CreateBug.run):
2530
2531 2012-05-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
2532
2533         Use suitable viewport values on XHTML-MP pages.
2534         https://bugs.webkit.org/show_bug.cgi?id=85425
2535
2536         Reviewed by Kenneth Rohde Christiansen.
2537
2538         Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
2539
2540         * qmake/mkspecs/features/features.prf:
2541
2542 2012-05-09  Jochen Eisinger  <jochen@chromium.org>
2543
2544         When creating a new page during a navigation, prime the initial document with the correct referrer policy
2545         https://bugs.webkit.org/show_bug.cgi?id=86001
2546
2547         Reviewed by Adam Barth.
2548
2549         Store the referrer policy in the request, so the network stack can comply with it.
2550
2551         * DumpRenderTree/chromium/WebViewHost.cpp:
2552         (WebViewHost::willSendRequest):
2553
2554 2012-05-09  Vivek Galatage  <vivekgalatage@gmail.com>
2555
2556         Remove CYGWIN=tty from environment variable as its no longer supported
2557         https://bugs.webkit.org/show_bug.cgi?id=85791
2558
2559         The CYGWIN=tty environment variable is no longer supported from Cygwin
2560         version 1.7.10. This fix avoids addition of this environment variable
2561         for Cygwin versions greater than 1.7.9. For supporting older versions
2562         i.e. 1.7.9 or older, the script takes care of retaining the environment
2563         variable.
2564
2565         Reviewed by Adam Roben.
2566
2567         * Scripts/webkitdirs.pm:
2568         (setupAppleWinEnv):
2569
2570 2012-05-09  Dirk Pranke  <dpranke@chromium.org>
2571
2572         nrwt: --skip-failing-tests should also skip flaky tests
2573         https://bugs.webkit.org/show_bug.cgi?id=85941
2574
2575         Reviewed by Ojan Vafai.
2576
2577         This changes --skip-failing-tests so that we skip tests that
2578         are believed to pass sometimes as well as tests that are
2579         believed to always fail.
2580
2581         In addition, in testing this I discovered that we had lousy
2582         test coverage of the details of retrying test failures and
2583         --clobber-old-results, so I wrote some more tests.
2584
2585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2586         (Manager.prepare_lists_and_print_output):
2587         * Scripts/webkitpy/layout_tests/port/test.py:
2588         (unit_test_list):
2589         (TestPort.__init__):
2590         (TestDriver.run_test):
2591         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2592         (MainTest.test_skip_failing_tests):
2593         (MainTest.test_retrying_and_flaky_tests):
2594
2595 2012-05-09  Christophe Dumez  <christophe.dumez@intel.com>
2596
2597         [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
2598         https://bugs.webkit.org/show_bug.cgi?id=84435
2599
2600         Reviewed by Antonio Gomes.
2601
2602         Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
2603         to support LayoutTestController's dumpIconChanges().
2604
2605         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2606         (DumpRenderTreeChrome::createView):
2607         (DumpRenderTreeChrome::onFrameIconChanged):
2608         (DumpRenderTreeChrome::onFrameCreated):
2609         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2610         (DumpRenderTreeChrome):
2611
2612 2012-05-09  Dominik Röttsches  <dominik.rottsches@intel.com>
2613
2614         webkit-patch upload Fails Behind Load-balancing Proxies
2615         https://bugs.webkit.org/show_bug.cgi?id=85980
2616
2617         Reviewed by Adam Barth.
2618
2619         Unchecking the login restriction to IP to allow the tool
2620         to function behind load-balancing proxies that use multiple
2621         outgoing IPs.
2622
2623         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2624         (Bugzilla.authenticate):
2625
2626 2012-05-09  Hao Zheng  <zhenghao@chromium.org>
2627
2628         [Chromium-android] Add unit test for Android layout test script (chromium_android.py)
2629         https://bugs.webkit.org/show_bug.cgi?id=80852
2630
2631         Reviewed by Adam Barth.
2632
2633         Add some tests to ensure that chromium android port works to some
2634         extent. Some methods is hard to test, as they rely on the actual
2635         behavior on device, e.g. pushing files to device.
2636
2637         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2638         (ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
2639         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2640         (ChromiumAndroidPortTest):
2641         (ChromiumAndroidPortTest.test_attributes):
2642         (ChromiumAndroidPortTest.test_get_last_stacktrace):
2643         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
2644         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
2645         (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
2646         (ChromiumAndroidDriverTest):
2647         (ChromiumAndroidDriverTest.setUp):
2648         (ChromiumAndroidDriverTest.test_get_drt_return_value):
2649         (ChromiumAndroidDriverTest.test_has_crash_hint):
2650         (ChromiumAndroidDriverTest.test_read_prompt):
2651         (ChromiumAndroidDriverTest.test_test_shell_command):
2652         (ChromiumAndroidDriverTest.test_write_command_and_read_line):
2653
2654 2012-05-09  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2655
2656         [Qt] ORWT fails with Qt 5 and WK2.
2657         https://bugs.webkit.org/show_bug.cgi?id=85968
2658
2659         Reviewed by Csaba Osztrogonác.
2660
2661         The Qt5 binary does not have a -style argument, so avoid using it.
2662
2663         * Scripts/old-run-webkit-tests:
2664
2665 2012-05-09  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2666
2667         [EFL][DRT] LayoutTestController addUserScript implementation
2668         https://bugs.webkit.org/show_bug.cgi?id=84718
2669
2670         Reviewed by Antonio Gomes.
2671
2672         Added implementation of addUserScript() to LayoutTestController.
2673
2674         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2675         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
2676         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2677         (LayoutTestController::addUserScript): added implementation
2678
2679 2012-05-09  Dan Bernstein  <mitz@apple.com>
2680
2681         Made build-webkit copy WebKitLibraries to the right location again after r116257
2682
2683         Reviewed by Mark Rowe.
2684
2685         * Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
2686         * Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
2687         product directory.
2688
2689 2012-05-08  Ojan Vafai  <ojan@chromium.org>
2690
2691         Show the chromium non-layout test bots in garden-o-matic
2692         https://bugs.webkit.org/show_bug.cgi?id=85903
2693
2694         Reviewed by Eric Seidel.
2695
2696         This is just a single-line high-level overview of the chromium non-layout test bots.
2697         This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
2698         order to do their job.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2704         (#chromium-gtests iframe):
2705         (#chromium-gtests):
2706         (#gtest-label):
2707
2708 2012-05-08  Kangil Han  <kangil.han@samsung.com>
2709
2710         [EFL][DRT] Implement TextInputController.
2711         https://bugs.webkit.org/show_bug.cgi?id=78559
2712
2713         Reviewed by Martin Robinson.
2714
2715         TextInputController has been created for an input emulation purpose in DRT.
2716         However, not like other ports, EFL doesn't have it.
2717         Therefore, this patch will enable EFL port to have an input emulation in DRT.
2718
2719         * DumpRenderTree/efl/CMakeLists.txt:
2720         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2721         (DumpRenderTreeChrome::onWindowObjectCleared):
2722         * DumpRenderTree/efl/TextInputController.cpp: Added.
2723         (setMarkedTextCallback):
2724         (hasMarkedTextCallback):
2725         (markedRangeCallback):
2726         (insertTextCallback):
2727         (unmarkTextCallback):
2728         (firstRectForCharacterRangeCallback):
2729         (selectedRangeCallback):
2730         (makeTextInputController):
2731         * DumpRenderTree/efl/TextInputController.h: Added.
2732
2733 2012-04-23  Raphael Kubo da Costa  <rakuco@webkit.org>
2734
2735         [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
2736         https://bugs.webkit.org/show_bug.cgi?id=84634
2737
2738         Reviewed by Gustavo Noronha Silva.
2739
2740         Drop unnecessary const char* -> WTF::String conversions by
2741         creating String objects directly in LayoutTestController out of
2742         JSStringRef's and passing them to DumpRenderTreeSupportEfl.
2743
2744         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2745         (LayoutTestController::queueLoad):
2746         (LayoutTestController::setValueForUser):
2747         (LayoutTestController::findString):
2748         (LayoutTestController::addUserStyleSheet):
2749
2750 2012-05-08  Alexander Shalamov  <alexander.shalamov@intel.com>
2751
2752         [EFL][DRT] EventSender needs implementation of leapForward function
2753         https://bugs.webkit.org/show_bug.cgi?id=83486
2754
2755         Reviewed by Eric Seidel.
2756
2757         Implemented leapForward function in Efl's DRT. This function is required
2758         to delay and queue event execution and simulate real user behavior.
2759
2760         * DumpRenderTree/efl/EventSender.cpp:
2761         (DelayedEvent):
2762         (MouseEventInfo::MouseEventInfo):
2763         (MouseEventInfo):
2764         (sendClick):
2765         (mouseDownCallback):
2766         (mouseUpCallback):
2767         (mouseMoveToCallback):
2768         (leapForwardCallback):
2769         (mouseScrollByCallback):
2770         (feedOrQueueMouseEvent):
2771         (feedMouseEvent):
2772         (feedQueuedMouseEvents):
2773
2774 2012-05-08  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2775
2776         [GTK] Memory leak in DRT EventSender.cpp
2777         https://bugs.webkit.org/show_bug.cgi?id=85886
2778
2779         Reviewed by Martin Robinson.
2780
2781         Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
2782         JSString created with JSStringCreateWithUTF8CString.
2783
2784         * DumpRenderTree/gtk/EventSender.cpp:
2785         (gdkModifersFromJSValue):
2786
2787 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
2788
2789         [EFL] glib dependency needs to be updated in jhbuild
2790         https://bugs.webkit.org/show_bug.cgi?id=85878
2791
2792         Reviewed by Martin Robinson.
2793
2794         Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
2795         addresses flakiness in media tests due to possible deadlock with the
2796         following output on stderr:
2797         GStreamer-WARNING **: wrong STREAM_LOCK count 0
2798
2799         The bug was fixed upstream by:
2800         http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
2801
2802         * efl/jhbuild.modules:
2803
2804 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
2805
2806         [Qt] Unbreak debugging of WebKit2.
2807         https://bugs.webkit.org/show_bug.cgi?id=85839
2808
2809         Reviewed by Simon Hausmann.
2810
2811         When you attach GDB to a running process, it stops it.
2812         http://trac.webkit.org/changeset/115958 introduced a pause()
2813         call to wait the debugger to be attached to then continue
2814         the execution of the WebProcess. Unfortunately the pause()
2815         function does not return unless a signal handler is called.
2816         This patch introduce an event handler to exit from the paused
2817         state when the debugger send the signal SIGCONT. The old code
2818         works with older version of GDB (<7.0) but not with newer
2819         versions where the behavior of pause() is correct.
2820
2821         * WebKitTestRunner/qt/main.cpp:
2822         (sigcontHandler):
2823         (main):
2824
2825 2012-05-08  Christophe Dumez  <christophe.dumez@intel.com>
2826
2827         [EFL][DRT] EFL's DRT does not fully support page visibility
2828         https://bugs.webkit.org/show_bug.cgi?id=85032
2829
2830         Reviewed by Antonio Gomes.
2831
2832         * DumpRenderTree/LayoutTestController.cpp:
2833         (resetPageVisibilityCallback): Fix incorrect argumentCount check.
2834         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2835         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
2836         reset page visibility setting between tests.
2837         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2838         (LayoutTestController::setPageVisibility): Add support for "preview"
2839         visibility state.
2840
2841 2012-05-08  Gavin Peters  <gavinp@chromium.org>
2842
2843         [webkit-patch] Return meaningful results from single-result queries.
2844         https://bugs.webkit.org/show_bug.cgi?id=85367
2845
2846         Reviewed by Dirk Pranke.
2847
2848         Sometimes a quicksearch returns a single result by just redirecting to the page for that single
2849         bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
2850         a result list consisting of that one bug.
2851
2852         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2853         (BugzillaQueries._fetch_bugs_from_advanced_query):
2854
2855 2012-05-08  Gavin Peters  <gavinp@chromium.org>
2856
2857         [webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
2858         https://bugs.webkit.org/show_bug.cgi?id=85368
2859
2860         Reviewed by Eric Seidel.
2861
2862         * Scripts/webkitpy/common/config/urls.py:
2863         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2864         (MockBugzillaQueries.fetch_bugs_matching_quicksearch):
2865         * Scripts/webkitpy/common/net/omahaproxy.py: Added.
2866         (OmahaProxy):
2867         (OmahaProxy.__init__):
2868         (OmahaProxy.set_url):
2869         (OmahaProxy._json_url):
2870         (OmahaProxy._get_json):
2871         (OmahaProxy.get_revisions):
2872         * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
2873         (MockOmahaProxy):
2874         (MockOmahaProxy.__init__):
2875         (OmahaProxyTest):
2876         (OmahaProxyTest.test_get_revisions):
2877         * Scripts/webkitpy/tool/commands/__init__.py:
2878         * Scripts/webkitpy/tool/commands/bugsearch.py:
2879         (BugSearch):
2880         * Scripts/webkitpy/tool/commands/chromechannels.py: Added.
2881         (ChromeChannels):
2882         (__init__):
2883         (execute):
2884         * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
2885         (MockOmahaProxy):
2886         (MockOmahaProxy.get_revisions):
2887         (TestableChromeChannels):
2888         (TestableChromeChannels.__init__):
2889         (ChromeChannelsTest):
2890         (ChromeChannelsTest.test_single_bug):
2891         (ChromeChannelsTest.test_with_query):
2892
2893 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2894
2895         Unreviewed. Fix GTK+ unit tests.
2896
2897         * gtk/common.py:
2898         (pkg_config_file_variable):
2899
2900 2012-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2901
2902         [GTK] Google tests that time out are leaked
2903         https://bugs.webkit.org/show_bug.cgi?id=84973
2904
2905         Reviewed by Philippe Normand.
2906
2907         Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
2908         leaving run-gtk-tests as simple wrapper that runs run-api-tests in
2909         a jhbuild environment when jhbuild is available.
2910
2911         * Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
2912         with jhbuild if present.
2913         * gtk/common.py:
2914         (pkg_config_file_variable): Generic function to get a variable
2915         from a pkg-config file.
2916         (prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
2917         * gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
2918         (TestRunner.__init__): Use common.build_path() to get the programs path.
2919         (TestRunner._lookup_atspi2_binary): Use
2920         common.pkg_config_file_variable() to get the 'exec_prefix'.
2921         (TestRunner._start_accessibility_daemons): Use subprocess.Popen()
2922         directly instead of helper _create_process that has been removed.
2923         (TestRunner._setup_testing_environment): Use subprocess.Popen()
2924         directly instead of helper _create_process that has been
2925         removed. Use common.top_level_path() and common.build_path()
2926         instead of custom methods that have been removed too.
2927         (TestRunner._run_test_command): Use subprocess.Popen() directly
2928         instead of helper _create_process that has been removed.
2929
2930 2012-05-08  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2931
2932         [EFL] [DRT] Clear extra views before setting a blank page
2933         https://bugs.webkit.org/show_bug.cgi?id=85608
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         We need to clear the extra views before setting a blank page,
2938         otherwise it will cause more events interactions and sometimes
2939         trigger a unload(). This was causing frame-crash-with-page-cache.html
2940         to leak events to the next test causing any subsequent test to
2941         fail.
2942
2943         * DumpRenderTree/efl/DumpRenderTree.cpp:
2944         (runTest):
2945         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2946         (DumpRenderTreeChrome::clearExtraViews):
2947         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2948         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2949         (DumpRenderTreeChrome):
2950
2951 2012-05-08  Balazs Kelemen  <kbalazs@webkit.org>
2952
2953         [Qt] X11 plugins need to be reworked for Qt5+WK1
2954         https://bugs.webkit.org/show_bug.cgi?id=80691
2955
2956         Reviewed by Simon Hausmann.
2957
2958         Implement basic windowless plugin support with Qt5.
2959
2960         * qmake/mkspecs/features/features.prf:
2961         Enable NPAPI plugins if X11 libraries are available.
2962         * qmake/mkspecs/features/functions.prf:
2963         Added a convenience function to determine availability
2964         of X11 libraries.
2965
2966 2012-05-07  Raphael Kubo da Costa  <rakuco@webkit.org>
2967
2968         [webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
2969         https://bugs.webkit.org/show_bug.cgi?id=85852
2970
2971         Reviewed by Dirk Pranke.
2972
2973         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2974         (HttpServerBase._is_server_running_on_all_ports): Revert the part
2975         of r89412 which was a workaround for an issue with Python 2.5 on
2976         Mac 10.5.
2977
2978 2012-05-07  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2979
2980         webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
2981         https://bugs.webkit.org/show_bug.cgi?id=81481
2982
2983         Reviewed by Dirk Pranke.
2984
2985         FreeBSD has the same sysctl interface present in Darwin to query
2986         the number of CPUs available, so use that too.
2987
2988         * Scripts/webkitdirs.pm:
2989         (determineNumberOfCPUs): Share the sysctl call with Darwin.
2990         (isFreeBSD): Added.
2991
2992 2012-05-07  Alexis Menard  <alexis.menard@openbossa.org>
2993
2994         Unreviewed Qt build fix in Debug.
2995
2996         We need some system includes here for getpid() to be recognized.
2997
2998         * WebKitTestRunner/qt/main.cpp:
2999
3000 2012-05-07  Ojan Vafai  <ojan@chromium.org>
3001
3002         When embedding the flakiness dashboard, hide popups when the frame is blurred.
3003         https://bugs.webkit.org/show_bug.cgi?id=85684
3004
3005         Reviewed by Dirk Pranke.
3006
3007         If you show a popup, then click elsewhere in garden-o-matic, it will now
3008         properly hide it.
3009
3010         * TestResultServer/static-dashboards/dashboard_base.js:
3011         (showPopup):
3012         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3013         (showPopupForBuild):
3014         (generatePageForIndividualTests.if):
3015         (generatePageForIndividualTests):
3016         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
3017         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3018         * TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
3019
3020 2012-05-07  Ian Vollick  <vollick@chromium.org>
3021
3022         [chromium] WebViewHost should setCompositorSurfaceReady
3023         https://bugs.webkit.org/show_bug.cgi?id=85418
3024
3025         Reviewed by James Robinson.
3026
3027         * DumpRenderTree/chromium/WebViewHost.cpp:
3028         (WebViewHost::setWebWidget):
3029
3030 2012-05-07  Jon Lee  <jonlee@apple.com>
3031
3032         WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
3033         https://bugs.webkit.org/show_bug.cgi?id=42331
3034         <rdar://problem/8193641>
3035
3036         Reviewed by Darin Adler.
3037
3038         This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
3039         outputting some of the required strings. As tests become unskipped the other callbacks
3040         can be supported.
3041
3042         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
3043         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3044         (WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
3045         dump callbacks for the layoutTestController.
3046         (WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
3047         Output some warning if we are trying to extract a value that is not a boolean.
3048         (WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
3049         We cannot set the bits on the layoutTestController until it has been created in beginTesting().
3050         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3051         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3052         (WTR::InjectedBundle::didReceiveMessage):
3053         (WTR):
3054         (WTR::InjectedBundle::beginTesting):
3055         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3056         (InjectedBundle):
3057         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3058         (WTR):
3059         (WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
3060         -[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
3061         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
3062         (WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
3063         (WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
3064         (WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
3065         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
3066         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
3067         "willPerformClientRedirectToURL" so we will have to use that value here.
3068         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
3069         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.
3070         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3071         (WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.
3072         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3073         (WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
3074         (WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
3075         (WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
3076         (LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.
3077         * WebKitTestRunner/TestInvocation.cpp:
3078         (WTR::shouldLogFrameLoadDelegates): Similar to DRT.
3079         (WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
3080         to the injected bundle.
3081
3082 2012-05-07  Tommy Widenflycht  <tommyw@google.com>
3083
3084         [chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
3085         https://bugs.webkit.org/show_bug.cgi?id=85618
3086
3087         Reviewed by Adam Barth.
3088
3089         Adding the capability to control which MediaStreamTracks actually get created,
3090         and adding a test that exercises the JS api using that capability.
3091
3092         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3093         (WebKit::WebUserMediaClientMock::requestUserMedia):
3094         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3095         * DumpRenderTree/chromium/WebViewHost.cpp:
3096         (WebViewHost::testMediaStreamClient):
3097         * DumpRenderTree/chromium/WebViewHost.h:
3098         (WebViewHost):
3099
3100 2012-05-07  Zan Dobersek  <zandobersek@gmail.com>
3101
3102         [Gtk] WebGL feature is not built anymore through build-webkit after r116251
3103         https://bugs.webkit.org/show_bug.cgi?id=85788
3104
3105         Reviewed by Martin Robinson.
3106
3107         Enable WebGL by default for the Gtk port. The feature is already enabled by
3108         default in configure.ac, so there's no reason it shouldn't be enabled when
3109         building through build-webkit.
3110
3111         * Scripts/webkitperl/FeatureList.pm:
3112
3113 2012-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3114
3115         Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
3116         We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.
3117
3118         Reviewed by Tor Arne Vestbø.
3119
3120         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3121         (IRCCommandTest.test_whois):
3122
3123 2012-05-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3124
3125         Unreviewed, rolling out r116299, r116301, and r116303.
3126         http://trac.webkit.org/changeset/116299
3127         http://trac.webkit.org/changeset/116301
3128         http://trac.webkit.org/changeset/116303
3129         https://bugs.webkit.org/show_bug.cgi?id=85795
3130
3131         Build is still broken (Requested by Ossy on #webkit).
3132
3133         * DumpRenderTree/qt/DumpRenderTree.pro:
3134         * DumpRenderTree/qt/main.cpp:
3135         (main):
3136         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
3137         * QtTestPlatformPlugin/TestIntegration.cpp: Removed.
3138         * QtTestPlatformPlugin/TestIntegration.h: Removed.
3139         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
3140         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
3141         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
3142         * QtTestPlatformPlugin/main.cpp: Removed.
3143         * QtTestPlatformPlugin/testplatform.json: Removed.
3144         * Tools.pro:
3145         * WebKitTestRunner/Target.pri:
3146         * WebKitTestRunner/qt/main.cpp:
3147         (main):
3148
3149 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3150
3151         Unreviewed Qt build fix.
3152
3153         One more try to learn how to use
3154         const with a pointer array.
3155
3156         * DumpRenderTree/qt/main.cpp:
3157         (initializeTestPlatformPlugin):
3158
3159 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3160
3161         Unreviewed build fix after r116299.
3162
3163         * DumpRenderTree/qt/main.cpp:
3164         (initializeTestPlatformPlugin):
3165
3166 2012-05-07  Balazs Kelemen  <kbalazs@webkit.org>
3167
3168         [Qt] Add test specific platform plugin to achieve unified layout test results
3169         https://bugs.webkit.org/show_bug.cgi?id=80996
3170
3171         Reviewed by Simon Hausmann.
3172
3173         Added QtTestPlatformPlugin as a new project under Tools.
3174         This is a Qt5-ish platform plugin that can be used to tweak the
3175         platform support interfaces in order to unify layout test results.
3176         For now it only overrides the font database on Mac and redirects
3177         everything else to the real platform plugin. The font database it
3178         provides mimics the way how we set up test fonts with fontconfig on Linux.
3179         Make DumpRenderTree and WebKitTestRunner use this platform plugin.
3180
3181         * DumpRenderTree/qt/DumpRenderTree.pro:
3182         * DumpRenderTree/qt/main.cpp:
3183         (initializeTestPlatformPlugin):
3184         (main):
3185         * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
3186         * QtTestPlatformPlugin/TestIntegration.cpp: Added.
3187         (TestIntegration::TestIntegration):
3188         (TestIntegration::fontDatabase):
3189         * QtTestPlatformPlugin/TestIntegration.h: Added.
3190         (TestIntegration):
3191         (TestIntegration::hasCapability):
3192         (TestIntegration::createPlatformPixmap):
3193         (TestIntegration::createPlatformWindow):
3194         (TestIntegration::createPlatformBackingStore):
3195         (TestIntegration::createPlatformOpenGLContext):
3196         (TestIntegration::createPlatformSharedGraphicsCache):
3197         (TestIntegration::guiThreadEventDispatcher):
3198         (TestIntegration::clipboard):
3199         (TestIntegration::drag):
3200         (TestIntegration::inputContext):
3201         (TestIntegration::accessibility):
3202         (TestIntegration::nativeInterface):
3203         (TestIntegration::services):
3204         (TestIntegration::styleHint):
3205         (TestIntegration::platformTheme):
3206         * QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
3207         (TestFontDatabase):
3208         * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
3209         (TestFontDatabase::populateFontDatabase):
3210         * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
3211         (TestIntegration::fontDatabase):
3212         * QtTestPlatformPlugin/main.cpp: Added.
3213         (TestIntegrationPlugin::keys):
3214         (TestIntegrationPlugin::create):
3215         (TestIntegrationPlugin::initialize):
3216         * QtTestPlatformPlugin/testplatform.json: Added.
3217         * Tools.pro:
3218         * WebKitTestRunner/Target.pri:
3219         * WebKitTestRunner/qt/main.cpp:
3220         (main):
3221
3222 2012-05-07  Christophe Dumez  <christophe.dumez@intel.com>
3223
3224         [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
3225         https://bugs.webkit.org/show_bug.cgi?id=85609
3226
3227         Reviewed by Simon Hausmann.
3228
3229         Flakiness was caused by the fact that
3230         media/crash-closing-page-with-media-as-plugin-fallback.html and
3231         media/video-poster-blocked-by-willsendrequest.html use the same PNG
3232         file as poster attribute in the video tag. The PNG file gets cached
3233         when the first test is executed and this somehow causes the second
3234         test to fail.
3235
3236         The flakiness was addressed by clearing the memory and page caches
3237         between tests.
3238
3239         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3240         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3241
3242 2012-05-07  Eric Seidel  <eric@webkit.org>
3243
3244         Add values for all features to Qt's features.pri
3245         https://bugs.webkit.org/show_bug.cgi?id=85746
3246
3247         Reviewed by Tor Arne Vestbø.
3248
3249         When generate-feature-files generates features.pri it provides a value
3250         for every possible ENABLE_.  In prepration for landing generate-feature-files
3251         it seems appropriate to add a value for all possible ENABLEs to the existing
3252         features.pri.  This lets me make sure that I'm getting them all right!
3253
3254         * qmake/mkspecs/features/features.pri:
3255
3256 2012-05-07  Adam Bergkvist  <adam.bergkvist@ericsson.com>
3257
3258         Added myself as a committer.
3259
3260         Not reviewed.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2012-05-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3265
3266         [EFL][DRT] Implement LayoutTestController::execCommand
3267         https://bugs.webkit.org/show_bug.cgi?id=82286
3268
3269         Reviewed by Antonio Gomes.
3270
3271         Add missing implementation execCommand and isCommandEnabled to EFL's
3272         LayoutTestController.
3273
3274         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3275         (LayoutTestController::execCommand):
3276         (LayoutTestController::isCommandEnabled):
3277
3278 2012-05-06  Hayato Ito  <hayato@chromium.org>
3279
3280         [prepare-ChangeLog] Excludes a reference file used by reftests from test files.
3281         https://bugs.webkit.org/show_bug.cgi?id=74268
3282
3283         Reviewed by Ryosuke Niwa.
3284
3285         * Scripts/prepare-ChangeLog:
3286         (generateFileList):
3287
3288 2012-05-06  Mary Wu  <mary.wu@torchmobile.com.cn>
3289
3290         Add a contributor to committers.py
3291         https://bugs.webkit.org/show_bug.cgi?id=85761
3292
3293         Reviewed by Unreviewed.
3294
3295         Add myself to committers.py contributor.
3296
3297         * Scripts/webkitpy/common/config/committers.py:
3298
3299 2012-05-06  Dan Bernstein  <mitz@apple.com>
3300
3301         Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
3302         https://bugs.webkit.org/show_bug.cgi?id=85739
3303
3304         Reviewed by Daniel Bates.
3305
3306         * Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
3307         from here...
3308         * Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
3309
3310 2012-05-06  Andy Estes  <aestes@apple.com>
3311
3312         Fix the build after r116246.
3313
3314         * DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
3315
3316 2012-05-06  Eric Seidel  <eric@webkit.org>
3317
3318         Update several build-webkit options to match the #defines they toggle
3319         https://bugs.webkit.org/show_bug.cgi?id=85744
3320
3321         Reviewed by Adam Barth.
3322
3323         Most notable here is fixing --3d-canvas to be --webgl these days --
3324         the define was renamed 15 months ago!
3325
3326         * Scripts/webkitperl/FeatureList.pm:
3327
3328 2012-05-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3329
3330         [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
3331         https://bugs.webkit.org/show_bug.cgi?id=83687
3332
3333         Reviewed by Antonio Gomes.
3334
3335         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3336         (LayoutTestController::setJavaScriptCanAccessClipboard):
3337
3338 2012-05-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3339
3340         Convert isPageBoxVisible to use Internals interface.
3341         https://bugs.webkit.org/show_bug.cgi?id=85692
3342
3343         Reviewed by Darin Adler.
3344
3345         Remove isPageBoxVisible functions, because it is able to work in the
3346         cross-port way through the Internals interface.
3347
3348         * DumpRenderTree/LayoutTestController.cpp:
3349         (LayoutTestController::staticFunctions):
3350         * DumpRenderTree/LayoutTestController.h:
3351         (LayoutTestController):
3352         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3353         * DumpRenderTree/chromium/LayoutTestController.cpp:
3354         (LayoutTestController::LayoutTestController):
3355         * DumpRenderTree/chromium/LayoutTestController.h:
3356         (LayoutTestController):
3357         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3359         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3360         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3361         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3362         (LayoutTestController):
3363         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3364         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3365
3366 2012-05-06  Tom Zakrajsek  <tomz@codeaurora.org>
3367
3368         sheriffbot isn't reopening patches after it lands rollouts
3369         https://bugs.webkit.org/show_bug.cgi?id=64418
3370
3371         Reviewed by Adam Barth.
3372
3373         * Scripts/webkitpy/tool/commands/download_unittest.py:
3374         * Scripts/webkitpy/tool/steps/createbug.py:
3375         (CreateBug.run):
3376
3377 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
3378
3379         webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
3380         https://bugs.webkit.org/show_bug.cgi?id=85697
3381
3382         Reviewed by Eric Seidel.
3383
3384         * Scripts/new-run-webkit-tests: Instead of manually detecting whether
3385         the path separator should be ':' or ';' by checking sys.platform, rely
3386         on os.pathsep which has exactly the same information (os.pathsep is
3387         ':' for Cygwin, from what I could check in Python's sources).
3388
3389 2012-05-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3390
3391         Unreviewed, rolling out r116223.
3392         http://trac.webkit.org/changeset/116223
3393         https://bugs.webkit.org/show_bug.cgi?id=85718
3394
3395         The bots need to set XDG_DATA_DIRS (Requested by rakuco on
3396         #webkit).
3397
3398         * efl/jhbuildrc:
3399         * gtk/jhbuildrc:
3400
3401 2012-05-05  Raphael Kubo da Costa  <rakuco@webkit.org>
3402
3403         [jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
3404         https://bugs.webkit.org/show_bug.cgi?id=85717
3405
3406         Reviewed by Martin Robinson.
3407
3408         After r116209, the XDG_DATA_DIRS environment variable is now
3409         passed by webkitpy's layout_tests code to run-with-jhbuild, so
3410         instead of setting a few defaults in jhbuildrc we can now rely on
3411         the values set and really used by each system.
3412
3413         * efl/jhbuildrc:
3414         * gtk/jhbuildrc:
3415
3416 2012-05-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3417
3418         [Qt] Buildfix for --minimal build after r116107.
3419
3420         Reviewed by Csaba Osztrogonác.
3421
3422         * qmake/mkspecs/features/features.prf:
3423
3424 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
3425
3426         [Gtk] GtkDriver is not required anymore after r116134
3427         https://bugs.webkit.org/show_bug.cgi?id=85699
3428
3429         Reviewed by Csaba Osztrogonác.
3430
3431         Remove GtkDriver as it was replaced by the XvfbDriver and is
3432         no longer needed.
3433
3434         * Scripts/webkitpy/layout_tests/port/gtk.py:
3435
3436 2012-05-05  Zan Dobersek  <zandobersek@gmail.com>
3437
3438         Increase the display ID for the Xvfb process to use if pixel_tests argument
3439         is true rather than if pixel_tests option is present. This fixes the
3440         XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
3441
3442         Rubber-stamped by Csaba Osztrogonác.
3443
3444         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3445         (XvfbDriver._start):
3446
3447 2012-05-04  Raphael Kubo da Costa  <rakuco@webkit.org>
3448
3449         webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
3450         https://bugs.webkit.org/show_bug.cgi?id=85694
3451
3452         Reviewed by Martin Robinson.
3453
3454         This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
3455         preserved, as it is particularly useful for Linux/Unix
3456         environments.  As a real use case, if shared-mime-info is
3457         installed into a non-trivial prefix, Glib and other libraries will
3458         have trouble to properly identify mimetypes (in ResourceResponses,
3459         for example) as the base freedesktop.org mimetype file will not be
3460         found.
3461
3462         * Scripts/webkitpy/layout_tests/port/base.py:
3463         (Port.to.setup_environ_for_server):
3464
3465 2012-05-04  Gustavo Noronha Silva  <gns@gnome.org>
3466
3467         [GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
3468         https://bugs.webkit.org/show_bug.cgi?id=85691
3469
3470         * GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
3471
3472 2012-05-04  Eric Seidel  <eric@webkit.org>
3473
3474         Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
3475         https://bugs.webkit.org/show_bug.cgi?id=85583
3476
3477         Reviewed by Daniel Bates.
3478
3479         * Scripts/webkitperl/FeatureList.pm:
3480
3481 2012-05-04  Eric Seidel  <eric@webkit.org>
3482
3483         Sort entries in FeaturesList.pm to make them easier to autogenerate
3484         https://bugs.webkit.org/show_bug.cgi?id=85584
3485
3486         Reviewed by Daniel Bates.
3487
3488         No functional changes, only sorting.
3489
3490         * Scripts/webkitperl/FeatureList.pm:
3491
3492 2012-05-04  Andy Estes  <aestes@apple.com>
3493
3494         REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
3495         https://bugs.webkit.org/show_bug.cgi?id=85675
3496
3497         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
3498         (TestWebKitAPI::TEST): Disable the test.
3499
3500 2012-04-30  Jer Noble  <jer.noble@apple.com>
3501
3502         Full screen will exit during a provisional load of a non-ancestor iframe.
3503         https://bugs.webkit.org/show_bug.cgi?id=85230
3504
3505         Reviewed by Maciej Stachowiak .
3506
3507         Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
3508         * DumpRenderTree/mac/UIDelegate.mm:
3509         (-[UIDelegate webView:closeFullScreenWithListener:]):
3510
3511         Add support for the new closeFullScreen injected bundle method:
3512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3513         (WTR::InjectedBundlePage::InjectedBundlePage):
3514         (WTR::InjectedBundlePage::closeFullScreen):
3515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3516
3517 2012-05-04  Ojan Vafai  <ojan@chromium.org>
3518
3519         Fix test naming to be camel-case like the methods they are testing.
3520
3521         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3522         (test):
3523
3524 2012-05-04  Ojan Vafai  <ojan@chromium.org>
3525
3526         Show the results links in the embedded flakiness dashboard
3527         https://bugs.webkit.org/show_bug.cgi?id=85660
3528
3529         Reviewed by Adam Barth.
3530
3531         Turns out these links don't add much visual noise and it's annoying
3532         to have to go to the dashboard from garden-o-matic just to view the
3533         results for a test.
3534
3535         This is useful for cases where garden-o-matic doesn't properly show the
3536         results (e.g. missing tests). If we address all those cases, then
3537         we could easily hide the results links again if we wanted to.
3538
3539         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3540         (showUpdateInfoForTest):
3541         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3542         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3543         (test):
3544
3545 2012-05-04  Dirk Pranke  <dpranke@chromium.org>
3546
3547         Revert to using chromium --test-shell mode on SL in NRWT
3548
3549         https://bugs.webkit.org/show_bug.cgi?id=83076
3550
3551         Unreviewed, build fix.
3552
3553         We seem to be seeing a lot more flakiness on the bot since
3554         I switched NRWT to "DRT" mode. We'll try reverting back and
3555         see if this helps things.
3556
3557         * Scripts/webkitpy/layout_tests/port/chromium.py:
3558         (ChromiumDriver.__init__):
3559
3560 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
3561
3562         [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
3563         https://bugs.webkit.org/show_bug.cgi?id=84941
3564
3565         Reviewed by Martin Robinson.
3566
3567         Print MIME type detection messages in EFL's DumpRenderTree if
3568         LayoutTestController's dumpResourceResponseMIMETypes() returns true.
3569
3570         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3571         (DumpRenderTreeChrome::onResponseReceived):
3572
3573 2012-05-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
3574
3575         [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
3576         https://bugs.webkit.org/show_bug.cgi?id=85134
3577
3578         Reviewed by Martin Robinson.
3579
3580         Add missing implementation setDefersLoading and goBack to GTK's
3581         LayoutTestController so that the test case rely on these methods
3582         can be enabled.
3583
3584         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3585         (resetDefaultsToConsistentValues):
3586         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3587         (LayoutTestController::goBack):
3588         (LayoutTestController::setDefersLoading):
3589
3590 2012-05-04  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3591
3592         [Qt][NRWT] Run each DRT in it's own xvfb
3593         https://bugs.webkit.org/show_bug.cgi?id=77335
3594
3595         Reviewed by Dirk Pranke.
3596
3597         * Scripts/webkitpy/layout_tests/port/gtk.py:
3598         (GtkPort._driver_class):
3599         * Scripts/webkitpy/layout_tests/port/qt.py:
3600         (QtPort._driver_class):
3601         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
3602         (XvfbDriver):
3603         (XvfbDriver._start):
3604         (XvfbDriver._start.x_filter):
3605         (XvfbDriver.stop):
3606
3607 2012-05-04  Zan Dobersek  <zandobersek@gmail.com>
3608
3609         Use destructuring assingment for the return values of the
3610         port.diff_image() method call.
3611
3612         Rubber-stamped by Dirk Pranke.
3613
3614         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3615         (write_test_result):
3616
3617 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3618
3619         Store fewer runs by default in the flakiness dashboard
3620         https://bugs.webkit.org/show_bug.cgi?id=85568
3621
3622         Reviewed by Dirk Pranke.
3623
3624         This will greatly shrink the size of the json files we load,
3625         resulting in a much faster initial load. People rarely care
3626         about more than 100 runs. For the cases they do, they can still click
3627         the show all runs checkbox to show 500 runs.
3628
3629         * TestResultServer/model/jsonresults.py:
3630
3631 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
3632
3633         [EFL] Frame load callbacks output is missing for redirections
3634         https://bugs.webkit.org/show_bug.cgi?id=85173
3635
3636         Reviewed by Antonio Gomes.
3637
3638         Catch the new ewk_frame signals to print the expected output in case
3639         of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
3640         returns true.
3641
3642         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3643         (DumpRenderTreeChrome::createView):
3644         (DumpRenderTreeChrome::onWillSendRequest):
3645         (DumpRenderTreeChrome::onFrameCreated):
3646         (DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
3647         (DumpRenderTreeChrome::onFrameRedirectRequested):
3648         (DumpRenderTreeChrome::onResponseReceived):
3649         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3650         (DumpRenderTreeChrome):
3651
3652 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3653
3654         [Qt] Fix up warning about missing GLib/Gio/GStreamer
3655
3656         We don't actually fall back.
3657
3658         Rubber-stamped by Csaba Osztrogonác.
3659
3660         * qmake/mkspecs/features/features.prf:
3661
3662 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3663
3664         [Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
3665
3666         And only print it once.
3667
3668         Reviewed by Csaba Osztrogonác.
3669
3670         * qmake/mkspecs/features/features.prf:
3671
3672 2012-05-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3673
3674         [Qt] Clean up and split features.prf into a static list of defaults
3675
3676         The static list of feature defaults is used as a fallback for any
3677         feature that's not dynamically detected or overriden on the command
3678         line (though build-webkit or passing DEFINES+= to qmake).
3679
3680         The static list is complete, which allows for auto-generation based
3681         on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)
3682
3683         https://bugs.webkit.org/show_bug.cgi?id=85611
3684
3685         Reviewed by Simon Hausmann.
3686
3687         * Scripts/build-webkit:
3688         * Tools.pro:
3689         * qmake/mkspecs/features/features.prf:
3690         * qmake/mkspecs/features/features.pri: Added.
3691
3692 2012-05-04  Sheriff Bot  <webkit.review.bot@gmail.com>
3693
3694         Unreviewed, rolling out r116085, r116091, and r116095.
3695         http://trac.webkit.org/changeset/116085
3696         http://trac.webkit.org/changeset/116091
3697         http://trac.webkit.org/changeset/116095
3698         https://bugs.webkit.org/show_bug.cgi?id=85628
3699
3700         We are not ready with dependencies on all platform yet (mac) +
3701         problems with debug builds. (Requested by Zoltan on #webkit).
3702
3703         * qmake/mkspecs/features/features.prf:
3704
3705 2012-05-04  Christophe Dumez  <christophe.dumez@intel.com>
3706
3707         [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
3708         https://bugs.webkit.org/show_bug.cgi?id=85171
3709
3710         Reviewed by Andreas Kling.
3711
3712         Implement support for overriding "WebKitLoadSiteIconsKey" setting in
3713         EFL's LayoutTestController.
3714
3715         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3716         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3717         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3718         (LayoutTestController::overridePreference):
3719
3720 2012-05-03  Alexis Menard  <alexis.menard@openbossa.org>
3721
3722         [Qt] Enable fullscreen API for WebKit2.
3723         https://bugs.webkit.org/show_bug.cgi?id=85498
3724
3725         Reviewed by Simon Hausmann.
3726
3727         Enable the fullscreen API on the MiniBrowser and turn
3728         it default on WebKit2, disable it on WK1.
3729
3730         * MiniBrowser/qt/BrowserWindow.cpp:
3731         (BrowserWindow::BrowserWindow):
3732         * MiniBrowser/qt/qml/BrowserWindow.qml:
3733         * Scripts/webkitperl/FeatureList.pm:
3734         * qmake/mkspecs/features/features.prf:
3735
3736 2012-05-04  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3737
3738         REGRESSION(r116008) old-run-webkit-tests broken
3739         https://bugs.webkit.org/show_bug.cgi?id=85597
3740
3741         Reviewed by Simon Hausmann.
3742
3743         Reinstate libraryContainsSymbol.
3744
3745         * Scripts/webkitperl/features.pm:
3746         (libraryContainsSymbol):
3747
3748 2012-05-04  Zoltan Horvath  <zoltan@webkit.org>
3749
3750         [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
3751         https://bugs.webkit.org/show_bug.cgi?id=80400
3752
3753         Remove WTF_USE_QT_IMAGE_DECODER macro.
3754
3755         Reviewed by Simon Hausmann.
3756
3757         * qmake/mkspecs/features/features.prf:
3758
3759 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
3760
3761         [EFL] DRT should obey layoutTestController's addURLToRedirect()
3762         https://bugs.webkit.org/show_bug.cgi?id=82722
3763
3764         Reviewed by Maciej Stachowiak.
3765
3766         Implement support for layoutTestController's addURLToRedirect()
3767         in EFL's DRT so that it redirects properly when indicated.
3768
3769         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3770         (DumpRenderTreeChrome::onWillSendRequest):
3771
3772 2012-05-03  Christophe Dumez  <christophe.dumez@intel.com>
3773
3774         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
3775         https://bugs.webkit.org/show_bug.cgi?id=82704
3776
3777         Reviewed by Antonio Gomes.
3778
3779         EFL's DRT needs to obey LayoutTestController's
3780         willSendRequestReturnsNullOnRedirect().
3781
3782         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3783         (DumpRenderTreeChrome::onWillSendRequest):
3784
3785 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
3786
3787         git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
3788         https://bugs.webkit.org/show_bug.cgi?id=85570
3789
3790         Reviewed by Adam Roben.
3791
3792         The standard format of commit messages and ChangeLog entries has a
3793         short summary in the first line, followed by the bug URL in
3794         Bugzilla. Passing "%s" in the pretty format line to git-rev-list
3795         merges these two lines into a single one separated by a space
3796         character, which is not what we want.
3797
3798         Since "%s%n%n%b" is in practice "%B" (raw message), use it
3799         instead, as the first two lines do not end up being merged
3800         together.
3801
3802         * Scripts/git-add-reviewer:
3803         (writeCommitMessageToFile):
3804
3805 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3806
3807         Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
3808         https://bugs.webkit.org/show_bug.cgi?id=85566
3809
3810         Reviewed by Adam Barth.
3811
3812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3813         (.):
3814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3815         (.):
3816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3817
3818 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
3819
3820         webkitpy: Recognize FreeBSD as a valid platform.
3821         https://bugs.webkit.org/show_bug.cgi?id=81467
3822
3823         Reviewed by Adam Barth.
3824
3825         Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
3826         on FreeBSD does not raise an "unrecognized platform" exception.
3827
3828         Most of this patch contains some unit tests for the mentioned
3829         method, as currently platform-specific code is needed only on
3830         Windows.
3831
3832         * Scripts/webkitpy/common/system/platforminfo.py:
3833         (PlatformInfo.__init__):
3834         (PlatformInfo.is_freebsd):
3835         (PlatformInfo._determine_os_name):
3836         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3837         (MockPlatformInfo.is_freebsd):
3838         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3839         (fake_platform):
3840         (fake_platform.FakePlatformModule.release):
3841         (TestPlatformInfo.test_real_code):
3842         (TestPlatformInfo.test_os_name_and_wrappers):
3843         (TestPlatformInfo.test_os_version):
3844         (TestPlatformInfo.test_display_name):
3845         (TestPlatformInfo.test_total_bytes_memory):
3846         (TestPlatformInfo.test_free_bytes_memory):
3847         * Scripts/webkitpy/layout_tests/port/factory.py:
3848         (PortFactory._default_port):
3849
3850 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3851
3852         Make the table headers white-space:nowrap. This decreases the vertical size,
3853         which makes for more minimal embedding in garden-o-matic.
3854
3855         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
3856         (.table-header-content *):
3857
3858 2012-05-03  Eric Seidel  <eric@webkit.org>
3859
3860         Split build-webkit's feature option list off into its own module in preparation for autogeneration
3861         https://bugs.webkit.org/show_bug.cgi?id=85548
3862
3863         Reviewed by Daniel Bates.
3864
3865         My Perl-fu is very weak.  This moves the feature option list off into a separate module
3866         file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
3867         It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
3868         not to matter.  Also, build-webkit doesn't actually use any of the variables we're using to
3869         store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
3870         which is actually cleaner.  Callers can't assume that they would get a new array every time, but someone
3871         with more Perl-fu than I could create something fancier than this if we need in the future.
3872
3873         * Scripts/build-webkit:
3874         * Scripts/webkitperl/FeatureList.pm: Added.
3875         (getFeatureOptionList):
3876
3877 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
3878
3879         REGRESSION: run-webkit-tests failing on Chromium Mac
3880         https://bugs.webkit.org/show_bug.cgi?id=85459
3881
3882         Unreviewed, build fix.
3883
3884         Turns out select doesn't throw IOErrors, it has it's own kind of
3885         error :(. Trap that instead.
3886
3887         * Scripts/webkitpy/layout_tests/port/server_process.py:
3888         (ServerProcess._wait_for_data_and_update_buffers_using_select):
3889
3890 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
3891
3892         [CMake] Rewrite FindCairo.cmake.
3893         https://bugs.webkit.org/show_bug.cgi?id=84895
3894
3895         Reviewed by Daniel Bates.
3896
3897         The old approach relied on pkg-config for finding Cairo (which
3898         introduced a dependency on pkg-config that could be avoided), used
3899         the LibFindMacros code that we should probably remove in the
3900         future and did not use the FindPackageHandleStandardArguments
3901         module.
3902
3903         Change all that by rewriting the module.
3904         - Use the pkg-config output optionally instead of requiring it
3905         like LibFindMacros did.
3906         - Remove the implicit dependency on FreeType which often found it
3907         the wrong way via pkg-config and without considering
3908         CMAKE_PREFIX_PATH.
3909         - Retrieve the Cairo version by looking at cairo-version.h instead
3910         of relying on pkg-config. It requires some additional code for
3911         checking if the desired version has been found, but that will not
3912         be needed once we start depending on CMake 2.8.3 or later.
3913
3914         The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
3915         instead of <Name>_FOUND, and to keep things consistent
3916         Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
3917         and CAIRO_INCLUDE_DIRS.
3918
3919         * DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
3920         Cairo_FOO.
3921         * EWebLauncher/CMakeLists.txt: Ditto.
3922
3923 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3924
3925         Fix modifier and bug sorting on the flakiness dashboard
3926         https://bugs.webkit.org/show_bug.cgi?id=85554
3927
3928         Reviewed by Dirk Pranke.
3929
3930         The sorting assumes that the column header name matches a field
3931         in the testResults object and uses that field for sorting.
3932         Filter the bugs out of the modifiers list and put them in a bugs field
3933         and only put the non-bug modifiers in the modifiers list.
3934
3935         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3936         (populateExpectationsData):
3937         (htmlForSingleTestRow):
3938         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3939
3940 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3941
3942         Fix some state resetting when running unittests. HtmlForSingleTestRow
3943         was flaky.
3944
3945         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3946         (htmlForSingleTestRow):
3947         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3948         (resetGlobals):
3949
3950 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
3951
3952         webkitpy: Use PlatformInfo wherever possible in the User class.
3953         https://bugs.webkit.org/show_bug.cgi?id=85549
3954
3955         Reviewed by Dirk Pranke.
3956
3957         Instead of relying on sys.platform to detect whether the current
3958         platform is a Mac, use the PlatformInfo class instead.
3959
3960         * Scripts/webkitpy/common/system/user.py:
3961         (User.__init__):
3962         (User.edit_changelog):
3963
3964 2012-05-03  Ojan Vafai  <ojan@chromium.org>
3965
3966         Remove the percent failed column from the flakiness dashboard
3967         https://bugs.webkit.org/show_bug.cgi?id=85552
3968
3969         Reviewed by Dirk Pranke.
3970
3971         This column isn't useful enough to justify the visual noise.
3972
3973         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3974         (processMissingAndExtraExpectations):
3975         (tableHeaders):
3976         (htmlForSingleTestRow):
3977         (sortTests):
3978         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3979         (test):
3980
3981 2012-05-03  Eric Seidel  <eric@webkit.org>
3982
3983         --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
3984         https://bugs.webkit.org/show_bug.cgi?id=85542
3985
3986         Reviewed by Daniel Bates.
3987
3988         Remove these last two odd-men-out, so that we can generate the default feature options
3989         for build-webkit using the new generate-feature-files command.
3990         The Mac build system has some special casing for ENABLE_ defines which gets them
3991         defined as -D on the build command, even though initially they start out as
3992         environment variables ENABLE_FOO = ENABLE_FOO.  The Feature options in build-webkit
3993         depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
3994         I'm told that WTF_URL is not actively being worked on, so just removing it for now.
3995         It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
3996         should be made generically smarter about these USE_WTF defines.
3997         (There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
3998         used by Qt.  If someone tried build-webkit --tiled-backing-store on Mac today it
3999         would not work!)
4000
4001         * Scripts/build-webkit:
4002
4003 2012-05-03  Eric Seidel  <eric@webkit.org>
4004
4005         Remove the last bits of Leopard support from our perl scripts
4006         https://bugs.webkit.org/show_bug.cgi?id=85545
4007
4008         Reviewed by Daniel Bates.
4009
4010         Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
4011         Leopard support several months ago.  Remove the last bits of isLeopard() branching
4012         in our Perl scripts, since no one is using this (Chromium has never used this Perl code).
4013
4014         * Scripts/build-webkit:
4015         * Scripts/old-run-webkit-tests:
4016         (countAndPrintLeaks):
4017         (captureSavedCrashLog):
4018         * Scripts/webkitdirs.pm:
4019         (determineArchitecture):
4020         (argumentsForRunAndDebugMacWebKitApp):
4021
4022 2012-05-03  Ojan Vafai  <ojan@chromium.org>
4023
4024         [Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
4025         https://bugs.webkit.org/show_bug.cgi?id=85551
4026
4027         Reviewed by Dirk Pranke.
4028
4029         It's not uploading results and in the short term we don't plan to have it start.
4030
4031         * TestResultServer/static-dashboards/builders.js:
4032         (isChromiumWebkitTipOfTreeTestRunner):
4033         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4034
4035 2012-05-03  Ojan Vafai  <ojan@chromium.org>
4036
4037         Show the test name in the dashboard if showChrome==false and we're showing multiple tests
4038         https://bugs.webkit.org/show_bug.cgi?id=85243
4039
4040         Reviewed by Dirk Pranke.
4041
4042         This happens for cases where a test name matches multiple tests.
4043         In practice, this only happens for virtual test suites (e.g. the canvas tests).
4044
4045         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4046         (htmlForIndividualTestOnAllBuildersWithChrome):
4047         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4048         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
4049         (testHtmlForIndividualTestOnAllBuildersWithChrome):
4050         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
4051         (testHtmlForIndividualTests):
4052
4053 2012-05-03  Ojan Vafai  <ojan@chromium.org>
4054
4055         Port the flakiness dashboard unittests to qunit
4056         https://bugs.webkit.org/show_bug.cgi?id=85544
4057
4058         Reviewed by Adam Barth.
4059
4060         * TestResultServer/static-dashboards/dashboard_base.js:
4061         (appendJSONScriptElements):
4062         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4063         (resetGlobals):
4064         (runExpectationsTest):
4065         (test):
4066         * TestResultServer/static-dashboards/run-unittests.html: Added.
4067
4068 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
4069
4070         webkitpy: Remove check for readline on Mac.
4071         https://bugs.webkit.org/show_bug.cgi?id=85547
4072
4073         Reviewed by Eric Seidel.
4074
4075         Python 2.5 is not supported by the WebKit project anymore, and
4076         Python's readline documentation does not mention the module not
4077         being available in the supported versions.
4078
4079         * Scripts/webkitpy/common/system/user.py:
4080
4081 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4082
4083         [NRWT] Run performance tests with lock
4084         https://bugs.webkit.org/show_bug.cgi?id=78628
4085
4086         Reviewed by Tony Chang.
4087
4088         Locking performance tests (like we do for http tests) will force them
4089         to run in serial. This reduces the load of the machine when running perf
4090         tests and minimizes the chances of the tests to fail, specially
4091         timeouts.
4092
4093         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4094         (Manager.__init__):
4095         (Manager._is_perf_test):
4096         (Manager._test_requires_lock):
4097         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4098
4099 2012-05-03  Dirk Pranke  <dpranke@chromium.org>
4100
4101         Attempt to fix a crash on SL ...
4102
4103         Unreviewed, build fix.
4104
4105         It looks like we may be getting an IOError raised during
4106         select() on chromium mac, and that error isn't being caught.
4107         Pushing it into the try/catch block will hopefully catch this
4108         and allow us to see why the subprocess is crashing.
4109
4110         * Scripts/webkitpy/layout_tests/port/server_process.py:
4111         (ServerProcess._wait_for_data_and_update_buffers_using_select):
4112
4113 2012-05-02  Jon Honeycutt  <jhoneycutt@apple.com>
4114
4115         WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
4116         implemented for WebKit2
4117         https://bugs.webkit.org/show_bug.cgi?id=84304
4118
4119         Reviewed by Jessie Berlin.
4120
4121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4122         Added new files to project.
4123
4124         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
4125         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4126         Look for the "DidReceiveWillSendSubmitEvent" message. The message body
4127         will be the dictionary of form control names and values passed to the
4128         injected bundle's willSendSubmitEvent handler; look for the pairs
4129         "textField" -> "text field" and "passwordField" -> "password field".
4130         Check that "hiddenField" is not included.
4131         (TestWebKitAPI::setInjectedBundleClient):
4132         (TestWebKitAPI::TEST):
4133
4134         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
4135         (TestWebKitAPI::willSendSubmitEvent):
4136         Post a message to the TestWebKitAPI process with the dictionary of form
4137         control names and values that we received.
4138         (TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
4139         (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
4140         Set up the page's form client.
4141
4142         * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
4143
4144 2012-05-03  Eric Seidel  <eric@webkit.org>
4145
4146         Remove dead code from build-webkit for working around old XCode dependency bug
4147         https://bugs.webkit.org/show_bug.cgi?id=85535
4148
4149         Reviewed by Adam Barth.
4150
4151         Xcode used to have a bug whereby it didn't notice if you changed the #defines
4152         passed on the command line to xcodebuild.  I wrote code to work around this
4153         while bringing up SVG support 5-6 years ago.  I think we can finally remove this
4154         code from build-webkit, since SVG is the only feature flag to ever use it
4155         (modern in-progress features like MathML don't seem to be using the support)
4156         an I suspect the XCode bug has long been fixed.
4157
4158         * Scripts/build-webkit:
4159         * Scripts/webkitperl/features.pm:
4160
4161 2012-05-03  Andy Estes  <aestes@apple.com>
4162
4163         InjectedBundleControllerMac.mm needs to include config.h
4164         https://bugs.webkit.org/show_bug.cgi?id=85531
4165
4166         Reviewed by Andreas Kling.
4167
4168         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
4169
4170 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
4171
4172         webkitpy: Use PlatformInfo whenever possible in server_process.py.
4173         https://bugs.webkit.org/show_bug.cgi?id=85516
4174
4175         Reviewed by Eric Seidel.
4176
4177         Eliminate direct access to sys.platform wherever possible by using
4178         PlatformInfo.is_win() instead.
4179
4180         * Scripts/webkitpy/layout_tests/port/server_process.py:
4181         (ServerProcess.__init__): Remove the executive parameter as it was
4182         not passed by any caller, obtain a SystemHost from port_obj
4183         instead.
4184         (ServerProcess._log): Style, remove extra empty line.
4185         (ServerProcess._start):
4186         (ServerProcess.stop):
4187         (ServerProcess.kill):
4188         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
4189         (TrivialMockPort.__init__): Create a MockSystemHost used by
4190         ServerProcess.
4191         (TestServerProcess.test_broken_pipe): Test different platforms.
4192
4193 2012-05-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4194
4195         webkitpy: Style checker broken when committing a PNG
4196         https://bugs.webkit.org/show_bug.cgi?id=85504
4197
4198         Reviewed by Dirk Pranke.
4199
4200         * Scripts/webkitpy/style/checkers/png.py:
4201         (PNGChecker.__init__):
4202
4203 2012-05-03  Philippe Normand  <pnormand@igalia.com>
4204
4205         Unreviewed, fix another call to join(), similar to the ones landed
4206         in r115975.
4207
4208         * Scripts/webkitdirs.pm:
4209         (jhbuildConfigurationChanged):
4210
4211 2012-05-03  Raphael Kubo da Costa  <rakuco@webkit.org>
4212
4213         webkitpy: Remove sys.platform accesses in CrashLogs.
4214         https://bugs.webkit.org/show_bug.cgi?id=85436
4215
4216         Reviewed by Dirk Pranke.
4217
4218         Instead of directly checking for sys.platform == 'darwin', use a
4219         SystemHost and call PlatformInfo.is_mac().
4220
4221         * Scripts/webkitpy/common/system/crashlogs.py:
4222         (CrashLogs.__init__):
4223         (CrashLogs.find_newest_log):
4224         (CrashLogs._log_directory_darwin):
4225         (CrashLogs._find_newest_log_darwin):
4226         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4227         (CrashLogsTest.test_find_log_darwin):
4228         * Scripts/webkitpy/layout_tests/port/mac.py:
4229         (MacPort._get_crash_log):
4230         * Scripts/webkitpy/layout_tests/port/test.py:
4231         (TestDriver.run_test):
4232         * Scripts/webkitpy/tool/commands/queries.py:
4233         (execute):
4234
4235 2012-05-03  Philippe Normand  <pnormand@igalia.com>
4236
4237         [GTK] join() is wrongly used in webkitdirs.pm since r115532
4238         https://bugs.webkit.org/show_bug.cgi?id=85501
4239
4240         Reviewed by Martin Robinson.
4241
4242         * Scripts/webkitdirs.pm:
4243         (getJhbuildPath):
4244         (buildAutotoolsProject):
4245
4246 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
4247
4248         [Gtk] ImageDiff crashes when it can't open a display
4249         https://bugs.webkit.org/show_bug.cgi?id=85476
4250
4251         Reviewed by Martin Robinson.
4252
4253         Replace gdk_init() initialization call with the g_type_init()
4254         call. GdkPixbufLoader doesn't actually need the current call to be
4255         made and this change will also remove crashes when ImageDiff
4256         is started in an environment without a DISPLAY env.
4257
4258         * DumpRenderTree/gtk/ImageDiff.cpp:
4259         (main):
4260
4261 2012-05-03  Zan Dobersek  <zandobersek@gmail.com>
4262
4263         ImageDiff should be run inside a properly established environment
4264         https://bugs.webkit.org/show_bug.cgi?id=85292
4265
4266         Reviewed by Martin Robinson.
4267
4268         When creating the ImageDiff server process, pass along a freshly-set-up environment
4269         in which the process should be executed in.
4270
4271         * Scripts/webkitpy/layout_tests/port/webkit.py:
4272         (WebKitPort._start_image_diff_process):
4273
4274 2012-05-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4275
4276         [Qt] Allow the web process and WTR to be paused on startup
4277
4278         Makes it easier to debug the web process or run-webkit-tests -2, as you
4279         have ample time to attach gdb to the process.
4280
4281         Reviewed by Simon Hausmann.
4282
4283         * Scripts/webkitpy/layout_tests/port/qt.py:
4284         (QtPort.setup_environ_for_server):
4285         * WebKitTestRunner/qt/main.cpp:
4286         (main):
4287
4288 2012-05-03  Csaba Osztrogonác  <ossy@webkit.org>
4289
4290         Password protect "Stop build" button
4291         https://bugs.webkit.org/show_bug.cgi?id=81982
4292
4293         Reviewed by Ryosuke Niwa.
4294
4295         Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
4296         features to prevent killing builds on build.webkit.org by SPAM bots.
4297
4298         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4299
4300 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
4301
4302         [DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
4303         https://bugs.webkit.org/show_bug.cgi?id=85468
4304
4305         Reviewed by Nikolas Zimmermann.
4306
4307         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4308         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
4309         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4310         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
4311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4312         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
4313         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4314         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
4315         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4316         (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
4317
4318 2012-05-03  Stephanie Lewis  <slewis@apple.com>
4319
4320         https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
4321         <rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
4322
4323         Reviewed by Brady Eidson.
4324
4325         The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
4326         for every world, even those that did not need the callback.  This had the side effect of creating a
4327         JSDOMWindowShell that the associated world didn't necessarily know to clean up.  Instead of creating
4328         unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
4329         in the API.  The object can be accessed later by those worlds which require it.
4330
4331         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
4332         (TestWebKitAPI):
4333         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4334         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
4335         (TestWebKitAPI):
4336         (DOMWindowExtensionBasic):
4337         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
4338         (TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
4339         (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
4340
4341 2012-05-03  Nikolas Zimmermann  <nzimmermann@rim.com>
4342
4343         Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.
4344
4345         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4346         (LayoutTestController::resetPageVisibility):
4347         (LayoutTestController::setPageVisibility):
4348
4349 2012-05-02  Alexander Færøy  <ahf@0x90.dk>
4350
4351         Rename deviceDPI to devicePixelRatio
4352         https://bugs.webkit.org/show_bug.cgi?id=85049
4353
4354         Reviewed by Kenneth Rohde Christiansen.
4355
4356         Use 1.5 as device pixel ratio for the Qt MiniBrowser.
4357
4358         * MiniBrowser/qt/qml/BrowserWindow.qml:
4359
4360 2012-05-03  Dongwoo Im  <dw.im@samsung.com>
4361
4362         [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
4363         https://bugs.webkit.org/show_bug.cgi?id=85347
4364
4365         Reviewed by Nikolas Zimmermann.
4366
4367         * DumpRenderTree/LayoutTestController.h:
4368         (LayoutTestController):
4369         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4370         (LayoutTestController::resetPageVisibility): Not implemented.
4371         (LayoutTestController::setPageVisibility): Not implemented.
4372         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4373         (LayoutTestController::resetPageVisibility): Reset the page visibility.
4374         (LayoutTestController::setPageVisibility): Set the page visibility.
4375         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4376         (LayoutTestController::resetPageVisibility): Not implemented.
4377         (LayoutTestController::setPageVisibility): Not implemented.
4378         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4379         (LayoutTestController::resetPageVisibility): Not implemented.
4380         (LayoutTestController::setPageVisibility): Not implemented.
4381         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4382         (LayoutTestController::resetPageVisibility): Not implemented.
4383         (LayoutTestController::setPageVisibility): Not implemented.
4384         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4385         (LayoutTestController::resetPageVisibility): Not implemented.
4386         (LayoutTestController::setPageVisibility): Not implemented.
4387
4388 2012-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
4389
4390         Unreviewed, rolling out r115918.
4391         http://trac.webkit.org/changeset/115918
4392         https://bugs.webkit.org/show_bug.cgi?id=85452
4393
4394         "Broke test-webkitpy on Apple Lion bots" (Requested by estes
4395         on #webkit).
4396
4397         * Scripts/webkitpy/common/system/crashlogs.py:
4398         (CrashLogs.__init__):
4399         (CrashLogs.find_newest_log):
4400         (CrashLogs._log_directory_darwin):
4401         (CrashLogs._find_newest_log_darwin):
4402         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4403         (CrashLogsTest.test_find_log_darwin):
4404         * Scripts/webkitpy/layout_tests/port/mac.py:
4405         (MacPort._get_crash_log):
4406         * Scripts/webkitpy/layout_tests/port/test.py:
4407         (TestDriver.run_test):
4408         * Scripts/webkitpy/tool/commands/queries.py:
4409         (execute):
4410
4411 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4412
4413         webkitpy: Remove sys.platform accesses in CrashLogs.
4414         https://bugs.webkit.org/show_bug.cgi?id=85436
4415
4416         Reviewed by Dirk Pranke.
4417
4418         Instead of directly checking for sys.platform == 'darwin', use a
4419         SystemHost and call PlatformInfo.is_mac().
4420
4421         * Scripts/webkitpy/common/system/crashlogs.py:
4422         (CrashLogs.__init__):
4423         (CrashLogs.find_newest_log):
4424         (CrashLogs._log_directory_darwin):
4425         (CrashLogs._find_newest_log_darwin):
4426         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
4427         (CrashLogsTest.test_find_log_darwin):
4428         * Scripts/webkitpy/layout_tests/port/mac.py:
4429         (MacPort._get_crash_log):
4430         * Scripts/webkitpy/layout_tests/port/test.py:
4431         (TestDriver.run_test):
4432         * Scripts/webkitpy/tool/commands/queries.py:
4433         (execute):
4434
4435 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4436
4437         webkitpy: Special-case win32 calls in file_lock and executive.
4438         https://bugs.webkit.org/show_bug.cgi?id=85431
4439
4440         Reviewed by Dirk Pranke.
4441
4442         Simplify accesses to sys.platform by only checking if sys.platform
4443         is "win32" and removing explicit checks for the else case.
4444
4445         * Scripts/webkitpy/common/system/executive.py:
4446         (Executive.check_running_pid):
4447         * Scripts/webkitpy/common/system/file_lock.py:
4448         (FileLock._create_lock):
4449         (FileLock._remove_lock):
4450
4451 2012-05-02  Ojan Vafai  <ojan@chromium.org>
4452
4453         Remove pink from flakiness dashboard
4454         https://bugs.webkit.org/show_bug.cgi?id=85422
4455
4456         Reviewed by Dirk Pranke.
4457
4458         The pink indicates that the test doesn't match it's listing in test_expectations.txt.
4459         In practice, this just added noise and confused people.
4460
4461         * TestResultServer/static-dashboards/flakiness_dashboard.js:
4462         (htmlForSingleTestRow):
4463         (showLegend):
4464         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
4465         (#legend-contents *):
4466         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4467         (testHtmlForSingleTestRow):
4468
4469 2012-05-02  Gustavo Noronha Silva  <gns@gnome.org>
4470
4471         Unreviewed. Fix mistake I committed when applying review comments.
4472
4473         * jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
4474         appended to its path, so jhbuild itself was being cloned and
4475         installed in the wrong place when using WEBKITOUTPUTDIR.
4476
4477 2012-05-02  Dirk Pranke  <dpranke@chromium.org>
4478
4479         nrwt: make ServerProcess work on chromium win
4480         https://bugs.webkit.org/show_bug.cgi?id=85333
4481
4482         Reviewed by Ojan Vafai.
4483
4484         This change implements a poor man's select() that will
4485         slow-spin doing non-blocking reads on the stdout and stderr
4486         named pipes connecting the worker to the driver. Seems to work
4487         and I have yet to see much overhead or ill effects but it
4488         probably needs more testing.
4489
4490         * Scripts/webkitpy/layout_tests/port/chromium.py:
4491         (ChromiumDriver.__init__):
4492         * Scripts/webkitpy/layout_tests/port/server_process.py:
4493         (ServerProcess._start):
4494         (ServerProcess._wait_for_data_and_update_buffers_using_select):
4495         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
4496         (ServerProcess):
4497         (ServerProcess._non_blocking_read_win32):
4498         (ServerProcess._read):
4499         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
4500         (TestServerProcess.test_basic): Added.
4501
4502 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4503
4504         webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
4505         https://bugs.webkit.org/show_bug.cgi?id=85426
4506
4507         Reviewed by Dirk Pranke.
4508
4509         r115880 replaced the direct use of sys.platform with a
4510         PlatformInfo object. Dirk Pranke later told me SystemHost objects
4511         should be preferred, as nothing out of webkitpy.common.system
4512         should create its own PlatformInfo instances.
4513
4514         * Scripts/webkitpy/common/system/systemhost_mock.py:
4515         (MockSystemHost.__init__): Make it possible to specify a custom
4516         filesystem object.
4517         * Scripts/webkitpy/style/checkers/png.py:
4518         (PNGChecker.__init__): Accept a host object instead of a
4519         filesystem one, which is now obtained from host.
4520         (PNGChecker._config_file_path): Retrieve PlatformInfo from
4521         SystemHost.
4522         * Scripts/webkitpy/style/checkers/png_unittest.py:
4523         (PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
4524         constructor signature.
4525         (PNGCheckerTest.test_check): Ditto.
4526
4527 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4528
4529         webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
4530         https://bugs.webkit.org/show_bug.cgi?id=85424
4531
4532         Reviewed by Tony Chang.
4533
4534         We should reduce direct usage of sys.platform in webkitpy and use
4535         PlatformInfo instead.
4536
4537         * Scripts/webkitpy/layout_tests/servers/http_server.py:
4538         (Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
4539         checking for 'darwin' directly.
4540         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
4541         (HttpServerBase.__init__): Ditto.
4542
4543 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4544
4545         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
4546         https://bugs.webkit.org/show_bug.cgi?id=85419
4547
4548         Reviewed by Dirk Pranke.
4549
4550         As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
4551         be created directly, we should should a SystemHost instead.
4552
4553         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4554         (MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
4555         object from it instead of creating PlatformInfo directly.
4556
4557 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4558
4559         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
4560         https://bugs.webkit.org/show_bug.cgi?id=85419
4561
4562         Rubber-stamped by Dirk Pranke.
4563
4564         Follow-up patch to r115887 which fixes some capitalization problems
4565         pointed out in comments 2 and 4.
4566
4567         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4568         (MainTest.setUp):
4569         (MainTest.test_child_processes_2):
4570         (MainTest.test_child_processes_min):
4571         (MainTest.test_exception_raised):
4572         (MainTest.test_keyboard_interrupt):
4573
4574 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4575
4576         webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
4577         https://bugs.webkit.org/show_bug.cgi?id=85419
4578
4579         Reviewed by Dirk Pranke.
4580
4581         Another part of the work towards replacing direct sys.platform
4582         usage with PlatformInfo.
4583
4584         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4585         (MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
4586         here. Even though it is costlier, unittest.setUpClass was
4587         introduced in Python 2.7.
4588         (MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
4589         (MainTest.test_child_processes_min): Ditto.
4590         (MainTest.test_exception_raised): Ditto.
4591         (MainTest.test_keyboard_interrupt): Ditto.
4592         (MainTest.test_crash_log): Check for PlatformInfo.is_mac().
4593         (MainTest.test_web_process_crash_log): Ditto, and remove duplicate
4594         check at the end.
4595         (MainTest.test_no_http_tests): Remove check for (cygwin && Python
4596         2.5.2), as we only support Python 2.6+.
4597
4598 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4599
4600         webkitpy: Remove direct sys.platform usage in the PNG checker.
4601         https://bugs.webkit.org/show_bug.cgi?id=85407
4602
4603         Reviewed by Tony Chang.
4604
4605         Work towards replacing direct sys.platform usage with
4606         PlatformInfo.
4607
4608         * Scripts/webkitpy/common/system/platforminfo_mock.py:
4609         (MockPlatformInfo.__init__): Accept os_name and os_version as
4610         arguments.
4611         * Scripts/webkitpy/style/checkers/png.py:
4612         (PNGChecker.__init__): Create a PlatformInfo object instead of
4613         using sys.platform when needed.
4614         (PNGChecker._config_file_path): Check for the current platform via
4615         PlatformInfo.
4616         * Scripts/webkitpy/style/checkers/png_unittest.py:
4617         (PNGCheckerTest.test_check): Update tests after the changes above.
4618
4619 2012-05-02  Raphael Kubo da Costa  <rakuco@webkit.org>
4620
4621         [watchlist] Update watchlist rules for EFL-related patches.
4622         http://bugs.webkit.org/show_bug.cgi?id=85160
4623
4624         Reviewed by Eric Seidel.
4625
4626         * Scripts/webkitpy/common/config/watchlist: Monitor
4627         Source/WTF/wtf/efl and LayoutTests/platform/efl as well.
4628
4629 2012-05-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
4630
4631         Revert r115191 - "Make the web view's url property follow the active url"
4632
4633         It uncovered/caused issues in the icon-implementation that can't be
4634         easily fixed, so rolling out instead.
4635
4636         https://bugs.webkit.org/show_bug.cgi?id=77554
4637
4638         Rubber-stamped by Simon Hausmann.
4639
4640         * MiniBrowser/qt/qml/BrowserWindow.qml:
4641         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4642         (TestWebKitAPI::TEST):
4643
4644 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
4645
4646         Reftest mismatches are providing undefined diff percent in results.html
4647         https://bugs.webkit.org/show_bug.cgi?id=85283
4648
4649         Reviewed by Ojan Vafai.
4650
4651         When writing test results for a reftest mismatch, also take into account the
4652         difference percent that is produced when generating image diff. This value is
4653         then used when creating test results in the form of dictionaries, stored under
4654         the 'image_diff_percent' key. It ultimately ends up in JSON results data,
4655         providing additional information about the reftest difference.
4656
4657         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4658         (interpret_test_failures): Store the diff percent for reftest failure under the
4659         'image_diff_percent' key.
4660         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4661         (write_test_result): Also set the new diff_percent attribute of the reftest
4662         mismatch failure to the value of the difference percent ImageDiff outputs.
4663         * Scripts/webkitpy/layout_tests/models/test_failures.py:
4664         (FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
4665         default value of None.
4666         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4667         (EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.
4668
4669 2012-05-02  Terry Anderson  <tdanderson@chromium.org>
4670
4671         Addition of a contributor to committers.py
4672         https://bugs.webkit.org/show_bug.cgi?id=85324
4673
4674         Reviewed by Unreviewed.
4675
4676         * Scripts/webkitpy/common/config/committers.py:
4677
4678 2012-05-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
4679
4680         [EFL] EFL's LayoutTestController overridePreference implementation
4681         https://bugs.webkit.org/show_bug.cgi?id=83007
4682
4683         Reviewed by Antonio Gomes.
4684
4685         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4686         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4687         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4688         (toBool): aux function converting JSStringRef to bool
4689         (toInt): aux function converting JSStringRef to int
4690         (LayoutTestController::overridePreference): added implementation
4691
4692 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
4693
4694         webkitpy: Fix sys.platform check in find_files_unittest.
4695         https://bugs.webkit.org/show_bug.cgi?id=85339
4696
4697         Reviewed by Ryosuke Niwa.
4698
4699         Follow-up to r101618 -- 'win' is not a valid sys.platform value,
4700         'win32' should be used instead. The check always returned false
4701         due to this, so assert_normalize() was never called.
4702
4703         * Scripts/webkitpy/common/find_files_unittest.py:
4704         (TestWinNormalize.test_win): Add the missing import for the
4705         FileSystem class and fix the sys.platform check.
4706
4707 2012-05-02  Zan Dobersek  <zandobersek@gmail.com>
4708
4709         [GTK] drag&drop related failures
4710         https://bugs.webkit.org/show_bug.cgi?id=84675
4711
4712         Reviewed by Philippe Normand.
4713
4714         Rather than checking options to see whether we're running pixel tests
4715         the pixel_tests argument passed to GtkDriver._start should be used as
4716         it also covers cases when pixel tests should be run because of testing
4717         reftests. This again creates different Xvfb processes with proper
4718         display IDs for a worker that's performing both ordinary and pixel
4719         tests, as was the case before changes made in r114788.
4720
4721         * Scripts/webkitpy/layout_tests/port/gtk.py:
4722         (GtkDriver._start):
4723
4724 2012-05-02  Simon Hausmann  <simon.hausmann@nokia.com>
4725
4726         [Qt] Enable device orientation/motion with Qt 5
4727
4728         Reviewed by Tor Arne Vestbø.
4729
4730         Enable device orientation/motion features with Qt 5 if Qt Sensors is available.
4731
4732         * qmake/mkspecs/features/features.prf:
4733
4734 2012-05-01  Raphael Kubo da Costa  <rakuco@webkit.org>
4735
4736         webkitpy: Remove unused platform imports.
4737         https://bugs.webkit.org/show_bug.cgi?id=85341
4738
4739         Reviewed by Eric Seidel.
4740
4741         Remove a few uses of `import platform' which were either rendered
4742         unneeded after r105931 or were never needed at all.
4743
4744         * Scripts/webkitpy/common/system/executive.py:
4745         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4746
4747 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
4748
4749         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
4750         https://bugs.webkit.org/show_bug.cgi?id=85289
4751
4752         Reviewed by Eric Seidel.
4753
4754         * DumpRenderTree/chromium/EventSender.cpp:
4755         (EventSender::gestureEvent):
4756             This change will allow for testing of WK85101. Currently
4757             no tests use the extra parameters deltaX and deltaY. Added
4758             a check for the size of |arguments|.
4759
4760 2012-05-01  Eric Seidel  <eric@webkit.org>
4761
4762         Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
4763         https://bugs.webkit.org/show_bug.cgi?id=85305
4764
4765         Reviewed by Adam Barth.
4766
4767         * Scripts/webkitpy/common/config/watchlist:
4768
4769 2012-05-01  Sheriff Bot  <webkit.review.bot@gmail.com>
4770
4771         Unreviewed, rolling out r115735.
4772         http://trac.webkit.org/changeset/115735
4773         https://bugs.webkit.org/show_bug.cgi?id=85314
4774
4775         cause two tests to crash due to an ASSERTION failure
4776         (Requested by zhenyao on #webkit).
4777
4778         * DumpRenderTree/chromium/EventSender.cpp:
4779         (EventSender::gestureEvent):
4780
4781 2012-05-01  Terry Anderson  <tdanderson@chromium.org>
4782
4783         [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
4784         https://bugs.webkit.org/show_bug.cgi?id=85289
4785
4786         Reviewed by Eric Seidel.
4787
4788         * DumpRenderTree/chromium/EventSender.cpp:
4789         (EventSender::gestureEvent):
4790             This change will allow for testing of WK85101. Currently no tests use the extra
4791             parameters deltaX and deltaY.
4792
4793 2012-05-01  Zan Dobersek  <zandobersek@gmail.com>
4794
4795         Print out stderr output of ImageDiff if it is present
4796         https://bugs.webkit.org/show_bug.cgi?id=85285
4797
4798         Reviewed by Philippe Normand.
4799
4800         Log the stderr output of ImageDiff as a warning if present. This is
4801         especially helpful when ImageDiff crashes and stderr data might contain
4802         relevant information about what caused the crash.
4803
4804         * Scripts/webkitpy/layout_tests/port/webkit.py:
4805         (WebKitPort._read_image_diff):
4806
4807 2012-05-01  Kenneth Rohde Christiansen  <kenneth@webkit.org>
4808
4809         [Qt] Add an experimental extension to set the min. contents width
4810         https://bugs.webkit.org/show_bug.cgi?id=85281
4811
4812         Reviewed by Antonio Gomes.
4813
4814         * MiniBrowser/qt/qml/BrowserWindow.qml:
4815
4816         Set the value of preferredMinimumContentsWidth to 980.
4817
4818 2012-04-30  Ojan Vafai  <ojan@chromium.org>
4819
4820         Fix tests to not depend on the actual list of builders at build.chromium.org.
4821
4822         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
4823         (testHtmlForIndividualTestOnAllBuildersWithChrome):
4824         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
4825
4826 2012-04-29  Sam Weinig  <sam@webkit.org>
4827
4828         Remove BlobBuilder
4829         https://bugs.webkit.org/show_bug.cgi?id=84036
4830
4831         Reviewed by Anders Carlsson.
4832
4833         * Scripts/build-webkit:
4834         * qmake/mkspecs/features/features.prf:
4835         Make exposing the WebKitBlobBuilder JS object conditional on a new
4836         ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
4837         but do for everyone else.
4838
4839 2012-04-30  Amruth Raj Padmanabhuni  <amruthraj@motorola.com>
4840
4841         [GTK] Add glib as a dependency to build glib-networking
4842         https://bugs.webkit.org/show_bug.cgi?id=85181
4843
4844         Reviewed by Martin Robinson.
4845
4846         * gtk/jhbuild.modules:
4847
4848 2012-04-30  Alexis Menard  <alexis.menard@openbossa.org>
4849
4850         Move myself to reviewers.
4851
4852         Reviewed by Andreas Kling.
4853
4854         * Scripts/webkitpy/common/config/committers.py:
4855
4856 2012-04-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4857
4858         Unreviewed, move myself to reviewers
4859
4860         * Scripts/webkitpy/common/config/committers.py:
4861
4862 2012-04-30  Carlos Garcia Campos  <cgarcia@igalia.com>
4863
4864         Unreviewed. Fix make distcheck.
4865
4866         * TestWebKitAPI/GNUmakefile.am: Add missing headers to compilation
4867         and resources to EXTRA_DIST.
4868
4869 2012-04-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4870
4871         [GTK] DRT support for layoutTestController.removeOriginAccessWhitelistEntry
4872         https://bugs.webkit.org/show_bug.cgi?id=85156
4873
4874         Reviewed by Martin Robinson.
4875
4876         Add missing implementation removeOriginAccessWhitelistEntry to
4877         GTK's LayoutTestController.
4878
4879         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4880         (LayoutTestController::removeOriginAccessWhitelistEntry):
4881
4882 2012-04-29  Maciej Stachowiak  <mjs@apple.com>
4883
4884         REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
4885         https://bugs.webkit.org/show_bug.cgi?id=81729
4886
4887         Reviewed by Dan Bernstein.
4888
4889         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4890         (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
4891
4892 2012-04-29  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
4893
4894         [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
4895         https://bugs.webkit.org/show_bug.cgi?id=85131
4896
4897         Reviewed by Martin Robinson.
4898
4899         Add missing implementation setDomainRelaxationForbiddenForURLScheme to
4900         GTK's LayoutTestController.
4901
4902         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4903         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
4904
4905 2012-04-28  Sam Weinig  <sam@webkit.org>
4906
4907         Smooth scrolling needs a new key
4908         <rdar://problem/11331632>
4909
4910         Reviewed by Dan Bernstein.
4911
4912         * DumpRenderTree/mac/DumpRenderTree.mm:
4913         (resetDefaultsToConsistentValues):
4914         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
4915         (TestWebKitAPI::InjectedBundleController::platformInitialize):
4916         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4917         (WTR::InjectedBundle::platformInitialize):
4918         Update for new key.
4919
4920 2012-04-28  Zan Dobersek  <zandobersek@gmail.com>
4921
4922         [WK2] http/tests/navigation/anchor-frames-gbk.html fails
4923         https://bugs.webkit.org/show_bug.cgi?id=76896
4924
4925         Reviewed by Darin Adler.
4926
4927         Only dump as text if currently dumping render tree. This ensures that
4928         calling dumpAsText in a test with dumpChildFramesAsText already being
4929         called doesn't override the first decision, possibly making tests fail.
4930
4931         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4932         (WTR::LayoutTestController::dumpAsText):
4933
4934 2012-04-28  Dan Winship  <danw@gnome.org>
4935
4936         Unreviewed; Add me to the SoupNetwork watchlist
4937
4938         * Scripts/webkitpy/common/config/watchlist:
4939
4940 2012-04-27  Gustavo Noronha Silva  <gns@gnome.org>
4941
4942         [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
4943         https://bugs.webkit.org/show_bug.cgi?id=76161
4944
4945         Reviewed by Martin Robinson.
4946
4947         * Scripts/webkitdirs.pm:
4948         (getJhbuildPath): New method to obtain the jhbuild base directory,
4949         using the product base directory
4950         (jhbuildConfigurationChanged): Use the new method
4951         (buildAutotoolsProject): Ditto.
4952         * efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
4953         * gtk/jhbuildrc: Ditto.
4954         * jhbuild/jhbuild-wrapper: Ditto.
4955
4956 2012-04-27  Scott Graham  <scottmg@chromium.org>
4957
4958         [chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
4959         https://bugs.webkit.org/show_bug.cgi?id=85083
4960
4961         Reviewed by Dirk Pranke.
4962
4963         Make output product_name for npTestNetscapePlugIn.dll match the case
4964         of the copy_TestNetscapePlugIn rule. This is required for ninja, which
4965         is more particular about case matching in rules than the VS build.
4966
4967         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
4968
4969 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
4970
4971         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
4972         https://bugs.webkit.org/show_bug.cgi?id=84917
4973
4974         Unreviewed, build fix.
4975
4976         Reland the change in r115453 with a fix for chromium win.
4977         The logic in ChromiumDriver was busted on windows, causing DRT
4978         to get launched without the --test-shell flag.
4979
4980         * Scripts/webkitpy/layout_tests/port/chromium.py:
4981         (ChromiumDriver):
4982         (ChromiumDriver.__init__):
4983         (ChromiumDriver._wrapper_options):
4984         (ChromiumDriver.cmd_line):
4985         (ChromiumDriver._start):
4986         (ChromiumDriver.has_crashed):
4987         (ChromiumDriver.run_test):
4988         (ChromiumDriver.stop):
4989         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4990         (ChromiumDriverTest.setUp):
4991         (ChromiumDriverTest.test_stop):
4992         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
4993         (ChromiumDriverTest.test_two_drivers):
4994
4995 2012-04-27  Peter Beverloo  <peter@chromium.org>
4996
4997         Add John Grabowski as a non-committer to committers.py
4998         https://bugs.webkit.org/show_bug.cgi?id=85080
4999
5000         Reviewed by Dirk Pranke.
5001
5002         He's being CC'ed often enough because of his involvement in the Chromium
5003         side of Chrome for Android upstreaming.
5004
5005         * Scripts/webkitpy/common/config/committers.py:
5006           add jrg@chromium.org
5007
5008 2012-04-27  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
5009
5010         [Qt] Fix minimal build.
5011         https://bugs.webkit.org/show_bug.cgi?id=85045
5012
5013         Reviewed by Tor Arne Vestbø.
5014
5015         Do not set conflicting values of ENABLE_XSLT.
5016
5017         * qmake/mkspecs/features/features.prf:
5018
5019 2012-04-27  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
5020
5021         [EFL][DRT] EFL should sanitize pulseaudio module configuration too
5022         https://bugs.webkit.org/show_bug.cgi?id=85047
5023
5024         Reviewed by Dirk Pranke.
5025
5026         PulseAudio test setup sanitization shared between EFL and GTK.
5027
5028         * Scripts/webkitpy/layout_tests/port/efl.py:
5029         (EflPort):
5030         (EflPort.setup_test_run):
5031         (EflPort.clean_up_test_run):
5032         * Scripts/webkitpy/layout_tests/port/gtk.py:
5033         (GtkPort): Moving pulseaudio unload/restore out to shared class.
5034         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.
5035         (PulseAudioSanitizer):
5036         (PulseAudioSanitizer._unload_pulseaudio_module):
5037         (PulseAudioSanitizer._restore_pulseaudio_module):
5038
5039 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
5040
5041         Unreviewed, revert r115453 - broke chromium win bots
5042
5043         * Scripts/webkitpy/layout_tests/port/chromium.py:
5044         (ChromiumPort._path_to_image_diff):
5045         (ChromiumDriver):
5046         (ChromiumDriver.__init__):
5047         (ChromiumDriver._wrapper_options):
5048         (ChromiumDriver.cmd_line):
5049         (ChromiumDriver.stop):
5050         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
5051         (ChromiumDriverTest.setUp):
5052         (ChromiumDriverTest.test_stop):
5053         (ChromiumDriverTest.test_two_drivers):
5054         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
5055
5056 2012-04-27  Ryosuke Niwa  <rniwa@webkit.org>
5057
5058         Chromium Windows Perf bots timeout due to not output
5059         https://bugs.webkit.org/show_bug.cgi?id=84940
5060
5061         Reviewed by Dirk Pranke.
5062
5063         Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
5064         Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
5065         built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
5066         this will fix the issue on the bot.
5067
5068         * Scripts/run-perf-tests:
5069         * Scripts/webkitpy/performance_tests/perftest.py:
5070         (PerfTest.run):
5071         (PerfTest.run_failed):
5072         (PerfTest.parse_output):
5073         (PerfTest.output_statistics):
5074         (ChromiumStylePerfTest.parse_output):
5075         (PageLoadingPerfTest.run):
5076         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
5077         (MainTest.test_parse_output):
5078         (MainTest.test_parse_output_with_failing_line):
5079         (TestPageLoadingPerfTest):
5080         (TestPageLoadingPerfTest.test_run):
5081         (TestPageLoadingPerfTest.test_run_with_bad_output):
5082         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
5083         (PerfTestsRunner.__init__):
5084         (PerfTestsRunner._parse_args):
5085         (PerfTestsRunner.run):
5086         (PerfTestsRunner._upload_json):
5087         (PerfTestsRunner._print_status):
5088         (PerfTestsRunner._run_tests_set):
5089         (PerfTestsRunner._run_single_test):
5090         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
5091         (create_runner):
5092         (test_run_test_set):
5093         (test_run_test_set_kills_drt_per_run):
5094         (test_run_test_pause_before_testing):
5095         (test_run_test_set_for_parser_tests):
5096         (test_run_test_set_with_json_output):
5097         (test_run_test_set_with_json_source):
5098         (test_run_test_set_with_multiple_repositories):
5099         (test_upload_json):
5100         (test_parse_args):
5101
5102 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
5103
5104         [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
5105         https://bugs.webkit.org/show_bug.cgi?id=84917
5106
5107         Reviewed by Ojan Vafai.
5108
5109         This change changes the chromium new-run-webkit-tests
5110         implementation to use the code in WebKitDriver and ServerProcess
5111         by default on Mac and Linux, instead of using the old-style
5112         Chromium/test_shell style of output.
5113
5114         We will still use the test_shell style on Windows for now
5115         and you can still get the old style of behavior with
5116         new-run-webkit-tests --additional-drt-flag --test-shell
5117
5118         * Scripts/webkitpy/layout_tests/port/chromium.py:
5119         (ChromiumDriver):
5120         (ChromiumDriver.__init__):
5121         (ChromiumDriver._wrapper_options):
5122         (ChromiumDriver.cmd_line):
5123         (ChromiumDriver._start):
5124         (ChromiumDriver.has_crashed):
5125         (ChromiumDriver.run_test):
5126         (ChromiumDriver.stop):
5127         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
5128         (ChromiumDriverTest.setUp):
5129         (ChromiumDriverTest.test_stop):
5130         (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
5131         (ChromiumDriverTest.test_two_drivers):
5132
5133 2012-04-27  Dirk Pranke  <dpranke@chromium.org>
5134
5135         webkitpy: fix race in unit tests for manager_worker_broker
5136         https://bugs.webkit.org/show_bug.cgi?id=84925
5137
5138         Reviewed by Ojan Vafai.
5139
5140         I have been intermittently seeing hangs when running
5141         test-webkitpy on Mac SL; it appears that there's a bug (?) in
5142         the multiprocessing module where queue references are getting
5143         leaked or not cleaned up somehow. By explicitly closing the
5144         queues, things seem to be happy, so this patch adds a cleanup()
5145         method to the message broker and modifies the manager (and the
5146         unit tests) to call it. This may get rid of the intermittent
5147         error on shutdown on Linux I've seen as well.
5148
5149         * Scripts/webkitpy/layout_tests/controllers/manager.py:
5150         (Manager._run_tests):
5151         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
5152         (_Broker.__del__):
5153         (_Broker):
5154         (_Broker.cleanup):
5155         (_BrokerConnection.cleanup):
5156         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
5157         (_TestsMixin.test_name):
5158         (_TestsMixin.test_cancel):
5159         (_TestsMixin.test_done):
5160         (_TestsMixin.test_unknown_message):
5161
5162 2012-04-27  Gavin Peters  <gavinp@chromium.org>
5163
5164         Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
5165         https://bugs.webkit.org/show_bug.cgi?id=84871
5166
5167         Reviewed by Adam Barth.
5168
5169         Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
5170         API separates it from prefetching.  Having separate include guards lets ports enable prefetching,
5171         a relatively easy change, without needing to build the infrastructure for prerendering, which
5172         is considerably more complicated.
5173
5174 2012-04-27  Philippe Normand  <pnormand@igalia.com>
5175
5176         Unreviewed, GTK gardening.
5177
5178         * Scripts/run-gtk-tests:
5179         (TestRunner): Skip flaky WebKit2 API test.
5180
5181 2012-04-27  Philippe Normand  <pnormand@igalia.com>
5182
5183         Unreviewed, GTK gardening.
5184
5185         * Scripts/run-gtk-tests:
5186         (TestRunner): Fix another typo. So easy to get confused by a Test
5187         name and the actual name of the executable...
5188
5189 2012-04-27  Philippe Normand  <pnormand@igalia.com>
5190
5191         Unreviewed, GTK gardening.
5192
5193         * Scripts/run-gtk-tests:
5194         (TestRunner): Skip failing WebKit2 API test.
5195
5196 2012-04-27  Christophe Dumez  <christophe.dumez@intel.com>
5197
5198         [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
5199         https://bugs.webkit.org/show_bug.cgi?id=81891
5200
5201         Reviewed by Philippe Normand.
5202
5203         Implement support for LayoutTestController's
5204         dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
5205         ewk_view signals about resource loading and print out the expected
5206         information. This allows for several test cases to be removed from the
5207         skip list.
5208
5209         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5210         (DumpRenderTreeChrome::createView):
5211         (descriptionSuitableForTestResult):
5212         (DumpRenderTreeChrome::onResponseReceived):
5213         (DumpRenderTreeChrome::onResourceLoadFinished):
5214         (DumpRenderTreeChrome::onResourceLoadFailed):
5215         (DumpRenderTreeChrome::onNewResourceRequest):
5216         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
5217         (DumpRenderTreeChrome):
5218
5219 2012-04-27  Philippe Normand  <pnormand@igalia.com>
5220
5221         Unreviewed, GTK typo fix.
5222
5223         * Scripts/run-gtk-tests:
5224         (TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.
5225
5226 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5227
5228         [SOUP] Add a way to register custom uri schemes in WebKit2
5229         https://bugs.webkit.org/show_bug.cgi?id=84130
5230
5231         Reviewed by Martin Robinson.
5232
5233         * Scripts/webkitpy/style/checkers/cpp.py:
5234         (check_identifier_name_in_declaration): Add webkit_soup prefix to
5235         the list of exceptions to the underscores in identifiers rule.
5236
5237 2012-04-26  Ryosuke Niwa  <rniwa@webkit.org>
5238
5239         Extract PerfTestFactory
5240         https://bugs.webkit.org/show_bug.cgi?id=83944
5241
5242         Reviewed by Dirk Pranke.
5243
5244         Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
5245         a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.
5246
5247         Also added simple test cases to sanity check PerfTestFactory.
5248
5249         * Scripts/webkitpy/performance_tests/perftest.py:
5250         (PerfTest.__init__):
5251         (PerfTest.test_name):
5252         (ChromiumStylePerfTest.__init__):
5253         (PageLoadingPerfTest.__init__):
5254         (PageLoadingPerfTest.run):
5255         (PerfTestFactory):
5256         (PerfTestFactory.create_perf_test):
5257         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
5258         (MainTest.test_parse_output):
5259         (MainTest.test_parse_output_with_failing_line):
5260         (TestPageLoadingPerfTest.test_run):
5261         (TestPageLoadingPerfTest.test_run_with_bad_output):
5262         (TestPerfTestFactory):
5263         (TestPerfTestFactory.test_regular_test):
5264         (TestPerfTestFactory.test_inspector_test):
5265         (TestPerfTestFactory.test_page_loading_test):
5266         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
5267         (PerfTestsRunner):
5268         (PerfTestsRunner._collect_tests):
5269         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
5270         (run_test):
5271         (_tests_for_runner):
5272
5273 2012-04-26  Dirk Pranke  <dpranke@chromium.org>
5274
5275         nrwt: clean up server process, webkit driver so chromium can use it
5276         https://bugs.webkit.org/show_bug.cgi?id=84910
5277
5278         Reviewed by Ojan Vafai.
5279
5280         This change moves the "sample a process" logic out of
5281         server_process.py and into a port-specific class (where really
5282         only the mac has an implementation), and also preemptively kills
5283         DRT when a test times out in WebKitDriver (rather than waiting through the
5284         additional delays caused by calling stop() when we would want to
5285         restart the driver generically in worker.py).
5286
5287         These changes will make it possible for the chromium port to
5288         switch over to the stock WebKitDriver implementation, at least
5289         on mac and linux.
5290
5291         * Scripts/webkitpy/layout_tests/port/base.py:
5292         (Port.sample_process):
5293         * Scripts/webkitpy/layout_tests/port/mac.py:
5294         (MacPort.sample_process):
5295         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
5296         (test_helper_fails_to_stop):
5297         (test_sample_process):
5298         (test_sample_process.logging_run_command):
5299         (test_sample_process_throws_exception):
5300         (test_sample_process_throws_exception.throwing_run_command):
5301         * Scripts/webkitpy/layout_tests/port/server_process.py:
5302         (ServerProcess._log):
5303         (ServerProcess._handle_timeout):
5304         (ServerProcess.stop):
5305         (ServerProcess):
5306         (ServerProcess.kill): Here we add a method to immediately stop
5307         the process rather than trying to shut it down cleanly.
5308         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
5309         (TestServerProcess.test_broken_pipe):
5310         * Scripts/webkitpy/layout_tests/port/webkit.py:
5311         (WebKitDriver.run_test): Fix an issue where we weren't passing
5312         along any per-test args (only needed for Chromium, but still).
5313         Also, kill the driver immediately if we time out a test.
5314
5315 2012-04-26  Benjamin Poulain  <bpoulain@apple.com>
5316
5317         ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
5318         https://bugs.webkit.org/show_bug.cgi?id=84668
5319
5320         Reviewed by Alexey Proskuryakov.
5321
5322         Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
5323
5324         * DumpRenderTree/mac/ObjCPlugin.m:
5325         (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
5326         (+[ObjCPlugin webScriptNameForSelector:]):
5327         (-[ObjCPlugin methodMappedToLongName]):
5328         (-[ObjCPlugin testConversionColon:]):
5329         (-[ObjCPlugin _:]):
5330
5331 2012-04-26  Dimitri Glazkov  <dglazkov@chromium.org>
5332
5333         Unreviewed, rolling out r115340.
5334         http://trac.webkit.org/changeset/115340
5335         https://bugs.webkit.org/show_bug.cgi?id=83048
5336
5337         Does not work with Windows.
5338
5339         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
5340         (SingleTestRunner._run_reftest):
5341         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
5342         (copy_file):
5343         * Scripts/webkitpy/layout_tests/port/base.py:
5344         (Port._parse_reftest_list):
5345         (Port.reference_files):
5346         (Port._real_tests):
5347         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
5348         (PortTest.test_reference_files):
5349         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
5350         (ChromiumDriverTest.test_write_command_and_read_line):
5351
5352 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
5353
5354         [EFL] Enable VIDEO_TRACK feature
5355         https://bugs.webkit.org/show_bug.cgi?id=84830
5356
5357         Reviewed by Gustavo Noronha Silva.
5358
5359         Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
5360         used.
5361
5362         * Scripts/build-webkit:
5363
5364 2012-04-08  Robert Hogan  <robert@webkit.org>
5365
5366         new-webkit-run-tests: handle ref tests from the CSS test suite
5367         https://bugs.webkit.org/show_bug.cgi?id=83048
5368
5369         Reviewed by Ryosuke Niwa.
5370
5371         This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
5372         of pixel and text results that are no longer required now that the reference results are used and adds in the support
5373         files from the CSS test suite that allow the ref tests to run.
5374
5375         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
5376         (SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
5377          run without it and report a pass!
5378         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
5379         (copy_file): ensure the output directory exists, it may not if the reference test is
5380           contained in a folder that contains nothing but reference tests.
5381         * Scripts/webkitpy/layout_tests/port/base.py:
5382         (Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
5383         (Port.reference_files): Only return reference results in the reftest list that actually exist on
5384           disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
5385           don't ignore them just because we have a reftest list for the test's directory.
5386         (Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
5387           is used by the CSS 2.1 test suite.
5388         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
5389         (PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
5390           on disk but no reference result listed in the directory's reftest list picks up its reference result.
5391         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
5392         (ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
5393          as the same file.
5394
5395 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5396
5397         Unreviewed. Fix GTK+ build after r115314.
5398
5399         For some reason it fails while bulding GtkVersioning for WTR, but
5400         it didn't fail neither in EWS nor in my laptop. We don't really
5401         need GtkVersioning in WTR since it already depends on GTK+3
5402         unconditionally.
5403
5404         * WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
5405         compilation.
5406         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
5407         (WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
5408         directly instead of getDefaultGDKPointerDevice() helper.
5409         (WTR::EventSenderProxy::keyDown): Ditto.
5410         (WTR::EventSenderProxy::mouseMoveTo): Ditto.
5411
5412 2012-04-24  Ojan Vafai  <ojan@chromium.org>
5413
5414         Show flakiness dashboard data in garden-o-matic
5415         https://bugs.webkit.org/show_bug.cgi?id=83716
5416
5417         Reviewed by Dimitri Glazkov.
5418
5419         Put an iframe below the expected/actual results in the Results view.
5420         Size the iframe to it's height.
5421
5422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
5423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
5424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
5425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
5426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
5427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
5428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
5429
5430 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
5431
5432         [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
5433         https://bugs.webkit.org/show_bug.cgi?id=84576
5434
5435         Reviewed by Martin Robinson.
5436
5437         Add missing implementation setJavaScriptProfilingEnabled to EFL's
5438         LayoutTestController in order to unskip tests rely on this setting.
5439
5440         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5441         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
5442         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
5443         (LayoutTestController::setJavaScriptProfilingEnabled):
5444
5445 2012-04-26  Xianzhu Wang  <wangxianzhu@chromium.org>
5446
5447         Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
5448
5449         Not reviewed.
5450
5451         * Scripts/webkitpy/common/config/committers.py:
5452
5453 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5454
5455         [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
5456         https://bugs.webkit.org/show_bug.cgi?id=84957
5457
5458         Reviewed by Martin Robinson.
5459
5460         * Scripts/run-gtk-tests:
5461         (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
5462         TestNewFirstVisuallyNonEmptyLayoutForImages.
5463         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
5464         (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
5465         toplevel window containing the web view to make sure events are
5466         received.
5467
5468 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5469
5470         Unreviewed. Add bug numbers to skipped tests.
5471
5472         * Scripts/run-gtk-tests:
5473         (TestRunner):
5474
5475 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5476
5477         [GTK] Build and run TestWebKitAPI WebKit2 unit tests
5478         https://bugs.webkit.org/show_bug.cgi?id=84446
5479
5480         Reviewed by Philippe Normand.
5481
5482         * Scripts/run-gtk-tests:
5483         (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
5484         containing tests. Unskip FunctionalTest.RefCountedStorage, since
5485         we are now using a custom main that initializes WTF threading.
5486         (TestRunner._setup_testing_environment): Set environment variables
5487         required to run WebKit2 tests.
5488         * TestWebKitAPI/GNUmakefile.am:
5489         * TestWebKitAPI/JavaScriptTest.cpp: Use
5490         JavaScriptCore/JSContextRef.h instead of
5491         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
5492         unconditionally.
5493         * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
5494         PlatformWindow for GTK.
5495         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
5496         unneded header that breaks the build of GTK port.
5497         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
5498         JavaScriptCore/JSContextRef.h instead of
5499         JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
5500         unconditionally.
5501         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
5502         (TestWebKitAPI::TEST): Add expected values for GTK+ port.
5503         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
5504         (TestWebKitAPI):
5505         (TestWebKitAPI::InjectedBundleController::platformInitialize):
5506         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
5507         (TestWebKitAPI::Util::checkTestFinished):
5508         (TestWebKitAPI::Util::run):
5509         (TestWebKitAPI::Util::sleep):
5510         (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
5511         (TestWebKitAPI::Util::createInjectedBundlePath):
5512         (TestWebKitAPI::Util::createURLForResource):
5513         (TestWebKitAPI::Util::URLForNonExistentResource):
5514         (TestWebKitAPI::Util::isKeyDown):
5515         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
5516         (TestWebKitAPI::PlatformWebView::PlatformWebView):
5517         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
5518         (TestWebKitAPI::PlatformWebView::page):
5519         (TestWebKitAPI::PlatformWebView::resizeTo):
5520         (TestWebKitAPI::doKeyStroke):
5521         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
5522         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
5523         (TestWebKitAPI::doMouseButtonEvent):
5524         (TestWebKitAPI::PlatformWebView::simulateRightClick):
5525         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
5526         * TestWebKitAPI/gtk/main.cpp:
5527         (main):
5528
5529 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5530
5531         [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
5532         https://bugs.webkit.org/show_bug.cgi?id=84695
5533
5534         Reviewed by Philippe Normand.
5535
5536         It also adds a command line option to be able to pass a custom
5537         timeout value, instead of hard-coding it. The default timeout is 10
5538         seconds if no other value is passed to the script.
5539
5540         * Scripts/run-gtk-tests:
5541         (TestTimeout): Exception raised when a test times out.
5542         (TestRunner._get_child_pid_from_test_output): Helper function to
5543         get the pid of the running test from gtester output.
5544         (TestRunner._kill_process): Helper funtion ot kill a process
5545         ignoring exceptions if the process is already died.
5546         (TestRunner._run_test_command): Run the test command raising
5547         TestTimeout exception if the test doesn't finish before the given
5548         timeout in seconds.
5549         (TestRunner._run_test_command.alarm_handler): Alarm handler that
5550         raises TestTimeout exception.
5551         (TestRunner._run_test_glib): Use _run_test_command() to run the test.
5552         (TestRunner._run_test_google): Ditto.
5553         (TestRunner.run_tests): Add current test to the list of timed out
5554         test if TestTimeout exception is raised. Show the list of timed
5555         out test at the end.
5556
5557 2012-04-26  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
5558
5559         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
5560         https://bugs.webkit.org/show_bug.cgi?id=83880
5561
5562         Reviewed by Antonio Gomes.
5563
5564         Add missing implementation addOriginAccessWhitelistEntry and
5565         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
5566         in order to unskip tests which rely on this.
5567
5568         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5569         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
5570         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
5571         (LayoutTestController::addOriginAccessWhitelistEntry):
5572         (LayoutTestController::removeOriginAccessWhitelistEntry):
5573
5574 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5575
5576         [GTK] Add downloads support to MiniBrowser
5577         https://bugs.webkit.org/show_bug.cgi?id=73662
5578
5579         Reviewed by Philippe Normand.
5580
5581         * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
5582         (browserDownloadsBarChildRemoved): Close the downloads bar if
5583         there aren't active downloads.
5584         (browserDownloadsBarResponse): Destroy the downloads bar when
5585         closed.
5586         (browser_downloads_bar_init):
5587         (browser_downloads_bar_class_init):
5588         (browser_downloads_bar_new): Create a new downloads bar.
5589         (actionButtonClicked): Cancel the download if cancel button was
5590         clicked, or open the downloaded file if the download finished.
5591         (browserDownloadFinalize):
5592         (browser_download_init):
5593         (browser_download_class_init):
5594         (downloadReceivedResponse): Update download message using the
5595         response URI.
5596         (remainingTime): Helper function to get human readable remaining
5597         time.
5598         (downloadProgress): Update downloads progress.
5599         (downloadReceivedData):
5600         (downloadFinished): Update download message and turn download
5601         button into open.
5602         (downloadFailed): Show error message or destroy the download UI if
5603         it was cancelled.
5604         (browserDownloadNew): Create a new download widget for the given
5605         WebKitDownload.
5606         (browser_downloads_bar_add_download): Add download widget to the
5607         downloads bar.
5608         * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
5609         * MiniBrowser/gtk/BrowserWindow.c:
5610         (downloadStarted): Create a download widget and add it to the
5611         downloads bar when a new download is started.
5612         (browserWindowConstructed): Connect to
5613         WebKitWebContext::download-started signal.
5614         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
5615
5616 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
5617
5618         Unreviewed. Skip unit test failing in debug bot.
5619
5620         * Scripts/run-gtk-tests:
5621         (TestRunner):
5622
5623 2012-04-26  Christophe Dumez  <christophe.dumez@intel.com>
5624
5625         [EFL][DRT] "resource,request,willsend" signal needs to provide more information
5626         https://bugs.webkit.org/show_bug.cgi?id=84670
5627
5628         Reviewed by Andreas Kling.
5629
5630         Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
5631         passed with the "resource,request,willsend" signal and dump
5632         information about the network request and the possible network
5633         response if LayoutTestController's dumpResourceLoadCallbacks() returns
5634         true.
5635
5636         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5637         (pathSuitableForTestResult):
5638         (urlSuitableForTestResult):
5639         (descriptionSuitableForTestResult):
5640         (DumpRenderTreeChrome::onWillSendRequest):
5641
5642 2012-04-25  Csaba Osztrogonác  <ossy@webkit.org>
5643
5644         [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
5645         http://trac.webkit.org/changeset/113703
5646         https://bugs.webkit.org/show_bug.cgi?id=83024
5647
5648         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
5649         * Tools.pro:
5650         * qmake/mkspecs/features/features.prf:
5651         * qmake/mkspecs/features/functions.prf:
5652
5653 2012-04-25  Maciej Stachowiak  <mjs@apple.com>
5654
5655         Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
5656         https://bugs.webkit.org/show_bug.cgi?id=84931
5657
5658         Reviewed by Filip Pizlo.
5659
5660         * DumpRenderTree/mac/LayoutTestHelper.m:
5661         (installLayoutTestColorProfile): Account for the possibility of the default
5662         profile being a factory profile.
5663
5664 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
5665
5666         Unreviewed, rolling out r115240.
5667         http://trac.webkit.org/changeset/115240
5668         https://bugs.webkit.org/show_bug.cgi?id=84928
5669
5670         It broke everything (Requested by Ossy_HOME on #webkit).
5671
5672         * Scripts/webkitpy/layout_tests/port/gtk.py:
5673         (GtkDriver):
5674         (GtkDriver._start):
5675         (GtkDriver._start.x_filter):
5676         (GtkDriver.stop):
5677         (GtkPort._driver_class):
5678         * Scripts/webkitpy/layout_tests/port/qt.py:
5679         (QtPort._build_driver):
5680         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
5681
5682 2012-04-25  Dirk Pranke  <dpranke@chromium.org>
5683
5684         [chromium] change DRT's "DRT" output to match the other ports
5685         https://bugs.webkit.org/show_bug.cgi?id=84904
5686
5687         Reviewed by Kent Tamura.
5688
5689         Since we run Chromium's DRT in --test-shell mode, the
5690         non-test-shell output has never been really beaten on to make
5691         sure it's right. This fixes a few issues and will be tested
5692         with upcoming NRWT changes that'll land in a separate patch.
5693         In particular we should never output framing text like "\n"
5694         or "#EOF" outside of something outside of TestEventPrinter,
5695         and we weren't handling audio output properly at all.
5696
5697         * DumpRenderTree/chromium/TestEventPrinter.cpp:
5698         (DRTPrinter):
5699         (TestShellPrinter):
5700         (DRTPrinter::handleTextFooter):
5701         (DRTPrinter::handleAudioFooter):
5702         (DRTPrinter::handleTestFooter):
5703         (TestShellPrinter::handleAudioFooter):
5704         * DumpRenderTree/chromium/TestEventPrinter.h:
5705         (TestEventPrinter):
5706         * DumpRenderTree/chromium/TestShell.cpp:
5707         (TestShell::TestShell):
5708         (TestShell::dump):
5709
5710 2012-04-25  Joshua Bell  <jsbell@chromium.org>
5711
5712         Unreviewed: Adding Alec Flett as a contributor (non-committer).
5713
5714         * Scripts/webkitpy/common/config/committers.py:
5715
5716 2012-04-25  Abhishek Arya  <inferno@chromium.org>
5717
5718         Mark myself as a reviewer.
5719         https://bugs.webkit.org/show_bug.cgi?id=84902
5720
5721         Reviewed by Dimitri Glazkov.
5722
5723         * Scripts/webkitpy/common/config/committers.py:
5724
5725 2012-04-25  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
5726
5727         [Qt][NRWT] Run each DRT in it's own xvfb
5728         https://bugs.webkit.org/show_bug.cgi?id=77335
5729
5730         Reviewed by Dirk Pranke.
5731
5732         * Scripts/webkitpy/layout_tests/port/gtk.py:
5733         (GtkPort._driver_class):
5734         * Scripts/webkitpy/layout_tests/port/qt.py:
5735         (QtPort._driver_class):
5736         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
5737         (XvfbDriver):
5738         (XvfbDriver._start):
5739         (XvfbDriver._start.x_filter):
5740         (XvfbDriver.stop):
5741
5742 2012-04-25  Sheriff Bot  <webkit.review.bot@gmail.com>
5743
5744         Unreviewed, rolling out r115222.
5745         http://trac.webkit.org/changeset/115222
5746         https://bugs.webkit.org/show_bug.cgi?id=84874
5747
5748         Caused test regressions on the EFL build (Requested by rakuco
5749         on #webkit).
5750
5751         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
5752         (LayoutTestController::addOriginAccessWhitelistEntry):
5753         (LayoutTestController::removeOriginAccessWhitelistEntry):
5754
5755 2012-04-25  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
5756
5757         [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
5758         https://bugs.webkit.org/show_bug.cgi?id=83880
5759
5760         Reviewed by Antonio Gomes.
5761
5762         Add missing implementation addOriginAccessWhitelistEntry and
5763         removeOriginAccessWhitelistEntry to EFL's LayoutTestController
5764         in order to unskip tests which rely on this.
5765
5766         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
5767         (LayoutTestController::addOriginAccessWhitelistEntry):
5768         (LayoutTestController::removeOriginAccessWhitelistEntry):
5769
5770 2012-04-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
5771
5772         [EFL] [DRT] Reset text zoom factor before running a test
5773         https://bugs.webkit.org/show_bug.cgi?id=84861
5774
5775         Reviewed by Antonio Gomes.
5776
5777         This fix eliminates most of the current flakiness on EFL build
5778         bots, although some CSS tests will now need rebasiling.
5779
5780         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5781         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
5782
5783 2012-04-25  Milian Wolff  <milian.wolff@kdab.com>
5784
5785         [Qt] add LayoutTestController::setPrinting support to Qt unit tests
5786         https://bugs.webkit.org/show_bug.cgi?id=84246
5787
5788         Reviewed by Simon Hausmann.
5789
5790         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
5791         (WebCore::DumpRenderTree::dump):
5792
5793 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
5794
5795         [Qt] Make the web view's url property follow the active url
5796
5797         https://bugs.webkit.org/show_bug.cgi?id=77554
5798
5799         Update  the location bar in the minibrowser to behave
5800         a bit more like normal browsers in terms of when the url will change
5801         and how active focus is handled.
5802
5803         Reviewed by Simon Hausmann.
5804
5805         * MiniBrowser/qt/qml/BrowserWindow.qml:
5806
5807 2012-04-25  Philippe Normand  <pnormand@igalia.com>
5808
5809         Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
5810         https://bugs.webkit.org/show_bug.cgi?id=81913
5811
5812         Reviewed by Tor Arne Vestbø.
5813
5814         * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
5815         and gstreamer-plugins-base >= 0.10.30 just like the GTK port
5816         does. 0.10.27 is unfortunately not recent enough to get the media
5817         player working reliably.
5818
5819
5820 2012-04-25  Xiaobo Wang  <xbwang@torchmobile.com.cn>
5821
5822         [BlackBerry] Run tests in '/http/tests/local' with local URI
5823         https://bugs.webkit.org/show_bug.cgi?id=84820
5824
5825         Reviewed by Nikolas Zimmermann.
5826
5827         Currently we run all tests under folder "/http/tests/" as HTTP
5828         tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
5829         'http/tests/local' are run with local path (like '/developer/LayoutTests
5830         /http/tests/local/absolute-url-strip-whitespace.html').
5831         With this patch we can keep the same behaviour as other portings.
5832
5833         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
5834         (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
5835
5836 2012-04-25  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
5837
5838         [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
5839         https://bugs.webkit.org/show_bug.cgi?id=84709
5840
5841         Reviewed by Eric Seidel.
5842
5843         Not all the settings that can be changed by layout testcases through a JS API were
5844         reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
5845
5846         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
5847         (defaultEditingBehavior): returns editing behavior depending on current platform.
5848         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
5849
5850 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
5851
5852         nrwt: add ASAN handling to chromium crash logs
5853         https://bugs.webkit.org/show_bug.cgi?id=84664
5854
5855         Reviewed by Ojan Vafai.
5856
5857         * Scripts/webkitpy/layout_tests/port/chromium.py:
5858         (ChromiumPort._get_crash_log):
5859
5860 2012-04-24  Dirk Pranke  <dpranke@chromium.org>
5861
5862         webkit-patch rebaseline-test is retrieving stale expectations
5863         https://bugs.webkit.org/show_bug.cgi?id=84762
5864
5865         Reviewed by Ojan Vafai.
5866
5867         webkit-patch rebaseline-expectations is fetching files directly
5868         from the layout-test-results directory on the buildbots, rather
5869         than fetching them from the archive. This is problematic because
5870         we don't clobber the directory after each run and so you can end
5871         up fetching stale failing results.
5872
5873         This change temporarily changes the code to fetch the zip file
5874         instead -- making things much slower -- until I can confer w/
5875         abarth and ojan over the best way to fix this for the long-term.
5876
5877         * Scripts/webkitpy/tool/commands/rebaseline.py:
5878         (RebaselineTest.__init__):
5879         (RebaselineTest._zip_file_set):
5880         (RebaselineTest):
5881         (RebaselineTest._fetch_baseline):
5882         (RebaselineTest._rebaseline_test):
5883         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
5884         (TestRebaseline.stub_rebaseline_test_command_and_tool):
5885         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
5886         (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
5887         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
5888         (test_rebaseline_updates_expectations_file):
5889         (test_rebaseline_test):
5890         (test_rebaseline_and_copy_test):
5891         (test_rebaseline_and_copy_test_no_existing_result):
5892         (test_rebaseline_and_copy_test_with_lion_result):
5893         (test_rebaseline_and_copy_no_overwrite_test):
5894
5895 2012-04-24  Ojan Vafai  <ojan@chromium.org>
5896
5897         Improve code for embedding flakiness dashboard as an iframe
5898         https://bugs.webkit.org/show_bug.cgi?id=84782
5899
5900         Reviewed by Dirk Pranke.
5901
5902         -Include the horizontal scrollbar height in the measured height of the page.
5903         -Post a message everytime the height changes instead of in response to a queryContentHeight message.
5904         This way, the embedder doesn't need to poll.
5905
5906         No new tests. This is hard to test because it involves postMessage and iframes.
5907         Once we switch the dashboard tests over to qunit, we should be able to write an
5908         asyncTest for this.
5909
5910         * TestResultServer/static-dashboards/flakiness_dashboard.js:
5911         (generatePage):
5912         (appendHTML):
5913         (appendExpectations):
5914         (postHeightChangedMessage):
5915         (generatePageForIndividualTests.if):
5916         (generatePageForIndividualTests):
5917         * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
5918
5919 2012-04-16  Ojan Vafai  <ojan@chromium.org>
5920
5921         Replace garden-o-matic accordion UI with a panel UI
5922         https://bugs.webkit.org/show_bug.cgi?id=84081
5923
5924         Reviewed by Dimitri Glazkov.
5925
5926         This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
5927         since we can reuse the same iframe without moving it in the DOM.
5928
5929         Also, excise unnecessary jquery-isms.
5930
5931         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
5932         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
5933         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
5934
5935 2012-04-24  Peter Beverloo  <peter@chromium.org>
5936
5937         [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
5938         https://bugs.webkit.org/show_bug.cgi?id=84729
5939
5940         Reviewed by Dirk Pranke.
5941
5942         This dependency is necessary for Android since it'll soon be
5943         calling InitAndroidOSPathStub() in it's platform support. The
5944         TestWebKitAPI and webkit_unit_tests already have this dependency.
5945
5946         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
5947
5948 2012-04-24  Ojan Vafai  <ojan@chromium.org>
5949
5950         Replace vague informative statement with the list of builders where the test isn't listed
5951         https://bugs.webkit.org/show_bug.cgi?id=84779
5952
5953         Reviewed by Dirk Pranke.
5954
5955         This is more informative and more likely to be noticed. With the old UI, people never
5956         read the line and if they did, they didn't really understand what it meant. Hopefully
5957         have the list of builders will be more clear.
5958
5959         * TestResultServer/static-dashboards/flakiness_dashboard.js:
5960         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
5961         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
5962
5963 2012-04-24  Tommy Widenflycht  <tommyw@google.com>
5964
5965         MediaStream API: Create a new flag for PeerConnection
5966         https://bugs.webkit.org/show_bug.cgi?id=84723
5967
5968         Reviewed by Dimitri Glazkov.
5969
5970         To allow Chrome to make the GetUserMedia functionality available by default we
5971         need another flag for the PeerConnection related parts. This new flag is in
5972         addition to the general media stream flag, and both need to be enabled for
5973         PeerConnection object creation.
5974
5975         * DumpRenderTree/chromium/TestShell.cpp:
5976         (TestShell::TestShell):
5977
5978 2012-04-24  Joe Mason  <jmason@rim.com>
5979
5980         [BlackBerry] Revert broken changes to authentication dialog
5981         https://bugs.webkit.org/show_bug.cgi?id=80135
5982
5983         Reviewed by Antonio Gomes.
5984
5985         The previous patches from this bug caused an infinite loop when using digest auth;
5986         apparently they were only tested with basic.
5987
5988         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
5989         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
5990         (WebCore):
5991
5992 2012-04-24  Zan Dobersek  <zandobersek@gmail.com>
5993
5994         [TestResultsServer] Add a unit test for changes in r114868
5995         https://bugs.webkit.org/show_bug.cgi?id=84713
5996
5997         Reviewed by Ojan Vafai.
5998
5999         Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
6000         that is created for either DEPS or ToT builder groups. The unit test covers changes
6001         made in r114868.
6002
6003         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
6004         (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
6005         (testBuilderGroupIsToTWebKitAttribute.assertEquals):
6006
6007 2012-04-24  Brady Eidson  <beidson@apple.com>
6008
6009         <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
6010          Need DOMWindow mechanism to supplement UserScripts for page cache notifications
6011
6012         Reviewed by Sam Weinig.
6013
6014         Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
6015
6016         It makes sure new extensions can be added at the right times, and that all of the expected
6017         callbacks are made.
6018
6019         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
6020         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
6021         (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
6022            bundle to a set of known expected messages.
6023
6024         Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
6025         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
6026         (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
6027         (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
6028         (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
6029         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
6030         (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
6031         (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
6032         (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
6033         (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
6034         (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
6035         (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
6036         (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
6037         (TestWebKitAPI::didFinishLoadForFrameCallback):
6038         (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
6039         (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
6040         (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
6041         (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
6042
6043         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
6044         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
6045
6046         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
6047
6048 2012-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
6049
6050         [GTK] Build and run TestWebKitAPI unit tests
6051         https://bugs.webkit.org/show_bug.cgi?id=84325
6052
6053         Reviewed by Philippe Normand.
6054
6055         We only build WTF unit tests for now. WebKit2 tests will be
6056         enabled in a follow up patch.
6057
6058         * Scripts/run-gtk-tests:
6059         (TestRunner): Add TestWebKitAPI/WTF to the list of directories
6060         containing unit tests.
6061         (TestRunner._run_test_glib): Run glib tests using gtester.
6062         (TestRunner._run_test_google): Run google tests.
6063         (TestRunner._run_test): Use _run_test_glib or _run_test_google
6064         depending on whether given test is glib or google test
6065         * TestWebKitAPI/GNUmakefile.am: Added.
6066         * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
6067         warning with -Wundef. Include WebKit2 headers only when building
6068         WebKit2.
6069
6070 2012-04-24  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
6071
6072         [Qt][WK2] Convert touch-point area
6073         https://bugs.webkit.org/show_bug.cgi?id=84434
6074
6075         Reviewed by Kenneth Rohde Christiansen.
6076
6077         Fix failing test after r114917 by also adding the new EventSender API
6078         to WebKitTestRunner.
6079
6080         * WebKitTestRunner/EventSenderProxy.h:
6081         (EventSenderProxy):
6082         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
6083         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
6084         (WTR::EventSendingController::setTouchPointRadius):
6085         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
6086         (EventSendingController):
6087         * WebKitTestRunner/TestController.cpp:
6088         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
6089         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
6090         (WTR::EventSenderProxy::addTouchPoint):
6091         (WTR::EventSenderProxy::updateTouchPoint):
6092         (WTR::EventSenderProxy::setTouchPointRadius):
6093         (WTR::EventSenderProxy::clearTouchPoints):
6094
6095 2012-04-24  Mikhail Naganov  <mnaganov@chromium.org>
6096
6097         [Chromium] Unreviewed test expectations update.
6098         https://bugs.webkit.org/show_bug.cgi?id=84726
6099
6100         Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
6101
6102         * Scripts/webkitpy/test/test_finder.py:
6103         (TestFinder._default_names):
6104
6105 2012-04-24  Christophe Dumez  <christophe.dumez@intel.com>
6106
6107         [EFL] Enable Web Timing
6108         https://bugs.webkit.org/show_bug.cgi?id=84705
6109
6110         Reviewed by Tony Gentilcore.
6111
6112         Enable web timing by default whenever build-webkit is used.
6113
6114         * Scripts/build-webkit:
6115
6116 2012-04-23  Eriq Augustine  <eaugusti@chromium.org>
6117
6118         Return value from executed script in Chromium.
6119         https://bugs.webkit.org/show_bug.cgi?id=79851
6120
6121         Reviewed by Adam Barth.
6122
6123         Adding a function to LayoutTestController that evaluates a script in
6124         an isolated wold an returns the result of the evaluation.
6125
6126         * DumpRenderTree/LayoutTestController.cpp:
6127         (evaluateScriptInIsolatedWorldAndReturnValue):
6128         (LayoutTestController::staticFunctions):
6129         * DumpRenderTree/LayoutTestController.h:
6130         (LayoutTestController):
6131         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
6132         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6133         * DumpRenderTree/chromium/LayoutTestController.cpp:
6134         (LayoutTestController::LayoutTestController):
6135         (LayoutTestController::setXSSAuditorEnabled):
6136         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6137         * DumpRenderTree/chromium/LayoutTestController.h:
6138         (LayoutTestController):
6139         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
6140         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6141         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
6142         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6143         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
6144         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6145         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
6146         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6147         * DumpRenderTree/qt/LayoutTestControllerQt.h:
6148         (LayoutTestController):
6149         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
6150         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6151         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
6152         (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
6153
6154 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
6155
6156         run-perf-tests fail intermittently with an exception
6157         https://bugs.webkit.org/show_bug.cgi?id=83532
6158
6159         Reviewed by Ryosuke Niwa.
6160
6161         This bulletproofs port.get_option('child_processes')
6162         against the case where the option wasn't set.
6163
6164         * Scripts/webkitpy/layout_tests/port/mac.py:
6165         (MacPort._get_crash_log):
6166         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
6167         (test_get_crash_log):
6168         (test_get_crash_log.fake_time_cb):
6169
6170 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
6171
6172         [Qt] Add desktop zooming support for QQuickWebView
6173         https://bugs.webkit.org/show_bug.cgi?id=82337
6174
6175         Unreviewed typo fix after r114900.
6176
6177         * MiniBrowser/qt/BrowserWindow.cpp:
6178         (BrowserWindow::BrowserWindow): Fix the mistyped
6179         value of a zoom level.
6180
6181 2012-04-23  Hao Zheng  <zhenghao@chromium.org>
6182
6183         [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
6184         https://bugs.webkit.org/show_bug.cgi?id=84580
6185
6186         Reviewed by Ojan Vafai.
6187
6188         Android's first fallback font is changed to DroidSansArabic.ttf in JB.
6189         Take the opportunity to get rid of the trick.
6190
6191         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
6192         (ChromiumAndroidPort.start_helper):
6193         (ChromiumAndroidPort._push_fonts):
6194
6195 2012-04-23  Dirk Pranke  <dpranke@chromium.org>
6196
6197         test-webkitpy is failing
6198         https://bugs.webkit.org/show_bug.cgi?id=84617
6199
6200         Reviewed by Eric Seidel.
6201
6202         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
6203         (HttpLockTestWithRealFileSystem.clean_all_lockfile):
6204
6205 2012-04-23  Ojan Vafai  <ojan@chromium.org>
6206
6207         Split up flakiness_dashboard.html into multiple files. This is a step in the direction
6208         of making the code more maintainable (e.g. being able to use qunit for testing).
6209
6210         * TestResultServer/static-dashboards/dashboard_base.js:
6211         * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
6212         * TestResultServer/static-dashboards/flakiness_dashboard.html:
6213         * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
6214         * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
6215         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
6216
6217 2012-04-23  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
6218
6219         [Qt][WK2] Convert touch-point area.
6220         https://bugs.webkit.org/show_bug.cgi?id=84434
6221
6222         Reviewed by Kenneth Rohde Christiansen.
6223
6224         Add feature to set touch-point radius for emitted touch-events.
6225
6226         * DumpRenderTree/qt/EventSenderQt.cpp:
6227         (EventSender::addTouchPoint):
6228         (EventSender::updateTouchPoint):
6229         (EventSender::setTouchPointRadius):
6230         (EventSender::clearTouchPoints):
6231         * DumpRenderTree/qt/EventSenderQt.h:
6232         (EventSender):
6233
6234 2012-04-23  Christophe Dumez  <christophe.dumez@intel.com>
6235
6236         [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
6237         https://bugs.webkit.org/show_bug.cgi?id=84425
6238
6239         Reviewed by Antonio Gomes.
6240
6241         Use the new helper in DumpRenderTreeSupportEfl to properly
6242         test whether an element performs autocompletion.
6243
6244         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
6245         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
6246
6247 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
6248
6249         master.cfg cleanup, remove dead codes after r92792.
6250         https://bugs.webkit.org/show_bug.cgi?id=84433
6251
6252         Relanding r114881 after typo fix in UploadBuiltProduct.
6253
6254         Reviewed by Ryosuke Niwa.
6255
6256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6257
6258 2012-04-23  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
6259
6260         [EFL][DRT] Need to support requestAnimationFrame
6261         https://bugs.webkit.org/show_bug.cgi?id=84585
6262
6263         Reviewed by Martin Robinson.
6264
6265         Making requestAnimationFrame() support a default on the EFL build.
6266
6267         * Scripts/build-webkit:
6268
6269 2012-04-23  Balazs Kelemen  <kbalazs@webkit.org>
6270
6271         [Qt] Add desktop zooming support for QQuickWebView
6272         https://bugs.webkit.org/show_bug.cgi?id=82337
6273
6274         Reviewed by Simon Hausmann.
6275
6276         Add zooming support for MiniBrowser to
6277         test the new API.
6278
6279         * MiniBrowser/qt/BrowserWindow.cpp:
6280         (BrowserWindow::BrowserWindow):
6281         (BrowserWindow::zoomIn):
6282         (BrowserWindow::zoomOut):
6283         (BrowserWindow::keyPressEvent):
6284         (BrowserWindow::wheelEvent):
6285         * MiniBrowser/qt/BrowserWindow.h:
6286         (BrowserWindow):
6287
6288 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
6289
6290         Unreviewed rolling out r114881, because it broke upload buildstep.
6291
6292         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6293         (ConfigureBuild.__init__):
6294         (ConfigureBuild.start):
6295         (CompileWebKit.start):
6296         (UploadBuiltProduct):
6297         (UploadBuiltProduct.determineExtraFeatures):
6298         (Factory.__init__):
6299         (BuildFactory.__init__):
6300         (TestFactory.__init__):
6301         (loadBuilderConfig):
6302
6303 2012-04-23  Csaba Osztrogonác  <ossy@webkit.org>
6304
6305         master.cfg cleanup, remove dead codes after r92792.
6306         https://bugs.webkit.org/show_bug.cgi?id=84433
6307
6308         Reviewed by Ryosuke Niwa.
6309
6310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6311
6312 2012-04-23  Milian Wolff  <mail@milianw.de>
6313
6314         [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
6315         https://bugs.webkit.org/show_bug.cgi?id=84327
6316
6317         Reviewed by Csaba Osztrogonác.
6318
6319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
6320         (WebCore::DumpRenderTree::dump):
6321
6322 2012-04-22  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
6323
6324         [Gtk] Added MOZ_X11 build flag for TARGET_X11
6325         https://bugs.webkit.org/show_bug.cgi?id=40785
6326
6327         Reviewed by Anders Carlsson.
6328
6329         * GNUmakefile.am:
6330
6331 2012-04-22  Zan Dobersek  <zandobersek@gmail.com>
6332
6333         [TestResultsServer] Impossible to inspect builds on non-Chromium builders
6334         https://bugs.webkit.org/show_bug.cgi?id=84544
6335
6336         Reviewed by Ryosuke Niwa.
6337
6338         Use the groupEnum parameter that is passed through to the onBuilderListLoad
6339         function rather than an undefined attribute of the BuilderGroup object. This
6340         makes it again possible to inspect builds on non-Chromium builders in the
6341         test results server by not trying to always add Chromium revision links.
6342
6343         * TestResultServer/static-dashboards/builders.js:
6344
6345 2012-04-20  Martin Robinson  <mrobinson@igalia.com>
6346
6347         [GTK] Revert changes that disabled Cairo fonts metrics hinting
6348         https://bugs.webkit.org/show_bug.cgi?id=84502
6349
6350         Reviewed by Daniel Bates.
6351
6352         Re-enable Cairo metrics hinting, which seems to ensure consistent results in
6353         reference and pixel test results. This makes our font metrics a bit different
6354         than the Mac port's, but it's a decent price to pay for consistent results.
6355
6356         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6357         (initializeGtkFontSettings):
6358         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
6359         (WTR::initializeGtkSettings):
6360
6361 2012-04-04  Jer Noble  <jer.noble@apple.com>
6362
6363         apple.com top navigation bar appears inside video during full screen exit animation
6364         https://bugs.webkit.org/show_bug.cgi?id=83095
6365
6366         Reviewed by Eric Carlson.
6367
6368         Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
6369         disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
6370         Document methods from within the script.  This allows subtle timing bugs to be consistently reproduced
6371         from within LayoutTests.
6372
6373         Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
6374         * DumpRenderTree/LayoutTestController.cpp:
6375         (setHasCustomFullScreenBehaviorCallback):
6376         (LayoutTestController::staticFunctions):
6377         * DumpRenderTree/LayoutTestController.h:
6378         (LayoutTestController::setHasCustomFullScreenBehavior):
6379         (LayoutTestController::hasCustomFullScreenBehavior):
6380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
6381         (WTR::InjectedBundlePage::enterFullScreenForElement):
6382         (WTR::InjectedBundlePage::exitFullScreenForElement):
6383         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
6384         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
6385         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
6386         (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
6387         (WTR::LayoutTestController::hasCustomFullScreenBehavior):
6388         * DumpRenderTree/chromium/LayoutTestController.cpp:
6389         (LayoutTestController::LayoutTestController):
6390         (LayoutTestController::reset):
6391         * DumpRenderTree/chromium/LayoutTestController.h:
6392         (LayoutTestController::setHasCustomFullScreenBehavior):
6393         (LayoutTestController::hasCustomFullScreenBehavior):
6394
6395         Query the new methods before calling will/did/Enter/ExitFullScreen:
6396         * DumpRenderTree/chromium/WebViewHost.cpp:
6397         (WebViewHost::enterFullScreenNow):
6398         (WebViewHost::exitFullScreenNow):
6399         * DumpRenderTree/mac/UIDelegate.mm:
6400         (-[UIDelegate webView:enterFullScreenForElement:listener:]):
6401         (-[UIDelegate webView:exitFullScreenForElement:listener:]):
6402
6403 2012-04-20  Nandor Huszka  <hnandor@inf.u-szeged.hu>
6404
6405         NRWT: option --skip-pixel-test-if-no-baseline support on DRT
6406         https://bugs.webkit.org/show_bug.cgi?id=72841
6407
6408         Reviewed by Dirk Pranke
6409
6410         This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
6411         instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
6412         and 'reference_files' fields to the TestInput objects, and use those flags
6413         to select the right driver to use in the DriverProxy.
6414
6415         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
6416         (SingleTestRunner.__init__):
6417         (SingleTestRunner._driver_input):
6418         (SingleTestRunner._run_reftest):
6419         * Scripts/webkitpy/layout_tests/controllers/worker.py:
6420         (Worker.handle_test_list):
6421         (Worker._update_test_input):
6422         * Scripts/webkitpy/layout_tests/models/test_input.py:
6423         (TestInput):
6424         (TestInput.__init__):
6425         (TestInput.__repr__):
6426         * Scripts/webkitpy/layout_tests/port/chromium.py:
6427         (ChromiumDriver._wrapper_options):
6428         (ChromiumDriver.run_test):
6429         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
6430         (ChromiumDriverTest.test_crash_log):
6431         * Scripts/webkitpy/layout_tests/port/driver.py:
6432         (DriverInput.__init__):
6433         (Driver.__init__):
6434         (DriverProxy.__init__):
6435         (DriverProxy.run_test):
6436         (DriverProxy.start):
6437         (DriverProxy.cmd_line):
6438         * Scripts/webkitpy/layout_tests/port/gtk.py:
6439         (GtkDriver._start):
6440         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
6441         (MockDRT.run):
6442         (MockDRT.input_from_line):
6443         (MockDRT.output_for_test):
6444         (MockDRT.write_test_output):
6445         (MockChromiumDRT.input_from_line):
6446         (MockChromiumDRT.output_for_test):
6447         (MockChromiumDRT.write_test_output):
6448         * Scripts/webkitpy/layout_tests/port/webkit.py:
6449         (WebKitDriver.cmd_line):
6450         (WebKitDriver.run_test):
6451         * WebKitTestRunner/TestController.cpp:
6452         (WTR::TestController::TestController):
6453         (WTR::TestController::initialize):
6454         (WTR::TestController::runTest):
6455         * WebKitTestRunner/TestController.h:
6456         (TestController):
6457         * WebKitTestRunner/TestInvocation.cpp:
6458         (WTR::TestInvocation::TestInvocation):
6459         (WTR::TestInvocation::setIsPixelTest):
6460         * WebKitTestRunner/TestInvocation.h:
6461         (TestInvocation):
6462
6463 2012-04-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
6464
6465         [EFL] Make it possible to define offline storage quota per origin
6466         https://bugs.webkit.org/show_bug.cgi?id=84170
6467
6468         Improved LayoutTestController::setDatabaseQuota to set quota based on
6469         origin which was causing some tests to fail. Also align the default
6470         quota for testing (5MB) with others ports.
6471
6472         When dumpDatabaseCallbacks is set to true by, also dump some database
6473         information when quota is exceed, which is also required by some tests.
6474
6475         Reviewed by Antonio Gomes.
6476
6477         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6478         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
6479         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
6480         (onExceededDatabaseQuota):
6481         (drtViewAdd):
6482         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
6483         (LayoutTestController::setDatabaseQuota):
6484
6485 2012-04-20  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
6486
6487         [EFL] [DRT] Send double click event from EventSender
6488         https://bugs.webkit.org/show_bug.cgi?id=82867
6489
6490         Reviewed by Daniel Bates.
6491
6492         Add support for EFL DumpRenderTree EventSender to send
6493         double click events.
6494
6495         * DumpRenderTree/efl/EventSender.cpp:
6496         (sendMouseEvent):
6497
6498 2012-04-20  Sergio Villar Senin  <svillar@igalia.com>
6499
6500         [GTK] Enable Web Timing
6501         https://bugs.webkit.org/show_bug.cgi?id=42432
6502
6503         Reviewed by Gustavo Noronha Silva.
6504
6505         Build web timing by default whenever build-webkit is used.
6506
6507         * Scripts/build-webkit:
6508
6509 2012-04-20  Kamil Blank  <k.blank@samsung.com>
6510
6511         [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
6512         https://bugs.webkit.org/show_bug.cgi?id=84430
6513
6514         Reviewed by Daniel Bates.
6515
6516         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6517         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
6518
6519 2012-04-20  Ryosuke Niwa  <rniwa@webkit.org>
6520
6521         REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
6522         https://bugs.webkit.org/show_bug.cgi?id=84424
6523
6524         Reviewed by Mark Rowe.
6525
6526         Let Windows and Chromium have their own list of files to copy.
6527
6528         * BuildSlaveSupport/built-product-archive:
6529         (removeDirectoryIfExists):
6530         (copyBuildFiles):
6531         (archiveBuiltProduct):
6532
6533 2012-04-20  Kamil Blank  <k.blank@samsung.com>
6534
6535         [EFL] Add setting API for author and user styles.
6536         https://bugs.webkit.org/show_bug.cgi?id=82860
6537
6538         Reviewed by Daniel Bates.
6539
6540         Implementation of setAuthorAndUserStylesEnabled.
6541
6542         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
6543         (LayoutTestController::setAuthorAndUserStylesEnabled):
6544
6545 2012-04-19  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
6546
6547         [EFL] Missing keycode translation for space key
6548         https://bugs.webkit.org/show_bug.cgi?id=84153
6549
6550         Reviewed by Antonio Gomes.
6551
6552         Set keyname for space key before dispatching event.
6553
6554         * DumpRenderTree/efl/EventSender.cpp:
6555         (keyNameFromJSValue):
6556
6557 2012-04-19  Carlos Garcia Campos  <cgarcia@igalia.com>
6558
6559         [GTK] Allow to use WebInspector in GtkLauncher
6560         https://bugs.webkit.org/show_bug.cgi?id=84143
6561
6562         Reviewed by Martin Robinson.
6563
6564         * GNUmakefile.am: Add new files to compilation.
6565         * GtkLauncher/LauncherInspectorWindow.c: Added.
6566         (launcherInspectorWindowFinalize):
6567         (launcher_inspector_window_init):
6568         (launcher_inspector_window_class_init):
6569         (inspectedURIChanged): Update the window title based on current
6570         inspected URI.
6571         (showInspectorWindow): Show inspector window.
6572         (closeInspectorWindow): Hide inspector window.
6573         (launcherInspectorWindowNew): Create an inspector window.
6574         (launcherInspectorWindowGetWebView): Return the inspected web view.
6575         * GtkLauncher/LauncherInspectorWindow.h: Added.
6576         * GtkLauncher/main.c:
6577         (inspectorInspectWebViewCb): Create an inspector window.
6578         (createBrowser): Connect to inspect-web-view signal of the view
6579         inspector.
6580
6581 2012-04-19  Jeremy Mao  <yujie.mao@intel.com>
6582
6583         Media Stream API: Piece of code cleanup for the chromium port
6584         https://bugs.webkit.org/show_bug.cgi?id=84328
6585
6586         Reviewed by Kent Tamura.
6587
6588         WebUserMediaClientMock use an old requestUserMedia interface and
6589         Replace it with the new interface.
6590
6591         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
6592         (WebKit::WebUserMediaClientMock::requestUserMedia):
6593         Remove the old requestUserMedia and replace it with the new.
6594         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
6595         (WebUserMediaClientMock):
6596
6597 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
6598
6599         [EFL] DRT console messages should contain only the file name part of local URIs
6600         https://bugs.webkit.org/show_bug.cgi?id=84236
6601
6602         Reviewed by Kentaro Hara.
6603
6604         Process console messages before printing them in EFL's DumpRenderTree
6605         them so that they contain only the file name part of local URIs. This
6606         is what is expected by test cases.
6607
6608         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
6609         (urlSuitableForTestResult):
6610         (onConsoleMessage):
6611
6612 2012-04-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
6613
6614         [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
6615         https://bugs.webkit.org/show_bug.cgi?id=84169
6616
6617         All databases were being created inside ~/.webkit which was causing
6618         flaky tests when running multiple tests in parallel, specially timeouts
6619         due to concurrency.
6620
6621         Reviewed by Eric Seidel.
6622
6623         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6624         (DumpRenderTreeChrome::initialize):
6625
6626 2012-04-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
6627
6628         [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
6629         https://bugs.webkit.org/show_bug.cgi?id=82484
6630
6631         Reviewed by Martin Robinson.
6632
6633         Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
6634
6635         * efl/jhbuild.modules:
6636         * gtk/jhbuild.modules:
6637
6638 2012-04-19  Lucas Forschler  <lforschler@apple.com>
6639
6640         Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
6641
6642         * BuildSlaveSupport/build.webkit.org-config/config.json:
6643
6644 2012-04-19  Christophe Dumez  <christophe.dumez@intel.com>
6645
6646         [EFL] dispatchDidCancelClientRedirect needs implementation
6647         https://bugs.webkit.org/show_bug.cgi?id=83669
6648
6649         Reviewed by Antonio Gomes.
6650
6651         Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
6652         and print out information that is expected by several test cases if
6653         LayoutTestController's dumpFrameLoadCallback() returns true.
6654
6655         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6656         (DumpRenderTreeChrome::createView):
6657         (DumpRenderTreeChrome::onFrameCreated):
6658         (DumpRenderTreeChrome::onFrameRedirectCancelled):
6659         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
6660         (DumpRenderTreeChrome):
6661
6662 2012-04-18  Hironori Bono  <hbono@chromium.org>
6663
6664         Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
6665         https://bugs.webkit.org/show_bug.cgi?id=83748
6666
6667         Reviewed by Ryosuke Niwa.
6668
6669         This change replaces a call for SpellChecker::didCheck() with one for
6670         SpellChecker::didCheckCenceled() because didCheck() has been split into
6671         didCheckSucceeded() and didCheckCanceled().
6672
6673         * DumpRenderTree/chromium/WebViewHost.cpp:
6674         (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
6675
6676 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
6677
6678         Fix failure in test-webkitpy after r114583.
6679
6680         Unreviewed, build fix.
6681
6682         Updating the call site in r114583 w/o updating the test caused
6683         the test to fail. Somehow I forgot to run the unit tests :(.
6684
6685         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
6686         (ChromiumDriverTest.test_crash_log):
6687
6688 2012-04-18  Filip Pizlo  <fpizlo@apple.com>
6689
6690         JSC testing should have complete coverage over typed array types
6691         https://bugs.webkit.org/show_bug.cgi?id=84302
6692
6693         Reviewed by Geoff Garen.
6694
6695         Made run-fast-jsc print something and a newline if jsc threw an exception or
6696         otherwise returned with an error code, but did not crash.
6697
6698         * Scripts/run-fast-jsc:
6699
6700 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
6701
6702         Fix crash in chromium.py after r114877.
6703
6704         Unreviewed, build fix.
6705
6706         Missed updating one call site for get_crash_log() :(.
6707
6708         * Scripts/webkitpy/layout_tests/port/chromium.py:
6709         (ChromiumDriver.run_test):
6710
6711 2012-04-18  Philippe Normand  <pnormand@igalia.com>
6712
6713         [GTK] NRWT bails out if more than one X server runs on the machine
6714         https://bugs.webkit.org/show_bug.cgi?id=84276
6715
6716         Reviewed by Dirk Pranke.
6717
6718         Set up GTK driver's Xvfb display number based on Xorg servers
6719         currently running.
6720
6721         * Scripts/webkitpy/layout_tests/port/gtk.py:
6722         (GtkDriver._start):
6723         (GtkDriver._start.x_filter):
6724
6725 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
6726
6727         run-webkit-tests picked up an old crash log
6728         https://bugs.webkit.org/show_bug.cgi?id=84196
6729
6730         Reviewed by Ryosuke Niwa.
6731
6732         Modify the crash log-finding code so that we can
6733         limit our search to logs newer than X - this prevents
6734         us from finding old crash logs for a given process/pid
6735         combination even when the PIDs might've wrapped.
6736
6737         Also fix a bug in filesystem_mock where files_under() would
6738         return paths that didn't exist.
6739
6740         * Scripts/webkitpy/common/system/crashlogs.py:
6741         (CrashLogs.find_newest_log):
6742         (CrashLogs._find_newest_log_darwin):
6743         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
6744         (CrashLogsTest.test_find_log_darwin):
6745         (CrashLogsTest.test_find_log_darwin.bad_read):
6746         (CrashLogsTest):
6747         * Scripts/webkitpy/common/system/filesystem_mock.py:
6748         (MockFileSystem.files_under):
6749         * Scripts/webkitpy/layout_tests/port/base.py:
6750         (Port._get_crash_log):
6751         * Scripts/webkitpy/layout_tests/port/gtk.py:
6752         (GtkPort._get_crash_log):
6753         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
6754         * Scripts/webkitpy/layout_tests/port/mac.py:
6755         (MacPort._get_crash_log):
6756         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
6757         (PortTestCase.test_get_crash_log):
6758         * Scripts/webkitpy/layout_tests/port/webkit.py:
6759         (WebKitDriver.run_test):
6760
6761 2012-04-18  Dirk Pranke  <dpranke@chromium.org>
6762
6763         nrwt: support additional test expectations files
6764         https://bugs.webkit.org/show_bug.cgi?id=84222
6765
6766         Reviewed by Ojan Vafai.
6767
6768         This patch adds an --additional-expectations flag that can be
6769         used to point to more files that will override the default set
6770         of expectations. This will allow us to remove the
6771         'google_chrome' ports and eventually help to clean up override
6772         handling in the chromium ports and unify expectations files and
6773         Skipped files; this can also be used to specify overrides for
6774         tests that run differently on a given machine.
6775
6776         * Scripts/webkitpy/layout_tests/port/base.py:
6777         (Port.test_expectations_overrides):
6778         * Scripts/webkitpy/layout_tests/port/chromium.py:
6779         (ChromiumPort.test_expectations_overrides):
6780         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6781         (parse_args):
6782         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
6783         (MainTest.test_additional_expectations):
6784
6785 2012-04-18  Jer Noble  <jer.noble@apple.com>
6786
6787         Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
6788         https://bugs.webkit.org/show_bug.cgi?id=84177
6789
6790         Reviewed by Dirk Pranke.
6791
6792         Try to delete the pid file left by Apache in the case it was killed forcefully.
6793
6794         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
6795         (LayoutTestApacheHttpd._stop_running_server):
6796
6797 2012-04-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
6798
6799         Clean-up WheelEvent Conversion.
6800         https://bugs.webkit.org/show_bug.cgi?id=84243
6801
6802         Reviewed by Simon Hausmann.
6803
6804         Calculate proper wheel-delta from pixel-delta given.
6805
6806         * DumpRenderTree/qt/EventSenderQt.cpp:
6807         (EventSender::EventSender):
6808         (EventSender::mouseScrollBy):
6809         (EventSender::continuousMouseScrollBy):
6810
6811 2012-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
6812
6813         Unreviewed, rolling out r114506.
6814         http://trac.webkit.org/changeset/114506
6815         https://bugs.webkit.org/show_bug.cgi?id=84254
6816
6817         Seems to be making gtk's DumpRenderTree crash occasionally
6818         (Requested by tomz on #webkit).
6819
6820         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6821         (resetDefaultsToConsistentValues):
6822
6823 2012-04-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
6824
6825         [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
6826         https://bugs.webkit.org/show_bug.cgi?id=84229
6827
6828         CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
6829         subsequent builds, stopping WebCore from being built ever again.
6830
6831         Instead of trying to emulate a build target using command line options,
6832         just build the existing jsc target directly.
6833
6834         Reviewed by Rob Buis.
6835
6836         * Scripts/build-jsc:
6837
6838 2012-04-18  Simon Pena  <spena@igalia.com>
6839
6840         [GTK] r114021 triggered media flakyness
6841         https://bugs.webkit.org/show_bug.cgi?id=83874
6842
6843         Reviewed by Philippe Normand.
6844
6845         Now that there is gtk API to update the
6846         MediaPlaybackRequiresUserGesture property, set it to false from the
6847         DumpRenderTree tool when resetting defaults to consistent values.
6848
6849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
6850         (resetDefaultsToConsistentValues):
6851
6852 2012-04-18  Vivek Galatage  <vivekgalatage@gmail.com>
6853
6854         Web Inspector: Disabling Inspector causes build failure on Windows
6855         https://bugs.webkit.org/show_bug.cgi?id=83557
6856
6857         Reviewed by Pavel Feldman.
6858
6859         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
6860         This change brings all such API calls under the guard.
6861
6862         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
6863         (WTR::LayoutTestController::showWebInspector):
6864         (WTR::LayoutTestController::closeWebInspector):
6865         (WTR::LayoutTestController::evaluateInWebInspector):
6866         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
6867         * WebKitTestRunner/TestInvocation.cpp:
6868         (WTR::TestInvocation::invoke):
6869
6870 2012-04-18  Mario Sanchez Prada  <msanchez@igalia.com>
6871
6872         [GTK] atk/textChangedNotifications API test fails
6873         https://bugs.webkit.org/show_bug.cgi?id=84010
6874
6875         Unreviewed, unskipping test after bug being fixed by r114311.
6876
6877         * Scripts/run-gtk-tests:
6878         (TestRunner): Unskip now passing test.
6879
6880 2012-04-17  Jacky Jiang  <zhajiang@rim.com>
6881
6882         [BlackBerry] Viewport metatag doesn't disable double-tap zoom
6883         https://bugs.webkit.org/show_bug.cgi?id=84199
6884
6885         Reviewed by George Staikos.
6886
6887         Revert a part of the change master_32/SHA:fa0f8ee9 and use
6888         WebPage::setUserScalable instead.
6889
6890         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
6891         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
6892
6893 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
6894
6895         build-webkit: make ninja work with chromium linux
6896         https://bugs.webkit.org/show_bug.cgi?id=84213
6897
6898         Reviewed by Eric Seidel.
6899
6900         Fix typos so that build-webkit will use ninja to
6901         build chromium if a build.ninja file exists and is up-to-date.
6902
6903         * Scripts/webkitdirs.pm:
6904         (determineIsChromiumNinja):
6905
6906 2012-04-17  Ojan Vafai  <ojan@chromium.org>
6907
6908         Add caching to the flakiness dashboard json files
6909         https://bugs.webkit.org/show_bug.cgi?id=84198
6910
6911         Reviewed by Dirk Pranke.
6912
6913         * TestResultServer/handlers/testfilehandler.py:
6914         (GetFile._get_file_list):
6915         (GetFile._get_file_content):
6916         (GetFile._get_file_content_from_key):
6917         (GetFile._get_test_list_json):
6918         (GetFile._serve_json):
6919         Add a Last-Modified header and handle If-Modified-Since headers.
6920         (GetFile.get):
6921
6922 2012-04-17  Anders Carlsson  <andersca@apple.com>
6923
6924         Need a client callback for when the user tries to interact with an already unresponsive page
6925         https://bugs.webkit.org/show_bug.cgi?id=84201
6926         <rdar://problem/11140862>
6927
6928         Reviewed by Andreas Kling.
6929
6930         Add new client functions.
6931
6932         * MiniBrowser/mac/BrowserWindowController.m:
6933         (-[BrowserWindowController awakeFromNib]):
6934         * WebKitTestRunner/TestController.cpp:
6935         (WTR::TestController::initialize):
6936
6937 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
6938
6939         nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
6940         https://bugs.webkit.org/show_bug.cgi?id=84190
6941
6942         Reviewed by Ojan Vafai.
6943
6944         LayoutTestHelper would exit when the user typed ctrl-c, but we
6945         would attempt to write to it to shut it down, generating an
6946         IOError.
6947
6948         * Scripts/webkitpy/layout_tests/port/chromium.py:
6949         (ChromiumPort.stop_helper):
6950
6951 2012-04-17  Dirk Pranke  <dpranke@chromium.org>
6952
6953         rename --experimental-fully-parallel
6954         https://bugs.webkit.org/show_bug.cgi?id=84188
6955
6956         Reviewed by Ojan Vafai.
6957
6958         I thought this was done long ago; rename
6959         --experimental-fully-parallel to just --fully-parallel and
6960         remove the --no- switch that AFAIK no one uses.
6961
6962         * Scripts/webkitpy/layout_tests/controllers/manager.py:
6963         (Manager._run_tests):
6964         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
6965         (parse_args):
6966
6967 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
6968
6969         EFL's LayoutTestController does not implement callShouldCloseOnWebView
6970         https://bugs.webkit.org/show_bug.cgi?id=82301
6971
6972         Reviewed by Martin Robinson.
6973
6974         Implement callShouldCloseOnWebView in EFL's LayoutTestController by
6975         calling shouldClose() on the FrameLoader, allowing the related test
6976         to be removed from the skip list.
6977
6978         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
6979         (LayoutTestController::callShouldCloseOnWebView):
6980
6981 2012-04-17  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
6982
6983         [EFL] Add setting API to enable/disable XSSAuditor
6984         https://bugs.webkit.org/show_bug.cgi?id=83281
6985
6986         Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
6987         in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
6988         'xss,detected' in DRT to enable a test, which is expecting a line containing
6989         'didDetectXSS' in the output when reflected XSS is encountered in the page.
6990
6991         Reviewed by Antonio Gomes.
6992
6993         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
6994         (DumpRenderTreeChrome::createView):
6995         (DumpRenderTreeChrome::onFrameCreated):
6996         (DumpRenderTreeChrome::onDidDetectXSS):
6997         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
6998         (DumpRenderTreeChrome):
6999         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
7000         (LayoutTestController::setXSSAuditorEnabled):
7001
7002 2012-04-17  Nandor Huszka  <hnandor@inf.u-szeged.hu>
7003
7004         [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
7005         https://bugs.webkit.org/show_bug.cgi?id=77533
7006
7007         Reviewed by Simon Hausmann.
7008
7009         Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
7010         the corresponding parameter to the buildQMakeProjects function.
7011
7012         * Scripts/build-jsc:
7013
7014 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
7015
7016         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
7017         https://bugs.webkit.org/show_bug.cgi?id=83030
7018
7019         Reviewed by Antonio Gomes.
7020
7021         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
7022         in EFL's DumpRenderTree. Make use of the new frame argument passed to
7023         the "load,started" and "load,finished" signals.
7024
7025         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
7026         (DumpRenderTreeChrome::createView):
7027         (DumpRenderTreeChrome::onLoadStarted):
7028         (DumpRenderTreeChrome::processWork):
7029         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
7030         (DumpRenderTreeChrome::onWebViewOnloadEvent):
7031         (DumpRenderTreeChrome::onInsecureContentRun):
7032         (DumpRenderTreeChrome::onInsecureContentDisplayed):
7033         (DumpRenderTreeChrome::onFrameCreated):
7034         (DumpRenderTreeChrome::onFrameProvisionalLoad):
7035         (DumpRenderTreeChrome::onFrameLoadCommitted):
7036         (DumpRenderTreeChrome::onFrameLoadFinished):
7037         (DumpRenderTreeChrome::onFrameLoadError):
7038         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
7039         (DumpRenderTreeChrome):
7040
7041 2012-04-17  Sheriff Bot  <webkit.review.bot@gmail.com>
7042
7043         Unreviewed, rolling out r114376.
7044         http://trac.webkit.org/changeset/114376
7045         https://bugs.webkit.org/show_bug.cgi?id=84155
7046
7047         Wrong patch version committed, asked by the patch author.
7048         (Requested by rakuco on #webkit).
7049
7050         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
7051         (DumpRenderTreeChrome::createView):
7052         (DumpRenderTreeChrome::processWork):
7053         (DumpRenderTreeChrome::onLoadFinished):
7054         (DumpRenderTreeChrome::onWillSendRequest):
7055         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
7056         (DumpRenderTreeChrome):
7057
7058 2012-04-17  Christophe Dumez  <christophe.dumez@intel.com>
7059
7060         [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
7061         https://bugs.webkit.org/show_bug.cgi?id=83030
7062
7063         Reviewed by Antonio Gomes.
7064
7065         Implement support for LayoutTestController's dumpFrameLoadCallbacks()
7066         in EFL's DumpRenderTree.
7067
7068         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
7069         (DumpRenderTreeChrome::createView):
7070         (DumpRenderTreeChrome::processWork):
7071         (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
7072         (DumpRenderTreeChrome::onWebViewOnloadEvent):
7073         (DumpRenderTreeChrome::onInsecureContentRun):
7074         (DumpRenderTreeChrome::onInsecureContentDisplayed):
7075         (DumpRenderTreeChrome::onFrameCreated):
7076         (DumpRenderTreeChrome::onFrameProvisionalLoad):
7077         (DumpRenderTreeChrome::onFrameLoadCommitted):
7078         (DumpRenderTreeChrome::onFrameLoadFinished):
7079         (DumpRenderTreeChrome::onFrameLoadError):
7080         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
7081         (DumpRenderTreeChrome):
7082
7083 2012-04-17  Michael Brüning  <michael.bruning@nokia.com>
7084
7085         [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
7086         https://bugs.webkit.org/show_bug.cgi?id=83035
7087
7088         Reviewed by Simon Hausmann.
7089
7090         The force_static_libs_as_shared feature for the Qt port will remove
7091         hide_symbols from Qt's CONFIG in order to make them visible to other
7092         libraries again.
7093
7094         Due to an evaluation order problem in qmake, the flags for the C++ compiler
7095         that are set by adding hide_symbols to the CONFIG variables get applied
7096         to qmake's C++ compiler flags directly and hence trying to remove these
7097         later will not work and cause build failures when using the force_static_libs_as_shared
7098         feature of the Qt port.
7099
7100         This is fixed by removing the flags that hide the exports from the compiler flags directly.
7101
7102         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
7103
7104 2012-04-16  Ryosuke Niwa  <rniwa@webkit.org>
7105
7106         Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
7107         https://bugs.webkit.org/show_bug.cgi?id=84068
7108
7109         Reviewed by Eric Seidel.
7110
7111         Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
7112         automatically creates the build directory if needed.
7113
7114         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7115         (DownloadAndPerfTestFactory.__init__):
7116         (DownloadAndPerfTestWebKit2Factory.__init__):
7117
7118 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7119
7120         [GTK] Use configure instead of autogen.sh for gtk+
7121         https://bugs.webkit.org/show_bug.cgi?id=84112
7122
7123         Rubber-stamped by Martin Robinson.
7124
7125         * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
7126         we don't want to depend on that for now, so run configure instead - we
7127         can, since we are using a tarball
7128
7129 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7130
7131         Unreviewed, rolling out r114322.
7132         http://trac.webkit.org/changeset/114322
7133         https://bugs.webkit.org/show_bug.cgi?id=84096
7134
7135         Didn't make the debug bot happy, so back out
7136
7137         * gtk/jhbuild.modules:
7138
7139 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7140
7141         [GTK] Try to fix debug bot by adding gobject-introspection to the build
7142         https://bugs.webkit.org/show_bug.cgi?id=84096
7143
7144         Unreviewed speculative build fix.
7145
7146         * gtk/jhbuild.modules: Added gobject-introspection, since modules need
7147         an up-to-date introspection m4 for running autogen.
7148
7149 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7150
7151         [GTK] Add pango to jhbuild
7152         https://bugs.webkit.org/show_bug.cgi?id=84086
7153
7154         Unreviewed build fix.
7155
7156         * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
7157         jhbuild environment. It's required for latest stable GTK+ and some
7158         systems may lack it.
7159
7160 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7161
7162         [GTK] fonts jhbuild module needs an empty clean target
7163         https://bugs.webkit.org/show_bug.cgi?id=84085
7164
7165         Rubber-stamped by Martin Robinson.
7166
7167         * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
7168         includes a phony clean target that should make warnings and errors go
7169         away.
7170
7171 2012-04-16  Gustavo Noronha Silva  <gns@gnome.org>
7172
7173         [GTK] Bump dependency on GTK+ 3.x to match reality
7174         https://bugs.webkit.org/show_bug.cgi?id=84060
7175
7176         Rubber-stamped by Martin Robinson.
7177
7178         * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
7179         to their GNOME 3.4 versions.
7180         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
7181         is applied upstream.
7182
7183 2012-04-16  Vincent Scheib  <scheib@chromium.org>
7184
7185         Adding Contributors Brian Salomon and Tom Hudson to committers.py.
7186
7187         Unreviewed.
7188
7189         * Scripts/webkitpy/common/config/committers.py:
7190
7191 2012-04-16  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
7192
7193         [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
7194         https://bugs.webkit.org/show_bug.cgi?id=84031
7195
7196         Reviewed by Rob Buis.
7197
7198         Implemented interface function didReceiveAuthenticationChallenge in class
7199         DumpRenderTree.
7200
7201         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
7202         (drtCredentialDescription):
7203         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
7204         (WebKit):
7205         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
7206         (WebCore):
7207         (DumpRenderTree):
7208
7209 2012-04-16  Philippe Normand  <pnormand@igalia.com>
7210
7211         build-webkit --gtk --no-webkit2 builds WK2
7212         https://bugs.webkit.org/show_bug.cgi?id=83977
7213
7214         Reviewed by Martin Robinson.
7215
7216         * Scripts/build-webkit: Fixup ./configure option to disable
7217         WebKit2 build.
7218
7219 2012-04-16  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
7220
7221         [EFL] [DRT] Feeding key events with invalid keyName
7222         https://bugs.webkit.org/show_bug.cgi?id=83797
7223
7224         Keep the keyName valid within scope of KeyEventInfo to avoid
7225         feeding key events with invalid keyName.
7226
7227         Reviewed by Philippe Normand.
7228
7229         * DumpRenderTree/efl/EventSender.cpp:
7230         (KeyEventInfo::KeyEventInfo):
7231         (KeyEventInfo):
7232         (keyPadNameFromJSValue):
7233         (keyNameFromJSValue):
7234         (createKeyEventInfo):
7235         (sendKeyDown):
7236
7237 2012-04-16  Andras Piroska  <pandras@inf.u-szeged.hu>
7238
7239         [Qt] Replace QtXmlPatterns usage with libxslt dependency
7240         <https://bugs.webkit.org/show_bug.cgi?id=76820>
7241
7242         Reviewed by Simon Hausmann.
7243
7244         The features.prf file was modified, in order to use libxml and libxslt by default.
7245         This modification only work at Qt5.
7246
7247         * qmake/config.tests/libxml2/libxml2.cpp: Added.
7248         (main):
7249         * qmake/config.tests/libxml2/libxml2.pro: Added.
7250         * qmake/config.tests/libxslt/libxslt.cpp: Added.
7251         (main):
7252         * qmake/config.tests/libxslt/libxslt.pro: Added.
7253         * qmake/mkspecs/features/features.prf:
7254         * qmake/sync.profile:
7255
7256 2012-04-16  Seokju Kwon  <seokju.kwon@samsung.com>
7257
7258         [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
7259         https://bugs.webkit.org/show_bug.cgi?id=83862
7260
7261         Reviewed by Kenneth Rohde Christiansen.
7262
7263         EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
7264         It doesn't work properly because of wrong parameter order in function call.
7265
7266         * EWebLauncher/main.c:
7267
7268 2012-04-16  Philippe Normand  <pnormand@igalia.com>
7269
7270         Unreviewed, GTK gardening.
7271
7272         * Scripts/run-gtk-tests:
7273         (TestRunner): Skip /webkit/atk/textChangedNotifications.
7274
7275 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
7276
7277         Chromium perf bots should not build
7278         https://bugs.webkit.org/show_bug.cgi?id=83641
7279
7280         Reviewed by Eric Seidel.
7281
7282         Don't build on perf bots to improve the cycle time.
7283
7284         * BuildSlaveSupport/build.webkit.org-config/config.json:
7285
7286 2012-04-14  Zalan Bujtas  <zbujtas@gmail.com>
7287
7288         [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
7289         https://bugs.webkit.org/show_bug.cgi?id=81945
7290
7291         Reviewed by Dan Bernstein.
7292
7293         WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
7294         the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
7295         PageCache to be functional.
7296
7297         * WebKitTestRunner/TestController.cpp:
7298         (WTR::TestController::resetStateToConsistentValues):
7299
7300 2012-04-11  James Robinson  <jamesr@chromium.org>
7301
7302         [chromium] Remove unused compositeToTexture / compositeOffscreen setting
7303         https://bugs.webkit.org/show_bug.cgi?id=83733
7304
7305         Reviewed by Adrienne Walker.
7306
7307         Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
7308
7309         * DumpRenderTree/chromium/DumpRenderTree.cpp:
7310         (main):
7311         * DumpRenderTree/chromium/TestShell.cpp:
7312         (TestShell::TestShell):
7313         (TestShell::resetWebSettings):
7314         * DumpRenderTree/chromium/TestShell.h:
7315         (TestShell):
7316         * DumpRenderTree/chromium/WebPreferences.cpp:
7317         (WebPreferences::reset):
7318         (WebPreferences::applyTo):
7319         * DumpRenderTree/chromium/WebPreferences.h:
7320         (WebPreferences):
7321
7322 2012-04-13  Ryosuke Niwa  <rniwa@webkit.org>
7323
7324         webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
7325         and also rebaseline the test results since we ignore the first run now.
7326
7327         * Scripts/webkitpy/performance_tests/perftest.py:
7328         (PageLoadingPerfTest.run):
7329         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
7330         (TestPageLoadingPerfTest.test_run):
7331
7332 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
7333
7334         Enable SVG page loading performance tests
7335         https://bugs.webkit.org/show_bug.cgi?id=83861
7336
7337         Reviewed by Adam Barth.
7338
7339         Add support for page loading tests. These are tests without any test running harnesses, and we use
7340         DriverOutput's test_timeout to measure the loading time.
7341
7342         Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
7343
7344         * Scripts/webkitpy/performance_tests/perftest.py:
7345         (PerfTest.run):
7346         (PerfTest):
7347         (PerfTest.run_failed):
7348         (PerfTest.parse_output):
7349         (PerfTest.output_statistics):
7350         (ChromiumStylePerfTest.parse_output):
7351         (PageLoadingPerfTest): Added.
7352         (PageLoadingPerfTest.__init__):
7353         (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
7354         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
7355         (MockPrinter):
7356         (MockPrinter.__init__):
7357         (MockPrinter.write):
7358         (MainTest):
7359         (MainTest.test_parse_output):
7360         (MainTest.test_parse_output_with_failing_line):
7361         (TestPageLoadingPerfTest):
7362         (TestPageLoadingPerfTest.assertWritten):
7363         (TestPageLoadingPerfTest.MockDriver):
7364         (TestPageLoadingPerfTest.MockDriver.__init__):
7365         (TestPageLoadingPerfTest.MockDriver.run_test):
7366         (TestPageLoadingPerfTest.test_run):
7367         (TestPageLoadingPerfTest.test_run_with_bad_output):
7368         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
7369         (PerfTestsRunner):
7370         (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
7371         (PerfTestsRunner._collect_tests):
7372         (PerfTestsRunner._run_tests_set):
7373         (PerfTestsRunner._run_single_test):
7374         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
7375         (test_collect_tests_with_page_load_svg):
7376         (test_collect_tests_with_page_load_svg.add_file):
7377
7378 2012-04-10  Brady Eidson  <beidson@apple.com>
7379
7380         <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
7381         Need WebKit2 API to notify whether history loads are in the page cache
7382
7383         Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
7384         callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
7385
7386         Reviewed by Darin Adler.
7387
7388         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
7389         (TestWebKitAPI::didFinishLoadForFrame):
7390         (TestWebKitAPI::willGoToBackForwardListItem):
7391         (TestWebKitAPI::setPageLoaderClient):
7392         (TestWebKitAPI::TEST):
7393         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
7394         (ShouldGoToBackForwardListItemTest):
7395         (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
7396         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
7397         (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
7398         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
7399
7400         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
7401         (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
7402
7403 2012-04-13  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
7404
7405         Group EFL bots into a category on the buildbot master
7406         https://bugs.webkit.org/show_bug.cgi?id=82712
7407
7408         Reviewed by Adam Roben.
7409
7410         Creating a new category definition on the buildbot frontend.
7411
7412         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
7413         (loadBuilderConfig): Determine category for EFL bots
7414         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
7415
7416 2012-04-13  Sheriff Bot  <webkit.review.bot@gmail.com>
7417
7418         Unreviewed, rolling out r113714.
7419         http://trac.webkit.org/changeset/113714
7420         https://bugs.webkit.org/show_bug.cgi?id=83887
7421
7422         It is behaving strange on the bots and needs more
7423         investigation. (Requested by jeez_ on #webkit).
7424
7425         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
7426         (WTR::PlatformWebView::PlatformWebView):
7427
7428 2012-04-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
7429
7430         webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
7431         https://bugs.webkit.org/show_bug.cgi?id=83690
7432
7433         Reviewed by Tor Arne Vestbø.
7434
7435         Typing part of an email and pressing <TAB> will bash-complete it using the list in
7436         Tools/Scripts/webkitpy/common/config/committers.py
7437
7438         * Scripts/webkit-tools-completion.sh:
7439
7440 2012-04-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
7441
7442         [EFL] Add API for color chooser
7443         https://bugs.webkit.org/show_bug.cgi?id=83692
7444
7445         Enables INPUT_TYPE_COLOR by default on the EFL port.
7446
7447         Reviewed by Kenneth Rohde Christiansen.
7448
7449         * Scripts/build-webkit:
7450
7451 2012-04-12  Ryosuke Niwa  <rniwa@webkit.org>
7452
7453         Extract PerfTest class from PerfTestRunner
7454         https://bugs.webkit.org/show_bug.cgi?id=83847
7455
7456         Reviewed by Hajime Morita.
7457
7458         Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
7459         that was previously represented by a tuple.
7460
7461         Also moved the logic to determine whether a given test is chromium style or not from run() to
7462         _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
7463         tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
7464         add new types of tests more easily.
7465
7466         * Scripts/webkitpy/performance_tests/perftest.py: Added.
7467         (PerfTest):
7468         (PerfTest.__init__):
7469         (PerfTest.test_name):
7470         (PerfTest.dirname):
7471         (PerfTest.path_or_url):
7472         (PerfTest._should_ignore_line_in_parser_test_result):
7473         (PerfTest.parse_output):
7474         (ChromiumStylePerfTest):
7475         (ChromiumStylePerfTest.__init__):
7476         (ChromiumStylePerfTest.parse_output):
7477         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
7478         (PerfTestsRunner._collect_tests):
7479         (PerfTestsRunner.run):
7480         (PerfTestsRunner._run_tests_set):
7481         (PerfTestsRunner._run_single_test):
7482         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
7483         (run_test):
7484         (_tests_for_runner):
7485         (test_run_test_set_with_json_output):
7486         (test_run_test_set_with_json_source):
7487         (test_run_test_set_with_multiple_repositories):
7488         (_collect_tests_and_sort_test_name):
7489         (test_collect_tests):
7490         (test_collect_tests_with_skipped_list):
7491
7492 2012-04-12  Balazs Kelemen  <kbalazs@webkit.org>
7493
7494         [Qt] Fix WebKit1 build with V8
7495         https://bugs.webkit.org/show_bug.cgi?id=83322
7496
7497         Reviewed by Adam Barth.
7498
7499         * DumpRenderTree/qt/DumpRenderTree.pro:
7500         * qmake/mkspecs/features/default_post.prf:
7501         * qmake/mkspecs/features/default_pre.prf:
7502         * qmake/mkspecs/features/features.prf:
7503
7504 2012-04-12  Dirk Pranke  <dpranke@chromium.org>
7505
7506         test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
7507         https://bugs.webkit.org/show_bug.cgi?id=83583
7508
7509         Reviewed by Philippe Normand
7510
7511         Updated the unit test to ignore the hours and minutes of the
7512         localtime for time(0), since we can't easily guarantee which
7513         timezone we're in or what timezone rules were in effect on
7514         1/1/1970; this should be mostly fine since we can trust that
7515         time.localtime() will work, although there is the possibility
7516         that we'll screw up the time formatting of which field is the
7517         hours and which is the minutes.
7518
7519         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
7520         (VerboseTest):
7521         (VerboseTest.test_basic):
7522         (VerboseTest.test_log_after_update):
7523
7524 2012-04-12  Dominik Rottsches  <dominik.rottsches@linux.intel.com>
7525
7526         Add an EFL Debug Buildbot to the master configuration
7527         https://bugs.webkit.org/show_bug.cgi?id=82711
7528
7529         Forgot to add EFL Linux Debug to scheduler.
7530
7531         Reviewed by Philippe Normand.
7532
7533         * BuildSlaveSupport/build.webkit.org-config/config.json:
7534
7535 2012-04-12  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
7536
7537         Add an EFL Debug Buildbot to the master configuration
7538         https://bugs.webkit.org/show_bug.cgi?id=82711
7539
7540         Reviewed by Philippe Normand.
7541
7542         Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
7543
7544         * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
7545
7546 2012-04-12  George Staikos  <staikos@webkit.org>
7547
7548         Enable the fullscreen API for BlackBerry.
7549         https://bugs.webkit.org/show_bug.cgi?id=83757
7550
7551         Reviewed by Antonio Gomes.
7552
7553         * Scripts/build-webkit:
7554
7555 2012-04-12  Simon Pena  <spena@igalia.com>
7556
7557         [GTK] Test runner crashes without recent versions of pulseaudio-utils
7558         https://bugs.webkit.org/show_bug.cgi?id=83774
7559
7560         Reviewed by Philippe Normand.
7561
7562         Besides checking that pactl is available, check also that its output
7563         is the expected one, and handle gracefully when it isn't, when
7564         trying to unload pulseaudio modules.
7565
7566         * Scripts/webkitpy/layout_tests/port/gtk.py:
7567         (GtkPort._unload_pulseaudio_module):
7568         (GtkPort._restore_pulseaudio_module):
7569
7570 2012-03-05  Pierre Rossi  <pierre.rossi@gmail.com>
7571
7572         [Qt] Use QRawFont when building with Qt 5
7573         https://bugs.webkit.org/show_bug.cgi?id=78001
7574
7575         Flip the QRawFont switch for Qt 5.
7576
7577         Reviewed by Simon Hausmann.
7578
7579         * qmake/mkspecs/features/features.prf:
7580
7581 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
7582
7583         Web Inspector: Disabling Inspector causes build failure on Windows
7584         https://bugs.webkit.org/show_bug.cgi?id=83557
7585
7586         Reviewed by Pavel Feldman.
7587
7588         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
7589         This change brings all such API calls under the guard.
7590
7591         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
7592         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
7593         (WTR):
7594         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7595         (LayoutTestController):
7596         * WebKitTestRunner/TestInvocation.cpp:
7597         (WTR::TestInvocation::invoke):
7598
7599 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
7600
7601         Fix regression introduced in r113927.
7602
7603         Unreviewed, build fix.
7604
7605         I failed to rename skipped_tests() to skipped_layout_tests()
7606         everywhere it needed to be renamed. The unit tests didn't catch
7607         this because the TestPort was one of the places that didn't get
7608         renamed :(.
7609
7610         * Scripts/webkitpy/layout_tests/controllers/manager.py:
7611         (Manager.parse_expectations):
7612         * Scripts/webkitpy/layout_tests/port/test.py:
7613         (TestPort.skipped_layout_tests):
7614         * Scripts/webkitpy/tool/commands/queries.py:
7615         (PrintExpectations._model):
7616
7617 2012-04-11  Dirk Pranke  <dpranke@chromium.org>
7618
7619         new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
7620         https://bugs.webkit.org/show_bug.cgi?id=47528
7621
7622         Reviewed by Adam Barth.
7623
7624         The skipped-ports command has been replaced by 'webkit-patch
7625         print-expectations', which offers the equivalent functionality
7626         via 'webkit-patch print-expectations --platform \* -t skip'
7627         (and other features, of course).
7628
7629         This also allows me to fix a nasty layering violation where the
7630         chromium port had to know about the TestExpectations objects in
7631         order to implement the command properly.
7632
7633         Lastly, this allows me to rename skipped_tests() to
7634         skipped_layout_tests() to more consistent with
7635         skipped_perf_tests().
7636
7637         This patch removes skips_layout_test() from the Port interface,
7638         because that can't be implemented without the port knowing about
7639         Expectations objects (and skipped-ports was the only thing using it).
7640
7641         * Scripts/webkitpy/layout_tests/port/base.py:
7642         (Port.skipped_layout_tests):
7643         (Port.skipped_perf_tests):
7644         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
7645         (PortTest.test_default_configuration_notfound):
7646         * Scripts/webkitpy/layout_tests/port/chromium.py:
7647         (ChromiumPort.test_expectations_overrides):
7648         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
7649         (ChromiumPortTest.test_path_to_image_diff):
7650         * Scripts/webkitpy/layout_tests/port/webkit.py:
7651         (WebKitPort.skipped_layout_tests):
7652         * Scripts/webkitpy/tool/commands/queries.py:
7653         (execute):
7654         * Scripts/webkitpy/tool/commands/queries_unittest.py:
7655         (QueryCommandsTest.test_tree_status):
7656
7657 2012-04-11  Mark Rowe  <mrowe@apple.com>
7658
7659         Remove a fprintf from LayoutTestController.
7660
7661         This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
7662         It was added for no apparent reason by Ryosuke in r113651.
7663
7664         * DumpRenderTree/LayoutTestController.cpp:
7665         (LayoutTestController::redirectionDestinationForURL):
7666
7667 2012-04-11  Nico Weber  <thakis@chromium.org>
7668
7669         [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
7670         https://bugs.webkit.org/show_bug.cgi?id=83709
7671
7672         Reviewed by Anders Carlsson.
7673
7674         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
7675         (handleEventCarbon):
7676
7677 2012-04-11  Rafael Brandao  <rafael.lobo@openbossa.org>
7678
7679         Adding myself to committers.py
7680         https://bugs.webkit.org/show_bug.cgi?id=83711
7681
7682         Unreviewed update to committers.py.
7683
7684         * Scripts/webkitpy/common/config/committers.py:
7685
7686 2012-04-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
7687
7688         [EFL] LayoutTestController needs implementation of pageProperty
7689         https://bugs.webkit.org/show_bug.cgi?id=82449
7690
7691         Add missing implementation pageProperty to EFL's LayoutTestController
7692         in order to unskip printing/page-rule-selection.html
7693
7694         Reviewed by Antonio Gomes.
7695
7696         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
7697         (LayoutTestController::pageProperty):
7698
7699 2012-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
7700
7701         Unreviewed, rolling out r113836.
7702         http://trac.webkit.org/changeset/113836
7703         https://bugs.webkit.org/show_bug.cgi?id=83705
7704
7705         Broke all the WebKit2 inspector tests (Requested by andersca
7706         on #webkit).
7707
7708         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
7709         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
7710         (WTR::LayoutTestController::showWebInspector):
7711         (WTR::LayoutTestController::closeWebInspector):
7712         (WTR::LayoutTestController::evaluateInWebInspector):
7713         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
7714         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7715         (LayoutTestController):
7716         * WebKitTestRunner/TestInvocation.cpp:
7717         (WTR::TestInvocation::invoke):
7718
7719 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
7720
7721         Web Inspector: Disabling Inspector causes build failure on Windows
7722         https://bugs.webkit.org/show_bug.cgi?id=83557
7723
7724         Reviewed by Pavel Feldman.
7725
7726         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
7727         This change brings all such API calls under the guard.
7728
7729         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
7730         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
7731         (WTR):
7732         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7733         (LayoutTestController):
7734         * WebKitTestRunner/TestInvocation.cpp:
7735         (WTR::TestInvocation::invoke):
7736
7737 2012-04-11  No'am Rosenthal  <noam.rosenthal@nokia.com>
7738
7739         [Qt][WK2] Manage graphics buffers in the web process
7740         https://bugs.webkit.org/show_bug.cgi?id=78675
7741
7742         Make graphics surface available only for Qt 5, attempting to fix
7743         the Qt-mac build.
7744
7745         Unreviewed build fix.
7746
7747         * qmake/mkspecs/features/features.prf:
7748
7749 2012-04-11  Philippe Normand  <pnormand@igalia.com>
7750
7751         Unreviewed, GTK NRWT follow-up fix after r113849.
7752
7753         * Scripts/webkitpy/layout_tests/port/gtk.py:
7754         (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
7755
7756 2012-04-11  Simon Pena  <spena@igalia.com>
7757
7758         [GTK] media/event-attributes.html fails
7759         https://bugs.webkit.org/show_bug.cgi?id=71662
7760
7761         Reviewed by Philippe Normand.
7762
7763         PulseAudio's module "module-stream-restore" allows saving the volume
7764         of a stream, restoring it the next time it runs.
7765         This affects the tests, since DumpRenderTree's volume settings are
7766         saved between test runs, and tests relying on specific volume values
7767         would miss some volumeChange events (or get additional ones).
7768
7769         This patch hooks on the existing GtkPort setup_test_run method and
7770         creates a new clean_up_test_run method, so PulseAudio's module is
7771         unloaded (if found) before running the tests, and restored (if it
7772         was there previously) after they finished, ensuring the tests run in
7773         the right environment.
7774
7775         * Scripts/webkitpy/layout_tests/controllers/manager.py:
7776         (Manager._clean_up_run): Invoke the port implementation of
7777         clean_up_test_run.
7778         * Scripts/webkitpy/layout_tests/port/base.py:
7779         (Port.clean_up_test_run): Add an empty implementation of
7780         clean_up_test_run.
7781         * Scripts/webkitpy/layout_tests/port/gtk.py:
7782         (GtkPort._unload_pulseaudio_module): Unloads the offending
7783         pulseaudio module, if found.
7784         (GtkPort):
7785         (GtkPort._restore_pulseaudio_module): Restores the offending
7786         pulseaudio module, if it was there previously.
7787         (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
7788         (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
7789
7790 2012-04-11  Andras Becsi  <andras.becsi@nokia.com>
7791
7792         Fix the build with gcc 4.7.0
7793         https://bugs.webkit.org/show_bug.cgi?id=83584
7794
7795         Reviewed by Alexey Proskuryakov.
7796
7797         * qmake/mkspecs/features/unix/default_post.prf:
7798         The -fuse-ld=gold option is not supported with upstream gcc.
7799
7800 2012-04-11  Ryosuke Niwa  <rniwa@webkit.org>
7801
7802         Refactor PerfTestRunner to include file extensions in test names
7803         https://bugs.webkit.org/show_bug.cgi?id=83677
7804
7805         Reviewed by Hajime Morita.
7806
7807         Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
7808
7809         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
7810         (PerfTestsRunner._collect_tests):
7811         (PerfTestsRunner._run_tests_set):
7812         (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
7813         We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
7814         (PerfTestsRunner._run_single_test):
7815         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
7816         (run_test):
7817         (_tests_for_runner):
7818         (test_run_test_set):
7819         (test_run_test_set_kills_drt_per_run):
7820         (test_run_test_pause_before_testing):
7821         (test_run_test_set_for_parser_tests):
7822         (test_collect_tests):
7823         (test_collect_tests_with_skipped_list):
7824
7825 2012-04-11  Vivek Galatage  <vivekgalatage@gmail.com>
7826
7827         Web Inspector: Disabling Inspector causes build failure on Windows
7828         https://bugs.webkit.org/show_bug.cgi?id=83557
7829
7830         Reviewed by Pavel Feldman.
7831
7832         The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
7833         This change brings all such API calls under the guard.
7834
7835         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
7836         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
7837         (WTR):
7838         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
7839         (LayoutTestController):
7840         * WebKitTestRunner/TestInvocation.cpp:
7841         (WTR::TestInvocation::invoke):
7842
7843 2012-04-10  Kent Tamura  <tkent@chromium.org>
7844
7845         Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
7846
7847         * Scripts/webkitpy/common/config/watchlist:
7848         * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
7849
7850 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
7851
7852         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
7853         https://bugs.webkit.org/show_bug.cgi?id=82799
7854
7855         Reviewed by Ojan Vafai.
7856
7857         The tests we were skipping in _mark_interrupted_tests_as_skipped
7858         had incorrectly-constructed TestResults, and so they were not
7859         being treated as failures. The JSON generator doesn't record
7860         tests that are passed or skiped in incremental_results, so you
7861         couldn't tell these tests were being skipped at all.
7862
7863         This change changes _mark_interrupted_tests_as_skipped() to
7864         treat the skipped tests as failures; this is arguably still
7865         incorrect but is minimally invasive for now. We probably need to
7866         revisit how we are uploading information about tests that are
7867         skipped and passed altogether in a separate change.
7868
7869         This change also cleans up a couple of other nits that were
7870         unnecessary or broken in this same code path.
7871
7872         * Scripts/webkitpy/layout_tests/controllers/manager.py:
7873         (Manager._mark_interrupted_tests_as_skipped):
7874         (Manager._upload_json_files): Deletes the check for
7875         chromium-mac-leopard (as it is no longer necessary).
7876         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
7877         (JSONLayoutResultsGenerator.__init__): Here we were
7878         recalculating the failure type unnecessarily.
7879         * Scripts/webkitpy/layout_tests/models/test_failures.py:
7880         (determine_result_type):
7881         (FailureEarlyExit): Adds a new failure type so we can tell what
7882         happened.
7883         (FailureEarlyExit.message):
7884         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
7885         (MainTest.test_exit_after_n_failures_upload): Add more checks to
7886         ensure that we are recording the SKIP correctly; this is less
7887         than ideal, because we can't actually test the contents of
7888         incremental_results.json. We should fix that at some point.
7889
7890 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
7891
7892         make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
7893         https://bugs.webkit.org/show_bug.cgi?id=83401
7894
7895         Reviewed by Adam Barth.
7896
7897         Last patch in the series - no longer look in mac-leopard,
7898         mac-snowleopard, or mac-lion.
7899
7900         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
7901         (ChromiumMacPort):
7902         * TestResultServer/static-dashboards/flakiness_dashboard.html:
7903
7904 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
7905
7906         webkit-patch: add a print-expectations command
7907         https://bugs.webkit.org/show_bug.cgi?id=83347
7908
7909         Reviewed by Adam Barth.
7910
7911         This command will print the expected results for a given set of
7912         tests on a given set of ports matching a given set of keywords.
7913
7914         Example output (printing all the tests not expected to pass, and their
7915         expected results, on a Mac):
7916
7917         $ webkit-patch print-expectations -x pass fast/html
7918         // For mac-snowleopard
7919         fast/html/details-open4.html = TEXT
7920         fast/html/details-open2.html = TEXT
7921         fast/html/details-no-summary4.html = TEXT
7922         fast/html/details-open-javascript.html = TEXT
7923         $
7924
7925         You can also print full test-expectatons.txt lines using --full and a
7926         CSV-style report (which can be useful for post-processing) using --csv.
7927
7928         It will replace the 'skipped-files' command (which will be
7929         removed in a subsequent patch) and is a more general (and
7930         cleaner and properly layered) solution.
7931
7932         Also add an update() command to MockOptions() to make overriding keywords easier.
7933
7934         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
7935         (TestExpectationSerializer.to_string):
7936         (TestExpectationSerializer):
7937         (TestExpectationSerializer.to_csv):
7938         (TestExpectationSerializer._format_result):
7939         (TestExpectationLine.create_passing_expectation):
7940         (TestExpectationsModel.get_test_set_for_keyword):
7941         (TestExpectationsModel.has_keyword):
7942         (TestExpectations.model):
7943         * Scripts/webkitpy/tool/commands/queries.py:
7944         (execute):
7945         (PrintExpectations):
7946         (PrintExpectations.__init__):
7947         (PrintExpectations.execute):
7948         (PrintExpectations._filter_tests):
7949         (PrintExpectations._format_lines):
7950         (PrintExpectations._model):
7951         * Scripts/webkitpy/tool/commands/queries_unittest.py:
7952         (TestPrintExpectations): Added.
7953         * Scripts/webkitpy/tool/mocktool.py:
7954         (MockOptions):
7955         (MockOptions.__init__):
7956         (MockOptions.update): Added.
7957
7958 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
7959
7960         webkitpy: refactor handling of --platform and related options
7961         https://bugs.webkit.org/show_bug.cgi?id=83525
7962
7963         Reviewed by Adam Barth.
7964
7965         This change moves to centralize handling of --platform, --debug,
7966         --gtk, and other similar flags into a central place next to the
7967         code that actually uses those flags in PortFactory to get the
7968         right Port object.
7969
7970         * Scripts/webkitpy/layout_tests/port/__init__.py:
7971         * Scripts/webkitpy/layout_tests/port/factory.py:
7972         (port_options):
7973         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
7974         (parse_args):
7975         * Scripts/webkitpy/tool/commands/queries.py:
7976         (PrintBaselines.__init__):
7977
7978 2012-04-10  Ojan Vafai  <ojan@chromium.org>
7979
7980         Add a chromeless view to the individual tests view
7981         https://bugs.webkit.org/show_bug.cgi?id=83541
7982
7983         Reviewed by Daniel Bates.
7984
7985         This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
7986
7987         * TestResultServer/static-dashboards/flakiness_dashboard.html:
7988         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
7989         (testHtmlForIndividualTestOnAllBuilders):
7990         (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
7991         (testHtmlForIndividualTestOnAllBuildersWithChrome):
7992         (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
7993         (testHtmlForIndividualTests):
7994         (htmlEscape):
7995         (runTests):
7996
7997 2012-04-10  Dirk Pranke  <dpranke@chromium.org>
7998
7999         remove 'win' from chromium-win, chromium-linux fallback paths
8000         https://bugs.webkit.org/show_bug.cgi?id=83613
8001
8002         Reviewed by Ojan Vafai.
8003
8004         The chromium ports no longer need to look at the apple 'win'
8005         directory for baseline results.
8006
8007         Also remove the old '-gpu-' entries from the flakiness dashboard
8008         map since I'm touching lines nearby.
8009
8010         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
8011         (ChromiumLinuxPort):
8012         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
8013         (ChromiumWinPort):
8014         * TestResultServer/static-dashboards/flakiness_dashboard.html:
8015
8016 2012-04-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
8017
8018         [Qt][WK2] Manage graphics buffers in the web process
8019         https://bugs.webkit.org/show_bug.cgi?id=78675
8020
8021         Enable graphics surfaces on Mac for Qt.
8022
8023         Reviewed by Kenneth Rohde Christiansen.
8024
8025         * qmake/mkspecs/features/features.prf:
8026
8027 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
8028
8029         [CMake] Enable USE_FOLDERS property
8030         https://bugs.webkit.org/show_bug.cgi?id=83571
8031
8032         Reviewed by Daniel Bates.
8033
8034         Setting the FOLDER property on targets gives more structure
8035         to the generated Visual Studio solutions.
8036         This does not affect other CMake generators.
8037
8038         * DumpRenderTree/efl/CMakeLists.txt:
8039         * EWebLauncher/CMakeLists.txt:
8040         * WinCELauncher/CMakeLists.txt:
8041
8042 2012-04-10  David Dorwin  <ddorwin@chromium.org>
8043
8044         Add Encrypted Media Extensions methods to HTMLMediaElement
8045         https://bugs.webkit.org/show_bug.cgi?id=82971
8046
8047         Reviewed by Adam Barth.
8048
8049         The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
8050         Implementation is based on v0.1 of the draft proposal at
8051         http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
8052
8053         * DumpRenderTree/chromium/TestShell.cpp:
8054         (TestShell::TestShell):
8055
8056 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
8057
8058         [EFL][DRT] Catch the "title,changed" signal
8059         https://bugs.webkit.org/show_bug.cgi?id=82174
8060
8061         Reviewed by Gustavo Noronha Silva.
8062
8063         EFL's DumpRenderTree now catches the "title,changed" signal, and
8064         prints out the needed information.
8065
8066         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
8067         (DumpRenderTreeChrome::onTitleChanged):
8068
8069 2012-04-10  Christophe Dumez  <christophe.dumez@intel.com>
8070
8071         [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
8072         https://bugs.webkit.org/show_bug.cgi?id=82443
8073
8074         Reviewed by Philippe Normand.
8075
8076         EFL's DRT needs to support LayoutTestController's
8077         willSendRequestReturnsNull() and return NULL when expected. This
8078         allows for several tests to be removed from the skip list.
8079
8080         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
8081         (DumpRenderTreeChrome::onWillSendRequest):
8082
8083 2012-04-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
8084
8085         [EFL] LayoutTestController needs implementation of addUserStyleSheet
8086         https://bugs.webkit.org/show_bug.cgi?id=82446
8087
8088         Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
8089         so that we can unskip related tests from the skip list.
8090
8091         Reviewed by Antonio Gomes.
8092
8093         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
8094         (LayoutTestController::addUserStyleSheet): Implemented.
8095
8096 2012-04-10  Philip Rogers  <pdr@google.com>
8097
8098         Adding myself to committers.py!
8099
8100         Unreviewed update to committers.py.
8101
8102         * Scripts/webkitpy/common/config/committers.py:
8103
8104 2012-04-10  Dinu Jacob  <dinu.jacob@nokia.com>
8105
8106         [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
8107         https://bugs.webkit.org/show_bug.cgi?id=82483
8108
8109         Reviewed by Kenneth Rohde Christiansen.
8110
8111         Set window title to default if there is no page title.
8112
8113         * MiniBrowser/qt/BrowserWindow.cpp:
8114         (BrowserWindow::BrowserWindow):
8115         (BrowserWindow::onTitleChanged):
8116         * MiniBrowser/qt/BrowserWindow.h:
8117         (BrowserWindow):
8118
8119 2012-03-23  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
8120
8121         [Qt][WK2] Implement PageClient::isViewWindowActive()
8122         https://bugs.webkit.org/show_bug.cgi?id=81143
8123
8124         Reviewed by Kenneth Rohde Christiansen.
8125
8126         Fix the WrapperWindow from our PlatformWebView
8127         so it correctly creates the platform related
8128         stuff for QWindow, which is not created unless
8129         QWindow::setVisible() or QWindow::show() are called.
8130
8131         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
8132         (WTR::PlatformWebView::PlatformWebView):
8133
8134 2012-04-10  Balazs Kelemen  <kbalazs@webkit.org>
8135
8136         [Qt][WK2] TestNetscapePlugin is broken
8137         https://bugs.webkit.org/show_bug.cgi?id=83024
8138
8139         Reviewed by Csaba Osztrogonác.
8140
8141         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
8142         Fix X11 availability check. embedded is always true with QPA.
8143         * Tools.pro:
8144         Build the test plugin if plugins are enabled for WebKit2.
8145         * qmake/mkspecs/features/features.prf:
8146         * qmake/mkspecs/features/functions.prf:
8147         Added a convenience function to determine availability
8148         of X11 libraries.
8149
8150 2012-04-10  Patrick Gansterer  <paroga@webkit.org>
8151
8152         [WIN] Fix build without precompiled header.
8153
8154         * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
8155
8156 2012-04-10  Arko Saha  <arko@motorola.com>
8157
8158         Unreviewed: adding myself to committers.py.
8159
8160         * Scripts/webkitpy/common/config/committers.py:
8161
8162 2012-04-09  Kaustubh Atrawalkar  <kaustubh@motorola.com>
8163
8164         Unreviewed: adding myself to committers.py.
8165
8166         * Scripts/webkitpy/common/config/committers.py:
8167
8168 2012-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
8169
8170         Unreviewed, rolling out r113656.
8171         http://trac.webkit.org/changeset/113656
8172         https://bugs.webkit.org/show_bug.cgi?id=83542
8173
8174         test is broken on chromium-win (Requested by simonjam on
8175         #webkit).
8176
8177         * DumpRenderTree/chromium/WebViewHost.cpp:
8178         (WebViewHost::dispatchIntent):
8179
8180 2012-04-09  Takashi Toyoshima  <toyoshim@chromium.org>
8181
8182         Update pywebsocket to 0.7.4.
8183         https://bugs.webkit.org/show_bug.cgi?id=83461
8184
8185         Reviewed by Kent Tamura.
8186
8187         This version supports TLS by using ssl in addition to pyOpenSSL.
8188         Other functional difrerences from 0.7.2 are:
8189          - strict Sec-WebSocket-Key validation conforming RFC 4648
8190          - compression ratio logging in debug
8191
8192         * Scripts/webkitpy/thirdparty/__init__.py:
8193         (AutoinstallImportHook._install_pywebsocket):
8194
8195 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
8196
8197         add a webkit-patch print-baselines command
8198         https://bugs.webkit.org/show_bug.cgi?id=83348
8199
8200         Reviewed by Adam Barth.
8201
8202         This adds a simple 'print-baselines' command to webkit-patch
8203         that can be used in one of two forms: to print where the
8204         baselines for a given test (or set of tests) on a single port
8205         will be found, or to generate a report for multiple ports.
8206
8207         Example of the former:
8208
8209         $ webkit-patch print-baselines fast/html/keygen.html
8210         // For mac-snowleopard
8211         platform/mac/fast/html/keygen-expected.txt
8212         platform/mac/fast/html/keygen-expected.png
8213         $
8214
8215         The latter is most useful for finding out which fallback dirs are
8216         used by which ports for which tests, for example,
8217         'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
8218         No example output is given because the reports are pretty wordy :).
8219
8220         * Scripts/webkitpy/layout_tests/port/base.py:
8221         (Port.baseline_extensions): Added.
8222         (Port.expected_baseline_dict): Added.
8223         * Scripts/webkitpy/tool/commands/queries.py:
8224         (PrintBaselines):
8225         (PrintBaselines.__init__):
8226         (PrintBaselines.execute):
8227         (PrintBaselines._print_baselines):
8228         (PrintBaselines._platform_for_path):
8229
8230 2012-04-09  Florin Malita  <fmalita@chromium.org>
8231
8232         Unreviewed: adding myself to committers.py.
8233
8234         * Scripts/webkitpy/common/config/committers.py:
8235
8236 2012-04-09  Ming Xie  <mxie@rim.com>
8237
8238         [BlackBerry] Allow simulator to use GLES2 acceleration
8239         https://bugs.webkit.org/show_bug.cgi?id=81672
8240
8241         Reviewed by Rob Buis.
8242
8243         * Scripts/webkitdirs.pm:
8244         (blackberryCMakeArguments):
8245
8246 2012-04-09  Dana Jansens  <danakj@chromium.org>
8247
8248         Mark myself as a committer
8249         https://bugs.webkit.org/show_bug.cgi?id=83510
8250
8251         Reviewed by Adrienne Walker.
8252
8253         * Scripts/webkitpy/common/config/committers.py:
8254
8255 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
8256
8257         nrwt is failing to upload test results on the chromium-mac-leopard bots
8258         https://bugs.webkit.org/show_bug.cgi?id=83230
8259
8260         Unreviewed, build fix.
8261
8262         It looks like the change in r113399 to use the per-request
8263         timeout variable didn't actually work, so I am removing the
8264         timeout code altogether and counting on the idea that upload
8265         just isn't likely to take that long and the timeouts and
8266         retransmits are largely unused and largely unnecessary. We'll
8267         see if this breaks anywhere else.
8268
8269         * Scripts/webkitpy/common/net/file_uploader.py:
8270         (FileUploader.__init__):
8271         (FileUploader._upload_data.callback):
8272         (FileUploader):
8273
8274 2012-04-09  Rob Buis  <rbuis@rim.com>
8275
8276         [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
8277         https://bugs.webkit.org/show_bug.cgi?id=83469
8278
8279         Reviewed by Dirk Schulze.
8280
8281         Remove WTF:: prefixes and fix a warning with the length variable.
8282
8283         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
8284         (jsStringRefToWebCoreString):
8285         (LayoutTestController::execCommand):
8286         (LayoutTestController::isCommandEnabled):
8287         (LayoutTestController::setUserStyleSheetLocation):
8288         (LayoutTestController::counterValueForElementById):
8289         (LayoutTestController::overridePreference):
8290         (LayoutTestController::setMockGeolocationError):
8291         (LayoutTestController::findString):
8292
8293 2012-04-09  Patrick Gansterer  <paroga@webkit.org>
8294
8295         Build fix for WinCE after r113570.
8296
8297         * Scripts/build-webkit: Do not use FastMalloc for WinCE.
8298
8299 2012-04-09  Eric Carlson  <eric.carlson@apple.com>
8300
8301         Subscribe eric.carlson@apple.com to Media-related changes
8302         https://bugs.webkit.org/show_bug.cgi?id=83421
8303
8304         Reviewed by Dan Bernstein.
8305
8306         * Scripts/webkitpy/common/config/watchlist:
8307
8308 2012-04-09  Martin Robinson  <mrobinson@igalia.com>
8309
8310         check-webkit-style should ignore NULL usage in gtk_style_context_get_style
8311         https://bugs.webkit.org/show_bug.cgi?id=83412
8312
8313         Reviewed by David Levin.
8314
8315         Accept NULL as an argument for gtk_style_context_get_style, because it's
8316         used as a sentinel in a variable argument list.
8317
8318         * Scripts/webkitpy/style/checkers/cpp.py:
8319         (check_for_null): Add an exception.
8320         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
8321         (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
8322
8323 2012-04-09  Dirk Pranke  <dpranke@chromium.org>
8324
8325         webkitpy: use the filesystem object properly in fileuploader
8326         https://bugs.webkit.org/show_bug.cgi?id=83326
8327
8328         Reviewed by Adam Barth.
8329
8330         We should be using the filesystem object rather than the codecs
8331         object.
8332
8333         * Scripts/webkitpy/common/net/file_uploader.py:
8334         (FileUploader.upload_as_multipart_form_data):
8335
8336 2012-04-09  Eric Seidel  <eric@webkit.org>
8337
8338         Enable webkit_unit_tests for commit queue and EWS while tracking failures
8339         https://bugs.webkit.org/show_bug.cgi?id=83329
8340
8341         Unreviewed.  Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
8342
8343         line 62, in _create_unit_test_results
8344          return UnitTestResults.results_from_string(results_xml)
8345          NameError: global name 'UnitTestResults' is not defined
8346
8347         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
8348         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
8349         (LayoutTestResultsReaderTest.test_create_unit_test_results):
8350
8351 2012-04-08  Adam Barth  <abarth@webkit.org>
8352
8353         The port object is missing unit_tests_results_path
8354         https://bugs.webkit.org/show_bug.cgi?id=83448
8355
8356         Unreviewed.
8357
8358         This is causing the cr-linux-ews to throw an exception.
8359
8360         * Scripts/webkitpy/common/config/ports.py:
8361         (DeprecatedPort.unit_tests_results_path):
8362
8363 2012-04-07  Patrick Gansterer  <paroga@webkit.org>
8364
8365         [CMake] Cleanup WTF include directories
8366         https://bugs.webkit.org/show_bug.cgi?id=82716
8367
8368         Reviewed by Eric Seidel.
8369
8370         * DumpRenderTree/efl/CMakeLists.txt:
8371         * WinCELauncher/CMakeLists.txt:
8372
8373 2012-04-07  Rob Buis  <rbuis@rim.com>
8374
8375         [BlackBerry] Add Battery Status API support
8376         https://bugs.webkit.org/show_bug.cgi?id=82615
8377
8378         Reviewed by George Staikos.
8379
8380         Enable BATTERY_STATUS.
8381
8382         * Scripts/build-webkit:
8383
8384 2012-04-06  Ami Fischman  <fischman@chromium.org>
8385
8386         Subscribe feature-media-reviews@c.o to Media-related changes.
8387         https://bugs.webkit.org/show_bug.cgi?id=83397
8388
8389         Reviewed by David Levin.
8390
8391         * Scripts/webkitpy/common/config/committers.py:
8392         * Scripts/webkitpy/common/config/watchlist:
8393
8394 2012-04-06  Adrienne Walker  <enne@google.com>
8395
8396         [chromium] Add virtual test suite for threaded compositing
8397         https://bugs.webkit.org/show_bug.cgi?id=82263
8398
8399         Reviewed by James Robinson.
8400
8401         Add compositing/visibility as a virtual test suites to test threaded
8402         compositing with. This is a reasonable smoke test of 9 tests, none of
8403         which have any expectations in the non-threaded case.
8404
8405         To fix many of the remaining tests in this virtual test suite, there
8406         will need to be some serious refactoring to merge the conflict between
8407         the way CCScheduler wants to draw frames and the way DRT also wants to
8408         control things. So, in the short term, enable a few simple tests that
8409         are known to be passing.
8410
8411         * Scripts/webkitpy/layout_tests/port/chromium.py:
8412         (ChromiumPort.virtual_test_suites):
8413
8414 2012-04-06  Enrica Casucci  <enrica@apple.com>
8415
8416         Provide Obj-C private API to simplify markup.
8417         https://bugs.webkit.org/show_bug.cgi?id=83334
8418         <rdar://problem/11033861>
8419
8420         Reviewed by Sam Weinig.
8421
8422         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
8423         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
8424         (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
8425         * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
8426
8427 2012-04-06  Dirk Pranke  <dpranke@chromium.org>
8428
8429         new-run-webkit-tests: fix bugs in 'mock' drt implementation
8430         https://bugs.webkit.org/show_bug.cgi?id=83341
8431
8432         Reviewed by Eric Seidel.
8433
8434         The current implementation crashed in some circumstances for
8435         reference tests and files that were missing expected results.
8436         This patch fixes those cases and adds more unit tests; it is a
8437         precursor to adding unit tests each port that actually uses this
8438         code, in order to get better coverage of the port/*
8439         implementations.
8440
8441         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
8442         (parse_options):
8443         (MockDRT.input_from_line):
8444         (MockDRT.output_for_test):
8445         (MockDRT.run_one_test):
8446         (MockChromiumDRT.input_from_line):
8447         (MockChromiumDRT.output_for_test):
8448         (MockChromiumDRT.run_one_test):
8449         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
8450         (MockDRTTest.make_input_output):
8451         (MockDRTTest.expected_output):
8452         (MockDRTTest):
8453         (MockDRTTest.assertTest):
8454         (MockDRTTest.test_missing_image):
8455         (MockDRTTest.test_missing_text):
8456         (MockDRTTest.test_reftest_match):
8457         (MockDRTTest.test_reftest_mismatch):
8458         (MockChromiumDRTTest.expected_output):
8459
8460 2012-04-06  James Robinson  <jamesr@chromium.org>
8461
8462         Enable webkit_unit_tests for commit queue and EWS while tracking failures
8463         https://bugs.webkit.org/show_bug.cgi?id=83329
8464
8465         Reviewed by Adam Barth.
8466
8467         This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
8468         the commit queue and EWS can reject patches that cause regressions.
8469
8470         * Scripts/webkitpy/common/config/ports.py:
8471         (ChromiumPort.run_webkit_unit_tests_command):
8472         * Scripts/webkitpy/common/config/ports_mock.py:
8473         (MockPort.unit_tests_results_path):
8474         * Scripts/webkitpy/common/net/layouttestresults.py:
8475         (LayoutTestResults.__init__):
8476         (LayoutTestResults.failing_tests):
8477         (LayoutTestResults):
8478         (LayoutTestResults.add_unit_test_failures):
8479         * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
8480         (UnitTestResults):
8481         (UnitTestResults.results_from_string):
8482         * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
8483         (UnitTestResultsTest):
8484         (UnitTestResultsTest.test_nostring):
8485         (UnitTestResultsTest.test_emptystring):
8486         (UnitTestResultsTest.test_nofailures):
8487         (test_onefailure):
8488         (test_multiple_failures_per_test):
8489         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
8490         (MockCommitQueue.test_results):
8491         (MockCommitQueue.archive_last_test_results):
8492         (FailingTestCommitQueue.test_results):
8493         (test_flaky_test_failure):
8494         (test_failed_archive):
8495         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
8496         (LayoutTestResultsReader._create_unit_test_results):
8497         (LayoutTestResultsReader.results):
8498         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
8499         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
8500         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
8501         (PatchAnalysisTaskDelegate.test_results):
8502         (PatchAnalysisTaskDelegate.archive_last_test_results):
8503         (PatchAnalysisTask._test):
8504         (PatchAnalysisTask._build_and_test_without_patch):
8505         (PatchAnalysisTask._test_patch):
8506         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
8507         (AbstractEarlyWarningSystem.test_results):
8508         (AbstractEarlyWarningSystem.archive_last_test_results):
8509         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
8510         (EarlyWarningSytemTest._test_testing_ews):
8511         * Scripts/webkitpy/tool/commands/queues.py:
8512         (CommitQueue.test_results):
8513         (CommitQueue.archive_last_test_results):
8514         * Scripts/webkitpy/tool/commands/queues_unittest.py:
8515         (CommitQueueTest.test_commit_queue):
8516         (test_rollout):
8517         (test_manual_reject_during_processing):
8518         * Scripts/webkitpy/tool/steps/runtests.py:
8519         (RunTests.run):
8520         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
8521         (RunTestsTest.test_webkit_run_unit_tests):
8522
8523 2012-04-06  Aaron Colwell  <acolwell@chromium.org>
8524
8525         Enable MediaSource feature for DumpRenderTree so
8526         MediaSource LayoutTests will pass for Chromium.
8527         https://bugs.webkit.org/show_bug.cgi?id=83053
8528
8529         Reviewed by Dimitri Glazkov.
8530
8531         * DumpRenderTree/chromium/TestShell.cpp:
8532         (TestShell::TestShell):
8533
8534 2012-04-06  George Staikos  <staikos@webkit.org>
8535
8536         Turn on vibration support for BlackBerry.
8537
8538         Reviewed by Rob Buis.
8539
8540         * Scripts/build-webkit:
8541
8542 2012-04-06  Dan Bernstein  <mitz@apple.com>
8543
8544         <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
8545
8546         Reviewed by Sam Weinig.
8547
8548         * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
8549
8550 2012-04-05  Dirk Pranke  <dpranke@chromium.org>
8551
8552         nrwt is failing to upload test results on the chromium-mac-leopard bots
8553         https://bugs.webkit.org/show_bug.cgi?id=83230
8554
8555         Reviewed by Ojan Vafai.
8556
8557         This should fix things properly; FileUploader() was setting the
8558         socket default timeout value, and apparently that doesn't work
8559         properly with urllib. Also, the class had a bad try/finally
8560         block that was causing the exceptions to be swallowed :(.
8561
8562         * Scripts/webkitpy/common/net/file_uploader.py:
8563         (FileUploader.__init__):
8564         (FileUploader._upload_data.callback):
8565         (FileUploader):
8566         (FileUploader._upload_data):
8567         * Scripts/webkitpy/common/net/networktransaction.py:
8568         (NetworkTimeout.__str__):
8569         (NetworkTransaction.run):
8570         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
8571         (JSONResultsGeneratorBase.upload_json_files):
8572
8573 2012-04-05  Patrick Gansterer  <paroga@webkit.org>
8574
8575         [Qt] Correct <wtf/*.h> include paths.
8576         https://bugs.webkit.org/show_bug.cgi?id=83270
8577
8578         Reviewed by Eric Seidel.
8579
8580         Modify the #include declerations so that the
8581         wtf types are included using the full path.
8582
8583         * WebKitTestRunner/qt/TestInvocationQt.cpp:
8584
8585 2012-04-05  Philippe Normand  <pnormand@igalia.com>
8586
8587         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
8588         https://bugs.webkit.org/show_bug.cgi?id=83176
8589
8590         Reviewed by Tony Chang.
8591
8592         Refactored the test to use os.path.join() to specify the
8593         core_pattern value of the empty crash log mock.
8594
8595         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
8596         (GtkPortTest):
8597         (GtkPortTest.assertLinesEqual):
8598         (GtkPortTest.test_get_crash_log):
8599         (_mock_gdb_output):
8600
8601 2012-04-05  Csaba Osztrogonác  <ossy@webkit.org>
8602
8603         [Qt] Fix includes after QtDeclarative -> QtQML renaming
8604         https://bugs.webkit.org/show_bug.cgi?id=82195
8605
8606         Relanding r112651, because Qt5 is updated everywhere.
8607
8608         * MiniBrowser/qt/BrowserWindow.cpp:
8609         (BrowserWindow::updateVisualMockTouchPoints):
8610         * MiniBrowser/qt/main.cpp:
8611         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
8612         (WTR::WrapperWindow::handleStatusChanged):
8613         * qmake/mkspecs/features/unix/default_post.prf:
8614
8615 2012-04-05  Pierre Rossi  <pierre.rossi@gmail.com>
8616
8617         [Qt] WK1/WK2 layout test results are diverging
8618         https://bugs.webkit.org/show_bug.cgi?id=82720
8619
8620         The resolving of default font families was altered in Qt5.
8621         This directly affects the font picked by DRT for layout
8622         tests. Since we want to keep the Qt4 and Qt5 results in line,
8623         we can trick DRT in picking the same font as before for now.
8624
8625         Reviewed by Csaba Osztrogonác.
8626
8627         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
8628         (WebKit::initializeTestFonts):
8629
8630 2012-04-05  Kinuko Yasuda  <kinuko@chromium.org>
8631
8632         Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
8633         https://bugs.webkit.org/show_bug.cgi?id=82592
8634
8635         Reviewed by David Levin.
8636
8637         Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
8638
8639         * DumpRenderTree/chromium/EventSender.cpp:
8640         (EventSender::beginDragWithFiles):
8641
8642 2012-04-04  Tim Horton  <timothy_horton@apple.com>
8643
8644         [mac] WKTR should always keep its windows offscreen
8645         https://bugs.webkit.org/show_bug.cgi?id=83244
8646         <rdar://problem/11188764>
8647
8648         Reviewed by Simon Fraser.
8649
8650         We don't want to allow windows onto the main display; intercept attempts to
8651         change WebKitTestRunnerWindow's frame origin and prevent it from happening.
8652
8653         Also keep around and respond with a new "fake" origin, in case someone is
8654         expecting it to change (I couldn't find any tests that expected this, however).
8655
8656         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
8657         (-[WebKitTestRunnerWindow setFrameOrigin:]):
8658         (-[WebKitTestRunnerWindow setFrame:display:animate:]):
8659         (-[WebKitTestRunnerWindow setFrame:display:]):
8660         (-[WebKitTestRunnerWindow frame]):
8661
8662 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
8663
8664         Fix typo introduced in r113271.
8665
8666         Unreviewed, build fix.
8667
8668         * Scripts/webkitpy/common/net/file_uploader.py:
8669         (FileUploader._upload_data.callback):
8670         (FileUploader):
8671
8672 2012-04-04  Scott Graham  <scottmg@google.com>
8673
8674         [Chromium, DRT] Bounds check indices on gamepadController
8675         https://bugs.webkit.org/show_bug.cgi?id=83192
8676
8677         Invalid test data would cause bad array accesses. Add simple checks to
8678         ignore such invalid data.
8679
8680         Reviewed by Kent Tamura.
8681
8682         * DumpRenderTree/chromium/GamepadController.cpp:
8683         (GamepadController::connect):
8684         (GamepadController::disconnect):
8685         (GamepadController::setId):
8686         (GamepadController::setButtonCount):
8687         (GamepadController::setButtonData):
8688         (GamepadController::setAxisCount):
8689         (GamepadController::setAxisData):
8690
8691 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
8692
8693         nrwt is failing to upload test results on the chromium-mac-leopard bots
8694         https://bugs.webkit.org/show_bug.cgi?id=83230
8695
8696         Reviewed by Ojan Vafai.
8697
8698         More debugging info and a possible fix - stop messing with the
8699         default network timeout, and don't swallow URLErrors.
8700
8701         * Scripts/webkitpy/common/net/file_uploader.py:
8702         (FileUploader._upload_data):
8703         * Scripts/webkitpy/common/net/networktransaction.py:
8704         (NetworkTransaction.run):
8705         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
8706         (JSONResultsGeneratorBase.upload_json_files):
8707
8708 2012-04-04  Dirk Pranke  <dpranke@chromium.org>
8709
8710         nrwt is failing to upload test results on the chromium-mac-leopard bots
8711         https://bugs.webkit.org/show_bug.cgi?id=83230
8712
8713         Reviewed by Ojan Vafai.
8714
8715         * Scripts/webkitpy/common/net/file_uploader.py:
8716         (FileUploader.__init__):
8717         (FileUploader._upload_data.callback):
8718         (FileUploader):
8719         * Scripts/webkitpy/layout_tests/controllers/manager.py:
8720         (Manager._upload_json_files):
8721         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
8722         (JSONResultsGeneratorBase.upload_json_files):
8723
8724 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
8725
8726         WKTR needs to implement layoutTestController.setPageVisibility()
8727         https://bugs.webkit.org/show_bug.cgi?id=69554
8728
8729         Reviewed by Simon Fraser.
8730
8731         This patch implements the layoutTestController.setPageVisibility
8732         so WKTR supports the Page Visibility API implementation by using InjectedBundle
8733         to set the visibility state directly to Page.
8734
8735         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
8736         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
8737         (WTR::LayoutTestController::setPageVisibility):
8738         (WTR):
8739         (WTR::LayoutTestController::resetPageVisibility):
8740         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
8741         (LayoutTestController):
8742
8743 2012-04-04  Adam Barth  <abarth@webkit.org>
8744
8745         [Chromium] TestWebKitAPI links in WebCore twice
8746         https://bugs.webkit.org/show_bug.cgi?id=83177
8747
8748         Reviewed by Dimitri Glazkov.
8749
8750         This is causing link errors in the Windows component build. This patch
8751         moves the dependencies a bit lower down in the dependency diagram in
8752         the hopes of removing the duplicate symbols.
8753
8754         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
8755
8756 2012-04-04  Christophe Dumez  <christophe.dumez@intel.com>
8757
8758         [EFL][DRT] Catch the "resource,request,willsend" signal
8759         https://bugs.webkit.org/show_bug.cgi?id=82192
8760
8761         Reviewed by Gustavo Noronha Silva.
8762
8763         EFL's DumpRenderTree now catches the "resource,request,willsend"
8764         signal in order to implement the "Blocked access to external URL"
8765         behavior and avoid potential network-related timeouts in the tests.
8766
8767         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
8768         (DumpRenderTreeChrome::createView):
8769         (DumpRenderTreeChrome::onWillSendRequest):
8770         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
8771         (DumpRenderTreeChrome):
8772
8773 2012-04-04  Patrick Gansterer  <paroga@webkit.org>
8774
8775         [EFL][DRT] Correct <wtf/*.h> include paths.
8776         https://bugs.webkit.org/show_bug.cgi?id=83168
8777
8778         Reviewed by Eric Seidel.
8779
8780         Modify the #include declarations so that the
8781         wtf types are included using the full path.
8782
8783         * DumpRenderTree/efl/DumpRenderTree.cpp:
8784
8785 2012-04-04  Philippe Normand  <pnormand@igalia.com>
8786
8787         gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
8788         https://bugs.webkit.org/show_bug.cgi?id=83176
8789
8790         Reviewed by Tony Chang.
8791
8792         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
8793         (test_get_crash_log): Skip the test on non-linux platforms.
8794
8795 2012-04-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
8796
8797         [EFL] DRT support for computedStyleIncludingVisitedInfo
8798         https://bugs.webkit.org/show_bug.cgi?id=82190
8799
8800         Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
8801         LayoutTestController so that we can unskip related tests from the skip list.
8802
8803         Reviewed by Antonio Gomes.
8804
8805         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
8806         (LayoutTestController::computedStyleIncludingVisitedInfo):
8807
8808 2012-04-04  Raphael Kubo da Costa  <rakuco@webkit.org>
8809
8810         Unreviewed; update my email address once again in the committers
8811         and watch list.
8812
8813         * Scripts/webkitpy/common/config/committers.py: Prefer my
8814         webkit.org email over my FreeBSD.org one.
8815         * Scripts/webkitpy/common/config/watchlist: Ditto.
8816
8817 2012-04-04  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
8818
8819         [Qt][WK2] QtWebKit2 should support Page Visibility API
8820         https://bugs.webkit.org/show_bug.cgi?id=81164
8821
8822         Reviewed by Kenneth Rohde Christiansen.
8823
8824         Enabling Page Visiblity API for Qt WebKit2.
8825
8826         * qmake/mkspecs/features/features.prf:
8827
8828 2012-04-04  Andras Becsi  <andras.becsi@nokia.com>
8829
8830         [Qt][WK2] Make the WebView a subclass of Flickable
8831         https://bugs.webkit.org/show_bug.cgi?id=83033
8832
8833         Reviewed by Kenneth Rohde Christiansen.
8834
8835         Remove workaround in MiniBrowser and the ScrollIndicator
8836         now that the WebView is a Flickable.
8837
8838         * MiniBrowser/qt/MiniBrowser.pro:
8839         * MiniBrowser/qt/qml/BrowserWindow.qml:
8840         * MiniBrowser/qt/qml/ScrollIndicator.qml:
8841         * WebKitTestRunner/Target.pri:
8842
8843 2012-04-04  Csaba Osztrogonác  <ossy@webkit.org>
8844
8845         REGRESSION(r113144): It made run-webkit-tests always fail
8846         https://bugs.webkit.org/show_bug.cgi?id=83142
8847
8848         Unreviewed trivial fix after r113144.
8849
8850         * Scripts/run-webkit-tests:
8851
8852 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8853
8854         I really hope this is the last build fix. Apparently exec doesn't quite arguments with
8855         double quotations on Windows. Use system instead.
8856
8857         Hopefully, this won't break anything.
8858
8859         * Scripts/run-webkit-tests:
8860
8861 2012-04-03  Keishi Hattori  <keishi@webkit.org>
8862
8863         Disable ENABLE_DATALIST for now
8864         https://bugs.webkit.org/show_bug.cgi?id=82871
8865
8866         Reviewed by Kent Tamura.
8867
8868         * Scripts/build-webkit: Disabled ENABLE_DATALIST.
8869
8870 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8871
8872         Sigh... this isn't going well. I can't even reproduce this issue locally.
8873         Another speculative fix.
8874
8875         * Scripts/run-webkit-tests:
8876
8877 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8878
8879         I don't know why I'm so sloppy today. Another build fix.
8880
8881         * Scripts/run-webkit-tests:
8882
8883 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8884
8885         Hopefully the last build fix for Chromium Windows.
8886
8887         Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
8888
8889         * Scripts/run-webkit-tests:
8890
8891 2012-04-03  Dirk Pranke  <dpranke@chromium.org>
8892
8893         [Chromium] Lots of timeouts causing Mac10.6 to exit early.
8894         https://bugs.webkit.org/show_bug.cgi?id=83076
8895
8896         Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
8897
8898         Add logic to the apple mac and chromium mac code to not use
8899         too many workers; it looks like the xserves (and possibly mac
8900         pros) count hyperthreaded cores when they really shouldn't and
8901         we end up using too many workers at a time; this leads to tests
8902         thrashing and timing out.
8903
8904         This change is a temporary fix to make the bots happy while I
8905         look into more profiling and other fixes.
8906
8907         * Scripts/webkitpy/layout_tests/port/mac.py:
8908         (ChromiumMacPort.default_child_processes):
8909
8910         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
8911         (ChromiumMacPort.default_child_processes):
8912
8913 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
8914
8915         WebKitTestRunner's EventSender is leaky
8916         https://bugs.webkit.org/show_bug.cgi?id=83099
8917
8918         Reviewed by Beth Dakin.
8919
8920         Fix leaks of WKNumbers by using the adoptWK idiom, and make
8921         all the code consistent.
8922
8923         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
8924         (WTR::EventSendingController::mouseDown):
8925         (WTR::EventSendingController::mouseUp):
8926         (WTR::EventSendingController::mouseMoveTo):
8927         (WTR::EventSendingController::leapForward):
8928         (WTR::EventSendingController::keyDown):
8929         (WTR::EventSendingController::mouseScrollBy):
8930         (WTR::EventSendingController::addTouchPoint):
8931         (WTR::EventSendingController::updateTouchPoint):
8932         (WTR::EventSendingController::setTouchModifier):
8933         (WTR::EventSendingController::releaseTouchPoint):
8934         (WTR::EventSendingController::cancelTouchPoint):
8935
8936 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8937
8938         Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
8939
8940         * Scripts/run-webkit-tests:
8941         (useNewRunWebKitTests):
8942
8943 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8944
8945         kill-old-processes should kill apache2 and httpd
8946         https://bugs.webkit.org/show_bug.cgi?id=83065
8947
8948         Reviewed by Tony Chang.
8949
8950         Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
8951
8952         * BuildSlaveSupport/kill-old-processes:
8953
8954 2012-04-03  Tony Chang  <tony@chromium.org>
8955
8956         run the same test steps on test only bots as on build-and-test bots
8957         https://bugs.webkit.org/show_bug.cgi?id=83090
8958
8959         Reviewed by Ryosuke Niwa.
8960
8961         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
8962         (TestFactory.__init__):
8963
8964 2012-04-03  Ami Fischman  <fischman@chromium.org>
8965
8966         Add a Media watchlist.
8967         https://bugs.webkit.org/show_bug.cgi?id=83071
8968
8969         Reviewed by David Levin.
8970
8971         * Scripts/webkitpy/common/config/watchlist:
8972
8973 2012-04-03  Simon Fraser  <simon.fraser@apple.com>
8974
8975         Fix large leak in WebKitTestRunner
8976         https://bugs.webkit.org/show_bug.cgi?id=83084
8977
8978         Reviewed by Beth Dakin.
8979
8980         Fix a leak of the bimap backing store created when doing pixel and
8981         ref tests. This leak was causing serious thrash on the test bots.
8982
8983         We don't need to allocate memory for CGBitmapContextCreate(); if we
8984         pass NULL, it will allocate and manage its own backing store.
8985
8986         * WebKitTestRunner/cg/TestInvocationCG.cpp:
8987         (WTR::createCGContextFromImage):
8988
8989 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
8990
8991         Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
8992
8993         * BuildSlaveSupport/built-product-archive:
8994         (unzipArchive):
8995
8996 2012-04-03  Ojan Vafai  <ojan@chromium.org>
8997
8998         Give more human friendly error message when builders fail to load or have stale data.
8999         https://bugs.webkit.org/show_bug.cgi?id=83058
9000
9001         Reviewed by Eric Seidel.
9002
9003         * TestResultServer/static-dashboards/dashboard_base.js:
9004         (addError):
9005         (addBuilderLoadErrors):
9006         (handleLocationChange):
9007         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
9008
9009 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
9010
9011         Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
9012
9013         * BuildSlaveSupport/built-product-archive:
9014         (extractBuiltProduct):
9015
9016 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
9017
9018         Yet another build fix after r113067. Don't trigger Chromium testers right away
9019         since they're now triggered by builders.
9020
9021         * BuildSlaveSupport/build.webkit.org-config/config.json:
9022
9023 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
9024
9025         Another build fix after r113067 for Mac port.
9026         It turned out that archiving the entire build directory doesn't work.
9027
9028         * BuildSlaveSupport/built-product-archive:
9029         (createZipManually):
9030         (createZip):
9031         (archiveBuiltProduct):
9032
9033 2012-04-03  Mike Lattanzio  <mlattanzio@rim.com>
9034
9035         [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
9036         https://bugs.webkit.org/show_bug.cgi?id=82643
9037
9038         Update LayoutTestController to accomodate the new find API.
9039         It now provides caseSensitive functionality to DRT.
9040
9041         Internal Review by Andy Chen.
9042
9043         Reviewed by Rob Buis.
9044
9045         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
9046         (LayoutTestController::findString):
9047
9048 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
9049
9050         Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
9051         because download-built-product creates the build directory as needed.
9052
9053         This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
9054
9055         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9056         (TestFactory.__init__):
9057
9058 2012-04-03  Ryosuke Niwa  <rniwa@webkit.org>
9059
9060         Build fix after r113067. Don't delete the build directory.
9061
9062         * BuildSlaveSupport/built-product-archive:
9063         (extractBuiltProduct):
9064
9065 2012-04-02  Ojan Vafai  <ojan@chromium.org>
9066
9067         Load all builder lists from the buildbot json
9068         https://bugs.webkit.org/show_bug.cgi?id=82998
9069
9070         Reviewed by Adam Barth.
9071
9072         Also, remove an unnecessary list of test types. Now we don't hard-code
9073         builder names anywhere and we only have a single hard-coded list of
9074         test types.
9075
9076         * TestResultServer/static-dashboards/builders.js:
9077         (BuilderMaster.prototype.logPath):
9078         (BuilderMaster.prototype.builderJsonPath):
9079         (requestBuilderList.xhr.onload):
9080         (requestBuilderList.xhr.onerror):
9081         (isChromiumDepsFyiGpuTestRunner):
9082         (isChromiumTipOfTreeGpuTestRunner):
9083         (isChromiumDepsGTestRunner):
9084         (isChromiumDepsCrosGTestRunner):
9085         (isChromiumTipOfTreeGTestRunner):
9086         (onBuilderListLoad):
9087         (loadBuildersList):
9088         * TestResultServer/static-dashboards/dashboard_base.js:
9089         (parseCrossDashboardParameters):
9090         (currentBuilderGroupCategory):
9091         * TestResultServer/static-dashboards/flakiness_dashboard.html:
9092         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
9093         (testHtmlForTestsWithExpectationsButNoFailures):
9094         (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
9095         (testGenerateChromiumDepsGTestBuildersFromBuilderList):
9096         (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
9097         (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
9098         * TestResultServer/static-dashboards/timeline_explorer.html:
9099
9100 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
9101
9102         Chromium testers should extract builds instead of building on their own
9103         https://bugs.webkit.org/show_bug.cgi?id=82996
9104
9105         Reviewed by Tony Chang.
9106
9107         Make Chromium builders triggger Chromium testers and make testers download and extract builds
9108         from the buildbot master instead of building binaries on their own.
9109
9110         Add download-built-product to wrap curl used in the download-built-product step since Windows
9111         does not provide "curl" natively.
9112
9113         * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
9114         Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
9115         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9116         (DownloadBuiltProduct): Call download-built-product instead of curl.
9117         * BuildSlaveSupport/built-product-archive:
9118         (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
9119         needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
9120         (archiveBuiltProduct): Zip the configuration build directory on Mac port.
9121         (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
9122         (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
9123         * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
9124
9125 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
9126
9127         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
9128         https://bugs.webkit.org/show_bug.cgi?id=82473
9129
9130         Reviewed by Philippe Normand.
9131
9132         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
9133         was ever run.
9134
9135         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
9136         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
9137
9138 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
9139
9140         [EFL] DRT support for setInteractiveFormValidationEnabled
9141         https://bugs.webkit.org/show_bug.cgi?id=82050
9142
9143         Enable interactive form validation and unskip tests from the
9144         skip list.
9145
9146         Reviewed by Antonio Gomes.
9147
9148         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
9149         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
9150
9151 2012-04-03  Philippe Normand  <pnormand@igalia.com>
9152
9153         Unreviewed, another test-webkitpy fix-up after r113037.
9154
9155         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
9156         crash dump depending on current environment.
9157
9158 2012-04-03  Philippe Normand  <pnormand@igalia.com>
9159
9160         Unreviewed, test-webkitpy build fix after r113037.
9161
9162         * Scripts/webkitpy/layout_tests/port/gtk.py:
9163         (GtkPort._get_crash_log):
9164
9165 2012-04-03  Philippe Normand  <pnormand@igalia.com>
9166
9167         [GTK] crash log reports support
9168         https://bugs.webkit.org/show_bug.cgi?id=81659
9169
9170         Reviewed by Martin Robinson.
9171
9172         Removed the daemontools crashmon/xvfb scripts and implemented the crash
9173         log reporting in the NRWT Gtk port. To get proper crash logs one
9174         needs to set the core pattern like this:
9175         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
9176         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
9177         environment variable.
9178
9179         * BuildSlaveSupport/gtk/README:
9180         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
9181         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
9182         * BuildSlaveSupport/gtk/crashmon/run: Removed.
9183         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
9184         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
9185         * BuildSlaveSupport/gtk/xvfb/run: Removed.
9186         * Scripts/new-run-webkit-tests:
9187         * Scripts/webkitpy/layout_tests/port/gtk.py:
9188         (GtkDriver.stop):
9189         (GtkPort.show_results_html_file):
9190         (GtkPort):
9191         (GtkPort._get_gdb_output):
9192         (GtkPort._get_crash_log):
9193         (GtkPort._get_crash_log.match_filename):
9194         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
9195         (GtkPortTest):
9196         (test_show_results_html_file):
9197         (assertLinesEqual):
9198         (_mock_gdb_output):
9199         (test_get_crash_log):
9200
9201 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
9202
9203         Enable and connect the WebInspectorServer with WebKit2 pages.
9204         https://bugs.webkit.org/show_bug.cgi?id=73094
9205
9206         Reviewed by Simon Hausmann.
9207
9208         Enable developer extras on pages in MiniBrowser for Qt.
9209
9210         * MiniBrowser/qt/qml/BrowserWindow.qml:
9211
9212 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
9213
9214         [EFL] LayoutTestController needs implementation of setDefersLoading
9215         https://bugs.webkit.org/show_bug.cgi?id=82890
9216
9217         Reviewed by Philippe Normand.
9218
9219         Implement setDefersLoading() in EFL's LayoutTestController so that the
9220         corresponding test case can be removed from the skip list.
9221
9222         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9223         (LayoutTestController::setDefersLoading):
9224
9225 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
9226
9227         [EFL] LayoutTestController needs implementation of goBack
9228         https://bugs.webkit.org/show_bug.cgi?id=81914
9229
9230         Reviewed by Philippe Normand.
9231
9232         Implement goBack() in EFL's LayoutTestController by calling
9233         ewk_frame_back().
9234
9235         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9236         (LayoutTestController::goBack):
9237
9238 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
9239
9240         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
9241         https://bugs.webkit.org/show_bug.cgi?id=82589
9242
9243         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
9244         in order to unskip printing/page-format-data.html
9245
9246         Reviewed by Philippe Normand.
9247
9248         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9249         (LayoutTestController::pageSizeAndMarginsInPixels):
9250
9251 2012-04-03  Simon Pena  <spena@igalia.com>
9252
9253         [GTK] DRT missing didRunInsecureContent notification
9254         https://bugs.webkit.org/show_bug.cgi?id=59367
9255
9256         Reviewed by Philippe Normand.
9257
9258         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
9259         the main WebFrame or any other WebFrame created later. Added
9260         "didRunInsecureContent" notification in the callback in order to
9261         get the LayoutTests passing.
9262
9263         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
9264         to WebFrame's "insecure-content-run" signal and add
9265         didRunInsecureContent notification in the callback to get the
9266         LayoutTests passing.
9267         (didRunInsecureContent):
9268         (createWebView):
9269
9270 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
9271
9272         rebaseline-server: Make it possible to not launch a browser with the server.
9273         https://bugs.webkit.org/show_bug.cgi?id=82999
9274
9275         Reviewed by Adam Barth.
9276
9277         Add the `--no-show-results' option, which lets one decide not to
9278         launch a web browser when running the rebaseline server.  This is
9279         especially useful if the default browser is not the wanted one, or
9280         if the rebaseline server page is already open.
9281
9282         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
9283         (AbstractLocalServerCommand.__init__):
9284         (AbstractLocalServerCommand.execute):
9285
9286 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
9287
9288         EFL's LayoutTestController disableImageLoading implementation.
9289         https://bugs.webkit.org/show_bug.cgi?id=82848
9290
9291         Reviewed by Hajime Morita.
9292
9293         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
9294         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
9295         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9296         (LayoutTestController::disableImageLoading):
9297
9298 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
9299
9300         [EFL] LayoutTestController needs implementation of isPageBoxVisible
9301         https://bugs.webkit.org/show_bug.cgi?id=82591
9302
9303         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
9304         in order to unskip printing/page-format-data.html
9305
9306         Reviewed by Hajime Morita.
9307
9308         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9309         (LayoutTestController::isPageBoxVisible):
9310
9311 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
9312
9313         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
9314         https://bugs.webkit.org/show_bug.cgi?id=82962
9315
9316         Reviewed by Dirk Pranke.
9317
9318         Ensure that _build_path() returns an absolute path.
9319
9320         Eric Seidel also had to deploy MockConfig in a bunch of places
9321         in order to correct previous testing errors where we were
9322         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
9323         was a real path.  The real Config object calls run_command("webkit-build-directory")
9324         to read the WebKit build directory from the webkitdirs.pm perl code.
9325         MockConfig abstracts this away and always returns "/mock-build" during
9326         testing.  This change is much larger than one would think necessary
9327         because of needing to deploy this MockConfig class.
9328
9329         * Scripts/webkitpy/layout_tests/port/webkit.py:
9330         (WebKitPort._build_path):
9331
9332 2012-04-02  Ojan Vafai  <ojan@chromium.org>
9333
9334         Fix snafu in r112971. We were never calling parseParameter for builder.
9335
9336         * TestResultServer/static-dashboards/dashboard_base.js:
9337
9338 2012-04-02  Ojan Vafai  <ojan@chromium.org>
9339
9340         Generate the lists of all layout test builders from the buildbot json
9341         https://bugs.webkit.org/show_bug.cgi?id=82924
9342
9343         Reviewed by Mihai Parparita.
9344
9345         In order to make this work, cleaned up a lot of existing technical debt.
9346         -Got rid of expectations builder. This concept is outdated and just dead code.
9347         -Split hash parameter parsing into two functions. One for dashboard_base
9348         (crossDashboardParameters) and one for the specific dashboard html file
9349         (dashboardSpecificParameters). In the old world, parseParameters needed to
9350         be called twice and depended on it's own output the first time through.
9351         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
9352         doesn't depend on the output of crossDashboardParameters.
9353         -Lots of variable/method renames due to the above.
9354         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
9355         for that dashboard.
9356
9357         * TestResultServer/static-dashboards/aggregate_results.html:
9358         * TestResultServer/static-dashboards/builders.js:
9359         (BuilderGroup):
9360         (BuilderGroup.prototype.setup):
9361         (jsonRequest.xhr.onload):
9362         (jsonRequest.xhr.onerror):
9363         (isWebkitTestRunner):
9364         (isChromiumWebkitTipOfTreeTestRunner):
9365         (isChromiumWebkitDepsTestRunner):
9366         (generateBuildersFromBuilderList):
9367         (onLayoutTestBuilderListLoad):
9368         (onErrorLoadingBuilderList):
9369         (loadBuildersList):
9370         * TestResultServer/static-dashboards/dashboard_base.js:
9371         (handleValidHashParameterWrapper):
9372         (queryHashAsMap):
9373         (parseParameter):
9374         (parseCrossDashboardParameters):
9375         (parseDashboardSpecificParameters):
9376         (parseParameters):
9377         (diffStates):
9378         (defaultValue):
9379         (isLayoutTestResults):
9380         (isGPUTestResults):
9381         (currentBuilderGroupCategory):
9382         (currentBuilderGroup):
9383         (initBuilders):
9384         Now that we've split parameter parseing, these methods no longer need
9385         to take an optional state. They can always just use the global cross-dashboard state.
9386
9387         (pathToBuilderResultsFile):
9388         (appendJSONScriptElementFor):
9389         (appendJSONScriptElements):
9390         (handleResourceLoadError):
9391         (haveJsonFilesLoaded):
9392         (combinedDashboardState):
9393         (setQueryParameter):
9394         (permaLinkURLHash):
9395         (toggleQueryParameter):
9396         (queryParameterValue):
9397         (selectHTML):
9398         (htmlForTestTypeSwitcher):
9399         (g_handleBuildersListLoaded):
9400         * TestResultServer/static-dashboards/flakiness_dashboard.html:
9401         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
9402         (testPlatformAndBuildType):
9403         (testSubstringList):
9404         (testHtmlForTestTypeSwitcherGroup):
9405         (testLookupVirtualTestSuite):
9406         (testBaseTest):
9407         (generateBuildersFromBuilderListHelper):
9408         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
9409         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
9410         (assertObjectsDeepEqual):
9411         (testQueryHashAsMap):
9412         (testDiffStates):
9413         * TestResultServer/static-dashboards/timeline_explorer.html:
9414         * TestResultServer/static-dashboards/treemap.html:
9415
9416 2012-04-02  Tony Chang  <tony@chromium.org>
9417
9418         check-webkit-style errors when removing .png files
9419         https://bugs.webkit.org/show_bug.cgi?id=82933
9420
9421         Reviewed by David Levin.
9422
9423         * Scripts/webkitpy/style/patchreader.py:
9424         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
9425         * Scripts/webkitpy/style/patchreader_unittest.py:
9426         (test_check_patch_with_png_deletion):
9427
9428 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
9429
9430         Unreviewed, rolling out r112948.
9431         http://trac.webkit.org/changeset/112948
9432         https://bugs.webkit.org/show_bug.cgi?id=82961
9433
9434         Someone else already checked in a similar change (Requested by
9435         sundiamonde on #webkit).
9436
9437         * Scripts/webkitpy/layout_tests/port/webkit.py:
9438         (WebKitDriver._start):
9439
9440 2012-04-02  Adam Barth  <abarth@webkit.org>
9441
9442         garden-o-matic isn't able to rebaseline audio failures
9443         https://bugs.webkit.org/show_bug.cgi?id=82957
9444
9445         Reviewed by Chris Rogers.
9446
9447         This patch just adds "wav" to the list of test suffixes and updates the
9448         unit tests to show that we're rebaselining audio tests results now too.
9449
9450         * Scripts/webkitpy/tool/commands/rebaseline.py:
9451         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
9452         (test_rebaseline_updates_expectations_file):
9453
9454 2012-04-02  Adam Barth  <abarth@webkit.org>
9455
9456         garden-o-matic should let you listen to audio failures
9457         https://bugs.webkit.org/show_bug.cgi?id=82953
9458
9459         Reviewed by Chris Rogers.
9460
9461         Now that we've actually got an audio failure on the bots, we can clean
9462         up the last stray bugs.  This patch doesn't have any tests because I'm
9463         lame.
9464
9465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
9466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
9467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
9468         (.):
9469
9470 2012-04-02  Stephanie Lewis  <slewis@apple.com>
9471
9472         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
9473         https://bugs.webkit.org/show_bug.cgi?id=82552
9474
9475         Reviewed by Dirk Pranke.
9476
9477         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
9478
9479         * Scripts/webkitpy/layout_tests/port/webkit.py:
9480         (WebKitDriver._start):
9481
9482 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
9483
9484         NRWT is not printing out the builder it's uploading JSON files for
9485         https://bugs.webkit.org/show_bug.cgi?id=82834
9486
9487         Reviewed by Ojan Vafai.
9488
9489         Handle log messages of the form log.info("%s", arg) properly ...
9490         I didn't even know you could do that :).
9491
9492         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
9493         (_LogHandler.emit):
9494         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
9495         (RegularTest.test_log_args):
9496         (VerboseTest.test_log_args):
9497
9498 2012-04-02  Tim Horton  <timothy_horton@apple.com>
9499
9500         [mac] LayoutTestHelper crashes if there is no main display
9501         https://bugs.webkit.org/show_bug.cgi?id=82944
9502         <rdar://problem/11162954>
9503
9504         Reviewed by Simon Fraser.
9505
9506         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
9507         a null dictionary, so we shouldn't go ahead and try to read from it.
9508
9509         * DumpRenderTree/mac/LayoutTestHelper.m:
9510         (installLayoutTestColorProfile):
9511
9512 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
9513
9514         [Qt][WK2] Set up plugin process on Unix
9515         https://bugs.webkit.org/show_bug.cgi?id=72121
9516
9517         Reviewed by Simon Hausmann.
9518
9519         * qmake/mkspecs/features/features.prf: Reenable plugins
9520         and turn on plugin process.
9521
9522 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
9523
9524         Unreviewed, rolling out r112868, r112879, and r112881.
9525         http://trac.webkit.org/changeset/112868
9526         http://trac.webkit.org/changeset/112879
9527         http://trac.webkit.org/changeset/112881
9528         https://bugs.webkit.org/show_bug.cgi?id=82901
9529
9530         "Build fail on bots." (Requested by kbalazs on #webkit).
9531
9532         * MiniBrowser/gtk/GNUmakefile.am:
9533         * qmake/mkspecs/features/features.prf:
9534
9535 2012-04-02  Philippe Normand  <pnormand@igalia.com>
9536
9537         [GTK] Enable shadow-dom in build-webkit.
9538
9539         Rubber-stamped by Gustavo Noronha Silva.
9540
9541         * Scripts/build-webkit: Enable shadow-dom build, this is need to
9542         have a working build currently.
9543
9544 2012-04-02  Andreas Kling  <kling@webkit.org>
9545
9546         Adding Zalan Bujtas to committers list.
9547
9548         * Scripts/webkitpy/common/config/committers.py:
9549
9550 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
9551
9552         [Qt][WK2] Set up plugin process on Unix
9553         https://bugs.webkit.org/show_bug.cgi?id=72121
9554
9555         Reviewed by Simon Hausmann.
9556
9557         * qmake/mkspecs/features/features.prf: Reenable plugins
9558         and turn on plugin process.
9559
9560 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
9561
9562         Unreviewed, rolling out r112651.
9563         http://trac.webkit.org/changeset/112651
9564         https://bugs.webkit.org/show_bug.cgi?id=82887
9565
9566         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
9567
9568         * MiniBrowser/qt/BrowserWindow.cpp:
9569         (BrowserWindow::updateVisualMockTouchPoints):
9570         * MiniBrowser/qt/main.cpp:
9571         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
9572         (WTR::WrapperWindow::handleStatusChanged):
9573         * qmake/mkspecs/features/unix/default_post.prf:
9574
9575 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
9576
9577         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
9578         https://bugs.webkit.org/show_bug.cgi?id=82877
9579
9580         Reviewed by Philippe Normand.
9581
9582         * Scripts/run-gtk-tests:
9583         (TestRunner.run_tests): Use replace instead of lstrip to remove
9584         the programs_path from the full path of unit tests.
9585
9586 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
9587
9588         Unreviewed. Skip flaky unit tests.
9589
9590         * Scripts/run-gtk-tests:
9591         (TestRunner):
9592
9593 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
9594
9595         webkitpy rebaseline.
9596
9597         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
9598         (test_run_test_set_with_json_output):
9599         (test_run_test_set_with_json_source):
9600
9601 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
9602
9603         perf-o-matic should store test results' units
9604         https://bugs.webkit.org/show_bug.cgi?id=82852
9605
9606         Reviewed by Kentaro Hara.
9607
9608         Include units in the results JSON.
9609
9610         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
9611         (PerfTestsRunner._process_chromium_style_test_result):
9612         (PerfTestsRunner._process_parser_test_result):
9613
9614 2012-04-01  Tony Tseung  <tseung@apple.com>
9615
9616         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
9617         composite fonts from existing physical fonts.
9618         <rdar://problem/10717370>
9619         https://bugs.webkit.org/show_bug.cgi?id=82810
9620
9621         A new test font of this kind as been added to the test tools for running the webkit-tests
9622
9623         Reviewed by Dan Bernstein.
9624
9625         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9626         Added new dependency SampleFont.sfont
9627
9628         * DumpRenderTree/fonts/SampleFont.sfont: Added.
9629
9630         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
9631         * DumpRenderTree/mac/DumpRenderTree.mm:
9632         (allowedFontFamilySet):
9633         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
9634
9635         (activateTestingFonts):
9636         Added the registration of the Composite Font Referene sample font
9637
9638         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
9639         (WTR::allowedFontFamilySet):
9640         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
9641
9642         (WTR::activateFonts):
9643         Added the registration of the Composite Font Referene sample font
9644
9645         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9646         Added new dependency SampleFont.sfont
9647
9648         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
9649
9650 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
9651
9652         Support the Network Information API
9653         https://bugs.webkit.org/show_bug.cgi?id=73528
9654
9655         Reviewed by Adam Barth.
9656
9657         Add network information API feature to build script.
9658
9659         * Scripts/build-webkit:
9660
9661 2012-03-31  Ojan Vafai  <ojan@chromium.org>
9662
9663         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
9664         https://bugs.webkit.org/show_bug.cgi?id=82839
9665
9666         Reviewed by Adam Barth.
9667
9668         Also, update various hard-coded lists for WIN7 and Lion ports.
9669         This is necessary since the new list of builders grabbed off the
9670         buildbot includes Lion.
9671
9672         * TestResultServer/static-dashboards/builders.js:
9673         (generateWebkitBuildersFromBuilderList):
9674         (xhr.onreadystatechange):
9675         Don't use dashboard_base's request method to avoid layering violation.
9676
9677         * TestResultServer/static-dashboards/dashboard_base.js:
9678         (parseParameters):
9679         (initBuilders):
9680         (haveJsonFilesLoaded):
9681         (g_handleBuildersListLoaded):
9682         Block loading the JSON files for each builder until we actually have a list of builders.
9683
9684         * TestResultServer/static-dashboards/flakiness_dashboard.html:
9685         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
9686         (testPlatformAndBuildType):
9687         (testGenerateWebkitBuildersFromBuilderList):
9688         * TestResultServer/static-dashboards/timeline_explorer.html:
9689         * TestResultServer/static-dashboards/treemap.html:
9690         Delay generating the page until the builder list has loaded.
9691
9692 2012-03-31  Ojan Vafai  <ojan@chromium.org>
9693
9694         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
9695         https://bugs.webkit.org/show_bug.cgi?id=82799
9696
9697         Reviewed by Eric Seidel.
9698
9699         If we don't run a test, mark it as skipped.
9700
9701         * Scripts/webkitpy/layout_tests/controllers/manager.py:
9702         (Manager._mark_interrupted_tests_as_skipped):
9703         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
9704         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
9705         (ManagerTest.test_interrupt_if_at_failure_limits):
9706
9707 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
9708
9709         One more build fix after r112781 for Chromium Windows.
9710         Don't copy zip .idb files.
9711
9712         * BuildSlaveSupport/built-product-archive:
9713         (copyBuildFiles):
9714
9715 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
9716
9717         Yet another build fix after r112781 for Chromium Windows.
9718         Run webkit-build-directory by perl explicitly.
9719
9720         * BuildSlaveSupport/built-product-archive:
9721         (determineWebKitBuildDirectory):
9722
9723 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
9724
9725         Fix the syntax error in master.cfg after r112734.
9726
9727         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9728         (unitTestsSupported):
9729
9730 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
9731
9732         Another build fix after r112781.
9733
9734         * BuildSlaveSupport/built-product-archive:
9735         (createZip):
9736
9737 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
9738
9739         Build fix after r112781.
9740
9741         * BuildSlaveSupport/built-product-archive:
9742         (createZipManually):
9743         (createZip):
9744
9745 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
9746
9747         Chromium bots should upload archived built files
9748         https://bugs.webkit.org/show_bug.cgi?id=82666
9749
9750         Reviewed by Tony Chang.
9751
9752         * BuildSlaveSupport/build.webkit.org-config/config.json:
9753         * BuildSlaveSupport/built-product-archive:
9754         (main):
9755         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
9756         call out to webkit-build-directory.
9757         (removeDirectoryIfExists): Extracted.
9758         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
9759         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
9760         (createZipManually.addToArchive):
9761         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
9762         (archiveBuiltProduct): Add support for Chromium port.
9763         * Scripts/webkit-build-directory: Add support for --platform options.
9764
9765 2012-03-30  Dan Bernstein  <mitz@apple.com>
9766
9767         Reverted r112767, because it caused many vertical text tests to fail.
9768
9769         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9770         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
9771         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
9772         * DumpRenderTree/mac/DumpRenderTree.mm:
9773         (allowedFontFamilySet):
9774         (activateTestingFonts):
9775         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
9776         (WTR::allowedFontFamilySet):
9777         (WTR::activateFonts):
9778         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
9779         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
9780
9781 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
9782
9783         [wx] Move wxWebKit API into WebKit namespace.
9784         https://bugs.webkit.org/show_bug.cgi?id=82740
9785
9786         Reviewed by Kevin Ollivier.
9787
9788         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
9789         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
9790         (LayoutWebViewEventHandler::bindEvents):
9791         (LayoutWebViewEventHandler::OnLoadEvent):
9792         (LayoutWebViewEventHandler::OnAlertEvent):
9793         (LayoutWebViewEventHandler::OnConfirmEvent):
9794         (LayoutWebViewEventHandler::OnPromptEvent):
9795         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
9796         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
9797         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
9798         (LayoutWebViewEventHandler):
9799         (dumpFramesAsText):
9800         (dump):
9801         (MyApp::OnInit):
9802         * wx/browser/browser.cpp:
9803         (MyApp::OnInit):
9804
9805 2012-03-30  Eli Fidler  <efidler@rim.com>
9806
9807         Enable OpenType Sanitizer for BlackBerry port.
9808         https://bugs.webkit.org/show_bug.cgi?id=82782
9809
9810         Reviewed by Eric Seidel.
9811
9812         * Scripts/webkitdirs.pm:
9813         (blackberryCMakeArguments): add OTS to include path
9814
9815 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
9816
9817         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
9818         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
9819         is found.
9820
9821         <rdar://problem/11158581>
9822
9823         Reviewed by Mark Rowe.
9824
9825         * Scripts/webkitpy/layout_tests/port/webkit.py:
9826         (WebKitDriver._start):
9827
9828 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
9829
9830         Disable run-api-tests on release mac builds
9831         https://bugs.webkit.org/show_bug.cgi?id=82788
9832
9833         Reviewed by Ryosuke Niwa.
9834
9835         TestWebKitAPI crashes every time in release builds currently
9836         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
9837         run-api-tests on mac release builders.
9838
9839         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
9840         (unitTestsSupported):
9841
9842 2012-03-30  Chang Shu  <cshu@webkit.org>
9843
9844         Unreviewed. Update my email.
9845
9846         * Scripts/webkitpy/common/config/committers.py:
9847
9848 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
9849
9850         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
9851         https://bugs.webkit.org/show_bug.cgi?id=82745
9852
9853         Reviewed by Simon Fraser.
9854
9855         * DumpRenderTree/AccessibilityUIElement.cpp:
9856         (rangeForPositionCallback):
9857         (AccessibilityUIElement::rangeForPosition):
9858         (AccessibilityUIElement::getJSClass):
9859         * DumpRenderTree/AccessibilityUIElement.h:
9860         (AccessibilityUIElement):
9861         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
9862         (AccessibilityUIElement::rangeForPosition):
9863         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
9864         (WTR::AccessibilityUIElement::rangeForPosition):
9865         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
9866         (AccessibilityUIElement):
9867         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
9868         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
9869         (WTR::AccessibilityUIElement::rangeForPosition):
9870         (WTR):
9871
9872 2012-03-30  David Barr  <davidbarr@chromium.org>
9873
9874         Split up top-level .gitignore and .gitattributes
9875         https://bugs.webkit.org/show_bug.cgi?id=82687
9876
9877         Reviewed by Tor Arne Vestbø.
9878
9879         * .gitattributes: Added.
9880         * .gitignore: Added.
9881         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
9882         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
9883
9884 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
9885
9886         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
9887
9888         * TestResultServer/static-dashboards/builders.js:
9889
9890 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
9891
9892         Update ChromiumOS bot names in builders.js to reflect changes made by
9893         http://crrev.com/129835
9894
9895         Also removes the ChromiumOS GTK builder, which was removed by
9896         http://crrev.com/129835
9897
9898         * TestResultServer/static-dashboards/builders.js:
9899
9900 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
9901
9902         [GTK] Disable introspection build in the at-spi2-core module.
9903         https://bugs.webkit.org/show_bug.cgi?id=82729
9904
9905         Reviewed by Philippe Normand.
9906
9907         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
9908
9909         * gtk/jhbuild.modules: Disable introspection.
9910
9911 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
9912
9913         Add a "preview" state to Page Visibility API implementation
9914         https://bugs.webkit.org/show_bug.cgi?id=81355
9915
9916         Reviewed by Adam Barth.
9917
9918         Updating the Page Visibility API implementation to the current spec version.
9919
9920         * DumpRenderTree/chromium/LayoutTestController.cpp:
9921         (LayoutTestController::setPageVisibility):
9922
9923 2012-03-30  Keishi Hattori  <keishi@webkit.org>
9924
9925         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
9926         https://bugs.webkit.org/show_bug.cgi?id=80972
9927
9928         Reviewed by Kent Tamura.
9929
9930         * Scripts/build-webkit:
9931         * qmake/mkspecs/features/features.prf:
9932
9933 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
9934
9935         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
9936         https://bugs.webkit.org/show_bug.cgi?id=82195
9937
9938         Reviewed by Simon Hausmann.
9939
9940         * MiniBrowser/qt/BrowserWindow.cpp:
9941         (BrowserWindow::updateVisualMockTouchPoints):
9942         * MiniBrowser/qt/main.cpp:
9943         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
9944         (WTR::WrapperWindow::handleStatusChanged):
9945         * qmake/mkspecs/features/unix/default_post.prf:
9946
9947 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
9948
9949         [EFL] Implement LayoutTestController::setMinimumTimerInterval
9950         https://bugs.webkit.org/show_bug.cgi?id=81220
9951
9952         Add missing implementation setMinimumTimerInterval to EFL's
9953         LayoutTestController so that we can unskip related tests from the skip list.
9954
9955         Reviewed by Philippe Normand.
9956
9957         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
9958         (LayoutTestController::setMinimumTimerInterval):
9959
9960 2012-03-29  Dan Bernstein  <mitz@apple.com>
9961
9962         Removed “Intel” from the Lion builders’ names.
9963
9964         Rubber-stamped by Mark Rowe.
9965
9966         * BuildSlaveSupport/build.webkit.org-config/config.json:
9967         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
9968         (LeaksViewer._displayURLPrompt):
9969
9970 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
9971
9972         [Chromium] Add sharded ChromiumOS debug bots to builders.js
9973         https://bugs.webkit.org/show_bug.cgi?id=82639
9974
9975         Reviewed by Eric Seidel.
9976
9977         The bots were sharded by http://crrev.com/129613, update builders.js
9978         to reflect this.
9979
9980         * TestResultServer/static-dashboards/builders.js:
9981
9982 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
9983
9984         remove support for junit-style xml output from test-webkitpy
9985         https://bugs.webkit.org/show_bug.cgi?id=82279
9986
9987         Reviewed by Eric Seidel.
9988
9989         This was added when we were looking into integrating w/ Jenkins
9990         rather than buildbot, but I believe that project got shelved, so
9991         this is unused. We can always add it back in later as necessary.
9992
9993         * Scripts/webkitpy/test/main.py:
9994         (Tester._parse_args):
9995         (Tester._run_tests):
9996         * Scritps/webkitpy/thirdparty/__init__.py:
9997
9998 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
9999
10000         new-run-webkit-tests: crashes when it fails to decode a stack trace
10001         https://bugs.webkit.org/show_bug.cgi?id=82673
10002
10003         Unreviewed, build fix.
10004
10005         We are assuming the stdout/stderr output from the driver is utf-8
10006         encoded when we get stack traces; this may not be a valid
10007         assumption generally, but if we do get strings that aren't valid
10008         utf-8, we would crash. Now we will ignore any decoding errors.
10009
10010         * Scripts/webkitpy/layout_tests/port/base.py:
10011         (Port._get_crash_log):
10012         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
10013         (PortTestCase.test_get_crash_log):
10014
10015 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
10016
10017         Scripts fail to detect when a tool crashes
10018         https://bugs.webkit.org/show_bug.cgi?id=82659
10019
10020         Reviewed by Mark Rowe.
10021
10022         Have exitStatus() detect when the process fail to exit cleanly
10023         (possibly because of a crash), and return a non-zero exit code
10024         in that case.
10025
10026         * Scripts/VCSUtils.pm:
10027         (exitStatus):
10028
10029 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
10030
10031         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
10032         https://bugs.webkit.org/show_bug.cgi?id=82581
10033
10034         Reviewed by Martin Robinson.
10035
10036         Running Javascriptcore tests through jhbuild
10037         for consistency with run-webkit-tests and in order to
10038         avoid confusing libraries when facing regressions.
10039
10040         * Scripts/run-javascriptcore-tests:
10041
10042 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
10043
10044         test-webkitpy: add --timing
10045         https://bugs.webkit.org/show_bug.cgi?id=82550
10046
10047         Reviewed by Eric Seidel.
10048
10049         This patch adds a --timing option that will display the time
10050         each test takes. It also removes the --silent option, since
10051         probably no one ever used it, and cleans up the logging
10052         option parsing code to be easier to follow.
10053
10054         * Scripts/webkitpy/test/main.py:
10055         (Tester._parse_args):
10056         (Tester._configure):
10057         * Scripts/webkitpy/test/runner.py:
10058         (TestRunner.write_result):
10059         * Scripts/webkitpy/test/runner_unittest.py:
10060         (RunnerTest.test_regular):
10061         (RunnerTest.test_verbose):
10062         (RunnerTest):
10063         (RunnerTest.test_timing):
10064
10065 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
10066
10067         HashMap<>::add should return a more descriptive object
10068         https://bugs.webkit.org/show_bug.cgi?id=71063
10069
10070         Reviewed by Ryosuke Niwa.
10071
10072         Update code to use AddResult instead of a pair.
10073
10074         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
10075         (LayoutTestController::evaluateScriptInIsolatedWorld):
10076         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
10077         (LayoutTestController::evaluateScriptInIsolatedWorld):
10078         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
10079         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
10080
10081 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
10082
10083         Web Inspector: chromium: DRT --no-timeout option doesn't work.
10084         https://bugs.webkit.org/show_bug.cgi?id=82608
10085
10086         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
10087         This was broken by r112354 and the sequence became opposite.
10088
10089         Reviewed by Yury Semikhatsky.
10090
10091         * DumpRenderTree/chromium/TestShell.cpp:
10092         (TestShell::TestShell):
10093         (TestShell::initialize):
10094
10095 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
10096
10097         Remove custom bindings form Internals.idl of attribute type Array.
10098         https://bugs.webkit.org/show_bug.cgi?id=82319
10099
10100         Reviewed by Kentaro Hara.
10101
10102         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
10103
10104         * GNUmakefile.am:
10105
10106 2012-03-28  Mark Rowe  <mrowe@apple.com>
10107
10108         Fix --no-saved-state.
10109
10110         Ignore the flag before Lion, rather than making it specific to Lion.
10111
10112         Rubber-stamped by Dan Bernstein.
10113
10114         * Scripts/webkitdirs.pm:
10115         (argumentsForRunAndDebugMacWebKitApp):
10116
10117 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
10118
10119         Add dtharp to contributors list
10120         https://bugs.webkit.org/show_bug.cgi?id=82545
10121
10122         Reviewed by Adam Barth.
10123
10124         Adding dtharp as Contributor.
10125
10126         * Scripts/webkitpy/common/config/committers.py:
10127
10128 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
10129
10130         build-webkit : the word "pass" is spelled incorrectly as "passs"
10131         https://bugs.webkit.org/show_bug.cgi?id=82532
10132
10133         Reviewed by Julien Chaffraix.
10134
10135         Corrected spelling of the word "pass" in build-webkit.
10136
10137         * Scripts/build-webkit:
10138
10139 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
10140
10141         new-run-webkit-tests doesn't log correctly after retrying failures
10142         https://bugs.webkit.org/show_bug.cgi?id=82541
10143
10144         Unreviewed, build fix.
10145
10146         r112189 introduced a regression where we would accidentally
10147         delete the log handler after we retried any failing tests - that
10148         meant that any log messages around uploading the results got
10149         dropped.
10150
10151         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10152         (Manager._run_tests):
10153
10154 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
10155
10156         [wx] Unreviewed. Build fix, move WTF back into JSCore target
10157         until issues with JSCore not linking in all WTF symbols are resolved.
10158
10159         * waf/build/settings.py:
10160
10161 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
10162
10163         download-built-product build step should detect 404 errors
10164         https://bugs.webkit.org/show_bug.cgi?id=82491
10165
10166         Reviewed by Ryosuke Niwa.
10167
10168         Pass --fail to curl so that it reports 404 errors.
10169
10170         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10171         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
10172         * BuildSlaveSupport/built-product-archive:
10173         (extractBuiltProduct): Remove trailing whitespace.
10174
10175 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
10176
10177         flakiness dashboard should only keep the last 500 runs
10178         https://bugs.webkit.org/show_bug.cgi?id=82530
10179
10180         Reviewed by Ojan Vafai.
10181
10182         If a bot has an overly large amount of failing tests, then
10183         storing 750 runs' worth takes a lot of memory and CPU time to
10184         process and we end up getting killed by AppEngine; this cases
10185         data corruption and confusion down the road when we have to
10186         retry the upload of the data and the tests show up as multiple
10187         runs.
10188
10189         * TestResultServer/model/jsonresults.py:
10190         (JsonResults.update_file):
10191
10192 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
10193
10194         extract-built-product build step should fail if unzipping fails
10195         https://bugs.webkit.org/show_bug.cgi?id=82493
10196
10197         Reviewed by Simon Fraser.
10198
10199         Forward non-zero exit code from subprocesses so that the master can detect any failures
10200         and bail out early.
10201
10202         * BuildSlaveSupport/built-product-archive:
10203         (main):
10204
10205 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
10206
10207         test-webkitpy should support files, directories, and packages as command line args
10208         https://bugs.webkit.org/show_bug.cgi?id=76765
10209
10210         Reviewed by Adam Barth.
10211
10212         This patch adds support for specifying files, directories, and
10213         packages to test-webkitpy along with the already existing
10214         support for modules, test classes, and individual test names.
10215
10216         Also, fix a bug in filesystem_mock where we wouldn't normalize a
10217         path containing a reference to the current directory properly,
10218         for example, '/foo/./bar.py'.
10219
10220         * Scripts/webkitpy/common/system/filesystem_mock.py:
10221         (MockFileSystem.normpath):
10222         * Scripts/webkitpy/test/main.py:
10223         (Tester._configure_logging):
10224         (Tester._run_tests):
10225         * Scripts/webkitpy/test/test_finder.py:
10226         (TestDirectoryTree.find_modules):
10227         (TestDirectoryTree.subpath):
10228         (TestFinder.is_dotted_name):
10229         (TestFinder.find_names):
10230         (TestFinder):
10231         (TestFinder._find_names_for_arg):
10232         (TestFinder._find_in_trees):
10233         (TestFinder._default_names):
10234         * Scripts/webkitpy/test/test_finder_unittest.py:
10235         (TestFinderTest.setUp):
10236         (TestFinderTest.tearDown):
10237         (TestFinderTest.check_names):
10238         (TestFinderTest.test_default_names):
10239         (TestFinderTest):
10240         (TestFinderTest.test_paths):
10241
10242 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
10243
10244         Fix inspector tests when running in internal builds.
10245
10246         <rdar://problem/11050694>
10247
10248         Reviewed by Tim Hatcher.
10249
10250         * DumpRenderTree/mac/DumpRenderTree.mm:
10251         (resetDefaultsToConsistentValues):
10252         * WebKitTestRunner/TestController.cpp:
10253         (WTR::TestController::resetStateToConsistentValues):
10254
10255 2012-03-28  David Kilzer  <ddkilzer@apple.com>
10256
10257         Use xcrun to find nm and ranlib on OS X builds
10258         <http://webkit.org/b/82466>
10259
10260         Reviewed by Dan Bernstein.
10261
10262         * Scripts/build-webkit: Use xcrun to find ranlib.
10263         * Scripts/webkitdirs.pm:
10264         (determineNmPath): Added.  Use xcrun to find nm on OS X.
10265         (nmPath): Added.
10266         * Scripts/webkitperl/features.pm:
10267         (libraryContainsSymbol): Use nmPath().
10268
10269 2012-03-28  Ojan Vafai  <ojan@chromium.org>
10270
10271         Add history navigation to garden-o-matic
10272         https://bugs.webkit.org/show_bug.cgi?id=82495
10273
10274         Reviewed by Dimitri Glazkov.
10275
10276         Also, maintain scroll offsets when returning to a tab. This makes addressing
10277         expected failures considerably easier when dealing with below-the-fold tests.
10278
10279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
10280         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
10281         switching.
10282         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
10283         from a file URL and Chrome puts each different file URL in it's own origin.
10284
10285         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
10286         Remove the href so that clicking on the accordion item does not modify window.location.hash.
10287
10288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
10289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
10290
10291 2012-03-28  Philippe Normand  <pnormand@igalia.com>
10292
10293         [GTK] generate-gtk-doc doesn't cope with custom build directory
10294         https://bugs.webkit.org/show_bug.cgi?id=82448
10295
10296         Reviewed by Martin Robinson.
10297
10298         Pass the product directory in generate-gtkdoc arguments from
10299         build-webkit.
10300
10301         * Scripts/webkitdirs.pm:
10302         (buildAutotoolsProject):
10303         * gtk/common.py:
10304         (get_build_path):
10305
10306 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
10307
10308         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
10309         https://bugs.webkit.org/show_bug.cgi?id=82341
10310
10311         Reviewed by Martin Robinson.
10312
10313         Add --skipped=skip|ignore|only command line option.
10314
10315         * Scripts/run-gtk-tests:
10316         (TestRunner._test_cases_to_skip): Return the list of test cases
10317         to skip for the given test depending on the skipped action.
10318         (TestRunner._should_run_test): Decide whether to run the test or
10319         not depending on the skipped action.
10320         (TestRunner.run_tests): Only show the list of skipped tests when
10321         skipped action is 'skip'.
10322
10323 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
10324
10325         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
10326         https://bugs.webkit.org/show_bug.cgi?id=82333
10327
10328         Reviewed by Martin Robinson.
10329
10330         * Scripts/run-gtk-tests:
10331         (TestRunner.SkippedTest): Add SkippedTest class to store more
10332         information about skipped tests.
10333         (TestRunner._setup_testing_environment): Use SkippedTest to add
10334         TestWebKitAccessibility to the skipped list.
10335         (TestRunner._find_skipped_test): Return the SkippedTest object for
10336         a given test path.
10337         (TestRunner._test_cases_to_skip): Returns the list of test cases
10338         that should be skipped for a given test path.
10339         (TestRunner._should_run_test): Helper funtion to decide whether
10340         the given test path should be run or not. Tests in the skipped
10341         list that don't have a list of failing test cases are not run at
10342         all. Tests in the skipped list that contain a list of test cases
10343         are run with gtester -s to skip the individual test cases.
10344         (TestRunner._run_test): Helper funtion to run a given test.
10345         (TestRunner.run_tests): Build the list of tests to run based on
10346         _should_run_test() and use helper function _run_test() to run
10347         every test.
10348
10349 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
10350
10351         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
10352         https://bugs.webkit.org/show_bug.cgi?id=52810
10353
10354         Reviewed by Simon Hausmann.
10355
10356         Use SSE2 floating point math on 32 bit instead of the default
10357         387 to make layout test result same on 32 and on 64 bit builds.
10358
10359         * qmake/mkspecs/features/unix/default_post.prf:
10360
10361 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
10362
10363         [Soup] DNS prefetching spams resolver, shoots self in the foot
10364         https://bugs.webkit.org/show_bug.cgi?id=41630
10365
10366         Reviewed by Martin Robinson.
10367
10368         Bump libsoup and glib dependencies.
10369
10370         * efl/jhbuild.modules:
10371         * gtk/jhbuild.modules:
10372
10373 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
10374
10375         [GTK] Disable introspection for jhbuild modules
10376         https://bugs.webkit.org/show_bug.cgi?id=82395
10377
10378         Reviewed by Philippe Normand.
10379
10380         * efl/jhbuild.modules: add --disable-introspection to all modules
10381         that support it
10382         * gtk/jhbuild.modules: ditto.
10383
10384 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
10385
10386         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
10387
10388         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10389         (BuildAndTestFactory.__init__):
10390
10391 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
10392
10393         [Qt] Unreviewed typo fix after r112383.
10394
10395         * Scripts/run-qtwebkit-tests:
10396         (Main.check_crash_occurences):
10397
10398 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
10399
10400         [Qt] run-qtwebkit-tests should report crashes
10401         https://bugs.webkit.org/show_bug.cgi?id=76905
10402
10403         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
10404         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
10405
10406         Reviewed by Csaba Osztrogonác.
10407
10408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10409         (RunQtAPITests.commandComplete):
10410         (RunQtAPITests.evaluateCommand):
10411         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
10412         (RunQtAPITestsTest):
10413         (test_failure):
10414         (test_crash):
10415         * Scripts/run-qtwebkit-tests:
10416         (Main.announce_results_html):
10417         (Main):
10418         (Main.check_crash_occurences):
10419         (Main.convert_to_stdout):
10420         (Main.convert_to_html):
10421
10422 2012-03-28  Kwonjin Jeong  <gram@company100.net>
10423
10424         Add support for Intel compiler on Linux QT port.
10425         https://bugs.webkit.org/show_bug.cgi?id=81077
10426
10427         Reviewed by Tor Arne Vestbø.
10428
10429         * qmake/mkspecs/features/default_post.prf:
10430         Don't hide symbols when building with Intel compiler.
10431         The symbols are needed when building QtWebKit tests.
10432
10433         * qmake/mkspecs/features/unix/icc.prf:
10434         Added to ignore icc-specific warnings.
10435         This feature is used with command-line arguments for build-webkit script.
10436
10437 2012-03-28  Philippe Normand  <pnormand@igalia.com>
10438
10439         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
10440
10441         * Scripts/update-webkitgtk-libs: This script is written in
10442         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
10443
10444 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
10445
10446         kill-old-processes doesn't do anything on linux
10447         https://bugs.webkit.org/show_bug.cgi?id=82388
10448
10449         Reviewed by Tony Chang.
10450
10451         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
10452         This should help stabilizing Chromium linux bots.
10453
10454         * BuildSlaveSupport/kill-old-processes:
10455
10456 2012-03-28  Philippe Normand  <pnormand@igalia.com>
10457
10458         [GTK] jhbuild wrongly tricked into clean-up
10459         https://bugs.webkit.org/show_bug.cgi?id=82216
10460
10461         Reviewed by Gustavo Noronha Silva.
10462
10463         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
10464         build tree. Also when checking if the jhbuild configuration
10465         changed use absolute md5sum paths.
10466
10467         * Scripts/webkitdirs.pm:
10468         (runAutogenForAutotoolsProjectIfNecessary):
10469         (jhbuildConfigurationChanged):
10470         (buildAutotoolsProject):
10471
10472 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
10473
10474         kill-old-processes doesn't do anything on linux
10475         https://bugs.webkit.org/show_bug.cgi?id=82388
10476
10477         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
10478
10479         The platform in Factory comes from config.json, accordingly platform is fullplatform,
10480         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
10481
10482         Reviewed by Ryosuke Niwa.
10483
10484         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10485         (Factory.__init__):
10486
10487 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
10488
10489         Make Chromium port for Android use hardware gpu path default.
10490         https://bugs.webkit.org/show_bug.cgi?id=82033
10491
10492         Reviewed by Dirk Pranke.
10493
10494         Skip canvas tests, which are run in virtual gpu test suites.
10495
10496         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10497         (ChromiumAndroidPort.__init__):
10498         (ChromiumAndroidPort.skipped_tests):
10499
10500 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
10501
10502         kill-old-processes doesn't do anything on linux
10503         https://bugs.webkit.org/show_bug.cgi?id=82388
10504
10505         Disable kill-old-processes on the Qt bots not to kill each others.
10506
10507         Reviewed by Ryosuke Niwa.
10508
10509         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
10510         (Factory.__init__):
10511
10512 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
10513
10514         Handle DRT crash caused by Android OOM.
10515         https://bugs.webkit.org/show_bug.cgi?id=82310
10516
10517         Reviewed by Tony Chang.
10518
10519         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
10520         is stopped silently and regarded as crashed. Re-run the test for
10521         such crash.
10522
10523         Add some debug log to NRWT.
10524
10525         * Scripts/webkitpy/layout_tests/port/chromium.py:
10526         (ChromiumDriver.run_test):
10527         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10528         (ChromiumAndroidPort.__init__):
10529         (ChromiumAndroidPort.get_last_stacktrace):
10530         (ChromiumAndroidDriver.__init__):
10531         (ChromiumAndroidDriver._start):
10532         (ChromiumAndroidDriver.run_test):
10533         (ChromiumAndroidDriver._get_drt_return_value):
10534
10535 2012-03-27  Ojan Vafai  <ojan@chromium.org>
10536
10537         Fix expected results for some unittest failures.
10538
10539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
10540
10541 2012-03-27  Adrienne Walker  <enne@google.com>
10542
10543         [chromium] Fix --enabled-threaded-compositing flag in DRT
10544         https://bugs.webkit.org/show_bug.cgi?id=82405
10545
10546         Reviewed by James Robinson.
10547
10548         --enable-threaded-compositing wasn't working because there was no way
10549         to set the value before it was used in the TestShell constructor.
10550
10551         To avoid adding yet another boolean parameter to TestShell's
10552         constructor, add an explicit initialize function that can operate on
10553         any boolean settings that are set post-constructor.
10554
10555         * DumpRenderTree/chromium/DumpRenderTree.cpp:
10556         (main):
10557         * DumpRenderTree/chromium/TestShell.cpp:
10558         (TestShell::TestShell):
10559         (TestShell::initialize):
10560         * DumpRenderTree/chromium/TestShell.h:
10561         (TestShell):
10562         (TestShell::setTestShellMode):
10563
10564 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
10565
10566         new-run-webkit-tests: suppress debug output from run-safari on results file
10567         https://bugs.webkit.org/show_bug.cgi?id=82400
10568
10569         Reviewed by Ryosuke Niwa.
10570
10571         Send the run-safari output to /dev/null rather than the console.
10572
10573         * Scripts/webkitpy/layout_tests/port/mac.py:
10574         (MacPort.show_results_html_file):
10575
10576 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
10577
10578         Improve error reporting in run-javascriptcore-tests
10579         https://bugs.webkit.org/show_bug.cgi?id=82379
10580
10581         Reviewed by Jessie Berlin.
10582
10583         When the script dies, have it print out the reason for dying.
10584
10585         * Scripts/run-javascriptcore-tests:
10586
10587 2012-03-27  Eric Seidel  <eric@webkit.org>
10588
10589         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
10590         https://bugs.webkit.org/show_bug.cgi?id=82373
10591
10592         Reviewed by Ryosuke Niwa.
10593
10594         Dave's committer-status in in-progress, so until then
10595         list him as a Contributor so at least I can more easily CC him on bugs.
10596
10597         * Scripts/webkitpy/common/config/committers.py:
10598
10599 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
10600
10601         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
10602         https://bugs.webkit.org/show_bug.cgi?id=82252
10603
10604         Reviewed by Gustavo Noronha Silva.
10605
10606         Appending the directory containing common.py may be problematic if
10607         another path in sys.path also contains either a common.py or a
10608         common/ module, so prepend to select our version instead. This is
10609         the case with fail2ban, which has a common/ directory which may
10610         end up being in Python's default path.
10611
10612         * efl/jhbuildrc:
10613         * gtk/jhbuildrc:
10614
10615 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
10616
10617         test-webkitpy: prepare for better test run output
10618         https://bugs.webkit.org/show_bug.cgi?id=82290
10619
10620         Reviewed by Adam Barth.
10621
10622         This code basically re-implements the output of the TextTestRunner default
10623         runner code from unittest, although the implementation is quite
10624         different, in preparation for changing the test output to be
10625         metered and possibly running in parallel.
10626
10627         The output is almost identical to before, except that instead of
10628         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
10629         "webkitpy.main.RunnerTest.test_regular passed". It has always
10630         annoyed me that they invert the names to be harder to read and
10631         so that you can't copy & paste back to the input for
10632         test-webkitpy.
10633
10634         This patch is provided to add a skeleton for unit tests and for
10635         comparison to an upcoming patch that will actually add new
10636         functionality.
10637
10638         * Scripts/webkitpy/test/main.py:
10639         (Tester.__init__):
10640         (Tester._configure_logging):
10641         (Tester._run_tests):
10642         * Scripts/webkitpy/test/runner.py: Added.
10643         (TestRunner):
10644         (TestRunner.__init__):
10645         (TestRunner.test_name):
10646         (TestRunner.all_test_names):
10647         (TestRunner.run):
10648         (TestRunner.write_result):
10649         (TestRunner.write_summary):
10650         * Scripts/webkitpy/test/runner_unittest.py: Added.
10651         (FakeModuleSuite):
10652         (FakeModuleSuite.__init__):
10653         (FakeModuleSuite.__str__):
10654         (FakeModuleSuite.run):
10655         (FakeTopSuite):
10656         (FakeTopSuite.__init__):
10657         (FakeLoader):
10658         (FakeLoader.__init__):
10659         (FakeLoader.top_suite):
10660         (FakeLoader.loadTestsFromName):
10661         (RunnerTest):
10662         (RunnerTest.test_regular):
10663         (RunnerTest.test_verbose):
10664
10665 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
10666
10667         [GTK] Build gnutls without p11-kit support
10668         https://bugs.webkit.org/show_bug.cgi?id=82212
10669
10670         Reviewed by Martin Robinson.
10671
10672         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
10673         configure, to avoid requiring that dependency, which is not used
10674         by libsoup and WebKit anyway
10675
10676 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
10677
10678         [Qt] Make debug build work on 32 bit
10679         https://bugs.webkit.org/show_bug.cgi?id=82331
10680
10681         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
10682         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
10683
10684         Reviewed by Tor Arne Vestbø.
10685
10686         * qmake/mkspecs/features/unix/default_post.prf:
10687         * qmake/mkspecs/features/unix/default_pre.prf:
10688
10689 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
10690
10691         Add png checking to check-webkit-style
10692         https://bugs.webkit.org/show_bug.cgi?id=75824
10693
10694         Reviewed by NOBODY Tony Chang.
10695
10696         * Scripts/webkitpy/style/checker.py:
10697         (_all_categories):
10698         (FileType):
10699         (CheckerDispatcher._should_skip_file_path):
10700         (CheckerDispatcher._file_type):
10701         (CheckerDispatcher._create_checker):
10702         * Scripts/webkitpy/style/checker_unittest.py:
10703         (CheckerDispatcherDispatchTest.test_none_paths):
10704         * Scripts/webkitpy/style/checkers/png.py: Added.
10705         (PNGChecker):
10706         (PNGChecker.__init__):
10707         (PNGChecker.check):
10708         (PNGChecker._config_file_path):
10709         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
10710         (MockSCMDetector):
10711         (MockSCMDetector.__init__):
10712         (MockSCMDetector.display_name):
10713         (MockSCMDetector.propget):
10714         (PNGCheckerTest):
10715         (PNGCheckerTest.test_init):
10716         (PNGCheckerTest.test_init.mock_handle_style_error):
10717         (PNGCheckerTest.test_check):
10718         (PNGCheckerTest.test_check.mock_handle_style_error):
10719         * Scripts/webkitpy/style/patchreader.py:
10720         (PatchReader.check):
10721
10722 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
10723
10724         Unreviewed. Skip GTK+ unit tests that fail in the bots
10725
10726         * Scripts/run-gtk-tests:
10727         (TestRunner): Add failing tests to the skipped list.
10728
10729 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
10730
10731         Unreviewed. Unskip all GTK+ unit test.
10732
10733         Currently, skipped tests contains the list of unit tests that have
10734         failed in one or more bots. In this moment it's not possible to
10735         skip just the test cases that fail, so the complete unit test is
10736         skipped when a single test case fails. For that reason, we don't
10737         know which test cases are actually failing for every skipped
10738         test. We are planning to land a patch to allow skipping individual
10739         test cases, but first we need to know which test cases are
10740         currently failing in the bots to skip them. So, this patch simply
10741         unskips all unit tests in order to watch the bots and get the list
10742         of test cases failing. Failing tests will be skipped again as soon
10743         as we have the new list of failing test cases.
10744
10745         * Scripts/run-gtk-tests:
10746         (TestRunner): Reset the list of skipped tests.
10747
10748 2012-03-26  Scott Byer  <scottbyer@chromium.org>
10749
10750         Enable layout testing of the scroll animator.
10751         https://bugs.webkit.org/show_bug.cgi?id=81858
10752         Add a call to the InternalSettings that layout tests can use to
10753         turn on scroll animation. Enable animation updates for the
10754         Chromium platform DRT when scroll animation has been turned on in
10755         a test. This should be a no-op for all current layout tests.
10756
10757         Reviewed by James Robinson.
10758
10759         * DumpRenderTree/chromium/WebViewHost.cpp:
10760         (WebViewHost::serviceAnimation):
10761         (WebViewHost::scheduleAnimation):
10762         * DumpRenderTree/chromium/WebViewHost.h:
10763         (WebViewHost):
10764
10765 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
10766
10767         [Qt][WK2] Support multi-file upload
10768         https://bugs.webkit.org/show_bug.cgi?id=81589
10769
10770         Reviewed by Simon Hausmann.
10771
10772         Modified filePicker to support multi-file upload.
10773
10774         * MiniBrowser/qt/MiniBrowser.qrc:
10775         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
10776         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
10777         * MiniBrowser/qt/js/MultiSelect.js: Added.
10778         (values):
10779         (isSelected):
10780         (removeValue):
10781         * MiniBrowser/qt/qml/CheckBox.qml: Added.
10782         * MiniBrowser/qt/qml/FilePicker.qml:
10783
10784 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
10785
10786         Retry crashing tests serially at the end of NRWT on Apple Mac
10787         https://bugs.webkit.org/show_bug.cgi?id=82233
10788
10789         Reviewed by Dirk Pranke.
10790
10791         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10792         (Manager.run):
10793         * Scripts/webkitpy/layout_tests/port/base.py:
10794         (Port.should_retry_crashes):
10795         * Scripts/webkitpy/layout_tests/port/mac.py:
10796         (MacPort.should_retry_crashes):
10797
10798 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
10799
10800         NRWT should retry failures serially
10801         https://bugs.webkit.org/show_bug.cgi?id=82241
10802
10803         Reviewed by Dirk Pranke.
10804
10805         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10806         (Manager._run_tests): Add another parameter to specify the number of workers to use.
10807         (Manager.run): Run the failures serially.
10808
10809 2012-03-26  Adrienne Walker  <enne@google.com>
10810
10811         Allow expectations on directories in virtual test suites
10812         https://bugs.webkit.org/show_bug.cgi?id=82250
10813
10814         Reviewed by Dirk Pranke.
10815
10816         lookup_virtual_test_base was only returning valid results for files
10817         and not directories. Fix by falling back to the virtual test suite
10818         mapping if possible.
10819
10820         * Scripts/webkitpy/layout_tests/port/base.py:
10821         (Port.lookup_virtual_test_base):
10822         * Scripts/webkitpy/layout_tests/port/test.py:
10823         (TestPort.skipped_tests):
10824         (TestPort.virtual_test_suites):
10825
10826 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
10827
10828         Fix duplicated ChangeLog entry from r112171.
10829
10830         Unreviewed, build fix.
10831
10832 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
10833
10834         nrwt: remove --worker-model flag
10835         https://bugs.webkit.org/show_bug.cgi?id=82112
10836
10837         Reviewed by Adam Barth.
10838
10839         The --worker-model=inline flag is basically redundant with the
10840         --child-processes=1 flag (technically, you could one run child
10841         process, but this is only useful for testing); this patch
10842         removes this flag, which simplifies things and enables more
10843         cleanup down the road.
10844
10845         * Scripts/webkitpy/layout_tests/controllers/manager.py:
10846         (Manager._run_tests):
10847         (Manager.print_config):
10848         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
10849         (get):
10850         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
10851         (make_broker):
10852         (FunctionTests.test_get__inline):
10853         (FunctionTests.test_get__processes):
10854         (_TestsMixin.setUp):
10855         (_TestsMixin.make_broker):
10856         (InlineBrokerTests.setUp):
10857         (MultiProcessBrokerTests.setUp):
10858         * Scripts/webkitpy/layout_tests/port/base.py:
10859         (Port.default_child_processes):
10860         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
10861         (ChromiumAndroidPort.check_sys_deps):
10862         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
10863         (ChromiumAndroidPortTest):
10864         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
10865         (MockDRTPortTest.make_port):
10866         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
10867         (PortTestCase):
10868         (PortTestCase.make_port):
10869         * Scripts/webkitpy/layout_tests/port/test.py:
10870         (TestPort.default_child_processes):
10871         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
10872         (_set_up_derived_options):
10873         (parse_args):
10874         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
10875         (parse_args):
10876         (MainTest.test_batch_size):
10877         (MainTest.test_child_processes_2):
10878         (MainTest.test_child_processes_min):
10879         (MainTest.test_exception_raised):
10880         (MainTest.test_keyboard_interrupt):
10881         (MainTest.test_exit_after_n_crashes):
10882         (MainTest.assert_run_order):
10883         (MainTest.test_run_order__inline):
10884         (MainTest.test_virtual):
10885
10886 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
10887
10888         test-webkitpy: split test-finding code into a different module
10889         https://bugs.webkit.org/show_bug.cgi?id=82253
10890
10891         Reviewed by Adam Barth.
10892
10893         Per suggestion from abarth, this change splits all the
10894         filesystem-crawling, test-finding code in test-webkitpy out into
10895         a separate module and switches to using a FileSystem object.
10896         This makes things much more testable, so we also add tests :).
10897
10898         We also add a realpath() method to the Filesystem object, since
10899         test-webkitpy needs that in order to be able to resolve symlinks
10900         properly to determine whether a file is under a particular tree
10901         or not.
10902
10903         * Scripts/webkitpy/common/system/filesystem.py:
10904         (FileSystem.realpath):
10905         * Scripts/webkitpy/common/system/filesystem_mock.py:
10906         (MockFileSystem.realpath):
10907         * Scripts/webkitpy/test/main.py:
10908         (Tester.__init__):
10909         (Tester.add_tree):
10910         (Tester.run):
10911         (Tester._run_tests):
10912         (Tester._log_exception):
10913         * Scripts/webkitpy/test/test_finder.py: Added.
10914         (TestDirectoryTree):
10915         (TestDirectoryTree.__init__):
10916         (TestDirectoryTree.find_modules):
10917         (TestDirectoryTree.find_modules.file_filter):
10918         (TestDirectoryTree.to_module):
10919         (TestDirectoryTree.clean):
10920         (TestFinder):
10921         (TestFinder.__init__):
10922         (TestFinder.add_tree):
10923         (TestFinder.additional_paths):
10924         (TestFinder.clean_trees):
10925         (TestFinder.is_module):
10926         (TestFinder.to_module):
10927         (TestFinder.find_names):
10928         (TestFinder._exclude):
10929         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
10930         (TestFinderTest):
10931         (TestFinderTest.setUp):
10932         (TestFinderTest.tearDown):
10933         (TestFinderTest.test_additional_system_paths):
10934         (TestFinderTest.test_is_module):
10935         (TestFinderTest.test_to_module):
10936         (TestFinderTest.test_clean):
10937         (TestFinderTest.test_find_names):
10938
10939 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
10940
10941         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
10942         https://bugs.webkit.org/show_bug.cgi?id=82209
10943
10944         Reviewed by Martin Robinson.
10945
10946         Respecting the $MAKE environment variable when it is defined makes
10947         building jhbuild more portable, as some platforms may have GNU
10948         make as gmake, for example.
10949
10950         * jhbuild/jhbuild-wrapper:
10951         (install_jhbuild):
10952
10953 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
10954
10955         add a Tree abstraction to test-webkitpy to better encapsulate things
10956         https://bugs.webkit.org/show_bug.cgi?id=82158
10957
10958         Reviewed by Adam Barth.
10959
10960         There are no functional changes in this patch, but adding a
10961         basic abstraction for the trees we are looking in for python
10962         tests will allow me to add some features later on more easily
10963         (like ignoring certain directories like webkitpy/thirdparty),
10964         and it makes things slightly less hard-coded.
10965
10966         * Scripts/test-webkitpy:
10967         * Scripts/webkitpy/test/main.py:
10968         (Tester.__init__):
10969         (Tester):
10970         (Tester.add_tree):
10971         (Tester._parse_args):
10972         (Tester._configure):
10973         (Tester.run):
10974         (Tester._find_modules):
10975         (Tester._run_tests):
10976         (Tester._is_module):
10977         (Tester._log_exception):
10978         (TestDirectoryTree):
10979         (TestDirectoryTree.__init__):
10980         (TestDirectoryTree.find_modules):
10981         (TestDirectoryTree.clean):
10982
10983 2012-03-26  Ojan Vafai  <ojan@chromium.org>
10984
10985         garden-o-matic should special case reftests
10986         https://bugs.webkit.org/show_bug.cgi?id=81812
10987
10988         Reviewed by Adam Barth.
10989
10990         On the examine page, don't show a rebaseline button for reftests.
10991         We still show it on the failure summary page because tests are grouped
10992         together. Long-term, we should make sure webkit-patch rebaseline-test
10993         never tries to rebaseline reftests.
10994
10995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
10996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
10997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
10998
10999 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
11000
11001         clean up NRWT logging/metering, be less verbose
11002         https://bugs.webkit.org/show_bug.cgi?id=73846
11003
11004         Reviewed by Ojan Vafai.
11005
11006         Re-land r112014 with a build fix for Python 2.6 compatibility.
11007
11008         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
11009         (ManagerTest.test_http_locking):
11010         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
11011         (AbstractWorker.run):
11012         * Scripts/webkitpy/layout_tests/controllers/worker.py:
11013         (Worker.__init__):
11014         (Worker._set_up_logging):
11015         (Worker):
11016         (Worker._set_up_host_and_port):
11017         (Worker.run):
11018         (Worker.cleanup):
11019         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
11020         (WorkerTest.test_default_platform_in_worker):
11021         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11022         (run):
11023         (main):
11024         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
11025         (MeteredStream):
11026         (MeteredStream.implements):
11027         (MeteredStream._erasure):
11028         (MeteredStream._ensure_newline):
11029         (MeteredStream.__init__):
11030         (MeteredStream.__del__):
11031         (MeteredStream.cleanup):
11032         (MeteredStream.write_throttled_update):
11033         (MeteredStream.write_update):
11034         (MeteredStream.write):
11035         (MeteredStream.writeln):
11036         (MeteredStream._erase_last_partial_line):
11037         (_LogHandler):
11038         (_LogHandler.__init__):
11039         (_LogHandler.emit):
11040         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
11041         (RegularTest):
11042         (RegularTest.setUp):
11043         (RegularTest.tearDown):
11044         (RegularTest.time_fn):
11045         (RegularTest.test_logging_not_included):
11046         (RegularTest._basic):
11047         (RegularTest.test_basic):
11048         (RegularTest._log_after_update):
11049         (RegularTest.test_log_after_update):
11050         (TtyTest):
11051         (TtyTest.test_basic):
11052         (TtyTest.test_log_after_update):
11053         (VerboseTest):
11054         (VerboseTest.test_basic):
11055         (VerboseTest.test_log_after_update):
11056         * Scripts/webkitpy/layout_tests/views/printing.py:
11057         (parse_print_options):
11058         (Printer.__init__):
11059         (Printer.cleanup):
11060         (Printer.print_progress):
11061         (Printer.print_update):
11062         (Printer._write):
11063         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
11064         (Testprinter.get_printer):
11065         (Testprinter.test_print_progress):
11066         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11067         (PerfTestsRunner.__init__):
11068         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
11069         (test_run_test_pause_before_testing):
11070
11071 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
11072
11073         [jhbuild] Revert $MAKE environment hack introduced in r101929.
11074         https://bugs.webkit.org/show_bug.cgi?id=82234
11075
11076         Reviewed by Martin Robinson.
11077
11078         The problem it was supposedly fixing was fixed in jhbuild itself
11079         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
11080         can remove the workaround added to the script.
11081
11082         * jhbuild/jhbuild-wrapper:
11083         (install_jhbuild):
11084
11085 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
11086
11087         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
11088         https://bugs.webkit.org/show_bug.cgi?id=82157
11089
11090         Reviewed by Rob Buis.
11091
11092         * Scripts/build-webkit:
11093         Make ENABLE_FILE_SYSTEM default on for blackberry.
11094
11095 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
11096
11097         [jhbuild] Explicitly disable DTrace when building glib.
11098         https://bugs.webkit.org/show_bug.cgi?id=82145
11099
11100         Reviewed by Gustavo Noronha Silva.
11101
11102         DTrace support is not really needed by WebKit, so disabling it
11103         helps avoid some build errors on more exotic platforms (such as
11104         FreeBSD).
11105
11106         * efl/jhbuild.modules:
11107         * gtk/jhbuild.modules:
11108
11109 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
11110
11111         Unreviewed, rolling out r111993.
11112         http://trac.webkit.org/changeset/111993
11113         https://bugs.webkit.org/show_bug.cgi?id=82184
11114
11115         It broke layout and API tests and made WTR crash (Requested by
11116         Ossy on #webkit).
11117
11118         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
11119         (WTR::PlatformWebView::PlatformWebView):
11120
11121 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
11122
11123         [wx] Unreviewed build fix. Move WTF to its own static lib build.
11124
11125         * waf/build/settings.py:
11126         (common_configure):
11127
11128 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
11129
11130         AX: Support solution to handle invalid ax text marker
11131         https://bugs.webkit.org/show_bug.cgi?id=82023
11132
11133         Reviewed by Oliver Hunt.
11134
11135         * DumpRenderTree/AccessibilityUIElement.cpp:
11136         (indexForTextMarkerCallback):
11137         (isTextMarkerValidCallback):
11138         (textMarkerForIndexCallback):
11139         (AccessibilityUIElement::indexForTextMarker):
11140         (AccessibilityUIElement::isTextMarkerValid):
11141         (AccessibilityUIElement::textMarkerForIndex):
11142         (AccessibilityUIElement::getJSClass):
11143         * DumpRenderTree/AccessibilityUIElement.h:
11144         (AccessibilityUIElement):
11145         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
11146         (AccessibilityUIElement::indexForTextMarker):
11147         (AccessibilityUIElement::textMarkerForIndex):
11148         (AccessibilityUIElement::isTextMarkerValid):
11149         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
11150         (WTR::AccessibilityUIElement::indexForTextMarker):
11151         (WTR::AccessibilityUIElement::isTextMarkerValid):
11152         (WTR::AccessibilityUIElement::textMarkerForIndex):
11153         (WTR):
11154         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
11155         (AccessibilityUIElement):
11156         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
11157         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
11158         (WTR):
11159         (WTR::AccessibilityUIElement::indexForTextMarker):
11160         (WTR::AccessibilityUIElement::isTextMarkerValid):
11161         (WTR::AccessibilityUIElement::textMarkerForIndex):
11162
11163 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
11164
11165         Unreviewed, rolling out r112014.
11166         http://trac.webkit.org/changeset/112014
11167         https://bugs.webkit.org/show_bug.cgi?id=82138
11168
11169         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
11170         #webkit).
11171
11172         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
11173         (ManagerTest.test_http_locking):
11174         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
11175         (AbstractWorker.run):
11176         * Scripts/webkitpy/layout_tests/controllers/worker.py:
11177         (Worker.__init__):
11178         (Worker.safe_init):
11179         (Worker.run):
11180         (Worker.cleanup):
11181         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
11182         (WorkerTest.test_default_platform_in_worker):
11183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11184         (run):
11185         (main):
11186         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
11187         (MeteredStream):
11188         (MeteredStream.is):
11189         (MeteredStream.__init__):
11190         (MeteredStream.write):
11191         (MeteredStream.update):
11192         (MeteredStream._overwrite):
11193         (MeteredStream._reset):
11194         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
11195         (TestMeteredStream):
11196         (TestMeteredStream.test_regular):
11197         * Scripts/webkitpy/layout_tests/views/printing.py:
11198         (_configure_logging):
11199         (_restore_logging):
11200         (Printer.__init__):
11201         (Printer.cleanup):
11202         (Printer.print_progress):
11203         (Printer.print_update):
11204         (Printer._write):
11205         (Printer):
11206         (Printer._update):
11207         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
11208         (TestUtilityFunctions.assertEmpty):
11209         (TestUtilityFunctions):
11210         (TestUtilityFunctions.assertNotEmpty):
11211         (TestUtilityFunctions.assertWritten):
11212         (TestUtilityFunctions.test_configure_logging):
11213         (Testprinter.get_printer):
11214         (Testprinter.test_print_progress):
11215         (Testprinter.test_print_progress.mock_time):
11216         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11217         (PerfTestsRunner.__init__):
11218         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
11219         (test_run_test_pause_before_testing):
11220
11221 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
11222
11223         [wx] Unreviewed. Fix the build after WTF move.
11224
11225         * waf/build/build_utils.py:
11226         (get_excludes):
11227         (get_excludes_in_dirs):
11228         * waf/build/settings.py:
11229         (get_port_excludes):
11230         (common_configure):
11231
11232 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
11233
11234         clean up NRWT logging/metering, be less verbose
11235         https://bugs.webkit.org/show_bug.cgi?id=73846
11236
11237         Reviewed by Ojan Vafai.
11238
11239         This patch totally rewrites the metered_stream module and
11240         changes the way it and the printing module now interact with the
11241         logging subsystem.
11242
11243         The printing module becomes a dumb layout_tests-specific wrapper around
11244         the metered stream. All of the intelligence of how and when to
11245         actually write (or erase) lines and how things interact with
11246         logging moves into the metered stream.
11247
11248         As of now, anything written to the metered stream *bypasses the
11249         logging system*. If a logger is passed to the meter constructor,
11250         the metered stream will also attach a log handler so that all
11251         messages fed to the logger will also be written to the metered
11252         stream. This detangles the logic that used to exist where
11253         sometimes the meter would write to the logger and sometimes the
11254         logger would write to the meter.
11255
11256         All of this makes the logic generic and reusable for
11257         test-webkitpy (coming in another patch). It also helps clarify
11258         what the mysterious "configure_logging" parameter to the printer
11259         constructor used to do (that parameter itself is gone now, and
11260         by default the printer and metered_stream will not ever touch
11261         the logging system; this makes a bunch of tests less fragile).
11262
11263         All of the above should produce no user-visible changes.
11264
11265         However, to also fix the bug in question, we change the message
11266         format in --verbose mode to %H:%M:%S.%frac %pid %message,
11267         eliminating the date, file:lineno, and level parameters. I am
11268         making this change at the same time because it would be
11269         difficult to write things consistently between the logs and the
11270         metered stream if we were still logging the file:lineno.
11271
11272         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
11273           Remove the configure_logging parameter
11274         * Scripts/webkitpy/layout_tests/controllers/worker.py:
11275           Use metered stream to configure the logging (we don't need a printer)
11276           and be careful about when and how we manipulate the log level
11277           and handlers on the root logger.
11278         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11279           Pass in the root logger so that log messages are formatted
11280           properly, and set the log level outside of any routines called
11281           by unit tests so as to not interfere.
11282         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
11283           remove a duplicate log message.
11284         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
11285           complete rewrite :).
11286         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
11287           complete rewrite :).
11288         * Scripts/webkitpy/layout_tests/views/printing.py:
11289           move the logging configuration into metered_stream, and also
11290           move the "when should I log progress messages" into metered stream.
11291         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
11292           remove tests that are no longer necessary.
11293         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11294           remove the configure_logging parameter.
11295         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
11296           update the test; since the printer no longer writes to the log,
11297           we need to check what is written to the regular_output instead.
11298           (test_run_test_pause_before_testing):
11299
11300 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
11301
11302         Add myself and Martin Robinson to:
11303           * GStreamerGraphics
11304           * GtkWebKit2PublicAPI
11305           * SoupNetwork
11306         and to the newly created WebKitGTKTranslations.
11307
11308         Rubber-stamped by Martin Robinson.
11309
11310         * Scripts/webkitpy/common/config/watchlist:
11311
11312 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
11313
11314         [Qt][WK2] Implement PageClient::isViewWindowActive()
11315         https://bugs.webkit.org/show_bug.cgi?id=81143
11316
11317         Reviewed by Kenneth Rohde Christiansen.
11318
11319         Fix the WrapperWindow from our PlatformWebView
11320         so it correctly creates the platform related
11321         stuff for QWindow, which is not created unless
11322         QWindow::setVisible() or QWindow::show() are called.
11323
11324         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
11325         (WTR::PlatformWebView::PlatformWebView):
11326
11327 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
11328
11329         nrwt: don't wait for safari to exit before exiting after showing the results file
11330         https://bugs.webkit.org/show_bug.cgi?id=81845
11331
11332         Reviewed by Ryosuke Niwa.
11333
11334         Prior to this change, if you ran new-run-webkit-tests and
11335         displayed the HTML results file at the end, we would block
11336         waiting for the user to quit the browser. There doesn't seem to
11337         be a need for that, and the Chromium ports don't do this.
11338
11339         Also, update the mac tests to capture the output and be quiet :).
11340
11341         * Scripts/webkitpy/common/system/executive_mock.py:
11342           Make popen() testable, implement should_log for it.
11343         * Scripts/webkitpy/layout_tests/port/mac.py:
11344         (MacPort.show_results_html_file):
11345         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
11346           Silence some of the tests via outputcapture.
11347
11348 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
11349
11350         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
11351         https://bugs.webkit.org/show_bug.cgi?id=82073
11352
11353         Reviewed by Martin Robinson.
11354
11355         * Scripts/webkitdirs.pm:
11356         (jhbuildConfigurationChanged): new function that isolates the
11357         jhbuild configuration change checking from the autogen logic.
11358         (mustReRunAutogen): code for the new function lived here.
11359         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
11360         itself, and cleans up the jhbuild root if configuration has
11361         changed; it also forces autogen to be run in that case, to
11362         make sure the new libraries are used.
11363         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
11364         * jhbuild/jhbuild-wrapper:
11365         (ensure_jhbuild): this might be run inside a jhbuild environment,
11366         in which case aclocal fails when trying to use the now deleted
11367         aclocal directory in the jhbuild prefix, so work around that.
11368
11369 2012-03-23  Ojan Vafai  <ojan@chromium.org>
11370
11371         garden-o-matic scrolls to the top of the page when you click an accordion item
11372         https://bugs.webkit.org/show_bug.cgi?id=82088
11373
11374         Reviewed by Adam Barth.
11375
11376         Check the scroll position and make sure that the clicked accordion item is visible.
11377
11378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
11379
11380 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
11381
11382         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
11383         https://bugs.webkit.org/show_bug.cgi?id=80567
11384
11385         Reviewed by Ryosuke Niwa.
11386
11387         Move clean_up_run to occur right after we finish testing and
11388         before we start processing the results. Also makes set_up_run()
11389         and clean_up_run() private since there's no real need for
11390         callers to be aware of them.
11391
11392         * Scripts/webkitpy/layout_tests/controllers/manager.py:
11393         (Manager._set_up_run):
11394         (Manager.run):
11395         (Manager._clean_up_run):
11396         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
11397         (ManagerTest.test_http_locking):
11398         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
11399         (run):
11400
11401 2012-03-23  Dean Jackson  <dino@apple.com>
11402
11403         Disable CSS_SHADERS in Apple builds
11404         https://bugs.webkit.org/show_bug.cgi?id=81996
11405
11406         Reviewed by Simon Fraser.
11407
11408         Default enableCSSShaders to be 0 on all builds that use
11409         this script. Use the flag to turn it back on.
11410
11411         * Scripts/build-webkit:
11412
11413 2012-03-23  Tony Chang  <tony@chromium.org>
11414
11415         [chromium] rename newwtf target back to wtf
11416         https://bugs.webkit.org/show_bug.cgi?id=82064
11417
11418         Reviewed by Adam Barth.
11419
11420         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11421
11422 2012-03-23  Jessie Berlin  <jberlin@apple.com>
11423
11424         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
11425         the Lion Intel WebKit2 Debug bots.
11426         https://bugs.webkit.org/show_bug.cgi?id=81012.
11427
11428         Rubber-stamped by Dan Bernstein.
11429
11430         Add a step to kill the pasteboard server while we investigate what is causing these
11431         assertion failures (to get the bots green).
11432
11433         * BuildSlaveSupport/kill-old-processes:
11434
11435 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
11436
11437         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
11438         https://bugs.webkit.org/show_bug.cgi?id=81986
11439
11440         Reviewed by David Levin.
11441
11442         Track whether or not errors are filtered in error handlers. If an
11443         alphabetical sorting error is reported for a header and filtered, try
11444         reporting it for the other potential source of the error. This ensures
11445         that the style bot can still find new sorting errors in both potential
11446         situations:
11447
11448             #include <foo.h> <-- 1. edited line
11449             #include <baz.h> <-- 2. edited line
11450
11451         * Scripts/webkitpy/style/checkers/cpp.py:
11452         (check_include_line): Potentially report the error for both lines,
11453         if the first error is filtered.
11454         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
11455         test that allows only reporting errors for certain lines. This verifies that
11456         when one line of an ordering error is filtered, the error is reported on the
11457         other line.
11458         (ErrorCollector.__init__):
11459         (ErrorCollector.__call__):
11460         (CppStyleTestBase.perform_lint):
11461         (CppStyleTestBase.perform_language_rules_check):
11462         (CppStyleTestBase.assert_language_rules_check):
11463         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
11464         Added a new test that verifies that when one line of the two lines of an ordering
11465         error occur, the error is reported on the other line.
11466         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
11467         (MockErrorHandler.__call__): Report True because the error is handled.
11468         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
11469         (ErrorCollector.__call__): Ditto.
11470         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
11471         (MockErrorHandler.__call__): Ditto.
11472         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
11473         (TestErrorHandler.__call__): Ditto.
11474         * Scripts/webkitpy/style/checkers/xml_unittest.py:
11475         (MockErrorHandler.__call__): Ditto.
11476         * Scripts/webkitpy/style/error_handlers.py:
11477         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
11478         and False if it is filtered.
11479
11480 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
11481
11482         Build fix for WinCE after r111778.
11483
11484         * WinCELauncher/CMakeLists.txt:
11485
11486 2012-03-23  Peter Beverloo  <peter@chromium.org>
11487
11488         Unreviewed buildfix for the Chromium Android builder.
11489
11490         Disable the ImageDiff target for now. Android needs to build this for
11491         host rather than for target (as other configurations do), but since the
11492         WTF move the dependency chain got significantly more complicated.
11493
11494         I'll work out a proper fix in the following bug, but since several
11495         things are broken due to this, this buildfix should be landed first.
11496         https://bugs.webkit.org/show_bug.cgi?id=82039
11497
11498         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11499
11500 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
11501
11502         [EFL][DRT] Implement LayoutTestController's methods related with editing.
11503         https://bugs.webkit.org/show_bug.cgi?id=80136
11504
11505         Reviewed by Ryosuke Niwa.
11506
11507         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
11508         setSelectTrailingWhitespaceEnabled.
11509
11510         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11511         (LayoutTestController::setSmartInsertDeleteEnabled):
11512         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
11513
11514 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
11515
11516         Convert hasGrammarMarker to use Internals interface
11517         https://bugs.webkit.org/show_bug.cgi?id=82004
11518
11519         Reviewed by Ryosuke Niwa.
11520
11521         Remove hasGrammarMarker functions, because it is able to work in the
11522         cross-port way through the Internals interface.
11523
11524         * DumpRenderTree/LayoutTestController.cpp:
11525         (LayoutTestController::staticFunctions):
11526         * DumpRenderTree/LayoutTestController.h:
11527         (LayoutTestController):
11528         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
11529         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
11531         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
11532         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
11533         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
11534
11535 2012-03-22  Adam Barth  <abarth@webkit.org>
11536
11537         sync-master-with-upstream creates non-linear git history
11538         https://bugs.webkit.org/show_bug.cgi?id=82006
11539
11540         Reviewed by Julien Chaffraix.
11541
11542         Previously this script would create a merge commit at the HEAD of
11543         origin/master, causing your fork of WebKit to diverge from upstream.
11544         The new version of this script pushes directly from upstream to origin
11545         (without round-tripping through any local branches), avoiding this
11546         problem.
11547
11548         * Scripts/sync-master-with-upstream:
11549
11550 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
11551
11552         Unreviewed build fix. Add knowledge of the WTF project to
11553         the autotools build system scripts so that build-jsc works
11554         correctly for GTK+.
11555
11556         * Scripts/webkitdirs.pm:
11557         (buildAutotoolsProject): handle the WTF project, build the
11558         libWTF.la target.
11559         (buildGtkProject): add WTF to the list of supported projects.
11560
11561 2012-03-22  Eric Seidel  <eric@webkit.org>
11562
11563         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
11564         https://bugs.webkit.org/show_bug.cgi?id=81984
11565
11566         Reviewed by Adam Barth.
11567
11568         * Scripts/VCSUtils.pm:
11569         (adjustPathForRecentRenamings):
11570
11571 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
11572
11573         [CMake] Fix build-jsc after r111778 and r111797.
11574         https://bugs.webkit.org/show_bug.cgi?id=82001
11575
11576         Reviewed by Filip Pizlo.
11577
11578         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
11579         does return if no error occurred, and build-jsc failed with
11580         "building not defined for this platform".
11581
11582         * Scripts/build-jsc: Always exit after caling
11583         buildCMakeProjectOrExit().
11584         * Scripts/webkitdirs.pm:
11585         (buildCMakeProjectOrExit): Return 0 if no error occurred.
11586
11587 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
11588
11589         [CMake] Unreviewed build fix after r111778.
11590
11591         * DumpRenderTree/efl/CMakeLists.txt: Replace
11592         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
11593         paths.
11594         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
11595         wtf include.
11596         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
11597         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
11598         with ${WTF_DIR}/wtf in the include paths.
11599
11600 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
11601
11602         Tools/Scripts/build-jsc doesn't work after WTF move
11603         https://bugs.webkit.org/show_bug.cgi?id=81999
11604
11605         Reviewed by Eric Seidel.
11606
11607         For ports that require WTF and JSC to be built as two projects and where
11608         the machinery to build both does not already exist, teach the tool to do
11609         so for us.
11610
11611         * Scripts/build-jsc:
11612         (buildMyProject):
11613
11614 2012-03-22  Ojan Vafai  <ojan@chromium.org>
11615
11616         Fix accidental missing line in r111793.
11617
11618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
11619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
11620         Remove base.values. It was unused and duplicates the builtin Object.values.
11621         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
11622         Accidentally deleted this line before committing r111793.
11623
11624 2012-03-22  Ojan Vafai  <ojan@chromium.org>
11625
11626         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
11627         https://bugs.webkit.org/show_bug.cgi?id=81983
11628
11629         Reviewed by Adam Barth.
11630
11631         The dialogs get in the way if you are doing multiple rebaselines. Also,
11632         a number of people didn't realize that you could do multiple rebaselines
11633         in parallel. A non-modal dialog is just confusing.
11634
11635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
11636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
11637         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
11638         show the number of tests being rebaselined.
11639
11640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
11641         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
11642         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
11643         into a single area.
11644
11645         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
11646         also serves to clear all teh content in the StatusArea.
11647
11648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
11649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
11650
11651 2012-03-22  Tony Chang  <tony@chromium.org>
11652
11653         Unreviewed, fix chromium build after wtf move.
11654
11655         Only use newwtf, remove references to wtf.
11656
11657         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
11658
11659 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
11660
11661         Actually move WTF files to their new home
11662         https://bugs.webkit.org/show_bug.cgi?id=81844
11663
11664         [Qt] Unreviewed buildfix after r111778.
11665
11666         * DumpRenderTree/qt/DumpRenderTree.pro:
11667
11668 2012-03-22  Dan Bernstein  <mitz@apple.com>
11669
11670         Font fallback in WebKitTestRunner depends on user settings
11671         https://bugs.webkit.org/show_bug.cgi?id=81978
11672
11673         Reviewed by Jessie Berlin.
11674
11675         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
11676         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
11677         with a value consisting of the array ("en") to the override defaults
11678         dictionary. This is the same value used in DumpRenderTree, and it
11679         ensures that font fallback follows a consistent path that is not
11680         affected by the language preferences of the user running the test.
11681
11682 2012-03-22  Andy Estes  <aestes@apple.com>
11683
11684         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
11685         https://bugs.webkit.org/show_bug.cgi?id=81971
11686
11687         Reviewed by Dan Bernstein.
11688
11689         Xcode will automatically link ObjC binaries against libarclite in some
11690         cases, which defines a class called __ARCLite__.
11691         check-for-inappropriate-objc-class-names shouldn't complain about this
11692         class name.
11693
11694         * Scripts/check-for-inappropriate-objc-class-names:
11695
11696 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
11697
11698         new-run-webkit-tests blames the wrong test for crashing
11699         https://bugs.webkit.org/show_bug.cgi?id=81951
11700
11701         Reviewed by Adam Barth.
11702
11703         NRWT wasn't extracting the WebProcess pid correct; should've
11704         used re.search instead of re.match :(. Add more tests!
11705
11706         * Scripts/webkitpy/layout_tests/port/mac.py:
11707         (MacPort._get_crash_log):
11708         * Scripts/webkitpy/layout_tests/port/webkit.py:
11709         (WebKitDriver.has_crashed):
11710         (WebKitDriver._check_for_driver_crash):
11711         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
11712         (WebKitDriverTest.test_no_timeout):
11713         (WebKitDriverTest):
11714         (WebKitDriverTest.test_check_for_driver_crash):
11715         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
11716         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
11717         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
11718         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
11719         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
11720         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
11721
11722 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11723
11724         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
11725         https://bugs.webkit.org/show_bug.cgi?id=81512
11726
11727         Adding missing implementation markerTextForListItem to EFL's
11728         LayoutTestController so that we can unskip related tests from
11729         the skip list.
11730
11731         Reviewed by Antonio Gomes.
11732
11733         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11734         (LayoutTestController::markerTextForListItem): Implemented.
11735
11736 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11737
11738         [EFL] Enable view mode media feature layout tests
11739         https://bugs.webkit.org/show_bug.cgi?id=81205
11740
11741         Adding missing implementation setViewModeMediaFeature to EFL's
11742         LayoutTestController so that we can unskip view mode
11743         media feature layout tests.
11744
11745         Reviewed by Antonio Gomes.
11746
11747         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11748         (LayoutTestController::setViewModeMediaFeature): Implemented.
11749
11750 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
11751
11752         nrwt: crash while stopping layout test helper on apple mac lion
11753         https://bugs.webkit.org/show_bug.cgi?id=81949
11754
11755         Reviewed by Eric Seidel.
11756
11757         stop_helper() didn't work right if the helper process wasn't
11758         still running or didn't respond properly to being shut down. Fix
11759         this and add some tests. Also add code to MockExecutive() to be
11760         able to mock executive.popen() properly.
11761
11762         * Scripts/webkitpy/common/system/executive_mock.py:
11763         (MockProcess.__init__):
11764         (MockProcess.wait):
11765         (MockExecutive.__init__):
11766         (MockExecutive.popen):
11767         * Scripts/webkitpy/common/system/systemhost_mock.py:
11768         (MockSystemHost.__init__):
11769         * Scripts/webkitpy/layout_tests/port/mac.py:
11770         (MacPort.start_helper):
11771         (MacPort.stop_helper):
11772         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
11773         (test_get_crash_log):
11774         (test_helper_starts):
11775         (test_helper_fails_to_start):
11776         (test_helper_fails_to_stop):
11777         (test_helper_fails_to_stop.bad_waiter):
11778
11779 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
11780
11781         [GTK] Add make to the jhbuild moduleset
11782         https://bugs.webkit.org/show_bug.cgi?id=81769
11783
11784         Reviewed by Martin Robinson.
11785
11786         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
11787         Add GNU make with custom patches to fix several issues:
11788
11789         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
11790           fix the argument list limit of GNU make when running make
11791           distcheck.
11792         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
11793           and Jeremy Devenport to fix parallel build issues present in
11794           GNU make 3.82
11795
11796         * gtk/jhbuild.modules: Added make with patches.
11797         * gtk/patches/make-3.82-arg-list-length.patch: Added.
11798         * gtk/patches/make-3.82-parallel-build.patch: Added.
11799
11800 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
11801
11802         [wx] Unreviewed. Adding Source/WTF to the build and updating
11803         waf port list.
11804
11805         * DumpRenderTree/wscript:
11806         * waf/build/settings.py:
11807
11808 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
11809
11810         Re-land fix for r81603 yet again (!) with latest build fix.
11811         https://bugs.webkit.org/show_bug.cgi?id=81603
11812
11813         Unreviewed, build fix.
11814
11815         The latest problem was a bad sprintf() in
11816         BasePort._get_crash_log(). I've reworked that routine and added
11817         unit tests for coverage.
11818
11819         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
11820         (SingleTestRunner._handle_error):
11821         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
11822         (write_test_result):
11823         (TestResultWriter.write_crash_log):
11824         * Scripts/webkitpy/layout_tests/port/base.py:
11825         (Port.diff_text):
11826         (Port._get_crash_log):
11827         * Scripts/webkitpy/layout_tests/port/chromium.py:
11828         (ChromiumDriver.run_test):
11829         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11830         (ChromiumDriverTest.test_crash_log):
11831         * Scripts/webkitpy/layout_tests/port/driver.py:
11832         (DriverOutput.__init__):
11833         * Scripts/webkitpy/layout_tests/port/mac.py:
11834         (MacPort.is_lion):
11835         (MacPort._get_crash_log):
11836         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
11837         (test_default_child_processes):
11838         (test_get_crash_log):
11839         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
11840         (MockDRTPortTest.test_get_crash_log):
11841         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
11842         (PortTestCase.test_get_crash_log):
11843         * Scripts/webkitpy/layout_tests/port/test.py:
11844         (TestDriver.run_test):
11845         * Scripts/webkitpy/layout_tests/port/webkit.py:
11846         (WebKitDriver.__init__):
11847         (WebKitDriver._start):
11848         (WebKitDriver.has_crashed):
11849         (WebKitDriver._check_for_driver_crash):
11850         (WebKitDriver.run_test):
11851
11852 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
11853
11854         [Qt] Enable support for handling database quota's in the MiniBrowser
11855         https://bugs.webkit.org/show_bug.cgi?id=81928
11856
11857         Reviewed by Simon Hausmann.
11858
11859         * MiniBrowser/qt/qml/BrowserWindow.qml:
11860
11861 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
11862
11863         [EFL] Implement LayoutTestController::setEditingBehavior
11864         https://bugs.webkit.org/show_bug.cgi?id=81124
11865
11866         Adding missing implementation setEditingBehavior to EFL's
11867         LayoutTestController. This implementation allows us to
11868         unskip some tests from the skip list.
11869
11870         Reviewed by Martin Robinson.
11871
11872         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
11873         (LayoutTestController::setEditingBehavior): Implemented.
11874
11875 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
11876
11877         [GTK] Use the angle-bracket form to include wtf headers
11878         https://bugs.webkit.org/show_bug.cgi?id=81884
11879
11880         Reviewed by Eric Seidel.
11881
11882         Use #include <wtf/foo> instead of #include "foo".
11883
11884         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
11885         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
11886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
11887         * DumpRenderTree/gtk/EditingCallbacks.cpp:
11888         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
11889         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
11890
11891 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
11892
11893         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
11894
11895         * Scripts/webkitpy/common/config/committers.py:
11896
11897 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
11898
11899         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
11900         https://bugs.webkit.org/show_bug.cgi?id=81889
11901
11902         Reviewed by Kenneth Rohde Christiansen.
11903
11904         Enable FAST_MOBILE_SCROLLING feature.
11905
11906         * qmake/mkspecs/features/features.prf:
11907
11908 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
11909
11910         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
11911         https://bugs.webkit.org/show_bug.cgi?id=81900
11912
11913         Reviewed by Gustavo Noronha Silva.
11914
11915         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
11916         path which assumed a certain directory structure for the build
11917         directory which may noy be true.
11918
11919         Instead, hardcode the path to the downloaded fonts starting from the
11920         top-level source directory. While this solution is also far from
11921         perfect, it makes it more consistent and reliable, and easier to
11922         tackle at once with the rest of bug 81475.
11923
11924         * DumpRenderTree/efl/CMakeLists.txt:
11925
11926 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
11927
11928         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
11929         https://bugs.webkit.org/show_bug.cgi?id=81888
11930
11931         Reviewed by Philippe Normand.
11932
11933         * Scripts/update-webkit-libs-jhbuild:
11934         (runJhbuild): Helper function to run jhbuild with a given command.
11935         Instead of running jhbuild directly, use the jhbuild-wrapper, so
11936         that we don't need to run it first to check whether jhbuild is
11937         installed or not.
11938         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
11939         * gtk/run-with-jhbuild: Ditto.
11940         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
11941         not only run.
11942
11943 2012-03-22  Philippe Normand  <pnormand@igalia.com>
11944
11945         Unreviewed, test-webkitpy fix after r111661.
11946
11947         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
11948         (MainTest.test_crash_log):
11949         (MainTest.test_web_process_crash_log):
11950
11951 2012-03-22  Philippe Normand  <pnormand@igalia.com>
11952
11953         Unreviewed, test-webkitpy fix after r111642.
11954
11955         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11956         (ChromiumDriverTest.setUp):
11957         (ChromiumDriverTest.test_two_drivers):
11958
11959 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
11960
11961         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
11962         https://bugs.webkit.org/show_bug.cgi?id=81603
11963
11964         Unreviewed rolling out r111609 and part of r111615,
11965         because it broke NRWT on Qt-WK2 platform.
11966
11967         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
11968         (SingleTestRunner._handle_error):
11969         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
11970         (write_test_result):
11971         (TestResultWriter.write_crash_report):
11972         * Scripts/webkitpy/layout_tests/port/base.py:
11973         (Port.is_crash_reporter):
11974         (Port._driver_class):
11975         * Scripts/webkitpy/layout_tests/port/chromium.py:
11976         (ChromiumDriver.run_test):
11977         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
11978         (ChromiumDriverTest.test_crashed_process_name):
11979         * Scripts/webkitpy/layout_tests/port/driver.py:
11980         (DriverOutput.__init__):
11981         * Scripts/webkitpy/layout_tests/port/mac.py:
11982         (MacPort):
11983         (MacPort.is_crash_reporter):
11984         (MacPort.release_http_lock):
11985         * Scripts/webkitpy/layout_tests/port/test.py:
11986         (TestDriver.run_test):
11987         * Scripts/webkitpy/layout_tests/port/webkit.py:
11988         (WebKitDriver.__init__):
11989         (WebKitDriver._start):
11990         (WebKitDriver.has_crashed):
11991         (WebKitDriver._check_for_driver_crash):
11992         (WebKitDriver.run_test):
11993
11994 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
11995
11996         [Qt] Add full platforms to Qt buildslaves
11997         https://bugs.webkit.org/show_bug.cgi?id=81877
11998
11999         Reviewed by Ryosuke Niwa.
12000
12001         * BuildSlaveSupport/build.webkit.org-config/config.json:
12002
12003 2012-03-21  Johnny Ding  <jnd@chromium.org>
12004
12005         Customize layout test timeout value for different ports.
12006         https://bugs.webkit.org/show_bug.cgi?id=79859
12007
12008         Reviewed by Ojan Vafai.
12009
12010         * Scripts/webkitpy/layout_tests/controllers/manager.py:
12011         (Manager):
12012         * Scripts/webkitpy/layout_tests/port/base.py:
12013         (Port.default_test_timeout_ms):
12014         * Scripts/webkitpy/layout_tests/port/chromium.py:
12015         (ChromiumDriver.stop):
12016         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
12017         (ChromiumAndroidPort.default_test_timeout_ms):
12018         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
12019         (_set_up_derived_options):
12020
12021 2012-03-21  Mark Rowe  <mrowe@apple.com>
12022
12023         Fix the build.
12024
12025         Ensure that our test tools don't try and use RTTI unnecessarily.
12026
12027         * DumpRenderTree/mac/Configurations/Base.xcconfig:
12028         * TestWebKitAPI/Configurations/Base.xcconfig:
12029         * WebKitTestRunner/Configurations/Base.xcconfig:
12030
12031 2012-03-21  Adam Barth  <abarth@webkit.org>
12032
12033         WebKit should have some scripts to smooth interactions with GitHub
12034         https://bugs.webkit.org/show_bug.cgi?id=81842
12035
12036         Reviewed by Eric Seidel.
12037
12038         These scripts support the workflow in
12039         https://trac.webkit.org/wiki/UsingGitHub by automating the
12040         configuration and syncing operations needed for a GitHub fork of WebKit
12041         to track the main WebKit repository.
12042
12043         * Scripts/configure-github-as-upstream: Added.
12044         * Scripts/sync-master-with-upstream: Added.
12045
12046 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
12047
12048         WTR - log the pid of a crashing WebProcess
12049         https://bugs.webkit.org/show_bug.cgi?id=81575
12050
12051         Reviewed by Alexey Proskuryakov.
12052
12053         This allows run-webkit-tests to find the right crash log for a
12054         given crashed WebProcess in WebKit2.
12055
12056         * WebKitTestRunner/TestController.cpp:
12057         (WTR::exceededDatabaseQuota):
12058         (WTR::TestController::createOtherPage):
12059         (WTR::TestController::initialize):
12060         (WTR::TestController::resetStateToConsistentValues):
12061         (WTR::TestController::runTest):
12062         (WTR::TestController::processDidCrash):
12063
12064 2012-03-21  Enrica Casucci  <enrica@apple.com>
12065
12066         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
12067         https://bugs.webkit.org/show_bug.cgi?id=81835
12068         <rdar://problem/11082749>
12069
12070         Reviewed by Brady Eidson.
12071
12072         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
12073         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
12074         (TestWebKitAPI::contextMenuCopyLink):
12075
12076 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
12077
12078         [CSS Shaders] Make CSS Shaders compile on Chromium
12079         https://bugs.webkit.org/show_bug.cgi?id=81435
12080
12081         Reviewed by Stephen White.
12082
12083         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
12084
12085         * DumpRenderTree/chromium/LayoutTestController.cpp:
12086         (LayoutTestController::overridePreference):
12087         * DumpRenderTree/chromium/WebPreferences.cpp:
12088         (WebPreferences::reset):
12089         (WebPreferences::applyTo):
12090         * DumpRenderTree/chromium/WebPreferences.h:
12091         (WebPreferences):
12092
12093 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
12094
12095         fix regression on gtk port introduced by r111609
12096         https://bugs.webkit.org/show_bug.cgi?id=81839
12097
12098         Reviewed by Philippe Normand.
12099
12100         r111609 should've initialized a couple of missing fields in
12101         WebKitDriver, and also should've checked for method overrides
12102         in the other ports :(.
12103
12104         * Scripts/webkitpy/layout_tests/port/gtk.py:
12105         (GtkDriver._start):
12106         * Scripts/webkitpy/layout_tests/port/webkit.py:
12107         (WebKitDriver.__init__):
12108         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
12109         (MainTest.test_crash_log):
12110         (MainTest.test_web_process_crash_log):
12111
12112 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
12113
12114         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
12115         https://bugs.webkit.org/show_bug.cgi?id=81603
12116
12117         Reviewed by Adam Barth.
12118
12119         Add a new _get_crash_log() overridable method on the Port
12120         object to customize how we fetch crash logs per port.
12121         Mac will now slow-spin with a timeout waiting for the crash log, rather
12122         than waiting for the ReportCrash process to exit (it appears
12123         that the mac will manage multiple crashes with a single
12124         ReportCrash process, the process waits around longer than
12125         necessary, presumably to avoid thrashing if processes are
12126         repeatedly crashing).
12127
12128         Also, add the DriverOutput should contain the crash log and other info,
12129         which is created in a port-specific manner but can then be
12130         treated generically. Previously single_test_runner would get
12131         told that something crashed and attempt to do something to get
12132         the crash log, but it didn't have the information it needed to
12133         od the right thing; better to make the driver hand back the
12134         right info.
12135
12136         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
12137         (SingleTestRunner._handle_error):
12138         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
12139         (write_test_result):
12140         (TestResultWriter.write_crash_log):
12141         * Scripts/webkitpy/layout_tests/port/base.py:
12142         (Port.diff_text):
12143         (Port._get_crash_log):
12144         * Scripts/webkitpy/layout_tests/port/chromium.py:
12145         (ChromiumDriver.run_test):
12146         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
12147         (ChromiumDriverTest.test_crash_log):
12148         * Scripts/webkitpy/layout_tests/port/driver.py:
12149         (DriverOutput.__init__):
12150         * Scripts/webkitpy/layout_tests/port/mac.py:
12151         (MacPort.is_lion):
12152         (MacPort._get_crash_log):
12153         * Scripts/webkitpy/layout_tests/port/test.py:
12154         (TestDriver.run_test):
12155         * Scripts/webkitpy/layout_tests/port/webkit.py:
12156         (WebKitDriver.__init__):
12157         (WebKitDriver._start):
12158         (WebKitDriver.has_crashed):
12159         (WebKitDriver._check_for_driver_crash):
12160         (WebKitDriver.run_test):
12161
12162 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
12163
12164         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
12165         https://bugs.webkit.org/show_bug.cgi?id=81507
12166
12167         Now that we're only loading from one directory, no need to
12168         iterate over a list of directories anymore.
12169
12170         Reviewed by Martin Robinson.
12171
12172         * DumpRenderTree/efl/CMakeLists.txt:
12173         * DumpRenderTree/efl/FontManagement.cpp:
12174         (addFontDirectory):
12175         (addFontsToEnvironment):
12176
12177 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
12178
12179         webkitpy: get ServerProcess out of the reportcrash business
12180         https://bugs.webkit.org/show_bug.cgi?id=81600
12181
12182         Unreviewed, build fix.
12183
12184         Re-land r111307 and r111293 with another fix for a crash in NRWT;
12185         we need to check if the driver has crashed before attempting to
12186         read from it.
12187
12188
12189         * Scripts/webkitpy/layout_tests/port/server_process.py:
12190         (ServerProcess._reset):
12191         (ServerProcess._handle_possible_interrupt):
12192         (ServerProcess.write):
12193         (ServerProcess.read_stdout):
12194         (ServerProcess.has_crashed):
12195         (ServerProcess._read):
12196         (ServerProcess.stop):
12197         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
12198         (TrivialMockPort.check_for_leaks):
12199         (TestServerProcess.test_broken_pipe):
12200         * Scripts/webkitpy/layout_tests/port/webkit.py:
12201         (WebKitPort._read_image_diff):
12202         (WebKitDriver.has_crashed):
12203         (WebKitDriver._check_for_driver_crash):
12204         (WebKitDriver.run_test):
12205         (WebKitDriver._read_block):
12206         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12207         (MockServerProcess.__init__):
12208         (MockServerProcess):
12209         (MockServerProcess.has_crashed):
12210
12211 2012-03-21  Zeno Albisser  <zeno@webkit.org>
12212
12213         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
12214         https://bugs.webkit.org/show_bug.cgi?id=81750
12215
12216         Building WebCore on mac currently creates an archive that is bigger than
12217         4GB. But ranlib fails to create a symbol table for such a big archive,
12218         even on 64bit machines.
12219         Therefore we start using SVGAllInOne.cpp when building debug
12220         on mac. This reduces the size of the archive by about 300MB.
12221
12222         Reviewed by Tor Arne Vestbø.
12223
12224         * qmake/mkspecs/features/mac/default_pre.prf:
12225
12226 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
12227
12228         Updated the address list of committers.py.
12229
12230         Reviewed by Csaba Osztrogonác.
12231
12232         * Scripts/webkitpy/common/config/committers.py:
12233
12234 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
12235
12236         Updating my nick in committers file.
12237
12238         Unreviewed.
12239
12240         * Scripts/webkitpy/common/config/committers.py:
12241
12242 2012-03-21  Peter Beverloo  <peter@chromium.org>
12243
12244         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
12245         https://bugs.webkit.org/show_bug.cgi?id=80861
12246
12247         Reviewed by Tony Chang.
12248
12249         Remove most Android-specific logic from webkitdirs.pm in favor of
12250         handling this during project generation time.
12251
12252         * Scripts/webkitdirs.pm:
12253         (buildChromiumMakefile):
12254
12255 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
12256
12257         [GTK] Allow running javascript from location bar in MiniBrowser
12258         https://bugs.webkit.org/show_bug.cgi?id=81331
12259
12260         Reviewed by Martin Robinson.
12261
12262         * MiniBrowser/gtk/BrowserWindow.c:
12263         (activateUriEntryCallback): Use browser_window_load_uri().
12264         (browser_window_load_uri): Check whether uri starts with
12265         javascript: and run the given script, or just call
12266         webkit_web_view_load_uri() to load the given uri.
12267         * MiniBrowser/gtk/BrowserWindow.h:
12268         * MiniBrowser/gtk/main.c:
12269         (createBrowserWindow): Use browser_window_load_uri().
12270
12271 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
12272
12273         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
12274         https://bugs.webkit.org/show_bug.cgi?id=75543
12275
12276         Reviewed by Martin Robinson.
12277
12278         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
12279         MiniBrowser CPP flags.
12280
12281 2012-03-20  Eric Seidel  <eric@webkit.org>
12282
12283         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
12284         https://bugs.webkit.org/show_bug.cgi?id=80911
12285
12286         Reviewed by Adam Barth.
12287
12288         Update include paths for Source/WTF.
12289
12290         * DumpRenderTree/efl/CMakeLists.txt:
12291         * DumpRenderTree/qt/DumpRenderTree.pro:
12292         * QtTestBrowser/QtTestBrowser.pro:
12293         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
12294
12295 2012-03-20  Adam Barth  <abarth@webkit.org>
12296
12297         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
12298         https://bugs.webkit.org/show_bug.cgi?id=81567
12299
12300         Reviewed by Eric Seidel.
12301
12302         This temporary measure should help us avoid disrupting the folks
12303         working on WebAudio when we move the webaudio directory to Modules.
12304
12305         * Scripts/VCSUtils.pm:
12306         (adjustPathForRecentRenamings):
12307         (parseGitDiffHeader):
12308         (parseSvnDiffHeader):
12309
12310 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
12311
12312         Unreviewed, rolling out r111453.
12313         http://trac.webkit.org/changeset/111453
12314         https://bugs.webkit.org/show_bug.cgi?id=81600
12315
12316         still broken
12317
12318         * Scripts/webkitpy/layout_tests/port/server_process.py:
12319         (ServerProcess._reset):
12320         (ServerProcess.handle_interrupt):
12321         (ServerProcess.write):
12322         (ServerProcess._check_for_crash):
12323         (ServerProcess._handle_timeout):
12324         (ServerProcess._check_for_abort):
12325         (ServerProcess._read):
12326         (ServerProcess.stop):
12327         (ServerProcess):
12328         (ServerProcess.set_crashed):
12329         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
12330         (TrivialMockPort.is_crash_reporter):
12331         (TestServerProcess.test_broken_pipe):
12332         * Scripts/webkitpy/layout_tests/port/webkit.py:
12333         (WebKitPort._read_image_diff):
12334         (WebKitDriver.has_crashed):
12335         (WebKitDriver._check_for_driver_crash):
12336         (WebKitDriver):
12337         (WebKitDriver._detected_crash):
12338         (WebKitDriver._subprocess_crashed):
12339         (WebKitDriver._crashed_process_name):
12340         (WebKitDriver.run_test):
12341         (WebKitDriver._read_block):
12342         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12343         (MockServerProcess.__init__):
12344
12345 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
12346
12347         webkitpy: get ServerProcess out of the reportcrash business
12348         https://bugs.webkit.org/show_bug.cgi?id=81600
12349
12350         Unreviewed, build fix.
12351
12352         Re-land r111307 and r111293 with fix for crash in NRWT; I
12353         was failing to set the crashing process name.
12354
12355         * Scripts/webkitpy/layout_tests/port/server_process.py:
12356         (ServerProcess._reset):
12357         (ServerProcess._handle_possible_interrupt):
12358         (ServerProcess.write):
12359         (ServerProcess.read_stdout):
12360         (ServerProcess.has_crashed):
12361         (ServerProcess._read):
12362         (ServerProcess.stop):
12363         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
12364         (TrivialMockPort.check_for_leaks):
12365         (TestServerProcess.test_broken_pipe):
12366         * Scripts/webkitpy/layout_tests/port/webkit.py:
12367         (WebKitPort._read_image_diff):
12368         (WebKitDriver.has_crashed):
12369         (WebKitDriver._check_for_driver_crash):
12370         (WebKitDriver.run_test):
12371         (WebKitDriver._read_block):
12372         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12373         (MockServerProcess.__init__):
12374         (MockServerProcess):
12375         (MockServerProcess.has_crashed):
12376
12377 2012-03-20  Tim Horton  <timothy_horton@apple.com>
12378
12379         [mac] Restore color space switching code to run-webkit-tests
12380         https://bugs.webkit.org/show_bug.cgi?id=80571
12381         <rdar://problem/11008529>
12382
12383         Reviewed by Simon Fraser.
12384
12385         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
12386
12387         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
12388         didn't exist until Lion.
12389
12390         * DumpRenderTree/mac/LayoutTestHelper.m:
12391         (installLayoutTestColorProfile):
12392         (restoreUserColorProfile):
12393
12394 2012-03-20  Adele Peterson  <adele@apple.com>
12395
12396         Update the last test to use EXPECT_WK_STREQ.
12397
12398         Reviewed by Dan Bernstein.
12399
12400         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
12401
12402 2012-03-20  Adele Peterson  <adele@apple.com>
12403
12404         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
12405         https://bugs.webkit.org/show_bug.cgi?id=81630
12406         <rdar://problem/10650660>
12407
12408         Reviewed by Alexey Proskuryakov.
12409
12410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12411         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
12412         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
12413         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
12414         (TestWebKitAPI):
12415         (TestWebKitAPI::didFinishLoadForFrame):
12416         (TestWebKitAPI::TEST):
12417         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
12418
12419 2012-03-20  Eric Seidel  <eric@webkit.org>
12420
12421         Add link on queues.webkit.org to kov's fancy queue-depth graph
12422         https://bugs.webkit.org/show_bug.cgi?id=81690
12423
12424         Reviewed by Adam Barth.
12425
12426         * QueueStatusServer/templates/recentstatus.html:
12427
12428 2012-03-20  Tim Horton  <timothy_horton@apple.com>
12429
12430         [mac] Restore color space switching code to run-webkit-tests
12431         https://bugs.webkit.org/show_bug.cgi?id=80571
12432         <rdar://problem/11008529>
12433
12434         Reviewed by Simon Fraser.
12435
12436         Make use of the layout test helper hooks to restore the Mac system-wide
12437         color profile switching code. This makes WkTR and DRT results match, and
12438         causes the main display's color profile to not affect results on Lion.
12439
12440         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
12441         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
12442         (installLayoutTestColorProfile):
12443         (restoreUserColorProfile):
12444         (simpleSignalHandler):
12445         (main):
12446         * Scripts/webkitpy/layout_tests/port/mac.py:
12447         (MacPort.release_http_lock):
12448         (MacPort):
12449         (MacPort._path_to_helper):
12450         (MacPort.start_helper):
12451         (MacPort.stop_helper):
12452         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
12453         (WTR::PlatformWebView::PlatformWebView):
12454         (WTR::PlatformWebView::windowSnapshotImage):
12455
12456 2012-02-24  Darin Fisher  <darin@chromium.org>
12457
12458         Add more Chromium WebKit API reviewers
12459         https://bugs.webkit.org/show_bug.cgi?id=81576
12460
12461         Reviewed by Adam Barth and David Levin.
12462
12463         Simplify watchlist to lump all WebKit API into one.
12464
12465         * Scripts/webkitpy/common/config/watchlist:
12466
12467 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
12468
12469         Convert hasSpellingMarker to use Internals interface.
12470         https://bugs.webkit.org/show_bug.cgi?id=81300
12471
12472         Reviewed by Ryosuke Niwa.
12473
12474         Remove hasSpellingMarker functions, because it is able to work in the
12475         cross-port way through the Internals interface.
12476
12477         * DumpRenderTree/LayoutTestController.cpp:
12478         (LayoutTestController::staticFunctions):
12479         * DumpRenderTree/LayoutTestController.h:
12480         (LayoutTestController):
12481         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
12482         * DumpRenderTree/chromium/LayoutTestController.cpp:
12483         (LayoutTestController::LayoutTestController):
12484         * DumpRenderTree/chromium/LayoutTestController.h:
12485         (LayoutTestController):
12486         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
12487         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
12488         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
12489         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
12490         * DumpRenderTree/qt/LayoutTestControllerQt.h:
12491         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
12492         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
12493
12494 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
12495
12496         Add new Qt-WK2 performance tester bot to build.webkit.org
12497         https://bugs.webkit.org/show_bug.cgi?id=80842
12498
12499         Reviewed by Ryosuke Niwa.
12500
12501         * BuildSlaveSupport/build.webkit.org-config/config.json:
12502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
12503         (RunAndUploadPerfTestsWebKit2):
12504         (RunAndUploadPerfTestsWebKit2.start):
12505         (BuildAndPerfTestWebKit2Factory):
12506         (BuildAndPerfTestWebKit2Factory.__init__):
12507         (DownloadAndPerfTestWebKit2Factory):
12508         (DownloadAndPerfTestWebKit2Factory.__init__):
12509
12510 2012-03-20  Peter Beverloo  <peter@chromium.org>
12511
12512         [Chromium] Update to Android NDK r7b
12513         https://bugs.webkit.org/show_bug.cgi?id=81005
12514
12515         Reviewed by Adam Barth.
12516
12517         Update to version r7b of the Android NDK, release notes of which are
12518         available on the following page:
12519         http://developer.android.com/sdk/ndk/index.html
12520
12521         * Scripts/update-webkit-chromium:
12522
12523 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
12524
12525         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
12526         https://bugs.webkit.org/show_bug.cgi?id=81502
12527
12528         Unreviewed.
12529
12530         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
12531
12532 2012-03-19  Jessie Berlin  <jberlin@apple.com>
12533
12534         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
12535         because they broke running the layout tests on mac.
12536
12537         * Scripts/webkitpy/layout_tests/port/webkit.py:
12538         (WebKitDriver._check_for_driver_crash):
12539
12540 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
12541
12542         [GTK] Allow running run-gtk-tests during 'make distcheck'
12543         https://bugs.webkit.org/show_bug.cgi?id=81415
12544
12545         Reviewed by Philippe Normand.
12546
12547         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
12548
12549         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
12550         main command run during 'make check.'
12551         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
12552         a requirement to run it. If jhbuild isn't around it will simply not start the
12553         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
12554         main loop and simply use the main loop in a synchronous method to start SPI
12555         daemons. Did a bunch of general cleanup around these tasks.
12556
12557 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
12558
12559         jhbuild: Use the multiprocessing module to get the number of CPUs.
12560         https://bugs.webkit.org/show_bug.cgi?id=81585
12561
12562         Reviewed by Martin Robinson.
12563
12564         Now that support for Python 2.5 has been dropped, we can safely
12565         use multiprocessing.cpu_count() to obtain the current number of
12566         CPUs in the system instead of running a webkitperl script for
12567         that.
12568
12569         * efl/common.py:
12570         (top_level_path):
12571         * efl/jhbuildrc:
12572         * gtk/common.py:
12573         (build_path):
12574         * gtk/jhbuildrc:
12575
12576 2012-03-19  Ojan Vafai  <ojan@chromium.org>
12577
12578         We should only add a live event listener once, not once per TestSelector.
12579         Adding one per TestSelector would cause accordion('option', 'active') to
12580         incorrectly be "false" if you examine multiple sets of tests.
12581
12582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
12583
12584 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12585
12586         Fix typo introduced in r111293.
12587
12588         Unreviewed, build fix.
12589
12590         * Scripts/webkitpy/layout_tests/port/webkit.py:
12591         (WebKitDriver._check_for_driver_crash):
12592
12593 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12594
12595         webkitpy: get ServerProcess out of the reportcrash business
12596         https://bugs.webkit.org/show_bug.cgi?id=81600
12597
12598         Reviewed by Adam Barth.
12599
12600         ServerProcess was half-aware that ReportCrash might run
12601         sometimes, and that the process ServerProcess was talking to
12602         might have its own crashing subprocesses; neither of these
12603         things really worked right and it made the logic convoluted, so
12604         this change makes handling crashes completely separate from the
12605         server_process code, so that it can focus on just I/O to the
12606         subprocess.
12607
12608         There should be no functional changes resulting from this patch.
12609
12610         * Scripts/webkitpy/layout_tests/port/server_process.py:
12611         (ServerProcess._reset):
12612         (ServerProcess._handle_possible_interrupt):
12613         (ServerProcess.write):
12614         (ServerProcess.read_stdout):
12615         (ServerProcess.has_crashed):
12616         (ServerProcess._read):
12617         (ServerProcess.stop):
12618         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
12619         (TrivialMockPort.check_for_leaks):
12620         (TestServerProcess.test_broken_pipe):
12621         * Scripts/webkitpy/layout_tests/port/webkit.py:
12622         (WebKitPort._read_image_diff):
12623         (WebKitDriver.has_crashed):
12624         (WebKitDriver._check_for_driver_crash):
12625         (WebKitDriver.run_test):
12626         (WebKitDriver._read_block):
12627         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
12628         (MockServerProcess.__init__):
12629         (MockServerProcess):
12630         (MockServerProcess.has_crashed):
12631
12632 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12633
12634         webkitpy: crashlog parsing is broken
12635         https://bugs.webkit.org/show_bug.cgi?id=81586
12636
12637         Reviewed by Adam Barth.
12638
12639         Seeking on a file opened through codecs() appears to not work
12640         correctly (at least on SL).
12641
12642         The code was more complicated than it needed to be, so I have
12643         revamped it to just read a full crashlog at once and then look
12644         for matches.
12645
12646         I have also added the ability to optionally propagate
12647         errors back (which can be helpful to debug races when ReportCrash is
12648         still running and you need to see that you couldn't open some
12649         files, rather than just ignoring them).
12650
12651         * Scripts/webkitpy/common/system/crashlogs.py:
12652         (CrashLogs.find_newest_log):
12653         (CrashLogs._find_newest_log_darwin):
12654         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
12655         (CrashLogsTest.test_find_log_darwin):
12656
12657 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12658
12659         webkitpy: clean up some port._filesystem references to not reference private members
12660         https://bugs.webkit.org/show_bug.cgi?id=81595
12661
12662         Reviewed by Eric Seidel.
12663
12664         There should be no functional changes in this patch, just some
12665         refactoring. Also, fixes a minor nit in write_image_diff_files(()
12666
12667         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
12668         (SingleTestRunner.__init__):
12669         (SingleTestRunner._run_compare_test):
12670         (SingleTestRunner._run_rebaseline):
12671         (SingleTestRunner._save_baseline_data):
12672         (SingleTestRunner._handle_error):
12673         (SingleTestRunner._run_reftest):
12674         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
12675         (write_test_result):
12676         (TestResultWriter.__init__):
12677         (TestResultWriter._make_output_directory):
12678         (TestResultWriter.output_filename):
12679         (TestResultWriter._output_testname):
12680         (TestResultWriter.write_output_files):
12681         (TestResultWriter.write_stderr):
12682         (TestResultWriter.write_crash_report):
12683         (TestResultWriter.create_text_diff_and_write_result):
12684         (TestResultWriter.write_image_diff_files):
12685         (copy_file):
12686         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
12687         (TestResultWriterTest.test_reftest_diff_image):
12688
12689 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12690
12691         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
12692         https://bugs.webkit.org/show_bug.cgi?id=81598
12693
12694         Reviewed by Eric Seidel.
12695
12696         "DumpRenderTree" shouldn't be hard-coded here, since some other
12697         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
12698
12699         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12700         (TestExpectations):
12701
12702 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12703
12704         webkitpy: allow instance data in TestFailure objects
12705         https://bugs.webkit.org/show_bug.cgi?id=81580
12706
12707         Reviewed by Tony Chang.
12708
12709         Current TestFailures are basically enums, but it would be nice,
12710         especially for crashes, if they contained the name and pid of
12711         the process that crashed.
12712
12713         * Scripts/webkitpy/layout_tests/models/test_failures.py:
12714         (TestFailure.message):
12715         (FailureTimeout.message):
12716         (FailureCrash):
12717         (FailureCrash.__init__):
12718         (FailureCrash.message):
12719         (FailureMissingResult.message):
12720         (FailureTextMismatch.message):
12721         (FailureMissingImageHash.message):
12722         (FailureMissingImage.message):
12723         (FailureImageHashMismatch.message):
12724         (FailureImageHashIncorrect.message):
12725         (FailureReftestMismatch.message):
12726         (FailureReftestMismatchDidNotOccur.message):
12727         (FailureReftestNoImagesGenerated.message):
12728         (FailureMissingAudio.message):
12729         (FailureAudioMismatch.message):
12730         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
12731         (TestFailuresTest.test_equals):
12732         (TestFailuresTest):
12733         (TestFailuresTest.test_crashes):
12734
12735 2012-03-19  Brady Eidson  <beidson@apple.com>
12736
12737         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
12738         Crash in 3rd party WebKit apps under XHR/Cache code
12739
12740         Reviewed by Antti Koivisto.
12741
12742         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12743         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
12744         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
12745         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
12746         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
12747         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
12748         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
12749         (TestWebKitAPI):
12750         (TestWebKitAPI::TEST):
12751
12752 2012-03-19  Brady Eidson  <beidson@apple.com>
12753
12754         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
12755         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
12756
12757         Reviewed by Enrica Casucci.
12758
12759         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
12760         are in the correct format.
12761
12762         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
12763         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
12764         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
12765         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
12766         (TestWebKitAPI::contextMenuCopyLink):
12767         (TestWebKitAPI::TEST):
12768
12769 2012-03-19  Ojan Vafai  <ojan@chromium.org>
12770
12771         Make the selected item in the accordion a link to the flakiness dashboard
12772         https://bugs.webkit.org/show_bug.cgi?id=81571
12773
12774         Reviewed by Dimitri Glazkov.
12775
12776         Also, make it so that you can select the text of the link, instead of the current behavior
12777         of acting as if you had clicked on the accordion header.
12778
12779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
12780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
12781
12782 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12783
12784         NRWT runs some tests that are skipped with -i command line option
12785         https://bugs.webkit.org/show_bug.cgi?id=81535
12786
12787         Reviewed by Ojan Vafai.
12788
12789         This change modifies the interaction of Skipped files and
12790         test_expectations files so that entries in Skipped files (and
12791         the -i command line) override *everything* in the expectations
12792         file.
12793
12794         Specifically, a directory in a Skipped file will cause all of
12795         the tests in the dir to be skipped even if individual tests in
12796         the dir are listed in the test_expectations.txt.
12797
12798         Skipped files also override anything in an overrides files.
12799
12800         This seems to make more intuitive sense, since if you list
12801         something in the Skips file (and even more specify it on the
12802         command line) you probably want it to be universally applied.
12803
12804         Theoretically we could add more precedence levels and have full
12805         paths in an expectations file override dirs in a Skipped file
12806         (but not the command line), but I don't know yet that that level
12807         of complexity is justified.
12808
12809         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
12810         (TestExpectations.__init__):
12811         (TestExpectations._add_skipped_tests):
12812         (TestExpectations._add_test):
12813         (TestExpectations._add_expectations):
12814         (TestExpectations._add_expectation_line):
12815         (TestExpectations._already_seen_better_match):
12816         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
12817         (test_more_specific_override_resets_skip):
12818         (SkippedTests):
12819         (SkippedTests.get_exp):
12820         (SkippedTests.assert_exp):
12821         (SkippedTests.test_skipped_tests_work):
12822         (SkippedTests.test_duplicate_skipped_test_fails_lint):
12823         (SkippedTests.test_skipped_file_overrides_expectations):
12824         (SkippedTests.test_skipped_dir_overrides_expectations):
12825         (SkippedTests.test_skipped_file_overrides_overrides):
12826         (SkippedTests.test_skipped_dir_overrides_overrides):
12827
12828 2012-03-19  Eric Seidel  <eric@webkit.org>
12829
12830         Fix WTF header include discipline in Chromium WebKit
12831         https://bugs.webkit.org/show_bug.cgi?id=81281
12832
12833         Reviewed by James Robinson.
12834
12835         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
12836         * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
12837
12838 2012-03-19  Andy Chen  <andchen@rim.com>
12839
12840         [BlackBerry] Add new layout test for text match marker
12841         https://bugs.webkit.org/show_bug.cgi?id=81531
12842
12843         Make the LayoutTestControllerBlackBerry::findString to test the
12844         BlackBerry port implementation.
12845
12846         Reviewed by Rob Buis.
12847
12848         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
12849         (LayoutTestController::findString):
12850
12851 2012-03-19  Ojan Vafai  <ojan@chromium.org>
12852
12853         Don't show WONTFIX tests in garden-o-matic
12854         https://bugs.webkit.org/show_bug.cgi?id=81554
12855
12856         Reviewed by Dimitri Glazkov.
12857
12858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
12859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
12860
12861 2012-03-19  Chris Fleizach  <cfleizach@apple.com>
12862
12863         platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
12864         https://bugs.webkit.org/show_bug.cgi?id=81530
12865
12866         Reviewed by Jessie Berlin.
12867
12868         Add rowAtIndex to WebKitTestRunner.
12869
12870         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
12871         (WTR::AccessibilityUIElement::rowAtIndex):
12872         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
12873         (AccessibilityUIElement):
12874         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
12875         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
12876         (WTR):
12877         (WTR::AccessibilityUIElement::rowAtIndex):
12878
12879 2012-03-19  Ojan Vafai  <ojan@chromium.org>
12880
12881         Change garden-o-matic All Failures tab to Expected Failures
12882         https://bugs.webkit.org/show_bug.cgi?id=81540
12883
12884         Reviewed by Dimitri Glazkov.
12885
12886         Also, fix some broken unittests that had just gotten stale.
12887
12888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
12889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
12890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
12891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
12892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
12893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
12894         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
12895         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
12896         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
12897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
12898
12899 2012-03-19  Hao Zheng  <zhenghao@chromium.org>
12900
12901         [chromium] DRT crashes at shutdown.
12902         https://bugs.webkit.org/show_bug.cgi?id=81504
12903
12904         Reviewed by James Robinson.
12905
12906         WebCompositor must be destroyed after WebView is properly destroyed,
12907         or some compositor objects like CCLayerTreeHost may not be destroyed.
12908         However, it is really hard to make the destruction order correct
12909         explicitly in ~TestShell. So move it out to DumpRenderTree.
12910
12911         * DumpRenderTree/chromium/DumpRenderTree.cpp:
12912         (main):
12913         * DumpRenderTree/chromium/TestShell.cpp:
12914         (TestShell::~TestShell):
12915
12916 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12917
12918         add dpranke to webkitpy watchlist
12919         https://bugs.webkit.org/show_bug.cgi?id=81433
12920
12921         Reviewed by Benjamin Poulain.
12922
12923         * Scripts/webkitpy/common/config/watchlist:
12924
12925 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
12926
12927         test-webkitpy is failing on SL/Python 2.6.1
12928         https://bugs.webkit.org/show_bug.cgi?id=81533
12929
12930         Reviewed by Ojan Vafai.
12931
12932         It appears that itertools.combinations() is buggy in 2.6.1; this
12933         backports the implementation from 2.7.
12934
12935         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
12936         (TestConfigurationConverter.collapse_macros):
12937         (TestConfigurationConverter):
12938         (TestConfigurationConverter.combinations):
12939
12940 2012-03-19  David Michael Barr  <davidbarr@google.com>
12941
12942         Optimize the cleanup sequence in the start-queue.sh script
12943         https://github.com/abarth/webkit/pull/1
12944
12945         Reviewed by Adam Barth.
12946
12947         Updating the working copy is an expensive operation
12948         for a repository the size of WebKit.
12949         Attempt to reset only to the target revision.
12950
12951         * EWSTools/start-queue.sh:
12952
12953 2012-03-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
12954
12955         Adjust architecture type of the EFL build bot.
12956         https://bugs.webkit.org/show_bug.cgi?id=81452
12957
12958         Reviewed by Tony Chang.
12959
12960         * BuildSlaveSupport/build.webkit.org-config/config.json: The
12961         buildslave is a 64-bit machine, therefore describe it as being
12962         x86_64, not i386.
12963
12964 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
12965
12966         [Qt] printLoadedUrls prints "Object" instead of the actual URL.
12967         https://bugs.webkit.org/show_bug.cgi?id=81514
12968
12969         Reviewed by Simon Hausmann.
12970
12971         * MiniBrowser/qt/qml/BrowserWindow.qml:
12972
12973 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
12974
12975         [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
12976         https://bugs.webkit.org/show_bug.cgi?id=81491
12977
12978         Reviewed by Philippe Normand.
12979
12980         For the find_path(), find_library() etc CMake calls to find the
12981         dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
12982         set, otherwise CMake cannot know the dependencies exist and will only
12983         look in the standard directories.
12984
12985         * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
12986         the jhbuild Root directory.
12987
12988 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
12989
12990         [EFL] Add XDG env vars to jhbuildrc
12991         https://bugs.webkit.org/show_bug.cgi?id=81510
12992
12993         Needed to ensure correct glib behaviour in jhbuild environment.
12994
12995         Reviewed by Philippe Normand.
12996
12997         * efl/jhbuildrc:
12998
12999 2012-03-19  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
13000
13001         Select best target for tap gesture.
13002         https://bugs.webkit.org/show_bug.cgi?id=78801
13003
13004         Reviewed by Kenneth Rohde Christiansen.
13005
13006         Add TOUCH_ADJUSTMENT to enabled features.
13007
13008         * qmake/mkspecs/features/features.prf:
13009
13010 2012-03-19  Robert Kroeger  <rjkroege@chromium.org>
13011
13012         [chromium] synthesize wheel events for fling on main thread
13013         https://bugs.webkit.org/show_bug.cgi?id=81458
13014
13015         Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
13016
13017         Reviewed by James Robinson.
13018
13019         * DumpRenderTree/chromium/EventSender.cpp:
13020         (EventSender::EventSender):
13021         (EventSender::gestureFlingCancel):
13022         (EventSender::gestureFlingStart):
13023         * DumpRenderTree/chromium/EventSender.h:
13024         (EventSender):
13025
13026 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
13027
13028         [Qt] Add command line option to set the user agent in the MiniBrowser
13029         https://bugs.webkit.org/show_bug.cgi?id=81508
13030
13031         Reviewed by Simon Hausmann.
13032
13033         * MiniBrowser/qt/BrowserWindow.cpp:
13034         (BrowserWindow::BrowserWindow):
13035         (BrowserWindow::webViewExperimental):
13036         * MiniBrowser/qt/BrowserWindow.h:
13037         (BrowserWindow):
13038         * MiniBrowser/qt/MiniBrowserApplication.cpp:
13039         (printHelp):
13040         (MiniBrowserApplication::handleUserOptions):
13041         * MiniBrowser/qt/MiniBrowserApplication.h:
13042         (WindowOptions::WindowOptions):
13043         (WindowOptions::setUserAgent):
13044         (WindowOptions::userAgent):
13045         (WindowOptions):
13046
13047 2012-03-19  Alexander Færøy  <alexander.faeroy@nokia.com>
13048
13049         [Qt] Remove dead user agent code from the MiniBrowser.
13050
13051         Reviewed by Simon Hausmann.
13052
13053         * MiniBrowser/qt/BrowserWindow.cpp:
13054         * MiniBrowser/qt/BrowserWindow.h:
13055         (BrowserWindow):
13056         * MiniBrowser/qt/MiniBrowser.qrc:
13057         * MiniBrowser/qt/useragentlist.txt: Removed.
13058
13059 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
13060
13061         jhbuild: Call jhbuild's autogen.sh via bash.
13062         https://bugs.webkit.org/show_bug.cgi?id=81485
13063
13064         Reviewed by Philippe Normand.
13065
13066         jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
13067         this is usually true only on Linux systems, and even then bash for
13068         some reason might not be available in that location. It is safer to
13069         call bash directly and pass autogen.sh to it instead.
13070
13071         * jhbuild/jhbuild-wrapper:
13072         (install_jhbuild):
13073
13074 2012-03-19  Philippe Normand  <pnormand@igalia.com>
13075
13076         [GTK] Prefix run-launcher with run-with-jhbuild
13077         https://bugs.webkit.org/show_bug.cgi?id=81503
13078
13079         Reviewed by Hajime Morita.
13080
13081         * Scripts/run-launcher:
13082
13083 2012-03-19  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
13084
13085         [EFL] Prefix run-launcher with run-with-jhbuild
13086         https://bugs.webkit.org/show_bug.cgi?id=80026
13087
13088         Reviewed by Hajime Morita.
13089
13090         * Scripts/run-launcher:
13091
13092 2012-03-18  Csaba Osztrogonác  <ossy@webkit.org>
13093
13094         [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
13095         https://bugs.webkit.org/show_bug.cgi?id=81498
13096
13097         * qmake/mkspecs/features/unix/default_post.prf:
13098
13099 2012-03-17  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
13100
13101         Unreviewed; switch to using my FreeBSD.org email address, the
13102         other one is going to disappear soon.
13103
13104         * Scripts/webkitpy/common/config/committers.py:
13105         * Scripts/webkitpy/common/config/watchlist:
13106
13107 2012-03-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
13108
13109         Unreviewed; fix webkitpy unit test failures after r111116.
13110
13111         It turns out that cmd_line in the patch in bug 80025 had the right
13112         signature when it was submitted, but r109242 added a few more
13113         required parameters, and since the method (and EflDriver) did not
13114         exist at the time we ended up committing a broken method.
13115
13116         * Scripts/webkitpy/layout_tests/port/efl.py:
13117         (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
13118         arguments.
13119
13120 2012-03-17  Charles Wei  <charles.wei@torchmobile.com.cn>
13121
13122         [BlackBerry] Enable Web Timing for performance profiling and improvement.
13123         https://bugs.webkit.org/show_bug.cgi?id=81085
13124
13125         Reviewed by Rob Buis.
13126
13127         * Scripts/build-webkit:
13128
13129 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
13130
13131         Add a dependencies installation step for EFL to buildbot master.cfg
13132         https://bugs.webkit.org/show_bug.cgi?id=81337
13133
13134         Reviewed by Gustavo Noronha Silva.
13135
13136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
13137         (InstallEflDependencies):
13138         (Factory.__init__):
13139
13140 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
13141
13142         [EFL] Prefixing run-webkit-tests with run-with-jhbuild
13143         https://bugs.webkit.org/show_bug.cgi?id=80025
13144
13145         Reviewed by Gustavo Noronha Silva.
13146
13147         * Scripts/webkitpy/layout_tests/port/efl.py:
13148         (EflDriver):
13149         (EflDriver.cmd_line):
13150         (EflPort._driver_class):
13151
13152 2012-03-17  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
13153
13154         [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
13155         https://bugs.webkit.org/show_bug.cgi?id=79904
13156
13157         build-webkit --efl will use jhbuild for fetching and building dependencies.
13158
13159         Reviewed by Gustavo Noronha Silva.
13160
13161         * Scripts/update-webkitefl-libs: Added.
13162         * Scripts/webkitdirs.pm:
13163         (jhbuildWrapperPrefixIfNeeded):
13164         (generateBuildSystemFromCMakeProject):
13165         (buildCMakeGeneratedProject):
13166         * efl/common.py: Added.
13167         (script_path):
13168         (top_level_path):
13169         (number_of_cpus):
13170         * efl/jhbuild.modules: Added.
13171         * efl/jhbuildrc: Added.
13172         * efl/run-with-jhbuild: Added.
13173
13174 2012-03-16  Stephanie Lewis  <slewis@apple.com>
13175
13176         https://bugs.webkit.org/show_bug.cgi?id=81065
13177         <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
13178         Fix crash preventing WebKitTestRunner from working in Release.
13179         WebKitTestRunner used ostringstream to collect output from the test.  ostringstream is incompatible with our
13180         FastMalloc overrides.  When copying strings out ostringstream a new string is allocated with FastMalloc because
13181         the allocation is inlined.  When that string is freed is uses the system malloc because that call is not inlined.
13182
13183         I removed ostringstream in favor of StringBuilder.
13184
13185         Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
13186
13187         Reviewed by Geoff Garen.
13188
13189         Add DEBUG_DEFINES to set NDEBUG on release builds.
13190         * WebKitTestRunner/Configurations/Base.xcconfig:
13191         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
13192
13193         Remove ostringstream member in favor of StringBuilder.
13194         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
13195         (WTR::InjectedBundle::initialize):
13196         (WTR::InjectedBundle::beginTesting):
13197         (WTR::InjectedBundle::done):
13198         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
13199         (WTF):
13200         (WTR::InjectedBundle::stringBuilder):
13201         (InjectedBundle):
13202
13203         Append output to StringBuilder.
13204         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
13205         (WTR::hasPrefix):
13206         (WTR::dumpPath):
13207         (WTR::rangeToStr):
13208         (WTR::styleDecToStr):
13209         (WTR::frameToStr):
13210         (WTR::dumpFrameScrollPosition):
13211         (WTR::dumpFrameText):
13212         (WTR::dumpDescendantFramesText):
13213         (WTR::InjectedBundlePage::dump):
13214         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
13215         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
13216         (WTR::InjectedBundlePage::willSendRequestForFrame):
13217         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
13218         (WTR::lastFileURLPathComponent):
13219         (WTR::InjectedBundlePage::willAddMessageToConsole):
13220         (WTR::InjectedBundlePage::willSetStatusbarText):
13221         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
13222         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
13223         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
13224         (WTR::InjectedBundlePage::shouldBeginEditing):
13225         (WTR::InjectedBundlePage::shouldEndEditing):
13226         (WTR::InjectedBundlePage::shouldInsertNode):
13227         (WTR::InjectedBundlePage::shouldInsertText):
13228         (WTR::InjectedBundlePage::shouldDeleteRange):
13229         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
13230         (WTR::InjectedBundlePage::shouldApplyStyle):
13231         (WTR::InjectedBundlePage::didBeginEditing):
13232         (WTR::InjectedBundlePage::didEndEditing):
13233         (WTR::InjectedBundlePage::didChange):
13234         (WTR::InjectedBundlePage::didChangeSelection):
13235         (WTR::InjectedBundlePage::supportsFullScreen):
13236         (WTR::InjectedBundlePage::enterFullScreenForElement):
13237         (WTR::InjectedBundlePage::exitFullScreenForElement):
13238         (WTR::InjectedBundlePage::beganEnterFullScreen):
13239         (WTR::InjectedBundlePage::beganExitFullScreen):
13240         (WTR::dumpBackForwardListItem):
13241         (WTR::InjectedBundlePage::dumpBackForwardList):
13242         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13243         (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
13244         (WTR::LayoutTestController::dumpConfigurationForViewport):
13245
13246         Convert between WTF::String and WKStringRef.
13247         * WebKitTestRunner/StringFunctions.h:
13248         (WTR::toWTFString):
13249         (WTR):
13250         * WebKitTestRunner/TestInvocation.cpp:
13251         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
13252
13253 2012-03-16  Eric Seidel  <eric@webkit.org>
13254
13255         Add a land-from-url command
13256         https://bugs.webkit.org/show_bug.cgi?id=81411
13257
13258         Reviewed by Adam Barth.
13259
13260         Very basic so far.  The goal is to make it landing smarter
13261         so that users don't have to bother to parse out the ids out of the urls.
13262
13263         * Scripts/webkitpy/common/config/urls.py:
13264         (parse_bug_id):
13265         (parse_attachment_id):
13266         * Scripts/webkitpy/common/config/urls_unittest.py:
13267         (URLsTest.test_parse_bug_id):
13268         (URLsTest):
13269         (URLsTest.test_parse_attachment_id):
13270         * Scripts/webkitpy/tool/commands/download.py:
13271         (ProcessURLsMixin):
13272         (ProcessURLsMixin._fetch_list_of_patches_to_process):
13273         (LandFromURL):
13274         * Scripts/webkitpy/tool/commands/download_unittest.py:
13275         (test_land_from_bug):
13276         (test_land_from_url):
13277
13278 2012-03-16  Dave Tharp  <dtharp@codeaurora.org>
13279
13280         build-webkit launcher instructions use wrong relative path for Qt
13281         https://bugs.webkit.org/show_bug.cgi?id=81357
13282
13283         Reviewed by Eric Seidel.
13284
13285         Ensure we are at the proper directory before generating run-launcher
13286         instructions.
13287
13288         * Scripts/build-webkit:
13289
13290 2012-03-16  Brady Eidson  <beidson@apple.com>
13291
13292         <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
13293         REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
13294
13295         Reviewed by Geoff Garen.
13296
13297         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13298         * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
13299
13300 2012-03-16  Ojan Vafai  <ojan@chromium.org>
13301
13302         Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
13303         https://bugs.webkit.org/show_bug.cgi?id=81407
13304
13305         Reviewed by Adam Barth.
13306
13307         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13308         (summarize_results):
13309         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
13310         (ResultSummaryTest.summarized_results):
13311         (ResultSummaryTest.test_no_svn_revision):
13312         (ResultSummaryTest.test_svn_revision):
13313         (ResultSummaryTest):
13314         (ResultSummaryTest.test_summarized_results_wontfix):
13315
13316 2012-03-16  Ojan Vafai  <ojan@chromium.org>
13317
13318         Have webkit-patch rebaseline-test update test_expectations.txt
13319         https://bugs.webkit.org/show_bug.cgi?id=81054
13320
13321         Recommit http://trac.webkit.org/changeset/110783 now that
13322         http://trac.webkit.org/changeset/111034 has landed.
13323
13324         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13325         (TestExpectations.remove_configuration_from_test):
13326         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
13327         (RemoveConfigurationsTest):
13328         (RemoveConfigurationsTest.test_remove):
13329         (test_remove_line):
13330         * Scripts/webkitpy/tool/commands/rebaseline.py:
13331         (RebaselineTest._update_expectations_file):
13332         (RebaselineTest._rebaseline_test_and_update_expectations):
13333         (RebaselineTest):
13334         (RebaselineTest.execute):
13335         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13336         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
13337         (test_rebaseline_updates_expectations_file):
13338
13339 2012-03-15  Ojan Vafai  <ojan@chromium.org>
13340
13341         Specifier collapsing when writing test expectations lines gets a number of cases wrong
13342         https://bugs.webkit.org/show_bug.cgi?id=81309
13343
13344         Reviewed by Dimitri Glazkov.
13345
13346         I've run this over all the lines in the current Chromium test_expectations.txt file,
13347         so I'm relatively confident we now cover all the cases.
13348
13349         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
13350         (TestConfigurationConverter.__init__):
13351         (TestConfigurationConverter.collapse_macros):
13352         (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
13353         (TestConfigurationConverter):
13354         (TestConfigurationConverter.intersect_combination):
13355         (TestConfigurationConverter.symmetric_difference):
13356         (TestConfigurationConverter.to_specifiers_list):
13357         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
13358         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
13359         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
13360         (make_mock_all_test_configurations_set):
13361         (TestConfigurationConverterTest.test_symmetric_difference):
13362         (TestConfigurationConverterTest.test_to_config_set):
13363         (TestConfigurationConverterTest.test_macro_expansion):
13364         (TestConfigurationConverterTest.test_to_specifier_lists):
13365         (TestConfigurationConverterTest.test_converter_macro_collapsing):
13366         * Scripts/webkitpy/layout_tests/port/chromium.py:
13367         (ChromiumPort):
13368         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
13369         (ChromiumAndroidPort.__init__):
13370         The android port uses "arm" as it's architecture, which is technically correct,
13371         but considerably complicates making collapsing work. We probably should kill
13372         the concept of architecture entirely. The benefits are not worth the code
13373         complexity.
13374
13375         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
13376         (ChromiumPortTest.test_all_test_configurations):
13377         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13378         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
13379         (test_rebaseline_updates_expectations_file):
13380
13381 2012-03-16  Dinu Jacob  <dinu.jacob@nokia.com>
13382
13383         [Qt][Wk2] Assertion Failure and crash on file upload
13384         https://bugs.webkit.org/show_bug.cgi?id=80854
13385
13386         Reviewed by Simon Hausmann.
13387
13388         Added filePicker to WebView using experimental API.
13389
13390         * MiniBrowser/qt/MiniBrowser.qrc:
13391         * MiniBrowser/qt/icons/folder.png: Added.
13392         * MiniBrowser/qt/icons/titlebar.png: Added.
13393         * MiniBrowser/qt/icons/up.png: Added.
13394         * MiniBrowser/qt/qml/BrowserWindow.qml:
13395         * MiniBrowser/qt/qml/FilePicker.qml: Added.
13396
13397 2012-03-16  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
13398
13399         Updating email for committer.py script.
13400
13401         * Scripts/webkitpy/common/config/committers.py:
13402
13403 2012-03-16  Robert Kroeger  <rjkroege@chromium.org>
13404
13405         [chromium] DRT: Add support for sending gesture scrolls without a begin
13406         https://bugs.webkit.org/show_bug.cgi?id=81292
13407
13408         Reviewed by Kent Tamura.
13409
13410         * DumpRenderTree/chromium/EventSender.cpp:
13411         (EventSender::EventSender):
13412         (EventSender::gestureScrollFirstPoint):
13413         * DumpRenderTree/chromium/EventSender.h:
13414         (EventSender):
13415
13416 2012-03-02  Carlos Garcia Campos  <cgarcia@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
13417
13418         [GTK] WebKitIconDatabase doesn't keep icons cached
13419         https://bugs.webkit.org/show_bug.cgi?id=56200
13420
13421         Reviewed by Martin Robinson.
13422
13423         Add support for favicons in GtkLauncher.
13424
13425         * GtkLauncher/main.c:
13426         (activateUriEntryCb):
13427         (iconLoadedCb):
13428         (createBrowser):
13429
13430 2012-03-16  Adam Barth  <abarth@webkit.org>
13431
13432         Remove sheriff-bot's last-green-revision command
13433         https://bugs.webkit.org/show_bug.cgi?id=81314
13434
13435         Reviewed by Eric Seidel.
13436
13437         This command is a cruel joke.  WebKit doesn't really ever have a
13438         last-green-revision.
13439
13440         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
13441         (BuildBot._find_green_revision):
13442         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
13443         (MockBuildBot.builder_statuses):
13444         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
13445         (test_find_green_revision):
13446         * Scripts/webkitpy/tool/bot/irc_command.py:
13447         (IRCCommand.execute):
13448         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
13449         (SheriffIRCBotTest.test_help):
13450         * Scripts/webkitpy/tool/commands/queries.py:
13451         (PatchesToReview.execute):
13452
13453 2012-03-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
13454
13455         [Qt] Make gccdepends test aware of broken icecream deps generation
13456
13457         Icecream seems to build the files without passing -o to gcc with
13458         the original destination path, which means the target name in the
13459         dependency file is wrong.
13460
13461         Also, echo something to the final file instead of just touching it,
13462         so it's not deleted on every build.
13463
13464         Reviewed by Simon Hausmann.
13465
13466         * qmake/config.tests/gccdepends/gccdepends.pro:
13467
13468 2012-03-16  Kihong Kwon  <kihong.kwon@samsung.com>
13469
13470         Support for Battery Status API
13471         https://bugs.webkit.org/show_bug.cgi?id=62698
13472
13473         Add include directory and file.
13474         http://www.w3.org/TR/battery-status/
13475
13476         Reviewed by Adam Barth.
13477
13478         * Scripts/build-webkit:
13479
13480 2012-03-16  Kishore Bolisetty  <kbolisetty@innominds.com>
13481
13482         check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
13483         https://bugs.webkit.org/show_bug.cgi?id=81007
13484
13485         Reviewed by Adam Barth.
13486
13487         A dedidcated build slave is available for efl on build.webkit.org.
13488         This change add's an entry for the elf port in list of available port builders.
13489         This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.
13490
13491         * Scripts/webkitpy/layout_tests/port/builders.py:
13492
13493 2012-03-16  Adam Barth  <abarth@webkit.org>
13494
13495         [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
13496         https://bugs.webkit.org/show_bug.cgi?id=81302
13497
13498         Reviewed by Eric Seidel.
13499
13500         This is a trivial patch, but the variable name turned up in a grep of
13501         webkitpy and looks like copy pasta.
13502
13503         * Scripts/webkitpy/common/net/statusserver.py:
13504         (StatusServer.next_work_item):
13505
13506 2012-03-16  Andrew Lo  <anlo@rim.com>
13507
13508         [BlackBerry] Enable PAGE_VISIBILITY_API
13509         https://bugs.webkit.org/show_bug.cgi?id=81257
13510
13511         Enable Page Visibility API for BlackBerry.
13512
13513         Reviewed by Rob Buis.
13514
13515         * Scripts/build-webkit:
13516
13517 2012-03-16  Zan Dobersek  <zandobersek@gmail.com>
13518
13519         [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
13520         https://bugs.webkit.org/show_bug.cgi?id=81232
13521
13522         Reviewed by Philippe Normand.
13523
13524         Use the newly-added helper method in DumpRenderTreeSupportGtk.
13525
13526         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
13527         (LayoutTestController::computedStyleIncludingVisitedInfo):
13528
13529 2012-03-15  Eric Seidel  <eric@webkit.org>
13530
13531         Move parse_bug_id into config/urls in preparation for re-use elsewhere.
13532         https://bugs.webkit.org/show_bug.cgi?id=81313
13533
13534         Reviewed by Adam Barth.
13535
13536         * Scripts/webkitpy/common/checkout/changelog.py:
13537         (parse_bug_id_from_changelog):
13538         * Scripts/webkitpy/common/config/urls.py:
13539         (parse_bug_id):
13540         * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
13541         (URLsTest):
13542         (URLsTest.test_parse_bug_id):
13543         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
13544         (test_parse_bug_id):
13545         * Scripts/webkitpy/tool/bot/irc_command.py:
13546         (_post_error_and_check_for_bug_url):
13547         * Scripts/webkitpy/tool/bot/sheriff.py:
13548         (Sheriff.post_rollout_patch):
13549         (Sheriff.post_chromium_deps_roll):
13550
13551 2012-03-15  Adam Barth  <abarth@webkit.org>
13552
13553         The commit-queue should fast-track patches that have already passed the testing EWS bots
13554         https://bugs.webkit.org/show_bug.cgi?id=81305
13555
13556         Reviewed by Eric Seidel.
13557
13558         If a patch has already passed the testing EWS bots (currently only the
13559         chromium-ews bot), we should be able to land the patch without running
13560         the tests again.  This patch is somewhat risky in that the tests might
13561         have been broken between when the EWS bots ran and when the
13562         commit-queue is processing the patch.  If that turns out to be a
13563         problem in practice, we'll tighten up this fast-track in some way,
13564         likely by making sure that the pass status is recent.
13565
13566         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
13567         (CommitQueueTaskDelegate.did_pass_testing_ews):
13568         (CommitQueueTask._did_pass_tests_recently):
13569         (CommitQueueTask.run):
13570         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
13571         (MockCommitQueue.did_pass_testing_ews):
13572         (test_fast_success_case):
13573         * Scripts/webkitpy/tool/commands/queues.py:
13574         (CommitQueue.did_pass_testing_ews):
13575         * Scripts/webkitpy/tool/commands/queues_unittest.py:
13576         (test_did_pass_testing_ews):
13577
13578 2012-03-15  Kentaro Hara  <haraken@chromium.org>
13579
13580         [PerformanceTests] run-perf-tests should output correct units
13581         https://bugs.webkit.org/show_bug.cgi?id=78303
13582
13583         Reviewed by Ryosuke Niwa.
13584
13585         Previously run-perf-tests just supported "ms" for units.
13586         Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
13587         This patch fixes run-perf-tests so that they can support custom units.
13588         The default unit is "ms".
13589
13590         The test result looks like this:
13591
13592         $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
13593         RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
13594         median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
13595
13596         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
13597         (PerfTestsRunner._process_parser_test_result):
13598
13599 2012-03-15  Brent Fulgham  <bfulgham@webkit.org>
13600
13601         [WinCairo] Unreviewed build change after wtf path changes.
13602
13603         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
13604         directories to look at the private header directory to find 'wtf'.
13605
13606 2012-03-15  Kent Tamura  <tkent@chromium.org>
13607
13608         REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
13609         https://bugs.webkit.org/show_bug.cgi?id=81293
13610
13611         Reviewed by Adam Barth.
13612
13613         r110595 introduced new format of the author field of ChangeLog entry:
13614         "Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>"
13615         Updte chanelog.py to support it.
13616
13617         * Scripts/webkitpy/common/checkout/changelog.py:
13618         (ChangeLogEntry._split_contributor_names):
13619         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
13620         (test_parse_authors):
13621
13622 2012-03-15  Lynn Neir  <lynn.neir@skype.net>
13623
13624         Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
13625
13626         Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
13627
13628         Reviewed by Jessie Berlin.
13629
13630         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
13631         (LayoutTestController::setValueForUser):
13632         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
13633         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13634         (WTR::LayoutTestController::setValueForUser):
13635         (WTR):
13636         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
13637         (LayoutTestController):
13638
13639 2012-03-15  Adam Barth  <abarth@webkit.org>
13640
13641         Update the start-queue.sh script to match what we're using on the bots
13642         https://bugs.webkit.org/show_bug.cgi?id=81277
13643
13644         Reviewed by Eric Seidel.
13645
13646         Over time we've added more magic git commands to clean up the local repo after
13647         it has been borked in various ways. The idea behind this sequence is to clear
13648         out any changes in the working copy and then to rebuild the master branch from
13649         origin/master.
13650
13651         This patch also removes the watchdog timer that we've stopped using on the
13652         bots.
13653
13654         This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
13655         Note: Eric and I are experimenting with GitHub to see if it might be
13656         useful for WebKit.  If you have thoughts on this topic, please feel
13657         free to grab Eric or me on #webkit to chat.  I assume that he and I are
13658         the only ones who care about this file so using this alternative
13659         process for this patch shouldn't cause any trouble.
13660
13661         * EWSTools/start-queue.sh:
13662
13663 2012-03-15  Adam Barth  <abarth@webkit.org>
13664
13665         The commit-queue can hang when the test_expectations.txt style check fails during commit
13666         https://bugs.webkit.org/show_bug.cgi?id=81251
13667
13668         Reviewed by Eric Seidel.
13669
13670         We forgot to check the --non-interactive flag, so we end up prompting
13671         the "user" who doesn't exist on the bot.  We might consider teaching
13672         the User class about non-interactive if we have this sort of bug again.
13673
13674         * Scripts/webkitpy/tool/steps/commit.py:
13675         (Commit.options):
13676         (Commit._check_test_expectations):
13677         (Commit.run):
13678         * Scripts/webkitpy/tool/steps/commit_unittest.py:
13679         (CommitTest.test_check_test_expectations):
13680
13681 2012-03-15  Jessie Berlin  <jberlin@apple.com>
13682
13683         fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
13684         Mac WK2 because WebAudio is not enabled
13685         https://bugs.webkit.org/show_bug.cgi?id=81259
13686
13687         Reviewed by Dan Bernstein.
13688
13689         Enable WebAudio so that it appears in the window object in the tests.
13690         The webaudio tests are all still skipped in the Mac Skipped list.
13691
13692         * WebKitTestRunner/TestController.cpp:
13693         (WTR::TestController::resetStateToConsistentValues):
13694
13695 2012-03-15  David Levin  <levin@chromium.org>
13696
13697         Various autoresize fixes.
13698         https://bugs.webkit.org/show_bug.cgi?id=81199
13699
13700         Reviewed by Darin Fisher.
13701
13702         * DumpRenderTree/chromium/LayoutTestController.cpp:
13703         (LayoutTestController::reset): Stop using the deprecated api that was removed.
13704
13705 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
13706
13707         [GTK] Actually use --release and --debug command line options in run-gtk-test
13708         https://bugs.webkit.org/show_bug.cgi?id=81234
13709
13710         Reviewed by Philippe Normand.
13711
13712         Actually handle --release and --debug command line options to
13713         create the build directory, falling back to current hack to detect
13714         whether it's a Release or Debug build when both options are missed.
13715
13716         * Scripts/run-gtk-tests:
13717         (TestRunner.__init__): Receive options too.
13718         (TestRunner._get_top_level_directory): Helper function to get the
13719         top level directory.
13720         (TestRunner._get_build_directory): Helper function to get the
13721         build directory depending on --release/--debug command line
13722         options or gessing it if both options are missing.
13723         (TestRunner._ensure_accessibility_daemon_is_running): Use
13724         self-options now.
13725         (TestRunner.run): Ditto.
13726         (TestRunner.run.run_tests): Pass options to the constructor
13727         instead of run().
13728
13729 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
13730
13731         [GTK] Run unit tests with --verbose in the bots
13732         https://bugs.webkit.org/show_bug.cgi?id=81230
13733
13734         Reviewed by Martin Robinson.
13735
13736         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
13737         (RunGtkAPITests): Add --verbose to run-gtk-test command.
13738
13739 2012-03-15  Kevin Ollivier  <kevino@theolliviers.com>
13740
13741         Move wx port to using export macros
13742         https://bugs.webkit.org/show_bug.cgi?id=77279
13743
13744         Reviewed by Hajime Morita.
13745
13746         * waf/build/settings.py:
13747         (common_configure):
13748
13749 2012-03-15  Philippe Normand  <pnormand@igalia.com>
13750
13751         Unreviewed, GTK build fix attempt after r110845.
13752
13753         * Scripts/run-gtk-tests: Added --release and --debug options.
13754
13755 2012-03-15  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
13756
13757         Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
13758         https://bugs.webkit.org/show_bug.cgi?id=79673
13759
13760         Preparatory work for bringing jhbuild enabled build to EFL port.
13761
13762         Reviewed by Philippe Normand.
13763
13764         * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
13765         * Scripts/update-webkitgtk-libs:
13766         * gtk/run-with-jhbuild:
13767         * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
13768         (top_level_path):
13769         (jhbuild_installed):
13770         (jhbuild_cloned):
13771         (jhbuild_at_expected_revision):
13772         (update_jhbuild):
13773         (clone_jhbuild):
13774         (install_jhbuild):
13775         (update_webkit_libs_jhbuild):
13776         (determine_platform):
13777         (ensure_jhbuild):
13778
13779 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
13780
13781         [GTK] Add command line options to run-gtk-tests script
13782         https://bugs.webkit.org/show_bug.cgi?id=81218
13783
13784         Reviewed by Philippe Normand.
13785
13786         Following command line options have been added:
13787
13788         -v, --verbose: to run gtester with --verbose. That would be used
13789         by the bots to make it easier to know which test case it failing.
13790
13791         --display: to use a different display for Xvfb
13792
13793         It's also possible to pass one or more tests as arguments.
13794
13795         * Scripts/run-gtk-tests:
13796         (TestRunner.__init__): Receive command line arguments.
13797         (TestRunner._get_tests): Get all the tests or the ones passed by
13798         command line arguments.
13799         (TestRunner._ensure_accessibility_daemon_is_running): Use display
13800         command line argument.
13801         (TestRunner.run): Pas command line options.
13802         (TestRunner.run.run_tests): Pass command line arguments.
13803
13804 2012-03-15  Carlos Garcia Campos  <cgarcia@igalia.com>
13805
13806         [GTK] WebKit2APITests/TestPrinting timeout in the bots
13807         https://bugs.webkit.org/show_bug.cgi?id=81211
13808
13809         Reviewed by Philippe Normand.
13810
13811         Add gtk+ patch to fix timeout in the bots. A similar patch has
13812         already landed in updatream gtk+, see
13813         http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
13814
13815         * gtk/jhbuild.modules:
13816         * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
13817
13818 2012-03-14  Gustavo Noronha Silva  <gns@gnome.org>
13819
13820         sheriffbot should also be addressable with a comma in addition to colon
13821         https://bugs.webkit.org/show_bug.cgi?id=81101
13822
13823         Reviewed by Adam Barth.
13824
13825         * Scripts/webkitpy/common/net/irc/ircbot.py:
13826         (IRCBot.on_pubmsg):
13827
13828 2012-03-15  Alexander Færøy  <alexander.faeroy@nokia.com>
13829
13830         [Qt] MiniBrowser scroll indicators should not scroll out of view
13831         https://bugs.webkit.org/show_bug.cgi?id=81131
13832
13833         Reviewed by Kenneth Rohde Christiansen.
13834
13835         * MiniBrowser/qt/qml/ScrollIndicator.qml:
13836
13837 2012-03-14  Chris Fleizach  <cfleizach@apple.com>
13838
13839         AX: ARIA tables need to support selected rows attribute/select rows changed notification
13840         https://bugs.webkit.org/show_bug.cgi?id=79821
13841
13842         Reviewed by Beth Dakin.
13843
13844         * DumpRenderTree/AccessibilityUIElement.cpp:
13845         (rowAtIndexCallback):
13846         (AccessibilityUIElement::getJSClass):
13847         * DumpRenderTree/AccessibilityUIElement.h:
13848         (AccessibilityUIElement):
13849         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
13850         (AccessibilityUIElement::rowAtIndex):
13851         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
13852         (AccessibilityUIElement::rowAtIndex):
13853         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
13854         (AccessibilityUIElement::rowAtIndex):
13855         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
13856         (AccessibilityUIElement::rowAtIndex):
13857
13858 2012-03-14  Tim Horton  <timothy_horton@apple.com>
13859
13860         NRWT should respect --additional-platform-directory's Skipped list
13861         https://bugs.webkit.org/show_bug.cgi?id=81172
13862
13863         Reviewed by Timothy Hatcher.
13864
13865         Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
13866         from said path are already used, but the Skipped file is ignored.
13867
13868         * Scripts/webkitpy/layout_tests/port/webkit.py:
13869         (WebKitPort._skipped_file_search_paths):
13870         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
13871         (test_skipped_file_search_paths):
13872
13873 2012-03-14  Ojan Vafai  <ojan@chromium.org>
13874
13875         Unreviewed, rolling out r110783.
13876         http://trac.webkit.org/changeset/110783
13877         https://bugs.webkit.org/show_bug.cgi?id=81054
13878
13879         Caused existing test expectation lines to expand to one for
13880         each test configuration.
13881
13882         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13883         (TestExpectations.has_warnings):
13884         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
13885         (test_macro_overrides):
13886         * Scripts/webkitpy/tool/commands/rebaseline.py:
13887         (RebaselineTest._save_baseline):
13888         (RebaselineTest._rebaseline_test):
13889         (RebaselineTest.execute):
13890         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13891         (TestRebaseline.test_tests_to_update):
13892
13893 2012-03-13  Jon Lee  <jonlee@apple.com>
13894
13895         Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
13896         https://bugs.webkit.org/show_bug.cgi?id=80922
13897         <rdar://problem/11035082>
13898
13899         Reviewed by Jian Li.
13900
13901         You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
13902         LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
13903         new API. Therefore, APIs that are common between the two will have:
13904         #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
13905
13906         This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
13907         the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
13908
13909         Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
13910         * DumpRenderTree/chromium/LayoutTestController.cpp:
13911         (LayoutTestController::grantDesktopNotificationPermission):
13912         (LayoutTestController::simulateDesktopNotificationClick):
13913         * DumpRenderTree/chromium/NotificationPresenter.cpp:
13914         * DumpRenderTree/chromium/TestShell.cpp:
13915         (TestShell::TestShell):
13916         (TestShell::resetTestController):
13917         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
13918         (DRTDesktopNotificationPresenter::checkNotificationPermission):
13919
13920 2012-03-13  Ojan Vafai  <ojan@chromium.org>
13921
13922         Have webkit-patch rebaseline-test update test_expectations.txt
13923         https://bugs.webkit.org/show_bug.cgi?id=81054
13924
13925         Reviewed by Dirk Pranke.
13926
13927         This will allow us to use the All Failures tab in garden-o-matic
13928         to rebaseline tests without making test_expectations.txt stale.
13929
13930         It's conservative and only removes lines if the test is
13931         not flaky and fails in a way the rebaseline would fix (e.g.
13932         CRASH/TIMEOUT will not be touched).
13933
13934         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13935         (TestExpectations.remove_configuration_from_test):
13936         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
13937         (RemoveConfigurationsTest):
13938         (RemoveConfigurationsTest.test_remove):
13939         (test_remove_line):
13940         * Scripts/webkitpy/tool/commands/rebaseline.py:
13941         (RebaselineTest._is_supported_port):
13942         (RebaselineTest):
13943         (RebaselineTest._update_expectations_file):
13944         (RebaselineTest._rebaseline_test_and_update_expectations):
13945         (RebaselineTest.execute):
13946         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
13947         (TestRebaseline.test_rebaseline_updates_expectations_file):
13948
13949 2012-03-14  Jessie Berlin  <jberlin@apple.com>
13950
13951         Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
13952         https://bugs.webkit.org/show_bug.cgi?id=81167
13953
13954         Reviewed by Sam Weinig.
13955
13956         Do not use 0 as a key in a HashMap.
13957
13958         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13959         cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
13960
13961 2012-03-14  Ojan Vafai  <ojan@chromium.org>
13962
13963         Add the chromium lion bot to garden-o-matic and remove
13964         the platform_move_to in builders.py since the Chromium Lion
13965         port is now a normal port.
13966
13967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
13968         * Scripts/webkitpy/layout_tests/port/builders.py:
13969
13970 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
13971
13972         Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
13973
13974         Unreviewed, build fix.
13975
13976         * Scripts/webkitpy/layout_tests/port/base.py:
13977         (Port.skipped_tests):
13978
13979 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
13980
13981         Please add a way to manually skip some tests in NRWT
13982         https://bugs.webkit.org/show_bug.cgi?id=81019
13983
13984         Reviewed by Ojan Vafai.
13985
13986         This patch implements the -i / --ignore-tests flag from ORWT
13987         and refactors the test_expectations.py code slightly to handle
13988         it.
13989
13990         * Scripts/webkitpy/layout_tests/controllers/manager.py:
13991         (Manager.parse_expectations):
13992         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
13993         (TestExpectations.__init__):
13994         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
13995         (test_add_skipped_tests):
13996         (test_add_skipped_tests_duplicate):
13997         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
13998         (parse_args):
13999         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
14000         (MainTest.test_ignore_tests):
14001         (MainTest.test_ignore_tests.assert_ignored):
14002
14003 2012-03-14  Dirk Pranke  <dpranke@chromium.org>
14004
14005         nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
14006         https://bugs.webkit.org/show_bug.cgi?id=81028
14007
14008         Reviewed by Ojan Vafai.
14009
14010         The mac port had incorrect lookups for 'mac-lion' and
14011         'mac-future' in some places. This patch fixes that and adds a
14012         bunch of tests.
14013
14014         * Scripts/webkitpy/layout_tests/port/mac.py:
14015         (MacPort.baseline_path):
14016         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
14017         (MacTest.assert_skipped_file_search_paths):
14018         (MacTest.test_skipped_file_search_paths):
14019         (_assert_search_path):
14020         (test_baseline_search_path):
14021         * Scripts/webkitpy/layout_tests/port/webkit.py:
14022         (WebKitPort._skipped_file_search_paths):
14023
14024 2012-03-13  Jer Noble  <jer.noble@apple.com>
14025
14026         Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
14027         https://bugs.webkit.org/show_bug.cgi?id=81056
14028
14029         Reviewed by Jessie Berlin.
14030
14031         Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
14032
14033         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
14034         (WTR::InjectedBundlePage::InjectedBundlePage):
14035         (WTR::InjectedBundlePage::beganEnterFullScreen):
14036         (WTR::InjectedBundlePage::beganExitFullScreen):
14037
14038 2012-03-14  Alexander Færøy  <alexander.faeroy@nokia.com>
14039
14040         The width and height of the scroll indicators in the MiniBrowser does
14041         not consider the offset margins.
14042         https://bugs.webkit.org/show_bug.cgi?id=81112
14043
14044         Reviewed by Kenneth Rohde Christiansen.
14045
14046         This patch fixes the issue by withdrawing two times the anchor
14047         margins.
14048
14049         * MiniBrowser/qt/qml/ScrollIndicator.qml:
14050
14051 2012-03-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
14052
14053         [EFL] Implement LayoutTestController::clearBackForwardList
14054         https://bugs.webkit.org/show_bug.cgi?id=80142
14055
14056         Adding missing implementation clearBackForwardList to EFL's
14057         LayoutTestController. This implementation allows us to unskip
14058         tests connected with history.
14059
14060         Reviewed by Antonio Gomes.
14061
14062         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
14063         (LayoutTestController::clearBackForwardList): Implemented.
14064
14065 2012-03-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
14066
14067         [EFL][DRT] Expose window.internals object
14068         https://bugs.webkit.org/show_bug.cgi?id=79900
14069
14070         Exposes window.internals for EFL's DRT. Makes possible to
14071         remove some tests from the skip list.
14072
14073         Reviewed by Antonio Gomes.
14074
14075         * DumpRenderTree/efl/CMakeLists.txt:
14076         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
14077         (DumpRenderTreeChrome::onWindowObjectCleared):
14078
14079 2012-03-13  Adam Barth  <abarth@webkit.org> && Benjamin Poulain  <bpoulain@apple.com>
14080
14081         Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
14082         https://bugs.webkit.org/show_bug.cgi?id=78853
14083
14084         Reviewed by Adam Barth.
14085
14086         * Scripts/build-webkit:
14087         * qmake/mkspecs/features/features.prf:
14088
14089 2012-03-12  Antonio Gomes  <agomes@rim.com>
14090
14091         Convert nodesFromRect tests to use Internals interface
14092         https://bugs.webkit.org/show_bug.cgi?id=80886
14093
14094         Reviewed by Ryosuke Niwa.
14095
14096         This clean up allows to remove port specific bits of each
14097         DRT implementation that supports testing Document::nodesFromRect,
14098         in favor of making use of the 'Internals' interface to test it.
14099
14100         This makes its code conveniently more expansible and cleaner.
14101
14102         Also removed stubs from Win and EFL DRTs.
14103
14104         * DumpRenderTree/LayoutTestController.cpp:
14105         (LayoutTestController::staticFunctions):
14106         * DumpRenderTree/LayoutTestController.h:
14107         (LayoutTestController):
14108         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
14109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
14110         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
14111         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
14112         * DumpRenderTree/qt/LayoutTestControllerQt.h:
14113         (LayoutTestController):
14114         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
14115
14116 2012-03-13  Ojan Vafai  <ojan@chromium.org>
14117
14118         Rebaselining for a new port doesn't work right with multiple fallback ports
14119         https://bugs.webkit.org/show_bug.cgi?id=80932
14120
14121         Reviewed by Adam Barth.
14122
14123         Since chromium-leopard also falls back to mac-leopard, we need to
14124         copy the existing result for both chromium-leopard and chromium-snowleopard
14125         before doing lion rebaselines.
14126
14127         * Scripts/webkitpy/layout_tests/port/builders.py:
14128         (fallback_port_names_for_new_port):
14129         * Scripts/webkitpy/tool/commands/rebaseline.py:
14130         (RebaselineTest):
14131         (RebaselineTest._copy_existing_baseline):
14132         (RebaselineTest._rebaseline_test):
14133         (RebaselineTest.execute):
14134         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
14135         * Scripts/webkitpy/tool/servers/gardeningserver.py:
14136         (GardeningHTTPRequestHandler.rebaseline):
14137         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
14138         (GardeningServerTest.test_rebaseline_new_port):
14139
14140 2012-03-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14141
14142         [Qt] Tweak minibrowser UI
14143
14144         Add some margins to the scroll indicators, and set a dark background
14145         color so you see the page dimensions.
14146
14147         Reviewed by Antonio Gomes.
14148
14149         * MiniBrowser/qt/qml/BrowserWindow.qml:
14150         * MiniBrowser/qt/qml/ScrollIndicator.qml:
14151
14152 2012-03-13  ChangSeok Oh  <shivamidow@gmail.com>
14153
14154         [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
14155         https://bugs.webkit.org/show_bug.cgi?id=79601
14156
14157         Reviewed by Gustavo Noronha Silva.
14158
14159         Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
14160         createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
14161         and is taken over to sendKeyDown.
14162         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
14163         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
14164
14165         * DumpRenderTree/efl/EventSender.cpp:
14166         (KeyEventInfo::KeyEventInfo):
14167         (KeyEventInfo):
14168         (createKeyEventInfo):
14169         (sendKeyDown):
14170         (keyDownCallback):
14171         (sendAsynchronousKeyDown):
14172         (scheduleAsynchronousKeyDownCallback):
14173
14174 2012-03-12  Ojan Vafai  <ojan@chromium.org>
14175
14176         webkit-patch optimize-baselines sometimes creates a mac-future result
14177         https://bugs.webkit.org/show_bug.cgi?id=80717
14178
14179         Reviewed by Adam Barth.
14180
14181         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
14182         (_baseline_search_hypergraph):
14183         (BaselineOptimizer._find_optimal_result_placement):
14184         (BaselineOptimizer._filter_virtual_ports):
14185         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
14186         (BaselineOptimizerTest.test_no_add_mac_future):
14187
14188 2012-03-12  Jessie Berlin  <jberlin@apple.com>
14189
14190         More Windows build fixing.
14191
14192         * DumpRenderTree/win/WorkQueueItemWin.cpp:
14193
14194 2012-03-12  Jessie Berlin  <jberlin@apple.com>
14195
14196         More Windows build fixing.
14197
14198         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
14199         * DumpRenderTree/win/EditingDelegate.cpp:
14200         * DumpRenderTree/win/EventSender.cpp:
14201         * DumpRenderTree/win/FrameLoadDelegate.cpp:
14202         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
14203         * DumpRenderTree/win/UIDelegate.cpp:
14204
14205 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
14206
14207         remove the 'gpu' group from the flakiness dashboard
14208         https://bugs.webkit.org/show_bug.cgi?id=80353
14209
14210         Reviewed by Adam Barth.
14211
14212         Since those bots are obsolete, we don't need this any more.
14213
14214         * TestResultServer/static-dashboards/builders.js:
14215         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
14216         (testPlatformAndBuildType):
14217         (testHtmlForTestTypeSwitcherGroup):
14218
14219 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
14220
14221         remove graphics_type from webkitpy.layout_tests.models.test_configuration
14222         https://bugs.webkit.org/show_bug.cgi?id=80643
14223
14224         Reviewed by Ojan Vafai.
14225
14226         Now that the chromium-gpu ports are gone, there's no need for
14227         the graphics_type CPU/GPU distinction. Most of this change is
14228         just updating tests accordingly.
14229
14230         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
14231         (TestExpectationEditorTests):
14232         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
14233         (TestConfiguration.__init__):
14234         (TestConfiguration.category_order):
14235         (TestConfiguration.__str__):
14236         (TestConfiguration.__repr__):
14237         (TestConfiguration.__hash__):
14238         (TestConfigurationConverter.to_specifiers_list):
14239         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
14240         (make_mock_all_test_configurations_set):
14241         (TestConfigurationTest.test_items):
14242         (TestConfigurationTest.test_keys):
14243         (TestConfigurationTest.test_str):
14244         (TestConfigurationTest.test_repr):
14245         (TestConfigurationTest.test_hash):
14246         (TestConfigurationTest.test_hash.query_unknown_key):
14247         (TestConfigurationTest.test_eq):
14248         (TestConfigurationTest.test_values):
14249         (SpecifierSorterTest.test_specifier_priority):
14250         (SpecifierSorterTest.test_sort_specifiers):
14251         (TestConfigurationConverterTest.test_to_config_set):
14252         (TestConfigurationConverterTest.test_macro_expansion):
14253         (TestConfigurationConverterTest.test_to_specifier_lists):
14254         (TestConfigurationConverterTest.test_converter_macro_collapsing):
14255         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
14256         (test_error_on_different_build_type):
14257         (TestExpectationSerializerTests.test_parsed_to_string):
14258         (TestExpectationSerializerTests.test_reconstitute_only_these):
14259         * Scripts/webkitpy/layout_tests/port/apple.py:
14260         (ApplePort._generate_all_test_configurations):
14261         * Scripts/webkitpy/layout_tests/port/base.py:
14262         (Port.__init__):
14263         (Port.name):
14264         (Port.version):
14265         (Port.test_configuration):
14266         * Scripts/webkitpy/layout_tests/port/builders.py:
14267         * Scripts/webkitpy/layout_tests/port/chromium.py:
14268         (ChromiumPort):
14269         (ChromiumPort._generate_all_test_configurations):
14270         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
14271         (ChromiumLinuxPort.__init__):
14272         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
14273         (ChromiumLinuxPortTest.test_check_illegal_port_names):
14274         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
14275         (ChromiumMacPortTest.test_baseline_path):
14276         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
14277         (ChromiumPortTest.test_all_test_configurations):
14278         * Scripts/webkitpy/layout_tests/port/efl.py:
14279         (EflPort._generate_all_test_configurations):
14280         * Scripts/webkitpy/layout_tests/port/gtk.py:
14281         (GtkPort._generate_all_test_configurations):
14282         * Scripts/webkitpy/layout_tests/port/qt.py:
14283         (QtPort._generate_all_test_configurations):
14284         * Scripts/webkitpy/layout_tests/port/test.py:
14285         (TestPort.all_test_configurations):
14286         (TestPort._all_build_types):
14287         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
14288         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
14289         (BuildCoverageExtrapolatorTest.test_extrapolate):
14290         (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
14291         (GardeningExpectationsUpdaterTest.test_add_new_expectation):
14292         (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
14293         (GardeningExpectationsUpdaterTest.test_pass_expectation):
14294         (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
14295         (GardeningExpectationsUpdaterTest.test_spurious_updates):
14296
14297 2012-03-12  Dirk Pranke  <dpranke@chromium.org>
14298
14299         _runtime_feature_list isn't supported on Apple Mac DRT
14300         https://bugs.webkit.org/show_bug.cgi?id=80906
14301
14302         Reviewed by Eric Seidel.
14303
14304         It looks like this feature is actually only supported on the Win
14305         DRT port, so this patch reworks the code to make that clearer
14306         and reduce unnecessary overrides.
14307
14308         * Scripts/webkitpy/layout_tests/port/efl.py:
14309         (EflPort._path_to_webcore_library):
14310         * Scripts/webkitpy/layout_tests/port/gtk.py:
14311         (GtkPort._path_to_webcore_library):
14312         * Scripts/webkitpy/layout_tests/port/qt.py:
14313         (QtPort._skipped_file_search_paths):
14314         * Scripts/webkitpy/layout_tests/port/webkit.py:
14315         (WebKitPort._runtime_feature_list):
14316         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
14317         (TestWebKitPort.__init__):
14318         (TestWebKitPort.all_test_configurations):
14319         (test_skipped_directories_for_features):
14320         * Scripts/webkitpy/layout_tests/port/win.py:
14321         (WinPort):
14322         (WinPort._runtime_feature_list):
14323         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
14324         (WinPortTest.test_operating_system):
14325         (WinPortTest):
14326         (WinPortTest.test_runtime_feature_list):
14327
14328 2012-03-12  Peter Beverloo  <peter@chromium.org>
14329
14330         [Chromium] Temporary build-fix for the Android bot
14331         https://bugs.webkit.org/show_bug.cgi?id=80862
14332
14333         Reviewed by Adam Barth.
14334
14335         Manually set the environmental variables required to compile source
14336         files through the Android NDK instead of relying on the envsetup.sh
14337         script. A proper fix will be landed to Chromium ASAP, and following
14338         a Chromium roll into WebKit this code will be removed.
14339
14340         * Scripts/webkitdirs.pm:
14341         (buildChromiumMakefile):
14342
14343 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14344
14345         [Qt] Use right construct to detect config_test_gccdepends
14346
14347         Reviewed by Andreas Kling.
14348
14349         * qmake/mkspecs/features/default_pre.prf:
14350
14351 2012-03-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14352
14353         [Qt] Expose location of WebKit's bin and imports dir through module file
14354
14355         Reviewed by Andreas Kling.
14356
14357         * qmake/qt_webkit.pri:
14358
14359 2012-03-12  Andras Becsi  <andras.becsi@nokia.com>
14360
14361         [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
14362         https://bugs.webkit.org/show_bug.cgi?id=80832
14363
14364         Reviewed by Tor Arne Vestbø.
14365
14366         Add a basic scroll indicator component to MiniBrowser so that it
14367         behaves similar to the ScrollDecorator QML component.
14368
14369         * MiniBrowser/qt/MiniBrowser.qrc:
14370         * MiniBrowser/qt/qml/BrowserWindow.qml:
14371         * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
14372
14373 2012-03-12  C Anthony Risinger  <anthony@xtfx.me>
14374
14375         [GTK] r110296 included an extra $ in @$(AM_V_GEN)
14376         https://bugs.webkit.org/show_bug.cgi?id=80809
14377
14378         Reviewed by Philippe Normand.
14379
14380         * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
14381
14382 2012-03-12  Ming Xie  <mxie@rim.com>
14383
14384         [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
14385         https://bugs.webkit.org/show_bug.cgi?id=80812
14386
14387         Reviewed by Rob Buis.
14388
14389         * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
14390         * Scripts/webkitdirs.pm:
14391         (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
14392
14393
14394 2012-03-12  Simon Hausmann  <simon.hausmann@nokia.com>
14395
14396         [Qt] Fix build with newer Qt 5.
14397
14398         Reviewed by Tor Arne Vestbø.
14399
14400         Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
14401         renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
14402         we should disable -Werror.
14403
14404         Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
14405         implicit load was removed recently.
14406
14407         * qmake/mkspecs/features/default_pre.prf:
14408         * qmake/mkspecs/features/unix/default_post.prf:
14409
14410 2012-03-11  Maciej Stachowiak  <mjs@apple.com>
14411
14412         Add --instruments option to sunspider to profile with Instruments
14413         https://bugs.webkit.org/show_bug.cgi?id=80783
14414
14415         Reviewed by Filip Pizlo.
14416
14417         * Scripts/run-sunspider:
14418
14419 2012-03-11  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
14420
14421         [Qt] [WK2] Support threaded renderer in WK2
14422         https://bugs.webkit.org/show_bug.cgi?id=76661
14423
14424         Remove disabling of threaded rendering.
14425
14426         Reviewed by Noam Rosenthal.
14427
14428         * MiniBrowser/qt/main.cpp:
14429         (main):
14430
14431 2012-03-09  Zan Dobersek  <zandobersek@gmail.com>
14432
14433         [WK2] run-perf-tests should be able to run with WTR
14434         https://bugs.webkit.org/show_bug.cgi?id=80042
14435
14436         Reviewed by Martin Robinson.
14437
14438         Add an option to PerfTestRunner to use WebKitTestRunner instead of
14439         DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
14440         to avoid timing out when running performance tests.
14441
14442         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
14443         (PerfTestsRunner._parse_args):
14444         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
14445         (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
14446         to true.
14447         (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
14448         as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
14449         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
14450         (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
14451         publicly accessible.
14452         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
14453         (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
14454         is required.
14455         * WebKitTestRunner/TestController.cpp:
14456         (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
14457         to true.
14458         (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
14459         if '--no-timeout' option is present.
14460         (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
14461         value, or -1.0 if timeout should not occur.
14462         * WebKitTestRunner/TestController.h:
14463         (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
14464         publicly accessible.
14465         * WebKitTestRunner/TestInvocation.cpp:
14466         (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
14467         containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
14468         Waiting for final message should not time out if not necessary.
14469         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
14470         (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
14471         * WebKitTestRunner/qt/TestControllerQt.cpp:
14472         (WTR::TestController::platformRunUntil): Ditto.
14473         * WebKitTestRunner/mac/TestControllerMac.mm:
14474         (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
14475         is missing.
14476         * WebKitTestRunner/win/TestControllerWin.cpp:
14477         (WTR::TestController::platformRunUntil): Ditto.
14478
14479 2012-03-09  Jon Lee  <jonlee@apple.com>
14480
14481         Rename NotificationPresenter to NotificationClient
14482         https://bugs.webkit.org/show_bug.cgi?id=80488
14483         <rdar://problem/10965558>
14484
14485         Reviewed by Kentaro Hara.
14486
14487         Refactor to use renamed WebCore::NotificationClient.
14488         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
14489         (DRTDesktopNotificationPresenter::checkNotificationPermission):
14490
14491 2012-03-07  James Robinson  <jamesr@chromium.org>
14492
14493         [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
14494         https://bugs.webkit.org/show_bug.cgi?id=80523
14495
14496         Reviewed by Darin Fisher.
14497
14498         * DumpRenderTree/chromium/WebViewHost.cpp:
14499         (WebViewHost::createGraphicsContext3D):
14500         * DumpRenderTree/chromium/WebViewHost.h:
14501         (WebViewHost):
14502
14503 2012-03-09  Eric Seidel  <eric@webkit.org>
14504
14505         build-webkit should build Source/WTF on Mac
14506         https://bugs.webkit.org/show_bug.cgi?id=80728
14507
14508         Reviewed by Adam Barth.
14509
14510         We'll add other ports to this list in future commits.
14511
14512         * Scripts/build-webkit:
14513
14514 2012-03-09  Jon Lee  <jonlee@apple.com>
14515
14516         Add support for ENABLE(LEGACY_NOTIFICATIONS)
14517         https://bugs.webkit.org/show_bug.cgi?id=80497
14518
14519         Reviewed by Adam Barth.
14520
14521         Prep for b80472: Update API for Web Notifications
14522         * Scripts/build-webkit:
14523         * qmake/mkspecs/features/features.prf:
14524
14525 2012-03-09  Ashod Nakashian  <ashodnakashian@yahoo.com>
14526
14527         Bash scripts should support LF endings only
14528         https://bugs.webkit.org/show_bug.cgi?id=79509
14529
14530         Reviewed by David Kilzer.
14531
14532         * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
14533         * EWSTools/start-queue.sh: Added property svn:eol-style.
14534         * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
14535         * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
14536         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
14537         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
14538
14539 2012-03-09  Ionut Biru  <ibiru@archlinux.org>
14540
14541         [BUILD] use detected python to run generate-gtkdoc
14542         https://bugs.webkit.org/show_bug.cgi?id=80695
14543
14544         Reviewed by Gustavo Noronha Silva.
14545
14546         * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
14547
14548 2012-03-09  Nat Duca  <nduca@chromium.org>
14549
14550         Make check-webkit-style complain about "no new tests" lines in changelogs
14551         https://bugs.webkit.org/show_bug.cgi?id=80582
14552
14553         Reviewed by David Levin.
14554
14555         * Scripts/webkitpy/style/checkers/changelog.py:
14556         (ChangeLogChecker.check_entry):
14557         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
14558         (ChangeLogCheckerTest.test_no_new_tests):
14559
14560 2012-03-09  Sheriff Bot  <webkit.review.bot@gmail.com>
14561
14562         Unreviewed, rolling out r110250.
14563         http://trac.webkit.org/changeset/110250
14564         https://bugs.webkit.org/show_bug.cgi?id=80682
14565
14566         It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
14567         qt-linux at all. (Requested by Ossy on #webkit).
14568
14569         * Scripts/old-run-webkit-tests:
14570         * Scripts/webkitpy/layout_tests/port/qt.py:
14571         (QtPort):
14572         (QtPort.determine_full_port_name):
14573         (QtPort.baseline_search_path):
14574         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
14575         (QtPortTest):
14576         (QtPortTest._assert_search_path):
14577         (QtPortTest.test_baseline_search_path):
14578
14579 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14580
14581         [Qt] Use Qt's module system for install rules and depending on QtWebKit
14582
14583         Instead of rolling our own install rules we now use the same approach as
14584         every other Qt module, by loading qt_module.prf and qt_module_config.prf.
14585
14586         This ensures that we follow the same semantics as the rest of Qt on
14587         what sort of config options are enabled by default (create_cmake eg.).
14588         It also allows us to use QT += webkit instead of the workaround we had
14589         with CONFIG += qtwebkit.
14590
14591         We do however force Qt to always treat our build as a non-developer build,
14592         so the libraries will end up in the WebKit lib directory instead of the
14593         qtbase directory (as with a normal developer-build). This allows us to
14594         keep the webkit-build self-contained. If Qt is a developer build we still
14595         copy the module file manually to Qt, so that you don't have to install
14596         WebKit to make it available.
14597
14598         For non-developer builds of Qt, it is still possible to use the built
14599         WebKit libraries without having to install them, by having the variable
14600         QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
14601         pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
14602
14603         https://bugs.webkit.org/show_bug.cgi?id=80590
14604
14605         Reviewed by Simon Hausmann.
14606
14607         * DumpRenderTree/qt/DumpRenderTree.pro:
14608         * MiniBrowser/qt/BrowserWindow.cpp:
14609         * MiniBrowser/qt/MiniBrowser.pro:
14610         * MiniBrowser/qt/MiniBrowserApplication.cpp:
14611         * MiniBrowser/qt/UrlLoader.cpp:
14612         * QtTestBrowser/QtTestBrowser.pro:
14613         * Tools.pro:
14614         * WebKitTestRunner/InjectedBundle/Target.pri:
14615         * WebKitTestRunner/Target.pri:
14616         * qmake/mkspecs/features/default_post.prf:
14617         * qmake/mkspecs/features/default_pre.prf:
14618         * qmake/mkspecs/features/functions.prf:
14619         * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
14620         * qmake/mkspecs/features/qtwebkit.prf:
14621         * qmake/mkspecs/features/rpath.prf:
14622         * qmake/mkspecs/modules/qt_webkit.pri: Removed.
14623         * qmake/qt_webkit.pri: Added.
14624
14625 2012-03-08  Igor Oliveira  <igor.o@sisa.samsung.com>
14626
14627         Unreviewed. Update my email.
14628
14629         * Scripts/webkitpy/common/config/committers.py:
14630
14631 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
14632
14633         Recent changes to chromium.py etc. broke chromium_android.py
14634         https://bugs.webkit.org/show_bug.cgi?id=80623
14635
14636         Reviewed by Dirk Pranke.
14637
14638         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
14639         (ChromiumAndroidDriver.__init__):
14640         (ChromiumAndroidDriver._start):
14641
14642 2012-03-08  Xianzhu Wang  <wangxianzhu@chromium.org>
14643
14644         [Chromium] Exception running reftest with --no-pixel-tests
14645         https://bugs.webkit.org/show_bug.cgi?id=80642
14646
14647         Reviewed by Dirk Pranke.
14648
14649         * Scripts/webkitpy/layout_tests/port/chromium.py:
14650         (ChromiumDriver.__init__):
14651         (ChromiumDriver._wrapper_options):
14652
14653 2012-03-08  Rafael Brandao  <rafael.lobo@openbossa.org>
14654
14655         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
14656         https://bugs.webkit.org/show_bug.cgi?id=72489
14657
14658         Reviewed by Dirk Pranke.
14659
14660         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
14661         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
14662         --platform will override the platform name and then we'll use it.
14663
14664         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
14665         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
14666         override it in the end.
14667
14668         * Scripts/old-run-webkit-tests:
14669         * Scripts/webkitpy/layout_tests/port/qt.py:
14670         (QtPort):
14671         (QtPort.determine_full_port_name):
14672         (QtPort.baseline_search_path):
14673         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
14674         (QtPortTest):
14675         (QtPortTest._assert_search_path):
14676         (QtPortTest.test_baseline_search_path):
14677
14678 2012-03-08  Beth Dakin  <bdakin@apple.com>
14679
14680         https://bugs.webkit.org/show_bug.cgi?id=80463
14681         RenderImage is using the wrong origin when calling addRelevantRepaintedObject
14682         -and corresponding-
14683         <rdar://problem/10970221>
14684
14685         Reviewed by Dan Bernstein.
14686
14687         New test!
14688         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14689         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
14690         (TestWebKitAPI):
14691         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
14692         (TestWebKitAPI::setPageLoaderClient):
14693         (TestWebKitAPI::TEST):
14694         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
14695         (TestWebKitAPI):
14696         (NewFirstVisuallyNonEmptyLayoutForImagesTest):
14697         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
14698         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
14699         * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
14700
14701 2012-03-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
14702
14703         [Qt] Prospective Windows build fix
14704
14705         Don't assume that windows-builds will always run inside a cmd.exe shell.
14706
14707         * qmake/mkspecs/features/default_pre.prf:
14708
14709 2012-03-08  Dan Bernstein  <mitz@apple.com>
14710
14711         <rdar://problem/10981173> Dashboard regions should not be in device space
14712
14713         Reviewed by John Sullivan.
14714
14715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
14716         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
14717         (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
14718         (TestWebKitAPI):
14719         (TestWebKitAPI::TEST):
14720
14721 2012-03-08  Dirk Pranke  <dpranke@chromium.org>
14722
14723         webkit-patch works oddly on local Git branches
14724         https://bugs.webkit.org/show_bug.cgi?id=76958
14725
14726         Reviewed by Ojan Vafai.
14727
14728         This change makes the '-g' flag to webkit-patch behave a
14729         little more consistently with git. The 'HEAD..' syntax
14730         is changed to 'HEAD....' (four dots), so as to not
14731         collide with the underlying git syntax. We also generalize
14732         the syntax to support any refname, so 'foo....' means
14733         diff against foo and include working copy changes.
14734
14735         This change also adds the 'UPSTREAM' shortcut to identify
14736         whatever the current upstream/tracking branch is; this is
14737         useful if you have multiple local branches stacked up.
14738
14739         * Scripts/webkitpy/common/checkout/scm/git.py:
14740         (Git._branch_from_ref):
14741         (Git):
14742         (Git._current_branch):
14743         (Git._upstream_branch):
14744         (Git.merge_base):
14745         (Git._commit_on_branch):
14746         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
14747         (GitSVNTest._second_local_commit):
14748         (GitSVNTest._two_local_commits):
14749         (GitSVNTest.test_commit_with_message_git_commit_range):
14750         (GitSVNTest.test_upstream_branch):
14751         (GitSVNTest.test_create_patch_working_copy_only):
14752         (GitSVNTest.test_changed_files_local_plus_working_copy):
14753         (GitSVNTest.test_changed_files_working_copy_only):
14754         (GitSVNTest.test_changed_files_upstream):
14755         * Scripts/webkitpy/tool/steps/options.py:
14756         (Options):
14757
14758 2012-03-08  John Sullivan  <sullivan@apple.com>
14759
14760         Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
14761
14762         Reviewed by Eric Carlson.
14763
14764         * Scripts/extract-localizable-strings:
14765         Added NSLocalizedFileSizeDescription to allowed list of tokens that start
14766         with NSLocalized. Also improved an error message to include the troublesome token.
14767
14768 2012-03-08  Sheriff Bot  <webkit.review.bot@gmail.com>
14769
14770         Unreviewed, rolling out r110115.
14771         http://trac.webkit.org/changeset/110115
14772         https://bugs.webkit.org/show_bug.cgi?id=80581
14773
14774         broke test-webkitpy (Requested by philn-tp on #webkit).
14775
14776         * Scripts/old-run-webkit-tests:
14777         * Scripts/webkitpy/layout_tests/port/qt.py:
14778         (QtPort):
14779         (QtPort.determine_full_port_name):
14780         (QtPort.baseline_search_path):
14781
14782 2012-03-08  Kentaro Hara  <haraken@chromium.org>
14783
14784         Unreviewed. Added myself to watchlist.
14785
14786         * Scripts/webkitpy/common/config/watchlist:
14787
14788 2012-03-07  Jessie Berlin  <jberlin@apple.com>
14789
14790         Clean Windows build fails after r110033
14791         https://bugs.webkit.org/show_bug.cgi?id=80553
14792
14793         Rubber-stamped by Jon Honeycutt and Eric Seidel.
14794
14795         Add the new JavaScriptCore include directory to some more vsprops files.
14796
14797         * DumpRenderTree/win/ImageDiffCommon.vsprops:
14798         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
14799         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
14800
14801 2012-03-07  Rafael Brandao  <rafael.lobo@openbossa.org>
14802
14803         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
14804         https://bugs.webkit.org/show_bug.cgi?id=72489
14805
14806         Reviewed by Dirk Pranke.
14807
14808         NRWT: The default platform name for Qt combined with --webkit-test-runner is now
14809         "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
14810         --platform will override the platform name and then we'll use it.
14811
14812         ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
14813         than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
14814         override it in the end.
14815
14816         * Scripts/old-run-webkit-tests:
14817         * Scripts/webkitpy/layout_tests/port/qt.py:
14818         (QtPort):
14819         (QtPort.determine_full_port_name):
14820         (QtPort.baseline_search_path):
14821
14822 2012-03-07  Hugo Parente Lima  <hugo.lima@openbossa.org>
14823
14824         [Qt][WK2] MiniBrowser on desktop does not react to click events
14825         https://bugs.webkit.org/show_bug.cgi?id=80314
14826
14827         Reviewed by Kenneth Rohde Christiansen.
14828
14829         Do not enable touch mocking on desktop mode.
14830
14831         * MiniBrowser/qt/MiniBrowserApplication.cpp:
14832         (MiniBrowserApplication::handleUserOptions):
14833
14834 2012-03-07  Ojan Vafai  <ojan@chromium.org>
14835
14836         Automatically move to the next test after rebaseline in the results view
14837         https://bugs.webkit.org/show_bug.cgi?id=80527
14838
14839         Reviewed by Dimitri Glazkov.
14840
14841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
14842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
14843
14844 2012-03-07  Ojan Vafai  <ojan@chromium.org>
14845
14846         garden-o-matic rebaseline is broken for ports that don't have a fallback port
14847         https://bugs.webkit.org/show_bug.cgi?id=80526
14848
14849         Reviewed by Adam Barth.
14850
14851         Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
14852         since there is no "None" port.
14853
14854         * Scripts/webkitpy/tool/servers/gardeningserver.py:
14855         (GardeningHTTPRequestHandler.rebaseline):
14856         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
14857         (GardeningServerTest.test_rebaseline):
14858
14859 2012-03-07  James Robinson  <jamesr@chromium.org>
14860
14861         [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
14862         https://bugs.webkit.org/show_bug.cgi?id=80521
14863
14864         Reviewed by Kenneth Russell.
14865
14866         Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
14867         to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
14868         renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
14869
14870         Covered by platform/chromium/compositing/plugins/*
14871
14872         * DumpRenderTree/chromium/TestWebPlugin.cpp:
14873         (TestWebPlugin::TestWebPlugin):
14874         (TestWebPlugin::initialize):
14875         (TestWebPlugin::updateGeometry):
14876         (TestWebPlugin::initScene):
14877         (TestWebPlugin::destroyScene):
14878         * DumpRenderTree/chromium/TestWebPlugin.h:
14879         (TestWebPlugin):
14880         * DumpRenderTree/chromium/WebViewHost.cpp:
14881         (WebViewHost::createPlugin):
14882
14883 2012-03-07  Philippe Normand  <pnormand@igalia.com>
14884
14885         [GTK] remove webkitpy dependency in run-gtk-tests
14886         https://bugs.webkit.org/show_bug.cgi?id=80500
14887
14888         Reviewed by Martin Robinson.
14889
14890         Replace Executive calls with bare subprocess calls.
14891
14892         * Scripts/run-gtk-tests:
14893         (TestRunner):
14894         (TestRunner._lookup_atspi2_binary):
14895         (TestRunner.run):
14896         (TestRunner.run.run_for_real):
14897
14898 2012-03-07  Philippe Normand  <pnormand@igalia.com>
14899
14900         Unreviewed, GTK build fix after r110059.
14901
14902         * Scripts/run-gtk-tests:
14903         (TestRunner._check_if_tests_have_timed_out):
14904         (TestRunner.run.run_tests):
14905         (TestRunner):
14906
14907 2012-03-07  Philippe Normand  <pnormand@igalia.com>
14908
14909         [GTK] race condition in run-gtk-tests
14910         https://bugs.webkit.org/show_bug.cgi?id=80495
14911
14912         Reviewed by Martin Robinson.
14913
14914         Refactored the script to wait the a11y dbus service becomes
14915         available before starting the tests.
14916
14917         * Scripts/run-gtk-tests:
14918         (TestRunner._lookup_atspi2_binary):
14919         (TestRunner):
14920         (TestRunner._wait_dbus_service_and_run):
14921         (TestRunner._wait_dbus_service_and_run.on_name_appeared):
14922         (TestRunner._wait_dbus_service_and_run.on_name_vanished):
14923         (TestRunner.run):
14924         (TestRunner.run.bailout):
14925         (TestRunner.run.run_for_real):
14926
14927 2012-03-07  Dinu Jacob  <dinu.jacob@nokia.com>
14928
14929         [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
14930         https://bugs.webkit.org/show_bug.cgi?id=80425
14931
14932         Reviewed by Simon Hausmann.
14933
14934         Set startScreenPos in mock touch point
14935
14936         * MiniBrowser/qt/MiniBrowserApplication.cpp:
14937         (MiniBrowserApplication::notify):
14938         * MiniBrowser/qt/MiniBrowserApplication.h:
14939         (MiniBrowserApplication):
14940
14941 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
14942
14943         [Qt] Windows build fix.
14944
14945         Reviewed by Tor Arne Vestbø.
14946
14947         Pass the -j parameter only to "make", not "nmake".
14948
14949         * Scripts/webkitdirs.pm:
14950         (buildQMakeProjects):
14951
14952 2012-03-07  Simon Hausmann  <simon.hausmann@nokia.com>
14953
14954         [Qt] Fix compilation without QtQuick1
14955         https://bugs.webkit.org/show_bug.cgi?id=80503
14956
14957         Reviewed by Tor Arne Vestbø.
14958
14959         Introduce HAVE_QQUICK1 as feature and added haveQtModule
14960         as convenience function.
14961
14962         * qmake/mkspecs/features/features.prf:
14963         * qmake/mkspecs/features/functions.prf:
14964
14965 2012-03-07  Zoltan Horvath  <zoltan@webkit.org>
14966
14967         [Qt] Add qmake config tests for JPEG and PNG library
14968         https://bugs.webkit.org/show_bug.cgi?id=80398
14969
14970         Add JPEG and PNG library tests to config.tests and
14971         add error() abort to WebCore.pri if tests don't work.
14972
14973         Reviewed by Tor Arne Vestbø.
14974
14975         * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
14976         (main):
14977         * qmake/config.tests/libjpeg/libjpeg.pro: Added.
14978         * qmake/config.tests/libpng/libpng.cpp: Added.
14979         (main):
14980         * qmake/config.tests/libpng/libpng.pro: Added.
14981         * qmake/sync.profile:
14982
14983 2012-03-07  Byungwoo Lee  <bw80.lee@samsung.com>
14984
14985         [EFL] Build warning: Fix warn_unused_result warnings.
14986         https://bugs.webkit.org/show_bug.cgi?id=79194
14987
14988         Reviewed by Filip Pizlo.
14989
14990         Fixed build warning which is getting generated when not using return
14991         value of a fuction, especially declared with warn_unused_result
14992         attribute.
14993
14994         * DumpRenderTree/efl/ImageDiff.cpp:
14995         (printImage):
14996
14997 2012-03-07  Kangil Han  <kangil.han@samsung.com>
14998
14999         [DRT] Remove PlainTextController implementations.
15000         https://bugs.webkit.org/show_bug.cgi?id=79959
15001
15002         Reviewed by Hajime Morita.
15003
15004         PlainTextController usages in existing tests have been
15005         replaced by internals API by bug 78570.
15006         So this patch will remove PlainTextController implementations
15007         to avoid further usage in new tests.
15008
15009         * DumpRenderTree/DumpRenderTree.gypi:
15010         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
15011         * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
15012         * DumpRenderTree/chromium/PlainTextController.h: Removed.
15013         * DumpRenderTree/chromium/TestShell.cpp:
15014         (TestShell::TestShell):
15015         (TestShell::bindJSObjectsToWindow):
15016         * DumpRenderTree/chromium/TestShell.h:
15017         (TestShell):
15018         * DumpRenderTree/gtk/DumpRenderTree.cpp:
15019         (webViewWindowObjectCleared):
15020         * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
15021         * DumpRenderTree/gtk/PlainTextController.h: Removed.
15022         * DumpRenderTree/mac/FrameLoadDelegate.mm:
15023         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
15024         * DumpRenderTree/mac/PlainTextController.h: Removed.
15025         * DumpRenderTree/mac/PlainTextController.mm: Removed.
15026         * DumpRenderTree/qt/DumpRenderTree.pro:
15027         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
15028         (WebCore::DumpRenderTree::DumpRenderTree):
15029         (WebCore::DumpRenderTree::initJSObjects):
15030         * DumpRenderTree/qt/DumpRenderTreeQt.h:
15031         (DumpRenderTree):
15032         * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
15033         * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
15034         * GNUmakefile.am:
15035
15036 2012-03-06  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
15037
15038         [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
15039         https://bugs.webkit.org/show_bug.cgi?id=80137
15040
15041         Reviewed by Eric Seidel.
15042
15043         Adds implementation LayoutTestController's setPopupBlockingEnabled.
15044         To pass popup-blocking-click-in-iframe.html EventSender should not
15045         repeat click events in idler's function. EventSender allows to
15046         asynchronously send click event through ecore_idler_add.
15047         This event will be called repeatedly as long as it return true.
15048         Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
15049
15050         * DumpRenderTree/efl/EventSender.cpp:
15051         (sendMouseEvent): Changed return value from bool to void because it always returns true.
15052         (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
15053         (mouseDownCallback): Remove unnecessary checking of return value.
15054         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
15055         (LayoutTestController::setPopupBlockingEnabled):
15056
15057 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
15058
15059         rebaseline_chromium_webkit_tests is obsolete and should be removed
15060         https://bugs.webkit.org/show_bug.cgi?id=80347
15061
15062         Reviewed by Tony Chang.
15063
15064         * Scripts/rebaseline-chromium-webkit-tests: Removed.
15065         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
15066         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
15067
15068 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
15069
15070         test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
15071         https://bugs.webkit.org/show_bug.cgi?id=80468
15072
15073         Unreviewed, build fix.
15074
15075         Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
15076
15077         * Scripts/webkitpy/layout_tests/servers/http_server.py:
15078         (Lighttpd._prepare_config):
15079
15080 2012-03-06  Dirk Pranke  <dpranke@chromium.org>
15081
15082         remove chromium_gpu ports
15083         https://bugs.webkit.org/show_bug.cgi?id=80345
15084
15085         Reviewed by Ojan Vafai.
15086
15087         This change leaves in the 'graphics_type' distinction in the
15088         test_expectations; removing that will require more updates and a
15089         pass over test_expectations.txt, so I'm separating that out.
15090
15091         * Scripts/webkitpy/layout_tests/port/builders.py:
15092         * Scripts/webkitpy/layout_tests/port/chromium.py:
15093         (ChromiumPort):
15094         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
15095         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
15096         * Scripts/webkitpy/layout_tests/port/factory.py:
15097         (PortFactory):
15098         (PortFactory.get):
15099         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
15100         (FactoryTest.test_qt):
15101         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
15102         (TestRebaseline.test_rebaseline_expectations):
15103
15104 2012-03-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
15105
15106         undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
15107         https://bugs.webkit.org/show_bug.cgi?id=80282
15108
15109         Reviewed by Antonio Gomes.
15110
15111         Remove transitive library dependencies; they are especially
15112         dangerous when one ends up linking against WTF, JSC and then WTF
15113         again, since some symbols will not be defined.
15114
15115         Passing --no-copy-dt-needed-entries and --as-needed to the linker
15116         (which some recent Linux distros do by default) makes the issue
15117         even more evident.
15118
15119         * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
15120         as the other libraries have the needed symbols. Explicitly link
15121         against fontconfig.
15122
15123 2012-03-06  Dean Jackson  <dino@apple.com>
15124
15125         filter-build-webkit needs more filters
15126         https://bugs.webkit.org/show_bug.cgi?id=80440
15127
15128         Reviewed by Joseph Pecoraro.
15129
15130         Added as many missing filters as I could find for Apple
15131         builds. Plus a few minor style updates.
15132
15133         * Scripts/filter-build-webkit:
15134         (printLine):
15135
15136 2012-03-06  Ojan Vafai  <ojan@chromium.org>
15137
15138         Copying old baselines throws an error if the new directory doesn't exist
15139         https://bugs.webkit.org/show_bug.cgi?id=80443
15140
15141         Reviewed by Adam Barth.
15142
15143         Existing tests cover the new code with the fix to filesystem_mock.
15144
15145         * Scripts/webkitpy/common/system/filesystem_mock.py:
15146         (MockFileSystem.copyfile):
15147         Fix the mock to better match python's copyfile semantics.
15148
15149         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
15150         (Rebaseliner._create_html_baseline_files):
15151         * Scripts/webkitpy/tool/commands/rebaseline.py:
15152         (RebaselineTest._copy_existing_baseline):
15153
15154 2012-03-05  Ojan Vafai  <ojan@chromium.org>
15155
15156         Add a mechanism to rebaseline new ports
15157         https://bugs.webkit.org/show_bug.cgi?id=80355
15158
15159         Reviewed by Adam Barth.
15160
15161         For a test that's only failing on a new port, we want
15162         to first copy the existing result into the location for the
15163         port it's replacing in order to not break that port.
15164
15165         For example, bringing up the chromium-lion port, if we just
15166         stick the results in the chromium-mac directory, the snow leopard
15167         will start failing. Instead, we first copy the existing result
15168         to the chromium-mac-snowleopard directory.
15169
15170         * Scripts/webkitpy/layout_tests/port/builders.py:
15171         (builder_path_for_port_name):
15172         (fallback_port_name_for_new_port):
15173         * Scripts/webkitpy/tool/commands/rebaseline.py:
15174         (RebaselineTest):
15175         (RebaselineTest._copy_existing_baseline):
15176         (RebaselineTest._rebaseline_test):
15177         (RebaselineTest.execute):
15178         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
15179         (TestRebaseline.test_rebaseline_test):
15180         (TestRebaseline):
15181         (TestRebaseline.test_rebaseline_and_copy_test):
15182         (test_rebaseline_and_copy_test_no_existing_result):
15183         (test_rebaseline_and_copy_test_with_lion_result):
15184         (test_rebaseline_and_copy_no_overwrite_test):
15185         * Scripts/webkitpy/tool/servers/gardeningserver.py:
15186         (GardeningHTTPRequestHandler.rebaseline):
15187         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
15188         (GardeningServerTest.test_rebaseline):
15189         (GardeningServerTest):
15190         (GardeningServerTest.test_rebaseline_new_port):
15191
15192 2012-03-06  Beth Dakin  <bdakin@apple.com>
15193
15194         https://bugs.webkit.org/show_bug.cgi?id=80351
15195         InlineTextBox is using the wrong origin when calling
15196         addRelevantRepaintedObject
15197         -and corresponding-
15198         <rdar://problem/10970221>
15199
15200         Reviewed by Sam Weinig.
15201
15202         This test has actually been broken since revision 109273. This change makes
15203         the test pass again, and it makes it specifically exercise the fix for this
15204         bug.
15205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
15206         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
15207         (TestWebKitAPI::TEST):
15208
15209         Adjust comments in the other tests to reflect the API changes from 109273.
15210         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
15211         (TestWebKitAPI::TEST):
15212         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
15213         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
15214         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
15215         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
15216         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
15217         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
15218         * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
15219
15220 2012-03-06  Hans Wennborg  <hans@chromium.org>
15221
15222         Speech JavaScript API: add SpeechRecognitionError
15223         https://bugs.webkit.org/show_bug.cgi?id=80410
15224
15225         Chromium: enable the runtime flag for scripted speech so we can run
15226         the layout tests for it.
15227
15228         Reviewed by Adam Barth.
15229
15230         * DumpRenderTree/chromium/TestShell.cpp:
15231         (TestShell::TestShell):
15232
15233 2012-03-06  Sami Kyostila  <skyostil@chromium.org>
15234
15235         Enable universal newlines in chromium android layout test runner
15236         https://bugs.webkit.org/show_bug.cgi?id=80418
15237
15238         Reviewed by Adam Barth.
15239
15240         The Chromium Android layout test runner uses the 'adb' program to
15241         communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
15242         output lines from the test runner, while the test expectation files are
15243         written with LF ('\n') delimiters. This causes the results to have
15244         spurious whitespace differences, making them more difficult to
15245         interpret.
15246
15247         The fix is to enable universal newlines for the DumpRenderTree pipe,
15248         causing the output to only contain LF newlines like on other platforms.
15249
15250         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
15251         (ChromiumAndroidDriver._start):
15252
15253 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15254
15255         [Qt] Revert r109900, it was completly busted
15256
15257         HAVE_FOO does _not_ have a WTF_ prefix, go figure.
15258
15259         We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
15260         of manual define checks.
15261
15262         Reviewed by Ossy.
15263
15264         * DumpRenderTree/qt/DumpRenderTree.pro:
15265         * QtTestBrowser/QtTestBrowser.pro:
15266         * WebKitTestRunner/InjectedBundle/Target.pri:
15267         * qmake/mkspecs/features/features.prf:
15268
15269 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15270
15271         [Qt] Use config test to determine if the compiler supports -MD
15272
15273         We used to assume that unix systems building against Qt5 would have
15274         a compiler that supported -MD. Although this was usually the case,
15275         we failed to take into account broken tools for distributed builds
15276         (e.g. teambuilder or icecream) which would end up producing .d files
15277         in the root of the build dir instead of along-side the object file.
15278
15279         Now that we use a config-test to determine the support, we'll capture
15280         those cases, unless distributed builds are enabled after the initial
15281         build-webkit run.
15282
15283         Reviewed by Csaba Osztrogonác.
15284
15285         * Tools.pro:
15286         * qmake/config.tests/gccdepends/empty.cpp: Added.
15287         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
15288         * qmake/mkspecs/features/default_pre.prf:
15289         * qmake/mkspecs/features/features.prf:
15290         * qmake/mkspecs/features/unix/default_pre.prf:
15291         * qmake/sync.profile:
15292
15293 2012-03-06  Csaba Osztrogonác  <ossy@webkit.org>
15294
15295         REGRESSION(r109294): It broke the unittest of master.cfg
15296         https://bugs.webkit.org/show_bug.cgi?id=80253
15297
15298         Reviewed by Tor Arne Vestbø.
15299
15300         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
15301         (BuildBotConfigLoader._create_mock_passwords_dict):
15302         (BuildBotConfigLoader._mock_open):
15303         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
15304         (BuildBotConfigLoader.load_config):
15305
15306 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
15307
15308         Qt API test buildstep throws exception after buildmaster update
15309         https://bugs.webkit.org/show_bug.cgi?id=80249
15310
15311         This patch based on Peter Gal's work.
15312
15313         Reviewed by Csaba Osztrogonác.
15314
15315         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
15316         (RunQtAPITests):
15317         (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
15318
15319 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15320
15321         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
15322
15323         Reviewed by Simon Hausmann.
15324         Reviewed by Ossy.
15325
15326         * DumpRenderTree/qt/DumpRenderTree.pro:
15327         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
15328         (WebKit::initializeTestFonts):
15329         * QtTestBrowser/QtTestBrowser.pro:
15330         * WebKitTestRunner/InjectedBundle/Target.pri:
15331         * qmake/mkspecs/features/features.prf:
15332
15333 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15334
15335         [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
15336
15337         Reviewed by Ossy.
15338
15339         * qmake/mkspecs/features/default_post.prf:
15340
15341 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15342
15343         [Qt] Make sure clean builds are followed by make qmake && make if needed
15344
15345         On non-GNUmake systems we have to run make qmake so that the generated
15346         sources are generated before we run qmake on the target pro files. This
15347         is achieved by using the 'incremental' target.
15348
15349         Reviewed by Ossy.
15350
15351         * Scripts/webkitdirs.pm:
15352         (buildQMakeProjects):
15353
15354 2012-03-06  Filip Pizlo  <fpizlo@apple.com>
15355
15356         DumpRenderTree should support preciseTime()
15357         https://bugs.webkit.org/show_bug.cgi?id=80397
15358
15359         Reviewed by Gavin Barraclough.
15360
15361         * DumpRenderTree/LayoutTestController.cpp:
15362         (preciseTimeCallback):
15363         (LayoutTestController::staticFunctions):
15364
15365 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
15366
15367         Unreviewed, rolling out r109887.
15368         http://trac.webkit.org/changeset/109887
15369         https://bugs.webkit.org/show_bug.cgi?id=80402
15370
15371         It broke the build (Requested by Ossy on #webkit).
15372
15373         * DumpRenderTree/qt/DumpRenderTree.pro:
15374         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
15375         (WebKit::initializeTestFonts):
15376         * QtTestBrowser/QtTestBrowser.pro:
15377         * WebKitTestRunner/InjectedBundle/Target.pri:
15378         * qmake/mkspecs/features/features.prf:
15379
15380 2012-03-06  Sheriff Bot  <webkit.review.bot@gmail.com>
15381
15382         Unreviewed, rolling out r109837.
15383         http://trac.webkit.org/changeset/109837
15384         https://bugs.webkit.org/show_bug.cgi?id=80399
15385
15386         breaks Mac Productions builds, too late to try and fix it
15387         tonight (Requested by eseidel on #webkit).
15388
15389         * Scripts/build-webkit:
15390
15391 2012-03-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15392
15393         [Qt] Use correct define names for HAVE(FOO) style optional dependencies
15394
15395         Reviewed by Simon Hausmann.
15396
15397         * DumpRenderTree/qt/DumpRenderTree.pro:
15398         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
15399         (WebKit::initializeTestFonts):
15400         * QtTestBrowser/QtTestBrowser.pro:
15401         * WebKitTestRunner/InjectedBundle/Target.pri:
15402         * qmake/mkspecs/features/features.prf:
15403
15404 2012-03-06  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
15405
15406         [Qt] Create EWS to build WebKit2
15407         https://bugs.webkit.org/show_bug.cgi?id=80277
15408
15409         Reviewed by Csaba Osztrogonác.
15410
15411         * QueueStatusServer/model/queues.py:
15412         (Queue):
15413         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
15414         (QtWK2EWS):
15415         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
15416         (EarlyWarningSytemTest.test_builder_ewses):
15417
15418 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
15419
15420         Unreviewed, rolling out r109733.
15421         http://trac.webkit.org/changeset/109733
15422         https://bugs.webkit.org/show_bug.cgi?id=80378
15423
15424         It broke Qt5 build system (Requested by Ossy on #webkit).
15425
15426         * Tools.pro:
15427         * qmake/config.tests/gccdepends/empty.cpp: Removed.
15428         * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
15429         * qmake/mkspecs/features/default_pre.prf:
15430         * qmake/mkspecs/features/features.prf:
15431         * qmake/mkspecs/features/unix/default_pre.prf:
15432         * qmake/sync.profile:
15433
15434 2012-03-05  Eric Seidel  <eric@webkit.org>
15435
15436         Update JavaScriptCore files to use fully-qualified WTF include path
15437         https://bugs.webkit.org/show_bug.cgi?id=79960
15438
15439         Reviewed by Adam Barth.
15440
15441         Build WTF/WTF.xcodeproj by default on Mac.
15442
15443         * Scripts/build-webkit:
15444
15445 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
15446
15447         There should be a way to disable optimizer in webkit-patch rebaseline-expectations
15448         https://bugs.webkit.org/show_bug.cgi?id=69590
15449
15450         Reviewed by Ryosuke Niwa.
15451
15452         Adds a --no-optimize flag to webkit-patch rebaseline-expectations
15453         to skip the 'optimize-expectations' step.
15454
15455         * Scripts/webkitpy/tool/commands/rebaseline.py:
15456         (RebaselineExpectations.__init__):
15457         (RebaselineExpectations.execute):
15458         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
15459
15460 2012-03-05  Kent Tamura  <tkent@chromium.org>
15461
15462         [Chromium] Add new popup type: PagePopup
15463         https://bugs.webkit.org/show_bug.cgi?id=80106
15464
15465         Reviewed by Darin Fisher.
15466
15467         * DumpRenderTree/chromium/WebViewHost.cpp:
15468         (WebViewHost::createPopupMenu):
15469
15470 2012-03-05  Jessie Berlin  <jberlin@apple.com>
15471
15472         Add myself as a reviewer.
15473
15474         * Scripts/webkitpy/common/config/committers.py:
15475         Also, add my IRC nick so it is easier to find and yell at me.
15476
15477 2012-03-05  Robert Kroeger  <rjkroege@chromium.org>
15478
15479         Correctly compute the positions of GestureScroll* events on
15480         Chromium.
15481         https://bugs.webkit.org/show_bug.cgi?id=80075
15482
15483         Reviewed by Adam Barth.
15484
15485         * DumpRenderTree/chromium/EventSender.cpp:
15486         (EventSender::reset):
15487         (EventSender::gestureEvent):
15488         * DumpRenderTree/chromium/EventSender.h:
15489         (EventSender):
15490
15491 2012-03-05  Dirk Pranke  <dpranke@chromium.org>
15492
15493         flakiness dashboard doesn't display baselines for virtual tests correctly
15494         https://bugs.webkit.org/show_bug.cgi?id=80341
15495
15496         Reviewed by Ojan Vafai.
15497
15498         If the test is part of a virtual test suite, we need to look for
15499         baselines in the underlying fallback path for the actual test
15500         being run, as well as baselines for the virtual version.
15501
15502         This patch adds code to handle both branches and also pulls the
15503         mapping of the test suites up into a constant.
15504
15505         * TestResultServer/static-dashboards/flakiness_dashboard.html:
15506         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15507         (testLookupVirtualTestSuite):
15508         (testBaseTest):
15509
15510 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
15511
15512         Unreviewed, rolling out r109760.
15513         http://trac.webkit.org/changeset/109760
15514         https://bugs.webkit.org/show_bug.cgi?id=80320
15515
15516         Caused many GTK+ tests to crash (Requested by mrobinson on
15517         #webkit).
15518
15519         * gtk/jhbuild.modules:
15520
15521 2012-03-05  Charlie Reis  <creis@chromium.org>
15522
15523         [chromium] Pass WebNavigationPolicy to WebViewClient::createView
15524         https://bugs.webkit.org/show_bug.cgi?id=80057
15525
15526         Reviewed by Darin Fisher.
15527
15528         * DumpRenderTree/chromium/WebViewHost.cpp:
15529         (WebViewHost::createView):
15530         * DumpRenderTree/chromium/WebViewHost.h:
15531         (WebViewHost):
15532
15533 2012-03-05  Martin Robinson  <mrobinson@igalia.com>
15534
15535         [soup] Crash while loading http://www.jusco.cn
15536         https://bugs.webkit.org/show_bug.cgi?id=68238
15537
15538         Reviewed by Philippe Normand.
15539
15540         * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
15541         in the jhbuild file.
15542
15543 2012-03-05  Sheriff Bot  <webkit.review.bot@gmail.com>
15544
15545         Unreviewed, rolling out r109748.
15546         http://trac.webkit.org/changeset/109748
15547         https://bugs.webkit.org/show_bug.cgi?id=80296
15548
15549         Made some tests crash, will fix and recommit (Requested by
15550         noamr on #webkit).
15551
15552         * MiniBrowser/qt/main.cpp:
15553         (main):
15554
15555 2012-03-05  Zan Dobersek  <zandobersek@gmail.com>
15556
15557         [GTK] plugins/netscape-plugin-page-cache-works.html fails
15558         https://bugs.webkit.org/show_bug.cgi?id=74409
15559
15560         Reviewed by Martin Robinson.
15561
15562         Add support for overriding the page-cache-for-plugins preference
15563         through DumpRenderTreeSupport.
15564
15565         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
15566         (booleanFromValue): A helper function to convert a string to boolean.
15567         (LayoutTestController::overridePreference):
15568
15569 2012-03-05  Rob Buis  <rbuis@rim.com>
15570
15571         [BlackBerry] Update Tools/DumpRenderTree
15572         https://bugs.webkit.org/show_bug.cgi?id=80287
15573
15574         Reviewed by Antonio Gomes.
15575
15576         Update so we are sure we can build our implementation of DRT.
15577
15578         * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
15579         * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
15580         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
15581         (AccessibilityController::addNotificationListener): add missing hook.
15582         (AccessibilityController::removeNotificationListener): add missing hook.
15583         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
15584         (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
15585         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
15586         (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
15587         (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
15588
15589 2012-03-05  No'am Rosenthal  <noam.rosenthal@nokia.com>
15590
15591         [Qt] [WK2] Support threaded renderer in WK2
15592         https://bugs.webkit.org/show_bug.cgi?id=76661
15593
15594         Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
15595
15596         Reviewed by Kenneth Rohde Christiansen.
15597
15598         * MiniBrowser/qt/main.cpp:
15599         (main):
15600
15601 2012-03-05  Alexander Færøy  <alexander.faeroy@nokia.com>
15602
15603         Unreviewed. Add myself to committer list.
15604
15605         * Scripts/webkitpy/common/config/committers.py:
15606
15607 2012-03-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15608
15609         [Qt] Use config test to determine if the compiler supports -MD
15610
15611         We used to assume that unix systems building against Qt5 would have
15612         a compiler that supported -MD. Although this was usually the case,
15613         we failed to take into account broken tools for distributed builds
15614         (e.g. teambuilder or icecream) which would end up producing .d files
15615         in the root of the build dir instead of along-side the object file.
15616
15617         Now that we use a config-test to determine the support, we'll capture
15618         those cases, unless distributed builds are enabled after the initial
15619         build-webkit run.
15620
15621         Reviewed by Csaba Osztrogonác.
15622
15623         * Tools.pro:
15624         * qmake/config.tests/gccdepends/empty.cpp: Added.
15625         * qmake/config.tests/gccdepends/gccdepends.pro: Added.
15626         * qmake/mkspecs/features/default_pre.prf:
15627         * qmake/mkspecs/features/features.prf:
15628         * qmake/mkspecs/features/unix/default_pre.prf:
15629         * qmake/sync.profile:
15630
15631 2012-03-05  Csaba Osztrogonác  <ossy@webkit.org>
15632
15633         Qt API test buildstep throws exception after buildmaster update
15634         https://bugs.webkit.org/show_bug.cgi?id=80249
15635
15636         Reviewed by Zoltan Herczeg.
15637
15638         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
15639         (BuildAndTestFactory.__init__):
15640
15641 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
15642
15643         [GTK] Unit tests are noisy when run under jhbuild
15644         https://bugs.webkit.org/show_bug.cgi?id=80241
15645
15646         Reviewed by Philippe Normand.
15647
15648         Force the 'memory' backend in GSettings so that each unit
15649         test doesn't produce a warning when it's forced to fall back
15650         to the 'memory' backend.
15651
15652         * Scripts/run-gtk-tests:
15653         (TestRunner.run): Force the 'memory' backend.
15654
15655 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
15656
15657         [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
15658         https://bugs.webkit.org/show_bug.cgi?id=80235
15659
15660         Reviewed by Philippe Normand.
15661
15662         * Scripts/run-gtk-tests:
15663         (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
15664         inspector resources path determination is shared by all tests.
15665
15666 2012-03-04  Martin Robinson  <mrobinson@igalia.com>
15667
15668         [GTK] REGRESSION: r108278 broke some tests that expect focus
15669         https://bugs.webkit.org/show_bug.cgi?id=79084
15670
15671         Reviewed by Philippe Normand.
15672
15673         Grab focus when dumping test results and also when sending
15674         events. During the course of testing, the WebView may lose
15675         focus and this seems to snap it back when tests demand it.
15676
15677         * DumpRenderTree/gtk/DumpRenderTree.cpp:
15678         (dump): Grab focus.
15679         * DumpRenderTree/gtk/EventSender.cpp:
15680         (dispatchEvent): Ditto.
15681
15682 2012-03-04  Charles Wei  <charles.wei@torchmobile.com.cn>
15683
15684         Unreviewed, Add myself to committer list.
15685         https://bugs.webkit.org/show_bug.cgi?id=80232
15686
15687         * Scripts/webkitpy/common/config/committers.py:
15688
15689 2012-03-04  Anders Carlsson  <andersca@apple.com>
15690
15691         Newer versions of clang fail to compile WebKit.
15692
15693         Fix build.
15694
15695         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
15696         (descriptionOfValue):
15697         (AccessibilityUIElement::rowIndexRange):
15698         (AccessibilityUIElement::columnIndexRange):
15699         (AccessibilityUIElement::selectedTextRange):
15700         * DumpRenderTree/mac/EditingDelegate.mm:
15701         (-[DOMRange dump]):
15702         * DumpRenderTree/mac/PolicyDelegate.mm:
15703         (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
15704         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
15705         (-[NSError _drt_descriptionSuitableForTestResult]):
15706         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
15707         (WTR::descriptionOfValue):
15708         (WTR::AccessibilityUIElement::rowIndexRange):
15709         (WTR::AccessibilityUIElement::columnIndexRange):
15710         (WTR::AccessibilityUIElement::selectedTextRange):
15711
15712 2012-03-03  Simon Hausmann  <simon.hausmann@nokia.com>
15713
15714         [Qt] Fix static_libs_as_shared build
15715         https://bugs.webkit.org/show_bug.cgi?id=80214
15716
15717         Reviewed by Tor Arne Vestbø.
15718
15719         * WebKitTestRunner/qt/main.cpp:
15720         (main): Set the correct environment variable for choosing the theme in the
15721         web process.
15722
15723 2012-03-03  Hans Wennborg  <hans@chromium.org>
15724
15725         Implement Speech JavaScript API
15726         https://bugs.webkit.org/show_bug.cgi?id=80019
15727
15728         Reviewed by Adam Barth.
15729
15730         Add ENABLE_SCRIPTED_SPEECH.
15731
15732         * Scripts/build-webkit:
15733         * qmake/mkspecs/features/features.prf:
15734
15735 2012-03-02  Alexey Proskuryakov  <ap@apple.com>
15736
15737         Fix commit queue, remove duplicate entry.
15738
15739         * Scripts/webkitpy/common/config/committers.py:
15740
15741 2012-03-02  Stephen Chenney  <schenney@chromium.org>
15742
15743         Unreviewed, add myself as a committer
15744
15745         * Scripts/webkitpy/common/config/committers.py:
15746
15747 2012-03-02  Ojan Vafai  <ojan@chromium.org>
15748
15749         Add the Chromium Lion canary bot to the flakiness dashboard.
15750         * TestResultServer/static-dashboards/builders.js:
15751
15752 2012-03-02  Dirk Pranke  <dpranke@chromium.org>
15753
15754         links for virtual tests are broken in the flakiness dashboard
15755         https://bugs.webkit.org/show_bug.cgi?id=80180
15756
15757         Reviewed by Ojan Vafai.
15758
15759         * TestResultServer/static-dashboards/flakiness_dashboard.html:
15760         (linkHTMLToOpenWindow):
15761         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
15762         (testLinkHTMLToOpenWindow): added.
15763
15764 2012-03-02  Philippe Normand  <pnormand@igalia.com>
15765
15766         [GTK] security/block-test.html baselines differ from mac
15767         https://bugs.webkit.org/show_bug.cgi?id=78343
15768
15769         Reviewed by Martin Robinson.
15770
15771         Improved the FrameLoader error heuristics to match mac behavior a
15772         bit more.
15773
15774         * DumpRenderTree/gtk/DumpRenderTree.cpp:
15775         (pathFromSoupURI): Handle ftp urls the same as http urls.
15776         (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
15777
15778 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
15779
15780         [Qt][WK2] Fix typo in patch committed in r109575
15781
15782         Unreviewed typo fix.
15783
15784         * MiniBrowser/qt/MiniBrowserApplication.cpp:
15785         (MiniBrowserApplication::notify): Cache the position
15786         in floating point coordinates.
15787
15788 2012-03-02  Andras Becsi  <andras.becsi@nokia.com>
15789
15790         [Qt][WK2] Infinite loop on history navigation, when panning
15791         https://bugs.webkit.org/show_bug.cgi?id=79119
15792
15793         Reviewed by Simon Hausmann.
15794
15795         Make the touch mocking more robust by creating touch events
15796         directly and sending them synchronously to the browser window.
15797         If the sent touch event was not accepted we propagate the
15798         original mouse event to its target.
15799         This way we make sure we only send either a touch or a mouse
15800         event and do not end up in an infinite loop between our mocking
15801         code and the Qt5 automatic mouse event synthesizing.
15802
15803         * MiniBrowser/qt/BrowserWindow.cpp:
15804         (BrowserWindow::updateVisualMockTouchPoints):
15805         * MiniBrowser/qt/BrowserWindow.h:
15806         (BrowserWindow):
15807         * MiniBrowser/qt/MiniBrowserApplication.cpp:
15808         (touchRectForPosition):
15809         (MiniBrowserApplication::notify):
15810         (MiniBrowserApplication::sendTouchEvent):
15811         * MiniBrowser/qt/MiniBrowserApplication.h:
15812         (MiniBrowserApplication):
15813
15814 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15815
15816         [Qt] Use 'all' as default target when debug_and_release is in effect
15817
15818         When debug_and_release is enabled, in combination with build_all,
15819         qmake will generate an aggregate makefile that calls make on both
15820         the debug and the release makefiles, but with the 'all' target.
15821
15822         In this case we can't use 'first' as the default target, as the
15823         extra targets would then not be run, so we append extra targets
15824         to 'all' instead.
15825
15826         Reviewed by Simon Hausmann.
15827
15828         * qmake/mkspecs/features/default_post.prf:
15829
15830 2012-03-02  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
15831
15832         [Qt] Make sure activeBuildConfig() returns the right config
15833
15834         Using isActiveConfig fails, as that only checks if the given
15835         argument is in CONFIG, not the order.
15836
15837         Reviewed by Simon Hausmann.
15838
15839         * qmake/mkspecs/features/functions.prf:
15840
15841 2012-03-02  Simon Hausmann  <simon.hausmann@nokia.com>
15842
15843         [Qt] Fix tests run with WTR not using QStyle theme
15844         https://bugs.webkit.org/show_bug.cgi?id=80147
15845
15846         Reviewed by Csaba Osztrogonác.
15847
15848         * WebKitTestRunner/qt/main.cpp:
15849         (main): Set environment variable for web process to use QStyle theme.
15850
15851 2012-03-02  Philippe Normand  <pnormand@igalia.com>
15852
15853         Unreviewed, remove debug print call.
15854
15855         * DumpRenderTree/gtk/DumpRenderTree.cpp:
15856         (descriptionSuitableForTestResult):
15857
15858 2012-03-02  Robert Kroeger  <rjkroege@chromium.org>
15859
15860         Updated EventSender to send complete gesture events.
15861         https://bugs.webkit.org/show_bug.cgi?id=80075
15862
15863         Reviewed by Adam Barth.
15864
15865         * DumpRenderTree/chromium/EventSender.cpp:
15866         (EventSender::gestureEvent): set additional parameters in sent events.
15867
15868 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
15869
15870         WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
15871         https://bugs.webkit.org/show_bug.cgi?id=80033
15872
15873         Reviewed by Gustavo Noronha Silva.
15874
15875         GCC 4.7 no longer includes unistd.h from most of the standard C++
15876         header files, so we need to explicitly include it for getcwd().
15877
15878         * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
15879         not only on Mac, but on all Unix platforms.
15880
15881 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
15882
15883         Actually look at the args in driver_input :(.
15884
15885         Unreviewed, build fix.
15886
15887         * Scripts/webkitpy/layout_tests/port/chromium.py:
15888         (ChromiumDriver.run_test):
15889
15890 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
15891
15892         Fix typo in flag used to run gpu virtual suites.
15893
15894         Unreviewed, build fix.
15895
15896         * Scripts/webkitpy/layout_tests/port/chromium.py:
15897         (ChromiumPort.virtual_test_suites):
15898
15899 2012-03-01  Adam Barth  <abarth@webkit.org>
15900
15901         Unreviewed, rolling out r109317.
15902         http://trac.webkit.org/changeset/109317
15903
15904         Let's try watchlists again now that we're using a pure git
15905         working copy
15906
15907         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
15908         (StyleQueueTask.run):
15909         * Scripts/webkitpy/tool/commands/queues_unittest.py:
15910
15911 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
15912
15913         webkitpy: test_run_test_pause_before_testing is failing after r109482
15914         https://bugs.webkit.org/show_bug.cgi?id=80084
15915
15916         Unreviewed, build fix.
15917
15918         Fixes the test string compare to ignore the time spent running
15919         the tests.
15920
15921         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
15922         (test_run_test_pause_before_testing):
15923
15924 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
15925
15926         nrwt: virtual tests aren't being run
15927         https://bugs.webkit.org/show_bug.cgi?id=80083
15928
15929         Reviewed by Eric Seidel.
15930
15931         If we tried to run all of the tests by default (and
15932         didn't specify any paths), the virtual tests weren't
15933         picked up.
15934
15935         * Scripts/webkitpy/layout_tests/port/base.py:
15936         (Port._virtual_tests):
15937         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
15938         (PortTest.test_tests):
15939         * Scripts/webkitpy/layout_tests/port/test.py:
15940         (TestPort.virtual_test_suites):
15941
15942 2012-03-01  Ryosuke Niwa  <rniwa@webkit.org>
15943
15944         run-perf-tests should report the test runtime
15945         https://bugs.webkit.org/show_bug.cgi?id=80078
15946
15947         Reviewed by Hajime Morita.
15948
15949         Record and output the aggreated test run time.
15950
15951         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
15952         (PerfTestsRunner._run_single_test):
15953
15954 2012-03-01  Michael Nordman  <michaeln@google.com>
15955
15956         [chromium] Use webkit_support to create session storage namespaces in DRT.
15957         https://bugs.webkit.org/show_bug.cgi?id=79933
15958
15959         Reviewed by Tony Chang.
15960
15961         * DumpRenderTree/chromium/WebViewHost.cpp:
15962         (WebViewHost::createSessionStorageNamespace):
15963
15964 2012-03-01  Dirk Pranke  <dpranke@chromium.org>
15965
15966         nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
15967         https://bugs.webkit.org/show_bug.cgi?id=80048
15968
15969         Reviewed by Adam Barth.
15970
15971         * Scripts/webkitpy/layout_tests/port/base.py:
15972         (Port.test_isfile):
15973         (Port.test_isdir):
15974         (Port):
15975         (Port.test_exists):
15976         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
15977         (PortTest.test_test_exists):
15978         (PortTest):
15979         (PortTest.test_test_isfile):
15980         (PortTest.test_test_isdir):
15981         * Scripts/webkitpy/layout_tests/port/test.py:
15982         (TestPort.virtual_test_suites):
15983         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
15984         (MainTest.test_virtual):
15985
15986 2012-03-01  Kalev Lember  <kalevlember@gmail.com>
15987
15988         [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
15989         https://bugs.webkit.org/show_bug.cgi?id=80031
15990
15991         Reviewed by Gustavo Noronha Silva.
15992
15993         Only build the libTestRunnerInjectedBundle.la convenience library when
15994         ENABLE_WEBKIT2 is defined.
15995
15996         * WebKitTestRunner/GNUmakefile.am:
15997
15998 2012-03-01  Philippe Normand  <pnormand@igalia.com>
15999
16000         Unreviewed, second attempt to fix GTK NRWT after r109242.
16001
16002         * Scripts/webkitpy/layout_tests/port/gtk.py:
16003         (GtkDriver._start):
16004
16005 2012-03-01  Philippe Normand  <pnormand@igalia.com>
16006
16007         Unreviewed, GTK NRWT build fix attempt after r109242.
16008
16009         * Scripts/webkitpy/layout_tests/port/gtk.py:
16010         (GtkDriver._start):
16011
16012 2012-03-01  Kentaro Hara  <haraken@chromium.org>
16013
16014         REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
16015         https://bugs.webkit.org/show_bug.cgi?id=80008
16016
16017         Reviewed by Adam Barth.
16018
16019         In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
16020         to "preprocess-idls.pl". This patch renames it.
16021
16022         Test: Confirm that run-bindings-tests runs.
16023
16024         * Scripts/webkitpy/bindings/main.py:
16025         (BindingsTests.generate_supplemental_dependency):
16026
16027 2012-02-29  Simon Hausmann  <simon.hausmann@nokia.com>
16028
16029         [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
16030         https://bugs.webkit.org/show_bug.cgi?id=78047
16031
16032         Reviewed by Kenneth Rohde Christiansen.
16033
16034         Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
16035         sending to the item requires the QObject::event re-implementation to dispatch to the correct
16036         event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
16037         the event handlers directly, and with the removal of our own dispatching we need to go through
16038         that code path.
16039
16040         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
16041         (WTR::PlatformWebView::sendEvent):
16042         (WTR::PlatformWebView::postEvent):
16043
16044 2012-02-29  Adam Barth  <abarth@webkit.org>
16045
16046         Disable watchlist.  It's been spamming CCs.
16047
16048         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
16049         (StyleQueueTask.run):
16050         * Scripts/webkitpy/tool/commands/queues_unittest.py:
16051
16052 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16053
16054         need to clone the gpu baselines and expectations into the new "virtual" dir
16055         https://bugs.webkit.org/show_bug.cgi?id=79956
16056
16057         Reviewed by Adam Barth.
16058
16059         * Scripts/webkitpy/layout_tests/port/chromium.py:
16060         (ChromiumPort.virtual_test_suites):
16061
16062 2012-02-29  Mark Rowe  <mrowe@apple.com>
16063
16064         Switch to using json rather than simplejson now that the master is using Python 2.7.
16065
16066         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16067         (loadBuilderConfig):
16068
16069 2012-02-29  David Levin  <levin@chromium.org>
16070
16071         [chromium] Add the ability to turn off autoresize.
16072         https://bugs.webkit.org/show_bug.cgi?id=77452
16073
16074         Reviewed by Darin Fisher.
16075
16076         * DumpRenderTree/chromium/LayoutTestController.cpp:
16077         (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
16078         (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
16079         (LayoutTestController::disableAutoResizeMode):  Ditto.
16080         * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
16081
16082 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16083
16084         nrwt: make --print trace work with virtual tests
16085         https://bugs.webkit.org/show_bug.cgi?id=79952
16086
16087         Reviewed by Adam Barth.
16088
16089         * Scripts/webkitpy/layout_tests/views/printing.py:
16090         (Printer._print_test_trace):
16091         (Printer._print_baseline):
16092
16093 2012-02-28  Brian Weinstein  <bweinstein@apple.com>
16094
16095         WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
16096         https://bugs.webkit.org/show_bug.cgi?id=79849
16097
16098         Reviewed by Beth Dakin.
16099
16100         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
16101         (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
16102
16103 2012-02-29  Lucas Forschler  <lforschler@apple.com>
16104
16105         Removed unused Apple buildslaves from the master configuration
16106         https://bugs.webkit.org/show_bug.cgi?id=79925
16107
16108         Reviewed by Stephanie Lewis.
16109
16110         * BuildSlaveSupport/build.webkit.org-config/config.json:
16111
16112 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16113
16114         nrwt: implement simple 'virtual test suite' support
16115         https://bugs.webkit.org/show_bug.cgi?id=79737
16116
16117         Reviewed by Adam Barth.
16118
16119         Add very basic support for 'virtual test suites' to NRWT:
16120         a virtual suite is a directory that may contain new baselines,
16121         contains a pointer to a "base" directory of tests, and an
16122         optional list of command line arguments to pass to DRT;
16123         it gives us a way to run all of the tests in a given directory
16124         multiple times with multiple (potentially differing) sets of
16125         results and baselines.
16126
16127         This patch implements the support needed for this feature, and
16128         some basic tests, but no actual port will use the feature yet.
16129
16130         This is probably the simplest implementation possible - the
16131         list of virtual suites will be hard-coded into the port's
16132         implementation. One can imagine a more data-driven approach
16133         where the suite instructions are stored in a manifest file
16134         either in LayoutTests (all suites in one file), or per-port,
16135         or per-directory. If this feature ends up being useful we
16136         should probably add something like that so people don't have
16137         to hunt around in the code to add suites.
16138
16139         * Scripts/webkitpy/layout_tests/port/base.py:
16140         (Port.__init__):
16141         (Port.expected_filename):
16142         (Port.tests):
16143         (Port):
16144         (Port._real_tests):
16145         (Port._driver_class):
16146         (Port.virtual_test_suites):
16147         (Port.virtual_suite):
16148         (Port.virtual_suite.VirtualTestSuite):
16149         (Port.virtual_suite.VirtualTestSuite.__init__):
16150         (Port.virtual_suite.VirtualTestSuite.__repr__):
16151         (Port.populated_virtual_test_suites):
16152         (Port._virtual_tests):
16153         (Port.lookup_virtual_test_base):
16154         (Port.lookup_virtual_test_args):
16155         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
16156         (PortTest.test_find_with_skipped_directories):
16157         * Scripts/webkitpy/layout_tests/port/driver.py:
16158         (DriverInput.__init__):
16159         (DriverProxy.run_test):
16160         * Scripts/webkitpy/layout_tests/port/test.py:
16161         (TestPort.virtual_test_suites):
16162         (TestDriver.run_test):
16163         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
16164         (MainTest.test_all):
16165         (MainTest.test_virtual):
16166
16167 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16168
16169         nrwt: support more than two drivers in DriverProxy
16170         https://bugs.webkit.org/show_bug.cgi?id=79736
16171
16172         Reviewed by Adam Barth.
16173
16174         Now that we can support per-test command lines for
16175         Drivers, modify DriverProxy to keep a map of running
16176         drivers for each needed command-line; this will allow
16177         us to transparently maintain a pool of appropriately
16178         configured DRTs without having to constantly start and stop
16179         them.
16180
16181         Note that this potentially raises a garbage collection
16182         problem - the number of running DRTs will grow with the
16183         number of different sets of command line args. For now
16184         this is no worse than the current code - if you're running
16185         with pixel tests, you will only need one DRT per worker,
16186         and if you aren't, you'll need two (one for text-only tests,
16187         and one for reftests).
16188
16189         An alternative would be to only ever have one running driver,
16190         and restart the driver as the command line changes, but this
16191         might (?) slow down execution in the text-only case - we
16192         should benchmark this because it would be simpler and possibly
16193         allow us to eliminate DriverProxy altogether.
16194
16195         * Scripts/webkitpy/layout_tests/port/driver.py:
16196         (DriverProxy.__init__):
16197         (DriverProxy):
16198         (DriverProxy._make_driver):
16199         (DriverProxy.run_test):
16200         (DriverProxy.has_crashed):
16201         (DriverProxy.stop):
16202         (DriverProxy.cmd_line):
16203         (DriverProxy._cmd_line_as_key):
16204
16205 2012-02-29  Adrienne Walker  <enne@google.com>
16206
16207         Unreviewed, add myself as a reviewer
16208
16209         * Scripts/webkitpy/common/config/committers.py:
16210
16211 2012-02-29  Greg Billock  <gbillock@google.com>
16212
16213         Add more tests for web intents
16214         https://bugs.webkit.org/show_bug.cgi?id=79527
16215
16216         Reviewed by Adam Barth.
16217
16218         * DumpRenderTree/chromium/LayoutTestController.cpp:
16219         (LayoutTestController::LayoutTestController):
16220         (LayoutTestController::sendWebIntentResponse):
16221         * DumpRenderTree/chromium/LayoutTestController.h:
16222         (LayoutTestController):
16223         * DumpRenderTree/chromium/WebViewHost.h:
16224         (WebViewHost):
16225         (WebViewHost::currentIntentRequest):
16226
16227 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16228
16229         nrwt: port/Driver needs to support per-test command line args
16230         https://bugs.webkit.org/show_bug.cgi?id=79733
16231
16232         Reviewed by Adam Barth.
16233
16234         As part of removing the 'gpu' configurations and adding support
16235         for 'virtual test suites', the Driver classes need to support
16236         per-test command lines (since different tests will need to be
16237         run with different command line options).
16238
16239         The per-test args are not yet used, so this change should have
16240         no visible effects and need no additional testing.
16241
16242         * Scripts/webkitpy/layout_tests/port/base.py:
16243         (Port.driver_cmd_line):
16244         * Scripts/webkitpy/layout_tests/port/chromium.py:
16245         (ChromiumDriver.cmd_line):
16246         (ChromiumDriver._start):
16247         (ChromiumDriver.start):
16248         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
16249         (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
16250         (ChromiumDriverTest):
16251         (ChromiumDriverTest.test_two_drivers):
16252         * Scripts/webkitpy/layout_tests/port/driver.py:
16253         (Driver.cmd_line):
16254         (DriverProxy.__init__):
16255         (DriverProxy.start):
16256         (DriverProxy.cmd_line):
16257         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
16258         (DriverTest.test_virtual_driver_methods):
16259         * Scripts/webkitpy/layout_tests/port/gtk.py:
16260         (GtkDriver.cmd_line):
16261         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
16262         * Scripts/webkitpy/layout_tests/port/test.py:
16263         (TestPort._path_to_driver):
16264         (TestDriver.cmd_line):
16265         (TestDriver.start):
16266         * Scripts/webkitpy/layout_tests/port/webkit.py:
16267         (WebKitDriver.cmd_line):
16268         (WebKitDriver._start):
16269         (WebKitDriver.run_test):
16270         (WebKitDriver.start):
16271         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
16272         (WebKitDriverTest.test_no_timeout):
16273         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
16274         (PerfTestsRunner._run_tests_set):
16275         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
16276         (test_run_test_pause_before_testing):
16277
16278 2012-02-29  Dirk Pranke  <dpranke@chromium.org>
16279
16280         perftestsrunner can call printer.write() after printer.cleanup()
16281         https://bugs.webkit.org/show_bug.cgi?id=79872
16282
16283         Reviewed by Ryosuke Niwa.
16284
16285         This patch fixes a unittest that was incorrectly calling
16286         PerfTestsRunner.run() twice (which led to a weird state in the
16287         printer object).
16288
16289         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
16290         (MainTest.test_run_with_upload_json):
16291
16292 2012-02-29  Balazs Kelemen  <kbalazs@webkit.org>
16293
16294         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
16295         https://bugs.webkit.org/show_bug.cgi?id=76546
16296
16297         Reviewed by Simon Hausmann.
16298
16299         Revert the workaround introduced in r107868 and reintroduce
16300         the qml binding so we can test the code path that we are more
16301         interested in. The reason that it did not work before is that
16302         we don't have an active platform window which we now workaround
16303         by propagating the resize through QWindowSystemInterface.
16304
16305         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
16306         (WTR::WrapperWindow::handleStatusChanged):
16307         (WTR::PlatformWebView::resizeTo):
16308
16309 2012-02-29  Gabor Rapcsanyi  <rgabor@webkit.org>
16310
16311         [GTK] Small fix for cross compilation to not generate gtkdoc.
16312
16313         Rubber-stamped by Csaba Osztrogonác.
16314
16315         * Scripts/webkitdirs.pm:
16316         (isCrossCompilation):
16317
16318 2012-02-28  Lucas Forschler  <lforschler@apple.com>
16319
16320         Fix a typo in config.json
16321         linx -> linux
16322
16323         * BuildSlaveSupport/build.webkit.org-config/config.json:
16324
16325 2012-02-28  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
16326
16327         [Qt] Allow read/write to the WebView.url property
16328         https://bugs.webkit.org/show_bug.cgi?id=77554
16329
16330         Reviewed by Tor Arne Vestbø.
16331
16332         Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
16333
16334         * MiniBrowser/qt/qml/BrowserWindow.qml:
16335
16336 2012-02-28  Dan Winship  <danw@gnome.org>
16337
16338         [GTK] make tests explicitly request GSettingsBackendMemory
16339         https://bugs.webkit.org/show_bug.cgi?id=79788
16340
16341         Reviewed by Martin Robinson.
16342
16343         Explicitly request the fallback memory-based GSettings backend; if
16344         other backends are available then we don't want to use them,
16345         because they would make tests depend on the user's preferences.
16346         And if other backends aren't available, we don't need glib to
16347         print a warning about that fact.
16348
16349         * Scripts/webkitpy/layout_tests/port/gtk.py:
16350         (GtkPort.setup_environ_for_server):
16351
16352 2012-02-28  Sheriff Bot  <webkit.review.bot@gmail.com>
16353
16354         Unreviewed, rolling out r109110.
16355         http://trac.webkit.org/changeset/109110
16356         https://bugs.webkit.org/show_bug.cgi?id=79806
16357
16358         webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
16359         (Requested by aroben on #webkit).
16360
16361         * Scripts/webkitpy/common/checkout/changelog.py:
16362         (parse_bug_id):
16363         (parse_bug_id_from_changelog):
16364         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
16365         * Scripts/webkitpy/common/config/urls.py:
16366
16367 2012-02-28  Adam Roben  <aroben@webkit.org>
16368
16369         Add my new email address
16370
16371         Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
16372
16373         Reviewed by Anders Carlsson.
16374
16375         * Scripts/webkitpy/common/config/committers.py:
16376
16377 2012-02-28  Adam Roben  <aroben@apple.com>
16378
16379         Teach webkitpy about wkb.ug URLs
16380
16381         Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
16382         use wkb.ug URLs
16383
16384         Reviewed by Anders Carlsson.
16385
16386         * Scripts/webkitpy/common/checkout/changelog.py:
16387         (parse_bug_id):
16388         (parse_bug_id_from_changelog):
16389         Fall back to the tiny URL format if neither the short nor long URL formats work.
16390
16391         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
16392         (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
16393
16394         * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
16395         wkb.ug URLs.
16396
16397 2012-02-28  János Badics  <dicska@gmail.com>
16398
16399         [Qt] build-webkit does not detect the number of CPUs
16400         https://bugs.webkit.org/show_bug.cgi?id=76445
16401
16402         Based on Seo Sanghyeon's work (modification:
16403         Automatically determine the number of CPUs for make
16404         only if -j make argument haven't already been specified.)
16405
16406         Reviewed by Csaba Osztrogonác.
16407
16408         * Scripts/webkitdirs.pm:
16409         (buildQMakeProjects):
16410
16411 2012-02-28  Kent Tamura  <tkent@chromium.org>
16412
16413         Update a pattern for forms files of watchlist
16414         https://bugs.webkit.org/show_bug.cgi?id=79767
16415
16416         Reviewed by Kentaro Hara.
16417
16418         * Scripts/webkitpy/common/config/watchlist:
16419         Catches the following files with the "Forms" pattern.
16420         - HTMLDatListElement.*
16421         - HTMLKeygenElement.*
16422         - HTMLLegendElement.*
16423         - HTMLOutputElement.*
16424         - FormAssociatedElement.*
16425         - SliderThumbElement.*
16426         - TextControlInnerElements.*
16427         - RenderFileUploadControl.*
16428
16429 2012-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
16430
16431         Unreviewed, rolling out r109041.
16432         http://trac.webkit.org/changeset/109041
16433         https://bugs.webkit.org/show_bug.cgi?id=79741
16434
16435         Broke Chromium Win build (Requested by bashi on #webkit).
16436
16437         * DumpRenderTree/chromium/LayoutTestController.cpp:
16438         (LayoutTestController::LayoutTestController):
16439         * DumpRenderTree/chromium/LayoutTestController.h:
16440         (LayoutTestController):
16441         * DumpRenderTree/chromium/WebViewHost.h:
16442
16443 2012-02-27  James Robinson  <jamesr@chromium.org>
16444
16445         [chromium] Remove media tests from ChromiumGpu configurations
16446         https://bugs.webkit.org/show_bug.cgi?id=79720
16447
16448         Reviewed by Adam Barth.
16449
16450         We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
16451         composited playback path via tests in the compositing/ directory.
16452
16453         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
16454         (_default_tests_paths):
16455         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
16456         (ChromiumGpuTest.test_default_tests_paths):
16457         (ChromiumGpuTest.test_test_files):
16458
16459 2012-02-27  Dirk Pranke  <dpranke@chromium.org>
16460
16461         nrwt: log multiline stderr/crash output properly
16462         https://bugs.webkit.org/show_bug.cgi?id=79722
16463
16464         Reviewed by Adam Barth.
16465
16466         This cleans up some nits in the log output to make things
16467         slightly easier to read (every line gets timestamped, etc.).
16468
16469         Also tweaks the log message for pixel hash mismatches.
16470
16471         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
16472         (SingleTestRunner._handle_error):
16473         (SingleTestRunner._compare_image):
16474
16475 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
16476
16477         Touch the master.cfg to force a reconfig.
16478
16479         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
16480         (BuildAndTestLeaksFactory):
16481         (NewBuildAndTestFactory):
16482
16483 2012-02-27  Jacky Jiang  <zhajiang@rim.com>
16484
16485         [BlackBerry] Upstream BlackBerry API web page related files
16486         https://bugs.webkit.org/show_bug.cgi?id=74380
16487
16488         Reviewed by Antonio Gomes.
16489
16490         Adapt to the removing of WebPage::mainFrame(), use
16491         DumpRenderTreeSupport::corePage() and its mainFrame() instead.
16492
16493         No new tests as this patch doesn't change behavior.
16494
16495         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
16496         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
16497         (BlackBerry::WebKit::DumpRenderTree::runTests):
16498
16499 2012-02-27  Ryosuke Niwa  <rniwa@webkit.org>
16500
16501         Add Windows and Linux Chromium perf bots
16502         https://bugs.webkit.org/show_bug.cgi?id=79418
16503
16504         Reviewed by Tony Chang.
16505
16506         Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
16507         the dedicated perf bot slave (uses the same hardware).
16508
16509         * BuildSlaveSupport/build.webkit.org-config/config.json:
16510
16511 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
16512
16513         Undefined variable 'current' when running chromium_android.py
16514         https://bugs.webkit.org/show_bug.cgi?id=79696
16515
16516         Reviewed by Adam Barth.
16517
16518         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
16519         (ChromiumAndroidDriver._read_prompt):
16520
16521 2012-02-27  Greg Billock  <gbillock@google.com>
16522
16523         Add more tests for web intents
16524         https://bugs.webkit.org/show_bug.cgi?id=79527
16525
16526         Reviewed by Adam Barth.
16527
16528         * DumpRenderTree/chromium/LayoutTestController.cpp:
16529         (LayoutTestController::LayoutTestController):
16530         (LayoutTestController::sendWebIntentResponse):
16531         * DumpRenderTree/chromium/LayoutTestController.h:
16532         (LayoutTestController):
16533         * DumpRenderTree/chromium/WebViewHost.h:
16534         (WebViewHost):
16535         (WebViewHost::currentIntentRequest):
16536
16537 2012-02-27  Xianzhu Wang  <wangxianzhu@chromium.org>
16538
16539         Chromium-Android layout test script: the adb shell prompt is not always '# '
16540         https://bugs.webkit.org/show_bug.cgi?id=79506
16541
16542         Reviewed by Adam Barth.
16543
16544         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
16545         (ChromiumAndroidDriver._start):
16546         (ChromiumAndroidDriver._read_prompt):
16547
16548 2012-02-27  Dan Bernstein  <mitz@apple.com>
16549
16550         Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
16551         https://bugs.webkit.org/show_bug.cgi?id=79607
16552
16553         Reviewed by Adele Peterson.
16554
16555         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
16556         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
16557         (TestWebKitAPI::AcceptsFirstMouse::url):
16558         (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
16559         (TestWebKitAPI::AcceptsFirstMouse::runTest):
16560         (TestWebKitAPI::TEST_F):
16561         * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
16562
16563 2012-02-27  Carlos Garcia Campos  <cgarcia@igalia.com>
16564
16565         Unreviewed. Fix make distcheck.
16566
16567         * GNUmakefile.am: Fix typo.
16568
16569 2012-02-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
16570
16571         [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
16572
16573         Reviewed by Kenneth Rohde Christiansen..
16574
16575         * qmake/mkspecs/features/features.prf:
16576
16577 2012-02-27  Hao Zheng  <zhenghao@chromium.org>
16578
16579         Add a ChromiumGpuAndroid port.
16580         https://bugs.webkit.org/show_bug.cgi?id=79628
16581
16582         Reviewed by Adam Barth.
16583
16584         Android does have a gpu port, so revert r107697.
16585
16586         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
16587         (ChromiumAndroidPort.__init__):
16588         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
16589         (ChromiumGpuAndroidPort):
16590         (ChromiumGpuAndroidPort.__init__):
16591         (ChromiumGpuAndroidPort.baseline_search_path):
16592         (ChromiumGpuAndroidPort.default_child_processes):
16593         (ChromiumGpuAndroidPort.tests):
16594         * Scripts/webkitpy/layout_tests/port/factory.py:
16595         (PortFactory):
16596
16597 2012-02-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
16598
16599         Change Build bot with BuildAndTest bot for EFL port.
16600         https://bugs.webkit.org/show_bug.cgi?id=77518
16601
16602         Reviewed by Ryosuke Niwa.
16603
16604         EFL build bot starts to support layout test.
16605
16606         * BuildSlaveSupport/build.webkit.org-config/config.json:
16607         * BuildSlaveSupport/built-product-archive:
16608         (archiveBuiltProduct):
16609         (extractBuiltProduct):
16610         * BuildSlaveSupport/test-result-archive:
16611         (archiveTestResults):
16612         * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
16613         (generateBuildSystemFromCMakeProject):
16614
16615 2012-02-24  Darin Fisher  <darin@chromium.org>
16616
16617         Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
16618
16619         Reviewed by James Robinson.
16620
16621         * Scripts/webkitpy/common/config/watchlist:
16622
16623 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
16624
16625         webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
16626         https://bugs.webkit.org/show_bug.cgi?id=79258
16627
16628         Reviewed by Ryosuke Niwa.
16629
16630         Split the fuzzy matching into separate functions so that they
16631         can be sharded and run in parallel.
16632
16633         Also, fix a bug in the svn_blame_regexp that was causing us
16634         to require ChangeLog lines to have at least one space after the
16635         author, making the code require trailing whitespace in the
16636         changelog in some places (this was making my life harder because
16637         I have my text editor set to strip trailing whitespace in python
16638         files, and that was causing test_parse_log_entries_from_changelog() to fail
16639         when the whitespace on line 275 was removed).
16640
16641         * Scripts/webkitpy/common/checkout/changelog.py:
16642         (ChangeLog):
16643         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
16644         (test_fuzzy_reviewer_match__none):
16645         (test_fuzzy_reviewer_match_adam_barth):
16646         (test_fuzzy_reviewer_match_darin_adler_et_al):
16647         (test_fuzzy_reviewer_match_dimitri_glazkov):
16648         (test_fuzzy_reviewer_match_george_staikos):
16649         (test_fuzzy_reviewer_match_mark_rowe):
16650
16651 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
16652
16653         webkitpy: committers_unittest fuzzy matching is really slow
16654         https://bugs.webkit.org/show_bug.cgi?id=79179
16655
16656         Reviewed by Ryosuke Niwa.
16657
16658         Break the fuzzy matching tests into individual routines for
16659         each contributor so that the intent is a little clearer, so
16660         that it's easier to test individual names (and identify
16661         duplicate tests), and so that we can eventually run
16662         them in parallel.
16663
16664         Also, mark most of them as 'integration' tests so that they
16665         can be skipped if we want to go fast (we leave a few as
16666         regular tests for functional coverage).
16667
16668         * Scripts/webkitpy/common/config/committers_unittest.py:
16669         (CommittersTest):
16670         (CommittersTest.test_contributors_by_fuzzy_match):
16671         (CommittersTest.integration_test_contributors__none):
16672         (CommittersTest.integration_test_contributors__none_2):
16673         (CommittersTest.integration_test_contributors__none_3):
16674         (CommittersTest.integration_test_contributors_ada_chan):
16675         (CommittersTest.integration_test_contributors_adele_peterson):
16676         (CommittersTest.integration_test_contributors_alexey_proskuryakov):
16677         (CommittersTest.integration_test_contributors_alice_liu):
16678         (CommittersTest.integration_test_contributors_alp_toker):
16679         (CommittersTest.integration_test_contributors_anders_carlsson):
16680         (CommittersTest.integration_test_contributors_antti_koivisto):
16681         (CommittersTest.integration_test_contributors_beth_dakin):
16682         (CommittersTest.integration_test_contributors_brady_eidson):
16683         (CommittersTest.integration_test_contributors_cameron_zwarich):
16684         (CommittersTest.integration_test_contributors_chris_blumenberg):
16685         (CommittersTest.integration_test_contributors_dan_bernstein):
16686         (CommittersTest.integration_test_contributors_dan_bernstein_2):
16687         (CommittersTest.integration_test_contributors_darin_adler):
16688         (CommittersTest.integration_test_contributors_david_harrison):
16689         (CommittersTest.integration_test_contributors_david_harrison_2):
16690         (CommittersTest.integration_test_contributors_david_hyatt):
16691         (CommittersTest.integration_test_contributors_david_kilzer):
16692         (CommittersTest.integration_test_contributors_don_melton):
16693         (CommittersTest.integration_test_contributors_eric_seidel):
16694         (CommittersTest.integration_test_contributors_geoffrey_garen):
16695         (CommittersTest.integration_test_contributors_greg_bolsinga):
16696         (CommittersTest.integration_test_contributors_holger_freyther):
16697         (CommittersTest.integration_test_contributors_jon_sullivan):
16698         (CommittersTest.integration_test_contributors_jon_honeycutt):
16699         (CommittersTest.integration_test_contributors_joseph_pecoraro):
16700         (CommittersTest.integration_test_contributors_ken_kocienda):
16701         (CommittersTest.integration_test_contributors_kenneth_russell):
16702         (CommittersTest.integration_test_contributors_kevin_decker):
16703         (CommittersTest.integration_test_contributors_kevin_mccullough):
16704         (CommittersTest.integration_test_contributors_lars_knoll):
16705         (CommittersTest.integration_test_contributors_lars_weintraub):
16706         (CommittersTest.integration_test_contributors_maciej_stachowiak):
16707         (CommittersTest.integration_test_contributors_mark_rowe):
16708         (CommittersTest.integration_test_contributors_nikolas_zimmermann):
16709         (CommittersTest.integration_test_contributors_oliver_hunt):
16710         (CommittersTest.integration_test_contributors_rniwa):
16711         (CommittersTest.disabled_integration_test_contributors_simon_fraser):
16712         (CommittersTest.integration_test_contributors_steve_falkenburg):
16713         (CommittersTest.integration_test_contributors_sam_weinig):
16714         (CommittersTest.integration_test_contributors_tim_omernick):
16715         (CommittersTest.integration_test_contributors_timothy_hatcher):
16716         (CommittersTest.integration_test_contributors_tor_arne_vestbo):
16717         (CommittersTest.integration_test_contributors_vicki_murley):
16718         (CommittersTest.integration_test_contributors_zack_rusin):
16719
16720 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
16721
16722         webkitpy: should autoinstall coverage
16723         https://bugs.webkit.org/show_bug.cgi?id=79535
16724
16725         Reviewed by Eric Seidel.
16726
16727         We should automatically print the coverage report after the run, too.
16728
16729         * Scripts/webkitpy/test/main.py:
16730         (Tester._run_tests):
16731         * Scripts/webkitpy/thirdparty/__init__.py:
16732         (AutoinstallImportHook.find_module):
16733         (AutoinstallImportHook._install_coverage):
16734
16735 2012-02-24  Pablo Flouret  <pablof@motorola.com>
16736
16737         Fix copypasta in build-webkit's --vibration option description
16738         https://bugs.webkit.org/show_bug.cgi?id=79528
16739
16740         Reviewed by Andreas Kling.
16741
16742         * Scripts/build-webkit:
16743
16744 2012-02-24  Antonio Gomes  <agomes@rim.com>
16745
16746         Adding myself to ScrollingCoordinator watchlist
16747         https://bugs.webkit.org/show_bug.cgi?id=79525
16748
16749         Reviewed by Rob Buis.
16750
16751         * Scripts/webkitpy/common/config/watchlist:
16752
16753 2012-02-24  Darin Fisher  <darin@chromium.org>
16754
16755         Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
16756
16757         Reviewed by Adam Barth.
16758
16759         * Scripts/webkitpy/common/config/watchlist:
16760
16761 2012-02-24  Dirk Pranke  <dpranke@chromium.org>
16762
16763         webkitpy: config_unittest is sensitive to other tests that might've already run
16764         https://bugs.webkit.org/show_bug.cgi?id=79382
16765
16766         Reviewed by Adam Barth.
16767
16768         If another test runs prior to config_unittest and pokes the
16769         cached configuration, the first test in config_unittest might
16770         fail; the tearDown() will then allow subsequent tests to pass.
16771         Clearing the configuration prior to each test makes things
16772         slightly slower but safer.
16773
16774         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
16775         (ConfigTest.setUp):
16776
16777 2012-02-24  David Kilzer  <ddkilzer@apple.com>
16778
16779         Use xcrun to find compiler paths for Generate Derived Sources build phase script
16780         <http://webkit.org/b/79512>
16781
16782         Reviewed by Dan Bernstein.
16783
16784         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
16785         (Generate Derived Sources): Use xcrun to find the path to the
16786         compiler since that works on both iOS and OS X.
16787
16788 2012-02-24  James Robinson  <jamesr@chromium.org>
16789
16790         Create a watchlist for ScrollingCoordinator changes
16791         https://bugs.webkit.org/show_bug.cgi?id=79511
16792
16793         Reviewed by Anders Carlsson.
16794
16795         * Scripts/webkitpy/common/config/watchlist:
16796
16797 2012-02-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
16798
16799         [EFL][DRT] Implement setValueForUser and setAutofilled.
16800         https://bugs.webkit.org/show_bug.cgi?id=79237
16801
16802         Reviewed by Andreas Kling.
16803
16804         Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
16805         Those implementations are related with input fields and allow to pass following tests:
16806         fast/forms/onchange-setvalueforuser.html
16807         fast/forms/input-autofilled.html
16808         fast/forms/reset-autofilled.html
16809
16810         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
16811         (LayoutTestController::setValueForUser):
16812         (LayoutTestController::setAutofilled):
16813
16814 2012-02-24  Zoltan Horvath  <zoltan@webkit.org>
16815
16816         [Qt] Allow to use WebCore imagedecoders
16817         https://bugs.webkit.org/show_bug.cgi?id=32410
16818
16819         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
16820
16821         Reviewed by Simon Hausmann.
16822
16823         * qmake/mkspecs/features/features.prf:
16824
16825 2012-02-24  Balazs Kelemen  <kbalazs@webkit.org>
16826
16827         [Qt] Add Qt5 way to force 96 DPI for tests
16828         https://bugs.webkit.org/show_bug.cgi?id=79364
16829
16830         Reviewed by Simon Hausmann.
16831
16832         * DumpRenderTree/qt/main.cpp:
16833         (main):
16834         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
16835         (WTR::activateFonts):
16836
16837 2012-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
16838
16839         [GTK] MiniBrowser should reload the view then the reload button is clicked
16840         https://bugs.webkit.org/show_bug.cgi?id=79472
16841
16842         Reviewed by Philippe Normand.
16843
16844         * MiniBrowser/gtk/BrowserWindow.c:
16845         (reloadCallback): Call webkit_web_view_reload().
16846         (browser_window_init): Connect reload item clicked even to
16847         reloadCallback instead of activateUriEntryCallback.
16848
16849 2012-02-24  Kentaro Hara  <haraken@chromium.org>
16850
16851         Add performance tests for DOM attribute getters and setters
16852         https://bugs.webkit.org/show_bug.cgi?id=79208
16853
16854         Reviewed by Ryosuke Niwa.
16855
16856         We want to allow perf tests to output info messages
16857         that do not affect the test results. To accomplish this,
16858         this patch modifies perftestsrunner.py so that it ignores
16859         a line that starts from "Info:".
16860
16861         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
16862         (PerfTestsRunner):
16863
16864 2012-02-24  Andrew Lo  <anlo@rim.com>
16865
16866         [BlackBerry] Enable requestAnimationFrame
16867         https://bugs.webkit.org/show_bug.cgi?id=79408
16868
16869         Enable requestAnimationFrame for BlackBerry.
16870
16871         Reviewed by Rob Buis.
16872
16873         * Scripts/build-webkit:
16874
16875 2012-02-24  Adam Barth  <abarth@webkit.org>
16876
16877         style-queue tries to apply the patch twice
16878         https://bugs.webkit.org/show_bug.cgi?id=79459
16879
16880         Reviewed by Eric Seidel.
16881
16882         Previously, we applied the patch using both apply-patch and
16883         check-style.  This patch introduces a check-style-local to mirror the
16884         apply-watchlist-local, which operates on the current working diff.
16885
16886         This patch also cleans up some other bugs I found by running the queue
16887         locally for a while.  The queue still prints out a slightly
16888         less-than-ideal message on the bugs when it find an error, but it's ok
16889         for now.  We'll need to iterate a bit.
16890
16891         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
16892         (StyleQueueTask.validate):
16893         (StyleQueueTask._check_style):
16894         * Scripts/webkitpy/tool/commands/download.py:
16895         (CheckStyleLocal):
16896         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
16897         (EarlyWarningSytemTest._default_expected_stderr):
16898         (EarlyWarningSytemTest._test_testing_ews):
16899         * Scripts/webkitpy/tool/commands/queues.py:
16900         (AbstractReviewQueue.handle_script_error):
16901         (StyleQueue.review_patch):
16902         * Scripts/webkitpy/tool/commands/queues_unittest.py:
16903         * Scripts/webkitpy/tool/commands/queuestest.py:
16904         (QueuesTest.assert_queue_outputs):
16905
16906 2012-02-23  Adam Barth  <abarth@webkit.org>
16907
16908         should_proceed_with_work_item is unused and can be removed
16909         https://bugs.webkit.org/show_bug.cgi?id=79416
16910
16911         Reviewed by Eric Seidel.
16912
16913         We used to use this function to check whether the tree is red.  Now, we
16914         don't use external measures of whether to proceed with work items.
16915         Instead, we analyze them with the idea in mind that the tree might be
16916         red.
16917
16918         * Scripts/webkitpy/tool/bot/queueengine.py:
16919         (QueueEngineDelegate.next_work_item):
16920         (QueueEngine.run):
16921         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
16922         (LoggingDelegate):
16923         (LoggingDelegate.next_work_item):
16924         (RaisingDelegate.process_work_item):
16925         (QueueEngineTest.test_terminating_error):
16926         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
16927         (AbstractEarlyWarningSystem.__init__):
16928         * Scripts/webkitpy/tool/commands/queues.py:
16929         (AbstractQueue.next_work_item):
16930         (FeederQueue.next_work_item):
16931         (CommitQueue.next_work_item):
16932         (AbstractReviewQueue.next_work_item):
16933         (StyleQueue.__init__):
16934         * Scripts/webkitpy/tool/commands/queues_unittest.py:
16935         (FeederQueueTest.test_feeder_queue):
16936         (CommitQueueTest.test_commit_queue):
16937         (test_commit_queue_failure):
16938         (test_commit_queue_failure_with_failing_tests):
16939         (test_rollout):
16940         (test_rollout_lands):
16941         (StyleQueueTest.test_style_queue_with_style_exception):
16942         (test_style_queue_with_watch_list_exception):
16943         * Scripts/webkitpy/tool/commands/queuestest.py:
16944         (QueuesTest.assert_queue_outputs):
16945         * Scripts/webkitpy/tool/commands/sheriffbot.py:
16946         (SheriffBot.next_work_item):
16947
16948 2012-02-23  Adrienne Walker  <enne@google.com>
16949
16950         Unreviewed, add Stephen Chenney to committers.py as a contributor.
16951
16952         * Scripts/webkitpy/common/config/committers.py:
16953
16954 2012-02-23  Adam Barth  <abarth@webkit.org>
16955
16956         style-queue logs bogus messages to the QueueStatusServer
16957         https://bugs.webkit.org/show_bug.cgi?id=79424
16958
16959         Reviewed by Eric Seidel.
16960
16961         Copy/paste error.
16962
16963         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
16964         (StyleQueueTask._check_style):
16965         (StyleQueueTask._apply_watch_list):
16966         * Scripts/webkitpy/tool/commands/queues_unittest.py:
16967
16968 2012-02-23  Eric Seidel  <eric@webkit.org>
16969
16970         Use self._filesystem in more places in the SCM classes
16971         https://bugs.webkit.org/show_bug.cgi?id=79415
16972
16973         Reviewed by Adam Barth.
16974
16975         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
16976         (SCMDetectorTest.test_detect_scm_system):
16977         * Scripts/webkitpy/common/checkout/scm/git.py:
16978         (Git.find_checkout_root):
16979         (Git.to_object_name):
16980         * Scripts/webkitpy/common/checkout/scm/scm.py:
16981         (SCM.__init__):
16982         (SCM.in_working_directory):
16983         * Scripts/webkitpy/common/checkout/scm/svn.py:
16984         (SVN.find_uuid):
16985         (SVN.find_checkout_root):
16986
16987 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
16988
16989         Unreviewed, rolling out r108685.
16990         http://trac.webkit.org/changeset/108685
16991         https://bugs.webkit.org/show_bug.cgi?id=79414
16992
16993         Broke Chromium builds (Requested by enne on #webkit).
16994
16995         * qmake/mkspecs/features/features.prf:
16996
16997 2012-02-23  Adam Barth  <abarth@webkit.org>
16998
16999         style-queue shouldn't spam bugs if it fails to update its working copy
17000         https://bugs.webkit.org/show_bug.cgi?id=79412
17001
17002         Reviewed by Eric Seidel.
17003
17004         This patch moves style-queue over to the new PatchAnalysisTask
17005         infrastructure, which is smarter about retrying patches when update
17006         fails.
17007
17008         * Scripts/webkitpy/common/system/executive_mock.py:
17009         (MockExecutive.run_and_throw_if_fail):
17010         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
17011         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
17012         (UnableToApplyPatch):
17013         (UnableToApplyPatch.__init__):
17014         (PatchAnalysisTask.__init__):
17015         * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
17016         (StyleQueueTaskDelegate):
17017         (StyleQueueTaskDelegate.parent_command):
17018         (StyleQueueTask):
17019         (StyleQueueTask.validate):
17020         (StyleQueueTask._check_style):
17021         (StyleQueueTask._apply_watch_list):
17022         (StyleQueueTask.run):
17023         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
17024         * Scripts/webkitpy/tool/commands/queues.py:
17025         (StyleQueue):
17026         (StyleQueue.should_proceed_with_work_item):
17027         (StyleQueue.review_patch):
17028         (StyleQueue.run_command):
17029         (StyleQueue.command_passed):
17030         (StyleQueue.command_failed):
17031         (StyleQueue.expected_failures):
17032         (StyleQueue.refetch_patch):
17033         * Scripts/webkitpy/tool/commands/queues_unittest.py:
17034         (StyleQueueTest.test_style_queue_with_style_exception):
17035         (test_style_queue_with_watch_list_exception):
17036
17037 2012-02-23  Zoltan Horvath  <zoltan@webkit.org>
17038
17039         [Qt] Allow to use WebCore imagedecoders
17040         https://bugs.webkit.org/show_bug.cgi?id=32410
17041
17042         Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
17043
17044         Reviewed by Simon Hausmann.
17045
17046         * qmake/mkspecs/features/features.prf:
17047
17048 2012-02-23  Eric Seidel  <eric@webkit.org>
17049
17050         Remove old broken find_checkout_root tests now that find_checkout_root is gone
17051         https://bugs.webkit.org/show_bug.cgi?id=79405
17052
17053         Reviewed by Adam Barth.
17054
17055         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
17056         (SCMDetectorTest):
17057         (SCMDetectorTest.test_find_checkout_root):
17058         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
17059         (SVNTestRepository.tear_down):
17060
17061 2012-02-23  Michael Brüning  <michael.bruning@nokia.com>
17062
17063         [Qt][WK2] Implement proxy authentication dialog.
17064         https://bugs.webkit.org/show_bug.cgi?id=79350
17065
17066         Reviewed by Simon Hausmann.
17067
17068         * MiniBrowser/qt/MiniBrowser.qrc:
17069         * MiniBrowser/qt/qml/BrowserWindow.qml:
17070         * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
17071
17072 2012-02-23  Kevin Ollivier  <kevino@theolliviers.com>
17073
17074         [wx] Build fix, add recently added source dirs.
17075
17076         * waf/build/settings.py:
17077
17078 2012-02-23  Simon Hausmann  <simon.hausmann@nokia.com>
17079
17080         [Qt] Add support for touch cancellation
17081         https://bugs.webkit.org/show_bug.cgi?id=79348
17082
17083         Reviewed by Kenneth Rohde Christiansen.
17084
17085         Added straight-forward touch cancellation event sending to Qt WK1 DRT
17086         and WK2 WTR.
17087
17088         * DumpRenderTree/qt/EventSenderQt.cpp:
17089         (EventSender::touchCancel):
17090         (EventSender::cancelTouchPoint):
17091         * DumpRenderTree/qt/EventSenderQt.h:
17092         (EventSender):
17093         * WebKitTestRunner/EventSenderProxy.h:
17094         (EventSenderProxy):
17095         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
17096         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
17097         (WTR::EventSendingController::touchCancel):
17098         (WTR):
17099         (WTR::EventSendingController::cancelTouchPoint):
17100         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
17101         (EventSendingController):
17102         * WebKitTestRunner/TestController.cpp:
17103         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
17104         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
17105         (WTR::EventSenderProxy::touchCancel):
17106         (WTR):
17107         (WTR::EventSenderProxy::cancelTouchPoint):
17108
17109 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
17110
17111         Unreviewed, rolling out r108626.
17112         http://trac.webkit.org/changeset/108626
17113         https://bugs.webkit.org/show_bug.cgi?id=79370
17114
17115         broke qt-wk2 bot, somehow the workaround does not work on the
17116         bot (Requested by Ossy on #webkit).
17117
17118         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17119         (WTR::WrapperWindow::handleStatusChanged):
17120         (WTR::PlatformWebView::resizeTo):
17121
17122 2012-02-23  ChangSeok Oh  <shivamidow@gmail.com>
17123
17124         [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
17125         https://bugs.webkit.org/show_bug.cgi?id=78481
17126
17127         Reviewed by Gustavo Noronha Silva.
17128
17129         Extracted shareable code from keyDownCallback and then added createKeyPressEvent
17130         to create gdk press key event.
17131         Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
17132         and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
17133
17134         * DumpRenderTree/gtk/EventSender.cpp:
17135         (scheduleAsynchronousClickCallback):
17136         (createKeyPressEvent):
17137         (sendKeyDown):
17138         (keyDownCallback):
17139         (sendAsynchronousKeyDown):
17140         (scheduleAsynchronousKeyDownCallback):
17141
17142 2012-02-23  Balazs Kelemen  <kbalazs@webkit.org>
17143
17144         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
17145         https://bugs.webkit.org/show_bug.cgi?id=76546
17146
17147         Reviewed by Simon Hausmann.
17148
17149         Co-authored with Simon Hausmann.
17150
17151         Revert the workaround introduced in r107868 and reintroduce
17152         the qml binding so we can test the code path that we are more
17153         interested in. The reason that it did not work before is that
17154         we don't have an active platform window which we now workaround
17155         by propagating the resize through QWindowSystemInterface.
17156
17157         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17158         (WTR::WrapperWindow::handleStatusChanged):
17159         (WTR::PlatformWebView::resizeTo):
17160
17161 2012-02-23  Sheriff Bot  <webkit.review.bot@gmail.com>
17162
17163         Unreviewed, rolling out r108577.
17164         http://trac.webkit.org/changeset/108577
17165         https://bugs.webkit.org/show_bug.cgi?id=79359
17166
17167         It doesn't work as expected (Requested by Ossy on #webkit).
17168
17169         * DumpRenderTree/qt/EventSenderQt.cpp:
17170         (EventSender::postEvent):
17171         * DumpRenderTree/qt/EventSenderQt.h:
17172         (EventSender):
17173
17174 2012-02-23  Philippe Normand  <pnormand@igalia.com>
17175
17176         [GTK] FullScreen signals
17177         https://bugs.webkit.org/show_bug.cgi?id=76181
17178
17179         Reviewed by Martin Robinson.
17180
17181         Use the two new entering/leaving fullscreen signals to hide/show
17182         the tool bar, the status bar and ask the user's permission before
17183         entering fullscreen.
17184
17185         * GtkLauncher/main.c:
17186         (webViewFullscreenMessageWindowClose):
17187         (webViewWindowStateEvent):
17188         (hide_widget):
17189         (show_widget):
17190         (webViewEnteringFullScreen):
17191         (webViewLeavingFullScreen):
17192         (createBrowser):
17193         (createWindow):
17194
17195 2012-02-22  Dongwoo Im  <dw.im@samsung.com>
17196
17197         [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
17198         https://bugs.webkit.org/show_bug.cgi?id=79076
17199
17200         Reviewed by Andreas Kling.
17201
17202         * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
17203         (builtDylibPathForName):
17204
17205 2012-02-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
17206
17207         [Qt] Add eventSender.gestureTap
17208         https://bugs.webkit.org/show_bug.cgi?id=66173
17209
17210         Reviewed by Kenneth Rohde Christiansen.
17211
17212         * DumpRenderTree/qt/EventSenderQt.cpp:
17213         (EventSender::gestureTap):
17214         * DumpRenderTree/qt/EventSenderQt.h:
17215
17216 2012-02-22  Brady Eidson  <beidson@apple.com>
17217
17218         <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
17219         Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
17220
17221         Reviewed by Anders Carlsson.
17222
17223         Update our tools to the new form of the PageLoadClient.
17224
17225         * MiniBrowser/mac/BrowserWindowController.m:
17226         (-[BrowserWindowController awakeFromNib]):
17227
17228         * WebKitTestRunner/TestController.cpp:
17229         (WTR::TestController::initialize):
17230
17231 2012-02-22  Daniel Bates  <dbates@webkit.org>
17232
17233         new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
17234         https://bugs.webkit.org/show_bug.cgi?id=79277
17235
17236         Reviewed by Adam Barth.
17237
17238         Pass command line argument no-saved-state to run-safari to disable Safari
17239         state restoration for the session on OS 10.7.
17240
17241         * Scripts/webkitpy/layout_tests/port/mac.py:
17242         (MacPort.show_results_html_file):
17243         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
17244         (test_show_results_html_file):
17245
17246 2012-02-22  Kalev Lember  <kalevlember@gmail.com>
17247
17248         Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
17249         https://bugs.webkit.org/show_bug.cgi?id=77759
17250
17251         Reviewed by Tony Chang.
17252
17253         Fixes build with gcc 4.7.
17254
17255         r100432 added the include only for ANDROID; this changes the ifdef to
17256         also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
17257         longer implicitly includes unistd.h from standard headers and other
17258         unix platforms are likely to get gcc 4.7 as well in the future.
17259
17260         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
17261
17262 2012-02-22  Philippe Normand  <pnormand@igalia.com>
17263
17264         Unreviewed, rolling out r108522.
17265         http://trac.webkit.org/changeset/108522
17266         https://bugs.webkit.org/show_bug.cgi?id=76181
17267
17268         Broke 4 fullscreen tests on GTK.
17269
17270         * GtkLauncher/main.c:
17271         (createBrowser):
17272         (createWindow):
17273
17274 2012-02-20  Philippe Normand  <pnormand@igalia.com>
17275
17276         [GTK] FullScreen signals
17277         https://bugs.webkit.org/show_bug.cgi?id=76181
17278
17279         Reviewed by Martin Robinson.
17280
17281         Use the two new entering/leaving fullscreen signals to hide/show
17282         the tool bar, the status bar and ask the user's permission before
17283         entering fullscreen.
17284
17285         * GtkLauncher/main.c:
17286         (webViewFullscreenMessageWindowClose):
17287         (webViewWindowStateEvent):
17288         (hide_widget):
17289         (show_widget):
17290         (webViewEnteringFullScreen):
17291         (webViewLeavingFullScreen):
17292         (createBrowser):
17293         (createWindow):
17294
17295 2012-02-22  Rob Flack  <flackr@chromium.org>
17296
17297         Update Linux ChromiumOS builders in flakiness dashboard.
17298         https://bugs.webkit.org/show_bug.cgi?id=79238
17299
17300         Reviewed by Ojan Vafai.
17301
17302         * TestResultServer/static-dashboards/builders.js:
17303
17304 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
17305
17306         webkitpy: test_function_length_check_definition_huge_lines is slow
17307         https://bugs.webkit.org/show_bug.cgi?id=79185
17308
17309         Reviewed by Adam Barth.
17310
17311         This test takes ~3 seconds to run, apparently because we're
17312         running a test on a 10,000 line function :). Dropping the
17313         function length to 640 still exercises the code path and
17314         provides a 10x speedup.
17315
17316         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
17317         (CppStyleTest):
17318         (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
17319
17320 2012-02-22  Dirk Pranke  <dpranke@chromium.org>
17321
17322         webkitpy: speed up FileLockTest.test_lock_lifecycle
17323         https://bugs.webkit.org/show_bug.cgi?id=79189
17324
17325         Reviewed by Adam Barth.
17326
17327         The unit test had a second lock trying to acquire a
17328         lock already held, and a hard-coded timeout of one second.
17329         I have changed the timeouts to a tenth of a second (which
17330         is probably still fine) and changed the hard-spin on
17331         the lock to a slow-spin every hundredth of a second.
17332
17333         * Scripts/webkitpy/common/system/file_lock.py:
17334         (FileLock.acquire_lock):
17335         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
17336         (FileLockTest.setUp):
17337         (FileLockTest.test_stuck_lock):
17338
17339 2012-02-22  Gabor Rapcsanyi  <rgabor@webkit.org>
17340
17341         build-webkit should use environment variable at number of CPU
17342         detection on all platform
17343         https://bugs.webkit.org/show_bug.cgi?id=79227
17344
17345         Reviewed by Martin Robinson.
17346
17347         * Scripts/webkitdirs.pm:
17348         (determineNumberOfCPUs):
17349
17350 2012-02-22  Mihnea Ovidenie  <mihnea@adobe.com>
17351
17352         [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
17353         https://bugs.webkit.org/show_bug.cgi?id=78960
17354
17355         Reviewed by Csaba Osztrogonác.
17356
17357         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
17358         (LayoutTestController::overridePreference):
17359
17360 2012-02-22  Hao Zheng  <zhenghao@chromium.org>
17361
17362         [chromium] Build WebKit with MEDIA_STREAM disabled.
17363         https://bugs.webkit.org/show_bug.cgi?id=79214
17364
17365         Reviewed by Kent Tamura.
17366
17367         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
17368         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
17369         * DumpRenderTree/chromium/WebViewHost.cpp:
17370         (WebViewHost::createMediaPlayer):
17371         * DumpRenderTree/chromium/WebViewHost.h:
17372         (WebViewHost):
17373
17374 2012-02-22  Zeno Albisser  <zeno@webkit.org>
17375
17376         [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
17377         https://bugs.webkit.org/show_bug.cgi?id=79124
17378
17379         WebKitTestRunnerPrefix.h should also be included
17380         when building with clang.
17381
17382         Reviewed by Kenneth Rohde Christiansen.
17383
17384         * WebKitTestRunner/Target.pri:
17385
17386 2012-02-20  Roland Steiner  <rolandsteiner@chromium.org>
17387
17388         <style scoped>: Add runtime-flag
17389         https://bugs.webkit.org/show_bug.cgi?id=79074
17390
17391         Enable the runtime-flag for DRT.
17392
17393         Reviewed by Dimitri Glazkov.
17394
17395         * DumpRenderTree/chromium/TestShell.cpp:
17396         (TestShell::TestShell):
17397
17398 2012-02-22  Carlos Garcia Campos  <cgarcia@igalia.com>
17399
17400         Unreviewed, rolling out r107351.
17401         http://trac.webkit.org/changeset/107351
17402         https://bugs.webkit.org/show_bug.cgi?id=53600
17403
17404         Several issues introduced in WebKitGTK+ API
17405
17406         * DumpRenderTree/gtk/DumpRenderTree.cpp:
17407         (createWebView):
17408         * GtkLauncher/main.c:
17409         (createWebViewCb):
17410         (createBrowser):
17411         (createWindow):
17412         (main):
17413
17414 2012-02-21  Filip Pizlo  <fpizlo@apple.com>
17415
17416         JSC should be a triple-tier VM
17417         https://bugs.webkit.org/show_bug.cgi?id=75812
17418         <rdar://problem/10079694>
17419
17420         Reviewed by Gavin Barraclough.
17421
17422         Changed EFL's build system to include a new directory in JavaScriptCore.
17423
17424         * DumpRenderTree/efl/CMakeLists.txt:
17425
17426 2012-02-21  Daniel Cheng  <dcheng@chromium.org>
17427
17428         [chromium] Fix image drag out on Chromium
17429         https://bugs.webkit.org/show_bug.cgi?id=79158
17430
17431         Reviewed by Tony Chang.
17432
17433         * DumpRenderTree/chromium/EventSender.cpp:
17434         (EventSender::dumpFilenameBeingDragged):
17435         (EventSender::beginDragWithFiles):
17436         * DumpRenderTree/chromium/WebViewHost.cpp:
17437         (addDRTFakeFileToDataObject):
17438
17439 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
17440
17441         webkitpy: speed up hot filesystem_mock functions
17442         https://bugs.webkit.org/show_bug.cgi?id=79159
17443
17444         Reviewed by Adam Barth.
17445
17446         Profiling run_webkit_tests_integrationtest.py revealed that
17447         isdir(), normpath(), and join() are called a lot and were very
17448         slow.This patch speeds them up substantially, shaving 20 seconds
17449         off of the execution time.
17450
17451         * Scripts/webkitpy/common/system/filesystem_mock.py:
17452         (MockFileSystem.isdir):
17453         (MockFileSystem._slow_but_correct_join):
17454         (MockFileSystem.join):
17455         (MockFileSystem.listdir):
17456         (MockFileSystem._slow_but_correct_normpath):
17457         (MockFileSystem.normpath):
17458         (MockFileSystem.write_binary_file):
17459         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
17460         (MockFileSystemTest.quick_check):
17461         (MockFileSystemTest):
17462         (MockFileSystemTest.test_join):
17463         (MockFileSystemTest.test_normpath):
17464         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
17465         (get_test_config): Call write_binary_file() instead of updating
17466           filesystem.files directly, so that we create directories as
17467           needed.
17468
17469 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
17470
17471         nrwt: make the delay between starting workers configurable per-port
17472         https://bugs.webkit.org/show_bug.cgi?id=79148
17473
17474         Reviewed by Eric Seidel.
17475
17476         Because of bug 79147, we have to sleep a bit in between starting
17477         DRTs; however, doing so across the board slows down the Test
17478         port. Making this configurable shaves 10 seconds off of
17479         run_webkit_tests_integrationtest.py
17480
17481         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17482         (Manager._run_tests):
17483         * Scripts/webkitpy/layout_tests/port/base.py:
17484         (Port.worker_startup_delay_secs):
17485         * Scripts/webkitpy/layout_tests/port/test.py:
17486         (TestPort.worker_startup_delay_secs):
17487
17488 2012-02-21  Jon Lee  <jonlee@apple.com>
17489
17490         Bring notifications support to WK1 mac
17491         https://bugs.webkit.org/show_bug.cgi?id=78783
17492         <rdar://problem/10610578>
17493
17494         Reviewed by Anders Carlsson.
17495
17496         * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
17497         (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
17498         (-[UIDelegate timerFired]):
17499
17500 2012-02-21  Kentaro Hara  <haraken@chromium.org>
17501
17502         Enable the IDL attribute checker in run-bindings-tests
17503         https://bugs.webkit.org/show_bug.cgi?id=79091
17504
17505         Reviewed by Adam Barth.
17506
17507         We have enabled the IDL attribute checker in Chromium in r108322.
17508         This patch enables the IDL attribute checker in run-bindings-tests.
17509
17510         No tests. I manually checked that [Custommm], [CallWith=],
17511         [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
17512         run-bindings-tests failures.
17513
17514         * Scripts/webkitpy/bindings/main.py:
17515         (BindingsTests.generate_supplemental_dependency):
17516
17517 2012-02-21  Rafael Weinstein  <rafaelw@chromium.org>
17518
17519         Add rafaelw as a committer.
17520
17521         Unreviewed.
17522
17523         * Scripts/webkitpy/common/config/committers.py:
17524
17525 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
17526
17527         webkitpy: update names after deleting message_broker
17528         https://bugs.webkit.org/show_bug.cgi?id=79000
17529
17530         Reviewed by Eric Seidel.
17531
17532         Part 3 of 3 in deleting message_broker.py; this change just
17533         adjusts the names for the newly merged symbols so that they are
17534         private as appropriate.
17535
17536         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
17537         (get):
17538         (_Broker):
17539         (_BrokerConnection):
17540         (_BrokerConnection.__init__):
17541         (AbstractWorker.__init__):
17542         (_ManagerConnection):
17543         (_ManagerConnection.__init__):
17544         (_WorkerConnection):
17545         (_WorkerConnection.__init__):
17546
17547 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
17548
17549         webkitpy: merge message_broker.py into manager_worker_broker.py
17550         https://bugs.webkit.org/show_bug.cgi?id=78999
17551
17552         Reviewed by Tony Chang.
17553
17554         This is pretty much a straight cut-and-paste of one file into
17555         another (broken up so that docstrings and imports are in the
17556         right place).
17557
17558         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
17559         (BrokerClient):
17560         (BrokerClient.is_done):
17561         (BrokerClient.name):
17562         (Broker):
17563         (Broker.__init__):
17564         (Broker.add_topic):
17565         (Broker._get_queue_for_topic):
17566         (Broker.post_message):
17567         (Broker.run_message_loop):
17568         (Broker.run_all_pending):
17569         (Broker._run_loop):
17570         (Broker._dispatch_message):
17571         (_Message):
17572         (_Message.loads):
17573         (_Message.__init__):
17574         (_Message.dumps):
17575         (_Message.__repr__):
17576         (BrokerConnection):
17577         (BrokerConnection.__init__):
17578         (BrokerConnection.run_message_loop):
17579         (BrokerConnection.post_message):
17580         (BrokerConnection.raise_exception):
17581         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
17582
17583 2012-02-21  Dirk Pranke  <dpranke@chromium.org>
17584
17585         webkitpy: prepare to delete message_broker.py
17586         https://bugs.webkit.org/show_bug.cgi?id=78997
17587
17588         Reviewed by Eric Seidel.
17589
17590         This is part 1 of 3 changes to fix bug 78187. This change
17591         prepares the code for merging message_broker.py into
17592         manager_worker_broker.py; the tests in message_broker_unittest
17593         are merged into manager_worker_broker_unittest, the symbols
17594         needed by the tests are exported from manager_worker_broker.py,
17595         and manager_worker_broker itself is updated to refer to the
17596         symbols directly (without the module prefix).
17597
17598         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
17599         (get):
17600         (AbstractWorker):
17601         (AbstractWorker.__init__):
17602         (_ManagerConnection):
17603         (_ManagerConnection.__init__):
17604         (_WorkerConnection):
17605         (_WorkerConnection.__init__):
17606         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
17607         (InterfaceTest.test_brokerclient_is_abstract):
17608         (InterfaceTest.test_brokerclient_is_abstract.methods):
17609         (MessageTest):
17610         (MessageTest.test__no_body):
17611         (MessageTest.test__body):
17612         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
17613
17614 2012-02-21  Sam Weinig  <sam@webkit.org>
17615
17616         Attempt to fix the Snow Leopard build.
17617
17618         * DumpRenderTree/mac/Configurations/Base.xcconfig:
17619         * MiniBrowser/Configurations/Base.xcconfig:
17620         * TestWebKitAPI/Configurations/Base.xcconfig:
17621         * WebKitTestRunner/Configurations/Base.xcconfig:
17622
17623 2012-02-21  Sam Weinig  <sam@webkit.org>
17624
17625         Use libc++ when building with Clang on Mac
17626         https://bugs.webkit.org/show_bug.cgi?id=78981
17627
17628         Reviewed by Dan Bernstein.
17629
17630         * DumpRenderTree/mac/Configurations/Base.xcconfig:
17631         * MiniBrowser/Configurations/Base.xcconfig:
17632         * TestWebKitAPI/Configurations/Base.xcconfig:
17633         * WebKitTestRunner/Configurations/Base.xcconfig:
17634
17635 2012-02-21  Adam Roben  <aroben@apple.com>
17636
17637         Roll out r108309, r108323, and r108326
17638
17639         They broke the 32-bit Lion build.
17640
17641         Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
17642
17643         * DumpRenderTree/efl/CMakeLists.txt:
17644
17645 2012-02-21  Andras Becsi  <andras.becsi@nokia.com>
17646
17647         [Qt][WK2] Get rid of the dependency to QtWidgets
17648         https://bugs.webkit.org/show_bug.cgi?id=76276
17649
17650         Reviewed by Simon Hausmann.
17651
17652         * MiniBrowser/qt/MiniBrowser.pro:
17653         * MiniBrowser/qt/MiniBrowserApplication.cpp:
17654         (MiniBrowserApplication::MiniBrowserApplication):
17655         (MiniBrowserApplication::notify):
17656         (MiniBrowserApplication::sendTouchEvent):
17657         * MiniBrowser/qt/MiniBrowserApplication.h:
17658         (MiniBrowserApplication):
17659         * QtTestBrowser/locationedit.h:
17660         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
17661         (WTR::activateFonts):
17662         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
17663
17664 2012-02-20  Adam Barth  <abarth@webkit.org>
17665
17666         mastercfg_unittest.py fails without simplejson
17667         https://bugs.webkit.org/show_bug.cgi?id=79070
17668
17669         Reviewed by Csaba Osztrogonác.
17670
17671         Now that we require Python 2.6 (and higher) we can import json rather
17672         than simplejson.  We still need to use the simplejson name because
17673         that's what the master.cfg script expects.
17674
17675         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
17676         (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
17677
17678 2012-02-20  Filip Pizlo  <fpizlo@apple.com>
17679
17680         JSC should be a triple-tier VM
17681         https://bugs.webkit.org/show_bug.cgi?id=75812
17682         <rdar://problem/10079694>
17683
17684         Reviewed by Gavin Barraclough.
17685
17686         Changed EFL's build system to include a new directory in JavaScriptCore.
17687
17688         * DumpRenderTree/efl/CMakeLists.txt:
17689
17690 2012-02-20  Kenichi Ishibashi  <bashi@chromium.org>
17691
17692         Update pywebsocket to 0.7.2
17693         https://bugs.webkit.org/show_bug.cgi?id=79066
17694
17695         This version includes vendor-prefixed deflate-frame extension support.
17696
17697         Reviewed by Kent Tamura.
17698
17699         * Scripts/webkitpy/thirdparty/__init__.py:
17700         (AutoinstallImportHook._install_pywebsocket):
17701
17702 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
17703
17704         [UNIX] Plugin information fields are not interpreted as UTF-8
17705         https://bugs.webkit.org/show_bug.cgi?id=78635
17706
17707         Reviewed by Gustavo Noronha Silva.
17708
17709         Interpret plugin metadata as UTF8 aways. This matches the behavior
17710         of Chromium and the Totem plugin.
17711
17712         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
17713         (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
17714
17715 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
17716
17717         [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
17718         https://bugs.webkit.org/show_bug.cgi?id=78935
17719
17720         Reviewed by Gustavo Noronha Silva.
17721
17722         Move the TestNetscapePlugin headers to a more appropriate directory and update
17723         the build files to match.
17724
17725         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
17726         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
17727         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
17728         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
17729         * GNUmakefile.am: Ditto.
17730
17731 2012-02-20  Kihong Kwon  <kihong.kwon@samsung.com>
17732
17733         Add a new API for the Vibration API(W3C).
17734         https://bugs.webkit.org/show_bug.cgi?id=72010
17735
17736         Reviewed by Hajime Morita.
17737
17738         * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
17739
17740 2012-02-20  János Badics  <dicska@gmail.com>
17741
17742         [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
17743         https://bugs.webkit.org/show_bug.cgi?id=71816
17744
17745         RunQtAPITests will notify if a timeout occurs during testing.
17746         Added unittest to the master.cfg
17747
17748         Reviewed by Csaba Osztrogonác.
17749
17750         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
17751         (RunQtAPITests.evaluateCommand):
17752         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
17753         (RunQtAPITestsTest):
17754         (RunQtAPITestsTest.assertResults):
17755         (RunQtAPITestsTest.test_timeout):
17756         (test_success):
17757         (test_failure):
17758         (test_timeout_and_failure):
17759
17760 2012-02-20  Andy Wingo  <wingo@igalia.com>
17761
17762         Add wingo as a committer.
17763
17764         Unreviewed.
17765
17766         * Scripts/webkitpy/common/config/committers.py: Add myself to the
17767         committers list.
17768
17769 2012-02-20  Jochen Eisinger  <jochen@chromium.org>
17770
17771         [chromium] check that we're not running multiple modal dialogs at the same time
17772         https://bugs.webkit.org/show_bug.cgi?id=78486
17773
17774         Reviewed by Kent Tamura.
17775
17776         * DumpRenderTree/chromium/TestShell.cpp:
17777         (TestShell::TestShell):
17778         * DumpRenderTree/chromium/TestShell.h:
17779         (TestShell::setIsDisplayingModalDialog):
17780         (TestShell::isDisplayingModalDialog):
17781         (TestShell):
17782         * DumpRenderTree/chromium/WebViewHost.cpp:
17783         (WebViewHost::runModal):
17784
17785 2012-02-20  Martin Robinson  <mrobinson@igalia.com>
17786
17787         Fix WebKit2GTK+ for 'make distcheck'.
17788
17789         Instead of conditionally including WebKit2 GNUmakefiles, always
17790         include them and conditionally activate the final targets.
17791
17792         * MiniBrowser/gtk/GNUmakefile.am:
17793         * WebKitTestRunner/GNUmakefile.am:
17794
17795 2012-02-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
17796
17797         Enable video option for EFL port in build-webkit.
17798         https://bugs.webkit.org/show_bug.cgi?id=79006
17799
17800         Reviewed by Daniel Bates.
17801
17802         * Scripts/build-webkit:
17803
17804 2012-02-19  JungJik Lee  <jungjik.lee@samsung.com>
17805
17806         [EFL] Use modifier keys to execute pre-rendering.
17807         https://bugs.webkit.org/show_bug.cgi?id=77933
17808
17809         Reviewed by Chang Shu.
17810
17811         Use modifier key to execute pre-rendering instead of using reserved function keys.
17812
17813         * EWebLauncher/main.c:
17814         (on_key_down):
17815
17816 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
17817
17818         Fix one more dangling reference to worker_connection.name, delete unused code.
17819
17820         Unreviewed, build fix.
17821
17822         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17823         (Manager.update):
17824         (_WorkerState.__init__):
17825
17826 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
17827
17828         Add a change that should've been in r108005.
17829
17830         Unreviewed, build fix.
17831
17832         In the refactoring/cleanup in r108005 I should've changed the
17833         implementation of WorkerConnection to make it match BrokerClient
17834         (and everything else) so that objects had a name() method
17835         instead of a name property.
17836
17837         * Scripts/webkitpy/layout_tests/controllers/manager.py:
17838         (Manager._run_tests):
17839         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
17840         (_WorkerConnection.__init__):
17841         (_WorkerConnection.name):
17842         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
17843         (_TestWorker.__init__):
17844         (_TestsMixin.name):
17845         (_TestsMixin.test_name):
17846         (_TestsMixin.test_cancel):
17847         (_TestsMixin.test_unknown_message):
17848
17849 2012-02-18  Dirk Pranke  <dpranke@chromium.org>
17850
17851         webkitpy: remove webkitpy.common.array_stream
17852         https://bugs.webkit.org/show_bug.cgi?id=78952
17853
17854         Reviewed by Eric Seidel.
17855
17856         Turns out array_stream didn't really do anything that StringIO
17857         didn't do (at least as of Python 2.6). This change removes it
17858         and updates all of the callers. Where possible, I changed the
17859         test assertions in order to capture the intent more clearly,
17860         e.g., instead of calling self.assertTrue('foo' in stream.get()),
17861         we have self.assertContainsLine(stream, 'foo'), and instead of
17862         self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
17863         the latter isn't that much more readable, but StringIO doesn't
17864         export an empty() method.
17865
17866         * Scripts/webkitpy/common/array_stream.py: Removed.
17867         * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
17868         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
17869         (passing_run):
17870         (run_and_capture):
17871         (StreamTestingMixin):
17872         (StreamTestingMixin.assertContains):
17873         (StreamTestingMixin.assertContainsLine):
17874         (StreamTestingMixin.assertEmpty):
17875         (StreamTestingMixin.assertNotEmpty):
17876         (LintTest):
17877         (LintTest.test_lint_test_files):
17878         (LintTest.test_lint_test_files__errors):
17879         (MainTest):
17880         (MainTest.test_child_process_1):
17881         (MainTest.test_child_processes_2):
17882         (MainTest.test_child_processes_min):
17883         (MainTest.test_help_printing):
17884         (MainTest.test_hung_thread):
17885         (MainTest.test_no_tests_found):
17886         (MainTest.test_no_tests_found_2):
17887         (MainTest.test_repeat_each_iterations_num_tests):
17888         (MainTest.test_test_list):
17889         (MainTest.test_unexpected_failures):
17890         (MainTest.test_worker_model__inline_with_child_processes):
17891         (MainTest.test_additional_platform_directory):
17892         (RebaselineTest):
17893         (RebaselineTest.assertBaselines):
17894         (RebaselineTest.test_reset_results):
17895         (RebaselineTest.test_missing_results):
17896         (RebaselineTest.test_new_baseline):
17897         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
17898         (MeteredStream.update):
17899         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
17900         (TestMeteredStream.test_regular):
17901         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
17902         (TestUtilityFunctions.assertEmpty):
17903         (TestUtilityFunctions):
17904         (TestUtilityFunctions.assertNotEmpty):
17905         (TestUtilityFunctions.assertWritten):
17906         (TestUtilityFunctions.test_configure_logging):
17907         (Testprinter.assertEmpty):
17908         (Testprinter):
17909         (Testprinter.assertNotEmpty):
17910         (Testprinter.assertWritten):
17911         (Testprinter.reset):
17912         (Testprinter.get_printer):
17913         (Testprinter.test_help_printer):
17914         (Testprinter.do_switch_tests.do_helper):
17915         (Testprinter.test_print_one_line_summary):
17916         (Testprinter.test_print_test_result):
17917         (Testprinter.test_print_progress):
17918         (Testprinter.test_write_nothing):
17919         (Testprinter.test_write_misc):
17920         (Testprinter.test_write_everything):
17921         (Testprinter.test_write_verbose):
17922         (Testprinter.test_print_unexpected_results):
17923         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
17924         (MainTest.assertWritten):
17925         (create_runner):
17926         (test_run_test_set):
17927         (test_run_test_set_kills_drt_per_run):
17928         (test_run_test_set_for_parser_tests):
17929         (test_run_test_set_with_json_output):
17930         (test_run_test_set_with_json_source):
17931         (test_run_test_set_with_multiple_repositories):
17932         (test_upload_json):
17933
17934 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
17935
17936         [wx] Add the WebCore/page/scrolling directory to the build dirs.
17937
17938         * waf/build/settings.py:
17939
17940 2012-02-18  Kevin Ollivier  <kevino@theolliviers.com>
17941
17942         [wx] Unreviewed build fix. Don't error out or hang if we have
17943         downloaded dependencies but server update check fails.
17944
17945         * waf/build/build_utils.py:
17946         (download_if_newer):
17947
17948 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
17949
17950         The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
17951         https://bugs.webkit.org/show_bug.cgi?id=69444
17952
17953         Reviewed by Tony Chang.
17954
17955         Currently if a test's image checksum doesn't match the checksum
17956         in the baseline, but the images themselves match according to
17957         ImageDiff, new-run-webkit-tests ignores the problem. This is
17958         probably bad, but it's not yet clear what the right thing to do
17959         is. This patch will log a warning to stderr, at least (but the
17960         test will still pass).
17961
17962         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
17963         (SingleTestRunner._compare_image):
17964         (SingleTestRunner._run_reftest):
17965         * Scripts/webkitpy/layout_tests/port/test.py:
17966         (unit_test_list):
17967         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
17968
17969 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
17970
17971         NRWT does not report failure for a skipped test
17972         https://bugs.webkit.org/show_bug.cgi?id=78750
17973
17974         Reviewed by Eric Seidel.
17975
17976         If a test is listed in a Skipped file and you run it anyway
17977         with --force, and the test fails, currently NRWT will print
17978         "test ran as expected"; this is confusing, because you probably
17979         expect the test to fail and yet this might lead you to think the
17980         test passed. This patch changes the expected behavior to "PASS",
17981         so tests that fail will be reported.
17982
17983         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
17984         (result_was_expected):
17985         (TestExpectationParser):
17986         (TestExpectationParser.expectation_for_skipped_test):
17987         (TestExpectations):
17988         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
17989         (test_add_skipped_tests):
17990         * Scripts/webkitpy/layout_tests/port/test.py:
17991         (unit_test_list): Add some tests that are expected to be in a Skipped file.
17992         (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
17993
17994 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
17995
17996         webkitpy: fix test code after bug 78181
17997         https://bugs.webkit.org/show_bug.cgi?id=78870
17998
17999         Reviewed by Adam Barth.
18000
18001         I forgot to update the test code as per Tony's suggestion in
18002         bug 78181 (r108005). This change does that, and in doing so
18003         it revealed a subtle bug in _InlineWorkerConnection.run() that
18004         I am fixing as part of this (_alive would not be cleared if an
18005         exception was thrown).
18006
18007         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18008         (_InlineWorkerConnection.run):
18009         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
18010         (_TestWorker.__init__):
18011         (_TestWorker.handle_stop):
18012         (_TestWorker.handle_test):
18013         (_TestWorker.run):
18014         (_TestsMixin.handle_exception):
18015         (_TestsMixin.test_unknown_message):
18016
18017 2012-02-17  Adam Roben  <aroben@apple.com>
18018
18019         Mac build fix after r108119
18020
18021         * DumpRenderTree/mac/DumpRenderTree.mm:
18022         (runThread):
18023         (runPthread):
18024         (testThreadIdentifierMap):
18025         Updated to match current WTF threading APIs.
18026
18027 2012-02-17  Dirk Pranke  <dpranke@chromium.org>
18028
18029         revert r107147 - breaks webkit-patch on Mac SL
18030         https://bugs.webkit.org/show_bug.cgi?id=78866
18031
18032         Reviewed by Adam Barth.
18033
18034         It appears that zipfile.ExtractAll is broken on Python 2.6.1,
18035         which is the version that ships on Mac SL. Reverting this
18036         change until we no longer have to worry about that version.
18037
18038         * Scripts/webkitpy/common/system/autoinstall.py:
18039         (AutoInstaller):
18040         (AutoInstaller._extract_all): Added a comment about SL.
18041         (AutoInstaller._unzip):
18042
18043 2012-02-17  Mihnea Ovidenie  <mihnea@adobe.com>
18044
18045         CSS regions enabled by default
18046         https://bugs.webkit.org/show_bug.cgi?id=78525
18047
18048         Reviewed by David Hyatt.
18049
18050         Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
18051         CSSRegions are still enabled by default.
18052         In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
18053
18054         * DumpRenderTree/chromium/LayoutTestController.cpp:
18055         (LayoutTestController::overridePreference):
18056         * DumpRenderTree/chromium/WebPreferences.cpp:
18057         (WebPreferences::reset):
18058         (WebPreferences::applyTo):
18059         * DumpRenderTree/chromium/WebPreferences.h:
18060         (WebPreferences):
18061         * DumpRenderTree/mac/DumpRenderTree.mm:
18062         (resetDefaultsToConsistentValues):
18063
18064 2012-02-17  Maciej Stachowiak  <mjs@apple.com>
18065
18066         Some API tests erroneously use = instead of == (causing build failures)
18067         https://bugs.webkit.org/show_bug.cgi?id=78915
18068
18069         Reviewed by Sam Weinig.
18070
18071         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
18072         (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
18073         (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
18074
18075 2012-02-17  Peter Beverloo  <peter@chromium.org>
18076
18077         [Chromium] Include TestShellLinux.cpp in the build for Android
18078         https://bugs.webkit.org/show_bug.cgi?id=78865
18079
18080         Reviewed by Eric Seidel.
18081
18082         Android will be re-using the TestShellLinux.cpp file. I already
18083         added this r104033, but it seems to have gotten lost in the
18084         recent refactorings.
18085
18086         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
18087
18088 2012-02-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
18089
18090         Unreviewed, disable video build on EFL until it can be
18091         supported by EFL build bot.
18092
18093         * Scripts/build-webkit:
18094
18095 2012-02-17  Carlos Garcia Campos  <cgarcia@igalia.com>
18096
18097         [GTK] Implement zoom in/out in MiniBrowser
18098         https://bugs.webkit.org/show_bug.cgi?id=75253
18099
18100         Reviewed by Gustavo Noronha Silva.
18101
18102         * MiniBrowser/gtk/BrowserWindow.c:
18103         (browserWindowCanZoomIn):
18104         (browserWindowCanZoomOut):
18105         (browserWindowUpdateZoomActions):
18106         (webViewZoomLevelChanged):
18107         (zoomInCallback):
18108         (zoomOutCallback):
18109         (browser_window_init):
18110         (browserWindowConstructed):
18111
18112 2012-02-17  Nikolas Zimmermann  <nzimmermann@rim.com>
18113
18114         layoutTestController.display() is flaky for SVG tests
18115         https://bugs.webkit.org/show_bug.cgi?id=78021
18116
18117         Reviewed by Adam Roben.
18118
18119         Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
18120         Size the web view before running the test, not when dumping.
18121         All platforms handle this correctly now.
18122
18123         * DumpRenderTree/win/DumpRenderTree.cpp:
18124         (dump):
18125         (sizeWebViewForCurrentTest):
18126         (runTest):
18127
18128 2012-02-16  Carlos Garcia Campos  <cgarcia@igalia.com>
18129
18130         [GTK] Make install is broken when building without --enable-gtk-doc
18131         https://bugs.webkit.org/show_bug.cgi?id=78828
18132
18133         Reviewed by Martin Robinson.
18134
18135         * gtk/generate-gtkdoc:
18136         (rebase_installed_docs): Check documentation has been generated
18137         before trying to rebase it.
18138
18139 2012-02-16  Dirk Pranke  <dpranke@chromium.org>
18140
18141         nrwt: simplify worker interface
18142         https://bugs.webkit.org/show_bug.cgi?id=78181
18143
18144         Reviewed by Tony Chang.
18145
18146         This change moves code in name(), is_done(), run(), and cancel()
18147         from Worker to AbstractWorker, since the logic is pretty much
18148         boilerplate code that any implementation would want to use.
18149
18150         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18151         (get.should):
18152         (AbstractWorker.__init__):
18153         (AbstractWorker):
18154         (AbstractWorker.name):
18155         (AbstractWorker.stop_handling_messages):
18156         (AbstractWorker.run):
18157         (AbstractWorker.is_done):
18158         (AbstractWorker.cancel):
18159         * Scripts/webkitpy/layout_tests/controllers/worker.py:
18160         (Worker.__init__):
18161         (Worker.run):
18162         (Worker.handle_stop):
18163
18164 2012-02-16  Michael Saboff  <msaboff@apple.com>
18165
18166         ENH: Add ability to run subset of JavaScript layout tests with JSC
18167         https://bugs.webkit.org/show_bug.cgi?id=78764
18168
18169         Reviewed by Gavin Barraclough.
18170
18171         New simple test drive shell script that runs a defined
18172         list of javascript tests using jsc and the standalone-{pre,post}.js
18173         wrappers.
18174
18175         * Scripts/run-fast-jsc: Added.
18176
18177 2012-02-16  Csaba Osztrogonác  <ossy@webkit.org>
18178
18179         Add new Qt performance tester bot to build.webkit.org
18180         https://bugs.webkit.org/show_bug.cgi?id=78795
18181
18182         Reviewed by Adam Roben.
18183
18184         * BuildSlaveSupport/build.webkit.org-config/config.json:
18185
18186 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
18187
18188         Disable inspector on WinCE.
18189
18190         Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
18191
18192         * Scripts/build-webkit:
18193
18194 2012-02-16  Patrick Gansterer  <paroga@webkit.org>
18195
18196         WinCE build fix after r107656.
18197
18198         Disable FTPDIR on WinCE, since it does not compile there.
18199
18200         * Scripts/build-webkit:
18201
18202 2012-02-15  Leo Yang  <leo.yang@torchmobile.com.cn>
18203
18204         Build fix after r107863.
18205
18206         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
18207
18208 2012-02-15  Tony Chang  <tony@chromium.org>
18209
18210         [chromium] add linux dbg back to garden-o-matic
18211         https://bugs.webkit.org/show_bug.cgi?id=78752
18212
18213         Reviewed by Adam Barth.
18214
18215         This reflects the current linux debug bot name (there's only one bot).
18216         I'm also remove the mac clang builder since it doesn't exist (mac
18217         always uses clang now).
18218
18219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
18220         * Scripts/webkitpy/layout_tests/port/builders.py:
18221
18222 2012-02-15  Sam Weinig  <sam@webkit.org>
18223
18224         Add style check for ctype functions that are generally frowned upon in WebKit
18225         https://bugs.webkit.org/show_bug.cgi?id=78748
18226
18227         Reviewed by Anders Carlsson.
18228
18229         Not every platform has DisallowCType.h to check for uses of the ctype.h
18230         functions, so add a style check for them as well.
18231
18232         * Scripts/webkitpy/style/checkers/cpp.py:
18233         (check_ctype_functions):
18234         (check_style):
18235         (CppChecker):
18236         Add check.
18237
18238         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
18239         (WebKitStyleTest.test_ctype_fucntion):
18240         Add checker.
18241
18242 2012-02-15  Szilard Ledan  <Ledan-Muntean.Szilard@stud.u-szeged.hu>
18243
18244         [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
18245         https://bugs.webkit.org/show_bug.cgi?id=76546
18246
18247         Reviewed by Simon Hausmann.
18248
18249         Resize the web view programatically because the declarative property binding
18250         does not work. Seems like our qml environment is not initialized fully but it
18251         needs more investigation.
18252
18253         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
18254         (WTR::WrapperWindow::handleStatusChanged):
18255         (WTR::PlatformWebView::resizeTo):
18256
18257 2012-02-15  Dirk Pranke  <dpranke@chromium.org>
18258
18259         webkitpy: add a worker_args concept to start_worker()
18260         https://bugs.webkit.org/show_bug.cgi?id=78572
18261
18262         Reviewed by Tony Chang.
18263
18264         This change replaces the three NRWT-specific arguments passed
18265         through the broker to the worker with a generic WorkerArguments
18266         wrapper class and a separate set_inline_arguments() call that can
18267         be used to pass additional data to the worker when it is running
18268         in the same process as the manager (this is needed for testing).
18269         With the addition of set_inline_arguments() we also no longer
18270         need to pass an optional argument to the worker.run() call.
18271
18272         Note that this method is *only* implemented on inline workers,
18273         so calling this on a regular (child process) worker will result
18274         in a runtime error.
18275
18276         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18277         (Manager._run_tests):
18278         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18279         (AbstractWorker.__init__):
18280         (AbstractWorker.run):
18281         (_ManagerConnection.start_worker):
18282         (_InlineManager.start_worker):
18283         (_InlineManager.set_inline_arguments):
18284         (_InlineManager.run_message_loop):
18285         (_MultiProcessManager.start_worker): Reworked signature.
18286         (_WorkerConnection.__init__):
18287         (_InlineWorkerConnection.__init__):
18288         (_InlineWorkerConnection.set_inline_arguments): New method.
18289         (_InlineWorkerConnection):
18290         (_InlineWorkerConnection.run):
18291         (_Process.run):
18292         (_MultiProcessWorkerConnection.__init__):
18293         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
18294         (_TestWorker.__init__):
18295         (_TestWorker.set_inline_arguments):
18296         (_TestWorker.handle_test):
18297         (_TestWorker.run):
18298         (_TestsMixin.test_cancel):
18299         (_TestsMixin.test_done):
18300         (_TestsMixin.test_unknown_message):
18301         (InlineBrokerTests): New class for more testing.
18302         (InlineBrokerTests.setUp):
18303         (InlineBrokerTests.test_inline_arguments): New test.
18304         (InterfaceTest.test_managerconnection_is_abstract):
18305         (InterfaceTest.test_workerconnection_is_abstract):
18306         * Scripts/webkitpy/layout_tests/controllers/worker.py:
18307         (WorkerArguments):
18308         (WorkerArguments.__init__):
18309         (Worker.__init__):
18310         (Worker.set_inline_arguments):
18311         (Worker):
18312         (Worker.run):
18313         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
18314         (WorkerTest.test_default_platform_in_worker):
18315
18316 2012-02-15  Adam Klein  <adamk@chromium.org>
18317
18318         Unreviewed, rolling out r107704.
18319         http://trac.webkit.org/changeset/107704
18320         https://bugs.webkit.org/show_bug.cgi?id=78486
18321
18322         Caused layout test crashes in debug builds.
18323
18324         Specific crashing tests:
18325
18326         fast/events/show-modal-dialog-onblur-onfocus.html
18327         fast/harness/show-modal-dialog.html
18328         inspector/console/console-long-eval-crash.html
18329
18330         * DumpRenderTree/chromium/TestShell.cpp:
18331         (TestShell::TestShell):
18332         * DumpRenderTree/chromium/TestShell.h:
18333         (TestShell):
18334         * DumpRenderTree/chromium/WebViewHost.cpp:
18335         (WebViewHost::runModal):
18336
18337 2012-02-15  Michael Brüning  <michael.bruning@nokia.com>
18338
18339         [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
18340         https://bugs.webkit.org/show_bug.cgi?id=76347
18341
18342         Reviewed by Kenneth Rohde Christiansen.
18343
18344         * MiniBrowser/qt/MiniBrowser.qrc:
18345         * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
18346         * MiniBrowser/qt/qml/BrowserWindow.qml:
18347         * MiniBrowser/qt/qml/DialogLineInput.qml:
18348
18349 2012-02-15  Simon Hausmann  <simon.hausmann@nokia.com>
18350
18351         [Qt] Fix WebGL in QtTestBrowser
18352
18353         Reviewed by Tor Arne Vestbø.
18354
18355         * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
18356         the options for enabling GL we also pass them on properly.
18357
18358 2012-02-14  Sam Weinig  <sam@webkit.org>
18359
18360         Add #include of unistd.h on the mac for getcwd.
18361
18362         Reviewed by Anders Carlsson.
18363
18364         This is necessary when building with libc++.
18365
18366         * WebKitTestRunner/TestInvocation.cpp:
18367
18368 2012-02-14  Sam Weinig  <sam@webkit.org>
18369
18370         In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
18371         https://bugs.webkit.org/show_bug.cgi?id=78663
18372
18373         Reviewed by Anders Carlsson.
18374
18375         * DumpRenderTree/DumpRenderTreePrefix.h:
18376         * DumpRenderTree/cg/ImageDiffCG.cpp:
18377
18378 2012-02-14  Adam Barth  <abarth@webkit.org>
18379
18380         Implement an adb-based driver for the ChromiumAndroidPort
18381         https://bugs.webkit.org/show_bug.cgi?id=78627
18382
18383         Reviewed by Eric Seidel.
18384
18385         This driver mostly just wires up the ChromiumDriver through adb.  In
18386         some cases, it translates protocol elements, such as URIs, so that the
18387         rest of webkitpy is insulated from the "remoteness" of the target device.
18388
18389         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18390         (ChromiumAndroidPort.start_helper):
18391         (ChromiumAndroidPort._driver_class):
18392         (ChromiumAndroidPort._update_version):
18393         (ChromiumAndroidPort._get_stderr):
18394         (ChromiumAndroidPort):
18395         (ChromiumAndroidPort._get_last_stacktrace):
18396         (ChromiumAndroidPort._teardown_performance):
18397         (ChromiumAndroidDriver):
18398         (ChromiumAndroidDriver.__init__):
18399         (ChromiumAndroidDriver._start):
18400         (ChromiumAndroidDriver.run_test):
18401         (ChromiumAndroidDriver.stop):
18402         (ChromiumAndroidDriver._test_shell_command):
18403         (ChromiumAndroidDriver._write_command_and_read_line):
18404         (ChromiumAndroidDriver._output_image):
18405         (ChromiumAndroidDriver._has_crash_hint):
18406
18407 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
18408
18409         webkitpy: the real_name() method in the Port class is no longer needed
18410         https://bugs.webkit.org/show_bug.cgi?id=78651
18411
18412         Reviewed by Eric Seidel.
18413
18414         The change in bug 78565 / r107718 made it no longer necessary
18415         (we can use options.platform instead).
18416
18417         * Scripts/webkitpy/layout_tests/port/base.py:
18418         (Port.name):
18419         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
18420         (MockDRTPort.__init__):
18421
18422 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
18423
18424         webkitpy: clean up options, port handling in manager_worker_broker
18425         https://bugs.webkit.org/show_bug.cgi?id=78568
18426
18427         Reviewed by Tony Chang.
18428
18429         manager_worker_broker no longer needs options or port objects
18430         directly, so we make them only be passed in start_worker().
18431
18432         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18433         (Manager._run_tests):
18434         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18435         (get):
18436         (_ManagerConnection.__init__):
18437         (_ManagerConnection.start_worker):
18438         (_InlineManager.__init__):
18439         (_InlineManager.start_worker):
18440         (_InlineManager.run_message_loop):
18441         (_MultiProcessManager.__init__):
18442         (_MultiProcessManager):
18443         (_MultiProcessManager.start_worker):
18444         (_InlineWorkerConnection.__init__):
18445         (_InlineWorkerConnection.run):
18446         (_Process.__init__):
18447         (_MultiProcessWorkerConnection.__init__):
18448         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
18449         (make_broker):
18450         (_TestWorker.run):
18451         (_TestsMixin.test_cancel):
18452         (_TestsMixin.test_done):
18453         (_TestsMixin.test_unknown_message):
18454         (MultiProcessBrokerTests.setUp):
18455         (InterfaceTest.test_managerconnection_is_abstract):
18456         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
18457         (Broker.__init__):
18458
18459 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
18460
18461         nrwt: add a unit test for regression introduced in bug 78565
18462         https://bugs.webkit.org/show_bug.cgi?id=78646
18463
18464         Reviewed by Tony Chang.
18465
18466         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
18467         (FakeConnection):
18468         (FakeConnection.run_message_loop):
18469         (FakeConnection.post_message):
18470         (WorkerTest):
18471         (WorkerTest.test_default_platform_in_worker):
18472
18473 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
18474
18475         NRWT is broken for the default port
18476         https://bugs.webkit.org/show_bug.cgi?id=78640
18477
18478         Reviewed by Tony Chang.
18479
18480         The change in r107718 (bug 78565) broke NRWT if you didn't
18481         specify any sort of --platform flag or equivalent. I didn't
18482         catch this because it's a full integration test (which we don't
18483         have an automated test for) and I missed this command line
18484         variant when testing interactively.
18485
18486         * Scripts/webkitpy/layout_tests/controllers/worker.py:
18487         (Worker.run):
18488
18489 2012-02-14  Ramya Chandrasekaran  <cramya@google.com>
18490
18491         Last character display for passwords in Android.
18492         https://bugs.webkit.org/show_bug.cgi?id=78532
18493
18494         Reviewed by Adam Barth.
18495
18496         * DumpRenderTree/chromium/WebPreferences.cpp:
18497         (WebPreferences::applyTo):
18498
18499 2012-02-14  Adam Barth  <abarth@webkit.org>
18500
18501         Finish implementing start_helper for ChromiumAndroidPort
18502         https://bugs.webkit.org/show_bug.cgi?id=78582
18503
18504         Reviewed by Eric Seidel.
18505
18506         This patch contains the remaining odds and ends for the start_helper function.
18507
18508         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18509         (ChromiumAndroidPort.start_helper):
18510         (ChromiumAndroidPort._synchronize_datetime):
18511         (ChromiumAndroidPort):
18512         (ChromiumAndroidPort._check_version):
18513         (ChromiumAndroidPort._run_adb_command):
18514         (ChromiumAndroidPort._copy_device_file):
18515
18516 2012-02-14  Dirk Pranke  <dpranke@chromium.org>
18517
18518         webkitpy: create ports in Workers, not in manager_worker_broker
18519         https://bugs.webkit.org/show_bug.cgi?id=78565
18520
18521         Reviewed by Tony Chang.
18522
18523         We will now create the Port object (if necessary) in the Worker
18524         directly, so that the manager_worker_broker module doesn't need
18525         all of this layout_test-specific logic. Part of the fixes for
18526         bug 78171.
18527
18528         These changes are all well-tested by the existing tests in
18529         run_webkit_tests_integrationtest.py.
18530
18531         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
18532         (_Process.run):
18533         * Scripts/webkitpy/layout_tests/controllers/worker.py:
18534         (Worker.__init__):
18535         (Worker.safe_init):
18536         (Worker.run):
18537         (Worker.cleanup):
18538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18539         (parse_args):
18540         (main): Fix a minor bug where running the 'mock-test' port didn't work right.
18541
18542 2012-02-14  Jochen Eisinger  <jochen@chromium.org>
18543
18544         [chromium] check that we're not running multiple modal dialogs at the same time
18545         https://bugs.webkit.org/show_bug.cgi?id=78486
18546
18547         Reviewed by Kent Tamura.
18548
18549         * DumpRenderTree/chromium/TestShell.cpp:
18550         (TestShell::TestShell):
18551         * DumpRenderTree/chromium/TestShell.h:
18552         (TestShell::setIsDisplayingModalDialog):
18553         (TestShell::isDisplayingModalDialog):
18554         (TestShell):
18555         * DumpRenderTree/chromium/WebViewHost.cpp:
18556         (WebViewHost::runModal):
18557
18558 2012-02-14  Adam Barth  <abarth@webkit.org>
18559
18560         Enable the GPU codepath in the chromium-android port
18561         https://bugs.webkit.org/show_bug.cgi?id=78580
18562
18563         Reviewed by James Robinson.
18564
18565         Suprise!  There is no ChromiumGpuAndroidPort!  Instead, Chromium
18566         Android always uses the GPU codepath, so we set the GPU flags on the
18567         main chromium-android port instead.
18568
18569         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18570         (ChromiumAndroidPort.__init__):
18571
18572 2012-02-14  Adam Barth  <abarth@webkit.org>
18573
18574         NRWT should expose --adb-args flag for Android
18575         https://bugs.webkit.org/show_bug.cgi?id=78579
18576
18577         Reviewed by Eric Seidel.
18578
18579         This flag is already wired up to the ChromiumAndroidPort.
18580
18581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18582         (parse_args):
18583
18584 2012-02-14  Alexey Proskuryakov  <ap@apple.com>
18585
18586         [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
18587         https://bugs.webkit.org/show_bug.cgi?id=78541
18588         <rdar://problem/10036695>
18589
18590         Reviewed by Kent Tamura.
18591
18592         * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
18593         * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
18594         After each test, reset to using new protocol.
18595
18596 2012-02-11  Nikolas Zimmermann  <nzimmermann@rim.com>
18597
18598         Convert svg/animations to use SMIL methods for driving the timeline
18599         https://bugs.webkit.org/show_bug.cgi?id=78422
18600
18601         Reviewed by Dirk Schulze.
18602
18603         Remove no longer needed SVG specific animation sampling functionality from DRT.
18604         Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
18605
18606         * DumpRenderTree/LayoutTestController.cpp:
18607         (LayoutTestController::staticFunctions):
18608         * DumpRenderTree/LayoutTestController.h:
18609         (LayoutTestController):
18610         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
18611         * DumpRenderTree/chromium/LayoutTestController.cpp:
18612         (LayoutTestController::LayoutTestController):
18613         * DumpRenderTree/chromium/LayoutTestController.h:
18614         (LayoutTestController):
18615         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
18616         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
18617         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
18618         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
18619         * DumpRenderTree/qt/LayoutTestControllerQt.h:
18620         (LayoutTestController):
18621         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
18622         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
18623
18624 2012-02-13  Rob Flack  <flackr@chromium.org>
18625
18626         Add Linux ChromiumOS test results to flakiness dashboard.
18627         https://bugs.webkit.org/show_bug.cgi?id=78495
18628
18629         Reviewed by Ojan Vafai.
18630
18631         * TestResultServer/static-dashboards/builders.js:
18632         * TestResultServer/static-dashboards/dashboard_base.js:
18633
18634 2012-02-13  ChangSeok Oh  <shivamidow@gmail.com>
18635
18636         [GTK] Mutation Observers build is broken
18637         https://bugs.webkit.org/show_bug.cgi?id=78433
18638
18639         Reviewed by Martin Robinson.
18640
18641         Enabled mutation observers as a default feature for GTK port, too.
18642
18643         * Scripts/build-webkit:
18644
18645 2012-02-13  Loïc Yhuel  <loic.yhuel_ext@softathome.com>
18646
18647         Allow to configure ENABLE_FTPDIR in build-webkit
18648         https://bugs.webkit.org/show_bug.cgi?id=65098
18649
18650         Reviewed by Eric Seidel.
18651
18652         Allow to disable ENABLE_FTPDIR by command line.
18653         Remove ENABLE_FTPDIR from --minimal build
18654
18655         * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
18656         * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
18657         as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
18658
18659 2012-02-13  Shinya Kawanaka  <shinyak@chromium.org>
18660
18661         Add shinyak as committer.
18662
18663         Unreviewed.
18664
18665         * Scripts/webkitpy/common/config/committers.py:
18666
18667 2012-02-13  Adam Barth  <abarth@webkit.org>
18668
18669         Implement start/stop_helper for ChromiumAndroidPort
18670         https://bugs.webkit.org/show_bug.cgi?id=78558
18671
18672         Reviewed by Dirk Pranke.
18673
18674         These functions (and their dependencies) set up the Android device for
18675         testing.
18676
18677         This patch also includes a few tweaks on the previous patch recommended
18678         by dpranke.
18679
18680         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18681         (ChromiumAndroidPort.__init__):
18682         (ChromiumAndroidPort.start_helper):
18683         (ChromiumAndroidPort.stop_helper):
18684         (ChromiumAndroidPort._shut_down_http_server):
18685         (ChromiumAndroidPort):
18686         (ChromiumAndroidPort._push_executable):
18687         (ChromiumAndroidPort._push_fonts):
18688         (ChromiumAndroidPort._restore_system_font):
18689         (ChromiumAndroidPort._push_test_resources):
18690         (ChromiumAndroidPort._push_to_device):
18691         (ChromiumAndroidPort._pull_from_device):
18692         (ChromiumAndroidPort._kill_device_process):
18693         (ChromiumAndroidPort._setup_performance):
18694         (ChromiumAndroidPort._teardown_performance):
18695         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
18696         (ChromiumAndroidPortTest):
18697         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
18698         (PortTestCase):
18699         (PortTestCase.make_port):
18700         (PortTestCase.test_default_worker_model):
18701
18702 2012-02-13  Adam Barth  <abarth@webkit.org>
18703
18704         Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
18705         https://bugs.webkit.org/show_bug.cgi?id=78550
18706
18707         Reviewed by Eric Seidel.
18708
18709         Much of this code just forwards to the "host" port, which seems like a
18710         reasonable thing to do.
18711
18712         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18713         (ChromiumAndroidPort.__init__):
18714         (ChromiumAndroidPort.stop_helper):
18715         (ChromiumAndroidPort):
18716         (ChromiumAndroidPort._build_path):
18717         (ChromiumAndroidPort._path_to_apache):
18718         (ChromiumAndroidPort._path_to_apache_config_file):
18719         (ChromiumAndroidPort._path_to_driver):
18720         (ChromiumAndroidPort._path_to_helper):
18721         (ChromiumAndroidPort._path_to_image_diff):
18722         (ChromiumAndroidPort._path_to_lighttpd):
18723         (ChromiumAndroidPort._path_to_lighttpd_modules):
18724         (ChromiumAndroidPort._path_to_lighttpd_php):
18725         (ChromiumAndroidPort._path_to_wdiff):
18726         (ChromiumAndroidPort._shut_down_http_server):
18727         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
18728         (ChromiumAndroidPortTest):
18729         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
18730         (PortTestCase):
18731         (PortTestCase.make_port):
18732         (PortTestCase.test_default_worker_model):
18733
18734 2012-02-13  Adam Barth  <abarth@webkit.org>
18735
18736         chromium_android.py should implement "virtual" methods from ChromiumPort
18737         https://bugs.webkit.org/show_bug.cgi?id=78545
18738
18739         Reviewed by Dirk Pranke.
18740
18741         This patch adds basic implementations that specialize a bunch of
18742         functions from ChromiumPort.
18743
18744         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
18745         (ChromiumAndroidPort):
18746         (ChromiumAndroidPort.__init__):
18747         (ChromiumAndroidPort.default_child_processes):
18748         (ChromiumAndroidPort.baseline_search_path):
18749         (ChromiumAndroidPort.check_build):
18750         (ChromiumAndroidPort.check_sys_deps):
18751         (ChromiumAndroidPort.default_worker_model):
18752         (ChromiumAndroidPort.test_expectations):
18753         (ChromiumAndroidPort.start_http_server):
18754         (ChromiumAndroidPort.stop_http_server):
18755         (ChromiumAndroidPort.start_helper):
18756         (ChromiumAndroidPort.stop_helper):
18757
18758 2012-02-13  Adam Barth  <abarth@webkit.org>
18759
18760         Add a skeleton ChromiumAndroid port to webkitpy
18761         https://bugs.webkit.org/show_bug.cgi?id=78543
18762
18763         Reviewed by Eric Seidel.
18764
18765         This patch just adds an empty ChromiumAndroid port object to webkitpy
18766         and wires it up to the factory objects.  An actual implementation will
18767         follow.
18768
18769         * Scripts/webkitpy/layout_tests/port/chromium.py:
18770         (ChromiumPort):
18771         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
18772         (ChromiumAndroidPort):
18773         (ChromiumAndroidPort.__init__):
18774         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
18775         (ChromiumPortTest.test_all_test_configurations):
18776         * Scripts/webkitpy/layout_tests/port/factory.py:
18777         (PortFactory):
18778
18779 2012-02-13  Adam Barth  <abarth@webkit.org>
18780
18781         NRWT's HTTP servers should support additional directories for resources
18782         https://bugs.webkit.org/show_bug.cgi?id=78528
18783
18784         Reviewed by Eric Seidel.
18785
18786         This functionality will be used by the Chromium-Android port.
18787
18788         * Scripts/webkitpy/layout_tests/port/base.py:
18789         (Port.to.start_http_server):
18790         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
18791         (LayoutTestApacheHttpd.__init__):
18792         * Scripts/webkitpy/layout_tests/servers/http_server.py:
18793         (Lighttpd.__init__):
18794         (Lighttpd._prepare_config):
18795
18796 2012-02-13  Ami Fischman  <fischman@chromium.org>
18797
18798         Add fischman as committer.
18799
18800         Unreviewed
18801
18802         * Scripts/webkitpy/common/config/committers.py:
18803
18804 2012-02-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
18805
18806         [EFL] Drop support for the Curl network backend.
18807         https://bugs.webkit.org/show_bug.cgi?id=77874
18808
18809         Reviewed by Eric Seidel.
18810
18811         Nobody seems to be maintaining the Curl backend in WebCore, the
18812         EFL port developers all seem to be using the Soup backend and the
18813         port itself has many features which are only implemented for the
18814         latter.
18815
18816         * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
18817         and always add the required include directories.
18818         * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
18819         include directories and link to them.
18820
18821 2012-02-13  Kenichi Ishibashi  <bashi@chromium.org>
18822
18823         [WebSocket] Update pywebsocket to 0.7.1
18824         https://bugs.webkit.org/show_bug.cgi?id=78484
18825
18826         pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
18827
18828         Reviewed by Kent Tamura.
18829
18830         * Scripts/webkitpy/thirdparty/__init__.py:
18831         (AutoinstallImportHook._install_pywebsocket):
18832
18833 2012-02-12  Kangil Han  <kangil.han@samsung.com>
18834
18835         [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
18836         https://bugs.webkit.org/show_bug.cgi?id=78091
18837
18838         Reviewed by Hajime Morita.
18839
18840         Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
18841         This patch will activate around 1,900 test cases from skipped list in EFL port.
18842
18843         * DumpRenderTree/efl/EventSender.cpp:
18844         (textZoom):
18845         (pageZoom):
18846         (textZoomInCallback):
18847         (textZoomOutCallback):
18848         (zoomPageInCallback):
18849         (zoomPageOutCallback):
18850
18851 2012-02-12  Ashod Nakashian  <ashodnakashian@yahoo.com>
18852
18853         KeywordLookupGenerator.py script fails in some cases
18854         https://bugs.webkit.org/show_bug.cgi?id=77886
18855
18856         Reviewed by Benjamin Poulain.
18857
18858         * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
18859         * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
18860         (GlobalVariablesTest.test_path_rules_specifier):
18861
18862 2012-02-12  Joe Thomas  <joethomas@motorola.com>
18863
18864         Add toText and isTextNode helpers in Text class.
18865         https://bugs.webkit.org/show_bug.cgi?id=78140
18866
18867         Unit test case for the new style checker introduced.
18868
18869         Reviewed by Adam Barth.
18870
18871         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
18872         (CppStyleTest):
18873         (CppStyleTest.test_static_cast_readability): Added a unit test case.
18874
18875 2012-02-12  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
18876
18877         Enable features supported by EFL port in build-webkit.
18878         https://bugs.webkit.org/show_bug.cgi?id=78348
18879
18880         Reviewed by Ryosuke Niwa.
18881
18882         Sync build-webkit with OptionEfl.cmake, as some features enabled in
18883         OptionEfl.cmake are not enabled in build-webkit.
18884
18885         * Scripts/build-webkit:
18886
18887 2012-02-12  Joe Thomas  <joethomas@motorola.com>
18888
18889         Add toText and isTextNode helpers in Text class.
18890         https://bugs.webkit.org/show_bug.cgi?id=78140
18891
18892         Added a style checker to use toText rather than static_cast<Text*>.
18893
18894         Reviewed by Adam Barth.
18895
18896         * Scripts/webkitpy/style/checkers/cpp.py:
18897         (check_language): Style checker for static_cast<Text*>.
18898
18899 2012-02-12  Philippe Normand  <pnormand@igalia.com>
18900
18901         Unreviewed, disable Mutation observers build on GTK until it can
18902         actually build.
18903
18904         * Scripts/build-webkit:
18905
18906 2012-02-11  Benjamin Poulain  <benjamin@webkit.org>
18907
18908         Add back WTFURL to WebKit
18909         https://bugs.webkit.org/show_bug.cgi?id=77291
18910
18911         Reviewed by Adam Barth.
18912
18913         Add a flag to build-webkit to easily build WebKit with WTFURL.
18914
18915         * Scripts/build-webkit:
18916
18917 2012-02-10  Adam Klein  <adamk@chromium.org>
18918
18919         Enable MUTATION_OBSERVERS by default on all platforms
18920         https://bugs.webkit.org/show_bug.cgi?id=78196
18921
18922         Reviewed by Ojan Vafai.
18923
18924         * Scripts/build-webkit:
18925
18926 2012-02-10  Adam Barth  <abarth@webkit.org>
18927
18928         Move garden-o-matic's All Failures out of experimental
18929         https://bugs.webkit.org/show_bug.cgi?id=78395
18930
18931         Reviewed by Dimitri Glazkov.
18932
18933         Several folks have tried this feature and found it useful.
18934
18935         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
18936
18937 2012-02-10  Tim Horton  <timothy_horton@apple.com>
18938
18939         NRWT should categorize options in --help
18940         https://bugs.webkit.org/show_bug.cgi?id=76221
18941
18942         Reviewed by Eric Seidel.
18943
18944         Use optparse's OptionGroup mechanism to logically group NRWT's options,
18945         providing a better experience when scanning all the options.
18946
18947         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
18948         (parse_args):
18949
18950 2012-02-10  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
18951
18952         [Qt][WK2] Refactor on Qt5 Layout tests' structure
18953         https://bugs.webkit.org/show_bug.cgi?id=77450
18954
18955         Reviewed by Csaba Osztrogonác.
18956
18957         Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
18958         to qt-5.0-wk2 and qt-5.0-wk1.
18959
18960         * Scripts/old-run-webkit-tests:
18961         (buildPlatformResultHierarchy):
18962         (readSkippedFiles):
18963         * Scripts/webkitpy/layout_tests/port/qt.py:
18964         (QtPort._wk2_port_name):
18965         (QtPort._skipped_file_search_paths):
18966         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
18967         (QtPortTest.test_baseline_search_path):
18968         * Scripts/webkitpy/layout_tests/port/webkit.py:
18969         (WebKitPort._wk2_port_name):
18970
18971 2012-02-09  Philippe Normand  <pnormand@igalia.com>
18972
18973         [GTK] EWS command-line option to run the tests
18974         https://bugs.webkit.org/show_bug.cgi?id=78211
18975
18976         Reviewed by Adam Barth.
18977
18978         New --run-tests option (defaults to False) for the EWS commands.
18979
18980         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
18981         (AbstractEarlyWarningSystem):
18982         (AbstractEarlyWarningSystem.__init__):
18983         (AbstractEarlyWarningSystem.review_patch):
18984         (ChromiumLinuxEWS):
18985         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
18986         (EarlyWarningSytemTest._test_builder_ews):
18987
18988 2012-02-09  Eric Seidel  <eric@webkit.org>
18989
18990         Rename compare_text and compare_audio to make it clear that they're !=
18991         https://bugs.webkit.org/show_bug.cgi?id=78301
18992
18993         Reviewed by Adam Barth.
18994
18995         I also removed the maybe_create_directory function which was redundant.
18996
18997         * Scripts/webkitpy/layout_tests/controllers/manager.py:
18998         (Manager.set_up_run):
18999         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
19000         (TestResultWriter._make_output_directory):
19001         * Scripts/webkitpy/layout_tests/port/base.py:
19002         (Port.do_text_results_differ):
19003         (Port.do_audio_results_differ):
19004         (Port.diff_text):
19005         (Port.driver_name):
19006         (Port.skips_perf_test):
19007         * Scripts/webkitpy/layout_tests/port/win.py:
19008         (WinPort.do_text_results_differ):
19009         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
19010         (WinPortTest.test_do_text_results_differ):
19011         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
19012         (LayoutTestApacheHttpd.__init__):
19013         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
19014         (HttpServerBase.__init__):
19015         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
19016         (Rebaseliner._diff_baselines):
19017
19018 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
19019
19020         [GTK] Add DRT support for modal dialogs
19021         https://bugs.webkit.org/show_bug.cgi?id=53600
19022
19023         Reviewed by Martin Robinson.
19024
19025         Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
19026         Most significantly, when creating a new web view in GtkLauncher, the window
19027         of the web view opener is passed around. In DumpRenderTree, the window of
19028         the main web view is always considered as the opener. This is required so
19029         the modal dialog's toplevel can be made transient for the opener's toplevel.
19030
19031         * DumpRenderTree/gtk/DumpRenderTree.cpp:
19032         (webViewRunModalDialog):
19033         (createWebView):
19034         * GtkLauncher/main.c:
19035         (createWebViewCb):
19036         (runModalDialogCb):
19037         (createBrowser):
19038         (createWindow):
19039         (main):
19040
19041 2012-02-09  Zan Dobersek  <zandobersek@gmail.com>
19042
19043         [Gtk] security/set-form-autocomplete-attribute.html fails
19044         https://bugs.webkit.org/show_bug.cgi?id=78261
19045
19046         Reviewed by Martin Robinson.
19047
19048         Use the new helper in DumpRenderTreeSupportGtk to properly
19049         test whether an element performs autocompletion.
19050
19051         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
19052         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
19053
19054 2012-02-09  James Robinson  <jamesr@chromium.org>
19055
19056         [chromium] Enable mock scrollbars for compositing layout tests
19057         https://bugs.webkit.org/show_bug.cgi?id=78299
19058
19059         Reviewed by Dirk Pranke.
19060
19061         This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
19062         compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
19063         more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
19064
19065         * DumpRenderTree/chromium/TestShell.cpp:
19066         (TestShell::runFileTest):
19067         * DumpRenderTree/chromium/WebPreferences.cpp:
19068         (WebPreferences::reset):
19069         (WebPreferences::applyTo):
19070         * DumpRenderTree/chromium/WebPreferences.h:
19071         (WebPreferences):
19072
19073 2012-02-09  Eric Seidel  <eric@webkit.org>
19074
19075         Remove more uses of "os" from our webkitpy code
19076         https://bugs.webkit.org/show_bug.cgi?id=78292
19077
19078         Reviewed by Adam Barth.
19079
19080         * Scripts/webkitpy/common/checkout/checkout_mock.py:
19081         (MockCheckout.__init__):
19082         (MockCheckout.is_path_to_changelog):
19083         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
19084         * Scripts/webkitpy/common/system/filesystem_mock.py:
19085         (MockFileSystem._split):
19086         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
19087         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
19088         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
19089         * Scripts/webkitpy/layout_tests/port/webkit.py:
19090         * Scripts/webkitpy/tool/bot/queueengine.py:
19091         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
19092         * Scripts/webkitpy/tool/commands/download.py:
19093         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
19094         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
19095         * Scripts/webkitpy/tool/commands/sheriffbot.py:
19096         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
19097         * Scripts/webkitpy/tool/commands/upload.py:
19098         (CreateBug.prompt_for_bug_title_and_comment):
19099         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
19100         * Scripts/webkitpy/tool/steps/attachtobug.py:
19101         (AttachToBug.run):
19102         * Scripts/webkitpy/tool/steps/checkstyle.py:
19103         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
19104         * Scripts/webkitpy/tool/steps/commit_unittest.py:
19105         * Scripts/webkitpy/tool/steps/editchangelog.py:
19106         * Scripts/webkitpy/tool/steps/preparechangelog.py:
19107         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
19108         (PrepareChangeLogTest.test_ensure_bug_url):
19109         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
19110         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
19111         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
19112         * Scripts/webkitpy/tool/steps/validatereviewer.py:
19113
19114 2012-02-09  Eric Seidel  <eric@webkit.org>
19115
19116         Remove the cr-mac-ews (it's long been dead)
19117         https://bugs.webkit.org/show_bug.cgi?id=78267
19118
19119         Reviewed by Adam Barth.
19120
19121         * QueueStatusServer/model/queues.py:
19122         (Queue):
19123         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
19124         (ChromiumWindowsEWS):
19125         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
19126         (EarlyWarningSytemTest._test_builder_ews):
19127         (EarlyWarningSytemTest._test_testing_ews):
19128
19129 2012-02-09  Dirk Pranke  <dpranke@chromium.org>
19130
19131         some tests in webkitpy are being run three times
19132         https://bugs.webkit.org/show_bug.cgi?id=78283
19133
19134         Reviewed by Ryosuke Niwa.
19135
19136         It turns out that if you import a class derived from
19137         unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
19138         the unittest framework treats it as if the class was defined in
19139         the file (as well in the original file). This led us to running
19140         the tests in ChangeLogTest three times.
19141
19142         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
19143         (PrepareChangeLogTest):
19144         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
19145         (_assert_message_for_revert_output):
19146
19147 2012-02-09  Adam Barth  <abarth@webkit.org>
19148
19149         Remove extraneous line in previous patch.  I forgot to remove this
19150         before landing.
19151
19152         * Scripts/webkitpy/layout_tests/port/driver.py:
19153         (DriverProxy.start):
19154
19155 2012-02-09  Adam Barth  <abarth@webkit.org>
19156
19157         run-perf-tests should have an option to pause before running tests so we can attach Instruments
19158         https://bugs.webkit.org/show_bug.cgi?id=78271
19159
19160         Reviewed by Ryosuke Niwa.
19161
19162         This lets me attach instruments to profile the performance of the test.
19163
19164         * Scripts/webkitpy/layout_tests/port/chromium.py:
19165         (ChromiumDriver.start):
19166         * Scripts/webkitpy/layout_tests/port/driver.py:
19167         (Driver.start):
19168         (DriverProxy.start):
19169         * Scripts/webkitpy/layout_tests/port/server_process.py:
19170         (ServerProcess.start):
19171         * Scripts/webkitpy/layout_tests/port/test.py:
19172         (TestDriver.start):
19173         * Scripts/webkitpy/layout_tests/port/webkit.py:
19174         (WebKitDriver.start):
19175         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19176         (get_tests_run.RecordingTestDriver.start):
19177         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
19178         (PerfTestsRunner._parse_args):
19179         (PerfTestsRunner._run_tests_set):
19180         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
19181         (start):
19182         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
19183         (test_run_test_set_kills_drt_per_run):
19184         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
19185         (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
19186
19187 2012-02-09  Adam Barth  <abarth@webkit.org>
19188
19189         run-perf-tests --chromium should run the chromium port
19190         https://bugs.webkit.org/show_bug.cgi?id=78266
19191
19192         Reviewed by Ryosuke Niwa.
19193
19194         This patch makes run-perf-tests work more like run-webkit-tests.
19195
19196         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
19197         (PerfTestsRunner._parse_args):
19198
19199 2012-02-09  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
19200
19201         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
19202         https://bugs.webkit.org/show_bug.cgi?id=77466
19203
19204         Reviewed by Dirk Pranke.
19205
19206         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
19207         is set or if we should raise an error. A unit test was added.
19208
19209         * Scripts/webkitpy/layout_tests/port/qt.py:
19210         (QtPort.operating_system):
19211         (QtPort):
19212         (QtPort.check_sys_deps):
19213         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
19214         (QtPortTest.test_operating_system):
19215         (QtPortTest):
19216         (QtPortTest.test_check_sys_deps):
19217
19218 2012-02-09  Eric Seidel  <eric@webkit.org>
19219
19220         Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
19221         https://bugs.webkit.org/show_bug.cgi?id=78263
19222
19223         Reviewed by Adam Barth.
19224
19225         * Scripts/webkitpy/common/config/ports.py:
19226         (DeprecatedPort):
19227         (DeprecatedPort.name):
19228         (DeprecatedPort.flag):
19229         (DeprecatedPort.script_path):
19230         (DeprecatedPort.script_shell_command):
19231         (DeprecatedPort.port):
19232         (DeprecatedPort.makeArgs):
19233         (DeprecatedPort.update_webkit_command):
19234         (DeprecatedPort.check_webkit_style_command):
19235         (DeprecatedPort.prepare_changelog_command):
19236         (DeprecatedPort.build_webkit_command):
19237         (DeprecatedPort.run_javascriptcore_tests_command):
19238         (DeprecatedPort.run_webkit_unit_tests_command):
19239         (DeprecatedPort.run_webkit_tests_command):
19240         (DeprecatedPort.run_python_unittests_command):
19241         (DeprecatedPort.run_perl_unittests_command):
19242         (DeprecatedPort.layout_tests_results_path):
19243         (MacPort):
19244         (WinPort):
19245         (GtkPort):
19246         (GtkPort.build_webkit_command):
19247         (GtkPort.run_webkit_tests_command):
19248         (QtPort):
19249         (QtPort.build_webkit_command):
19250         (EflPort):
19251         (EflPort.build_webkit_command):
19252         (ChromiumPort):
19253         (ChromiumPort.update_webkit_command):
19254         (ChromiumPort.build_webkit_command):
19255         (ChromiumPort.run_webkit_tests_command):
19256         (ChromiumPort.run_javascriptcore_tests_command):
19257         (ChromiumXVFBPort):
19258         (ChromiumXVFBPort.run_webkit_tests_command):
19259         * Scripts/webkitpy/common/config/ports_unittest.py:
19260         (DeprecatedPortTest):
19261         (DeprecatedPortTest.test_mac_port):
19262         (DeprecatedPortTest.test_gtk_port):
19263         (DeprecatedPortTest.test_qt_port):
19264         (DeprecatedPortTest.test_chromium_port):
19265         (DeprecatedPortTest.test_chromium_xvfb_port):
19266         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
19267         (AbstractEarlyWarningSystem.__init__):
19268         * Scripts/webkitpy/tool/commands/sheriffbot.py:
19269         * Scripts/webkitpy/tool/main.py:
19270         (WebKitPatch):
19271         (WebKitPatch.handle_global_options):
19272         * Scripts/webkitpy/tool/steps/abstractstep.py:
19273         * Scripts/webkitpy/tool/steps/steps_unittest.py:
19274         (StepsTest.test_runtests_args):
19275
19276 2012-02-09  Jochen Eisinger  <jochen@chromium.org>
19277
19278         [chromium] always initialize makeArgs in buildChromiumNinja
19279         https://bugs.webkit.org/show_bug.cgi?id=78231
19280
19281         Reviewed by Tony Gentilcore.
19282
19283         * Scripts/webkitdirs.pm:
19284         (buildChromiumNinja):
19285
19286 2012-02-09  Carlos Garcia Campos  <cgarcia@igalia.com>
19287
19288         [GTK] Show url of current hovered link in MiniBrowser
19289         https://bugs.webkit.org/show_bug.cgi?id=78098
19290
19291         Reviewed by Martin Robinson.
19292
19293         * MiniBrowser/gtk/BrowserWindow.c:
19294         (webViewMouseTargetChanged): Check whether hit test result is a
19295         link and use the url to update the status bar text.
19296         (browserWindowConstructed): Connect to
19297         WebKitWebView::mouse-target-changed signal.
19298
19299 2012-02-09  Rob Buis  <rbuis@rim.com>
19300
19301         [BlackBerry] Upstream DumpRenderTreeBlackBerry
19302         https://bugs.webkit.org/show_bug.cgi?id=78042
19303
19304         Reviewed by Antonio Gomes.
19305
19306         Upstream final part of our DRT implementation.
19307
19308         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
19309         * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
19310         * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
19311         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
19312         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
19313
19314 2012-02-09  Ryosuke Niwa  <rniwa@webkit.org>
19315
19316         kill-old-processes should kill gcc and clang
19317         https://bugs.webkit.org/show_bug.cgi?id=78189
19318
19319         Reviewed by Eric Seidel.
19320
19321         Added a bunch of processes names of gcc and clang to the list.
19322
19323         * BuildSlaveSupport/kill-old-processes:
19324
19325 2012-02-07  MORITA Hajime  <morrita@google.com>
19326
19327         Replacement text should be available from the marker.
19328         https://bugs.webkit.org/show_bug.cgi?id=77934
19329
19330         Made the mock requestCheckingOfText() implementation to return
19331         a replacement text for each misspelled word if available.
19332
19333         Reviewed by Kent Tamura.
19334
19335         * DumpRenderTree/chromium/WebViewHost.cpp:
19336         (WebViewHost::finishLastTextCheck):
19337
19338 2012-02-08  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
19339
19340         [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
19341         https://bugs.webkit.org/show_bug.cgi?id=78146
19342
19343         Reviewed by Ryosuke Niwa.
19344
19345         Our DumpRenderTree should support --no-timeout and --timeout options in order
19346         to be able to use run-perf-tests and have a Performance Bot.
19347         This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
19348         and the necessary code to handle such command line arguments to our DumpRenderTree.
19349
19350         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
19351         (WebCore::DumpRenderTree::setTimeout):
19352         (WebCore):
19353         (WebCore::DumpRenderTree::setShouldTimeout):
19354         * DumpRenderTree/qt/DumpRenderTreeQt.h:
19355         (DumpRenderTree):
19356         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
19357         (LayoutTestController::LayoutTestController):
19358         (LayoutTestController::waitUntilDone):
19359         (LayoutTestController::notifyDone):
19360         * DumpRenderTree/qt/LayoutTestControllerQt.h:
19361         (LayoutTestController::setTimeout):
19362         (LayoutTestController::setShouldTimeout):
19363         (LayoutTestController):
19364         * DumpRenderTree/qt/main.cpp:
19365         (isOption):
19366         (printUsage):
19367         (main):
19368
19369 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
19370
19371         Rubber-stamped by Martin Robinson.
19372
19373         * gtk/common.py:
19374         (get_build_path): Move test for current directory being a valid
19375         directory up so it takes precedence over WebKitBuild/Release and
19376         WebKitBuild/Debug when they exist as well.
19377
19378 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
19379
19380         [GTK] doc rebasing does not respect DESTDIR
19381         https://bugs.webkit.org/show_bug.cgi?id=78177
19382
19383         Reviewed by Martin Robinson.
19384
19385         * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
19386         calling it for rebasing.
19387         * gtk/generate-gtkdoc:
19388         (get_common_options): Handle the new --virtual-root option.
19389         * gtk/gtkdoc.py:
19390         (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
19391         it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
19392
19393 2012-02-08  Adam Barth  <abarth@webkit.org>
19394
19395         Remove Python 2.5 support from WebKit
19396         https://bugs.webkit.org/show_bug.cgi?id=71593
19397
19398         Reviewed by Eric Seidel.
19399
19400         This is the last vestige of our Python 2.5 support.
19401
19402         * Scripts/webkitpy/tool/commands/queues_unittest.py:
19403         (AbstractQueueTest.test_log_from_script_error_for_upload):
19404
19405 2012-02-08  Adam Barth  <abarth@webkit.org>
19406
19407         version_check.py should inform users that we don't support Python 2.5 anymore
19408         https://bugs.webkit.org/show_bug.cgi?id=78179
19409
19410         Reviewed by Eric Seidel.
19411
19412         We don't support Python 2.5 anymore.
19413
19414         * Scripts/webkitpy/common/version_check.py:
19415
19416 2012-02-08  Adam Barth  <abarth@webkit.org>
19417
19418         test_configuration.py shouldn't re-implement itertools
19419         https://bugs.webkit.org/show_bug.cgi?id=78178
19420
19421         Reviewed by Eric Seidel.
19422
19423         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
19424         (TestConfigurationConverter.to_specifiers_list):
19425         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
19426         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
19427         (TestConfigurationConverter):
19428
19429 2012-02-08  Adam Barth  <abarth@webkit.org>
19430
19431         webkitpy should reply upon the multiprocessing package existing
19432         https://bugs.webkit.org/show_bug.cgi?id=78176
19433
19434         Reviewed by Eric Seidel.
19435
19436         Now that we don't support Python 2.5, this import can't fail.
19437
19438         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
19439         (get):
19440         (_Process):
19441         (_Process.__init__):
19442         (_Process.run):
19443         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
19444         (FunctionTests.test_get__processes):
19445         (MultiProcessBrokerTests.setUp):
19446         * Scripts/webkitpy/layout_tests/port/base.py:
19447         (Port.__init__):
19448         (Port.default_worker_model):
19449         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
19450         (ChromiumMacPort.check_build):
19451         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
19452         (PortTestCase.test_default_worker_model):
19453         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19454
19455 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
19456
19457         Unreviewed typo fix that makes docs build again for the gtk2-based
19458         library.
19459
19460         * gtk/generate-gtkdoc:
19461
19462 2012-02-08  Adam Barth  <abarth@webkit.org>
19463
19464         Don't re-implement ZipFile.extractall
19465         https://bugs.webkit.org/show_bug.cgi?id=78173
19466
19467         Reviewed by Eric Seidel.
19468
19469         We can use ZipFile.extractall now that we don't support Python 2.5.
19470
19471         * Scripts/webkitpy/common/system/autoinstall.py:
19472         (AutoInstaller._extract_targz):
19473         (AutoInstaller._unzip):
19474
19475 2012-02-08  Adam Barth  <abarth@webkit.org>
19476
19477         Remove the ospath compat shim from webkitpy
19478         https://bugs.webkit.org/show_bug.cgi?id=78170
19479
19480         Reviewed by Eric Seidel.
19481
19482         We no longer need this compat shim now that we don't support Python 2.5.
19483
19484         * Scripts/webkitpy/common/checkout/scm/git.py:
19485         * Scripts/webkitpy/common/checkout/scm/svn.py:
19486         * Scripts/webkitpy/common/system/filesystem.py:
19487         (FileSystem.relpath):
19488         * Scripts/webkitpy/common/system/filesystem_mock.py:
19489         (MockFileSystem.relpath):
19490         * Scripts/webkitpy/common/system/ospath.py: Removed.
19491         * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
19492
19493 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
19494
19495         Build fix attempt after r107053.
19496
19497         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
19498         (test_collect_tests):
19499
19500 2012-02-08  Adam Barth  <abarth@webkit.org>
19501
19502         Remove simplejson because it's no longer used by webkitpy
19503         https://bugs.webkit.org/show_bug.cgi?id=78164
19504
19505         Reviewed by Eric Seidel.
19506
19507         All the importers of this code were removed in a previous patch.
19508
19509         * Scripts/webkitpy/thirdparty/simplejson: Removed.
19510         * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
19511         * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
19512         * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
19513         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
19514         * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
19515         * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
19516         * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
19517         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
19518         * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
19519         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
19520
19521 2012-02-08  Adam Barth  <abarth@webkit.org>
19522
19523         webkitpy still imports simplejson
19524         https://bugs.webkit.org/show_bug.cgi?id=78161
19525
19526         Reviewed by Eric Seidel.
19527
19528         We no longer support Python 2.5, so we can rely upon Python's built-in
19529         JSON package.
19530
19531         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
19532         * Scripts/webkitpy/common/net/resultsjsonparser.py:
19533         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
19534         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
19535         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
19536         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
19537         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19538         * Scripts/webkitpy/style/checkers/jsonchecker.py:
19539         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
19540         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
19541         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
19542
19543 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
19544
19545         [GTK] Fails to build docs with non-standard build directories
19546         https://bugs.webkit.org/show_bug.cgi?id=78118
19547
19548         * gtk/common.py:
19549         (get_build_path): add comment to document changes done in r107098,
19550         as requested by the reviewer and forgotten by me.
19551
19552 2012-02-08  Adam Barth  <abarth@webkit.org>
19553
19554         Stop importing with_statement from the mysterious future
19555         https://bugs.webkit.org/show_bug.cgi?id=78156
19556
19557         Reviewed by Eric Seidel.
19558
19559         The future is now!  (Well, at least 2008, when Python 2.6 was released,
19560         is no longer the __future__.)
19561
19562         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
19563         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
19564         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
19565         * Scripts/webkitpy/common/net/credentials_unittest.py:
19566         * Scripts/webkitpy/common/net/file_uploader.py:
19567         * Scripts/webkitpy/common/newstringio_unittest.py:
19568         * Scripts/webkitpy/common/system/autoinstall.py:
19569         * Scripts/webkitpy/common/system/crashlogs.py:
19570         * Scripts/webkitpy/common/system/fileset.py:
19571         * Scripts/webkitpy/common/system/filesystem.py:
19572         * Scripts/webkitpy/common/system/filesystem_unittest.py:
19573         * Scripts/webkitpy/common/system/path.py:
19574         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
19575         * Scripts/webkitpy/layout_tests/controllers/manager.py:
19576         * Scripts/webkitpy/layout_tests/port/base.py:
19577         (of):
19578         * Scripts/webkitpy/layout_tests/port/gtk.py:
19579         * Scripts/webkitpy/layout_tests/port/test.py:
19580         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19581         * Scripts/webkitpy/style/filereader_unittest.py:
19582         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
19583         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
19584         * Scripts/webkitpy/tool/commands/analyzechangelog.py:
19585         * Scripts/webkitpy/tool/commands/queues.py:
19586         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
19587         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
19588
19589 2012-02-08  Rob Buis  <rbuis@rim.com>
19590
19591         [BlackBerry] Upstream DumpRenderTreeBlackBerry
19592         https://bugs.webkit.org/show_bug.cgi?id=78042
19593
19594         Reviewed by Antonio Gomes.
19595
19596         Upstream more parts of our DRT implementation.
19597
19598         * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
19599         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
19600         * DumpRenderTree/blackberry/EventSender.cpp: Added.
19601         * DumpRenderTree/blackberry/EventSender.h: Added.
19602         * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
19603         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
19604
19605 2012-02-08  Dirk Pranke  <dpranke@chromium.org>
19606
19607         check-webkit-style failing with "Path does not exist."
19608         https://bugs.webkit.org/show_bug.cgi?id=77873
19609
19610         Reviewed by Ojan Vafai.
19611
19612         This change fixes the way the style checker determines which
19613         Port class to use for a given test_expectations.txt path; the
19614         previous version used a heuristic that didn't really work in the
19615         first place.
19616
19617         * Scripts/webkitpy/style/checkers/test_expectations.py:
19618         (TestExpectationsChecker._determine_port_from_expectations_path):
19619         (TestExpectationsChecker.__init__):
19620         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
19621         (TestExpectationsTestCase._expect_port_for_expectations_path):
19622         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
19623
19624 2012-02-08  Fehér Zsolt  <feherzs@inf.u-szeged.hu>
19625
19626         nrwt: make --skip-pixel-test-if-no-baseline option
19627         https://bugs.webkit.org/show_bug.cgi?id=70484
19628
19629         Reviewed by Dirk Pranke.
19630
19631         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
19632         (SingleTestRunner.__init__):
19633         (SingleTestRunner._should_fetch_expected_checksum):
19634         * Scripts/webkitpy/layout_tests/controllers/worker.py:
19635         (Worker.handle_test_list):
19636         * Scripts/webkitpy/layout_tests/models/test_input.py:
19637         (TestInput.__init__):
19638         * Scripts/webkitpy/layout_tests/port/webkit.py:
19639         (WebKitDriver.cmd_line):
19640         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19641         (_set_up_derived_options):
19642         (parse_args):
19643         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
19644         (MainTest.test_skip_pixel_test_if_no_baseline_option):
19645         * WebKitTestRunner/TestController.cpp:
19646         (WTR::TestController::TestController):
19647         (WTR::TestController::initialize):
19648         (WTR::TestController::runTest):
19649         * WebKitTestRunner/TestController.h:
19650         (TestController):
19651         * WebKitTestRunner/TestInvocation.cpp:
19652         (WTR::TestInvocation::TestInvocation):
19653         (WTR::TestInvocation::setIsPixelTest):
19654         * WebKitTestRunner/TestInvocation.h:
19655         (WTR::TestInvocation::setSkipPixelTestOption):
19656         (TestInvocation):
19657
19658 2012-02-08  Rob Buis  <rbuis@rim.com>
19659
19660         [BlackBerry] Upstream DumpRenderTreeBlackBerry
19661         https://bugs.webkit.org/show_bug.cgi?id=78042
19662
19663         Reviewed by Antonio Gomes.
19664
19665         Add implementation for our DumpRenderTree solution.
19666
19667         * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
19668         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
19669
19670 2012-02-08  Antti Koivisto  <antti@apple.com>
19671
19672         REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
19673         https://bugs.webkit.org/show_bug.cgi?id=78080
19674
19675         Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
19676
19677         Add API test.
19678
19679         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
19680         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
19681         (TestWebKitAPI):
19682         (TestWebKitAPI::TEST):
19683
19684 2012-02-08  Gustavo Noronha Silva  <gns@gnome.org>
19685
19686         [GTK] Fails to build docs with non-standard build directories
19687         https://bugs.webkit.org/show_bug.cgi?id=78118
19688
19689         Reviewed by Martin Robinson.
19690
19691         * gtk/common.py:
19692         (get_build_path): also try the current directory as a valid build
19693         dir, which makes non-standard build directories such as build-2.0
19694         and build-3.0 work
19695
19696 2012-02-08  Carlos Garcia Campos  <cgarcia@igalia.com>
19697
19698         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
19699         https://bugs.webkit.org/show_bug.cgi?id=78099
19700
19701         Reviewed by Martin Robinson.
19702
19703         * MiniBrowser/gtk/BrowserWindow.c:
19704         (webViewDecidePolicy): Check whether it's a link clicked with the
19705         middle mouse button and load the request in a new window.
19706         (browserWindowConstructed): Connect to
19707         WebKitWebView::decide-policy signal.
19708
19709 2012-02-08  Ryosuke Niwa  <rniwa@webkit.org>
19710
19711         Revert a part of the change in r106687 as a build fix.
19712
19713         Since Chromium port doesn't checkout the entire WebKit trunk,
19714         we can't run "svn info" on webkit_base.
19715
19716         * Scripts/webkitpy/layout_tests/port/base.py:
19717         (Port.repository_paths):
19718
19719 2012-02-07  Ryosuke Niwa  <rniwa@webkit.org>
19720
19721         run-perf-tests doesn't recognize paths that start with PerformanceTests
19722         https://bugs.webkit.org/show_bug.cgi?id=78012
19723
19724         Reviewed by Adam Barth.
19725
19726         Use resolve paths using filesystem.relpath before passing it to find_files.find.
19727
19728         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
19729         (PerfTestsRunner):
19730         (PerfTestsRunner._collect_tests):
19731         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
19732         (test_collect_tests):
19733         (test_collect_tests.add_file):
19734
19735 2012-02-07  Justin Novosad  <junov@chromium.org>
19736
19737         [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
19738         https://bugs.webkit.org/show_bug.cgi?id=78039
19739
19740         Reviewed by Stephen White.
19741
19742         Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
19743
19744         * DumpRenderTree/chromium/DumpRenderTree.cpp:
19745         (main):
19746         * DumpRenderTree/chromium/TestShell.cpp:
19747         (TestShell::TestShell):
19748         (TestShell::resetWebSettings):
19749         (TestShell::runFileTest):
19750         * DumpRenderTree/chromium/TestShell.h:
19751         (TestShell::setDeferred2dCanvasEnabled):
19752         (TestShell):
19753         * DumpRenderTree/chromium/WebPreferences.cpp:
19754         (WebPreferences::reset):
19755         (WebPreferences::applyTo):
19756         * DumpRenderTree/chromium/WebPreferences.h:
19757         (WebPreferences):
19758
19759 2012-02-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
19760
19761         [CMAKE] Use *bin* and *lib* directories for executable and libraries.
19762         https://bugs.webkit.org/show_bug.cgi?id=77928
19763
19764         Reviewed by Daniel Bates.
19765
19766         CMake has used *Programs* directory for executable. In addition, shared libraries are being
19767         built in source directory. It is better to set common places in order to maintain executable
19768         and libraries. *bin* is for executable and *lib* is for library.
19769
19770         * DumpRenderTree/efl/CMakeLists.txt:
19771         * EWebLauncher/CMakeLists.txt:
19772         * Scripts/run-launcher:
19773         * Scripts/webkitdirs.pm:
19774         (jscProductDir):
19775         * Scripts/webkitpy/layout_tests/port/efl.py:
19776         (EflPort._path_to_driver):
19777         (EflPort._path_to_image_diff):
19778
19779 2012-02-07  Adam Klein  <adamk@chromium.org>
19780
19781         Add JSC support for delivering mutations when the outermost script context exits
19782         https://bugs.webkit.org/show_bug.cgi?id=70289
19783
19784         Reviewed by Eric Seidel.
19785
19786         * DumpRenderTree/mac/EventSendingController.mm: Add support for
19787         eventSender.scheduleAsynchronousKeyDown.
19788         (+[EventSendingController isSelectorExcludedFromWebScript:]):
19789         (+[EventSendingController webScriptNameForSelector:]):
19790         (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
19791         (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
19792         * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
19793
19794 2012-02-07  Chris Rogers  <crogers@google.com>
19795
19796         Add Chris Rogers to reviewers section
19797         https://bugs.webkit.org/show_bug.cgi?id=78016
19798
19799         Reviewed by Adam Barth.
19800
19801         * Scripts/webkitpy/common/config/committers.py:
19802
19803 2012-02-07  Nikolas Zimmermann  <nzimmermann@rim.com>
19804
19805         layoutTestController.display() is flaky for SVG tests
19806         https://bugs.webkit.org/show_bug.cgi?id=78021
19807
19808         Reviewed by Dan Bernstein.
19809
19810         Fix race condition in repaint rect tracking. When running a test using the repaint.js
19811         harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
19812         the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
19813         hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
19814         svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
19815         the repaint test already run, thus invalidating the previously tracked repaint rects.
19816
19817         * DumpRenderTree/mac/DumpRenderTree.mm:
19818         (dump):
19819         (runTest):
19820
19821 2012-02-07  Hans Wennborg  <hans@chromium.org>
19822
19823         Chromium: remove WebSpeechInputResult::set
19824         https://bugs.webkit.org/show_bug.cgi?id=77977
19825
19826         Reviewed by Darin Fisher.
19827
19828         It was renamed to assign() in r106475.
19829
19830         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
19831         (makeRectResult):
19832
19833 2012-02-07  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
19834
19835         [Qt] Give emulated touch-point a radius
19836         https://bugs.webkit.org/show_bug.cgi?id=77985
19837
19838         Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
19839
19840         Reviewed by Kenneth Rohde Christiansen.
19841
19842         * MiniBrowser/qt/BrowserWindow.cpp:
19843         (BrowserWindow::updateVisualMockTouchPoints):
19844         * MiniBrowser/qt/MiniBrowserApplication.cpp:
19845         (MiniBrowserApplication::notify):
19846         * MiniBrowser/qt/qml/MockTouchPoint.qml:
19847
19848 2012-02-07  Mario Sanchez Prada  <msanchez@igalia.com>
19849
19850         [GTK] Include gdk-pixbuf in the jhbuild modules
19851         https://bugs.webkit.org/show_bug.cgi?id=77980
19852
19853         Reviewed by Gustavo Noronha Silva.
19854
19855         * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
19856
19857 2012-02-07  Simon Hausmann  <simon.hausmann@nokia.com>
19858
19859         [Qt] Prevent early test termination with newer Qt 5
19860         https://bugs.webkit.org/show_bug.cgi?id=77945
19861
19862         Reviewed by Csaba Osztrogonác.
19863
19864         QTBUG-24120 tracks a regression in Qt that would make layout tests
19865         terminate early. This patch works around it in a Qt 4 + 5 safe manner
19866         by disabling the quitOnLastWindowClosed feature, which we don't want/need
19867         for DRT anyway.
19868
19869         * DumpRenderTree/qt/main.cpp:
19870         (main): Don't quit on last window closed.
19871
19872 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
19873
19874         Fix some miscellaneous 'make dist' error for WebKitGTK+.
19875
19876         * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
19877         files should not be distributed.
19878
19879 2012-02-02  Hajime Morrita  <morrita@chromium.org>
19880
19881         [PerformanceTests] Each Dromaeo test needs its landing html.
19882         https://bugs.webkit.org/show_bug.cgi?id=77504
19883
19884         Reviewed by Ryosuke Niwa.
19885
19886         Added an ignorable pattern which happens in some Dromaeo tests.
19887
19888         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
19889         (PerfTestsRunner):
19890
19891 2012-02-06  Kalev Lember  <kalevlember@gmail.com>
19892
19893         [GTK] Add missing pango include dir to fix build
19894         https://bugs.webkit.org/show_bug.cgi?id=77832
19895
19896         Reviewed by Martin Robinson.
19897
19898         * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
19899
19900 2012-02-06  Martin Robinson  <mrobinson@igalia.com>
19901
19902         [GTK] Fix remaining errors in GTK+ WebKit2 API
19903         https://bugs.webkit.org/show_bug.cgi?id=77890
19904
19905         Reviewed by Gustavo Noronha Silva.
19906
19907         Verify that WebKit2 GTK+ test files are not skipped during style checks.
19908         Skip soup_server_new when checking for NULL versus 0 usage.
19909
19910         * Scripts/webkitpy/style/checker_unittest.py:
19911         (CheckerDispatcherSkipTest.test_should_skip_with_warning):
19912         * Scripts/webkitpy/style/checkers/cpp.py:
19913         (check_for_null):
19914
19915 2012-02-06  Eric Seidel  <eric@webkit.org>
19916
19917         webkit-patch apply-from-bug should be able to apply non-reviewed patches
19918         https://bugs.webkit.org/show_bug.cgi?id=77883
19919
19920         Reviewed by Adam Barth.
19921
19922         This is very helpful if you use bugzilla as a replacement for git-stash.
19923         Makes it simpler to re-apply the patch w/o having to look up the patch id.
19924
19925         * Scripts/webkitpy/tool/commands/download.py:
19926         (ProcessBugsMixin._fetch_list_of_patches_to_process):
19927         * Scripts/webkitpy/tool/commands/download_unittest.py:
19928         (DownloadCommandsTest.test_apply_from_bug):
19929
19930 2012-02-06  Philippe Normand  <pnormand@igalia.com>
19931
19932         [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
19933         https://bugs.webkit.org/show_bug.cgi?id=77866
19934
19935         Reviewed by Martin Robinson.
19936
19937         * Scripts/webkitpy/style/checker.py: Ignore readability/naming
19938         errors in some gstreamer source code files defining new GStreamer elements.
19939         * Scripts/webkitpy/style/checker_unittest.py:
19940         (GlobalVariablesTest.test_path_rules_specifier):
19941
19942 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
19943
19944         [GTK] Make sure html_dir exists before calling gtkdoc-rebase
19945         https://bugs.webkit.org/show_bug.cgi?id=77869
19946
19947         Reviewed by Philippe Normand.
19948
19949         * gtk/gtkdoc.py:
19950         (GTKDoc.rebase_installed_docs): Check html_dir exists.
19951
19952 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
19953
19954         [Qt] Don't version QtWebKit.experimental.
19955         https://bugs.webkit.org/show_bug.cgi?id=77739
19956
19957         Reviewed by Tor Arne Vestbø.
19958
19959         * MiniBrowser/qt/qml/BrowserWindow.qml:
19960
19961 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
19962
19963         [GTK] Fix several gtkdoc-fixxref warnings
19964         https://bugs.webkit.org/show_bug.cgi?id=77613
19965
19966         Reviewed by Martin Robinson.
19967
19968         * gtk/generate-gtkdoc:
19969         (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
19970         of ignored files, since it's private.
19971         * gtk/gtkdoc.py:
19972         (GTKDoc._ignored_files_basenames): Helper function that returns a
19973         string with the list of ignored files basenames separated by a
19974         spaces, as expected by several gtkdoc commands.
19975         (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
19976         --ignore-headers option.
19977         (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
19978         --ignore-files option.
19979
19980 2012-02-06  Carlos Garcia Campos  <cgarcia@igalia.com>
19981
19982         [GTK] Fix xrefs after installing API documentation
19983         https://bugs.webkit.org/show_bug.cgi?id=77551
19984
19985         Reviewed by Martin Robinson.
19986
19987         * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
19988         api docs.
19989         * gtk/common.py:
19990         (prefix_of_pkg_config_file): Get the prefix variable of the given
19991         pkg-config file.
19992         (gtk_version_of_pkg_config_file): Get the gtk version required by
19993         the given pkg-config file.
19994         * gtk/generate-gtkdoc: Add --rebase command line option to rebase
19995         installed documentation.
19996         (get_gtkdoc_module_paths): Get paths where API doc is installed
19997         for the dependencies of the given pkg-config file.
19998         (get_common_xref_deps): Get API doc directories of dependencies
19999         common to WebKit1 and WebKit2.
20000         (get_webkit2_options): Add cross_reference_deps option.
20001         (get_webkit1_options): Ditto
20002         (rebase_installed_docs): Helper function to create a generator for
20003         the given pkg-config file and options and call rebase_installed_docs.
20004         * gtk/gtkdoc.py:
20005         (GTKDoc.__init__): Initialize cross_reference_deps.
20006         (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
20007         dependencies.
20008         (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
20009         links of installed documentation.
20010         (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
20011         file.
20012
20013 2012-02-06  Sergio Villar Senin  <svillar@igalia.com>
20014
20015         Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
20016         https://bugs.webkit.org/show_bug.cgi?id=77672
20017
20018         Reviewed by Dirk Pranke.
20019
20020         Test repetitions must be taken into account when working out
20021         the statistics shown by run-webkit-tests.
20022
20023         * Scripts/webkitpy/layout_tests/controllers/manager.py:
20024         (Manager.prepare_lists_and_print_output):
20025         (Manager._print_result_summary):
20026         * Scripts/webkitpy/layout_tests/models/result_summary.py:
20027         (ResultSummary.__init__):
20028         (ResultSummary.add):
20029         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
20030         (MainTest.test_repeat_each_iterations_num_tests):
20031
20032 2012-02-05  Dan Bernstein  <mitz@apple.com>
20033
20034         <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
20035         https://bugs.webkit.org/show_bug.cgi?id=77823
20036
20037         Reviewed by Anders Carlsson.
20038
20039         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
20040         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
20041
20042 2012-02-04  Dan Bernstein  <mitz@apple.com>
20043
20044         <rdar://problem/10660698> Clients cannot prevent caching of individual responses
20045         https://bugs.webkit.org/show_bug.cgi?id=77822
20046
20047         Reviewed by Sam Weinig.
20048
20049         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
20050         (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
20051
20052 2012-02-04  Sam Weinig  <sam@webkit.org>
20053
20054         Add ability to send WKURLRequests in WebKit2 API user messages
20055         https://bugs.webkit.org/show_bug.cgi?id=77819
20056
20057         Reviewed by Anders Carlsson.
20058
20059         Add testing for round-tripping WKTypes from the UIProcess,
20060         to the WebProcess, and back.
20061
20062         - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
20063           More can easily be added.
20064
20065         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20066         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
20067         (TestWebKitAPI):
20068         (WebKit2UserMessageRoundTripTest):
20069         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
20070         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
20071         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
20072         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
20073         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
20074         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
20075         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
20076         (TestWebKitAPI::TEST_F):
20077         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
20078         (TestWebKitAPI):
20079         (UserMessageTest):
20080         (TestWebKitAPI::UserMessageTest::UserMessageTest):
20081         (TestWebKitAPI::UserMessageTest::didReceiveMessage):
20082         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
20083         (TestWebKitAPI::PlatformWebView::resizeTo):
20084         (TestWebKitAPI):
20085         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
20086         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
20087
20088 2012-02-04  Dan Bernstein  <mitz@apple.com>
20089
20090         <rdar://problem/10772406> WKPreferences instances cannot be copied
20091         https://bugs.webkit.org/show_bug.cgi?id=77816
20092
20093         Reviewed by Sam Weinig.
20094
20095         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
20096         (TestWebKitAPI::TEST):
20097
20098 2012-02-04  Adam Barth  <abarth@webkit.org>
20099
20100         garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
20101         https://bugs.webkit.org/show_bug.cgi?id=77802
20102
20103         Reviewed by Eric Seidel.
20104
20105         This patch refactors our directory grouping code into base.js where it
20106         can be shared between failures.js and notifications.js.  It then adds
20107         an Examine action to each group of failures that triggers the "results"
20108         view.
20109
20110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
20111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
20112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
20113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
20114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
20115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
20116
20117 2012-02-04  Ojan Vafai  <ojan@chromium.org>
20118
20119         check-webkit-style is throwing an exception
20120         https://bugs.webkit.org/show_bug.cgi?id=77744
20121
20122         Reviewed by David Levin.
20123
20124         If the test_list is None, then we don't need to check for unsupported
20125         feature tests to skip.
20126
20127         * Scripts/webkitpy/layout_tests/port/webkit.py:
20128         (WebKitPort._has_test_in_directories):
20129         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
20130         (test_skipped_tests_for_unsupported_features_empty_test_list):
20131
20132 2012-02-03  Adam Barth  <abarth@webkit.org>
20133
20134         List of all failures in garden-o-matic should actually list all the failures
20135         https://bugs.webkit.org/show_bug.cgi?id=77796
20136
20137         Reviewed by Eric Seidel.
20138
20139         This patch wires a bit more data into the new "All Failures" tab.  I've
20140         also iterated on how we enable this experimental feature.  The tab is
20141         still just a dumb list, but we'll make it smarter.
20142
20143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
20144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
20145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
20146         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
20147
20148 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
20149
20150         Windows build fix after r106692.
20151
20152         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
20153         (PortTest.test_reference_files):
20154
20155 2012-02-03  Beth Dakin  <bdakin@apple.com>
20156
20157         https://bugs.webkit.org/show_bug.cgi?id=77782
20158         WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
20159         once on some pages with frames
20160         -and corresponding-
20161         <rdar://problem/10798474>
20162
20163         Reviewed by Sam Weinig.
20164
20165         One new test.
20166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20167         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
20168         (TestWebKitAPI):
20169         (TestWebKitAPI::didForceRepaint):
20170         (TestWebKitAPI::didFinishLoadForFrame):
20171         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
20172         (TestWebKitAPI::setPageLoaderClient):
20173         (TestWebKitAPI::TEST):
20174         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
20175         (TestWebKitAPI):
20176         (NewFirstVisuallyNonEmptyLayoutFramesTest):
20177         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
20178         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
20179         * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
20180
20181 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
20182
20183         webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
20184         https://bugs.webkit.org/show_bug.cgi?id=77781
20185
20186         Reviewed by Eric Seidel.
20187
20188         This change fixes a couple of issues discovered while debugging
20189         test-webkitpy; both calling exit() instead of sys.exit() --
20190         which is discouraged in program code instead of the interpreter
20191         -- and a particular usage of outputcapture were stdin to get whacked
20192         and preventing debugging.
20193
20194         This change introduces a couple of common _exit() methods that
20195         will standardize how webkit-patch exit's, in case we need to do
20196         something different in the future.
20197
20198         * Scripts/webkitpy/common/system/deprecated_logging.py:
20199         (error):
20200         * Scripts/webkitpy/common/system/outputcapture.py:
20201         (OutputCapture.assert_outputs):
20202         * Scripts/webkitpy/tool/bot/queueengine.py:
20203         (QueueEngine.exit_after_handled_error):
20204         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
20205         (AbstractSequencedCommand.execute):
20206         * Scripts/webkitpy/tool/commands/queues.py:
20207         (StyleQueue.handle_script_error):
20208         * Scripts/webkitpy/tool/commands/upload.py:
20209         (MarkBugFixed.execute):
20210         * Scripts/webkitpy/tool/multicommandtool.py:
20211         (Command._exit):
20212         * Scripts/webkitpy/tool/steps/abstractstep.py:
20213         (AbstractStep._exit):
20214         * Scripts/webkitpy/tool/steps/checkstyle.py:
20215         (CheckStyle.run):
20216         * Scripts/webkitpy/tool/steps/commit.py:
20217         (Commit._check_test_expectations):
20218         * Scripts/webkitpy/tool/steps/confirmdiff.py:
20219         (ConfirmDiff.run):
20220
20221 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
20222
20223         Perf bot build fix.
20224
20225         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20226         (PerfTestsRunner._generate_json):
20227
20228 2012-02-03  Adam Barth  <abarth@webkit.org>
20229
20230         Add a blank "Expected Failures" tab to garden-o-matic
20231         https://bugs.webkit.org/show_bug.cgi?id=77793
20232
20233         Reviewed by Eric Seidel.
20234
20235         This tab will help us explore and manage our expected failures.  The
20236         tab is hidden by default via a new "experimental features" flag.
20237
20238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
20239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
20240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
20241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
20242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
20243         (#unexpected):
20244         (#onebar.partytime #unexpected):
20245
20246 2012-02-03  Lucas Forschler  <lforschler@apple.com>
20247
20248         update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
20249         https://bugs.webkit.org/show_bug.cgi?id=77785
20250
20251         Fix the build bots.
20252
20253         Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
20254
20255         * Scripts/update-webkit-support-libs:
20256         (downloadExpectedVersionNumber):
20257
20258 2012-02-03  Lucas Forschler  <lforschler@apple.com>
20259
20260         Add a Mac Lion Performance bot.
20261         https://bugs.webkit.org/show_bug.cgi?id=77765
20262
20263         Reviewed by Adam Roben.
20264
20265         This will update the master configuration in the following ways:
20266             Add a new performance slave (apple-xseve-11)
20267             Add a new Factory to download a build and run perf tests.
20268
20269         * BuildSlaveSupport/build.webkit.org-config/config.json:
20270         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
20271         (DownloadAndPerfTestFactory):
20272         (DownloadAndPerfTestFactory.__init__):
20273
20274 2012-02-03  Dirk Pranke  <dpranke@chromium.org>
20275
20276         Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
20277         https://bugs.webkit.org/show_bug.cgi?id=77752
20278
20279         Reviewed by James Robinson.
20280
20281         Delete unneeded file accidentally checked in in r106481.
20282
20283         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
20284
20285 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
20286
20287         Ref Tests should support plain SVG files
20288         https://bugs.webkit.org/show_bug.cgi?id=77685
20289
20290         Reviewed by Tony Chang.
20291
20292         Don't assume reference files always use .html as the extension.
20293         Instead, use the list of supported extension to look for -expected.* and -mismatch.*
20294
20295         Also fix various bugs in MockFileSystem and TestPort.
20296
20297         * Scripts/webkitpy/common/system/filesystem_mock.py:
20298         (MockFileSystem.isdir):
20299         * Scripts/webkitpy/layout_tests/port/base.py:
20300         (Port.reference_files):
20301         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
20302         (PortTest.test_is_test_file):
20303         (PortTest.test_reference_files):
20304         * Scripts/webkitpy/layout_tests/port/test.py:
20305         (TestInstance.__init__):
20306
20307 2012-02-03  Ryosuke Niwa  <rniwa@webkit.org>
20308
20309         perf-o-matic should store chromium svn revision
20310         https://bugs.webkit.org/show_bug.cgi?id=77725
20311
20312         Reviewed by Dirk Pranke.
20313
20314         Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
20315         repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
20316         is implemented in terms of newly added svn_revision.
20317
20318         * Scripts/webkitpy/common/checkout/scm/git.py:
20319         (Git.svn_revision):
20320         * Scripts/webkitpy/common/checkout/scm/scm.py:
20321         (SCM.head_svn_revision):
20322         (SCM):
20323         (SCM.svn_revision):
20324         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
20325         (MockSCM.svn_revision):
20326         * Scripts/webkitpy/common/checkout/scm/svn.py:
20327         (SVN.svn_revision):
20328         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
20329         (JSONLayoutResultsGenerator.__init__):
20330         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
20331         (JSONResultsGeneratorBase._insert_generic_metadata):
20332         * Scripts/webkitpy/layout_tests/port/base.py:
20333         (Port.repository_paths):
20334         * Scripts/webkitpy/layout_tests/port/chromium.py:
20335         (ChromiumPort.repository_paths):
20336         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20337         (PerfTestsRunner._generate_json):
20338         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20339         (test_run_test_set_with_json_output):
20340         (test_run_test_set_with_json_source):
20341         (test_run_test_set_with_multiple_repositories):
20342
20343 2012-02-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
20344
20345         [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
20346         https://bugs.webkit.org/show_bug.cgi?id=77632
20347
20348         Reviewed by Kenneth Rohde Christiansen.
20349
20350         * MiniBrowser/qt/BrowserWindow.cpp:
20351         (BrowserWindow::BrowserWindow):
20352         * MiniBrowser/qt/MiniBrowserApplication.cpp:
20353         (MiniBrowserApplication::sendTouchEvent):
20354         (MiniBrowserApplication::handleUserOptions):
20355         * MiniBrowser/qt/MiniBrowserApplication.h:
20356         (WindowOptions):
20357         (WindowOptions::WindowOptions):
20358         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
20359         (WTR::PlatformWebView::PlatformWebView):
20360         * WebKitTestRunner/qt/main.cpp:
20361         (main):
20362         * qmake/mkspecs/features/default_post.prf:
20363
20364 2012-02-03  Simon Hausmann  <simon.hausmann@nokia.com>
20365
20366         [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
20367         https://bugs.webkit.org/show_bug.cgi?id=77723
20368
20369         Reviewed by Tor Arne Vestbø.
20370
20371         * Tools.pro: Compile WTR again on all platforms with WK2.
20372
20373 2012-02-03  Sriram Neelakandan  <sriram.neelakandan@gmail.com>
20374
20375         Ensure that inspector disabled build works
20376         https://bugs.webkit.org/show_bug.cgi?id=77604
20377
20378         Reviewed by Tor Arne Vestbø.
20379
20380         * qmake/mkspecs/features/features.prf:
20381
20382 2012-02-02  Jochen Eisinger  <jochen@chromium.org>
20383
20384         [chromium] add support for --makeargs to the ninja-based build
20385         https://bugs.webkit.org/show_bug.cgi?id=77688
20386
20387         Reviewed by Adam Barth.
20388
20389         * Scripts/webkitdirs.pm:
20390         (buildChromiumNinja):
20391
20392 2012-02-02  Eric Seidel  <eric@webkit.org>
20393
20394         Run tests in serial on SnowLeopard to avoid CFURLCache crashes
20395         https://bugs.webkit.org/show_bug.cgi?id=75145
20396
20397         Reviewed by Dirk Pranke.
20398
20399         * Scripts/webkitpy/layout_tests/port/mac.py:
20400         (MacPort.default_child_processes):
20401         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
20402         (test_operating_system):
20403         (test_default_child_processes):
20404
20405 2012-02-02  Dirk Pranke  <dpranke@chromium.org>
20406
20407        nrwt shouldn't blow up when there are errors in test_expectations.txt
20408        https://bugs.webkit.org/show_bug.cgi?id=73603
20409
20410        Reviewed by Ojan Vafai.
20411
20412        This change removes the distinction between 'errors' and 'warnings'
20413        in the test expectations parser. Now, any problem is a
20414        'warning', and if we are linting the file, warnings become fatal (errors).
20415
20416         This will allow a normal run-webkit-tests run to proceed even if
20417         there are bad lines.
20418
20419         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
20420         (ParseError.__init__):
20421         (ParseError.__str__):
20422         (ParseError.__repr__):
20423         (TestExpectationSerializer.to_string):
20424         (TestExpectationParser._parse_modifiers):
20425         (TestExpectationParser._parse_expectations):
20426         (TestExpectationParser._check_modifiers_against_expectations):
20427         (TestExpectationParser._tokenize):
20428         (TestExpectationLine.__init__):
20429         (TestExpectationLine.is_invalid):
20430         (TestExpectationsModel.add_expectation_line):
20431         (TestExpectationsModel._already_seen_better_match):
20432         (TestExpectations.__init__):
20433         (TestExpectations._report_warnings):
20434         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
20435         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
20436         (assert_bad_expectations):
20437         (test_parse_warning):
20438         (test_overrides__duplicate):
20439         (ExpectationSyntaxTests.test_missing_expectation):
20440         (ExpectationSyntaxTests.test_missing_colon):
20441         (ExpectationSyntaxTests.test_too_many_colons):
20442         (ExpectationSyntaxTests.test_too_many_equals_signs):
20443         (ExpectationSyntaxTests.test_unrecognized_expectation):
20444         (SemanticTests.test_bug_format):
20445         (SemanticTests.test_bad_bugid):
20446         (SemanticTests.test_slow_and_timeout):
20447         (test_ambiguous):
20448         (test_more_modifiers):
20449         (test_order_in_file):
20450         (test_macro_overrides):
20451         (RebaseliningTest.assertRemove):
20452         (TestExpectationParserTests.test_tokenize_blank):
20453         (TestExpectationParserTests.test_tokenize_missing_colon):
20454         (TestExpectationParserTests.test_tokenize_extra_colon):
20455         (TestExpectationParserTests.test_tokenize_empty_comment):
20456         (TestExpectationParserTests.test_tokenize_comment):
20457         (TestExpectationParserTests.test_tokenize_missing_equal):
20458         (TestExpectationParserTests.test_tokenize_extra_equal):
20459         (TestExpectationParserTests.test_tokenize_valid):
20460         (TestExpectationParserTests.test_tokenize_valid_with_comment):
20461         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
20462         (TestExpectationSerializerTests.test_unparsed_to_string):
20463         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
20464         (lint):
20465         * Scripts/webkitpy/style/checkers/test_expectations.py:
20466         (TestExpectationsChecker.check_test_expectations):
20467
20468 2012-02-02  Sheriff Bot  <webkit.review.bot@gmail.com>
20469
20470         Unreviewed, rolling out r106543.
20471         http://trac.webkit.org/changeset/106543
20472         https://bugs.webkit.org/show_bug.cgi?id=77671
20473
20474         Made tests less stable (Requested by rniwa on #webkit).
20475
20476         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20477         (PerfTestsRunner):
20478         (PerfTestsRunner.__init__):
20479         (PerfTestsRunner._run_tests_set):
20480         (PerfTestsRunner._run_single_test):
20481         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20482         (MainTest.TestDriver.run_test):
20483         (run_test):
20484
20485 2012-02-02  Beth Dakin  <bdakin@apple.com>
20486
20487         https://bugs.webkit.org/show_bug.cgi?id=77664
20488         Add API tests for didNewFirstVisuallyNonEmptyLayout
20489
20490         Reviewed by Darin Adler.
20491
20492         Two new tests.
20493         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
20494         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
20495         (TestWebKitAPI):
20496         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
20497         (TestWebKitAPI::setPageLoaderClient):
20498         (TestWebKitAPI::TEST):
20499         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
20500         (TestWebKitAPI):
20501         (TestWebKitAPI::didForceRepaint):
20502         (TestWebKitAPI::didFinishLoadForFrame):
20503         (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
20504         (TestWebKitAPI::setPageLoaderClient):
20505         (TestWebKitAPI::TEST):
20506         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
20507         (TestWebKitAPI):
20508         (NewFirstVisuallyNonEmptyLayoutFailsTest):
20509         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
20510         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
20511         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
20512         (TestWebKitAPI):
20513         (NewFirstVisuallyNonEmptyLayoutTest):
20514         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
20515         (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
20516
20517 2012-02-02  Michael Saboff  <msaboff@apple.com>
20518
20519         Add Michael Saboff to reviewers list.
20520
20521         Rubber-stamped by Gavin Barraclough.
20522
20523         * Scripts/webkitpy/common/config/committers.py:
20524
20525 2012-02-02  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
20526
20527         Add myself as a committer
20528
20529         Unreviewed
20530
20531         * Scripts/webkitpy/common/config/committers.py:
20532
20533 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
20534
20535         [PerformanceTests] tests have dependencies
20536         https://bugs.webkit.org/show_bug.cgi?id=77506
20537
20538         Reviewed by Hajime Morita.
20539
20540         Load an initialization page before each test after starting a DRT so that
20541         warming up DRT won't affect the performance test results.
20542
20543         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20544         (PerfTestsRunner):
20545         (PerfTestsRunner.__init__):
20546         (PerfTestsRunner._run_tests_set):
20547         (PerfTestsRunner._run_single_test):
20548         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20549         (MainTest.TestDriver.run_test):
20550         (test_initial_page_loaded):
20551         (test_initial_page_loaded.run_test):
20552
20553 2012-02-02  Ryosuke Niwa  <rniwa@webkit.org>
20554
20555         Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
20556
20557         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20558         (PerfTestsRunner._run_tests_set):
20559         (PerfTestsRunner._run_single_test):
20560         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20561         (create_runner):
20562         (test_run_passing_test):
20563         (test_run_silent_test):
20564         (test_run_failed_test):
20565         (test_run_tonguey_test):
20566         (test_run_timeout_test):
20567         (test_run_crash_test):
20568         (test_run_test_set_kills_drt_per_run):
20569         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
20570         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
20571         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
20572
20573 2012-02-01  Jacob Goldstein  <jacobg@adobe.com>
20574
20575         Webkit generate-coverage-data script needs update to use new test script
20576         https://bugs.webkit.org/show_bug.cgi?id=77597
20577
20578         Reviewed by Dirk Schulze.
20579
20580         * Scripts/generate-coverage-data:
20581
20582 2012-02-01  Adam Barth  <abarth@webkit.org>
20583
20584         Update the tests to show that the mac-ews processes patches from
20585         non-committers.
20586
20587         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
20588         (EarlyWarningSytemTest.test_committer_only_ewses):
20589         (EarlyWarningSytemTest.test_builder_ewses):
20590
20591 2012-02-01  Adam Barth  <abarth@webkit.org>
20592
20593         Mac-ews logs are huge
20594         https://bugs.webkit.org/show_bug.cgi?id=77045
20595
20596         Reviewed by Eric Seidel.
20597
20598         In order to get the cr-linux-ews bot to run tests on EC2, we created
20599         the chromium-xvfb port, which contained a number of tweaks to the
20600         Chromium port's behavior.  This patch refactors those tweaks so they
20601         can be shared with the mac-ews, mostly by moving them into the
20602         non-interactive mode of RunTests.
20603
20604         * Scripts/webkitpy/common/config/ports.py:
20605         (WebKitPort):
20606         (WebKitPort.layout_tests_results_path):
20607         (ChromiumPort.run_javascriptcore_tests_command):
20608         (ChromiumXVFBPort):
20609         (ChromiumXVFBPort.run_webkit_tests_command):
20610         * Scripts/webkitpy/common/config/ports_mock.py:
20611         (MockPort):
20612         (MockPort.layout_tests_results_path):
20613         * Scripts/webkitpy/common/config/ports_unittest.py:
20614         (WebKitPortTest.test_chromium_xvfb_port):
20615         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
20616         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
20617         * Scripts/webkitpy/tool/commands/queues_unittest.py:
20618         (CommitQueueTest.test_commit_queue):
20619         (test_rollout):
20620         (test_manual_reject_during_processing):
20621         * Scripts/webkitpy/tool/steps/runtests.py:
20622         (RunTests.run):
20623         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
20624         (RunTestsTest.test_no_unit_tests):
20625         * Scripts/webkitpy/tool/steps/steps_unittest.py:
20626         (StepsTest.test_runtests_args):
20627
20628 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
20629
20630         Roll out r106442. It made some tests more stable but others less stable.
20631
20632         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20633         (PerfTestsRunner._run_tests_set):
20634         (PerfTestsRunner._run_single_test):
20635         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20636         (create_runner):
20637         (test_run_passing_test):
20638         (test_run_silent_test):
20639         (test_run_failed_test):
20640         (test_run_tonguey_test):
20641         (test_run_timeout_test):
20642         (test_run_crash_test):
20643         (test_run_test_set):
20644
20645 2012-02-01  Lucas Forschler  <lforschler@apple.com>
20646
20647         Enable EWS for non-contributers.
20648         https://bugs.webkit.org/show_bug.cgi?id=77576
20649
20650         Reviewed by Adam Barth.
20651
20652         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
20653         (MacEWS):
20654
20655 2012-02-01  Beth Dakin  <bdakin@apple.com>
20656
20657         https://bugs.webkit.org/show_bug.cgi?id=77383
20658         Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
20659         -and corresponding-
20660         <rdar://problem/10709560>
20661
20662         Reviewed by Sam Weinig.
20663
20664         WebKit2's WebLoaderClient has a temporary new function that must be accounted
20665         for.
20666         * MiniBrowser/mac/BrowserWindowController.m:
20667         (-[BrowserWindowController awakeFromNib]):
20668         * WebKitTestRunner/TestController.cpp:
20669         (WTR::TestController::initialize):
20670
20671 2012-02-01  Dirk Pranke  <dpranke@chromium.org>
20672
20673         TestWebKitAPI isn't being built on chromium bots any more
20674         https://bugs.webkit.org/show_bug.cgi?id=77563
20675
20676         Reviewed by Dimitri Glazkov.
20677
20678         I accidentally dropped it in the refactoring in r105449.
20679
20680         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
20681
20682 2012-02-01  Hans Wennborg  <hans@chromium.org>
20683
20684         Rename WebSpeechInputResult::set() to assign()
20685         https://bugs.webkit.org/show_bug.cgi?id=77540
20686
20687         Reviewed by Darin Fisher.
20688
20689         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
20690         (MockWebSpeechInputController::addMockRecognitionResult):
20691         (MockWebSpeechInputController::speechTaskFired):
20692
20693 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
20694
20695         [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
20696         https://bugs.webkit.org/show_bug.cgi?id=77542
20697
20698         Reviewed by Martin Robinson.
20699
20700         * gtk/generate-gtkdoc: Check first whether there's
20701         webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
20702         instead.
20703         (get_webkit2_options): Return just the options since the
20704         pkg_config_path doesn't depend on options
20705         (get_webkit1_options): Ditto.
20706         (generate_doc): Helper function to create a generator and generate
20707         documentation for the given pkg-config file with the given options.
20708         * gtk/gtkdoc.py:
20709         (GTKDoc.__init__): Don't use ** for args parameter, since it's
20710         used as a dict and never expanded.
20711         (PkgConfigGTKDoc.__init__): Ditto.
20712
20713 2012-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
20714
20715         [GTK] API documentation is not installed even when building with --enable-gtk-doc
20716         https://bugs.webkit.org/show_bug.cgi?id=77094
20717
20718         Reviewed by Martin Robinson.
20719
20720         * GNUmakefile.am: Add install-data-local and uninstall-local rules
20721         to install/uninstall WebKit1 and WebKit2 API documentation.
20722
20723 2012-02-01  Sheriff Bot  <webkit.review.bot@gmail.com>
20724
20725         Unreviewed, rolling out r106460.
20726         http://trac.webkit.org/changeset/106460
20727         https://bugs.webkit.org/show_bug.cgi?id=77552
20728
20729         It break unit tests if WEBKIT_TESTFONTS isn't defined.
20730         (Requested by Ossy on #webkit).
20731
20732         * Scripts/webkitpy/layout_tests/port/qt.py:
20733
20734 2012-02-01  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
20735
20736         [Qt] Automatic clean build feature always do clean build with --no-webkit2
20737         https://bugs.webkit.org/show_bug.cgi?id=74519
20738
20739         Reviewed by Tor Arne Vestbø.
20740
20741         Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
20742
20743         * qmake/mkspecs/features/features.prf:
20744
20745 2012-02-01  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
20746
20747         [Qt][WK2] run-webkit-tests --qt  crashes if WEBKIT_TESTFONTS is not set
20748         https://bugs.webkit.org/show_bug.cgi?id=77466
20749
20750         Reviewed by Kenneth Rohde Christiansen.
20751
20752         Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
20753         is set or if we should raise an error.
20754
20755         * Scripts/webkitpy/layout_tests/port/qt.py:
20756         (QtPort.setup_environ_for_server):
20757
20758 2012-02-01  Philippe Normand  <pnormand@igalia.com> and Sergio Villar Senin  <svillar@igalia.com>
20759
20760         Reviewed by Martin Robinson.
20761
20762         [GTK] Improve FrameLoader signals. Resource loading
20763         https://bugs.webkit.org/show_bug.cgi?id=49543
20764
20765         Support for the new loader signals in DRT.
20766
20767         * DumpRenderTree/gtk/DumpRenderTree.cpp:
20768         (urlPath):
20769         (willSendRequestCallback):
20770         (urlSuitableForTestResult):
20771         (descriptionSuitableForTestResult):
20772         (didReceiveResponse):
20773         (didFinishLoading):
20774         (didFailLoadingWithError):
20775         (createWebView):
20776
20777 2012-02-01  Ryosuke Niwa  <rniwa@webkit.org>
20778
20779         run-perf-tests should restart DRT for each test
20780         https://bugs.webkit.org/show_bug.cgi?id=77506
20781
20782         Reviewed by Adam Barth.
20783
20784         Always restart DRT when running performance tests in order to minimize the dependency between tests.
20785
20786         * Scripts/webkitpy/layout_tests/port/chromium.py:
20787         (ChromiumDriver.stop):
20788         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20789         (PerfTestsRunner._run_tests_set):
20790         (PerfTestsRunner._run_single_test):
20791         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
20792         (create_runner):
20793         (test_run_passing_test):
20794         (test_run_silent_test):
20795         (test_run_failed_test):
20796         (test_run_tonguey_test):
20797         (test_run_timeout_test):
20798         (test_run_crash_test):
20799         (test_run_test_set_kills_drt_per_run):
20800         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
20801         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
20802         (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
20803
20804 2012-01-31  Hans Wennborg  <hans@chromium.org>
20805
20806         Speech Input: Report speech element rect relative to window rather than frame
20807         https://bugs.webkit.org/show_bug.cgi?id=76443
20808
20809         Reviewed by Darin Fisher.
20810
20811         Update LayoutTestController to allow for retrieving the speech
20812         element's position used in a request.
20813
20814         In Chromium this is handled by the MockWebSpeechInputController;
20815         adding stubs for the other implementations.
20816
20817         * DumpRenderTree/LayoutTestController.cpp:
20818         (setMockSpeechInputDumpRectCallback):
20819         (LayoutTestController::staticFunctions):
20820         * DumpRenderTree/LayoutTestController.h:
20821         (LayoutTestController):
20822         * DumpRenderTree/chromium/LayoutTestController.cpp:
20823         (LayoutTestController::LayoutTestController):
20824         (LayoutTestController::setMockSpeechInputDumpRect):
20825         * DumpRenderTree/chromium/LayoutTestController.h:
20826         (LayoutTestController):
20827         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
20828         (MockWebSpeechInputController::setDumpRect):
20829         (MockWebSpeechInputController::clearResults):
20830         (MockWebSpeechInputController::startRecognition):
20831         (MockWebSpeechInputController::MockWebSpeechInputController):
20832         (makeRectResult):
20833         (MockWebSpeechInputController::speechTaskFired):
20834         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
20835         (MockWebSpeechInputController):
20836         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
20837         (LayoutTestController::setMockSpeechInputDumpRect):
20838         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
20839         (LayoutTestController::setMockSpeechInputDumpRect):
20840         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
20841         (LayoutTestController::setMockSpeechInputDumpRect):
20842         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
20843         (LayoutTestController::setMockSpeechInputDumpRect):
20844         * DumpRenderTree/qt/LayoutTestControllerQt.h:
20845         (LayoutTestController):
20846         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
20847         (LayoutTestController::setMockSpeechInputDumpRect):
20848         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
20849         (LayoutTestController::setMockSpeechInputDumpRect):
20850
20851 2012-01-31  Ryuan Choi  <ryuan.choi@samsung.com>
20852
20853         [EFL] Add basic DRT/Efl implementation to support viewport test.
20854         https://bugs.webkit.org/show_bug.cgi?id=77320
20855
20856         Reviewed by Andreas Kling.
20857
20858         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
20859         (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
20860
20861 2012-01-31  Alexey Proskuryakov  <ap@apple.com>
20862
20863         REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
20864         https://bugs.webkit.org/show_bug.cgi?id=77473
20865         <rdar://problem/10751357>
20866
20867         Reviewed by Darin Adler.
20868
20869         * DumpRenderTree/mac/EventSendingController.mm:
20870         (-[EventSendingController keyDown:withModifiers:withLocation:]):
20871         * WebKitTestRunner/mac/EventSenderProxy.mm:
20872         (WTR::EventSenderProxy::keyDown):
20873         Added a new special keyDown value to test this.
20874
20875 2012-01-31  Dirk Pranke  <dpranke@chromium.org>
20876
20877         nrwt: fix the mock port to work with DriverProxy, reftests
20878         https://bugs.webkit.org/show_bug.cgi?id=77170
20879
20880         Reviewed by Eric Seidel.
20881
20882         The DryrunPort used for benchmarking and testing NRWT has been
20883         broken since we added the DriverProxy code. It isn't really
20884         needed any more, so I've removed it.
20885
20886         The MockDRT port was also broken by DriverProxy, and moreover,
20887         never worked w/ reftests. Since we don't exercise this module in
20888         the unit tests, the code had also bitrotted some. I have cleaned
20889         it up and made it use DriverInput and DriverOutput for
20890         consistency.
20891
20892         * Scripts/webkitpy/layout_tests/port/dryrun.py:
20893         (DryRunPort.__init__):
20894         (DryRunPort):
20895         (DryRunPort.real_name):
20896         (DryRunPort.create_driver):
20897         (DryRunPort.driver_cmd_line):
20898         (DryRunPort._driver_class):
20899         (DryrunDriver):
20900         (DryrunDriver.run_test):
20901         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
20902         (MockDRTPort.create_driver):
20903         (MockChromiumDRT.run_one_test):
20904
20905 2012-01-31  Ojan Vafai  <ojan@chromium.org>
20906
20907         run-webkit-tests calls out to webkit-build-directory twice
20908         https://bugs.webkit.org/show_bug.cgi?id=77248
20909
20910         Reviewed by Dirk Pranke.
20911
20912         * Scripts/webkit-build-directory:
20913         If called with no arguments, print out both the top-level directory and the
20914         configuration directory
20915
20916         * Scripts/webkitpy/layout_tests/port/config.py:
20917         (Config.build_directory):
20918         When called with no arguments, get and cache both the top-level and configuration directories.
20919
20920         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
20921         (main):
20922         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
20923         (ConfigTest.assert_configuration):
20924         (ConfigTest.test_build_directory.mock_webkit_build_directory):
20925         (ConfigTest.test_build_directory):
20926         (ConfigTest.test_default_configuration__notfound):
20927         * Scripts/webkitpy/layout_tests/port/webkit.py:
20928         (WebKitPort._build_path):
20929         Cache the build directory in the options object so that other users
20930         of the options object don't need to call out to webkit-build-directory.
20931         Also, properly support the existing --build-directory argument.
20932
20933 2012-01-31  Ryosuke Niwa  <rniwa@webkit.org>
20934
20935         Bump up the timeout for performance tests since DOM/DOMTable.html
20936         and Parser/html5-full-render.html are timing out on the bot.
20937
20938         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
20939         (PerfTestsRunner._parse_args):
20940
20941 2012-01-31  Ehsan Akhgari  <ehsan.akhgari@gmail.com>
20942
20943         Fix the update_webgl_conformance_tests.py script in order to enable it
20944         to detect the SCM being used correctly.
20945         https://bugs.webkit.org/show_bug.cgi?id=77462
20946
20947         Reviewed by Kenneth Russell.
20948
20949         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
20950         (default_out_dir):
20951
20952 2012-01-31  Eric Seidel  <eric@webkit.org>
20953
20954         webkit-patch apply-from-bug should work regardless of your CWD
20955         https://bugs.webkit.org/show_bug.cgi?id=77482
20956
20957         Reviewed by Adam Barth.
20958
20959         webkit-patch only ever works with patches made from the root
20960         directory.  We should pass the CWD to svn-apply in the case
20961         where we're running not from the webkit root.  I believe
20962         this used to work in the past and regressed.
20963
20964         * Scripts/webkitpy/common/checkout/checkout.py:
20965         (Checkout.apply_patch):
20966         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
20967         (CheckoutTest.test_apply_patch):
20968
20969 2012-01-31  Sheriff Bot  <webkit.review.bot@gmail.com>
20970
20971         Unreviewed, rolling out r106302.
20972         http://trac.webkit.org/changeset/106302
20973         https://bugs.webkit.org/show_bug.cgi?id=77472
20974
20975         Broke building DRT before running the tests (Requested by ojan
20976         on #webkit).
20977
20978         * Scripts/webkit-build-directory:
20979         * Scripts/webkitpy/layout_tests/port/config.py:
20980         (Config.build_directory):
20981         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
20982         (main):
20983         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
20984         (ConfigTest.assert_configuration):
20985         (ConfigTest.test_build_directory.mock_webkit_build_directory):
20986         (ConfigTest.test_build_directory):
20987         (ConfigTest.test_default_configuration__notfound):
20988         * Scripts/webkitpy/layout_tests/port/webkit.py:
20989         (WebKitPort._build_path):
20990
20991 2012-01-31  Antoine Labour  <piman@chromium.org>
20992
20993         Merge WebGraphicsContext3D creation and initialization, and move it to
20994         WebViewClient.
20995         https://bugs.webkit.org/show_bug.cgi?id=76593
20996
20997         Reviewed by Darin Fisher.
20998
20999         * DumpRenderTree/chromium/TestWebPlugin.cpp:
21000         (TestWebPlugin::TestWebPlugin):
21001         (TestWebPlugin::initialize):
21002         * DumpRenderTree/chromium/TestWebPlugin.h:
21003         * DumpRenderTree/chromium/WebViewHost.cpp:
21004         (WebViewHost::createGraphicsContext3D):
21005         (WebViewHost::createPlugin):
21006         * DumpRenderTree/chromium/WebViewHost.h:
21007
21008 2012-01-31  Gabor Rapcsanyi  <rgabor@webkit.org>
21009
21010         [GTK] build-webkit warning.
21011         https://bugs.webkit.org/show_bug.cgi?id=77411
21012
21013         Reviewed by Philippe Normand.
21014
21015         * Scripts/webkitdirs.pm:
21016         (isCrossCompilation):
21017
21018 2012-01-31  Dan Bernstein  <mitz@apple.com>
21019
21020         When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
21021
21022         Reviewed by Anders Carlsson.
21023
21024         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
21025
21026 2012-01-31  Csaba Osztrogonác  <ossy@webkit.org>
21027
21028         If the QTDIR environment variable is set, the build system fails to compile WinCairo
21029         https://bugs.webkit.org/show_bug.cgi?id=77112
21030
21031         Reviewed by Daniel Bates.
21032
21033         * Scripts/webkitdirs.pm:
21034         (determineIsQt):
21035
21036 2012-01-31  Adam Roben  <aroben@apple.com>
21037
21038         Only call -typingAttributes on WebViews, not WebHTMLViews
21039
21040         Looks like this case was just missed in r105908.
21041
21042         Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
21043
21044         Reviewed by Antti Koivisto.
21045
21046         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
21047         (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
21048         earlier.
21049
21050 2012-01-31  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
21051
21052         [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
21053         https://bugs.webkit.org/show_bug.cgi?id=77221
21054
21055         Reviewed by Kenneth Rohde Christiansen.
21056
21057         This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
21058
21059         * MiniBrowser/qt/MiniBrowserApplication.cpp:
21060         (MiniBrowserApplication::sendTouchEvent):
21061
21062 2012-01-26  Hans Wennborg  <hans@chromium.org>
21063
21064         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
21065         https://bugs.webkit.org/show_bug.cgi?id=77083
21066
21067         Reviewed by Darin Fisher.
21068
21069         Add MockWebSpeechInputController which provides a mock implementation
21070         of the WebSpeechInputController interface, and use that in
21071         DumpRenderTree.
21072
21073         * DumpRenderTree/DumpRenderTree.gypi:
21074         * DumpRenderTree/chromium/LayoutTestController.cpp:
21075         (LayoutTestController::addMockSpeechInputResult):
21076         * DumpRenderTree/chromium/LayoutTestController.h:
21077         ():
21078         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
21079         (MockWebSpeechInputController::create):
21080         (MockWebSpeechInputController::addMockRecognitionResult):
21081         (MockWebSpeechInputController::clearResults):
21082         (MockWebSpeechInputController::startRecognition):
21083         (MockWebSpeechInputController::cancelRecognition):
21084         (MockWebSpeechInputController::stopRecording):
21085         (MockWebSpeechInputController::MockWebSpeechInputController):
21086         (MockWebSpeechInputController::speechTaskFired):
21087         (MockWebSpeechInputController::SpeechTask::SpeechTask):
21088         (MockWebSpeechInputController::SpeechTask::stop):
21089         (MockWebSpeechInputController::SpeechTask::runIfValid):
21090         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
21091         (WebKit):
21092         (MockWebSpeechInputController):
21093         (MockWebSpeechInputController::taskList):
21094         (SpeechTask):
21095         * DumpRenderTree/chromium/TestShell.cpp:
21096         * DumpRenderTree/chromium/WebViewHost.cpp:
21097         (WebViewHost::speechInputController):
21098         * DumpRenderTree/chromium/WebViewHost.h:
21099         (WebKit):
21100         (WebViewHost::speechInputControllerMock):
21101         (WebViewHost):
21102         ():
21103
21104 2012-01-31  Hajime Morrita  <morrita@chromium.org>
21105
21106         [PerformanceTests] Add landing html for Dromaeo dom-query test
21107         https://bugs.webkit.org/show_bug.cgi?id=77329
21108
21109         Reviewed by Ryosuke Niwa.
21110
21111         Added some more ignorable output patterns to allow warnings
21112         from a third party test suite.
21113
21114         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
21115         (PerfTestsRunner):
21116         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
21117
21118 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
21119
21120         [wx] Unreviewed. Update download URLs to new domain.
21121
21122         * waf/build/build_utils.py:
21123         (update_wx_deps):
21124
21125 2012-01-30  Kevin Ollivier  <kevino@theolliviers.com>
21126
21127         [wx] Unreviewed. Build fix, add JavaScriptCore/tools
21128         to the list of build directories.
21129
21130         * waf/build/settings.py:
21131
21132 2012-01-30  Kentaro Hara  <haraken@chromium.org>
21133
21134         REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
21135         output an empty method name (i.e. "()")
21136         https://bugs.webkit.org/show_bug.cgi?id=77336
21137
21138         Reviewed by Darin Adler.
21139
21140         r105797 tried to detect a change outside methods, but it causes a bug that
21141         prepare-ChangeLog can output an empty method name, like this:
21142
21143             * foo/bar/baz.cpp:
21144             (method1):
21145             ():
21146             (method2):
21147
21148         This is because the cpp parser in prepare-ChangeLog cannot distinguish
21149         '{' as the beginning of a method with '{' as the beginning of an array definition
21150         at the top level.
21151
21152             int a[] = { 1, 2, 3 };  // This '{' is the beginning of an array definition.
21153
21154             void func() { // This '{' is the beginning of a method.
21155                 ...;
21156             }
21157
21158         This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
21159
21160         * Scripts/prepare-ChangeLog:
21161         (get_function_line_ranges_for_cpp): Modified as described above.
21162         (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
21163         an empty method name. Ideally this should not happen but may happen, since the
21164         parsers are not perfect.
21165         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
21166         (NameSpace7):
21167         (NameSpace8):
21168         (Class109):
21169         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
21170
21171 2012-01-30  Ojan Vafai  <ojan@chromium.org>
21172
21173         run-webkit-tests calls out to webkit-build-directory twice
21174         https://bugs.webkit.org/show_bug.cgi?id=77248
21175
21176         Reviewed by Dirk Pranke.
21177
21178         This reduces to calls to webkit-build-directory to one call and
21179         saves 500ms for run-webkit-tests over a single file.
21180
21181         * Scripts/webkit-build-directory:
21182         If called with no arguments, print out both the top-level directory and the
21183         configuration directory.
21184
21185         * Scripts/webkit-build-directory:
21186         * Scripts/webkitpy/layout_tests/port/config.py:
21187         (Config.build_directory):
21188         When called with no arguments, get and cache both the top-level and configuration directories.
21189
21190         * Scripts/webkitpy/layout_tests/port/config_standalone.py:
21191         (main):
21192         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
21193         (ConfigTest.assert_configuration):
21194         (ConfigTest.test_build_directory.mock_webkit_build_directory):
21195         (ConfigTest.test_build_directory):
21196         (ConfigTest.test_default_configuration__notfound):
21197         * Scripts/webkitpy/layout_tests/port/webkit.py:
21198         (WebKitPort._build_path):
21199         Cache the root directory in the options object so that other users
21200         of the options object don't need to call out to webkit-build-directory.
21201
21202 2012-01-30  Ojan Vafai  <ojan@chromium.org>
21203
21204         Parsing test_expecations.txt + Skipped lists takes too long
21205         https://bugs.webkit.org/show_bug.cgi?id=77059
21206
21207         Reviewed by Dirk Pranke.
21208
21209         This saves ~100ms on the Apple Mac port.
21210         -memoize a bunch of path methods.
21211         -Avoid doing multiple disk accesses per line.
21212         -Parse the skipped list directly instead of turning it into a test_expecations.txt
21213         formatting string and parsing that.
21214
21215         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
21216         (TestExpectationParser):
21217         (TestExpectationParser.expectation_for_skipped_test):
21218         (TestExpectationParser._parse_line):
21219         (TestExpectationParser._collect_matching_tests):
21220         (TestExpectations.__init__):
21221         (TestExpectations._add_skipped_tests):
21222         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
21223         (test_add_skipped_tests):
21224         (test_add_skipped_tests_duplicate):
21225         * Scripts/webkitpy/layout_tests/port/base.py:
21226         (Port):
21227         (Port.test_isfile):
21228         (Port.normalize_test_name):
21229         (Port.layout_tests_dir):
21230         (Port.abspath_for_test):
21231         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21232
21233 2012-01-30  Alexis Menard  <alexis.menard@openbossa.org>
21234
21235         Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
21236
21237         * Scripts/webkitpy/common/config/watchlist:
21238
21239 2012-01-30  Gavin Barraclough  <barraclough@apple.com>
21240
21241         Unreviewed build fix following bug#76855
21242
21243         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
21244         ():
21245         (TestWebKitAPI::TEST_F):
21246
21247 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
21248
21249         [Qt] WKTR: Use a software rendering pipiline when running tests.
21250         https://bugs.webkit.org/show_bug.cgi?id=76708
21251
21252         Reviewed by Kenneth Rohde Christiansen.
21253
21254         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
21255         (WTR::WrapperWindow::WrapperWindow):
21256         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
21257
21258 2012-01-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
21259
21260         [Qt] Store build config immediately instead of waiting for a successfull build
21261
21262         Otherwise we will not pick up changes to the config if the build is aborted,
21263         for example due to build errors or if the user pressed Ctrl+Z. We now write
21264         the new config before starting a build, but still defer to write the SVN
21265         revision once the build completes successfully.
21266
21267         Reviewed by Ossy.
21268
21269         * Scripts/webkitdirs.pm:
21270         (buildQMakeProjects):
21271
21272 2012-01-30  Alexander Færøy  <ahf@0x90.dk>
21273
21274         [Qt] Add "New Window" button to the Qt MiniBrowser
21275         https://bugs.webkit.org/show_bug.cgi?id=77281
21276
21277         Reviewed by Tor Arne Vestbø.
21278
21279         * MiniBrowser/qt/BrowserWindow.cpp:
21280         (BrowserWindow::BrowserWindow):
21281         * MiniBrowser/qt/MiniBrowser.qrc:
21282         * MiniBrowser/qt/icons/plus.png: Added.
21283         * MiniBrowser/qt/qml/BrowserWindow.qml:
21284
21285 2012-01-30  Csaba Osztrogonác  <ossy@webkit.org>
21286
21287         Unreviewed rolling out r106222.
21288
21289         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
21290         (SingleTestRunner.__init__):
21291         * Scripts/webkitpy/layout_tests/controllers/worker.py:
21292         (Worker.handle_test_list):
21293         * Scripts/webkitpy/layout_tests/models/test_input.py:
21294         (TestInput.__init__):
21295         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21296         (_set_up_derived_options):
21297         (parse_args):
21298         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
21299         (MainTest.test_repeat_each):
21300         * WebKitTestRunner/TestInvocation.cpp:
21301         (WTR::TestInvocation::setIsPixelTest):
21302
21303 2012-01-30  Hans Wennborg  <hans@chromium.org>
21304
21305         Unreviewed, rolling out r106219.
21306         http://trac.webkit.org/changeset/106219
21307         https://bugs.webkit.org/show_bug.cgi?id=77083
21308
21309         This broke Chromium's test_shell.
21310
21311         * DumpRenderTree/DumpRenderTree.gypi:
21312         * DumpRenderTree/chromium/LayoutTestController.cpp:
21313         (LayoutTestController::addMockSpeechInputResult):
21314         * DumpRenderTree/chromium/LayoutTestController.h:
21315         (WebKit):
21316         (LayoutTestController):
21317         ():
21318         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
21319         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
21320         * DumpRenderTree/chromium/TestShell.cpp:
21321         * DumpRenderTree/chromium/WebViewHost.cpp:
21322         (WebViewHost::speechInputController):
21323         * DumpRenderTree/chromium/WebViewHost.h:
21324         (WebKit):
21325         (WebViewHost::speechInputControllerMock):
21326         (WebViewHost):
21327         ():
21328
21329 2012-01-26  Hans Wennborg  <hans@chromium.org>
21330
21331         Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
21332         https://bugs.webkit.org/show_bug.cgi?id=77083
21333
21334         Reviewed by Darin Fisher.
21335
21336         Add MockWebSpeechInputController which provides a mock implementation
21337         of the WebSpeechInputController interface, and use that in
21338         DumpRenderTree.
21339
21340         * DumpRenderTree/DumpRenderTree.gypi:
21341         * DumpRenderTree/chromium/LayoutTestController.cpp:
21342         (LayoutTestController::addMockSpeechInputResult):
21343         * DumpRenderTree/chromium/LayoutTestController.h:
21344         ():
21345         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
21346         (MockWebSpeechInputController::create):
21347         (MockWebSpeechInputController::addMockRecognitionResult):
21348         (MockWebSpeechInputController::clearResults):
21349         (MockWebSpeechInputController::startRecognition):
21350         (MockWebSpeechInputController::cancelRecognition):
21351         (MockWebSpeechInputController::stopRecording):
21352         (MockWebSpeechInputController::MockWebSpeechInputController):
21353         (MockWebSpeechInputController::speechTaskFired):
21354         (MockWebSpeechInputController::SpeechTask::SpeechTask):
21355         (MockWebSpeechInputController::SpeechTask::stop):
21356         (MockWebSpeechInputController::SpeechTask::runIfValid):
21357         * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
21358         (WebKit):
21359         (MockWebSpeechInputController):
21360         (MockWebSpeechInputController::taskList):
21361         (SpeechTask):
21362         * DumpRenderTree/chromium/TestShell.cpp:
21363         * DumpRenderTree/chromium/WebViewHost.cpp:
21364         (WebViewHost::speechInputController):
21365         * DumpRenderTree/chromium/WebViewHost.h:
21366         (WebKit):
21367         (WebViewHost::speechInputControllerMock):
21368         (WebViewHost):
21369         ():
21370
21371 2012-01-29  Sheriff Bot  <webkit.review.bot@gmail.com>
21372
21373         Unreviewed, rolling out r106109.
21374         http://trac.webkit.org/changeset/106109
21375         https://bugs.webkit.org/show_bug.cgi?id=77302
21376
21377         It made tests crash (Requested by Ossy_weekend on #webkit).
21378
21379         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
21380         (WTR::WrapperWindow::WrapperWindow):
21381         (WTR::PlatformWebView::PlatformWebView):
21382
21383 2012-01-28  Nico Weber  <thakis@chromium.org>
21384
21385         [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
21386         https://bugs.webkit.org/show_bug.cgi?id=77243
21387
21388         Reviewed by Adam Barth.
21389
21390         * Scripts/update-webkit:
21391         * Scripts/webkitdirs.pm:
21392         (isChromiumNinja):
21393         (determineIsChromiumNinja):
21394         (buildChromiumNinja):
21395         (buildChromium):
21396
21397 2012-01-27  Kentaro Hara  <haraken@chromium.org>
21398
21399         The cpp parser of prepare-ChangeLog treats if(...) {} as a method
21400         https://bugs.webkit.org/show_bug.cgi?id=77241
21401
21402         Reviewed by Ryosuke Niwa.
21403
21404         The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
21405         in a method in some namespace or class is treated as a method.
21406         This patch fixes the bug.
21407
21408             class C {
21409                 void func()
21410                 {
21411                     if (1) {    // This should not be treated as a method.
21412                     }
21413                 }
21414             };
21415
21416         * Scripts/prepare-ChangeLog:
21417         (get_function_line_ranges_for_cpp):
21418         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
21419         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
21420         (Class108):
21421         (Class108::func35):
21422
21423 2012-01-27  Enrica Casucci  <enrica@apple.com>
21424
21425         Followup to http://trac.webkit.org/changeset/106171.
21426         Dan Bernstein pointed out correctly that I should
21427         have used copy instead of initWithString.
21428
21429         Reviewed by Dan Bernstein.
21430
21431         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
21432         (-[LocalPasteboard initWithName:]):
21433
21434 2012-01-27  Enrica Casucci  <enrica@apple.com>
21435
21436         DRT pasteboard object should return the correct pasteboard name.
21437         https://bugs.webkit.org/show_bug.cgi?id=77260
21438
21439         Currently the name property always returns nil.
21440         Adding a memeber variable to store the pasteboard name and return its
21441         value from the name method instead of returning nil always.
21442
21443         Reviewed by Dan Bernstein.
21444
21445         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
21446         (+[DumpRenderTreePasteboard _pasteboardWithName:]):
21447         (-[LocalPasteboard initWithName:]):
21448         (-[LocalPasteboard name]):
21449
21450 2012-01-27  Martin Robinson  <mrobinson@igalia.com>
21451
21452         [GTK] [WK2] Implement the policy client
21453         https://bugs.webkit.org/show_bug.cgi?id=76343
21454
21455         Reviewed by Gustavo Noronha Silva.
21456
21457         * gtk/generate-gtkdoc:
21458         (get_webkit2_options): Update the list of skipped source files to include all clients.
21459
21460 2012-01-27  Ada Chan  <adachan@apple.com>
21461
21462         Add test for WKBundleFrameGetParentFrame().
21463         https://bugs.webkit.org/show_bug.cgi?id=77161
21464
21465         Reviewed by Anders Carlsson.
21466
21467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
21468         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
21469         (TestWebKitAPI):
21470         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
21471         (TestWebKitAPI::setInjectedBundleClient):
21472         (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
21473         Make sure the check is successful.
21474         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
21475         (TestWebKitAPI):
21476         (ParentFrameTest):
21477         (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
21478         (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
21479         If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
21480         to the test controller.
21481         (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
21482
21483 2012-01-27  Zan Dobersek  <zandobersek@gmail.com>
21484
21485         [Gtk] DumpRenderTree lacks --no-timeout command line option
21486         https://bugs.webkit.org/show_bug.cgi?id=77196
21487
21488         Reviewed by Martin Robinson.
21489
21490         Add the --no-timeout command line option and reorganize
21491         watchdog code to make running DumpRenderTree without
21492         timeout possible.
21493
21494         * DumpRenderTree/gtk/DumpRenderTree.cpp:
21495         (setWaitToDumpWatchdog):
21496         (shouldSetWaitToDumpWatchdog):
21497         (initializeGlobalsFromCommandLineOptions):
21498         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
21499         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
21500         (waitToDumpWatchdogFired):
21501         (LayoutTestController::setWaitToDump):
21502
21503 2012-01-27  Andras Becsi  <andras.becsi@nokia.com>
21504
21505         [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
21506         https://bugs.webkit.org/show_bug.cgi?id=77122
21507
21508         Reviewed by Kenneth Rohde Christiansen.
21509
21510         * MiniBrowser/qt/MiniBrowserApplication.cpp:
21511         (MiniBrowserApplication::MiniBrowserApplication):
21512
21513 2012-01-27  Zeno Albisser  <zeno@webkit.org>
21514
21515         [Qt][Mac] Build fails after adding ICU support (r105997).
21516         https://bugs.webkit.org/show_bug.cgi?id=77118
21517
21518         Define WTF_USE_ICU_UNICODE if we are on mac.
21519
21520         Reviewed by Tor Arne Vestbø.
21521
21522         * qmake/mkspecs/features/features.prf:
21523
21524 2012-01-27  Roland Takacs  <takacs.roland@stud.u-szeged.hu>
21525
21526         Update committers.py with new contributors.
21527         https://bugs.webkit.org/show_bug.cgi?id=77207
21528
21529         I added six new contributors into committers.py:
21530
21531         - Adam Kallai
21532         - Balazs Ankes
21533         - Janos Badics
21534         - Nandor Huszka
21535         - Roland Takacs
21536         - Szilard Ledan-Muntean
21537
21538         * Scripts/webkitpy/common/config/committers.py:
21539
21540 2012-01-27  Vsevolod Vlasov  <vsevik@chromium.org>
21541
21542         Add Vsevolod Vlasov to reviewers list.
21543
21544         Reviewed by Pavel Feldman.
21545
21546         * Scripts/webkitpy/common/config/committers.py:
21547
21548 2012-01-26  No'am Rosenthal  <noam.rosenthal@nokia.com> and Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
21549
21550         [Qt] WKTR: Use a software rendering pipiline when running tests.
21551         https://bugs.webkit.org/show_bug.cgi?id=76708
21552
21553         Reviewed by Kenneth Rohde Christiansen.
21554
21555         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
21556         (WTR::WrapperWindow::WrapperWindow):
21557         (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
21558
21559 2012-01-26  Kevin Ollivier  <kevino@theolliviers.com>
21560
21561         [wx] Unreviewed. Build fix, add WebCore/testing/js
21562         to the list of source directories we build.
21563
21564         * waf/build/settings.py:
21565
21566 2012-01-26  Filip Pizlo  <fpizlo@apple.com>
21567
21568         Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
21569         https://bugs.webkit.org/show_bug.cgi?id=77177
21570
21571         Reviewed by Jon Honeycutt.
21572
21573         * Scripts/commit-log-editor:
21574
21575 2012-01-26  Ojan Vafai  <ojan@chromium.org>
21576
21577         Decrease sleep time when killing server_process on Mac.
21578         https://bugs.webkit.org/show_bug.cgi?id=77169
21579
21580         Reviewed by Eric Seidel.
21581
21582         This shaves another ~70ms off single test runtime.
21583
21584         * Scripts/webkitpy/layout_tests/port/server_process.py:
21585         (ServerProcess.stop):
21586
21587 2012-01-26  Ojan Vafai  <ojan@chromium.org>
21588
21589         Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
21590         https://bugs.webkit.org/show_bug.cgi?id=77164
21591
21592         Reviewed by Dirk Pranke.
21593
21594         http://trac.webkit.org/changeset/106035 depends on builder_name being
21595         falsey by default. There's other code that requires it to be iterable
21596         by default. So, make it be the empty string.
21597
21598         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21599         (parse_args):
21600
21601 2012-01-26  Ryosuke Niwa  <rniwa@webkit.org>
21602
21603         run-perf-test should include relative file paths in test names
21604         https://bugs.webkit.org/show_bug.cgi?id=77144
21605
21606         Reviewed by Adam Barth.
21607
21608         Include all directory names in the test name separated by "/".
21609         e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
21610
21611         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
21612         (PerfTestsRunner):
21613         (PerfTestsRunner._process_parser_test_result):
21614         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
21615         (test_run_test_set_with_json_output):
21616         (test_run_test_set_with_json_source):
21617
21618 2012-01-26  Dirk Pranke  <dpranke@chromium.org>
21619
21620         webkitpy: re-land cleanup of test scaffolding
21621         https://bugs.webkit.org/show_bug.cgi?id=77153
21622
21623         Reviewed by Eric Seidel.
21624
21625         This is an attempt to reland the change in bug 76973 /
21626         r105935. My earlier attempt to manipulate PYTHONPATH
21627         seems to only work some of the time, for reasons that
21628         elude me. Directly adding Tools/Scripts to sys.path from
21629         inside the test script appears to work (more?) reliably.
21630
21631         Also, it seemed like the files didn't actually get deleted
21632         the last time; I don't know why.
21633
21634         * Scripts/test-webkitpy:
21635         * Scripts/webkitpy/common/system/executive_unittest.py:
21636         (command_line):
21637         (ExecutiveTest):
21638         (ExecutiveTest.test_run_command_args_type):
21639         (ExecutiveTest.test_run_command_with_unicode):
21640         (ExecutiveTest.test_running_pids):
21641         (main):
21642         * Scripts/webkitpy/common/system/fileutils.py: Removed.
21643         * Scripts/webkitpy/test/cat.py: Removed.
21644         * Scripts/webkitpy/test/cat_unittest.py: Removed.
21645         * Scripts/webkitpy/test/echo.py: Removed.
21646         * Scripts/webkitpy/test/echo_unittest.py: Removed.
21647
21648 2012-01-26  Ojan Vafai  <ojan@chromium.org>
21649
21650         run-webkit-tests calls "nm" when it doesn't need to
21651         https://bugs.webkit.org/show_bug.cgi?id=77143
21652
21653         Reviewed by Dirk Pranke.
21654
21655         If we are not running any test that can be skipped by checking
21656         the DRT feature list or looking at the list of symbols, avoid calling
21657         out to DRT or calling "nm".
21658
21659         This saves ~700ms on my Mac Pro. In cases where you still have to call out
21660         to "nm" it's only a couple ms slower.
21661
21662         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
21663         (TestExpectations.__init__):
21664         * Scripts/webkitpy/layout_tests/port/base.py:
21665         (Port.skipped_tests):
21666         * Scripts/webkitpy/layout_tests/port/webkit.py:
21667         (WebKitPort._should_check_for_missing_features):
21668         (WebKitPort):
21669         (WebKitPort._should_check_for_missing_symbols):
21670         (WebKitPort._skipped_tests_for_unsupported_features):
21671         (WebKitPort.skipped_layout_tests):
21672         (WebKitPort.skipped_tests):
21673         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
21674         (WebKitPortTest.test_skipped_directories_for_symbols):
21675         (test_skipped_directories_for_features):
21676         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
21677         (test_skipped_layout_tests):
21678
21679 2012-01-26  Benjamin Poulain  <bpoulain@apple.com>
21680
21681         Support a suffix on ChangeLog filenames based on a configuration file
21682         https://bugs.webkit.org/show_bug.cgi?id=76956
21683
21684         Reviewed by Kentaro Hara.
21685
21686         Modify the tools used to generate, edit and resolve ChangeLogs to support
21687         the addition of a suffix to the ChangeLog filename.
21688
21689         This patch makes it easier to support alternate ChangeLog files in branches.
21690
21691         * Scripts/VCSUtils.pm:
21692         (changeLogSuffix):
21693         (changeLogFileName):
21694         * Scripts/commit-log-editor:
21695         * Scripts/prepare-ChangeLog:
21696         (getLatestChangeLogs):
21697         (generateNewChangeLogs):
21698         (generateFileList):
21699         * Scripts/resolve-ChangeLogs:
21700         (findChangeLog):
21701
21702 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
21703
21704         Unreviewed, rolling out r106038.
21705         http://trac.webkit.org/changeset/106038
21706         https://bugs.webkit.org/show_bug.cgi?id=77142
21707
21708         Caused a bunch of skipped tests to not be skipped. (Requested
21709         by ojan on #webkit).
21710
21711         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
21712         (TestExpectationParser):
21713         (TestExpectationParser.parse):
21714         (TestExpectationParser._parse_line):
21715         (TestExpectationParser._collect_matching_tests):
21716         (TestExpectations.__init__):
21717         (TestExpectations._add_skipped_tests):
21718         * Scripts/webkitpy/layout_tests/port/base.py:
21719         (Port.test_dirs):
21720         (Port.normalize_test_name):
21721         (Port.update_baseline):
21722         (Port.layout_tests_dir):
21723         (Port.relative_perf_test_filename):
21724         (Port.abspath_for_test):
21725
21726 2012-01-25  Ojan Vafai  <ojan@chromium.org>
21727
21728         Parsing test_expecations.txt + Skipped lists takes too long
21729         https://bugs.webkit.org/show_bug.cgi?id=77059
21730
21731         Reviewed by Dirk Pranke.
21732
21733         This saves ~100ms on the Apple Mac port.
21734         -memoize a bunch of path methods.
21735         -Avoid doing multiple disk accesses per line.
21736         -Parse the skipped list directly instead of turning it into a test_expecations.txt
21737         formatting string and parsing that.
21738
21739         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
21740         (TestExpectationParser):
21741         (TestExpectationParser.parse_skipped_tests):
21742         (TestExpectationParser._parse_line):
21743         (TestExpectationParser._collect_matching_tests):
21744         (TestExpectations.__init__):
21745         (TestExpectations._add_skipped_tests):
21746         * Scripts/webkitpy/layout_tests/port/base.py:
21747         (Port):
21748         (Port.test_isfile):
21749         (Port.normalize_test_name):
21750         (Port.layout_tests_dir):
21751         (Port.abspath_for_test):
21752
21753 2012-01-25  Ojan Vafai  <ojan@chromium.org>
21754
21755         Only store the SVN revision in the summarized results if we're on a builder
21756         https://bugs.webkit.org/show_bug.cgi?id=76976
21757
21758         Reviewed by Dirk Pranke.
21759
21760         This shaves another ~130ms off the single test run-webkit-tests runtime.
21761
21762         * Scripts/webkitpy/layout_tests/controllers/manager.py:
21763         (summarize_results):
21764         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
21765         (ResultSummaryTest.get_result):
21766         (ResultSummaryTest):
21767         (ResultSummaryTest.get_result_summary):
21768         (ResultSummaryTest.get_unexpected_results):
21769         (ResultSummaryTest.test_no_svn_revision):
21770         (ResultSummaryTest.test_svn_revision):
21771         * Scripts/webkitpy/layout_tests/port/base.py:
21772         (Port.use_trac_links_in_results_html):
21773
21774 2012-01-26  Luciano Wolf  <luciano.wolf@openbossa.org>
21775
21776         [Qt][WK2] fast/loader tests failed after r94178
21777         https://bugs.webkit.org/show_bug.cgi?id=67388
21778
21779         Reviewed by Simon Hausmann.
21780
21781         Applying the same fix used for Qt-WebKit1 from bug #67254 -
21782         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
21783         https://bugs.webkit.org/show_bug.cgi?id=67254
21784         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
21785         derived from the running location of DumpRenderTree binary.
21786
21787         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
21788         (WTR::LayoutTestController::pathToLocalResource):
21789
21790 2012-01-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
21791
21792         Implement overridePreference for boolean preferences in WebKitTestRunner
21793         https://bugs.webkit.org/show_bug.cgi?id=77033
21794
21795         Reviewed by Alexey Proskuryakov.
21796
21797         For now overridePreference supports boolean values.
21798
21799         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
21800         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
21801         (WTR::LayoutTestController::setXSSAuditorEnabled):
21802         (WTR::LayoutTestController::overridePreference):
21803         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
21804         * WebKitTestRunner/TestController.cpp:
21805         (WTR::TestController::resetStateToConsistentValues): Reset the overrides
21806         explicitly and properly disable the use of PageCache when resetting the
21807         state. Tests that use PageCache can now enable it via overridePreference.
21808
21809 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
21810
21811         [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
21812         https://bugs.webkit.org/show_bug.cgi?id=77100
21813
21814         Reviewed by Simon Hausmann.
21815
21816         This patch makes the MiniBrowser read multiple URL's from the command
21817         line such that there will be one browser window opened for each URL.
21818
21819         * MiniBrowser/qt/MiniBrowserApplication.cpp:
21820         (MiniBrowserApplication::handleUserOptions):
21821
21822 2012-01-26  Alexander Færøy  <alexander.faeroy@nokia.com>
21823
21824         [Qt] The Qt MiniBrowser crashes when given multiple URL's
21825         https://bugs.webkit.org/show_bug.cgi?id=77009
21826
21827         Reviewed by Simon Hausmann.
21828
21829         This patch fixes a crash in BrowserWindow::newWindow() where a
21830         BrowserWindow-object is constructed with a 0 pointer as the
21831         WindowOptions parameter which leads to a crash.
21832
21833         * MiniBrowser/qt/BrowserWindow.cpp:
21834         (BrowserWindow::BrowserWindow):
21835         (BrowserWindow::newWindow):
21836         * MiniBrowser/qt/BrowserWindow.h:
21837
21838 2012-01-26  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
21839
21840         [Qt] Use ICU if available
21841         https://bugs.webkit.org/show_bug.cgi?id=76821
21842
21843         Reviewed by Simon Hausmann.
21844
21845         Adding unicode defines for a Qt 5 based build.
21846
21847         * qmake/mkspecs/features/features.prf:
21848
21849 2012-01-26  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
21850
21851         [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
21852         https://bugs.webkit.org/show_bug.cgi?id=42545
21853
21854         Reviewed by Zoltan Herczeg.
21855
21856         Implement the setGeolocationPermission method.
21857
21858         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
21859         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
21860         (WTR::LayoutTestController::setGeolocationPermission):
21861         (WTR):
21862         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
21863         (LayoutTestController):
21864
21865 2012-01-26  Balazs Kelemen  <kbalazs@webkit.org>
21866
21867         [NRWT] Support --ignore-metrics
21868         https://bugs.webkit.org/show_bug.cgi?id=76278
21869
21870         Reviewed by Tony Chang.
21871
21872         Port the feature from ORWT.
21873
21874         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
21875         (SingleTestRunner._run_compare_test):
21876         * Scripts/webkitpy/layout_tests/port/driver.py:
21877         (DriverOutput):
21878         (DriverOutput.strip_metrics):
21879         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
21880         (DriverOutputTest):
21881         (DriverOutputTest.test_strip_metrics):
21882         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21883         (_set_up_derived_options):
21884         (parse_args):
21885
21886 2012-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
21887
21888         Unreviewed, rolling out r105935 and r105954.
21889         http://trac.webkit.org/changeset/105935
21890         http://trac.webkit.org/changeset/105954
21891         https://bugs.webkit.org/show_bug.cgi?id=77080
21892
21893         test-webkitpy is still broken (Requested by abarth on
21894         #webkit).
21895
21896         * Scripts/test-webkitpy:
21897         * Scripts/webkitpy/common/system/executive_unittest.py:
21898         (never_ending_command):
21899         (ExecutiveTest.test_run_command_args_type):
21900         (ExecutiveTest.test_run_command_with_unicode):
21901         (ExecutiveTest.test_running_pids):
21902         * Scripts/webkitpy/common/system/fileutils.py:
21903         (make_stdout_binary):
21904         * Scripts/webkitpy/test/cat.py:
21905         (command_arguments):
21906         (main):
21907         * Scripts/webkitpy/test/cat_unittest.py:
21908         (CatTest):
21909         (CatTest.assert_cat):
21910         (CatTest.test_basic):
21911         (CatTest.test_no_newline):
21912         (CatTest.test_unicode):
21913         (CatTest.test_as_command):
21914         * Scripts/webkitpy/test/echo.py:
21915         (command_arguments):
21916         (main):
21917         * Scripts/webkitpy/test/echo_unittest.py:
21918         (EchoTest):
21919         (EchoTest.test_basic):
21920         (EchoTest.test_no_newline):
21921         (EchoTest.test_unicode):
21922         (EchoTest.test_argument_order):
21923         (EchoTest.test_empty_arguments):
21924         (EchoTest.test_no_arguments):
21925         (EchoTest.test_as_command):
21926
21927 2012-01-26  Gabor Rapcsanyi  <rgabor@webkit.org>
21928
21929         [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
21930         https://bugs.webkit.org/show_bug.cgi?id=76138
21931
21932         Reviewed by Martin Robinson.
21933
21934         * Scripts/webkitdirs.pm:
21935         (isCrossCompilation):
21936         (buildAutotoolsProject):
21937
21938 2012-01-25  Adam Barth  <abarth@webkit.org>
21939
21940         Kentaro is a reviewer now.  Yay!
21941
21942         * Scripts/webkitpy/common/config/committers.py:
21943
21944 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
21945
21946         nrwt: running w/ no arguments fails
21947         https://bugs.webkit.org/show_bug.cgi?id=77064
21948
21949         Unreviewed, build fix.
21950
21951         This change fixes a regression introduced in r105944
21952         where running without --platform <foo> or one of the other
21953         platform switches would cause a null deref :(.
21954
21955         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21956         (main):
21957
21958 2012-01-25  Eric Seidel  <eric@webkit.org>
21959
21960         Automatically CC someone from Apple on any changes to Obj-C public API
21961         https://bugs.webkit.org/show_bug.cgi?id=77053
21962
21963         Reviewed by Timothy Hatcher.
21964
21965         This has long been de-facto practice, seems now that we have
21966         fancy watchlist support, we should just make the tools
21967         do this automatically.
21968
21969         * Scripts/webkitpy/common/config/watchlist:
21970
21971 2012-01-25  Antoine Labour  <piman@chromium.org>
21972
21973         Updating status in committers.py.
21974
21975         Unreviewed.
21976
21977         * Scripts/webkitpy/common/config/committers.py:
21978
21979 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
21980
21981         test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
21982         https://bugs.webkit.org/show_bug.cgi?id=77058
21983
21984         Reviewed by Eric Seidel.
21985
21986         r105935 broke executive_unittest by changing which script we
21987         were running and not ensuring that the PYTHONPATH was set up
21988         properly.
21989
21990         This change also fixes a regression introduced recently where
21991         test-webkitpy wasn't figuring out the path to Tools/Scripts
21992         right, either (so running ./test-webkitpy would fail).
21993
21994         * Scripts/test-webkitpy:
21995         * Scripts/webkitpy/common/system/executive_unittest.py:
21996         (script_dir):
21997         (ExecutiveTest.setUp):
21998         (ExecutiveTest):
21999         (ExecutiveTest.tearDown):
22000
22001 2012-01-25  Adam Barth  <abarth@webkit.org>
22002
22003         Disable tests on the mac-ews while we sort out hte stability issues.
22004
22005         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
22006         (MacEWS):
22007
22008 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
22009
22010         investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
22011         https://bugs.webkit.org/show_bug.cgi?id=76475
22012
22013         Reviewed by Eric Seidel.
22014
22015         This patch cleans up the internal usage of port names for the
22016         Apple mac and Apple win ports so that 'mac' and 'win are never
22017         considered "fully specified" port names: they are still legal
22018         input to the PortFactory.get() routine, but only if run on the given
22019         platform (i.e. trying to PortFactory.get('mac') on windows or
22020         linux will return an error, since we don't know which version of
22021         the port is desired.
22022
22023         This also cleans up handling of the webkit2 variants, so that
22024         the full port names consistently follow the
22025         <operating_system>-<version>[-<wk2>] convention.
22026
22027         Lastly this patch adds some assertions and removes some
22028         try/catch logic to catch more programming and usage errors;
22029         previously mac-tiger might've been allowed -- and it would've
22030         translated into using just the baselines in platform/mac -- but
22031         now it should fail.
22032
22033         * Scripts/webkitpy/layout_tests/port/apple.py:
22034         (ApplePort.determine_full_port_name):
22035         (ApplePort.__init__):
22036         (ApplePort):
22037         (ApplePort._port_name_with_version):
22038         * Scripts/webkitpy/layout_tests/port/builders.py:
22039         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
22040         (FactoryTest.test_mac):
22041         (FactoryTest.test_win):
22042         * Scripts/webkitpy/layout_tests/port/mac.py:
22043         (MacPort.baseline_search_path):
22044         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
22045         (MacTest.test_versions):
22046         * Scripts/webkitpy/layout_tests/port/win.py:
22047         (WinPort.baseline_search_path):
22048         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
22049         (WinTest.test_versions):
22050
22051 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
22052
22053         webkitpy: print nicer errors while linting expectations files, remove redundant tests
22054         https://bugs.webkit.org/show_bug.cgi?id=76955
22055
22056         Reviewed by Adam Barth.
22057
22058         This change cleans up the errors that are printed so that the
22059         are more "quickfix" compatible (path:lineno).
22060
22061         Also, there were a bunch of redundant tests between
22062         layout_tests.models.test_expectations_unittest and
22063         style.checkers.test_expectations_unittest. The latter should
22064         just expect the former to do most of the testing.
22065
22066         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
22067         (TestExpectationParser._parse_modifiers):
22068         (TestExpectations._report_errors):
22069         (TestExpectations._add_skipped_tests):
22070         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
22071         (test_parse_error_nonfatal):
22072         (SemanticTests.test_bad_bugid):
22073         * Scripts/webkitpy/style/checkers/test_expectations.py:
22074         (TestExpectationsChecker.__init__):
22075         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
22076         (TestExpectationsTestCase.assert_lines_lint):
22077         (TestExpectationsTestCase.test_valid_expectations):
22078         (TestExpectationsTestCase.test_invalid_expectations):
22079         (TestExpectationsTestCase.test_tab):
22080
22081 2012-01-25  Eric Seidel  <eric@webkit.org>
22082
22083         webkit-patch apply-* should always continue after failures
22084         https://bugs.webkit.org/show_bug.cgi?id=77057
22085
22086         Reviewed by Adam Barth.
22087
22088         As far as I can tell there is only one potential drawback to always
22089         forcing: that if you're somehow in the wrong directory it will create new
22090         directories for new files.  Since webkit-patch always cd's to the root
22091         it seems that's not a drawback.  The drawback of not using --force for
22092         svn-apply, is that it will stop after the first failure, which is rarely
22093         (if ever) the desired behavior.  This just removes the force option
22094         (which was strangely hidden behind --non-interactive).  This should
22095         make for a better user experiance.
22096
22097         * Scripts/webkitpy/common/checkout/checkout.py:
22098         (Checkout.apply_patch):
22099         * Scripts/webkitpy/common/checkout/checkout_mock.py:
22100         (MockCheckout.apply_patch):
22101         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
22102         (CheckoutTest.test_chromium_deps):
22103         (CheckoutTest):
22104         (CheckoutTest.test_apply_patch):
22105         * Scripts/webkitpy/tool/commands/download_unittest.py:
22106         (DownloadCommandsTest._default_options):
22107         * Scripts/webkitpy/tool/steps/applypatch.py:
22108         (ApplyPatch.options):
22109         (ApplyPatch.run):
22110         * Scripts/webkitpy/tool/steps/options.py:
22111         (Options):
22112
22113 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
22114
22115         nrwt: should be able to run --platform test interactively
22116         https://bugs.webkit.org/show_bug.cgi?id=76959
22117
22118         Reviewed by Adam Barth.
22119
22120         As part of refactoring the Port interfaces, in r103254 I made
22121         passing a Host object to the Port mandatory; previously TestPort
22122         objects would create their own (mock) hosts. However,
22123         new-run-webkit-tests always passed a real Host, not a MockHost,
22124         and so you couldn't run new-run-webkit-tests --platform test
22125         interactively to debug test failures.
22126
22127         This change fixes that by creating a MockHost instead of a real
22128         host if you say --platform test*.
22129
22130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
22131         (main):
22132
22133 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
22134
22135         run-webkit-tests --lint-test-files should lint all the ports by default
22136         https://bugs.webkit.org/show_bug.cgi?id=76749
22137
22138         Reviewed by Ojan Vafai.
22139
22140         Currently run-webkit-tests --lint-test-files will only lint the
22141         test_expectations for the single port determined by the command
22142         line options. This is not obvious and can produce unintended results
22143         if you want to lint the chromium port (probably the normal case
22144         for using --lint-test-files) but don't specify a port name or
22145         --chromium.
22146
22147         I think we should probably lint *all* of the ports if no port
22148         name is supplied. This change implements that, and also moves
22149         the linting logic out of the Manager class, since this really
22150         has nothing to do with Managers. It has little to do with
22151         run-webkit-tests, but splitting it into a different script would
22152         introduce compatibility issues. It might make sense to do that
22153         anyway, in a separate patch and combining that with cleaning up
22154         the style checker to share more code.
22155
22156         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22157         (Manager._strip_test_dir_prefix):
22158         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
22159         (lint):
22160         (run):
22161         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
22162         (LintTest.test_all_configurations): added.
22163         (LintTest.test_lint_test_files): added.
22164         (LintTest.test_lint_test_files__errors): added.
22165         (MainTest.test_lint_test_files): removed.
22166         (MainTest.test_lint_test_files__errors): removed.
22167
22168 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
22169
22170         webkitpy: clean up a bunch of test scaffolding
22171         https://bugs.webkit.org/show_bug.cgi?id=76973
22172
22173         Reviewed by Eric Seidel.
22174
22175         There were several helper modules in the webkitpy.test package
22176         that appear to only be used by executive_unittest.py. I am
22177         rolling them all into that file to make that clearer.
22178
22179         * Scripts/webkitpy/common/system/executive_unittest.py:
22180         (ExecutiveTest.test_run_command_args_type):
22181         (ExecutiveTest.test_run_command_with_unicode):
22182         (ExecutiveTest.test_running_pids):
22183         (command_line):
22184         (main):
22185         * Scripts/webkitpy/common/system/fileutils.py: Removed.
22186         * Scripts/webkitpy/test/cat.py: Removed.
22187         * Scripts/webkitpy/test/cat_unittest.py: Removed.
22188         * Scripts/webkitpy/test/echo.py: Removed.
22189         * Scripts/webkitpy/test/echo_unittest.py: Removed.
22190
22191 2012-01-25  Dirk Pranke  <dpranke@chromium.org>
22192
22193         webkitpy: clean up a bunch of test scaffolding
22194         https://bugs.webkit.org/show_bug.cgi?id=76973
22195
22196         Reviewed by Eric Seidel.
22197
22198         There were several helper modules in the webkitpy.test package
22199         that appear to only be used by executive_unittest.py. I am
22200         rolling them all into that file to make that clearer.
22201
22202         * Scripts/webkitpy/common/system/executive_unittest.py:
22203         (ExecutiveTest.test_run_command_args_type):
22204         (ExecutiveTest.test_run_command_with_unicode):
22205         (ExecutiveTest.test_running_pids):
22206         (command_line):
22207         (main):
22208         * Scripts/webkitpy/common/system/fileutils.py: Removed.
22209         * Scripts/webkitpy/test/cat.py: Removed.
22210         * Scripts/webkitpy/test/cat_unittest.py: Removed.
22211         * Scripts/webkitpy/test/echo.py: Removed.
22212         * Scripts/webkitpy/test/echo_unittest.py: Removed.
22213
22214 2012-01-25  Eric Seidel  <eric@webkit.org>
22215
22216         Remove Python 2.5 support from WebKit
22217         https://bugs.webkit.org/show_bug.cgi?id=71593
22218
22219         Reviewed by Adam Barth.
22220
22221         Just removing support from this one core file.
22222         I'll commit the rest of the (large) change once we've
22223         gone 24 hours and seen that no bots have exploded.
22224         We can roll out this one change if we break bots
22225         and then roll in the rest once those bots are fixed.
22226
22227         * Scripts/webkitpy/common/system/executive.py:
22228         (Executive.cpu_count):
22229
22230 2012-01-25  Hajime Morita  <morrita@google.com>
22231
22232         ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
22233         https://bugs.webkit.org/show_bug.cgi?id=76863
22234
22235         Reviewed by Dimitri Glazkov.
22236
22237         Added a feature flag.
22238
22239         * Scripts/build-webkit:
22240         * qmake/mkspecs/features/features.prf:
22241
22242 2012-01-25  Martin Robinson  <mrobinson@igalia.com>
22243
22244         [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
22245         https://bugs.webkit.org/show_bug.cgi?id=76344
22246
22247         Reviewed by Sam Weinig.
22248
22249         Add a test verifying that the mouse button during policy decisions for
22250         events not triggered by mouse events is NoButton.
22251
22252         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
22253         (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
22254         (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
22255
22256 2012-01-25  Ryosuke Niwa  <rniwa@webkit.org>
22257
22258         run-perf-tests should timeout sooner
22259         https://bugs.webkit.org/show_bug.cgi?id=77026
22260
22261         Reviewed by Adam Barth.
22262
22263         Bump off the timeout from 10 minutes to 4 minutes.
22264
22265         Also use float instead of str in test result values to compress the size of json files bots upload.
22266
22267         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
22268         (PerfTestsRunner._parse_args):
22269         (PerfTestsRunner._process_chromium_style_test_result):
22270         (PerfTestsRunner._process_parser_test_result):
22271         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
22272         (test_run_test_set_for_parser_tests):
22273         (test_run_test_set_with_json_output):
22274         (test_run_test_set_with_json_source):
22275
22276 2012-01-25  Enrica Casucci  <enrica@apple.com>
22277
22278         WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
22279         https://bugs.webkit.org/show_bug.cgi?id=76951
22280         <rdar://problem/9325158>
22281
22282         Reviewed by Alexey Proskuryakov.
22283
22284         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
22285         and WebHTMLView.
22286         (TestWebKitAPI::TEST):
22287
22288 2012-01-23  MORITA Hajime  <morrita@google.com>
22289
22290         [Refactoring][Internals] Should have InternalSettings
22291         https://bugs.webkit.org/show_bug.cgi?id=76424
22292
22293         Reviewed by Kent Tamura.
22294
22295         * GNUmakefile.am: Added so new files.
22296
22297 2012-01-25  Takashi Toyoshima  <toyoshim@chromium.org>
22298
22299         webkitpy: new-run-webkit-websocket is broken
22300         https://bugs.webkit.org/show_bug.cgi?id=76999
22301
22302         Reviewed by Dirk Pranke.
22303
22304         r105674 broke new-run-webkit-websocket, since options.chromium
22305         doesn't exist any more. new-run-webkit-httpd was also broken
22306         and already fixed at r105835.
22307         * Scripts/new-run-webkit-websocketserver:
22308         (main):
22309
22310 2012-01-25  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
22311
22312         [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
22313         https://bugs.webkit.org/show_bug.cgi?id=63458
22314
22315         Reviewed by Adam Roben.
22316
22317         Implement the setPopupBlockingEnabled method.
22318
22319         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
22320         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
22321         (WTR::LayoutTestController::setPopupBlockingEnabled):
22322         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
22323
22324 2012-01-24  Balazs Kelemen  <kbalazs@webkit.org>
22325
22326         [Qt] Cleanup testfonts handling
22327         https://bugs.webkit.org/show_bug.cgi?id=76068
22328
22329         Reviewed by Simon Hausmann.
22330
22331         Factor test font initialization into it's own file  so test
22332         font users can share the implementation by adding the file
22333         to their build.
22334         Use fonts.conf from the test font directory to not require the
22335         current directory to be the WebKit root.
22336         Fix the -use-test-fonts option of QtTestBrowser by initializing
22337         the fonts earlier, before it is too late (namely before calling
22338         show on the main window).
22339
22340         * DumpRenderTree/qt/DumpRenderTree.pro:
22341         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
22342         (WebCore::DumpRenderTree::open):
22343         * DumpRenderTree/qt/DumpRenderTreeQt.h:
22344         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
22345         (WebKit::initializeTestFonts):
22346         * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
22347         * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
22348         we will use the one from the test fonts directory.
22349         * DumpRenderTree/qt/main.cpp:
22350         (main): Fix the ifdefs to make it clear that the code to
22351         set up the Dpi has not been ported to Qt5 yet.
22352         * QtTestBrowser/QtTestBrowser.pro:
22353         * QtTestBrowser/launcherwindow.h:
22354         (WindowOptions::WindowOptions):
22355         * QtTestBrowser/main.cpp:
22356         (launcherMain):
22357         (LauncherApplication::handleUserOptions):
22358         * WebKitTestRunner/InjectedBundle/Target.pri:
22359         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
22360         (WTR::activateFonts): Remove the code to set up the Dpi
22361         because it does not work with Qt5.
22362
22363 2012-01-25  Simon Hausmann  <simon.hausmann@nokia.com>
22364
22365         [Qt] build-webkit --qt requires a git-svn or SVN checkout.
22366
22367         Reviewed by Tor Arne Vestø.
22368
22369         Don't require it by making svnRevisionForDirectory return "unknown"
22370         instead of bailing out with an error.
22371
22372         * Scripts/VCSUtils.pm:
22373         (svnRevisionForDirectory):
22374
22375 2012-01-25  Adam Barth  <abarth@webkit.org>
22376
22377         Temporarily disable running the unit tests on the Chromium EWS.  These
22378         tests don't work properly (see
22379         https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
22380         blocking the EWS.
22381
22382         * Scripts/webkitpy/common/config/ports.py:
22383         (ChromiumPort):
22384
22385 2012-01-25  Adam Barth  <abarth@webkit.org>
22386
22387         Update results.html version of PixelZoomer
22388         https://bugs.webkit.org/show_bug.cgi?id=76965
22389
22390         Reviewed by Ojan Vafai.
22391
22392         Improve readability as suggested by Ojan.
22393
22394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
22395
22396 2012-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
22397
22398         [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
22399         https://bugs.webkit.org/show_bug.cgi?id=76899
22400
22401         Reviewed by Martin Robinson.
22402
22403         * gtk/generate-gtkdoc:
22404         (get_webkit2_options): WebKitWebLoaderClient has been renamed to
22405         WebKitLoaderClient.
22406
22407 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
22408
22409         Build fix. Trigger Chromium Mac Release (Perf) on new commits.
22410
22411         * BuildSlaveSupport/build.webkit.org-config/config.json:
22412
22413 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
22414
22415         WebKit needs public performance tests running on public bots
22416         https://bugs.webkit.org/show_bug.cgi?id=10266
22417
22418         Reviewed by Adam Barth.
22419
22420         Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
22421         and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
22422
22423         * BuildSlaveSupport/build.webkit.org-config/config.json:
22424         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22425         (RunAndUploadPerfTests):
22426         (RunAndUploadPerfTests.start):
22427         (UploadPerfTestResults):
22428         (BuildAndPerfTestFactory):
22429         (BuildAndPerfTestFactory.__init__):
22430
22431 2012-01-24  Ojan Vafai  <ojan@chromium.org>
22432
22433         Initializing the browser property of the Bugzilla class takes too long
22434         https://bugs.webkit.org/show_bug.cgi?id=76960
22435
22436         Reviewed by Adam Barth.
22437
22438         Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
22439         on my Mac Pro.
22440
22441         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
22442         (Bugzilla.__init__):
22443         (Bugzilla._get_browser):
22444         (Bugzilla):
22445         (Bugzilla._set_browser):
22446
22447 2012-01-24  Mark Rowe  <mrowe@apple.com>
22448
22449         Death to JavaScriptGlue.
22450
22451         Rubber-stamped by Geoffrey Garen.
22452
22453         * BuildSlaveSupport/build-launcher-app:
22454         (copyNightlyLauncher):
22455         * Scripts/build-webkit:
22456         * Scripts/do-file-rename:
22457         * Scripts/do-webcore-rename:
22458         * Scripts/webkitpy/common/config/build.py:
22459         (_should_file_trigger_build):
22460         * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
22461         path in conjunction with a cross-platform path.
22462         (ShouldBuildTest):
22463
22464 2012-01-24  Kentaro Hara  <haraken@chromium.org>
22465
22466         webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
22467         https://bugs.webkit.org/show_bug.cgi?id=75836
22468
22469         Reviewed by David Kilzer.
22470
22471         Previously parser_unittests.pl can just test the returned value of
22472         get_function_line_ranges() in prepare-ChangeLog. This patch fixes
22473         parser_unittests.pl so that it also tests the stdout and stderr of
22474         get_function_line_ranges().
22475
22476         This patch adds css_unittests_warning.css, which contains test cases
22477         for warning messages of the CSS parser of prepare-ChangeLog.
22478
22479         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
22480         (captureOutput): Captures the stdout and stderr of a given method.
22481         (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
22482         string to relative paths.
22483
22484         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
22485         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
22486         (element1):
22487         (element2):
22488         (element3):
22489         (element4):
22490         ():
22491         (element5):
22492         (element6):
22493
22494         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
22495         Just updated the test results, i.e. added stdout and stderr results.
22496         No essential changes in the test results.
22497         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
22498         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
22499         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
22500         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
22501         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
22502
22503 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
22504
22505         webkitpy: new-run-webkit-httpd is broken
22506         https://bugs.webkit.org/show_bug.cgi?id=76963
22507
22508         Reviewed by Adam Barth.
22509
22510         r105674 broke new-run-webkit-httpd, since options.chromium
22511         doesn't exist any more. We didn't catch this because we don't
22512         run the integration tests by default anywhere :(.
22513
22514         * Scripts/new-run-webkit-httpd:
22515         (run):
22516         (main):
22517
22518 2012-01-24  Adam Barth  <abarth@webkit.org>
22519
22520         garden-o-matic pixel zoomer should let you look at every pixel of the image
22521         https://bugs.webkit.org/show_bug.cgi?id=76962
22522
22523         Reviewed by Ojan Vafai.
22524
22525         Previously, you couldn't get up to the right and bottom pixels.
22526
22527         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
22528
22529 2012-01-24  Enrica Casucci  <enrica@apple.com>
22530
22531         WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
22532         https://bugs.webkit.org/show_bug.cgi?id=76951
22533         <rdar://problem/9325158>
22534
22535         Added test to verify that WebHTMLView supports the typingAttributes method and that it
22536         works as expected.
22537
22538         Reviewed by Alexey Proskuryakov.
22539
22540         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
22541         (TestWebKitAPI::TEST):
22542
22543 2012-01-24  James Robinson  <jamesr@chromium.org>
22544
22545         Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
22546         https://bugs.webkit.org/show_bug.cgi?id=76884
22547
22548         Reviewed by Adam Barth.
22549
22550         * Scripts/webkitpy/tool/bot/irc_command.py:
22551         (Rollout.execute):
22552         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
22553         (SheriffIRCBotTest.test_rollout):
22554         (SheriffIRCBotTest.test_revert):
22555         (SheriffIRCBotTest.test_multi_rollout):
22556         (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
22557         (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
22558         (SheriffIRCBotTest.test_rollout_invalidate_reason):
22559         (test_multi_rollout_invalidate_reason):
22560
22561 2012-01-24  Kentaro Hara  <haraken@chromium.org>
22562
22563         The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
22564         https://bugs.webkit.org/show_bug.cgi?id=75531
22565
22566         Reviewed by David Kilzer.
22567
22568         Previously, the cpp parser of prepare-ChangeLog could not detect a change
22569         outside methods. Consider the following cpp file.
22570
22571             namespace N {
22572             int a;     // this change does not appear on ChangeLog.
22573             class C {
22574                 int b;     // this change does not appear on ChangeLog.
22575                 void f()
22576                 {
22577                     int c;     // this change appears on ChangeLog.
22578                 }
22579                 int d;     // this change does not appear on ChangeLog.
22580             };
22581             int e;     // this change does not appear on ChangeLog.
22582             };
22583
22584         The previous prepare-ChangeLog outputs just methods in which a change is found:
22585             (N::C::f):
22586
22587         This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
22588         and methods in which a change is found:
22589             (N):
22590             (N::C):
22591             (N::C::f):
22592
22593         * Scripts/prepare-ChangeLog:
22594         (get_function_line_ranges_for_cpp): Modified as described above.
22595
22596         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
22597         (Class104):
22598         (Class105):
22599         (Class106):
22600         (Class106::func32):
22601         (Class106::func33):
22602         (NameSpace3):
22603         (NameSpace4):
22604         (NameSpace5):
22605         (NameSpace6):
22606         (Class107):
22607         (NameSpace5::NameSpace6::Class107::func34):
22608         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
22609
22610 2012-01-24  Kentaro Hara  <haraken@chromium.org>
22611
22612         prepare-ChangeLog outputs warnings for top-level { ... } blocks
22613         https://bugs.webkit.org/show_bug.cgi?id=75943
22614
22615         Reviewed by David Kilzer.
22616
22617         Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
22618         because it does not distinguish '}' at the end of a subroutine
22619         with '}' at the end of a if or for statement.
22620
22621         foo.pl:
22622             if (1) {
22623             }
22624             for (@v) {
22625             }
22626
22627         output:
22628             nested functions found at top-level at foo.pl:2
22629             nested functions found at top-level at foo.pl:4
22630
22631         This patch fixes the bug.
22632
22633         * Scripts/prepare-ChangeLog:
22634         (get_function_line_ranges_for_perl):
22635         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
22636         Added test cases. No change in the test results.
22637
22638 2012-01-24  Dirk Pranke  <dpranke@chromium.org>
22639
22640         r105674 broke check-webkit-style for chromium's test_expectations.
22641
22642         Unreviewed, build fix.
22643
22644         We now need to pass in a platform name of 'chromium' if we want
22645         the chromium port; options.chromium is no longer recognized. I
22646         will follow this patch up with a separate patch that has a test,
22647         but this at least fixes the build.
22648
22649         * Scripts/webkitpy/style/checkers/test_expectations.py:
22650         (TestExpectationsChecker._determine_port_from_exepectations_path):
22651
22652 2012-01-20  Ojan Vafai  <ojan@chromium.org>
22653
22654         check-webkit-style of the chromium test_expectations.txt file takes too long
22655         https://bugs.webkit.org/show_bug.cgi?id=76745
22656
22657         Reviewed by Dimitri Glazkov.
22658
22659         When in lint mode, have TestExpectations test all configurations instead
22660         of looping over each configuration. This also has the benefit of making
22661         the error output considerably more concise.
22662
22663         Also, got rid of the double-printing of errors when linting through check-webkit-style.
22664
22665         * Scripts/webkitpy/layout_tests/controllers/manager.py:
22666         (Manager.lint):
22667         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
22668         (TestExpectations._report_errors):
22669         (TestExpectations._add_expectations):
22670         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
22671         (test_parse_error_nonfatal):
22672         (test_error_on_different_platform):
22673         * Scripts/webkitpy/style/checkers/test_expectations.py:
22674         (TestExpectationsChecker.check_test_expectations):
22675         (TestExpectationsChecker.check):
22676         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
22677         (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
22678         (TestExpectationsTestCase.assert_lines_lint):
22679
22680 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
22681
22682         Another build fix attempt after r105543.
22683
22684         * Scripts/webkitpy/common/net/file_uploader.py:
22685         (FileUploader.upload_as_multipart_form_data):
22686
22687 2012-01-24  Ryosuke Niwa  <rniwa@webkit.org>
22688
22689         Build fix attempt after r105543.
22690
22691         * Scripts/webkitpy/common/net/file_uploader.py:
22692         (FileUploader.upload_as_multipart_form_data):
22693
22694 2012-01-24  Vincent Scheib  <scheib@chromium.org>
22695
22696         [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
22697         https://bugs.webkit.org/show_bug.cgi?id=76411
22698
22699         Reviewed by Adam Barth.
22700
22701         Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
22702         into a series of patches, this change adds a trivial
22703         pointer lock implementation to the Chromium port's DumpRenderTree
22704         and exposes LayoutTestController hooks to force failure conditions.
22705
22706         * DumpRenderTree/chromium/LayoutTestController.cpp:
22707         (LayoutTestController::LayoutTestController):
22708         (LayoutTestController::didLosePointerLock):
22709         (LayoutTestController::setPointerLockWillFailAsynchronously):
22710         (LayoutTestController::setPointerLockWillFailSynchronously):
22711         * DumpRenderTree/chromium/LayoutTestController.h:
22712         * DumpRenderTree/chromium/WebViewHost.cpp:
22713         (WebViewHost::requestPointerLock):
22714         (WebViewHost::requestPointerUnlock):
22715         (WebViewHost::isPointerLocked):
22716         (WebViewHost::didCompletePointerLock):
22717         (WebViewHost::didNotCompletePointerLock):
22718         (WebViewHost::didLosePointerLock):
22719         (WebViewHost::reset):
22720         * DumpRenderTree/chromium/WebViewHost.h:
22721         (WebViewHost::setPointerLockWillFailAsynchronously):
22722         (WebViewHost::setPointerLockWillFailSynchronously):
22723
22724 2012-01-24  Mario Sanchez Prada  <msanchez@igalia.com>
22725
22726         Unreviewed, skip WK2 API test timing out on some GTK bots.
22727
22728         WebKit2APITests/TestDownloads is consistently timing out on the
22729         32bit release and 64bit debug bots.
22730
22731         * Scripts/run-gtk-tests:
22732         (TestRunner): Skip WebKit2APITests/TestDownloads.
22733
22734 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
22735
22736         [Qt] Fix the build with the newes Qt5 hashes
22737         https://bugs.webkit.org/show_bug.cgi?id=76657
22738
22739         Reviewed by Simon Hausmann.
22740
22741         * MiniBrowser/qt/MiniBrowserApplication.cpp:
22742         (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
22743         for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
22744
22745 2012-01-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
22746
22747         [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
22748
22749         We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
22750         building with MinGW inside cmd.exe will require the same construct. Instead
22751         we assume that when the first character in PWD is a '/' we're running under
22752         Cygwin, and use the normal unix way of setting environment variables.
22753
22754         Reviewed by Simon Hausmann.
22755
22756         * qmake/mkspecs/features/default_pre.prf:
22757
22758 2012-01-24  Simon Hausmann  <simon.hausmann@nokia.com>
22759
22760         Some qmake build files must include Qt5's "quick" module.
22761         https://bugs.webkit.org/show_bug.cgi?id=76671
22762
22763         Unreviewed build fix.
22764
22765         * MiniBrowser/qt/MiniBrowser.pro:
22766         * WebKitTestRunner/Target.pri:
22767
22768 2012-01-24  Andras Becsi  <andras.becsi@nokia.com>
22769
22770         [Qt] Fix the event timestamps for touch mocking
22771
22772         Reviewed by Simon Hausmann.
22773
22774         * MiniBrowser/qt/MiniBrowserApplication.cpp:
22775         (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
22776         timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
22777
22778 2012-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
22779
22780         [GTK] Implement DownloadClient in WebKit2 GTK+ API
22781         https://bugs.webkit.org/show_bug.cgi?id=72952
22782
22783         Reviewed by Martin Robinson.
22784
22785         * gtk/generate-gtkdoc:
22786         (get_webkit2_options): Ignore WebKitDownloadClient.
22787
22788 2012-01-23  Zan Dobersek  <zandobersek@gmail.com>
22789
22790         [GTK] editing/deleting/5408255.html results are incorrect
22791         https://bugs.webkit.org/show_bug.cgi?id=53644
22792
22793         Reviewed by Martin Robinson.
22794
22795         WEBKIT_TOP_LEVEL environment variable is now set directly in either
22796         WebKitTestRunner or DumpRenderTree through usage of a compilation-time
22797         macro. This way both tools can be run outside the test harness without
22798         the need to manually set the environment variable.
22799
22800         * DumpRenderTree/gtk/DumpRenderTree.cpp:
22801         (getTopLevelPath):
22802         * GNUmakefile.am:
22803         * Scripts/webkitpy/layout_tests/port/gtk.py:
22804         (GtkPort.setup_environ_for_server):
22805         * WebKitTestRunner/GNUmakefile.am:
22806         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
22807         (WTR::InjectedBundle::platformInitialize):
22808
22809 2012-01-23  Dmitry Lomov  <dslomov@google.com>
22810
22811         [Chromium] Implement layoutTestController.workerThreadCount in DRT
22812         https://bugs.webkit.org/show_bug.cgi?id=74653.
22813
22814         Reviewed by Darin Fisher.
22815
22816         * DumpRenderTree/chromium/LayoutTestController.cpp:
22817         (LayoutTestController::LayoutTestController):
22818         (LayoutTestController::workerThreadCount):
22819         * DumpRenderTree/chromium/LayoutTestController.h:
22820
22821 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
22822
22823         nrwt: make --chromium work like --qt
22824         https://bugs.webkit.org/show_bug.cgi?id=76875
22825
22826         Reviewed by Adam Barth.
22827
22828         --chromium used to have to be handled differently from --qt
22829         due to the way the PortFactory was implemented; there's not
22830         really a good reason for that any more so this patch makes
22831         things slightly more consistent and eliminates the
22832         options.chromium flag (--chromium is now truly a synonym for
22833         --platform chromium).
22834
22835         * Scripts/webkitpy/layout_tests/port/factory.py:
22836         (PortFactory._default_port):
22837         (PortFactory.get):
22838         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
22839         (FactoryTest.setUp):
22840         (FactoryTest.test_chromium_mac):
22841         (FactoryTest.test_chromium_linux):
22842         (FactoryTest.test_chromium_win):
22843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
22844         (parse_args):
22845
22846 2012-01-23  Dirk Pranke  <dpranke@chromium.org>
22847
22848         run-webkit-tests needs to propagate --chromium
22849         https://bugs.webkit.org/show_bug.cgi?id=76870
22850
22851         Reviewed by Eric Seidel.
22852
22853         run-webkit-tests removes '--chromium' argument from @ARGV when
22854         determining which port to run, which means that that doesn't
22855         propagate to new-run-webkit-tests. That's bad (and is handled
22856         for the other ports by re-adding the flag, but apparently we're
22857         just now noticing for Chromium).
22858
22859         * Scripts/run-webkit-tests:
22860
22861 2012-01-23  Brian Weinstein  <bweinstein@apple.com>
22862
22863         More build fixing after r105646.
22864
22865         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
22866         (TestWebKitAPI::TestNode::key):
22867
22868 2012-01-23  Gavin Barraclough  <barraclough@apple.com>
22869
22870         Unreviewed build fix - r105646 broke this.
22871
22872         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
22873         (TestWebKitAPI::TestNode::TestNode):
22874         (TestWebKitAPI::TestNode::key):
22875         (TestWebKitAPI::RedBlackTreeTest::assertEqual):
22876         (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
22877         (TestWebKitAPI::RedBlackTreeTest::testDriver):
22878
22879 2012-01-23  Sheriff Bot  <webkit.review.bot@gmail.com>
22880
22881         Unreviewed, rolling out r105658.
22882         http://trac.webkit.org/changeset/105658
22883         https://bugs.webkit.org/show_bug.cgi?id=76883
22884
22885         We want this eventually, but not right at this moment
22886         (Requested by abarth on #webkit).
22887
22888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
22889
22890 2012-01-23  Adam Barth  <abarth@webkit.org>
22891
22892         garden-o-matic should support Chromium Mac Lion
22893         https://bugs.webkit.org/show_bug.cgi?id=76880
22894
22895         Reviewed by Eric Seidel.
22896
22897         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
22898
22899 2012-01-23  Emil A Eklund  <eae@chromium.org>
22900
22901         check-webkit-style whitespace/operators triggers on overloaded division operator
22902         https://bugs.webkit.org/show_bug.cgi?id=76650
22903
22904         Reviewed by Darin Adler.
22905
22906         * Scripts/webkitpy/style/checkers/cpp.py:
22907         (check_spacing):
22908         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
22909         (CppStyleTest.test_operator_methods):
22910
22911 2012-01-23  Ryosuke Niwa  <rniwa@webkit.org>
22912
22913         run-perf-tests should report server-side errors
22914         https://bugs.webkit.org/show_bug.cgi?id=76802
22915
22916         Reviewed by Tony Chang.
22917
22918         Report errors whenever server's response doesn't match "OK".
22919
22920         * Scripts/webkitpy/common/net/file_uploader.py:
22921         (FileUploader.upload_single_text_file):
22922         (FileUploader.upload_as_multipart_form_data):
22923         (FileUploader._upload_data.callback):
22924         (FileUploader):
22925         (FileUploader._upload_data):
22926         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
22927         (PerfTestsRunner._upload_json):
22928         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
22929         (test_upload_json):
22930         (test_upload_json.MockFileUploader.upload_single_text_file):
22931
22932 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
22933
22934         run-perf-tests ignore Skipped list on chromium
22935         https://bugs.webkit.org/show_bug.cgi?id=76764
22936
22937         Reviewed by Dirk Pranke.
22938
22939         Move skipped_perf_tests from WebKit port to Base port so that Chromium port
22940         can also find skipped list. Chromium port only uses test_expectations.txt for
22941         layout tests but performacne tests don't use test_expectations.txt so Chromium port
22942         also needs to use Skipped list.
22943
22944         * Scripts/webkitpy/layout_tests/port/base.py:
22945         (Port._tests_from_skipped_file_contents):
22946         (Port):
22947         (Port._expectations_from_skipped_files):
22948         (Port.skipped_perf_tests):
22949         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
22950         (PortTest.test_skipped_perf_tests):
22951         (PortTest.test_skipped_perf_tests.add_text_file):
22952         * Scripts/webkitpy/layout_tests/port/webkit.py:
22953         (WebKitPort._skipped_tests_for_unsupported_features):
22954         (WebKitPort._skipped_file_search_paths):
22955         (WebKitPort.skipped_layout_tests):
22956
22957 2012-01-23  Andy Estes  <aestes@apple.com>
22958
22959         Fix the build after r105635.
22960
22961         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
22962         (TestWebKitAPI::TEST):
22963
22964 2012-01-23  Xianzhu Wang  <wangxianzhu@chromium.org>
22965
22966         Basic enhancements to StringBuilder
22967         https://bugs.webkit.org/show_bug.cgi?id=67081
22968
22969         Reviewed by Darin Adler.
22970
22971         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
22972         (TestWebKitAPI::TEST):
22973
22974 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
22975
22976         [GTK] run-gtk-tests randomly fails while running the xprop comand
22977         https://bugs.webkit.org/show_bug.cgi?id=76817
22978
22979         Reviewed by Gustavo Noronha Silva.
22980
22981         No need to use xprop to remove the AT_SPI_BUS property since
22982         run-gtk-tests will always run new instances of Xvfb.
22983
22984         * Scripts/run-gtk-tests:
22985         (TestRunner): Unskip TestWebKitAccessibility.
22986         (TestRunner.run): Uncomment lines for launching the accessibility
22987         bus and registry daemon, and remove lines for running xprop.
22988
22989 2012-01-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
22990
22991         [Qt] Don't warn about override and final being C++11 extensions
22992
22993         Clang will emit a warning when these extensions are used without passing
22994         --std=c++11, but we use feature checking to decide if we have the right
22995         extensions, so we can safely ignore these warnings. The XCode and Windows
22996         project files have the same workaround.
22997
22998         The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
22999         we only have one extra compiler for Objective-C, which is also used for
23000         Objective-C++ sources, so we have to pass the flag, even if it doesn't
23001         make sense for Objective-C.
23002
23003         Reviewed by Simon Hausmann.
23004
23005         * qmake/mkspecs/features/unix/default_post.prf:
23006
23007 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23008
23009         [Qt] Change how build-webkit decides when to do full incremental builds
23010
23011         Instead of relying on update-webkit (which isn't run on the bots) to
23012         decide when to do a full incremental build (make qmake), we let the
23013         build-webkit script itself check the current SVN revision against the
23014         previous build (by storing it in .webkit.config).
23015
23016         If the two differ we assume a full incremental build is needed, since
23017         the new revisions might have introduced problematic things like new
23018         Q_OBJECT macros. If not, we assume the developer is doing changes
23019         locally, and revert to doing a plain 'make'.
23020
23021         In addition, when the build fails in the latter case, we inform the
23022         developer of possible pitfalls and how to manually run 'make qmake'.
23023
23024         Reviewed by Ossy.
23025
23026         * Scripts/update-webkit:
23027         * Scripts/webkitdirs.pm:
23028         (buildQMakeProjects):
23029
23030 2012-01-23  Mario Sanchez Prada  <msanchez@igalia.com>
23031
23032         [GTK] run-gtk-tests randomly fails while running the xprop comand
23033         https://bugs.webkit.org/show_bug.cgi?id=76817
23034
23035         Reviewed by Philippe Normand.
23036
23037         Temporarily comment the lines related to launching the ATSPI bus
23038         and registry daemon, which are making the bots to fail randomly.
23039
23040         * Scripts/run-gtk-tests:
23041         (TestRunner): Skip TestWebKitAccessibility, as it won't run
23042         properly if the ATSPI infrastructure is not properly initialized.
23043         (TestRunner.run): Comment lines related to initialization of ATSPI.
23044
23045 2012-01-22  Ryosuke Niwa  <rniwa@webkit.org>
23046
23047         Windows python test build fix.
23048
23049         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23050         (PerfTestsRunner.__init__):
23051
23052 2012-01-22  Sergio Villar Senin  <svillar@igalia.com>
23053
23054         [GTK] DumpRenderTree converts "file:///" to a path differently
23055         https://bugs.webkit.org/show_bug.cgi?id=76631
23056
23057         Reviewed by Martin Robinson.
23058
23059         DumpRenderTree should print "/" as the last path component if the
23060         path is a lone slash instead of empty output.
23061
23062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
23063         (webViewConsoleMessage):
23064
23065 2012-01-20  David Levin  <levin@chromium.org>
23066
23067         The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
23068         https://bugs.webkit.org/show_bug.cgi?id=76752
23069
23070         Reviewed by Eric Seidel.
23071
23072         * Scripts/webkitpy/style/checkers/cpp.py:
23073         (check_for_leaky_patterns):
23074         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
23075         (LeakyPatternTest.test_create_dc):
23076         (LeakyPatternTest.test_create_compatible_dc):
23077
23078 2012-01-20  Shawn Singh  <shawnsingh@chromium.org>
23079
23080         Changed my status in commiters.py
23081
23082         Unreviewed.
23083
23084         * Scripts/webkitpy/common/config/committers.py:
23085
23086 2012-01-20  Ojan Vafai  <ojan@chromium.org>
23087
23088         run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
23089         https://bugs.webkit.org/show_bug.cgi?id=76748
23090
23091         Reviewed by Ryosuke Niwa.
23092
23093         It crawls the whole subtree and then doesn't use the data. Cutting this out
23094         saves 4 seconds warm and 17 seconds cold on my Mac Pro.
23095
23096         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
23097         (run):
23098
23099 2012-01-20  Adam Barth  <abarth@webkit.org>
23100
23101         Another tiny tweak to the garden-o-matic CSS.  This makes things line
23102         up slightly nicer when there aren't any failures.
23103
23104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
23105         (#summary):
23106
23107 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
23108
23109         run-perf-tests should support --test-results-server option
23110         https://bugs.webkit.org/show_bug.cgi?id=76680
23111
23112         Reviewed by Adam Barth.
23113
23114         Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
23115         to be used by perf bots. Also refactor file_uploader as needed.
23116
23117         * Scripts/webkitpy/common/net/file_uploader.py:
23118         (FileUploader.__init__):
23119         (FileUploader.upload_single_file):
23120         (FileUploader.upload_as_multipart_form_data):
23121         (FileUploader):
23122         (FileUploader._upload_data):
23123         (FileUploader._upload_data.callback):
23124         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
23125         (JSONResultsGeneratorBase.upload_json_files):
23126         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23127         (PerfTestsRunner):
23128         (PerfTestsRunner._parse_args):
23129         (PerfTestsRunner.run):
23130         (PerfTestsRunner._generate_json):
23131         (PerfTestsRunner._upload_json):
23132         (PerfTestsRunner._run_tests_set):
23133         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
23134         (create_runner):
23135         (test_run_with_upload_json):
23136         (test_run_with_upload_json.mock_upload_json):
23137         (test_upload_json):
23138         (test_upload_json.MockFileUploader):
23139         (test_upload_json.MockFileUploader.__init__):
23140         (test_upload_json.MockFileUploader.upload_single_file):
23141         (test_parse_args):
23142
23143 2012-01-20  Adam Barth  <abarth@webkit.org>
23144
23145         The party time image overlaps real content!  This patch makes the
23146         image centered vertically.
23147
23148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
23149         (#onebar.partytime #summary):
23150
23151 2012-01-19  Ojan Vafai  <ojan@chromium.org>
23152
23153         Refactor TestExpectationsParser in preparation for caching the results
23154         https://bugs.webkit.org/show_bug.cgi?id=76669
23155
23156         Reviewed by Dimitri Glazkov.
23157
23158         Make everything private expect for the parse method.
23159         Eventually, we'll need the expectations lines to not be modified
23160         outside of TestExpectationsParser so we can cache the results.
23161         This makes check-webkit-style of the chromium test_expectations.txt file
23162         go from ~17 seconds to ~12 seconds on my Mac Pro.
23163
23164         This patch is just a refactor in preparation, so no new tests.
23165
23166         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
23167         (TestExpectationEditorTests.make_parsed_expectation_lines):
23168         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
23169         (TestExpectationParser.parse):
23170         (TestExpectationParser):
23171         (TestExpectationParser._parse_line):
23172         (TestExpectationParser._tokenize):
23173         (TestExpectationParser._tokenize_list):
23174         (TestExpectationsModel._clear_expectations_for_test):
23175         (TestExpectations.__init__):
23176         (TestExpectations._add_expectations):
23177         (TestExpectations._add_skipped_tests):
23178         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
23179         (TestExpectationParserTests.test_tokenize_blank):
23180         (TestExpectationParserTests.test_tokenize_missing_colon):
23181         (TestExpectationParserTests.test_tokenize_extra_colon):
23182         (TestExpectationParserTests.test_tokenize_empty_comment):
23183         (TestExpectationParserTests.test_tokenize_comment):
23184         (TestExpectationParserTests.test_tokenize_missing_equal):
23185         (TestExpectationParserTests.test_tokenize_extra_equal):
23186         (TestExpectationParserTests.test_tokenize_valid):
23187         (TestExpectationParserTests.test_tokenize_valid_with_comment):
23188         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
23189         (TestExpectationParserTests.test_parse_empty_string):
23190         (TestExpectationSerializerTests.assert_round_trip):
23191         (TestExpectationSerializerTests.assert_list_round_trip):
23192         * Scripts/webkitpy/tool/commands/expectations.py:
23193         (OptimizeExpectations.execute):
23194         * Scripts/webkitpy/tool/servers/gardeningserver.py:
23195         (GardeningExpectationsUpdater.update_expectations):
23196
23197 2012-01-20  Adam Barth  <abarth@webkit.org>
23198
23199         Follow-up to previous patch: don't produce NaN when the revision number
23200         is missing.
23201
23202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
23203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
23204
23205 2012-01-20  Adam Barth  <abarth@webkit.org>
23206
23207         Garden-o-matic should tell me which revisions have been checked by all the bots
23208         https://bugs.webkit.org/show_bug.cgi?id=76722
23209
23210         Reviewed by Dimitri Glazkov.
23211
23212         This information helps me know when it's safe for me to roll a
23213         candidate revision.
23214
23215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
23216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
23217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
23218
23219 2012-01-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23220
23221         build-webkit: Don't spit out congratulations message on Ctrl+C
23222
23223         Reviewed by Andreas Kling.
23224
23225         * Scripts/build-webkit:
23226
23227 2012-01-20  Philippe Normand  <pnormand@igalia.com>
23228
23229         [GTK] Allow extra jhbuild modulesets
23230         https://bugs.webkit.org/show_bug.cgi?id=76691
23231
23232         Reviewed by Gustavo Noronha Silva.
23233
23234         * gtk/jhbuildrc: Extra modulesets and modules can be added in
23235         JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
23236         env variables respectively. Use comma-separated values. Example:
23237         WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
23238
23239 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
23240
23241         [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
23242         https://bugs.webkit.org/show_bug.cgi?id=72589
23243
23244         Reviewed by Martin Robinson.
23245
23246         Ensure the accessibility infrastructure is available when running
23247         the unit tests, otherwise WK2's accessibility tests won't work.
23248
23249         * Scripts/run-gtk-tests:
23250         (TestRunner):
23251         (TestRunner._lookup_atspi2_binary): New. Looks for the directory
23252         where at-spi2's stuff is located (like at-spi-bus-launcher and
23253         at-spi2-registryd).
23254         (TestRunner.run): Initialize the accessibility infrastructure.
23255
23256         * gtk/generate-gtkdoc:
23257         (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
23258
23259         * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
23260
23261 2012-01-20  Hayato Ito  <hayato@chromium.org>
23262
23263         Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
23264         https://bugs.webkit.org/show_bug.cgi?id=76353
23265
23266         Reviewed by Hajime Morita.
23267
23268         Add ShadowRoot.idl, which is enabled only on chromium port since this is
23269         under development feature.
23270         ShadowRoot.idl contains minimum API so that we can test it.
23271         Other APIs should be added on other changes so that we can isolate issues.
23272
23273         * DumpRenderTree/chromium/TestShell.cpp:
23274         (TestShell::TestShell):
23275
23276 2012-01-20  Mario Sanchez Prada  <msanchez@igalia.com>
23277
23278         [GTK] GTK's DRT not to log events for already defunct objects
23279         https://bugs.webkit.org/show_bug.cgi?id=76620
23280
23281         Reviewed by Martin Robinson.
23282
23283         Do not log 'state-change:defunct' events.
23284
23285         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
23286         (printAccessibilityEvent): Early return if a
23287         'state-change:defunct' signal is passed.
23288         (axObjectEventListener): Pass the signal name and value in
23289         separate parameters to printAccessibilityEvent.
23290
23291 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
23292
23293         Unreviewed build fix. Wrong variable being used as the cwd for git
23294         remote update command.
23295
23296         * gtk/run-with-jhbuild:
23297         (update_jhbuild):
23298
23299 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
23300
23301         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
23302         https://bugs.webkit.org/show_bug.cgi?id=76585
23303
23304         Reviewed by Martin Robinson.
23305
23306         This allows us to specify a minimum version of jhbuild required,
23307         while also providing stability against changes done to the master
23308         branch, by letting us choose what is the exact version that will
23309         be used.
23310
23311         * gtk/run-with-jhbuild: refactored for more hackability and easier
23312         reading
23313         (jhbuild_installed): checks whether jhbuild is installed
23314         (jhbuild_cloned): checks whether jhbuild has been cloned
23315         (jhbuild_at_expected_revision): checks whether jhbuild is at the
23316         expected revision
23317         (update_jhbuild): brings jhbuild to the expected revision
23318         (clone_jhbuild): clones jhbuild
23319         (install_jhbuild): build and installs jhbuild
23320         (update_webkitgtk_libs): runs update-webkitgtk-libs
23321         (ensure_jhbuild): high-level logic to decide whether and which of
23322         the steps above are executed
23323
23324 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
23325
23326         [WK2] DumpRenderTree converts "file:///" to a path differently
23327         https://bugs.webkit.org/show_bug.cgi?id=76653
23328
23329         Reviewed by John Sullivan.
23330
23331         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
23332         Do print a slash if there are no path components.
23333
23334 2012-01-19  Eric Seidel  <eric@webkit.org>
23335
23336         webkit-patch cannot rollout patches without changelog/bug number
23337         https://bugs.webkit.org/show_bug.cgi?id=75962
23338
23339         Reviewed by Adam Barth.
23340
23341         * Scripts/webkitpy/tool/commands/download.py:
23342         (AbstractRolloutPrepCommand._prepare_state):
23343         * Scripts/webkitpy/tool/commands/download_unittest.py:
23344         (AbstractRolloutPrepCommandTest.test_prepare_state):
23345
23346 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
23347
23348         [WK2] fast/url/degenerate-file-base.html fails
23349         https://bugs.webkit.org/show_bug.cgi?id=76619
23350
23351         Reviewed by Adam Roben.
23352
23353         A URL generated form local path for loading had an extra slash, making document.URL
23354         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
23355
23356         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
23357
23358 2012-01-18  Ojan Vafai  <ojan@chromium.org>
23359
23360         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
23361         https://bugs.webkit.org/show_bug.cgi?id=76510
23362
23363         Reviewed by Adam Barth.
23364
23365         Unlike other style rules, if you get the syntax of the test_expectations.txt
23366         file wrong, the layout tests won't run. Also, this check is simple and only
23367         slows down committing if you actually modify one of the test_expectations.txt files.
23368
23369         * Scripts/webkitpy/style/checkers/test_expectations.py:
23370         (TestExpectationsChecker.check_test_expectations):
23371         (TestExpectationsChecker.check):
23372         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
23373         (TestExpectationsTestCase.test_check_covers_all_configurations):
23374         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
23375         (TestExpectationsTestCase):
23376         (assert_lines_lint):
23377
23378 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
23379
23380         Build fix. Revert an unintentional change to WebKitDriver in r105443.
23381
23382         * Scripts/webkitpy/layout_tests/port/driver.py:
23383         (DriverProxy.__init__):
23384
23385 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
23386
23387         remove the duplicated build rules from WebKit.gyp, Tools.gyp
23388         https://bugs.webkit.org/show_bug.cgi?id=73384
23389
23390         Reviewed by Tony Chang.
23391
23392         This patch removes the no-longer-necessary conditional logic for
23393         build_webkit_exes_from_webkit_gyp; we now always build the exes
23394         from their own dedicated gyp files.
23395
23396         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
23397
23398 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
23399
23400         make-new-script-test should work with HTTP tests
23401         https://bugs.webkit.org/show_bug.cgi?id=76603
23402
23403         Reviewed by Adam Roben.
23404
23405         * Scripts/make-new-script-test:
23406         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
23407         now also creates absolute paths for HTTP.
23408
23409 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
23410
23411         Some perf tests time out when ran by run-perf-tests
23412         https://bugs.webkit.org/show_bug.cgi?id=76612
23413
23414         Reviewed by Dirk Pranke and Eric Seidel.
23415
23416         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
23417         Otherwise some tests such as Parser/xml-parser.html will timeout.
23418
23419         --no-timeout option is currently supported by Chromium and Mac ports.
23420
23421         * Scripts/webkitpy/layout_tests/port/base.py:
23422         (Port.to.create_driver):
23423         * Scripts/webkitpy/layout_tests/port/chromium.py:
23424         (ChromiumDriver.__init__):
23425         (ChromiumDriver._wrapper_options):
23426         * Scripts/webkitpy/layout_tests/port/driver.py:
23427         (Driver.__init__):
23428         (DriverProxy.__init__):
23429         * Scripts/webkitpy/layout_tests/port/webkit.py:
23430         (WebKitDriver.__init__):
23431         (WebKitDriver.cmd_line):
23432         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
23433         (WebKitDriverTest.test_read_binary_block):
23434         (WebKitDriverTest):
23435         (WebKitDriverTest.test_no_timeout):
23436         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
23437         (get_tests_run.RecordingTestDriver.__init__):
23438         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23439         (PerfTestsRunner._parse_args):
23440         (PerfTestsRunner._run_tests_set):
23441         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
23442         (create_runner):
23443
23444 2012-01-19  Ben Wells  <benwells@chromium.org>
23445
23446         Add support for window.print to chromium DRT
23447         https://bugs.webkit.org/show_bug.cgi?id=76479
23448
23449         When used in a test window.print goes into print mode and then
23450         straight out again. This will allow the afterprint event to be
23451         tested by having the afterprint event happen before the dump
23452         happens.
23453
23454         Reviewed by Mihai Parparita.
23455
23456         * DumpRenderTree/chromium/WebViewHost.cpp:
23457         (WebViewHost::printPage):
23458         * DumpRenderTree/chromium/WebViewHost.h:
23459
23460 2012-01-18  Enrica Casucci  <enrica@apple.com>
23461
23462         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
23463         https://bugs.webkit.org/show_bug.cgi?id=76588
23464         <rdar://problem/9325183>
23465
23466         Added test.
23467
23468         Reviewed by Dan Bernstein.
23469
23470         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
23471         (TestWebKitAPI::TEST):
23472
23473 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23474
23475         [Qt] Do full incremental builds until bots use update-webkit
23476
23477         Rubber-stamped by Simon Hausmann.
23478
23479         * Scripts/webkitdirs.pm:
23480         (buildQMakeProjects):
23481
23482 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23483
23484         Fix the Qt build
23485
23486         Unreviewed build fix.
23487
23488         * Scripts/webkitdirs.pm:
23489         (buildQMakeProjects):
23490
23491 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23492
23493         [Qt] Make build-webkit always do safe incremental builds after update-webkit
23494
23495         When building against Qt5 with GCC we would just run 'make' in the build dir,
23496         and rely on the dependency files output by GCC (-MD) to handle dependency
23497         tracking, but that fails for special-cases like adding a Q_OBJECT macro
23498         to a header.
23499
23500         To guarantee that an incrmental build will work, we have to run 'make qmake',
23501         which we now do on every build-webkit that's followed by a successful run
23502         of update-webkit. The reasoning is that update-webkit can result in such
23503         potential corner-cases being applied, and since we can't know for sure
23504         unless we inspect the diff and account for all the corner cases we assume
23505         the worst and always run 'make qmake'.
23506
23507         After a succesful run of build-webkit we proceed to do just 'make' for any
23508         subsequent runs, since we assume that the developer knows what kind of
23509         changes he/she is doing, and when a 'make qmake' is needed.
23510
23511         Reviewed by Simon Hausmann.
23512
23513         * Scripts/update-webkit:
23514         * Scripts/webkitdirs.pm:
23515         (determineCurrentSVNRevision):
23516         (currentSVNRevision):
23517         (buildQMakeProjects):
23518         * qmake/mkspecs/features/default_post.prf:
23519
23520 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
23521
23522         run-perf-tests should support Skipped list
23523         https://bugs.webkit.org/show_bug.cgi?id=76594
23524
23525         Reviewed by Adam Barth.
23526
23527         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
23528
23529         * Scripts/webkitpy/layout_tests/port/base.py:
23530         (Port.perf_tests_dir):
23531         (Port.skipped_perf_tests):
23532         (Port.skips_perf_test):
23533         (Port.relative_perf_test_filename):
23534         * Scripts/webkitpy/layout_tests/port/test.py:
23535         (TestPort.perf_tests_dir):
23536         * Scripts/webkitpy/layout_tests/port/webkit.py:
23537         (WebKitPort._expectations_from_skipped_files):
23538         (WebKitPort):
23539         (WebKitPort.skipped_layout_tests):
23540         (WebKitPort.skipped_perf_tests):
23541         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23542         (PerfTestsRunner._collect_tests):
23543         (PerfTestsRunner.run):
23544         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
23545         (test_run_test_set_with_json_output):
23546         (test_run_test_set_with_json_source):
23547         (test_collect_tests_with_skipped_list):
23548         (test_collect_tests_with_skipped_list.add_file):
23549
23550 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
23551
23552         Fix path to chromium_src_dir introduced in previous change.
23553
23554         Unreviewed, build fix.
23555
23556         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
23557
23558 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
23559
23560         Need infrastructure to test Content-Disposition filename encoding support
23561         https://bugs.webkit.org/show_bug.cgi?id=76572
23562         <rdar://problem/6421825>
23563
23564         Reviewed by Sam Weinig.
23565
23566         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
23567
23568         WebKitTestRunner does not have a policy delegate yet, bug 42546.
23569
23570         * DumpRenderTree/mac/PolicyDelegate.mm:
23571         (dispositionTypeFromContentDispositionHeader):
23572         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
23573
23574 2012-01-18  Ojan Vafai  <ojan@chromium.org>
23575
23576         Fix tests from http://trac.webkit.org/changeset/105332.
23577
23578         The code assumed that if you passed an options object with a configuration
23579         attribute that it would have a valid value. A bunch of the testing mocks
23580         do things like having a configuration value of None.
23581
23582         * Scripts/webkitpy/layout_tests/port/base.py:
23583         (Port.__init__):
23584
23585 2012-01-18  Ojan Vafai  <ojan@chromium.org>
23586
23587         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
23588         https://bugs.webkit.org/show_bug.cgi?id=76576
23589
23590         Reviewed by Adam Barth.
23591
23592         Avoid calling default_configuration in base.py. We don't need it for
23593         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
23594         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
23595         from common.executive.
23596
23597         At some point someone should probably look into why that call is so slow
23598         since it's on the critical path for run-webkit-tests and build-webkit startup.
23599
23600         * Scripts/webkitpy/layout_tests/port/base.py:
23601         (Port.__init__):
23602         * Scripts/webkitpy/style/checkers/test_expectations.py:
23603         (TestExpectationsChecker._determine_port_from_exepectations_path):
23604
23605 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
23606
23607         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
23608         https://bugs.webkit.org/show_bug.cgi?id=76505
23609
23610         Reviewed by Tony Chang.
23611
23612         Update chromium build script to use All.gyp instead of WebKit.gyp
23613
23614         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
23615         * Scripts/webkitdirs.pm:
23616
23617 2012-01-18  Sam Weinig  <sam@webkit.org>
23618
23619         Don’t hardcode the path to ‘make‘.
23620
23621         Reviewed by Dan Bernstein.
23622
23623         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
23624
23625 2012-01-18  Joshua Bell  <jsbell@chromium.org>
23626
23627         Adding myself to committers.py
23628         https://bugs.webkit.org/show_bug.cgi?id=76569
23629
23630         Unreviewed.
23631
23632         * Scripts/webkitpy/common/config/committers.py:
23633
23634 2012-01-18  Adam Barth  <abarth@webkit.org>
23635
23636         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
23637         https://bugs.webkit.org/show_bug.cgi?id=76567
23638
23639         Reviewed by Eric Seidel.
23640
23641         Current the AppleMac port has slightly more failures than we allow on
23642         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
23643         which should hopefully let the mac-ews run to completion.  Once
23644         AppleMac has fewer failures, we can lower the cap again.
23645
23646         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
23647         (LayoutTestResultsReaderTest.test_layout_test_results):
23648         * Scripts/webkitpy/tool/steps/runtests.py:
23649         (RunTests):
23650         * Scripts/webkitpy/tool/steps/steps_unittest.py:
23651
23652 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
23653
23654         Provide access to user's list of preferred languages
23655         https://bugs.webkit.org/show_bug.cgi?id=76138
23656
23657         Reviewed by Alexey Proskuryakov.
23658
23659         * GNUmakefile.am: Add JSInternalsCustom.cpp.
23660
23661 2012-01-18  Adam Barth  <abarth@webkit.org>
23662
23663         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
23664         configurations.
23665
23666         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
23667         (ChromiumLinuxPort.__init__):
23668
23669 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
23670
23671         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
23672         https://bugs.webkit.org/show_bug.cgi?id=73460
23673
23674         Reviewed by Chris Fleizach.
23675
23676         * DumpRenderTree/AccessibilityUIElement.h:
23677         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
23678         (AccessibilityUIElement::AccessibilityUIElement):
23679         (AccessibilityUIElement::scrollToMakeVisibleCallback):
23680         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
23681         (AccessibilityUIElement::scrollToGlobalPointCallback):
23682         * DumpRenderTree/chromium/AccessibilityUIElement.h:
23683         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
23684         (AccessibilityUIElement::scrollToMakeVisible):
23685         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23686         (AccessibilityUIElement::scrollToGlobalPoint):
23687         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
23688         (AccessibilityUIElement::scrollToMakeVisible):
23689         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23690         (AccessibilityUIElement::scrollToGlobalPoint):
23691         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
23692         (AccessibilityUIElement::scrollToMakeVisible):
23693         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23694         (AccessibilityUIElement::scrollToGlobalPoint):
23695
23696 2012-01-17  Enrica Casucci  <enrica@apple.com>
23697
23698         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
23699         https://bugs.webkit.org/show_bug.cgi?id=76490
23700         <rdar://problem/9460733>
23701
23702         Added TestWebKitAPI test.
23703
23704         Reviewed by Dan Bernstein.
23705
23706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
23707         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
23708         changeAttributes to the WebView.
23709
23710 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
23711
23712         [Qt] Consolidate layout test crash logging
23713         https://bugs.webkit.org/show_bug.cgi?id=75088
23714
23715         Reviewed by Simon Hausmann.
23716
23717         Move backtrace generating logic into WTFReportBacktrace
23718         and add a way to deinstall signal handlers if we know
23719         that we have already printed the backtrace.
23720
23721         * DumpRenderTree/qt/main.cpp:
23722         (crashHandler):
23723         (setupSignalHandlers):
23724         (WTFCrashHook):
23725         (main):
23726         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
23727         (WTR::crashHandler):
23728         (WTR::setupSignalHandlers):
23729         (WTR::crashHook):
23730         (WTR::InjectedBundle::platformInitialize):
23731
23732 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
23733
23734         Unreviewed build fix after r105256.
23735
23736         There was a cyclic dependency between self._port and self._host assigments.
23737
23738         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23739         (PerfTestsRunner.__init__):
23740
23741 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23742
23743         Add new watchlist rule for the Qt build system
23744
23745         Reviewed by Simon Hausmann.
23746
23747         * Scripts/webkitpy/common/config/watchlist:
23748
23749 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23750
23751         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
23752
23753         Reviewed by Simon Hausmann.
23754
23755         * Tools.pro:
23756
23757 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
23758
23759         [Qt] Allow building only a subset of the WebKit sub-projects
23760
23761         Fixes build-jsc, broken in r104825.
23762
23763         We no longer need the intermediate buildQMakeQtProject(), as we're the
23764         only port using qmake, and buildQMakeProject is now highly Qt specific.
23765
23766         <http://webkit.org/b/76179>
23767
23768         Reviewed by Simon Hausmann.
23769
23770         * Scripts/build-jsc:
23771         * Scripts/build-webkit:
23772         * Scripts/webkitdirs.pm:
23773         (buildQMakeProjects):
23774
23775 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
23776
23777         run-perf-tests should generate a json file that summaries the result
23778         https://bugs.webkit.org/show_bug.cgi?id=76504
23779
23780         Reviewed by Adam Barth.
23781
23782         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
23783         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
23784         another json file to be merged into the generated json file.
23785
23786         Also fixed a bug that --build wasn't set by default.
23787
23788         * Scripts/webkitpy/layout_tests/port/test.py:
23789         (TestPort.webkit_base):
23790         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
23791         (PerfTestsRunner.__init__):
23792         (PerfTestsRunner):
23793         (PerfTestsRunner._parse_args):
23794         (PerfTestsRunner.run):
23795         (PerfTestsRunner._generate_json_if_specified):
23796         (PerfTestsRunner._process_chromium_style_test_result):
23797         (PerfTestsRunner._process_parser_test_result):
23798         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
23799         (MainTest):
23800         (create_runner):
23801         (test_run_test_set):
23802         (test_run_test_set_for_parser_tests):
23803         (test_run_test_set_with_summary_json):
23804         (test_collect_tests):
23805         (test_parse_args):
23806
23807 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
23808
23809         Unreviewed, rolling out r105244.
23810         http://trac.webkit.org/changeset/105244
23811         https://bugs.webkit.org/show_bug.cgi?id=76518
23812
23813         broke Chromium Mac (Requested by rolandsteiner on #webkit).
23814
23815         * DumpRenderTree/AccessibilityUIElement.h:
23816         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
23817         (AccessibilityUIElement::AccessibilityUIElement):
23818         * DumpRenderTree/chromium/AccessibilityUIElement.h:
23819         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
23820         (AccessibilityUIElement::removeSelection):
23821         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
23822         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
23823         (AccessibilityUIElement::removeSelection):
23824
23825 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
23826
23827         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
23828         https://bugs.webkit.org/show_bug.cgi?id=73460
23829
23830         Reviewed by Chris Fleizach.
23831
23832         * DumpRenderTree/AccessibilityUIElement.h:
23833         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
23834         (AccessibilityUIElement::AccessibilityUIElement):
23835         (AccessibilityUIElement::scrollToMakeVisibleCallback):
23836         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
23837         (AccessibilityUIElement::scrollToGlobalPointCallback):
23838         * DumpRenderTree/chromium/AccessibilityUIElement.h:
23839         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
23840         (AccessibilityUIElement::scrollToMakeVisible):
23841         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23842         (AccessibilityUIElement::scrollToGlobalPoint):
23843         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
23844         (AccessibilityUIElement::scrollToMakeVisible):
23845         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23846         (AccessibilityUIElement::scrollToGlobalPoint):
23847         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
23848         (AccessibilityUIElement::scrollToMakeVisible):
23849         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
23850         (AccessibilityUIElement::scrollToGlobalPoint):
23851
23852 2012-01-17  Adam Barth  <abarth@webkit.org>
23853
23854         Enable tests on the mac-ews
23855         https://bugs.webkit.org/show_bug.cgi?id=76502
23856
23857         Reviewed by Simon Fraser.
23858
23859         Apple now has five machines running the mac-ews.  Lucas Forschler has
23860         asked that we try enabling tests to see if we have enough bandwidth.
23861
23862         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
23863         (MacEWS):
23864
23865 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
23866
23867         Add a check-webkit-style exception for GDBInterface.cpp
23868         https://bugs.webkit.org/show_bug.cgi?id=76187
23869
23870         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
23871         that it does not fail the style check.
23872
23873         Reviewed by Martin Robinson.
23874
23875         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
23876         readability/naming tests on
23877         Source/JavaScriptCore/jit/GDBInterface.cpp.
23878         * Scripts/webkitpy/style/checker_unittest.py:
23879         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
23880         the above exception.
23881
23882 2012-01-17  Hajime Morrita  <morrita@chromium.org>
23883
23884         https://bugs.webkit.org/show_bug.cgi?id=76245
23885         [Mac][DRT] should allow query string for the file URL.
23886
23887         Reviewed by Tony Chang.
23888
23889         Taught DRT about file:// as a url instead of a file path.
23890         We are now able to use a path file:///foo/bar.html?baz as a url
23891         with which DRT opens "/foo/bar.html" with "baz" as a query string.
23892
23893         * DumpRenderTree/mac/DumpRenderTree.mm:
23894         (runTest):
23895
23896 2012-01-17  Ojan Vafai  <ojan@chromium.org>
23897
23898         Check style on test_expectations.txt files before commit
23899         https://bugs.webkit.org/show_bug.cgi?id=76484
23900
23901         Reviewed by Adam Barth.
23902
23903         Unlike other style rules, if you get the syntax of the test_expectations.txt
23904         file wrong, the layout tests won't run. Also, this check is simple and only
23905         slows down committing if you actually modify one of the test_expectations.txt files.
23906
23907         * Scripts/webkitpy/tool/steps/commit.py:
23908         (Commit._check_test_expectations):
23909         (Commit.run):
23910         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
23911         (CommitTest):
23912         (CommitTest.test_check_test_expectations):
23913
23914 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
23915
23916         [Qt] Debug build fails with debug qt5
23917         https://bugs.webkit.org/show_bug.cgi?id=76463
23918
23919         Reviewed by Simon Hausmann.
23920
23921         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
23922
23923         * QtTestBrowser/cookiejar.h:
23924
23925 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
23926
23927         webkitpy: fix json import on linux
23928         https://bugs.webkit.org/show_bug.cgi?id=76481
23929
23930         Reviewed by Adam Barth.
23931
23932         For some reason, the version of simplejson autoinstalled on my linux
23933         box seems to be broken. We should really only be using
23934         simplejson if json isn't available anyway, so this change looks
23935         for json first.
23936
23937         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
23938         (JSONGeneratorTest.test_test_timings_trie):
23939
23940 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
23941
23942         Fix failures in test-webkitpy caused by r105177.
23943
23944         Unreviewed, build fix.
23945
23946         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
23947         (ChromiumLinuxPort._determine_driver_path_statically):
23948         (ChromiumLinuxPort._static_build_path):
23949
23950 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
23951
23952         webkitpy: make PortFactory.get() be fully data-driven
23953         https://bugs.webkit.org/show_bug.cgi?id=76360
23954
23955         Reviewed by Eric Seidel.
23956
23957         Refactor PortFactory.get() to be fully data-driven.
23958
23959         * Scripts/webkitpy/layout_tests/port/factory.py:
23960         (PortFactory):
23961         (PortFactory._default_port):
23962         (PortFactory.get):
23963         (PortFactory.get.in):
23964         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
23965         (FactoryTest.assert_port):
23966
23967 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
23968
23969         webkitpy: add determine_full_port_name(), clean up port.__init__()
23970         https://bugs.webkit.org/show_bug.cgi?id=76357
23971
23972         Reviewed by Adam Barth.
23973
23974         Each Port class is now required to implement a 'port_name' field
23975         that will match the start of all ports constructed by this class and
23976         a 'determine_full_port_name' field that will make the port
23977         fully-qualified.
23978
23979         * Scripts/webkitpy/layout_tests/port/apple.py:
23980         (ApplePort.__init__):
23981         * Scripts/webkitpy/layout_tests/port/base.py:
23982         (Port):
23983         (Port.determine_port_name):
23984         (Port.__init__):
23985         * Scripts/webkitpy/layout_tests/port/chromium.py:
23986         (ChromiumPort.for):
23987         (ChromiumPort.__init__):
23988         (ChromiumPort):
23989         (ChromiumPort._chromium_base_dir):
23990         (ChromiumPort.path_from_chromium_base):
23991         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
23992         (ChromiumGpuLinuxPort):
23993         (ChromiumGpuLinuxPort.__init__):
23994         (ChromiumGpuMacPort):
23995         (ChromiumGpuMacPort.__init__):
23996         (ChromiumGpuWinPort):
23997         (ChromiumGpuWinPort.__init__):
23998         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
23999         (ChromiumLinuxPort):
24000         (ChromiumLinuxPort.determine_port_name):
24001         (ChromiumLinuxPort.__init__):
24002         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
24003         (ChromiumMacPort):
24004         (ChromiumMacPort.determine_port_name):
24005         (ChromiumMacPort.__init__):
24006         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
24007         (ChromiumWinPort):
24008         (ChromiumWinPort.determine_port_name):
24009         (ChromiumWinPort.__init__):
24010         * Scripts/webkitpy/layout_tests/port/dryrun.py:
24011         (DryRunPort):
24012         (DryRunPort.determine_port_name):
24013         (DryRunPort.__init__):
24014         * Scripts/webkitpy/layout_tests/port/efl.py:
24015         (EflPort):
24016         * Scripts/webkitpy/layout_tests/port/factory.py:
24017         (PortFactory):
24018         (PortFactory._default_port):
24019         (PortFactory.get):
24020         (PortFactory.get.in):
24021         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
24022         (FactoryTest.assert_port):
24023         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
24024         (GoogleChromeLinux32Port):
24025         (GoogleChromeLinux32Port.determine_port_name):
24026         (GoogleChromeLinux64Port):
24027         (GoogleChromeLinux64Port.determine_port_name):
24028         (GoogleChromeMacPort):
24029         (GoogleChromeMacPort.determine_port_name):
24030         (GoogleChromeWinPort):
24031         (GoogleChromeWinPort.determine_port_name):
24032         * Scripts/webkitpy/layout_tests/port/gtk.py:
24033         (GtkPort):
24034         * Scripts/webkitpy/layout_tests/port/mac.py:
24035         (MacPort):
24036         (MacPort.determine_port_name):
24037         (MacPort.__init__):
24038         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
24039         (test_versions):
24040         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
24041         (MockDRTPort):
24042         (MockDRTPort.determine_port_name):
24043         (MockDRTPort.__init__):
24044         (MockDRT):
24045         (MockDRT.determine_port_name):
24046         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
24047         (PortTestCase.make_port):
24048         * Scripts/webkitpy/layout_tests/port/qt.py:
24049         (QtPort):
24050         (QtPort.determine_port_name):
24051         (QtPort.__init__):
24052         * Scripts/webkitpy/layout_tests/port/test.py:
24053         (TestPort):
24054         (TestPort.determine_port_name):
24055         (TestPort.__init__):
24056         * Scripts/webkitpy/layout_tests/port/webkit.py:
24057         (WebKitPort.__init__):
24058         * Scripts/webkitpy/layout_tests/port/win.py:
24059         (WinPort):
24060         (WinPort.determine_port_name):
24061         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
24062         (get_test_baselines.AllPlatformsPort.__init__):
24063         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
24064         (get_test_config.TestMacPort):
24065         (get_test_config):
24066
24067 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
24068
24069         webkitpy: clean up port code in preparation for static port names
24070         https://bugs.webkit.org/show_bug.cgi?id=76356
24071
24072         Reviewed by Adam Barth.
24073
24074         To fix bug 76215 and be able to determine appropriate port names
24075         in webkitpy without actually constructing Port objects, we need
24076         to shuffle some logic in the chromium ports to be able to figure
24077         out whether we built DRT in 32 or 64-bit mode.
24078
24079         * Scripts/webkitpy/layout_tests/port/chromium.py:
24080         (ChromiumPort):
24081         (ChromiumPort._chromium_base_dir):
24082         (ChromiumPort.__init__):
24083         (ChromiumPort.path_from_chromium_base):
24084         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
24085         (ChromiumLinuxPort):
24086         (ChromiumLinuxPort._determine_driver_path_statically):
24087         (ChromiumLinuxPort._static_build_path):
24088         (ChromiumLinuxPort._determine_architecture):
24089         (ChromiumLinuxPort.__init__):
24090         (ChromiumLinuxPort._build_path):
24091
24092 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
24093
24094         Do not remove pixel failures for ref tests.
24095         https://bugs.webkit.org/show_bug.cgi?id=76243
24096
24097         Reviewed by Tony Chang.
24098
24099         'NRWT --no-pixel-tests' complains when reftests are expected to
24100         be image mismatch.
24101
24102         * Scripts/webkitpy/layout_tests/controllers/manager.py:
24103         (Manager._update_summary_with_result):
24104         * Scripts/webkitpy/layout_tests/models/test_failures.py:
24105         (is_reftest_failure):
24106         (determine_result_type):
24107
24108 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
24109
24110         REGRESSION(r81225): ORWT should ignore reftests
24111         https://bugs.webkit.org/show_bug.cgi?id=67936
24112
24113         Reviewed by Csaba Osztrogonác.
24114
24115         * Scripts/old-run-webkit-tests:
24116         (isUsedInReftest): $filename should be the first parameter
24117         (findTestsToRun): run test if it isn't reftest
24118
24119 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
24120
24121         Unreviewed. Fix python unit test I broke with r105142
24122
24123         * Scripts/webkitpy/common/config/ports_unittest.py:
24124         (WebKitPortTest.test_gtk_port):
24125
24126 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
24127
24128         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
24129
24130         Qt 5 no longer has that flag.
24131
24132         Reviewed by Simon Hausmann.
24133
24134         * MiniBrowser/qt/MiniBrowserApplication.cpp:
24135         (MiniBrowserApplication::notify):
24136
24137 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
24138
24139         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
24140         https://bugs.webkit.org/show_bug.cgi?id=75857
24141
24142         Reviewed by Adam Barth.
24143
24144         * Scripts/webkitdirs.pm:
24145         (buildAutotoolsProject): move cleaning the build to happen early,
24146         and handle --update-gtk right after that
24147         * Scripts/webkitpy/common/config/ports.py:
24148         (GtkPort.build_webkit_command): pass --update-gtk as an option to
24149         build-webkit, so that it is used in the EWS
24150
24151 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
24152
24153         [Qt] Don't add _debug postfix to targets when building debug only
24154
24155         Reviewed by Simon Hausmann.
24156
24157         * qmake/mkspecs/features/default_post.prf:
24158         * qmake/mkspecs/features/functions.prf:
24159
24160 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
24161
24162         [Qt] Add more files to project-files for easier navigation in Qt Creator
24163
24164         Reviewed by Simon Hausmann.
24165
24166         * Tools.pro:
24167         * qmake/config.tests/README: Added.
24168
24169 2012-01-17  Philippe Normand  <pnormand@igalia.com>
24170
24171         [GTK] fast/dom/constructed-objects-prototypes.html fails
24172         https://bugs.webkit.org/show_bug.cgi?id=75432
24173
24174         Reviewed by Martin Robinson.
24175
24176         * Scripts/build-webkit: Enable video-track in GTK.
24177
24178 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
24179
24180         Add toyoshim as a committer.
24181         https://bugs.webkit.org/show_bug.cgi?id=76390
24182
24183         Reviewed by Hajime Morita.
24184
24185         * Scripts/webkitpy/common/config/committers.py:
24186
24187 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
24188
24189         [WinCairo] Build fix after r104155. Several debug targets were not
24190         properly including the '*Common' property sheets.
24191
24192         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
24193         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
24194         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
24195         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
24196         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
24197
24198 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
24199
24200         REGRESSION(r105072): It broke committers_unittest.py
24201         https://bugs.webkit.org/show_bug.cgi?id=76396
24202
24203         Reviewed by Adam Barth.
24204
24205         * Scripts/webkitpy/common/config/committers_unittest.py:
24206         (CommittersTest._assert_fuzz_match): It should handle more names.
24207         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
24208
24209 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
24210
24211         [GTK] Include gtk+3 in the jhbuild modules
24212         https://bugs.webkit.org/show_bug.cgi?id=76284
24213
24214         Reviewed by Philippe Normand.
24215
24216         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
24217
24218 2012-01-16  Dan Winship  <danw@gnome.org>
24219
24220         Add myself as a committer
24221
24222         Unreviewed
24223
24224         * Scripts/webkitpy/common/config/committers.py:
24225
24226 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
24227
24228         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
24229
24230         Some recent versions of a few Linux distributions have started passing
24231         --as-needed and --no-copy-dt-needed-entries by default to the linker,
24232         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
24233         needed a few symbols from libjavascriptcore_efl.so.
24234
24235         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
24236         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
24237         libraries are searched in the right order by the linker.
24238
24239 2012-01-16  Philippe Normand  <pnormand@igalia.com>
24240
24241         [GTK] set audio resources path in NRTW
24242         https://bugs.webkit.org/show_bug.cgi?id=76380
24243
24244         Reviewed by Martin Robinson.
24245
24246         * Scripts/webkitpy/layout_tests/port/gtk.py:
24247         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
24248         the uninstalled audio resources are used during webaudio tests.
24249
24250 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
24251
24252         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
24253         https://bugs.webkit.org/show_bug.cgi?id=76369
24254
24255         Reviewed by Xan Lopez.
24256
24257         If there's an installed version of webkit and there are new
24258         symbols in the build tree, gtkdoc-scanobj fails due to undefined
24259         references, because the env ldflags are given before the local
24260         ones.
24261
24262         * gtk/gtkdoc.py:
24263         (GTKDoc._run_gtkdoc_scangobj):
24264
24265 2012-01-15  Pablo Flouret  <pablof@motorola.com>
24266
24267         Fix compilation errors on build-webkit --debug --no-video on mac.
24268         https://bugs.webkit.org/show_bug.cgi?id=75867
24269
24270         Reviewed by Philippe Normand.
24271
24272         Add --[no-]video-track to build-webkit, since video track feature
24273         depends on video.
24274
24275         * Scripts/build-webkit:
24276
24277 2012-01-14  James Robinson  <jamesr@chromium.org>
24278
24279         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
24280         https://bugs.webkit.org/show_bug.cgi?id=76313
24281
24282         Reviewed by Adam Barth.
24283
24284         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
24285
24286         * Scripts/run-chromium-webkit-unit-tests:
24287
24288 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
24289
24290         Unreviewed, rolling out r105017.
24291         http://trac.webkit.org/changeset/105017
24292         https://bugs.webkit.org/show_bug.cgi?id=76333
24293
24294         broke the build (Requested by philn-tp on #webkit).
24295
24296         * gtk/jhbuild.modules:
24297
24298 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
24299
24300         [GTK] Include gtk+3 in the jhbuild modules
24301         https://bugs.webkit.org/show_bug.cgi?id=76284
24302
24303         Reviewed by Philippe Normand.
24304
24305         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
24306
24307 2012-01-13  Adam Barth  <abarth@webkit.org>
24308
24309         Remove --dry-run support from webkit-patch
24310         https://bugs.webkit.org/show_bug.cgi?id=76300
24311
24312         Reviewed by Dirk Pranke.
24313
24314         This is the rest of the patch from Bug 76300.  I landed it separtely
24315         because main.py had some stray conflict markers that I needed to clean
24316         up first.
24317
24318         * Scripts/webkitpy/test/main.py:
24319         (Tester.parse_args):
24320         (Tester._run_tests):
24321
24322 2012-01-13  Adam Barth  <abarth@webkit.org>
24323
24324         test-webkitpy does not run
24325         https://bugs.webkit.org/show_bug.cgi?id=76318
24326
24327         Unreviewed.
24328
24329         Looks like some conflict markers got left in the file.
24330
24331         * Scripts/webkitpy/test/main.py:
24332         (Tester.run):
24333
24334 2012-01-13  Adam Barth  <abarth@webkit.org>
24335
24336         Remove --dry-run support from webkit-patch
24337         https://bugs.webkit.org/show_bug.cgi?id=76300
24338
24339         Reviewed by Dirk Pranke.
24340
24341         We don't use this functionality for anything, and it doesn't really
24342         work.  Someone in #webkit tried using it and and got sad/confused.  We
24343         should just remove it.
24344
24345         * Scripts/webkitpy/common/checkout/scm/git.py:
24346         (Git.push_local_commits_to_server):
24347         * Scripts/webkitpy/common/checkout/scm/scm.py:
24348         (SCM.__init__):
24349         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
24350         (_shared_test_commit_with_message):
24351         (GitSVNTest.test_commit_text_parsing):
24352         * Scripts/webkitpy/common/checkout/scm/svn.py:
24353         (SVN.commit_with_message):
24354         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
24355         (Bugzilla.__init__):
24356         (Bugzilla.quips):
24357         (Bugzilla.authenticate):
24358         (Bugzilla.add_attachment_to_bug):
24359         (Bugzilla.add_patch_to_bug):
24360         (Bugzilla.create_bug):
24361         (Bugzilla.clear_attachment_flags):
24362         (Bugzilla.set_flag_on_attachment):
24363         (Bugzilla.obsolete_attachment):
24364         (Bugzilla.add_cc_to_bug):
24365         (Bugzilla.post_comment_to_bug):
24366         (Bugzilla.close_bug_as_fixed):
24367         (Bugzilla.reassign_bug):
24368         (reopen_bug):
24369         * Scripts/webkitpy/test/main.py:
24370         (Tester.parse_args):
24371         (Tester.run_tests):
24372
24373 2012-01-13  David Levin  <levin@chromium.org>
24374
24375         check-webkit-style: should encourage the use of Own* classes for Windows DC.
24376         https://bugs.webkit.org/show_bug.cgi?id=76227
24377
24378         Reviewed by Dirk Pranke.
24379
24380         * Scripts/webkitpy/style/checkers/cpp.py:
24381         (check_for_leaky_patterns): The new check.
24382         (process_line): Added a call to the new check.
24383         (CppChecker): Added the new error type.
24384         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
24385         (CppStyleTestBase):
24386         (CppStyleTestBase.perform_leaky_pattern_check):
24387         The check for only leaky pattern errors.
24388         (LeakyPatternTest): Test cases.
24389
24390 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
24391
24392         test-webkitpy: clean up handling of test directories, QueueStatusServer
24393         https://bugs.webkit.org/show_bug.cgi?id=76238
24394
24395         Reviewed by Adam Barth.
24396
24397         This patch cleans up a bunch of hacks related to how we find all
24398         of the python unit tests and set up the sys.path variable in
24399         test-webkitpy.
24400
24401         This patch changes how test-webkitpy works slightly in that we
24402         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
24403         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
24404         This greatly simplifies the mapping of paths to module names and
24405         appears to have no significant performance impact or other drawbacks.
24406
24407         There are other ways that we could remove all of the hacks and
24408         still have a more flexible mapping of paths to module names, but
24409         the ones I've thought of so far add a decent amount of complexity to
24410         the implementation and don't seem to buy us much.
24411
24412         * QueueStatusServer/__init__.py:
24413         * Scripts/test-webkitpy:
24414         * Scripts/webkitpy/test/main.py:
24415         (Tester._modules_from_paths):
24416         (Tester._is_module):
24417
24418 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
24419
24420         test-webkitpy: should support classes and individual test names as well as modules
24421         https://bugs.webkit.org/show_bug.cgi?id=76233
24422
24423         Reviewed by Adam Barth.
24424
24425         The default unittest.main() supports a list of individual
24426         TestCase classes or individual tests as well as modules. This
24427         change adds support for the same to test-webkitpy, so now you
24428         can say
24429
24430           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
24431
24432         and
24433
24434           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
24435
24436         in addition to
24437
24438           % test-wekbitpy webkitpy.test.cat_unittest
24439
24440         * Scripts/test-webkitpy:
24441         * Scripts/webkitpy/test/cat_unittest.py:
24442         * Scripts/webkitpy/test/main.py:
24443         (Tester.parse_args):
24444         (Tester.run):
24445         (Tester):
24446         (Tester._find_modules):
24447         (Tester._exclude):
24448         (Tester._run_tests):
24449         (Tester._is_module):
24450         (Tester._log_exception):
24451
24452 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
24453
24454         test-webkitpy: add basic code coverage support
24455         https://bugs.webkit.org/show_bug.cgi?id=76201
24456
24457         Reviewed by Adam Barth.
24458
24459         This test adds basic code coverage support to test-webkitpy; if
24460         you pass the -c flag, we will generate a new coverage file. We
24461         can start simply with this and add more features as necessary.
24462
24463         This patch requires coverage to be already installed on the
24464         machine. I am not auto-installing this for now.
24465
24466         * Scripts/webkitpy/test/main.py:
24467         (Tester.parse_args):
24468         (Tester.run_tests):
24469
24470 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
24471
24472         StatusBubbleTest.test_build_bubble is failing
24473         https://bugs.webkit.org/show_bug.cgi?id=76222
24474
24475         Reviewed by Adam Barth.
24476
24477         * QueueStatusServer/handlers/statusbubble_unittest.py:
24478         (StatusBubbleTest.test_build_bubble):
24479
24480 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
24481
24482         nrwt should use multiple http shards
24483         https://bugs.webkit.org/show_bug.cgi?id=75958
24484
24485         Add --max-locked-shards option to the nrwt for manual set
24486         the maximum number of the locked shards
24487
24488         Reviewed by Dirk Pranke.
24489
24490         * Scripts/webkitpy/layout_tests/controllers/manager.py:
24491         (Manager._max_locked_shards):
24492         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
24493         (ShardingTests.get_shards):
24494         (ShardingTests.test_multiple_locked_shards):
24495         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
24496         (parse_args):
24497
24498 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
24499
24500         prepare-ChangeLog: Look for a text editor in a few more variables.
24501         https://bugs.webkit.org/show_bug.cgi?id=76289
24502
24503         Reviewed by Ryosuke Niwa.
24504
24505         A text editor was looked for only in the CHANGE_LOG_EDITOR and
24506         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
24507         to the OS X-specific open(1) command.
24508
24509         As there does not seem to be a common way of looking for a text editor
24510         among the scripts in Tools/Scripts right now, just look at $VISUAL and
24511         $EDITOR (set much more often than the other variables in Unix systems)
24512         before falling back to open(1).
24513
24514         * Scripts/prepare-ChangeLog:
24515         (openChangeLogs):
24516
24517 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
24518
24519         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
24520         https://bugs.webkit.org/show_bug.cgi?id=76269
24521
24522         Reviewed by Martin Robinson.
24523
24524         * gtk/gtkdoc.py:
24525         (GTKDoc._run_gtkdoc_scangobj):
24526
24527 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
24528
24529         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
24530         https://bugs.webkit.org/show_bug.cgi?id=76247
24531
24532         Reviewed by Kenneth Rohde Christiansen.
24533
24534         * WebKitTestRunner/TestController.cpp:
24535         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
24536
24537 2012-01-13  Hajime Morrita  <morrita@chromium.org>
24538
24539         [Mac][DRT] Should support --no-timeout
24540         https://bugs.webkit.org/show_bug.cgi?id=76242
24541
24542         Reviewed by Darin Adler.
24543
24544         * DumpRenderTree/mac/DumpRenderTree.mm:
24545         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
24546         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
24547         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
24548         * DumpRenderTree/mac/DumpRenderTreeMac.h:
24549         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
24550         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
24551
24552 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
24553
24554         Mitigate scrollbar differences when running pixel tests
24555         https://bugs.webkit.org/show_bug.cgi?id=67217
24556
24557         Reviewed by Dan Bernstein.
24558
24559         Enable mock scrollbars by default for tests.
24560
24561         * DumpRenderTree/mac/DumpRenderTree.mm:
24562         (resetDefaultsToConsistentValues):
24563         * WebKitTestRunner/TestController.cpp:
24564         (WTR::TestController::resetStateToConsistentValues):
24565
24566 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
24567
24568         Need a script to run tests in PerformanceTests
24569         https://bugs.webkit.org/show_bug.cgi?id=76132
24570
24571         Reviewed by Adam Barth.
24572
24573         Add run-perf-tests to run performance tests using parser/resources/runner.js.
24574         Unfortunately, there isn't an easy way of telling which test uses which format
24575         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
24576
24577         All test outputs are re-formatted to match Chromium perf-bot style.
24578
24579         * Scripts/run-inspector-perf-tests.py:
24580         * Scripts/run-perf-tests: Added.
24581         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
24582         (PerfTestsRunner):
24583         (PerfTestsRunner.__init__):
24584         (PerfTestsRunner._collect_tests):
24585         (PerfTestsRunner.run):
24586         (PerfTestsRunner._print_status):
24587         (PerfTestsRunner._run_tests_set):
24588         (PerfTestsRunner._process_chromium_style_test_result):
24589         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
24590         (PerfTestsRunner._process_parser_test_result):
24591         (PerfTestsRunner._run_single_test):
24592         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
24593         (MainTest.TestDriver.run_test):
24594         (create_runner):
24595         (run_test):
24596         (test_run_test_set):
24597         (test_run_test_set_for_parser_tests):
24598         (test_collect_tests):
24599
24600 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
24601
24602         webkitpy: clean up port unit tests in preparation for making port_name mandatory
24603         https://bugs.webkit.org/show_bug.cgi?id=76123
24604
24605         Reviewed by Adam Barth.
24606
24607         This change updates the unit tests to be more consistent in how
24608         ports are created, in preparation for making port_name a
24609         mandatory parameter to the constructor and removing any version
24610         interpretation from it.
24611
24612         There should be no functional changes in this patch, but some
24613         tests that are no longer relevant have been removed or reworked.
24614
24615         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
24616         (PortTest.test_get_option__default):
24617         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
24618         (ChromiumLinuxPortTest):
24619         (ChromiumLinuxPortTest.assert_architecture):
24620         (ChromiumLinuxPortTest.test_determine_architecture_fails):
24621         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
24622         (ChromiumMacPortTest):
24623         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
24624         (ChromiumPortTest):
24625         (ChromiumPortTest.test_all_test_configurations):
24626         (ChromiumPortTest.TestMacPort.__init__):
24627         (ChromiumPortTest.TestLinuxPort.__init__):
24628         (ChromiumPortTest.TestWinPort.__init__):
24629         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
24630         (ChromiumWinTest):
24631         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
24632         (EflPortTest):
24633         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
24634         (GtkPortTest):
24635         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
24636         (MacTest):
24637         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
24638         (MockDRTPortTest):
24639         (MockDRTPortTest.make_port):
24640         * Scripts/webkitpy/layout_tests/port/qt.py:
24641         (QtPort._port_flag_for_scripts):
24642         (QtPort.__init__):
24643         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
24644         (QtPortTest):
24645         (QtPortTest._assert_search_path):
24646         (QtPortTest.test_baseline_search_path):
24647         (QtPortTest.test_operating_system):
24648         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
24649         (WebKitPortTest):
24650         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
24651         (WinPortTest):
24652         (WinPortTest._assert_search_path):
24653         (WinPortTest.test_baseline_search_path):
24654         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
24655         (get_test_config.TestMacPort.__init__):
24656
24657 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
24658
24659         test-webkitpy: clean up logging and provide a real --help message
24660         https://bugs.webkit.org/show_bug.cgi?id=76142
24661
24662         Reviewed by Adam Barth.
24663
24664         This test is mostly more refactoring - it calls objects in
24665         unittest directly instead of routing through unittest.main() --
24666         in order to gain more control over the logging and to provide a
24667         correct --help message. This will also give us a better
24668         foundation for adding more feautures down the road.
24669
24670         This patch adds different levels of logging controlled by the
24671         '-s', '-q', and '-v' options (see --help for details), and
24672         removes the --verbose-logging option.
24673
24674         * Scripts/test-webkitpy:
24675         * Scripts/webkitpy/test/main.py:
24676         (Tester):
24677         (Tester.clean_packages):
24678         (Tester.__init__):
24679         (Tester.parse_args):
24680         (Tester.configure):
24681         (Tester._configure_logging):
24682         (Tester.find_modules):
24683         (Tester._exclude):
24684         (Tester._modules_from_paths):
24685         (Tester.run_tests):
24686
24687 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
24688
24689         Make the new WTF module build on Qt
24690         https://bugs.webkit.org/show_bug.cgi?id=76163
24691
24692         Reviewed by Tor Arne Vestbø.
24693
24694         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
24695
24696 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
24697
24698         Unreviewed, mac DumpRenderTree fix.
24699
24700         * DumpRenderTree/mac/UIDelegate.mm:
24701         (-[UIDelegate webView:addMessageToConsole:withSource:]):
24702
24703 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
24704
24705         WebKitTestRunner should not print console message line number when it is equal to zero.
24706         https://bugs.webkit.org/show_bug.cgi?id=76167
24707
24708         Reviewed by Csaba Osztrogonác.
24709
24710         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
24711         (WTR::InjectedBundlePage::willAddMessageToConsole):
24712
24713 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
24714
24715         Make default console messages line numbers consistent.
24716         https://bugs.webkit.org/show_bug.cgi?id=74075
24717
24718         Reviewed by Pavel Feldman.
24719
24720         Unset line numbers are not printed to console now.
24721         Added Source/WebCore/inspector to efl DumpRenderTree include path.
24722
24723         * DumpRenderTree/chromium/WebViewHost.cpp:
24724         (WebViewHost::didAddMessageToConsole):
24725         * DumpRenderTree/efl/CMakeLists.txt:
24726         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
24727         (onConsoleMessage):
24728         * DumpRenderTree/gtk/DumpRenderTree.cpp:
24729         (webViewConsoleMessage):
24730         * DumpRenderTree/mac/UIDelegate.mm:
24731         (-[UIDelegate webView:addMessageToConsole:withSource:]):
24732         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
24733         (WebCore::WebPage::javaScriptConsoleMessage):
24734         * DumpRenderTree/win/UIDelegate.cpp:
24735         (UIDelegate::webViewAddMessageToConsole):
24736         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
24737         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
24738
24739 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
24740
24741         test-webkitpy: push more logic into webkitpy.test.main, clean up code
24742         https://bugs.webkit.org/show_bug.cgi?id=76021
24743
24744         Reviewed by Eric Seidel.
24745
24746         I plan to add more functionality to test-webkitpy, but it is
24747         difficult to hack on now; this patch is the first of two that
24748         brings test-webkitpy more inline with current coding style by
24749         pushing more logic into the webkitpy.test.main.Tester class (so
24750         that it will be testable itself).
24751
24752         There should be no functional changes in this patch.
24753
24754         * Scripts/test-webkitpy:
24755         (_path_from_webkit_root):
24756         * Scripts/webkitpy/test/main.py:
24757         (Tester):
24758         (Tester.init):
24759         (Tester.configure_logging):
24760         (Tester.configure_logging.filter):
24761         (Tester.clean_packages):
24762         (Tester.run_tests):
24763
24764 2012-01-11  Wei Jia  <wjia@chromium.org>
24765
24766         implement layout tests for <video> with media stream
24767         https://bugs.webkit.org/show_bug.cgi?id=74882
24768
24769         Reviewed by Kent Tamura.
24770
24771         * DumpRenderTree/DumpRenderTree.gypi:
24772         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
24773         (WebKit::WebUserMediaClientMock::create):
24774         (WebKit::WebUserMediaClientMock::IsMockStream):
24775         (WebKit::WebUserMediaClientMock::requestUserMedia):
24776         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
24777         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
24778         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
24779         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
24780         * DumpRenderTree/chromium/WebViewHost.cpp:
24781         (WebViewHost::userMediaClient):
24782         (WebViewHost::userMediaClientMock):
24783         (WebViewHost::createMediaPlayer):
24784         (WebViewHost::mediaStreamUtil):
24785         (WebViewHost::testMediaStreamClient):
24786         * DumpRenderTree/chromium/WebViewHost.h:
24787
24788 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
24789
24790         Unreviewed, build fix.
24791
24792         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
24793
24794         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
24795         (ChromiumWinPort.__init__):
24796
24797 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
24798
24799         Sheriffbot build fix. Don't emit empty lines on IRC.
24800
24801         * Scripts/webkitpy/tool/bot/irc_command.py:
24802         (LastGreenRevision.execute):
24803
24804 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
24805
24806         last-green-revision should report the revision that succeeded on all bots
24807         https://bugs.webkit.org/show_bug.cgi?id=76109
24808
24809         Reviewed by Adam Barth.
24810
24811         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
24812         considered green by this algorithm, all matching builders must have a successful run at the revision
24813         or two consecutive successful runs before and after the revision.
24814
24815         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
24816         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
24817
24818         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
24819         (BuildBot._revisions_for_builder):
24820         (BuildBot):
24821         (BuildBot._find_green_revision):
24822         (BuildBot.last_green_revision):
24823         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
24824         (MockBuildBot.last_green_revision):
24825         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
24826         (test_revisions_for_builder):
24827         (test_find_green_revision):
24828         (test_last_green_revision):
24829         * Scripts/webkitpy/tool/bot/irc_command.py:
24830         (LastGreenRevision.execute):
24831         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
24832         (SheriffIRCBotTest.test_lgr):
24833         * Scripts/webkitpy/tool/commands/queries.py:
24834         (LastGreenRevision):
24835
24836 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
24837
24838         Unreviewed, fix build bustage on win32 introduced by r104725.
24839
24840         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
24841         (MockDRTPortTest.make_port):
24842         (MockChromiumDRTTest.test_pixeltest__fails):
24843
24844 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
24845
24846         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
24847         https://bugs.webkit.org/show_bug.cgi?id=75618
24848
24849         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
24850
24851         Reviewed by Tony Chang.
24852
24853         * DumpRenderTree/chromium/LayoutTestHelper.mm:
24854         (installLayoutTestColorProfile):
24855         (restoreUserColorProfile):
24856         (main):
24857
24858 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
24859
24860         test-webkitpy: fix -v and eliminate some spurious warnings
24861         https://bugs.webkit.org/show_bug.cgi?id=76099
24862
24863         Reviewed by Adam Barth.
24864
24865         when we added support for --xml output, we broke the -v flag.
24866
24867         Also, fix the code to swallow a harmless warning from
24868         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
24869
24870         test-webkitpy is now silent again except for the one known
24871         logging issue.
24872
24873         * Scripts/webkitpy/common/checkout/checkout.py:
24874         (Checkout.commit_message_for_this_commit):
24875         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
24876         (test_commit_message_for_this_commit):
24877         * Scripts/webkitpy/style/checkers/jsonchecker.py:
24878         (JSONChecker.check):
24879         (JSONChecker.line_number_from_json_exception):
24880         * Scripts/webkitpy/test/main.py:
24881         (Tester.run_tests):
24882
24883 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
24884
24885         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
24886         https://bugs.webkit.org/show_bug.cgi?id=76084
24887
24888         Reviewed by Adam Barth.
24889
24890         This will help make it easier to catch layering violations. This
24891         change just refactors test code; there are no changes to
24892         production code.
24893
24894         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
24895         (PortTest.make_port):
24896         (PortTest.test_find_no_paths_specified):
24897         (PortTest.test_find_one_test):
24898         (PortTest.test_find_glob):
24899         (PortTest.test_find_with_skipped_directories):
24900         (PortTest.test_find_with_skipped_directories_2):
24901         (PortTest.test_parse_reftest_list):
24902         (PortTest.test_httpd_returns_error_code):
24903         (PortTest.test_virtual_methods):
24904         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
24905         (ChromiumGpuTest.assert_port_works):
24906         (ChromiumGpuTest._assert_baseline_path):
24907         (ChromiumGpuTest.test_graphics_type):
24908         (ChromiumGpuTest.test_default_tests_paths.test_paths):
24909         (ChromiumGpuTest.test_test_files):
24910         (ChromiumGpuTest.test_test_files.test_paths):
24911         (ChromiumGpuTest):
24912         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
24913         (ChromiumLinuxPortTest.assert_architecture):
24914         (ChromiumLinuxPortTest.test_check_illegal_port_names):
24915         (ChromiumLinuxPortTest.test_determine_architecture_fails):
24916         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
24917         (DriverTest.make_port):
24918         (DriverTest):
24919         (DriverTest.assertVirtual):
24920         (DriverTest._assert_wrapper):
24921         (DriverTest.test_virtual_driver_methods):
24922         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
24923         (MockDRTPortTest.make_port):
24924         (MockDRTPortTest.test_port_name_in_constructor):
24925         (MockDRTTest.assertTest):
24926         (MockDRTTest.test_main):
24927         (MockChromiumDRTTest.test_pixeltest__fails):
24928         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
24929         (QtPortTest._assert_search_path):
24930         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
24931         (TestWebKitPort.__init__):
24932         (WebKitPortUnitTests.test_default_options):
24933         (test_runtime_feature_list):
24934         (test_test_expectations):
24935
24936 2012-01-11  Ojan Vafai  <ojan@chromium.org>
24937
24938         Style skipped tests in the flakiness dashboard
24939         https://bugs.webkit.org/show_bug.cgi?id=76091
24940
24941         Reviewed by Tony Chang.
24942
24943         * TestResultServer/static-dashboards/dashboard_base.js:
24944         Removed "FLAKY" from this list since we don't ever mark individual runs
24945         as flaky. Also deleted an outdated line.
24946         * TestResultServer/static-dashboards/flakiness_dashboard.html:
24947
24948 2012-01-11  Ojan Vafai  <ojan@chromium.org>
24949
24950         Remove gtest normalization code from the test results server
24951         https://bugs.webkit.org/show_bug.cgi?id=76089
24952
24953         Reviewed by Tony Chang.
24954
24955         The normalization now happens on the gtest side.
24956
24957         * TestResultServer/model/jsonresults.py:
24958         (JsonResults.merge):
24959         * TestResultServer/model/jsonresults_unittest.py:
24960         (JsonResultsTest.test_gtest):
24961
24962 2012-01-11  Ojan Vafai  <ojan@chromium.org>
24963
24964         Be more aggressive about deleting unnecessary results from the test-results-server json files
24965         https://bugs.webkit.org/show_bug.cgi?id=76086
24966
24967         Reviewed by Tony Chang.
24968
24969         Remove any tests that only contain skip/pass/nodata values whose runtime
24970         is less than 5 seconds.
24971
24972         * TestResultServer/model/jsonresults.py:
24973         (JsonResults._normalize_results_json):
24974         * TestResultServer/model/jsonresults_unittest.py:
24975         (JsonResultsTest.test_merge_remove_test):
24976         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
24977
24978 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
24979
24980         last-green-revision should give us per-bot information
24981         https://bugs.webkit.org/show_bug.cgi?id=76011
24982
24983         Reviewed by Adam Barth.
24984
24985         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
24986         we report the latest green run on each bot from the last 100 runs.
24987
24988         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
24989         (BuildBot._fetch_builder_page):
24990         (BuildBot):
24991         (BuildBot._green_revision_for_builder):
24992         (BuildBot.last_green_revision):
24993         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
24994         (test_green_revision_for_builder):
24995         (test_last_green_revision):
24996         * Scripts/webkitpy/tool/bot/irc_command.py:
24997         (LastGreenRevision.execute):
24998         * Scripts/webkitpy/tool/commands/queries.py:
24999         (LastGreenRevision.execute):
25000
25001 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
25002
25003         webkitpy: clean up version detection in webkitpy.layout_tests.port
25004         https://bugs.webkit.org/show_bug.cgi?id=76016
25005
25006         Reviewed by Adam Barth.
25007
25008         This change updates the code in webkitpy.layout_tests.port to
25009         use the new os_name and os_version fields on host.platform. This
25010         gets layout_tests.port out of the version parsing business. Most
25011         of the diffs are just cleaning up test code to accomodate the
25012         changes.
25013
25014         * Scripts/webkitpy/common/system/executive_mock.py:
25015         (MockExecutive):
25016         (MockExecutive.ignore_error):
25017         (MockExecutive2):
25018         (MockExecutive2.ignore_error):
25019         * Scripts/webkitpy/common/system/platforminfo_mock.py:
25020         (MockPlatformInfo.is_mac):
25021         (MockPlatformInfo.is_linux):
25022         (MockPlatformInfo.is_win):
25023         * Scripts/webkitpy/common/system/systemhost_mock.py:
25024         (MockSystemHost.__init__):
25025         * Scripts/webkitpy/layout_tests/port/apple.py:
25026         (ApplePort.__init__):
25027         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
25028         (ChromiumMacPort.__init__):
25029         (ChromiumMacPort.check_wdiff):
25030         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
25031         (ChromiumMacPortTest):
25032         (ChromiumMacPortTest.assert_name):
25033         (ChromiumMacPortTest.test_versions):
25034         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
25035         (ChromiumPortTest.test_all_test_configurations):
25036         (ChromiumPortTest.TestMacPort.__init__):
25037         (ChromiumPortTest.TestLinuxPort.__init__):
25038         (ChromiumPortTest.TestWinPort.__init__):
25039         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
25040         (ChromiumWinPort.__init__):
25041         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
25042         (ChromiumWinTest):
25043         (ChromiumWinTest.assert_name):
25044         (ChromiumWinTest.test_versions):
25045         (ChromiumWinTest.test_baseline_path):
25046         (ChromiumWinTest.test_build_path):
25047         * Scripts/webkitpy/layout_tests/port/factory.py:
25048         (PortFactory._port_name_from_arguments_and_options):
25049         (PortFactory.get):
25050         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
25051         (FactoryTest):
25052         (FactoryTest.setUp):
25053         (FactoryTest.assert_port):
25054         (FactoryTest.test_mac):
25055         (FactoryTest.test_win):
25056         (FactoryTest.test_google_chrome):
25057         (FactoryTest.test_gtk):
25058         (FactoryTest.test_qt):
25059         (FactoryTest.test_chromium_gpu):
25060         (FactoryTest.test_chromium_gpu_linux):
25061         (FactoryTest.test_chromium_gpu_mac):
25062         (FactoryTest.test_chromium_gpu_win):
25063         (FactoryTest.test_chromium_mac):
25064         (FactoryTest.test_chromium_linux):
25065         (FactoryTest.test_chromium_win):
25066         (FactoryTest.test_unknown_specified):
25067         (FactoryTest.test_unknown_default):
25068         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
25069         (TestGoogleChromePort):
25070         (TestGoogleChromePort._verify_baseline_path):
25071         (TestGoogleChromePort._verify_expectations_overrides):
25072         (TestGoogleChromePort.test_get_google_chrome_port):
25073         * Scripts/webkitpy/layout_tests/port/mac.py:
25074         (MacPort):
25075         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
25076         (MacTest):
25077         (assert_name):
25078         (test_tests_for_other_platforms):
25079         (test_version):
25080         (test_versions):
25081         (test_is_version_methods):
25082         (test_setup_environ_for_server):
25083         (_assert_search_path):
25084         (test_show_results_html_file):
25085         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
25086         (PortTestCase):
25087         (PortTestCase.make_port):
25088         * Scripts/webkitpy/layout_tests/port/win.py:
25089         (WinPort):
25090         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
25091         (WinPortTest):
25092         (WinPortTest.test_show_results_html_file):
25093         (WinPortTest._assert_search_path):
25094         (WinPortTest._assert_version):
25095
25096 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
25097
25098         [Qt][WK2] Remove workaround introduced into bug 75470
25099         https://bugs.webkit.org/show_bug.cgi?id=75889
25100
25101         Reviewed by Tor Arne Vestbø.
25102
25103         * MiniBrowser/qt/qml/BrowserWindow.qml:
25104
25105 2012-01-10  Dmitry Lomov  <dslomov@google.com>
25106
25107         [Chromium] Remove obsolete references to WebWorker class.
25108         https://bugs.webkit.org/show_bug.cgi?id=76020
25109
25110         Reviewed by David Levin.
25111
25112         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
25113         * DumpRenderTree/chromium/WebViewHost.cpp:
25114         * DumpRenderTree/chromium/WebViewHost.h:
25115
25116 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
25117
25118         [Qt] Some css3 filter tests are failing after r104698
25119         https://bugs.webkit.org/show_bug.cgi?id=76055
25120
25121         Reviewed by Simon Hausmann.
25122
25123         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
25124         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
25125
25126 2012-01-11  Tony Chang  <tony@chromium.org>
25127
25128         Don't remove 0 byte files when running build-webkit --chromium
25129         https://bugs.webkit.org/show_bug.cgi?id=75997
25130
25131         Reviewed by Csaba Osztrogonác.
25132
25133         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
25134
25135         * Scripts/webkitdirs.pm:
25136         (determineIsQt):
25137
25138 2012-01-10  David Kilzer  <ddkilzer@apple.com>
25139
25140         Add TestWebKitAPI tests for KURL
25141         <http://webkit.org/b/75774>
25142
25143         Reviewed by Adam Barth.
25144
25145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
25146         WebCore folder and KURL.cpp source file to the project.
25147         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
25148         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
25149         during setup since this test doesn't go through WebKit or
25150         WebKit2.
25151         (TestWebKitAPI::TEST_F): Add two basic tests.
25152
25153 2012-01-10  David Kilzer  <ddkilzer@apple.com>
25154
25155         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
25156
25157         Reviewed by Adam Barth.
25158
25159         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
25160
25161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
25162         WTFStringUtilities.h to the project.
25163         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
25164         WTFStringUtilities.h.
25165         * TestWebKitAPI/WTFStringUtilities.h: Added.
25166         (WTF::operator<<):
25167
25168 2012-01-10  Vincent Scheib  <scheib@chromium.org>
25169
25170         Clarify run-webkit-tests options reset-results and new-baseline
25171         https://bugs.webkit.org/show_bug.cgi?id=75993
25172
25173         Reviewed by Dirk Pranke.
25174
25175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
25176         (parse_args):
25177
25178 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
25179
25180         Disabled mock scrollbars should draw differently
25181         https://bugs.webkit.org/show_bug.cgi?id=75995
25182
25183         Reviewed by James Robinson.
25184
25185         When the scrollbar is disabled, paint the entire track of
25186         mock scrollbars with a lighter gray, and hide the thumb.
25187
25188         * DumpRenderTree/mac/DumpRenderTree.mm:
25189         (-[DRTMockScroller drawKnob]):
25190         (-[DRTMockScroller drawRect:]):
25191
25192 2012-01-10  James Robinson  <jamesr@chromium.org>
25193
25194         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
25195         https://bugs.webkit.org/show_bug.cgi?id=75988
25196
25197         Reviewed by Adam Barth.
25198
25199         * Scripts/webkitpy/common/config/ports.py:
25200         (WebKitPort.run_webkit_unit_tests_command):
25201         (WebKitPort):
25202         (ChromiumPort.run_webkit_unit_tests_command):
25203         (ChromiumPort):
25204         * Scripts/webkitpy/common/config/ports_mock.py:
25205         (MockPort.run_webkit_unit_tests_command):
25206         * Scripts/webkitpy/tool/commands/download_unittest.py:
25207         (DownloadCommandsTest.test_build_and_test):
25208         (test_land):
25209         (test_land_red_builders):
25210         * Scripts/webkitpy/tool/steps/runtests.py:
25211         (RunTests.run):
25212         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
25213
25214 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
25215
25216         webkitpy: add os_name, os_version to platforminfo
25217         https://bugs.webkit.org/show_bug.cgi?id=75931
25218
25219         Reviewed by Eric Siedel.
25220
25221         As a first step in cleaning up the version parsing logic in
25222         webkitpy.layout_tests.port, this adds common routines for
25223         getting the os_name and os_version fields to the PlatformInfo
25224         class. Nothing uses them yet but I've added FIXME's to some of
25225         the code that needs to be deleted in the port files.
25226
25227         * Scripts/webkitpy/common/system/platforminfo.py:
25228         (PlatformInfo.__init__):
25229         (PlatformInfo):
25230         (PlatformInfo._determine_os_name):
25231         (PlatformInfo._determine_mac_version):
25232         (PlatformInfo._determine_linux_version):
25233         (PlatformInfo._determine_win_version):
25234         (PlatformInfo.display_name):
25235         (PlatformInfo.total_bytes_memory):
25236         (PlatformInfo._compute_bytes_from_vm_stat_output):
25237         (PlatformInfo.free_bytes_memory):
25238         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
25239         (TestPlatformInfo):
25240         (TestPlatformInfo.make_info):
25241         (TestPlatformInfo.make_info.mock_run_command):
25242         (TestPlatformInfo.setUp):
25243         (TestPlatformInfo.tearDown):
25244         (TestPlatformInfo.test_basic):
25245         (TestPlatformInfo.integration_test_basic):
25246         (TestPlatformInfo.test_display_name_mac):
25247         (TestPlatformInfo.test_display_name_win32):
25248         (TestPlatformInfo.test_memory_mac):
25249         (TestPlatformInfo.test_memory_win32):
25250         (TestPlatformInfo.test_determine_os_name):
25251         (TestPlatformInfo.test_determine_mac_version):
25252         (TestPlatformInfo.test_determine_linux_version):
25253         (TestPlatformInfo.test_determine_win_version_from_tuple):
25254         (TestPlatformInfo.test_determine_win_version_from_cmd):
25255         * Scripts/webkitpy/layout_tests/port/apple.py:
25256         (ApplePort.__init__):
25257         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
25258         (ChromiumMacPort.__init__):
25259         * Scripts/webkitpy/layout_tests/port/mac.py:
25260         (MacPort):
25261         * Scripts/webkitpy/layout_tests/port/win.py:
25262         (WinPort):
25263
25264 2012-01-10  Adam Roben  <aroben@apple.com>
25265
25266         Make it possible to type data: URLs into MiniBrowser on Windows
25267
25268         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
25269         MiniBrowser on Windows
25270
25271         Reviewed by Darin Adler.
25272
25273         * MiniBrowser/win/BrowserWindow.cpp:
25274         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
25275         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
25276         does, we assume it already has a scheme and don't modify it.
25277
25278 2012-01-10  Adam Roben  <aroben@apple.com>
25279
25280         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
25281
25282         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
25283         MiniBrowser on Windows
25284
25285         Reviewed by Darin Adler.
25286
25287         * MiniBrowser/win/BrowserView.cpp:
25288         (BrowserView::goToURL): Pass the typed string through
25289         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
25290
25291 2012-01-10  Ben Wells  <benwells@chromium.org>
25292
25293         Adding myself (benwells) to committers.py
25294         https://bugs.webkit.org/show_bug.cgi?id=75971
25295
25296         Reviewed by Ojan Vafai.
25297
25298         * Scripts/webkitpy/common/config/committers.py:
25299
25300 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
25301
25302         AX: support helpText() in DumpRenderTree
25303         https://bugs.webkit.org/show_bug.cgi?id=40193
25304
25305         Reviewed by Chris Fleizach.
25306
25307         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
25308         (AccessibilityUIElement::helpText): Implemented.
25309
25310 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
25311
25312         Unreviewed, rolling out r104572.
25313         http://trac.webkit.org/changeset/104572
25314         https://bugs.webkit.org/show_bug.cgi?id=75967
25315
25316         It broke zillion tests (Requested by Ossy on #webkit).
25317
25318         * DumpRenderTree/qt/EventSenderQt.cpp:
25319         (EventSender::EventSender):
25320         (EventSender::sendOrQueueEvent):
25321         (EventSender::replaySavedEvents):
25322         (EventSender::eventFilter):
25323         * DumpRenderTree/qt/EventSenderQt.h:
25324
25325 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
25326
25327         [Qt] fast/events/dont-loose-last-event test fails on WK1
25328         https://bugs.webkit.org/show_bug.cgi?id=73894
25329
25330         Reviewed by Simon Hausmann.
25331
25332         Empty the entire event queue when requested besides using
25333         sendEvent instead of postEvent to make sure all events were
25334         delivered.
25335         This commit also removes not working DRT code to handle drag and drop,
25336         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
25337
25338         * DumpRenderTree/qt/EventSenderQt.cpp:
25339         (EventSender::EventSender):
25340         (EventSender::sendOrQueueEvent):
25341         (EventSender::replaySavedEvents):
25342         * DumpRenderTree/qt/EventSenderQt.h:
25343
25344 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
25345
25346         [Qt] Enable CSS_FILTERS in Qt build
25347         https://bugs.webkit.org/show_bug.cgi?id=75777
25348
25349         Add the CSS_FILTERS feature flag to Qt.
25350
25351         Reviewed by Kenneth Rohde Christiansen.
25352
25353         * qmake/mkspecs/features/features.prf:
25354
25355 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
25356
25357         [Qt] Unreviewed -Werror build fix.
25358
25359         * MiniBrowser/qt/MiniBrowserApplication.cpp:
25360         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
25361         declaration.
25362
25363 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
25364
25365         [Qt] Remove dependency to uitools
25366         https://bugs.webkit.org/show_bug.cgi?id=75952
25367
25368         Reviewed by Tor Arne Vestbø.
25369
25370         QUiLoader is used for creating QLabel/QProgressBar widgets for
25371         a layout test, to verify some widget embedding feature. Unfortunately
25372         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
25373         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
25374         let's break the circular dependency.
25375
25376         * DumpRenderTree/qt/DumpRenderTree.pro:
25377         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
25378         (WebCore::WebPage::createPlugin):
25379         * QtTestBrowser/QtTestBrowser.pro:
25380         * QtTestBrowser/launcherwindow.h:
25381         * QtTestBrowser/webpage.cpp:
25382         (WebPage::createPlugin):
25383         * qmake/mkspecs/features/minimal_qt.prf:
25384         * qmake/mkspecs/features/uitools.prf: Removed.
25385
25386 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
25387
25388         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
25389         https://bugs.webkit.org/show_bug.cgi?id=75894
25390
25391         Reviewed by Tor Arne Vestbø.
25392
25393         * MiniBrowser/qt/MiniBrowserApplication.h:
25394         (MiniBrowserApplication::windowOptions):
25395         * MiniBrowser/qt/main.cpp:
25396         (main):
25397
25398 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
25399
25400         [Qt] DRT crashes with Qt 5
25401         https://bugs.webkit.org/show_bug.cgi?id=75951
25402
25403         Reviewed by Ossy.
25404
25405         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
25406         Qt relies on font-config to define the default font family.
25407
25408 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
25409
25410         [Qt] REGRESSION(r100130): Clean build feature is broken.
25411         https://bugs.webkit.org/show_bug.cgi?id=75863
25412
25413         Reviewed by Tor Arne Vestbø.
25414
25415         * Scripts/webkitdirs.pm:
25416         (buildQMakeProject):
25417
25418 2012-01-10  Zeno Albisser  <zeno@webkit.org>
25419
25420         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
25421         https://bugs.webkit.org/show_bug.cgi?id=75885
25422
25423         In QML events are propagated through parents. But since the
25424         WebView may consume key events, a shortcut might never reach
25425         the top QtQuickItem.
25426         Therefore an application wide event handling function in C++
25427         needs to take care of shortcuts for MiniBrowser.
25428
25429         Reviewed by Kenneth Rohde Christiansen.
25430
25431         * MiniBrowser/qt/BrowserWindow.cpp:
25432         (BrowserWindow::reload):
25433         (BrowserWindow::focusAddressBar):
25434         * MiniBrowser/qt/BrowserWindow.h:
25435         * MiniBrowser/qt/MiniBrowserApplication.cpp:
25436         (MiniBrowserApplication::notify):
25437         * MiniBrowser/qt/qml/BrowserWindow.qml:
25438
25439 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
25440
25441         Add --efl alias for --platform=efl to run-webkit-test
25442         https://bugs.webkit.org/show_bug.cgi?id=75937
25443
25444         Reviewed by Andreas Kling.
25445
25446         * Scripts/run-webkit-tests: Add --efl alias.
25447         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
25448         (parse_args):
25449
25450 2012-01-09  Dan Bernstein  <mitz@apple.com>
25451
25452         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
25453         https://bugs.webkit.org/show_bug.cgi?id=75920
25454
25455         Reviewed by Darin Adler.
25456
25457         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
25458         (TestWebKitAPI::TEST): Added a test for a range in a
25459         -webkit-user-select: none; block.
25460
25461 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
25462
25463         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
25464         https://bugs.webkit.org/show_bug.cgi?id=75884
25465
25466         Reviewed by Ryosuke Niwa.
25467
25468         Fix regression introduced (revealed?) in r104340. Chromium file
25469         url syntax is different on win32 and the test results weren't
25470         expecting that.
25471
25472         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
25473         (TestExpectations._report_errors):
25474         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
25475         (test_parse_error_nonfatal):
25476         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
25477         (MockDRTTest.input_line):
25478         (MockChromiumDRTTest.test_pixeltest__fails):
25479         * Scripts/webkitpy/layout_tests/port/test.py:
25480         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
25481         (TestRebaseliner.make_rebaseliner):
25482         (TestRebaseliner.test_one_platform):
25483         (TestRebaseliner.test_all_platforms):
25484         (TestRebaseliner.test_png_file_with_comment):
25485         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
25486         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
25487         (TestRealMain.test_all_platforms):
25488
25489 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
25490
25491         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
25492
25493         Unreviewed, build fix.
25494
25495         test-webkitpy had a built-in self-test routine to verify that
25496         deleting the .pyc files worked correctly. When I removed the
25497         python24 directory in r104482, I broke the self-test.
25498
25499         I have deleted the self-test for now. Since I am reworking
25500         test-webkitpy I will make sure the new version is adequately
25501         tested.
25502
25503         * Scripts/test-webkitpy:
25504         (configure_logging):
25505         (_clean_pyc_files):
25506         (_clean_packages):
25507         (init):
25508
25509 2012-01-09  Justin Novosad  <junov@chromium.org>
25510
25511         [Chromium] remove all references to the legacy accelerated 2d Canvas
25512         implementation
25513         https://bugs.webkit.org/show_bug.cgi?id=75108
25514
25515         Purging an old settings flag that is no longer referenced
25516
25517         Reviewed by Darin Fisher.
25518
25519         * DumpRenderTree/chromium/DumpRenderTree.cpp:
25520         (main):
25521         * DumpRenderTree/chromium/TestShell.cpp:
25522         (TestShell::TestShell):
25523         (TestShell::resetWebSettings):
25524         * DumpRenderTree/chromium/TestShell.h:
25525         (TestShell::setAccelerated2dCanvasEnabled):
25526         * DumpRenderTree/chromium/WebPreferences.cpp:
25527         (WebPreferences::reset):
25528         (WebPreferences::applyTo):
25529         * DumpRenderTree/chromium/WebPreferences.h:
25530
25531 2012-01-09  Adam Roben  <aroben@apple.com>
25532
25533         Convert Cygwin paths to Windows paths before passing them to DRT
25534
25535         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
25536         NRWT
25537
25538         I couldn't find a way to test this because I couldn't figure out how to override the
25539         cygpath function as it is used by WebKitDriver.
25540
25541         Reviewed by Dirk Pranke.
25542
25543         * Scripts/webkitpy/layout_tests/port/webkit.py:
25544         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
25545         Windows-style path before passing it to DRT.
25546
25547 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
25548
25549         webkitpy: revamp version checking
25550         https://bugs.webkit.org/show_bug.cgi?id=75765
25551
25552         Reviewed by Adam Barth.
25553
25554         The version-checking code in webkitpy/python24/versioning seems really
25555         awkward and overdesigned, especially since we don't support python 2.4
25556         any more.
25557
25558         In addition, I am tired of getting warnings about Python 2.6 being "a
25559         newer release than what is supported" :).
25560
25561         I'm taking a page from the depot_tools python code and just creating a
25562         new webkitpy.common.version_check module that will print a message on
25563         stderr and call sys.exit() if we're running an unsupported version.
25564
25565         * Scripts/check-webkit-style:
25566         * Scripts/new-run-webkit-httpd:
25567         * Scripts/new-run-webkit-tests:
25568         * Scripts/rebaseline-chromium-webkit-tests:
25569         * Scripts/test-webkitpy:
25570         (configure_logging):
25571         (init):
25572         * Scripts/webkit-patch:
25573         (main):
25574         * Scripts/webkitpy/common/system/executive.py:
25575         (Executive._child_process_encoding):
25576         (Executive._should_encode_child_process_arguments):
25577         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
25578         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
25579         * Scripts/webkitpy/python24/__init__.py: Removed.
25580         * Scripts/webkitpy/python24/versioning.py: Removed.
25581         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
25582
25583 2012-01-09  Adam Barth  <abarth@webkit.org>
25584
25585         Remove Chromium Mac CG from the flakiness dashboard
25586         https://bugs.webkit.org/show_bug.cgi?id=75873
25587
25588         Reviewed by Ojan Vafai.
25589
25590         This configuration no longer exists.
25591
25592         * TestResultServer/static-dashboards/builders.js:
25593         * TestResultServer/static-dashboards/flakiness_dashboard.html:
25594         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
25595         (testOverrideJustBuildType):
25596         (testPlatformAndBuildType):
25597
25598 2012-01-06  Adam Roben  <aroben@apple.com>
25599
25600         Print an error message when NRWT can't run Apache
25601
25602         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
25603
25604         Reviewed by Dirk Pranke.
25605
25606         * Scripts/webkitpy/layout_tests/port/base.py:
25607         (Port.check_httpd): Print an error message when Apache returns an error code instead of
25608         failing silently.
25609
25610         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
25611         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
25612         run Apache.
25613         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
25614         fails.
25615
25616 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
25617
25618         [Gtk][ARM] Cross compiler buildbot is failing after r103040
25619         https://bugs.webkit.org/show_bug.cgi?id=75846
25620
25621         Reviewed by Philippe Normand.
25622
25623         * Scripts/webkitdirs.pm:
25624         (runAutogenForAutotoolsProjectIfNecessary):
25625
25626 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
25627
25628         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
25629         https://bugs.webkit.org/show_bug.cgi?id=75807
25630
25631         This patch adds a new icon to navigationbar of the Qt MiniBrowser
25632         which allows you to dynamically toggle whether touch mocking is
25633         enabled or disabled.
25634
25635         Reviewed by Tor Arne Vestbø.
25636
25637         * MiniBrowser/qt/MiniBrowser.qrc:
25638         * MiniBrowser/qt/MiniBrowserApplication.cpp:
25639         (MiniBrowserApplication::notify):
25640         * MiniBrowser/qt/MiniBrowserApplication.h:
25641         (WindowOptions::WindowOptions):
25642         (WindowOptions::touchMockingEnabled):
25643         (WindowOptions::setTouchMockingEnabled):
25644         * MiniBrowser/qt/icons/touch.png: Added.
25645         * MiniBrowser/qt/qml/BrowserWindow.qml:
25646
25647 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
25648
25649         Unreviewed. Fix make distcheck issues.
25650
25651         * MiniBrowser/gtk/GNUmakefile.am:
25652
25653 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
25654
25655         Unreviewed, rolling out r104421.
25656         http://trac.webkit.org/changeset/104421
25657         https://bugs.webkit.org/show_bug.cgi?id=75816
25658
25659         Need to rebaseline some tests on Linux (Requested by noamr on
25660         #webkit).
25661
25662         * qmake/mkspecs/features/features.prf:
25663
25664 2012-01-08  Adam Barth  <abarth@webkit.org>
25665
25666         Remove support for Chromium Mac CG from garden-o-matic
25667         https://bugs.webkit.org/show_bug.cgi?id=75814
25668
25669         Reviewed by Eric Seidel.
25670
25671         This configuration no longer exists.  This patch is mostly a matter of
25672         updating config.js and removing the examples from the unit tests.
25673
25674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
25675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
25676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
25677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
25678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
25679
25680 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
25681
25682         [Qt] Enable CSS_FILTERS in Qt build
25683         https://bugs.webkit.org/show_bug.cgi?id=75777
25684
25685         Add the CSS_FILTERS feature flag to Qt.
25686
25687         Reviewed by Kenneth Rohde Christiansen.
25688
25689         * qmake/mkspecs/features/features.prf:
25690
25691 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
25692
25693         Categorize bots by ports instead of core/non-core separation
25694         https://bugs.webkit.org/show_bug.cgi?id=75766
25695
25696         Reviewed by Eric Seidel.
25697
25698         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
25699         (Chromium still comes before GTK and Qt).
25700
25701         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25702         (loadBuilderConfig):
25703         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
25704
25705 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
25706
25707         Remove the concept of core builders from webkitpy
25708         https://bugs.webkit.org/show_bug.cgi?id=75809
25709
25710         Reviewed by Ryosuke Niwa.
25711
25712         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
25713         and remove the relevant code.
25714
25715         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
25716         (BuildBot.__init__):
25717         (BuildBot._matches_regexps):
25718         (BuildBot._builder_statuses_with_names_matching_regexps):
25719         (BuildBot.builder_statuses):
25720         (BuildBot.failure_map):
25721         (BuildBot._latest_builds_from_builders):
25722         (BuildBot.last_green_revision):
25723         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
25724         (MockBuildBot.builder_statuses):
25725         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
25726         (test_status_parsing):
25727         (test_last_green_revision):
25728         (test_last_green_revision.mock_builds_from_builders):
25729
25730 2012-01-08  Adam Barth  <abarth@webkit.org>
25731
25732         Remove Chromium Mac CG concept from webkitpy
25733         https://bugs.webkit.org/show_bug.cgi?id=75810
25734
25735         Reviewed by Ryosuke Niwa.
25736
25737         This configuration no longer exists.  We can remove all the supporting
25738         code from webkitpy.
25739
25740         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
25741         (BaselineOptimizerTest.test_move_baselines):
25742         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
25743         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
25744         (BaselineOptimizerTest.test_common_directory_includes_root):
25745         (BaselineOptimizerTest.test_complex_shadowing):
25746         * Scripts/webkitpy/common/config/build.py:
25747         (_should_file_trigger_build):
25748         * Scripts/webkitpy/common/config/build_unittest.py:
25749         (ShouldBuildTest):
25750         * Scripts/webkitpy/layout_tests/port/builders.py:
25751         * Scripts/webkitpy/layout_tests/port/chromium.py:
25752         (ChromiumPort):
25753         (ChromiumPort._generate_all_test_configurations):
25754         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
25755         (_default_tests_paths):
25756         (ChromiumGpuLinuxPort.tests):
25757         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
25758         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
25759         (ChromiumGpuTest.assert_port_works):
25760         (ChromiumGpuTest.test_baseline_paths):
25761         (ChromiumGpuTest.test_graphics_type):
25762         (ChromiumGpuTest.test_default_tests_paths):
25763         (ChromiumGpuTest.test_test_files):
25764         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
25765         (ChromiumMacPort):
25766         (ChromiumMacPort.__init__):
25767         (ChromiumMacPort.baseline_search_path):
25768         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
25769         (ChromiumMacPortTest.test_graphics_type):
25770         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
25771         (ChromiumPortTest.test_all_test_configurations):
25772         * Scripts/webkitpy/layout_tests/port/dryrun.py:
25773         * Scripts/webkitpy/layout_tests/port/factory.py:
25774         (PortFactory._port_name_from_arguments_and_options):
25775         (PortFactory.get):
25776         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
25777         (FactoryTest.test_chromium_gpu_mac):
25778         (FactoryTest.test_chromium_mac):
25779         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
25780         (GetGoogleChromePortTest._verify_expectations_overrides):
25781         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
25782         (MockChromiumDRTTest.test_chromium_parse_options):
25783         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
25784         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
25785         (test_url_fetcher):
25786         (test_zip_factory):
25787         (test_archive):
25788         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
25789         (TestRebaseline.test_rebaseline_expectations):
25790
25791 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
25792
25793         Categorize bots by ports instead of core/non-core separation
25794         https://bugs.webkit.org/show_bug.cgi?id=75766
25795
25796         Reviewed by Adam Barth.
25797
25798         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
25799
25800         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
25801         (loadBuilderConfig):
25802         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
25803
25804 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
25805
25806         Unreviewed, rolling out r104403.
25807         http://trac.webkit.org/changeset/104403
25808         https://bugs.webkit.org/show_bug.cgi?id=75803
25809
25810         It broke all tests on Qt5 (Requested by Ossy_weekend on
25811         #webkit).
25812
25813         * qmake/mkspecs/features/features.prf:
25814
25815 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
25816
25817         [Qt] Enable CSS_FILTERS in Qt build
25818         https://bugs.webkit.org/show_bug.cgi?id=75777
25819
25820         Add the CSS_FILTERS feature flag to Qt.
25821
25822         Reviewed by Kenneth Rohde Christiansen.
25823
25824         * qmake/mkspecs/features/features.prf:
25825
25826 2012-01-04  Kentaro Hara  <haraken@chromium.org>
25827
25828         Rewrite the CSS parser of prepare-ChangeLog with unittests.
25829         https://bugs.webkit.org/show_bug.cgi?id=75202
25830
25831         Reviewed by David Kilzer.
25832
25833         The current CSS parser can just parse simple CSSes like
25834
25835             foo bar baz {
25836                 property1: value;
25837                 property2: value;
25838             }
25839
25840         , and cannot parse comments nor a CSS in which a selector and {
25841         appears in different lines. This patch rewrites the CSS parser
25842         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
25843         shown in css_unittests.css.
25844
25845         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
25846
25847         * Scripts/prepare-ChangeLog:
25848         (get_selector_line_ranges_for_css):
25849         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
25850         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
25851         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
25852         (element1):
25853         (element2):
25854         (element3):
25855         (element4.p):
25856         (element5.p.q.r.s):
25857         (element6#p):
25858         (element7 element8):
25859         (element9.p element10.q):
25860         (element11#p element12#q):
25861         (element13, element14):
25862         (.p):
25863         (#p):
25864         (.p element15 #q element16.r element17#s):
25865         (element18:target):
25866         (element19):
25867         (element20):
25868         (element21):
25869         (element22):
25870
25871 2012-01-04  Kentaro Hara  <haraken@chromium.org>
25872
25873         The Perl parser of prepare-ChangeLog can parse here-documents
25874         https://bugs.webkit.org/show_bug.cgi?id=73208
25875
25876         Reviewed by David Kilzer.
25877
25878         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
25879         which results in wrong subroutine names in ChangeLogs.
25880         With this patch, prepare-ChangeLog can judge whether the line of "}"
25881         is the end of a subroutine or a line inside a here-document.
25882
25883         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
25884
25885         * Scripts/prepare-ChangeLog:
25886         (get_function_line_ranges_for_perl):
25887         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
25888         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
25889         Added test cases for here-documents.
25890         (func7):
25891         (func8):
25892         (func9):
25893         (func10):
25894         (func11):
25895         (func12):
25896         (func13):
25897         (func14):
25898         (func15):
25899         (func16):
25900
25901 2012-01-08  Kentaro Hara  <haraken@chromium.org>
25902
25903         Add unittests for the JavaScript parser of prepare-ChangeLog
25904         https://bugs.webkit.org/show_bug.cgi?id=75201
25905
25906         Reviewed by David Kilzer.
25907
25908         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
25909         of prepare-ChangeLog.
25910
25911         * Scripts/prepare-ChangeLog:
25912         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
25913         omitted from parsing. Thus,
25914
25915             str = "foo"
25916             function func() {
25917             }
25918
25919         was recognized as equivalent to
25920
25921             str = function func() {
25922             }
25923
25924         This patch replaces a string with a dummy identifier 'string_appeared_here'
25925         to tell the parser that a string appeared there.
25926
25927         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
25928         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
25929         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
25930         (func1):
25931         (func2):
25932         (func3):
25933         (func4):
25934         (func5):
25935         (func6):
25936         (func7):
25937         (func8):
25938         (func9):
25939         (func10):
25940         (func11):
25941         (func12):
25942         (funcOverloaded):
25943         (Func1.prototype.get x1):
25944         (Func1.prototype.get x2):
25945         (Func1.prototype.set x1):
25946         (Func1.prototype.set x3):
25947         (Func2.prototype.func13):
25948         (Func2.prototype.func14):
25949         (Func2.prototype.func15):
25950         (func16.func17):
25951         (func16.func18):
25952         (func16.func19):
25953         (func16):
25954
25955 2012-01-08  David Levin  <levin@chromium.org>
25956
25957         [chromium] Add layout test support for autosize code in FrameView.
25958         https://bugs.webkit.org/show_bug.cgi?id=73631
25959
25960         Reviewed by Dmitry Titov.
25961
25962         * DumpRenderTree/chromium/LayoutTestController.cpp:
25963         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
25964         (LayoutTestController::reset): Set the autoresize mode back to false.
25965         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
25966         * DumpRenderTree/chromium/LayoutTestController.h:
25967         * DumpRenderTree/chromium/WebViewHost.cpp:
25968         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
25969         * DumpRenderTree/chromium/WebViewHost.h:
25970
25971 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
25972
25973         [WK2][GTK] Each test takes roughly half a second to load
25974         https://bugs.webkit.org/show_bug.cgi?id=70699
25975
25976         Reviewed by Martin Robinson.
25977
25978         Set the XDG_CACHE_HOME environment variable when testing with
25979         WebKitTestRunner. This way the testing is started with a non-existing
25980         application cache. If the cache exists and is not empty, the emptying
25981         and vacuuming that is performed before every test can consume a lot of
25982         time.
25983
25984         This is just a temporary workaround until it becomes possible to set
25985         a desired directory to be used as the application cache location through
25986         WebKitWebContext.
25987
25988         * Scripts/webkitpy/layout_tests/port/gtk.py:
25989         (GtkPort.setup_environ_for_server):
25990
25991 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
25992
25993         [GTK] Enable requestAnimationFrame in build-webkit
25994         https://bugs.webkit.org/show_bug.cgi?id=75773
25995
25996         Reviewed by Martin Robinson.
25997
25998         Enable requestAnimationFrame for the Gtk port.
25999
26000         * Scripts/build-webkit:
26001
26002 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
26003
26004         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
26005
26006         * Scripts/webkitdirs.pm:
26007         (buildChromium):
26008         Missing parentheses.
26009
26010 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
26011
26012         Fix DRT build on case-sensitive file systems.
26013
26014         Fix case of include of WebDynamicScrollBarsView.h
26015
26016         * DumpRenderTree/mac/DumpRenderTree.mm:
26017
26018 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
26019
26020         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
26021         https://bugs.webkit.org/show_bug.cgi?id=75662
26022
26023         Reviewed by Dan Bernstein.
26024
26025         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
26026         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
26027         test window uses the main display's color space, so that the pixel values in the bitmap
26028         that gets checksummed are identical to the CSS colors.
26029
26030         Removed the code that switches the display profile in DRT, since that is no longer required.
26031
26032         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
26033         * DumpRenderTree/mac/DumpRenderTree.mm:
26034         (crashHandler): Remove code that switches display profiles.
26035         (prepareConsistentTestingEnvironment): Ditto.
26036         (dumpRenderTree): Ditto.
26037         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
26038         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
26039         (createBitmapContextFromWebView): Add comment about the colorspace handling.
26040         * WebKitTestRunner/cg/TestInvocationCG.cpp:
26041         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
26042         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
26043         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
26044         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
26045         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
26046
26047 2012-01-06  David Kilzer  <ddkilzer@apple.com>
26048
26049         run-api-tests: specify individual suites and tests on the command-line
26050
26051         Reviewed by Adam Roben.
26052
26053         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
26054
26055         The run-api-tests script will now accept a list of arguments on
26056         the command-line that are used as prefix filters.  To run all
26057         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
26058         use:
26059
26060             $ run-api-tests WTF
26061
26062         To run only the tests in the "WTF" suite, not the "WTF_Vector"
26063         suite, use:
26064
26065             $ run-api-tests WTF.
26066
26067         * Scripts/run-api-tests: Filter tests if any prefix arguments
26068         are passed on the command-line.
26069
26070 2012-01-06  David Kilzer  <ddkilzer@apple.com>
26071
26072         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
26073
26074         Reviewed by Adam Roben.
26075
26076         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
26077
26078         * Scripts/run-api-tests:
26079         (dumpTestsBySuite): Update to accept array of tests instead of
26080         hash data structure.
26081         (runTestsBySuite): Ditto.
26082         (listAllTests): Rename from populateTests().  Update to return
26083         an array of tests instad of the hash data structure.
26084
26085 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
26086
26087         webkitpy: clean up test/uri conversion routines
26088         https://bugs.webkit.org/show_bug.cgi?id=75648
26089
26090         Reviewed by Eric Seidel.
26091
26092         This change moves test_to_uri and uri_to_test from the Port
26093         class to the Driver class (the routines were only being
26094         called by the drivers), and removes a bunch of stale and/or
26095         busted logic.
26096
26097         * Scripts/webkitpy/layout_tests/port/base.py:
26098         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
26099         * Scripts/webkitpy/layout_tests/port/chromium.py:
26100         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
26101         * Scripts/webkitpy/layout_tests/port/driver.py:
26102         (is_http_test):
26103         (test_to_uri):
26104         (uri_to_test):
26105         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
26106         (run_one_test):
26107         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
26108         (MockDRTTest.input_line):
26109         (input_line):
26110         (expected_output):
26111         * Scripts/webkitpy/layout_tests/port/test.py:
26112         * Scripts/webkitpy/layout_tests/port/webkit.py:
26113         (_command_from_driver_input):
26114
26115 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
26116
26117         Mitigate scrollbar differences when running pixel tests
26118         https://bugs.webkit.org/show_bug.cgi?id=67217
26119
26120         Reviewed by Dan Bernstein.
26121
26122         Add an NSScroller subclass that draws mock scrollbars identically
26123         to the WebCore mock scrollbar theme, and register it with the
26124         WebDynamicScrollbarsView.
26125
26126         * DumpRenderTree/mac/DumpRenderTree.mm:
26127         (-[DRTMockScroller rectForPart:]):
26128         (-[DRTMockScroller drawKnob]):
26129         (-[DRTMockScroller drawRect:]):
26130         (registerMockScrollbars):
26131         (prepareConsistentTestingEnvironment):
26132
26133 2012-01-05  Jon Lee  <jonlee@apple.com>
26134
26135         Update DRT on Mac to draw resize handles on text areas.
26136
26137         Reviewed by John Sullivan.
26138
26139         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
26140         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
26141
26142         * DumpRenderTree/mac/DumpRenderTree.mm:
26143         (resetDefaultsToConsistentValues):
26144
26145 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26146
26147         [Qt] Move listing of include paths and libs to pri files in sources
26148
26149         Includepaths are sometimes modified by non-Qt contributors so keeping
26150         them in files inside Sources makes it more likely that they are updated
26151         along with project files for the other ports.
26152
26153         Using pri files instead of prf files for this also has the benefit that
26154         the include() from the main target file can be parsed and followed by
26155         Qt Creator -- something that does not work with load().
26156
26157         Dependency from a target to a library through the WEBKIT variable are
26158         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
26159         set the source root of the module and include the right pri file.
26160
26161         Ideally we'd use the variant of include() that takes an optional
26162         namespace to read the variables into, or the fromfile() function,
26163         but both of these add an overhead of about 40% on the total qmake
26164         runtime, due to making a deep copy of all the variables in the
26165         project or re-reading all the prf files from scratch.
26166
26167         Reviewed by Simon Hausmann.
26168         Reviewed by Ossy.
26169
26170         * qmake/mkspecs/features/default_post.prf:
26171         * qmake/mkspecs/modules/javascriptcore.prf: Added.
26172         * qmake/mkspecs/modules/webcore.prf: Added.
26173         * qmake/mkspecs/modules/webkit2.prf: Added.
26174         * qmake/mkspecs/modules/wtf.prf: Added.
26175
26176 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
26177
26178         [EFL] Add pre-render handling code in EWebLauncher.
26179         https://bugs.webkit.org/show_bug.cgi?id=73430
26180
26181         Reviewed by Zoltan Herczeg.
26182
26183         Add pre-render handling code by pressing Insert key.
26184
26185         * EWebLauncher/main.c:
26186         (on_key_down):
26187
26188 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
26189
26190         NRWT should use test_expectation.txt on wk2 platforms
26191         https://bugs.webkit.org/show_bug.cgi?id=75417
26192
26193         Reviewed by Dirk Pranke.
26194
26195         * Scripts/webkitpy/layout_tests/port/webkit.py:
26196         (path_to_test_expectations_file):
26197         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
26198         (test_path_to_test_expectations_file):
26199
26200 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
26201
26202         Don't hardcode expected file URIs in as they depend on the platform
26203         https://bugs.webkit.org/show_bug.cgi?id=75666
26204
26205         Reviewed by Dirk Pranke.
26206
26207         * Scripts/webkitpy/layout_tests/port/win.py:
26208         (WinPort.show_results_html_file):
26209         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
26210         (MainTest.test_unexpected_failures):
26211         (MainTest.test_results_directory_default):
26212         (MainTest.test_results_directory_relative):
26213
26214 2012-01-05  Anders Carlsson  <andersca@apple.com>
26215
26216         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
26217         https://bugs.webkit.org/show_bug.cgi?id=75667
26218         <rdar://problem/10389454>
26219
26220         Reviewed by Kevin Decker.
26221
26222         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
26223
26224         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
26225         (PluginTest::executeScript):
26226         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
26227         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
26228         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
26229         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
26230         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
26231
26232 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
26233
26234         webkitpy: clean up port factory methods
26235         https://bugs.webkit.org/show_bug.cgi?id=75590
26236
26237         Reviewed by Eric Seidel.
26238
26239         This change consolidates much of the "factory method" logic
26240         of determining which port objects to create for a given set
26241         of configurations by merging the separate factory methods in
26242         chromium_gpu and google_chrome into PortFactory so that at least
26243         all of the logic is in one place.
26244
26245         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
26246         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
26247         * Scripts/webkitpy/layout_tests/port/factory.py:
26248         (_port_name_from_arguments_and_options):
26249         (get):
26250         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
26251         (test_google_chrome):
26252         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
26253         (GoogleChromeLinux32Port):
26254         (GoogleChromeLinux32Port.baseline_search_path):
26255         (test_expectations_overrides):
26256         (architecture):
26257         (GoogleChromeLinux64Port):
26258         (GoogleChromeLinux64Port.baseline_search_path):
26259         (GoogleChromeMacPort):
26260         (GoogleChromeMacPort.baseline_search_path):
26261         (GoogleChromeWinPort):
26262         (GoogleChromeWinPort.baseline_search_path):
26263         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
26264         (_verify_baseline_path):
26265
26266 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
26267
26268         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
26269         https://bugs.webkit.org/show_bug.cgi?id=75617
26270
26271         Reviewed by Dirk Pranke.
26272
26273         * Scripts/webkitpy/common/system/filesystem.py:
26274         (FileSystem.exists):
26275         * Scripts/webkitpy/common/system/filesystem_mock.py:
26276         (MockFileSystem.exists):
26277         * Scripts/webkitpy/common/system/filesystem_unittest.py:
26278         (GenericFileSystemTests.teardown_generic_test_dir):
26279         * Scripts/webkitpy/layout_tests/port/base.py:
26280         (Port.to.show_results_html_file):
26281         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
26282         (MainTest.test_results_directory_absolute):
26283
26284 2012-01-05  Adam Roben  <aroben@apple.com>
26285
26286         Remove some unnecessary code from old-run-webkit-tests
26287
26288         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
26289         WebKitTestRunner.
26290
26291         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
26292         Windows
26293
26294         Reviewed by Eric Seidel.
26295
26296         * Scripts/old-run-webkit-tests:
26297         (top level):
26298         (openDumpTool):
26299         Removed calls to setPathForRunningWebKitApp.
26300
26301 2012-01-05  Adam Roben  <aroben@apple.com>
26302
26303         Teach NRWT to use run-safari to open results.html on Apple's Windows port
26304
26305         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
26306         better, since we always want to open results.html using the user's build of WebKit, not
26307         whatever their default browser is.
26308
26309         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
26310         for Apple's Windows port
26311
26312         Reviewed by Eric Seidel.
26313
26314         * Scripts/webkitpy/layout_tests/port/win.py:
26315         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
26316         an obsolete comment.
26317
26318         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
26319         (WinPortTest.test_show_results_html_file): Updated expected results.
26320
26321 2012-01-05  Adam Roben  <aroben@apple.com>
26322
26323         Prepend Safari.exe's path to the command-line passed to CreateProcess
26324
26325         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
26326         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
26327         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
26328         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
26329         first argument that WebKitLauncherWin was trying to pass to it.
26330
26331         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
26332
26333         Reviewed by Steve Falkenburg.
26334
26335         * WebKitLauncherWin/WebKitLauncherWin.cpp:
26336         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
26337         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
26338
26339 2012-01-05  Adam Roben  <aroben@apple.com>
26340
26341         Stop using explicit memory management in WebKitLauncherWin
26342
26343         We now use stack-allocated STL objects instead.
26344
26345         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
26346         Safari
26347
26348         Reviewed by Steve Falkenburg.
26349
26350         * WebKitLauncherWin/WebKitLauncherWin.cpp:
26351         (getStringValue):
26352         (applePathFromRegistry):
26353         (safariInstallDir):
26354         (safariBrowserExe):
26355         (_tWinMain):
26356         Changed to use stack-allocated STL objects instead of malloc/free.
26357
26358 2012-01-05  Adam Roben  <aroben@apple.com>
26359
26360         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
26361
26362         This allows us to add the Safari and Apple Application Support directories to PATH before
26363         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
26364
26365         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
26366         Windows port of DumpRenderTree/WebKitTestRunner
26367
26368         Reviewed by Steve Falkenburg.
26369
26370         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
26371         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
26372
26373         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
26374         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
26375         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
26376
26377         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
26378         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
26379         the stub launcher.
26380
26381         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
26382         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
26383         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
26384         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
26385         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
26386         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
26387         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
26388
26389         * WebKitTestRunner/win/main.cpp:
26390         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
26391
26392 2012-01-05  Adam Roben  <aroben@apple.com>
26393
26394         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
26395
26396         This allows us to add the Safari and Apple Application Support directories to PATH before
26397         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
26398
26399         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
26400         Windows port of DumpRenderTree/WebKitTestRunner
26401
26402         Reviewed by Steve Falkenburg.
26403
26404         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
26405         which I forgot to add to this .sln when that project was created.
26406
26407         * DumpRenderTree/win/DumpRenderTree.cpp:
26408         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
26409
26410         * DumpRenderTree/win/DumpRenderTree.vcproj:
26411         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
26412         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
26413
26414         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
26415         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
26416         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
26417         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
26418         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
26419         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
26420         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
26421         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
26422
26423         * win/DLLLauncher/DLLLauncherMain.cpp:
26424         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
26425         Safari's directory to PATH so that SafariTheme.dll can be found.
26426
26427         (main):
26428         (wWinMain):
26429         Changed to use the new modifyPath function.
26430
26431 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
26432
26433         [Qt] Never enable FontConfig on Mac OS X
26434         https://bugs.webkit.org/show_bug.cgi?id=75616
26435
26436         Reviewed by Tor Arne Vestbø.
26437
26438         * qmake/mkspecs/features/features.prf:
26439
26440 2012-01-05  Alpha Lam  <hclam@chromium.org>
26441
26442         Unreviewed, rolling out r104159.
26443         http://trac.webkit.org/changeset/104159
26444         https://bugs.webkit.org/show_bug.cgi?id=75590
26445
26446         Chromium port GPU tests cannot be executed.
26447
26448         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
26449         (get):
26450         (_default_tests_paths):
26451         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
26452         (ChromiumGpuTest.assert_port_works):
26453         * Scripts/webkitpy/layout_tests/port/factory.py:
26454         (PortFactory._port_name_from_arguments_and_options):
26455         (PortFactory):
26456         (PortFactory._get_kwargs):
26457         (PortFactory.get):
26458         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
26459         (FactoryTest.test_google_chrome.names):
26460         (FactoryTest.test_google_chrome):
26461         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
26462         (GetGoogleChromePort):
26463         (GetGoogleChromePort.GoogleChromeLinux32Port):
26464         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
26465         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
26466         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
26467         (GetGoogleChromePort.GoogleChromeLinux64Port):
26468         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
26469         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
26470         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
26471         (GetGoogleChromePort.GoogleChromeMacPort):
26472         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
26473         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
26474         (GetGoogleChromePort.GoogleChromeWinPort):
26475         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
26476         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
26477         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
26478         (GetGoogleChromePortTest._verify_baseline_path):
26479         (GetGoogleChromePortTest._verify_expectations_overrides):
26480
26481 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
26482
26483         webkitpy: clean up port factory methods
26484         https://bugs.webkit.org/show_bug.cgi?id=75590
26485
26486         Reviewed by Eric Seidel.
26487
26488         This change consolidates much of the "factory method" logic
26489         of determining which port objects to create for a given set
26490         of configurations by merging the separate factory methods in
26491         chromium_gpu and google_chrome into PortFactory so that at least
26492         all of the logic is in one place.
26493
26494         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
26495         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
26496         * Scripts/webkitpy/layout_tests/port/factory.py:
26497         (_port_name_from_arguments_and_options):
26498         (get):
26499         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
26500         (test_google_chrome):
26501         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
26502         (GoogleChromeLinux32Port):
26503         (GoogleChromeLinux32Port.baseline_search_path):
26504         (test_expectations_overrides):
26505         (architecture):
26506         (GoogleChromeLinux64Port):
26507         (GoogleChromeLinux64Port.baseline_search_path):
26508         (GoogleChromeMacPort):
26509         (GoogleChromeMacPort.baseline_search_path):
26510         (GoogleChromeWinPort):
26511         (GoogleChromeWinPort.baseline_search_path):
26512         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
26513         (_verify_baseline_path):
26514
26515 2012-01-04  Adam Roben  <aroben@apple.com>
26516
26517         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
26518
26519         This allows us to add the Apple Application Support directory to PATH before trying to load
26520         WebKit so that CoreGraphics.dll and friends can be found.
26521
26522         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
26523
26524         Reviewed by Anders Carlsson.
26525
26526         * DumpRenderTree/win/ImageDiff.vcproj:
26527         * DumpRenderTree/win/ImageDiffCommon.vsprops:
26528         Changed to build ImageDiff.dll instead of ImageDiff.exe.
26529
26530         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
26531         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
26532
26533         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
26534         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
26535         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
26536         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
26537         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
26538         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
26539         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
26540
26541         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
26542         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
26543         to main.
26544
26545         * win/DLLLauncher/DLLLauncherMain.cpp:
26546         (main):
26547         (wWinMain):
26548         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
26549         stub launcher acts as a console program and calls a console version of
26550         dllLauncherEntryPoint.
26551
26552 2012-01-04  Adam Roben  <aroben@apple.com>
26553
26554         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
26555
26556         This allows us to add the Apple Application Support directory to PATH before trying to load
26557         WebKit so that CoreGraphics.dll and friends can be found.
26558
26559         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
26560         double-clicked
26561
26562         Reviewed by Anders Carlsson.
26563
26564         * MiniBrowser/MiniBrowser.vcproj:
26565         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
26566         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
26567
26568         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
26569         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
26570         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
26571         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
26572         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
26573         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
26574         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
26575
26576         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
26577         but changed to build the stub launcher.
26578
26579         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
26580         it needs to be compiled into the .exe instead of the .dll.
26581         (DllMain): Added. We use this to store the DLL's HINSTANCE.
26582         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
26583         DLLLauncherMain code.
26584
26585         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
26586         to here.
26587
26588 2012-01-04  Adam Roben  <aroben@apple.com>
26589
26590         Make WinLauncher's window frame respond to clicks/drags again
26591
26592         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
26593         bar when Aero is disabled
26594
26595         Reviewed by Brent Fulgham.
26596
26597         * WinLauncher/WinLauncher.cpp:
26598         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
26599         Also removed an unnecessary "break" keyword.
26600
26601 2012-01-04  Adam Roben  <aroben@apple.com>
26602
26603         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
26604
26605         This allows us to add the Apple Application Support directory to PATH before trying to load
26606         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
26607         should use this mechanism.
26608
26609         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
26610         double-clicked
26611
26612         Reviewed by Anders Carlsson.
26613
26614         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
26615         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
26616         done by the now-removed InitInstance function.
26617         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
26618         calls. Merged code from InitInstance into this function, and change to use the global hInst
26619         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
26620         function, which corresponds to WinLauncher.exe.
26621
26622         * WinLauncher/WinLauncher.vcproj:
26623         * WinLauncher/WinLauncherCommon.vsprops:
26624         Changed to build WinLauncher.dll instead of WinLauncher.exe.
26625
26626         * WinLauncher/WinLauncherLauncher.rc: Added.
26627         * WinLauncher/WinLauncherLauncherResource.h: Added.
26628         This just references the WinLauncher.ico file to set the application icon (though it looks
26629         like that's a default icon).
26630
26631         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
26632         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
26633
26634         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
26635         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
26636         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
26637         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
26638         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
26639         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
26640         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
26641
26642         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
26643         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
26644         program if it detects heap corruption.
26645         (getStringValue): Helper function to read a string value from the registry.
26646         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
26647         application from the registry.
26648         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
26649         Application Support directory.
26650         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
26651         (prependPath): Helper function to prepend a directory to the PATH.
26652         (fatalError): Helper function to display an error to the user.
26653         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
26654         dllLauncherEntryPoint function.
26655
26656 2012-01-05  Kentaro Hara  <haraken@chromium.org>
26657
26658         prepare-ChangeLog cannot parse python code that nests classes and defs
26659         https://bugs.webkit.org/show_bug.cgi?id=75524
26660
26661         Reviewed by Ryosuke Niwa.
26662
26663         This patch fixes the python parser of prepare-ChangeLog so that it can parse
26664         python code that nests classes and defs, like this:
26665
26666         class C:
26667             pass
26668             def f():
26669                 pass
26670             pass
26671
26672         Also, this patch fixes the python parser so that it inserts a dummy line
26673         at the end of the file to pop out all popped scopes.
26674
26675         * Scripts/prepare-ChangeLog:
26676         (get_function_line_ranges_for_python):
26677
26678         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
26679         Added test cases that nest classes and defs.
26680         (func7):
26681         (func7.func8):
26682         (func7.func8.func9):
26683         (Class2):
26684         (Class2.Class3):
26685         (Class2.Class3.Class4):
26686         (Class5):
26687         (Class5.func10):
26688         (Class5.func11):
26689         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
26690
26691 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
26692
26693         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
26694         https://bugs.webkit.org/show_bug.cgi?id=75433
26695
26696         Reviewed by Martin Robinson.
26697
26698         * MiniBrowser/gtk/BrowserWindow.c:
26699         (webViewLoadFailed): Reset the progress bar when load fails.
26700         (browserWindowConstructed): Connect to load-failed signal.
26701
26702 2012-01-04  Dan Bernstein  <mitz@apple.com>
26703
26704         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
26705         start WebProcess under gdb and WebProcess will then run the client executable.
26706
26707         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
26708
26709         Reviewed by Anders Carlsson.
26710
26711         * Scripts/webkitdirs.pm:
26712         (shouldTargetWebProcess): Added.
26713         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
26714         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
26715         app using the -client-executable option if targeting the web process.
26716
26717 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
26718
26719         Adding myself to committers list.
26720
26721         Unreviewed.
26722
26723         * Scripts/webkitpy/common/config/committers.py:
26724
26725 2012-01-04  David Kilzer  <ddkilzer@apple.com>
26726
26727         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
26728
26729         This reverts commit r103546.
26730
26731         * TestWebKitAPI/TestsController.cpp:
26732         (TestWebKitAPI::TestsController::TestsController):
26733
26734 2012-01-04  James Robinson  <jamesr@chromium.org>
26735
26736         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
26737         https://bugs.webkit.org/show_bug.cgi?id=74583
26738
26739         Reviewed by Darin Fisher.
26740
26741         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
26742
26743         * Scripts/webkitpy/style/checkers/cpp.py:
26744         (check_function_definition):
26745
26746 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26747
26748         [Qt] Fix link order of static libraries and unbreak QtWin32
26749
26750         We were keeping the correct static link order between the intermediate
26751         WebKit libraries, but not the internal dependencies for each of those
26752         libraries. The load() will in some instances mess with LIBS, so we need
26753         to ensure that the dependent libraries are added after the library we
26754         are linking against.
26755
26756         Reviewed by Simon Hausmann.
26757
26758         * qmake/mkspecs/features/default_post.prf:
26759
26760 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26761
26762         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
26763
26764         The custom qmake variable 'WEBKIT' is used for signaling that a
26765         target depends in some way on other subproject of the WebKit
26766         project. For now this is limited to the set of intermediate
26767         libraries: wtf, javascriptcore, webcore, and webkit2.
26768
26769         This replaces the previous convension of using load(foo) for
26770         just include paths, and CONFIG += foo to also link against foo.
26771
26772         Adding a dependency results in additional include paths being
26773         available, and potentially linking to the library. This is
26774         decided by the build system based on conditions such as what
26775         kind of target is being built and the general build config.
26776
26777         An advantage to his approach is that it simplifies the individual
26778         foo.prf files, for example by allowing us to use INCLUDEPATH +=
26779         and LIBS += as normal instead of prepending.
26780
26781         Reviewed by Simon Hausmann.
26782
26783         * DumpRenderTree/qt/DumpRenderTree.pro:
26784         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
26785         * QtTestBrowser/QtTestBrowser.pro:
26786         * WebKitTestRunner/InjectedBundle/Target.pri:
26787         * WebKitTestRunner/Target.pri:
26788         * qmake/README:
26789         * qmake/mkspecs/features/default_post.prf:
26790         * qmake/mkspecs/features/functions.prf:
26791         * qmake/mkspecs/features/javascriptcore.prf:
26792         * qmake/mkspecs/features/qtwebkit.prf:
26793         * qmake/mkspecs/features/webcore.prf:
26794         * qmake/mkspecs/features/webkit2.prf:
26795         * qmake/mkspecs/features/wtf.prf:
26796
26797 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
26798
26799         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
26800         https://bugs.webkit.org/show_bug.cgi?id=75488
26801
26802         Reviewed by Tor Arne Vestbø.
26803
26804         * MiniBrowser/qt/MiniBrowser.qrc:
26805         * MiniBrowser/qt/qml/BrowserWindow.qml:
26806         * MiniBrowser/qt/qml/Dialog.qml:
26807         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
26808         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
26809
26810 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26811
26812         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
26813
26814         It wasn't really a problem at runtime since the right QtWebKit was
26815         already loaded as a dependency of the web process, but the ldd output
26816         would still be busted.
26817
26818         Reviewed by Simon Hausmann.
26819
26820         * WebKitTestRunner/InjectedBundle/Target.pri:
26821
26822 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
26823
26824         [Qt] Move use of $$qtLibraryTarget() to a single place
26825
26826         Reviewed by Kenneth Rohde Christiansen.
26827
26828         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
26829         * WebKitTestRunner/InjectedBundle/Target.pri:
26830         * qmake/mkspecs/features/default_post.prf:
26831         * qmake/mkspecs/features/webcore.prf:
26832
26833 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
26834
26835         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
26836         https://bugs.webkit.org/show_bug.cgi?id=75238
26837
26838         Reviewed by Antonio Gomes.
26839
26840         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that
26841         it could initiate download directly if it has the download attribute in the link
26842         and doesn't need to open new blank page for the target="_blank". Enabling this
26843         feature in the BlackBerry porting also prepares for later blob feature implementation.
26844
26845         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
26846         for the BlackBerry porting.
26847
26848 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
26849
26850         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
26851         https://bugs.webkit.org/show_bug.cgi?id=75475
26852
26853         Reviewed by Martin Robinson.
26854
26855         The problem is that the property blurb contains <a ping> and tree
26856         view uses gtk_tooltip_set_markup() internally, so we need to
26857         escape the text.
26858
26859         * MiniBrowser/gtk/BrowserSettingsDialog.c:
26860         (browserSettingsDialogConstructed): Escape property blurb before
26861         storing it in the GtkTreeModel.
26862
26863 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
26864
26865         When showing results.html pass a correct URL to webbrowser.open
26866         https://bugs.webkit.org/show_bug.cgi?id=75438
26867
26868         Reviewed by Adam Barth.
26869
26870         * Scripts/webkitpy/common/system/filesystem.py:
26871         (file_path_as_url):
26872         * Scripts/webkitpy/common/system/filesystem_mock.py:
26873         (file_path_as_url):
26874         * Scripts/webkitpy/common/system/filesystem_unittest.py:
26875         (test_file_path_as_url):
26876         * Scripts/webkitpy/layout_tests/port/base.py:
26877         (show_results_html_file):
26878         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
26879         (test_show_results_html_file):
26880         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
26881         (test_results_directory_relative):
26882
26883 2012-01-03  Ojan Vafai  <ojan@chromium.org>
26884
26885         shrink the header on the flakiness dashboard
26886         https://bugs.webkit.org/show_bug.cgi?id=65153
26887
26888         Reviewed by Adam Roben.
26889
26890         Move some of the "show" links to be to the right of the header
26891         instead of below the header when they content they're showing
26892         is hidden. That way we don't waste vertical space on them.
26893
26894         No new tests. This code is covered by existing tests.
26895
26896         * TestResultServer/static-dashboards/flakiness_dashboard.html:
26897
26898 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
26899
26900         Add a tool to analyze change logs
26901         https://bugs.webkit.org/show_bug.cgi?id=72243
26902
26903         Reviewed by Eric Seidel.
26904
26905         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
26906         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
26907         for visualizing json files.
26908
26909         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
26910         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
26911         generates json files, and N is the number of changelogs to parse.
26912
26913         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
26914         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
26915         * Scripts/webkitpy/tool/commands/__init__.py:
26916         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
26917         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
26918         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
26919         * Scripts/webkitpy/tool/steps/options.py:
26920
26921 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
26922
26923         Add a tool to analyze change logs
26924         https://bugs.webkit.org/show_bug.cgi?id=72243
26925
26926         Reviewed by Eric Seidel.
26927
26928         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
26929         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
26930         for visualizing json files.
26931
26932         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
26933         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
26934         generates json files, and N is the number of changelogs to parse.
26935
26936         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
26937         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
26938         * Scripts/webkitpy/tool/commands/__init__.py:
26939         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
26940         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
26941         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
26942         * Scripts/webkitpy/tool/steps/options.py:
26943
26944 2012-01-03  Adam Roben  <aroben@apple.com>
26945
26946         Make Port subclasses override the operating_system method rather than setting an attribute
26947
26948         Without this patch, any use of Port.operating_system() within a port's __init__ method would
26949         return the default value ("mac"). This was confusing the version-checking logic inside
26950         ApplePort.__init__ on Windows.
26951
26952         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
26953         crashes on launch on Windows 7 SP1
26954
26955         Reviewed by Eric Seidel.
26956
26957         * Scripts/webkitpy/layout_tests/port/apple.py:
26958         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
26959
26960         * Scripts/webkitpy/layout_tests/port/base.py:
26961         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
26962         should now override the operating_system method instead.
26963         (Port.operating_system): Changed to always return "mac". Subclasses should override to
26964         return something else.
26965
26966         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
26967         (ChromiumLinuxPort.__init__):
26968         (ChromiumLinuxPort.operating_system):
26969         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
26970         (ChromiumMacPort.__init__):
26971         (ChromiumMacPort.operating_system):
26972         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
26973         (ChromiumWinPort.__init__):
26974         (ChromiumWinPort.operating_system):
26975         * Scripts/webkitpy/layout_tests/port/mac.py:
26976         (MacPort.__init__):
26977         (MacPort.operating_system):
26978         * Scripts/webkitpy/layout_tests/port/win.py:
26979         (WinPort.__init__):
26980         (WinPort.operating_system):
26981         Changed to override the operating_system method rather than setting the _operating_system
26982         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
26983
26984         * Scripts/webkitpy/layout_tests/port/qt.py:
26985         (QtPort.__init__):
26986         (QtPort._path_to_webcore_library):
26987         Changed to use self.operating_system() instead of self._operating_system, for consistency
26988         with other Port-related code.
26989
26990         (QtPort.operating_system): Added this override of Port.operating_system that returns the
26991         value we determined in our __init__ method.
26992
26993         * Scripts/webkitpy/layout_tests/port/test.py:
26994         (TestPort.operating_system): Added this override of Port.operating_system that returns the
26995         value we determined in our __init__ method.
26996
26997         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
26998         (PortTest.test_operating_system):
26999         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
27000         (ChromiumLinuxPortTest.test_operating_system):
27001         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
27002         (ChromiumMacPortTest.test_operating_system):
27003         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
27004         (ChromiumWinPortTest.test_operating_system):
27005         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
27006         (MacPortTest.test_operating_system):
27007         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
27008         (QtPortTest.test_operating_system):
27009         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
27010         (WinPortTest.test_operating_system):
27011         Test that all ports return the expected operating system string.
27012
27013 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
27014
27015         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
27016         https://bugs.webkit.org/show_bug.cgi?id=75474
27017
27018         Reviewed by Philippe Normand.
27019
27020         * Scripts/run-gtk-tests: Ignore files whose name does not start
27021         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
27022
27023 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
27024
27025         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
27026         https://bugs.webkit.org/show_bug.cgi?id=75472
27027
27028         Reviewed by Tor Arne Vestbø.
27029
27030         * MiniBrowser/qt/MiniBrowser.pro:
27031         * MiniBrowser/qt/MiniBrowser.qrc:
27032         * MiniBrowser/qt/qml/BrowserWindow.qml:
27033         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
27034
27035 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
27036
27037         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
27038         https://bugs.webkit.org/show_bug.cgi?id=75471
27039
27040         Reviewed by Tor Arne Vestbø.
27041
27042         Add simple UI for JavaScript Alert dialogs. This patch also adds a
27043         simple DialogButton QML type and a Dialog QML type which will be
27044         reusable for other JavaScript dialogs.
27045
27046         * MiniBrowser/qt/MiniBrowser.qrc:
27047         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
27048         * MiniBrowser/qt/qml/BrowserWindow.qml:
27049         * MiniBrowser/qt/qml/Dialog.qml: Added.
27050         * MiniBrowser/qt/qml/DialogButton.qml: Added.
27051
27052 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
27053
27054         [Qt][WK2] MiniBrowser doesn't show url bar
27055         https://bugs.webkit.org/show_bug.cgi?id=75470
27056
27057         Reviewed by Tor Arne Vestbø.
27058
27059         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
27060         on QtDeclarative (QTBUG-23422).
27061
27062 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
27063
27064         [GTK] Simplify loader client WebKit2 GTK+ API
27065         https://bugs.webkit.org/show_bug.cgi?id=74605
27066
27067         Reviewed by Gustavo Noronha Silva.
27068
27069         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
27070         private API.
27071
27072 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27073
27074         [Qt] Clean up detection of fontconfig
27075
27076         We decide in features.prf whether or not fontconfig is available, and
27077         set the HAVE_FONTCONFIG define accordingly. All leaf project files
27078         should use this define to decide whether or not to link against
27079         fontconfig, not do their own detection.
27080
27081         We don't need to add link_pkgconfig to CONFIG in each project file,
27082         as we selectivly enable that configuration in defaults_post when
27083         needed.
27084
27085         Reviewed by Ossy.
27086
27087         * DumpRenderTree/qt/DumpRenderTree.pro:
27088         * QtTestBrowser/QtTestBrowser.pro:
27089         * WebKitTestRunner/InjectedBundle/Target.pri:
27090         * qmake/mkspecs/features/unix/default_post.prf:
27091         * qmake/mkspecs/features/unix/default_pre.prf:
27092
27093 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
27094
27095         [Qt] Introduce qmake replace function for the active build config
27096
27097         Reviewed by Ossy.
27098
27099         * qmake/mkspecs/features/default_post.prf:
27100         * qmake/mkspecs/features/functions.prf:
27101
27102 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
27103
27104         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
27105         https://bugs.webkit.org/show_bug.cgi?id=75435
27106
27107         Reviewed by Martin Robinson.
27108
27109         * GNUmakefile.am: Make sure DRT links to X11.
27110         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
27111
27112 2011-12-04  Philippe Normand  <pnormand@igalia.com>
27113
27114         [WK2][GTK] WebSettings support in MiniBrowser
27115         https://bugs.webkit.org/show_bug.cgi?id=73773
27116
27117         Reviewed by Martin Robinson.
27118
27119         Patch heavily inspired from the WebKit GtkLauncher to support
27120         command-line WebSettings. Example: --enable-fullscreen=TRUE.
27121         The full list of options can be consulted with --help-websettings.
27122
27123         * MiniBrowser/gtk/main.c:
27124         (loadURI):
27125         (parseOptionEntryCallback):
27126         (isValidParameterType):
27127         (getOptionEntriesFromWebKitSettings):
27128         (addSettingsGroupToContext):
27129         (main):
27130
27131 2012-01-02  Philippe Normand  <pnormand@igalia.com>
27132
27133         [GTK] GtkLauncher settings improvements
27134         https://bugs.webkit.org/show_bug.cgi?id=75439
27135
27136         Reviewed by Martin Robinson.
27137
27138         * GtkLauncher/main.c:
27139         (filenameToURL): We can use NULL in C.
27140         (isValidParameterType): Utility function to filter GParamTypes
27141         that can be edited.
27142         (getOptionEntriesFromWebKitWebSettings): Avoid handling
27143         construct-only properties and use the isValidParameterType
27144         function. Makes the code a bit cleaner.
27145
27146 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
27147
27148         [EFL] Remove whitespace/declaration style exception
27149         https://bugs.webkit.org/show_bug.cgi?id=75424
27150
27151         Reviewed by David Levin.
27152
27153         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
27154         application. So, they still need to use EFL coding style.
27155
27156         * Scripts/webkitpy/style/checker.py:
27157
27158 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
27159
27160         [GTK] Add a way to change web view settings in MiniBrowser
27161         https://bugs.webkit.org/show_bug.cgi?id=71568
27162
27163         Reviewed by Philippe Normand.
27164
27165         Add a preferences button to the toolbar that shows a dialog to
27166         change settings of the current web view. It uses a GtkTreeView
27167         with a custom cell renderer to support multiple types of values.
27168
27169         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
27170         (browserCellRendererVariantFinalize):
27171         (browserCellRendererVariantGetProperty):
27172         (browserCellRendererVariantSetModeForValue):
27173         (browserCellRendererVariantSetProperty):
27174         (browserCellRendererVariantGetRendererForValue):
27175         (browserCellRendererVariantCellRendererTextEdited):
27176         (browserCellRendererVariantCellRendererSpinEdited):
27177         (browserCellRendererVariantCellRendererActivate):
27178         (browserCellRendererVariantCellRendererRender):
27179         (browserCellRendererVariantCellRendererStartEditing):
27180         (browserCellRendererVariantCellRendererGetPreferredWidth):
27181         (browserCellRendererVariantCellRendererGetPreferredHeight):
27182         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
27183         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
27184         (browserCellRendererVariantCellRendererGetAlignedArea):
27185         (browser_cell_renderer_variant_init):
27186         (browser_cell_renderer_variant_class_init):
27187         (browser_cell_renderer_variant_new):
27188         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
27189         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
27190         (cellRendererChanged):
27191         (browserSettingsDialogSetProperty):
27192         (browser_settings_dialog_init):
27193         (browserSettingsDialogConstructed):
27194         (browser_settings_dialog_class_init):
27195         (browser_settings_dialog_new):
27196         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
27197         * MiniBrowser/gtk/BrowserWindow.c:
27198         (settingsCallback):
27199         (browser_window_init):
27200         * MiniBrowser/gtk/GNUmakefile.am:
27201         * MiniBrowser/gtk/browser-marshal.list: Added.
27202
27203 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
27204
27205         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
27206         https://bugs.webkit.org/show_bug.cgi?id=74711
27207
27208         Reviewed by Philippe Normand.
27209
27210         * MiniBrowser/gtk/BrowserWindow.c:
27211         (webViewClose): Destroy the window.
27212         (webViewReadyToShow): Use WindowProperties of the new view to
27213         setup and show the window.
27214         (webViewCreate): Create a new view and add it to a browser window.
27215         (browser_window_init):
27216         (browserWindowConstructed): Connect to WebKitWebView::create signal.
27217
27218 2011-12-31  Dan Bernstein  <mitz@apple.com>
27219
27220         MiniBrowser sets the WKView’s frame incorrectly
27221         https://bugs.webkit.org/show_bug.cgi?id=75393
27222
27223         Reviewed by Anders Carlsson.
27224
27225         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
27226         which is not needed since the binray is linked with the frameworks search path set to the
27227         built products directory.
27228         * MiniBrowser/mac/BrowserWindowController.m:
27229         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
27230         container’s bounds rather than its frame.
27231         * MiniBrowser/mac/make-launchable.sh: Removed.
27232
27233 2011-12-29  Dan Bernstein  <mitz@apple.com>
27234
27235         debug-safari --no-saved-state fails to start the debugger
27236         https://bugs.webkit.org/show_bug.cgi?id=75374
27237
27238         Reviewed by Sam Weinig.
27239
27240         * Scripts/webkitdirs.pm:
27241         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
27242         the executable being debugged.
27243
27244 2011-12-29  Sam Weinig  <sam@webkit.org>
27245
27246         It should be easier to iterate a Vector backwards
27247         https://bugs.webkit.org/show_bug.cgi?id=75359
27248
27249         Reviewed by Anders Carlsson.
27250
27251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27252         * TestWebKitAPI/TestWebKitAPI.gypi:
27253         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
27254         Add new Vector test.
27255
27256         * TestWebKitAPI/Tests/Vector.cpp: Added.
27257         (TestWebKitAPI::TEST):
27258         Test Vector iterators, reverse_iterators and new reversed proxy.
27259
27260 2011-12-28  Dmitry Lomov  <dslomov@google.com>
27261
27262         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
27263         https://bugs.webkit.org/show_bug.cgi?id=66509
27264         Just renames, merges and removal of dead code. Here are the list of renames:
27265           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
27266           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
27267           - WebWorkerBase merged into WebSharedWorkerImpl
27268           - NewWebWorkerBase renamed into WebWorkerBase
27269
27270         Reviewed by David Levin.
27271
27272         * DumpRenderTree/chromium/TestWebWorker.h:
27273         (TestWebWorker::createWorker):
27274         * DumpRenderTree/chromium/WebViewHost.cpp:
27275         (WebViewHost::createWorker):
27276         * DumpRenderTree/chromium/WebViewHost.h:
27277
27278 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
27279
27280         Unreviewed, rolling out r103785.
27281         http://trac.webkit.org/changeset/103785
27282         https://bugs.webkit.org/show_bug.cgi?id=75332
27283
27284         Broke builders; looks like clobbering didnt help (Requested by
27285         dslomov on #webkit).
27286
27287         * DumpRenderTree/chromium/TestWebWorker.h:
27288         (TestWebWorker::createWorker):
27289         * DumpRenderTree/chromium/WebViewHost.cpp:
27290         (WebViewHost::createWorker):
27291         * DumpRenderTree/chromium/WebViewHost.h:
27292
27293 2011-12-28  Dmitry Lomov  <dslomov@google.com>
27294
27295
27296         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
27297         https://bugs.webkit.org/show_bug.cgi?id=66509
27298         Just renames, merges and removal of dead code. Here are the list of renames:
27299           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
27300           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
27301           - WebWorkerBase merged into WebSharedWorkerImpl
27302           - NewWebWorkerBase renamed into WebWorkerBase
27303
27304         Reviewed by David Levin.
27305
27306         * DumpRenderTree/chromium/TestWebWorker.h:
27307         (TestWebWorker::createWorker):
27308         * DumpRenderTree/chromium/WebViewHost.cpp:
27309         (WebViewHost::createWorker):
27310         * DumpRenderTree/chromium/WebViewHost.h:
27311
27312 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
27313
27314         Unreviewed, rolling out r103620.
27315         http://trac.webkit.org/changeset/103620
27316         https://bugs.webkit.org/show_bug.cgi?id=75316
27317
27318         Causes many crashes (Requested by abarth on #webkit).
27319
27320         * DumpRenderTree/chromium/LayoutTestController.cpp:
27321         (LayoutTestController::LayoutTestController):
27322         (LayoutTestController::reset):
27323         * DumpRenderTree/chromium/LayoutTestController.h:
27324         * DumpRenderTree/chromium/WebViewHost.cpp:
27325         * DumpRenderTree/chromium/WebViewHost.h:
27326
27327 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
27328
27329         Unreviewed, rolling out r103734.
27330         http://trac.webkit.org/changeset/103734
27331         https://bugs.webkit.org/show_bug.cgi?id=75278
27332
27333         Broke cr-mac (Requested by dslomov on #webkit).
27334
27335         * DumpRenderTree/chromium/TestWebWorker.h:
27336         (TestWebWorker::createWorker):
27337         * DumpRenderTree/chromium/WebViewHost.cpp:
27338         (WebViewHost::createWorker):
27339         * DumpRenderTree/chromium/WebViewHost.h:
27340
27341 2011-12-27  Dmitry Lomov  <dslomov@google.com>
27342
27343
27344         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
27345         https://bugs.webkit.org/show_bug.cgi?id=66509
27346         Just renames, merges and removal of dead code. Here are the list of renames:
27347           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
27348           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
27349           - WebWorkerBase merged into WebSharedWorkerImpl
27350           - NewWebWorkerBase renamed into WebWorkerBase
27351
27352         Reviewed by David Levin.
27353
27354         * DumpRenderTree/chromium/TestWebWorker.h:
27355         (TestWebWorker::createWorker):
27356         * DumpRenderTree/chromium/WebViewHost.cpp:
27357         (WebViewHost::createWorker):
27358         * DumpRenderTree/chromium/WebViewHost.h:
27359
27360 2011-12-27  Anders Carlsson  <andersca@apple.com>
27361
27362         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
27363         https://bugs.webkit.org/show_bug.cgi?id=75266
27364
27365         Reviewed by Sam Weinig.
27366
27367         * TestWebKitAPI/Tests/WTF/Functional.cpp:
27368         (TestWebKitAPI::Number::create):
27369         (TestWebKitAPI::Number::~Number):
27370         (TestWebKitAPI::Number::value):
27371         (TestWebKitAPI::Number::Number):
27372         (TestWebKitAPI::multiplyNumberByTwo):
27373         (TestWebKitAPI::TEST):
27374
27375 2011-12-24  Kentaro Hara  <haraken@chromium.org>
27376
27377         Add unittests for the C++ parser of prepare-ChangeLog
27378         https://bugs.webkit.org/show_bug.cgi?id=75191
27379
27380         Reviewed by Ryosuke Niwa.
27381
27382         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
27383         of prepare-ChangeLog.
27384
27385         * Scripts/prepare-ChangeLog:
27386         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
27387         to get_function_line_ranges_for_cpp().
27388         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
27389         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
27390         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
27391         (func1):
27392         (func2):
27393         (func3):
27394         (func4):
27395         (func5):
27396         (func6):
27397         (func7):
27398         (func8):
27399         (func9):
27400         (func10):
27401         (func11):
27402         (func12):
27403         (func13):
27404         (func14):
27405         (func15):
27406         (funcOverloaded):
27407         (Class::func16):
27408         (Class1::Class2::func17):
27409         (Class2::func18):
27410         (Class2::func19):
27411         (Class2::func20):
27412         (Class2::func21):
27413         (Class2::func22):
27414         (func23):
27415         (func24):
27416         (Class2::func25):
27417         (Class1::func26):
27418         (Class2::func27):
27419         (Class3::func28):
27420         (Class7::operator+):
27421         (Class100::Class100):
27422         (Class101::~Class101):
27423         (Class102::Class102):
27424         (Class103::Class103):
27425         (Struct1::func29):
27426         (Struct2::func30):
27427         (NameSpace1::func30):
27428         (NameSpace1::NameSpace2::func31):
27429
27430 2011-12-24  Kentaro Hara  <haraken@chromium.org>
27431
27432         Add unittests for the Java parser of prepare-ChangeLog
27433         https://bugs.webkit.org/show_bug.cgi?id=75195
27434
27435         Reviewed by Ryosuke Niwa.
27436
27437         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
27438         of prepare-ChangeLog.
27439
27440         * Scripts/prepare-ChangeLog:
27441         (get_function_line_ranges_for_java): Fixed a parser bug.
27442
27443             interface I
27444             {
27445                 void f()
27446                 {
27447                 }
27448             }
27449
27450         should be recognized as "I.f", and
27451
27452             class C interface I
27453             {
27454                 void f()
27455                 {
27456                 }
27457             }
27458
27459         should be recognized as "C.f".
27460         Without this patch, both are recognized as "I.f".
27461
27462         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
27463         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
27464         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
27465         (Simple):
27466         (Simple.func1):
27467         (Simple.func2):
27468         (Simple.func3):
27469         (Simple.func4):
27470         (Simple.func5):
27471         (Simple.func6):
27472         (Simple.func7):
27473         (Simple.func8):
27474         (Simple.func9):
27475         (Simple.func10):
27476         (Simple.funcOverloaded):
27477         (Simple.func11):
27478         (Simple.func12):
27479         (Simple.func13):
27480         (Simple.func14):
27481         (Simple.func15):
27482         (Simple.func16):
27483         (Simple.func17):
27484         (Simple.func18):
27485         (Simple.func19):
27486         (Simple.func20):
27487         (Simple.func21):
27488         (Derived1):
27489         (Derived1.Derived1):
27490         (Derived1.func22):
27491         (Interface1):
27492         (Interface2):
27493         (Interface2.func23):
27494         (Derived2):
27495         (Derived2.Derived2):
27496         (Derived2.func23):
27497
27498 2011-12-24  Kentaro Hara  <haraken@chromium.org>
27499
27500         Add unittests for the Python parser of prepare-ChangeLog
27501         https://bugs.webkit.org/show_bug.cgi?id=75197
27502
27503         Reviewed by Ryosuke Niwa.
27504
27505         python_unittests.py is the unittest for get_function_line_ranges_for_python()
27506         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
27507         This is because the current python parser is wrong, and it cannot correctly parse nested
27508         classes and defs (even one def in a class), nor class inheritance.
27509         We will fix it in another patch.
27510
27511         * Scripts/prepare-ChangeLog:
27512         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
27513         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
27514         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
27515         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
27516         (func1):
27517         (func2):
27518         (func3):
27519         (funcInsideComment):
27520         (func4):
27521         (func5):
27522         (func6):
27523         (funcOverloaded):
27524         (Class1):
27525
27526 2011-12-24  Dan Bernstein  <mitz@apple.com>
27527
27528         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
27529
27530         Reviewed by Anders Carlsson.
27531
27532         * Scripts/webkitdirs.pm:
27533         (determineBaseProductDir):
27534
27535 2011-12-24  Dan Bernstein  <mitz@apple.com>
27536
27537         Make build-webkit aware of additional Xcode build location defaults.
27538
27539         Reviewed by Anders Carlsson.
27540
27541         * Scripts/webkitdirs.pm:
27542         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
27543         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
27544         (determineBaseProductDir): Changed to check for a custom build location
27545         style specified as an absolute location.
27546
27547 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
27548
27549         Unreviewed, rolling out r103619.
27550         http://trac.webkit.org/changeset/103619
27551         https://bugs.webkit.org/show_bug.cgi?id=66509
27552
27553         Broke chromium clang build
27554
27555         * DumpRenderTree/chromium/TestWebWorker.h:
27556         (TestWebWorker::createWorker):
27557         * DumpRenderTree/chromium/WebViewHost.cpp:
27558         (WebViewHost::createWorker):
27559         * DumpRenderTree/chromium/WebViewHost.h:
27560
27561 2011-12-23  Daniel Bates  <dbates@webkit.org>
27562
27563         Provide option to disable Mac OS 10.7 application resume when using
27564         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
27565         https://bugs.webkit.org/show_bug.cgi?id=66902
27566
27567         Reviewed by David Kilzer.
27568
27569         Add an optional command line argument --no-saved-state to disable
27570         application resume (state restoration) for the session on Mac OS 10.7.
27571
27572         For instance, when debugging an issue in Safari it is useful to be able
27573         to temporarily disable application resume. Currently you can disable
27574         application resume when launching Safari from within Xcode. We should
27575         expose a similar option in our command line tools.
27576
27577         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
27578         to print a help message and exit() if the command line argument --help was given.
27579         * Scripts/debug-safari: Ditto.
27580         * Scripts/debug-test-runner: Ditto.
27581         * Scripts/run-minibrowser: Ditto.
27582         * Scripts/run-safari: Ditto.
27583         * Scripts/run-test-runner: Ditto.
27584         * Scripts/run-test-webkit-api: Ditto.
27585         * Scripts/run-webkit-app: Ditto.
27586         * Scripts/webkitdirs.pm:
27587         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
27588         (argumentsForRunAndDebugMacWebKitApp): Added.
27589         (runMacWebKitApp): If the --no-saved-state command line argument was given then
27590         disable application resume for the session.
27591         (execMacWebKitAppForDebugging): Ditto.
27592
27593 2011-12-23  Dmitry Lomov  <dslomov@google.com>
27594
27595         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
27596         https://bugs.webkit.org/show_bug.cgi?id=66509
27597         Just renames, merges and removal of dead code. Here are the list of renames:
27598           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
27599           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
27600           - WebWorkerBase merged into WebSharedWorkerImpl
27601           - NewWebWorkerBase renamed into WebWorkerBase
27602
27603         Reviewed by David Levin.
27604
27605         * DumpRenderTree/chromium/TestWebWorker.h:
27606         (TestWebWorker::createWorker):
27607         * DumpRenderTree/chromium/WebViewHost.cpp:
27608         (WebViewHost::createWorker):
27609         * DumpRenderTree/chromium/WebViewHost.h:
27610
27611 2011-12-23  Kentaro Hara  <haraken@chromium.org>
27612
27613         Let parser_unittests.pl call different language parsers
27614         https://bugs.webkit.org/show_bug.cgi?id=75081
27615
27616         Reviewed by David Kilzer.
27617
27618         We introduced parser_unittests.pl in bug 74994 , but it is implemented
27619         to always call get_function_line_ranges_for_perl(). In order to enable unittests
27620         for other languages, this patch lets parser_unittests.pl call different language
27621         parsers depending on the languages.
27622
27623         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
27624
27625         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
27626
27627 2011-12-22  Adam Roben  <aroben@apple.com>
27628
27629         Snow Leopard test fix
27630
27631         * Scripts/webkitpy/test/main.py:
27632         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
27633         unittest.main, even though that's the default. So now we explicitly specify a
27634         TextTestRunner.
27635
27636 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
27637
27638         AX: attributed strings do not include AXHeading information when a link is contained within the heading
27639         https://bugs.webkit.org/show_bug.cgi?id=75059
27640
27641         Reviewed by Darin Adler.
27642
27643         Support the ability to check if an arbitrary attribute is present within an
27644         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
27645
27646         * DumpRenderTree/AccessibilityUIElement.cpp:
27647         (attributedStringForTextMarkerRangeContainsAttributeCallback):
27648         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
27649         (AccessibilityUIElement::getJSClass):
27650         * DumpRenderTree/AccessibilityUIElement.h:
27651         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
27652         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
27653         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
27654         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
27655         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
27656         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
27657         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
27658         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
27659
27660 2011-12-22  David Kilzer  <ddkilzer@apple.com>
27661
27662         run-api-tests: runAllTests() and runTest() should not use global variables
27663
27664         Reviewed by Adam Roben.
27665
27666         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
27667
27668         * Scripts/run-api-tests:
27669         (runTestsBySuite): Rename from runAllTests().  Add arguments for
27670         list of tests and $verbose.
27671         (runTest): Add $verbose argument.
27672
27673 2011-12-22  David Kilzer  <ddkilzer@apple.com>
27674
27675         run-api-tests: inline runAllTestsInSuite() into runAllTests()
27676
27677         Reviewed by Adam Roben.
27678
27679         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
27680
27681         In order to make it easy to run one or more individual suites,
27682         or one more individual tests, it's easier to call a single
27683         method with different data structures than individual methods.
27684
27685         * Scripts/run-api-tests:
27686         (runAllTests): Inline runAllTestsInSuite().
27687
27688 2011-12-22  Adam Roben  <aroben@apple.com>
27689
27690         Add a --xml flag to test-webkitpy
27691
27692         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
27693         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
27694         This is useful for working with tools that consume JUnit-style XML files.
27695
27696         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
27697         running test-webkitpy
27698
27699         Reviewed by Darin Adler.
27700
27701         * Scripts/webkitpy/test/main.py:
27702         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
27703         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
27704
27705         * Scripts/webkitpy/thirdparty/__init__.py:
27706         (AutoinstallImportHook.find_module):
27707         (AutoinstallImportHook._install_xmlrunner):
27708         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
27709         This change is untested because it's basically impossible to get a test to pass when --xml
27710         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
27711         the test runs).
27712
27713 2011-12-22  David Kilzer  <ddkilzer@apple.com>
27714
27715         TestWebKitAPI: initialize the main thread before running tests
27716         <http://webkit.org/b/75064>
27717
27718         Reviewed by Adam Roben.
27719
27720         * TestWebKitAPI/TestsController.cpp:
27721         (TestWebKitAPI::TestsController::TestsController): Call
27722         WTF::initializeMainThread() to prevent assertions in Debug
27723         builds.
27724
27725 2011-12-22  David Kilzer  <ddkilzer@apple.com>
27726
27727         run-api-tests: dumpAllTests() should not use global variables
27728
27729         Reviewed by Adam Roben.
27730
27731         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
27732
27733         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
27734         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
27735         global data as an argument.  Sort suite names and test names
27736         alphabetically to match output when running tests.
27737
27738 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
27739
27740         [BlackBerry] Enable blob for the BlackBerry porting
27741         https://bugs.webkit.org/show_bug.cgi?id=75074
27742
27743         Reviewed by George Staikos.
27744
27745         * Scripts/build-webkit:
27746
27747 2011-12-22  Kentaro Hara  <haraken@chromium.org>
27748
27749         Add unittests for the Perl parser of prepare-ChangeLog
27750         https://bugs.webkit.org/show_bug.cgi?id=74994
27751
27752         Reviewed by David Kilzer.
27753
27754         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
27755
27756         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
27757
27758         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
27759         Runs unittests specified in @testFiles.
27760         You can reset expected results by specifying a --reset-results option.
27761         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
27762         Contains simple methods.
27763         (func1):
27764         (func2):
27765         (func3):
27766         (func4):
27767         (func5):
27768         (func6):
27769         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
27770         This test result is generated by the --reset-results option.
27771
27772 2011-12-21  Eric Seidel  <eric@webkit.org>
27773
27774         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
27775         so that they appear in the bugzilla autocomplete CC list.
27776         I also removed the "radar" irc nick (which I believe does not exist)
27777         and removed the uneeded [] around the radar bugzilla email.
27778
27779         Unreviewed.
27780
27781         * Scripts/webkitpy/common/config/committers.py:
27782
27783 2011-12-21  Daniel Bates  <dbates@rim.com>
27784
27785         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
27786         https://bugs.webkit.org/show_bug.cgi?id=74985
27787
27788         Reviewed by Eric Seidel.
27789
27790         * Scripts/build-jsc:
27791         * Scripts/webkitdirs.pm:
27792         (cmakeBasedPortName): Added.
27793
27794 2011-12-21  Daniel Bates  <dbates@rim.com>
27795
27796         Extract BlackBerry CMake arguments from build-webkit into separate function
27797         https://bugs.webkit.org/show_bug.cgi?id=74981
27798
27799         Reviewed by Rob Buis.
27800
27801         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
27802         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
27803         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
27804         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
27805         that we can pass them to the CMake build system when building JavaScriptCore.
27806
27807         * Scripts/build-webkit: Move construction of CMake argument list from here to
27808         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
27809         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
27810         call it from build-webkit.
27811         * Scripts/webkitdirs.pm:
27812         (blackberryCMakeArguments): Added.
27813         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
27814         BlackBerry port.
27815
27816 2011-12-21  Daniel Bates  <dbates@webkit.org>
27817
27818         Extract WinCE CMake arguments from build-webkit into separate function
27819         https://bugs.webkit.org/show_bug.cgi?id=74983
27820
27821         Reviewed by Rob Buis.
27822
27823         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
27824         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
27825         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
27826         that we can pass it to the CMake build system when building JavaScriptCore.
27827
27828         * Scripts/build-webkit:
27829         * Scripts/webkitdirs.pm:
27830         (cmakeBasedPortArguments): Added.
27831
27832 2011-12-21  Kentaro Hara  <haraken@chromium.org>
27833
27834         In prepare-ChangeLog, replace constant global variables with "use constant"
27835         https://bugs.webkit.org/show_bug.cgi?id=74992
27836
27837         Reviewed by Ryosuke Niwa.
27838
27839         This patch replaces the following constant global variables with "use constant"s.
27840             - $changeLogTimeZone
27841             - $SVN
27842             - $GIT
27843             - %supportedTestExtensions
27844
27845         * Scripts/prepare-ChangeLog:
27846         (changeLogNameFromArgs):
27847         (changeLogEmailAddressFromArgs):
27848         (resolveConflictedChangeLogs):
27849         (generateNewChangeLogs):
27850         (diffCommand):
27851         (statusCommand):
27852         (createPatchCommand):
27853         (findOriginalFileFromSvn):
27854         (determinePropertyChanges):
27855         (generateFileList):
27856         (reviewerAndDescriptionForGitCommit):
27857
27858 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
27859
27860         nrwt: rename field references from _fs to _filesystem
27861         https://bugs.webkit.org/show_bug.cgi?id=74898
27862
27863         Reviewed by Adam Barth.
27864
27865         This is a simple cleanup; most of the code uses
27866         self._filesystem, but some used self._fs; this change renames
27867         the latter to the former to be more consistent.
27868
27869         * Scripts/webkitpy/layout_tests/controllers/manager.py:
27870         (Manager.__init__):
27871         (Manager.collect_tests):
27872         (Manager._strip_test_dir_prefix):
27873         (Manager._split_into_chunks_if_necessary):
27874         (Manager.results_directory):
27875         (Manager._clobber_old_results):
27876         (Manager._upload_json_files):
27877         (Manager.print_config):
27878         (Manager._copy_results_html_file):
27879         (Manager._show_results_html_file):
27880         (Manager._log_worker_stack):
27881         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
27882         (JSONLayoutResultsGenerator._normalize_results_json):
27883         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
27884         (JSONResultsGeneratorBase.__init__):
27885         (JSONResultsGeneratorBase.generate_json_output):
27886         (JSONResultsGeneratorBase.generate_times_ms_file):
27887         (JSONResultsGeneratorBase.upload_json_files):
27888         (JSONResultsGeneratorBase._get_svn_revision):
27889         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
27890         (Base.__init__):
27891
27892 2011-12-20  Kentaro Hara  <haraken@chromium.org>
27893
27894         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
27895         https://bugs.webkit.org/show_bug.cgi?id=74836
27896
27897         Reviewed by David Kilzer.
27898
27899         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
27900         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
27901         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
27902         of prepare-ChangeLog.
27903
27904         Using LoadAsModule.pm, you can load a Perl script as follows.
27905         The first argument is the arbitrary package name you want to use, and the second argument
27906         is the name of the Perl script you want to load.
27907
27908             use LoadAsModule qw(RunLeaks run-leaks);
27909             RunLeaks::someFunctionDefinedInRunLeaks(...);
27910
27911         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
27912                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
27913                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
27914
27915         * Scripts/webkitperl/LoadAsModule.pm: Added.
27916         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
27917         (import):
27918         (readFile):
27919         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
27920         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
27921         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
27922
27923 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
27924
27925         [Qt] WK2 Debugging quirks need some improvement
27926         https://bugs.webkit.org/show_bug.cgi?id=74859
27927
27928         Reviewed by Simon Hausmann.
27929
27930         Improvements added to make debugging WebKit2 more
27931         confortable and efficient:
27932         1. Unify debugging quirks. From now all of them are controlled
27933         by the QT_WEBKIT2_DEBUG environment variable.
27934         2. Disable crash handlers for WebKitTestRunner if debugging quirks
27935         are used to make it possible to use postmortem debugging via core dumps
27936         which is extremely useful for debugging bugs triggered by layout tests.
27937         3. Disable test timeout for WebKitTestRunner if debugging quirks
27938         are used because that makes debugging impossible.
27939
27940         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
27941         (WTR::InjectedBundle::platformInitialize):
27942         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
27943         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
27944         * WebKitTestRunner/qt/TestControllerQt.cpp:
27945         (WTR::TestController::platformRunUntil):
27946
27947 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
27948
27949         [Qt][WK2] Implement favicon support
27950         https://bugs.webkit.org/show_bug.cgi?id=71082
27951
27952         Reviewed by Simon Hausmann.
27953
27954         A favorite icon was added on MiniBrowser's url bar as example.
27955         We display a default icon when the page doesn't have an icon ready.
27956
27957         * MiniBrowser/qt/MiniBrowser.qrc:
27958         * MiniBrowser/qt/icons/favicon.png: Added.
27959         * MiniBrowser/qt/qml/BrowserWindow.qml:
27960
27961 2011-12-19  Sam Weinig  <sam@webkit.org>
27962
27963         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
27964         https://bugs.webkit.org/show_bug.cgi?id=74907
27965
27966         Reviewed by Dan Bernstein.
27967
27968         Add ScrollByLineCommands API test.
27969
27970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
27971         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
27972         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
27973
27974 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
27975
27976         webkitpy: remove port.executive, port.filesystem, port.user properties
27977         https://bugs.webkit.org/show_bug.cgi?id=74896
27978
27979         Reviewed by Eric Seidel.
27980
27981         Following on the refactoring of the port and host objects, this
27982         removes the public executive, filesystem, and user properties
27983         from the Port interface (protected versions of executive and
27984         filesystem still exist). There is still some more clean up to
27985         make the code more consistent and rearrange some other files to
27986         talk to Hosts directly instead of getting them off of the Port
27987         class.
27988
27989         * Scripts/webkitpy/layout_tests/controllers/manager.py:
27990         (Manager.__init__):
27991         (Manager.results_directory):
27992         (Manager._log_worker_stack):
27993         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
27994         (ManagerTest.test_fallback_path_in_config):
27995         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
27996         (_InlineManager.start_worker):
27997         (_InlineWorkerConnection.__init__):
27998         * Scripts/webkitpy/layout_tests/controllers/worker.py:
27999         (Worker.safe_init):
28000         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
28001         (TestConfiguration.from_port):
28002         * Scripts/webkitpy/layout_tests/port/base.py:
28003         (Port.__init__):
28004         (Port.tests):
28005         (Port.show_results_html_file):
28006         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
28007         (PortTest.test_layout_tests_skipping):
28008         (PortTest.test_test_dirs):
28009         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
28010         (_set_up_derived_options):
28011         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
28012         (PerfTestsRunner.__init__):
28013         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
28014         (HtmlGenerator.__init__):
28015         (HtmlGenerator.show_html):
28016         (real_main):
28017         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
28018         (TestHtmlGenerator.make_generator):
28019
28020 2011-12-19  Daniel Bates  <dbates@webkit.org>
28021
28022         Pass command line arguments to GDB when debugging a Mac WebKit application
28023         https://bugs.webkit.org/show_bug.cgi?id=72829
28024
28025         Reviewed by David Kilzer.
28026
28027         Pass through any command line arguments given to debug-{safari, minibrowser}
28028         to GDB so that they may influence the application instance launched by GDB.
28029
28030         * Scripts/webkitdirs.pm:
28031         (execMacWebKitAppForDebugging):
28032
28033 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
28034
28035         webkitpy: remove executive,filesystem,user parameters from Port constructor
28036         https://bugs.webkit.org/show_bug.cgi?id=74878
28037
28038         Reviewed by Eric Seidel.
28039
28040         This change concludes the refactoring that makes Host a required
28041         parameter for Port and ensures that all access to filesystem,
28042         executives, etc. is going through the Host.
28043
28044         * Scripts/webkitpy/layout_tests/port/base.py:
28045         (Port.__init__):
28046
28047 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
28048
28049         webkitpy: finish refactoring port classes to make a host mandatory
28050         https://bugs.webkit.org/show_bug.cgi?id=74566
28051
28052         Reviewed by Eric Seidel.
28053
28054         This change makes all Port objects take a required (System)Host
28055         parameter, and updates the TestPort object to no longer create a
28056         mock filesystem or add files to the existing filesystem by
28057         default.
28058
28059         * Scripts/webkitpy/layout_tests/port/base.py:
28060         (Port.__init__):
28061         * Scripts/webkitpy/layout_tests/port/factory.py:
28062         (PortFactory.__init__):
28063         (PortFactory._get_kwargs):
28064         * Scripts/webkitpy/layout_tests/port/test.py:
28065         (TestInstance.__init__):
28066         (TestPort.__init__):
28067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
28068         (passing_run):
28069         (logging_run):
28070         (get_tests_run):
28071         (MainTest.test_single_file):
28072         (MainTest.test_stderr_is_saved):
28073         (MainTest.test_test_list):
28074         (MainTest.test_test_list_with_prefix):
28075         (MainTest.test_missing_and_unexpected_results):
28076         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
28077         (MainTest.test_crash_with_stderr):
28078         (MainTest.test_no_image_failure_with_image_diff):
28079         (MainTest.test_crash_log):
28080         (MainTest.test_web_process_crash_log):
28081         (MainTest.test_exit_after_n_failures_upload):
28082         (MainTest.test_results_directory_absolute):
28083         (MainTest.test_results_directory_relative):
28084         (MainTest.test_retries_directory):
28085         (MainTest.test_tolerance.get_port_for_run):
28086         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
28087         (EndToEndTest.test_end_to_end):
28088         (EndToEndTest.test_reftest_with_two_notrefs):
28089         (RebaselineTest.test_reset_results):
28090         (RebaselineTest.test_missing_results):
28091         (RebaselineTest.test_new_baseline):
28092         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
28093         (Rebaseliner.__init__):
28094         (main):
28095         (real_main):
28096         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
28097         (test_host_port_and_filesystem):
28098         (TestRebaseliner.make_rebaseliner):
28099         (TestRealMain.test_all_platforms):
28100         (TestHtmlGenerator.make_generator):
28101
28102 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
28103
28104         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
28105         https://bugs.webkit.org/show_bug.cgi?id=74562
28106
28107         Reviewed by Eric Seidel.
28108
28109         Apart from a minor change to style/checkers/test_expectations.py
28110         to take a host as a parameter to a TestExpectationsChecker(),
28111         there are only refactoring changes to unit tests here.
28112
28113         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
28114         (TestResultWriterTest.test_reftest_diff_image):
28115         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
28116         (JSONGeneratorTest._test_json_generation):
28117         (JSONGeneratorTest.test_test_timings_trie):
28118         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
28119         (Base.__init__):
28120         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
28121         (PortTest.make_port):
28122         (PortTest.test_layout_tests_skipping):
28123         (PortTest.test_test_dirs):
28124         (PortTest.test_additional_platform_directory):
28125         (PortTest.test_uses_test_expectations_file):
28126         (PortTest.test_find_no_paths_specified):
28127         (PortTest.test_find_one_test):
28128         (PortTest.test_find_glob):
28129         (PortTest.test_find_with_skipped_directories):
28130         (PortTest.test_find_with_skipped_directories_2):
28131         (PortTest.test_parse_reftest_list):
28132         * Scripts/webkitpy/layout_tests/port/dryrun.py:
28133         (DryRunPort.__init__):
28134         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
28135         (FactoryTest.setUp):
28136         (FactoryTest.tearDown):
28137         (FactoryTest.assert_port):
28138         (FactoryTest.assert_platform_port):
28139         (FactoryTest.test_unknown_specified):
28140         (FactoryTest.test_unknown_default):
28141         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
28142         (GetGoogleChromePortTest._verify_expectations_overrides):
28143         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
28144         (MockDRTPortTest.make_port):
28145         (MockDRTTest.assertTest):
28146         (MockDRTTest.test_main):
28147         (MockChromiumDRTTest.test_pixeltest__fails):
28148         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
28149         (QtPortTest._assert_search_path):
28150         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
28151         (TestWebKitPort.__init__):
28152         (WebKitPortTest.test_skipped_directories_for_symbols):
28153         (test_skipped_directories_for_features):
28154         (test_skipped_layout_tests):
28155         (test_skipped_file_search_paths):
28156         (test_root_option):
28157         (test_test_expectations):
28158         (test_build_driver):
28159         (test_linux_distro_detection):
28160         (test_apache_config_file_name_for_platform):
28161         (test_path_to_apache_config_file):
28162         (WebKitDriverTest.test_read_block):
28163         * Scripts/webkitpy/style/checkers/test_expectations.py:
28164         (TestExpectationsChecker.__init__):
28165         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
28166         (TestExpectationsTestCase._expect_port_for_expectations_path):
28167         (TestExpectationsTestCase.assert_lines_lint):
28168         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
28169         (get_test_config.TestMacPort):
28170
28171 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
28172
28173         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
28174         https://bugs.webkit.org/show_bug.cgi?id=74854
28175
28176         Reviewed by Csaba Osztrogonác.
28177
28178         Since r101052, libewebkit.so is built in a different location, so we
28179         need to adjust the path returned by builtDylibPathForName.
28180
28181         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
28182         port also respects Release/Debug configurations.
28183
28184         These changes should make run-launcher finally work correctly with
28185         webkit-efl.
28186
28187         * Scripts/webkitdirs.pm:
28188         (usesPerConfigurationBuildDirectory):
28189         (builtDylibPathForName):
28190
28191 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
28192
28193         [Qt][WK2] Add support for modal event loop processing for WTR
28194         https://bugs.webkit.org/show_bug.cgi?id=74852
28195
28196         Reviewed by Kenneth Rohde Christiansen.
28197
28198         Rewrote event loop processing: Instead of terminating the event loop
28199         in notifyDone() - something no other platform does - we now respect the
28200         "bool& condition" parameter passed to platformRunUntil. This ensures
28201         proper termination even when the condition is changed from within a
28202         nested event loop, because only when we _exit_ from the nested event
28203         loop we will check the condition and terminate the test properly.
28204
28205         In addition this patch implements TestController::runModal by means of
28206         a nested event loop, which is passed to the platform webview that is
28207         supposed to be modal. It is that view's responsibility to exit the
28208         loop, upon destruction. I believe that's similar to how it works on the Mac,
28209         where it doesn't seem that NSApp's runModalForWindow is terminate via
28210         abort/stopModal but simply because the window is closed.
28211
28212         * WebKitTestRunner/PlatformWebView.h:
28213         (WTR::PlatformWebView::setModalEventLoop):
28214         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
28215         (WTR::PlatformWebView::PlatformWebView):
28216         (WTR::PlatformWebView::~PlatformWebView):
28217         * WebKitTestRunner/qt/TestControllerQt.cpp:
28218         (WTR::TestController::notifyDone):
28219         (WTR::TestController::platformRunUntil):
28220         (WTR::TestController::runModal):
28221
28222 2011-12-18  Kentaro Hara  <haraken@chromium.org>
28223
28224         REGRESSION(r103149): prepare-ChangeLog outputs a warning
28225         https://bugs.webkit.org/show_bug.cgi?id=74808
28226
28227         Reviewed by David Kilzer.
28228
28229         Added the prototype declaration of main() to avoid warning messages.
28230         Sorted subroutine declarations in the alphabetical order.
28231
28232         * Scripts/prepare-ChangeLog:
28233
28234 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
28235
28236         [Qt] Fix QtTestBrowser compilation with QtWidgets module
28237         https://bugs.webkit.org/show_bug.cgi?id=74791
28238
28239         Reviewed by Andreas Kling.
28240
28241         * QtTestBrowser/QtTestBrowser.pro:
28242
28243 2011-12-17  Kentaro Hara  <haraken@chromium.org>
28244
28245         Remove top-level code completely from prepare-ChangeLog
28246         https://bugs.webkit.org/show_bug.cgi?id=74698
28247
28248         Reviewed by Darin Adler.
28249
28250         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
28251         This patch just moves all top-level code into main().
28252
28253         * Scripts/prepare-ChangeLog:
28254         (main):
28255
28256 2011-12-16  Dean Jackson  <dino@apple.com>
28257
28258         Move webkit-bug-importer to Contributor. It won't
28259         autocomplete as an Account.
28260         See https://bugs.webkit.org/show_bug.cgi?id=74739
28261         for some discussion.
28262
28263         Unreviewed.
28264
28265         * Scripts/webkitpy/common/config/committers.py:
28266
28267 2011-12-16  Dean Jackson  <dino@apple.com>
28268
28269         Add webkit-bug-importer@group.apple.com to accounts
28270         so that it autocompletes in bugzilla.
28271
28272         Unreviewed.
28273
28274         * Scripts/webkitpy/common/config/committers.py:
28275
28276 2011-12-16  Philippe Normand  <pnormand@igalia.com>
28277
28278         Unreviewed, skipping 3 failing GTK API tests.
28279
28280         * Scripts/run-gtk-tests:
28281
28282 2011-12-16  Philippe Normand  <pnormand@igalia.com>
28283
28284         Unreviewed, GTK API tests build fix attempt.
28285
28286         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
28287
28288 2011-12-16  Philippe Normand  <pnormand@igalia.com>
28289
28290         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
28291
28292         * Scripts/run-gtk-tests:
28293
28294 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
28295
28296         [Qt] Fix the build for newer Qt5
28297         https://bugs.webkit.org/show_bug.cgi?id=74703
28298
28299         Reviewed by Csaba Osztrogonác.
28300
28301         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
28302         * DumpRenderTree/qt/EventSenderQt.cpp:
28303         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
28304         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
28305         (WTR::EventSenderProxy::sendTouchEvent):
28306         * MiniBrowser/qt/MiniBrowserApplication.cpp:
28307         (MiniBrowserApplication::sendTouchEvent): Ditto.
28308         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
28309
28310 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
28311
28312         [Qt] Detect and force clean build when feature defines are added
28313
28314         Reviewed by Ossy.
28315
28316         https://bugs.webkit.org/show_bug.cgi?id=74689
28317
28318         * Scripts/webkitdirs.pm:
28319
28320 2011-12-16  Kentaro Hara  <haraken@chromium.org>
28321
28322         [Refactoring] Remove all global variables from prepare-ChangeLog
28323         https://bugs.webkit.org/show_bug.cgi?id=74681
28324
28325         Reviewed by Ryosuke Niwa.
28326
28327         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
28328         manner. This bug is one of the incremental refactorings to remove all top-level
28329         code and global variables from prepare-ChangeLog. In this patch,
28330         we make the following global variables be used only through parameter passing.
28331         This patch removes all global variables from prepare-ChangeLog.
28332             - $mergeBase
28333             - $gitCommit
28334             - $gitIndex
28335
28336         * Scripts/prepare-ChangeLog:
28337         (generateFunctionLists):
28338         (changeLogNameFromArgs):
28339         (changeLogEmailAddressFromArgs):
28340         (generateNewChangeLogs):
28341         (printDiff):
28342         (diffFromToString):
28343         (diffCommand):
28344         (statusCommand):
28345         (createPatchCommand):
28346         (generateFileList):
28347         (isConflictStatus):
28348
28349 2011-12-15  Philippe Normand  <pnormand@igalia.com>
28350
28351         [GTK] Rounding errors on 32-bit machines causes tests to fail
28352         https://bugs.webkit.org/show_bug.cgi?id=72254
28353
28354         Initial patch by vanuan@gmail.com.
28355         Reviewed by Martin Robinson.
28356
28357         * Scripts/webkitdirs.pm:
28358         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
28359         CXXFLAGS to autogen in an attempt to harmonize floating point
28360         values between 32-bit and 64-bit architectures.
28361
28362 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
28363
28364         [GTK] Make distcheck fails during the install
28365         https://bugs.webkit.org/show_bug.cgi?id=74274
28366
28367         No review, since this is a build fix.
28368
28369         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
28370         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
28371         always runs. This means that the gtkdoc step was always running when make was
28372         invoked. Generating gtkdoc during 'make install' was triggering a race condition
28373         with the library file. Later we can fix generate-forwarding-headers and unbreak
28374         'make docs,' but this bandaid is sufficient to let us release.
28375
28376 2011-12-15  Eric Seidel  <eric@webkit.org>
28377
28378         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
28379         https://bugs.webkit.org/show_bug.cgi?id=74650
28380
28381         Reviewed by Adam Barth.
28382
28383         * Scripts/webkitpy/common/system/platforminfo.py:
28384         (PlatformInfo._compute_bytes_from_vm_stat_output):
28385         * Scripts/webkitpy/layout_tests/port/base.py:
28386         (Port.default_child_processes):
28387         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
28388         (PortTest.test_default_child_processes):
28389
28390 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
28391
28392         bencher script should support remote benchmarking on platforms that don't have ruby
28393         https://bugs.webkit.org/show_bug.cgi?id=74659
28394
28395         Rubber-stamped by Sam Weinig.
28396
28397         Added the ability to have bencher generate a benchmarking playload that consists of
28398         copies of all of the benchmarks, optionally copies of all of the frameworks and
28399         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
28400         order, which then spits out a raw results file that bencher can parse.
28401
28402         In normal operating mode, you never see this, as it just generates the payload and
28403         script internally, runs it, parses the results, and spits them out.
28404
28405         The --remote mode has been changed to use this style, so any remote host that has
28406         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
28407         a sh-compatible shell can be used for remote benchmarking.
28408
28409         The feature to include VMs in the benchmarking payload is by default only activated
28410         when using --remote, but it can also be activated when doing local benchmarking; the
28411         benefit is that you remove any pathname-related performance pathologies. All VMs
28412         become equal because they are all located in
28413         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
28414         (usually 0 or 1).
28415
28416         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
28417         through DumpRenderTree. This is only a bit slower than running in jsc.
28418
28419         * Scripts/bencher:
28420
28421 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
28422
28423         webkitpy: clean up TestPort to (mostly) not create a new filesystem
28424         https://bugs.webkit.org/show_bug.cgi?id=74556
28425
28426         This change modifies the TestPort to be ready to add tests to an
28427         existing filesystem instead of creating a new filesystem; we
28428         leave unit_test_filesystem() in for now for compatibility.
28429
28430         * Scripts/webkitpy/common/host_mock.py:
28431         (MockHost.__init__):
28432           - call add_unit_tests_to_mock_filesystem by default to make
28433             the MockHost more generally useful for layout_test unit tests.
28434         * Scripts/webkitpy/layout_tests/port/test.py:
28435         (TestInstance.__init__):
28436         (add_unit_tests_to_mock_filesystem):
28437         (add_file):
28438         (unit_test_filesystem):
28439         (TestPort.__init__):
28440         (TestPort._set_default_overriding_none):
28441
28442 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
28443
28444         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
28445         https://bugs.webkit.org/show_bug.cgi?id=74551
28446
28447         This is some minor cleanup prior to making all of the host/port
28448         changes described in bug 74138.
28449
28450         * Scripts/webkitpy/common/host_mock.py:
28451         (MockHost.__init__):
28452           - make sure the scm object is initialized with the same mock
28453             executive and filesystem objects.
28454
28455         * Scripts/webkitpy/common/system/filesystem_mock.py:
28456         (MockFileSystem.clear_written_files):
28457           - add a routine that will be useful in testing.
28458         (MockFileSystem.maybe_make_directory):
28459         (MockFileSystem.write_binary_file):
28460           - fix bugs to make sure directories are created properly.
28461         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
28462         (_Process.run):
28463           - add clarifying comments.
28464         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
28465         (MockDRTPort.__init__):
28466         (MockDRT.__init__):
28467           - add clarifying comments.
28468
28469 2011-12-15  Anders Carlsson  <andersca@apple.com>
28470
28471         Regression (r102866): Navigating away from or closing a page with a plugin crashes
28472         https://bugs.webkit.org/show_bug.cgi?id=74655
28473
28474         Reviewed by Sam Weinig.
28475
28476         Add a bunch of tests.
28477
28478         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28479
28480 2011-12-15  Stephanie Lewis  <slewis@apple.com>
28481
28482         https://bugs.webkit.org/show_bug.cgi?id=74469
28483         Escape paths to svn commands so our tools can handle filenames with @ symbols.
28484
28485         Reviewed by Adam Roben.
28486
28487         * Scripts/VCSUtils.pm:
28488         (scmMoveOrRenameFile):
28489         (scmAddExecutableBit):
28490         (scmRemoveExecutableBit):
28491         (determineSVNRoot):
28492         (svnRevisionForDirectory):
28493         (pathRelativeToSVNRepositoryRootForPath):
28494         (svnStatus):
28495         (escapeSubversionPath):
28496         * Scripts/parse-malloc-history:
28497         (main):
28498         * Scripts/prepare-ChangeLog:
28499         (diffCommand):
28500         (statusCommand):
28501         (findOriginalFileFromSvn):
28502         (determinePropertyChanges):
28503         * Scripts/resolve-ChangeLogs:
28504         (conflictFiles):
28505         (resolveConflict):
28506         (showStatus):
28507         * Scripts/svn-apply:
28508         (patch):
28509         (scmCopy):
28510         (scmAdd):
28511         (scmRemove):
28512         * Scripts/svn-create-patch:
28513         (findBaseUrl):
28514         (findMimeType):
28515         (findSourceFileAndRevision):
28516         (generateDiff):
28517         (generateFileList):
28518         (manufacturePatchForAdditionWithHistory):
28519         * Scripts/svn-unapply:
28520         (patch):
28521         (revertDirectories):
28522
28523 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
28524
28525         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
28526         https://bugs.webkit.org/show_bug.cgi?id=74617
28527
28528         Reviewed by Kenneth Rohde Christiansen.
28529
28530         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
28531         for viewport info button, adjusted height and added rounded corners.
28532
28533 2011-12-15  Andy Estes  <aestes@apple.com>
28534
28535         TestFailures: store the name of the buildbot results directory in a property
28536         https://bugs.webkit.org/show_bug.cgi?id=74663
28537
28538         Reviewed by Adam Barth.
28539
28540         Store the name of the results directory as a property on Buildbot's
28541         prototype. This allows subclasses of Buildbot to customize the results
28542         directory.
28543
28544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
28545         (Buildbot.prototype.resultsDirectoryURL):
28546
28547 2011-12-15  Tony Chang  <tony@chromium.org>
28548
28549         [chromium] pass --delete_unversioned_trees to gclient on the bots
28550         https://bugs.webkit.org/show_bug.cgi?id=74565
28551
28552         Reviewed by Kenneth Russell.
28553
28554         It was temporarily removed in r102891 to keep the bots green.  Now
28555         that the bots have cycled, we can add it back.
28556
28557         * Scripts/update-webkit-chromium:
28558
28559 2011-12-15  Kentaro Hara  <haraken@chromium.org>
28560
28561         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
28562         https://bugs.webkit.org/show_bug.cgi?id=74497
28563
28564         Reviewed by Ryosuke Niwa.
28565
28566         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
28567         manner. This bug is one of the incremental refactorings to remove all top-level
28568         code and global variables from prepare-ChangeLog. In this patch,
28569         we make the following global variables be used only through parameter passing.
28570             - $bugDescription
28571             - $bugNumber
28572             - $name
28573             - $emailAddress
28574             - $gitReviewer
28575             - $writeChangeLogs
28576
28577         * Scripts/prepare-ChangeLog:
28578         (fetchBugDescriptionFromURL):
28579         (generateNewChangeLogs):
28580         (reviewerAndDescriptionForGitCommit):
28581
28582 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
28583
28584         [EFL] Add a few more web database functions to ewk_settings.
28585         https://bugs.webkit.org/show_bug.cgi?id=72148
28586
28587         Reviewed by Antonio Gomes.
28588
28589         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
28590         (LayoutTestController::clearAllDatabases):
28591         (LayoutTestController::setDatabaseQuota):
28592
28593 2011-12-15  Martin Kosiba  <mkosiba@google.com>
28594
28595         Fix find on web pages with -webkit-user-select: none for Chromium
28596         https://bugs.webkit.org/show_bug.cgi?id=72281
28597
28598         Reviewed by Ryosuke Niwa.
28599
28600         Provided a partial findString implementation. This doesn't support
28601         all of the FindOptions since they're not exposed via WebFindOptions.
28602
28603         * DumpRenderTree/chromium/LayoutTestController.cpp:
28604         (LayoutTestController::LayoutTestController):
28605         (LayoutTestController::findString):
28606         * DumpRenderTree/chromium/LayoutTestController.h:
28607
28608 2011-12-15  Kenneth Russell  <kbr@google.com>
28609
28610         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
28611         https://bugs.webkit.org/show_bug.cgi?id=74581
28612
28613         Reviewed by Darin Fisher.
28614
28615         * DumpRenderTree/chromium/LayoutTestController.cpp:
28616         (LayoutTestController::overridePreference):
28617         * DumpRenderTree/chromium/WebPreferences.cpp:
28618         (WebPreferences::reset):
28619         (WebPreferences::applyTo):
28620         * DumpRenderTree/chromium/WebPreferences.h:
28621
28622 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
28623
28624         [Qt] Improve the look of the viewport info overlay
28625
28626         Reviewed by Tor Arne Vestbø.
28627
28628         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
28629
28630 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
28631
28632         [Qt] Support requestAnimationFrame API
28633         https://bugs.webkit.org/show_bug.cgi?id=74528
28634
28635         Add build-option for requestAnimationFrame feature.
28636
28637         Reviewed by Kenneth Rohde Christiansen.
28638
28639         * qmake/mkspecs/features/features.prf:
28640
28641 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
28642
28643         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
28644
28645         Reviewed by Simon Hausmann.
28646
28647         * qmake/mkspecs/features/webcore.prf:
28648
28649 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
28650
28651         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
28652         https://bugs.webkit.org/show_bug.cgi?id=72893
28653
28654         Reviewed by Kenneth Rohde Christiansen.
28655
28656         This patch extends QQuickWebViewExperimental by a property named
28657         viewportInfo, which contains the viewport scalability and
28658         layout and contents size information. This property is exposed to
28659         QML through the experimental extension for QQuickWebView.
28660
28661         * MiniBrowser/qt/MiniBrowser.pro:
28662         * MiniBrowser/qt/MiniBrowser.qrc:
28663         * MiniBrowser/qt/icons/info.png: Added.
28664         * MiniBrowser/qt/qml/BrowserWindow.qml:
28665         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
28666
28667 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
28668
28669         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
28670         https://bugs.webkit.org/show_bug.cgi?id=74586
28671
28672         Reviewed by Hajime Morita.
28673
28674         No new tests. Covered by existing tests.
28675
28676         * DumpRenderTree/chromium/WebViewHost.cpp:
28677         (WebViewHost::requestCheckingOfText):
28678           Returns immediately if text is empty.
28679
28680 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
28681
28682         [Qt] QtWebKit fails to build on Mac OS X after r102776
28683         https://bugs.webkit.org/show_bug.cgi?id=74593
28684
28685         Reviewed by Simon Hausmann.
28686
28687         CONFIG =+ link_pkgconfig is needed such that the correct parameters
28688         are passed to the compiler.
28689
28690         * DumpRenderTree/qt/DumpRenderTree.pro:
28691
28692 2011-12-14  Tony Chang  <tony@chromium.org>
28693
28694         [chromium] Remove redundant third_party entries from chromium DEPS
28695         https://bugs.webkit.org/show_bug.cgi?id=74472
28696
28697         Reviewed by Kenneth Russell.
28698
28699         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
28700
28701 2011-12-14  Kentaro Hara  <haraken@chromium.org>
28702
28703         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
28704         VCSUtils::isGit() and VCSUtils::isSVN().
28705         https://bugs.webkit.org/show_bug.cgi?id=74485
28706
28707         Reviewed by David Kilzer.
28708
28709         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
28710         manner. This bug is one of the incremental refactorings to remove all top-level
28711         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
28712         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
28713         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
28714         just by looking at the current working directory.
28715
28716         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
28717         (diffFromToString):
28718         (diffCommand):
28719         (statusCommand):
28720         (createPatchCommand):
28721         (diffHeaderFormat):
28722         (generateFileList):
28723         (isAddedStatus):
28724         (isConflictStatus):
28725         (statusDescription):
28726         (extractLineRange):
28727
28728 2011-12-14  Sam Weinig  <weinig@apple.com>
28729
28730         Remove whitespace from InheritedPropertySheets attributes in
28731         vsprops files to appease the Visual Studio project migrator.
28732
28733         Reviewed by Adam Roben.
28734
28735         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
28736         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
28737         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
28738         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
28739         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
28740         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
28741         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
28742         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
28743         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
28744         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
28745         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
28746         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
28747         * DumpRenderTree/win/ImageDiffDebug.vsprops:
28748         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
28749         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
28750         * DumpRenderTree/win/ImageDiffProduction.vsprops:
28751         * DumpRenderTree/win/ImageDiffRelease.vsprops:
28752         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
28753         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
28754         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
28755         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
28756         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
28757         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
28758         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
28759         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
28760         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
28761         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
28762         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
28763         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
28764         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
28765         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
28766         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
28767         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
28768         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
28769         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
28770         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
28771         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
28772         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
28773         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
28774         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
28775         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
28776         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
28777         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
28778         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
28779         * WinLauncher/WinLauncherDebug.vsprops:
28780         * WinLauncher/WinLauncherDebugAll.vsprops:
28781         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
28782         * WinLauncher/WinLauncherProduction.vsprops:
28783         * WinLauncher/WinLauncherRelease.vsprops:
28784         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
28785         * record-memory-win/record-memory-winDebug.vsprops:
28786         * record-memory-win/record-memory-winDebugAll.vsprops:
28787         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
28788         * record-memory-win/record-memory-winProduction.vsprops:
28789         * record-memory-win/record-memory-winRelease.vsprops:
28790         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
28791
28792 2011-12-14  Anders Carlsson  <andersca@apple.com>
28793
28794         Windows build fix.
28795
28796         Move CHECKs out of the destructor.
28797
28798         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28799         (TestWebKitAPI::B::~B):
28800         (TestWebKitAPI::TEST):
28801
28802 2011-12-14  Anders Carlsson  <andersca@apple.com>
28803
28804         binding a member function should ref/deref the object pointer if needed
28805         https://bugs.webkit.org/show_bug.cgi?id=74552
28806
28807         Reviewed by Sam Weinig.
28808
28809         Add new tests.
28810
28811         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28812         (TestWebKitAPI::B::B):
28813         (TestWebKitAPI::B::~B):
28814         (TestWebKitAPI::B::ref):
28815         (TestWebKitAPI::B::deref):
28816         (TestWebKitAPI::B::f):
28817         (TestWebKitAPI::B::g):
28818         (TestWebKitAPI::TEST):
28819
28820 2011-12-14  Hajime Morrita  <morrita@chromium.org>
28821
28822         JS_INLINE and WTF_INLINE should be visible from WebCore
28823         https://bugs.webkit.org/show_bug.cgi?id=73191
28824
28825         Reviewed by Kevin Ollivier.
28826
28827         Removed macro definitions which is now provided by Platform.h
28828
28829         * DumpRenderTree/chromium/config.h:
28830         * DumpRenderTree/config.h:
28831         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
28832         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
28833         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
28834         * TestWebKitAPI/config.h:
28835         * WebKitTestRunner/config.h:
28836
28837 2011-12-14  Kentaro Hara  <haraken@chromium.org>
28838
28839         Unreviewed, rolling out r102761.
28840         http://trac.webkit.org/changeset/102761
28841         https://bugs.webkit.org/show_bug.cgi?id=74485
28842
28843         we came up with a better fix than this (see comments in bug
28844         74485)
28845
28846         * Scripts/prepare-ChangeLog:
28847         (generateFunctionLists):
28848         (printDiff):
28849         (diffCommand):
28850         (statusCommand):
28851         (createPatchCommand):
28852         (generateFileList):
28853         (isAddedStatus):
28854         (isConflictStatus):
28855         (statusDescription):
28856         (extractLineRange):
28857
28858 2011-12-14  Anders Carlsson  <andersca@apple.com>
28859
28860         Work around a bug in the MSVC2005 compiler
28861         https://bugs.webkit.org/show_bug.cgi?id=74550
28862
28863         Reviewed by Sam Weinig.
28864
28865         Re-enable tests.
28866
28867         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28868
28869 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
28870
28871         [Qt] Test fonts are not used with Qt5
28872         https://bugs.webkit.org/show_bug.cgi?id=72513
28873
28874         My last unreviewed buildfix for this crazy bug.
28875
28876         * qmake/mkspecs/features/features.prf:
28877
28878 2011-12-14  Anders Carlsson  <andersca@apple.com>
28879
28880         Another attempt at fixing the Windows build.
28881
28882         Disable all the tests until I can figure out what's going on here.
28883
28884         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28885
28886 2011-12-14  Anders Carlsson  <andersca@apple.com>
28887
28888         Fix the Windows build.
28889
28890         Disable some of the tests for now.
28891
28892         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28893
28894 2011-12-14  Anders Carlsson  <andersca@apple.com>
28895
28896         bind should handle member functions
28897         https://bugs.webkit.org/show_bug.cgi?id=74529
28898
28899         Reviewed by Sam Weinig.
28900
28901         Add tests.
28902
28903         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28904         (TestWebKitAPI::A::A):
28905         (TestWebKitAPI::A::f):
28906         (TestWebKitAPI::A::addF):
28907         (TestWebKitAPI::TEST):
28908
28909 2011-12-14  Anders Carlsson  <andersca@apple.com>
28910
28911         Add unary and binary bind overloads
28912         https://bugs.webkit.org/show_bug.cgi?id=74524
28913
28914         Reviewed by Sam Weinig.
28915
28916         Add tests.
28917
28918         * TestWebKitAPI/Tests/WTF/Functional.cpp:
28919         (TestWebKitAPI::TEST):
28920         (TestWebKitAPI::multiplyByTwo):
28921         (TestWebKitAPI::multiplyByOneAndAHalf):
28922         (TestWebKitAPI::multiply):
28923         (TestWebKitAPI::subtract):
28924
28925 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
28926
28927         [Qt] Test fonts are not used with Qt5
28928         https://bugs.webkit.org/show_bug.cgi?id=72513
28929
28930         MIPS and SH4 buildfix after r102776 and r102795.
28931
28932         Reviewed by Csaba Osztrogonác.
28933
28934         * qmake/mkspecs/features/features.prf:
28935
28936 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
28937
28938         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
28939
28940         * qmake/mkspecs/features/features.prf:
28941
28942 2011-12-14  Andreas Kling  <kling@webkit.org>
28943
28944         Make my e-mail address a little more awesome.
28945
28946         * Scripts/webkitpy/common/config/committers.py:
28947
28948 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
28949
28950         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
28951
28952         * qmake/mkspecs/features/webcore.prf:
28953
28954 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
28955
28956         [Qt] Test fonts are not used with Qt5
28957         https://bugs.webkit.org/show_bug.cgi?id=72513
28958
28959         Reviewed by Simon Hausmann.
28960
28961         Don't depend on Q_WS_X11 anymore since it's not the Qt5
28962         way to detect the platform. Make the guards depend
28963         on our own configtest for fontconfig. For Qt4 we can still
28964         use the preassumption that we have it on Linux.
28965
28966         * DumpRenderTree/qt/DumpRenderTree.pro:
28967         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
28968         (WebCore::DumpRenderTree::open):
28969         (WebCore::DumpRenderTree::initializeFonts):
28970         * DumpRenderTree/qt/DumpRenderTreeQt.h:
28971         * DumpRenderTree/qt/main.cpp:
28972         (main): Additionally remove a nonsense piece of code that was
28973         trying to reset the font settings - which is not necessary -
28974         after we have already returned from main.
28975         * WebKitTestRunner/InjectedBundle/Target.pri:
28976         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
28977         (WTR::activateFonts):
28978         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
28979         from WTR. It is not needed. We set up the fonts via the injected bundle.
28980         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
28981         (main):
28982         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
28983         * qmake/mkspecs/features/features.prf:
28984         * qmake/sync.profile:
28985
28986 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
28987
28988         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
28989
28990         Followup to r102679
28991
28992         https://bugs.webkit.org/show_bug.cgi?id=74413
28993
28994         Reviewed by Simon Hausmann.
28995
28996         * qmake/mkspecs/features/webcore.prf:
28997
28998 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
28999
29000         [Qt] Mobile theme could use a little refresh
29001         https://bugs.webkit.org/show_bug.cgi?id=74293
29002
29003         Have MiniBrowser use the mobile theme when not
29004         passed --desktop.
29005
29006         Reviewed by Kenneth Rohde Christiansen.
29007
29008         * MiniBrowser/qt/MiniBrowserApplication.cpp:
29009         (MiniBrowserApplication::handleUserOptions):
29010
29011 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
29012
29013         [Qt] [Gardening] Remove qt-4.7 layout tests dir
29014         https://bugs.webkit.org/show_bug.cgi?id=74426
29015
29016         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
29017         on the tree.
29018
29019         Reviewed by Csaba Osztrogonác.
29020
29021         * Scripts/webkitpy/layout_tests/port/qt.py:
29022         (QtPort.qt_version):
29023         (QtPort.baseline_search_path):
29024         (QtPort._skipped_file_search_paths):
29025         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
29026         (QtPortTest._assert_search_path):
29027
29028 2011-12-14  Kentaro Hara  <haraken@chromium.org>
29029
29030         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
29031         through parameter passing
29032         https://bugs.webkit.org/show_bug.cgi?id=74485
29033
29034         Reviewed by Ryosuke Niwa.
29035
29036         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
29037         manner. This bug is one of the incremental refactorings to remove all top-level
29038         code and global variables from prepare-ChangeLog. In this patch,
29039         we make the following global variables be used only through parameter passing.
29040             - $isGit
29041             - $isSVN
29042
29043         * Scripts/prepare-ChangeLog:
29044         (generateFunctionLists):
29045         (printDiff):
29046         (diffFromToString):
29047         (diffCommand):
29048         (statusCommand):
29049         (createPatchCommand):
29050         (diffHeaderFormat):
29051         (generateFileList):
29052         (isAddedStatus):
29053         (isConflictStatus):
29054         (statusDescription):
29055         (extractLineRange):
29056
29057 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
29058
29059         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
29060         https://bugs.webkit.org/show_bug.cgi?id=74417
29061
29062         Reviewed by Simon Hausmann.
29063
29064         Based on original patch by Kenneth Christiansen.
29065
29066         Already covered by current tests.
29067
29068         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
29069         (WebCore::DumpRenderTree::DumpRenderTree):
29070         (WebCore::DumpRenderTree::~DumpRenderTree):
29071         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
29072         (LayoutTestController::setMockDeviceOrientation):
29073
29074 2011-12-03  Philippe Normand  <pnormand@igalia.com>
29075
29076         [GTK] Bad text rendering since r101343
29077         https://bugs.webkit.org/show_bug.cgi?id=73744
29078
29079         Reviewed by Martin Robinson.
29080
29081         Turn cairo hint metrics off for better font metrics reporting in
29082         the tests. This is especially important for SVG.
29083
29084         * DumpRenderTree/gtk/DumpRenderTree.cpp:
29085         (initializeGtkFontSettings):
29086         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
29087         (WTR::initializeGtkSettings):
29088
29089 2011-12-13  Kentaro Hara  <haraken@chromium.org>
29090
29091         [Refactoring] Remove several global variables from prepare-ChangeLog
29092         https://bugs.webkit.org/show_bug.cgi?id=74389
29093
29094         Reviewed by David Kilzer.
29095
29096         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
29097         manner. This bug is one of the incremental refactorings to remove all top-level
29098         code and global variables from prepare-ChangeLog. In this patch,
29099         we make the following global variables being used only through parameter passing.
29100             - %paths
29101             - $changedFiles
29102             - $conflictFiles
29103             - $functionLists
29104             - $bugURL
29105
29106         * Scripts/prepare-ChangeLog:
29107         (findChangeLogs):
29108         (generateNewChangeLogs):
29109         (processPaths):
29110         (generateFileList):
29111         (firstDirectoryOrCwd):
29112
29113 2011-12-13  Anders Carlsson  <andersca@apple.com>
29114
29115         Add a very bare-bones implementation of bind and Function to WTF
29116         https://bugs.webkit.org/show_bug.cgi?id=74462
29117
29118         Reviewed by Sam Weinig.
29119
29120         Add basic tests for WTF::Function and WTF::bind.
29121
29122         * TestWebKitAPI/TestWebKitAPI.gypi:
29123         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29124         * TestWebKitAPI/Tests/Functional.cpp: Added.
29125         (TestWebKitAPI::returnFortyTwo):
29126         (TestWebKitAPI::TEST):
29127         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
29128
29129 2011-12-13  Robin Dunn  <robin@alldunn.com>
29130
29131         [wx] Add a URL argument to wxWebView constructor.
29132         https://bugs.webkit.org/show_bug.cgi?id=74316
29133
29134         Reviewed by Kevin Ollivier.
29135
29136         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
29137         (MyApp::OnInit):
29138         * wx/browser/browser.cpp:
29139         (MyApp::OnInit):
29140
29141 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
29142
29143         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
29144         https://bugs.webkit.org/show_bug.cgi?id=74430
29145
29146         Reviewed by David Levin.
29147
29148         * Scripts/webkitpy/common/config/watchlist:
29149
29150 2011-12-13  Peter Beverloo  <peter@chromium.org>
29151
29152         [Chromium] Pull in FreeType and decrease check-out complexity for Android
29153         https://bugs.webkit.org/show_bug.cgi?id=74401
29154
29155         Decrease the check-out complexity by removing the need to first run
29156         "update-webkit-chromium --chromium" prior to running it with
29157         "--chromium-android", which was caused by an unversioned third_party/
29158         directory being created. This moves the Android NDK to Source/WebKit/
29159         chromium/, coming from third_party/ in that directory.
29160
29161         Reviewed by Adam Barth.
29162
29163         * Scripts/update-webkit-chromium:
29164         * Scripts/webkitdirs.pm:
29165         (buildChromiumMakefile):
29166
29167 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
29168
29169         build-jsc passing incorrect args to buildGtkProject
29170         https://bugs.webkit.org/show_bug.cgi?id=74308
29171
29172         Reviewed by Gustavo Noronha Silva.
29173
29174         * Scripts/build-webkit: Instead of invoking buildGtkProject with
29175         another argument about webkit2, unshift a --disable-webkit2
29176         argument onto the buildArgs.
29177         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
29178         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
29179         and build-jsc are run one after the other.
29180
29181 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
29182
29183         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
29184         https://bugs.webkit.org/show_bug.cgi?id=74413
29185
29186         Unreviewed buildfix.
29187
29188         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
29189
29190 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
29191
29192         [Qt] Unreviewed speculativ debug buildfix after r102679.
29193
29194         * QtTestBrowser/QtTestBrowser.pro:
29195         * QtTestBrowser/main.cpp:
29196
29197 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
29198
29199         [Qt] Get rid of layering violations in includes
29200
29201         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
29202         in the webcore.prf, but rather in each target that specificly needs
29203         headers in these location. We used to include them directly in webcore
29204         since we had layering violations between WebCore and WebKit, but now
29205         that they are gone there's no reason to do that.
29206
29207         Reviewed by Simon Hausmann.
29208
29209         * DumpRenderTree/qt/DumpRenderTree.pro:
29210         * QtTestBrowser/launcherwindow.h:
29211         * WebKitTestRunner/InjectedBundle/Target.pri:
29212         * qmake/mkspecs/features/webcore.prf:
29213         * qmake/mkspecs/features/webkit2.prf:
29214
29215 2011-12-13  János Badics  <dicska@gmail.com>
29216
29217         [NRWT] It crashes intermittently when there are WebProcess crashes
29218         https://bugs.webkit.org/show_bug.cgi?id=73451
29219
29220         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
29221
29222         Reviewed by Kenneth Rohde Christiansen.
29223
29224         * Scripts/webkitpy/layout_tests/port/server_process.py:
29225         (ServerProcess._check_for_crash):
29226
29227 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
29228
29229         Unreviewed. Fix GTK+ API docs build.
29230
29231         * gtk/generate-gtkdoc:
29232         (get_webkit2_options): Ignore WebKitUIClient since it's private
29233         API.
29234
29235 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
29236
29237         Reviewed, removed one of my email addresses to use the apprpriate one.
29238
29239         * Scripts/webkitpy/common/config/committers.py:
29240
29241 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
29242
29243         [Qt] Fix skip list search path and expected file search path in ORWT
29244         https://bugs.webkit.org/show_bug.cgi?id=74281
29245
29246         Expected file search path fixed.
29247
29248         Print all used skipped list and expected search path in verbose mode similar to NRWT.
29249
29250         Reviewed by Csaba Osztrogonác.
29251
29252         * Scripts/old-run-webkit-tests:
29253         (buildPlatformResultHierarchy):
29254         (buildPlatformTestHierarchy):
29255         (readSkippedFiles):
29256
29257 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
29258
29259         [Qt] Missing layoutTestController.dumpWillCacheResponse
29260         https://bugs.webkit.org/show_bug.cgi?id=74287
29261
29262         Reviewed by Csaba Osztrogonác.
29263
29264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
29265         (LayoutTestController::reset):
29266         (LayoutTestController::dumpWillCacheResponse):
29267         * DumpRenderTree/qt/LayoutTestControllerQt.h:
29268
29269 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
29270
29271         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
29272         https://bugs.webkit.org/show_bug.cgi?id=73771
29273
29274         Reviewed by Gustavo Noronha Silva.
29275
29276         When using a fallback font during testing, always use DejaVu Sans. This prevents
29277         falling back to DejaVu Serif on some systems.
29278
29279         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
29280
29281 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
29282
29283         Add myself as a committer
29284
29285         * Scripts/webkitpy/common/config/committers.py:
29286
29287 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
29288
29289         [Qt] [WK2] Support customizing popup menus with QML
29290         https://bugs.webkit.org/show_bug.cgi?id=73560
29291
29292         Reviewed by Tor Arne Vestbø.
29293
29294         Add an Item Selector to our WebView using the experimental API.
29295
29296         * MiniBrowser/qt/MiniBrowser.pro:
29297         * MiniBrowser/qt/MiniBrowser.qrc:
29298         * MiniBrowser/qt/qml/BrowserWindow.qml:
29299         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
29300
29301 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
29302
29303         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
29304         https://bugs.webkit.org/show_bug.cgi?id=74283
29305
29306         Reviewed by Simon Hausmann.
29307
29308         * MiniBrowser/qt/MiniBrowserApplication.cpp:
29309         (MiniBrowserApplication::sendTouchEvent):
29310
29311 2011-12-12  Kentaro Hara  <haraken@chromium.org>
29312
29313         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
29314         to show ChangeLogs diff and open ChangeLogs in an editor
29315         https://bugs.webkit.org/show_bug.cgi?id=74266
29316
29317         Reviewed by Ryosuke Niwa.
29318
29319         We are planning to write unit-tests for prepare-ChangeLog
29320         in a run-leaks_unittest manner. This patch is one of the incremental
29321         refactorings to remove all top-level code and global variables from
29322         prepare-ChangeLog.
29323
29324         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
29325         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
29326         Renamed @changed_files to @changedFiles.
29327         Renamed %conflict_files to %conflictFiles.
29328         (generateFunctionLists):
29329         (printDiff):
29330         (openChangeLogs):
29331
29332 2011-12-11  Kentaro Hara  <haraken@chromium.org>
29333
29334         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
29335         https://bugs.webkit.org/show_bug.cgi?id=74257
29336
29337         Reviewed by Ryosuke Niwa.
29338
29339         We are planning to write unit-tests for prepare-ChangeLog
29340         in a run-leaks_unittest/ manner. This patch is one of the incremental
29341         refactorings to remove all top-level code and global variables from
29342         prepare-ChangeLog.
29343
29344         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
29345         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
29346         into resolveConflictedChangeLogs().
29347         (getLatestChangeLogs):
29348         (resolveConflictedChangeLogs):
29349
29350 2011-12-11  Kentaro Hara  <haraken@chromium.org>
29351
29352         [Refactoring] Move top-level code to generate a new ChangeLog into a method
29353         https://bugs.webkit.org/show_bug.cgi?id=74253
29354
29355         Reviewed by David Kilzer.
29356
29357         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
29358         which requires to remove top-level code and global variables. This patch is one of
29359         the incremental refactorings for that.
29360
29361         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
29362         (generateFunctionLists):
29363         (findChangeLogs):
29364         (generateNewChangeLogs):
29365         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
29366
29367 2011-12-10  Kentaro Hara  <haraken@chromium.org>
29368
29369         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
29370         https://bugs.webkit.org/show_bug.cgi?id=74175
29371
29372         Reviewed by Ryosuke Niwa.
29373
29374         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
29375         This requires to remove top-level code. This patch is one of the incremental refactorings
29376         for that.
29377
29378         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
29379         (findChangeLogs):
29380
29381 2011-12-10  Andreas Kling  <kling@webkit.org>
29382
29383         Add my Apple e-mail to committers.py.
29384
29385         * Scripts/webkitpy/common/config/committers.py:
29386
29387 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
29388
29389         chromium win build: revert build_webkit_exes_from_webkit_gyp change
29390         https://bugs.webkit.org/show_bug.cgi?id=74225
29391
29392         This change sets build_webkit_exes_from_webkit_gyp back to 1;
29393         the "All.gyp" solution doesn't work on windows.
29394
29395         * Scripts/webkitdirs.pm:
29396         (buildChromium):
29397
29398 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
29399
29400         [Qt] Click's count is limited to three continuous clicks.
29401         https://bugs.webkit.org/show_bug.cgi?id=45666
29402
29403         Reviewed by Kenneth Rohde Christiansen.
29404
29405         Update m_time at every call to leapForward, so double clicks
29406         event are correctly sent by EventSender.
29407
29408         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
29409         (WTR::EventSenderProxy::updateClickCountForButton):
29410         (WTR::EventSenderProxy::leapForward):
29411
29412 2011-12-09  Kentaro Hara  <haraken@chromium.org>
29413
29414         [Refactoring] Reduce top-level code in prepare-ChangeLog
29415         https://bugs.webkit.org/show_bug.cgi?id=74172
29416
29417         Reviewed by Ryosuke Niwa.
29418
29419         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
29420         This requires to remove top-level code. This patch is one of the incremental refactorings
29421         for that.
29422
29423         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
29424         (generateFunctionLists):
29425
29426 2011-12-09  Sam Weinig  <sam@webkit.org>
29427
29428         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
29429         https://bugs.webkit.org/show_bug.cgi?id=74218
29430
29431         Reviewed by Anders Carlsson.
29432
29433         Add a test of the WKConnectionRef API.
29434
29435         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
29436         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
29437         (TestWebKitAPI::didCreateConnection):
29438         (TestWebKitAPI::connectionDidReceiveMessage):
29439         (TestWebKitAPI::connectionDidClose):
29440         (TestWebKitAPI::TEST):
29441         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
29442         (TestWebKitAPI::connectionDidReceiveMessage):
29443         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
29444         (TestWebKitAPI::WKConnectionTest::initialize):
29445
29446 2011-12-09  David Levin  <levin@chromium.org>
29447
29448         Hash* iterators should allow comparison between const and const versions.
29449         https://bugs.webkit.org/show_bug.cgi?id=73370
29450
29451         Reviewed by Darin Adler.
29452
29453         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
29454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
29455         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
29456         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
29457         (TestWebKitAPI::TEST): Add a test for the new functionality.
29458
29459 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
29460
29461         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
29462         https://bugs.webkit.org/show_bug.cgi?id=74212
29463
29464         Reviewed by Tony Chang.
29465
29466         The change introduced in r102201 to split the executables out of
29467         WebKit.gyp apparently doesn't work right on Windows, since
29468         WebKit.gyp and Tools.gyp refer to dependent projects by
29469         different relative paths (it appears gyp doesn't normalize the
29470         paths). This change moves Tools.gyp to be in the same directory
29471         as WebKit.gyp (and All.gyp), which should fix this and
29472         conveniently will also solve the problem of how to add Tools.gyp
29473         to the chromium DEPS file.
29474
29475         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
29476
29477 2011-12-09  Kentaro Hara  <haraken@chromium.org>
29478
29479         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
29480         https://bugs.webkit.org/show_bug.cgi?id=74173
29481
29482         Reviewed by Ryosuke Niwa.
29483
29484         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
29485         This requires to remove top-level code. This patch is one of the incremental refactorings
29486         for that.
29487
29488         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
29489         (fetchBugDescriptionFromURL):
29490
29491 2011-12-09  Tony Chang  <tony@chromium.org>
29492
29493         Switch the chromium mac bots to using skia test results
29494         https://bugs.webkit.org/show_bug.cgi?id=74201
29495
29496         Reviewed by Ryosuke Niwa.
29497
29498         This is reverting http://trac.webkit.org/changeset/97781 and changing
29499         the name in master.cfg to no longer have cg in the name.
29500
29501         * BuildSlaveSupport/build.webkit.org-config/config.json:
29502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
29503         (appendCustomBuildFlags):
29504         (RunWebKitTests.start):
29505
29506 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
29507
29508         [Qt] Remove a wrongly placed ASSERT.
29509
29510         Reviewed by Tor Arne Vestbø.
29511
29512         * MiniBrowser/qt/MiniBrowserApplication.cpp:
29513         (MiniBrowserApplication::notify):
29514
29515 2011-12-09  Cary Clark  <caryclark@google.com>
29516
29517         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
29518         https://bugs.webkit.org/show_bug.cgi?id=74118
29519
29520         Reviewed by Adam Barth.
29521
29522         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
29523         (get):
29524         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
29525         (ChromiumMacPort.__init__):
29526         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
29527         (ChromiumMacPortTest.test_versions):
29528         (ChromiumMacPortTest.test_graphics_type):
29529
29530 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
29531
29532         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
29533
29534         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
29535         this failed when moving files in the source tree, as the .d file would contain
29536         stale dependencies on the old source file location. By keeping the object files
29537         (and hence the depdendency files) in a proper tree structure inside the objects
29538         directory we can prevent this failure.
29539
29540         A side benefit is that we can also have objects with the same name inside the
29541         same project.
29542
29543         Reviewed by Simon Hausmann.
29544
29545         * qmake/mkspecs/features/unix/default_pre.prf:
29546
29547 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
29548
29549         Unreviewed. Update unit test after r102412.
29550
29551         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
29552         (IRCCommandTest.test_whois):
29553
29554 2011-12-09  Kentaro Hara  <haraken@chromium.org>
29555
29556         REGRESSION(r102105): run-bindings-tests should output full diff results
29557         https://bugs.webkit.org/show_bug.cgi?id=74166
29558
29559         Reviewed by Adam Barth.
29560
29561         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
29562         run-bindings-tests should output full diff results.
29563
29564         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
29565         (BindingsTests.generate_from_idl):
29566         (BindingsTests.generate_supplemental_dependency):
29567         (BindingsTests.detect_changes):
29568
29569 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
29570
29571         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
29572         https://bugs.webkit.org/show_bug.cgi?id=73990
29573
29574         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
29575
29576         Fix QtQuick includes after move from QtDeclarative to QtQuick.
29577
29578         * MiniBrowser/qt/BrowserWindow.h:
29579         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
29580
29581 2011-12-08  Adam Klein  <adamk@chromium.org>
29582
29583         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
29584         https://bugs.webkit.org/show_bug.cgi?id=73492
29585
29586         Reviewed by Adam Barth.
29587
29588         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
29589         keypress event without any script on the stack.
29590
29591         * DumpRenderTree/chromium/EventSender.cpp:
29592         (EventSender::EventSender):
29593         (EventSender::keyDown):
29594         (KeyDownTask::KeyDownTask):
29595         (KeyDownTask::runIfValid):
29596         (EventSender::scheduleAsynchronousKeyDown):
29597         * DumpRenderTree/chromium/EventSender.h:
29598
29599 2011-12-08  Hayato Ito  <hayato@chromium.org>
29600
29601         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
29602         https://bugs.webkit.org/show_bug.cgi?id=73980
29603
29604         Reviewed by Tony Chang.
29605
29606         * gdb/webkit.py:
29607         (guess_string_length):
29608         (ustring_to_string):
29609         (lstring_to_string):
29610         (LCharStringPrinter):
29611         (LCharStringPrinter.to_string):
29612         (WTFStringImplPrinter.get_length):
29613         (WTFStringImplPrinter.to_string):
29614         (WTFStringImplPrinter.is_8bit):
29615         (WTFStringPrinter.stringimpl_ptr):
29616         (WTFStringPrinter.get_length):
29617         (WTFStringPrinter.to_string):
29618         (add_pretty_printers.lookup_function):
29619
29620 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
29621
29622         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
29623         https://bugs.webkit.org/show_bug.cgi?id=73916
29624
29625         Reviewed by Kent Tamura.
29626
29627         * qmake/mkspecs/features/features.prf:
29628
29629 2011-12-08  Adrienne Walker  <enne@google.com>
29630
29631         Unreviewed contributor additions to committers.py.
29632
29633         * Scripts/webkitpy/common/config/committers.py:
29634
29635 2011-12-08  David Reveman  <reveman@chromium.org>
29636
29637         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
29638         https://bugs.webkit.org/show_bug.cgi?id=74017
29639
29640         Reviewed by James Robinson.
29641
29642         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
29643
29644         * DumpRenderTree/chromium/DumpRenderTree.cpp:
29645         (main):
29646         * DumpRenderTree/chromium/TestShell.cpp:
29647         (TestShell::TestShell):
29648         (TestShell::resetWebSettings):
29649         * DumpRenderTree/chromium/TestShell.h:
29650         (TestShell::setAcceleratedPaintingEnabled):
29651         (TestShell::setPerTilePaintingEnabled):
29652         * DumpRenderTree/chromium/WebPreferences.cpp:
29653         (WebPreferences::reset):
29654         (WebPreferences::applyTo):
29655         * DumpRenderTree/chromium/WebPreferences.h:
29656         * Scripts/webkitpy/layout_tests/port/chromium.py:
29657         (ChromiumDriver._wrapper_options):
29658         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
29659         (parse_args):
29660
29661 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
29662
29663         create a "SystemHost" object for webkitpy to slim down the Host object
29664         https://bugs.webkit.org/show_bug.cgi?id=72680
29665
29666         Reviewed by Eric Siedel.
29667
29668         This creates a SystemHost object that other objects that should
29669         only have dependencies on functionality in webkitpy.common.system
29670         can use; this will allow them to not require a full Host.
29671
29672         * Scripts/webkitpy/common/host.py:
29673         * Scripts/webkitpy/common/host_mock.py:
29674         * Scripts/webkitpy/common/system/systemhost.py: Added.
29675         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
29676
29677 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
29678
29679         AX: platform/mac/accessibility/search-with-frames.html crashes
29680         https://bugs.webkit.org/show_bug.cgi?id=74093
29681
29682         Reviewed by Darin Adler.
29683
29684         Take care of the case when an incoming element is null.
29685
29686         * DumpRenderTree/AccessibilityUIElement.cpp:
29687         (uiElementForSearchPredicateCallback):
29688         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
29689         (AccessibilityUIElement::uiElementForSearchPredicate):
29690         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
29691         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
29692
29693 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
29694
29695         [Qt] Visualize mock point ID's in the MiniBrowser
29696         https://bugs.webkit.org/show_bug.cgi?id=74098
29697
29698         Reviewed by Tor Arne Vestbø.
29699
29700         * MiniBrowser/qt/BrowserWindow.cpp:
29701         (BrowserWindow::updateVisualMockTouchPoints):
29702         * MiniBrowser/qt/qml/MockTouchPoint.qml:
29703
29704 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
29705
29706         Accessibility: AccessibilityController should support listening to notifications on all elements.
29707         https://bugs.webkit.org/show_bug.cgi?id=72866
29708
29709         Adds addNotificationListener and removeNotificationListener methods
29710         to AccessibilityController, to listen to notifications on any element
29711         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
29712         implementations are all contained in this change.
29713
29714         On Mac, refactors AccessibilityNotificationHandler into its own
29715         source file that can be used by both AccessibilityController and
29716         AccessibilityUIElement. (Both DRT and WKTR.)
29717
29718         Reviewed by Chris Fleizach.
29719
29720         * DumpRenderTree/AccessibilityController.cpp:
29721         (addNotificationListenerCallback):
29722         (removeNotificationListenerCallback):
29723         (AccessibilityController::getJSClass):
29724         * DumpRenderTree/AccessibilityController.h:
29725         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
29726         * DumpRenderTree/chromium/AccessibilityController.cpp:
29727         (AccessibilityController::AccessibilityController):
29728         (AccessibilityController::notificationReceived):
29729         (AccessibilityController::addNotificationListenerCallback):
29730         (AccessibilityController::removeNotificationListenerCallback):
29731         * DumpRenderTree/chromium/AccessibilityController.h:
29732         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
29733         (AccessibilityController::addNotificationListener):
29734         (AccessibilityController::removeNotificationListener):
29735         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
29736         (AccessibilityController::~AccessibilityController):
29737         (AccessibilityController::addNotificationListener):
29738         (AccessibilityController::removeNotificationListener):
29739         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
29740         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
29741         (-[NSString createJSStringRef]):
29742         (-[AccessibilityNotificationHandler init]):
29743         (-[AccessibilityNotificationHandler setPlatformElement:]):
29744         (-[AccessibilityNotificationHandler dealloc]):
29745         (-[AccessibilityNotificationHandler setCallback:]):
29746         (-[AccessibilityNotificationHandler startObserving]):
29747         (-[AccessibilityNotificationHandler _notificationReceived:]):
29748         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
29749         (AccessibilityUIElement::addNotificationListener):
29750         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
29751         (notificationListenerProc):
29752         (AccessibilityController::addNotificationListener):
29753         (AccessibilityController::removeNotificationListener):
29754         (AccessibilityController::winNotificationReceived):
29755         (AccessibilityController::winAddNotificationListener):
29756         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
29757         (AccessibilityUIElement::addNotificationListener):
29758         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
29759         (WTR::AccessibilityController::addNotificationListener):
29760         (WTR::AccessibilityController::removeNotificationListener):
29761         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
29762         (WTR::AccessibilityController::logAccessibilityEvents):
29763         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
29764         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
29765         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
29766         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
29767         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
29768         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
29769         (WTR::AccessibilityController::addNotificationListener):
29770         (WTR::AccessibilityController::removeNotificationListener):
29771         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
29772         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
29773         (-[NSString createJSStringRef]):
29774         (-[AccessibilityNotificationHandler init]):
29775         (-[AccessibilityNotificationHandler setPlatformElement:]):
29776         (-[AccessibilityNotificationHandler dealloc]):
29777         (-[AccessibilityNotificationHandler setCallback:]):
29778         (-[AccessibilityNotificationHandler startObserving]):
29779         (-[AccessibilityNotificationHandler _notificationReceived:]):
29780         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
29781         (WTR::AccessibilityUIElement::AccessibilityUIElement):
29782         (WTR::AccessibilityUIElement::verticalScrollbar):
29783         (WTR::AccessibilityUIElement::addNotificationListener):
29784         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
29785
29786 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
29787
29788         [Qt][WK2] Unreviewed buildfix after r102352.
29789
29790         * qmake/mkspecs/features/webkit2.prf:
29791
29792 2011-12-08  Adam Roben  <aroben@apple.com>
29793
29794         Make finding crash logs by PID work on Snow Leopard
29795
29796         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
29797         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
29798         read the first line of the crash log and pull the PID out of there.
29799
29800         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
29801         Snow Leopard
29802
29803         Reviewed by Darin Adler.
29804
29805         * Scripts/webkitpy/common/system/crashlogs.py:
29806         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
29807         name and PID for the log, rather than checking the Lion-only app_description extended
29808         attribute. We now also reject the log if the process name doesn't match what we expect.
29809
29810         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
29811         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
29812         PID.
29813         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
29814         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
29815         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
29816         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
29817         read, files that actually contain a crash log for some other process, and files that are
29818         misformatted.
29819
29820         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
29821         unused.
29822
29823         * Scripts/webkitpy/common/system/filesystem_mock.py:
29824         (MockFileSystem.__init__): Removed xattr support, which is now unused.
29825         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
29826         ReadableTextFileObject. This function was completely broken before!
29827         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
29828         bugs like the above.
29829         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
29830         things like readline() and seek().
29831
29832         (ReadableTextFileObject.close):
29833         (ReadableTextFileObject.read):
29834         Added. We override the superclass implementation to account for using a StringIO object.
29835
29836         (ReadableTextFileObject.readline):
29837         (ReadableTextFileObject.seek):
29838         Added. These just call through to StringIO.
29839
29840         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
29841         (MainTest.test_crash_log):
29842         (MainTest.test_web_process_crash_log):
29843         Changed to use make_mock_crash_report_darwin.
29844
29845 2011-12-06  Jon Lee  <jonlee@apple.com>
29846
29847         [WK2] Add permissions support (73960)
29848         https://bugs.webkit.org/show_bug.cgi?id=73960
29849         <rdar://problem/10357008>
29850
29851         Reviewed by Darin Adler.
29852
29853         Add null function item to comply with added callback to WKPageUIClient.
29854
29855         * MiniBrowser/mac/BrowserWindowController.m:
29856         (-[BrowserWindowController awakeFromNib]):
29857         * WebKitTestRunner/TestController.cpp:
29858         (WTR::TestController::createOtherPage):
29859         (WTR::TestController::initialize):
29860
29861 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
29862
29863         [Qt] Visualize mock points in the Qt MiniBrowser
29864         https://bugs.webkit.org/show_bug.cgi?id=74074
29865
29866         Reviewed by Tor Arne Vestbø.
29867
29868         * MiniBrowser/qt/BrowserWindow.cpp:
29869         (BrowserWindow::updateVisualMockTouchPoints):
29870         * MiniBrowser/qt/BrowserWindow.h:
29871         * MiniBrowser/qt/MiniBrowser.qrc:
29872         * MiniBrowser/qt/MiniBrowserApplication.cpp:
29873         (MiniBrowserApplication::notify):
29874         (MiniBrowserApplication::sendTouchEvent):
29875         * MiniBrowser/qt/MiniBrowserApplication.h:
29876         * MiniBrowser/qt/icons/touchpoint.png: Added.
29877         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
29878
29879 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
29880
29881         [Qt] WebKitTestRunner crashes with debug builds
29882         https://bugs.webkit.org/show_bug.cgi?id=74090
29883
29884         Reviewed by Tor Arne Vestbø.
29885
29886         * WebKitTestRunner/qt/TestControllerQt.cpp:
29887         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
29888         to ensure WTF/JSC threading is initialized.
29889
29890 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
29891
29892         fix build-webkit --chromium after breakage in r102201
29893         https://bugs.webkit.org/show_bug.cgi?id=74031
29894
29895         Reviewed by Tony Chang.
29896
29897         * Scripts/webkitdirs.pm:
29898         (buildChromium):
29899
29900 2011-12-08  Kentaro Hara  <haraken@chromium.org>
29901
29902         Unreviewed, rolling out r102280.
29903         http://trac.webkit.org/changeset/102280
29904         https://bugs.webkit.org/show_bug.cgi?id=74031
29905
29906         Chromium/Windows build is broken
29907
29908         * Scripts/webkitdirs.pm:
29909         (buildChromium):
29910
29911 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
29912
29913         Adding myself to committers list.
29914
29915         Unreviewed.
29916
29917         * Scripts/webkitpy/common/config/committers.py:
29918
29919 2011-12-07  Michael Saboff  <msaboff@apple.com>
29920
29921         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
29922         https://bugs.webkit.org/show_bug.cgi?id=73995
29923
29924         Reenabled failing tests that the code part of the patch fixes.
29925
29926         Reviewed by Geoffrey Garen.
29927
29928         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
29929         (TestWebKitAPI::TEST):
29930
29931 2011-12-07  MORITA Hajime  <morrita@google.com>
29932
29933         [filter-build-webkit] should not emit reset color when --no-color is given
29934         https://bugs.webkit.org/show_bug.cgi?id=73992
29935
29936         Reviewed by Daniel Bates.
29937
29938         Stop printing control sequences when --no-color is given.
29939         After this change, the filter runs nicely even on environments
29940         like Emacs compilation-mode which cannot understand the control sequence.
29941
29942         * Scripts/filter-build-webkit:
29943         (printLine):
29944
29945 2011-12-07  Eric Seidel  <eric@webkit.org>
29946
29947         Use free memory to determine if we have space for DRT instances instead of total memory
29948         https://bugs.webkit.org/show_bug.cgi?id=74021
29949
29950         Reviewed by Adam Barth.
29951
29952         This will hopefully make the Mac buildbots behave better.
29953
29954         I also reduced the expected memory needed per DRT now that
29955         we're properly accounting for the system memory in our calculations.
29956
29957         * Scripts/webkitpy/common/system/platforminfo.py:
29958         (PlatformInfo.total_bytes_memory):
29959         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
29960         * Scripts/webkitpy/common/system/platforminfo_mock.py:
29961         (MockPlatformInfo.total_bytes_memory):
29962         * Scripts/webkitpy/layout_tests/port/base.py:
29963         (Port.default_child_processes):
29964         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
29965         (PortTest.test_default_child_processes):
29966
29967 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
29968
29969         fix build-webkit --chromium after breakage in r102201
29970         https://bugs.webkit.org/show_bug.cgi?id=74031
29971
29972         Reviewed by Tony Chang.
29973
29974         r102201 introduced a change to the chromium build that splits
29975         the executables out of WebKit.gyp into other gyp files, and adds
29976         a new "All.gyp" that builds everything. However, I forgot to
29977         update the build script to use All.gyp.
29978
29979         * Scripts/webkitdirs.pm:
29980         (buildChromium):
29981
29982 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
29983
29984         Moved myself to the committers list.
29985
29986         * Scripts/webkitpy/common/config/committers.py:
29987
29988 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
29989
29990         [Qt] Fix debug shlib build with V8.
29991
29992         Reviewed by Tor Arne Vestbø.
29993
29994         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
29995         v8 builds.
29996
29997 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
29998
29999         [Qt] V8 build fixes.
30000
30001         Reviewed by Tor Arne Vestbø.
30002
30003         * qmake/mkspecs/features/javascriptcore.prf: Don't add
30004         Source/Thirdparty to the include search path here.
30005         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
30006         used when building WebCore as well as using it, because header files like
30007         GraphicsContext3D.h include stuff from ThirdParty.
30008
30009 2011-12-07  Peter Beverloo  <peter@chromium.org>
30010
30011         [Chromium] Fix project file generation for the Android bot after r102201
30012         https://bugs.webkit.org/show_bug.cgi?id=73996
30013
30014         The gyp refactoring in r102201 was didn't explicitly exclude
30015         the Android operating system in Tools/Tools.gyp, which broke
30016         as gcc_version is not defined for that configuration.
30017
30018         Reviewed by Andreas Kling.
30019
30020         * Tools.gyp:
30021
30022 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
30023
30024         Unreviewed. Disabled failing tests on chromium.
30025
30026         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
30027         (TestWebKitAPI::TEST):
30028
30029 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
30030
30031         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
30032         https://bugs.webkit.org/show_bug.cgi?id=73382
30033
30034         Reviewed by Tony Chang.
30035
30036         XCode (and hence GYP) can't handle circular dependencies between
30037         files (and projects). Accordingly, although the binaries in
30038         WebKit.gyp depend on webkit_support and webkit_support depends
30039         on webkit, we don't mention the latter dependency in the file.
30040         To fix this, this change moves the binaries like DRT into a new
30041         GYP file, and modifies gyp_webkit to build from that file
30042         instead of WebKit.gyp.
30043
30044         * Tools.gyp: Added.
30045
30046 2011-12-06  Adam Roben  <aroben@apple.com>
30047
30048         Add a pid parameter to CrashLogs.find_newest_log
30049
30050         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
30051         considered.
30052
30053         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
30054         process whose crash log you want to find
30055
30056         Reviewed by Dirk Pranke.
30057
30058         * Scripts/webkitpy/common/system/crashlogs.py:
30059         (CrashLogs.find_newest_log): Added an optional pid parameter.
30060         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
30061         candidate log's app_description extended attribute to see if that log corresponds to a
30062         crashed process with the specified PID.
30063
30064         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
30065         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
30066         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
30067         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
30068
30069         * Scripts/webkitpy/common/system/filesystem.py:
30070         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
30071         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
30072         present.
30073
30074         * Scripts/webkitpy/common/system/filesystem_mock.py:
30075         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
30076         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
30077         dictionary.
30078
30079         * Scripts/webkitpy/tool/commands/queries.py:
30080         (CrashLog): Added help text. Added an optional PID parameter.
30081         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
30082
30083 2011-12-06  Adam Roben  <aroben@apple.com>
30084
30085         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
30086
30087         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
30088         alive beyond the normal timeout limit. In cases where the crashed process was able to die
30089         faster, NRWT would assume that Crash Reporter had finished even though it often was still
30090         running, which would lead to an incorrect crash log being picked up.
30091
30092         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
30093
30094         Reviewed by Dirk Pranke.
30095
30096         * Scripts/webkitpy/layout_tests/port/server_process.py:
30097         (ServerProcess._reset):
30098         (ServerProcess.write):
30099         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
30100         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
30101         set_crashed.
30102
30103         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
30104         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
30105         we bail out of handling the failure as a timeout if we find out that the process in fact
30106         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
30107         so.
30108         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
30109         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
30110         disk.
30111
30112         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
30113         (TrivialMockPort.is_crash_reporter): Added.
30114
30115         * Scripts/webkitpy/layout_tests/port/webkit.py:
30116         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
30117         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
30118
30119 2011-12-06  Adam Barth  <abarth@webkit.org>
30120
30121         NRWT fails on unreleased versions of Mac OS X
30122         https://bugs.webkit.org/show_bug.cgi?id=72748
30123
30124         Reviewed by Dirk Pranke.
30125
30126         Hopefully this patch will make NRWT work on future versions on Mac OS X.
30127         Most of the infrastructure was already in place, but there were some
30128         asserts that failed.  I've tested this patch by haxoring the version
30129         detection logic to simulate an unknown version.  We might need to
30130         iterate based on feedback from folks with a real future version.
30131
30132         * Scripts/webkitpy/layout_tests/port/apple.py:
30133         (ApplePort.__init__):
30134             - mac-future is an allowed port_name that's used internally by
30135               webkitpy to represent future versions of Mac OS X.
30136         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
30137         (test_versions):
30138             - Test that we don't throw exceptions when dealing with future
30139               versions of Mac OS X.
30140         * Scripts/webkitpy/layout_tests/port/webkit.py:
30141         (WebKitPort._expectations_from_skipped_files):
30142             - Demote this logging message to "debug".  It's expected that
30143               mac-future doesn't have a Skipped file.
30144         * Scripts/webkitpy/layout_tests/port/mac.py:
30145         (MacPort.__init__):
30146         * Scripts/webkitpy/layout_tests/port/win.py:
30147         (WinPort.__init__):
30148             - Re-order some code in these constructors so that
30149               self._operating_system is available to the ApplePort constructor.
30150
30151 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
30152
30153         Added myself as a committer.
30154
30155         * Scripts/webkitpy/common/config/committers.py:
30156
30157 2011-12-06  Peter Beverloo  <peter@chromium.org>
30158
30159         Added myself as a committer.
30160
30161         * Scripts/webkitpy/common/config/committers.py:
30162
30163 2011-12-06  Kentaro Hara  <haraken@chromium.org>
30164
30165         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
30166         https://bugs.webkit.org/show_bug.cgi?id=73637
30167
30168         Reviewed by Adam Barth.
30169
30170         This patch replaces subprocess.Popen() with Executive, similar to other
30171         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
30172         works well for cases where no exception is raised, no exception is raised
30173         but diff is found, and ScriptError is raised.
30174
30175         * Scripts/run-bindings-tests:
30176         (main):
30177         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
30178         (BindingsTests.__init__):
30179         (BindingsTests.generate_from_idl):
30180         (BindingsTests.generate_supplemental_dependency):
30181         (BindingsTests.detect_changes):
30182
30183 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
30184
30185         [Qt] MiniBrowser should default to touch behavior
30186         https://bugs.webkit.org/show_bug.cgi?id=73863
30187
30188         Reviewed by Chang Shu.
30189
30190         MiniBrowser currently defaults to the traditional desktop behaviour
30191         instead of touch behaviour which is prefered.
30192
30193         * MiniBrowser/qt/BrowserWindow.cpp:
30194         (BrowserWindow::BrowserWindow):
30195         * MiniBrowser/qt/MiniBrowserApplication.cpp:
30196         (printHelp):
30197         (MiniBrowserApplication::handleUserOptions):
30198         * MiniBrowser/qt/MiniBrowserApplication.h:
30199         (WindowOptions::WindowOptions):
30200         (WindowOptions::setUseTraditionalDesktopBehavior):
30201         (WindowOptions::useTraditionalDesktopBehavior):
30202
30203 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
30204
30205         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
30206         https://bugs.webkit.org/show_bug.cgi?id=73878
30207
30208         Reviewed by Tony Chang.
30209
30210         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
30211         r98785 made webkit.py always use m_data16, which does not work when
30212         the string is an 8-bit string (such as KURL::string()).
30213
30214         I was not able to directly call StringImpl::is8Bit() in the Python
30215         code, so I just reproduced the implementation there.
30216
30217         * gdb/webkit.py:
30218         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
30219         (WTFStringPrinter.to_string):
30220         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
30221         (JSCUStringPrinter.to_string):
30222
30223 2011-12-05  Eric Seidel  <eric@webkit.org>
30224
30225         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
30226         in hopes of making the Snow Leopard bot stop timing out.
30227
30228         Unreviewed.
30229
30230         * Scripts/webkitpy/layout_tests/port/base.py:
30231         (Port.default_child_processes):
30232         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
30233         (PortTest.test_default_child_processes):
30234
30235 2011-12-05  Eric Seidel  <eric@webkit.org>
30236
30237         NRWT creates too many workers on RAM-limited machines
30238         https://bugs.webkit.org/show_bug.cgi?id=73847
30239
30240         Reviewed by Dirk Pranke.
30241
30242         Make NRWT restrict its number of workers when there isn't enough
30243         RAM to support them.
30244         Also re-enable parallel testing on the Mac bots which were
30245         failing due to not enough ram.
30246
30247         * Scripts/run-webkit-tests:
30248         (platformIsReadyForParallelTesting):
30249         * Scripts/webkitpy/common/host.py:
30250         (Host.__init__):
30251         * Scripts/webkitpy/common/system/executive_mock.py:
30252         (MockExecutive.cpu_count):
30253         * Scripts/webkitpy/common/system/platforminfo.py:
30254         (PlatformInfo.__init__):
30255         (PlatformInfo.display_name):
30256         * Scripts/webkitpy/common/system/platforminfo_mock.py:
30257         (MockPlatformInfo.display_name):
30258         * Scripts/webkitpy/layout_tests/port/base.py:
30259         (Port.default_child_processes):
30260         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
30261         (PortTest.test_default_child_processes):
30262         (PortTest.test_pretty_patch_os_error):
30263
30264 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
30265
30266         Last mouse event could be lost if a JS call to eventSender.leapForward is made
30267         https://bugs.webkit.org/show_bug.cgi?id=73366
30268
30269         Reviewed by Kenneth Rohde Christiansen.
30270
30271         Empty the entire event queue when requested besides using
30272         sendEvent instead of postEvent to make sure all events were
30273         delivered.
30274
30275         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
30276         (WTR::EventSenderProxy::EventSenderProxy):
30277         (WTR::EventSenderProxy::sendOrQueueEvent):
30278         (WTR::EventSenderProxy::replaySavedEvents):
30279
30280 2011-12-05  Adam Barth  <abarth@webkit.org>
30281
30282         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
30283         https://bugs.webkit.org/show_bug.cgi?id=73845
30284
30285         Reviewed by Darin Fisher.
30286
30287         Update includes to point to the new header locations.
30288
30289         * DumpRenderTree/chromium/AccessibilityController.cpp:
30290         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
30291         * DumpRenderTree/chromium/CppBoundClass.cpp:
30292         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
30293         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
30294         * DumpRenderTree/chromium/DRTDevToolsClient.h:
30295         * DumpRenderTree/chromium/EventSender.cpp:
30296         * DumpRenderTree/chromium/EventSender.h:
30297         * DumpRenderTree/chromium/GamepadController.h:
30298         * DumpRenderTree/chromium/LayoutTestController.cpp:
30299         * DumpRenderTree/chromium/LayoutTestController.h:
30300         * DumpRenderTree/chromium/MockSpellCheck.cpp:
30301         * DumpRenderTree/chromium/NotificationPresenter.cpp:
30302         * DumpRenderTree/chromium/PlainTextController.cpp:
30303         * DumpRenderTree/chromium/Task.cpp:
30304         * DumpRenderTree/chromium/TestNavigationController.h:
30305         * DumpRenderTree/chromium/TestShell.cpp:
30306         * DumpRenderTree/chromium/TestWebPlugin.cpp:
30307         * DumpRenderTree/chromium/TestWebPlugin.h:
30308         * DumpRenderTree/chromium/TextInputController.cpp:
30309         * DumpRenderTree/chromium/WebPermissions.cpp:
30310         * DumpRenderTree/chromium/WebPreferences.h:
30311         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
30312         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
30313         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
30314         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
30315         * DumpRenderTree/chromium/WebViewHost.cpp:
30316
30317 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
30318
30319         Add Aharon Lanin to the contributors list.
30320
30321         * Scripts/webkitpy/common/config/committers.py:
30322
30323 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
30324
30325         Moving myself from contributors to committers.
30326
30327         * Scripts/webkitpy/common/config/committers.py:
30328
30329 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
30330
30331         Add myself as a committer.
30332
30333         * Scripts/webkitpy/common/config/committers.py:
30334
30335 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
30336
30337         [Qt] Rename QQuickWebView::canStop property to just loading
30338         https://bugs.webkit.org/show_bug.cgi?id=73813
30339
30340         Reviewed by Kenneth Rohde Christiansen.
30341
30342         Replaced references to WebView.canStop with WebView.loading.
30343
30344         * MiniBrowser/qt/qml/BrowserWindow.qml:
30345
30346 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
30347
30348         run-webkit-tests: limit --child-processes properly on apple mac
30349         https://bugs.webkit.org/show_bug.cgi?id=73856
30350
30351         Reviewed by Adam Roben.
30352
30353         Fix typos in r102013 so that we correctly pass --child-processes=1 on
30354         the apple mac bots temporarily.
30355
30356         * Scripts/run-webkit-tests:
30357         (platformIsReadyForParallelTesting):
30358
30359 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
30360
30361         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
30362         https://bugs.webkit.org/show_bug.cgi?id=73840
30363
30364         Reviewed by Simon Fraser.
30365
30366         Temporarily go back to single process mode on Mac.
30367
30368         * Scripts/run-webkit-tests:
30369         (platformIsReadyForParallelTesting):
30370
30371 2011-12-05  Adam Roben  <aroben@apple.com>
30372
30373         Redeploy apple-macpro-7 and apple-xserve-1
30374
30375         These slaves have been sitting idle since we removed our Leopard builders in r97496.
30376
30377         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
30378         sitting idle
30379
30380         Reviewed by Sam Weinig.
30381
30382         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
30383         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
30384         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
30385         (WebKit2 Tests)".
30386
30387 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
30388
30389         [Qt] Make the UI of the MiniBrowser slightly nicer
30390
30391         Rubberstamped by Simon Hausmann.
30392
30393         - Add proper padding
30394         - Show feedback when pressing on the toolbar icons
30395         - Make the text entry better looking
30396
30397         * MiniBrowser/qt/qml/BrowserWindow.qml:
30398
30399 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
30400
30401         NRWT should handle duplicated expectations
30402         https://bugs.webkit.org/show_bug.cgi?id=69750
30403
30404         Reviewed by Dirk Pranke.
30405
30406         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
30407         (TestExpectations.__init__):
30408         (TestExpectations._report_errors):
30409         (TestExpectations._add_expectations):
30410         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
30411         (test_add_skipped_tests):
30412         * Scripts/webkitpy/layout_tests/port/base.py:
30413         (Port.skipped_tests):
30414         * Scripts/webkitpy/layout_tests/port/webkit.py:
30415         (WebKitPort.test_expectations):
30416         (WebKitPort.skipped_tests):
30417         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
30418         (test_test_expectations):
30419
30420 2011-12-04  Eric Seidel  <eric@webkit.org>
30421
30422         After success with Mac, Win and Gtk, turning on parallel testing
30423         by default for all platforms (except Qt).
30424
30425         We'll add more platforms to the blacklist if we see problems.
30426
30427         Unreviewed.
30428
30429         * Scripts/run-webkit-tests:
30430         (platformIsReadyForParallelTesting):
30431
30432 2011-12-04  Sam Weinig  <sam@webkit.org>
30433
30434         Add tests for RetainPtr::adoptNS/adoptCF
30435         https://bugs.webkit.org/show_bug.cgi?id=73470
30436
30437         Reviewed by Adam Roben and Darin Adler.
30438
30439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30440         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
30441         (TestWebKitAPI::TEST):
30442         Test that adopting using adoptCF creates a RetainPtr with a
30443         value whose retain count is 1.
30444
30445         * TestWebKitAPI/Tests/WTF/ns: Added.
30446         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
30447         (TestWebKitAPI::TEST):
30448         Test that adopting using adoptNS creates a RetainPtr with a
30449         value whose retain count is 1.
30450
30451 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
30452
30453         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
30454         https://bugs.webkit.org/show_bug.cgi?id=73748
30455
30456         Reviewed by Gustavo Noronha Silva.
30457
30458         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
30459
30460 2011-12-04  Philippe Normand  <pnormand@igalia.com>
30461
30462         Another GTK build fix after r101922.
30463
30464         Rubber-stamped by Martin Robinson.
30465
30466         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30467         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
30468
30469 2011-12-04  Xan Lopez  <xlopez@igalia.com>
30470
30471         Fix compiler warning in LayoutTestController
30472
30473         Reviewed by Philippe Normand.
30474
30475         * DumpRenderTree/LayoutTestController.cpp:
30476         (LayoutTestController::LayoutTestController): fix warning.
30477
30478 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
30479
30480         Add missing methods used by fast/notifications tests to LayoutTestController
30481         https://bugs.webkit.org/show_bug.cgi?id=63616
30482
30483         Reviewed by Martin Robinson.
30484
30485         Add missing simulateDesktopNotificationClick method used by
30486         fast/notifications. Provide a default implementation for
30487         areDesktopNotificationPermissionRequestsIgnored and
30488         ignoreDesktopNotificationPermissionRequests.
30489
30490         * DumpRenderTree/LayoutTestController.cpp:
30491         (LayoutTestController::LayoutTestController): call into the port implementation.
30492         (simulateDesktopNotificationClickCallback): ditto.
30493         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
30494         (LayoutTestController::staticFunctions): declare new methods.
30495         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
30496         * DumpRenderTree/LayoutTestController.h:
30497         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
30498         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
30499         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
30500         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30501         (LayoutTestController::simulateDesktopNotificationClick): ditto.
30502         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
30503         (LayoutTestController::simulateDesktopNotificationClick): ditto.
30504         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
30505         (LayoutTestController::simulateDesktopNotificationClick): ditto.
30506         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
30507         (LayoutTestController::simulateDesktopNotificationClick): ditto.
30508
30509 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
30510
30511         [GTK] Don't log document events in DRT
30512         https://bugs.webkit.org/show_bug.cgi?id=73746
30513
30514         Reviewed by Martin Robinson.
30515
30516         Stop connecting globally to document-related events.
30517
30518         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
30519         (connectAccessibilityCallbacks): Removed connections.
30520         (disconnectAccessibilityCallbacks): Removed disconnections.
30521
30522 2011-12-03  Dan Bernstein  <mitz@apple.com>
30523
30524         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
30525
30526         Reviewed by Darin Adler.
30527
30528         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30529         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
30530         (TestWebKitAPI::TEST):
30531
30532 2011-12-03  Philippe Normand  <pnormand@igalia.com>
30533
30534         Another GTK build fix after r101922.
30535
30536         Rubber-stamped by Martin James Robinson.
30537
30538         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30539         (LayoutTestController::pathToLocalResource): return value needs to
30540         be a URI.
30541
30542 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
30543
30544         Small fix for my previous patch. Do not try to delete a member
30545         of a dictionary that does not exist.
30546
30547         Reviewed by Gustavo Noronha Silva.
30548
30549         * gtk/run-with-jhbuild:
30550         (install_and_run_jhbuild):
30551
30552 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
30553
30554         Fix jhbuild installation for people who have unusual MAKE environment
30555         variables such as 'make -j4' as the jhbuild build does not handle it.
30556
30557         Reviewed by Gustavo Noronha Silva.
30558
30559         * gtk/run-with-jhbuild:
30560         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
30561
30562 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
30563
30564         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
30565         when run for the first time.
30566
30567         Reviewed by Gustavo Noronha Silva.
30568
30569         * Scripts/update-webkitgtk-libs: Fix first run.
30570
30571 2011-12-03  Philippe Normand  <pnormand@igalia.com>
30572
30573         Unreviewed, GTK build fix after r101922.
30574
30575         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30576         (LayoutTestController::pathToLocalResource): Added sentinel in
30577         g_build_filename call.
30578
30579 2011-12-03  Philippe Normand  <pnormand@igalia.com>
30580
30581         GTK API tests build fix. Run the tests inside jhbuild.
30582
30583         Rubber-stamped by Gustavo Noronha Silva.
30584
30585         * Scripts/run-gtk-tests:
30586         (TestRunner.__init__):
30587         (TestRunner.run._error_handler):
30588         (TestRunner):
30589         (TestRunner.run):
30590
30591 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
30592
30593         Small build fix. Properly specify the path to the locally installed jhbuild.
30594
30595         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
30596
30597 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
30598
30599         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
30600         https://bugs.webkit.org/show_bug.cgi?id=67256
30601
30602         Reviewed by Philippe Normand.
30603
30604         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
30605         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
30606         which points to the more generic top-level path of the WebKit checkout. This code is
30607         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
30608         share code here.
30609
30610         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
30611         location. This will cause the fallback to fail if you build into a non-typical location
30612         or even fake it with a symlink. In this case it's important to use the environment variable.
30613
30614         * DumpRenderTree/gtk/DumpRenderTree.cpp:
30615         (getTopLevelPath): Added.
30616         (initializeFonts): Use the new helper to get the font path.
30617         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
30618         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
30619         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
30620         test paths.
30621         * Scripts/webkitpy/layout_tests/port/gtk.py:
30622         (GtkPort.setup_environ_for_server):Pass the top-level path of the
30623         checkout instead of passing the font path.
30624         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
30625         (WTR::getTopLevelPath): Added this helper.
30626         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
30627
30628 2011-12-02  David Levin  <levin@chromium.org>
30629
30630         Rename WTF class from TemporarilyChange to TemporaryChange.
30631         https://bugs.webkit.org/show_bug.cgi?id=73479
30632
30633         Reviewed by Eric Seidel.
30634
30635         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
30636         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
30637         * TestWebKitAPI/TestWebKitAPI.gypi:
30638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
30639         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
30640         (TestWebKitAPI::TEST):
30641         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
30642
30643 2011-12-02  Tony Chang  <tony@chromium.org>
30644
30645         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
30646         https://bugs.webkit.org/show_bug.cgi?id=73453
30647
30648         Reviewed by Ryosuke Niwa.
30649
30650         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
30651         The verbose output will include the failure reason.
30652
30653         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
30654         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
30655         (write_test_result):
30656         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
30657         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
30658         (determine_result_type):
30659         (FailureReftestNoImagesGenerated.__init__):
30660         (FailureReftestNoImagesGenerated):
30661         (FailureReftestNoImagesGenerated.message):
30662         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
30663         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
30664         (MainTest.test_run_singly_actually_runs_tests):
30665         (MainTest.test_unexpected_failures):
30666         (EndToEndTest.test_end_to_end):
30667
30668 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
30669
30670         ChangeLog should be able to parse annotated changelogs
30671         https://bugs.webkit.org/show_bug.cgi?id=72703
30672
30673         Reviewed by Eric Seidel.
30674
30675         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
30676         and extract the revision number for each entry.
30677
30678         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
30679
30680         * Scripts/webkitpy/common/checkout/changelog.py:
30681         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
30682         * Scripts/webkitpy/common/checkout/scm/git.py:
30683         * Scripts/webkitpy/common/checkout/scm/scm.py:
30684         * Scripts/webkitpy/common/checkout/scm/svn.py:
30685
30686 2011-12-02  Eric Seidel  <eric@webkit.org>
30687
30688         Enable parallel testing for Win and Gtk bots
30689         after confirming with Lucas and Martin the bots should be OK.
30690
30691         Unreviewed. (I ran the idea by Lucas and Martin.)
30692
30693         * Scripts/run-webkit-tests:
30694         (platformIsReadyForParallelTesting):
30695
30696 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
30697
30698         Try to fix the GTK+ build.
30699
30700         * gtk/jhbuild.modules: Properly specify the glib-networking
30701         dependency for soup.
30702
30703 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
30704
30705         Fix a syntax error in the committers.py file.
30706
30707         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
30708
30709 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
30710
30711         Add Alan Stearns and Peter Linss to the contributors list.
30712
30713         * Scripts/webkitpy/common/config/committers.py:
30714
30715 2011-12-02  Kent Tamura  <tkent@chromium.org>
30716
30717         [Chromium] Fix compilation warnings for ASSERT()
30718         https://bugs.webkit.org/show_bug.cgi?id=73623
30719
30720         Reviewed by Tony Chang.
30721
30722         * DumpRenderTree/chromium/ImageDiff.cpp:
30723          - Fix fprintf format: %s -> %d for __LINE__
30724          - Do nothing for ASSERT() if NDEBUG.
30725
30726 2011-12-02  Eric Seidel  <eric@webkit.org>
30727
30728         Enable parallel testing for all Mac bots.
30729
30730         Unreviewed.
30731
30732         * Scripts/run-webkit-tests:
30733         (platformIsReadyForParallelTesting):
30734
30735 2011-12-02  Eric Seidel  <eric@webkit.org>
30736
30737         Enable parallel testing for run-webkit-tests on Mac Lion.
30738         I plan to move all the machines to parallel testing shortly
30739         but we're starting with Lion.
30740
30741         Unreviewed.
30742
30743         * Scripts/run-webkit-tests:
30744         (platformIsReadyForParallelTesting):
30745
30746 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
30747
30748         Added helper method to identify whether the page has custom page size style.
30749         https://bugs.webkit.org/show_bug.cgi?id=73585
30750
30751         Reviewed by Darin Fisher.
30752
30753         * DumpRenderTree/chromium/LayoutTestController.cpp:
30754         (LayoutTestController::LayoutTestController):
30755         (LayoutTestController::hasCustomPageSizeStyle):
30756         * DumpRenderTree/chromium/LayoutTestController.h:
30757
30758 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
30759
30760         [NRWT] reftest should support having multiple references per test
30761         https://bugs.webkit.org/show_bug.cgi?id=73613
30762
30763         Reviewed by Dirk Pranke.
30764
30765         Add a support for having multiple reference files for a single test.
30766
30767         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
30768         at least one of expected mismatches, we compare expected mismatches first in order to minimize
30769         the number of reference files to open on DRT.
30770
30771         * Scripts/webkitpy/layout_tests/controllers/manager.py:
30772         (interpret_test_failures): Remove checks no longer applicable.
30773         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
30774         (ResultSummaryTest.test_interpret_test_failures): Ditto.
30775         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
30776         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
30777         (SingleTestRunner._driver_input):
30778         (SingleTestRunner.run):
30779         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
30780         * Scripts/webkitpy/layout_tests/models/test_input.py:
30781         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
30782         * Scripts/webkitpy/layout_tests/port/base.py:
30783         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
30784         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
30785         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
30786         (PortTest.test_parse_reftest_list):
30787         * Scripts/webkitpy/layout_tests/port/test.py:
30788         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
30789         (MainTest.test_unexpected_failures):
30790         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
30791         (EndToEndTest.test_end_to_end):
30792         (EndToEndTest.test_reftest_with_two_notrefs): Added.
30793
30794 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
30795
30796         Build libsoup without gnome dependencies (like keyring).
30797
30798         * gtk/jhbuild.modules:
30799
30800 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
30801
30802         Also build gcrypt and p11-kit, and make them dependencies of
30803         gnutls.
30804
30805         * gtk/jhbuild.modules:
30806
30807 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
30808
30809         [wx] Unreviewed build fixes for Windows build.
30810
30811         * waf/build/wxpresets.py:
30812
30813 2011-12-01  Eric Seidel  <eric@webkit.org>
30814
30815         Reviewed by Adam Barth.
30816
30817         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
30818         https://bugs.webkit.org/show_bug.cgi?id=32006
30819
30820         I decided not to make it warn, and just have it re-open the bug.
30821         That's not that different from today's behavior which will
30822         just silently attach the patch.
30823
30824         This patch makes behavior between upload and land-safely consistent
30825         (previously one would assign patches and the other would not)
30826         as well as adds the ability for both to ensure that the bug is open.
30827
30828         To test this I had to add a few more methods to MockBugzilla which
30829         (positively) affected a few other test results.
30830
30831         I also made AbstractStep keep a cached copy of the Bug object
30832         and used the cached copy where appropriate (including for 'bug_title').
30833         This should reduce the number of bug fetches we perform.
30834
30835         * Scripts/webkitpy/tool/commands/download_unittest.py:
30836         * Scripts/webkitpy/tool/commands/upload.py:
30837         * Scripts/webkitpy/tool/commands/upload_unittest.py:
30838         * Scripts/webkitpy/tool/mocktool.py:
30839         * Scripts/webkitpy/tool/steps/__init__.py:
30840         * Scripts/webkitpy/tool/steps/abstractstep.py:
30841         * Scripts/webkitpy/tool/steps/closebug.py:
30842         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
30843         * Scripts/webkitpy/tool/steps/postdiff.py:
30844         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
30845         * Scripts/webkitpy/tool/steps/preparechangelog.py:
30846         * Scripts/webkitpy/tool/steps/steps_unittest.py:
30847         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
30848
30849 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
30850
30851         Also pass --no-interact to jhbuild when updating dependencies.
30852
30853         * Scripts/update-webkitgtk-libs:
30854
30855 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
30856
30857         Make _build_path check more thoroughly that build paths exist.
30858         https://bugs.webkit.org/show_bug.cgi?id=73601
30859
30860         Reviewed by Ojan Vafai.
30861
30862         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
30863         (ChromiumMacPort._build_path):
30864
30865 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
30866
30867         Add libffi to the jhbuild modules list as a glib dependency.
30868
30869         Rubber-stamped by Martin Robinson.
30870
30871         * gtk/jhbuild.modules:
30872
30873 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
30874
30875         Build fix. Use internal pcre on glib, make gnutls a dependency of
30876         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
30877         in non-interactive mode.
30878
30879         * Scripts/update-webkitgtk-libs:
30880         * gtk/jhbuild.modules:
30881         * gtk/run-with-jhbuild:
30882
30883 2011-12-02  Adam Roben  <aroben@apple.com>
30884
30885         Fix for Python 2.6
30886
30887         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
30888         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
30889         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
30890         searching for "Tests that timed out:" etc. This makes our check less strict, but it
30891         shouldn't matter given the kinds of content we parse.
30892
30893 2011-12-02  Adam Roben  <aroben@apple.com>
30894
30895         Fix names of failed/timed out tests in run-api-tests output
30896
30897         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
30898         out tests
30899
30900         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
30901
30902         Reviewed by Simon Fraser.
30903
30904         * Scripts/run-api-tests:
30905         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
30906         of this function.
30907
30908 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
30909
30910         [GTK] generate-gtkdoc should respect build type
30911         https://bugs.webkit.org/show_bug.cgi?id=73296
30912
30913         Reviewed by Philippe Normand.
30914
30915         * Scripts/webkitdirs.pm:
30916         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
30917         * gtk/common.py: If --build is passed give preference to the Debug build directory.
30918
30919 2011-12-02  Tony Chang  <tony@chromium.org>
30920
30921         [nrwt] fix wdiff output
30922         https://bugs.webkit.org/show_bug.cgi?id=73604
30923
30924         Reviewed by Adam Barth.
30925
30926         * Scripts/webkitpy/layout_tests/port/base.py:
30927         (Port.wdiff_text):
30928         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
30929         (PortTest.test_wdiff_text):
30930
30931 2011-12-02  Adam Roben  <aroben@apple.com>
30932
30933         Teach build.webkit.org to display how many unit tests failed or timed out
30934
30935         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
30936         build.webkit.org
30937
30938         We now display something like "5 unit tests failed or timed out". Eventually we might want
30939         to split out how many failure vs. timeouts there were.
30940
30941         Reviewed by Darin Adler.
30942
30943         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
30944         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
30945         classes that may want to subclass it.
30946         (RunUnitTests): Changed to inherit from TestWithFailureCount.
30947         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
30948         timed out:" and "Tests that failed:" lines, if present.
30949
30950         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
30951         (StubStdio):
30952         (StubRemoteCommand):
30953         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
30954
30955         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
30956         the test run correctly.
30957
30958         (RunUnitTestsTest.test_no_failures_or_timeouts):
30959         (RunUnitTestsTest.test_one_failure):
30960         (RunUnitTestsTest.test_multiple_failures):
30961         (RunUnitTestsTest.test_one_timeout):
30962         (RunUnitTestsTest.test_multiple_timeouts):
30963         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
30964         Test various cases.
30965
30966 2011-12-02  Adam Roben  <aroben@apple.com>
30967
30968         Teach prepare-ChangeLog to treat master.cfg as a Python file
30969
30970         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
30971         in buildbot's master.cfg
30972
30973         Reviewed by Darin Adler.
30974
30975         * Scripts/prepare-ChangeLog:
30976         (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
30977         master.cfg.
30978
30979 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
30980
30981         [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
30982         https://bugs.webkit.org/show_bug.cgi?id=73669
30983
30984         Reviewed by Gustavo Noronha Silva.
30985
30986         Add a wrapper script that knows how to install jhbuild and also to wrap commands
30987         in the jhbuild shell.
30988
30989         * Scripts/webkitdirs.pm:
30990         (runAutogenForAutotoolsProject): Use the new wrapper script.
30991         (mustReRunAutogen): Ditto.
30992         (buildAutotoolsProject): Ditto.
30993         * Scripts/webkitpy/layout_tests/port/gtk.py:
30994         (GtkDriver.cmd_line): Ditto.
30995         * gtk/run-with-jhbuild: Added.
30996
30997 2011-12-01  Adam Roben  <aroben@apple.com>
30998
30999         Teach check-webkit-style how to check the syntax of JSON files
31000
31001         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
31002
31003         I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
31004         patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
31005         2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
31006         been removed, since its output differs by platform.
31007
31008         Reviewed by Darin Adler.
31009
31010         * Scripts/webkitpy/style/checker.py:
31011         (_all_categories): Added JSONChecker's categories to the set of all categories.
31012         (FileType): Added a JSON type. Incremented other types.
31013         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
31014         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
31015
31016         * Scripts/webkitpy/style/checker_unittest.py:
31017         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
31018         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
31019
31020         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
31021         which would have matched our other checkers, because I couldn't figure out how to call
31022         "json.loads" without hitting namespace conflicts.)
31023         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
31024         just the modified lines from a patch.
31025         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
31026         exception.
31027         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
31028         try to extract a line number.
31029
31030         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
31031         (MockErrorHandler.__init__):
31032         (MockErrorHandler.turn_off_line_filtering):
31033         (MockErrorHandler.__call__):
31034         Helper class. Copied from xml_unittest.py.
31035
31036         (JSONCheckerTest.test_line_number_from_json_exception): Test the
31037         line_number_from_json_exception helper method.
31038
31039         (JSONCheckerTest.assert_no_error):
31040         (JSONCheckerTest.assert_error):
31041         Helper methods to assert that we did or didn't get an error.
31042
31043         (JSONCheckerTest.mock_handle_style_error): Helper method.
31044
31045         (JSONCheckerTest.test_conflict_marker):
31046         (JSONCheckerTest.test_single_quote):
31047         (JSONCheckerTest.test_init):
31048         (JSONCheckerTest.test_no_error):
31049         Test various cases.
31050
31051 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
31052
31053         [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
31054         https://bugs.webkit.org/show_bug.cgi?id=73664
31055
31056         Reviewed by Martin Robinson.
31057
31058         This patch adds our HTTP library and its main dependencies; this
31059         should not affect layout or rendering.
31060
31061         * gtk/jhbuild.modules:
31062
31063 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
31064
31065         [GTK] Also run DumpRenderTree under jhbuild
31066         https://bugs.webkit.org/show_bug.cgi?id=73646
31067
31068         Reviewed by Martin Robinson.
31069
31070         * Scripts/webkitpy/layout_tests/port/gtk.py:
31071         (GtkDriver.cmd_line):
31072
31073 2011-12-02  Hajime Morrita  <morrita@chromium.org>
31074
31075         Unreviewed, rolling out r101751 and r101775.
31076         http://trac.webkit.org/changeset/101751
31077         http://trac.webkit.org/changeset/101775
31078         https://bugs.webkit.org/show_bug.cgi?id=73191
31079
31080         breaks Windows build
31081
31082         * DumpRenderTree/chromium/config.h:
31083         * DumpRenderTree/config.h:
31084         * TestWebKitAPI/config.h:
31085         * WebKitTestRunner/config.h:
31086
31087 2011-12-02  Kentaro Hara  <haraken@chromium.org>
31088
31089         Move run-bindings-tests implementation to webkitpy/bindings/main.py
31090         https://bugs.webkit.org/show_bug.cgi?id=73619
31091
31092         Reviewed by Adam Barth.
31093
31094         As run-bindings-tests has been growing, this patch just moves its implementation
31095         to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
31096
31097         No change in behavior.
31098
31099         * Scripts/run-bindings-tests:
31100         (main):
31101         * Scripts/webkitpy/bindings/__init__.py: Added.
31102         * Scripts/webkitpy/bindings/main.py: Added.
31103         (BindingsTests.__init__):
31104         (BindingsTests.generate_from_idl):
31105         (BindingsTests.generate_supplemental_dependency):
31106         (BindingsTests.detect_changes):
31107         (BindingsTests.run_tests):
31108
31109 2011-12-01  Ilya Tikhonovsky  <loislo@chromium.org>
31110
31111         Tools/Scripts: eliminate find_test_files from Port class.
31112         https://bugs.webkit.org/show_bug.cgi?id=73553
31113
31114         rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
31115         I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
31116         Also I'll move _is_test_file() and related functions close to Port.tests().
31117
31118         Reviewed by Dirk Pranke.
31119
31120         * Scripts/webkitpy/layout_tests/port/base.py:
31121         (Port.tests):
31122         (Port.is_reference_html_file):
31123         (Port._has_supported_extension):
31124         (Port._is_test_file):
31125         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
31126         (PortTest.test_find_no_paths_specified):
31127         (PortTest.test_find_one_test):
31128         (PortTest.test_find_glob):
31129         (PortTest.test_find_with_skipped_directories):
31130         (PortTest.test_find_with_skipped_directories_2):
31131         (PortTest.test_is_test_file):
31132         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
31133         (_default_tests_paths):
31134         (ChromiumGpuLinuxPort.tests):
31135         (ChromiumGpuCgMacPort.tests):
31136         (ChromiumGpuMacPort.tests):
31137         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
31138         (ChromiumGpuTest.test_default_tests_paths.test_paths):
31139         (ChromiumGpuTest.test_default_tests_paths):
31140         (ChromiumGpuTest.test_test_files.test_paths):
31141         (ChromiumGpuTest):
31142         (ChromiumGpuTest.test_test_files):
31143         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
31144         (get_tests_run.RecordingTestDriver.run_test):
31145         * Scripts/webkitpy/tool/commands/rebaseline.py:
31146         (OptimizeBaselines._optimize_baseline):
31147         (OptimizeBaselines.execute):
31148         (AnalyzeBaselines._analyze_baseline):
31149         (AnalyzeBaselines.execute):
31150
31151 2011-12-01  Hajime Morrita  <morrita@chromium.org>
31152
31153         JS_INLINE and WTF_INLINE should be visible from WebCore
31154         https://bugs.webkit.org/show_bug.cgi?id=73191
31155
31156         Reviewed by Kevin Ollivier.
31157
31158         Removed macro definitions which is now provided by Platform.h
31159
31160         * DumpRenderTree/chromium/config.h:
31161         * DumpRenderTree/config.h:
31162         * TestWebKitAPI/config.h:
31163         * WebKitTestRunner/config.h:
31164
31165 2011-12-01  Hayato Ito  <hayato@chromium.org>
31166
31167         Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
31168         https://bugs.webkit.org/show_bug.cgi?id=73406
31169
31170         Reviewed by Ryosuke Niwa.
31171
31172         WebKitPort's image_diff uses tolerance='0.1' in default.
31173         When reftests fail, we should use tolerace=0 when diff-ing images.
31174
31175         Since ImageDiff on chromium port doesn't use tolerance value as of now,
31176         this change doesn't affect chromium port's behavior.
31177
31178         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
31179         (write_test_result):
31180         * Scripts/webkitpy/layout_tests/port/base.py:
31181         (Port.diff_image):
31182         * Scripts/webkitpy/layout_tests/port/chromium.py:
31183         (ChromiumPort.diff_image):
31184         * Scripts/webkitpy/layout_tests/port/test.py:
31185         (TestPort.diff_image):
31186         * Scripts/webkitpy/layout_tests/port/webkit.py:
31187         (WebKitPort.diff_image):
31188         (WebKitPort._start_image_diff_process):
31189         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
31190         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
31191
31192 2011-12-01  Adam Klein  <adamk@chromium.org>
31193
31194         Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
31195         https://bugs.webkit.org/show_bug.cgi?id=73599
31196
31197         Reviewed by Ojan Vafai.
31198
31199         * TestResultServer/static-dashboards/builders.js:
31200         * TestResultServer/static-dashboards/dashboard_base.js:
31201         ():
31202         (htmlForTestTypeSwitcher):
31203         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
31204         (testHtmlForTestTypeSwitcherGroup):
31205
31206 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
31207
31208         Parse reftest.list and extract types of ref tests
31209         https://bugs.webkit.org/show_bug.cgi?id=66837
31210
31211         Reviewed by Dirk Pranke.
31212
31213         Add support for reftest.list to base port.
31214
31215         * Scripts/webkitpy/common/find_files.py:
31216         (find):
31217         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
31218         (SingleTestRunner.__init__):
31219         * Scripts/webkitpy/layout_tests/port/base.py:
31220         (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
31221         to a dictionary of {test path: ("==" or "!=", reference file path)}
31222         (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
31223         (Port._reference_file_for): Added; obtains the reference file name given a test name.
31224         (Port.is_reftest): Added; Calls _reference_file_for.
31225         (Port.reftest_expected_filename): Calls _reference_file_for.
31226         (Port.reftest_expected_mismatch_filename): Ditto.
31227         (Port.find_test_files):
31228         (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
31229         -expected, -expected-mismach, -ref, or -notref as a reference file.
31230         (_is_test_file):
31231         (_parse_reftest_list): Added.
31232         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
31233         (PortTest.test_is_test_file):
31234         (PortTest.test_parse_reftest_list):
31235         * Scripts/webkitpy/layout_tests/port/dryrun.py:
31236         (DryrunDriver.run_test):
31237         * Scripts/webkitpy/layout_tests/port/test.py:
31238         (unit_test_filesystem.add_test_file):
31239         (unit_test_filesystem.add_file):
31240         (unit_test_filesystem):
31241         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
31242         (get_tests_run.RecordingTestDriver.run_test):
31243         (MainTest.test_unexpected_failures):
31244         (MainTest.test_missing_and_unexpected_results):
31245         (EndToEndTest.test_end_to_end):
31246         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
31247         (Rebaseliner._compile_rebaselining_tests):
31248
31249 2011-12-01  Sheriff Bot  <webkit.review.bot@gmail.com>
31250
31251         Unreviewed, rolling out r101711.
31252         http://trac.webkit.org/changeset/101711
31253         https://bugs.webkit.org/show_bug.cgi?id=73605
31254
31255         Broke 3 webkitpy tests (Requested by rniwa on #webkit).
31256
31257         * Scripts/webkitpy/style/checker.py:
31258         (_all_categories):
31259         (FileType):
31260         (CheckerDispatcher._file_type):
31261         (CheckerDispatcher._create_checker):
31262         * Scripts/webkitpy/style/checker_unittest.py:
31263         (CheckerDispatcherDispatchTest.assert_checker_cpp):
31264         (CheckerDispatcherDispatchTest.test_cpp_paths):
31265         * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
31266         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
31267
31268 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
31269
31270         Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
31271
31272         * Scripts/webkitpy/common/config/watchlist:
31273
31274 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
31275
31276         [GTK] Read fonts from the jhbuild root
31277         https://bugs.webkit.org/show_bug.cgi?id=73487
31278
31279         Reviewed by Gustavo Noronha Silva.
31280
31281         Read fonts from the jhbuild root instead of from the system. This will ensure
31282         that all testers use the same fonts instead of leaving this up to luck.
31283
31284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
31285         (initializeFonts): Load fonts from jhbuild root.
31286         * Scripts/webkitpy/layout_tests/port/gtk.py:
31287         (GtkPort.setup_environ_for_server): Pass an environment variable containing
31288         the path to the jhbuild root.
31289         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
31290         (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
31291
31292 2011-12-01  Adam Roben  <aroben@apple.com>
31293
31294         Teach check-webkit-style how to check the syntax of JSON files
31295
31296         Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
31297
31298         Reviewed by Darin Adler.
31299
31300         * Scripts/webkitpy/style/checker.py:
31301         (_all_categories): Added JSONChecker's categories to the set of all categories.
31302         (FileType): Added a JSON type. Incremented other types.
31303         (CheckerDispatcher._file_type): Use the JSON file type for .json files.
31304         (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
31305
31306         * Scripts/webkitpy/style/checker_unittest.py:
31307         (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
31308         (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
31309
31310         * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
31311         which would have matched our other checkers, because I couldn't figure out how to call
31312         "json.loads" without hitting namespace conflicts.)
31313         (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
31314         just the modified lines from a patch.
31315         (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
31316         exception.
31317         (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
31318         try to extract a line number.
31319
31320         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
31321         (MockErrorHandler.__init__):
31322         (MockErrorHandler.turn_off_line_filtering):
31323         (MockErrorHandler.__call__):
31324         Helper class. Copied from xml_unittest.py.
31325
31326         (JSONCheckerTest.test_line_number_from_json_exception): Test the
31327         line_number_from_json_exception helper method.
31328
31329         (JSONCheckerTest.assert_no_error):
31330         (JSONCheckerTest.assert_error):
31331         Helper methods to assert that we did or didn't get an error.
31332
31333         (JSONCheckerTest.mock_handle_style_error): Helper method.
31334
31335         (JSONCheckerTest.test_conflict_marker):
31336         (JSONCheckerTest.test_single_quote):
31337         (JSONCheckerTest.test_init):
31338         (JSONCheckerTest.test_missing_closing_brace):
31339         (JSONCheckerTest.test_no_error):
31340         Test various cases.
31341
31342 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
31343
31344         [GTK] Add a helper function to find the current executable's path
31345         https://bugs.webkit.org/show_bug.cgi?id=73473
31346
31347         Reviewed by Gustavo Noronha Silva.
31348
31349         Update MiniBrowser to not pass the binary directory as an environment variable.
31350         This means that you can move the binaries around without it breaking.
31351
31352         * MiniBrowser/gtk/main.c:
31353         (main): No longer set the environment variable.
31354         * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
31355         * WebKitTestRunner/gtk/main.cpp:  Ditto.
31356
31357 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
31358
31359         Unreviewed. Fix bad file =(.
31360
31361         * gtk/jhbuild.modules:
31362         * Scripts/webkitdirs.pm:
31363         (runAutogenForAutotoolsProject):
31364
31365 2011-12-01  Gustavo Noronha Silva  <gns@gnome.org>
31366
31367         [GTK] Add freetype to our jhbuild setup
31368         https://bugs.webkit.org/show_bug.cgi?id=73488
31369
31370         Reviewed by Martin Robinson.
31371
31372         This adds the first library to our jhbuild setup, and makes sure
31373         build-webkit calls autogen.sh and make with jhbuild, so that the
31374         environment is properly set.
31375
31376         * Scripts/webkitdirs.pm:
31377         (saveSum):
31378         (hashFile):
31379         (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
31380         call autogen under jhbuild run;
31381         (mustRunAutogen): generalized the arguments change checking to also force
31382         running autogen when jhbuild files change;
31383         (buildAutotoolsProject): run make under jhbuild;
31384         * gtk/jhbuild.modules: add freetype.
31385
31386 2011-12-01  Dominic Mazzoni  <dmazzoni@google.com>
31387
31388         Fix WebKitTestRunner compile warnings with XCode 3.2
31389         https://bugs.webkit.org/show_bug.cgi?id=73378
31390
31391         Reviewed by Chris Fleizach.
31392
31393         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
31394         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
31395         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
31396         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
31397         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
31398         (WTR::AccessibilityUIElement::AccessibilityUIElement):
31399         (WTR::AccessibilityUIElement::verticalScrollbar):
31400
31401 2011-12-01  Adam Roben  <aroben@apple.com>
31402
31403         Allow committers to use their Trac credentials to force builds on the buildbots
31404
31405         Fixes <http://webkit.org/b/73353>
31406
31407         A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
31408         three files to do its job: a config file that contains a list of WebKit committer usernames,
31409         an htdigest file that contains Trac credentials, and JSON file that gives the paths for
31410         those two files.
31411
31412         Reviewed by Darin Adler.
31413
31414         * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
31415         (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
31416         whether credentials were valid or not.
31417         (CommitterAuth.__init__): Just store the path to auth.json.
31418         (CommitterAuth.auth_json): Load, parse, and return auth.json.
31419         (CommitterAuth.auth_json_filename): Return the path to auth.json.
31420         (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
31421         credentials are valid Trac credentials. Return false otherwise or if an error occurred while
31422         checking those conditions.
31423         (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
31424         false otherwise or if an exception was thrown.
31425         (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
31426         Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
31427
31428         (CommitterAuth.open_auth_json_file):
31429         (CommitterAuth.open_trac_credentials_file):
31430         (CommitterAuth.open_webkit_committers_file):
31431         Open the specified file. These are mostly useful for testing purposes.
31432
31433         (CommitterAuth.trac_credentials_filename):
31434         (CommitterAuth.webkit_committers_filename):
31435         Return the path to the specified file by retrieving it from auth.json.
31436
31437         (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
31438         of WebKit committers from it.
31439
31440         * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
31441         (CMStringIO.__enter__):
31442         (CMStringIO.__exit__):
31443         Helper class that makes it possible to use StringIO with the "with" statement.
31444
31445         (open_override): Helper context manager for overriding the global "open" function
31446         temporarily.
31447
31448         (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
31449         tests.
31450         (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
31451         "open" to test that the expected path was opened.
31452         (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
31453         successfully.
31454         (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
31455         somehow have no Trac account can't authenticate.
31456
31457         (CommitterAuthTest.test_fail_to_open_auth_json_file):
31458         (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
31459         (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
31460         Test what happens when we can't open the three files we depend upon.
31461
31462         (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
31463         an authentication class.
31464
31465         (CommitterAuthTest.test_invalid_auth_json_file):
31466         (CommitterAuthTest.test_invalid_committers_file):
31467         (CommitterAuthTest.test_invalid_trac_credentials_file):
31468         (CommitterAuthTest.test_missing_auth_json_keys):
31469         Test what happens when the three files we depend upon are invalid in some way.
31470
31471         (CommitterAuthTest.test_open_auth_json_file):
31472         (CommitterAuthTest.test_open_trac_credentials_file):
31473         (CommitterAuthTest.test_open_webkit_committers_file):
31474         Test that we open the expected paths.
31475
31476         (CommitterAuthTest.test_trac_credentials_filename):
31477         (CommitterAuthTest.test_webkit_committers_filename):
31478         Test that we extract filenames out of auth.json correctly.
31479
31480         (CommitterAuthTest.test_non_committer_fails):
31481         (CommitterAuthTest.test_unknown_user_fails):
31482         (CommitterAuthTest.test_username_is_prefix_of_valid_user):
31483         (CommitterAuthTest.test_wrong_password_fails):
31484         Test various failed authentication attempts.
31485
31486         (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
31487         committers out of the committers file correctly.
31488
31489         (CommitterAuthTest.fake_auth_json_file):
31490         (CommitterAuthTest.invalid_auth_json_file):
31491         (CommitterAuthTest.fake_committers_file):
31492         (CommitterAuthTest.invalid_committers_file):
31493         (CommitterAuthTest.fake_htdigest_file):
31494         (CommitterAuthTest.invalid_htdigest_file):
31495         Return various fake files for testing.
31496
31497         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
31498         to be used for authentication in the web interface, and specify that only authenticated
31499         users may force builds.
31500
31501 2011-12-01  Adam Roben  <aroben@apple.com>
31502
31503         Add an HTDigestParser class to webkitpy
31504
31505         Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
31506
31507         This class can be used to parse Apache's htdigest files and check whether a given
31508         username/realm/password tuple is present in the file. Eventually this will be used for
31509         authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
31510
31511         Reviewed by Eric Seidel.
31512
31513         * Scripts/webkitpy/common/net/htdigestparser.py: Added.
31514         (HTDigestParser.__init__): Stores the parsed representation of the file.
31515         (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
31516         password and returns whether the resulting tuple is present in the file.
31517         (HTDigestParser.entries): Just returns the parsed representation of the file.
31518         (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
31519         expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
31520         whole file as invalid and all authentication attempts will fail.
31521
31522         * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
31523         (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
31524         optionally appended with some extra data, generates the expected entries.
31525         (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
31526         authenticate, and tuples not present cannot.
31527         (HTDigestParserTest.test_entries): Tests that we get the expected entries from
31528         fake_htdigest_file.
31529
31530         (HTDigestParserTest.test_empty_file):
31531         (HTDigestParserTest.test_too_few_colons):
31532         (HTDigestParserTest.test_too_many_colons):
31533         (HTDigestParserTest.test_invalid_hash):
31534         Test various forms of invalid files.
31535
31536         (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
31537
31538 2011-12-01  Philippe Normand  <pnormand@igalia.com>
31539
31540         [GTK] Make the new 64-bit Release bot part of the core set
31541         https://bugs.webkit.org/show_bug.cgi?id=73570
31542
31543         Reviewed by Adam Roben.
31544
31545         The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
31546         Debug bot which was already part of the core set. The GTK
31547         gardeners are willing to actively maintain it.
31548
31549         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
31550         (BuildBot.__init__):
31551         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
31552         (test_builder_name_regexps):
31553
31554 2011-12-01  Philippe Normand  <pnormand@igalia.com>
31555
31556         [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
31557         https://bugs.webkit.org/show_bug.cgi?id=73547
31558
31559         Reviewed by Adam Roben.
31560
31561         * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
31562         the 32-bit Debug configuration to 64-bit Release. The new slave is
31563         a 64-bit machine already. The 32-bit slave will be shut down.
31564
31565 2011-12-01  Martin Robinson  <mrobinson@igalia.com>
31566
31567         [GTK] build-jsc should not trigger gtkdoc generation
31568         https://bugs.webkit.org/show_bug.cgi?id=73552
31569
31570         Reviewed by Philippe Normand.
31571
31572         Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
31573         that build-jsc does not try to generate gtkdoc.
31574
31575         * Scripts/webkitdirs.pm:
31576         (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
31577
31578 2011-12-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
31579
31580         tests_run0.txt gets clobbered when re-running failing tests
31581         https://bugs.webkit.org/show_bug.cgi?id=63844
31582
31583         Reviewed by Dirk Pranke.
31584
31585         * Scripts/webkitpy/layout_tests/controllers/manager.py:
31586         (Manager.results_directory):
31587         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
31588         (AbstractWorker.__init__):
31589         (_ManagerConnection.start_worker):
31590         (_InlineManager.start_worker):
31591         (_MultiProcessManager.start_worker):
31592         (_WorkerConnection.__init__):
31593         (_InlineWorkerConnection.__init__):
31594         (_MultiProcessWorkerConnection.__init__):
31595         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
31596         (_TestWorker.__init__):
31597         (_TestsMixin.test_cancel):
31598         (_TestsMixin.test_done):
31599         (_TestsMixin.test_unknown_message):
31600         (InterfaceTest.test_managerconnection_is_abstract):
31601         (InterfaceTest.test_workerconnection_is_abstract):
31602         * Scripts/webkitpy/layout_tests/controllers/worker.py:
31603         (Worker.__init__):
31604         (Worker.safe_init):
31605         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
31606         (MainTest.test_retries_directory):
31607
31608 2011-12-01  Adam Roben  <aroben@apple.com>
31609
31610         Buildbot fix
31611
31612         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
31613         BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
31614         it possible for build steps to reference things like the buildbotURL property of the config.
31615
31616 2011-11-30  Adam Roben  <aroben@apple.com>
31617
31618         Use curl for downloading builds to test slaves
31619
31620         Buildbot's built-in file transfer capabilities are transferring files much more slowly than
31621         curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
31622         often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
31623         overhead (courtesy of the Twisted framework).
31624
31625         Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
31626         meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
31627         This should make the test slaves quite a bit faster, and should ease the CPU load on
31628         build.webkit.org a bit.
31629
31630         Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
31631
31632         Reviewed by Mark Rowe.
31633
31634         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
31635         to Test slaves. It's run just before DownloadBuiltProduct.
31636         (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
31637         download.
31638         (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
31639         FileDownload used to do this for us automatically.
31640
31641 2011-11-21  Philippe Normand  <pnormand@igalia.com>
31642
31643         [GTK] enable-webaudio websetting
31644         https://bugs.webkit.org/show_bug.cgi?id=69836
31645
31646         Reviewed by Martin Robinson.
31647
31648         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
31649         (LayoutTestController::overridePreference): Update WebKitGTK
31650         enable-webaudio setting when a layout test requests it.
31651
31652 2011-11-30  Ilya Tikhonovsky  <loislo@chromium.org>
31653
31654         Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
31655         https://bugs.webkit.org/show_bug.cgi?id=73079
31656
31657         The idea is to have performance tests for WebInspector.
31658         I was suggested to put these tests into PerformanceTests/inspector.
31659         They produce output in a format that is suitable for chromium perf bot drawing scripts.
31660
31661         I'd like to reuse code for scanning folders for test files.
31662         Because of the fact that original test_files.py has common and layout specific parts
31663         I decided to extract the generic part and put it into webkitpy/common
31664         I think the two packages with name test_files look strange but I have no idea about a better name.
31665
31666         Reviewed by Dirk Pranke.
31667
31668         * Scripts/run-inspector-perf-tests.py: Added.
31669         * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
31670         (find):
31671         (_normalize):
31672         * Scripts/webkitpy/common/find_files_unittest.py: Added.
31673         (MockWinFileSystem.join):
31674         (MockWinFileSystem):
31675         (MockWinFileSystem.normpath):
31676         (TestWinNormalize.assert_filesystem_normalizes):
31677         (TestWinNormalize.test_mocked_win):
31678         (TestWinNormalize):
31679         (TestWinNormalize.test_win):
31680         * Scripts/webkitpy/layout_tests/port/base.py:
31681         (Port.tests):
31682         (Port.find_test_files):
31683         (Port._driver_class):
31684         (is_reference_html_file):
31685         (_has_supported_extension):
31686         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
31687         (PortTest.test_find_no_paths_specified):
31688         (PortTest.test_find_one_test):
31689         (PortTest.test_find_glob):
31690         (PortTest.test_find_with_skipped_directories):
31691         (PortTest.test_find_with_skipped_directories_2):
31692         (PortTest):
31693         (PortTest.test_is_test_file):
31694         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
31695         (_tests):
31696         * Scripts/webkitpy/layout_tests/port/test.py:
31697         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
31698         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
31699         * Scripts/webkitpy/performance_tests/__init__.py: Added.
31700         * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
31701         (PerfTestsRunner.__init__):
31702         (PerfTestsRunner._parse_args):
31703         (PerfTestsRunner._collect_tests._is_test_file):
31704         (PerfTestsRunner._collect_tests):
31705         (PerfTestsRunner.run):
31706         (PerfTestsRunner._run_tests_set):
31707         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
31708         (MainTest.TestPort):
31709         (MainTest.TestPort.create_driver):
31710         (MainTest.TestDriver.run_test):
31711         (MainTest.TestDriver):
31712         (MainTest.TestDriver.stop):
31713         (MainTest.create_runner):
31714         (MainTest.run_test):
31715         (MainTest.test_run_passing_test):
31716         (MainTest.test_run_silent_test):
31717         (MainTest.test_run_failed_test):
31718         (MainTest.test_run_tonguey_test):
31719         (MainTest.test_run_timeout_test):
31720         (MainTest.test_run_crash_test):
31721         (MainTest.test_run_test_set):
31722         (MainTest.test_collect_tests):
31723         (MainTest):
31724         (MainTest.test_parse_args):
31725         * Scripts/webkitpy/tool/commands/rebaseline.py:
31726         (OptimizeBaselines.execute):
31727         (AnalyzeBaselines.execute):
31728
31729 2011-11-30  nduca@chromium.org  <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
31730
31731         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
31732         https://bugs.webkit.org/show_bug.cgi?id=70838
31733
31734         Reviewed by James Robinson.
31735
31736         * DumpRenderTree/chromium/TestShell.cpp:
31737         (TestShell::resetWebSettings):
31738         * DumpRenderTree/chromium/TestShell.h:
31739         (TestShell::threadedCompositingEnabled):
31740         * DumpRenderTree/chromium/WebPreferences.cpp:
31741         (WebPreferences::reset):
31742         (WebPreferences::applyTo):
31743         * DumpRenderTree/chromium/WebPreferences.h:
31744         * DumpRenderTree/chromium/WebViewHost.cpp:
31745         (WebViewHost::WebViewHost):
31746         (WebViewHost::~WebViewHost):
31747
31748 2011-11-30  Chris Fleizach  <cfleizach@apple.com>
31749
31750         AX: Nodes are reporting that focus can be set when they really can't
31751         https://bugs.webkit.org/show_bug.cgi?id=72791
31752
31753         Reviewed by Beth Dakin.
31754
31755         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
31756         (AccessibilityUIElement::isFocusable):
31757         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
31758         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
31759         (WTR::AccessibilityUIElement::isFocusable):
31760
31761 2011-11-30  Alejandro G. Castro  <alex@igalia.com>
31762
31763         Moved myself to the reviewers list.
31764
31765         * Scripts/webkitpy/common/config/committers.py:
31766
31767 2011-11-30  David Levin  <levin@chromium.org>
31768
31769         [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
31770         https://bugs.webkit.org/show_bug.cgi?id=73415
31771
31772         Reviewed by Darin Fisher.
31773
31774         * DumpRenderTree/chromium/WebViewHost.cpp:
31775         (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
31776         it being moved to a new interface and having the parameter removed.
31777         * DumpRenderTree/chromium/WebViewHost.h: Ditto.
31778
31779 2011-11-30  Adam Roben  <aroben@apple.com>
31780
31781         Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
31782
31783         This will make it a lot easier to investigate build failures on the bots.
31784
31785         Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
31786
31787         Reviewed by Eric Seidel.
31788
31789         * Scripts/webkitpy/common/system/executive_mock.py:
31790         (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
31791         makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
31792         seen in practice.
31793
31794         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
31795         (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
31796         The Printer was modifying the root logger in way that would cause my new tests in
31797         WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
31798         seem important to the functioning of this test, and passing False makes Printer not modify
31799         the root logger.
31800
31801         * Scripts/webkitpy/layout_tests/port/webkit.py:
31802         (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
31803         up when --verbose is passed but not otherwise.
31804         (WebKitPort._build_driver): When an error occurs, log the error message and the script's
31805         output at the ERROR level so it will always show up.
31806
31807         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
31808         (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
31809         cases. Test that the build scripts' output is logged when --verbose is passed or the build
31810         fails.
31811
31812 2011-11-30  Adam Roben  <aroben@apple.com>
31813
31814         Add a way to set OutputCapture's log level
31815
31816         This will be used by some unit tests I'm planning to add.
31817
31818         Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
31819
31820         Reviewed by Eric Seidel.
31821
31822         * Scripts/webkitpy/common/system/outputcapture.py:
31823         (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
31824         level we ever used before this patch.
31825         (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
31826         being tested uses. Sets the log level for any current or future logging handlers.
31827         (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
31828
31829         * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
31830         (OutputCaptureTest.setUp): Create an OutputCapture to test.
31831         (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
31832         (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
31833         was logged.
31834         (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
31835         (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
31836         level.
31837
31838 2011-11-29  Beth Dakin  <bdakin@apple.com>
31839
31840         https://bugs.webkit.org/show_bug.cgi?id=72751
31841         WebKit2.MouseMoveAfterCrash API test is failing
31842
31843         Reviewed by Sam Weinig.
31844
31845         Like DumpRenderTree, the NSWindow should act as an active window.
31846         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
31847         (-[ActiveOffscreenWindow isKeyWindow]):
31848         (TestWebKitAPI::PlatformWebView::PlatformWebView):
31849
31850 2011-11-30  Gustavo Noronha Silva  <gns@gnome.org>
31851
31852         Add step to update gtk dependencies to the buildbot
31853         https://bugs.webkit.org/show_bug.cgi?id=73455
31854
31855         Reviewed by Martin Robinson.
31856
31857         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
31858
31859 2011-11-30  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
31860
31861         [Qt] Add a fullscreen option to MiniBrowser.
31862         https://bugs.webkit.org/show_bug.cgi?id=73445
31863
31864         Reviewed by Noam Rosenthal.
31865
31866         This bypasses the compositor on the N9 to increase performances
31867         and remove the huge useless gray bar part of the window frame
31868         at the bottom.
31869
31870         * MiniBrowser/qt/BrowserWindow.cpp:
31871         (BrowserWindow::BrowserWindow):
31872         * MiniBrowser/qt/MiniBrowserApplication.cpp:
31873         (printHelp):
31874         (MiniBrowserApplication::handleUserOptions):
31875         * MiniBrowser/qt/MiniBrowserApplication.h:
31876         (WindowOptions::setStartFullScreen):
31877         (WindowOptions::startFullScreen):
31878
31879 2011-11-30  Martin Robinson  <mrobinson@igalia.com>
31880
31881         [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
31882         https://bugs.webkit.org/show_bug.cgi?id=73425
31883
31884         Reviewed by Gustavo Noronha Silva.
31885
31886         Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
31887         ensure that the jhbuild root is up-to-date. Currently the only module is
31888         the font module.
31889
31890         * Scripts/update-webkitgtk-libs: Added.
31891         * gtk/common.py: Added a helper to get the number of CPUs.
31892         * gtk/jhbuild.modules: Added.
31893         * gtk/jhbuildrc: Added.
31894
31895 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
31896
31897         [Qt] Remove dependency of Qt DRT on JavaScriptCore.
31898
31899         Reviewed by Csaba Osztrogonác.
31900
31901         * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
31902         instead of one that pulls in JavaScriptCore headers.
31903         * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
31904         with load(javascriptcore).
31905
31906 2011-11-30  Sheriff Bot  <webkit.review.bot@gmail.com>
31907
31908         Unreviewed, rolling out r101440 and r101442.
31909         http://trac.webkit.org/changeset/101440
31910         http://trac.webkit.org/changeset/101442
31911         https://bugs.webkit.org/show_bug.cgi?id=73429
31912
31913         multiple crashes on layout tests (Requested by hayato on
31914         #webkit).
31915
31916         * DumpRenderTree/chromium/TestShell.cpp:
31917         (TestShell::resetWebSettings):
31918         * DumpRenderTree/chromium/TestShell.h:
31919         * DumpRenderTree/chromium/WebPreferences.cpp:
31920         (WebPreferences::reset):
31921         (WebPreferences::applyTo):
31922         * DumpRenderTree/chromium/WebPreferences.h:
31923         * DumpRenderTree/chromium/WebViewHost.cpp:
31924         (WebViewHost::WebViewHost):
31925         (WebViewHost::~WebViewHost):
31926
31927 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
31928
31929         [Chromium] Fix broken DRT build for Aura Linux
31930         https://bugs.webkit.org/show_bug.cgi?id=72667
31931
31932         Reviewed by Tony Chang.
31933
31934         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
31935
31936         The following changes have been made:
31937
31938           1. Renamed TestShellAndroid to TestShellLinux.
31939           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
31940           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
31941
31942         * DumpRenderTree/DumpRenderTree.gypi:
31943         * DumpRenderTree/chromium/EventSender.cpp:
31944         (EventSender::keyDown):
31945         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
31946         * DumpRenderTree/chromium/TestShellGtk.cpp:
31947         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
31948         (AlarmHandler):
31949         (TestShell::waitTestFinished):
31950         (setupFontconfig):
31951         (platformInit):
31952         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
31953         (checkLayoutTestSystemDependencies):
31954         (openStartupDialog):
31955
31956 2011-11-30  Fady Samuel  <fsamuel@chromium.org>
31957
31958         [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
31959         https://bugs.webkit.org/show_bug.cgi?id=73328
31960
31961         Reviewed by Kent Tamura.
31962
31963         * DumpRenderTree/chromium/LayoutTestController.cpp:
31964         (LayoutTestController::enableFixedLayoutMode):
31965         (LayoutTestController::setFixedLayoutSize):
31966
31967 2011-11-29  Hayato Ito  <hayato@chromium.org>
31968
31969         Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
31970         https://bugs.webkit.org/show_bug.cgi?id=73381
31971
31972         Reviewed by Ryosuke Niwa.
31973
31974         This is a quick fix for the breakage of tests on non-chromium port.
31975         We should implement diff_image later on non-chromium ports.
31976
31977         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
31978         (write_test_result):
31979
31980 2011-11-29  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
31981
31982         [NRWT] Fix --platform=qt-5.0 --new-baseline combo
31983         https://bugs.webkit.org/show_bug.cgi?id=72489
31984
31985         Reviewed by Eric Seidel.
31986
31987         Before the this fix always added "qt" option for the option list
31988         * Scripts/run-webkit-tests:
31989         * Scripts/webkitpy/layout_tests/port/qt.py:
31990
31991 2011-11-29  David Levin  <levin@chromium.org>
31992
31993         Add a way to revert a variable to its previous value after leaving a scope.
31994         https://bugs.webkit.org/show_bug.cgi?id=73371
31995
31996         Reviewed by Adam Barth.
31997
31998         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
31999         * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
32000         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
32001         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
32002         * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
32003         (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
32004
32005 2011-11-28  Kentaro Hara  <haraken@chromium.org>
32006
32007         Implement [Supplemental] IDL and support it in run-bindings-tests
32008         https://bugs.webkit.org/show_bug.cgi?id=73162
32009
32010         Reviewed by Adam Barth.
32011
32012         run-bindings-tests supports the [Supplemental] IDL in the following way.
32013             (1) It creates a file |x| listing all IDL files.
32014             (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
32015             (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
32016                 Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
32017                 including all attributes in IDL files that are supplementing the IDL file |z|.
32018
32019         * Scripts/run-bindings-tests:
32020         (generate_from_idl):
32021         (generate_supplemental_dependency):
32022         (detect_changes):
32023         (run_tests):
32024         (main):
32025
32026 2011-11-18  Nat Duca  <nduca@chromium.org>
32027
32028         [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
32029         https://bugs.webkit.org/show_bug.cgi?id=70838
32030
32031         Reviewed by James Robinson.
32032
32033         * DumpRenderTree/chromium/TestShell.cpp:
32034         (TestShell::resetWebSettings):
32035         * DumpRenderTree/chromium/TestShell.h:
32036         (TestShell::threadedCompositingEnabled):
32037         * DumpRenderTree/chromium/WebPreferences.cpp:
32038         (WebPreferences::reset):
32039         (WebPreferences::applyTo):
32040         * DumpRenderTree/chromium/WebPreferences.h:
32041         * DumpRenderTree/chromium/WebViewHost.cpp:
32042         (WebViewHost::WebViewHost):
32043         (WebViewHost::~WebViewHost):
32044
32045 2011-11-29  Ojan Vafai  <ojan@chromium.org>
32046
32047         List of builders in the flakiness dashboard is out of date
32048         https://bugs.webkit.org/show_bug.cgi?id=73347
32049
32050         Reviewed by Adam Barth.
32051
32052         The chromium gpu bots no longer run layout tests, so kill that
32053         group entirely.
32054
32055         * TestResultServer/static-dashboards/builders.js:
32056         * TestResultServer/static-dashboards/dashboard_base.js:
32057
32058 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
32059
32060         [Qt] Don't hard-code the list of WebKit2 generated sources
32061
32062         The generated sources are... wait for it... generated. So
32063         use the generator itself to figure out which sources we need
32064         to compile.
32065
32066         Reviewed by Simon Hausmann.
32067
32068         * qmake/mkspecs/features/default_post.prf:
32069
32070 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
32071
32072         [GTK] Add a method to detect 'make dist' errors without running 'make dist'
32073         https://bugs.webkit.org/show_bug.cgi?id=73216
32074
32075         Reviewed by Philippe Normand.
32076
32077         Add a script that tries to sniff out 'make dist' problems without running
32078         'make dist.' 'make distcheck' takes a very long time to run and this should
32079         reduce the amount of times it needs to be run consecutively.
32080
32081         * gtk/common.py:
32082         (get_build_path.is_valid_build_directory): Guess the source directory
32083         by the existence of the GNUmakefile instead of the .libs directory. This
32084         allows one to run the script after running autogen.sh but before fully
32085         building.
32086         * gtk/find-make-dist-errors: Added.
32087
32088 2011-11-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
32089
32090         [Qt] Remove use of internal headers in the MiniBrowser
32091
32092         Reviewed by Simon Hausmann.
32093
32094         * MiniBrowser/qt/MiniBrowser.pro:
32095
32096 2011-11-29  Simon Hausmann  <simon.hausmann@nokia.com>
32097
32098         [Qt] Fix debug-shlib build without webkit2
32099
32100         Reviewed by Tor Arne Vestbø.
32101
32102         * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
32103
32104 2011-11-28  Csaba Osztrogonác  <ossy@webkit.org>
32105
32106         [Qt][WK2] Unreviewed buildfix after r101307.
32107
32108         * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
32109
32110 2011-11-29  Roland Steiner  <rolandsteiner@chromium.org>
32111
32112         <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
32113         https://bugs.webkit.org/show_bug.cgi?id=72848
32114
32115         Add option to build-webkit.
32116
32117         Reviewed by Dimitri Glazkov.
32118
32119         * Scripts/build-webkit:
32120
32121 2011-11-28  Ojan Vafai  <ojan@chromium.org>
32122
32123         gtest normalization in the test results server is sometimes wrong
32124         https://bugs.webkit.org/show_bug.cgi?id=73262
32125
32126         Reviewed by Tony Chang.
32127
32128         If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
32129         entries in the incremental JSON, one of the entries will have the correct data
32130         from the run and the other will have dummy no-data values. Make sure to
32131         always pick the one with real data.
32132
32133         * TestResultServer/model/jsonresults.py:
32134         (JsonResults._remove_gtest_modifiers):
32135         * TestResultServer/model/jsonresults_unittest.py:
32136         (JsonResultsTest.test_remove_gtest_modifiers):
32137
32138 2011-11-28  Ojan Vafai  <ojan@chromium.org>
32139
32140         Some of the results.json files have results/times entries at the directory level
32141         https://bugs.webkit.org/show_bug.cgi?id=73261
32142
32143         Reviewed by Tony Chang.
32144
32145         This is just a bug that got introduced in a temporary push of the results server.
32146         This patch repairs the broken files. After all the bots have cycled, we can simplify
32147         this code to just assert that results/times are not at the directory level.
32148
32149         Also, when catching exceptions, log the full stacktrace.
32150
32151         * TestResultServer/model/jsonresults.py:
32152         (_is_directory):
32153         (JsonResults._load_json):
32154         (JsonResults._merge_tests):
32155         (JsonResults.merge):
32156         * TestResultServer/model/jsonresults_unittest.py:
32157         (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
32158
32159 2011-11-28  Tony Chang  <tony@chromium.org>
32160
32161         ews bots should pass --force to update-webkit-chromium
32162         https://bugs.webkit.org/show_bug.cgi?id=73230
32163
32164         Reviewed by Adam Barth.
32165
32166         This makes it less likely for gclient changes to break the bots (e.g.,
32167         if a DEPS repository moves or is switched to a branch).
32168
32169         Also pass --force when using |build-webkit --update-chromium| since this
32170         appears to only be used by the bots.
32171
32172         Take 2: Add Options.non_interactive to update.py's options() method.
32173
32174         * Scripts/update-webkit:
32175         * Scripts/webkitdirs.pm:
32176         (determineIsChromium): Add --force-update to update-webkit --chromium.
32177         (forceChromiumUpdate):
32178         (buildChromium): Pass --force to update-webkit-chromium.
32179         * Scripts/webkitpy/tool/steps/update.py:
32180         (Update.run): Add --force-update if non-interactive (i.e., bots).
32181         * Scripts/webkitpy/tool/steps/update_unittest.py:
32182
32183 2011-11-28  Tony Chang  <tony@chromium.org>
32184
32185         Revert r101279, broke the ews and cq bots.
32186
32187         * Scripts/update-webkit:
32188         * Scripts/webkitdirs.pm:
32189         (determineIsChromium):
32190         (buildChromium):
32191         * Scripts/webkitpy/common/config/ports.py:
32192         (WebKitPort.update_webkit_command):
32193         (ChromiumPort.update_webkit_command):
32194         * Scripts/webkitpy/common/config/ports_mock.py:
32195         (MockPort.update_webkit_command):
32196         * Scripts/webkitpy/tool/steps/update.py:
32197         * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
32198
32199 2011-11-28  Ojan Vafai  <ojan@chromium.org>
32200
32201         testlistjson on the test results server doesn't understand hierarchical results format
32202         https://bugs.webkit.org/show_bug.cgi?id=73246
32203
32204         Reviewed by Tony Chang.
32205
32206         * TestResultServer/model/jsonresults.py:
32207         (JsonResults._delete_results_and_times):
32208         Instead of just getting the top-level keys, we now walk the tests tree and
32209         delete the results and times values.
32210
32211         * TestResultServer/model/jsonresults_unittest.py:
32212         Simplify the test harness to take in the same JSON format for the tests
32213         that the actual results.json uses instead of something very similar but
32214         needlessly different. This also allows for testing the broken case of
32215         results and times values being at non-leaf level.
32216
32217 2011-11-28  Tony Chang  <tony@chromium.org>
32218
32219         ews bots should pass --force to update-webkit-chromium
32220         https://bugs.webkit.org/show_bug.cgi?id=73230
32221
32222         Reviewed by Adam Barth.
32223
32224         This makes it less likely for gclient changes to break the bots (e.g.,
32225         if a DEPS repository moves or is switched to a branch).
32226
32227         Also pass --force when using |build-webkit --update-chromium| since this
32228         appears to only be used by the bots.
32229
32230         * Scripts/update-webkit:
32231         * Scripts/webkitdirs.pm:
32232         (determineIsChromium): Add --force-update to update-webkit --chromium.
32233         (forceChromiumUpdate):
32234         (buildChromium): Pass --force to update-webkit-chromium.
32235         * Scripts/webkitpy/tool/steps/update.py:
32236         (Update.run): Add --force-update if non-interactive (i.e., bots).
32237         * Scripts/webkitpy/tool/steps/update_unittest.py:
32238
32239 2011-11-28  Michael Saboff  <msaboff@apple.com>
32240
32241         Fixed help message for --exclude-kraken to say that
32242         it excludes Kraken and not SunSpider.
32243
32244         Rubber-stamped by Filip Pizlo.
32245
32246         * Scripts/bencher:
32247
32248 2011-11-28  Sheriff Bot  <webkit.review.bot@gmail.com>
32249
32250         Unreviewed, rolling out r101273.
32251         http://trac.webkit.org/changeset/101273
32252         https://bugs.webkit.org/show_bug.cgi?id=73244
32253
32254         multiple test failures and timeouts (Requested by tony^work on
32255         #webkit).
32256
32257         * DumpRenderTree/DumpRenderTree.gypi:
32258         * DumpRenderTree/chromium/EventSender.cpp:
32259         (EventSender::keyDown):
32260         * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
32261         (AlarmHandler):
32262         (TestShell::waitTestFinished):
32263         (platformInit):
32264         (openStartupDialog):
32265         (checkLayoutTestSystemDependencies):
32266         * DumpRenderTree/chromium/TestShellGtk.cpp:
32267         (AlarmHandler):
32268         (setupFontconfig):
32269         (TestShell::waitTestFinished):
32270         (platformInit):
32271         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
32272         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
32273
32274 2011-11-28  John Yani  <vanuan@gmail.com>
32275
32276         new-run-webkit-tests is locale dependent
32277         https://bugs.webkit.org/show_bug.cgi?id=68691
32278
32279         Reviewed and modified by Eric Seidel.
32280
32281         This is a simpler version of John's patch which I'm landing.
32282         This just engages the hacks from the Host constructor on a global
32283         basis.
32284
32285         * Scripts/webkitpy/common/host.py:
32286         (Host.__init__):
32287         (Host._engage_awesome_locale_hacks):
32288
32289 2011-11-28  Fady Samuel  <fsamuel@chromium.org>
32290
32291         [Chromium] Fix broken DRT build for Aura Linux
32292         https://bugs.webkit.org/show_bug.cgi?id=72667
32293
32294         Reviewed by Tony Chang.
32295
32296         DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
32297
32298         The following changes have been made:
32299
32300           1. Renamed TestShellAndroid to TestShellLinux.
32301           2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
32302           3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
32303
32304         * DumpRenderTree/DumpRenderTree.gypi:
32305         * DumpRenderTree/chromium/EventSender.cpp:
32306         (EventSender::keyDown):
32307         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
32308         * DumpRenderTree/chromium/TestShellGtk.cpp:
32309         * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
32310         (AlarmHandler):
32311         (TestShell::waitTestFinished):
32312         (setupFontconfig):
32313         (platformInit):
32314         * DumpRenderTree/chromium/TestShellStub.cpp: Added.
32315         (checkLayoutTestSystemDependencies):
32316         (openStartupDialog):
32317
32318 2011-11-28  Eric Seidel  <eric@webkit.org>
32319
32320         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
32321         https://bugs.webkit.org/show_bug.cgi?id=71983
32322
32323         Reviewed by Adam Barth.
32324
32325         We'll add more code to Environment overtime,
32326         allowing us to mock out more of our direct interactions with os.environ.
32327
32328         This patch also makes run_command print the passed in environment.
32329
32330         * Scripts/webkitpy/common/host_mock.py:
32331         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32332         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32333         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32334         * Scripts/webkitpy/common/system/executive.py:
32335         * Scripts/webkitpy/common/system/executive_mock.py:
32336         * Scripts/webkitpy/layout_tests/port/webkit.py:
32337         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
32338         * Scripts/webkitpy/tool/commands/download_unittest.py:
32339         * Scripts/webkitpy/tool/steps/build.py:
32340
32341 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
32342
32343         [Qt] Build system fixes against V8.
32344
32345         Reviewed by Tor Arne Vestbø.
32346
32347         * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
32348         * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
32349         WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
32350
32351 2011-11-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
32352
32353         Make sure the useFixedLayout feature is consistently handled
32354         https://bugs.webkit.org/show_bug.cgi?id=73212
32355
32356         Reviewed by Simon Hausmann.
32357
32358         The web page parameters are set to our Qt defaults and are now altered
32359         in the WebKitTestRunner.
32360
32361         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
32362         (WTR::WrapperWindow::WrapperWindow):
32363
32364 2011-11-28  Simon Hausmann  <simon.hausmann@nokia.com>
32365
32366         [Qt] WTF should be built as separate static library
32367         https://bugs.webkit.org/show_bug.cgi?id=73201
32368
32369         Reviewed by Tor Arne Vestbø.
32370
32371         * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
32372         * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
32373         thus wtf dependency.
32374         * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
32375         * WebKitTestRunner/Target.pri: Ditto.
32376         * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
32377         consider wtf, too.
32378         * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
32379         moved into wtf.prf.
32380         * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
32381         link in libwtf.
32382         * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
32383
32384 2011-11-28  Kentaro Hara  <haraken@chromium.org>
32385
32386         run-bindings-tests shows diff error for a newly added binding test
32387         https://bugs.webkit.org/show_bug.cgi?id=73179
32388
32389         Reviewed by Adam Barth.
32390
32391         Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
32392         run-bindings-tests just shows diff error because reference files
32393         (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
32394
32395             FAIL: (V8) V8TestSupplemental.h
32396             diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
32397
32398         Instead, this patch treats a non-existent reference file as an empty file and
32399         shows the result of the newly added binding test, like this:
32400
32401             FAIL: (V8) V8TestSupplemental.h
32402             --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h       1970-01-01 09:00:00.000000000 +0900
32403             +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
32404             @@ -0,0 +1,84 @@
32405             +/*
32406             +    This file is part of the WebKit open source project.
32407             +    This file has been generated by generate-bindings.pl. DO NOT MODIFY!
32408             +
32409             (omitted)
32410
32411         * Scripts/run-bindings-tests:
32412         (detect_changes): Just added an -N option to the diff command.
32413
32414 2011-11-28  Martin Robinson  <mrobinson@igalia.com>
32415
32416         [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
32417         https://bugs.webkit.org/show_bug.cgi?id=73165
32418
32419         Reviewed by Philippe Normand.
32420
32421         Fix some syntax errors in this script and remove an unused variable.
32422
32423         * gtk/generate-gtkdoc:
32424         (get_webkit2_options.src_path):
32425         (get_webkit2_options):
32426         (get_webkit1_options.src_path):
32427
32428 2011-11-26  Kevin Ollivier  <kevino@theolliviers.com>
32429
32430         [wx] Unreviewed build fix. Enable the inspector.
32431
32432         * waf/build/settings.py:
32433
32434 2011-11-26  Martin Robinson  <mrobinson@igalia.com>
32435
32436         Try to fix the build after r101174.
32437
32438         * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
32439
32440 2011-11-17  Martin Robinson  <mrobinson@igalia.com>
32441
32442         [GTK] Integrate build-gtkdoc into build-webkit and make
32443         https://bugs.webkit.org/show_bug.cgi?id=72626
32444
32445         Reviewed by Philippe Normand.
32446
32447         * GNUmakefile.am: Added support for new scripts and "make docs".
32448         * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
32449         (buildAutotoolsProject):
32450         * gtk/generate-gtkdoc: Added.
32451         * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
32452
32453 2011-11-25  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
32454
32455         [Qt] Add support for using OWRT with Qt5
32456         https://bugs.webkit.org/show_bug.cgi?id=72947
32457
32458         Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
32459
32460         Reviewed by Csaba Osztrogonác.
32461
32462         * Scripts/old-run-webkit-tests:
32463
32464 2011-11-25  Yury Semikhatsky  <yurys@chromium.org>
32465
32466         [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
32467         https://bugs.webkit.org/show_bug.cgi?id=73126
32468
32469         No need to have a separate client call for this. The front-end can store messages
32470         which arrive before front-end loaded and dispatch them later. This happens in layout
32471         tests only by the way as all other messages should be initiated by the front-end code.
32472
32473         Reviewed by Pavel Feldman.
32474
32475         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
32476         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
32477         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
32478         * DumpRenderTree/chromium/DRTDevToolsClient.h:
32479
32480 2011-11-24  Kentaro Hara  <haraken@chromium.org>
32481
32482         Replace subprocess.call() with subprocess.Popen()
32483         https://bugs.webkit.org/show_bug.cgi?id=73105
32484
32485         Reviewed by Adam Barth.
32486
32487         Currently, the stdout and stderr of the child processes of run-bindings-tests
32488         are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
32489         This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
32490         between a parent process and a child process. This patch replaces subprocess.call() with
32491         subprocess.Popen() and synchronizes the stdout and stderr between them.
32492         This patch also makes output messages of run-bindings-tests more readable.
32493
32494         With this patch, the output messages of run-bindings-tests look like as follows:
32495
32496             PASS: (CPP) WebDOMTestObj.h
32497             PASS: (CPP) WebDOMTestObj.cpp
32498             FAIL: (CPP) WebDOMTestInterface.h
32499             --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h      2011-11-25 13:34:09.313516268 +0900
32500             +++ /tmp/tmpDAV87G/WebDOMTestInterface.h        2011-11-25 13:44:42.712946812 +0900
32501             @@ -23,7 +23,7 @@
32502              #ifndef WebDOMTestInterface_h
32503              #define WebDOMTestInterface_h
32504
32505             -#if ENABLE(Condition1) || ENABLE(Condition2)
32506             +#if ENABLE(Condition1) || ENABLE(Condition3)
32507
32508              #include <WebDOMObject.h>
32509              #include <WebDOMString.h>
32510              @@ -53,5 +53,5 @@
32511              WebDOMTestInterface toWebKit(WebCore::TestInterface*);
32512
32513              #endif
32514             -#endif // ENABLE(Condition1) || ENABLE(Condition2)
32515             +#endif // ENABLE(Condition1) || ENABLE(Condition3)
32516             PASS: (CPP) WebDOMFloat64Array.cpp
32517             PASS: (CPP) WebDOMFloat64Array.h
32518
32519             Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
32520
32521         * Scripts/run-bindings-tests:
32522         (generate_from_idl):
32523         (detect_changes):
32524         (run_tests):
32525         (main):
32526
32527 2011-11-24  Kentaro Hara  <haraken@chromium.org>
32528
32529         Fix the current working directory of run-bindings-tests
32530         https://bugs.webkit.org/show_bug.cgi?id=73106
32531
32532         Reviewed by Adam Barth.
32533
32534         Currently, run-bindings-tests outputs the following error
32535         (although it outputs "all tests passed!" in the end):
32536
32537             Testing the ObjC generator on TestObj.idl
32538             gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
32539             gcc: warning: '-x objective-c' after last input file has no effect
32540             gcc: no input files
32541
32542         This is because CodeGeneratorObjC.pm assumes that the current working directory
32543         is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
32544         Thus, this patch changes it to WebKit/Source/.
32545
32546         * Scripts/run-bindings-tests:
32547         (generate_from_idl):
32548         (main):
32549
32550 2011-11-24  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
32551
32552         [Qt] Get rid of the buildDirForSource() function in the build system
32553
32554         At some point the plan was to allow for running qmake on sub-trees
32555         of the sources, into the top level build directory, but this is no
32556         longer possible, so no reason to keep the convenience function around.
32557
32558         Reviewed by Simon Hausmann.
32559
32560         * WebKitTestRunner/DerivedSources.pri:
32561         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
32562         * qmake/mkspecs/features/default_post.prf:
32563         * qmake/mkspecs/features/default_pre.prf:
32564         * qmake/mkspecs/features/functions.prf:
32565         * qmake/mkspecs/features/javascriptcore.prf:
32566         * qmake/mkspecs/features/webcore.prf:
32567         * qmake/mkspecs/features/webkit2.prf:
32568
32569 2011-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
32570
32571         Unreviewed, rolling out r101107.
32572         http://trac.webkit.org/changeset/101107
32573         https://bugs.webkit.org/show_bug.cgi?id=73062
32574
32575         Breaks the commit-queue (Requested by abarth on #webkit).
32576
32577         * Scripts/webkitpy/common/host.py:
32578         (Host._engage_awesome_windows_hacks):
32579         * Scripts/webkitpy/common/host_mock.py:
32580         (MockHost.__init__):
32581         * Scripts/webkitpy/common/system/environment.py: Removed.
32582         * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
32583         * Scripts/webkitpy/common/system/executive.py:
32584         (Executive._run_command_with_teed_output):
32585         (Executive.run_and_throw_if_fail):
32586         * Scripts/webkitpy/common/system/executive_mock.py:
32587         (MockExecutive.run_and_throw_if_fail):
32588         (MockExecutive.run_command):
32589         * Scripts/webkitpy/layout_tests/port/webkit.py:
32590         (WebKitPort._driver_build_script_name):
32591         (WebKitPort._run_script):
32592         (WebKitPort._build_driver):
32593         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
32594         (test_build_driver):
32595         * Scripts/webkitpy/tool/commands/download_unittest.py:
32596         * Scripts/webkitpy/tool/steps/build.py:
32597         (Build.build):
32598
32599 2011-11-23  Ojan Vafai  <ojan@chromium.org>
32600
32601         Unreviewed, rolling out r101110.
32602         http://trac.webkit.org/changeset/101110
32603         https://bugs.webkit.org/show_bug.cgi?id=73057
32604
32605         The bots have now cycled and this patch is no longer needed.
32606
32607         * Scripts/webkitpy/layout_tests/controllers/manager.py:
32608         (Manager._upload_json_files):
32609
32610 2011-11-23  Ojan Vafai  <ojan@chromium.org>
32611
32612         Temporarily save the incremental results json in order to identify bug
32613         https://bugs.webkit.org/show_bug.cgi?id=73057
32614
32615         Reviewed by Dean Jackson.
32616
32617         The test results server needed to be rolled back from tip of tree
32618         due to a JSON merging bug. It's hard to identify what the bug is without
32619         the raw data.
32620
32621         * Scripts/webkitpy/layout_tests/controllers/manager.py:
32622         (Manager._upload_json_files):
32623
32624 2011-11-23  Ojan Vafai  <ojan@chromium.org>
32625
32626         Merging two version 4 results hits an error in the test results server
32627         https://bugs.webkit.org/show_bug.cgi?id=73042
32628
32629         Reviewed by Adam Barth.
32630
32631         The old code assumed that if the aggregate results value was not a leaf
32632         value that the incremental results would exist, which is just totally
32633         wrong. Added a test for that case as well.
32634
32635         * TestResultServer/model/jsonresults.py:
32636         (JsonResults._merge_tests):
32637         * TestResultServer/model/jsonresults_unittest.py:
32638         (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
32639         (JsonResultsTest.test_merge_build_directory_hierarchy):
32640
32641 2011-11-23  Eric Seidel  <eric@webkit.org>
32642
32643         Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
32644         https://bugs.webkit.org/show_bug.cgi?id=71983
32645
32646         Reviewed by Adam Barth.
32647
32648         We'll add more code to Environment overtime,
32649         allowing us to mock out more of our direct interactions with os.environ.
32650
32651         This patch also makes run_command print the passed in environment.
32652
32653         * Scripts/webkitpy/common/host_mock.py:
32654         * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32655         * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32656         * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
32657         * Scripts/webkitpy/common/system/executive.py:
32658         * Scripts/webkitpy/common/system/executive_mock.py:
32659         * Scripts/webkitpy/layout_tests/port/webkit.py:
32660         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
32661         * Scripts/webkitpy/tool/commands/download_unittest.py:
32662         * Scripts/webkitpy/tool/steps/build.py:
32663
32664 2011-11-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
32665
32666         [Qt] Re-generate QtWebKit API forwarding headers when API changes
32667
32668         The forwarding headers are generated by syncqt, and syncqt is run by qmake,
32669         so we need sync.profile to live in the same directory as the project file
32670         that will be touched when adding/removing API (api.pri in our case).
32671
32672         Since the WebKit2 APIs live in a separate static library, we have to
32673         add the project file for WebKit2 as a dependency of the api.pri file
32674         as well, so that any changes to the WebKit2 API will still trigger a
32675         run of qmake (and then syncqt).
32676
32677         Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
32678         that the forwarding headers are still generated in the root build dir,
32679         not in the Source dir along with the internal forwarding headers.
32680
32681         Reviewed by Andreas Kling.
32682
32683         * qmake/mkspecs/features/default_pre.prf:
32684         * qmake/mkspecs/features/functions.prf:
32685
32686 2011-11-23  Johnny Ding  <jnd@chromium.org>
32687
32688         Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
32689         https://bugs.webkit.org/show_bug.cgi?id=72950
32690
32691         Reviewed by Tony Chang.
32692
32693         * DumpRenderTree/chromium/LayoutTestController.cpp:
32694         (LayoutTestController::queueLoadHTMLString):
32695
32696 2011-11-23  Adam Barth  <abarth@webkit.org>
32697
32698         garden-o-matic should display a message if it can't find results to display
32699         https://bugs.webkit.org/show_bug.cgi?id=72991
32700
32701         Reviewed by Dimitri Glazkov.
32702
32703         Not all failures (e.g., TIMEOUT) have results that we can display.
32704         This patch adds a short message so that the user can see that we're
32705         done trying to load the results.
32706
32707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
32708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
32709         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
32710
32711 2011-11-23  Adam Barth  <abarth@webkit.org>
32712
32713         garden-o-matic should explain more clearly what the builder lists at the top of the page mean
32714         https://bugs.webkit.org/show_bug.cgi?id=72992
32715
32716         Reviewed by Dimitri Glazkov.
32717
32718         This patch also prepares us to list other sorts of failures, like
32719         performance and unit test.
32720
32721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
32722         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
32723         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
32724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
32725
32726 2011-11-23  Ryan Sleevi  <rsleevi@chromium.org>
32727
32728         Add new Chromium tests to the flakiness dashboard
32729         https://bugs.webkit.org/show_bug.cgi?id=72997
32730
32731         Reviewed by Ojan Vafai.
32732
32733         * TestResultServer/static-dashboards/dashboard_base.js:
32734         ():
32735
32736 2011-11-23  Adam Barth  <abarth@webkit.org>
32737
32738         garden-o-matic should support AUDIO failures
32739         https://bugs.webkit.org/show_bug.cgi?id=69477
32740
32741         Reviewed by Dimitri Glazkov.
32742
32743         This is a first iteration at supporting AUDIO failures in
32744         garden-o-matic.  We'll probably need to iterate a bit when we have a
32745         real audio failure in the tree to play with.  For example, we'll
32746         probably want to add and <audio> element to the "Examine" view to hear
32747         the differences, but that all can be done in a subsequent patch.
32748
32749         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
32750
32751 2011-11-23  Scott Graham  <scottmg@chromium.org>
32752
32753         Adding gamepad support
32754         https://bugs.webkit.org/show_bug.cgi?id=69451
32755
32756         Reviewed by Darin Fisher.
32757
32758         Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
32759         gamepad data that will be retrieved when JS code pulls via API access.
32760
32761         * DumpRenderTree/DumpRenderTree.gypi:
32762         * DumpRenderTree/chromium/GamepadController.cpp: Added.
32763         (GamepadController::GamepadController):
32764         (GamepadController::bindToJavascript):
32765         (GamepadController::reset):
32766         (GamepadController::connect):
32767         (GamepadController::disconnect):
32768         (GamepadController::setId):
32769         (GamepadController::setButtonCount):
32770         (GamepadController::setButtonData):
32771         (GamepadController::setAxisCount):
32772         (GamepadController::setAxisData):
32773         (GamepadController::fallbackCallback):
32774         * DumpRenderTree/chromium/GamepadController.h: Added.
32775         * DumpRenderTree/chromium/TestShell.cpp:
32776         (TestShell::TestShell):
32777         (TestShell::resetTestController):
32778         (TestShell::bindJSObjectsToWindow):
32779         * DumpRenderTree/chromium/TestShell.h:
32780         (TestShell::gamepadController):
32781
32782 2011-11-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
32783
32784         [CMake] Move the top-level logic to the top-level directory.
32785         https://bugs.webkit.org/show_bug.cgi?id=72685
32786
32787         Reviewed by Brent Fulgham.
32788
32789         * CMakeLists.txt: Added.
32790         * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
32791         * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
32792         * Scripts/webkitdirs.pm:
32793         (generateBuildSystemFromCMakeProject):
32794         * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
32795
32796 2011-11-17  Vincent Scheib  <scheib@chromium.org>
32797
32798         Pointer Lock: Initial Tests for navigator.webkitPonter
32799         https://bugs.webkit.org/show_bug.cgi?id=72659
32800
32801         Reviewed by Darin Fisher.
32802
32803         * DumpRenderTree/chromium/TestShell.cpp:
32804         (TestShell::TestShell):
32805             Enabling PointerLock in TestShell
32806
32807 2011-11-22  Ryan Sleevi  <rsleevi@chromium.org>
32808
32809         Update flakiness dashboard for new Chromium builders and tests
32810         https://bugs.webkit.org/show_bug.cgi?id=72931
32811
32812         Reviewed by Ojan Vafai.
32813
32814         * TestResultServer/static-dashboards/builders.js:
32815         * TestResultServer/static-dashboards/dashboard_base.js:
32816
32817 2011-11-22  Adam Roben  <aroben@apple.com>
32818
32819         Remove some debugging code I accidentally left in r101005
32820
32821         * Scripts/prepare-ChangeLog:
32822         (get_function_line_ranges_for_python):
32823
32824 2011-11-22  Adam Roben  <aroben@apple.com>
32825
32826         Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
32827
32828         Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
32829         classes/methods in Python source files
32830
32831         Reviewed by Dan Bates.
32832
32833         * Scripts/prepare-ChangeLog:
32834         (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
32835         or that use python as their interpreter. Modified the code that extracts the interpreter to
32836         ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
32837         scripts.
32838         (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
32839         for class/def lines and generate ranges based on them.
32840
32841 2011-11-21  Yuta Kitamura  <yutak@chromium.org>
32842
32843         [GTK] Enable WebSocket hybi tests
32844         https://bugs.webkit.org/show_bug.cgi?id=72870
32845
32846         Reviewed by Xan Lopez.
32847
32848         * DumpRenderTree/gtk/DumpRenderTree.cpp:
32849         (resetDefaultsToConsistentValues):
32850         Reset the setting value to the default value (true).
32851         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
32852         (LayoutTestController::overridePreference):
32853         Change the setting value through a function in DumpRenderTreeSupportGtk.
32854
32855 2011-11-21  Ryosuke Niwa  <rniwa@webkit.org>
32856
32857         ChangeLogEntry should be able to parse entries with multiple authors
32858         https://bugs.webkit.org/show_bug.cgi?id=72690
32859
32860         Reviewed by Eric Seidel.
32861
32862         Support multi-author change log entries in ChangeLogEntry. Split author names using
32863         the same logic as splitting reviewer names. _authors now stores list of dictionaries
32864         with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
32865         accounts because some contributors are never listed in committers.py.
32866
32867         * Scripts/webkitpy/common/checkout/changelog.py:
32868         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
32869         * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
32870         throws an exception when the argument is None.
32871
32872 2011-11-21  Simon Hausmann  <simon.hausmann@nokia.com>
32873
32874         [Qt] Speed up debug builds.
32875         https://bugs.webkit.org/show_bug.cgi?id=72882
32876
32877         Reviewed by Tor Arne Vestbø.
32878
32879         Introduce a special type of build that replaces the static jsc/wc/wk2
32880         static libraries with shared libraries, that individually are much faster
32881         to link and don't require relinking into the big library when changing just
32882         one file in one module. It can be enabled with
32883         --qmakearg="CONFIG+=force_static_libs_as_shared"
32884
32885         * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
32886         disable symbol visibility, static linkage and enable rpath.
32887         * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
32888         we need to link the convenience libraries together or not and renamed linkStaticLibrary
32889         to just linkLibrary (because linkage is not necessarily static).
32890         * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
32891         link against jsc/wc/wk2 when linking app code against QtWebKit.
32892         * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
32893         function.
32894         * qmake/mkspecs/features/webcore.prf: Ditto.
32895         * qmake/mkspecs/features/webkit2.prf: Ditto.
32896
32897 2011-11-21  Adam Klein  <adamk@chromium.org>
32898
32899         Update flakiness dashboard linkification regexps for crbug.com/100000 and above
32900         https://bugs.webkit.org/show_bug.cgi?id=72898
32901
32902         Reviewed by Ojan Vafai.
32903
32904         Also removed a comment that was going to be more trouble to keep up to
32905         date than seemed worthwhile (the code is now the documentation).
32906
32907         * TestResultServer/static-dashboards/flakiness_dashboard.html:
32908
32909 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
32910
32911         [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
32912         https://bugs.webkit.org/show_bug.cgi?id=72895
32913
32914         Reviewed by Chris Fleizach.
32915
32916         * DumpRenderTree/chromium/WebViewHost.cpp:
32917         (WebViewHost::postAccessibilityNotification):
32918
32919 2011-11-21  Philippe Normand  <pnormand@igalia.com>
32920
32921         Unreviewed, run-gtk-tests temporary workaround after r98500.
32922
32923         * Scripts/run-gtk-tests: Try to find the build directory like in
32924         build-gtkdoc, until webkit-build-directory --configuration gets fixed.
32925
32926 2011-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
32927
32928         [GTK] Add a way to skip unit tests in the bots
32929         https://bugs.webkit.org/show_bug.cgi?id=72879
32930
32931         Reviewed by Philippe Normand.
32932
32933         Rewrite the script in python to make it easier for everybody to
32934         change it and add support for skipping tests.
32935
32936         * Scripts/run-gtk-tests:
32937
32938 2011-11-21  Raphael Kubo da Costa  <kubo@profusion.mobi>
32939
32940         [EFL] Add more appcache functions to ewk_settings.
32941         https://bugs.webkit.org/show_bug.cgi?id=72143
32942
32943         Reviewed by Kenneth Rohde Christiansen.
32944
32945         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
32946         (LayoutTestController::clearAllApplicationCaches):
32947         (LayoutTestController::setAppCacheMaximumSize): Use the right
32948         function, this is not related to the memory cache, but rather to the
32949         appcache.
32950
32951 2011-11-18  Adam Roben  <aroben@apple.com>
32952
32953         Make NRWT consider all lines of output from parse-malloc-history, not just the first
32954
32955         Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
32956         found" even when there are more than 1 unique leaks
32957
32958         Reviewed by Darin Adler.
32959
32960         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
32961         (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
32962         "^" will be considered to match the beginning of any line, not only the beginning of the
32963         string.
32964
32965         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
32966         (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
32967         fake output and updated expectations to match.
32968
32969 2011-11-21  Andras Becsi  <andras.becsi@nokia.com>
32970
32971         [Qt] Clean up MiniBrowser project file after recent changes
32972         https://bugs.webkit.org/show_bug.cgi?id=72869
32973
32974         Reviewed by Simon Hausmann.
32975
32976         Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
32977
32978         * MiniBrowser/qt/MiniBrowser.pro:
32979
32980 2011-11-21  Dominic Mazzoni  <dmazzoni@google.com>
32981
32982         Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
32983         https://bugs.webkit.org/show_bug.cgi?id=72479
32984
32985         Reviewed by Chris Fleizach.
32986
32987         * DumpRenderTree/AccessibilityUIElement.cpp:
32988         (getIsSelectedOptionActiveCallback):
32989         (AccessibilityUIElement::getJSClass):
32990         * DumpRenderTree/AccessibilityUIElement.h:
32991         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
32992         (AccessibilityUIElement::AccessibilityUIElement):
32993         (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
32994         * DumpRenderTree/chromium/AccessibilityUIElement.h:
32995         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
32996         (AccessibilityUIElement::isSelectedOptionActive):
32997         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
32998         (AccessibilityUIElement::isSelectedOptionActive):
32999         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
33000         (AccessibilityUIElement::isSelectedOptionActive):
33001
33002 2011-11-21  Takashi Toyoshima  <toyoshim@chromium.org>
33003
33004         Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
33005         https://bugs.webkit.org/show_bug.cgi?id=72859
33006
33007         Reviewed by Eric Seidel.
33008
33009         * Scripts/new-run-webkit-websocketserver:
33010
33011 2011-11-20  Shinya Kawanaka  <shinyak@google.com>
33012
33013         [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
33014         https://bugs.webkit.org/show_bug.cgi?id=72655
33015
33016         Reviewed by Hajime Morita.
33017
33018         Fixed the calculation of offset.
33019
33020         * DumpRenderTree/chromium/WebViewHost.cpp:
33021         (WebViewHost::finishLastTextCheck):
33022
33023 2011-11-20  Ojan Vafai  <ojan@chromium.org>
33024
33025         Change the final place where we use version 3 of the results json output
33026         https://bugs.webkit.org/show_bug.cgi?id=72838
33027
33028         Reviewed by Adam Barth.
33029
33030         This converts the json from being a flat map of test name --> results
33031         to being hierarchical by directory. This will make the json files
33032         considerably smaller.
33033
33034         Also cleaned up some functions that were returning/checking boolean values
33035         that were always True.
33036
33037         * TestResultServer/model/jsonresults.py:
33038         * TestResultServer/model/jsonresults_unittest.py:
33039
33040 2011-11-20  Ojan Vafai  <ojan@chromium.org>
33041
33042         Include the master name when querying the test results server.
33043         This will soon be required since leaving the master name out mean
33044         that multiple files could match the query.
33045
33046         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
33047
33048 2011-11-19  Ojan Vafai  <ojan@chromium.org>
33049
33050         Fix jsonp callback code to add the callback if json content
33051         is not jsonp.
33052         * TestResultServer/handlers/testfilehandler.py:
33053
33054 2011-11-19  Alice Boxhall  <aboxhall@chromium.org>
33055
33056         Modify dashboard_base.js to optionally accept version 4 results json.
33057
33058         Reviewed by Ojan Vafai.
33059
33060         * TestResultServer/static-dashboards/dashboard_base.js:
33061         (ADD_RESULTS):
33062         (flattenTrie):
33063         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
33064         (testFlattenTrie):
33065
33066 2011-11-19  Ojan Vafai  <ojan@chromium.org>
33067
33068         Stop storing results files as jsonp in the test results server
33069         https://bugs.webkit.org/show_bug.cgi?id=72814
33070
33071         Reviewed by Adam Barth.
33072
33073         * TestResultServer/model/jsonresults.py:
33074         * TestResultServer/model/jsonresults_unittest.py:
33075
33076 2011-11-19  Ojan Vafai  <ojan@chromium.org>
33077
33078         Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
33079         https://bugs.webkit.org/show_bug.cgi?id=72813
33080
33081         Reviewed by Adam Barth.
33082
33083         Once this lands, we can start storing pure json in the test results server and then
33084         we can delete the code with all the FIXMEs added here.
33085
33086         * Scripts/webkitpy/layout_tests/controllers/manager.py:
33087         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
33088         Only add jsonp for full_results.json.
33089         * TestResultServer/model/jsonresults.py:
33090         * TestResultServer/model/jsonresults_unittest.py:
33091         Accept pure json uploads.
33092         * TestResultServer/static-dashboards/dashboard_base.js:
33093         (appendJSONScriptElementFor):
33094         Use the callback parameter so that the server can start returning pure json if it's left out.
33095
33096 2011-11-19  Ojan Vafai  <ojan@chromium.org>
33097
33098         Allow json NRWT downloads to be pure json and not jsonp
33099         https://bugs.webkit.org/show_bug.cgi?id=72809
33100
33101         Reviewed by Adam Barth.
33102
33103         I'm moving the server to storing and serving up raw json instead of jsonp.
33104         You can still get the jsonp by passing a "callback" parameter, but there's no
33105         need for run-webkit-tests to get jsonp when all it wants is the raw json.
33106
33107         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
33108         Make the wrapper stripping only happen if the json is actually wrapped.
33109         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
33110
33111 2011-11-18  Daniel Bates  <dbates@rim.com>
33112
33113         Add CMake build infrastructure for the BlackBerry port
33114         https://bugs.webkit.org/show_bug.cgi?id=72768
33115
33116         Reviewed by Antonio Gomes.
33117
33118         Add optional --blackberry command line argument to build-webkit to build the
33119         BlackBerry port.
33120
33121         * Scripts/build-webkit:
33122         * Scripts/webkitdirs.pm:
33123         (determineBaseProductDir):
33124         (argumentsForConfiguration):
33125         (builtDylibPathForName):
33126         (determineIsQt):
33127         (isBlackBerry): Added.
33128         (determineIsBlackBerry): Added.
33129         (blackberryTargetArchitecture): Added.
33130         (isAppleWebKit):
33131
33132 2011-11-18  James Robinson  <jamesr@chromium.org>
33133
33134         Unreviewed, rolling out r100835.
33135         http://trac.webkit.org/changeset/100835
33136         https://bugs.webkit.org/show_bug.cgi?id=72778
33137
33138         Broke some page scale tests
33139
33140         * DumpRenderTree/chromium/EventSender.cpp:
33141         (EventSender::scalePageBy):
33142
33143 2011-11-18  Adam Barth  <abarth@webkit.org>
33144
33145         Prepare to move manual-tests out of WebCore
33146         https://bugs.webkit.org/show_bug.cgi?id=72782
33147
33148         Reviewed by Eric Seidel.
33149
33150         Update this file to refer to the new location of ManualTests.
33151
33152         * Scripts/webkitpy/common/config/build.py:
33153
33154 2011-11-18  James Robinson  <jamesr@chromium.org>
33155
33156         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
33157         https://bugs.webkit.org/show_bug.cgi?id=72778
33158
33159         Reviewed by Kenneth Russell.
33160
33161         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
33162
33163         * DumpRenderTree/chromium/EventSender.cpp:
33164         (EventSender::scalePageBy):
33165
33166 2011-11-18  Scott Graham  <scottmg@chromium.org>
33167
33168         IDL changes for gamepad support
33169         https://bugs.webkit.org/show_bug.cgi?id=71753
33170
33171         Reviewed by Adam Barth.
33172
33173         Runtime enable gamepad in chromium test shell.
33174
33175         * DumpRenderTree/chromium/TestShell.cpp:
33176         (TestShell::TestShell):
33177
33178 2011-10-27  Darin Fisher  <darin@chromium.org>
33179
33180         [chromium] Improve fullscreen API
33181         https://bugs.webkit.org/show_bug.cgi?id=70477
33182
33183         Reviewed by Adam Barth.
33184
33185         Implement enter/exitFullScreen.  The implementation is asynchronous,
33186         via postDelayedTask, to simulate how the browser actually behaves.
33187
33188         * DumpRenderTree/chromium/WebViewHost.cpp:
33189         (WebViewHost::enterFullScreen):
33190         (WebViewHost::exitFullScreen):
33191         (WebViewHost::setAddressBarURL):
33192         (WebViewHost::enterFullScreenNow):
33193         (WebViewHost::exitFullScreenNow):
33194         * DumpRenderTree/chromium/WebViewHost.h:
33195
33196 2011-11-18  Adam Roben  <aroben@apple.com>
33197
33198         Ignore an ANGLE leak that is not WebKit's fault
33199
33200         * Scripts/old-run-webkit-tests:
33201         (countAndPrintLeaks):
33202         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
33203         (LeakDetector._callstacks_to_exclude_from_leaks):
33204         Added ScanFromString to the call stacks to exclude on all OS versions.
33205
33206 2011-11-18  Adam Roben  <aroben@apple.com>
33207
33208         Ignore another Lion-specific leak that is not WebKit's fault
33209
33210         * Scripts/old-run-webkit-tests:
33211         (countAndPrintLeaks):
33212         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
33213         (LeakDetector._callstacks_to_exclude_from_leaks):
33214         Added SecTransformExecute to the call stacks to exclude.
33215
33216 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
33217
33218         [Qt] Enable WebSocket hybi tests
33219         https://bugs.webkit.org/show_bug.cgi?id=72687
33220
33221         Reviewed by Simon Hausmann.
33222
33223         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
33224
33225         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
33226         (WebCore::WebPage::resetSettings):
33227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
33228         (LayoutTestController::overridePreference):
33229
33230 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
33231
33232         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
33233         https://bugs.webkit.org/show_bug.cgi?id=72707
33234
33235         Reviewed by Philippe Normand.
33236
33237         Make new-run-webkit-tests use the right path to locate the test
33238         plugin used by WebKitTestRunner.
33239
33240         * Scripts/webkitpy/layout_tests/port/gtk.py:
33241
33242 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
33243
33244         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
33245         https://bugs.webkit.org/show_bug.cgi?id=72697
33246
33247         Reviewed by Kenneth Rohde Christiansen.
33248
33249         * Tools.pro: Make WTR linux only for the moment.
33250         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
33251         * WebKitTestRunner/Target.pri: Ditto.
33252         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
33253         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
33254
33255 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
33256
33257         [Qt] Change default size of the MiniBrowser
33258
33259         Reviewed by Simon Hausmann.
33260
33261         As we lay out desktop pages using the width of 980, change our default
33262         size to 980x735 so that we are not scaling down by default.
33263
33264         * MiniBrowser/qt/MiniBrowserApplication.h:
33265         (WindowOptions::WindowOptions):
33266
33267 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
33268
33269         [EFL] Clean up the use of DATA_DIR in the buildsystem
33270         https://bugs.webkit.org/show_bug.cgi?id=72681
33271
33272         Reviewed by Daniel Bates.
33273
33274         Instead of adding -DDATA_DIR in all scopes, only define it in
33275         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
33276         it.
33277
33278         We can then define DATA_DIR to the generated theme directory for
33279         EWebLauncher, since it's what we want here.
33280
33281         * CMakeListsEfl.txt:
33282
33283 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
33284
33285         [EFL] Move platform includes last in DRT's include directories.
33286         https://bugs.webkit.org/show_bug.cgi?id=72684
33287
33288         Reviewed by Daniel Bates.
33289
33290         This is the first step in fixing the build when a platform include (in
33291         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
33292         is included instead of WebKit's.
33293
33294         * DumpRenderTree/efl/CMakeLists.txt:
33295
33296 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
33297
33298         fuzzy_match doesn't recognize "Dan B" or "hyatt"
33299         https://bugs.webkit.org/show_bug.cgi?id=72636
33300
33301         Reviewed by Eric Seidel.
33302
33303         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
33304         and user names of email addreses such as rniwa in rniwa@webkit.org.
33305
33306         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
33307
33308         * Scripts/webkitpy/common/config/committers.py:
33309         * Scripts/webkitpy/common/config/committers_unittest.py:
33310
33311 2011-11-17  Eric Seidel  <eric@webkit.org>
33312
33313         Remove support for running check-webkit-style w/o a webkit checkout
33314         https://bugs.webkit.org/show_bug.cgi?id=72678
33315
33316         Reviewed by Adam Barth.
33317
33318         After talking to Dave Levin we've decided to remove this
33319         code.  I know of no users of check-webkit-style w/o a webkit checkout
33320         and this needlessly adds complexity.
33321
33322         * Scripts/webkitpy/style/main.py:
33323
33324 2011-11-17  Eric Seidel  <eric@webkit.org>
33325
33326         Remove more direct uses of os.path
33327         https://bugs.webkit.org/show_bug.cgi?id=72677
33328
33329         Reviewed by Adam Barth.
33330
33331         Remove more uses of os.path, including refactoring
33332         CommitterValidator to use a Host object instead of
33333         manual hacks to emulate what SCM and FileSystem provide.
33334
33335         * Scripts/webkitpy/common/checkout/changelog.py:
33336         * Scripts/webkitpy/common/config/committervalidator.py:
33337         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
33338         * Scripts/webkitpy/common/system/filesystem_mock.py:
33339          - Turns out none of our unittests actually looked at this path.
33340            now I've made it be a valid path.
33341         * Scripts/webkitpy/tool/bot/feeders.py:
33342         * Scripts/webkitpy/tool/commands/queues.py:
33343
33344 2011-11-17  Eric Seidel  <eric@webkit.org>
33345
33346         Teach TextFileReader about FileSystem
33347         https://bugs.webkit.org/show_bug.cgi?id=72673
33348
33349         Reviewed by Adam Barth.
33350
33351         Unfortunately TextFileReader doesn't use FileSystem
33352         everywhere yet, so we can't move the unittests to
33353         using MockFileSystem, but we're close.
33354
33355         * Scripts/webkitpy/style/filereader.py:
33356         * Scripts/webkitpy/style/filereader_unittest.py:
33357         * Scripts/webkitpy/style/main.py:
33358
33359 2011-11-17  Eric Seidel  <eric@webkit.org>
33360
33361         Give check-webkit-style a Host
33362         https://bugs.webkit.org/show_bug.cgi?id=72670
33363
33364         Reviewed by Adam Barth.
33365
33366         * Scripts/webkitpy/common/checkout/scm/detection.py:
33367         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
33368          - We don't run these unittests, but this one was looking for the wrong exception.
33369         * Scripts/webkitpy/style/main.py:
33370         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
33371          - This was create a new scm object even though it already had one?
33372
33373 2011-11-17  Eric Seidel  <eric@webkit.org>
33374
33375         Move check-webkit-style change_directory code to more modern mocks
33376         https://bugs.webkit.org/show_bug.cgi?id=72664
33377
33378         Reviewed by Adam Barth.
33379
33380         * Scripts/check-webkit-style:
33381         * Scripts/webkitpy/style/main.py:
33382         * Scripts/webkitpy/style/main_unittest.py:
33383
33384 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
33385
33386         [GTK] enable ref tests
33387         https://bugs.webkit.org/show_bug.cgi?id=72601
33388
33389         Re-enable ref tests. Run the driver under evenly numbered display if performing
33390         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
33391         being run in an already used Xvfb instance if pixel tests are disabled.
33392
33393         Reviewed by Tony Chang.
33394
33395         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
33396         after the process is killed
33397
33398 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
33399
33400         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
33401         https://bugs.webkit.org/show_bug.cgi?id=72620
33402
33403         Reviewed by David Levin.
33404
33405         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
33406         adding the suffix the cpp file. One example of false positive
33407         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
33408
33409         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
33410         basename contains the cpp's basename.
33411         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
33412
33413 2011-11-17  Eric Seidel  <eric@webkit.org>
33414
33415         Move check-webkit-style's guts into webkitpy/style/main.py
33416         https://bugs.webkit.org/show_bug.cgi?id=72657
33417
33418         Reviewed by Adam Barth.
33419
33420         * Scripts/check-webkit-style:
33421         * Scripts/webkitpy/style/main.py:
33422
33423 2011-11-17  Eric Seidel  <eric@webkit.org>
33424
33425         new-run-webkit-tests is locale dependent
33426         https://bugs.webkit.org/show_bug.cgi?id=68691
33427
33428         Reviewed by Adam Barth.
33429
33430         Make NRWT use a clean environment, just like ORWT did.
33431
33432         * Scripts/webkitpy/layout_tests/port/base.py:
33433         * Scripts/webkitpy/layout_tests/port/chromium.py:
33434         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
33435         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
33436         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
33437         * Scripts/webkitpy/layout_tests/port/efl.py:
33438         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
33439         * Scripts/webkitpy/layout_tests/port/mac.py:
33440         * Scripts/webkitpy/layout_tests/port/qt.py:
33441         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
33442         * Scripts/webkitpy/layout_tests/port/webkit.py:
33443         * Scripts/webkitpy/layout_tests/port/win.py:
33444
33445 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
33446
33447         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
33448         https://bugs.webkit.org/show_bug.cgi?id=72615
33449
33450         Reviewed by James Robinson.
33451
33452         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
33453
33454 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
33455
33456         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
33457         https://bugs.webkit.org/show_bug.cgi?id=72595
33458
33459         Reviewed by Noam Rosenthal.
33460
33461         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
33462         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
33463         ensure the registration of the DRTNode JS bindings.
33464         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
33465         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
33466         registration of QWebElement (now done implicitly through QWebPage ->
33467         QtWebElementRunTime::initialize code path)
33468
33469 2011-11-17  Adam Roben  <aroben@apple.com>
33470
33471         Fix a crash-inducing typo I introduced in r100648
33472
33473         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
33474         handling a crashing test
33475
33476         Reviewed by Adam Barth.
33477
33478         * Scripts/webkitpy/layout_tests/port/chromium.py:
33479         (ChromiumDriver.run_test): Get the driver name from the port.
33480
33481         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
33482         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
33483         right crashed process name.
33484
33485 2011-11-17  Adam Roben  <aroben@apple.com>
33486
33487         Fix NRWT's parsing of the number of excluded leaks
33488
33489         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
33490         leaks were excluded
33491
33492         Reviewed by Adam Barth.
33493
33494         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
33495         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
33496         regular expression match, not the entire matched string.
33497
33498         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
33499         (LeakDetectorTest): Added some example output that shows how things look when leaks are
33500         excluded.
33501         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
33502         correctly.
33503
33504 2011-11-17  Adam Roben  <aroben@apple.com>
33505
33506         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
33507
33508         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
33509         when web process crashes, but WebProcess crash log should get saved instead
33510
33511         Reviewed by Eric Seidel.
33512
33513         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
33514         (write_test_result): Simplified a little to share more code between the case where we
33515         crashed when running the test and where we crashed when checking the expected rendering for
33516         a reftest. Changed to pass the crashed process name down to write_crash_report.
33517         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
33518         along to CrashLogs.find_newest_log rather than always using the driver name.
33519
33520         * Scripts/webkitpy/layout_tests/port/chromium.py:
33521         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
33522         crashed.
33523
33524         * Scripts/webkitpy/layout_tests/port/test.py:
33525         (TestInstance.__init__): Initialize new web_process_crash attribute.
33526         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
33527         test this patch adds.
33528         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
33529         specifies that the driver crashed or the web process crashed.
33530
33531         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
33532         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
33533         which we pretend the web process crashed rather than the driver process.
33534
33535         (MainTest.test_run_singly_actually_runs_tests):
33536         (MainTest.test_unexpected_failures):
33537         (EndToEndTest.test_end_to_end):
33538         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
33539
33540 2011-11-17  Tony Chang  <tony@chromium.org>
33541
33542         [chromium] stop spamming features warning on every build
33543         https://bugs.webkit.org/show_bug.cgi?id=72629
33544
33545         Reviewed by Ojan Vafai.
33546
33547         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
33548         $mediaStreamSupport is on by default for chromium, make the default
33549         for $blobSupport also on.
33550
33551         * Scripts/build-webkit:
33552
33553 2011-11-17  Adam Roben  <aroben@apple.com>
33554
33555         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
33556
33557         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
33558         that are supposed to be ignored
33559
33560         Reviewed by Adam Barth.
33561
33562         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
33563         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
33564         required when passing arguments via the shell (which we aren't doing here). It is not
33565         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
33566
33567         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
33568         (LeakDetectorTest.test_leaks_args): Updated expectations.
33569
33570 2011-11-17  Philippe Normand  <pnormand@igalia.com>
33571
33572         Unreviewed, run-bindings-tests fix after r91028.
33573
33574         * Scripts/run-bindings-tests: Use scm.detection module.
33575
33576 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
33577
33578         Silence a warning about control reaching the end of a non-void function
33579         https://bugs.webkit.org/show_bug.cgi?id=72616
33580
33581         Reviewed by Tony Gentilcore.
33582
33583         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
33584         (AccessibilityUIElement::verticalScrollbar):
33585
33586 2011-11-17  Adam Roben  <aroben@apple.com>
33587
33588         Ignore some leaks in frameworks we link against on Lion
33589
33590         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
33591         aren't WebKit's fault
33592
33593         Reviewed by Antti Koivisto.
33594
33595         * Scripts/old-run-webkit-tests:
33596         (countAndPrintLeaks):
33597         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
33598         (LeakDetector._callstacks_to_exclude_from_leaks):
33599         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
33600
33601         * Scripts/webkitpy/layout_tests/port/mac.py:
33602         (MacPort.is_lion): Added.
33603
33604         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
33605         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
33606         methods.
33607
33608 2011-11-17  Philippe Normand  <pnormand@igalia.com>
33609
33610         [GTK] Disable ref tests
33611         https://bugs.webkit.org/show_bug.cgi?id=72599
33612
33613         Reviewed by Xan Lopez.
33614
33615         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
33616         tests to avoid massive flakiness.
33617
33618 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
33619
33620         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
33621
33622         A new extension object has been added to QQuickWebView (the same approach should be used
33623         for other API classes that need experimental APIs). The QML extension mechanism is then
33624         built on top of the experimental object.
33625
33626         https://bugs.webkit.org/show_bug.cgi?id=72522
33627
33628         Reviewed by Simon Hausmann.
33629
33630         * MiniBrowser/qt/BrowserWindow.cpp:
33631         (BrowserWindow::BrowserWindow):
33632         (BrowserWindow::webView):
33633         * MiniBrowser/qt/BrowserWindow.h:
33634         * MiniBrowser/qt/UrlLoader.cpp:
33635         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
33636         * qmake/mkspecs/features/default_post.prf:
33637         * qmake/mkspecs/features/default_pre.prf:
33638         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
33639         * qmake/mkspecs/features/qtwebkit.prf:
33640
33641 2011-11-17  Adam Barth  <abarth@webkit.org>
33642
33643         Move test_results_uploader.py out of layout_package
33644         https://bugs.webkit.org/show_bug.cgi?id=72590
33645
33646         Reviewed by Eric Seidel.
33647
33648         Most of the lines of code in this file are wrong, but I've restrained
33649         myself and only changed a few of them to generalized this class to the
33650         common package.
33651
33652         This is part of a series of patches to remove layout_package.
33653
33654         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
33655         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
33656         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
33657
33658 2011-11-17  Adam Barth  <abarth@webkit.org>
33659
33660         Unreviewed. Fix style nits in printing.py.
33661
33662         * Scripts/webkitpy/layout_tests/views/printing.py:
33663
33664 2011-11-17  Adam Barth  <abarth@webkit.org>
33665
33666         Minor style nits in run_webkit_tests.py
33667         https://bugs.webkit.org/show_bug.cgi?id=72583
33668
33669         Reviewed by Eric Seidel.
33670
33671         This patch just fixes some minor style issues as I work my way back
33672         into this code.
33673
33674         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
33675
33676 2011-11-17  Adam Barth  <abarth@webkit.org>
33677
33678         Move test_result_writer out of layout_package
33679         https://bugs.webkit.org/show_bug.cgi?id=72586
33680
33681         Rubber-stamped by Eric Seidel.
33682
33683         This is part of a series of patches to remove layout_package.
33684
33685         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
33686         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
33687         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
33688         * Scripts/webkitpy/tool/commands/rebaseline.py:
33689
33690 2011-11-17  Adam Barth  <abarth@webkit.org>
33691
33692         svn-apply shouldn't magically move files into Source anymore
33693         https://bugs.webkit.org/show_bug.cgi?id=72579
33694
33695         Reviewed by Eric Seidel.
33696
33697         The Source directory has existed for long enough that we don't need
33698         svn-apply to magically re-write old-style patches anymore.
33699
33700         * Scripts/VCSUtils.pm:
33701         (parseGitDiffHeader):
33702         (parseSvnDiffHeader):
33703
33704 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
33705
33706         Add a list of contribution areas
33707         https://bugs.webkit.org/show_bug.cgi?id=72566
33708
33709         Reviewed by Eric Seidel.
33710
33711         Added ContributionAreas class.
33712
33713         * Scripts/webkitpy/common/config/contributionareas.py: Added.
33714         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
33715
33716 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
33717
33718         Refactor ChangeLogTest.test_parse_reviewer_text
33719         https://bugs.webkit.org/show_bug.cgi?id=72572
33720
33721         Reviewed by Eric Seidel.
33722
33723         Refactored the test code by introduing two helper functions.
33724
33725         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
33726
33727 2011-11-16  Eric Seidel  <eric@webkit.org>
33728
33729         Add SCMDetector object to make scm detection mockable
33730         https://bugs.webkit.org/show_bug.cgi?id=72247
33731
33732         Reviewed by Adam Barth.
33733
33734         I think SCM detection may eventually be rolled into Checkout,
33735         but this patch at least makes it possible to mock code-paths
33736         which rely on scm detection.
33737         In the process of replacing callers of these free-functions
33738         I found that one of the functions was no longer used,
33739         and that one of the callers could instead just use the SCM
33740         object it already had access to through port.host.scm().
33741         I also discovered that I was not calling Host._initialize_scm()
33742         and thus host.scm() was always returning None!
33743
33744         * Scripts/check-webkit-style:
33745         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
33746         * Scripts/webkitpy/common/checkout/deps.py:
33747         * Scripts/webkitpy/common/checkout/scm/__init__.py:
33748         * Scripts/webkitpy/common/checkout/scm/detection.py:
33749         * Scripts/webkitpy/common/checkout/scm/git.py:
33750         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
33751         * Scripts/webkitpy/common/checkout/scm/svn.py:
33752         * Scripts/webkitpy/common/host.py:
33753         * Scripts/webkitpy/common/host_mock.py:
33754         * Scripts/webkitpy/layout_tests/controllers/manager.py:
33755         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
33756         * Scripts/webkitpy/layout_tests/port/base.py:
33757         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
33758         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
33759         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
33760         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
33761
33762 2011-11-16  Mark Rowe  <mrowe@apple.com>
33763
33764         Fix the build.
33765
33766         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
33767         Apply the workaround that we use in other projects to WebKitTestRunner.
33768
33769         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
33770         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
33771         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
33772
33773 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
33774
33775         [Qt] Fix build after WTR AX support
33776         https://bugs.webkit.org/show_bug.cgi?id=72560
33777
33778         Reviewed by Geoffrey Garen.
33779
33780         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
33781         * WebKitTestRunner/InjectedBundle/Target.pri:
33782
33783 2011-11-16  Tony Chang  <tony@chromium.org>
33784
33785         repurpose the flexbox bot for grid layout
33786         https://bugs.webkit.org/show_bug.cgi?id=72557
33787
33788         Reviewed by Ryosuke Niwa.
33789
33790         Since new flexbox is enabled everywhere, we don't need this bot
33791         anymore.  However, work on grid layout has begun, so we can use this
33792         bot to compile with ENABLE_CSS_GRID_LAYOUT.
33793
33794         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
33795         the bot on the waterfall, I will change the slave config to enable
33796         the compile flag and tests.
33797
33798 2011-11-11  Adrienne Walker  <enne@google.com>
33799
33800         [chromium] Expose mock scrollbars to window.internals
33801         https://bugs.webkit.org/show_bug.cgi?id=72195
33802
33803         Reviewed by James Robinson.
33804
33805         Because mock scrollbars are a global setting, reset between runs.
33806
33807         * DumpRenderTree/chromium/WebPreferences.cpp:
33808         (WebPreferences::applyTo):
33809
33810 2011-11-16  James Robinson  <jamesr@chromium.org>
33811
33812         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
33813         https://bugs.webkit.org/show_bug.cgi?id=72562
33814
33815         Reviewed by Dirk Pranke.
33816
33817         * DumpRenderTree/chromium/TestShell.cpp:
33818         (TestShell::runFileTest):
33819
33820 2011-11-16  Tony Chang  <tony@chromium.org>
33821
33822         [NRWT] speculative fix for multiple subprocess test on cygwin
33823         https://bugs.webkit.org/show_bug.cgi?id=72518
33824
33825         Reviewed by Adam Barth.
33826
33827         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
33828             tries to emulate posix fd behavior.
33829         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
33830
33831 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
33832
33833         Revert r100509; change was committed twice (first time as r100491).
33834         Unreviewed, build fix.
33835
33836         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
33837
33838 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
33839
33840         Run a dummy test in the gpu configurations if there's nothing to do.
33841         https://bugs.webkit.org/show_bug.cgi?id=72498
33842
33843         Reviewed by James Robinson.
33844
33845         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
33846
33847 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
33848
33849         contributors_by_fuzzy_match is super slow
33850         https://bugs.webkit.org/show_bug.cgi?id=72540
33851
33852         Reviewed by Eric Seidel.
33853
33854         Make contributors_by_name do case insensitive search using a dictionary.
33855
33856         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
33857         because that's the most common case.
33858
33859         * Scripts/webkitpy/common/config/committers.py:
33860         * Scripts/webkitpy/common/config/committers_unittest.py:
33861
33862 2011-11-16  David Levin  <levin@chromium.org>
33863
33864         check-webkit-style should recognize functions even if they have OVERRIDE after them.
33865         https://bugs.webkit.org/show_bug.cgi?id=72515
33866
33867         Reviewed by Adam Barth.
33868
33869         * Scripts/webkitpy/style/checkers/cpp.py:
33870         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
33871
33872 2011-11-16  Tony Chang  <tony@chromium.org>
33873
33874         [NRWT] refactor drivers to require pixel_tests param
33875         https://bugs.webkit.org/show_bug.cgi?id=72517
33876
33877         Reviewed by Ojan Vafai.
33878
33879         No tests, just a refactoring.
33880
33881         * Scripts/webkitpy/layout_tests/port/chromium.py:
33882         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
33883         * Scripts/webkitpy/layout_tests/port/webkit.py:
33884         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
33885
33886 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
33887
33888         Run a dummy test in the gpu configurations if there's nothing to do.
33889         https://bugs.webkit.org/show_bug.cgi?id=72498
33890
33891         Reviewed by James Robinson.
33892
33893         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
33894
33895 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
33896
33897         WebKitTestRunner needs to support accessibility-related DRT APIs
33898         https://bugs.webkit.org/show_bug.cgi?id=42131
33899
33900         Reviewed by Beth Dakin.
33901
33902         Port the AX code in DRT to WKTestRunner by using IDL.
33903
33904         * DumpRenderTree/AccessibilityUIElement.cpp:
33905         (horizontalScrollbarCallback):
33906         (verticalScrollbarCallback):
33907         (AccessibilityUIElement::horizontalScrollbar):
33908         (AccessibilityUIElement::verticalScrollbar):
33909         (AccessibilityUIElement::getJSClass):
33910         * DumpRenderTree/AccessibilityUIElement.h:
33911         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
33912         (AccessibilityUIElement::horizontalScrollbar):
33913         (AccessibilityUIElement::verticalScrollbar):
33914         * WebKitTestRunner/DerivedSources.make:
33915         * WebKitTestRunner/GNUmakefile.am:
33916         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
33917         (WTR::AccessibilityController::create):
33918         (WTR::AccessibilityController::AccessibilityController):
33919         (WTR::AccessibilityController::~AccessibilityController):
33920         (WTR::AccessibilityController::makeWindowObject):
33921         (WTR::AccessibilityController::wrapperClass):
33922         (WTR::AccessibilityController::rootElement):
33923         (WTR::AccessibilityController::focusedElement):
33924         (WTR::AccessibilityController::elementAtPoint):
33925         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
33926         (WTR::AccessibilityController::logFocusEvents):
33927         (WTR::AccessibilityController::logValueChangeEvents):
33928         (WTR::AccessibilityController::logScrollingStartEvents):
33929         (WTR::AccessibilityController::logAccessibilityEvents):
33930         (WTR::AccessibilityController::addNotificationListener):
33931         (WTR::AccessibilityController::notificationReceived):
33932         (WTR::AccessibilityController::resetToConsistentState):
33933         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
33934         (WTR::AccessibilityTextMarker::create):
33935         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
33936         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
33937         (WTR::AccessibilityTextMarker::platformTextMarker):
33938         (WTR::AccessibilityTextMarker::wrapperClass):
33939         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
33940         (WTR::AccessibilityTextMarker::isEqual):
33941         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
33942         (WTR::AccessibilityTextMarkerRange::create):
33943         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
33944         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
33945         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
33946         (WTR::AccessibilityTextMarkerRange::wrapperClass):
33947         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
33948         (WTR::AccessibilityTextMarkerRange::isEqual):
33949         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
33950         (WTR::AccessibilityUIElement::create):
33951         (WTR::AccessibilityUIElement::wrapperClass):
33952         (WTR::AccessibilityUIElement::isValid):
33953         (WTR::AccessibilityUIElement::AccessibilityUIElement):
33954         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
33955         (WTR::AccessibilityUIElement::isEqual):
33956         (WTR::AccessibilityUIElement::elementAtPoint):
33957         (WTR::AccessibilityUIElement::childAtIndex):
33958         (WTR::AccessibilityUIElement::indexOfChild):
33959         (WTR::AccessibilityUIElement::childrenCount):
33960         (WTR::AccessibilityUIElement::titleUIElement):
33961         (WTR::AccessibilityUIElement::parentElement):
33962         (WTR::AccessibilityUIElement::takeFocus):
33963         (WTR::AccessibilityUIElement::takeSelection):
33964         (WTR::AccessibilityUIElement::addSelection):
33965         (WTR::AccessibilityUIElement::removeSelection):
33966         (WTR::AccessibilityUIElement::allAttributes):
33967         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
33968         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
33969         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
33970         (WTR::AccessibilityUIElement::attributesOfChildren):
33971         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
33972         (WTR::AccessibilityUIElement::increment):
33973         (WTR::AccessibilityUIElement::decrement):
33974         (WTR::AccessibilityUIElement::showMenu):
33975         (WTR::AccessibilityUIElement::press):
33976         (WTR::AccessibilityUIElement::stringAttributeValue):
33977         (WTR::AccessibilityUIElement::uiElementAttributeValue):
33978         (WTR::AccessibilityUIElement::numberAttributeValue):
33979         (WTR::AccessibilityUIElement::boolAttributeValue):
33980         (WTR::AccessibilityUIElement::isAttributeSupported):
33981         (WTR::AccessibilityUIElement::isAttributeSettable):
33982         (WTR::AccessibilityUIElement::isActionSupported):
33983         (WTR::AccessibilityUIElement::role):
33984         (WTR::AccessibilityUIElement::subrole):
33985         (WTR::AccessibilityUIElement::roleDescription):
33986         (WTR::AccessibilityUIElement::title):
33987         (WTR::AccessibilityUIElement::description):
33988         (WTR::AccessibilityUIElement::language):
33989         (WTR::AccessibilityUIElement::stringValue):
33990         (WTR::AccessibilityUIElement::accessibilityValue):
33991         (WTR::AccessibilityUIElement::helpText):
33992         (WTR::AccessibilityUIElement::orientation):
33993         (WTR::AccessibilityUIElement::x):
33994         (WTR::AccessibilityUIElement::y):
33995         (WTR::AccessibilityUIElement::width):
33996         (WTR::AccessibilityUIElement::height):
33997         (WTR::AccessibilityUIElement::intValue):
33998         (WTR::AccessibilityUIElement::minValue):
33999         (WTR::AccessibilityUIElement::maxValue):
34000         (WTR::AccessibilityUIElement::valueDescription):
34001         (WTR::AccessibilityUIElement::insertionPointLineNumber):
34002         (WTR::AccessibilityUIElement::selectedTextRange):
34003         (WTR::AccessibilityUIElement::isEnabled):
34004         (WTR::AccessibilityUIElement::isRequired):
34005         (WTR::AccessibilityUIElement::isFocused):
34006         (WTR::AccessibilityUIElement::isFocusable):
34007         (WTR::AccessibilityUIElement::isSelected):
34008         (WTR::AccessibilityUIElement::isSelectable):
34009         (WTR::AccessibilityUIElement::isMultiSelectable):
34010         (WTR::AccessibilityUIElement::setSelectedChild):
34011         (WTR::AccessibilityUIElement::selectedChildrenCount):
34012         (WTR::AccessibilityUIElement::selectedChildAtIndex):
34013         (WTR::AccessibilityUIElement::isExpanded):
34014         (WTR::AccessibilityUIElement::isChecked):
34015         (WTR::AccessibilityUIElement::isVisible):
34016         (WTR::AccessibilityUIElement::isOffScreen):
34017         (WTR::AccessibilityUIElement::isCollapsed):
34018         (WTR::AccessibilityUIElement::isIgnored):
34019         (WTR::AccessibilityUIElement::hasPopup):
34020         (WTR::AccessibilityUIElement::hierarchicalLevel):
34021         (WTR::AccessibilityUIElement::clickPointX):
34022         (WTR::AccessibilityUIElement::clickPointY):
34023         (WTR::AccessibilityUIElement::documentEncoding):
34024         (WTR::AccessibilityUIElement::documentURI):
34025         (WTR::AccessibilityUIElement::url):
34026         (WTR::AccessibilityUIElement::speak):
34027         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
34028         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
34029         (WTR::AccessibilityUIElement::attributesOfColumns):
34030         (WTR::AccessibilityUIElement::attributesOfRows):
34031         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
34032         (WTR::AccessibilityUIElement::attributesOfHeader):
34033         (WTR::AccessibilityUIElement::indexInTable):
34034         (WTR::AccessibilityUIElement::rowIndexRange):
34035         (WTR::AccessibilityUIElement::columnIndexRange):
34036         (WTR::AccessibilityUIElement::rowCount):
34037         (WTR::AccessibilityUIElement::columnCount):
34038         (WTR::AccessibilityUIElement::selectedRowAtIndex):
34039         (WTR::AccessibilityUIElement::disclosedByRow):
34040         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
34041         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
34042         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
34043         (WTR::AccessibilityUIElement::ariaIsGrabbed):
34044         (WTR::AccessibilityUIElement::ariaDropEffects):
34045         (WTR::AccessibilityUIElement::lineForIndex):
34046         (WTR::AccessibilityUIElement::rangeForLine):
34047         (WTR::AccessibilityUIElement::boundsForRange):
34048         (WTR::AccessibilityUIElement::setSelectedTextRange):
34049         (WTR::AccessibilityUIElement::stringForRange):
34050         (WTR::AccessibilityUIElement::attributedStringForRange):
34051         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
34052         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
34053         (WTR::AccessibilityUIElement::cellForColumnAndRow):
34054         (WTR::AccessibilityUIElement::horizontalScrollbar):
34055         (WTR::AccessibilityUIElement::verticalScrollbar):
34056         (WTR::AccessibilityUIElement::addNotificationListener):
34057         (WTR::AccessibilityUIElement::removeNotificationListener):
34058         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
34059         (WTR::AccessibilityUIElement::textMarkerRangeLength):
34060         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
34061         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
34062         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
34063         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
34064         (WTR::AccessibilityUIElement::textMarkerForPoint):
34065         (WTR::AccessibilityUIElement::previousTextMarker):
34066         (WTR::AccessibilityUIElement::nextTextMarker):
34067         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
34068         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
34069         (WTR::AccessibilityUIElement::platformUIElement):
34070         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
34071         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
34072         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
34073         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
34074         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
34075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
34076         (WTR::InjectedBundle::beginTesting):
34077         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
34078         (WTR::InjectedBundle::accessibilityController):
34079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
34080         (WTR::InjectedBundlePage::didClearWindowForFrame):
34081         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
34082         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
34083         (WTR::LayoutTestController::platformName):
34084         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
34085         (WTR::AccessibilityTextMarker::isEqual):
34086         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
34087         (WTR::AccessibilityTextMarkerRange::isEqual):
34088         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
34089         (+[NSString stringWithJSStringRef:]):
34090         (-[NSString createJSStringRef]):
34091         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
34092         (-[AccessibilityNotificationHandler dealloc]):
34093         (-[AccessibilityNotificationHandler _notificationReceived:]):
34094         (-[AccessibilityNotificationHandler setCallback:]):
34095         (WTR::AccessibilityUIElement::AccessibilityUIElement):
34096         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
34097         (WTR::AccessibilityUIElement::isEqual):
34098         (WTR::descriptionOfValue):
34099         (WTR::attributesOfElement):
34100         (WTR::concatenateAttributeAndValue):
34101         (WTR::convertNSArrayToVector):
34102         (WTR::descriptionOfElements):
34103         (WTR::AccessibilityUIElement::getLinkedUIElements):
34104         (WTR::AccessibilityUIElement::getDocumentLinks):
34105         (WTR::AccessibilityUIElement::getChildren):
34106         (WTR::AccessibilityUIElement::getChildrenWithRange):
34107         (WTR::AccessibilityUIElement::childrenCount):
34108         (WTR::AccessibilityUIElement::elementAtPoint):
34109         (WTR::AccessibilityUIElement::indexOfChild):
34110         (WTR::AccessibilityUIElement::childAtIndex):
34111         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
34112         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
34113         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
34114         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
34115         (WTR::AccessibilityUIElement::selectedChildAtIndex):
34116         (WTR::AccessibilityUIElement::selectedChildrenCount):
34117         (WTR::AccessibilityUIElement::selectedRowAtIndex):
34118         (WTR::AccessibilityUIElement::titleUIElement):
34119         (WTR::AccessibilityUIElement::parentElement):
34120         (WTR::AccessibilityUIElement::disclosedByRow):
34121         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
34122         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
34123         (WTR::AccessibilityUIElement::attributesOfChildren):
34124         (WTR::AccessibilityUIElement::allAttributes):
34125         (WTR::AccessibilityUIElement::stringAttributeValue):
34126         (WTR::AccessibilityUIElement::numberAttributeValue):
34127         (WTR::AccessibilityUIElement::uiElementAttributeValue):
34128         (WTR::AccessibilityUIElement::boolAttributeValue):
34129         (WTR::AccessibilityUIElement::isAttributeSettable):
34130         (WTR::AccessibilityUIElement::isAttributeSupported):
34131         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
34132         (WTR::AccessibilityUIElement::role):
34133         (WTR::AccessibilityUIElement::subrole):
34134         (WTR::AccessibilityUIElement::roleDescription):
34135         (WTR::AccessibilityUIElement::title):
34136         (WTR::AccessibilityUIElement::description):
34137         (WTR::AccessibilityUIElement::orientation):
34138         (WTR::AccessibilityUIElement::stringValue):
34139         (WTR::AccessibilityUIElement::language):
34140         (WTR::AccessibilityUIElement::helpText):
34141         (WTR::AccessibilityUIElement::x):
34142         (WTR::AccessibilityUIElement::y):
34143         (WTR::AccessibilityUIElement::width):
34144         (WTR::AccessibilityUIElement::height):
34145         (WTR::AccessibilityUIElement::clickPointX):
34146         (WTR::AccessibilityUIElement::clickPointY):
34147         (WTR::AccessibilityUIElement::intValue):
34148         (WTR::AccessibilityUIElement::minValue):
34149         (WTR::AccessibilityUIElement::maxValue):
34150         (WTR::AccessibilityUIElement::valueDescription):
34151         (WTR::AccessibilityUIElement::insertionPointLineNumber):
34152         (WTR::AccessibilityUIElement::isActionSupported):
34153         (WTR::AccessibilityUIElement::isEnabled):
34154         (WTR::AccessibilityUIElement::isRequired):
34155         (WTR::AccessibilityUIElement::isFocused):
34156         (WTR::AccessibilityUIElement::isSelected):
34157         (WTR::AccessibilityUIElement::isExpanded):
34158         (WTR::AccessibilityUIElement::isChecked):
34159         (WTR::AccessibilityUIElement::hierarchicalLevel):
34160         (WTR::AccessibilityUIElement::speak):
34161         (WTR::AccessibilityUIElement::ariaIsGrabbed):
34162         (WTR::AccessibilityUIElement::ariaDropEffects):
34163         (WTR::AccessibilityUIElement::lineForIndex):
34164         (WTR::AccessibilityUIElement::rangeForLine):
34165         (WTR::AccessibilityUIElement::boundsForRange):
34166         (WTR::AccessibilityUIElement::stringForRange):
34167         (WTR::AccessibilityUIElement::attributedStringForRange):
34168         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
34169         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
34170         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
34171         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
34172         (WTR::AccessibilityUIElement::attributesOfColumns):
34173         (WTR::AccessibilityUIElement::attributesOfRows):
34174         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
34175         (WTR::AccessibilityUIElement::attributesOfHeader):
34176         (WTR::AccessibilityUIElement::rowCount):
34177         (WTR::AccessibilityUIElement::columnCount):
34178         (WTR::AccessibilityUIElement::indexInTable):
34179         (WTR::AccessibilityUIElement::rowIndexRange):
34180         (WTR::AccessibilityUIElement::columnIndexRange):
34181         (WTR::AccessibilityUIElement::cellForColumnAndRow):
34182         (WTR::AccessibilityUIElement::horizontalScrollbar):
34183         (WTR::AccessibilityUIElement::verticalScrollbar):
34184         (WTR::AccessibilityUIElement::selectedTextRange):
34185         (WTR::AccessibilityUIElement::setSelectedTextRange):
34186         (WTR::AccessibilityUIElement::increment):
34187         (WTR::AccessibilityUIElement::decrement):
34188         (WTR::AccessibilityUIElement::showMenu):
34189         (WTR::AccessibilityUIElement::press):
34190         (WTR::AccessibilityUIElement::setSelectedChild):
34191         (WTR::AccessibilityUIElement::accessibilityValue):
34192         (WTR::AccessibilityUIElement::documentEncoding):
34193         (WTR::AccessibilityUIElement::documentURI):
34194         (WTR::AccessibilityUIElement::url):
34195         (WTR::AccessibilityUIElement::addNotificationListener):
34196         (WTR::AccessibilityUIElement::removeNotificationListener):
34197         (WTR::AccessibilityUIElement::isFocusable):
34198         (WTR::AccessibilityUIElement::isSelectable):
34199         (WTR::AccessibilityUIElement::isMultiSelectable):
34200         (WTR::AccessibilityUIElement::isVisible):
34201         (WTR::AccessibilityUIElement::isOffScreen):
34202         (WTR::AccessibilityUIElement::isCollapsed):
34203         (WTR::AccessibilityUIElement::isIgnored):
34204         (WTR::AccessibilityUIElement::hasPopup):
34205         (WTR::AccessibilityUIElement::takeFocus):
34206         (WTR::AccessibilityUIElement::takeSelection):
34207         (WTR::AccessibilityUIElement::addSelection):
34208         (WTR::AccessibilityUIElement::removeSelection):
34209         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
34210         (WTR::AccessibilityUIElement::textMarkerRangeLength):
34211         (WTR::AccessibilityUIElement::previousTextMarker):
34212         (WTR::AccessibilityUIElement::nextTextMarker):
34213         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
34214         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
34215         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
34216         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
34217         (WTR::AccessibilityUIElement::textMarkerForPoint):
34218         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
34219         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
34220         (WTR::LayoutTestController::platformName):
34221         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
34222         (WTR::LayoutTestController::platformName):
34223         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
34224         (WTR::LayoutTestController::platformName):
34225         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
34226         * WebKitTestRunner/win/InjectedBundle.vcproj:
34227
34228 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
34229
34230         [Qt] Fix use of config.tests
34231
34232         We were checking @buildArgs to determine if the optional argument was
34233         passed or not, but this is not the right way to do that in Perl. The
34234         right way is to not use a prototype for the function, and to pass
34235         the list as a reference (to avoid list expansion). That way we can
34236         check the number of arguments, and choose the right code path based
34237         on that.
34238
34239         We were also missing a default-value of 0 for any feature that's not
34240         set in features.prf.
34241
34242         Reviewed by Kenneth Rohde Christiansen.
34243
34244         * Scripts/build-webkit:
34245         * Scripts/webkitdirs.pm:
34246         (qtFeatureDefaults):
34247         (buildQMakeProject):
34248
34249 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
34250
34251         [Qt] Prospective fix for broken plugin tests
34252
34253         Don't hide symbols for the NPAPI test plugin
34254
34255         Rubber-stamped by Andreas Kling.
34256
34257         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
34258
34259 2011-11-16  Adam Roben  <aroben@apple.com>
34260
34261         Move filenames/line numbers off to the right edge in Leaks Viewer
34262
34263         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
34264         because filenames/line numbers are right next to function names
34265
34266         Reviewed by Andreas Kling.
34267
34268         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
34269         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
34270         function name. Use the filename as the profile node's URL (we don't have enough info to
34271         compute a real URL currently) and the line number as the profile node's line number so the
34272         Inspector code will put them on the right side of the callstack graph.
34273
34274         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
34275         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
34276         passed here, just filenames.
34277
34278         (WebInspector.linkifyURLAsNode):
34279         (WebInspector.linkifyResourceAsNode):
34280         Copied and slightly modified from inspector.js.
34281
34282 2011-11-16  Adam Roben  <aroben@apple.com>
34283
34284         Make Leaks Viewer load builds from the new Lion Leaks bot
34285
34286         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
34287
34288         Reviewed by Andreas Kling.
34289
34290         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
34291         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
34292         SnowLeopard one.
34293
34294 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
34295
34296         [EFL] Clean up the offline apps-related functions in ewk_settings.
34297         https://bugs.webkit.org/show_bug.cgi?id=72132
34298
34299         Reviewed by Kenneth Rohde Christiansen.
34300
34301         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
34302         prefixes for code that is related only to the HTML5 app cache
34303         features.
34304
34305         Use `ewk_settings_application_cache' and
34306         `ewk_view_setting_application_cache' instead.
34307
34308         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
34309         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
34310
34311 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
34312
34313         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
34314
34315         Reviewed by Tor Arne Vestbø.
34316
34317         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
34318         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
34319         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
34320         removes the .so.0.0.0 and just produces .so.
34321
34322 2011-11-16  Peter Beverloo  <peter@chromium.org>
34323
34324         Explicitly include unistd.h in TestNetscapePlugIn
34325         https://bugs.webkit.org/show_bug.cgi?id=72385
34326
34327         This is needed for the sleep() call in the indicateTestFailure method,
34328         which seems to be implicitly available for other platforms. This is not
34329         the case on Android.
34330
34331         Reviewed by Steve Block.
34332
34333         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
34334
34335 2011-11-16  Peter Beverloo  <peter@chromium.org>
34336
34337         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
34338         https://bugs.webkit.org/show_bug.cgi?id=72384
34339
34340         Update to Android NDK r7, which was released last Friday. This adds
34341         support for RTTI and the -mimplicit-it gcc flag, which are required to
34342         respectively build ICU and Skia.
34343
34344         Reviewed by Steve Block.
34345
34346         * Scripts/update-webkit-chromium:
34347         * Scripts/webkitdirs.pm:
34348         (buildChromiumMakefile):
34349
34350 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
34351
34352         Unreviewed, rolling out r100266.
34353         http://trac.webkit.org/changeset/100266
34354
34355         Broke WTR.
34356
34357         * qmake/mkspecs/features/default_post.prf:
34358
34359 2011-11-16  Eric Seidel  <eric@webkit.org>
34360
34361         check-webkit-style broken by r99773: "Could not determine the port"
34362         https://bugs.webkit.org/show_bug.cgi?id=72275
34363
34364         Reviewed by Adam Barth.
34365
34366         I will continue engaging hacks, until windows improves.
34367
34368         * Scripts/webkitpy/common/host.py:
34369          - Host uses self.executive instead of self._executive like Port does.
34370          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
34371
34372 2011-11-16  Eric Seidel  <eric@webkit.org>
34373
34374         check-webkit-style broken by r99773: "Could not determine the port"
34375         https://bugs.webkit.org/show_bug.cgi?id=72275
34376
34377         Reviewed by Adam Barth.
34378
34379         Engage windows hacks harder.
34380
34381         This is a speculative fix for ChromiumWin.  We're now
34382         creating an SCM object much earlier, so we need to
34383         engage our "awesome" windows hacks earlier.
34384
34385         * Scripts/webkitpy/common/host.py:
34386         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
34387
34388 2011-11-15  Darin Adler  <darin@apple.com>
34389
34390         DRT's uiElementAttributeValueCallback function is leaky
34391         https://bugs.webkit.org/show_bug.cgi?id=72453
34392
34393         Reviewed by Dan Bernstein.
34394
34395         * DumpRenderTree/AccessibilityUIElement.cpp:
34396         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
34397
34398 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
34399
34400         Implement edit-distance based reviewer recognition algorithm
34401         https://bugs.webkit.org/show_bug.cgi?id=72351
34402
34403         Reviewed by Eric Seidel.
34404
34405         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
34406         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
34407         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
34408         "build fix" to a reviewer's name (e.g. with with edit distance 9).
34409
34410         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
34411         the edit distance is implemented in edit_distance.py.
34412
34413         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
34414         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
34415
34416         * Scripts/webkitpy/common/checkout/changelog.py:
34417         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
34418         * Scripts/webkitpy/common/config/committers.py:
34419         * Scripts/webkitpy/common/config/committers_unittest.py:
34420         * Scripts/webkitpy/common/editdistance.py: Added.
34421         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
34422         * Scripts/webkitpy/tool/steps/validatereviewer.py:
34423         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
34424
34425 2011-11-15  Tony Chang  <tony@chromium.org>
34426
34427         Skip a failing webkitpy test on cygwin.
34428
34429         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
34430
34431 2011-11-15  Sam Weinig  <sam@webkit.org>
34432
34433         TestWebKitAPI should not put its resources in the root products directory
34434         https://bugs.webkit.org/show_bug.cgi?id=72446
34435
34436         Reviewed by Anders Carlsson.
34437
34438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
34439         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
34440         directory.
34441
34442         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
34443         (TEST_F):
34444         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
34445         (TestWebKitAPI::TEST):
34446         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
34447         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
34448         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
34449         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
34450         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
34451         (TestWebKitAPI::Util::createURLForResource):
34452         Update calls to retrieve files from the bundle to look in the newly
34453         created subdirectory.
34454
34455 2011-11-15  Tony Chang  <tony@chromium.org>
34456
34457         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
34458
34459         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
34460
34461 2011-11-15  Tony Chang  <tony@chromium.org>
34462
34463         Unreviewed, fix test-webkitpy tests.  Move the check for image results
34464         earlier.
34465
34466         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
34467         * Scripts/webkitpy/layout_tests/port/webkit.py:
34468
34469 2011-11-15  James Robinson  <jamesr@chromium.org>
34470
34471         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
34472         https://bugs.webkit.org/show_bug.cgi?id=72444
34473
34474         Reviewed by Adam Barth.
34475
34476         * DumpRenderTree/chromium/DumpRenderTree.cpp:
34477
34478 2011-11-15  Tony Chang  <tony@chromium.org>
34479
34480         Unreviewed, better fix for ref tests failures on SL Intel bot.
34481         Revert the previous change and return None if pixel results from
34482         either the test page or the expected page is missing.
34483
34484         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
34485         * Scripts/webkitpy/layout_tests/port/webkit.py:
34486
34487 2011-11-15  James Robinson  <jamesr@chromium.org>
34488
34489         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
34490         https://bugs.webkit.org/show_bug.cgi?id=72402
34491
34492         Reviewed by Dirk Pranke.
34493
34494         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
34495         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
34496         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
34497         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
34498         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
34499         compositing enabled.
34500
34501         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
34502         patch should not impact any tests.
34503
34504         * DumpRenderTree/chromium/DumpRenderTree.cpp:
34505         (main):
34506         * DumpRenderTree/chromium/TestShell.cpp:
34507         (TestShell::TestShell):
34508         (TestShell::resetWebSettings):
34509         * DumpRenderTree/chromium/TestShell.h:
34510         (TestShell::setAcceleratedCompositingForVideoEnabled):
34511         * DumpRenderTree/chromium/WebPreferences.cpp:
34512         (WebPreferences::reset):
34513         (WebPreferences::applyTo):
34514         * DumpRenderTree/chromium/WebPreferences.h:
34515         * Scripts/webkitpy/layout_tests/port/chromium.py:
34516         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
34517         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
34518
34519 2011-11-15  Tony Chang  <tony@chromium.org>
34520
34521         Unreviewed, try to fix ref tests failures on SL Intel bot.
34522         It looks like ImageDiff isn't returning an image diff.
34523
34524         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
34525
34526 2011-11-15  Tony Chang  <tony@chromium.org>
34527
34528         Unreviewed fix of ref-tests on GTK+.
34529         If a driver is never started, _xvfb_process is never set.
34530
34531         * Scripts/webkitpy/layout_tests/port/gtk.py:
34532
34533 2011-11-14  Tony Chang  <tony@chromium.org>
34534
34535         [NRWT] Reftests should run even when pixel tests are disabled.
34536         https://bugs.webkit.org/show_bug.cgi?id=60605
34537
34538         Reviewed by Dirk Pranke.
34539
34540         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
34541             Also add an assert to make sure we get image hashes back when running ref tests.
34542         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
34543         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
34544         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
34545         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
34546             of starting a pixel driver if needed.  It handles the logic of sending the test
34547             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
34548         * Scripts/webkitpy/layout_tests/port/dryrun.py:
34549         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
34550         * Scripts/webkitpy/layout_tests/port/webkit.py:
34551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
34552         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
34553
34554 2011-11-15  David Kilzer  <ddkilzer@apple.com>
34555
34556         Don't use File::Slurp for run-leaks unit tests
34557         <http://webkit.org/b/72356>
34558
34559         Reviewed by Daniel Bates.
34560
34561         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
34562         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
34563         Extracted common package logic into RunLeaks.pm.  Fixed call to
34564         RunLeaks::parseLeaksOutput().
34565         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
34566         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
34567
34568 2011-11-15  Peter Kasting  <pkasting@google.com>
34569
34570         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
34571         https://bugs.webkit.org/show_bug.cgi?id=72349
34572
34573         Reviewed by Adam Roben.
34574
34575         * Scripts/VCSUtils.pm:
34576         (isSVNDirectory):
34577
34578 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
34579
34580         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
34581
34582         Reviewed by Tor Arne Vestbø.
34583
34584         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
34585         magic here where we handle all TEMPLATE = lib .pro files.
34586
34587 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
34588
34589         [Qt] Unreviewed prospective --minimal build fix.
34590
34591         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
34592         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
34593
34594 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
34595
34596         [Qt] Unreviewed --minimal build fix.
34597
34598         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
34599         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
34600         to make moc's preprocessor abort.
34601
34602 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
34603
34604         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
34605         https://bugs.webkit.org/show_bug.cgi?id=72156
34606
34607         Reviewed by Daniel Bates.
34608
34609         Similar to --makearg and --qmakearg, --cmakearg lets one pass
34610         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
34611
34612         * Scripts/build-webkit:
34613         * Scripts/webkitdirs.pm:
34614         (generateBuildSystemFromCMakeProject):
34615
34616 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
34617
34618         Improve ChangeLogEntry's reviewer parsing algorithm part 2
34619         https://bugs.webkit.org/show_bug.cgi?id=72340
34620
34621         Reviewed by Eric Seidel.
34622
34623         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
34624         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
34625
34626         * Scripts/webkitpy/common/checkout/changelog.py:
34627         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
34628
34629 2011-11-14  Eric Seidel  <eric@webkit.org>
34630
34631         check-webkit-style broken by r99773: "Could not determine the port"
34632         https://bugs.webkit.org/show_bug.cgi?id=72275
34633
34634         Reviewed by Adam Barth.
34635
34636         The TestExpectationsChecker was using a generic try/except block
34637         which caught all exceptions, so we didn't notice that failing
34638         to pass a Host to PortFactory was causing an exception in port instantiation.
34639         I've factored out the "lookup the port" logic into a separate function
34640         which I've now unittested.  This should fix the bug and prevent
34641         others like it from occuring the the future.
34642
34643         * Scripts/webkitpy/style/checkers/test_expectations.py:
34644         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
34645
34646 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
34647
34648         Add --css-grid-layout to build-webkit and the build systems
34649         https://bugs.webkit.org/show_bug.cgi?id=72320
34650
34651         Reviewed by Ojan Vafai.
34652
34653         * Scripts/build-webkit:
34654         Added the option.
34655
34656 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
34657
34658         Unreviewed, rolling out r100192.
34659         http://trac.webkit.org/changeset/100192
34660         https://bugs.webkit.org/show_bug.cgi?id=72328
34661
34662         Caused infinite tests to fail (Requested by abarth on
34663         #webkit).
34664
34665         * Scripts/webkitpy/layout_tests/port/base.py:
34666         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
34667
34668 2011-11-14  Tony Chang  <tony@chromium.org>
34669
34670         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
34671         https://bugs.webkit.org/show_bug.cgi?id=72196
34672
34673         Reviewed by Ojan Vafai.
34674
34675         * Scripts/build-webkit:
34676
34677 2011-11-14  John Yani  <vanuan@gmail.com>
34678
34679         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
34680         Override LOCALE to en_US.
34681
34682         Reviewed by Eric Seidel.
34683
34684         * Scripts/webkitpy/layout_tests/port/base.py:
34685
34686 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
34687
34688         [Chromium] build-webkit silently drops the features flags
34689         https://bugs.webkit.org/show_bug.cgi?id=72293
34690
34691         Reviewed by Tony Chang.
34692
34693         Chromium still ignores @features but now we give a warning!
34694
34695         * Scripts/build-webkit: Check if one of the features is different
34696         from the default and print a warning in this case.
34697
34698 2011-11-14  David Kilzer  <ddkilzer@apple.com>
34699
34700         run-leaks does not work on Lion?
34701         <http://webkit.org/b/71059>
34702         <rdar://problem/10428527>
34703
34704         Reviewed by Adam Roben.
34705
34706         The output of leaks(1) changed again in Lion to move the
34707         "leaks Report Version: 2.0" line from the first line of the
34708         output to just above the "Process " lines that run-leaks is
34709         interested in parsing.  This required using a more generic
34710         algorithm to find the start of the "Process " lines.
34711
34712         * Scripts/run-leaks:
34713         (parseLeaksOutput): Make the code to skip headers more generic.
34714         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
34715         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
34716         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
34717
34718 2011-11-14  Lei Zhang  <thestig@chromium.org>
34719
34720         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
34721         https://bugs.webkit.org/show_bug.cgi?id=72088
34722
34723         Reviewed by Tony Chang.
34724
34725         * DumpRenderTree/chromium/AccessibilityUIElement.h:
34726
34727 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
34728
34729         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
34730         https://bugs.webkit.org/show_bug.cgi?id=72147
34731
34732         Reviewed by Adam Barth.
34733
34734         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
34735
34736 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
34737
34738         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
34739
34740         Reviewed by Simon Hausmann.
34741
34742         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
34743
34744 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
34745
34746         [Qt] Disable plugins on X11 for WK2
34747
34748         Reviewed by Kenneth Rohde Christiansen.
34749
34750         Currently plugins are in-process and they crash in the likely case of
34751         a plugin installation that uses Qt 4, which beautifully clashes with the
34752         Qt 5 based QtWebProcess.
34753
34754         * qmake/mkspecs/features/features.prf:
34755
34756 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
34757
34758         [Qt] Add support for config tests for Qt 5
34759
34760         This allows us to build and run configure-tests at build
34761         time to determine if a given platform feature is available.
34762
34763         Reviewed by Simon Hausmann.
34764
34765         * Scripts/build-webkit:
34766         * Scripts/webkitdirs.pm:
34767         (qtFeatureDefaults):
34768         * qmake/configure.pro: Added.
34769         * qmake/mkspecs/features/features.prf:
34770         * qmake/sync.profile: Added.
34771
34772 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
34773
34774         [Qt] Remove the QStyle dependency in Qt's mobile theme
34775         https://bugs.webkit.org/show_bug.cgi?id=67773
34776
34777         This refactoring splits up RenderThemeQt with two
34778         subclasses, a QStyle-backed one, and a Mobile version
34779         that uses the old mobile theme for now.
34780
34781         QStyle availability is detected at compile time, and
34782         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
34783         environment variable.
34784
34785         Reviewed by Simon Hausmann.
34786
34787         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
34788         (WTR::activateFonts):
34789         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
34790         based on availability of QtWidgets.
34791         * qmake/mkspecs/features/webcore.prf: cleanup.
34792
34793 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
34794
34795         Unreviewed, rolling out r100116.
34796         http://trac.webkit.org/changeset/100116
34797
34798         r100104 was rolled out, so no longer needed
34799
34800         * Scripts/run-bindings-tests:
34801
34802 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
34803
34804         Unreviewed, rolling out r100104.
34805         http://trac.webkit.org/changeset/100104
34806         https://bugs.webkit.org/show_bug.cgi?id=72247
34807
34808         broke windows builds
34809
34810         * Scripts/check-webkit-style:
34811         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
34812         * Scripts/webkitpy/common/checkout/deps.py:
34813         * Scripts/webkitpy/common/checkout/scm/__init__.py:
34814         * Scripts/webkitpy/common/checkout/scm/detection.py:
34815         * Scripts/webkitpy/common/checkout/scm/git.py:
34816         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
34817         * Scripts/webkitpy/common/checkout/scm/svn.py:
34818         * Scripts/webkitpy/common/host.py:
34819         * Scripts/webkitpy/common/host_mock.py:
34820         * Scripts/webkitpy/layout_tests/controllers/manager.py:
34821         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
34822         * Scripts/webkitpy/layout_tests/port/base.py:
34823         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
34824         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
34825         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
34826         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
34827
34828 2011-11-14  Philippe Normand  <pnormand@igalia.com>
34829
34830         Unreviewed, build fix after r100104. run-binding-tests broke.
34831
34832         * Scripts/run-bindings-tests: Explicitely use scm.detection.
34833
34834 2011-11-13  Eric Seidel  <eric@webkit.org>
34835
34836         Add SCMDetector object to make scm detection mockable
34837         https://bugs.webkit.org/show_bug.cgi?id=72247
34838
34839         Reviewed by Adam Barth.
34840
34841         I think SCM detection may eventually be rolled into Checkout,
34842         but this patch at least makes it possible to mock code-paths
34843         which rely on scm detection.
34844         In the process of replacing callers of these free-functions
34845         I found that one of the functions was no longer used,
34846         and that one of the callers could instead just use the SCM
34847         object it already had access to through port.host.scm().
34848         I also discovered that I was not calling Host._initialize_scm()
34849         and thus host.scm() was always returning None!
34850
34851         * Scripts/check-webkit-style:
34852         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
34853         * Scripts/webkitpy/common/checkout/deps.py:
34854         * Scripts/webkitpy/common/checkout/scm/__init__.py:
34855         * Scripts/webkitpy/common/checkout/scm/detection.py:
34856         * Scripts/webkitpy/common/checkout/scm/git.py:
34857         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
34858         * Scripts/webkitpy/common/checkout/scm/svn.py:
34859         * Scripts/webkitpy/common/host.py:
34860         * Scripts/webkitpy/common/host_mock.py:
34861         * Scripts/webkitpy/layout_tests/controllers/manager.py:
34862         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
34863         * Scripts/webkitpy/layout_tests/port/base.py:
34864         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
34865         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
34866         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
34867         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
34868
34869 2011-11-13  Gavin Peters  <gavinp@chromium.org>
34870
34871         command line control of webcore log channels in chromium DumpRenderTree
34872         https://bugs.webkit.org/show_bug.cgi?id=72126
34873
34874         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
34875         what chromium takes.
34876
34877         Reviewed by Kent Tamura.
34878
34879         * DumpRenderTree/chromium/DumpRenderTree.cpp:
34880         (main):
34881
34882 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
34883
34884         [Qt] Fix minor config typo in the build tool documentation
34885         https://bugs.webkit.org/show_bug.cgi?id=72194
34886
34887         Reviewed by Andreas Kling.
34888
34889         * qmake/README:
34890
34891 2011-11-11  Stephen Chenney  <schenney@chromium.org>
34892
34893         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
34894         https://bugs.webkit.org/show_bug.cgi?id=49257
34895
34896         Adds the remaining missing layout test functionality for printing.
34897
34898         Reviewed by Darin Fisher.
34899
34900         * DumpRenderTree/chromium/LayoutTestController.cpp:
34901         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
34902         (parsePageNumber): Method to parse JS arguments for a page number
34903         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
34904         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
34905         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
34906         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
34907         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
34908
34909 2011-11-11  Darin Adler  <darin@apple.com>
34910
34911         Remove all releaseRef implementations except for RetainPtr
34912         https://bugs.webkit.org/show_bug.cgi?id=71423
34913
34914         Reviewed by Julien Chaffraix.
34915
34916         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
34917         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
34918
34919 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
34920
34921         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
34922         https://bugs.webkit.org/show_bug.cgi?id=72090
34923
34924         Reviewed by Eric Seidel.
34925
34926         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
34927         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
34928
34929         yay! r100002.
34930
34931         * Scripts/webkitpy/common/checkout/changelog.py:
34932         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
34933
34934 2011-11-11  Tony Chang  <tony@chromium.org>
34935
34936         Remove --force from gclient sync.  The bots seem to have made it past
34937         the update step.
34938
34939         * Scripts/update-webkit:
34940
34941 2011-11-11  Tony Chang  <tony@chromium.org>
34942
34943         Add --force to gclient sync. Once the cq bots cycle, we can remove
34944         this since it slows down the normal sync.
34945
34946         * Scripts/update-webkit:
34947
34948 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
34949
34950         When --force is used, also use --reset
34951         https://bugs.webkit.org/show_bug.cgi?id=72129
34952
34953         Reviewed by Dimitri Glazkov.
34954
34955         * Scripts/update-webkit-chromium:
34956
34957 2011-11-11  Tony Chang  <tony@chromium.org>
34958
34959         allow two chromium drivers to run at the same time in NRWT
34960         https://bugs.webkit.org/show_bug.cgi?id=72067
34961
34962         Reviewed by Dirk Pranke.
34963
34964         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
34965             posix prevents the subprocesses from sharing the same fd for stdin.
34966             Sharing the same fd prevents us from closing the files unless all references
34967             to the fd are closed.
34968         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
34969             to adding a test for this, speed up a test (from 3sec to 0) by fixing
34970             the timeout override. It looks like it regressed in r95875.
34971
34972 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
34973
34974         Unreviewed, rolling out r99964.
34975         http://trac.webkit.org/changeset/99964
34976         https://bugs.webkit.org/show_bug.cgi?id=72124
34977
34978         Broke too many Qt tests (Requested by tronical_ on #webkit).
34979
34980         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
34981         (WTR::activateFonts):
34982         * qmake/mkspecs/features/features.prf:
34983         * qmake/mkspecs/features/webcore.prf:
34984
34985 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
34986
34987         [Qt] Remove the QStyle dependency in Qt's mobile theme
34988         https://bugs.webkit.org/show_bug.cgi?id=67773
34989
34990         This refactoring splits up RenderThemeQt with two
34991         subclasses, a QStyle-backed one, and a Mobile version
34992         that uses the old mobile theme for now.
34993
34994         QStyle availability is detected at compile time, and
34995         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
34996         environment variable.
34997
34998         Reviewed by Simon Hausmann.
34999
35000         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
35001         (WTR::activateFonts):
35002         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
35003         based on availability of QtWidgets.
35004         * qmake/mkspecs/features/webcore.prf: cleanup.
35005
35006 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35007
35008         [Qt] Add missing include to PlatformWebViewQt
35009
35010         Reviewed by Simon Hausmann.
35011
35012         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
35013
35014 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35015
35016         [Qt] Fix incremental builds on Windows after buildsystem refactor
35017
35018         The qmake rules to ensure that we run make on the derived sources
35019         before running qmake on the target were inside a unix-scope, which
35020         resulted in flakey builds on Windows.
35021
35022         We now generate a rule on all platforms that ensures that "make qmake"
35023         will always run make on the derived sources. In addition, on platforms
35024         that have GNU make (where "make incremental" does not run "make qmake",
35025         but only "make"), we add a similar rule that ensures that any time the
35026         target makefile is regenerated we first run qmake and make on the derived
35027         sources. This rule relies on GNU make's order-only-prerequisites to
35028         not trigger a qmake-run of the target every time we run make.
35029
35030         https://bugs.webkit.org/show_bug.cgi?id=71778
35031
35032         Reviewed by Simon Hausmann.
35033
35034         * qmake/mkspecs/features/functions.prf:
35035
35036 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
35037
35038         [Qt][WK2] Remove QWebNavigationController
35039         https://bugs.webkit.org/show_bug.cgi?id=72113
35040
35041         Reviewed by Andreas Kling.
35042
35043         Adapt to the move of the QWebNavigationController functions/properties to
35044         QQuickWebView.
35045
35046         * MiniBrowser/qt/MiniBrowserApplication.cpp:
35047         * MiniBrowser/qt/qml/BrowserWindow.qml:
35048
35049 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
35050
35051         [Qt] Build system tweak
35052
35053         Reviewed by Tor Arne Vestbø.
35054
35055         Be a good qmake citizen, return true from our linkStaticLibrary
35056         "test" function.
35057
35058         * qmake/mkspecs/features/functions.prf:
35059
35060 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
35061
35062         [Qt] Add support for QT += webkit-private
35063
35064         Reviewed by Tor Arne Vestbø.
35065
35066         * qmake/qt_webkit.pri: Declare private headers.
35067
35068 2011-11-11  Philippe Normand  <pnormand@igalia.com>
35069
35070         Unreviewed, build fix attempt after r99907. Since that revision
35071         GTK layout tests were not running at all...
35072
35073         * Scripts/webkitpy/layout_tests/port/gtk.py:
35074
35075 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
35076
35077         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
35078         https://bugs.webkit.org/show_bug.cgi?id=72001
35079
35080         Reviewed by Dirk Pranke.
35081
35082         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
35083
35084 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
35085
35086         bencher script should support remote benchmarking
35087         https://bugs.webkit.org/show_bug.cgi?id=71618
35088
35089         Rubber-stamped by Geoff Garen.
35090
35091         Added the following features:
35092
35093         - Benchmark report tells you the hostname and machine model (according to
35094           'sysctl hw.model') of the machine you did the run on, and svn revision number
35095           (according to 'svn info') of the VMs you're testing.
35096
35097         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
35098           acceptable, in addition to just host, in which case your username is used)
35099           and it automatically packages the build directories of the VMs you're testing,
35100           sends them to the remote machine along with your copy of the bencher script
35101           and all of the options you passed.  This pretty much seamlessly allows you
35102           to run a set of benchmarks on any machine that is sufficiently compatible with
35103           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
35104           must now include a tempPath setting that tells bencher where to put files
35105           when that machine is used as a slave in a remote benchmarking run.
35106
35107         - Added yet another way of specifying which benchmarks to run. This was sort of
35108           necessary for --remote to work as expected. Previously, you either said what
35109           suites to exclude (for example --exclude-sunspider) or that you only wanted
35110           to run one suite to the exclusion of others (--sunspider-only). But it's
35111           often better to just be able to specify the list of suites you want. This is
35112           now supported. You can say, for example, --v8 --sunspider, which means, just
35113           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
35114           still supported.
35115
35116         * Scripts/bencher:
35117
35118 2011-11-10  Tony Chang  <tony@chromium.org>
35119
35120         Lazily start DRT instances in NRWT
35121         https://bugs.webkit.org/show_bug.cgi?id=72038
35122
35123         Reviewed by Eric Seidel.
35124
35125         Just a refactoring, no new tests.
35126
35127         * Scripts/webkitpy/layout_tests/controllers/worker.py:
35128         * Scripts/webkitpy/layout_tests/port/chromium.py:
35129         * Scripts/webkitpy/layout_tests/port/dryrun.py:
35130         * Scripts/webkitpy/layout_tests/port/test.py:
35131         * Scripts/webkitpy/layout_tests/port/webkit.py:
35132
35133 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
35134
35135         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
35136         https://bugs.webkit.org/show_bug.cgi?id=72057
35137
35138         Reviewed by Eric Seidel.
35139
35140         Make the regular expression more explicit.
35141
35142         * Scripts/webkitpy/common/checkout/changelog.py:
35143         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
35144
35145 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
35146
35147         [Qt] X11 plugins need to be reworked for Qt5
35148         https://bugs.webkit.org/show_bug.cgi?id=70023
35149
35150         Reviewed by Simon Hausmann.
35151
35152         Rework our basic plugin support in a way that does
35153         not need a bridge between Qt and X. The solution is
35154         based on getting the content drawed by the plugin
35155         from the server as an image and creating a QImage
35156         from it.
35157
35158         * qmake/mkspecs/features/features.prf: Enable X11
35159         plugins if Qt is built with the xcb-xlib backend.
35160
35161 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
35162
35163         [Qt] Fix keyboard related layout tests after API refactoring
35164
35165         Reviewed by Tor Arne Vestbø.
35166
35167         Send key events to the handling page item, not the view.
35168
35169         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
35170         (WTR::PlatformWebView::sendEvent):
35171         (WTR::PlatformWebView::postEvent):
35172
35173 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
35174
35175         [GTK] Make the ENABLE(FEATURE) macro work in DRT
35176         https://bugs.webkit.org/show_bug.cgi?id=71940
35177
35178         Reviewed by Philippe Normand.
35179
35180         * GNUmakefile.am:
35181         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
35182         ENABLE_* variables are part of the environment.
35183
35184 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
35185
35186         [Qt] Fix focus related layout tests after API refactoring
35187
35188         Reviewed by Tor Arne Vestbø.
35189
35190         Make sure the focus is set on the page now, not on the view
35191         (which doesn't actually handle the focus).
35192
35193         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
35194         (WTR::WrapperWindow::WrapperWindow):
35195         (WTR::WrapperWindow::handleStatusChanged):
35196
35197 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
35198
35199         [Qt] Merge QTouchWebView and QDesktopWebView into one class
35200         https://bugs.webkit.org/show_bug.cgi?id=71355
35201
35202         Reviewed by Kenneth Rohde Christiansen.
35203
35204         Make MiniBrowser and WebKitTestRunner work again after the
35205         merge.
35206
35207         * MiniBrowser/qt/BrowserWindow.cpp:
35208         (BrowserWindow::BrowserWindow):
35209         (BrowserWindow::webView):
35210         * MiniBrowser/qt/MiniBrowser.pro:
35211         * MiniBrowser/qt/MiniBrowser.qrc:
35212         * MiniBrowser/qt/MiniBrowserApplication.cpp:
35213         * MiniBrowser/qt/main.cpp:
35214         * MiniBrowser/qt/qml/BrowserWindow.qml:
35215         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
35216         * MiniBrowser/qt/qml/TouchView.qml: Removed.
35217         * WebKitTestRunner/PlatformWebView.h:
35218         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
35219         (WTR::PlatformWebView::PlatformWebView):
35220
35221 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35222
35223         [Qt] Change semantics of the haveQt() function to match API promises
35224
35225         Having Qt 5 does not imply that we have Qt 4, from an API point of
35226         view, as a major version can in theory break BC/SC. Our minimum
35227         version of Qt 4 will always be the latest released version of Qt 4,
35228         so the only place we should use haveQt(4, x) is when checking for
35229         the minimum requirements.
35230
35231         Reviewed by Simon Hausmann.
35232
35233         * qmake/mkspecs/features/default_pre.prf:
35234         * qmake/mkspecs/features/features.prf:
35235         * qmake/mkspecs/features/functions.prf:
35236
35237 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
35238
35239         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
35240         https://bugs.webkit.org/show_bug.cgi?id=69411
35241
35242         Reviewed by Martin Robinson.
35243
35244         * WebKitTestRunner/EventSenderProxy.h:
35245         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
35246         * WebKitTestRunner/TestController.cpp:
35247         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
35248         use the EventSender instead of WebProcess Event Simulation.
35249         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
35250         (WTR::WTREventQueueItem::WTREventQueueItem):
35251         (WTR::EventSenderProxy::EventSenderProxy):
35252         (WTR::getMouseButtonModifiers):
35253         (WTR::eventSenderButtonToGDKButton):
35254         (WTR::EventSenderProxy::createMouseButtonEvent):
35255         (WTR::EventSenderProxy::updateClickCountForButton):
35256         (WTR::EventSenderProxy::replaySavedEvents):
35257         (WTR::EventSenderProxy::sendOrQueueEvent):
35258         (WTR::webkitModifiersToGDKModifiers):
35259         (WTR::getGDKKeySymForKeyRef):
35260         (WTR::EventSenderProxy::keyDown):
35261         (WTR::EventSenderProxy::mouseDown):
35262         (WTR::EventSenderProxy::mouseUp):
35263         (WTR::EventSenderProxy::mouseMoveTo):
35264         (WTR::EventSenderProxy::mouseScrollBy):
35265         (WTR::EventSenderProxy::leapForward):
35266
35267 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35268
35269         [Qt] Enable exports and constructor functions in static libs
35270
35271         Reviewed by Tor Arne Vestbø.
35272
35273         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
35274         mac/win32-msvc equivalents when linking static libraries into a shared
35275         library or executable.
35276
35277 2011-11-09  Hayato Ito  <hayato@chromium.org>
35278
35279         [NRWT] Make results.html aware of reference filename in reftests.
35280         https://bugs.webkit.org/show_bug.cgi?id=71574
35281
35282         Reviewed by Ryosuke Niwa.
35283
35284         If a reference filename is different from the default one, include that in result summary
35285         so results.html can link to the correct reference file.
35286
35287         * Scripts/webkitpy/layout_tests/controllers/manager.py:
35288         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
35289
35290 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
35291
35292         [wx] Unreviewed build fix. Update project files and
35293         add LTC stubs for new methods.
35294
35295         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
35296         (LayoutTestController::addChromeInputField):
35297         (LayoutTestController::removeChromeInputField):
35298         (LayoutTestController::focusWebView):
35299         (LayoutTestController::setBackingScaleFactor):
35300         * waf/build/settings.py:
35301
35302 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
35303
35304         [wx] Unreviewed build fix. Support XCode 4 when building deps.
35305
35306         * wx/install-unix-extras:
35307
35308 2011-11-09  Eric Seidel  <eric@webkit.org>
35309
35310         Remove the concept of platform-dependent unittests
35311         https://bugs.webkit.org/show_bug.cgi?id=71963
35312
35313         Unreviewed.  Fix test-webkitpy on cygwin.
35314
35315         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
35316
35317 2011-11-09  Dana Jansens  <danakj@chromium.org>
35318
35319         Add cc-bugs group to watch changes in chromium graphics
35320         https://bugs.webkit.org/show_bug.cgi?id=71690
35321
35322         Reviewed by David Levin.
35323
35324         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
35325         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
35326         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
35327         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
35328
35329 2011-11-09  Eric Seidel  <eric@webkit.org>
35330
35331         Remove more platform-dependent unittests
35332         https://bugs.webkit.org/show_bug.cgi?id=71971
35333
35334         Reviewed by Adam Barth.
35335
35336         Tests which only run on a couple platforms will break.
35337         All tests should run on all platforms where possible.
35338
35339         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
35340         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
35341         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
35342         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
35343
35344 2011-11-09  Ojan Vafai  <ojan@chromium.org>
35345
35346         Merge in results to the test results server even if build numbers conflict
35347         https://bugs.webkit.org/show_bug.cgi?id=71967
35348
35349         Reviewed by Tony Chang.
35350
35351         This was initially meant to be a sanity check that we don't
35352         enter duplicate runs, but it turns out that we can reasonably get
35353         in these situations when a builder is clobbered (e.g. the build
35354         numbers start over again from 0).
35355
35356         * TestResultServer/model/jsonresults.py:
35357         * TestResultServer/model/jsonresults_unittest.py:
35358
35359 2011-11-09  Eric Seidel  <eric@webkit.org>
35360
35361         Remove the concept of platform-dependent unittests
35362         https://bugs.webkit.org/show_bug.cgi?id=71963
35363
35364         Reviewed by Adam Barth.
35365
35366         These have been the source of never-ending sadness.
35367         We'd change behavior and forget to update results in
35368         some unittests because they were only run on certain platforms.
35369         This change removes a large source of these platform-dependent
35370         unittests, which was caused by the port_maker stuff.
35371
35372         It's possible that this change will break test-webkitpy
35373         on some platforms, but that will be a one-time cost.
35374         I will fix the breakage by removing the platform-dependantness
35375         of any such broken tests.
35376
35377         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
35378         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
35379         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
35380         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
35381         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
35382         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
35383         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
35384         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
35385         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
35386         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
35387         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
35388         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
35389         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
35390
35391 2011-11-09  Eric Seidel  <eric@webkit.org>
35392
35393         Make the Port object have a Host
35394         https://bugs.webkit.org/show_bug.cgi?id=71961
35395
35396         Reviewed by Adam Barth.
35397
35398         This has been a long time coming.
35399         Now that Port has a Host object, it's very easy
35400         to write unittests which use a properly mocked Port.
35401         Soon we will remove the executive, filesystem and user
35402         members of Port and get everything through the Host.
35403
35404         Note how in many callsites we're actually removing
35405         explicit mocks, since we're now always going to get the
35406         correct Executive/User/FileSystem from the
35407         Host and callsites don't need to be careful to pass each one.
35408
35409         This is prep-work for adding a new Environment member to
35410         Host and needing to be able to access the Environment
35411         member from Port functions w/o needing to pass an Environment
35412         object (or appropriate Mock) every place we create a Port object.
35413         Now that we have a single Host object to reach out through, its
35414         simple to add additional functionality (like Environment) while
35415         keeping our unittests properly mocked.
35416
35417         * Scripts/webkitpy/common/host.py:
35418         * Scripts/webkitpy/common/net/credentials_unittest.py:
35419         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
35420         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
35421         * Scripts/webkitpy/layout_tests/port/apple.py:
35422         * Scripts/webkitpy/layout_tests/port/base.py:
35423         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
35424         * Scripts/webkitpy/layout_tests/port/chromium.py:
35425         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
35426         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
35427         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
35428         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
35429         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
35430         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
35431         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
35432         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
35433         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
35434         * Scripts/webkitpy/layout_tests/port/dryrun.py:
35435         * Scripts/webkitpy/layout_tests/port/efl.py:
35436         * Scripts/webkitpy/layout_tests/port/factory.py:
35437         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
35438         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
35439         * Scripts/webkitpy/layout_tests/port/gtk.py:
35440         * Scripts/webkitpy/layout_tests/port/mac.py:
35441         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
35442         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
35443         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
35444         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
35445         * Scripts/webkitpy/layout_tests/port/qt.py:
35446         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
35447         * Scripts/webkitpy/layout_tests/port/test.py:
35448         * Scripts/webkitpy/layout_tests/port/webkit.py:
35449         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
35450         * Scripts/webkitpy/layout_tests/port/win.py:
35451         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
35452         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
35453         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
35454         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
35455         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
35456
35457 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
35458
35459         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
35460         https://bugs.webkit.org/show_bug.cgi?id=71561
35461
35462         Reviewed by Dimitri Glazkov.
35463
35464         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
35465         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
35466
35467 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
35468
35469         Implement dumpProgressFinishedCallback() for Mac layoutTestController
35470         https://bugs.webkit.org/show_bug.cgi?id=66772
35471
35472         Reviewed by Simon Fraser.
35473
35474         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
35475         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
35476
35477         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
35478         in the FrameLoadDelegate and print the output in response to the notification.
35479
35480         * DumpRenderTree/mac/FrameLoadDelegate.mm:
35481         (-[FrameLoadDelegate init]):
35482         (-[FrameLoadDelegate dealloc]):
35483         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
35484
35485 2011-11-09  Philippe Normand  <pnormand@igalia.com>
35486
35487         [GTK][DRT] window internals object is not reset after each test
35488         https://bugs.webkit.org/show_bug.cgi?id=71890
35489
35490         Reviewed by Martin Robinson.
35491
35492         Call WebCoreTestSupport::resetInternalsObject without going
35493         through DumpRenderTreeSupport.
35494
35495         * DumpRenderTree/gtk/DumpRenderTree.cpp:
35496         (runTest):
35497
35498 2011-11-09  Beth Dakin  <bdakin@apple.com>
35499
35500         Build fix.
35501
35502         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
35503         (AccessibilityUIElement::uiElementAttributeValue):
35504
35505 2011-11-09  Beth Dakin  <bdakin@apple.com>
35506
35507         Speculative build fix.
35508
35509         * DumpRenderTree/AccessibilityUIElement.h:
35510
35511 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
35512
35513         Unreviewed build fix.
35514
35515         * DumpRenderTree/AccessibilityUIElement.cpp:
35516         (AccessibilityUIElement::makeJSAccessibilityUIElement):
35517         A bad merge added this check that is making the bots sad.
35518
35519 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
35520
35521         AX: crash when accessing selectedTab in a tab list
35522         https://bugs.webkit.org/show_bug.cgi?id=70938
35523
35524         Reviewed by Beth Dakin.
35525
35526         Add the ability to retrieve an element through an arbitrary attribute.
35527
35528         * DumpRenderTree/AccessibilityUIElement.cpp:
35529         (uiElementAttributeValueCallback):
35530         (AccessibilityUIElement::uiElementAttributeValue):
35531         (AccessibilityUIElement::getJSClass):
35532         * DumpRenderTree/AccessibilityUIElement.h:
35533         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
35534         (AccessibilityUIElement::uiElementAttributeValue):
35535
35536 2011-11-09  Andy Wingo  <wingo@igalia.com>
35537
35538         Add webkitdirs.pm:getArchitecture implementation for GTK
35539         https://bugs.webkit.org/show_bug.cgi?id=71370
35540
35541         Reviewed by Xan Lopez.
35542
35543         * Scripts/webkitdirs.pm (determineArchitecture): Add an
35544         implementation for ports using autotools, so that a vanilla
35545         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
35546         to build-jsc on x86-64 machines.
35547
35548 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35549
35550         Unreviewed, rolling out r99707.
35551         http://trac.webkit.org/changeset/99707
35552
35553         Re-enable until we can disable it together with tests in one
35554         shot.
35555
35556         * qmake/mkspecs/features/features.prf:
35557
35558 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35559
35560         [Qt] Disable use of QtUiTools if the library/module is not found
35561
35562         We rely on the lookup order of prf files to inject our own uitools.prf
35563         that will verify that QtUiTools is in fact present before allowing the
35564         CONFIG += uitools to have any effect.
35565
35566         Reviewed by Simon Hausmann.
35567
35568         * DumpRenderTree/qt/DumpRenderTree.pro:
35569         * QtTestBrowser/QtTestBrowser.pro:
35570         * qmake/mkspecs/features/uitools.prf: Added.
35571
35572 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35573
35574         Unreviewed, rolling out r99701.
35575         http://trac.webkit.org/changeset/99701
35576
35577         Breaks Qt mac build
35578
35579         * qmake/mkspecs/features/functions.prf:
35580
35581 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35582
35583         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
35584
35585         Reviewed by Tor Arne Vestbø.
35586
35587         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
35588         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
35589         is not up to the task of full XSLT support, so we should disable it.
35590
35591 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35592
35593         [Qt] Enable exports and constructor functions in static libs
35594
35595         Reviewed by Tor Arne Vestbø.
35596
35597         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
35598         mac/win32-msvc equivalents when linking static libraries into a shared
35599         library or executable.
35600
35601 2011-11-09  Philippe Normand  <pnormand@igalia.com>
35602
35603         [GTK][DRT] window internals object is not reset after each test
35604         https://bugs.webkit.org/show_bug.cgi?id=71890
35605
35606         Reviewed by Xan Lopez.
35607
35608         * DumpRenderTree/gtk/DumpRenderTree.cpp:
35609         (runTest): reset the Internals object after each test.
35610
35611 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35612
35613         [Qt] Detect presence of QtUiTools and enable it only when available
35614
35615         The disable_uitools option was a workaround for missing detection.
35616
35617         Reviewed by Simon Hausmann.
35618
35619         * QtTestBrowser/QtTestBrowser.pro:
35620         * qmake/mkspecs/features/default_post.prf:
35621         * qmake/mkspecs/features/default_pre.prf:
35622
35623 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35624
35625         [Qt] Don't override config for the build_pass of debug_and_release
35626
35627         Qmake will parse the profile once for each configuration (debug and
35628         release), with the build_pass option set. In that situation we don't
35629         want to override what qmake is setting explicitly, otherwise the
35630         debug-step will end up hitting all the release-scopes.
35631
35632         Reviewed by Simon Hausmann.
35633
35634         * qmake/mkspecs/features/default_pre.prf:
35635
35636 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35637
35638         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
35639
35640         * qmake/mkspecs/features/functions.prf:
35641
35642 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35643
35644         [Qt] Centralize duplicated code for linking the static libs
35645
35646         Reviewed by Tor Arne Vestbø.
35647
35648         * qmake/mkspecs/features/functions.prf:
35649         * qmake/mkspecs/features/javascriptcore.prf:
35650         * qmake/mkspecs/features/webcore.prf:
35651         * qmake/mkspecs/features/webkit2.prf:
35652
35653 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
35654
35655         [Qt] Build system cleanup
35656         https://bugs.webkit.org/show_bug.cgi?id=71815
35657
35658         Reviewed by Kenneth Rohde Christiansen.
35659
35660         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
35661         static library.
35662         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
35663         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
35664
35665 2011-11-08  Hayato Ito  <hayato@chromium.org>
35666
35667         [NRWT] Make single_test_runner aware of reference filename of test_input.
35668         https://bugs.webkit.org/show_bug.cgi?id=71567
35669
35670         Reviewed by Ryosuke Niwa.
35671
35672         Make single_test_runner honor a reference filename of given test_input so that
35673         we can use any file as reference html, instead of depending on implicit naming convention.
35674         The typical use case is to support w3c reftests.
35675
35676         No tests since no functional changes until there is a client.
35677         Test should be easily written with future clients.
35678
35679         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
35680         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
35681         * Scripts/webkitpy/layout_tests/models/test_failures.py:
35682         * Scripts/webkitpy/layout_tests/models/test_input.py:
35683
35684 2011-11-08  Lucas Forschler  <lforschler@apple.com>
35685
35686         https://bugs.webkit.org/show_bug.cgi?id=71839
35687         Update the leaks bot OS to Lion.
35688         Update the config.json to reflect the update.
35689
35690         Reviewed by Stephanie Lewis.
35691
35692         * BuildSlaveSupport/build.webkit.org-config/config.json:
35693
35694 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
35695
35696         Unreviewed, rolling out r99626.
35697         http://trac.webkit.org/changeset/99626
35698         https://bugs.webkit.org/show_bug.cgi?id=71866
35699
35700         "C++ exceptions cannot be disabled without influencing the
35701         Objective-C exceptions" (Requested by benjaminp on #webkit).
35702
35703         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
35704
35705 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
35706
35707         [Mac] Disable C++ exceptions from DumpRenderTree
35708         https://bugs.webkit.org/show_bug.cgi?id=71834
35709
35710         Reviewed by Darin Adler.
35711
35712         DumpRenderTree Mac does not handle C++ exceptions. When such exception
35713         happens, it tends to cause the AutoReleasePool stack to be corrupted,
35714         which leads to crashes long after the exception was raised.
35715
35716         This patch disabled C++ exceptions in order to catch the problems where
35717         they happen when a C++ exception is raised.
35718
35719         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
35720
35721 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
35722
35723         Moved myself to the reviewer list (yay!).
35724
35725         * Scripts/webkitpy/common/config/committers.py:
35726
35727 2011-11-08  Zeno Albisser  <zeno@webkit.org>
35728
35729         Added myself as a committer.
35730
35731         * Scripts/webkitpy/common/config/committers.py:
35732
35733 2011-11-08  Andy Wingo  <wingo@igalia.com>
35734
35735         Skip some ECMAScript tests that fail on Linux in some time zones.
35736         https://bugs.webkit.org/show_bug.cgi?id=71371
35737
35738         Reviewed by Martin Robinson.
35739
35740         * Scripts/run-javascriptcore-tests: Skip some more tests.
35741
35742 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
35743
35744         [Qt] Unreviewed trivial fix after build system refactoring.
35745
35746         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
35747
35748 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35749
35750         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
35751
35752         If a pro file needs to access the OBJECTS_DIR it should use the
35753         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
35754         after defaults_post has been processed.
35755
35756         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
35757         the command line will override whatever we set in defaults_pre.
35758
35759         Reviewed by Simon Hausmann.
35760
35761         * qmake/mkspecs/features/default_post.prf:
35762         * qmake/mkspecs/features/default_pre.prf:
35763
35764 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35765
35766         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
35767
35768         Reviewed by Simon Hausmann.
35769
35770         * qmake/mkspecs/features/default_post.prf:
35771
35772 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
35773
35774         [Qt][WK2] MiniBrowser should use urlFromUserInput()
35775         https://bugs.webkit.org/show_bug.cgi?id=71680
35776
35777         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
35778         complete urls in MiniBrowser.
35779
35780         Reviewed by Tor Arne Vestbø.
35781
35782         * MiniBrowser/qt/BrowserWindow.cpp:
35783         (BrowserWindow::BrowserWindow):
35784         (BrowserWindow::load):
35785         * MiniBrowser/qt/qml/BrowserWindow.qml:
35786         * MiniBrowser/qt/utils.cpp:
35787         (Utils::urlFromUserInput):
35788         * MiniBrowser/qt/utils.h:
35789         (Utils::Utils):
35790
35791 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
35792
35793         Added myself as a committer.
35794
35795         * Scripts/webkitpy/common/config/committers.py:
35796
35797 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
35798
35799         Unreviewed webkitpy test fix after r99512.
35800
35801         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
35802         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
35803
35804 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
35805
35806         Added myself as a committer.
35807
35808         * Scripts/webkitpy/common/config/committers.py:
35809
35810 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
35811
35812         Unreviewed, rolling out r99470.
35813         http://trac.webkit.org/changeset/99470
35814         https://bugs.webkit.org/show_bug.cgi?id=71740
35815
35816         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
35817
35818         * Scripts/webkitpy/common/config/watchlist:
35819
35820 2011-11-07  Tony Chang  <tony@chromium.org>
35821
35822         [chromium] update flakiness dashboard to reflect current bots
35823
35824         Reviewed by Ojan Vafai.
35825
35826         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
35827             bots and merged linux debug bots into a single bot.
35828         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
35829         (setupExpectationsTest):
35830
35831 2011-11-07  Dana Jansens  <danakj@chromium.org>
35832
35833         Add cc-bugs group to watch changes in chromium graphics
35834         https://bugs.webkit.org/show_bug.cgi?id=71690
35835
35836         Reviewed by James Robinson.
35837
35838         * Scripts/webkitpy/common/config/watchlist:
35839
35840 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
35841
35842         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
35843         https://bugs.webkit.org/show_bug.cgi?id=70912
35844
35845         Reviewed by Ojan Vafai.
35846
35847         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
35848         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
35849
35850 2011-11-07  Eric Seidel  <eric@webkit.org>
35851
35852         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
35853         https://bugs.webkit.org/show_bug.cgi?id=62199
35854
35855         Reviewed by Dirk Pranke.
35856
35857         * Scripts/webkitpy/layout_tests/controllers/manager.py:
35858         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
35859         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
35860
35861 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
35862
35863         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
35864         https://bugs.webkit.org/show_bug.cgi?id=71485
35865
35866         Reviewed by Darin Fisher.
35867
35868         * DumpRenderTree/chromium/EventSender.cpp:
35869         (EventSender::scalePageBy):
35870         * DumpRenderTree/chromium/TestShell.cpp:
35871         (TestShell::resetTestController):
35872
35873 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35874
35875         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
35876
35877         Allows us to not package up the whole Source/JavaScriptCore directory for the
35878         buildbots.
35879
35880         Reviewed-by Simon Hausmann.
35881
35882         * BuildSlaveSupport/built-product-archive:
35883         * Scripts/webkitdirs.pm:
35884         (jscProductDir):
35885
35886 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35887
35888         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
35889
35890         Reviewed-by Simon Hausmann.
35891
35892         * qmake/mkspecs/features/default_post.prf:
35893
35894 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35895
35896         [Qt] Sanitize qmake paths correctly before comparing
35897
35898         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
35899         which caused us to always generate derived webcore sources, but never build
35900         them. The bug has been fixed, and we now also sanitize paths for the injected
35901         bundle derived sources.
35902
35903         Reviewed by Simon Hausmann.
35904
35905         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
35906         * qmake/mkspecs/features/functions.prf:
35907
35908 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
35909
35910         [Qt] Print right order for changing feature defines
35911
35912         Reviewed by Simon Hausmann.
35913
35914         * Scripts/webkitdirs.pm:
35915         (buildQMakeProject):
35916
35917 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
35918
35919         [Qt] Unreviewed trivial fix after build system refactoring.
35920
35921         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
35922
35923 2011-11-06  Eric Seidel  <eric@webkit.org>
35924
35925         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
35926         https://bugs.webkit.org/show_bug.cgi?id=66078
35927
35928         Unreviewed.  Add an assert about the type of "args"
35929         to our Executive Mocks and fix a piece of code
35930         from this patch which was hitting that assert
35931         when executing for real.
35932
35933         * Scripts/webkitpy/common/system/executive_mock.py:
35934         * Scripts/webkitpy/layout_tests/port/webkit.py:
35935
35936 2011-11-06  Eric Seidel  <eric@webkit.org>
35937
35938         Split chunk handling out of prepare_lists_and_print_output to make it more readable
35939         https://bugs.webkit.org/show_bug.cgi?id=71629
35940
35941         Reviewed by Adam Barth.
35942
35943         * Scripts/webkitpy/layout_tests/controllers/manager.py:
35944
35945 2011-11-06  Eric Seidel  <eric@webkit.org>
35946
35947         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
35948         https://bugs.webkit.org/show_bug.cgi?id=66078
35949
35950         Reviewed by Adam Barth.
35951
35952         The runtime feature detection was fixed to work in bug 64472.
35953         In this bug I moved the symbol-based feature detection from
35954         popen() to Executive.run_command and cleaned up the callers
35955         and unittests to make sure that we're correctly parsing the
35956         nm output correctly.  The old code happened to work even though
35957         the runtime-features path was using "str in list" and the
35958         symbol features path was using "str in str" and it just happened
35959         to do what we wanted to.  Now runtime features and symbol feature
35960         blacklists are computed separately (and with better documentation).
35961
35962         This system remains confusing, partially because these are black-lists
35963         which are amended to whatever static blacklist may exist for the
35964         port as part of a Skipped list file.
35965
35966         For example, notice how the runtime feature list only has directory
35967         blacklists for a couple features.  If all features are off,
35968         how do we skip enough tests with only 2 entries in the blacklist map?
35969         The answer is that Windows is the only port to use runtime feature
35970         detection, and the win/Skipped file turns off all the other features
35971         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
35972         which use symbol-based feature detection turn of mathml, wcss, etc
35973         using the blacklists found in _missing_symbol_to_skipped_tests.
35974
35975         I also noticed a couple places where we still referenced xhtmlmp
35976         even though support for such has been removed from WebKit.  Removed those.
35977
35978         This should result in no functional change.
35979
35980         * Scripts/webkitpy/layout_tests/port/gtk.py:
35981          - Use self._filesystem instead of os.path
35982         * Scripts/webkitpy/layout_tests/port/webkit.py:
35983         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
35984
35985 2011-11-06  Dan Bernstein  <mitz@apple.com>
35986
35987         Made show-pretty-diff work when the input path contains spaces.
35988
35989         Reviewed by Anders Carlsson.
35990
35991         * Scripts/show-pretty-diff:
35992
35993 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
35994
35995         [chromium] Use the security origin instead of the URL when checking notification permissions
35996         https://bugs.webkit.org/show_bug.cgi?id=71590
35997
35998         Reviewed by Adam Barth.
35999
36000         * DumpRenderTree/chromium/NotificationPresenter.cpp:
36001         (NotificationPresenter::checkPermission):
36002         * DumpRenderTree/chromium/NotificationPresenter.h:
36003
36004 2011-11-05  Darin Adler  <darin@apple.com>
36005
36006         Fix a small leak in Mac version of LayoutTestController
36007         https://bugs.webkit.org/show_bug.cgi?id=71615
36008
36009         Reviewed by Mark Rowe.
36010
36011         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
36012         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
36013         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
36014
36015 2011-11-04  Eric Seidel  <eric@webkit.org>
36016
36017         Upgrade to the latest Mechanize
36018         https://bugs.webkit.org/show_bug.cgi?id=71594
36019
36020         Reviewed by Adam Barth.
36021
36022         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
36023         Mechanize is no longer two separate libraries, so importing it is much simpler.
36024
36025         * Scripts/webkitpy/thirdparty/__init__.py:
36026
36027 2011-11-04  Stephen Chenney  <schenney@chromium.org>
36028
36029         Crash in ScrollAnimator.cpp
36030         https://bugs.webkit.org/show_bug.cgi?id=69865
36031
36032         The code in ScrollAnimator assumes that horizontal per-page mouse
36033         wheel events cannot happen, which is not true. This patch adds layout
36034         tests for all paging wheel event situations and fixes the broken
36035         horizontal case.
36036
36037         Reviewed by Anders Carlsson
36038
36039         * DumpRenderTree/chromium/EventSender.cpp:
36040         (EventSender::handleMouseWheel): Added the ability to specify that a
36041         mouse wheel event should be paging.
36042
36043 2011-11-04  Eric Seidel  <eric@webkit.org>
36044
36045         Remove deprecated free functions in port.factory
36046         https://bugs.webkit.org/show_bug.cgi?id=71494
36047
36048         Unreviewed.  Fix exception when running new-run-webkit-httpd.
36049
36050         * Scripts/new-run-webkit-httpd:
36051
36052 2011-11-04  Adam Roben  <aroben@apple.com>
36053
36054         Remove Leopard-specific code from build.webkit.org
36055
36056         We don't have any Leopard bots anymore.
36057
36058         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
36059
36060         Reviewed by Mark Rowe.
36061
36062         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
36063         and StopATSServer steps.
36064         (unitTestsSupported): Removed check for mac-leopard.
36065         (TestFactory.__init__): Removed Leopard-specific steps.
36066
36067 2011-11-04  Eric Seidel  <eric@webkit.org>
36068
36069         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
36070         https://bugs.webkit.org/show_bug.cgi?id=71549
36071
36072         Reviewed by Adam Barth.
36073
36074         Several members of Host didn't really belong there
36075         and were instead specific to WebKitPatch, so I've moved
36076         them up onto that class.
36077
36078         * Scripts/webkitpy/common/host.py:
36079         * Scripts/webkitpy/common/host_mock.py:
36080         * Scripts/webkitpy/tool/main.py:
36081         * Scripts/webkitpy/tool/mocktool.py:
36082         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
36083
36084 2011-11-04  Tony Chang  <tony@chromium.org>
36085
36086         garden-o-matic: bring back party time!
36087         https://bugs.webkit.org/show_bug.cgi?id=71582
36088
36089         Reviewed by Adam Barth.
36090
36091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
36092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
36093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
36094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
36095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
36096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
36097
36098 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
36099
36100         [EFL] DRT: Fix the order of the items in the dumped history list.
36101         https://bugs.webkit.org/show_bug.cgi?id=71562
36102
36103         It did not make much sense to hold the history list in a map, as we do not need
36104         the keys. And the printed items must be sorted by target, which is more easily
36105         done with a vector.
36106
36107         Should make tests such as http/tests/navigation/error404-frames.html pass.
36108
36109         Reviewed by Antonio Gomes.
36110
36111         * DumpRenderTree/efl/DumpHistoryItem.cpp:
36112         (compareHistoryItemsByTarget):
36113         (dumpHistoryItem):
36114
36115 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
36116
36117         [Qt] Remove ENABLE_SQLITE from qmake files
36118         https://bugs.webkit.org/show_bug.cgi?id=71546
36119
36120         Reviewed by Simon Hausmann.
36121
36122         * qmake/mkspecs/features/features.prf:
36123         * qmake/mkspecs/features/webcore.prf:
36124
36125 2011-11-04  Adam Barth  <abarth@webkit.org>
36126
36127         watchlist for WebIDL shouldn't trigger on Internals.idl
36128         https://bugs.webkit.org/show_bug.cgi?id=70657
36129
36130         Reviewed by David Levin.
36131
36132         Internals.idl isn't part of the Web-facing IDL in the project.
36133
36134         * Scripts/webkitpy/common/config/watchlist:
36135
36136 2011-11-04  Anders Carlsson  <andersca@apple.com>
36137
36138         Fix WKTR crash when running NPN_ConvertPoint test.
36139
36140         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
36141
36142         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
36143         (ConvertPoint::NPP_SetWindow):
36144
36145 2011-11-04  Anders Carlsson  <andersca@apple.com>
36146
36147         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
36148         https://bugs.webkit.org/show_bug.cgi?id=71570
36149
36150         Reviewed by Simon Fraser.
36151
36152         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
36153         (PluginTest::NPP_SetWindow):
36154         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
36155         Remove the NPP parameter from NPP_SetWindow.
36156
36157         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
36158         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
36159         Remove the NPP parameter from NPP_SetWindow.
36160
36161         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
36162         (PassDifferentNPPStruct::NPP_SetWindow):
36163         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
36164
36165         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
36166         (ConvertPoint::NPP_SetWindow):
36167         Run the test from NPP_SetWindow and call notifyDone() when done.
36168
36169         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
36170         (NPP_SetWindow):
36171         Remove unnecessary parameter.
36172
36173 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
36174
36175         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
36176
36177         Rubber-stamped by Tor Arne Vestbø.
36178
36179         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
36180         changed slightly after the refactoring.
36181
36182 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36183
36184         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
36185
36186         Reviewed by Simon Hausmann.
36187
36188         * qmake/mkspecs/features/default_pre.prf:
36189
36190 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36191
36192         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
36193
36194         Reviewed by Simmon Hausmann.
36195
36196         * qmake/mkspecs/features/default_pre.prf:
36197
36198 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36199
36200         [Qt] Disable STDIN check before cleaning build dir
36201
36202         It didn't work on the bots.
36203
36204         Reviewed by Ossy.
36205
36206         * Scripts/webkitdirs.pm:
36207
36208 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36209
36210         [Qt] Don't build all of webkit when running build-jsc
36211
36212         In case the whole webkit project was built, but we then subsequently
36213         want to build only JSC, we need to run make in the proper subdirectory.
36214
36215         This also means the incremental target needs to be added to all
36216         makefiles.
36217
36218         Reviewed by Simmon Hausmann.
36219
36220         * Scripts/webkitdirs.pm:
36221         (buildQMakeProject):
36222         * qmake/mkspecs/features/default_post.prf:
36223
36224 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
36225
36226         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
36227
36228         Reviewed by Tor Arne Vestbø.
36229
36230         * Scripts/webkitdirs.pm:
36231         (jscProductDir): jsc path changed.
36232
36233 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36234
36235         [Qt] Error out early if trying to build against Qt < 4.8
36236
36237         Reviewed by Simon Hausmann.
36238
36239         * qmake/mkspecs/features/default_pre.prf:
36240
36241 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
36242
36243         Fix run-launcher for Qt and Gtk.
36244
36245         Rubber-stamped by Tor Arne Vestbø.
36246
36247         * Scripts/webkitdirs.pm:
36248         (isWK2): Re-add isWK2(), as it's used in run-launcher.
36249
36250 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36251
36252         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
36253
36254         Reviewed by Simon Hausmann.
36255
36256         * Scripts/build-webkit:
36257
36258 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
36259
36260         [GTK] Use web view title as window title in MiniBrowser
36261         https://bugs.webkit.org/show_bug.cgi?id=71544
36262
36263         Reviewed by Philippe Normand.
36264
36265         * MiniBrowser/gtk/BrowserWindow.c:
36266         (webViewURIChanged): Removed extra space.
36267         (webViewTitleChanged): Set window title using
36268         webkit_web_view_get_title().
36269         (browser_window_init): Set initial default window title.
36270         (browserWindowConstructed): Connect to WebView notify::title
36271         signal.
36272
36273 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
36274
36275         [Qt] Refactor and clean up the qmake build system
36276
36277         The qmake build system has accumulated a bit of cruft and redundancy
36278         over time. There's also a fairly tight coupling between how to build
36279         the various targets, and _what_ to build, making it harder to add new
36280         rules or sources. This patch aims to elevate these issues somewhat.
36281
36282         This is a short-list of the changes:
36283
36284           * The rules for how to build targets are now mostly contained as
36285             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
36286             allows us to do pre- and post-processing of each project file,
36287             which helps to clean up the actual project files.
36288
36289           * Derived sources are no longer generated as a separate make-step
36290             but is part of each target's project file as a subdir. Makefile
36291             rules are used to ensure that we run make on the derived sources
36292             before running qmake on the actual target makefile. This makes
36293             it easier to keep a proper dependency between derived sources
36294             and the target.
36295
36296           * We use GNU make and the compiler to generate dependencies on
36297             UNIX-based systems running Qt 5. This allows us to lessen the
36298             need to run qmake, which should reduce compile time.
36299
36300           * WebKit2 is now build by default if building with Qt 5. It can
36301             be disabled by passing --no-webkit2 to build-webkit.
36302
36303         The result of these changes are hopefully a cleaner and easier
36304         build system to modify, and faster build times due to no longer
36305         running qmake on every single build. It's also a first step
36306         towards possibly generating the list of sources using another
36307         build system.
36308
36309         https://bugs.webkit.org/show_bug.cgi?id=71222
36310
36311         Reviewed by Simon Hausmann.
36312
36313         * DerivedSources.pro: Removed.
36314         * DumpRenderTree/qt/DumpRenderTree.pro:
36315         * DumpRenderTree/qt/ImageDiff.pro:
36316         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
36317         * MiniBrowser/qt/MiniBrowser.pro:
36318         * QtTestBrowser/QtTestBrowser.pro:
36319         * QtTestBrowser/launcherwindow.cpp:
36320         (LauncherWindow::initializeView):
36321         (LauncherWindow::createChrome):
36322         (LauncherWindow::screenshot):
36323         * QtTestBrowser/launcherwindow.h:
36324         (WindowOptions::WindowOptions):
36325         * Scripts/build-webkit:
36326         (unlinkZeroFiles):
36327         * Scripts/webkitdirs.pm:
36328         (qtFeatureDefaults):
36329         (promptUser):
36330         (buildQMakeProject):
36331         * Tools.pro:
36332         * WebKitTestRunner/DerivedSources.pri: Added.
36333         * WebKitTestRunner/DerivedSources.pro: Removed.
36334         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
36335         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
36336         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
36337         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
36338         * WebKitTestRunner/Target.pri: Added.
36339         * WebKitTestRunner/WebKitTestRunner.pro:
36340         * WebKitTestRunner/qt/TestInvocationQt.cpp:
36341         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
36342         * qmake/README: Added.
36343         * qmake/mkspecs/features/default_post.prf: Added.
36344         * qmake/mkspecs/features/default_pre.prf: Added.
36345         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
36346         * qmake/mkspecs/features/functions.prf: Added.
36347         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
36348         * qmake/mkspecs/features/mac/default_post.prf: Added.
36349         * qmake/mkspecs/features/mac/default_pre.prf: Added.
36350         * qmake/mkspecs/features/minimal_qt.prf: Added.
36351         * qmake/mkspecs/features/qtwebkit.prf: Added.
36352         * qmake/mkspecs/features/rpath.prf: Added.
36353         * qmake/mkspecs/features/unix/default_post.prf: Added.
36354         * qmake/mkspecs/features/unix/default_pre.prf: Added.
36355         * qmake/mkspecs/features/valgrind.prf: Added.
36356         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
36357         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
36358         * qmake/mkspecs/features/win32/default_post.prf: Added.
36359         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
36360         * qmake/syncqt-4.8: Added.
36361         (showUsage):
36362         ():
36363         (copyFile):
36364         (symlinkFile):
36365
36366 2011-11-04  Eric Seidel  <eric@webkit.org>
36367
36368         Remove deprecated free functions in port.factory
36369         https://bugs.webkit.org/show_bug.cgi?id=71494
36370
36371         Unreviewed.  Fixing exception seen when running test-webkitpy.
36372
36373         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
36374         unittest, since that script is nearly ready to be deleted.  But I added
36375         it back at the last second and failed to run the tests. :(
36376         This fixes the exception the bots were seeing.
36377
36378         * Scripts/webkitpy/style/checkers/test_expectations.py:
36379         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
36380         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
36381
36382 2011-11-02  Xiaomei Ji  <xji@chromium.org>
36383
36384         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
36385         https://bugs.webkit.org/show_bug.cgi?id=71163
36386
36387         Reviewed by Ryosuke Niwa.
36388
36389         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
36390         (WebPreferences::applyTo):
36391
36392 2011-11-03  Eric Seidel  <eric@webkit.org>
36393
36394         Remove deprecated free functions in port.factory
36395         https://bugs.webkit.org/show_bug.cgi?id=71494
36396
36397         Reviewed by Adam Barth.
36398
36399         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
36400         free functions in factory.py.  To remove these required fixing all callsites
36401         to use MockHost, Host, or PortFactory where appropriate.  After this change
36402         we're only left with a handfull of places where we inappropraitely use a
36403         real Executive, FileSystem or User object during unittesting.
36404
36405         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
36406          - These PortFactory overrides were from an earlier edition of my previous patch
36407            in the end, I removed MockPortFactory so all tests ended up with this same
36408            real PortFactory() with a MockHost.  This was simply redundent code.
36409         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
36410          - Use MockHost to get a mocked-out PortFactory.
36411         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
36412          - This code has no access to a Host object, so we just use a default PortFactory
36413            for now.  This will still incorrectly create real Executive/FileSystem objects
36414            durring unittesting, which is wrong. :(
36415         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
36416          - Use a MockHost to get a mocked PortFactory.
36417         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
36418          - Use a MockHost to get a mocked PortFactory.
36419         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
36420          - ditto.
36421         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
36422          - ditto.
36423         * Scripts/webkitpy/layout_tests/port/__init__.py:
36424          - factory.get no longer exists.  Yay!
36425         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
36426          - Use a MockHost to get a mocked PortFactory.
36427            To do this efficiently, I created a helper function
36428            and combined all these (mostly redundant) tests into one test
36429            with several calls to the helper function.
36430         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
36431          - Pass MockUser and MockExecutive in these port testing subclasses.
36432          - I also removed a bunch of unecessary uses of mocktool. namespacing.
36433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
36434          - Awesome windows hacks should only happen on win32.  Once we started
36435            using MockExecutives these 'svn help' commands started printing in
36436            other tests, which is how I found this bug.
36437         * Scripts/webkitpy/layout_tests/port/dryrun.py:
36438          - DryRunPort has no Host, so just use a PortFactory() directly.
36439            This will do the wrong thing if we're unittesting the DryRun port
36440            but it's no worse than the existing code.
36441         * Scripts/webkitpy/layout_tests/port/factory.py:
36442          - Remove the free functions.
36443          - Fix argument overriding to be able to override None.
36444         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
36445          - Use a mocked-out PortFactory during testing.
36446         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
36447          - Pass MockExecutive and MockUser to these manual Port instantiations.
36448         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
36449          - No access to a Host object here, so just using PortFactory directly.
36450            This is wrong, but no more wrong than the existing code was.
36451         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
36452          - Use a MockHost to get a mocked out PortFactory.
36453         * Scripts/webkitpy/layout_tests/port/test.py:
36454          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
36455         * Scripts/webkitpy/layout_tests/port/win.py:
36456          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
36457            now that we're actually passing MockExecutive to most Port instantiations during testing.
36458         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
36459          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
36460         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
36461          - Host is the future.
36462         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
36463          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
36464            we don't need to pass MockUser explicitly, it does that automatically for us.
36465         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
36466          - Use a MockHost to get a mocked out PortFactory.
36467         * Scripts/webkitpy/style/checkers/test_expectations.py:
36468          - We don't have access to a Host object, so using PortFactory() directly.
36469         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
36470          - Remove unused variable.
36471         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
36472          - Host isn't accessible here, so using PortFactory() directly, which
36473            although unfortunate is no worse than before.
36474         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
36475          - Testing is much easier when you don't need to hack global state...
36476         * Scripts/webkitpy/tool/commands/expectations.py:
36477          - Use the port_factory on the tool.
36478         * Scripts/webkitpy/tool/commands/rebaseline.py:
36479          - ditto.
36480         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
36481          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
36482            the arguments in the right order.  Fixing that made it use a MockFileSystem
36483            (like it had been trying to), which then required us to actually populate
36484            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
36485         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
36486          - Get the port_factory from the tool.
36487         * Scripts/webkitpy/tool/servers/gardeningserver.py:
36488          - Ditto.
36489         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
36490          - Use a MockHost to get a mocked out Port object.
36491
36492 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
36493
36494         [EFL] DRT: Allow choosing which backing store to use.
36495         https://bugs.webkit.org/show_bug.cgi?id=70532
36496
36497         Reviewed by Antonio Gomes.
36498
36499         This change makes it possible to change the backing store used by DRT
36500         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
36501         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
36502
36503         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
36504         (DumpRenderTreeChrome::createView):
36505         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
36506         (shouldUseSingleBackingStore):
36507         (chooseAndInitializeAppropriateSmartClass):
36508         (drtViewAdd):
36509         * DumpRenderTree/efl/DumpRenderTreeView.h:
36510
36511 2011-11-02  Erik Arvidsson  <arv@chromium.org>
36512
36513         JS Test Harness: Remove more link tags
36514         https://bugs.webkit.org/show_bug.cgi?id=71339
36515
36516         Reviewed by Ojan Vafai.
36517
36518         * Scripts/make-new-script-test:
36519         (writeTestFile): Don't output <link>
36520
36521 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
36522
36523         Reviewed by Martin Robinson.
36524
36525         [GTK] arguments passed to build-jsc are not taken into account
36526         https://bugs.webkit.org/show_bug.cgi?id=58333
36527
36528         * Scripts/build-jsc:
36529
36530 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
36531
36532         [GTK] Show url of history items in a status bar in MiniBrowser
36533         https://bugs.webkit.org/show_bug.cgi?id=71474
36534
36535         Reviewed by Martin Robinson.
36536
36537         * MiniBrowser/gtk/BrowserWindow.c:
36538         (browserWindowSetStatusText): Set status text and show/hide the
36539         status label.
36540         (resetStatusText): Reset status text when history menu is hidden.
36541         (browserWindowHistoryItemSelected): Show url of currently selected
36542         history item.
36543         (browserWindowCreateBackForwardMenu): Connect to hide signal of
36544         menu to reset the status text.
36545         (browserWindowConstructed): Use GtkOverlay if available to show
36546         status text.
36547
36548 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
36549
36550         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
36551         https://bugs.webkit.org/show_bug.cgi?id=71466
36552
36553         Reviewed by Martin Robinson.
36554
36555         * MiniBrowser/gtk/BrowserWindow.c:
36556         (browserWindowHistoryItemActivated): Go to selected back formard
36557         list item using webkit_web_view_go_to_back_forward_list_item()
36558         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
36559         given GList of WebKitBackForwardListItems.
36560         (browserWindowUpdateNavigationActions): Enable/disable back and
36561         forward buttons depending on whether it's possible to go
36562         back/forward. Create a menu for back and forward toolbar buttons.
36563         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
36564         (browserWindowConstructed): Connect to WebKitBackForwardList
36565         changed signal.
36566
36567 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
36568
36569         [Qt] Remove Maemo specific code paths
36570         https://bugs.webkit.org/show_bug.cgi?id=71476
36571
36572         Reviewed by Kenneth Rohde Christiansen.
36573
36574         * QtTestBrowser/launcherwindow.cpp:
36575         (LauncherWindow::~LauncherWindow):
36576         (LauncherWindow::init):
36577         (LauncherWindow::showLinkHover):
36578         (LauncherWindow::selectElements):
36579         (LauncherWindow::showFPS):
36580         (LauncherWindow::updateFPS):
36581         * QtTestBrowser/launcherwindow.h:
36582         (WindowOptions::WindowOptions):
36583         * QtTestBrowser/locationedit.cpp:
36584         * QtTestBrowser/locationedit.h:
36585
36586 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
36587
36588         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
36589         https://bugs.webkit.org/show_bug.cgi?id=71461
36590
36591         Reviewed by Martin Robinson.
36592
36593         * MiniBrowser/gtk/BrowserWindow.c:
36594         (resetEntryProgress): Reset the entry progress after a while when
36595         load has been completed.
36596         (webViewLoadProgressChanged): Update location entry progress.
36597         (browserWindowConstructed): Connect to WebView
36598         notify::estimated-load-progress signal.
36599
36600 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
36601
36602         [GTK] Remove WebKit2 C API from MiniBrowser
36603         https://bugs.webkit.org/show_bug.cgi?id=71459
36604
36605         Reviewed by Martin Robinson.
36606
36607         Use the GTK+ API instead to add minimum functionality. The other
36608         features will be ported to GTK+ API in following patches.
36609
36610         * MiniBrowser/gtk/BrowserWindow.c:
36611         (activateUriEntryCallback): Use webkit_web_view_load_uri().
36612         (goBackCallback): Use webkit_web_view_go_back().
36613         (goForwardCallback): Use webkit_web_view_go_forward().
36614         (webViewURIChanged): Update location entry with current uri using
36615         webkit_web_view_get_uri().
36616         (browserWindowFinalize):
36617         (browserWindowGetProperty):
36618         (browserWindowSetProperty):
36619         (browser_window_init):
36620         (browserWindowConstructed): Connect to notify::uri signal of
36621         WebView to be notified when the URI changes.
36622         (browser_window_class_init):
36623         (browser_window_new): Use WebKitWebView.
36624         (browser_window_get_view): Use WebKitWebView
36625         * MiniBrowser/gtk/BrowserWindow.h:
36626         * MiniBrowser/gtk/GNUmakefile.am:
36627         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
36628         * MiniBrowser/gtk/main.c:
36629         (loadURI): Use webkit_web_view_new().
36630         (main):
36631
36632 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
36633
36634         [Qt] Unable to start MiniBrowser after run-webkit-tests
36635         https://bugs.webkit.org/show_bug.cgi?id=71469
36636
36637         Reviewed by Csaba Osztrogonác.
36638
36639         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
36640         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
36641         line arguments.
36642
36643 2011-11-03  Philippe Normand  <pnormand@igalia.com>
36644
36645         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
36646         https://bugs.webkit.org/show_bug.cgi?id=71445
36647
36648         Reviewed by Martin Robinson.
36649
36650         * DumpRenderTree/gtk/DumpRenderTree.cpp:
36651         (initializeFonts): set directoriesDescription only when needed.
36652         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
36653         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
36654         refactored the font files loading code to avoid copy/pastes, ease
36655         maintenance and future font directories additions.
36656
36657 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
36658
36659         [GTK] Remove GtkLauncher2
36660         https://bugs.webkit.org/show_bug.cgi?id=71449
36661
36662         Reviewed by Martin Robinson.
36663
36664         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
36665         made sense when we wanted to implement the exactly same wk1 API
36666         for wk2. Now the code would require an ifdef for most the api, so
36667         it's better to remove GtkLauncher2 and port MiniBrowser to the new
36668         GTK+ API.
36669
36670         * GNUmakefile.am:
36671         * GtkLauncher/main.c:
36672         (notifyProgressCb):
36673         (closeWebViewCb):
36674         (createBrowser):
36675         (addWebSettingsGroupToContext):
36676         (main):
36677
36678 2011-11-02  Philippe Normand  <pnormand@igalia.com>
36679
36680         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
36681         https://bugs.webkit.org/show_bug.cgi?id=71359
36682
36683         Reviewed by Martin Robinson.
36684
36685         * DumpRenderTree/gtk/DumpRenderTree.cpp:
36686         (initializeFonts): Add the new font path for Debian fonts and
36687         refactored the font files loading code to avoid copy/pastes, ease
36688         maintenance and future font directories additions.
36689
36690 2011-11-02  Eric Seidel  <eric@webkit.org>
36691
36692         Move Mocks into _mock files near their implementations
36693         https://bugs.webkit.org/show_bug.cgi?id=71425
36694
36695         Reviewed by Adam Barth.
36696
36697         This entire change is splitting mocktool.py into separate _mock.py files
36698         and placing them next to their real implementations.
36699
36700         I also deleted MockPortFactory (since it was wrong) and was just hiding
36701         the fact that the "skipped-ports" command was broken (and has been for a long time).
36702         So I made MockHost use a real PortFactory (passed a MockHost) and changed
36703         the skipped-ports implementation to use modern PortFactory methods.
36704
36705         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
36706         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
36707         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
36708         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
36709         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
36710         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
36711         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
36712         * Scripts/webkitpy/common/host.py:
36713         * Scripts/webkitpy/common/host_mock.py: Added.
36714         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
36715         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
36716         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
36717         * Scripts/webkitpy/common/net/credentials_unittest.py:
36718         * Scripts/webkitpy/common/net/failuremap_unittest.py:
36719         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
36720         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
36721         * Scripts/webkitpy/common/net/statusserver_unittest.py:
36722         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
36723         * Scripts/webkitpy/common/system/executive.py:
36724         * Scripts/webkitpy/common/system/executive_mock.py:
36725         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
36726         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
36727         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
36728         * Scripts/webkitpy/common/system/workspace_unittest.py:
36729         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
36730         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
36731         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
36732         * Scripts/webkitpy/layout_tests/port/__init__.py:
36733         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
36734         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
36735         * Scripts/webkitpy/layout_tests/port/factory.py:
36736         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
36737         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
36738         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
36739         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
36740         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
36741         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
36742         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
36743         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
36744         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
36745         * Scripts/webkitpy/test/main.py:
36746         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
36747         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
36748         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
36749         * Scripts/webkitpy/tool/commands/queries_unittest.py:
36750         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
36751         * Scripts/webkitpy/tool/mocktool.py:
36752         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
36753
36754 2011-11-02  Dan Bernstein  <mitz@apple.com>
36755
36756         Fixed the build and removed another copy to ColorBits.ttf.
36757
36758         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
36759         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
36760         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
36761
36762 2011-11-02  Dan Bernstein  <mitz@apple.com>
36763
36764         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
36765         https://bugs.webkit.org/show_bug.cgi?id=71424
36766
36767         Reviewed by Sam Weinig.
36768
36769         Removed the ColorBits font and the code to register it in the process
36770         running the tests. The font was only used by the aforementioned test,
36771         which is now being removed.
36772
36773         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
36774         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
36775         * DumpRenderTree/mac/DumpRenderTree.mm:
36776         (allowedFontFamilySet):
36777         (activateTestingFonts):
36778         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
36779         (WTR::inititializeFontConfigSetting):
36780         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
36781         (WTR::allowedFontFamilySet):
36782         (WTR::activateFonts):
36783
36784 2011-11-02  Dan Bernstein  <mitz@apple.com>
36785
36786         Fix an intermittent hang in RenderedImageFromDOMRange.
36787
36788         Reviewed by Anders Carlsson.
36789
36790         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
36791         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
36792         immediately if there are no sources by passing a date in the distant past.
36793
36794 2011-11-02  Adam Roben  <aroben@apple.com>
36795
36796         Add git-add-reviewer
36797
36798         I've been using this script for a while to add reviewers to git commits in my local
36799         repository before pushing them to the Subversion repository. Basic usage is:
36800
36801         git-add-reviewer HEAD^ "Joe Schmoe"
36802         or
36803         git-add-reviewer -i trunk
36804
36805         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
36806         git commits
36807
36808         Reviewed by Sam Weinig.
36809
36810         * Scripts/git-add-reviewer: Added.
36811         (top level): Parse options, check that the working tree is clean, then run in either
36812         interactive or non-interactive mode as appropriate.
36813         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
36814         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
36815         editor exits, we check out the commit just before the earliest one we're modifying. Then
36816         for each commit, we check it out, update the reviewer, and amend the commit to contain the
36817         new reviewer. Finally, we update the branch that was originally checked out to point to the
36818         last amended commit.
36819         (nonInteractive): Check out the commit to modify, write the current commit message to the
36820         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
36821         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
36822         a usage message and exit.
36823         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
36824         and index are clean.
36825         (fail): Print out the specified error message, if any, and return false. This function is
36826         used as a return value in various error cases throughout the script.
36827         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
36828         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
36829         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
36830         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
36831
36832         (addReviewerToChangeLog):
36833         (addReviewerToCommitMessage):
36834         These just call through to addReviewerToFile.
36835
36836         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
36837         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
36838         temp file, then move the temp file over the original file and stage it for the next commit.
36839         (head): Returns the name of the currently-checked-out branch.
36840         (isAncestor): Returns true if the first commit is an ancestor of the second.
36841         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
36842         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
36843         (resetToCommit): Checks out the given commit, throwing away any local changes.
36844         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
36845         the specified file.
36846         (rebaseOntoHead): Rebases the specified branch onto HEAD.
36847         (checkout): Checks out the given commit.
36848         (getConfigValue): Reads the specified config variable from git-config.
36849
36850 2011-11-02  Dean Jackson  <dino@apple.com>
36851
36852         Add ENABLE_CSS_SHADERS flag
36853         https://bugs.webkit.org/show_bug.cgi?id=71394
36854
36855         Reviewed by Sam Weinig.
36856
36857         * Scripts/build-webkit:
36858
36859 2011-10-31  Eric Seidel  <eric@webkit.org>
36860
36861         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
36862         https://bugs.webkit.org/show_bug.cgi?id=71237
36863
36864         Reviewed by Adam Barth.
36865
36866         Calling the static version of factory.get() with proper mocking
36867         requires passsing an explict filesystem, executive, etc.
36868         So instead, we use a PortFactory instance and pass it a Host pointer.
36869         I had to add a MockHost since we'd not needed a non-host tool before now.
36870
36871         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
36872         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
36873         * Scripts/webkitpy/tool/commands/rebaseline.py:
36874         * Scripts/webkitpy/tool/mocktool.py:
36875
36876 2011-11-02  Anders Carlsson  <andersca@apple.com>
36877
36878         Update for the WebKit2 API fixage.
36879
36880         * MiniBrowser/mac/BrowserWindowController.m:
36881         (-[BrowserWindowController awakeFromNib]):
36882         * WebKitTestRunner/TestController.cpp:
36883         (WTR::TestController::initialize):
36884
36885 2011-11-02  Anders Carlsson  <andersca@apple.com>
36886
36887         Fix build.
36888
36889         Add new functions to the page loader client.
36890
36891         * MiniBrowser/mac/BrowserWindowController.m:
36892         (-[BrowserWindowController awakeFromNib]):
36893         * WebKitTestRunner/TestController.cpp:
36894         (WTR::TestController::initialize):
36895
36896 2011-11-02  Dan Bernstein  <mitz@apple.com>
36897
36898         <rdar://problem/10336700> Add API to get rendered text image without having to select it
36899         https://bugs.webkit.org/show_bug.cgi?id=71407
36900
36901         Reviewed by Simon Fraser.
36902
36903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
36904         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
36905         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
36906         (TestWebKitAPI::TEST):
36907
36908 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
36909
36910         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
36911         https://bugs.webkit.org/show_bug.cgi?id=71351
36912
36913         Reviewed by Darin Adler.
36914
36915         Add the delimiter "/" at the end of the path instead of adding +1 when using
36916         the path.
36917
36918         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
36919         (-[NSURL _drt_descriptionSuitableForTestResult]):
36920
36921 2011-11-02  Tom Sepez  <tsepez@chromium.org>
36922
36923         XSSAuditor is silent
36924         https://bugs.webkit.org/show_bug.cgi?id=70973
36925
36926         Reviewed by Adam Barth.
36927
36928         * DumpRenderTree/chromium/WebViewHost.cpp:
36929         (WebViewHost::didDetectXSS):
36930         * DumpRenderTree/chromium/WebViewHost.h:
36931         * DumpRenderTree/mac/FrameLoadDelegate.mm:
36932         (-[FrameLoadDelegate webView:didDetectXSS:]):
36933         * MiniBrowser/mac/BrowserWindowController.m:
36934         (didDetectXSSForFrame):
36935         (-[BrowserWindowController awakeFromNib]):
36936         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
36937         (WTR::InjectedBundlePage::InjectedBundlePage):
36938         (WTR::InjectedBundlePage::didDetectXSSForFrame):
36939         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
36940
36941 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
36942
36943         [Qt] REGRESSION: 5 editing tests fail
36944         https://bugs.webkit.org/show_bug.cgi?id=71117
36945
36946         Reviewed by Andreas Kling.
36947
36948         Make sure that the view is properly focused, in order to get the
36949         didBeginEditing DRT calls.
36950
36951         This requires activating the window (the call will result in a FocusIn
36952         event to the window as well as setting QGuiApplication::focusWindow())
36953         as well as enabling the focus on the view item. The signature of
36954         setFocus has changed to take a boolean.
36955
36956         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
36957         (WTR::WrapperWindow::handleStatusChanged):
36958
36959 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
36960
36961         [chromium] Add per-script font preferences support in overridePreference
36962         https://bugs.webkit.org/show_bug.cgi?id=71110
36963
36964         This allows a layout test to do something like:
36965
36966         // Set standard font for Arabic to Ahem.
36967         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
36968
36969         This should make writing a layout test for per-script fonts easier.
36970
36971         This change only affects the Chromium DumpRenderTree, but the other
36972         platforms should probably also have a similar change eventually.
36973
36974         Reviewed by Tony Chang.
36975
36976         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
36977         font preferences to overridePreference
36978         (LayoutTestController::cppVariantToWebStringArray):
36979         (setFontMap):
36980         (LayoutTestController::overridePreference):
36981         * DumpRenderTree/chromium/LayoutTestController.h:
36982         * DumpRenderTree/chromium/WebPreferences.cpp:
36983         (setStandardFontFamilyWrapper):
36984         (setFixedFontFamilyWrapper):
36985         (setSerifFontFamilyWrapper):
36986         (setSansSerifFontFamilyWrapper):
36987         (setCursiveFontFamilyWrapper):
36988         (setFantasyFontFamilyWrapper):
36989         (applyFontMap):
36990         (WebPreferences::applyTo):
36991         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
36992         preference members
36993         (WebPreferences::UScriptCodeHashTraits::emptyValue):
36994         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
36995         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
36996
36997 2011-11-02  Elliot Poger  <epoger@google.com>
36998
36999         until use_skia=1 by default on mac, default port should be chromium-cg-mac
37000         https://bugs.webkit.org/show_bug.cgi?id=71312
37001
37002         Reviewed by Adam Barth.
37003
37004         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
37005         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
37006         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
37007
37008 2011-11-02  Stephen Chenney  <schenney@chromium.org>
37009
37010         printing layout test failures after r98634
37011         https://bugs.webkit.org/show_bug.cgi?id=71080
37012
37013         Reviewed by Kent Tamura
37014
37015         * DumpRenderTree/chromium/WebViewHost.cpp:
37016         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
37017         matches that for Skia.
37018
37019 2011-11-01  Sam Weinig  <sam@webkit.org>
37020
37021         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
37022         https://bugs.webkit.org/show_bug.cgi?id=71346
37023
37024         Reviewed by Dan Bernstein.
37025
37026         * Scripts/webkit-tools-completion.sh:
37027         Add "-o default" which allows for completing files in addition to the word list.
37028
37029 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
37030
37031         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
37032         https://bugs.webkit.org/show_bug.cgi?id=71310
37033
37034         Reviewed by Kenneth Rohde Christiansen.
37035
37036         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
37037         define works in EventSendingController.idl
37038         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
37039         handlers.
37040         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
37041         required by tests.
37042         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
37043         ui process.
37044         (WTR::EventSendingController::addTouchPoint):
37045         (WTR::EventSendingController::updateTouchPoint):
37046         (WTR::EventSendingController::setTouchModifier):
37047         (WTR::EventSendingController::touchStart):
37048         (WTR::EventSendingController::touchMove):
37049         (WTR::EventSendingController::touchEnd):
37050         (WTR::EventSendingController::clearTouchPoints):
37051         (WTR::EventSendingController::releaseTouchPoint):
37052         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
37053         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
37054         defines.
37055         * WebKitTestRunner/TestController.cpp:
37056         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
37057         touch messages to the EventSenderProxy.
37058         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
37059         (WTR::EventSenderProxy::EventSenderProxy):
37060         (WTR::EventSenderProxy::addTouchPoint):
37061         (WTR::EventSenderProxy::updateTouchPoint):
37062         (WTR::EventSenderProxy::setTouchModifier):
37063         (WTR::EventSenderProxy::touchStart):
37064         (WTR::EventSenderProxy::touchMove):
37065         (WTR::EventSenderProxy::touchEnd):
37066         (WTR::EventSenderProxy::clearTouchPoints):
37067         (WTR::EventSenderProxy::releaseTouchPoint):
37068         (WTR::EventSenderProxy::sendTouchEvent):
37069         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
37070
37071 2011-11-01  Sam Weinig  <sam@webkit.org>
37072
37073         resolve-ChangeLogs --help should be faster.
37074
37075         Reviewed by Adam Roben.
37076
37077         * Scripts/resolve-ChangeLogs:
37078         (usageAndExit):
37079         Add a call to usageAndExit() before doing work to find unmerged changelogs
37080         if --help or something illegal is provided on the command line.
37081
37082 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
37083
37084         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
37085         https://bugs.webkit.org/show_bug.cgi?id=71342
37086
37087         Reviewed by Darin Adler.
37088
37089         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
37090         [NSString substringFromIndex:] with an index out of the string range.
37091
37092         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
37093         from the root of the disk.
37094         The problem was hidden because the exception are catched when calling the delegate.
37095
37096         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
37097         in a subdirectory of the main frame.
37098
37099         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
37100         (-[NSURL _drt_descriptionSuitableForTestResult]):
37101
37102 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
37103
37104         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
37105         https://bugs.webkit.org/show_bug.cgi?id=71318
37106
37107         Reviewed by James Robinson.
37108
37109         Fixed a typo for --enable-hardware-gpu flag.
37110
37111         * Scripts/webkitpy/layout_tests/port/chromium.py:
37112
37113 2011-11-01  Elliot Poger  <epoger@google.com>
37114
37115         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
37116         https://bugs.webkit.org/show_bug.cgi?id=71286
37117
37118         Reviewed by Stephen White.
37119
37120         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
37121
37122 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
37123
37124         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
37125         https://bugs.webkit.org/show_bug.cgi?id=71299
37126
37127         Reviewed by Andreas Kling.
37128
37129         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
37130         build to enable WebCoreTestSupport::injectInternalsObject.
37131         (WTR::InjectedBundlePage::didClearWindowForFrame):
37132         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
37133
37134 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
37135
37136         [Qt] Merge common desktop and touch view APIs under a base class.
37137         https://bugs.webkit.org/show_bug.cgi?id=71280
37138
37139         Reviewed by Andreas Kling.
37140
37141         Remove unneded forwarding logic for TouchWebView since those properties are
37142         now in the view just as the desktop web view.
37143
37144         * MiniBrowser/qt/qml/TouchView.qml:
37145
37146 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
37147
37148         check-webkit-style: Allow names starting with "_q_".
37149         https://bugs.webkit.org/show_bug.cgi?id=70625
37150
37151         Reviewed by Tor Arne Vestbø.
37152
37153         Used by the Qt port as the standard prefix for private slots.
37154
37155         * Scripts/webkitpy/style/checkers/cpp.py:
37156         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
37157
37158 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
37159
37160         [Qt][WK2] Fix valgrind error about uninitialized variable
37161         https://bugs.webkit.org/show_bug.cgi?id=71273
37162
37163         Reviewed by Kenneth Christiansen.
37164
37165         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37166         (MiniBrowserApplication::notify): Initialize isPrimary.
37167
37168 2011-10-31  Adam Roben  <aroben@apple.com>
37169
37170         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
37171
37172         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
37173         leaky builds
37174
37175         Reviewed by Anders Carlsson.
37176
37177         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
37178         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
37179         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
37180         total of N bytes!").
37181
37182 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
37183
37184         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
37185         https://bugs.webkit.org/show_bug.cgi?id=71228
37186
37187         Reviewed by Antonio Gomes.
37188
37189         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
37190         (DumpRenderTreeChrome::createNewWindow):
37191         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
37192
37193 2011-10-31  Eric Seidel  <eric@webkit.org>
37194
37195         webkitpy tests depend too much on the user's environment
37196         https://bugs.webkit.org/show_bug.cgi?id=71234
37197
37198         Reviewed by Dirk Pranke.
37199
37200         This change just makes a bunch of our older tests use
37201         more modern mocking to avoid trying to launch processes
37202         or read from the user's filesystem during unittesting.
37203
37204         I found many of these by adding an assert in Executive.run_command
37205         that we were not unittesting.  I can't add that assert always
37206         as there are some valid uses of Executive during unittesting.
37207         Once I fix more of these, I may find a way to add such an assert conditionally.
37208
37209         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
37210         * Scripts/webkitpy/common/net/credentials_unittest.py:
37211         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
37212         * Scripts/webkitpy/layout_tests/port/base.py:
37213         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
37214
37215 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
37216
37217         [Qt] MiniBrowser doesn't resize as the size is always overridden
37218         https://bugs.webkit.org/show_bug.cgi?id=71212
37219
37220         Reviewed by Simon Hausmann.
37221
37222         Remove call overriden the size.
37223
37224         * MiniBrowser/qt/main.cpp:
37225         (main):
37226
37227 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
37228
37229         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
37230         http://trac.webkit.org/changeset/98819
37231         http://trac.webkit.org/changeset/98823
37232         http://trac.webkit.org/changeset/98825
37233         http://trac.webkit.org/changeset/98830
37234         https://bugs.webkit.org/show_bug.cgi?id=71199
37235
37236         Broke Chromium Windows bot (Requested by rniwa on #webkit).
37237
37238         * Scripts/webkitpy/layout_tests/port/base.py:
37239         * Scripts/webkitpy/layout_tests/port/chromium.py:
37240         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
37241         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
37242         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
37243         * Scripts/webkitpy/layout_tests/port/efl.py:
37244         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
37245         * Scripts/webkitpy/layout_tests/port/mac.py:
37246         * Scripts/webkitpy/layout_tests/port/qt.py:
37247         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
37248         * Scripts/webkitpy/layout_tests/port/webkit.py:
37249         * Scripts/webkitpy/layout_tests/port/win.py:
37250
37251 2011-10-30  Eric Seidel  <eric@webkit.org>
37252
37253         new-run-webkit-tests is locale dependent
37254         https://bugs.webkit.org/show_bug.cgi?id=68691
37255
37256         Unreviewed.
37257
37258         This is a temporary hack until someone from the cr-win port
37259         can take a look and determine which environment variable
37260         lighttpd is missing.
37261
37262         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
37263
37264 2011-10-30  Eric Seidel  <eric@webkit.org>
37265
37266         new-run-webkit-tests is locale dependent
37267         https://bugs.webkit.org/show_bug.cgi?id=68691
37268
37269         Unreviewed.  I would have preferred to have this reviewed,
37270         but relevant reviewers are asleep and bots are broken.
37271
37272         This was a regression from moving to a clean environment.
37273         ChromiumWin (and possibly other ports), need the "PATH"
37274         environment copied over.  This wasn't caught in my testing
37275         because although we had unittests to cover this, they
37276         weren't being run on anything but windows.  The vast majority
37277         of this change is just fixing the unittests to use our
37278         modern MockFileSystem/MockUser/MockExecutive so they can
37279         be run on any system (and removing the platform checks from
37280         the unittests so they are run everywhere).
37281
37282         The actual fix is the single line "PATH" string added to base.py.
37283         The rest of this change is just fixing the Chromium port unittests
37284         to run on all systems (including changing the Chromium port to
37285         use FileSystem.path_to_module instead of __file__).
37286
37287         * Scripts/webkitpy/layout_tests/port/base.py:
37288         * Scripts/webkitpy/layout_tests/port/chromium.py:
37289         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
37290         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
37291         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
37292         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
37293
37294 2011-10-29  Eric Seidel  <eric@webkit.org>
37295
37296         new-run-webkit-tests is locale dependent
37297         https://bugs.webkit.org/show_bug.cgi?id=68691
37298
37299         Unreviewed.
37300
37301         Fix the Qt port and unittest the function so we don't break it again.
37302
37303         * Scripts/webkitpy/layout_tests/port/qt.py:
37304         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
37305
37306 2011-10-29  Eric Seidel  <eric@webkit.org>
37307
37308         new-run-webkit-tests is locale dependent
37309         https://bugs.webkit.org/show_bug.cgi?id=68691
37310
37311         Reviewed by Adam Barth.
37312
37313         Make NRWT use a clean environment just like ORWT did.
37314         I've manually validated that NRWT now copies over
37315         the same environment variables that ORWT did.
37316         This new code is exercised by existing setup_environ_for_server tests.
37317
37318         * Scripts/webkitpy/layout_tests/port/base.py:
37319         * Scripts/webkitpy/layout_tests/port/efl.py:
37320         * Scripts/webkitpy/layout_tests/port/mac.py:
37321         * Scripts/webkitpy/layout_tests/port/qt.py:
37322         * Scripts/webkitpy/layout_tests/port/webkit.py:
37323         * Scripts/webkitpy/layout_tests/port/win.py:
37324
37325 2011-10-29  Eric Seidel  <eric@webkit.org>
37326
37327         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
37328         https://bugs.webkit.org/show_bug.cgi?id=34984
37329
37330         Reviewed by Adam Barth.
37331
37332         Move run-webkit-tests from using a white-list of supported NRWT ports
37333         to a blacklist of ports requiring ORWT.
37334
37335         I've also added the ability to opt-in to parallel testing on a per-port basis.
37336
37337         With these changes I'm going to officially declare this bug dead and
37338         work on remaining polish issues and individual developer complaints.
37339
37340         * Scripts/run-webkit-tests:
37341         (useNewRunWebKitTests):
37342         (platformIsReadyForParallelTesting):
37343
37344 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
37345
37346         Unreviewed, rolling out r98780.
37347         http://trac.webkit.org/changeset/98780
37348         https://bugs.webkit.org/show_bug.cgi?id=71173
37349
37350         Broke Qt bots (Requested by rniwa on #webkit).
37351
37352         * Scripts/run-webkit-tests:
37353         (useNewRunWebKitTests):
37354
37355 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
37356
37357         webkit.py gdb visualizer is broken after change to StringImpl
37358         https://bugs.webkit.org/show_bug.cgi?id=71154
37359
37360         Reviewed by Tony Chang.
37361
37362         r98624 changed StringImpl m_data to m_data32. This changes updates
37363         webkit.py to match.
37364
37365         * gdb/webkit.py:
37366
37367 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
37368
37369         Fix typo in check-for-inappropriate-objc-class-names
37370         https://bugs.webkit.org/show_bug.cgi?id=71144
37371
37372         Reviewed by Dan Bernstein.
37373
37374         * Scripts/check-for-inappropriate-objc-class-names:
37375
37376 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
37377
37378         Add support for sending scroll-update events from EventSender.
37379         https://bugs.webkit.org/show_bug.cgi?id=66272
37380
37381         Reviewed by Adam Barth.
37382
37383         * DumpRenderTree/chromium/EventSender.cpp:
37384         (EventSender::EventSender):
37385         (EventSender::reset):
37386         (EventSender::gestureScrollUpdate):
37387         (EventSender::gestureEvent):
37388         * DumpRenderTree/chromium/EventSender.h:
37389
37390 2011-10-28  Eric Seidel  <eric@webkit.org>
37391
37392         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
37393         https://bugs.webkit.org/show_bug.cgi?id=34984
37394
37395         Reviewed by Adam Barth.
37396
37397         Move run-webkit-tests from using a white-list of supported NRWT ports
37398         to a blacklist of ports requiring ORWT.
37399
37400         I've also added the ability to opt-in to parallel testing on a per-port basis.
37401
37402         With these changes I'm going to officially declare this bug dead and
37403         work on remaining polish issues and individual developer complaints.
37404
37405         * Scripts/run-webkit-tests:
37406         (useNewRunWebKitTests):
37407         (platformIsReadyForParallelTesting):
37408
37409 2011-10-28  Eric Seidel  <eric@webkit.org>
37410
37411         NRWT crashes when parsing leaks output due to UTF-8 decoding error
37412         https://bugs.webkit.org/show_bug.cgi?id=71112
37413
37414         Reviewed by Adam Barth.
37415
37416         Use read_binary_file instead of read_text_file and add a test
37417         case with some non-utf8 data to make sure we don't break this in the future.
37418
37419         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
37420         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
37421
37422 2011-10-28  David Levin  <levin@chromium.org>
37423
37424         watchlist should not CC the bug reporter
37425         https://bugs.webkit.org/show_bug.cgi?id=71079
37426
37427         Reviewed by Adam Barth.
37428
37429         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
37430         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
37431
37432         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
37433         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
37434         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
37435
37436 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
37437
37438         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
37439         https://bugs.webkit.org/show_bug.cgi?id=71116
37440
37441         Reviewed by David Levin.
37442
37443         * Scripts/webkitpy/common/config/watchlist:
37444
37445 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
37446
37447         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
37448         https://bugs.webkit.org/show_bug.cgi?id=70494
37449
37450         Reviewed by Kenneth Christiansen.
37451
37452         Use QQuick* instead of QSG* as well as QStandardPaths
37453         instead of QDesktopLocation.
37454
37455         * MiniBrowser/qt/BrowserWindow.cpp:
37456         (BrowserWindow::BrowserWindow):
37457         * MiniBrowser/qt/BrowserWindow.h:
37458         * QtTestBrowser/cookiejar.cpp:
37459         (TestBrowserCookieJar::TestBrowserCookieJar):
37460         * QtTestBrowser/launcherwindow.cpp:
37461         (LauncherWindow::setDiskCache):
37462         * WebKitTestRunner/PlatformWebView.h:
37463         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
37464         (WTR::WrapperWindow::WrapperWindow):
37465         (WTR::WrapperWindow::handleStatusChanged):
37466
37467 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
37468
37469         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
37470         https://bugs.webkit.org/show_bug.cgi?id=71106
37471
37472         Reviewed by Simon Hausmann.
37473
37474         Holding Ctrl allows multiple touch points to be held on the screen using
37475         mouse buttons. It would previously only prevent TouchReleased to be sent
37476         and would require another MouseButtonRelease to be sent without holding Ctrl.
37477
37478         This patch makes sure that all held touch points are released when Ctrl
37479         is released if MouseButtonRelease was received.
37480         It also removes the touch QEvent::Type logic since it's currently handled
37481         by QtGui by observing the modified touch points.
37482
37483         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37484         (MiniBrowserApplication::notify):
37485         (MiniBrowserApplication::sendTouchEvent):
37486         * MiniBrowser/qt/MiniBrowserApplication.h:
37487
37488 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
37489
37490         [Qt] MiniBrowser needs a -window-size option
37491         https://bugs.webkit.org/show_bug.cgi?id=70999
37492
37493         Reviewed by Simon Hausmann.
37494
37495         Add an -window-size option useful for testing the viewport handling.
37496         Also clean up the option handling.
37497
37498         * MiniBrowser/qt/BrowserWindow.cpp:
37499         (BrowserWindow::BrowserWindow):
37500         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37501         (MiniBrowserApplication::handleUserOptions):
37502         * MiniBrowser/qt/MiniBrowserApplication.h:
37503         (WindowOptions::WindowOptions):
37504         (WindowOptions::setRequestedWindowSize):
37505         (WindowOptions::requestedWindowSize):
37506         * MiniBrowser/qt/utils.cpp:
37507         (takeOptionValue):
37508         * MiniBrowser/qt/utils.h:
37509
37510 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
37511
37512         Add allowScriptFromSource callback to FrameLoaderClient
37513         https://bugs.webkit.org/show_bug.cgi?id=71013
37514
37515         Reviewed by Darin Fisher.
37516
37517         * DumpRenderTree/chromium/LayoutTestController.cpp:
37518         (LayoutTestController::LayoutTestController):
37519         (LayoutTestController::setScriptsAllowed):
37520         * DumpRenderTree/chromium/LayoutTestController.h:
37521         * DumpRenderTree/chromium/WebPermissions.cpp:
37522         (WebPermissions::allowScriptFromSource):
37523         (WebPermissions::setScriptsAllowed):
37524         (WebPermissions::reset):
37525         * DumpRenderTree/chromium/WebPermissions.h:
37526
37527 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
37528
37529         Added myself as a committer.
37530
37531         * Scripts/webkitpy/common/config/committers.py:
37532
37533 2011-10-27  Adam Barth  <abarth@webkit.org>
37534
37535         Remove WinCairo from the set of core builders.  WinCairo rarely builds
37536         and is never green.
37537
37538         Rubber-stamped by Eric Seidel.
37539
37540         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
37541         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
37542
37543 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
37544
37545         WebSocket: Connecting to localhost:8880 takes one second on Windows
37546         https://bugs.webkit.org/show_bug.cgi?id=64788
37547
37548         Reviewed by Dirk Pranke.
37549
37550         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
37551         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
37552         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
37553         from timing out on Windows, because this test tries to open a lot of
37554         connections to localhost and each attempt takes one second to fall back from
37555         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
37556
37557 2011-10-27  Adam Barth  <abarth@webkit.org>
37558
37559         Dis-integrate run-bindings-tests with webkitpy
37560         https://bugs.webkit.org/show_bug.cgi?id=71092
37561
37562         Reviewed by Ryosuke Niwa.
37563
37564         These tests aren't really adding any value.
37565
37566         * Scripts/webkitpy/common/config/ports.py:
37567         * Scripts/webkitpy/tool/commands/download_unittest.py:
37568         * Scripts/webkitpy/tool/mocktool.py:
37569         * Scripts/webkitpy/tool/steps/runtests.py:
37570         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
37571         * Scripts/webkitpy/tool/steps/steps_unittest.py:
37572
37573 2011-10-27  Eric Seidel  <eric@webkit.org>
37574
37575         REGRESSION (r98639): NRWT crashes when parsing leaks output
37576         https://bugs.webkit.org/show_bug.cgi?id=71087
37577
37578         Unreviewed.  Sadly we have no good way to test logging.
37579
37580         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
37581
37582 2011-10-27  David Levin  <levin@chromium.org>
37583
37584         Test expectation errors should include the file name and platform in both the log and exception info.
37585         https://bugs.webkit.org/show_bug.cgi?id=71067
37586
37587         Reviewed by Ojan Vafai.
37588
37589         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
37590         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
37591
37592 2011-10-27  Eric Seidel  <eric@webkit.org>
37593
37594         new-run-webkit-tests doesn't understand --qt or --gtk
37595         https://bugs.webkit.org/show_bug.cgi?id=63970
37596
37597         Reviewed by Ojan Vafai.
37598
37599         Add support for --qt and --gtk to NRWT.
37600         I also removed some incorrect comments in the option parsing
37601         code (options which we already implement, but said we didn't)
37602         as well as moved --platform parsing out of the "results_options"
37603         section into the top configuration section.
37604
37605         Now run-webkit-tests no longer needs NRWT-specific code for passing
37606         --platform=qt, etc.
37607
37608         * Scripts/run-webkit-tests:
37609         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
37610
37611 2011-10-27  Eric Seidel  <eric@webkit.org>
37612
37613         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
37614         https://bugs.webkit.org/show_bug.cgi?id=66227
37615
37616         Reviewed by Adam Roben.
37617
37618         I believe this should fix the bug.
37619
37620         * Scripts/run-webkit-tests: make NRWT default for --leaks
37621         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
37622         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
37623         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
37624         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
37625         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
37626         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
37627         * Scripts/webkitpy/layout_tests/port/mac.py:
37628         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
37629
37630 2011-10-27  Stephen Chenney  <schenney@chromium.org>
37631
37632         [Chromium] Need setPrinting
37633         https://bugs.webkit.org/show_bug.cgi?id=46152
37634
37635         Reviewed by Hajime Morita.
37636
37637         * DumpRenderTree/chromium/LayoutTestController.cpp:
37638         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
37639         (LayoutTestController::reset): Clearing flags for setPrinting.
37640         (LayoutTestController::setPrinting): Set flags for setPrinting.
37641         * DumpRenderTree/chromium/LayoutTestController.h:
37642         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
37643         (LayoutTestController::isPrinting): Method to return the setPrinting status.
37644         * DumpRenderTree/chromium/TestShell.cpp:
37645         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
37646         (TestShell::dump): Modified to dump setPrinting-specific output.
37647         * DumpRenderTree/chromium/WebViewHost.cpp:
37648         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
37649         active.
37650         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
37651
37652 2011-10-27  Sam Weinig  <sam@webkit.org>
37653
37654         Add allowsPlugIns property to WKBrowsingContextGroup
37655         https://bugs.webkit.org/show_bug.cgi?id=70987
37656
37657         Reviewed by Anders Carlsson.
37658
37659         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
37660         Add basic test for WKBrowsingContextGroup.allowsPlugIns.
37661
37662 2011-10-27  Adam Roben  <aroben@apple.com>
37663
37664         Test WKBundlePageGetBackingScaleFactor
37665
37666         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
37667         can't reliably determine the scale factor of snapshots returned via
37668         WKBundlePageCreateSnapshot* API
37669
37670         Reviewed by Sam Weinig.
37671
37672         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
37673
37674         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
37675         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
37676         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
37677         (TestWebKitAPI::createWindow): Conjure up a window.
37678         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
37679         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
37680         factors and when using a custom scale factor, and check that we get those same scale factors
37681         back.
37682
37683         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
37684         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
37685         members.
37686         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
37687         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
37688         from the page using the new API and send it back.
37689
37690 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
37691
37692         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
37693
37694         Rubber-stamped by Simon Hausmann.
37695
37696         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37697         (MiniBrowserApplication::handleUserOptions):
37698         Fix typo error.
37699
37700 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
37701
37702         [WebSocket] update pywebsocket to 0.7.
37703         https://bugs.webkit.org/show_bug.cgi?id=70992
37704
37705         Reviewed by Kent Tamura.
37706
37707         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
37708
37709         * Scripts/webkitpy/thirdparty/__init__.py:
37710
37711 2011-10-27  Elliot Poger  <epoger@google.com>
37712
37713         make lion observe MAC lines in test_expectations.txt
37714         https://bugs.webkit.org/show_bug.cgi?id=70941
37715
37716         Reviewed by Ojan Vafai.
37717
37718         * Scripts/webkitpy/layout_tests/port/chromium.py:
37719         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
37720
37721 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
37722
37723         [Chromium] Allow DRT to be built without notifications enabled.
37724         https://bugs.webkit.org/show_bug.cgi?id=70919
37725
37726         Reviewed by Tony Gentilcore.
37727
37728         * DumpRenderTree/chromium/LayoutTestController.cpp:
37729         (LayoutTestController::grantDesktopNotificationPermission):
37730         (LayoutTestController::simulateDesktopNotificationClick):
37731         * DumpRenderTree/chromium/NotificationPresenter.cpp:
37732         * DumpRenderTree/chromium/TestShell.cpp:
37733         (TestShell::TestShell):
37734         (TestShell::resetTestController):
37735
37736 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
37737
37738         [Qt] Improve command line arguments handling for MiniBrowser.
37739         https://bugs.webkit.org/show_bug.cgi?id=70616
37740
37741         Reviewed by Kenneth Rohde Christiansen.
37742
37743         - Use two dashes for word arguments.
37744         - Return with an error when an unsupported argument is given.
37745         - Allow the URL to be placed before option arguments.
37746
37747         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37748         (printHelp):
37749         (MiniBrowserApplication::handleUserOptions):
37750         * MiniBrowser/qt/utils.cpp:
37751         (takeOptionFlag):
37752         (takeOptionValue):
37753         * MiniBrowser/qt/utils.h:
37754
37755 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
37756
37757         [Qt] NRWT doesn't work on qt-mac platform
37758         https://bugs.webkit.org/show_bug.cgi?id=64445
37759
37760         Reviewed by Adam Barth.
37761
37762         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
37763         (useNewRunWebKitTests):
37764         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
37765
37766 2011-10-26  Sam Weinig  <sam@webkit.org>
37767
37768         Add initial setting to WKBrowsingContextGroup
37769         https://bugs.webkit.org/show_bug.cgi?id=70942
37770
37771         Reviewed by Anders Carlsson.
37772
37773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37774         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
37775         Add basic test that setting the javaScriptEnabled setting takes. It is not
37776         possible to test its effect quite yet.
37777
37778 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
37779
37780         [GTK] [WK2] Add WebKit2 distcheck support
37781         https://bugs.webkit.org/show_bug.cgi?id=70933
37782
37783         Reviewed by Martin Robinson.
37784
37785         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
37786         sources and EXTRA_DIST.
37787
37788 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
37789
37790         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
37791
37792         Reviewed by Tor Arne Vestbø.
37793
37794         We're using QScroller since r98460, which requires QWidget/QApplication. So
37795         use QApplication and QtWidgets for the time being.
37796
37797         * MiniBrowser/qt/MiniBrowser.pro:
37798         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37799         (MiniBrowserApplication::MiniBrowserApplication):
37800         (MiniBrowserApplication::notify):
37801         * MiniBrowser/qt/MiniBrowserApplication.h:
37802
37803 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
37804
37805         [Qt][WK2] Rewrite MiniBrowser in QML
37806         https://bugs.webkit.org/show_bug.cgi?id=70315
37807
37808         Add the first QML based implementation of MiniBrowser.
37809
37810         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
37811                  Zeno Albisser <zeno.albisser@nokia.com>
37812
37813         Reviewed by Tor Arne Vestbø.
37814
37815         * MiniBrowser/qt/BrowserWindow.cpp:
37816         (BrowserWindow::BrowserWindow):
37817         (BrowserWindow::webView):
37818         (BrowserWindow::load):
37819         (BrowserWindow::keyPressEvent):
37820         (BrowserWindow::~BrowserWindow):
37821         * MiniBrowser/qt/BrowserWindow.h:
37822         * MiniBrowser/qt/MiniBrowser.pro:
37823         * MiniBrowser/qt/MiniBrowser.qrc:
37824         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37825         (MiniBrowserApplication::MiniBrowserApplication):
37826         (MiniBrowserApplication::handleUserOptions):
37827         * MiniBrowser/qt/MiniBrowserApplication.h:
37828         (WindowOptions::WindowOptions):
37829         * MiniBrowser/qt/UrlLoader.cpp:
37830         (UrlLoader::UrlLoader):
37831         * MiniBrowser/qt/icons/next.png: Added.
37832         * MiniBrowser/qt/icons/previous.png: Added.
37833         * MiniBrowser/qt/icons/refresh.png: Added.
37834         * MiniBrowser/qt/icons/stop.png: Added.
37835         * MiniBrowser/qt/main.cpp:
37836         (main):
37837         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
37838
37839 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
37840
37841         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
37842         https://bugs.webkit.org/show_bug.cgi?id=70529
37843
37844         Remove obsolete code for a new QML based implementation
37845         of MiniBrowser.
37846         Change BrowserWindow to derive from QSGView instead of
37847         QMainWindow. QSGView is used as a top level window that
37848         provides the container for placing QML content.
37849         Make MiniBrowserApplication derive from QGuiApplication
37850         instead of QApplication.
37851
37852         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
37853                  Zeno Albisser <zeno.albisser@nokia.com>
37854
37855         Reviewed by Simon Hausmann.
37856
37857         * MiniBrowser/qt/BrowserView.cpp: Removed.
37858         * MiniBrowser/qt/BrowserView.h: Removed.
37859         * MiniBrowser/qt/BrowserWindow.cpp:
37860         (BrowserWindow::BrowserWindow):
37861         (BrowserWindow::load):
37862         (BrowserWindow::screenshot):
37863         (BrowserWindow::loadURLListFromFile):
37864         (BrowserWindow::updateUserAgentList):
37865         (BrowserWindow::~BrowserWindow):
37866         * MiniBrowser/qt/BrowserWindow.h:
37867         * MiniBrowser/qt/MiniBrowser.pro:
37868         * MiniBrowser/qt/MiniBrowserApplication.cpp:
37869         (MiniBrowserApplication::MiniBrowserApplication):
37870         (MiniBrowserApplication::notify):
37871         * MiniBrowser/qt/MiniBrowserApplication.h:
37872         * MiniBrowser/qt/UrlLoader.cpp:
37873         (UrlLoader::UrlLoader):
37874         * MiniBrowser/qt/main.cpp:
37875
37876 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
37877
37878         [Qt][WK2] Remove QAction from MiniBrowser
37879         https://bugs.webkit.org/show_bug.cgi?id=70525
37880
37881         In order to rewrite MiniBrowser in QML we need a suitable
37882         mechanism for triggering navigation actions.
37883         Due to the QtWidgets dependency of QAction the current
37884         solution is not suitable anymore. Therefore we introduce
37885         invokable methods and export properties in QWebNavigationController.
37886
37887         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
37888                  Zeno Albisser <zeno.albisser@nokia.com>
37889
37890         Reviewed by Simon Hausmann.
37891
37892         * MiniBrowser/qt/BrowserView.cpp:
37893         * MiniBrowser/qt/BrowserView.h:
37894         * MiniBrowser/qt/BrowserWindow.cpp:
37895         (BrowserWindow::BrowserWindow):
37896
37897 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
37898
37899         [EFL] Unregister viewport,changed signal in EWebLauncher.
37900         https://bugs.webkit.org/show_bug.cgi?id=70478
37901
37902         Reviewed by Eric Seidel.
37903
37904         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
37905         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
37906         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
37907         This signal is for mobile device.
37908
37909         * EWebLauncher/main.c:
37910         (browserCreate):
37911
37912 2011-10-25  Anders Carlsson  <andersca@apple.com>
37913
37914         Plug-ins have no way to find out when the device scale factor changes
37915         https://bugs.webkit.org/show_bug.cgi?id=67226
37916         <rdar://problem/10048276>
37917
37918         Reviewed by Sam Weinig.
37919
37920         Keep a cached copy of the contents scale and update it when it changes.
37921
37922         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
37923         (ContentsScaleFactor::ContentsScaleFactor):
37924         (ContentsScaleFactor::cachedContentsScaleFactor):
37925         (ContentsScaleFactor::ScriptableObject::hasProperty):
37926         (ContentsScaleFactor::ScriptableObject::getProperty):
37927         (ContentsScaleFactor::NPP_New):
37928         (ContentsScaleFactor::NPP_SetValue):
37929
37930 2011-10-25  Sam Weinig  <sam@webkit.org>
37931
37932         Add WKBrowsingContextLoadDelegateTest test for a failed load
37933         https://bugs.webkit.org/show_bug.cgi?id=70859
37934
37935         Reviewed by Anders Carlsson.
37936
37937         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
37938         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
37939
37940         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
37941         Test that we are getting the correct NSError code and domain.
37942
37943 2011-10-25  Erik Arvidsson  <arv@chromium.org>
37944
37945         JS Test Harness: Make successfullyParsed optional
37946         https://bugs.webkit.org/show_bug.cgi?id=70784
37947
37948         Reviewed by Ojan Vafai.
37949
37950         * Scripts/make-new-script-test:
37951         (writeTestFile): Update the template for script tests.
37952
37953 2011-10-25  Anders Carlsson  <andersca@apple.com>
37954
37955         Plug-ins have to use JavaScript to find out the current device scale factor
37956         https://bugs.webkit.org/show_bug.cgi?id=67225
37957         <rdar://problem/10048258>
37958
37959         Reviewed by Darin Adler.
37960
37961         Add a plug-in test for getting the contents scale factor.
37962
37963         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
37964         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
37965         (ContentsScaleFactor::ContentsScaleFactor):
37966         (ContentsScaleFactor::contentsScaleFactor):
37967         (ContentsScaleFactor::ScriptableObject::hasProperty):
37968         (ContentsScaleFactor::ScriptableObject::getProperty):
37969         (ContentsScaleFactor::ScriptableObject::pluginTest):
37970         (ContentsScaleFactor::NPP_GetValue):
37971
37972 2011-10-25  Sam Weinig  <sam@webkit.org>
37973
37974         Flesh out WKBrowsingContextLoadDelegate a bit
37975         https://bugs.webkit.org/show_bug.cgi?id=70846
37976
37977         Reviewed by Anders Carlsson.
37978
37979         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
37980         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
37981         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
37982         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
37983         (WKBrowsingContextLoadDelegateTest::SetUp):
37984         (WKBrowsingContextLoadDelegateTest::TearDown):
37985         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
37986         (TEST_F):
37987         Add basic testing for WKBrowsingContextLoadDelegate.
37988
37989 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
37990
37991         make-script-test-wrappers should not look outside fast/js
37992         https://bugs.webkit.org/show_bug.cgi?id=66357
37993
37994         Reviewed by Maciej Stachowiak.
37995
37996         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
37997         fast/js.
37998
37999 2011-10-25  Adam Barth  <abarth@webkit.org>
38000
38001         Add a --make option to update-webkit to engage the Makefile-based build system
38002         https://bugs.webkit.org/show_bug.cgi?id=70847
38003
38004         Reviewed by Dimitri Glazkov.
38005
38006         I can never remember what crazy environment variables I'm supposed to
38007         set to tell GYP what to do.
38008
38009         * Scripts/update-webkit:
38010
38011 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
38012
38013         [EFL] DRT: Force layout when sending events.
38014         https://bugs.webkit.org/show_bug.cgi?id=70357
38015
38016         Reviewed by Antonio Gomes.
38017
38018         Some tests such as editing/input/page-up-down-scrolls.html rely on the
38019         scrollbars being properly set up during the onload events.
38020         Document::implicitClose(), however, dispatches the onload events before
38021         calling FrameView::layout(), so these tests usually fail.
38022
38023         We now do the same as the GTK+ and Chromium ports and manually force the
38024         layout when dispatching events.
38025
38026         * DumpRenderTree/efl/EventSender.cpp:
38027         (sendMouseEvent):
38028         (keyDownCallback):
38029
38030 2011-10-25  Daniel Bates  <dbates@rim.com>
38031
38032         build-webkit --clean should only clean build directory for CMake-based ports
38033         https://bugs.webkit.org/show_bug.cgi?id=70834
38034
38035         Reviewed by Antonio Gomes.
38036
38037         Currently build-webkit --clean both cleans the build directory and builds WebKit for
38038         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
38039         as per its description in the usage message of build-webkit.
38040
38041         * Scripts/webkitdirs.pm:
38042         (buildCMakeProjectOrExit):
38043
38044 2011-10-25  Anna Cavender  <annacc@chromium.org>
38045
38046         Enable running of track layout tests for Chromium
38047         https://bugs.webkit.org/show_bug.cgi?id=70803
38048
38049         Reviewed by Adam Barth.
38050
38051         Make DumpRenderTree/TestShell always run with track enabled
38052         (equivalent of --enable-video-track).
38053
38054         * DumpRenderTree/chromium/TestShell.cpp:
38055         (TestShell::TestShell):
38056
38057 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
38058
38059         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
38060         https://bugs.webkit.org/show_bug.cgi?id=70603
38061
38062         Reviewed by Gustavo Noronha Silva.
38063
38064         * MiniBrowser/gtk/BrowserWindow.c:
38065         (focus):
38066         (unFocus):
38067         (browserWindowUIClientInit):
38068
38069 2011-10-25  Dan Bernstein  <mitz@apple.com>
38070
38071         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
38072
38073         Reviewed by Adam Roben.
38074
38075         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
38076         (TestWebKitAPI::TEST):
38077
38078 2011-10-25  Eric Seidel  <eric@webkit.org>
38079
38080         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
38081         https://bugs.webkit.org/show_bug.cgi?id=64471
38082
38083         Reviewed by Adam Roben.
38084
38085         Speculative fix.
38086
38087         * Scripts/webkitpy/layout_tests/port/win.py:
38088         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
38089
38090 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
38091
38092         Fix bug summary when rolling Chromium DEPS to LKGR.
38093         https://bugs.webkit.org/show_bug.cgi?id=69917
38094
38095         Reviewed by Adam Barth.
38096
38097         * Scripts/webkitpy/tool/bot/irc_command.py:
38098         * Scripts/webkitpy/tool/bot/sheriff.py:
38099         * Scripts/webkitpy/tool/commands/roll.py:
38100         * Scripts/webkitpy/tool/commands/roll_unittest.py:
38101
38102 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
38103
38104         [EFL] Build fix. Add include path to find npapi.h
38105         https://bugs.webkit.org/show_bug.cgi?id=70730
38106
38107         Unreviewed build fix.
38108
38109         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
38110
38111 2011-10-24  Eric Seidel  <eric@webkit.org>
38112
38113         Plugin tests are failing after switching WK2 to NRWT
38114         https://bugs.webkit.org/show_bug.cgi?id=70760
38115
38116         Reviewed by Simon Fraser.
38117
38118         Perpetuate this horrible hack.
38119
38120         * Scripts/webkitpy/layout_tests/port/webkit.py:
38121
38122 2011-10-24  Eric Seidel  <eric@webkit.org>
38123
38124         NRWT doesn't support ORWT's --root option, but should
38125         https://bugs.webkit.org/show_bug.cgi?id=70416
38126
38127         Reviewed by Dirk Pranke.
38128
38129         Add support for ORWT's --root option which is used for
38130         running tests with a nightly build of WebKit.
38131
38132         * Scripts/old-run-webkit-tests:
38133         * Scripts/webkitpy/layout_tests/port/base.py:
38134          - webkit_build_path was never called by any code, removed.
38135         * Scripts/webkitpy/layout_tests/port/webkit.py:
38136         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
38137
38138 2011-10-24  David Levin  <levin@chromium.org>
38139
38140         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
38141         https://bugs.webkit.org/show_bug.cgi?id=70747
38142
38143         Reviewed by Tony Chang.
38144
38145         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
38146         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
38147
38148 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
38149
38150         [Qt][WK2] Crash when running pixel tests
38151         https://bugs.webkit.org/show_bug.cgi?id=70725
38152
38153         Reviewed by Chang Shu.
38154
38155         * WebKitTestRunner/qt/TestInvocationQt.cpp:
38156         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
38157
38158 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
38159
38160         [GTK] Remove g_thread_init() calls
38161         https://bugs.webkit.org/show_bug.cgi?id=70717
38162
38163         Reviewed by Xan Lopez.
38164
38165         With newer glib it's not needed anymore and with previous versions
38166         it was already called by g_type_init().
38167
38168         * DumpRenderTree/gtk/DumpRenderTree.cpp:
38169         (main):
38170         * GtkLauncher/main.c:
38171         (main):
38172         * MiniBrowser/gtk/main.c:
38173         (main):
38174
38175 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
38176
38177         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
38178         https://bugs.webkit.org/show_bug.cgi?id=69403
38179
38180         We did not added autotoolsconfig.h to the config.h file and we
38181         were adding Platform.h without the config.h in the
38182         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
38183         the Prefix file.
38184
38185         Reviewed by Martin Robinson.
38186
38187         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
38188
38189 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
38190
38191         [EFL] Remove unused code from EWebLauncher
38192         https://bugs.webkit.org/show_bug.cgi?id=70590
38193
38194         Reviewed by Andreas Kling.
38195
38196         Removed unused function on_closeWindow from EWebLauncher
38197
38198         * EWebLauncher/main.c:
38199
38200 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
38201
38202         Add watchlist for WebCore/css and put myself on it.
38203         https://bugs.webkit.org/show_bug.cgi?id=70701
38204
38205         Reviewed by Adam Barth.
38206
38207         * Scripts/webkitpy/common/config/watchlist:
38208         Add watchlist for WebCore/css and put myself on it.
38209
38210 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
38211
38212         [GTK] Implement KeyDown function for WebKit2 EventSender.
38213         https://bugs.webkit.org/show_bug.cgi?id=69410
38214
38215         Reviewed by Martin Robinson.
38216
38217         Implement the KeyDown function on Gtk platform.
38218
38219         * WebKitTestRunner/GNUmakefile.am:
38220         * WebKitTestRunner/TestController.cpp:
38221         (WTR::TestController::TestController):
38222         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
38223         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
38224         (WTR::EventSenderProxy::EventSenderProxy):
38225         (WTR::dispatchEvent):
38226         (WTR::getModifiers):
38227         (WTR::getGDKKeySymForKeyRef):
38228         (WTR::EventSenderProxy::keyDown):
38229
38230 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
38231
38232         [WK2][GTK] run-launcher script fails after testing WK2 tests
38233         https://bugs.webkit.org/show_bug.cgi?id=70676
38234
38235         Reviewed by Andreas Kling.
38236
38237         Pass the '-2' flag instead of '--webkit-test-runner' when executing
38238         run-launcher script after testing with WebKitTestRunner.
38239
38240         * Scripts/webkitpy/layout_tests/port/gtk.py:
38241
38242 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
38243
38244         [WK2][GTK] Missing env variables cause WKTR to crash
38245         https://bugs.webkit.org/show_bug.cgi?id=70674
38246
38247         Reviewed by Martin Robinson.
38248
38249         Set two environment variables that the Gtk's port of WebKitTestRunner
38250         depends on and crashes if they're not explicitly set by the user.
38251         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
38252         properly uses the _build_path method.
38253
38254         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
38255         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
38256         environment variables.
38257
38258 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
38259
38260         Bencher script doesn't measure GC times accurately
38261         https://bugs.webkit.org/show_bug.cgi?id=70588
38262
38263         Reviewed by Geoff Garen.
38264
38265         Added two new options which allow different ways of measuring GC times:
38266
38267         --measure-gc, which omits calls to gc() between benchmark invocations.
38268         This option takes an optional argument, which is the name of the
38269         VM in which to enable this feature. This allows comparing a single VM
38270         against itself, with and without GC.
38271
38272         --rerun <N>, which causes each sample measurement to include N invocations
38273         which do not have gc() calls between them. The default is N = 1, which
38274         results in the same behavior as before.
38275
38276         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
38277         N >= 3) to get more of a contribution from GC to the measured times.
38278         --rerun results in tighter confidence intervals than --measure-gc, since
38279         it amortizes GC effects in each sample, while with --measure-gc some
38280         samples will see GC and some won't leading to a higher standard devation
38281         and thus requiring more samples to reduce confidence intervals to
38282         managable levels.
38283
38284         * Scripts/bencher:
38285
38286 2011-10-21  Sam Weinig  <sam@webkit.org>
38287
38288         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
38289         https://bugs.webkit.org/show_bug.cgi?id=70653
38290
38291         Reviewed by Simon Fraser.
38292
38293         * MiniBrowser/mac/AppDelegate.h:
38294         * MiniBrowser/mac/AppDelegate.m:
38295         (-[BrowserAppDelegate init]):
38296         (-[BrowserAppDelegate newWindow:]):
38297         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
38298         * MiniBrowser/mac/BrowserWindowController.h:
38299         * MiniBrowser/mac/BrowserWindowController.m:
38300         (-[BrowserWindowController initWithContext:pageGroup:]):
38301         (-[BrowserWindowController windowWillClose:]):
38302         (createNewPage):
38303         (-[BrowserWindowController awakeFromNib]):
38304         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
38305         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
38306         Update testing code to pass a PageGroup as necessary.
38307
38308 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
38309
38310         webkitpy: Teach NRWT about the EFL port
38311         https://bugs.webkit.org/show_bug.cgi?id=70637
38312
38313         Allows using ``efl'' as a platform when executing NRWT.
38314
38315         Reviewed by Eric Seidel.
38316
38317         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
38318         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
38319         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
38320         when using PortFactory.get(port_name='efl').
38321
38322 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
38323
38324         [Gtk] mousemove event always has metaKey == true
38325         https://bugs.webkit.org/show_bug.cgi?id=35299
38326
38327         Reviewed by Martin Robinson.
38328
38329         * DumpRenderTree/gtk/EventSender.cpp:
38330         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
38331         keyboard events. So making it in sync with WebCore files.
38332         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
38333
38334 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
38335
38336         watchlist: Add a new entry for WebKit2 GTK+ public API
38337         https://bugs.webkit.org/show_bug.cgi?id=70601
38338
38339         Reviewed by Philippe Normand.
38340
38341         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
38342         for patches that might include new API that points to the WebKit2
38343         GTK+ API guidelines.
38344
38345         * Scripts/webkitpy/common/config/watchlist:
38346
38347 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
38348
38349         Remove QtScript source code from WebKit.
38350         https://bugs.webkit.org/show_bug.cgi?id=64088
38351
38352         Reviewed by Tor Arne Vestbø.
38353
38354         Removed dead code that isn't developed anymore.
38355
38356         * Scripts/webkitpy/style/checker_unittest.py:
38357
38358 2011-10-20  Eric Seidel  <eric@webkit.org>
38359
38360         Switch webkit2 bot to NRWT
38361         https://bugs.webkit.org/show_bug.cgi?id=56729
38362
38363         Reviewed by Adam Barth.
38364
38365         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
38366         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
38367
38368         * Scripts/run-webkit-tests:
38369         (runningOnBuildBot):
38370         (useNewRunWebKitTests):
38371
38372 2011-10-20  Eric Seidel  <eric@webkit.org>
38373
38374         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
38375         https://bugs.webkit.org/show_bug.cgi?id=70585
38376
38377         Reviewed by Adam Barth.
38378
38379         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
38380         However since DRT was functioning fine before in Qt, we'll make this an error log for now
38381         and once we find the root cause flip this back to an assert.
38382
38383         * Scripts/webkitpy/layout_tests/port/webkit.py:
38384
38385 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
38386
38387         Unreviewed, rolling out r98064.
38388         http://trac.webkit.org/changeset/98064
38389         https://bugs.webkit.org/show_bug.cgi?id=64788
38390
38391         Broke Mac bots.
38392
38393         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
38394
38395 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
38396
38397         WebSocket: Connecting to localhost:8880 takes one second on Windows
38398         https://bugs.webkit.org/show_bug.cgi?id=64788
38399
38400         Reviewed by Dirk Pranke.
38401
38402         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
38403         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
38404         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
38405         from timing out on Windows, because this test tries to open a lot of
38406         connections to localhost and each attempt takes one second to fall back from
38407         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
38408
38409 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
38410
38411         nrwt: newly generated results are put in cross-platform directory
38412         https://bugs.webkit.org/show_bug.cgi?id=68931
38413
38414         Reviewed by Dirk Pranke.
38415
38416         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
38417         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
38418         (because png images are typically different on each platform), and passing True when .txt file is missing
38419         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
38420
38421         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
38422         * Scripts/webkitpy/layout_tests/port/test.py:
38423         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
38424         and added a test case.
38425
38426 2011-10-20  Kent Tamura  <tkent@chromium.org>
38427
38428         Unreviewed. Adding myself to watchlist.
38429
38430         * Scripts/webkitpy/common/config/watchlist:
38431         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
38432
38433 2011-10-20  Nico Weber  <thakis@chromium.org>
38434
38435         [chromium/mac] Add support for building with make
38436         https://bugs.webkit.org/show_bug.cgi?id=70455
38437
38438         Reviewed by Adam Barth.
38439
38440         Depends on http://codereview.chromium.org/8352029/
38441         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
38442         create a toplevel Makefile.chromium.
38443
38444         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
38445         `Tools/Scripts/build-webkit --chromium` will build with make instead of
38446         xcodebuild.
38447
38448         Also let nrwt use a binary from out/ if it exists.
38449
38450         * Scripts/webkitdirs.pm:
38451         (determineBaseProductDir):
38452         (isChromiumMacMake):
38453         (determineIsChromiumMacMake):
38454         (buildChromium):
38455
38456 2011-10-20  Eric Seidel  <eric@webkit.org>
38457
38458         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
38459         https://bugs.webkit.org/show_bug.cgi?id=70524
38460
38461         Reviewed by Adam Barth.
38462
38463         This is a speculative fix, since I do not use a platform
38464         which outputs crashlogs over stderr.
38465
38466         * Scripts/webkitpy/layout_tests/port/server_process.py:
38467         * Scripts/webkitpy/layout_tests/port/webkit.py:
38468
38469 2011-10-20  Eric Seidel  <eric@webkit.org>
38470
38471         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
38472         https://bugs.webkit.org/show_bug.cgi?id=70492
38473
38474         Reviewed by Adam Barth.
38475
38476         The bug turned out to be that I was assuming the block.content
38477         would be empty before the binary content following Content-Length
38478         was read inside _read_block.  Turns out its not, due to extra newlines
38479         and "ExpectedHash" header.
38480
38481         In the process of trying to figure out what was going wrong I ended up
38482         cleaning up our newline usage in DumpRenderTree a little.  Moved
38483         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
38484
38485         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
38486         per Adam's request in the original bug.
38487
38488         * DumpRenderTree/PixelDumpSupport.cpp:
38489         (dumpWebViewAsPixelsAndCompareWithExpected):
38490         * DumpRenderTree/cg/ImageDiffCG.cpp:
38491         (main):
38492         * DumpRenderTree/mac/DumpRenderTree.mm:
38493         (dump):
38494         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
38495         (restoreMainDisplayColorProfile):
38496         (setupMainDisplayColorProfile):
38497         * Scripts/webkitpy/layout_tests/port/server_process.py:
38498         * Scripts/webkitpy/layout_tests/port/webkit.py:
38499         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
38500
38501 2011-10-20  Tony Chang  <tony@chromium.org>
38502
38503         [chromium] Remove <stdint.h> from ImageDiff and use
38504         unsigned int instead of uint32_t.
38505
38506         Unreviewed, fixing the chromium win build.
38507
38508         * DumpRenderTree/chromium/ImageDiff.cpp:
38509         (Image::pixelAt):
38510         (Image::setPixelAt):
38511         (maxOf3):
38512         (getRedComponent):
38513         (getGreenComponent):
38514         (getBlueComponent):
38515         (weightedPercentageDifferent):
38516         (createImageDiff):
38517
38518 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
38519
38520         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
38521         https://bugs.webkit.org/show_bug.cgi?id=69997
38522
38523         Reviewed by Tony Chang.
38524
38525         This change is required to make ImageDiff for Android, and can benefit
38526         other platforms, too. On Android, most targets are built as
38527         toolsets:target. while ImageDiff needs to be built as toolsets:host.
38528         Currently, building the standalone target of ImageDiff depends on about
38529         85 other targets (try  make ImageDiff'), which is inefficient. After the
38530         change, ImageDiff only depends on webkit_support_gfx, which in turn
38531         depends on libpng and zlib.
38532
38533         * DumpRenderTree/chromium/ImageDiff.cpp:
38534         (main):
38535
38536 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
38537
38538         [EFL] Unreviewed DumpRenderTree build fix.
38539
38540         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
38541         (LayoutTestController::addChromeInputField): Add stub.
38542         (LayoutTestController::removeChromeInputField): Ditto.
38543         (LayoutTestController::focusWebView): Ditto.
38544         (LayoutTestController::setBackingScaleFactor): Ditto.
38545
38546 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
38547
38548         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
38549         https://bugs.webkit.org/show_bug.cgi?id=70142
38550
38551         Reviewed by Gustavo Noronha Silva.
38552
38553         * CMakeListsEfl.txt: Include DRT CMakeLists.
38554         * DumpRenderTree/efl/CMakeLists.txt: Added.
38555
38556 2011-10-20  Philippe Normand  <pnormand@igalia.com>
38557
38558         [style] Allow usage of NULL in gst_*
38559         https://bugs.webkit.org/show_bug.cgi?id=70498
38560
38561         Reviewed by David Levin.
38562
38563         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
38564         of gst_ calls. Now just ignore NULL in all of them.
38565         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
38566
38567 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
38568
38569         [EFL] Unreviewed. Build fix after r97043.
38570
38571         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
38572         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
38573         * DumpRenderTree/efl/EventSender.cpp:
38574         (scalePageByCallback): Ditto.
38575
38576 2011-10-20  Philippe Normand  <pnormand@igalia.com>
38577
38578         Unreviewed. Adding myself to watchlists.
38579         * Scripts/webkitpy/common/config/watchlist:
38580
38581 2011-10-19  Eric Seidel  <eric@webkit.org>
38582
38583         Reviewed by Adam Barth.
38584
38585         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
38586         https://bugs.webkit.org/show_bug.cgi?id=63683
38587
38588         * Scripts/webkitpy/common/net/layouttestresults.py:
38589         * Scripts/webkitpy/common/net/resultsjsonparser.py:
38590         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
38591         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
38592         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
38593         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
38594         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
38595         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
38596         * Scripts/webkitpy/layout_tests/port/base.py:
38597         * Scripts/webkitpy/layout_tests/port/server_process.py:
38598         * Scripts/webkitpy/layout_tests/port/webkit.py:
38599         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
38600
38601 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
38602
38603         Chromium doesn't support git branch builds, so don't add the branch to the product dir
38604         https://bugs.webkit.org/show_bug.cgi?id=70449
38605
38606         Reviewed by Eric Seidel.
38607
38608         * Scripts/webkitdirs.pm:
38609         (determineBaseProductDir):
38610
38611 2011-10-19  Ojan Vafai  <ojan@chromium.org>
38612
38613         Unreviewed. Adding myself to watchlists.
38614         * Scripts/webkitpy/common/config/watchlist:
38615
38616 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
38617
38618         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
38619         https://bugs.webkit.org/show_bug.cgi?id=62166
38620
38621         Reviewed by Eric Seidel.
38622
38623         Included options to control committer/reviewer patch count requirements,
38624         an age-limit on patches, and verbose output for more in-depth analysis.
38625
38626         * Scripts/webkitpy/common/checkout/changelog.py:
38627         * Scripts/webkitpy/tool/commands/__init__.py:
38628         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
38629         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
38630
38631 2011-10-19  Eric Seidel  <eric@webkit.org>
38632
38633         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
38634         Make NRWT normalize directory names in Skipped files during parsing.
38635
38636         Unreviewed.  Very simple (tested) change.
38637
38638         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
38639         * Scripts/webkitpy/layout_tests/port/webkit.py:
38640
38641 2011-10-19  David Levin  <levin@chromium.org>
38642
38643         watchlist: Should be more robust to bad regex.
38644         https://bugs.webkit.org/show_bug.cgi?id=69486
38645
38646         Reviewed by Adam Barth.
38647
38648         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
38649           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
38650           patterns since they are no longer anchored on the right hand side.
38651         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
38652         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
38653         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
38654         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
38655         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
38656         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
38657         filenames are no longer anchored on the right hand side.
38658         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
38659         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
38660         don't kill everything.
38661
38662 2011-10-19  David Levin  <levin@chromium.org>
38663
38664         watchlist: Add a stylecheck to do validity checks for the watchlist config.
38665         https://bugs.webkit.org/show_bug.cgi?id=69487
38666
38667         Reviewed by Adam Barth.
38668
38669         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
38670         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
38671         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
38672
38673 2011-10-19  Eric Seidel  <eric@webkit.org>
38674
38675         NRWT ServerProcess can't read lines from stderr and stdio separately
38676         https://bugs.webkit.org/show_bug.cgi?id=70435
38677
38678         Reviewed by Adam Barth.
38679
38680         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
38681         DRT expects RWT to read one line at a time from stderr and stdout independently.
38682         This allows DRT to communicate errors over stderr and have them responded to immediately
38683         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
38684         class only exposed a read_line function which would read a line from stdout
38685         and batch all output from stderr into an error buffer.  Callers would only be able
38686         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
38687
38688         * Scripts/webkitpy/layout_tests/port/server_process.py:
38689         * Scripts/webkitpy/layout_tests/port/webkit.py:
38690
38691 2011-10-19  Chang Shu  <cshu@webkit.org>
38692
38693         [Qt] Support WK1-only Skipped list
38694         https://bugs.webkit.org/show_bug.cgi?id=70254
38695
38696         Reviewed by Csaba Osztrogonác.
38697
38698         Added a new search path qt-wk1 for skipping WK1-only tests.
38699
38700         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
38701         * Scripts/old-run-webkit-tests: ORWT
38702
38703 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
38704
38705         [GTK] Enable to use built-product-archive on GTK platform
38706         https://bugs.webkit.org/show_bug.cgi?id=70319
38707
38708         Reviewed by Csaba Osztrogonác.
38709
38710         * BuildSlaveSupport/built-product-archive:
38711
38712 2011-10-18  David Levin  <levin@chromium.org>
38713
38714         watchlist: Should try to run if it can and not throw on mistakes.
38715         https://bugs.webkit.org/show_bug.cgi?id=70358
38716
38717         Reviewed by Adam Barth.
38718
38719         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
38720         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
38721         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
38722         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
38723         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
38724         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
38725
38726 2011-10-18  Sam Weinig  <sam@webkit.org>
38727
38728         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
38729         https://bugs.webkit.org/show_bug.cgi?id=70387
38730
38731         Reviewed by Dan Bernstein.
38732
38733         * MiniBrowser/mac/BrowserWindowController.m:
38734         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
38735         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
38736         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
38737         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
38738         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
38739         Update to include WKViewPrivate.h where necessary.
38740
38741 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
38742
38743         Web Inspector: Some localizedStrings.js Updates
38744         https://bugs.webkit.org/show_bug.cgi?id=70365
38745
38746         Reviewed by Darin Adler.
38747
38748         * Scripts/check-inspector-strings:
38749         Updated to the new webkitpy way to determine checkout root.
38750
38751         * Scripts/webkitdirs.pm:
38752         (copyInspectorFrontendFiles):
38753         Made it so build-webkit --inspector-frontend copies over
38754         the localizedStrings.js file as well as the frontend files.
38755
38756 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
38757
38758         [EFL] DRT: Clear list of visited pages before each test.
38759         https://bugs.webkit.org/show_bug.cgi?id=70355
38760
38761         Reviewed by Antonio Gomes.
38762
38763         r97596 uncovered a bug in the implementation: the list of visited
38764         links was not cleared between tests, which caused tests such as
38765         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
38766         changed depending on whether fast/repaint/border-repaint-glitch.html
38767         was visited before or not).
38768
38769         Call ewk_history_clear to make sure the visited links list does not
38770         persist between tests.
38771
38772         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
38773         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
38774
38775 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
38776
38777         Split TestExpectationsEditor into its own file.
38778         https://bugs.webkit.org/show_bug.cgi?id=70348
38779
38780         Reviewed by Adam Barth.
38781
38782         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
38783         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
38784         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
38785         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
38786         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
38787
38788 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
38789
38790         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
38791         https://bugs.webkit.org/show_bug.cgi?id=70313
38792
38793         Reviewed by Adam Barth.
38794
38795         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
38796         this parameter because build-webkit and other scripts don't accept it.
38797
38798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
38799
38800 2011-10-18  Adam Barth  <abarth@webkit.org>
38801
38802         Subscribe myself to WebIDL changes
38803         https://bugs.webkit.org/show_bug.cgi?id=70341
38804
38805         Reviewed by David Levin.
38806
38807         I've also added some documentation and refactored my previous
38808         subscriptions to make it eaiser for others to subscribe as well.
38809
38810         * Scripts/webkitpy/common/config/watchlist:
38811
38812 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
38813
38814         Add myself to the newfangled watchlist plumbing.
38815         https://bugs.webkit.org/show_bug.cgi?id=70338
38816
38817         Reviewed by David Levin.
38818
38819         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
38820
38821 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
38822
38823         Fix a unit test in TestFailures.
38824         https://bugs.webkit.org/show_bug.cgi?id=70337
38825
38826         Reviewed by Adam Barth.
38827
38828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
38829             the value of a method property should always be lowercase.
38830
38831 2011-10-18  Adam Barth  <abarth@webkit.org>
38832
38833         Always enable ENABLE(XPATH)
38834         https://bugs.webkit.org/show_bug.cgi?id=70217
38835
38836         Reviewed by Eric Seidel.
38837
38838         * Scripts/build-webkit:
38839
38840 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
38841
38842         garden-o-matic should not report flaking in expected failures as failures.
38843         https://bugs.webkit.org/show_bug.cgi?id=70279
38844
38845         Reviewed by Adam Barth.
38846
38847         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
38848         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
38849         same for garden-o-matic.
38850
38851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
38852             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
38853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
38854
38855 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
38856
38857         [Gtk] Support for client-based geolocation
38858         https://bugs.webkit.org/show_bug.cgi?id=64970
38859
38860         Reviewed by Martin Robinson.
38861
38862         Add support for testing client-based geolocation tests in DumpRenderTree.
38863
38864         * DumpRenderTree/gtk/DumpRenderTree.cpp:
38865         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
38866         (createWebView): Create web view after declaring DumpRenderTree mode.
38867         That way a mock client for geolocation is used instead of a GeoClue
38868         client if a web view is created when testing.
38869         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
38870         geolocation layout tests.
38871         (LayoutTestController::setMockGeolocationPosition):
38872         (LayoutTestController::setMockGeolocationError):
38873         (LayoutTestController::setGeolocationPermission):
38874         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
38875         * Scripts/build-webkit: Note that the Gtk port is using client-based
38876         geolocation, even though changing this flag has no effect on compilation.
38877
38878 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
38879
38880         [Chromium] suppress console output from DevTools window
38881         https://bugs.webkit.org/show_bug.cgi?id=69632
38882
38883         Reviewed by Pavel Feldman.
38884
38885         * DumpRenderTree/chromium/TestShell.cpp:
38886         (TestShell::showDevTools):
38887         * DumpRenderTree/chromium/WebViewHost.cpp:
38888         (WebViewHost::didAddMessageToConsole):
38889         (WebViewHost::reset):
38890         (WebViewHost::setLogConsoleOutput):
38891         * DumpRenderTree/chromium/WebViewHost.h:
38892
38893 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
38894
38895         Unreviewed, rolling out r97735.
38896         http://trac.webkit.org/changeset/97735
38897         https://bugs.webkit.org/show_bug.cgi?id=70317
38898
38899         some people apparently use build-jsc with the qt port without
38900         building webkit first (Requested by torarne on #webkit).
38901
38902         * Scripts/build-webkit:
38903         * Scripts/webkitdirs.pm:
38904         (buildQMakeProject):
38905         (buildQMakeQtProject):
38906
38907 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
38908
38909         [Qt] Remove dead code in build-webkit
38910
38911         build-webkit will iterate over a list of subdirectories to build,
38912         but this feature is only used by the Apple ports. For QtWebKit we
38913         always pass an empty directory to buildQMakeProject, which makes
38914         the logic for dealing with sub-projects in buildQMakeProject just
38915         added noise.
38916
38917         If we do want this feature at some point, we should redo it in
38918         the context of the upcoming build system changes for Qt.
38919
38920         Reviewed by Simon Hausmann.
38921
38922         * Scripts/build-webkit:
38923         * Scripts/webkitdirs.pm:
38924         (buildQt):
38925
38926 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
38927
38928         Remove traces of Symbian support from the build scripts
38929
38930         Reviewed by Simon Hausmann.
38931
38932         * Scripts/build-webkit:
38933         * Scripts/webkitdirs.pm:
38934         (determineBaseProductDir):
38935         (argumentsForConfiguration):
38936         (usesPerConfigurationBuildDirectory):
38937         (buildQMakeProject):
38938
38939 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
38940
38941         Build fix after r97672.
38942
38943         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
38944
38945 2011-10-17  Kent Tamura  <tkent@chromium.org>
38946
38947         A follow-up of r97716.
38948         https://bugs.webkit.org/show_bug.cgi?id=68803
38949
38950         * DumpRenderTree/chromium/LayoutTestController.cpp:
38951         (LayoutTestController::reset): Initialize m_dumpCreateView.
38952
38953 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
38954
38955         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
38956         https://bugs.webkit.org/show_bug.cgi?id=68803
38957
38958         Reviewed by Nate Chapin.
38959
38960         * DumpRenderTree/chromium/LayoutTestController.cpp:
38961         (LayoutTestController::LayoutTestController):
38962         (LayoutTestController::dumpCreateView):
38963         * DumpRenderTree/chromium/LayoutTestController.h:
38964         (LayoutTestController::shouldDumpCreateView):
38965         * DumpRenderTree/chromium/WebViewHost.cpp:
38966         (WebViewHost::createView):
38967
38968 2011-10-17  Nate Chapin  <japhet@chromium.org>
38969
38970         Add myself to watchlists, and add a watch
38971         for Source/WebCore/loader/.
38972         https://bugs.webkit.org/show_bug.cgi?id=70263
38973
38974         Reviewed by David Levin.
38975
38976         * Scripts/webkitpy/common/config/watchlist:
38977
38978 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
38979
38980         [EFL] DRT: Make non-recognized keys work in events as well.
38981         https://bugs.webkit.org/show_bug.cgi?id=69860
38982
38983         Reviewed by Antonio Gomes.
38984
38985         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
38986         here: it has a select box with a few non-latin options, and one of them
38987         is selected via the keyboard.
38988
38989         In this specific case, we need to make EventHandler::keyEvent send a
38990         keyPressEvent to SelectElement, so that
38991         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
38992         only when PlatformKeyEvent::text() is not empty, which was not the case
38993         so far.
38994
38995         * DumpRenderTree/efl/EventSender.cpp:
38996         (keyDownCallback):
38997
38998 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
38999
39000         Add layout tests for WebPlugin compositor path
39001         https://bugs.webkit.org/show_bug.cgi?id=69027
39002
39003         Reviewed by James Robinson.
39004
39005         * DumpRenderTree/DumpRenderTree.gypi:
39006         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
39007         (premultiplyAlpha):
39008         (TestWebPlugin::TestWebPlugin):
39009         (TestWebPlugin::~TestWebPlugin):
39010         (TestWebPlugin::mimeType):
39011         (TestWebPlugin::initialize):
39012         (TestWebPlugin::destroy):
39013         (TestWebPlugin::updateGeometry):
39014         (TestWebPlugin::parsePrimitive):
39015         (TestWebPlugin::parseColor):
39016         (TestWebPlugin::parseOpacity):
39017         (TestWebPlugin::initScene):
39018         (TestWebPlugin::drawScene):
39019         (TestWebPlugin::destroyScene):
39020         (TestWebPlugin::initProgram):
39021         (TestWebPlugin::initPrimitive):
39022         (TestWebPlugin::drawPrimitive):
39023         (TestWebPlugin::loadShader):
39024         (TestWebPlugin::loadProgram):
39025         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
39026         (TestWebPlugin::scriptableObject):
39027         (TestWebPlugin::paint):
39028         (TestWebPlugin::updateFocus):
39029         (TestWebPlugin::updateVisibility):
39030         (TestWebPlugin::acceptsInputEvents):
39031         (TestWebPlugin::handleInputEvent):
39032         (TestWebPlugin::didReceiveResponse):
39033         (TestWebPlugin::didReceiveData):
39034         (TestWebPlugin::didFinishLoading):
39035         (TestWebPlugin::didFailLoading):
39036         (TestWebPlugin::didFinishLoadingFrameRequest):
39037         (TestWebPlugin::didFailLoadingFrameRequest):
39038         (TestWebPlugin::Scene::Scene):
39039         * DumpRenderTree/chromium/WebViewHost.cpp:
39040         (WebViewHost::createPlugin):
39041
39042 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
39043
39044         [nrwt] Add new category for MISSING
39045         https://bugs.webkit.org/show_bug.cgi?id=69990
39046
39047         Reviewed by Dirk Pranke.
39048
39049         Treat missing results as a new category in summerize_results.
39050
39051         Because Chromium port wants to turn bots red when there are tests with missing results,
39052         extracted the logic to compute the exit code as exit_code_from_summarized_results in
39053         base and chromium ports.
39054
39055         * Scripts/webkitpy/layout_tests/controllers/manager.py:
39056         * Scripts/webkitpy/layout_tests/port/base.py:
39057         * Scripts/webkitpy/layout_tests/port/chromium.py:
39058         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
39059
39060 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
39061
39062         garden-o-matic operations fail because of CSP.
39063         https://bugs.webkit.org/show_bug.cgi?id=70249
39064
39065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
39066
39067 2011-10-17  Ada Chan  <adachan@apple.com>
39068
39069         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
39070         https://bugs.webkit.org/show_bug.cgi?id=70168
39071
39072         Reviewed by Alexey Proskuryakov.
39073
39074         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
39075         (TestWebKitAPI::didFinishLoadForFrame):
39076         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
39077
39078         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39079         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
39080         Add the new file.
39081
39082 2011-10-17  Darin Adler  <darin@apple.com>
39083
39084         Add some more *.pyc ignores in directories with Python scripts.
39085
39086         * QueueStatusServer: Added property svn:ignore.
39087         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
39088         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
39089         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
39090
39091 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
39092
39093         [Qt][WK2][meta] Fix failing API tests
39094         https://bugs.webkit.org/show_bug.cgi?id=70236
39095
39096         Reviewed by Csaba Osztrogonác.
39097
39098         In order to run WebKit2 API tests we need the WebProcess to be in
39099         the path so let's add the bin directory when running the API tests of Qt.
39100
39101         * Scripts/run-qtwebkit-tests:
39102
39103 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
39104
39105         [Qt][WK2] Build dependency problems
39106         https://bugs.webkit.org/show_bug.cgi?id=68456
39107
39108         Reviewed by Csaba Osztrogonác.
39109
39110         * Scripts/webkitdirs.pm:
39111         (buildQMakeProject):
39112
39113 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
39114
39115         [build] Introduce Qt/SH4 buildbot
39116         https://bugs.webkit.org/show_bug.cgi?id=70227
39117
39118         Reviewed by Adam Roben.
39119
39120         Add buildslave for Linux/Qt/SH4.
39121
39122         * BuildSlaveSupport/build.webkit.org-config/config.json:
39123
39124 2011-10-16  Adam Barth  <abarth@webkit.org>
39125
39126         Always enable ENABLE(DOM_STORAGE)
39127         https://bugs.webkit.org/show_bug.cgi?id=70189
39128
39129         Reviewed by Eric Seidel.
39130
39131         * Scripts/build-webkit:
39132         * waf/build/settings.py:
39133
39134 2011-10-15  Adam Barth  <abarth@webkit.org>
39135
39136         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
39137         https://bugs.webkit.org/show_bug.cgi?id=70194
39138
39139         Reviewed by Daniel Bates.
39140
39141         * Scripts/build-webkit:
39142
39143 2011-10-15  Ojan Vafai  <ojan@chromium.org>
39144
39145         run-webkit-tests should accept --child-processes
39146         https://bugs.webkit.org/show_bug.cgi?id=69713
39147
39148         Reviewed by Adam Barth.
39149
39150         Only set --child-processes=1 if --child-processes it not
39151         passed on the commandline.
39152
39153         * Scripts/run-webkit-tests:
39154
39155 2011-10-15  Daniel Bates  <dbates@webkit.org>
39156
39157         Extract common gdb code into its own function; Remove script gdb-safari
39158         https://bugs.webkit.org/show_bug.cgi?id=68499
39159
39160         Reviewed by David Kilzer.
39161
39162         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
39163         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
39164         We should extract the common parts into a function that can be shared by all callers
39165         so as to remove duplicate code.
39166
39167         As a side effect of removing duplicate code we can remove the script gdb-safari since
39168         its code has been incorporated into webkitdirs::debugSafari() which is called by the
39169         script debug-safari.
39170
39171         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
39172         * Scripts/gdb-safari: Removed.
39173         * Scripts/webkitdirs.pm:
39174         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
39175         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
39176         script gdb-safari to here.
39177         (debugSafari): Added.
39178         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
39179         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
39180         runSafari() always returns 1 on Windows and the script run-safari exits using this
39181         value as its exit status. Hence, the script run-safari always exits with a nonzero
39182         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
39183         exit status of the WebKit launcher application.
39184         (debugMiniBrowser): Modified to call debugMacWebKitApp().
39185         (debugWebKitTestRunner): Ditto.
39186
39187 2011-10-15  Robert Hogan  <robert@webkit.org>
39188
39189         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
39190         https://bugs.webkit.org/show_bug.cgi?id=70056
39191
39192         Reviewed by Adam Barth.
39193
39194         The preferred file-order for patches is LayoutTests at the end and
39195         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
39196         it when creating patches for review and landing.
39197
39198         * Scripts/webkitpy/common/checkout/scm/git.py:
39199         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
39200         * Scripts/webkitpy/common/config/orderfile: Added.
39201
39202 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
39203
39204         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
39205         https://bugs.webkit.org/show_bug.cgi?id=69920
39206
39207         Reviewed by Kenneth Rohde Christiansen.
39208
39209         * DumpRenderTree/qt/DumpRenderTree.pro:
39210         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
39211         (WebCore::DumpRenderTree::open):
39212         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
39213         * QtTestBrowser/QtTestBrowser.pro:
39214         * QtTestBrowser/launcherwindow.cpp:
39215         (LauncherWindow::screenshot):
39216         (LauncherWindow::showFPS):
39217         (LauncherWindow::updateFPS):
39218         * QtTestBrowser/launcherwindow.h:
39219         (WindowOptions::WindowOptions):
39220         * QtTestBrowser/mainwindow.cpp:
39221         (MainWindow::buildUI):
39222         * Scripts/webkitpy/style/checker.py: Remove rules for the
39223         WebKit/qt/symbian/platformplugin directory.
39224         * Scripts/webkitpy/style/checker_unittest.py:
39225         * Tools.pro:
39226         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
39227         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
39228         (WTR::LayoutTestController::platformInitialize):
39229         * WebKitTestRunner/qt/TestControllerQt.cpp:
39230         (WTR::isExistingLibrary):
39231         * WebKitTestRunner/qt/WebKitTestRunner.pro:
39232
39233 2011-10-15  Adam Barth  <abarth@webkit.org>
39234
39235         Fix typo in webkitpy help
39236         https://bugs.webkit.org/show_bug.cgi?id=70169
39237
39238         Reviewed by Eric Seidel.
39239
39240         * Scripts/webkitpy/tool/commands/upload.py:
39241
39242 2011-10-15  Tony Chang  <tony@chromium.org>
39243
39244         fix another typo in treemap.html
39245         https://bugs.webkit.org/show_bug.cgi?id=70149
39246
39247         Reviewed by Ojan Vafai.
39248
39249         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
39250
39251         * TestResultServer/static-dashboards/treemap.html:
39252
39253 2011-10-14  Adam Barth  <abarth@webkit.org>
39254
39255         Hide status bubbles from queues which are very far behind
39256         https://bugs.webkit.org/show_bug.cgi?id=70133
39257
39258         Reviewed by Eric Seidel.
39259
39260         The mac-ews is so far behind that we shouldn't show its status bubble.
39261         The status bubble just makes contributors sad.
39262
39263         * QueueStatusServer/handlers/statusbubble.py:
39264
39265 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
39266
39267         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
39268         https://bugs.webkit.org/show_bug.cgi?id=70143
39269
39270         Reviewed by Adam Barth.
39271
39272         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
39273         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
39274
39275 2011-10-14  David Levin  <levin@chromium.org>
39276
39277         watchlist: Add a validation check for the email names in the list.
39278         https://bugs.webkit.org/show_bug.cgi?id=70154
39279
39280         Reviewed by Adam Barth.
39281
39282         If an email is listed which doesn't have a bugzilla log in, then any emails
39283         added to the bug along with that email will fail to happen, so try to prevent this
39284         from happening by validating that emails added to the watchlist are known to be
39285         contributors.
39286
39287         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
39288         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
39289         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
39290
39291 2011-10-14  David Levin  <levin@chromium.org>
39292
39293         watchlist: If the style check fails, then the watchlist will not be run.
39294         https://bugs.webkit.org/show_bug.cgi?id=69484
39295
39296         Reviewed by Adam Barth.
39297
39298         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
39299         if the style part fails and don't allow watch list failures turn the
39300         bot run red.
39301         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
39302         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
39303
39304 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
39305
39306         Plumb style-checker filter up to command options and make land-cowboy use it.
39307         https://bugs.webkit.org/show_bug.cgi?id=70119
39308
39309         Reviewed by Adam Barth.
39310
39311         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
39312         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
39313         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
39314         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
39315         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
39316         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
39317         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
39318
39319 2011-10-14  Sam Weinig  <sam@webkit.org>
39320
39321         Remove the Leopard slaves.
39322
39323         Reviewed by Adam Roben.
39324
39325         * BuildSlaveSupport/build.webkit.org-config/config.json:
39326
39327 2011-10-14  Peter Beverloo  <peter@chromium.org>
39328
39329         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
39330         https://bugs.webkit.org/show_bug.cgi?id=70028
39331
39332         Reviewed by Adam Barth.
39333
39334         * Scripts/update-webkit-chromium:
39335         * Scripts/webkitdirs.pm:
39336         (buildChromiumMakefile):
39337         (buildChromium):
39338
39339 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
39340
39341         Unreviewed; add missing #includes.
39342
39343         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
39344         * DumpRenderTree/efl/EventSender.cpp:
39345
39346 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
39347
39348         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
39349         https://bugs.webkit.org/show_bug.cgi?id=69770
39350
39351         Reviewed by Antonio Gomes.
39352
39353         We were just appending the given URL to the absolute URI of the main
39354         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
39355         instead of "file:///foo/bar/theother/url.html".
39356
39357         This should make fast/dom/navigation-type-navigate.html behave
39358         better (it still fails, but later).
39359
39360         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
39361         (LayoutTestController::queueLoad):
39362
39363 2011-10-13  Arko Saha  <arko@motorola.com>
39364
39365         Microdata: Basic implementation of document.getItems() method.
39366         https://bugs.webkit.org/show_bug.cgi?id=68610
39367
39368         Reviewed by Ryosuke Niwa.
39369
39370         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
39371         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
39372
39373         * Scripts/build-webkit:
39374
39375 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
39376
39377         new-run-webkit-tests does not support qt-4.8 results
39378         https://bugs.webkit.org/show_bug.cgi?id=64071
39379
39380         Roll-back second part of r97252. :)
39381
39382         * Scripts/webkitpy/layout_tests/port/qt.py:
39383
39384 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
39385
39386         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
39387         https://bugs.webkit.org/show_bug.cgi?id=70106
39388
39389         Reviewed by Antonio Gomes.
39390
39391         OwnFastMallocPtr was being used as a smart pointer that automatically called
39392         free() on the strings returned by the EFL or by ewk.
39393
39394         However, when WTF is built in release mode, it uses its own memory management
39395         code instead of using the system malloc(), free() and friends. This means bad
39396         things will happen when one uses WTF's free() on memory allocated with system
39397         malloc() by the EFL or ewk.
39398
39399         The easiest way to solve this is to call free() ourselves.
39400
39401         * DumpRenderTree/efl/DumpRenderTree.cpp:
39402         (dumpFramesAsText):
39403         (getFinalTestURL):
39404
39405 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
39406
39407         [EFL] Add DumpRenderTreeSupportEfl
39408         https://bugs.webkit.org/show_bug.cgi?id=68458
39409
39410         Reviewed by Kenneth Rohde Christiansen.
39411
39412         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
39413
39414         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
39415         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
39416         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
39417         (DumpRenderTreeChrome::onWindowObjectCleared):
39418         (DumpRenderTreeChrome::onDocumentLoadFinished):
39419         * DumpRenderTree/efl/GCControllerEfl.cpp:
39420         (GCController::collect):
39421         (GCController::collectOnAlternateThread):
39422         (GCController::getJSObjectCount):
39423         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
39424         (LayoutTestController::counterValueForElementById):
39425         (LayoutTestController::pageNumberForElementById):
39426         (LayoutTestController::numberOfPages):
39427         (LayoutTestController::workerThreadCount):
39428         (LayoutTestController::findString):
39429         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
39430         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
39431         (LayoutTestController::sampleSVGAnimationForElementAtTime):
39432         (LayoutTestController::numberOfActiveAnimations):
39433         (LayoutTestController::suspendAnimations):
39434         (LayoutTestController::resumeAnimations):
39435         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
39436         (createBitmapContextFromWebView):
39437
39438 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
39439
39440         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
39441
39442         Unreviewed.
39443
39444         * Scripts/run-webkit-tests:
39445         (useNewRunWebKitTests):
39446
39447 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
39448
39449         new-run-webkit-tests does not support qt-4.8 results
39450         https://bugs.webkit.org/show_bug.cgi?id=64071
39451
39452         Roll-back r97252 with unit test fix.
39453
39454         Reviewed by Csaba Osztrogonác.
39455
39456         * Scripts/webkitpy/layout_tests/port/qt.py:
39457         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
39458
39459 2011-10-13  Ojan Vafai  <ojan@chromium.org>
39460
39461         Make filter-build-webkit exit 1 if the build fails.
39462         https://bugs.webkit.org/show_bug.cgi?id=70080
39463
39464         Reviewed by Eric Seidel.
39465
39466         This only works if you redirect stderr to stdout, but it at least makes it possible.
39467         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
39468         only if the build succeeds.
39469
39470         * Scripts/filter-build-webkit:
39471
39472 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
39473
39474         land-cowboy should at least check style.
39475         https://bugs.webkit.org/show_bug.cgi?id=70073
39476
39477         Reviewed by Adam Barth.
39478
39479         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
39480
39481 2011-10-13  Tony Chang  <tony@chromium.org>
39482
39483         fix regex in layout test times dashboard
39484         https://bugs.webkit.org/show_bug.cgi?id=70059
39485
39486         This fixes the treemapfocus query param.
39487
39488         Reviewed by Ojan Vafai.
39489
39490         * TestResultServer/static-dashboards/treemap.html:
39491
39492 2011-10-13  Beth Dakin  <bdakin@apple.com>
39493
39494         https://bugs.webkit.org/show_bug.cgi?id=70050
39495         DRT and WRT should have HiDPI testing capabilities
39496
39497         Reviewed by Darin Adler.
39498
39499         New layoutTestController function setBackingScaleFactor takes a double for a scale
39500         factor and a callback function to call once the backing scale factor has
39501         successfully been set for the view.
39502         * DumpRenderTree/LayoutTestController.cpp:
39503         (setBackingScaleFactorCallback):
39504         (LayoutTestController::staticFunctions):
39505
39506         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other
39507         platforms do nothing.
39508         * DumpRenderTree/LayoutTestController.h:
39509         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
39510         (LayoutTestController::setBackingScaleFactor):
39511         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
39512         (LayoutTestController::setBackingScaleFactor):
39513         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
39514         (LayoutTestController::setBackingScaleFactor):
39515
39516         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a
39517         value of 0, which resets to the system default.
39518         * DumpRenderTree/mac/DumpRenderTree.mm:
39519         (resetWebViewToConsistentStateBeforeTesting):
39520
39521         When generating the pixel dump, create a Bitmap of the appropriate size based on
39522         the backing scale factor. If it is a HiDPI view, paint into the context using
39523         displayRectIgnoringOpacity.
39524         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
39525         (createBitmapContextFromWebView):
39526
39527         And now the same stuff for WK2. Again, new layoutTestController function
39528         setBackingScaleFactor takes a double for a scale factor and a callback function.
39529         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
39530         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
39531         (WTR::LayoutTestController::setBackingScaleFactor):
39532         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
39533         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
39534
39535         The InjectedBundle sends a message to the UI process to set the backing scale
39536         factor. It also processes a message the UI process will send back once it
39537         completes this task, and at that time, the InjectedBundle calls the callback.
39538         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
39539         (WTR::InjectedBundle::didReceiveMessage):
39540         (WTR::InjectedBundle::postSetBackingScaleFactor):
39541         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
39542
39543         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor
39544         with a value of 0, which resets to the system default.
39545         * WebKitTestRunner/TestController.cpp:
39546         (WTR::TestController::resetStateToConsistentValues):
39547
39548         Upon receiving the SetBackingScaleFactor message, call
39549         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message
39550         back to InjectedBundle to say it has been done.
39551         * WebKitTestRunner/TestInvocation.cpp:
39552         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
39553
39554         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a
39555         window's scale factor so we have to avoid that.
39556         * WebKitTestRunner/cg/TestInvocationCG.cpp:
39557         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
39558
39559 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
39560
39561         [Chromium] Allow building without speech input enabled.
39562         https://bugs.webkit.org/show_bug.cgi?id=69867
39563
39564         Reviewed by Darin Fisher.
39565
39566         * DumpRenderTree/chromium/LayoutTestController.cpp:
39567         (LayoutTestController::addMockSpeechInputResult):
39568
39569 2011-10-13  Kent Tamura  <tkent@chromium.org>
39570
39571         [Chromium] A DRT fix for r97348.
39572
39573         * DumpRenderTree/chromium/LayoutTestController.cpp:
39574         (LayoutTestController::overridePreference):
39575         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
39576         print an error message.
39577
39578 2011-10-12  Lucas Forschler  <lforschler@apple.com>
39579
39580         Update kill-old-processes logic.
39581         https://bugs.webkit.org/show_bug.cgi?id=63651
39582
39583         Reviewed by Ryosuke Niwa.
39584
39585         Remove unused mac platform specific folder.
39586         Update master.config to use new kill-old-processes.
39587
39588         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
39589         * BuildSlaveSupport/kill-old-processes:
39590         * BuildSlaveSupport/mac: Removed.
39591
39592 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
39593
39594         [NRWT] New tests without expected files are reported as flakey tests
39595         https://bugs.webkit.org/show_bug.cgi?id=67268
39596
39597         Reviewed by Dirk Pranke.
39598
39599         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
39600         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
39601         for missing results in retry_summary.
39602
39603         Fixed the bug by treating missing results separately.
39604
39605         * Scripts/webkitpy/layout_tests/controllers/manager.py:
39606         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
39607
39608 2011-10-12  Adam Barth  <abarth@webkit.org>
39609
39610         Remove ENABLE(XHTMLMP) and associated code
39611         https://bugs.webkit.org/show_bug.cgi?id=69729
39612
39613         Reviewed by David Levin.
39614
39615         * Scripts/build-webkit:
39616         * Scripts/old-run-webkit-tests:
39617         * Scripts/webkitperl/features.pm:
39618         * Scripts/webkitpy/layout_tests/port/webkit.py:
39619         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
39620
39621 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
39622
39623         Kill old run-webkit-tests processes in kill-process on Mac
39624         https://bugs.webkit.org/show_bug.cgi?id=69976
39625
39626         Reviewed by Dirk Pranke.
39627
39628         Add a system call to remove all python processes running run-webkit-tests.
39629
39630         * BuildSlaveSupport/kill-old-processes:
39631         * BuildSlaveSupport/mac: Removed.
39632
39633 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
39634
39635         Many WK2 snapshots are blank
39636         https://bugs.webkit.org/show_bug.cgi?id=69953
39637
39638         Reviewed by Beth Dakin.
39639
39640         Two fixes:
39641         1. negating a size_t in CGContextTranslateCTM() fails, because
39642         size_t is unsigned. Fix by casing to CGFloat before negation.
39643
39644         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
39645         Autodisplay is necessary to kick off Core Animation rendering.
39646
39647         * WebKitTestRunner/cg/TestInvocationCG.cpp:
39648         (WTR::createCGContextFromImage):
39649         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
39650         (WTR::PlatformWebView::PlatformWebView):
39651
39652 2011-10-12  Adam Barth  <abarth@webkit.org>
39653
39654         commit-queue doesn't have a friendly error message when the reviewer line is messed up
39655         https://bugs.webkit.org/show_bug.cgi?id=69979
39656
39657         Reviewed by Eric Seidel.
39658
39659         Rather than combining the ChangeLog validation with a more complicated
39660         command, this patch has the commit-queue run it as a separate command,
39661         which will give us more control over the error message.
39662
39663         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
39664         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
39665         * Scripts/webkitpy/tool/commands/download.py:
39666         * Scripts/webkitpy/tool/commands/queues_unittest.py:
39667         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
39668         * Scripts/webkitpy/tool/steps/validatereviewer.py:
39669
39670 2011-10-12  Eric Seidel  <eric@webkit.org>
39671
39672         Layout tests asserting in LayoutTestController::pathToLocalResource()
39673         https://bugs.webkit.org/show_bug.cgi?id=69898
39674
39675         Reviewed by Simon Fraser.
39676
39677         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
39678
39679         * Scripts/old-run-webkit-tests:
39680         (openDumpTool):
39681
39682 2011-10-12  Adam Barth  <abarth@webkit.org>
39683
39684         The commit-queue doesn't tell me which tests my patch broke
39685         https://bugs.webkit.org/show_bug.cgi?id=69975
39686
39687         Reviewed by Eric Seidel.
39688
39689         We now print the list of newly failing tests, like we do for the EWS.
39690
39691         * Scripts/webkitpy/tool/commands/queues.py:
39692         * Scripts/webkitpy/tool/commands/queues_unittest.py:
39693
39694 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
39695
39696         Added myself as a committer.
39697
39698         * Scripts/webkitpy/common/config/committers.py:
39699
39700 2011-10-12  Adam Barth  <abarth@webkit.org>
39701
39702         _run_tests is a confusing variable name in webkitpy
39703         https://bugs.webkit.org/show_bug.cgi?id=69971
39704
39705         Reviewed by Eric Seidel.
39706
39707         Eric and I thought this was a function.
39708
39709         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
39710
39711 2011-10-12  Tony Chang  <tony@chromium.org>
39712
39713         Fix test-webkitpy after r97307 and r97293.
39714
39715         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
39716           is None during tests so add back the check.
39717         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
39718           output directory is now build/Debug.
39719
39720 2011-10-12  Tony Chang  <tony@chromium.org>
39721
39722         [chromium] remove old build dirs on chromium-win
39723         https://bugs.webkit.org/show_bug.cgi?id=69961
39724
39725         Reviewed by Adam Barth.
39726
39727         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
39728           always in build and never in chrome or webkit.
39729
39730 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
39731
39732         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
39733         https://bugs.webkit.org/show_bug.cgi?id=69954
39734
39735         Also renamed the action and associated event name to address an FIXME.
39736
39737         Reviewed by Adam Barth.
39738
39739         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
39740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
39741         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
39742
39743 2011-10-12  Tony Chang  <tony@chromium.org>
39744
39745         stop spamming 'stopping test driver timed out, killing it' when running rwt
39746         https://bugs.webkit.org/show_bug.cgi?id=69938
39747
39748         Reviewed by Adam Barth.
39749
39750         In http://trac.webkit.org/changeset/95875 , we made the timeout for
39751         stopping the driver based on time_out_ms, but we based it on the wrong
39752         default times.
39753
39754         * Scripts/webkitpy/layout_tests/port/chromium.py:
39755
39756 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
39757
39758         3D transforms are flattened in WebKit2 snapshots
39759         https://bugs.webkit.org/show_bug.cgi?id=68276
39760
39761         Reviewed by Adam Roben.
39762
39763         Fix WKImage leak noticed by Adam.
39764
39765         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
39766         (WTR::PlatformWebView::windowSnapshotImage):
39767
39768 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
39769
39770         garden-o-matic should color-code test failure types.
39771         https://bugs.webkit.org/show_bug.cgi?id=69945
39772
39773         Reviewed by Adam Barth.
39774
39775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
39776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
39777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
39778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
39779
39780 2011-10-12  Adam Barth  <abarth@webkit.org>
39781
39782         webkitpy tests are failing on Mac bots
39783         https://bugs.webkit.org/show_bug.cgi?id=69929
39784
39785         Reviewed by Simon Fraser.
39786
39787         Admit that Lion exists.
39788
39789         * Scripts/webkitpy/layout_tests/port/chromium.py:
39790         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
39791
39792 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
39793
39794         Improve output of run-api-tests to make time-outs more obvious
39795         https://bugs.webkit.org/show_bug.cgi?id=69788
39796
39797         Reviewed by Adam Roben.
39798
39799         List the tests that failed and timed out at the bottom of the output,
39800         if run with --verbose.
39801
39802         * Scripts/run-api-tests:
39803         (runAllTests):
39804         (runTest):
39805
39806 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
39807
39808         Unreviewed, rolling out r97252.
39809         http://trac.webkit.org/changeset/97252
39810         https://bugs.webkit.org/show_bug.cgi?id=69944
39811
39812         Broke test-webkpy (Requested by abarth on #webkit).
39813
39814         * Scripts/webkitpy/layout_tests/port/qt.py:
39815         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
39816
39817 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
39818
39819         new-run-webkit-tests does not support qt-4.8 results
39820         https://bugs.webkit.org/show_bug.cgi?id=64071
39821
39822         Reviewed by Csaba Osztrogonác.
39823
39824         * Scripts/webkitpy/layout_tests/port/qt.py:
39825         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
39826
39827 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
39828
39829         [GTK] [WebKit2] Make adding another unit test easier
39830         https://bugs.webkit.org/show_bug.cgi?id=69409
39831
39832         Reviewed by Gustavo Noronha Silva.
39833
39834         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
39835         new WebKit2 tests.
39836
39837 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
39838
39839         [WebSocket] update pywebsocket to 0.6b6.
39840         https://bugs.webkit.org/show_bug.cgi?id=69824
39841
39842         Reviewed by Kent Tamura.
39843
39844         WebKit supports WebSocket with version 8 based protocol for now.
39845         We should update its protocol to version 13 based one like hybi-17.
39846         pywebsocket 0.6b6 supports both of version 8 and 13.
39847
39848         * Scripts/webkitpy/thirdparty/__init__.py:
39849
39850 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
39851
39852         WebKitTestRunner needs to link with WebKit for NSURL category methods
39853         https://bugs.webkit.org/show_bug.cgi?id=69892
39854
39855         Reviewed by Sam Weinig.
39856
39857         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
39858         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
39859         WebKit.framework to fix this.
39860
39861         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
39862
39863 2011-10-11  Adam Barth  <abarth@webkit.org>
39864
39865         sheriffbot takes too long to acknowledge rollout commands
39866         https://bugs.webkit.org/show_bug.cgi?id=69871
39867
39868         Reviewed by Eric Seidel.
39869
39870         We used to update the working copy before acknowledging the command
39871         because we wanted to ping all the relevant IRC nicks.  That's caused a
39872         bunch of frustration because folks don't know whether the bot has heard
39873         their commands.
39874
39875         This patch makes the bot reply immediately before updating the working
39876         copy.  All the relevenat folks are still pinged when the bot finishes
39877         preparing the rollout.
39878
39879         * Scripts/webkitpy/tool/bot/irc_command.py:
39880         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
39881
39882 2011-10-11  Adam Barth  <abarth@webkit.org>
39883
39884         test-webkitpy fails on Lion
39885         https://bugs.webkit.org/show_bug.cgi?id=69873
39886
39887         Reviewed by Eric Seidel.
39888
39889         This patch fixes one of the two failures.  I'll need to track down the
39890         other failure another time.
39891
39892         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
39893
39894 2011-10-11  Adam Barth  <abarth@webkit.org>
39895
39896         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
39897         https://bugs.webkit.org/show_bug.cgi?id=65230
39898
39899         Reviewed by Dimitri Glazkov.
39900
39901         This patch causes us to treat crashed or hung run-webkit-tests runs
39902         similarly to how we treat compile failures.  In some sense, they're
39903         similar because they prevent us from getting test coverage.
39904
39905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
39906         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
39907
39908 2011-10-11  Adam Barth  <abarth@webkit.org>
39909
39910         Failing builder display in garden-o-matic should have the same visual style as the failure grid
39911         https://bugs.webkit.org/show_bug.cgi?id=69876
39912
39913         Reviewed by Dimitri Glazkov.
39914
39915         This patch generalizes the view we use for failing builders in the
39916         FailureGrid so that we can use it for the list of builders that aren't
39917         compiling.
39918
39919         One downside of this patch is that it makes it harder to tell when
39920         debug builders are failing (as opposed to release builders) because
39921         that information isn't presented in this view.  A future patch will
39922         improve this aspect.
39923
39924         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
39925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
39926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
39927         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
39928         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
39929         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
39930
39931 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
39932
39933         Some API tests are timing out in Release
39934         https://bugs.webkit.org/show_bug.cgi?id=69787
39935
39936         Reviewed by Mark Rowe.
39937
39938         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
39939         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
39940
39941         * TestWebKitAPI/Configurations/Base.xcconfig:
39942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39943         * TestWebKitAPI/config.h:
39944
39945 2011-10-11  Adam Barth  <abarth@webkit.org>
39946
39947         garden-o-matic links to flakiness dashboard should open in a new tab
39948         https://bugs.webkit.org/show_bug.cgi?id=69864
39949
39950         Reviewed by Dimitri Glazkov.
39951
39952         This bug was obvious in the first five minutes of using this new
39953         feature.  :)
39954
39955         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
39956         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
39957
39958 2011-10-11  Adam Barth  <abarth@webkit.org>
39959
39960         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
39961         that * doesn't really mean "all".  I've emailed the W3C working group
39962         about changing the spec.
39963
39964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
39965
39966 2011-10-11  Adam Barth  <abarth@webkit.org>
39967
39968         garden-o-matic should link to the flakiness dashboard
39969         https://bugs.webkit.org/show_bug.cgi?id=69862
39970
39971         Reviewed by Dimitri Glazkov.
39972
39973         The flakiness dashboard has lots of great information about the failure
39974         history of each test.  This patch adds a link from garden-o-matic to
39975         the flakiness dashboard so the gardener can look at this information.
39976
39977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
39978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
39979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
39980
39981 2011-10-11  David Levin  <levin@chromium.org>
39982
39983         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
39984         https://bugs.webkit.org/show_bug.cgi?id=69789
39985
39986         Reviewed by Eric Seidel.
39987
39988         Made the signature of _assertRaisesRegexp match that of Python 2.7.
39989
39990         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
39991         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
39992         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
39993         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
39994
39995 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
39996
39997         [EFL] DRT: Do not abort() when an unknown key is pressed.
39998         https://bugs.webkit.org/show_bug.cgi?id=69856
39999
40000         Reviewed by Antonio Gomes.
40001
40002         A lot of tests crash due to the previous behaviour. Just using the
40003         received name of the pressed key works most of the time, and when it
40004         does not the failing tests should tell us.
40005
40006         * DumpRenderTree/efl/EventSender.cpp:
40007         (keyPadNameFromJSValue):
40008         (keyNameFromJSValue):
40009         (keyDownCallback):
40010
40011 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
40012
40013         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
40014         https://bugs.webkit.org/show_bug.cgi?id=68016
40015
40016         Reviewed by Chang Shu.
40017
40018         * Scripts/webkitpy/layout_tests/port/qt.py:
40019
40020 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
40021
40022         [EFL] DRT: Return the right window count in LayoutTestController.
40023         https://bugs.webkit.org/show_bug.cgi?id=69764
40024
40025         Reviewed by Antonio Gomes.
40026
40027         Follow-up to r96943: now that we have DumpRenderTreeChrome and
40028         DumpRenderTreeView in the tree, we can correctly count the number of
40029         open windows in DRT.
40030
40031         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
40032         (LayoutTestController::windowCount):
40033
40034 2011-10-11  Jer Noble  <jer.noble@apple.com>
40035
40036         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
40037         https://bugs.webkit.org/show_bug.cgi?id=69800
40038
40039         Reviewed by Csaba Osztrogonác.
40040
40041         Enable WEB_AUDIO at runtime.
40042
40043         * DumpRenderTree/mac/DumpRenderTree.mm:
40044         (resetDefaultsToConsistentValues):
40045
40046 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
40047
40048         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
40049         https://bugs.webkit.org/show_bug.cgi?id=69769
40050
40051         Reviewed by Antonio Gomes.
40052
40053         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
40054         (LayoutTestController::setIconDatabaseEnabled):
40055
40056 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
40057
40058         [Qt] Remove all references to QTDIR_build and standalone_package
40059
40060         Qt is now modularized, which means we no longer import WebKit into
40061         the Qt source tree. Instead we use git submodules, and building
40062         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
40063
40064         To decrease the number of buildsystem configurations we also remove
40065         the standalone_package code-path used when we were providing tarballs
40066         with the derived sources pre-generated.
40067
40068         Reviewed by Simon Hausmann.
40069
40070         * MiniBrowser/qt/MiniBrowser.pro:
40071         * QtTestBrowser/QtTestBrowser.pro:
40072         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
40073
40074 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
40075
40076         Update Chromium accessibility support in DRT.
40077         https://bugs.webkit.org/show_bug.cgi?id=69676
40078
40079         Reviewed by Chris Fleizach.
40080
40081         Adds several missing properties and methods to enable more
40082         tests to pass, and in particular adds support for notification
40083         callbacks.
40084
40085         * DumpRenderTree/chromium/AccessibilityController.cpp:
40086         (AccessibilityController::AccessibilityController):
40087         (AccessibilityController::reset):
40088         (AccessibilityController::getFocusedElement):
40089         (AccessibilityController::shouldLogAccessibilityEvents):
40090         (AccessibilityController::notificationReceived):
40091         (AccessibilityController::logAccessibilityEventsCallback):
40092         * DumpRenderTree/chromium/AccessibilityController.h:
40093         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
40094         (getHelpText):
40095         (getStringValue):
40096         (getOrientation):
40097         (AccessibilityUIElement::AccessibilityUIElement):
40098         (AccessibilityUIElement::getChildAtIndex):
40099         (AccessibilityUIElement::isEqual):
40100         (AccessibilityUIElement::notificationReceived):
40101         (AccessibilityUIElement::roleGetterCallback):
40102         (AccessibilityUIElement::titleGetterCallback):
40103         (AccessibilityUIElement::descriptionGetterCallback):
40104         (AccessibilityUIElement::helpTextGetterCallback):
40105         (AccessibilityUIElement::stringValueGetterCallback):
40106         (AccessibilityUIElement::xGetterCallback):
40107         (AccessibilityUIElement::yGetterCallback):
40108         (AccessibilityUIElement::widthGetterCallback):
40109         (AccessibilityUIElement::heightGetterCallback):
40110         (AccessibilityUIElement::intValueGetterCallback):
40111         (AccessibilityUIElement::minValueGetterCallback):
40112         (AccessibilityUIElement::maxValueGetterCallback):
40113         (AccessibilityUIElement::childrenCountGetterCallback):
40114         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
40115         (AccessibilityUIElement::selectedTextRangeGetterCallback):
40116         (AccessibilityUIElement::isEnabledGetterCallback):
40117         (AccessibilityUIElement::isRequiredGetterCallback):
40118         (AccessibilityUIElement::isFocusedGetterCallback):
40119         (AccessibilityUIElement::isFocusableGetterCallback):
40120         (AccessibilityUIElement::isSelectedGetterCallback):
40121         (AccessibilityUIElement::isSelectableGetterCallback):
40122         (AccessibilityUIElement::isMultiSelectableGetterCallback):
40123         (AccessibilityUIElement::isExpandedGetterCallback):
40124         (AccessibilityUIElement::isCheckedGetterCallback):
40125         (AccessibilityUIElement::isVisibleGetterCallback):
40126         (AccessibilityUIElement::isOffScreenGetterCallback):
40127         (AccessibilityUIElement::isCollapsedGetterCallback):
40128         (AccessibilityUIElement::hasPopupGetterCallback):
40129         (AccessibilityUIElement::isValidGetterCallback):
40130         (AccessibilityUIElement::orientationGetterCallback):
40131         (AccessibilityUIElement::showMenuCallback):
40132         (AccessibilityUIElement::pressCallback):
40133         (AccessibilityUIElement::isEqualCallback):
40134         (AccessibilityUIElement::addNotificationListenerCallback):
40135         (AccessibilityUIElement::removeNotificationListenerCallback):
40136         (AccessibilityUIElement::takeFocusCallback):
40137         (AccessibilityUIElement::fallbackCallback):
40138         (RootAccessibilityUIElement::getChildAtIndex):
40139         (AccessibilityUIElementList::getOrCreate):
40140         * DumpRenderTree/chromium/AccessibilityUIElement.h:
40141         * DumpRenderTree/chromium/CppVariant.cpp:
40142         (CppVariant::invokeDefault):
40143         * DumpRenderTree/chromium/CppVariant.h:
40144         * DumpRenderTree/chromium/LayoutTestController.cpp:
40145         (LayoutTestController::LayoutTestController):
40146         (LayoutTestController::reset):
40147         * DumpRenderTree/chromium/LayoutTestController.h:
40148         * DumpRenderTree/chromium/WebViewHost.cpp:
40149         (WebViewHost::postAccessibilityNotification):
40150
40151 2011-10-10  Adam Klein  <adamk@chromium.org>
40152
40153         Support Distributed-CompileC as an action name in filter-build-webkit
40154         https://bugs.webkit.org/show_bug.cgi?id=69783
40155
40156         Reviewed by Ojan Vafai.
40157
40158         * Scripts/filter-build-webkit:
40159
40160 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
40161
40162         3D transforms are flattened in WebKit2 snapshots
40163         https://bugs.webkit.org/show_bug.cgi?id=68276
40164
40165         Reviewed by Anders Carlsson.
40166
40167         Use a snapshot of the window, rather than an image from the web process
40168         for pixel testing in WebKitTestRunner. This correctly captures compositing
40169         layers, so works for 3D transform tests.
40170
40171         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
40172         * WebKitTestRunner/cg/TestInvocationCG.cpp:
40173         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
40174         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
40175         use that instead of the image we get from the web process.
40176         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
40177         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
40178         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
40179         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
40180         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
40181         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
40182         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
40183         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
40184
40185 2011-10-10  David Levin  <levin@chromium.org>
40186
40187         Quick fix for watchlist unit test failures when using Python 2.7+
40188         Reviewed by Adam Barth.
40189
40190         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
40191         better fix.
40192
40193         * Scripts/webkitpy/common/webkitunittest.py: Always use our
40194         version of assertRaisesRegexp.
40195
40196 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
40197
40198         Unreviewed, rolling out r97082.
40199         http://trac.webkit.org/changeset/97082
40200         https://bugs.webkit.org/show_bug.cgi?id=69784
40201
40202         broke Windows build (Requested by smfr on #webkit).
40203
40204         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
40205         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
40206         (WTR::createCGContextFromImage):
40207         (WTR::computeMD5HashStringForContext):
40208         (WTR::dumpBitmap):
40209         (WTR::paintRepaintRectOverlay):
40210         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
40211         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
40212         (WTR::PlatformWebView::PlatformWebView):
40213
40214 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
40215
40216         3D transforms are flattened in WebKit2 snapshots
40217         https://bugs.webkit.org/show_bug.cgi?id=68276
40218
40219         Reviewed by Anders Carlsson.
40220
40221         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
40222         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
40223         the window when doing pixel tests.
40224
40225         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
40226
40227         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
40228         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
40229         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
40230         (WTR::computeMD5HashStringForContext):
40231         (WTR::dumpBitmap):
40232         (WTR::paintRepaintRectOverlay):
40233         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
40234         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
40235         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
40236         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
40237         We need the window to autodisplay for Core Animation to render layers and start animations.
40238
40239 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
40240
40241         WebKitTestRunner needs layoutTestController.setWindowIsKey
40242         https://bugs.webkit.org/show_bug.cgi?id=42688
40243
40244         Reviewed by Anders Carlsson.
40245
40246         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
40247         This sets a flag that the platform layer uses to indicate that
40248         the window is the key window, which fixes focus ring drawing
40249         in pixel results.
40250
40251         Also focus the web view when we get a 'didCommitLoad' for the main
40252         frame, as DumpRenderTree does.
40253
40254         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
40255         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
40256         (WTR::InjectedBundle::postSetWindowIsKey):
40257         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
40258         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
40259         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
40260         (WTR::LayoutTestController::addChromeInputField):
40261         (WTR::LayoutTestController::removeChromeInputField):
40262         (WTR::LayoutTestController::focusWebView):
40263         (WTR::LayoutTestController::setWindowIsKey):
40264         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
40265         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
40266         (WTR::LayoutTestController::callFocusWebViewCallback):
40267         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
40268         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
40269         so that we can override -isKeyWindow. Use a boolean member variable
40270         to track window key status.
40271         (WTR::PlatformWebView::setWindowIsKey):
40272         (WTR::PlatformWebView::windowIsKey):
40273         * WebKitTestRunner/TestController.cpp:
40274         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
40275         (WTR::closeOtherPage): Use the same cast as other functions.
40276         (WTR::focus): Implement to call setWindowIsKey(true)
40277         (WTR::unfocus): Implement to call setWindowIsKey(false)
40278         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
40279         (WTR::TestController::initialize):
40280         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
40281         * WebKitTestRunner/TestController.h:
40282         * WebKitTestRunner/TestInvocation.cpp:
40283         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
40284         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
40285         (WTR::PlatformWebView::PlatformWebView):
40286         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
40287         (-[WebKitTestRunnerWindow isKeyWindow]):
40288         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
40289         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
40290         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
40291         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
40292         (WTR::PlatformWebView::PlatformWebView):
40293         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
40294         (WTR::PlatformWebView::PlatformWebView):
40295
40296 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
40297
40298         check-webkit-style: Add readability exception for Ewk_* data types.
40299         https://bugs.webkit.org/show_bug.cgi?id=69763
40300
40301         Reviewed by David Levin.
40302
40303         Many EFL-related files (such as EditorClientEfl.h or
40304         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
40305         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
40306         check-webkit-style.
40307
40308         Add an exception for them, just like there are exceptions for
40309         Evas_*, Ecore_* and others.
40310
40311         * Scripts/webkitpy/style/checkers/cpp.py:
40312         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
40313
40314 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
40315
40316         [Chromium] Get rid of WebAccessibilityCache.
40317         https://bugs.webkit.org/show_bug.cgi?id=68224
40318
40319         Reviewed by Dimitri Glazkov.
40320
40321         * DumpRenderTree/chromium/AccessibilityController.cpp:
40322         (AccessibilityController::bindToJavascript):
40323
40324 2011-10-09  Adam Barth  <abarth@webkit.org>
40325
40326         Remove "near miss" XSS vulnerabilities in garden-o-matic
40327         https://bugs.webkit.org/show_bug.cgi?id=69708
40328
40329         Reviewed by David Levin.
40330
40331         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
40332         any actual vulnerabilities yet, but he did identify a couple "near
40333         misses" where a slight change in garden-o-matic could lead to a
40334         vulnerability.  This patch removes those potential issues.
40335
40336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
40337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
40338
40339 2011-10-07  Adam Barth  <abarth@webkit.org>
40340
40341         Add a Content-Security-Policy to garden-o-matic
40342         https://bugs.webkit.org/show_bug.cgi?id=69668
40343
40344         Reviewed by David Levin.
40345
40346         This will help mitigate cross-site script and will also help us dogfood CSP.
40347
40348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
40349
40350 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
40351
40352         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
40353         https://bugs.webkit.org/show_bug.cgi?id=66380
40354
40355         Reviewed by Antonio Gomes.
40356
40357         This encapsulates EWebKit into an object that manages multiple windows
40358         and provides a cleaner interface to EFL's DumpRenderTree.
40359
40360         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
40361         (DumpRenderTreeChrome::create):
40362         (DumpRenderTreeChrome::DumpRenderTreeChrome):
40363         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
40364         (DumpRenderTreeChrome::createNewWindow):
40365         (DumpRenderTreeChrome::createView):
40366         (DumpRenderTreeChrome::removeWindow):
40367         (DumpRenderTreeChrome::initialize):
40368         (DumpRenderTreeChrome::extraViews):
40369         (DumpRenderTreeChrome::mainFrame):
40370         (DumpRenderTreeChrome::mainView):
40371         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
40372         (DumpRenderTreeChrome::onWindowObjectCleared):
40373         (DumpRenderTreeChrome::onLoadStarted):
40374         (DumpRenderTreeChrome::processWork):
40375         (DumpRenderTreeChrome::onLoadFinished):
40376         (DumpRenderTreeChrome::onStatusbarTextSet):
40377         (DumpRenderTreeChrome::onTitleChanged):
40378         (DumpRenderTreeChrome::onDocumentLoadFinished):
40379         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
40380         * DumpRenderTree/efl/EventSender.cpp:
40381         (sendClick): Use browser->mainFrame() instead of mainFrame.
40382         (mouseDownCallback): Ditto.
40383         (mouseUpCallback): Ditto.
40384         (mouseMoveToCallback): Ditto.
40385         (mouseScrollByCallback): Ditto.
40386         (keyDownCallback): Ditto.
40387         (scalePageByCallback): Ditto.
40388         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
40389         (LayoutTestController::counterValueForElementById): Use
40390         browser->mainFrame() instead of mainFrame.
40391         (LayoutTestController::pageNumberForElementById): Ditto.
40392         (LayoutTestController::numberOfPages): Ditto.
40393         (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
40394         (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
40395         (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
40396         (LayoutTestController::numberOfActiveAnimations): Ditto.
40397         (LayoutTestController::suspendAnimations): Ditto.
40398         (LayoutTestController::resumeAnimations): Ditto.
40399         (LayoutTestController::setWebViewEditable): Ditto.
40400         (LayoutTestController::webHistoryItemCount): Use browser->mainView()
40401         instead of browser.
40402         (LayoutTestController::queueLoad): Ditto.
40403         (LayoutTestController::setAcceptsEditing): Ditto.
40404         (LayoutTestController::setUserStyleSheetEnabled): Ditto.
40405         (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
40406         (LayoutTestController::setFrameFlatteningEnabled): Ditto.
40407         (LayoutTestController::setSpatialNavigationEnabled): Ditto.
40408         (LayoutTestController::setPluginsEnabled): Ditto.
40409         (LayoutTestController::findString): Ditto.
40410         (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
40411         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
40412         (createBitmapContextFromWebView): Use browser->mainFrame() instead of
40413         mainFrame.
40414         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
40415         (LoadItem::invoke): Ditto.
40416         (LoadHTMLStringItem::invoke): Ditto.
40417         (ScriptItem::invoke): Ditto.
40418         (ReloadItem::invoke): Use browser->mainView() instead of browser.
40419
40420 2011-10-07  Simon Hausmann  <simon.hausmann@nokia.com>
40421
40422         [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
40423         https://bugs.webkit.org/show_bug.cgi?id=69617
40424
40425         Reviewed by Andreas Kling.
40426
40427         Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
40428         the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
40429         events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
40430         events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
40431         logic.
40432
40433         * MiniBrowser/qt/MiniBrowserApplication.cpp:
40434         (MiniBrowserApplication::MiniBrowserApplication):
40435         (MiniBrowserApplication::notify):
40436         * MiniBrowser/qt/MiniBrowserApplication.h:
40437
40438 2011-10-06  Adam Barth  <abarth@webkit.org>
40439
40440         Port PixelZoomer to work in garden-o-matic
40441         https://bugs.webkit.org/show_bug.cgi?id=69577
40442
40443         Reviewed by David Levin.
40444
40445         This implementation of PixelZoomer is basically a fork of the
40446         implementation used by results.html.  These two apps have different
40447         requirements on where this code lives.  results.html wants to be
40448         self-contained whereas garden-o-matic wants to live in the public_html
40449         folder of the buildbot.  We could do something fancy here to share the
40450         code, but that's not likely to be of much benefit.
40451
40452         I had to change a few things about pixelzoomer to accounter for the
40453         differences in DOM between results.html and garden-o-matic, but
40454         surprisingly little.  I also moved all the code into an anonymous
40455         function, which is the style we're suing for module separation in
40456         garden-o-matic.  Finally, some jQuery-ims snuck in because I didn't
40457         want to drag along too many extra functions from results.html.
40458
40459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
40460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
40461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
40462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
40463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
40464         (.pixel-zoom-container):
40465         (.pixel-zoom-container > *):
40466         (.pixel-zoom-container .scaled-image-container):
40467         (.scaled-image-container > img):
40468
40469 2011-10-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
40470
40471         [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
40472         https://bugs.webkit.org/show_bug.cgi?id=69505
40473
40474         Reviewed by Andreas Kling.
40475
40476         * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
40477         (on_viewport_changed):
40478
40479 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
40480
40481         [WinCairo] Unreviewed test correction.
40482
40483         * Scripts/webkitdirs.pm:
40484         (argumentsForConfiguration): Add 'wincairo' option to the set of
40485         configuration flags used by run-javascript-core tests, so that it
40486         does not attempt to run Apple's release version.
40487
40488 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
40489
40490         [WinCairo] Unreviewed test correction.
40491
40492         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
40493          of known build slave types so that test-result-archive won't fail
40494          when running tests.
40495
40496 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
40497
40498         The GTK+ WebKit2 headers produce a lot of style warnings
40499         https://bugs.webkit.org/show_bug.cgi?id=69481
40500
40501         Reviewed by David Levin.
40502
40503         Prevent emitting so many style warnings for GTK+ API. We skip header
40504         files in the WebKit2 GTK+ API directory and also avoid warnings about
40505         identifier names that begin with "webkit_" in files that contain the
40506         string "gtk".
40507
40508         * Scripts/webkitpy/style/checker.py: Do not check header files in
40509         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
40510         adding the ability to specify a regular expression in the skip list. Remove
40511         a few files from the skipped list that no longer exist.
40512         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
40513         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
40514         about identifiers that begin with "webkit_".
40515         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
40516
40517 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
40518
40519         [WinCairo] Correct config.json for WinCairo Test builds.
40520         https://bugs.webkit.org/show_bug.cgi?id=69272
40521
40522         Reviewed by Ryosuke Niwa.
40523
40524         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
40525          old 'WinCairo Debug (Build)' label and replace with correct
40526          'WinCairo Release' label.
40527
40528 2011-10-06  David Levin  <levin@chromium.org>
40529
40530         Add a style checker watchlist definition and add myself to it.
40531         https://bugs.webkit.org/show_bug.cgi?id=69564
40532
40533         Reviewed by Daniel Bates.
40534
40535         * Scripts/webkitpy/common/config/watchlist:
40536
40537 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
40538
40539         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
40540         https://bugs.webkit.org/show_bug.cgi?id=69450
40541
40542         Reviewed by Ryosuke Niwa.
40543
40544         This should avoid stderr messages when running
40545         webarchive/test-link-rel-icon.html.
40546
40547         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
40548         (LayoutTestController::setIconDatabaseEnabled):
40549
40550 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
40551
40552         [WK2] [GTK] Add Skipped file for Webkit2 test runner
40553         https://bugs.webkit.org/show_bug.cgi?id=69517
40554
40555         Use the shared WK2 skipped file also in GTK port.
40556
40557         Reviewed by Martin Robinson.
40558
40559         * Scripts/old-run-webkit-tests:
40560         (readSkippedFiles):
40561
40562 2011-10-06  Elliot Poger  <epoger@google.com>
40563
40564         allow new-run-webkit-tests to run on Lion
40565         https://bugs.webkit.org/show_bug.cgi?id=69429
40566
40567         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
40568         directory to fallback lists (even though that directory doesn't exist yet)
40569
40570         Reviewed by Adam Barth.
40571
40572         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
40573         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
40574
40575 2011-10-03  Hans Wennborg  <hans@chromium.org>
40576
40577         IndexedDB: Remove SQLite-LevelDB migration code
40578         https://bugs.webkit.org/show_bug.cgi?id=69264
40579
40580         Reviewed by Tony Chang.
40581
40582         Remove setOverrideIndexedDBBackingStore. It was used in the layout
40583         test for migration.
40584
40585         * DumpRenderTree/chromium/LayoutTestController.cpp:
40586         (LayoutTestController::LayoutTestController):
40587         * DumpRenderTree/chromium/LayoutTestController.h:
40588
40589 2011-10-05  James Robinson  <jamesr@chromium.org>
40590
40591         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
40592         https://bugs.webkit.org/show_bug.cgi?id=69498
40593
40594         Reviewed by Adam Barth.
40595
40596         * DumpRenderTree/chromium/DumpRenderTree.cpp:
40597         (main):
40598         * DumpRenderTree/chromium/TestShell.cpp:
40599         (TestShell::TestShell):
40600         (TestShell::resetWebSettings):
40601         * DumpRenderTree/chromium/TestShell.h:
40602         (TestShell::setThreadedCompositingEnabled):
40603         * DumpRenderTree/chromium/WebPreferences.cpp:
40604         (WebPreferences::reset):
40605         (WebPreferences::applyTo):
40606         * DumpRenderTree/chromium/WebPreferences.h:
40607         * Scripts/webkitpy/layout_tests/port/chromium.py:
40608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
40609
40610 2011-10-05  Erik Arvidsson  <arv@chromium.org>
40611
40612         [QT] Fix DRT after r96779
40613
40614         unreviewed.
40615
40616         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
40617         (WebCore::dumpHistoryItem):
40618
40619 2011-10-05  Erik Arvidsson  <arv@chromium.org>
40620
40621         window.location.href and others needlessly decodes URI-encoded characters
40622         https://bugs.webkit.org/show_bug.cgi?id=30225
40623
40624         Reviewed by Darin Adler.
40625
40626         * DumpRenderTree/chromium/TestShell.cpp:
40627         (normalizeLayoutTestURLInternal): Remove extra encode.
40628
40629 2011-10-05  Darin Adler  <darin@apple.com>
40630
40631         Fix build.
40632
40633         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
40634         (TestWebKitAPI::TEST): Remove underscore prefix from call to
40635         WKContextRegisterURLSchemeAsEmptyDocument.
40636
40637 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
40638
40639         [WinCairo] Switch to building Release target, and activate tests.
40640         https://bugs.webkit.org/show_bug.cgi?id=69272
40641
40642         Reviewed by Adam Barth.
40643
40644         * BuildSlaveSupport/build.webkit.org-config/config.json:
40645         Change from debug to release target. Switch from "Build" to
40646         "BuildAndTest"
40647
40648 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
40649
40650         In WebKitTestRunner, text has font smoothing in pixel snapshots
40651         https://bugs.webkit.org/show_bug.cgi?id=69396
40652
40653         Reviewed by Darin Adler.
40654
40655         Call the new WKContext method that disables font smoothing in
40656         WebKitTestRunner, so that pixel snapshots don't have font smoothing
40657         enabled. Remove leading underscore from a WKContext function call.
40658
40659         * WebKitTestRunner/TestController.cpp:
40660         (WTR::TestController::resetStateToConsistentValues):
40661
40662 2011-10-05  David Levin  <levin@chromium.org>
40663
40664         Improve the watchlist for threading entries.
40665         https://bugs.webkit.org/show_bug.cgi?id=69463
40666
40667         Reviewed by Adam Barth.
40668
40669         * Scripts/webkitpy/common/config/watchlist:
40670
40671 2011-10-05  Adam Roben  <aroben@apple.com>
40672
40673         Add tests for using RetainPtrs inside HashMap and HashSet
40674
40675         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
40676         in HashMap/HashSet fails to compile
40677
40678         Reviewed by John Sullivan.
40679
40680         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
40681         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
40682         and value type of HashMap.
40683
40684         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
40685         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
40686         Added new file.
40687
40688 2011-10-05  Adam Barth  <abarth@webkit.org>
40689
40690         Mark as Expected in garden-o-matic is confusing
40691         https://bugs.webkit.org/show_bug.cgi?id=69452
40692
40693         Reviewed by David Levin.
40694
40695         krit didn't understand the difference between this button and the
40696         Rebaseline button because both of them seem to indicate that the new
40697         behavior is expected.  This patch renames "Mark as Expected" to "Expect
40698         Failure" to make it clear that we're just expecting the test to fail
40699         rather than accepting the new results as passing.  We might need to
40700         iterate on these names a bit more if folks continue to find them
40701         confusing.
40702
40703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
40704
40705 2011-10-05  Adam Barth  <abarth@webkit.org>
40706
40707         Add watchlist entries for abarth
40708         https://bugs.webkit.org/show_bug.cgi?id=69461
40709
40710         Reviewed by David Levin.
40711
40712         I might have gone a bit overboard.  We'll see if this is too much spam
40713         for me.
40714
40715         * Scripts/webkitpy/common/config/watchlist:
40716
40717 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
40718
40719         [WinCairo] Teach old-run-webkit-tests about wincairo.
40720         https://bugs.webkit.org/show_bug.cgi?id=69280
40721
40722         Reviewed by Adam Roben.
40723
40724         * Scripts/old-run-webkit-tests: Handle wincairo case.
40725         (buildPlatformResultHierarchy):
40726         (readSkippedFiles): Ditto
40727         * Scripts/webkitdirs.pm: Deal with wincairo build case.
40728         (determineConfiguration):
40729
40730 2011-10-05  Chang Shu  <cshu@webkit.org>
40731
40732         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
40733         https://bugs.webkit.org/show_bug.cgi?id=68924
40734
40735         Added TextInputController files and JS interfaces for the above functions.
40736
40737         Reviewed by Darin Adler.
40738
40739         * WebKitTestRunner/DerivedSources.make:
40740         * WebKitTestRunner/DerivedSources.pro:
40741         * WebKitTestRunner/GNUmakefile.am:
40742         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
40743         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
40744         (WTR::InjectedBundle::beginTesting):
40745         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
40746         (WTR::InjectedBundle::textInputController):
40747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
40748         (WTR::InjectedBundlePage::didClearWindowForFrame):
40749         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
40750         (WTR::TextInputController::create):
40751         (WTR::TextInputController::TextInputController):
40752         (WTR::TextInputController::~TextInputController):
40753         (WTR::TextInputController::wrapperClass):
40754         (WTR::TextInputController::makeWindowObject):
40755         (WTR::TextInputController::setMarkedText):
40756         (WTR::TextInputController::hasMarkedText):
40757         (WTR::TextInputController::unmarkText):
40758         (WTR::TextInputController::insertText):
40759         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
40760         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
40761         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
40762         * WebKitTestRunner/win/InjectedBundle.vcproj:
40763
40764 2011-10-04  Oliver Hunt  <oliver@apple.com>
40765
40766         Add rudimentary filtering to write barriers
40767         https://bugs.webkit.org/show_bug.cgi?id=69392
40768
40769         Reviewed by Filip Pizlo.
40770
40771         When we're recording gc phase times Heap.o picks up
40772         some exit time destructors, so we'll just ignore Heap.o
40773         in this check.
40774
40775         * Scripts/check-for-exit-time-destructors:
40776
40777 2011-10-05  Chang Shu  <cshu@webkit.org>
40778
40779         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
40780         https://bugs.webkit.org/show_bug.cgi?id=69365
40781
40782         Reviewed by Darin Adler.
40783
40784         Added js API in WTR LayoutTestController.
40785
40786         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
40787         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
40788         (WTR::LayoutTestController::dumpConfigurationForViewport):
40789         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
40790
40791 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
40792
40793         [EFL] ImageDiff: Do not clear the image before it is processed and compared
40794         https://bugs.webkit.org/show_bug.cgi?id=69378
40795
40796         Reviewed by Antonio Gomes.
40797
40798         Commit 61836 to Evas added a few cleanup calls to some
40799         evas_object_image functions which effectively made ImageDiff consider
40800         all images to be equal.
40801
40802         It turns out that now evas_object_image_colorspace_set clears any
40803         data set, so the call to evas_object_image_data_set was not having any
40804         effect.
40805
40806         * DumpRenderTree/efl/ImageDiff.cpp:
40807         (readImageFromStdin): Call evas_object_image_data_set after
40808         evas_object_image_colorspace_set.
40809
40810 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
40811
40812         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
40813         https://bugs.webkit.org/show_bug.cgi?id=68449
40814
40815         Reviewed by Antonio Gomes.
40816
40817         evas_render() must be called to close up temporary files and unmap unused
40818         resources. evas_object_image_data_set() must be called after an
40819         evas_object_image_data_get() to balance an internal reference count.
40820
40821         * DumpRenderTree/efl/ImageDiff.cpp:
40822         (differenceImageFromDifferenceBuffer):
40823         (calculateDifference):
40824         (printImage):
40825         (printImageDifferences):
40826
40827 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
40828
40829         [Qt][WK2] Unreviewed build fix.
40830
40831         Don't use WebCore directly in WTR.
40832
40833         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
40834         (WTR::PlatformWebView::addChromeInputField):
40835         (WTR::PlatformWebView::removeChromeInputField):
40836         (WTR::PlatformWebView::makeWebViewFirstResponder):
40837
40838 2011-10-05  David Levin  <levin@chromium.org>
40839
40840         watchlist: Add more rules for chromium public api and sort the file.
40841         https://bugs.webkit.org/show_bug.cgi?id=69323
40842
40843         Reviewed by Adam Barth.
40844
40845         * Scripts/webkitpy/common/config/watchlist:
40846
40847 2011-10-05  David Levin  <levin@chromium.org>
40848
40849         watchlist: Don't add the same message to a bug more than once.
40850         https://bugs.webkit.org/show_bug.cgi?id=69303
40851
40852         Reviewed by Adam Barth.
40853
40854         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
40855         if a message is in the comments already.
40856         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
40857         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
40858         Pick a bug supplied by the mock. Change the test due to different output
40859         from the mock watch list tool.
40860         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
40861         another email so it will be filtered out, fix bugs to have the cc and comment fields,
40862         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
40863         to debug).
40864         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
40865         and/or cc's that are already in the bug.
40866         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
40867         and remove a comment that is filtered out.
40868
40869 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
40870
40871         [Qt][WK2] Unreviewed build fix after r96643.
40872
40873         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
40874         (WTR::PlatformWebView::addChromeInputField):
40875         (WTR::PlatformWebView::removeChromeInputField):
40876         (WTR::PlatformWebView::makeWebViewFirstResponder):
40877
40878 2011-10-04  Kent Tamura  <tkent@chromium.org>
40879
40880         Introduce feature flags for incomplete input types
40881         https://bugs.webkit.org/show_bug.cgi?id=68971
40882
40883         Reviewed by Hajime Morita.
40884
40885         * Scripts/build-webkit:
40886         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
40887         They are disabled by default.
40888
40889 2011-10-04  Adam Barth  <abarth@webkit.org>
40890
40891         garden-o-matic doesn't launch it's UI on Lion
40892         https://bugs.webkit.org/show_bug.cgi?id=69349
40893
40894         Reviewed by Darin Adler.
40895
40896         It turns out that Lion is a bit more picky about file URLs.  This patch
40897         switches us from using a path to using an actual file URL, silencing
40898         the warning and making the tool actually launch on Lion.
40899
40900         * Scripts/webkitpy/tool/servers/gardeningserver.py:
40901
40902 2011-10-04  Daniel Bates  <dbates@rim.com>
40903
40904         Fix Perl undefined variable warning when using run-safari after
40905         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
40906
40907         Rubber-stamped by Alexey Proskuryakov.
40908
40909         * Scripts/webkitdirs.pm:
40910         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
40911         is defined before using it in a comparison operation.
40912
40913 2011-10-04  Scott Graham  <scottmg@chromium.org>
40914
40915         Add GAMEPAD feature flag
40916         https://bugs.webkit.org/show_bug.cgi?id=66859
40917
40918         Reviewed by Darin Fisher.
40919
40920         * Scripts/build-webkit:
40921
40922 2011-10-04  Jon Lee  <jonlee@apple.com>
40923
40924         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
40925         https://bugs.webkit.org/show_bug.cgi?id=68412
40926         <rdar://problem/9988252>
40927
40928         Reviewed by Darin Adler.
40929
40930         In order to create a test for the bug, I had to update DRT and WKTR to create some
40931         widget that allows first responder status to move away from the main web view.
40932
40933         Three methods were added to layoutTestController: addChromeInputField,
40934         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
40935         that is a sibling to the web view, and sets up the key event loop between the two.
40936         removeChromeInputField removes that field. focusWebView moves first responder
40937         status to the web view.
40938
40939         The test makes the call via layoutTestController and passes a callback that it
40940         assumes will be executed once the task is completed. In DRT the callback is called
40941         synchronously. In WKTR this is handled with message passing between the two
40942         processes.
40943
40944         * DumpRenderTree/LayoutTestController.cpp:
40945         (addChromeInputFieldCallback):
40946         (removeChromeInputFieldCallback):
40947         (focusWebViewCallback):
40948         (LayoutTestController::staticFunctions):
40949         * DumpRenderTree/LayoutTestController.h:
40950         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
40951         (LayoutTestController::addChromeInputField):
40952         (LayoutTestController::removeChromeInputField):
40953         (LayoutTestController::focusWebView):
40954         * DumpRenderTree/mac/DumpRenderTree.mm:
40955         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
40956         make sure to remove the chrome input field.
40957         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
40958         (LayoutTestController::addChromeInputField):
40959         (LayoutTestController::removeChromeInputField):
40960         (LayoutTestController::focusWebView):
40961         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
40962         (LayoutTestController::addChromeInputField):
40963         (LayoutTestController::removeChromeInputField):
40964         (LayoutTestController::focusWebView):
40965         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
40966         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
40967         (WTR::InjectedBundle::didReceiveMessage):
40968         (WTR::InjectedBundle::postAddChromeInputField):
40969         (WTR::InjectedBundle::postRemoveChromeInputField):
40970         (WTR::InjectedBundle::postFocusWebView):
40971         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
40972         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
40973         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
40974         through JS.
40975         (WTR::cacheLayoutTestControllerCallback):
40976         (WTR::callLayoutTestControllerCallback):
40977         (WTR::LayoutTestController::addChromeInputField):
40978         (WTR::LayoutTestController::removeChromeInputField):
40979         (WTR::LayoutTestController::focusWebView):
40980         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
40981         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
40982         (WTR::LayoutTestController::callFocusWebViewCallback):
40983         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
40984         * WebKitTestRunner/PlatformWebView.h:
40985         * WebKitTestRunner/TestController.cpp:
40986         (WTR::TestController::resetStateToConsistentValues):
40987         * WebKitTestRunner/TestInvocation.cpp:
40988         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
40989         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
40990         (WTR::PlatformWebView::addChromeInputField):
40991         (WTR::PlatformWebView::removeChromeInputField):
40992         (WTR::PlatformWebView::makeWebViewFirstResponder):
40993         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
40994         (WTR::PlatformWebView::addChromeInputField):
40995         (WTR::PlatformWebView::removeChromeInputField):
40996         (WTR::PlatformWebView::makeWebViewFirstResponder):
40997         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
40998         (WTR::PlatformWebView::addChromeInputField):
40999         (WTR::PlatformWebView::removeChromeInputField):
41000         (WTR::PlatformWebView::makeWebViewFirstResponder):
41001
41002         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
41003         with the patch-- just cleaning up style.
41004         (LayoutTestController::addDisallowedURL):
41005         (originsArrayToJS):
41006         (LayoutTestController::queueLoad):
41007         (LayoutTestController::setMockDeviceOrientation):
41008         (LayoutTestController::setIconDatabaseEnabled):
41009         (LayoutTestController::setEditingBehavior):
41010
41011 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
41012
41013         Move font-fixup code in WebKitTestRunner to a better place
41014         https://bugs.webkit.org/show_bug.cgi?id=69356
41015
41016         Reviewed by Sam Weinig.
41017
41018         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
41019         already contains font-related code.
41020
41021         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
41022         (WTR::InjectedBundle::initialize):
41023         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
41024         (WTR::allowedFontFamilySet):
41025         (WTR::drt_NSFontManager_availableFontFamilies):
41026         (WTR::drt_NSFontManager_availableFonts):
41027         (WTR::swizzleNSFontManagerMethods):
41028         (WTR::activateFonts):
41029         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
41030         (WTR::InjectedBundle::platformInitialize):
41031
41032 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
41033
41034         [EFL] DRT: Add DumpRenderTree.cpp
41035         https://bugs.webkit.org/show_bug.cgi?id=62034
41036
41037         Reviewed by Antonio Gomes.
41038
41039         This is the main implementation file for EFL's DumpRenderTree.
41040
41041         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
41042         (dumpFramesAsText):
41043         (dumpFrameScrollPosition):
41044         (shouldLogFrameLoadDelegates):
41045         (shouldDumpAsText):
41046         (sendPixelResultsEOF):
41047         (invalidateAnyPreviousWaitToDumpWatchdog):
41048         (onEcoreEvasResize):
41049         (onCloseWindow):
41050         (useLongRunningServerMode):
41051         (parseCommandLineOptions):
41052         (getFinalTestURL):
41053         (getExpectedPixelHash):
41054         (createLayoutTestController):
41055         (runTest):
41056         (runTestingServerLoop):
41057         (adjustOutputTypeByMimeType):
41058         (dumpFrameContentsAsText):
41059         (shouldDumpFrameScrollPosition):
41060         (shouldDumpPixelsAndCompareWithExpected):
41061         (shouldDumpBackForwardList):
41062         (initEfl):
41063         (shutdownEfl):
41064         (displayWebView):
41065         (dump):
41066         (initEcoreEvas):
41067         (main):
41068
41069 2011-10-03  Adam Barth  <abarth@webkit.org>
41070
41071         garden-o-matic should remove builders from the failure grid once they start to pass
41072         https://bugs.webkit.org/show_bug.cgi?id=69309
41073
41074         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
41075         in reviewing these patches.
41076
41077         This patch follows the update/purge model from UpdateTracker.  This
41078         patch is less awesome than it could be because it causes the UI to
41079         flash slightly.  In a future patch, we'll want to use these
41080         update/purge notifications to update the UI without flashing.  However,
41081         that's not such a big deal because this UI is hidden in the default
41082         view.
41083
41084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
41085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
41086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
41087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
41088
41089 2011-10-03  David Levin  <levin@chromium.org>
41090
41091         webkitpy: Expose cc_emails and comments from bug.py
41092         https://bugs.webkit.org/show_bug.cgi?id=69308
41093
41094         Reviewed by Adam Barth.
41095
41096         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
41097         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
41098         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
41099         to comments being exposed.
41100
41101 2011-10-03  James Robinson  <jamesr@chromium.org>
41102
41103         Add myself to the watchlist for platform/graphics/chromium
41104         https://bugs.webkit.org/show_bug.cgi?id=69297
41105
41106         Reviewed by David Levin.
41107
41108         * Scripts/webkitpy/common/config/watchlist:
41109
41110 2011-10-03  Anders Carlsson  <andersca@apple.com>
41111
41112         Remove custom scrollbar painting hooks
41113         https://bugs.webkit.org/show_bug.cgi?id=69163
41114
41115         Reviewed by Alexey Proskuryakov.
41116
41117         * DumpRenderTree/chromium/WebPreferences.cpp:
41118         (WebPreferences::applyTo):
41119         No need to enable custom scrollbar painting.
41120
41121 2011-10-03  David Levin  <levin@chromium.org>
41122
41123         watchlist: Make watchlist run on a bot.
41124         https://bugs.webkit.org/show_bug.cgi?id=68974
41125
41126         Reviewed by Adam Barth.
41127
41128         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
41129         * Scripts/webkitpy/tool/commands/queues_unittest.py:
41130         Change to log what is run so that we can see the style command
41131         and the watchlist command being run.
41132
41133 2011-10-03  David Levin  <levin@chromium.org>
41134
41135         watchlist: Allow specified a bug to attach the watchlist info to.
41136         https://bugs.webkit.org/show_bug.cgi?id=69288
41137
41138         Reviewed by Eric Seidel.
41139
41140         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
41141         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
41142         Add tests and fix an existing test because the unit tests do not go through the
41143         normal command line processing (so the -g argument remained when we determined bug ids).
41144         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
41145         get the assert raises regex method.
41146         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
41147
41148 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
41149
41150         [EFL] DRT: Add JSStringUtils.{cpp,h}
41151         https://bugs.webkit.org/show_bug.cgi?id=66397
41152
41153         Reviewed by Ryosuke Niwa.
41154
41155         Adds helper functions to compare the equality of C-style strings and
41156         JSStringRef objects.
41157
41158         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
41159         (equals):
41160         * DumpRenderTree/efl/JSStringUtils.h: Added.
41161
41162 2011-10-03  Adam Barth  <abarth@webkit.org>
41163
41164         garden-o-matic should work in Safari 5.1
41165         https://bugs.webkit.org/show_bug.cgi?id=69290
41166
41167         Reviewed by Sam Weinig.
41168
41169         My old implementation of bind was too clever by half.  This one seems
41170         to work better, at least according to this test.
41171
41172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
41173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
41174
41175 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
41176
41177         Unreviewed: change my e-mail in commiters.py
41178
41179         (I'm leaving the company and my @openbossa.org will be no more)
41180
41181         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
41182
41183 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
41184
41185         Correct post-build step for WinCairo test runs.
41186         https://bugs.webkit.org/show_bug.cgi?id=69191
41187
41188         Reviewed by Brian Weinstein.
41189
41190         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
41191         shell case to handle the CFLite build.
41192
41193 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
41194
41195         Added myself to reviewers, because I'm now a reviewer.
41196
41197         * Scripts/webkitpy/common/config/committers.py:
41198
41199 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
41200
41201         Bencher script makes it difficult to do automated performance testing
41202         https://bugs.webkit.org/show_bug.cgi?id=69207
41203
41204         Reviewed by Sam Weinig.
41205
41206         This adds two new features:
41207
41208         The ability to disable automatic VM detection, which is flaky if any
41209         profiling features are enabled in jsc.
41210
41211         The ability to compute, and report, a scaled result for all benchmark
41212         suites. It is the geometric mean of three numbers: SunSpider's
41213         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
41214         It is also possible to turn off all other output from bencher and just
41215         get this number with the --brief option.
41216
41217         * Scripts/bencher:
41218
41219 2011-10-01  Sam Weinig  <sam@webkit.org>
41220
41221         WTR is not successfully changing the NSUserDefaults
41222         https://bugs.webkit.org/show_bug.cgi?id=69204
41223
41224         Reviewed by Dan Bernstein.
41225
41226         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
41227         (WTR::InjectedBundle::platformInitialize):
41228         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
41229         get our overrides picked up.
41230
41231 2011-09-30  Daniel Bates  <dbates@rim.com>
41232
41233         Cleanup: Extract code to launch a Mac WebKit application into a common function
41234         https://bugs.webkit.org/show_bug.cgi?id=68662
41235
41236         Reviewed by Adam Roben.
41237
41238         Extracts common code to launch a WebKit application on Mac OS X into a function
41239         so that we can remove duplicate code.
41240
41241         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
41242         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
41243         (runMacWebKitApp): Added.
41244         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
41245         (runMiniBrowser): Ditto.
41246         (runWebKitTestRunner): Ditto.
41247         (runTestWebKitAPI): Ditto.
41248
41249 2011-09-29  David Levin  <levin@chromium.org>
41250
41251         watchlist: Add webkit-patch command to run watchlist.
41252         https://bugs.webkit.org/show_bug.cgi?id=68973
41253
41254         Reviewed by Eric Seidel.
41255
41256         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
41257         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
41258         the cc and messages as sorted lists. To allow for deterministic ordering.
41259         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
41260         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
41261         that it will be exposed as a command by webkit-patch.
41262         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
41263         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
41264         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
41265         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
41266         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
41267         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
41268         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
41269         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
41270
41271 2011-09-30  David Levin  <levin@chromium.org>
41272
41273         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
41274         https://bugs.webkit.org/show_bug.cgi?id=69031
41275
41276         Reviewed by Adam Barth.
41277
41278         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
41279         a comment to explain something important about the email addresses, and
41280         a comment to let emacs know to treat the file as a python file.
41281         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
41282         Detects increases or decreases in a pattern.
41283         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
41284         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
41285         Added unit tests for watchlist which has "more" or "less".
41286         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
41287         Added support for "more" or "less".
41288
41289 2011-09-30  Sam Weinig  <sam@webkit.org>
41290
41291         Add support for eventSender.mouseScrollBy in WTR
41292         https://bugs.webkit.org/show_bug.cgi?id=69189
41293
41294         Add implementation of eventSender.mouseScrollBy for the mac.
41295
41296         Reviewed by Simon Fraser.
41297
41298         * WebKitTestRunner/EventSenderProxy.h:
41299         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
41300         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
41301         (WTR::EventSendingController::keyDown):
41302         (WTR::EventSendingController::mouseScrollBy):
41303         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
41304         * WebKitTestRunner/TestController.cpp:
41305         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
41306         * WebKitTestRunner/mac/EventSenderProxy.mm:
41307         (WTR::EventSenderProxy::mouseScrollBy):
41308
41309 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
41310
41311         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
41312         https://bugs.webkit.org/show_bug.cgi?id=35273
41313
41314         Reviewed by Dan Bernstein.
41315
41316         There are two types of font issue that can cause layout test failure.
41317         First, the user may have non-standard fonts installed that affect the layout
41318         of some tests. For example, some tests use the MS Gothic font if installed.
41319
41320         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
41321         which override the system fonts (e.g. a copy of Arial from MS Office). For
41322         some tests, this can affect font metrics or fallback behavior.
41323
41324         This change addresses the first problem only. It limits the set of fonts
41325         available through NSFontManager, by swizzling some methods to return
41326         a list of fonts or font families which only include fonts from a hardcoded
41327         whitelist.
41328
41329         * DumpRenderTree/mac/DumpRenderTree.mm:
41330         (allowedFontFamilySet):
41331         (drt_NSFontManager_availableFontFamilies):
41332         (drt_NSFontManager_availableFonts):
41333         (swizzleNSFontManagerMethods):
41334         (activateTestingFonts):
41335         (adjustFonts):
41336         (createWebViewAndOffscreenWindow):
41337         (prepareConsistentTestingEnvironment):
41338         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
41339         (WTR::allowedFontFamilySet):
41340         (WTR::drt_NSFontManager_availableFontFamilies):
41341         (WTR::drt_NSFontManager_availableFonts):
41342         (WTR::swizzleNSFontManagerMethods):
41343         (WTR::InjectedBundle::platformInitialize):
41344
41345 2011-09-30  David Levin  <levin@chromium.org>
41346
41347         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
41348         https://bugs.webkit.org/show_bug.cgi?id=69039
41349
41350         Reviewed by Adam Barth.
41351
41352         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
41353         Actually skip only one specific test that is failing on Windows.
41354
41355 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
41356
41357         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
41358
41359         For DRT we didn't install the message handler early enough to
41360         catch output while constructing the QApplication. For WTR we
41361         didn't even install a message handler.
41362
41363         Since the UI process will forward any output from the web process
41364         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
41365         in WTR before the web process is started. This is picked up by the
41366         web process which installs its own message handler.
41367
41368         The environment variable can be overriden on the command line if you
41369         want to see output from the web process, or you can pass --verbose to
41370         WTR to see output from both processes.
41371
41372         https://bugs.webkit.org/show_bug.cgi?id=69132
41373
41374         Reviewed by Andreas Kling.
41375
41376         * DumpRenderTree/qt/main.cpp:
41377         * WebKitTestRunner/qt/main.cpp:
41378
41379 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
41380
41381         [Qt] Make sure WTR sizes the window and item correctly
41382
41383         Revision 96345 changed the logic for how the view and
41384         window was created, but missed a vital part, setting
41385         the size.
41386
41387         We now use a QSGView for the window, that has a simple
41388         item as its root object that is always resized to fit
41389         within the window. The webview is then parented to the
41390         root object and set to anchors.fill: parent. That way
41391         any window geometry changes will propagate to the web
41392         view.
41393
41394         https://bugs.webkit.org/show_bug.cgi?id=69134
41395
41396         Reviewed by Andreas Kling.
41397
41398         * WebKitTestRunner/PlatformWebView.h:
41399         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
41400
41401 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
41402
41403         [EFL] Only save the current viewport in PixelDumpSupportEfl.
41404         https://bugs.webkit.org/show_bug.cgi?id=68450
41405
41406         Reviewed by Antonio Gomes.
41407
41408         The previous implementation saved the whole page contents in the final
41409         PNG, however the baselines and expectations in the tree only want the
41410         current viewport (with a scrollbar, if needed), so we now only save the
41411         currently visible contents.
41412
41413         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
41414         (createBitmapContextFromWebView): Use
41415         ewk_frame_visible_content_geometry_get instead of
41416         ewk_frame_contents_size_get.
41417
41418 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
41419
41420         [EFL] Support and keep track of extra windows (views).
41421         https://bugs.webkit.org/show_bug.cgi?id=68454
41422
41423         Reviewed by Antonio Gomes.
41424
41425         So far, window.open and related JavaScript code would not work, as
41426         DRTView did not implementation
41427         Ewk_View_Smart_Class::window_{open,close}. The default implementation
41428         in ewk just returns the current window/view, which broke any
41429         layouttest which relied on window.open.
41430
41431         We now properly create and remove these new views. Unfortunately, the
41432         current way ewk works (and due to the fact that we cannot pass class
41433         methods as function pointers to the EFL functions), DRTView needs to
41434         know that DRTChrome exists and call `browser' directly in some points.
41435
41436         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
41437         (onWindowCreate):
41438         (onWindowCloseDelayed):
41439         (onWindowClose):
41440         (drtViewTiledAdd):
41441
41442 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
41443
41444         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
41445         https://bugs.webkit.org/show_bug.cgi?id=42698
41446
41447         Reviewed by Andreas Kling.
41448
41449         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
41450         and call clearApplicationCache when layoutTest start up.
41451
41452         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
41453         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
41454         (WTR::InjectedBundle::beginTesting):
41455         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
41456         (WTR::LayoutTestController::clearAllApplicationCaches):
41457         (WTR::LayoutTestController::setAppCacheMaximumSize):
41458         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
41459
41460 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
41461
41462         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
41463         https://bugs.webkit.org/show_bug.cgi?id=69145
41464
41465         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
41466         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
41467         and is perfectly suitable for SceneGraph as well. GraphicsScene events
41468         will not be available in QtGui anymore in future. Therefore we also have to change
41469         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
41470
41471         Reviewed by Chang Shu.
41472
41473         * WebKitTestRunner/EventSenderProxy.h:
41474         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
41475         (WTR::EventSenderProxy::createMouseEvent):
41476         (WTR::EventSenderProxy::mouseDown):
41477         (WTR::EventSenderProxy::mouseUp):
41478         (WTR::EventSenderProxy::mouseMoveTo):
41479
41480 2011-09-30  James Robinson  <jamesr@chromium.org>
41481
41482         [chromium] Add WebKit API for sending input events to the compositor thread
41483         https://bugs.webkit.org/show_bug.cgi?id=69117
41484
41485         Reviewed by Darin Fisher.
41486
41487         Adds support for creating and setting a compositor thread in DRT.
41488
41489         * DumpRenderTree/chromium/WebViewHost.cpp:
41490         (WebViewHost::WebViewHost):
41491         * DumpRenderTree/chromium/WebViewHost.h:
41492
41493 2011-09-29  David Levin  <levin@chromium.org>
41494
41495         watchlist: Add cross-checks for WatchList once it is filled.
41496         https://bugs.webkit.org/show_bug.cgi?id=68975
41497
41498         Reviewed by Eric Seidel.
41499
41500         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
41501         instead of having trivial getter and setters.
41502         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
41503         pass the validation checks.
41504         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
41505         and fix a few style nits.
41506         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
41507         validation checks.
41508         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
41509
41510 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
41511
41512         run-api-tests fails on chromium-win bot
41513         https://bugs.webkit.org/show_bug.cgi?id=69121
41514
41515         On Windows running a perl script needs the interpreter.
41516
41517         Reviewed by Adam Barth.
41518
41519         * Scripts/run-api-tests:
41520         (buildTestTool):
41521
41522 2011-09-29  Adam Barth  <abarth@webkit.org>
41523
41524         Attempt to make this tool work on Windows.
41525
41526         * Scripts/run-api-tests:
41527         (buildTestTool):
41528
41529 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
41530
41531         [Qt] Try to fix the minial build
41532
41533         * QtTestBrowser/launcherwindow.cpp:
41534         * QtTestBrowser/webpage.cpp:
41535
41536 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
41537
41538         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
41539
41540         QWidget and friends now live in the QtWidgets library. We update
41541         includes in implementation files and private headers to us the
41542         non-module-prefixed path, and leave the lookup for the include
41543         path. For public headers we have to ifdef the includes as the
41544         user might now have the modules we need in his QT config.
41545
41546         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
41547         have to update our code and use windowHandle() for setting the
41548         parent relationships.
41549
41550         https://bugs.webkit.org/show_bug.cgi?id=68687
41551
41552         Reviewed by Andreas Kling.
41553
41554         * DumpRenderTree/qt/DumpRenderTree.pro:
41555         * DumpRenderTree/qt/ImageDiff.pro:
41556         * MiniBrowser/qt/BrowserView.cpp:
41557         * MiniBrowser/qt/BrowserView.h:
41558         * MiniBrowser/qt/BrowserWindow.cpp:
41559         * MiniBrowser/qt/BrowserWindow.h:
41560         * MiniBrowser/qt/MiniBrowser.pro:
41561         * MiniBrowser/qt/MiniBrowserApplication.h:
41562         * MiniBrowser/qt/main.cpp:
41563         * QtTestBrowser/QtTestBrowser.pro:
41564         * QtTestBrowser/launcherwindow.cpp:
41565         * QtTestBrowser/launcherwindow.h:
41566         * QtTestBrowser/locationedit.h:
41567         * QtTestBrowser/main.cpp:
41568         * QtTestBrowser/mainwindow.cpp:
41569         * QtTestBrowser/mainwindow.h:
41570         * QtTestBrowser/webinspector.h:
41571         * QtTestBrowser/webpage.cpp:
41572         * QtTestBrowser/webview.cpp:
41573         * WebKitTestRunner/PlatformWebView.h:
41574         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
41575
41576 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
41577
41578         Initial implementation of WebInspector for WebKit2 GTK port.
41579         https://bugs.webkit.org/show_bug.cgi?id=68235
41580
41581         Reviewed by Martin Robinson.
41582
41583         * MiniBrowser/gtk/BrowserWindow.c:
41584         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
41585
41586 2011-09-29  Adam Barth  <abarth@webkit.org>
41587
41588         Unbreak the "update expectatations" button by using the existing
41589         machinery to create the failureInfo objects.
41590
41591         Unbreak the "close" button on the progress dialog by using |this|
41592         instead of the old name of the object.
41593
41594         Teach the controllers unit test not to talk to the actual network.
41595
41596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
41597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
41598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
41599
41600 2011-09-29  Hans Wennborg  <hans@chromium.org>
41601
41602         IndexedDB: Use LevelDB also for in-memory databases
41603         https://bugs.webkit.org/show_bug.cgi?id=68903
41604
41605         Reviewed by Steve Block.
41606
41607         Remove the temporary dir that was necessary before LevelDB supported
41608         in-memory databases.
41609
41610         * DumpRenderTree/chromium/TestShell.cpp:
41611         (TestShell::TestShell):
41612         * DumpRenderTree/chromium/TestShell.h:
41613
41614 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
41615
41616         Run TestWebKitAPI on Chromium buildbots
41617         https://bugs.webkit.org/show_bug.cgi?id=68678
41618
41619         Reviewed by Tony Chang.
41620
41621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
41622
41623 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
41624
41625         garden-o-matic results should anticipate 0 unexpected failures.
41626         https://bugs.webkit.org/show_bug.cgi?id=69036
41627
41628         Also fixes controllers: UnexpectedFailures test.
41629
41630         Reviewed by Adam Barth.
41631
41632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
41633
41634 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
41635
41636         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
41637
41638         https://bugs.webkit.org/show_bug.cgi?id=67253
41639
41640         Reviewed by Eric Seidel.
41641
41642         Nearly all of the work in this was done by Simon Fraser; I'm
41643         just repackaging it and cleaning it up a bit. This change
41644         modifies port.diff_image() to return a tuple of (pass/fail,
41645         %age), adds the value to the FailureImageHashMismatch, and
41646         writes the value into the full_results.json files to be
41647         displayed in the results page.
41648
41649         * Scripts/webkitpy/layout_tests/controllers/manager.py:
41650         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
41651         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
41652         * Scripts/webkitpy/layout_tests/models/test_failures.py:
41653         * Scripts/webkitpy/layout_tests/port/base.py:
41654         * Scripts/webkitpy/layout_tests/port/chromium.py:
41655         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
41656         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
41657         * Scripts/webkitpy/layout_tests/port/test.py:
41658         * Scripts/webkitpy/layout_tests/port/webkit.py:
41659         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
41660
41661 2011-09-25  Kentaro Hara  <haraken@chromium.org>
41662
41663         Unreviewed. Adding myself to committers.py.
41664
41665         * Scripts/webkitpy/common/config/committers.py:
41666
41667 2011-09-28  Adam Barth  <abarth@webkit.org>
41668
41669         garden-o-matic shouldn't depend on test-results.appspot.com
41670         https://bugs.webkit.org/show_bug.cgi?id=69019
41671
41672         Reviewed by Dimitri Glazkov.
41673
41674         This patch moves garden-o-matic from getting full_results.json from
41675         test-results.appspot.com to getting that information directly from the
41676         buildbot.  This patch improve the load time and accuracy of
41677         garden-o-matic because test-results.appspot.com is slow and is dropping
41678         a significant number of writes (see
41679         https://bugs.webkit.org/show_bug.cgi?id=68748).
41680
41681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
41682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
41683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
41684
41685 2011-09-28  David Levin  <levin@chromium.org>
41686
41687         watchlist: Add a way to load the watchlist from config.
41688         https://bugs.webkit.org/show_bug.cgi?id=68991
41689
41690         Reviewed by Eric Seidel.
41691
41692         * Scripts/webkitpy/common/config/watchlist: Added.
41693         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
41694         Support for loading the watch list.
41695         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
41696         Tests for the loading.
41697         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
41698         Adjusted to use the common base class.
41699         * Scripts/webkitpy/common/webkitunittest.py: Added.
41700         Made a common base class for functionality used in more than one.
41701
41702 2011-09-28  David Levin  <levin@chromium.org>
41703
41704         Attempt fix for Leopard python unit test run.
41705
41706         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
41707
41708 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
41709
41710         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
41711         https://bugs.webkit.org/show_bug.cgi?id=68938
41712
41713         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
41714
41715         Reviewed by David Hyatt.
41716
41717         * DumpRenderTree/chromium/WebViewHost.cpp:
41718         (WebViewHost::didUpdateLayout): Added width/height queries.
41719         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
41720
41721 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
41722
41723         Get rebaseline server running again
41724         https://bugs.webkit.org/show_bug.cgi?id=69020
41725
41726         Reviewed by Adam Barth.
41727
41728         Make rebaseline server run again after r90337 (missing format_date_time
41729         import, results_json wasn't outputting anything).
41730
41731         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
41732         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
41733
41734 2011-09-28  David Grogan  <dgrogan@chromium.org>
41735
41736         Move dgrogan from contributor to committer
41737         https://bugs.webkit.org/show_bug.cgi?id=69021
41738
41739         * Scripts/webkitpy/common/config/committers.py:
41740
41741 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
41742
41743         Add Mac Skia GPU bots to builders.py
41744         https://bugs.webkit.org/show_bug.cgi?id=69016
41745
41746         Reviewed by Eric Seidel.
41747
41748         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
41749         GPU tests.
41750
41751         * Scripts/webkitpy/layout_tests/port/builders.py:
41752         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
41753
41754 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
41755
41756         Second try at fixing the GTK+ build.
41757
41758         * GNUmakefile.am:
41759
41760 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
41761
41762         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
41763         https://bugs.webkit.org/show_bug.cgi?id=68680
41764
41765         Reviewed by Tony Chang.
41766
41767         * Scripts/run-chromium-webkit-unit-tests:
41768         * Scripts/webkitdirs.pm:
41769         (determineBaseProductDir):
41770
41771 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
41772
41773         [Gtk] Implement textInputController.doCommand
41774         https://bugs.webkit.org/show_bug.cgi?id=66496
41775
41776         Reviewed by Martin Robinson.
41777
41778         * DumpRenderTree/gtk/TextInputController.cpp:
41779         (doCommandCallback): Callback function for textInputController.doCommand
41780
41781 2011-09-28  David Levin  <levin@chromium.org>
41782
41783         watchlist: Suggest corrections for typos and improve error message consistency.
41784         https://bugs.webkit.org/show_bug.cgi?id=68976
41785
41786         Reviewed by Adam Barth.
41787
41788         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
41789         for typos and improve consistency of the error messages.
41790         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
41791         and improve the regex that were already present.
41792
41793 2011-09-28  David Levin  <levin@chromium.org>
41794
41795         watchlist: Add support for matching added or deleted lines.
41796         https://bugs.webkit.org/show_bug.cgi?id=68972
41797
41798         Reviewed by Adam Barth.
41799
41800         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
41801         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
41802         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
41803         to the pattern match to only have the diff lines instead of the DiffFile.
41804         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
41805         Add tests for the new patterns and combinations of the patterns.
41806         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
41807         Sort imports. Add changeline support.
41808
41809 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
41810
41811         [GTK] Add WebKitError to GTK+ WebKit2 API
41812         https://bugs.webkit.org/show_bug.cgi?id=68508
41813
41814         Reviewed by Martin Robinson.
41815
41816         * GNUmakefile.am: Add path to webkitgtk derived sources to the
41817         include path.
41818
41819 2011-09-28  Philippe Normand  <pnormand@igalia.com>
41820
41821         [GTK] missing WebKit2 support in run-gtk-tests
41822         https://bugs.webkit.org/show_bug.cgi?id=68992
41823
41824         Rubber-stamped by Andreas Kling.
41825
41826         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
41827         webkit2 directory.
41828
41829 2011-09-27  Philippe Normand  <pnormand@igalia.com>
41830
41831         [GTK] build-webkit --no-webkit2 still builds WebKit2
41832         https://bugs.webkit.org/show_bug.cgi?id=68892
41833
41834         Reviewed by Martin Robinson.
41835
41836         Take the --no-webkit2 option in account when building WebKitGTK+.
41837
41838         * Scripts/build-webkit:
41839         * Scripts/webkitdirs.pm:
41840         (buildAutotoolsProject):
41841         (buildGtkProject):
41842
41843 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
41844
41845         Make Chromium Win Release (Tests) a core builder
41846         https://bugs.webkit.org/show_bug.cgi?id=68906
41847
41848         Reviewed by Adam Barth.
41849
41850         Add Chromium Win Release (Tests) to the list of core builders.
41851
41852         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
41853         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
41854
41855 2011-09-27  Adam Barth  <abarth@webkit.org>
41856
41857         garden-o-matic should load faster and inform the user what is happening
41858         https://bugs.webkit.org/show_bug.cgi?id=68954
41859
41860         Reviewed by Dimitri Glazkov.
41861
41862         This test disables the expected failures tab.  The web inspector showed
41863         that loading the data for this tab was slowing down the loading time
41864         for the whole app.  We need to find a way to load that data lazily.
41865
41866         This patch also improves the update message to better describe the
41867         progress the app is making analyzing data from the buildbot.
41868
41869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
41870         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
41871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
41872
41873 2011-09-27  Adam Barth  <abarth@webkit.org>
41874
41875         garden-o-matic should show the first result when examining results
41876         https://bugs.webkit.org/show_bug.cgi?id=68960
41877
41878         Reviewed by Dimitri Glazkov.
41879
41880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
41881
41882 2011-09-27  David Levin  <levin@chromium.org>
41883
41884         watchlist: Add support for cc and message rules.
41885         https://bugs.webkit.org/show_bug.cgi?id=68950
41886
41887         Reviewed by Adam Barth.
41888
41889         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
41890         the cc's and messages for a patch.
41891         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
41892         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
41893         for the rules.
41894         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
41895         A generic encapsulation of either a message list or a cc list.
41896         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
41897
41898 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
41899
41900         webkit-patch doesn't like UTF-8 characters in reviewers names
41901         https://bugs.webkit.org/show_bug.cgi?id=63452
41902
41903         Reviewed by Eric Seidel.
41904
41905         * Scripts/webkit-patch:
41906
41907 2011-09-27  Adam Barth  <abarth@webkit.org>
41908
41909         garden-o-matic examine buttons shows both expected and unexpected failures
41910         https://bugs.webkit.org/show_bug.cgi?id=68918
41911
41912         Reviewed by Dimitri Glazkov.
41913
41914         This was a copy/paste error when I refactored this classes to share
41915         more code.
41916
41917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
41918
41919 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
41920
41921         Add Kaustubh Atrawalkar to the list of contributors.
41922
41923         * Scripts/webkitpy/common/config/committers.py:
41924
41925 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
41926
41927         [Chromium] Fixed layout mode tests break subsequent tests
41928         https://bugs.webkit.org/show_bug.cgi?id=68923
41929
41930         Reviewed by Adam Barth.
41931
41932         Reset fixed layout mode between tests, so that tests that run after
41933         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
41934         regular 800x600 non-fixed layout.
41935
41936         * DumpRenderTree/chromium/TestShell.cpp:
41937         (TestShell::resetTestController):
41938
41939 2011-09-27  David Levin  <levin@chromium.org>
41940
41941         watchlist: Add the filename pattern for definitions.
41942         https://bugs.webkit.org/show_bug.cgi?id=68917
41943
41944         Reviewed by Adam Barth.
41945
41946         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
41947         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
41948         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
41949         for definitions.
41950         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
41951         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
41952
41953 2011-09-27  Adam Barth  <abarth@webkit.org>
41954
41955         garden-o-matic results view should sort test and builder names
41956         https://bugs.webkit.org/show_bug.cgi?id=68488
41957
41958         Reviewed by Andy Estes.
41959
41960         Previously, the test and builder names were displayed in an arbitrary
41961         order that changed from time to time.  That confused one user study
41962         participant.  This patch sorts the lists so that they occur in a
41963         predictable order.
41964
41965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
41966
41967 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
41968
41969         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
41970         http://trac.webkit.org/changeset/96108
41971         http://trac.webkit.org/changeset/96111
41972         http://trac.webkit.org/changeset/96113
41973         http://trac.webkit.org/changeset/96116
41974         https://bugs.webkit.org/show_bug.cgi?id=68913
41975
41976         Wait for working Qt5 (Requested by ossy on #webkit).
41977
41978         * DumpRenderTree/qt/DumpRenderTree.pro:
41979         * DumpRenderTree/qt/ImageDiff.pro:
41980         * MiniBrowser/qt/BrowserView.cpp:
41981         (BrowserView::BrowserView):
41982         * MiniBrowser/qt/BrowserView.h:
41983         * MiniBrowser/qt/BrowserWindow.cpp:
41984         (BrowserWindow::BrowserWindow):
41985         (BrowserWindow::urlChanged):
41986         (BrowserWindow::~BrowserWindow):
41987         * MiniBrowser/qt/BrowserWindow.h:
41988         * MiniBrowser/qt/MiniBrowser.pro:
41989         * MiniBrowser/qt/MiniBrowserApplication.h:
41990         * MiniBrowser/qt/main.cpp:
41991         * QtTestBrowser/QtTestBrowser.pro:
41992         * QtTestBrowser/launcherwindow.cpp:
41993         * QtTestBrowser/launcherwindow.h:
41994         * QtTestBrowser/locationedit.h:
41995         * QtTestBrowser/main.cpp:
41996         * QtTestBrowser/mainwindow.cpp:
41997         * QtTestBrowser/mainwindow.h:
41998         * QtTestBrowser/webinspector.h:
41999         * QtTestBrowser/webpage.cpp:
42000         * QtTestBrowser/webview.cpp:
42001         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
42002         * WebKitTestRunner/PlatformWebView.h:
42003         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
42004         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
42005         (WTR::WebView::wkView):
42006         (WTR::WebView::pageRef):
42007         (WTR::WebView::~WebView):
42008         (WTR::WebView::WebView):
42009         (WTR::PlatformWebView::PlatformWebView):
42010         (WTR::PlatformWebView::sendEvent):
42011         (WTR::PlatformWebView::postEvent):
42012         * WebKitTestRunner/qt/WebKitTestRunner.pro:
42013
42014 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
42015
42016         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
42017         https://bugs.webkit.org/show_bug.cgi?id=65178
42018
42019         Reviewed by Martin Robinson.
42020
42021         * GNUmakefile.am:
42022         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
42023
42024 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
42025
42026         [Qt][WK2] Buildfix after r96108.
42027
42028         Rubber-stamped by Andreas Kling.
42029
42030         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
42031         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
42032         * WebKitTestRunner/qt/WebKitTestRunner.pro:
42033
42034 2011-09-27  David Levin  <levin@chromium.org>
42035
42036         watchlist: Change watchlistparser.py to be class based.
42037         https://bugs.webkit.org/show_bug.cgi?id=68869
42038
42039         Reviewed by Eric Seidel.
42040
42041         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
42042         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
42043
42044 2011-09-27  David Levin  <levin@chromium.org>
42045
42046         watchlist: Break out the diff boilerplate to allow for re-use.
42047         https://bugs.webkit.org/show_bug.cgi?id=68871
42048
42049         Reviewed by Eric Seidel.
42050
42051         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
42052         Break out the diff into a new file.
42053         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
42054
42055 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
42056
42057         Web Inspector: UI performance: introduce heap size tracking stats.
42058         https://bugs.webkit.org/show_bug.cgi?id=68901
42059
42060         It is interesting how much the heap memory is used by Inspector in order of running the test.
42061
42062         Reviewed by Yury Semikhatsky.
42063
42064         * DumpRenderTree/chromium/TestShell.cpp:
42065         (TestShell::showDevTools):
42066         (TestShell::closeDevTools):
42067
42068 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
42069
42070         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
42071
42072         QWidget and friends now live in the QtWidgets library. We update
42073         includes in implementation files and private headers to us the
42074         non-module-prefixed path, and leave the lookup for the include
42075         path. For public headers we have to ifdef the includes as the
42076         user might now have the modules we need in his QT config.
42077
42078         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
42079         have to update our code and use windowHandle() for setting the
42080         parent relationships.
42081
42082         https://bugs.webkit.org/show_bug.cgi?id=68687
42083
42084         Reviewed by Andreas Kling.
42085
42086         * DumpRenderTree/qt/DumpRenderTree.pro:
42087         * DumpRenderTree/qt/ImageDiff.pro:
42088         * MiniBrowser/qt/BrowserView.cpp:
42089         * MiniBrowser/qt/BrowserView.h:
42090         * MiniBrowser/qt/BrowserWindow.cpp:
42091         * MiniBrowser/qt/BrowserWindow.h:
42092         * MiniBrowser/qt/MiniBrowser.pro:
42093         * MiniBrowser/qt/MiniBrowserApplication.h:
42094         * MiniBrowser/qt/main.cpp:
42095         * QtTestBrowser/QtTestBrowser.pro:
42096         * QtTestBrowser/launcherwindow.cpp:
42097         * QtTestBrowser/launcherwindow.h:
42098         * QtTestBrowser/locationedit.h:
42099         * QtTestBrowser/main.cpp:
42100         * QtTestBrowser/mainwindow.cpp:
42101         * QtTestBrowser/mainwindow.h:
42102         * QtTestBrowser/webinspector.h:
42103         * QtTestBrowser/webpage.cpp:
42104         * QtTestBrowser/webview.cpp:
42105         * WebKitTestRunner/PlatformWebView.h:
42106         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
42107
42108 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
42109
42110         [Qt][WK2] Add support for hover API in Qt WebKit2
42111         https://bugs.webkit.org/show_bug.cgi?id=68369
42112
42113         Reviewed by Andreas Kling.
42114
42115         Change the statusbar to show the link URL when hovering links in
42116         MiniBrowser using QDesktopWebView.
42117
42118         * MiniBrowser/qt/BrowserWindow.cpp:
42119         (BrowserWindow::BrowserWindow):
42120         (BrowserWindow::onLinkHovered):
42121         * MiniBrowser/qt/BrowserWindow.h:
42122
42123 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
42124
42125         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
42126         https://bugs.webkit.org/show_bug.cgi?id=68864
42127
42128         Reviewed by Adam Barth.
42129
42130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
42131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
42132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
42133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
42134
42135 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
42136
42137         [Qt][WK2] One more unreviewed buildfix after r96005.
42138
42139         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
42140
42141 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
42142
42143         [Qt][WK2] Unreviewed buildfix after r96005.
42144
42145         * WebKitTestRunner/qt/TestInvocationQt.cpp:
42146         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
42147
42148 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
42149
42150         garden-o-matic should be pretty in Open Sans.
42151         https://bugs.webkit.org/show_bug.cgi?id=68845
42152
42153         Reviewed by Adam Barth.
42154
42155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
42156
42157 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
42158
42159         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
42160         https://bugs.webkit.org/show_bug.cgi?id=68841
42161
42162         Reviewed by Adam Barth.
42163
42164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
42165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
42166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
42167
42168 2011-09-26  David Levin  <levin@chromium.org>
42169
42170         watchlist: Add parsing for definition section.
42171         https://bugs.webkit.org/show_bug.cgi?id=68850
42172
42173         Reviewed by Adam Barth.
42174
42175         * Scripts/webkitpy/common/watchlist/watchlist.py:
42176         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
42177         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
42178
42179 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
42180
42181         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
42182
42183         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
42184         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
42185         * WebKitTestRunner/win/TestInvocationWin.cpp:
42186         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
42187
42188 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
42189
42190         Repaint tests don't work in WebKit2
42191         https://bugs.webkit.org/show_bug.cgi?id=68453
42192
42193         Reviewed by Sam Weinig.
42194
42195         Convert DumpRenderTree to use use the repaint rects
42196         exposed via WebKit API when generating the repaint test
42197         overlay.
42198
42199         Fix WebKitTestRunner to work with repaint tests, again
42200         using the repaint rects exposed from WK2.
42201
42202         In both cases, layoutTestController.display() now just
42203         forces a display of the web view, and turns on repaint
42204         rect tracking on the main FrameView.
42205
42206         Later, when pixel results are requested, the alpha overlay
42207         that shows the repaint rects is generated using the list
42208         of rects supplied by WebCore.
42209
42210         * DumpRenderTree/mac/DumpRenderTree.mm:
42211         (resetDefaultsToConsistentValues):
42212         (resetWebViewToConsistentStateBeforeTesting):
42213         (displayWebView):
42214         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
42215         (paintRepaintRectOverlay):
42216         (createBitmapContextFromWebView):
42217         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
42218         (WTR::InjectedBundle::beginTesting):
42219         (WTR::InjectedBundle::done):
42220         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
42221         (WTR::InjectedBundle::setRepaintRects):
42222         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
42223         (WTR::InjectedBundlePage::reset):
42224         (WTR::InjectedBundlePage::dump):
42225         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
42226         (WTR::LayoutTestController::display):
42227         * WebKitTestRunner/TestInvocation.cpp:
42228         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
42229         * WebKitTestRunner/TestInvocation.h:
42230         * WebKitTestRunner/cg/TestInvocationCG.cpp:
42231         (WTR::paintRepaintRectOverlay):
42232         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
42233
42234 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
42235
42236         Get hover'ed element URL from HitTest.
42237
42238         mouseDidMoveOverElement now gets the hover'ed element link using
42239         WKHitTestResult API's.
42240         https://bugs.webkit.org/show_bug.cgi?id=68426
42241
42242         Reviewed by Anders Carlsson.
42243
42244         * MiniBrowser/gtk/BrowserWindow.c:
42245         (mouseDidMoveOverElement):
42246
42247 2011-09-26  David Levin  <levin@chromium.org>
42248
42249         Add skeleton parsing for a WatchList.
42250         https://bugs.webkit.org/show_bug.cgi?id=68823
42251
42252         Reviewed by Adam Barth.
42253
42254         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
42255         Parses the top level watch list sections -- none are defined yet -- and
42256         throws an exception if an invalid one is listed.
42257         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
42258         Verify the exception for an invalid section in a watch list.
42259         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
42260
42261 2011-09-26  Adam Roben  <aroben@apple.com>
42262
42263         Clean up code imported from WebKitAPITest
42264
42265         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
42266         TestWebKitAPI conventions
42267
42268         Reviewed by David Levin.
42269
42270         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
42271         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
42272         namespace name.
42273
42274         (TestWebKitAPI::WebViewDestruction::SetUp):
42275         (TestWebKitAPI::WebViewDestruction::webViewCount):
42276         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
42277         (TestWebKitAPI::WebViewDestruction::runMessagePump):
42278         (TestWebKitAPI::WebViewDestruction::TearDown):
42279         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
42280         Moved functionality from free functions into these new test fixtures.
42281
42282         * TestWebKitAPI/win/HostWindow.cpp:
42283         * TestWebKitAPI/win/HostWindow.h:
42284         Prefixed Win32 API calls with ::. Updated namespace name.
42285
42286 2011-09-23  Adam Roben  <aroben@apple.com>
42287
42288         Merge WebKitAPITest into TestWebKitAPI
42289
42290         This also means that our formerly-WebKitAPITest tests will be run on the bots!
42291
42292         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
42293         them more idiomatic in a separate pass.
42294
42295         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
42296         functionality (and names!)
42297
42298         Reviewed by Anders Carlsson.
42299
42300         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
42301         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
42302         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
42303
42304         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
42305
42306         * TestWebKitAPI/win/main.cpp:
42307         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
42308
42309         * WebKitAPITest: Removed this directory and its contents.
42310
42311 2011-09-23  Adam Roben  <aroben@apple.com>
42312
42313         Remove two failing WebKitAPITest tests
42314
42315         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
42316
42317         Reviewed by Anders Carlsson.
42318
42319         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
42320         MainFrameAfterClose tests.
42321
42322 2011-09-25  Adam Barth  <abarth@webkit.org>
42323
42324         Finish removing PLATFORM(BREWMP) by removing associated code
42325         https://bugs.webkit.org/show_bug.cgi?id=68779
42326
42327         Reviewed by Sam Weinig.
42328
42329         * Scripts/webkitpy/common/config/build.py:
42330         * waf/build/settings.py:
42331
42332 2011-09-21  Ai Makabi  <makabi@google.com>
42333
42334         Provides a simple LRU cache class in Python.
42335
42336         https://bugs.webkit.org/show_bug.cgi?id=67823
42337
42338         Reviewed by Tony Chang.
42339
42340         * Scripts/webkitpy/common/lru_cache.py:
42341         * Scripts/webkitpy/common/lru_cache_unittest.py:
42342
42343 2011-09-25  Adam Barth  <abarth@webkit.org>
42344
42345         Remove PLATFORM(HAIKU) and associated code
42346         https://bugs.webkit.org/show_bug.cgi?id=68774
42347
42348         Reviewed by Sam Weinig.
42349
42350         * Scripts/webkitpy/common/config/build.py:
42351         * waf/build/settings.py:
42352
42353 2011-09-24  Adam Barth  <abarth@webkit.org>
42354
42355         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
42356         https://bugs.webkit.org/show_bug.cgi?id=68767
42357
42358         Reviewed by Eric Seidel.
42359
42360         * Scripts/build-webkit:
42361
42362 2011-09-24  Adam Barth  <abarth@webkit.org>
42363
42364         Remove ENABLE(WCSS) and associated code
42365         https://bugs.webkit.org/show_bug.cgi?id=68759
42366
42367         Reviewed by Darin Adler.
42368
42369         * Scripts/build-webkit:
42370         * Scripts/old-run-webkit-tests:
42371         * Scripts/webkitperl/features.pm:
42372         (hasFeature):
42373         * Scripts/webkitpy/layout_tests/port/webkit.py:
42374         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
42375
42376 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
42377
42378         Fixed GTK compilation after r95878, the operator== was defined
42379         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
42380
42381         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
42382
42383 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
42384
42385         [DRT] Include the right config file for EFL's DRT.
42386         https://bugs.webkit.org/show_bug.cgi?id=67042
42387
42388         Reviewed by Martin Robinson.
42389
42390         Ports which use CMake as their buildsystem (such as the EFL one) also
42391         have config.h files, but they are named differently, so include the
42392         right one depending on the buildsystem being used.
42393
42394         * DumpRenderTree/config.h:
42395
42396 2011-09-23  Adam Klein  <adamk@chromium.org>
42397
42398         Add ENABLE_MUTATION_OBSERVERS feature flag
42399         https://bugs.webkit.org/show_bug.cgi?id=68732
42400
42401         Reviewed by Ojan Vafai.
42402
42403         This flag will guard an implementation of the "Mutation Observers" proposed in
42404         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
42405
42406         * Scripts/build-webkit:
42407
42408 2011-09-23  Chang Shu  <cshu@webkit.org>
42409
42410         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
42411         https://bugs.webkit.org/show_bug.cgi?id=68556
42412
42413         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
42414
42415         Reviewed by Darin Adler.
42416
42417         * WebKitTestRunner/EventSenderProxy.h:
42418         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
42419         * WebKitTestRunner/PlatformWebView.h:
42420         * WebKitTestRunner/mac/EventSenderProxy.mm:
42421         (WTR::EventSenderProxy::EventSenderProxy):
42422         (WTR::EventSenderProxy::leapForward):
42423         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
42424         (WTR::EventSenderProxy::EventSenderProxy):
42425         (WTR::getMouseButton):
42426         (WTR::getModifiers):
42427         (WTR::EventSenderProxy::updateClickCountForButton):
42428         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
42429         (WTR::EventSenderProxy::mouseDown):
42430         (WTR::EventSenderProxy::mouseUp):
42431         (WTR::EventSenderProxy::mouseMoveTo):
42432         (WTR::EventSenderProxy::leapForward):
42433         (WTR::EventSenderProxy::sendOrQueueEvent):
42434         (WTR::EventSenderProxy::replaySavedEvents):
42435         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
42436         (WTR::PlatformWebView::postEvent):
42437         * WebKitTestRunner/qt/WebKitTestRunner.pro:
42438
42439 2011-09-23  Lei Zhang  <thestig@chromium.org>
42440
42441         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
42442         https://bugs.webkit.org/show_bug.cgi?id=68026
42443
42444         Reviewed by Dirk Pranke.
42445
42446         * Scripts/webkitpy/layout_tests/port/chromium.py:
42447
42448 2011-09-23  Elliot Poger  <epoger@google.com>
42449
42450         update layout_tests to account for new default of use_skia=1
42451         https://bugs.webkit.org/show_bug.cgi?id=68698
42452
42453         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
42454         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
42455         (Chromium-on-Mac now uses the Skia graphics library instead of
42456         Core Graphics).
42457
42458         Also updates layout_test code to work with that change.
42459
42460         Reviewed by Mihai Parparita.
42461
42462         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
42463         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
42464
42465 2011-09-23  Mark Rowe  <mrowe@apple.com>
42466
42467         Fix the build.
42468
42469         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
42470         the WTF namespace.
42471
42472 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
42473
42474         enable NRWT for run-webkit-tests on Lion
42475         https://bugs.webkit.org/show_bug.cgi?id=68673
42476
42477         Reviewed by Eric Seidel.
42478
42479         * Scripts/run-webkit-tests:
42480         (useNewRunWebKitTests):
42481
42482 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
42483
42484         Add unit test for existing StringBuilder
42485         https://bugs.webkit.org/show_bug.cgi?id=67080
42486
42487         Reviewed by Darin Adler.
42488
42489         * TestWebKitAPI/TestWebKitAPI.gypi:
42490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
42491         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
42492         (operator<<):
42493         (TestWebKitAPI::expectBuilderContent):
42494         (TestWebKitAPI::expectEmpty):
42495         (TestWebKitAPI::TEST):
42496
42497 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
42498
42499         [EFL] Use ewk_view to navigate in history instead of ewk_history.
42500         https://bugs.webkit.org/show_bug.cgi?id=68455
42501
42502         Reviewed by Antonio Gomes.
42503
42504         BackForwardItem::invoke() was using ewk_history functions to navigate
42505         in history; however, this will only call WebCore::BackForwardListImpl
42506         and not move between pages at all. We now call ewk_view_navigate and
42507         its siblings to make sure the navigation actually happens.
42508
42509         This should make tests like fast/dom/navigation-type-back-forward.html
42510         stop timing out.
42511
42512         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
42513         (BackForwardItem::invoke):
42514
42515 2011-09-22  Dean Jackson  <dino@apple.com>
42516
42517         Add ENABLE_CSS_FILTERS
42518         https://bugs.webkit.org/show_bug.cgi?id=68652
42519
42520         Reviewed by Simon Fraser.
42521
42522         * Scripts/build-webkit:
42523
42524 2011-09-22  Anders Carlsson  <andersca@apple.com>
42525
42526         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
42527         https://bugs.webkit.org/show_bug.cgi?id=68660
42528
42529         Reviewed by Adam Barth.
42530
42531         * WebKitTestRunner/mac/EventSenderProxy.mm:
42532         (WTR::EventSenderProxy::mouseUp):
42533
42534 2011-09-22  Adam Roben  <aroben@apple.com>
42535
42536         Remove FindSafari
42537
42538         It isn't used or built anymore.
42539
42540         Fixes <http://webkit.org/b/68628>
42541
42542         Reviewed by Darin Adler.
42543
42544         * FindSafari: Removed this directory and its contents.
42545
42546 2011-09-22  Adam Roben  <aroben@apple.com>
42547
42548         Remove FindSafari from all our .sln files
42549
42550         It isn't used anymore, so there's no point in building it.
42551
42552         Part of <http://webkit.org/b/68628> Remove FindSafari
42553
42554         Reviewed by Steve Falkenburg.
42555
42556         * DumpRenderTree/DumpRenderTree.sln:
42557         * WebKitTestRunner/WebKitTestRunner.sln:
42558
42559 2011-09-22  Adam Roben  <aroben@apple.com>
42560
42561         Remove all uses of FindSafari
42562
42563         It isn't really needed anymore.
42564
42565         Fixes <http://webkit.org/b/68626>.
42566
42567         Reviewed by Darin Adler.
42568
42569         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
42570
42571         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
42572         WebKit, but now we use WebKit.exe for that.
42573
42574         * Scripts/webkitdirs.pm:
42575         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
42576         do the same thing.
42577
42578         (readRegistryString):
42579         (writeRegistryString):
42580         Moved here from old-run-webkit-tests.
42581
42582 2011-09-22  Adam Roben  <aroben@apple.com>
42583
42584         Use the "direct object" form of system() to run WebKit.exe
42585
42586         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
42587         path to WebKit.exe.
42588
42589         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
42590         %WEBKITOUTPUTDIR%
42591
42592         Reviewed by Steve Falkenburg.
42593
42594         * Scripts/webkitdirs.pm:
42595         (runSafari):
42596
42597 2011-09-22  Adam Roben  <aroben@apple.com>
42598
42599         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
42600
42601         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
42602         spaces in the path to the WebKit source tree
42603
42604         Reviewed by John Sullivan.
42605
42606         * Scripts/webkitdirs.pm:
42607         (setupCygwinEnv):
42608
42609 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
42610
42611         [Qt] Use same DPI for application font as rest of app in DRT and WTR
42612
42613         QApplication will initialize the default application font based
42614         on the application DPI at construction time, but we then override
42615         the application DPI using QX11Info (hard-coding it to 96 for
42616         consistency). This hard-coding is not reflected in the application
42617         font, so we explicitly have update the font ourselves.
42618
42619         The 6 test results that are updated were originally produced with
42620         a DPI of 75, as this is the default fallback DPI when a QFont is
42621         constructed before QApplication. This was wrong, and the results
42622         are updated to match a DPI of 96.
42623
42624         Reviewed by Csaba Osztrogonác.
42625
42626         * DumpRenderTree/qt/main.cpp:
42627         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
42628
42629 2011-09-21  Anna Cavender  <annacc@chromium.org>
42630
42631         Update committers.py with a new contributor contact
42632         https://bugs.webkit.org/show_bug.cgi?id=68565
42633
42634         Reviewed by Eric Carlson.
42635
42636         * Scripts/webkitpy/common/config/committers.py:
42637
42638 2011-09-21  Chang Shu  <cshu@webkit.org>
42639
42640         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
42641         https://bugs.webkit.org/show_bug.cgi?id=68108
42642
42643         This patch implements the event sender mouse events through WebKit2 UIProcess which is
42644         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
42645         platform as the first step so the existing code is still kept for other platforms.
42646
42647         Reviewed by Darin Adler.
42648
42649         * WebKitTestRunner/EventSenderProxy.h:
42650         (WTR::EventSenderProxy::EventSenderProxy):
42651         (WTR::EventSenderProxy::leapForward):
42652         (WTR::EventSenderProxy::currentEventTime):
42653         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
42654         (WTR::EventSendingController::EventSendingController):
42655         (WTR::EventSendingController::mouseDown):
42656         (WTR::EventSendingController::mouseUp):
42657         (WTR::EventSendingController::mouseMoveTo):
42658         (WTR::EventSendingController::leapForward):
42659         (WTR::EventSendingController::keyDown):
42660         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
42661         * WebKitTestRunner/TestController.cpp:
42662         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
42663         * WebKitTestRunner/mac/EventSenderProxy.mm:
42664         (WTR::eventTypeForMouseButtonAndAction):
42665         (WTR::operator==):
42666         (WTR::EventSenderProxy::updateClickCountForButton):
42667         (WTR::EventSenderProxy::mouseDown):
42668         (WTR::EventSenderProxy::mouseUp):
42669         (WTR::EventSenderProxy::mouseMoveTo):
42670         (WTR::EventSenderProxy::keyDown):
42671         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
42672         (WTR::EventSenderProxy::keyDown):
42673         (WTR::EventSenderProxy::mouseDown):
42674         (WTR::EventSenderProxy::mouseUp):
42675         (WTR::EventSenderProxy::mouseMoveTo):
42676
42677 2011-09-21  Dan Bernstein  <mitz@apple.com>
42678
42679         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
42680         https://bugs.webkit.org/show_bug.cgi?id=68451
42681
42682         Reviewed by Darin Adler.
42683
42684         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
42685         Objective-C classes with names not having one of a list of prefixes
42686         passed on the command line.
42687
42688 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
42689
42690         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
42691         https://bugs.webkit.org/show_bug.cgi?id=68206
42692
42693         Reviewed by Tony Chang.
42694
42695         * Scripts/webkitdirs.pm:
42696         (determineBaseProductDir): add support for chromium-mac
42697         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
42698         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
42699
42700 2011-09-21  Adam Barth  <abarth@webkit.org>
42701
42702         garden-o-matic command should explain that it is starting a local server
42703         https://bugs.webkit.org/show_bug.cgi?id=68486
42704
42705         Reviewed by Dimitri Glazkov.
42706
42707         In the user study, both participants didn't understand why the
42708         garden-o-matic command appeared to hang.  This patch adds an
42709         explaination of what's going on.  It also adds a confirmation prompt
42710         before launching the browser to give the user a chance to read the
42711         text.  If that's too much of a speed bump, we can iterate.
42712
42713         * Scripts/webkitpy/tool/commands/gardenomatic.py:
42714
42715 2011-09-21  Chang Shu  <cshu@webkit.org>
42716
42717         [Qt] Implement KeyDown function for WebKit2 EventSender.
42718         https://bugs.webkit.org/show_bug.cgi?id=56485
42719
42720         Implement the KeyDown function on Qt platform.
42721
42722         Reviewed by Andreas Kling.
42723
42724         * WebKitTestRunner/PlatformWebView.h:
42725         * WebKitTestRunner/TestController.cpp:
42726         (WTR::TestController::TestController):
42727         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
42728         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
42729         (WTR::getModifiers):
42730         (WTR::EventSenderProxy::keyDown):
42731         (buildModifierFlags):
42732         (EventSenderProxy::keyDown):
42733         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
42734         (WTR::PlatformWebView::sendEvent):
42735         * WebKitTestRunner/qt/WebKitTestRunner.pro:
42736
42737 2011-09-20  Adam Barth  <abarth@webkit.org>
42738
42739         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
42740         https://bugs.webkit.org/show_bug.cgi?id=68496
42741
42742         Reviewed by Dimitri Glazkov.
42743
42744         This patch adds a bunch of sorting to make sure things happen in a
42745         predictable order in both JavaScriptCore and V8.  We've talked before
42746         about whether these two JavaScript engines should enumerate
42747         dictionaries in the same order, but the consensus has been that they
42748         shouldn't.  Personally, I disagree with that consensus, but such is life.
42749
42750         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
42751         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
42752         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
42753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
42754
42755 2011-09-20  Adam Barth  <abarth@webkit.org>
42756
42757         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
42758         https://bugs.webkit.org/show_bug.cgi?id=68495
42759
42760         Reviewed by Dimitri Glazkov.
42761
42762         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
42763
42764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
42765
42766 2011-09-20  Eric Seidel  <eric@webkit.org>
42767
42768         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
42769         https://bugs.webkit.org/show_bug.cgi?id=65781
42770
42771         Reviewed by Ryosuke Niwa.
42772
42773         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
42774         to resolve the passed in url relative to the absolute url for the test.
42775         For http tests, since the test url is an http url, we can't resolve relative
42776         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
42777         for resolving.
42778
42779         I believe this is a better approach than the on used in the Qt and Chromium DRT's
42780         (which resolves the path relative to the built location of the DRT executable)
42781         and we should move this new code into a shared location in a follow-up patch.
42782
42783         It turns out that there was a second use for pathToLocalResource, used by one
42784         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
42785         To support this test I made the new pathToLocalResource smart enough to map
42786         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
42787
42788         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
42789         (LayoutTestController::pathToLocalResource):
42790         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
42791
42792 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
42793
42794         Need to specify a django version, instead of using default
42795         https://bugs.webkit.org/show_bug.cgi?id=68398
42796
42797         Reviewed by Eric Seidel.
42798
42799         * QueueStatusServer/__init__.py:
42800         * QueueStatusServer/main.py:
42801
42802 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
42803
42804         Update committers.py with a few more contributor contacts
42805         https://bugs.webkit.org/show_bug.cgi?id=68487
42806
42807         Reviewed by Eric Seidel.
42808
42809         * Scripts/webkitpy/common/config/committers.py:
42810
42811 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
42812
42813         Fix webkitpy unit tests after 95547 and 95549
42814         https://bugs.webkit.org/show_bug.cgi?id=68483
42815
42816         Reviewed by Adam Barth.
42817
42818         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
42819
42820         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
42821         parse_entries_from_file(), use StringIO and entry.reviewer_text().
42822         While testing parse_latest_entry_from_file(), expect the correct
42823         touched_files() list.
42824
42825 2011-09-20  Adam Barth  <abarth@webkit.org>
42826
42827         garden-o-matic makes it hard to compare images when scroll bars appear
42828         https://bugs.webkit.org/show_bug.cgi?id=68482
42829
42830         Reviewed by Eric Seidel.
42831
42832         Because we autoscale image width, the images rescale if we overflow
42833         vertically and get a scrollbar.  That makes it hard to compare two sets
42834         of images.  This patch reserves space for the scrollbar so we won't
42835         have the layout change.
42836
42837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
42838
42839 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
42840
42841         Unreviewed, rolling out r95565.
42842         http://trac.webkit.org/changeset/95565
42843         https://bugs.webkit.org/show_bug.cgi?id=68470
42844
42845         Broke builds (Requested by andersca on #webkit).
42846
42847         * MiniBrowser/gtk/BrowserWindow.c:
42848         (mouseDidMoveOverElement):
42849
42850 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
42851
42852         Get hover'ed element URL from HitTest.
42853
42854         mouseDidMoveOverElement now gets the hover'ed element link using
42855         WKHitTestResult API's.
42856         https://bugs.webkit.org/show_bug.cgi?id=68426
42857
42858         Reviewed by Anders Carlsson.
42859
42860         * MiniBrowser/gtk/BrowserWindow.c:
42861         (mouseDidMoveOverElement):
42862
42863 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
42864
42865         Changelog class should have a method to return all entries
42866         https://bugs.webkit.org/show_bug.cgi?id=68399
42867
42868         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
42869         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
42870
42871         Reviewed by Ryosuke Niwa.
42872
42873         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
42874         and adapt it to become a generator.
42875         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
42876
42877 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
42878
42879         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
42880         https://bugs.webkit.org/show_bug.cgi?id=51159
42881
42882         Permit any URL with a local scheme to set a user style sheet. Allow qrc
42883         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
42884
42885         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
42886
42887         Reviewed by Kenneth Rohde Christiansen.
42888
42889         * DumpRenderTree/qt/DumpRenderTree.pro:
42890         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
42891         * DumpRenderTree/qt/resources/user.css: Added.
42892         (body):
42893         * WebKitTestRunner/qt/WebKitTestRunner.pro:
42894         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
42895         * WebKitTestRunner/qt/resources/user.css: Added.
42896         (body):
42897
42898 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
42899
42900         ChangeLogEntry class should contain a list of touched files
42901         https://bugs.webkit.org/show_bug.cgi?id=68115
42902
42903         Reviewed by Eric Seidel.
42904
42905         Add method to return the list of files touched in a ChangeLog entry.
42906
42907         * Scripts/webkitpy/common/checkout/changelog.py: Add
42908         touched_files_regexp and touched_files() method.
42909         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
42910         unit tests for touched_files() method.
42911
42912 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
42913
42914         Unreviewed, rolling out r95526 and r95541.
42915         http://trac.webkit.org/changeset/95526
42916         http://trac.webkit.org/changeset/95541
42917         https://bugs.webkit.org/show_bug.cgi?id=68443
42918
42919         It broke 6 tests (Requested by ossy_ on #webkit).
42920
42921         * DumpRenderTree/qt/main.cpp:
42922         (main):
42923         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
42924         (WTR::activateFonts):
42925
42926 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
42927
42928         Fix patch and bug numbering in the mocktool simulation code
42929         https://bugs.webkit.org/show_bug.cgi?id=68374
42930
42931         Reviewed by Adam Barth.
42932
42933         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
42934         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
42935         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
42936         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
42937         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
42938         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
42939         * Scripts/webkitpy/tool/commands/download_unittest.py:
42940         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
42941         * Scripts/webkitpy/tool/commands/queries_unittest.py:
42942         * Scripts/webkitpy/tool/commands/queues_unittest.py:
42943         * Scripts/webkitpy/tool/commands/queuestest.py:
42944         * Scripts/webkitpy/tool/commands/upload_unittest.py:
42945         * Scripts/webkitpy/tool/mocktool.py:
42946         * Scripts/webkitpy/tool/steps/steps_unittest.py:
42947         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
42948
42949 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
42950
42951         [Qt] Don't override default QApplication font for DRT and WTR
42952
42953         Revision 95526 moved the relevant code below the QApplication
42954         constructor, to fix a potential crash, and that made the code
42955         take effect, breaking 6 tests.
42956
42957         We should rely on the QWebSettings to set default fonts, and
42958         this QApplication::setFont() is a relic from when we didn't
42959         have that option, so we remove the code.
42960
42961         Reviewed by Csaba Osztrogonác.
42962
42963         * DumpRenderTree/qt/main.cpp:
42964         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
42965
42966 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
42967
42968         WebKitTestRunner: Provide usage if run without arguments
42969
42970         If WTR is run without either one or more filenames, or
42971         a '-' to indicate server mode, we don't need to start
42972         up the test machinery. Doing so might actually crash,
42973         as we'll exit the application immedeatly after anyways.
42974
42975         Reviewed by Simon Hausmann.
42976
42977         * WebKitTestRunner/TestController.cpp:
42978         (WTR::TestController::initialize):
42979
42980 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
42981
42982         [Qt] Don't use QFont before initializing QApplication
42983
42984         Could potentially result in crash.
42985
42986         Reviewed by Simon Hausmann.
42987
42988         * DumpRenderTree/qt/main.cpp:
42989         (main):
42990
42991 2011-09-19  Adam Barth  <abarth@webkit.org>
42992
42993         Always enable ENABLE(EVENTSOURCE)
42994         https://bugs.webkit.org/show_bug.cgi?id=68414
42995
42996         Reviewed by Eric Seidel.
42997
42998         * Scripts/build-webkit:
42999
43000 2011-09-19  David Levin  <levin@chromium.org>
43001
43002         Sheriffbot rollout should be more intuitive.
43003         https://bugs.webkit.org/show_bug.cgi?id=68415
43004
43005         Reviewed by Adam Barth.
43006
43007         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
43008         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
43009           and a few others cases.
43010         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
43011
43012 2011-09-19  David Levin  <levin@chromium.org>
43013
43014         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
43015         https://bugs.webkit.org/show_bug.cgi?id=68391
43016
43017         Reviewed by Darin Adler.
43018
43019         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
43020         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
43021
43022 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
43023
43024         Style checker should not check public Qt WK2 API for parameter_name.
43025         https://bugs.webkit.org/show_bug.cgi?id=68359
43026
43027         Reviewed by Andreas Kling.
43028
43029         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
43030         Add an exception in the style checker to disable the check. Also added the test for it.
43031
43032         * Scripts/webkitpy/style/checker.py:
43033         * Scripts/webkitpy/style/checker_unittest.py:
43034
43035 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
43036
43037         GTK DRT leaks memory while comparing history items
43038         https://bugs.webkit.org/show_bug.cgi?id=68086
43039
43040         Reviewed by Martin Robinson.
43041
43042         webkit_web_history_item_get_target() returns a g_strdup()'d string,
43043         so memory must be freed before compareHistoryItems() returns.
43044
43045         * DumpRenderTree/gtk/DumpRenderTree.cpp:
43046         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
43047
43048 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
43049
43050         Buildbot marks a nrwt bot red when tests are missing results
43051         https://bugs.webkit.org/show_bug.cgi?id=64812
43052
43053         Reviewed by Ryosuke Niwa.
43054
43055         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43056         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
43057
43058 2011-09-19  Jessie Berlin  <jberlin@apple.com>
43059
43060         Sites that use history pushState or replaceState are recorded in history in Private Browsing
43061         mode.
43062         https://bugs.webkit.org/show_bug.cgi?id=68208
43063
43064         Reviewed by Brady Eidson.
43065
43066         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
43067         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
43068
43069         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
43070         (TestWebKitAPI::didNavigateWithNavigationData):
43071         This is a context history client callback, so it should not be called when in Private
43072         Browsing. Add a call to FAIL().
43073         (TestWebKitAPI::didSameDocumentNavigationForFrame):
43074         This is a page load client callback that happens after the didNavigateWithNavigationData
43075         callback. End the test.
43076         (TestWebKitAPI::TEST):
43077         Enable Private Browsing and load a page that uses history.pushState.
43078
43079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43080         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
43081         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
43082         Ditto.
43083         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
43084         Ditto.
43085         * TestWebKitAPI/win/copy-resources.cmd:
43086         Ditto.
43087
43088 2011-09-16  Elliot Poger  <epoger@google.com>
43089
43090         add non-CG Webkit-Mac builds to flakiness dashboard
43091         https://bugs.webkit.org/show_bug.cgi?id=68265
43092
43093         Reviewed by Adam Barth.
43094
43095         As Chromium-on-Mac approaches the switchover from Core Graphics to
43096         Skia, we need to add the Skia version to the flakiness dashboard.
43097
43098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
43099         * TestResultServer/static-dashboards/builders.js:
43100         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
43101
43102 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
43103
43104         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
43105         https://bugs.webkit.org/show_bug.cgi?id=68071
43106
43107         Reviewed by Adam Barth.
43108
43109         * DumpRenderTree/chromium/WebPermissions.cpp:
43110         (WebPermissions::allowImage):
43111         * DumpRenderTree/chromium/WebPermissions.h:
43112
43113 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
43114
43115         update-webkit-chromium should retry the gclient call if it fails once
43116         https://bugs.webkit.org/show_bug.cgi?id=68252
43117
43118         Reviewed by Adam Barth.
43119
43120         * Scripts/update-webkit-chromium:
43121
43122 2011-09-16  Rob Buis  <rbuis@rim.com>
43123
43124         Add Eli's rim address and change the nick.
43125
43126         * Scripts/webkitpy/common/config/committers.py:
43127
43128 2011-09-16  Anders Carlsson  <andersca@apple.com>
43129
43130         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
43131         https://bugs.webkit.org/show_bug.cgi?id=68269
43132
43133         Reviewed by Geoffrey Garen.
43134
43135         Update client function signatures.
43136
43137         * MiniBrowser/gtk/BrowserWindow.c:
43138         (browserWindowUIClientInit):
43139         * MiniBrowser/mac/BrowserWindowController.m:
43140         (mouseDidMoveOverElement):
43141         (-[BrowserWindowController awakeFromNib]):
43142         * MiniBrowser/win/BrowserView.cpp:
43143         (BrowserView::create):
43144         * WebKitTestRunner/TestController.cpp:
43145         (WTR::TestController::createOtherPage):
43146         (WTR::TestController::initialize):
43147
43148 2011-09-16  Anders Carlsson  <andersca@apple.com>
43149
43150         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
43151         https://bugs.webkit.org/show_bug.cgi?id=68266
43152
43153         Reviewed by John Sullivan.
43154
43155         * MiniBrowser/mac/BrowserWindowController.m:
43156         (mouseDidMoveOverElement):
43157
43158 2011-09-16  Vincent Scheib  <scheib@chromium.org>
43159
43160         Add Vincent Scheib to the committers list.
43161
43162         * Scripts/webkitpy/common/config/committers.py:
43163
43164 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
43165
43166         Unreviewed, rolling out r95285.
43167         http://trac.webkit.org/changeset/95285
43168         https://bugs.webkit.org/show_bug.cgi?id=68247
43169
43170         It broke a webkitpy test (Requested by ossy on #webkit).
43171
43172         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43173
43174 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
43175
43176         Buildbot marks a nrwt bot red when tests are missing results
43177         https://bugs.webkit.org/show_bug.cgi?id=64812
43178
43179         Reviewed by Dirk Pranke.
43180
43181         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43182
43183 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
43184
43185         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
43186         https://bugs.webkit.org/show_bug.cgi?id=68178
43187
43188         Reviewed by Xan Lopez.
43189
43190         Add a work-around to enable WebKit2 when using build-webkit.
43191
43192         * Scripts/webkitdirs.pm:
43193         (buildAutotoolsProject):
43194
43195 2011-09-15  James Robinson  <jamesr@chromium.org>
43196
43197         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
43198
43199         * Scripts/webkitpy/common/config/committers.py:
43200
43201 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
43202
43203         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
43204         https://bugs.webkit.org/show_bug.cgi?id=68003
43205
43206         Reviewed by Adam Barth.
43207
43208         * Scripts/webkitpy/tool/mocktool.py:
43209         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
43210         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
43211
43212 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
43213
43214         Python version check is confusing in test-webkitpy
43215         https://bugs.webkit.org/show_bug.cgi?id=68004
43216
43217         Reviewed by Adam Barth.
43218
43219         * Scripts/test-webkitpy:
43220
43221 2011-09-15  Eric Seidel  <eric@webkit.org>
43222
43223         Reviewed by Adam Barth.
43224
43225         webkit-patch should be able to find users and add them to bugzilla groups
43226         https://bugs.webkit.org/show_bug.cgi?id=63351
43227
43228         These are both very basic commands.  But it's now possible to find
43229         all users matching a regexp, as well as add all users matching a regexp
43230         to a set of groups.
43231
43232         bugzilla.py already knew how to find users (for validate-committer-lists)
43233         but now it has the ability to modify the user records.
43234
43235         I split some of the logic out into a new EditUsersParser class
43236         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
43237
43238         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
43239         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
43240         * Scripts/webkitpy/tool/commands/__init__.py:
43241         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
43242         * Scripts/webkitpy/tool/commands/findusers.py: Added.
43243
43244 2011-09-15  Eric Seidel  <eric@webkit.org>
43245
43246         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
43247         https://bugs.webkit.org/show_bug.cgi?id=68182
43248
43249         Reviewed by Adam Barth.
43250
43251         * Scripts/build-webkit:
43252         * waf/build/settings.py:
43253
43254 2011-09-15  Eric Seidel  <eric@webkit.org>
43255
43256         Unreviewed.  Make contributor email look-up case-insensitive.
43257
43258         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
43259         was missing from committers.py due to case sensitivity.
43260
43261         This also includes a test expectations update to committers_unittest.py
43262         after my previous change.
43263
43264         * Scripts/webkitpy/common/config/committers.py:
43265         * Scripts/webkitpy/common/config/committers_unittest.py:
43266         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
43267
43268 2011-09-15  Eric Seidel  <eric@webkit.org>
43269
43270         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
43271
43272         Add a bunch of email aliases to committers.py for regular contributors
43273         who are committing using other email addresses than they have listed in the file.
43274
43275         * Scripts/webkitpy/common/config/committers.py:
43276
43277 2011-09-15  Eric Seidel  <eric@webkit.org>
43278
43279         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
43280         https://bugs.webkit.org/show_bug.cgi?id=68022
43281
43282         Reviewed by Ryosuke Niwa.
43283
43284         * Scripts/build-webkit:
43285         * waf/build/settings.py:
43286
43287 2011-09-15  Anders Carlsson  <andersca@apple.com>
43288
43289         Fix Mac build by including config.h where needed.
43290
43291         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
43292         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
43293         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
43294         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
43295         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
43296         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
43297         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
43298         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
43299         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
43300         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
43301         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
43302         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
43303         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
43304         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
43305         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
43306         * TestWebKitAPI/mac/main.mm:
43307
43308 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
43309
43310         Let TestWebKitAPI work for chromium
43311         https://bugs.webkit.org/show_bug.cgi?id=67756
43312
43313         Reviewed by Sam Weinig.
43314
43315         * Scripts/build-api-tests:
43316         * Scripts/run-api-tests:
43317         (isSupportedPlatform):
43318         (runTest):
43319         (populateTests):
43320         * Scripts/webkitdirs.pm:
43321         (determineBaseProductDir):
43322         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
43323         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
43324         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
43325         * TestWebKitAPI/InjectedBundleController.cpp:
43326         * TestWebKitAPI/InjectedBundleMain.cpp:
43327         * TestWebKitAPI/JavaScriptTest.cpp:
43328         * TestWebKitAPI/PlatformUtilities.cpp:
43329         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
43330         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43331         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
43332         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
43333         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
43334         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
43335         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
43336         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
43337         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
43338         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
43339         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
43340         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
43341         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
43342         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
43343         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
43344         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
43345         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
43346         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
43347         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
43348         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
43349         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
43350         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
43351         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
43352         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
43353         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
43354         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
43355         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
43356         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
43357         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
43358         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
43359         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
43360         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
43361         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
43362         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
43363         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
43364         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
43365         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
43366         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
43367         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
43368         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
43369         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
43370         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
43371         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
43372         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
43373         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
43374         * TestWebKitAPI/TestsController.cpp:
43375         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
43376         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
43377         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
43378         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
43379         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
43380         * TestWebKitAPI/win/main.cpp:
43381
43382 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
43383
43384         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
43385         https://bugs.webkit.org/show_bug.cgi?id=68145
43386
43387         This will allow for other classes in DumpRenderTree to reuse this functionality
43388
43389         Reviewed by David Levin.
43390
43391         * DumpRenderTree/chromium/TestShell.cpp:
43392         (normalizeLayoutTestURLInternal):
43393         (dumpHistoryItem):
43394         (TestShell::normalizeLayoutTestURL):
43395         * DumpRenderTree/chromium/TestShell.h:
43396
43397 2011-09-14  Ada Chan  <adachan@apple.com>
43398
43399         Add test for WKBundleFrameCopyWebArchive().
43400         https://bugs.webkit.org/show_bug.cgi?id=67857
43401
43402         Reviewed by Anders Carlsson.
43403
43404         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
43405         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
43406         the returned data is a valid webarchive.
43407         (TestWebKitAPI::setInjectedBundleClient):
43408         (TestWebKitAPI::didFinishLoadForFrame):
43409         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
43410         injected bundle for the webarchive and check the returned webarchive.
43411         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
43412         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
43413         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
43414         the web archive.
43415
43416         Add files to project.
43417         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
43418         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
43419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43420
43421 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
43422
43423         committers.py should support multiple IRC nicknames
43424         https://bugs.webkit.org/show_bug.cgi?id=68110
43425
43426         Reviewed by Eric Seidel.
43427
43428         Add multiple IRC nickname support to committers.py
43429
43430         * Scripts/webkitpy/common/config/committers.py:
43431         * Scripts/webkitpy/common/config/committers_unittest.py:
43432         * Scripts/webkitpy/tool/bot/irc_command.py:
43433         * Scripts/webkitpy/tool/bot/sheriff.py:
43434
43435 2011-09-14  Jon Lee  <jonlee@apple.com>
43436
43437         Implement globalFlag for WebKitTestRunner
43438         https://bugs.webkit.org/show_bug.cgi?id=68033
43439         <rdar://problem/10119204>
43440
43441         Reviewed by Sam Weinig.
43442
43443         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
43444         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
43445         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
43446         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
43447         (WTR::LayoutTestController::globalFlag): simple getter
43448         (WTR::LayoutTestController::setGlobalFlag): simple setter
43449
43450 2011-09-13  Eric Seidel  <eric@webkit.org>
43451
43452         Remove ENABLE_SVG_USE as <use> is required by HTML5
43453         https://bugs.webkit.org/show_bug.cgi?id=68019
43454
43455         Reviewed by Ryosuke Niwa.
43456
43457         * Scripts/build-webkit:
43458         * waf/build/settings.py:
43459
43460 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
43461
43462         Remove Jan Erik Hanssen (added in my r95078) from the list for now
43463         since I can't confirm acceptable his committership.
43464
43465         * Scripts/webkitpy/common/config/committers.py:
43466
43467 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
43468
43469         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
43470         https://bugs.webkit.org/show_bug.cgi?id=68066
43471
43472         Reviewed by Adam Barth.
43473
43474         * DumpRenderTree/chromium/WebViewHost.cpp:
43475         * DumpRenderTree/chromium/WebViewHost.h:
43476
43477 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
43478
43479         committers.py is missing some contributors
43480         https://bugs.webkit.org/show_bug.cgi?id=68059
43481
43482         Reviewed by Adam Barth.
43483
43484         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
43485
43486         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
43487
43488         * Scripts/webkitpy/common/config/committers.py:
43489
43490 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
43491
43492         Fix webkit python test after r95061.
43493
43494         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
43495
43496 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
43497
43498         Add myself as a contributor. No review needed.
43499
43500         * Scripts/webkitpy/common/config/committers.py:
43501
43502 2011-09-13  Adam Barth  <abarth@webkit.org>
43503
43504         garden-o-matic has unfriendly error messages when the local server is not available
43505         https://bugs.webkit.org/show_bug.cgi?id=68042
43506
43507         Reviewed by Dimitri Glazkov.
43508
43509         This patch moves us from using alert to showing the error inline in the
43510         progress dialog.
43511
43512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
43513         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
43514         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
43515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
43516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
43517
43518 2011-09-13  Adam Barth  <abarth@webkit.org>
43519
43520         FailureGrid in garden-o-matic should link to the builder's waterfall page
43521         https://bugs.webkit.org/show_bug.cgi?id=68036
43522
43523         Reviewed by Dimitri Glazkov.
43524
43525         One of the users in the user study thought the configurations names in
43526         the failure grid would link to the underlying bots.  That makes sense,
43527         so this patch adds the behavior.
43528
43529         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
43530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
43531         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
43532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
43533
43534 2011-09-13  Adam Barth  <abarth@webkit.org>
43535
43536         garden-o-matic should be able to mark failures as expected
43537         https://bugs.webkit.org/show_bug.cgi?id=68027
43538
43539         Reviewed by Dimitri Glazkov.
43540
43541         All the back-end infrastructure exists for this operation.  This patch
43542         just adds some UI to the front-end and wires that UI up to the back
43543         end.  This exact UI will likely need some more polish, but this should
43544         be a reasonable first cut.
43545
43546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
43547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
43548         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
43549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
43550         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
43551
43552 2011-09-13  Adam Barth  <abarth@webkit.org>
43553
43554         garden-o-matic should tell you about the progress of your rebaseline
43555         https://bugs.webkit.org/show_bug.cgi?id=67967
43556
43557         Reviewed by Dimitri Glazkov.
43558
43559         This patch adds ui.MessageBox, which is a light wrapper around jQuery
43560         UI's dialog widget.  We then use ui.MessageBox to show status messages
43561         about in-progress rebaselines.  As each baseline is downloaded, the
43562         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
43563
43564         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
43565         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
43566         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
43567         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
43568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
43569         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
43570
43571 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
43572
43573         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
43574         https://bugs.webkit.org/show_bug.cgi?id=68024
43575
43576         Reviewed by Gustavo Noronha Silva.
43577
43578         Using g_list_count() and g_list_nth_data() together on a loop is
43579         inneficient since they're both O(n). Iterate over lists in a saner
43580         way.
43581
43582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
43583         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
43584         iterate on it using g_list_next(). Free the list after done with it.
43585         (dumpBackForwardListForWebView): Instead of appending (which is
43586         expensive in GLists) history items and then iterating from the tail
43587         of the itemsToPrint list, prepend items and walk forwards as usual.
43588         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
43589         remove the (unneeded) viewList variable.
43590
43591 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
43592
43593         Add Eric's IRC nick.
43594
43595         * Scripts/webkitpy/common/config/committers.py:
43596
43597 2011-09-13  Anders Carlsson  <andersca@apple.com>
43598
43599         Disable C++ exceptions when building with clang
43600         https://bugs.webkit.org/show_bug.cgi?id=68031
43601         <rdar://problem/9556880>
43602
43603         Reviewed by Mark Rowe.
43604
43605         * MiniBrowser/Configurations/Base.xcconfig:
43606         * TestWebKitAPI/Configurations/Base.xcconfig:
43607         * WebKitTestRunner/Configurations/Base.xcconfig:
43608
43609 2011-09-13  Ojan Vafai  <ojan@chromium.org>
43610
43611         [chromium] fix flakiness dashboard for chromium interactive tests
43612         https://bugs.webkit.org/show_bug.cgi?id=68029
43613
43614         Reviewed by Tony Chang.
43615
43616         * TestResultServer/static-dashboards/flakiness_dashboard.html:
43617         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
43618
43619 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
43620
43621         Add Alice and Aryeh to the list of contributors.
43622
43623         * Scripts/webkitpy/common/config/committers.py:
43624
43625 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
43626
43627         sheriffbot whois should also tell us email addresses
43628         https://bugs.webkit.org/show_bug.cgi?id=67975
43629
43630         Reviewed by Eric Seidel and David Levin.
43631
43632         Taught sheriffbot how to tell us contributor's email addresses.
43633
43634         * Scripts/webkitpy/tool/bot/irc_command.py:
43635         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
43636
43637 2011-09-13  Eric Seidel  <eric@webkit.org>
43638
43639         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
43640         https://bugs.webkit.org/show_bug.cgi?id=68018
43641
43642         Reviewed by Ryosuke Niwa.
43643
43644         * Scripts/build-webkit:
43645         * waf/build/settings.py:
43646
43647 2011-09-13  Chang Shu  <cshu@webkit.org>
43648
43649         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
43650         https://bugs.webkit.org/show_bug.cgi?id=57515
43651
43652         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
43653         TestController synchronously. The latter then sends simulated event to WebKit2 module,
43654         which is synchronous, too.
43655
43656         Reviewed by Darin Adler.
43657
43658         * WebKitTestRunner/EventSenderProxy.h: Added.
43659         (WTR::EventSenderProxy::EventSenderProxy):
43660         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
43661         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
43662         (WTR::EventSendingController::keyDown):
43663         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
43664         * WebKitTestRunner/PlatformWebView.h:
43665         (WTR::PlatformWebView::platformWindow):
43666         * WebKitTestRunner/TestController.cpp:
43667         (WTR::TestController::TestController):
43668         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
43669         * WebKitTestRunner/TestController.h:
43670         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
43671         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
43672         (WTR::buildModifierFlags):
43673         (WTR::EventSenderProxy::keyDown):
43674
43675 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
43676
43677         [EFL] DRT: Add DumpRenderTreeEfl.h
43678         https://bugs.webkit.org/show_bug.cgi?id=63993
43679
43680         Reviewed by Eric Seidel.
43681
43682         This header contains some global variables used by EFL's
43683         DumpRenderTree implementation.
43684
43685         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
43686         appropriate.
43687         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
43688
43689 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
43690
43691         [EFL] Send the right key names for PageUp and PageDown.
43692         https://bugs.webkit.org/show_bug.cgi?id=67044
43693
43694         Reviewed by Kenneth Rohde Christiansen.
43695
43696         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
43697         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
43698         However, EventSender was sending "Page_Up" and "Page_Down", so tests
43699         such as editing/input/page-up-down-scrolls.html were timing out due to
43700         the right key down events not being sent.
43701
43702         * DumpRenderTree/efl/EventSender.cpp:
43703         (keyPadNameFromJSValue):
43704         (keyNameFromJSValue):
43705
43706 2011-09-12  Eric Seidel  <eric@webkit.org>
43707
43708         sheriffbot whois is case sensitive
43709         https://bugs.webkit.org/show_bug.cgi?id=67972
43710
43711         Reviewed by Adam Barth.
43712
43713         I also fixed a typo in the "More than 5 contributors" message
43714         from my previous commit.
43715
43716         * Scripts/webkitpy/common/config/committers.py:
43717         * Scripts/webkitpy/common/config/committers_unittest.py:
43718         * Scripts/webkitpy/tool/bot/irc_command.py:
43719         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
43720
43721 2011-09-12  Eric Seidel  <eric@webkit.org>
43722
43723         sheriffbot whois should be smarter
43724         https://bugs.webkit.org/show_bug.cgi?id=67971
43725
43726         Reviewed by Adam Barth.
43727
43728         This makes sheriffbot whois basically grep the committers list
43729         making it much easier to find a contributor by name.
43730
43731         Unfortunately the current unittests depend on the real committers.py
43732         file, so as we add more eric's to the project, this unittest result will
43733         change.  I think that's OK for now.  We'll fix it when it breaks.
43734
43735         * Scripts/webkitpy/common/config/committers.py:
43736         * Scripts/webkitpy/tool/bot/irc_command.py:
43737         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
43738
43739 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
43740
43741         Unreviewed, rolling out r94976.
43742         http://trac.webkit.org/changeset/94976
43743         https://bugs.webkit.org/show_bug.cgi?id=67953
43744
43745         Broke a bunch of security/load& tests (Requested by rniwa on
43746         #webkit).
43747
43748         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
43749         (LayoutTestController::pathToLocalResource):
43750
43751 2011-09-12  Eric Seidel  <eric@webkit.org>
43752
43753         Rubber-stamped by Adam Barth.
43754
43755         Remove the "the tree is burning!" warning previously shown
43756         when landing patches.  It was a dream.  But it's just noise now.
43757
43758         Some bots will require a restart to notice the removal of the option
43759         so I've left the --ignore-builders option in for now.
43760
43761         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
43762         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
43763         * Scripts/webkitpy/tool/commands/download.py:
43764         * Scripts/webkitpy/tool/commands/download_unittest.py:
43765         * Scripts/webkitpy/tool/commands/queues_unittest.py:
43766         * Scripts/webkitpy/tool/steps/__init__.py:
43767         * Scripts/webkitpy/tool/steps/commit.py:
43768         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
43769         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
43770
43771 2011-09-12  Eric Seidel  <eric@webkit.org>
43772
43773         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
43774         https://bugs.webkit.org/show_bug.cgi?id=65781
43775
43776         Reviewed by Ryosuke Niwa.
43777
43778         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
43779         to resolve the passed in url relative to the absolute url for the test.
43780
43781         I believe this is a better approach than the on used in the Qt and Chromium DRT's
43782         (which resolves the path relative to the built location of the DRT executable)
43783         and we should move this new code into a shared location in a follow-up patch.
43784
43785         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
43786         (LayoutTestController::pathToLocalResource):
43787
43788 2011-09-12  Eric Seidel  <eric@webkit.org>
43789
43790         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
43791         https://bugs.webkit.org/show_bug.cgi?id=67530
43792
43793         Reviewed by Adam Barth.
43794
43795         I believe I've fixed the bug in the original patch which prompted the rollout.
43796         The previous patch was using the wrong deadline for the initial read,
43797         subtracting time.time() twice from the deadline value.
43798
43799         * Scripts/webkitpy/layout_tests/port/webkit.py:
43800         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
43801
43802 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
43803
43804         [Qt][WK2] WebKitTestRunner does not produce crash logs
43805         https://bugs.webkit.org/show_bug.cgi?id=67714
43806
43807         Reviewed by Chang Shu.
43808
43809         Added a simple way of generating backtrace on crash
43810         to the web process. The implementation is similar what
43811         we have in DRT. It depends on GNU libc functionality
43812         so it is only enabled where we are running in such an environment.
43813
43814         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
43815         (WTR::printBacktrace):
43816         (WTR::crashHandler):
43817         (WTR::InjectedBundle::platformInitialize):
43818
43819 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
43820
43821         Added my IRC nick to the committers file.
43822
43823         * Scripts/webkitpy/common/config/committers.py:
43824
43825 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
43826
43827         The executable allocator makes it difficult to free individual
43828         chunks of executable memory
43829         https://bugs.webkit.org/show_bug.cgi?id=66363
43830
43831         Reviewed by Oliver Hunt.
43832
43833         Introduced a best-fit, balanced-tree based allocator. The allocator
43834         required a balanced tree that does not allocate memory and that
43835         permits the removal of individual nodes directly (as opposed to by
43836         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
43837         Changed all references to executable code to use a reference counted
43838         handle.
43839
43840         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
43841         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
43842         (TestWebKitAPI::TEST_F):
43843         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
43844         (TestWebKitAPI::Pair::findExact):
43845         (TestWebKitAPI::Pair::remove):
43846         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
43847         (TestWebKitAPI::Pair::assertFoundAndRemove):
43848         (TestWebKitAPI::Pair::assertEqual):
43849         (TestWebKitAPI::Pair::assertSameValuesForKey):
43850         (TestWebKitAPI::Pair::testDriver):
43851         (TestWebKitAPI::TEST_F):
43852
43853 2011-09-10  Andy Estes  <aestes@apple.com>
43854
43855         Move myself from committers_unable_to_review to reviewers_list.
43856
43857         * Scripts/webkitpy/common/config/committers.py:
43858
43859 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
43860
43861         [wx] Unreviewed build fix. MSW build fixes.
43862
43863         * DumpRenderTree/config.h:
43864         * waf/build/wxpresets.py:
43865
43866 2011-09-10  Andreas Kling  <kling@webkit.org>
43867
43868         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
43869         https://bugs.webkit.org/show_bug.cgi?id=59328
43870
43871         Reviewed by Kenneth Rohde Christiansen.
43872
43873         * MiniBrowser/mac/BrowserWindowController.m:
43874         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
43875
43876 2011-09-10  Adam Barth  <abarth@webkit.org>
43877
43878         Build fix for Android.  DumpRenderTree is a client of the WebKit API
43879         and does not have access to notImplemented().
43880
43881         * DumpRenderTree/chromium/TestShellAndroid.cpp:
43882         (openStartupDialog):
43883
43884 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
43885
43886         Add a script to create a monolithic script-test
43887         https://bugs.webkit.org/show_bug.cgi?id=67747
43888
43889         Reviewed by Darin Adler.
43890
43891         * Scripts/make-new-script-test: Added.
43892
43893 2011-09-09  Luiz Agostini  <luiz@webkit.org>
43894
43895         Adding myself to the reviewers list.
43896
43897         * Scripts/webkitpy/common/config/committers.py:
43898
43899 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
43900
43901         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
43902         https://bugs.webkit.org/show_bug.cgi?id=67855
43903
43904         Reviewed by Dirk Pranke.
43905
43906         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
43907         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
43908
43909         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
43910
43911         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
43912
43913 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
43914
43915         Add myself to committers.py
43916         https://bugs.webkit.org/show_bug.cgi?id=67853
43917
43918         Reviewed by Darin Adler.
43919
43920         * Scripts/webkitpy/common/config/committers.py:
43921
43922 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
43923
43924         [Qt] Remove common.pri
43925         https://bugs.webkit.org/show_bug.cgi?id=67814
43926
43927         Reviewed by Andreas Kling.
43928
43929         * Tools.pro:
43930
43931 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
43932
43933         [NRWT] the nrwt check httpd with --no-http option
43934         https://bugs.webkit.org/show_bug.cgi?id=67835
43935
43936         Reviewed by Tony Chang.
43937
43938         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43939         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
43940
43941 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
43942
43943         [chromium] Implement DRT support for Android.
43944         https://bugs.webkit.org/show_bug.cgi?id=67590
43945
43946         Reviewed by Tony Chang.
43947
43948         Add 2 mechanism to make DRT interaction more robust on Android:
43949         - Send 'QUIT' to DRT to make it stop.
43950         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
43951         input commands before it starts.
43952         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
43953         and <clocale> for 'LC_ALL' to compile on Android.
43954
43955         Also change to use sigaction instead of signal for TestShellGtk.cpp,
43956         as signal() man page recommends using sigaction().
43957
43958         * DumpRenderTree/DumpRenderTree.gypi:
43959         * DumpRenderTree/chromium/DumpRenderTree.cpp:
43960         (main):
43961         * DumpRenderTree/chromium/LayoutTestController.cpp:
43962         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
43963         (AlarmHandler):
43964         (TestShell::waitTestFinished):
43965         (platformInit):
43966         (openStartupDialog):
43967         (checkLayoutTestSystemDependencies):
43968         * DumpRenderTree/chromium/TestShellGtk.cpp:
43969         (AlarmHandler):
43970         (TestShell::waitTestFinished):
43971
43972 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
43973
43974         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
43975
43976         * waf/build/settings.py:
43977
43978 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
43979
43980         Unreviewed, rolling out r94851.
43981         http://trac.webkit.org/changeset/94851
43982         https://bugs.webkit.org/show_bug.cgi?id=67847
43983
43984         It broke a webkitpy test (Requested by ossy on #webkit).
43985
43986         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43987
43988 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
43989
43990         [NRWT] the nrwt check httpd with --no-http option
43991         https://bugs.webkit.org/show_bug.cgi?id=67835
43992
43993         Reviewed by Csaba Osztrogonác.
43994
43995         * Scripts/webkitpy/layout_tests/controllers/manager.py:
43996
43997 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
43998
43999         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
44000         https://bugs.webkit.org/show_bug.cgi?id=67794
44001         <rdar://problem/9892024>
44002
44003         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
44004
44005         Reviewed by Brady Eidson.
44006
44007         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
44008         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
44009         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
44010         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
44011             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
44012             didPerformServerRedirect.
44013
44014         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
44015         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
44016             our InjectedBundleTest.
44017         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
44018             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
44019             the request.
44020         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
44021
44022         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
44023
44024         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
44025         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
44026         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
44027         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
44028
44029 2011-09-08  David Levin  <levin@chromium.org>
44030
44031         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
44032         https://bugs.webkit.org/show_bug.cgi?id=67797
44033
44034         Reviewed by Eric Seidel.
44035
44036         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
44037         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
44038
44039 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
44040
44041         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
44042         https://bugs.webkit.org/show_bug.cgi?id=67723
44043
44044         Reviewed by Adam Barth.
44045
44046         * DumpRenderTree/chromium/EventSender.h:
44047         * DumpRenderTree/chromium/LayoutTestController.cpp:
44048         (LayoutTestController::LayoutTestController):
44049         (LayoutTestController::enableFixedLayoutMode):
44050         (LayoutTestController::setFixedLayoutSize):
44051         * DumpRenderTree/chromium/LayoutTestController.h:
44052
44053 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
44054
44055         Add standalone script that filters the output of build-webkit to be more human-readable
44056         https://bugs.webkit.org/show_bug.cgi?id=44081
44057
44058         Reviewed by Daniel Bates.
44059
44060         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
44061         a build script (e.g. build-webkit) and it spits out a prettier version.
44062         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
44063         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
44064
44065 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
44066
44067         Add myself to committers.py
44068         https://bugs.webkit.org/show_bug.cgi?id=67696
44069
44070         Reviewed by Kent Tamura.
44071
44072         * Scripts/webkitpy/common/config/committers.py:
44073
44074 2011-09-07  Adam Barth  <abarth@webkit.org>
44075
44076         rebaseline button in garden-o-matic details view should work
44077         https://bugs.webkit.org/show_bug.cgi?id=67738
44078
44079         Reviewed by Dimitri Glazkov.
44080
44081         This patch wires up the rebaseline button in garden-o-matic results
44082         details view.  The button is current per-test, so there isn't a way to
44083         rebaseline individual bots.  This is a place to start.  If we decide we
44084         want per-bot rebaselining, we'll need to think of some better UI.
44085
44086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
44088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
44089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
44090
44091 2011-09-07  Eric Seidel  <eric@webkit.org>
44092
44093         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
44094         https://bugs.webkit.org/show_bug.cgi?id=67737
44095
44096         Reviewed by Adam Barth.
44097
44098         I got a little over-eager when deprecating host.port_factory in the previous commit.
44099         Turns out that Host.port_factory was already the "modern" port/factory.py
44100         it was just the Module object.  I un-deprecated the variable, and changed it from
44101         being the module to being an actual PortFactory, passing it a host object.
44102         I also taught PortFactory how to set user/executive/filesystem in the kwargs
44103         when instantiating a new Port object.
44104         This magically fixed the test_rebaseline test, since its now no longer talking
44105         to the real filesystem.
44106
44107         * Scripts/webkitpy/common/host.py:
44108         * Scripts/webkitpy/layout_tests/port/factory.py:
44109         * Scripts/webkitpy/tool/commands/queries.py:
44110         * Scripts/webkitpy/tool/mocktool.py:
44111
44112 2011-09-07  Eric Seidel  <eric@webkit.org>
44113
44114         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
44115         https://bugs.webkit.org/show_bug.cgi?id=67734
44116
44117         Reviewed by Adam Barth.
44118
44119         Right now every place that creates a Port object has to be very careful
44120         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
44121         The correct fix is for port/factory.py (which creates most port objects)
44122         to know how to pass these in automatically.  However, currently all port/factory.py
44123         functions are free functions instead of being on an object.  This patch
44124         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
44125
44126         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
44127         pass along the proper scm/user/filesystem to the Port object.
44128
44129         * Scripts/webkitpy/common/host.py:
44130         * Scripts/webkitpy/layout_tests/port/factory.py:
44131         * Scripts/webkitpy/tool/commands/queries.py:
44132         * Scripts/webkitpy/tool/mocktool.py:
44133
44134 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
44135
44136         Unreviewed, rolling out r94441.
44137         http://trac.webkit.org/changeset/94441
44138         https://bugs.webkit.org/show_bug.cgi?id=67731
44139
44140         "MacEWSes are backed up due to new machines not able to reach
44141         git.webkit.org.  Disabling tests for now" (Requested by
44142         eseidel2 on #webkit).
44143
44144         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
44145
44146 2011-09-07  Elliot Poger  <epoger@google.com>
44147
44148         filter test_expectations properly for chromium-mac vs chromium-cg-mac
44149         https://bugs.webkit.org/show_bug.cgi?id=67324
44150
44151         Reviewed by Dirk Pranke.
44152
44153         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
44154         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
44155         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
44156         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
44157         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
44158
44159 2011-09-07  Eric Boren  <borenet@gmail.com>
44160
44161         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
44162         https://bugs.webkit.org/show_bug.cgi?id=66800
44163
44164         Reviewed by Darin Fisher.
44165
44166         * DumpRenderTree/chromium/EventSender.cpp:
44167         (EventSender::sendCurrentTouchEvent):
44168
44169 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
44170
44171         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
44172         https://bugs.webkit.org/show_bug.cgi?id=67254
44173
44174         Reviewed by Csaba Osztrogonác.
44175
44176         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
44177         derived from the running location of DumpRenderTree binary.
44178
44179         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
44180         (LayoutTestController::pathToLocalResource):
44181         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
44182
44183 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
44184
44185         REGRESSION(r94288) build-webkit doesn't work on Symbian
44186         https://bugs.webkit.org/show_bug.cgi?id=67706
44187
44188         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
44189         (buildQMakeProject):
44190
44191 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
44192
44193         REGRESSION(r94288) build-webkit doesn't work on Windows
44194         https://bugs.webkit.org/show_bug.cgi?id=67646
44195
44196         Roll back r94655 with a small fix.
44197
44198         * Scripts/webkitdirs.pm:
44199         (buildQMakeProject):
44200
44201 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
44202
44203         Unreviewed, rolling out r94635.
44204         http://trac.webkit.org/changeset/94635
44205         https://bugs.webkit.org/show_bug.cgi?id=67704
44206
44207         Linux Touch build is failing to compile this change.
44208         (Requested by loislo on #webkit).
44209
44210         * DumpRenderTree/chromium/EventSender.cpp:
44211         (EventSender::sendCurrentTouchEvent):
44212
44213 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
44214
44215         Unreviewed, rolling out r94655.
44216         http://trac.webkit.org/changeset/94655
44217         https://bugs.webkit.org/show_bug.cgi?id=67703
44218
44219         It broke Leopard debug bot (Requested by ossy on #webkit).
44220
44221         * Scripts/webkitdirs.pm:
44222
44223 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
44224
44225         REGRESSION(r94288) build-webkit doesn't work on Windows
44226         https://bugs.webkit.org/show_bug.cgi?id=67646
44227
44228         Reviewed by Csaba Osztrogonác.
44229
44230         * Scripts/webkitdirs.pm:
44231
44232 2011-09-06  Eric Boren  <borenet@gmail.com>
44233
44234         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
44235         https://bugs.webkit.org/show_bug.cgi?id=66800
44236
44237         Reviewed by Darin Fisher.
44238
44239         * DumpRenderTree/chromium/EventSender.cpp:
44240         (EventSender::sendCurrentTouchEvent):
44241
44242 2011-09-06  Adam Barth  <abarth@webkit.org>
44243
44244         garden-o-matic details view should having working rebaseline and next/previous buttons
44245         https://bugs.webkit.org/show_bug.cgi?id=67659
44246
44247         Reviewed by Dimitri Glazkov.
44248
44249         This patch wires up basic back/forward buttons that let you traverse
44250         through the results we're examining in the details view.  This ended up
44251         being more code than I expected, but I wanted to keep all the state
44252         information in the DOM itself.
44253
44254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
44255         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
44256         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
44257
44258 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
44259
44260         fix MockFileSystem.glob(), refactor filesystem tests
44261         https://bugs.webkit.org/show_bug.cgi?id=67462
44262
44263         Reviewed by Eric Seidel.
44264
44265         In debugging why my proposed change for MockFileSystem.glob()
44266         in bug 66228 didn't work, I stumbled across two real bugs
44267         that cancelled each other out for the unit tests. I fixed those
44268         (glob shouldn't recurse into subdirs, and we weren't populating
44269         self.dirs from self.files properly).
44270
44271         I have also created a "mixin" class for tests that can be shared
44272         between the real filesystem and the mock filesystem - MockFileSystem
44273         is being used enough it needs its own tests.
44274
44275         * Scripts/webkitpy/common/system/filesystem_mock.py:
44276         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
44277         * Scripts/webkitpy/common/system/filesystem_unittest.py:
44278
44279 2011-09-06  Anders Carlsson  <andersca@apple.com>
44280
44281         Move NPAPI headers in bridge to plugins
44282         https://bugs.webkit.org/show_bug.cgi?id=67661
44283
44284         Update forwarding headers.
44285
44286         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
44287         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
44288
44289 2011-09-06  Tony Chang  <tony@chromium.org>
44290
44291         [chromium] Check in 'build' for compiled binaries first
44292         https://bugs.webkit.org/show_bug.cgi?id=67549
44293
44294         Reviewed by Dirk Pranke.
44295
44296         I'm working on moving the windows build output to a common location
44297         rather than relative to the sln file.  Because of that, we need to
44298         check those build locations first for DumpRenderTree.exe.
44299
44300         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
44301
44302 2011-09-06  Adam Barth  <abarth@webkit.org>
44303
44304         Use a hierarchial structure for the garden-o-matic results view
44305         https://bugs.webkit.org/show_bug.cgi?id=67620
44306
44307         Reviewed by Dimitri Glazkov.
44308
44309         This patch re-organizes the results view to use a hierachial structure
44310         for selection.  At the top-level are sections for each test.  Expanding
44311         the test section shows a tab selector for builders.
44312
44313         This structure prepares us for wiring up various actions to this view.
44314
44315         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44316         (.):
44317         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
44318         ():
44319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
44320         (.):
44321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
44322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
44323         (.results-view>.toolbar):
44324         (.results-view>.toolbar ul.actions):
44325         (.results-view>.toolbar ul.actions li):
44326         (.results-grid table):
44327         (.results-grid table td, .results-view table th):
44328         (.results-grid table th):
44329         (.results-grid .text-result):
44330         (.results-grid .image-result):
44331
44332 2011-09-06  Adam Barth  <abarth@webkit.org>
44333
44334         garden-o-matic's base.probe generates spam in the JavaScript console
44335         https://bugs.webkit.org/show_bug.cgi?id=67622
44336
44337         Reviewed by Dimitri Glazkov.
44338
44339         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
44340         instead of HTMLScriptElement to test whether results exist.  This
44341         reduces the console.log spam and saves bandwidth because we can use a
44342         HEAD request instead of a GET request.
44343
44344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
44345
44346 2011-09-05  Adam Barth  <abarth@webkit.org>
44347
44348         Add a tab to garden-o-matic for viewing expected failures
44349         https://bugs.webkit.org/show_bug.cgi?id=67619
44350
44351         Reviewed by Dimitri Glazkov.
44352
44353         This patch adds a basic tab to garden-o-matic that shows all the tests
44354         failing on the bots, including the expected failures.  This patch
44355         mostly involves refactoring existing classes to allow new subclasses.
44356
44357         This view is useful for when gardeners mark tests as expected to fail
44358         and then rebaseline them later.
44359
44360         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44361         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
44362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
44363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
44364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
44365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
44367
44368 2011-09-05  Adam Barth  <abarth@webkit.org>
44369
44370         Fix global variable leak in garden-o-matic
44371         https://bugs.webkit.org/show_bug.cgi?id=67617
44372
44373         Reviewed by Dimitri Glazkov.
44374
44375         Caught by running the unit tests with noglobals turned on.
44376
44377         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
44378
44379 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
44380
44381         [Qt][WK2] Add pixel test support
44382         https://bugs.webkit.org/show_bug.cgi?id=66283
44383
44384         Reviewed by Andreas Kling.
44385
44386         Implemented pixel result generation by reusing the logic
44387         that we have in DumpRenderTree.
44388         * WebKitTestRunner/qt/TestInvocationQt.cpp:
44389         (WTR::dumpImage):
44390         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
44391
44392 2011-09-04  Robin Dunn  <robin@alldunn.com>
44393
44394         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
44395         https://bugs.webkit.org/show_bug.cgi?id=67577
44396
44397         Reviewed by Kevin Ollivier.
44398
44399         * waf/build/settings.py:
44400
44401 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
44402
44403         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
44404
44405         * waf/build/settings.py:
44406
44407 2011-09-03  Dan Bernstein  <mitz@apple.com>
44408
44409         32-bit build fix.
44410
44411         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
44412         (TestWebKitAPI::Util::toSTD):
44413
44414 2011-09-03  Dan Bernstein  <mitz@apple.com>
44415
44416         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
44417         https://bugs.webkit.org/show_bug.cgi?id=67559
44418
44419         Reviewed by Darin Adler.
44420
44421         * DumpRenderTree/mac/DumpRenderTree.mm:
44422         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
44423         the call to it.
44424         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
44425         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
44426         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
44427         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
44428         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
44429         (TestWebKitAPI::Util::toSTD): Added.
44430
44431 2011-09-03  Adam Barth  <abarth@webkit.org>
44432
44433         garden-o-matic results view should have a better results selector
44434         https://bugs.webkit.org/show_bug.cgi?id=67542
44435
44436         Reviewed by Dimitri Glazkov.
44437
44438         This patch adds a basic grid-based results selector to the results
44439         view.  Currently, this grid just shows how the tests fail on the
44440         various bots.  A future patch will let you select which failure to view
44441         and to mark the failures for rebaselining.
44442
44443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
44444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
44445           - Add some more basic functions for manipulating dictionaries.
44446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
44448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
44449
44450 2011-09-03  Adam Barth  <abarth@webkit.org>
44451
44452         garden-o-matic results view should show Actual and Expected results for text failures
44453         https://bugs.webkit.org/show_bug.cgi?id=67536
44454
44455         Reviewed by Eric Seidel.
44456
44457         In the past, we didn't show actual and expected text results (we just
44458         showed the diff) because we didn't have the awesome six-by-two results
44459         grid.  Now that we do, we can move show these results.
44460
44461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
44462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
44463           - Fixed some typos that were preventing these unit tests from running.
44464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
44465         (.):
44466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
44467           - Report -actual.txt and -expected.txt as possible results URLs.
44468
44469 2011-09-03  Adam Barth  <abarth@webkit.org>
44470
44471         garden-o-matic shows "ghost" failures that are already fixed
44472         https://bugs.webkit.org/show_bug.cgi?id=67535
44473
44474         Reviewed by Eric Seidel.
44475
44476         About 10% of writes fail to stick on test-results.appspot.com.  This
44477         patch causes us to fetch the full_results.json blob directly from
44478         build.chromium.org rather than relying upon AppEngine.
44479
44480         Unforuntately, we still need to get historical information from
44481         AppEngine.  That will take several patches to fix becuase I need to
44482         change the bots to write the full_results.json file to the
44483         build-specific directory in addition to the zip file.
44484
44485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
44486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
44487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
44488
44489 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
44490
44491         Unreviewed, rolling out r94458.
44492         http://trac.webkit.org/changeset/94458
44493         https://bugs.webkit.org/show_bug.cgi?id=67558
44494
44495         Caused appcache test to fail on various bots (Requested by
44496         rniwa on #webkit).
44497
44498         * Scripts/webkitpy/layout_tests/port/webkit.py:
44499         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
44500
44501 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
44502
44503         Unreviewed, rolling out r94453.
44504         http://trac.webkit.org/changeset/94453
44505         https://bugs.webkit.org/show_bug.cgi?id=67557
44506
44507         Caused appcache test to fail on various bots (Requested by
44508         rniwa on #webkit).
44509
44510         * Scripts/webkitpy/layout_tests/port/webkit.py:
44511
44512 2011-09-02  Michael Saboff  <msaboff@apple.com>
44513
44514         Add JSC:RegExp functional tests
44515         https://bugs.webkit.org/show_bug.cgi?id=67339
44516
44517         New perl script to build JavaScriptCore and run the RegExp tests.
44518
44519         Reviewed by Gavin Barraclough.
44520
44521         * Scripts/run-regexp-tests: Added.
44522
44523 2011-09-02  Michael Saboff  <msaboff@apple.com>
44524
44525         Add JSC:RegExp functional tests
44526         https://bugs.webkit.org/show_bug.cgi?id=67339
44527
44528         New perl script to build JavaScriptCore and run the RegExp tests.
44529
44530         Reviewed by Gavin Barraclough.
44531
44532         * Scripts/run-regexp-tests: Added.
44533
44534 2011-09-02  Eric Seidel  <eric@webkit.org>
44535
44536         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
44537         https://bugs.webkit.org/show_bug.cgi?id=67530
44538
44539         Unreviewed.  Fixing typo from previous commit.
44540
44541         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
44542         which exercises the code I previously made a typo in.
44543
44544         * Scripts/webkitpy/layout_tests/port/webkit.py:
44545         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
44546
44547 2011-09-02  Eric Seidel  <eric@webkit.org>
44548
44549         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
44550         https://bugs.webkit.org/show_bug.cgi?id=67530
44551
44552         Reviewed by Adam Barth.
44553
44554         No functional change, just reshuffling code.
44555
44556         * Scripts/webkitpy/layout_tests/port/webkit.py:
44557
44558 2011-09-02  Darin Adler  <darin@apple.com>
44559
44560         Added Subversion ignore for .pyc generated files.
44561
44562         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
44563         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
44564         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
44565
44566 2011-09-02  Adam Barth  <abarth@webkit.org>
44567
44568         Enable testing on mac-ews
44569         https://bugs.webkit.org/show_bug.cgi?id=67505
44570
44571         Reviewed by Eric Seidel.
44572
44573         This patch enables testing on the Mac EWS, which should help
44574         contributors not turn the Mac bots red.
44575
44576         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
44577
44578 2011-09-01  Beth Dakin  <bdakin@apple.com>
44579
44580         https://bugs.webkit.org/show_bug.cgi?id=67451
44581         Add a test for going back to a cached page after changing the device scale factor
44582
44583         Reviewed by Adam Roben.
44584
44585         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
44586         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44587         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
44588         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
44589         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
44590         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
44591         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
44592         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
44593         (TestWebKitAPI::TEST_F):
44594
44595         Added new function to WebKitAgnosticTest to goBack. Separated
44596         waitForLoadToFinish() into its own function (instead of being a part of
44597         loadAndWaitUntilFinished()) so that it can be called from goBack as
44598         well. Also added initializeView() so we can set the cache model.
44599         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
44600         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
44601         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
44602         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
44603         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
44604         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
44605         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
44606         (TestWebKitAPI::WebKitAgnosticTest::goBack):
44607         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
44608
44609 2011-09-02  Anders Carlsson  <andersca@apple.com>
44610
44611         Build fix.
44612
44613         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
44614         (PrivateBrowsing::ScriptableObject::pluginTest):
44615
44616 2011-09-02  Anders Carlsson  <andersca@apple.com>
44617
44618         Move private browsing test to a PluginTest subclass
44619         https://bugs.webkit.org/show_bug.cgi?id=67498
44620
44621         Reviewed by Darin Adler.
44622
44623         * DumpRenderTree/DumpRenderTree.gypi:
44624         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
44625         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
44626         (pluginGetProperty):
44627         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
44628         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
44629         (PluginTest::NPP_SetValue):
44630         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
44631         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
44632         (PrivateBrowsing::PrivateBrowsing):
44633         (PrivateBrowsing::privateBrowsingEnabled):
44634         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
44635         (PrivateBrowsing::ScriptableObject::hasProperty):
44636         (PrivateBrowsing::ScriptableObject::getProperty):
44637         (PrivateBrowsing::ScriptableObject::pluginTest):
44638         (PrivateBrowsing::NPP_New):
44639         (PrivateBrowsing::NPP_GetValue):
44640         (PrivateBrowsing::NPP_SetValue):
44641         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
44642         (NPP_New):
44643         (NPP_SetValue):
44644         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
44645         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
44646         * GNUmakefile.am:
44647
44648 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
44649
44650         [Qt] Build dependency problems
44651         https://bugs.webkit.org/show_bug.cgi?id=38054
44652
44653         Trivial fix after r94288.
44654
44655         Rubber-stamped by Andras Becsi.
44656
44657         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
44658         (buildQMakeProject):
44659
44660 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
44661
44662         Remove my old e-mail address and add my new one.
44663
44664         Rubber-stamped by Tor Arne Vestbø.
44665
44666         * Scripts/webkitpy/common/config/committers.py:
44667
44668 2011-09-02  Philippe Normand  <pnormand@igalia.com>
44669
44670         [GTK] run-gtk-tests leaves a zombie Xvfb process
44671         https://bugs.webkit.org/show_bug.cgi?id=67389
44672
44673         Reviewed by Martin Robinson.
44674
44675         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
44676         child process instead of doing shell redirection.
44677
44678 2011-09-01  Mark Rowe  <mrowe@apple.com>
44679
44680         Fix the build by adding some more missing return types.
44681
44682         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
44683         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
44684
44685 2011-09-01  Eric Seidel  <eric@webkit.org>
44686
44687         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
44688         https://bugs.webkit.org/show_bug.cgi?id=66228
44689
44690         Reviewed by Dirk Pranke.
44691
44692         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
44693         The LeaksViewer tool globs for all *-leaks.txt files.
44694         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
44695
44696         In order to test this I had to fix a limitation in our MockFileSystem.glob
44697         method.  However, doing so uncovered a typo and bug in the integration tests.
44698         I've disabled the offending integration tests.
44699
44700         * Scripts/webkitpy/common/system/filesystem_mock.py:
44701         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
44702         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
44703
44704 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
44705
44706         Adds a LayoutTestController method to make it possible to test
44707         starting speech input via an API call.
44708         https://bugs.webkit.org/show_bug.cgi?id=60170
44709
44710         Reviewed by Dimitri Glazkov.
44711
44712         * DumpRenderTree/LayoutTestController.h:
44713         * DumpRenderTree/chromium/LayoutTestController.cpp:
44714         (LayoutTestController::LayoutTestController):
44715         (LayoutTestController::startSpeechInput):
44716         * DumpRenderTree/chromium/LayoutTestController.h:
44717         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
44718         (LayoutTestController::startSpeechInput):
44719         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
44720         (LayoutTestController::startSpeechInput):
44721         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
44722         (LayoutTestController::startSpeechInput):
44723         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
44724         (LayoutTestController::startSpeechInput):
44725         * DumpRenderTree/qt/LayoutTestControllerQt.h:
44726         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
44727         (LayoutTestController::startSpeechInput):
44728         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
44729         (LayoutTestController::startSpeechInput):
44730
44731 2011-09-01  Tim Horton  <hortont424@gmail.com>
44732
44733         Fix TestWebKitAPI build on clang-2.0
44734
44735         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
44736
44737 2011-09-01  Adam Barth  <abarth@webkit.org>
44738
44739         Remove unused "extension" parameter from rebaseline gardeningserver handler
44740         https://bugs.webkit.org/show_bug.cgi?id=67384
44741
44742         Reviewed by James Robinson.
44743
44744         This parameter hasn't done anything in a while.
44745
44746         * Scripts/webkitpy/tool/commands/rebaseline.py:
44747         * Scripts/webkitpy/tool/servers/gardeningserver.py:
44748         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
44749
44750 2011-09-01  Eric Seidel  <eric@webkit.org>
44751
44752         Unreviewed.
44753
44754         Fix a typo in unittests.  Unfortunately fixing it
44755         caused several assertions.  Just disabling the test
44756         instead, since it was providing no value before due to the typo.
44757
44758         * Scripts/webkitpy/layout_tests/port/test.py:
44759
44760 2011-09-01  Adam Barth  <abarth@webkit.org>
44761
44762         Add a "rebaseline" button to the garden-o-matic summary page
44763         https://bugs.webkit.org/show_bug.cgi?id=67382
44764
44765         Reviewed by Dimitri Glazkov.
44766
44767         As much as we might wish folks to not rebaseline entire test groups at
44768         once, the truth is that doing so is a common operation.  Adding a
44769         button for this operation is likely to make folks happy.
44770
44771         This patch also cleans up a bunch of plumbing surrounding failureInfo
44772         objects.
44773
44774         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
44775         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
44776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
44777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
44778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44779         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
44780         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
44781         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
44782         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44783         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
44784
44785 2011-09-01  Adam Barth  <abarth@webkit.org>
44786
44787         garden-o-matic should let the gardener assign blame for a group of test failures
44788         https://bugs.webkit.org/show_bug.cgi?id=67379
44789
44790         Reviewed by Dimitri Glazkov.
44791
44792         If a group of test failures has a large revision range, the gardener
44793         might wish to blame a specific revision for the failure.  Currently,
44794         this only effect of assigning blame in this way is to hide the other
44795         suspect commits.
44796
44797         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
44798         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
44799         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44800
44801 2011-09-01  Adam Barth  <abarth@webkit.org>
44802
44803         Hide garden-o-matic failure table until hover
44804         https://bugs.webkit.org/show_bug.cgi?id=67376
44805
44806         Reviewed by Dimitri Glazkov.
44807
44808         This patch removes the failure table for build failures (because it
44809         does not make sense) and hides the failure table for test groups until
44810         the user hovers over the test failure block, reducing visual noise.
44811
44812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
44814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
44815
44816 2011-09-01  Adam Barth  <abarth@webkit.org>
44817
44818         Switch garden-o-matic from commitData.title to commitData.summary
44819         https://bugs.webkit.org/show_bug.cgi?id=67375
44820
44821         Reviewed by Dimitri Glazkov.
44822
44823         commitData.title is a string provided by Trac, which isn't great in all
44824         cases.  commitData.summary is my attempt to find the most important
44825         one-line summary of the commit.  This patch switches garden-o-matic
44826         over to summary.
44827
44828         Also, this patch tweaks a bunch of CSS to tighten up the summary page
44829         and reduce visual noise.
44830
44831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
44833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
44834
44835 2011-09-01  Adam Barth  <abarth@webkit.org>
44836
44837         Group failing tests in garden-o-matic if there are more than three in a folder
44838         https://bugs.webkit.org/show_bug.cgi?id=67373
44839
44840         Reviewed by Dimitri Glazkov.
44841
44842         Sometimes a failure will cause many tests in a given directory to fail.
44843         When that happens, it's better to list the directory as a single item
44844         (with a count) rather than spamming all the test names.
44845
44846         (This patch also updates a bunch of unit test expected results after my last commit.)
44847
44848         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
44849         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
44850         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
44851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
44852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
44853
44854 2011-09-01  Adam Barth  <abarth@webkit.org>
44855
44856         Lower the visual noise from the failing builders display
44857         https://bugs.webkit.org/show_bug.cgi?id=67369
44858
44859         Reviewed by Dimitri Glazkov.
44860
44861         This patch ensures that the "Building" row in the failing builders
44862         display is always last and dims it by 50% to reduce visual noise.  This
44863         lets the gardener focus on the actual failures.
44864
44865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
44866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
44867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
44868
44869 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
44870
44871         [Qt] Build dependency problems
44872         https://bugs.webkit.org/show_bug.cgi?id=38054
44873
44874         Make clean build after the defines are changed.
44875
44876         Reviewed by Csaba Osztrogonác.
44877
44878         * Scripts/webkitdirs.pm:
44879         (buildQMakeProject):
44880
44881 2011-08-31  Adam Barth  <abarth@webkit.org>
44882
44883         Move DumpRenderTree to WebKitPlatformSupport
44884         https://bugs.webkit.org/show_bug.cgi?id=67331
44885
44886         Reviewed by Darin Fisher.
44887
44888         This patch update DumpRenderTree to account for the WebKitClient =>
44889         WebKitPlatformSupport rename.
44890
44891         * DumpRenderTree/chromium/NotificationPresenter.cpp:
44892         (NotificationPresenter::show):
44893         * DumpRenderTree/chromium/Task.cpp:
44894         (postTask):
44895
44896 2011-08-31  Eric Seidel  <eric@webkit.org>
44897
44898         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
44899         https://bugs.webkit.org/show_bug.cgi?id=67314
44900
44901         Reviewed by Adam Barth.
44902
44903         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
44904         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
44905         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
44906
44907         I also moved a bunch of code into dashboard.css which belonged there.
44908
44909         * QueueStatusServer/handlers/activebots.py: Added.
44910         * QueueStatusServer/main.py:
44911         * QueueStatusServer/stylesheets/dashboard.css:
44912         (.queue_bubble):
44913         (.queue_name):
44914         (.last_heard_from):
44915         (.status_text):
44916         (.alive):
44917         (.behind):
44918         (.dead):
44919         * QueueStatusServer/templates/activebots.html: Added.
44920         * QueueStatusServer/templates/dashboard.html:
44921         * QueueStatusServer/templates/recentstatus.html:
44922
44923 2011-08-31  Oliver Hunt  <oliver@apple.com>
44924
44925         Move CheckedArithmeticOperations.cpp to the intended location
44926
44927         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44928         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
44929
44930 2011-08-31  Elliot Poger  <epoger@google.com>
44931
44932         add unittest to validate the complete set of Chromium configurations
44933         https://bugs.webkit.org/show_bug.cgi?id=67211
44934
44935         Reviewed by Adam Barth.
44936
44937         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
44938
44939 2011-08-31  Nico Weber  <thakis@chromium.org>
44940
44941         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
44942         https://bugs.webkit.org/show_bug.cgi?id=67297
44943
44944         Reviewed by Tony Chang.
44945
44946         Explicitly disable smooth scrolling in chromium's DRT.
44947
44948         * DumpRenderTree/chromium/WebPreferences.cpp:
44949         (WebPreferences::applyTo):
44950
44951 2011-08-31  Oliver Hunt  <oliver@apple.com>
44952
44953         Add Checked<> tests to windows build
44954
44955         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
44956
44957 2011-08-30  Oliver Hunt  <oliver@apple.com>
44958
44959         Add support for checked arithmetic
44960         https://bugs.webkit.org/show_bug.cgi?id=67095
44961
44962         Reviewed by Sam Weinig.
44963
44964         Add test cases for Checked<>
44965
44966         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
44967         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
44968
44969 2011-08-31  Adam Barth  <abarth@webkit.org>
44970
44971         Move summary.html to garden-o-matic.html.
44972
44973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
44974         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
44975         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
44976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
44977
44978 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
44979
44980         [chromium] DRT linux should pass nativeKeyCode to plugins
44981         https://bugs.webkit.org/show_bug.cgi?id=66679
44982
44983         Reviewed by Tony Chang.
44984
44985         * DumpRenderTree/chromium/EventSender.cpp:
44986         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
44987         (simulated) nativeKeyCode for the given input keyboard code.
44988
44989 2011-08-31  Adam Barth  <abarth@webkit.org>
44990
44991         Tighen up UI for garden-o-matic tab strip
44992         https://bugs.webkit.org/show_bug.cgi?id=67266
44993
44994         Reviewed by Dimitri Glazkov.
44995
44996         This patch add CSS to move the tab strip to the edges of the page and
44997         to remove some gratuitous border-radius.
44998
44999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
45000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
45001
45002 2011-08-31  Adam Barth  <abarth@webkit.org>
45003
45004         garden-o-matic results view shouldn't be horrifically ugly
45005         https://bugs.webkit.org/show_bug.cgi?id=67264
45006
45007         Reviewed by Dimitri Glazkov.
45008
45009         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
45010
45011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
45013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
45014
45015 2011-08-31  Adam Barth  <abarth@webkit.org>
45016
45017         garden-o-matic needs a tabstrip
45018         https://bugs.webkit.org/show_bug.cgi?id=67263
45019
45020         Reviewed by Dimitri Glazkov.
45021
45022         This patch adds a basic tabstrip to garden-o-matic.  The results
45023         details view now opens in the "Results" tab, and the user can flip back
45024         and forth between the Summary and the Results tab quickly.  There's
45025         also a stub for a "Commits" tab, which is disabled.
45026
45027         This patch isn't the most beautiful in the world, but it gets the ball
45028         rolling on a multi-modal UI.
45029
45030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
45032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
45033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
45034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
45035
45036 2011-08-31  Ai Makabi  <makabi@google.com>
45037
45038         Extract reference links from reftest test file.
45039         https://bugs.webkit.org/show_bug.cgi?id=66838
45040
45041         Reviewed by Shinichiro Hamaji.
45042
45043         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
45044         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
45045         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
45046
45047 2011-08-03  Philippe Normand  <pnormand@igalia.com>
45048
45049         [webkitpy] missing log import in common/net/resultsjsonparser.py
45050         https://bugs.webkit.org/show_bug.cgi?id=65606
45051
45052         Reviewed by Martin Robinson.
45053
45054         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
45055
45056 2011-08-30  Philippe Normand  <pnormand@igalia.com>
45057
45058         [stylechecker] complains about NULL usage in some gst_structure_ calls
45059         https://bugs.webkit.org/show_bug.cgi?id=67194
45060
45061         Reviewed by Martin Robinson.
45062
45063         Don't warn about NULL in some gst_structure_ calls. 0 can't be
45064         used for these, a proper sentinel is required.
45065
45066         * Scripts/webkitpy/style/checkers/cpp.py:
45067         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
45068
45069 2011-08-30  Adam Barth  <abarth@webkit.org>
45070
45071         Remove old-style UI from garden-o-matic
45072         https://bugs.webkit.org/show_bug.cgi?id=67257
45073
45074         Reviewed by Dimitri Glazkov.
45075
45076         This code is nowhere near as awesome as the new hotness.  Let's remove
45077         it so it doesn't weigh us down.
45078
45079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
45080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
45081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
45082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
45083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
45084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
45085
45086 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
45087
45088         [WebSocket] update pywebsocket to 0.6b5.
45089         https://bugs.webkit.org/show_bug.cgi?id=66924
45090
45091         Reviewed by Kent Tamura.
45092
45093         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
45094         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
45095         0.6b3 or later supports a closing handshake handler and it is useful to
45096         verify client's closing handshake implementation.
45097         0.6b4 supports AbortedByUserException. It is useful to eliminate
45098         unnecessary server warning messages on intended abnormal closures.
45099         0.6b5 supports Python 2.5.1 or Mac 10.5.
45100
45101         * Scripts/webkitpy/thirdparty/__init__.py:
45102         Update download URL and directory path.
45103
45104 2011-08-30  Dan Bernstein  <mitz@apple.com>
45105
45106         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
45107         https://bugs.webkit.org/show_bug.cgi?id=67230
45108
45109         Reviewed by Darin Adler.
45110
45111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
45112         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
45113         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
45114         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
45115         (TestWebKitAPI::TEST):
45116
45117 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
45118
45119         Add MediaSource API to HTMLMediaElement
45120         https://bugs.webkit.org/show_bug.cgi?id=64731
45121
45122         Reviewed by Eric Carlson.
45123
45124         * Scripts/build-webkit:
45125
45126 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
45127
45128         Emit last progress notification before calling dispatchDidFinishLoad
45129         https://bugs.webkit.org/show_bug.cgi?id=28851
45130
45131         Reviewed by Adam Barth.
45132
45133         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
45134         Chromium and GTK ports. The first two were simple changes.
45135
45136         Some refactoring was needed in GTK port to assure that the dumps are emitted
45137         correctly and the processing after the page load finished is in the right place.
45138
45139         To detect the load finished, we use the callback for the "load-status" notifier
45140         signal of the top loading frame. And we use the deprecated "load-finished" signal
45141         for dumping (if enabled) the progress finished expected output.
45142
45143         * DumpRenderTree/LayoutTestController.cpp:
45144         (LayoutTestController::LayoutTestController):
45145         (dumpProgressFinishedCallbackCallback):
45146         (LayoutTestController::staticFunctions):
45147         * DumpRenderTree/LayoutTestController.h:
45148         (LayoutTestController::dumpProgressFinishedCallback):
45149         (LayoutTestController::setDumpProgressFinishedCallback):
45150         * DumpRenderTree/chromium/LayoutTestController.cpp:
45151         (LayoutTestController::LayoutTestController):
45152         (LayoutTestController::dumpProgressFinishedCallback):
45153         (LayoutTestController::reset):
45154         * DumpRenderTree/chromium/LayoutTestController.h:
45155         (LayoutTestController::shouldDumpProgressFinishedCallback):
45156         (LayoutTestController::setShouldDumpProgressFinishedCallback):
45157         * DumpRenderTree/chromium/WebViewHost.cpp:
45158         (WebViewHost::didStopLoading):
45159         * DumpRenderTree/gtk/DumpRenderTree.cpp:
45160         (webViewLoadFinished):
45161         (topLoadingFrameLoadFinished):
45162         (webFrameLoadStatusNotified):
45163         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
45164         (LayoutTestController::reset):
45165         (LayoutTestController::dumpProgressFinishedCallback):
45166         * DumpRenderTree/qt/LayoutTestControllerQt.h:
45167
45168 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
45169
45170         JavaScriptCore does not have a good mechanism for performance
45171         regression testing
45172         https://bugs.webkit.org/show_bug.cgi?id=67177
45173
45174         Reviewed by Darin Adler.
45175
45176         Added a new script, which allows for testing one, two, or more VMs
45177         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
45178         are interleaved at random to minimize systematics.  The results
45179         that bencher prints includes all possible relevant information about
45180         how bencher was invoked.  Bencher can be easily used to measure
45181         performance changes down to fractions of a percent.
45182
45183         Bencher also includes experimental support for running benchmarks in
45184         a DumpRenderTree release build.  This works in SunSpider and V8, but
45185         not yet in Kraken.  Running benchmarks in DumpRenderTree more
45186         closely mimics the performance when running in browser.
45187
45188         * Scripts/bencher: Added.
45189
45190 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
45191
45192         DumpRenderTree should begin each test with an empty cookie store
45193         https://bugs.webkit.org/show_bug.cgi?id=63545
45194         <rdar://problem/5666907>
45195
45196         Reviewed by Darin Adler.
45197
45198         * DumpRenderTree/mac/DumpRenderTree.mm:
45199         (resetDefaultsToConsistentValues):
45200         (setDefaultsToConsistentValuesForTesting):
45201         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
45202         (LayoutTestController::setAlwaysAcceptCookies):
45203         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
45204         (WTR::InjectedBundle::beginTesting):
45205         Use new SPIs to manipulate sessions.
45206
45207 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
45208
45209         Unreviewed, rolling out r94055 and r94057.
45210         http://trac.webkit.org/changeset/94055
45211         http://trac.webkit.org/changeset/94057
45212         https://bugs.webkit.org/show_bug.cgi?id=67191
45213
45214         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
45215
45216         * Scripts/webkitpy/thirdparty/__init__.py:
45217
45218 2011-08-30  Adam Barth  <abarth@webkit.org>
45219
45220         Chromium Android should not be a core builder
45221         https://bugs.webkit.org/show_bug.cgi?id=67184
45222
45223         Reviewed by Ryosuke Niwa.
45224
45225         This bot hasn't been consistently green yet because it has never actually run!
45226
45227         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
45228         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
45229
45230 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
45231
45232         [WebSocket] update pywebsocket to 0.6b4.
45233         https://bugs.webkit.org/show_bug.cgi?id=66924
45234
45235         Reviewed by Kent Tamura.
45236
45237         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
45238         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
45239         0.6b3 or later supports a closing handshake handler and it is useful to
45240         verify client's closing handshake implementation.
45241         0.6b4 supports AbortedByUserException. It is useful to eliminate
45242         unnecessary server warning messages on intended abnormal closures.
45243
45244         * Scripts/webkitpy/thirdparty/__init__.py:
45245         Update download URL and directory path.
45246
45247 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
45248
45249         sheriffbot "usage" help statements are wrong
45250         https://bugs.webkit.org/show_bug.cgi?id=67170
45251
45252         Reviewed by Adam Barth.
45253
45254         * Scripts/webkitpy/tool/bot/irc_command.py:
45255         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
45256         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
45257
45258 2011-08-29  Adam Barth  <abarth@webkit.org>
45259
45260         Add support for chomium-mac (non-CoreGraphics) baselines
45261         https://bugs.webkit.org/show_bug.cgi?id=67163
45262
45263         Reviewed by Eric Seidel.
45264
45265         This patch teaches the non-CG chromium-mac bots to look at non-CG
45266         baselines.  However, the patch still leaves CG as the default set of
45267         baselines.
45268
45269         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
45270         * Scripts/webkitpy/common/config/build.py:
45271         * Scripts/webkitpy/common/config/build_unittest.py:
45272         * Scripts/webkitpy/layout_tests/port/builders.py:
45273         * Scripts/webkitpy/layout_tests/port/chromium.py:
45274         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
45275         * Scripts/webkitpy/layout_tests/port/factory.py:
45276         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
45277         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
45278         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
45279         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
45280
45281 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
45282
45283         Small fix in chromium port of new-run-webkit-tests.
45284         https://bugs.webkit.org/show_bug.cgi?id=67078
45285
45286         Reviewed by Dirk Pranke.
45287
45288         * Scripts/webkitpy/layout_tests/port/chromium.py:
45289
45290 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
45291
45292         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
45293         r93999.
45294         http://trac.webkit.org/changeset/93987
45295         http://trac.webkit.org/changeset/93992
45296         http://trac.webkit.org/changeset/93995
45297         http://trac.webkit.org/changeset/93998
45298         http://trac.webkit.org/changeset/93999
45299         https://bugs.webkit.org/show_bug.cgi?id=67147
45300
45301         Many failing tests (Requested by ap on #webkit).
45302
45303         * DumpRenderTree/mac/DumpRenderTree.mm:
45304         (setDefaultsToConsistentValuesForTesting):
45305         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
45306         (WTR::InjectedBundle::beginTesting):
45307
45308 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
45309
45310         DumpRenderTree should begin each test with an empty cookie store
45311         https://bugs.webkit.org/show_bug.cgi?id=63545
45312         <rdar://problem/5666907>
45313
45314         Reviewed by Darin Adler.
45315
45316         * DumpRenderTree/mac/DumpRenderTree.mm:
45317         (setDefaultsToConsistentValuesForTesting):
45318         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
45319         (WTR::InjectedBundle::beginTesting):
45320         Tell WebCore to use a temporary session, starting with a clean cookie store.
45321
45322 2011-08-23  Chris Marrin  <cmarrin@apple.com>
45323
45324         [mac] requestAnimationFrame support for mac port
45325         https://bugs.webkit.org/show_bug.cgi?id=59146
45326
45327         Reviewed by Simon Fraser.
45328
45329         Add support for request-animation-callback flag
45330
45331         * Scripts/build-webkit:
45332
45333 2011-08-27  Peter Beverloo  <peter@chromium.org>
45334
45335         Add a build bot for Chromium with OS(ANDROID)
45336         https://bugs.webkit.org/show_bug.cgi?id=66687
45337
45338         Reviewed by Adam Barth.
45339
45340         * BuildSlaveSupport/build.webkit.org-config/config.json:
45341
45342 2011-08-27  Peter Beverloo  <peter@chromium.org>
45343
45344         Update the master build bot configuration script to properly
45345         deal with the --chromium-android switch.
45346         https://bugs.webkit.org/show_bug.cgi?id=66687
45347
45348         The --chromium-android switch is needed when running
45349         update-webkit-chromium and build-webkit, as it'll tell the
45350         scripts to pull in the right dependencies and cross-compile
45351         WebKit using the Android NDK.
45352
45353         Reviewed by Adam Barth.
45354
45355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
45356
45357 2011-08-27  Peter Beverloo  <peter@chromium.org>
45358
45359         Teach the update and build scripts how to handle dependencies
45360         and cross-compiling rules for the Chromium port on OS(ANDROID).
45361         https://bugs.webkit.org/show_bug.cgi?id=66687
45362
45363         Reviewed by Adam Barth.
45364
45365         * Scripts/build-webkit:
45366         * Scripts/update-webkit:
45367         * Scripts/update-webkit-chromium:
45368         * Scripts/webkitdirs.pm:
45369         (argumentsForConfiguration):
45370         (isChromium):
45371         (isChromiumAndroid):
45372         (determineIsChromiumAndroid):
45373         (buildChromium):
45374
45375 2011-08-26  Adam Barth  <abarth@webkit.org>
45376
45377         garden-o-matic should let me know that I need to run the local server
45378         https://bugs.webkit.org/show_bug.cgi?id=66985
45379
45380         Reviewed by Dimitri Glazkov.
45381
45382         The patch triggers an alert dialog whenever the user tries to use a
45383         feature that requires the local server.
45384
45385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
45386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
45387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
45388
45389 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
45390
45391         garden-o-matic summary view should have pretty commit data information.
45392         https://bugs.webkit.org/show_bug.cgi?id=67069
45393
45394         Reviewed by Adam Barth.
45395
45396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
45397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
45398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
45399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
45400
45401 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
45402
45403         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
45404         https://bugs.webkit.org/show_bug.cgi?id=67066
45405
45406         Reviewed by Adam Barth.
45407
45408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
45409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
45410
45411 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
45412
45413         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
45414         https://bugs.webkit.org/show_bug.cgi?id=67041
45415
45416         Reviewed by Martin Robinson.
45417
45418         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
45419         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
45420         when the GTK+ port was being built.
45421
45422         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
45423
45424 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
45425
45426         Clean up and line up layout in garden-o-matic summary view.
45427         https://bugs.webkit.org/show_bug.cgi?id=67057
45428
45429         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
45430         2) Rearranged DOM structure a bit to accommodate recent changes;
45431         3) Added minimal CSS to line things up.
45432
45433         Reviewed by Adam Barth.
45434
45435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
45436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
45437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
45438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
45439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
45440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
45441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
45442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
45443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
45444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
45445
45446 2011-08-26  Alice Liu  <alice.liu@apple.com>
45447
45448         https://bugs.webkit.org/show_bug.cgi?id=66823
45449         Add the request info to the WebPageProxy::CreateNewPage message
45450
45451         Reviewed by Anders Carlsson.
45452
45453         Update function declarations with additional parameter:
45454         * MiniBrowser/gtk/BrowserWindow.c:
45455         (createNewPage):
45456         * MiniBrowser/mac/BrowserWindowController.m:
45457         (createNewPage):
45458         * MiniBrowser/win/BrowserView.cpp:
45459         (createNewPage):
45460         * WebKitTestRunner/TestController.cpp:
45461         (WTR::TestController::createOtherPage):
45462         * WebKitTestRunner/TestController.h:
45463
45464 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
45465
45466         Make show-pretty-diff work on linux
45467         https://bugs.webkit.org/show_bug.cgi?id=67017
45468
45469         Reviewed by Adam Barth.
45470
45471         * Scripts/show-pretty-diff:
45472
45473 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
45474
45475         Reorganize garden-o-matic CSS files to match JS-built views.
45476         https://bugs.webkit.org/show_bug.cgi?id=66998
45477
45478         Reviewed by Adam Barth.
45479
45480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
45481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
45482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
45483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
45484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
45485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
45486
45487 2011-08-25  Adam Barth  <abarth@webkit.org>
45488
45489         garden-o-matic should be able to roll out patches
45490         https://bugs.webkit.org/show_bug.cgi?id=66982
45491
45492         Reviewed by Dimitri Glazkov.
45493
45494         This patch just wires the rollout event through the controller to the
45495         local server, which is already set up to perform rollouts.
45496
45497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
45498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
45500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
45501
45502 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
45503
45504         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
45505         https://bugs.webkit.org/show_bug.cgi?id=66951
45506
45507         Reviewed by Andreas Kling.
45508
45509         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
45510         width and height one by one and setWidth cause geometryChange event in QTouchWebView.
45511
45512         * MiniBrowser/qt/BrowserView.cpp:
45513         (BrowserView::resizeEvent):
45514
45515 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
45516
45517         garden-o-matic summary view should provide information on builders still in flight.
45518         https://bugs.webkit.org/show_bug.cgi?id=66992
45519
45520         Reviewed by Adam Barth.
45521
45522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
45523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
45524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
45525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
45526         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
45527
45528 2011-08-25  Adam Barth  <abarth@webkit.org>
45529
45530         webkit-patch rebaseline-expectations don't work when run outside the root
45531         https://bugs.webkit.org/show_bug.cgi?id=66966
45532
45533         Reviewed by Eric Seidel.
45534
45535         Turns out tool.path() used to be relative, which caused problems when
45536         running webkit-patch outside the root directory.  This patch makes it
45537         absolute.  I checked all callers, and they all appear to want this
45538         behavior.
45539
45540         It was unclear to me how to test this change because we only really
45541         have a testing strategy for webkitpy, not for the main script.
45542
45543         * Scripts/webkit-patch:
45544
45545 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
45546
45547         garden-o-matic summary needs a mock view that could be used for working on styling
45548         https://bugs.webkit.org/show_bug.cgi?id=66971
45549
45550         Reviewed by Adam Barth.
45551
45552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
45553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
45554
45555 2011-08-25  Anders Carlsson  <andersca@apple.com>
45556
45557         Return the correct value for NPNVsupportsCarbonBool
45558         https://bugs.webkit.org/show_bug.cgi?id=66964
45559
45560         Add a test.
45561
45562         Reviewed by Adam Roben.
45563
45564         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
45565         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
45566         (SupportsCarbonEventModel::SupportsCarbonEventModel):
45567         (SupportsCarbonEventModel::testConvert):
45568         (SupportsCarbonEventModel::runTest):
45569         (SupportsCarbonEventModel::NPP_New):
45570
45571 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
45572
45573         garden-o-matic summary view should not be broken.
45574
45575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
45576         (table.comparison): Added more specificity.
45577
45578 2011-08-25  Adam Barth  <abarth@webkit.org>
45579
45580         This command has been broken for a while.  This patch updates the
45581         callsite to the new API.
45582
45583         * Scripts/webkitpy/tool/commands/rebaseline.py:
45584
45585 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
45586
45587         garden-o-matic needs a way to report where and how tests are failing in the summary view.
45588         https://bugs.webkit.org/show_bug.cgi?id=66955
45589
45590         Introduce FailureGrid, your one-stop failure-indicating destination.
45591
45592         Reviewed by Adam Barth.
45593
45594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
45595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
45596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
45597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
45598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
45599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
45600
45601 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
45602
45603         Add myself to the committers list
45604         https://bugs.webkit.org/show_bug.cgi?id=66941
45605
45606         Reviewed by Andreas Kling.
45607
45608         * Scripts/webkitpy/common/config/committers.py:
45609
45610 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
45611
45612         Unreviewed, rolling out r93767.
45613         http://trac.webkit.org/changeset/93767
45614         https://bugs.webkit.org/show_bug.cgi?id=66931
45615
45616         Broke Qt bot. (Requested by yutak on #webkit).
45617
45618         * Scripts/webkitpy/thirdparty/__init__.py:
45619
45620 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
45621
45622         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
45623         https://bugs.webkit.org/show_bug.cgi?id=66924
45624
45625         Reviewed by Kent Tamura.
45626
45627         * Scripts/webkitpy/thirdparty/__init__.py:
45628
45629 2011-08-24  Adam Barth  <abarth@webkit.org>
45630
45631         The user can't close the details view in garden-o-matic
45632         https://bugs.webkit.org/show_bug.cgi?id=66911
45633
45634         Reviewed by Dimitri Glazkov.
45635
45636         In addition to adding a close button, this patch changes the test
45637         selector to use a <select> element and refactors the test selector to
45638         share code with the builder selector.
45639
45640         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45641         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
45642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
45643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
45644
45645 2011-08-24  James Robinson  <jamesr@chromium.org>
45646
45647         [chromium] Stacktrace not in test output when a test crashes
45648         https://bugs.webkit.org/show_bug.cgi?id=66806
45649
45650         Reviewed by Dirk Pranke.
45651
45652         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
45653         trace.
45654
45655         * Scripts/webkitpy/layout_tests/port/chromium.py:
45656
45657 2011-08-24  Adam Barth  <abarth@webkit.org>
45658
45659         Remove empty directory.
45660
45661         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
45662
45663 2011-08-24  Adam Barth  <abarth@webkit.org>
45664
45665         Finish writing up details-view in garden-o-matic
45666         https://bugs.webkit.org/show_bug.cgi?id=66891
45667
45668         Reviewed by Dimitri Glazkov.
45669
45670         This patch mostly just copies a bunch of CSS from main.css to
45671         summary.css.  Presumably we'll delete main.css soon.
45672
45673         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
45675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
45676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
45677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
45678
45679 2011-08-24  James Robinson  <jamesr@chromium.org>
45680
45681         Some compositing LayoutTests flakily crashing on Mac 10.6
45682         https://bugs.webkit.org/show_bug.cgi?id=66740
45683
45684         Reviewed by Adam Barth.
45685
45686         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
45687         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
45688         chromium configuration.
45689
45690         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
45691         (NPP_Destroy):
45692
45693 2011-08-24  Anton D'Auria  <adauria@apple.com>
45694
45695         No review necessary.
45696
45697         Adding myself to list of committers.
45698
45699         * Scripts/webkitpy/common/config/committers.py:
45700
45701 2011-08-24  Avi Drissman  <avi@google.com>
45702
45703         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
45704         https://bugs.webkit.org/show_bug.cgi?id=66875
45705
45706         Reviewed by James Robinson.
45707
45708         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
45709         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
45710
45711 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
45712
45713         Make notifications appear in time order again.
45714         https://bugs.webkit.org/show_bug.cgi?id=66815
45715
45716         Reviewed by Adam Barth.
45717
45718         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
45719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
45720
45721 2011-08-23  James Robinson  <jamesr@chromium.org>
45722
45723         [chromium] Need a way to test lost compositor context recovery
45724         https://bugs.webkit.org/show_bug.cgi?id=66820
45725
45726         Reviewed by Kenneth Russell.
45727
45728         Exposes a LayoutTestController interface in chromium to simulate a
45729         lost compositor context.
45730
45731         * DumpRenderTree/chromium/LayoutTestController.cpp:
45732         (LayoutTestController::LayoutTestController):
45733         (LayoutTestController::loseCompositorContext):
45734         * DumpRenderTree/chromium/LayoutTestController.h:
45735
45736 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
45737
45738         Change garden-o-matic frontend builder array to be a configuration map.
45739         https://bugs.webkit.org/show_bug.cgi?id=66816
45740
45741         Reviewed by Adam Barth.
45742
45743         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
45744         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
45745         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
45746         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
45747         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
45748
45749 2011-08-23  Cary Clark  <caryclark@google.com>
45750
45751         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
45752         https://bugs.webkit.org/show_bug.cgi?id=66803
45753
45754         This fixes the WebKit Canaries, in particular avoids a crash on tests
45755         like css1/basic/comments.html.
45756
45757         Reviewed by James Robinson.
45758
45759         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
45760         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
45761         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
45762         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
45763         and treated it as if it were a CGContextRef.
45764
45765 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
45766
45767         Fix mergeChangeLogs test on native windows
45768         https://bugs.webkit.org/show_bug.cgi?id=66797
45769
45770         Reviewed by Adam Roben.
45771
45772         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
45773         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
45774
45775         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
45776         (writeTempFile):
45777
45778 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
45779
45780         garden-o-matic relative time is wrong and updates too frequently.
45781         https://bugs.webkit.org/show_bug.cgi?id=66802
45782
45783         Reviewed by Adam Barth.
45784
45785         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
45786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
45787         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
45788
45789 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
45790
45791         Add missing quotes around filenames in mergeChangeLogs
45792         https://bugs.webkit.org/show_bug.cgi?id=66794
45793
45794         Reviewed by Adam Roben.
45795
45796         * Scripts/VCSUtils.pm:
45797         (mergeChangeLogs):
45798
45799 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
45800
45801         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
45802         https://bugs.webkit.org/show_bug.cgi?id=49080
45803
45804         Reviewed by Adam Roben.
45805
45806         Use the string form of pipe open instead (like we do at all other places).
45807
45808         * Scripts/VCSUtils.pm:
45809         (mergeChangeLogs):
45810
45811 2011-08-23  Adam Barth  <abarth@webkit.org>
45812
45813         garden-o-matic summary should be able to examine failures
45814         https://bugs.webkit.org/show_bug.cgi?id=66748
45815
45816         Reviewed by Dimitri Glazkov.
45817
45818         This patch refactors a bunch of code from summary.js to independent
45819         controllers in controllers.js.  This patch also contains the first
45820         iteration of binding the "examine" event to a the behavior showing the
45821         details view for the tests.  There's more work to do here to make this
45822         work properly (and elegantly), but this patch is a start.
45823
45824         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
45825         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
45826         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
45827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
45828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
45829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
45830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
45831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
45832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
45833
45834 2011-08-23  Adam Barth  <abarth@webkit.org>
45835
45836         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
45837         https://bugs.webkit.org/show_bug.cgi?id=66737
45838
45839         Reviewed by Steve Block.
45840
45841         This directory doesn't exist anymore now that the Android port shares
45842         more code with Chromium.
45843
45844         * Scripts/webkitpy/common/config/build.py:
45845
45846 2011-08-22  Eric Seidel  <eric@webkit.org>
45847
45848         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
45849         I won't have ssh access to the bot again for a couple days, so
45850         attempting to fix by changing this script.  If this doesn't
45851         work we'll just live with the it hung for now.
45852
45853         Unreviewed.
45854
45855         * EWSTools/start-queue.sh:
45856
45857 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
45858
45859         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
45860         https://bugs.webkit.org/show_bug.cgi?id=66727
45861
45862         Reviewed by Adam Barth.
45863
45864         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
45865             in which case the serializer treats all expectations as unparsed.
45866         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
45867
45868 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
45869
45870         Update unit test expectations after r93530.
45871
45872         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
45873         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
45874
45875 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
45876
45877         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
45878         https://bugs.webkit.org/show_bug.cgi?id=66705
45879
45880         Reviewed by Adam Barth.
45881
45882         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
45883         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
45884
45885 2011-08-22  James Robinson  <jamesr@chromium.org>
45886
45887         [chromium] Update builder names for chromium gpu bots due to CG switchover
45888         https://bugs.webkit.org/show_bug.cgi?id=66693
45889
45890         Reviewed by Dirk Pranke.
45891
45892         Update the port and builder names for the chromium mac gpu bots to
45893         account for the CG transition.
45894
45895         * Scripts/webkitpy/layout_tests/port/builders.py:
45896
45897 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
45898
45899         fix the GPU bot names on the layout test dashboard
45900         https://bugs.webkit.org/show_bug.cgi?id=66697
45901
45902         Reviewed by Dimitri Glazkov.
45903
45904         * TestResultServer/static-dashboards/builders.js:
45905
45906 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
45907
45908         garden-o-matic's relative time display should be updated regularly.
45909         https://bugs.webkit.org/show_bug.cgi?id=66682
45910
45911         Reviewed by Adam Barth.
45912
45913         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
45914         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
45915         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
45916
45917 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
45918
45919         Pass --makeargs of build-webkit to chromium linux builder
45920         https://bugs.webkit.org/show_bug.cgi?id=66361
45921
45922         Reviewed by Tony Chang.
45923
45924         * Scripts/build-webkit:
45925         * Scripts/webkitdirs.pm:
45926         (buildChromiumMakefile):
45927         (buildChromium):
45928
45929 2011-08-22  Peter Beverloo  <peter@chromium.org>
45930
45931         Add myself to the contributor list.
45932         https://bugs.webkit.org/show_bug.cgi?id=66674
45933
45934         Reviewed by Tony Gentilcore.
45935
45936         * Scripts/webkitpy/common/config/committers.py:
45937
45938 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
45939
45940         [Qt] ImageDiff does not consider --tolerance
45941         https://bugs.webkit.org/show_bug.cgi?id=66299
45942
45943         Reviewed by Csaba Osztrogonác.
45944
45945         * DumpRenderTree/qt/ImageDiff.cpp:
45946         (main):
45947
45948 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
45949
45950         Update contributor list.
45951
45952         Reviewed by Zoltan Herczeg.
45953
45954         * Scripts/webkitpy/common/config/committers.py:
45955
45956 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
45957
45958         [ORWT] Fix --reset-results --add-platform-exceptions combo
45959         https://bugs.webkit.org/show_bug.cgi?id=65464
45960
45961         Reviewed by Csaba Osztrogonác.
45962
45963         * Scripts/old-run-webkit-tests:
45964
45965 2011-08-20  Adam Barth  <abarth@webkit.org>
45966
45967         garden-o-matic summary.html should have UI for examining failures
45968         https://bugs.webkit.org/show_bug.cgi?id=66625
45969
45970         Reviewed by Dimitri Glazkov.
45971
45972         This patch introduces the notion of UI actions and converts our
45973         existing manual <button> manipulation with this new abstraction.  The
45974         patch also adds an Examine button to failure notifications.  In a
45975         future patch, I'll add a controller that wires this button up to
45976         something useful.
45977
45978         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
45979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
45980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
45981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
45982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
45983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
45984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
45985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
45986
45987 2011-08-20  Adam Barth  <abarth@webkit.org>
45988
45989         garden-o-matic summary page should indiciate compile failures
45990         https://bugs.webkit.org/show_bug.cgi?id=66624
45991
45992         Reviewed by Dimitri Glazkov.
45993
45994         This patch creates a notification-based UI for build failures.  The new
45995         UI displays the same information that used to be displayed in the
45996         infobar.  There's lots of room for improvement in surfacing more
45997         information, but this is a start.
45998
45999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
46000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
46001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
46002
46003 2011-08-19  James Robinson  <jamesr@chromium.org>
46004
46005         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
46006         https://bugs.webkit.org/show_bug.cgi?id=66606
46007
46008         Reviewed by Dirk Pranke.
46009
46010         The chromium GPU configuration does not (currently) contain any tests
46011         incompatible with --experimental-fully-parallel, and this flag is a
46012         significan speedup because of the directory canvas/philip/tests which
46013         contains 802 tests in the same directory. Setting this option by
46014         default on this configuration is a 2x speed in release, 44s to 22s,
46015         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
46016
46017         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
46018         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
46019         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
46020
46021 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
46022
46023         Unreviewed, rolling out r93426.
46024         http://trac.webkit.org/changeset/93426
46025         https://bugs.webkit.org/show_bug.cgi?id=66607
46026
46027         Broke the Mac build by not building gtest.framework anymore
46028         (Requested by andersca on #webkit).
46029
46030         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
46031
46032 2011-08-19  James Robinson  <jamesr@chromium.org>
46033
46034         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
46035         https://bugs.webkit.org/show_bug.cgi?id=66603
46036
46037         Reviewed by Dirk Pranke.
46038
46039         The various ChromiumGpu ports should use the same child worker
46040         selection logic as other ports so they can run with full
46041         parallelization on multicore systems.
46042
46043         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
46044         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
46045
46046 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
46047
46048         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
46049         https://bugs.webkit.org/show_bug.cgi?id=66570
46050
46051         Reviewed by Mihai Parparita.
46052
46053         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
46054         (WebThemeControlDRTWin::draw):
46055         (WebThemeControlDRTWin::drawTextField):
46056         (WebThemeControlDRTWin::drawProgressBar):
46057         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
46058
46059 2011-08-18  Dmitry Lomov  <dslomov@google.com>
46060
46061         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
46062         https://bugs.webkit.org/show_bug.cgi?id=66521
46063
46064         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
46065
46066         Reviewed by David Levin.
46067
46068         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
46069
46070 2011-08-19  Adam Roben  <aroben@apple.com>
46071
46072         Add project file changes I left out in r93417
46073
46074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
46075
46076 2011-08-19  Adam Roben  <aroben@apple.com>
46077
46078         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
46079
46080         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
46081         NSScreen
46082
46083         Reviewed by Anders Carlsson.
46084
46085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
46086
46087         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
46088         (-[SimpleObject setValue:]): Original implementation.
46089
46090         (TestWebKitAPI::setValue2):
46091         (TestWebKitAPI::setValue3):
46092         Swizzled implementations.
46093
46094         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
46095         instance method.
46096
46097         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
46098         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
46099         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
46100         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
46101
46102 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
46103
46104         Fix _path_to_apache() error reporting
46105         https://bugs.webkit.org/show_bug.cgi?id=66486
46106
46107         Reviewed by Ryosuke Niwa.
46108
46109         * Scripts/webkitpy/layout_tests/port/webkit.py:
46110
46111 2011-08-19  Adam Roben  <aroben@apple.com>
46112
46113         Windows build fix after r93404
46114
46115         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
46116
46117 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
46118
46119         Add leandrogracia to the committers list
46120         https://bugs.webkit.org/show_bug.cgi?id=66552
46121
46122         Also fix line endings in file.
46123
46124         No reviewed required.
46125
46126         * Scripts/webkitpy/common/config/committers.py:
46127
46128 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
46129
46130         Fix compilation issue in WebKitTestRunner
46131         https://bugs.webkit.org/show_bug.cgi?id=66554
46132
46133         Reviewed by Martin Robinson.
46134
46135         * WebKitTestRunner/PixelDumpSupport.cpp:
46136
46137 2011-08-19  Adam Roben  <aroben@apple.com>
46138
46139         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
46140
46141         This will make it easier to write other WebKit-agnostic tests
46142
46143         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
46144         code in other WebKit-agnostic tests
46145
46146         Reviewed by Anders Carlsson.
46147
46148         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
46149
46150         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
46151         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
46152         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
46153         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
46154         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
46155         WebKitAgnosticTest handles for us.
46156         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
46157
46158         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
46159         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
46160         DynamicDeviceScaleFactor::runTest.
46161
46162         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
46163         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
46164         DynamicDeviceScaleFactor.WebKit.
46165         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
46166         DynamicDeviceScaleFactor.WebKit2.
46167
46168 2011-08-19  Adam Roben  <aroben@apple.com>
46169
46170         Clean up #includes in TestWebKitAPI
46171
46172         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
46173
46174         Reviewed by Anders Carlsson.
46175
46176         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
46177         files and WebKit/WebKit.h for ObjC files.
46178
46179         * TestWebKitAPI/InjectedBundleController.cpp:
46180         * TestWebKitAPI/JavaScriptTest.h:
46181         * TestWebKitAPI/PlatformUtilities.h:
46182         * TestWebKitAPI/PlatformWebView.h:
46183         * TestWebKitAPI/Test.h:
46184         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
46185         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
46186         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
46187         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
46188         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
46189         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
46190         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
46191         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
46192         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
46193         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
46194         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
46195         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
46196         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
46197         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
46198         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
46199         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
46200         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
46201         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
46202         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
46203         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
46204         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
46205         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
46206         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
46207         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
46208         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
46209         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
46210         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
46211         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
46212         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
46213         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
46214         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
46215         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
46216         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
46217         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
46218         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
46219         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
46220         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
46221         * TestWebKitAPI/TestsController.cpp:
46222         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
46223         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
46224         #includes since it is no longer a special header.
46225
46226 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
46227
46228         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
46229         https://bugs.webkit.org/show_bug.cgi?id=64886
46230
46231         Temporarily disable the http locking to work around the issue.
46232         I'm not actually sure if this is going to work or improve things
46233         much.
46234
46235         Reviewed by Ryosuke Niwa.
46236
46237         * Scripts/webkitpy/layout_tests/port/mac.py:
46238
46239 2011-08-18  Tony Chang  <tony@chromium.org>
46240
46241         add embedded png checksums to WebKitTestRunner
46242         https://bugs.webkit.org/show_bug.cgi?id=66494
46243
46244         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
46245         some code from DRT and adds it to the WebKitTestRunner.
46246
46247         Reviewed by Darin Adler.
46248
46249         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
46250         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
46251         * WebKitTestRunner/GNUmakefile.am: Add new files
46252         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
46253         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
46254         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
46255         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
46256         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
46257         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
46258         * WebKitTestRunner/cg/TestInvocationCG.cpp:
46259         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
46260         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
46261         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
46262
46263 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
46264
46265         https://bugs.webkit.org/show_bug.cgi?id=47240
46266
46267         Fixed a cygwin path problem in the chromium port of diff_image;
46268         Also made the return values of the diff_image function more consistent.
46269
46270         Reviewed by Dirk Pranke.
46271
46272         * Scripts/webkitpy/layout_tests/port/chromium.py:
46273
46274 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
46275
46276         [GTK] Fix compilation problems with deprecations in gtk+
46277         https://bugs.webkit.org/show_bug.cgi?id=66073
46278
46279         Reviewed by Martin Robinson.
46280
46281         * DumpRenderTree/gtk/DumpRenderTree.cpp:
46282         (main): G_CONST_RETURN was deprecated
46283         * GtkLauncher/main.c:
46284         (createWindow): Added gtk_box_new conditional compilation for
46285         gtk+-3.
46286         * MiniBrowser/gtk/BrowserWindow.c:
46287         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
46288         are just supporting gtk+-3 for WebKit2.
46289
46290 2011-08-18  Anders Carlsson  <andersca@apple.com>
46291
46292         Fix libc++ C++0x build
46293         https://bugs.webkit.org/show_bug.cgi?id=66479
46294
46295         Reviewed by Adam Roben.
46296
46297         Add missing includes.
46298
46299         * DumpRenderTree/LayoutTestController.cpp:
46300         * DumpRenderTree/mac/CheckedMalloc.cpp:
46301
46302 2011-08-18  Adam Roben  <aroben@apple.com>
46303
46304         Test that WebKit updates style when a WebView is moved between differently-scaled windows
46305
46306         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
46307         WebView is moved between windows with different backing scale factors
46308
46309         Reviewed by Anders Carlsson.
46310
46311         * TestWebKitAPI/JavaScriptTest.cpp:
46312         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
46313         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
46314         gtest's built-in error messages.
46315
46316         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
46317         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
46318         those overloads.
46319
46320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
46321
46322         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
46323         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
46324         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
46325         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
46326         (TestWebKitAPI::setPageLoaderClient): Set up the client.
46327         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
46328         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
46329         SyntheticBackingScaleFactorWindow and returns it.
46330         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
46331         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
46332         window, is moved to a differently-scaled window, and is taken out of the window.
46333         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
46334         WebKit1 and WebKit2.
46335         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
46336
46337         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
46338
46339         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
46340         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
46341
46342         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
46343         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
46344         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
46345         initializer.
46346         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
46347
46348         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
46349         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
46350         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
46351
46352 2011-08-18  Dmitry Lomov  <dslomov@google.com>
46353
46354         https://bugs.webkit.org/show_bug.cgi?id=66425
46355         check-webkit-style should detect incorrectly formatted file change descriptions.
46356         Description, if present, should be separated from colon with a space.
46357
46358         Reviewed by David Levin.
46359
46360         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
46361         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
46362
46363 2011-08-18  Adam Barth  <abarth@webkit.org>
46364
46365         webkit-patch pretty-diff should be shown in main help
46366         https://bugs.webkit.org/show_bug.cgi?id=66404
46367
46368         Reviewed by Dimitri Glazkov.
46369
46370         As requested by dglazkov.
46371
46372         * Scripts/webkitpy/tool/commands/prettydiff.py:
46373
46374 2011-08-17  Dmitry Lomov  <dslomov@google.com>
46375
46376         https://bugs.webkit.org/show_bug.cgi?id=66400
46377         Fix TestWebKitAPI build on Mac OS.
46378
46379         Reviewed by David Levin.
46380
46381         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
46382
46383 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
46384
46385         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
46386         https://bugs.webkit.org/show_bug.cgi?id=66427
46387
46388         Reviewed by Adam Barth.
46389
46390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
46391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
46392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
46393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
46394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
46395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
46396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
46397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
46398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
46399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
46400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
46401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
46402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
46403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
46404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
46405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
46406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
46407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
46408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
46409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
46410         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
46411         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
46412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
46413         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
46414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
46415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
46416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
46417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
46418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
46419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
46420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
46421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
46422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
46423         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
46424         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
46425         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
46426         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
46427         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
46428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
46429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
46430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
46431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
46432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
46433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
46434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
46435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
46436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
46437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
46438         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
46439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
46440         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
46441         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
46442         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
46443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
46444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
46445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
46446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
46447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
46448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
46449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
46450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
46451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
46452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
46453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
46454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
46455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
46456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
46457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
46458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
46459         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
46460         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
46461         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
46462         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
46463         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
46464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
46465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
46466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
46467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
46468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
46469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
46470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
46471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
46472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
46473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
46474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
46475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
46476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
46477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
46478         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
46479         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
46480         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
46481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
46482         ():
46483         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
46484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
46485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
46486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
46487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
46488         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
46489         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
46490         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
46491         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
46492         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
46493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
46494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
46495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
46496         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
46497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
46498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
46499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
46500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
46501         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
46502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
46503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
46504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
46505
46506 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
46507
46508         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
46509         https://bugs.webkit.org/show_bug.cgi?id=65877
46510
46511         Reviewed by Eric Seidel.
46512
46513         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
46514
46515 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
46516
46517         Remove base.keys and replace it with Object.keys.
46518         https://bugs.webkit.org/show_bug.cgi?id=66422
46519
46520         Reviewed by Adam Barth.
46521
46522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
46523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
46524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
46525
46526 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
46527
46528         garden-o-matic Summary view should have items in descending chronological order.
46529         https://bugs.webkit.org/show_bug.cgi?id=66403
46530
46531         Reviewed by Adam Barth.
46532
46533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
46534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
46535         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
46536
46537 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
46538
46539         Fix a few errors in garden-o-matic frontend unit tests.
46540         https://bugs.webkit.org/show_bug.cgi?id=66421
46541
46542         Reviewed by Adam Barth.
46543
46544         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
46545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
46546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
46547
46548 2011-08-17  Adam Barth  <abarth@webkit.org>
46549
46550         Update Tools to account for (CG) being added to Chromium builder names
46551         https://bugs.webkit.org/show_bug.cgi?id=66410
46552
46553         Reviewed by Adam Barth.
46554
46555         Some of these names will change back once we turn on Skia bots.
46556
46557         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
46558         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
46559         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
46560         * Scripts/webkitpy/layout_tests/port/builders.py:
46561         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
46562         * TestResultServer/static-dashboards/builders.js:
46563         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
46564
46565 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
46566
46567         Wire up relative time to garden-o-matic summary view.
46568         https://bugs.webkit.org/show_bug.cgi?id=66343
46569
46570         Reviewed by Adam Barth.
46571
46572         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
46573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
46574         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
46575         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
46576         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
46577
46578 2011-08-17  Adam Roben  <aroben@apple.com>
46579
46580         Make run-api-tests run tests in alphabetical order
46581
46582         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
46583
46584         Reviewed by David Kilzer.
46585
46586         * Scripts/run-api-tests:
46587         (runAllTests):
46588         (runAllTestsInSuite):
46589         Sort the lists of tests and suites before iterating over them.
46590
46591 2011-08-17  Adam Barth  <abarth@webkit.org>
46592
46593         garden-o-matic should be able to rebaseline expected failures
46594         https://bugs.webkit.org/show_bug.cgi?id=66204
46595
46596         Reviewed by Dimitri Glazkov.
46597
46598         This patch introduces a new view for displaying expect, actual, and
46599         differences between results.  The new view also has a fledgling
46600         controller that handles some basic operations.  The new view is
46601         exercised by rebaseline.html, which lets you rebaselines expected
46602         failures, but the new view is not fully integrated into
46603         garden-o-matic.html
46604
46605         More patches will be required to make this stuff fully working, but
46606         this patch was already somewhat spiraling out of control.  Hopefully
46607         this patch will serve as a good starting point for further development.
46608
46609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
46610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
46611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
46612         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
46613         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
46614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
46615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
46616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
46617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
46618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
46619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
46620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
46621
46622 2011-08-16  Chang Shu  <cshu@webkit.org>
46623
46624         Support reset in WebCore::Internals
46625         https://bugs.webkit.org/show_bug.cgi?id=66307
46626
46627         Reviewed by Dimitri Glazkov.
46628
46629         Added call to resetInternalsObject in DRT.
46630
46631         * DumpRenderTree/chromium/TestShell.cpp:
46632         (TestShell::resetTestController):
46633         * DumpRenderTree/mac/DumpRenderTree.mm:
46634         (resetWebViewToConsistentStateBeforeTesting):
46635         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
46636         (WebCore::WebPage::resetSettings):
46637
46638 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
46639
46640         Add a new build slave for the Qt port on Mac OS SnowLeopard.
46641         https://bugs.webkit.org/show_bug.cgi?id=66392
46642
46643         Modify the config file to include the new build slave.
46644
46645         Reviewed by Adam Roben.
46646
46647         * BuildSlaveSupport/build.webkit.org-config/config.json:
46648
46649 2011-08-17  Sam White  <samuel.white@rochester.edu>
46650
46651         AccessibilityObject levels are inconsistent
46652         https://bugs.webkit.org/show_bug.cgi?id=66180
46653
46654         Added the ability to get numeric attribute values using numberAttributeValue. This
46655         function complements the existing stringAttributeValue and boolAttributeValue functions.
46656         The addition of numberAttributeValue was necessary because the stringAttributeValue
46657         function does a type check and will only return strings. This limitation made it
46658         impossible to get values for attributes that returned an NSNumber.
46659
46660         Reviewed by Chris Fleizach.
46661
46662         * DumpRenderTree/AccessibilityUIElement.cpp:
46663         (numberAttributeValueCallback):
46664         (AccessibilityUIElement::getJSClass):
46665         * DumpRenderTree/AccessibilityUIElement.h:
46666         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
46667         (AccessibilityUIElement::numberAttributeValue):
46668         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
46669         (AccessibilityUIElement::numberAttributeValue):
46670         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
46671         (AccessibilityUIElement::numberAttributeValue):
46672
46673 2011-08-17  Adam Roben  <aroben@apple.com>
46674
46675         Tell Trac logs always to display all specified revisions in a single page
46676
46677         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
46678         revisions than that.
46679
46680         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
46681         relevant revisions
46682
46683         Reviewed by Daniel Bates.
46684
46685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
46686         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
46687         a single page.
46688
46689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
46690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
46691         Updated tests for the above.
46692
46693 2011-08-17  Adam Roben  <aroben@apple.com>
46694
46695         Fix TestFailures's link to file a bug about TestFailures itself
46696
46697         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
46698         bug about itself is broken
46699
46700         Reviewed by Dan Bates.
46701
46702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
46703         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
46704         the host from the path.
46705
46706 2011-08-17  Adam Roben  <aroben@apple.com>
46707
46708         Teach TestFailures to ignore unbelievably short test runs
46709
46710         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
46711         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
46712
46713         Reviewed by Dan Bates.
46714
46715         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
46716         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
46717         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
46718         that caused it not to run any tests at all (as happened for a while due to
46719         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
46720
46721         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
46722         Test for the above.
46723
46724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
46725         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
46726
46727 2011-08-16  Adam Barth  <abarth@webkit.org>
46728
46729         Add a CG qualifier similar to the GPU qualifier
46730         https://bugs.webkit.org/show_bug.cgi?id=66359
46731
46732         Reviewed by Eric Seidel.
46733
46734         Once we have a Skia configuration on Chromium Mac, we'll use this CG
46735         qualifier to note that expectations apply only to the CG configuration.
46736
46737         * Scripts/webkitpy/layout_tests/port/chromium.py:
46738         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
46739
46740 2011-08-16  Eric Seidel  <eric@webkit.org>
46741
46742         REGRESSION(92717): WinPort needs to parse version information from port_name
46743         https://bugs.webkit.org/show_bug.cgi?id=66325
46744
46745         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
46746
46747         * Scripts/webkitpy/layout_tests/port/mac.py:
46748         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
46749
46750 2011-08-16  Adam Barth  <abarth@webkit.org>
46751
46752         Change webkit-patch analyze-baselines to print in a more unix-friendly way
46753         https://bugs.webkit.org/show_bug.cgi?id=66349
46754
46755         Reviewed by James Robinson.
46756
46757         As requested by jamesr.
46758
46759         * Scripts/webkitpy/tool/commands/rebaseline.py:
46760
46761 2011-08-16  Eric Seidel  <eric@webkit.org>
46762
46763         REGRESSION(92717): WinPort needs to parse version information from port_name
46764         https://bugs.webkit.org/show_bug.cgi?id=66325
46765
46766         Reviewed by Adam Barth.
46767
46768         WinPort didn't have any port_name parsing logic.
46769         Seemed it was best to just share the logic from MacPort.
46770         Sharing the logic from MacPort seemed easiest with a shared superclass.
46771         Once I created ApplePort (the superclass) there was a bunch of logic to share.
46772         I found LeakDetector was just in the way when switching back and forth
46773         between win.py and mac.py so I moved it into its own file.
46774
46775         The only logic change here is that WinPort should now be
46776         able to parse port_name values like MacPort (and other ports)
46777         can.  The fact that ports do this in their constructors is
46778         wrong and a source of many bugs.  But at least now WinPort
46779         matches the status-quo.
46780
46781         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
46782         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
46783         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
46784         * Scripts/webkitpy/layout_tests/port/mac.py:
46785         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
46786         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
46787         * Scripts/webkitpy/layout_tests/port/win.py:
46788         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
46789
46790 2011-08-16  Adam Barth  <abarth@webkit.org>
46791
46792         Add webkit-patch analyze-baselines, as requested by jamesr.
46793
46794         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
46795         * Scripts/webkitpy/tool/commands/rebaseline.py:
46796
46797 2011-08-16  Adam Barth  <abarth@webkit.org>
46798
46799         Fold bulk-optimize-baselines into optimize-baselines
46800         https://bugs.webkit.org/show_bug.cgi?id=66345
46801
46802         Reviewed by James Robinson.
46803
46804         bulk-optimize-baselines is now a superset of optimize-baselines, so
46805         they can be combined.
46806
46807         * Scripts/webkitpy/tool/commands/rebaseline.py:
46808
46809 2011-08-16  Adam Barth  <abarth@webkit.org>
46810
46811         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
46812         https://bugs.webkit.org/show_bug.cgi?id=66334
46813
46814         Reviewed by Tony Chang.
46815
46816         This patch moves us closer to switching the Chromium port from
46817         CoreGraphics to Skia.  This patch teaches our tools that the current
46818         Chromium Mac configuration is actually chromium-cg-mac, which makes
46819         room for a future chromium-mac configuration that uses Skia.
46820
46821         Shortly after this patch lands, I'll do a server-side move of the
46822         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
46823         and chromium-cg-mac-leopard.
46824
46825         * BuildSlaveSupport/build.webkit.org-config/config.json:
46826         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
46827         * Scripts/webkitpy/common/config/build.py:
46828         * Scripts/webkitpy/common/config/build_unittest.py:
46829         * Scripts/webkitpy/layout_tests/port/base.py:
46830         * Scripts/webkitpy/layout_tests/port/builders.py:
46831         * Scripts/webkitpy/layout_tests/port/chromium.py:
46832         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
46833         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
46834         * Scripts/webkitpy/layout_tests/port/dryrun.py:
46835         * Scripts/webkitpy/layout_tests/port/factory.py:
46836         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
46837         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
46838         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
46839         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
46840         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
46841         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
46842         * TestResultServer/static-dashboards/flakiness_dashboard.html:
46843
46844 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
46845
46846         garden-o-matic frontend needs a friendly relative time description method.
46847         https://bugs.webkit.org/show_bug.cgi?id=66324
46848
46849         Reviewed by Adam Barth.
46850
46851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
46852         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
46853         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
46854
46855 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
46856
46857         Summary view should not add multiple entries for the same test failure.
46858         https://bugs.webkit.org/show_bug.cgi?id=66318
46859
46860         Reviewed by Adam Barth.
46861
46862         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
46863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
46864             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
46865         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
46866
46867 2011-08-16  Adam Roben  <aroben@apple.com>
46868
46869         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
46870
46871         The basic strategy here is that once a test has failed or passed many times in a row we
46872         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
46873         in many fewer false positives than our current behavior.
46874
46875         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
46876         flaky, including tests that failed for a while but then were fixed
46877
46878         Reviewed by Dan Bates.
46879
46880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
46881         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
46882         number of non-too-many-failure builds we've seen.
46883         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
46884         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
46885         tests, keep track of how many times they have passed or failed in a row. If they pass or
46886         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
46887         considered flaky it doesn't matter how many times it passes or fails.)
46888
46889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
46890         Added tests for the above.
46891
46892 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
46893
46894         garden-o-matic needs a summary view with actions for each problem.
46895         https://bugs.webkit.org/show_bug.cgi?id=66144
46896
46897         Reviewed by Adam Barth.
46898
46899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
46900         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
46901         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
46902         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
46903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
46904         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
46905
46906 2011-08-16  Dean Jackson  <dino@apple.com>
46907
46908         Adding Ted "hober" O'Connor as a non-committing contributor.
46909
46910         * Scripts/webkitpy/common/config/committers.py:
46911
46912 2011-08-16  Adam Roben  <aroben@apple.com>
46913
46914         Teach TestFailures how to interpret unfinished test runs
46915
46916         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
46917         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
46918
46919         Reviewed by David Kilzer.
46920
46921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
46922         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
46923         rather than "isStarted" so that we don't count builds for which the test run never finished.
46924         Bumped the cache version to evict old, buggy cached data.
46925
46926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
46927         Added a test for the above, and made a somewhat synthetic test more realistic by including
46928         more of the actual JSON data from build.webkit.org.
46929
46930         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
46931         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
46932         cached data.
46933
46934 2011-08-16  Adam Roben  <aroben@apple.com>
46935
46936         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
46937
46938         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
46939         should match Lion's behavior.
46940
46941         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
46942         but doesn't use Lion results
46943
46944         Reviewed by David Kilzer.
46945
46946         * Scripts/old-run-webkit-tests:
46947         (expectedDirectoryForTest):
46948         * Scripts/webkitpy/layout_tests/port/win.py:
46949         (WinPort.baseline_search_path):
46950         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
46951         (WinPortTest.test_baseline_search_path):
46952         Replaced mac-snowleopard with mac-lion.
46953
46954         * Scripts/webkitpy/common/config/build.py:
46955         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
46956         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
46957         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
46958         will no longer look there for results.
46959
46960         * Scripts/webkitpy/common/config/build_unittest.py:
46961         (ShouldBuildTest.test_should_build): Tests for the above changes.
46962
46963 2011-08-16  Dean Jackson  <dino@apple.com>
46964
46965         Move me from contributor to reviewer.
46966
46967         * Scripts/webkitpy/common/config/committers.py:
46968
46969 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
46970
46971         garden-o-matic frontend needs model.commitDataForRevisionRange function.
46972         https://bugs.webkit.org/show_bug.cgi?id=66252
46973
46974         Reviewed by Adam Barth.
46975
46976         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
46977         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
46978
46979 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
46980
46981         garden-o-matic frontend needs a generic way to track updates.
46982         https://bugs.webkit.org/show_bug.cgi?id=66245
46983
46984         Reviewed by Adam Barth.
46985
46986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
46987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
46988
46989 2011-08-15  Adam Roben  <aroben@apple.com>
46990
46991         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
46992
46993         Failures now give output of the form: foo should be bar but is baz
46994
46995         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
46996         test is in TestWebKitAPI's output
46997
46998         Reviewed by David Levin.
46999
47000         * TestWebKitAPI/JavaScriptTest.cpp:
47001         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
47002         members.
47003         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
47004         object, rather than doing any testing of it here.
47005         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
47006         to use a pretty error message when the test fails.
47007
47008         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
47009         gtest-style macros that wrap it.
47010
47011         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
47012
47013         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
47014         (TestWebKitAPI::TEST): Changed to use the new macros.
47015
47016         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
47017         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
47018         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
47019         the test passes, though. Returning early seems to have been an unnecessary optimization.
47020
47021         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
47022         (TestWebKitAPI::TEST): Changed to use the new macros.
47023
47024 2011-08-15  Eric Seidel  <eric@webkit.org>
47025
47026         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
47027
47028         Unreviewed.
47029
47030         * Scripts/run-webkit-tests:
47031         (usingLeaks):
47032         (useNewRunWebKitTests):
47033
47034 2011-08-14  Adam Barth  <abarth@webkit.org>
47035
47036         Switch results detail view over to new-style object-oriented UI widgets
47037         https://bugs.webkit.org/show_bug.cgi?id=66200
47038
47039         Reviewed by Dimitri Glazkov.
47040
47041         This patch replaces my goofy template-based UI for the results
47042         comparison screen with new object-oriented UI widgets.
47043
47044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
47045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
47046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
47047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
47048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
47049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
47050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
47051
47052 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
47053
47054         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
47055         https://bugs.webkit.org/show_bug.cgi?id=66166
47056
47057         Also changed base.RequestTracker to:
47058         a) fire callback immediately if requestsInFlight is 0;
47059         b) not barf if callback is not supplied.
47060
47061         Reviewed by Adam Barth.
47062
47063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
47064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
47065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
47066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
47067
47068 2011-08-12  Mark Rowe  <mrowe@apple.com>
47069
47070         Be more forward-looking in the choice of compiler.
47071
47072         Rubber-stamped by Jon Honeycutt.
47073
47074         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
47075         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
47076         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
47077         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
47078
47079 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
47080
47081         DRT: Add support for gesture events.
47082         https://bugs.webkit.org/show_bug.cgi?id=66105
47083
47084         Reviewed by Darin Fisher.
47085
47086         * DumpRenderTree/chromium/EventSender.cpp:
47087         (EventSender::EventSender):
47088         (EventSender::gestureScrollBegin):
47089         (EventSender::gestureScrollEnd):
47090         (EventSender::gestureTap):
47091         (EventSender::gestureEvent):
47092         * DumpRenderTree/chromium/EventSender.h:
47093
47094 2011-08-12  Andy Estes  <aestes@apple.com>
47095
47096         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
47097         https://bugs.webkit.org/show_bug.cgi?id=66158
47098
47099         Reviewed by Dan Bernstein.
47100
47101         * DumpRenderTree/LayoutTestController.cpp:
47102         (allowRoundingHacksCallback): The third argument is the 'this'
47103         JSObjectRef, not the second.
47104
47105 2011-08-12  Andy Estes  <aestes@apple.com>
47106
47107         Cancel in onbeforeunload dialog sometime causes a button to stop working.
47108         https://bugs.webkit.org/show_bug.cgi?id=26211
47109
47110         Reviewed by Alexey Proskuryakov.
47111
47112         Implement a new LayoutTestController method that a test can call to set
47113         the return value of DumpRenderTree's beforeunload UI delegate.
47114
47115         * DumpRenderTree/LayoutTestController.cpp:
47116         (LayoutTestController::LayoutTestController): Initialize
47117         m_shouldStayOnPageAfterHandlingBeforeUnload.
47118         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
47119         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
47120         (LayoutTestController::staticFunctions): Register
47121         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
47122         * DumpRenderTree/LayoutTestController.h:
47123         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
47124         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
47125         * DumpRenderTree/chromium/LayoutTestController.cpp:
47126         (LayoutTestController::LayoutTestController): Initialize
47127         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
47128         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
47129         (LayoutTestController::reset): Reset
47130         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
47131         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
47132         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
47133         from JavaScript.
47134         * DumpRenderTree/chromium/LayoutTestController.h:
47135         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
47136         * DumpRenderTree/chromium/WebViewHost.cpp:
47137         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
47138         return the inverse of
47139         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
47140         * DumpRenderTree/mac/UIDelegate.mm:
47141         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
47142         * DumpRenderTree/win/UIDelegate.cpp:
47143         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
47144         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
47145         Define setShouldStayOnPageAfterHandlingBeforeUnload().
47146         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
47147         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
47148         to the Test Controller telling it what value it should return in its
47149         onbeforeunload UI delegate.
47150         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
47151         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
47152         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
47153         Call InjectedBundle::postNewBeforeUnloadReturnValue().
47154         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
47155         * WebKitTestRunner/TestController.cpp:
47156         (WTR::TestController::TestController): Initialize
47157         m_beforeUnloadReturnValue to true.
47158         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
47159         the value of TestController::beforeUnloadReturnValue().
47160         (WTR::TestController::resetStateToConsistentValues): Reset
47161         m_beforeUnloadReturnValue to true.
47162         * WebKitTestRunner/TestController.h:
47163         (WTR::TestController::beforeUnloadReturnValue):
47164         (WTR::TestController::setBeforeUnloadReturnValue):
47165         * WebKitTestRunner/TestInvocation.cpp:
47166         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
47167         message posted from the injected bundle by retrieving the message body
47168         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
47169
47170 2011-08-12  Sam Weinig  <sam@webkit.org>
47171
47172         Move compiler specific macros to their own header
47173         https://bugs.webkit.org/show_bug.cgi?id=66119
47174
47175         Reviewed by Anders Carlsson.
47176
47177         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
47178
47179 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
47180
47181         Add a way to extend DOM objects in garden-o-matic.
47182         https://bugs.webkit.org/show_bug.cgi?id=66096
47183
47184         Reviewed by Adam Barth.
47185
47186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
47187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
47188
47189 2011-08-11  MORITA Hajime  <morrita@google.com>
47190
47191         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
47192         https://bugs.webkit.org/show_bug.cgi?id=45438
47193
47194         Reviewed by Kent Tamura.
47195
47196         MockSpellCheck was assuming the input of spellCheckWord() is a word.
47197         But it can be a series of word. This change made spellCheckWord()
47198         understand simple word boundary which appears in tests.
47199
47200         * DumpRenderTree/chromium/MockSpellCheck.cpp:
47201         (MockSpellCheck::spellCheckWord):
47202
47203 2011-08-11  Mark Rowe  <mrowe@apple.com>
47204
47205         Rework some Makefile logic to remove a double-negative.
47206
47207         Reviewed by Jon Honeycutt.
47208
47209         * DumpRenderTree/mac/PerlSupport/Makefile:
47210
47211 2011-08-11  Anders Carlsson  <andersca@apple.com>
47212
47213         Add a FIXME.
47214
47215         * TestWebKitAPI/TestsController.cpp:
47216         (TestWebKitAPI::TestsController::TestsController):
47217
47218 2011-08-11  Anders Carlsson  <andersca@apple.com>
47219
47220         Initialize threading before running any tests
47221         https://bugs.webkit.org/show_bug.cgi?id=66112
47222
47223         Reviewed by Adam Barth.
47224
47225         * TestWebKitAPI/TestsController.cpp:
47226         (TestWebKitAPI::TestsController::TestsController):
47227
47228 2011-08-11  Adam Barth  <abarth@webkit.org>
47229
47230         Add unexpected-passes.html to TestFailures for marking tests as passing
47231         https://bugs.webkit.org/show_bug.cgi?id=66102
47232
47233         Reviewed by Dimitri Glazkov.
47234
47235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
47236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
47237             - Move some code into the library so it can be shared.
47238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
47239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
47240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
47241             - Add round-trip unit tests.
47242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
47243         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
47244             - I'm not entirely sure this feature should remain a separate HTML
47245               file, but it seemed better than cluttering up the main HTML file
47246               with too much extra stuff.
47247         * Scripts/webkitpy/tool/servers/gardeningserver.py:
47248         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
47249             - The gardening server couldn't handle adding PASS expectations.  Now it can.
47250
47251 2011-08-11  Eric Seidel  <eric@webkit.org>
47252
47253         NRWT has wrong fallback order for Mac now that Lion exists
47254         https://bugs.webkit.org/show_bug.cgi?id=66093
47255
47256         Reviewed by Adam Barth.
47257
47258         ORWT used a different system for fallback orders than NRWT did.
47259         I moved win.py to match ORWT fallback orders in bug 64486.
47260         This bug moves mac.py to match ORWT fallback order
47261         and adds 'lion' as a supported OS version.
47262
47263         Because ChromiumMac shares OS version detection code with AppleMac
47264         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
47265
47266         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
47267         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
47268         * Scripts/webkitpy/layout_tests/port/mac.py:
47269         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
47270         * Scripts/webkitpy/layout_tests/port/win.py:
47271
47272 2011-08-11  Adam Barth  <abarth@webkit.org>
47273
47274         Update test results now that we use absolute URLs.
47275
47276         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
47277
47278 2011-08-11  Adam Barth  <abarth@webkit.org>
47279
47280         garden-o-matic should be able to determine when tests unexpectedly pass
47281         https://bugs.webkit.org/show_bug.cgi?id=66092
47282
47283         Reviewed by Dimitri Glazkov.
47284
47285         This patch just contains the library methods for extracting this
47286         information.  I'll add some UI in a subsequent patch.
47287
47288         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
47289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
47290
47291 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
47292
47293         New expectation entries should be placed next to existing ones.
47294         https://bugs.webkit.org/show_bug.cgi?id=66066
47295
47296         Reviewed by Adam Barth.
47297
47298         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
47299             which is computed as the last found reference to the same test.
47300         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
47301
47302 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
47303
47304         Unreviewed, rolling out r92847.
47305         http://trac.webkit.org/changeset/92847
47306         https://bugs.webkit.org/show_bug.cgi?id=65986
47307
47308         Broke check-webkit-style
47309
47310         * Scripts/webkitpy/style/checker.py:
47311         * Scripts/webkitpy/style/checker_unittest.py:
47312
47313 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
47314
47315         Unreviewed, rolling out r92847.
47316         http://trac.webkit.org/changeset/92847
47317         https://bugs.webkit.org/show_bug.cgi?id=65986
47318
47319         Broke check-webkit-style
47320
47321         * Scripts/webkitpy/style/checker.py:
47322         * Scripts/webkitpy/style/checker_unittest.py:
47323
47324 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
47325
47326         [Qt] autotests shouldn't require config.h in the style check
47327         https://bugs.webkit.org/show_bug.cgi?id=65986
47328
47329         Remove the include rules from the style-check for Qt tests.
47330         Since for the most part it's just a matter of using the
47331         API provided by QtWebKit, enforcing the WebCore set of rules
47332         only seems to make sense in the case of MIMESniffing.
47333
47334         Reviewed by Benjamin Poulain.
47335
47336         * Scripts/webkitpy/style/checker.py:
47337         * Scripts/webkitpy/style/checker_unittest.py:
47338
47339 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
47340
47341         [WK2] Implement waitForPolicyDelegate
47342         https://bugs.webkit.org/show_bug.cgi?id=42330
47343
47344         Reviewed by Csaba Osztrogonác.
47345
47346         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
47347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
47348         (WTR::navigationTypeToString):
47349         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
47350         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
47351         (WTR::LayoutTestController::LayoutTestController):
47352         (WTR::LayoutTestController::setCustomPolicyDelegate):
47353         (WTR::LayoutTestController::waitForPolicyDelegate):
47354         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
47355         (WTR::LayoutTestController::isPolicyDelegateEnabled):
47356         (WTR::LayoutTestController::isPolicyDelegatePermissive):
47357
47358 2011-08-11  Adam Barth  <abarth@webkit.org>
47359
47360         rebaseline-expectations should use the release bots, not the debug
47361         bots.  The debug bots don't all run all the tests.  Also, delay
47362         updating test_expectations a long as possible to avoid clearing out
47363         lines that we'll need for other ports.
47364
47365         * Scripts/webkitpy/layout_tests/port/builders.py:
47366         * Scripts/webkitpy/tool/commands/rebaseline.py:
47367         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
47368
47369 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
47370
47371         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
47372         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
47373
47374         * BuildSlaveSupport/build.webkit.org-config/config.json:
47375
47376 2011-08-10  Eric Seidel  <eric@webkit.org>
47377
47378         new-run-webkit-test's WinPort has no fallback logic
47379         https://bugs.webkit.org/show_bug.cgi?id=64486
47380
47381         Unreviewed.
47382
47383         Turns out that we've long had a subtle bug whereby if you didn't
47384         already have DumpRenderTree built, we might end up running unsupported tests
47385         because the DumpRenderTree --print-supported-features check would silently fail.
47386
47387         When I moved the call from using popen to using Executive.run_command, this silent
47388         failure became noisy.  (Breaking some bots.)
47389
47390         This re-orders our steps so that we always build DRT before collecting expectations,
47391         as well as adds a warning message when DumpRenderTree can't be found.
47392
47393         * Scripts/webkitpy/layout_tests/port/webkit.py:
47394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
47395
47396 2011-08-10  Eric Seidel  <eric@webkit.org>
47397
47398         new-run-webkit-test's WinPort has no fallback logic
47399         https://bugs.webkit.org/show_bug.cgi?id=64486
47400
47401         Unreviewed.  Fix test-webkitpy under Python 2.5.
47402
47403         * Scripts/webkitpy/layout_tests/port/win.py:
47404
47405 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
47406
47407         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
47408         https://bugs.webkit.org/show_bug.cgi?id=65875
47409
47410         Reviewed by Kenneth Rohde Christiansen.
47411
47412         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
47413
47414         This causes mouse events to be sent twice in some cases. We work around the problem
47415         by defining the first touch point to be a primary touch point (case which hit some
47416         weird condition in QWidget, skipping the generation of fake mouse events).
47417
47418         * MiniBrowser/qt/MiniBrowserApplication.cpp:
47419         (MiniBrowserApplication::notify):
47420
47421 2011-08-10  David Hyatt  <hyatt@apple.com>
47422
47423         https://bugs.webkit.org/show_bug.cgi?id=66004
47424
47425         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
47426         the code on by default.
47427
47428         Reviewed by Adam Roben.
47429
47430         * BuildSlaveSupport/build.webkit.org-config/config.json:
47431         * Scripts/build-webkit:
47432
47433 2011-08-10  Oliver Hunt  <oliver@apple.com>
47434
47435         JSEvaluteScript does not return the correct object when given JSONP data
47436         https://bugs.webkit.org/show_bug.cgi?id=66003
47437
47438         Reviewed by Gavin Barraclough.
47439
47440         Add a test case.
47441
47442         * DumpRenderTree/mac/DumpRenderTree.mm:
47443         (testStringByEvaluatingJavaScriptFromString):
47444
47445 2011-08-10  Eric Seidel  <eric@webkit.org>
47446
47447         WIN: NRWT runs compositing tests on configurations that don't support compositing
47448         https://bugs.webkit.org/show_bug.cgi?id=64472
47449
47450         Reviewed by Adam Barth.
47451
47452         I think the code was just wrong.  It was never splitting the string
47453         into list pieces before.
47454         I've now tested the supported_features code and theoretically it
47455         should now work with Windows DRT.
47456
47457         I also made the list-lookup functions always return lists, to make
47458         it possible to clean up the list-transform code in the future
47459         (I opted not to do that cleanup in this patch, but at least now
47460         both types of feature lookup functions match return types.)
47461
47462         * Scripts/webkitpy/layout_tests/port/webkit.py:
47463         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
47464
47465 2011-08-10  Eric Seidel  <eric@webkit.org>
47466
47467         Clean up ChromiumDriver a little
47468         https://bugs.webkit.org/show_bug.cgi?id=65995
47469
47470         Unreviewed.
47471
47472         Fix NRWT for chromium.  Silly python.
47473
47474         * Scripts/webkitpy/layout_tests/port/chromium.py:
47475
47476 2011-08-10  Eric Seidel  <eric@webkit.org>
47477
47478         Clean up ChromiumDriver a little
47479         https://bugs.webkit.org/show_bug.cgi?id=65995
47480
47481         Reviewed by Adam Barth.
47482
47483         - We no longer support threading, so remove threading specific code.
47484         - Add FIXMEs about using ServerProcess instead.
47485         - Condense option-mapping if-cascade into a for loop.
47486         - Unindent long if blocks by using early return.
47487         - Unwrap lines which are needlessly wrapped.
47488
47489         There should be no functional changes here, just code cleanup/dead-code removal.
47490
47491         * Scripts/webkitpy/layout_tests/port/chromium.py:
47492
47493 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
47494
47495         Unmuddle construction options for TestConfiguration.
47496         https://bugs.webkit.org/show_bug.cgi?id=65988
47497
47498         The TestConfiguration instance is now constructed only using actual values.
47499         Port-based construction is split into a "from_port" class method.
47500
47501         Reviewed by Eric Seidel.
47502
47503         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
47504         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
47505         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
47506         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
47507         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
47508
47509 2011-08-10  Eric Seidel  <eric@webkit.org>
47510
47511         Leaks bot shows python logging prefixes as part of summary display
47512         https://bugs.webkit.org/show_bug.cgi?id=65931
47513
47514         Reviewed by Adam Barth.
47515
47516         The big part of this change is adding a unittesting system for
47517         master.cfg, so mere-mortals can make changes to build.webkit.org
47518         with greatly-reduced risk of breaking the world.
47519
47520         Turns out that in typing up my trival logging fix I made 2 typos,
47521         so hopefully the hour spent getting master.cfg to load was worth it. :)
47522
47523         I also tried to make mastercfg_unittest run as part of test-webkitpy
47524         but right now test-webkitpy requires that unittest files be located in
47525         a module-name-compatible directory.  'build.webkit.org-config' is not
47526         a valid module name.
47527
47528         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
47529          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
47530            by using a new _strip_python_logging_prefix function.
47531          - Also fixed this function to file to work with a more modern
47532            simplejson version (which returns unicode objects instead of str objects)
47533            and filed a related bug with buildbot.net due to their handling of unicode builder names.
47534         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
47535          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
47536          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
47537         * Scripts/webkitpy/thirdparty/__init__.py:
47538          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
47539
47540 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
47541
47542         garden-o-matic should extrapolate failures given a set of known results
47543         https://bugs.webkit.org/show_bug.cgi?id=65882
47544
47545         Reviewed by Adam Barth.
47546
47547         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
47548         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
47549             adjusted all call sites.
47550         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
47551             makes wider net for specific failures.
47552         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
47553
47554 2011-08-10  Adam Barth  <abarth@webkit.org>
47555
47556         The URL we were computing for retrieving baselines was missing a slash
47557         character because our mocks had an extra slash character.  I've
47558         corrected both the code and the mock.
47559
47560         * Scripts/webkitpy/tool/commands/rebaseline.py:
47561         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
47562         * Scripts/webkitpy/tool/mocktool.py:
47563
47564 2011-08-09  Adam Barth  <abarth@webkit.org>
47565
47566         Move the quote mark to the right place.
47567
47568         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
47569
47570 2011-08-09  Adam Barth  <abarth@webkit.org>
47571
47572         garden-o-matic should use huerstics to narrow regression range
47573         https://bugs.webkit.org/show_bug.cgi?id=65948
47574
47575         Reviewed by Dimitri Glazkov.
47576
47577         When analyzing a regression range, if one of the commit messages
47578         mentions the test in question, we now hueristically assume that
47579         revision caused the failure.  (I'm shamelessly stealing this idea from
47580         TestFailures.)
47581
47582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
47583
47584 2011-07-13  Eric Seidel  <eric@webkit.org>
47585
47586         new-run-webkit-test's WinPort has no fallback logic
47587         https://bugs.webkit.org/show_bug.cgi?id=64486
47588
47589         Reviewed by Adam Roben.
47590
47591         I've tried to write a patch for bug 64439 twice now, and both times
47592         I've ended up re-writing half the port system.  So I'm breaking
47593         things up into smaller pieces, this being the first.
47594
47595         WinPort still does not have any port_name parsing, so when instantiated
47596         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
47597         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
47598
47599         Otherwise this should "just work" for windows.  I've not been able to test the
47600         version detection on my mac, but the unit tests show the code behaving as designed.
47601
47602         * Scripts/webkitpy/layout_tests/port/win.py:
47603         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
47604
47605 2011-08-09  Adam Barth  <abarth@webkit.org>
47606
47607         Teach build.webkit.org's garden-o-matic how to talk to the local server
47608         https://bugs.webkit.org/show_bug.cgi?id=65940
47609
47610         Reviewed by Dimitri Glazkov.
47611
47612         After this patch, the version of garden-o-matic on build.webkit.org is
47613         fully functional.  It can interact with the local server via CORS.
47614
47615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
47616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
47617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
47618         * Scripts/webkitpy/tool/commands/gardenomatic.py:
47619         * Scripts/webkitpy/tool/servers/gardeningserver.py:
47620
47621 2011-08-09  Adam Barth  <abarth@webkit.org>
47622
47623         Enable CORS for garden-o-matic
47624         https://bugs.webkit.org/show_bug.cgi?id=65936
47625
47626         Reviewed by Dimitri Glazkov.
47627
47628         This patch will allow the hosted instance of garden-o-matic to
47629         communicate with the local server.
47630
47631         * Scripts/webkitpy/tool/servers/gardeningserver.py:
47632         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
47633
47634 2011-08-09  Adam Barth  <abarth@webkit.org>
47635
47636         Upgrade jquery in TestFailures
47637         https://bugs.webkit.org/show_bug.cgi?id=65935
47638
47639         Reviewed by Dimitri Glazkov.
47640
47641         Upgrade to a newer version of jQuery with better support for CORS and CSP.
47642
47643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
47644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
47645         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
47646
47647 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
47648
47649         Unreviewed, rolling out r92683.
47650         http://trac.webkit.org/changeset/92683
47651         https://bugs.webkit.org/show_bug.cgi?id=65921
47652
47653          "Breaks Qt --minimal build. Revert pending update of the Qt
47654         minimal configuration" (Requested by simathur on #webkit).
47655
47656         * QtTestBrowser/cookiejar.cpp:
47657         (TestBrowserCookieJar::TestBrowserCookieJar):
47658         * QtTestBrowser/launcherwindow.cpp:
47659         (LauncherWindow::createChrome):
47660         (LauncherWindow::setDiskCache):
47661         * QtTestBrowser/main.cpp:
47662         (LauncherApplication::handleUserOptions):
47663         * QtTestBrowser/webpage.cpp:
47664         (WebPage::openUrlInDefaultBrowser):
47665
47666 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
47667
47668         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
47669         https://bugs.webkit.org/show_bug.cgi?id=65880
47670
47671         Reviewed by Andreas Kling.
47672
47673         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
47674         check for their feature flags. Assume that any reasonable Qt build provides them.
47675         * QtTestBrowser/cookiejar.cpp:
47676         (TestBrowserCookieJar::TestBrowserCookieJar):
47677         * QtTestBrowser/launcherwindow.cpp:
47678         (LauncherWindow::createChrome):
47679         (LauncherWindow::setDiskCache):
47680         * QtTestBrowser/main.cpp:
47681         (LauncherApplication::handleUserOptions):
47682         * QtTestBrowser/webpage.cpp:
47683         (WebPage::openUrlInDefaultBrowser):
47684
47685 2011-08-09  Adam Barth  <abarth@webkit.org>
47686
47687         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
47688         https://bugs.webkit.org/show_bug.cgi?id=65891
47689
47690         Reviewed by Eric Seidel.
47691
47692         The problem was that platform/chromium contained a bogus expectation
47693         file that needed to be removed, but by the time we got around to
47694         removing it, we'd already moved the correct baseline into its place.
47695         After this patch, we copy the gold results into memory before
47696         reshuffling things on disk (and we delete bad things before adding good
47697         things).
47698
47699         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
47700         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
47701
47702 2011-08-08  Adam Barth  <abarth@webkit.org>
47703
47704         Chromium Windows bots can't figure out what SVN revision they're running
47705         https://bugs.webkit.org/show_bug.cgi?id=65893
47706
47707         Reviewed by Eric Seidel.
47708
47709         The comment in _engage_awesome_windows_hacks explains why we're making
47710         this change.  It's ugly and rediculous, but this approach seems better
47711         than using shell=True when calling popen.
47712
47713         * Scripts/webkitpy/common/checkout/scm/svn.py:
47714         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
47715
47716 2011-08-08  Adam Barth  <abarth@webkit.org>
47717
47718         Remove deduplicate-tests
47719         https://bugs.webkit.org/show_bug.cgi?id=65886
47720
47721         Reviewed by Tony Chang.
47722
47723         This script is redundant with "webkit-patch bulk-optimize-baselines",
47724         which can find many more duplicates than deduplicate-tests because
47725         bulk-optimize-baselines can move results around whereas
47726         deduplicate-tests can only remove results.
47727
47728         * Scripts/deduplicate-tests: Removed.
47729         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
47730         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
47731
47732 2011-08-08  Adam Barth  <abarth@webkit.org>
47733
47734         scm.delete should delete empty parent directories as well
47735         https://bugs.webkit.org/show_bug.cgi?id=65878
47736
47737         Reviewed by Eric Seidel.
47738
47739         This behavior makes SVN match GIT (which has no concept of empty
47740         directories).  This bug comes up a lot when optimizing baselines, which
47741         often create empty directories when we're able to optimize everything
47742         out of a given folder.
47743
47744         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
47745         * Scripts/webkitpy/common/checkout/scm/svn.py:
47746
47747 2011-08-08  Lucas Forschler  <lforschler@apple.com>
47748
47749         Add triggers for Lion WK2 test bots.
47750
47751         Reviewed by Stephanie Lewis.
47752
47753         * BuildSlaveSupport/build.webkit.org-config/config.json:
47754
47755 2011-08-08  Adam Barth  <abarth@webkit.org>
47756
47757         bulk-optimize-baselines should take directories on the command line
47758         https://bugs.webkit.org/show_bug.cgi?id=65879
47759
47760         Reviewed by Dimitri Glazkov.
47761
47762         Passing lists of tests via stdin is a pain.  It's easier if the command
47763         takes a list of tests on the command line, like run-webkit-tests.
47764
47765         * Scripts/webkitpy/tool/commands/rebaseline.py:
47766
47767 2011-08-08  Adam Barth  <abarth@webkit.org>
47768
47769         Deprecate rebaseline-chromium-webkit-tests
47770         https://bugs.webkit.org/show_bug.cgi?id=65873
47771
47772         Reviewed by Dimitri Glazkov.
47773
47774         This script never worked correctly and now is redundant with more
47775         modern infrastructure for rebaselining tests.  This patch deprecates
47776         the script in order to flush out any issues with the new tools.  Once
47777         folks are happy with the new tools, we'll delete this script.
47778
47779         * Scripts/rebaseline-chromium-webkit-tests:
47780
47781 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
47782
47783         garden-o-matic should only touch expectations that need updating.
47784         https://bugs.webkit.org/show_bug.cgi?id=65876
47785
47786         Reviewed by Adam Barth.
47787
47788         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
47789             so that a caller could influence which lines to serialize from values.
47790         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
47791         * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
47792         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
47793
47794 2011-08-08  Dimitri Glazkov  <dglazkov@chromium.org>
47795
47796         TestExpectationsEditor should return a list of updated expectations.
47797         https://bugs.webkit.org/show_bug.cgi?id=65872
47798
47799         Reviewed by Adam Barth.
47800
47801         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
47802         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
47803
47804 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
47805
47806         Fix SCM webkitpy unit test failures
47807         https://bugs.webkit.org/show_bug.cgi?id=65823
47808
47809         Reviewed by Eric Seidel.
47810
47811         * Scripts/webkitpy/common/checkout/scm/git.py:
47812         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
47813
47814 2011-08-08  Eric Seidel  <eric@webkit.org>
47815
47816         Move the --leaks bot back over to NRWT now that I'm back
47817         from vacation and able to debug it.
47818
47819         Unreviewed.
47820
47821         * Scripts/run-webkit-tests:
47822         (usingWebKit2):
47823         (useNewRunWebKitTests):
47824
47825 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
47826
47827         Wire up updating expectations in garden-o-matic.
47828         https://bugs.webkit.org/show_bug.cgi?id=65794
47829
47830         Reviewed by Adam Barth.
47831
47832         * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
47833         * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
47834         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
47835         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
47836
47837 2011-08-08  Jochen Eisinger  <jochen@chromium.org>
47838
47839         webkit-patch doesn't get along with renamed files
47840         https://bugs.webkit.org/show_bug.cgi?id=48075
47841
47842         Possibly a bit heavy handed - I removed all instances of -C and
47843         changed every instance of -M with '--no-renames' in git.py. This
47844         forces git to not try to tell us about renames at all, which is
47845         ultimately the behaviour we want. The old file is shown deleted,
47846         then the new file is shown added, followed by any changes that
47847         occurred. Also gets rid of the problem where deleting one file
47848         and adding another file which has similar content would
47849         unexpectedly show up as a rename, and fall out of a diff.
47850
47851         Based on a patch by Wyatt Carss.
47852
47853         Reviewed by Eric Seidel.
47854
47855         * Scripts/webkitpy/common/checkout/scm/git.py:
47856
47857 2011-08-07  Sam White  <samuel.white@rochester.edu>
47858
47859         Add the ability to search the AccessibilityObject cache
47860         https://bugs.webkit.org/show_bug.cgi?id=64994
47861
47862         Added testing support for AccessibilityObject cache searching. Currently,
47863         only the mac platform is full supported and has had API exposed. Other
47864         platforms have only have this new functionality stubbed. Full implementation
47865         is a job suited only for an accessibility expert of each respective platform.
47866
47867         Reviewed by Chris Fleizach.
47868
47869         * DumpRenderTree/AccessibilityUIElement.cpp:
47870         (uiElementForSearchPredicateCallback):
47871         (AccessibilityUIElement::getJSClass):
47872         * DumpRenderTree/AccessibilityUIElement.h:
47873         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
47874         (AccessibilityUIElement::uiElementForSearchPredicate):
47875         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
47876         (AccessibilityUIElement::uiElementForSearchPredicate):
47877         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
47878         (AccessibilityUIElement::uiElementForSearchPredicate):
47879
47880 2011-08-06  Adam Barth  <abarth@webkit.org>
47881
47882         Remove dead code in webkitpy
47883         https://bugs.webkit.org/show_bug.cgi?id=65818
47884
47885         Reviewed by Dimitri Glazkov.
47886
47887         This code was added to support the rebaseline2 command six months ago,
47888         but the rebaseline2 command was never finished and no one else has used
47889         this code since it was landed.  This patch removes the dead code.  If
47890         we revive rebaseline2, then we can revert this patch and recover the
47891         code.  Until then, this code is just dead weight.
47892
47893         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
47894         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
47895         * Scripts/webkitpy/common/net/testoutput.py: Removed.
47896         * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
47897         * Scripts/webkitpy/common/net/testoutputset.py: Removed.
47898         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
47899         * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
47900         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
47901         * Scripts/webkitpy/layout_tests/port/base.py:
47902         * Scripts/webkitpy/layout_tests/port/chromium.py:
47903         * Scripts/webkitpy/layout_tests/port/webkit.py:
47904
47905 2011-08-06  Adam Barth  <abarth@webkit.org>
47906
47907         webkit-patch optimize-baselines can't handle promotions to base results directory
47908         https://bugs.webkit.org/show_bug.cgi?id=65819
47909
47910         Reviewed by Dimitri Glazkov.
47911
47912         This bug came up when testing the optimizer on some editing baselines.
47913
47914         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
47915         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
47916
47917 2011-08-06  Adam Barth  <abarth@webkit.org>
47918
47919         Add a small command to optimize baselines in bulk.
47920
47921         * Scripts/webkitpy/tool/commands/rebaseline.py:
47922
47923 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
47924
47925         Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
47926
47927         * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
47928
47929 2011-08-05  Dimitri Glazkov  <dglazkov@chromium.org>
47930
47931         Garden-o-matic updateexpectations needs a unit test.
47932         https://bugs.webkit.org/show_bug.cgi?id=65780
47933
47934         Reviewed by Adam Barth.
47935
47936         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
47937
47938 2011-08-05  Anders Carlsson  <andersca@apple.com>
47939
47940         Future proof an Objective-C test
47941         https://bugs.webkit.org/show_bug.cgi?id=65788
47942
47943         Reviewed by Dan Bernstein.
47944
47945         Add isObjectInstanceOf to ObjCController.
47946
47947         * DumpRenderTree/mac/ObjCController.m:
47948         (+[ObjCController isSelectorExcludedFromWebScript:]):
47949         (+[ObjCController webScriptNameForSelector:]):
47950         (-[ObjCController isObject:instanceOf:]):
47951
47952 2011-08-05  Adam Barth  <abarth@webkit.org>
47953
47954         trac.js needs unittests
47955         https://bugs.webkit.org/show_bug.cgi?id=65673
47956
47957         Reviewed by Dimitri Glazkov.
47958
47959         This tests also have somewhat large fixtures.  I've trimmed the example
47960         XML down a bunch while still hitting interesting cases in the parsing.
47961
47962         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
47963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
47964
47965 2011-08-05  Adam Barth  <abarth@webkit.org>
47966
47967         Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
47968         https://bugs.webkit.org/show_bug.cgi?id=65759
47969
47970         Reviewed by Dimitri Glazkov.
47971
47972         rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
47973         architecture, is poorly tested, and has a bunch of quirks.  This patch
47974         rebuilds the core functionality of rebaseline-chromium-webkit-tests on
47975         top of more modern infrastructure.  In the process, we get more code
47976         re-use and better testing.
47977
47978         Once we're satisfied with this new implementation, we can delete the
47979         old implementation.
47980
47981         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
47982         * Scripts/webkitpy/common/net/web.py:
47983         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
47984         * Scripts/webkitpy/layout_tests/port/builders.py:
47985         * Scripts/webkitpy/layout_tests/port/chromium.py:
47986         * Scripts/webkitpy/layout_tests/port/factory.py:
47987         * Scripts/webkitpy/layout_tests/port/webkit.py:
47988         * Scripts/webkitpy/tool/commands/rebaseline.py:
47989         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
47990
47991 2011-08-05  Anders Carlsson  <andersca@apple.com>
47992
47993         Remove PluginHalter
47994         https://bugs.webkit.org/show_bug.cgi?id=65729
47995
47996         Reviewed by Darin Adler.
47997
47998         Remove call to set the allowed plug-in run time.
47999
48000         * DumpRenderTree/mac/DumpRenderTree.mm:
48001         (resetDefaultsToConsistentValues):
48002
48003 2011-08-05  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
48004
48005         Unreviewed build fix for Qt-Minimal buildbot
48006
48007         Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
48008         is disabled.
48009
48010         Rubber-stamped by Holger Freyther.
48011
48012         * QtTestBrowser/cookiejar.cpp:
48013         (TestBrowserCookieJar::TestBrowserCookieJar):
48014
48015 2011-08-05  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
48016
48017         [Qt] QtTestBrowser: Add support for saving cookies on disk
48018         https://bugs.webkit.org/show_bug.cgi?id=65328
48019
48020         Simple cookiejar that saves cookies on disk.
48021
48022         Added menu options to clear cookies (Edit->Clear cookies) and
48023         disable disk cookies (Settings->[ ]Save Cookies on Disk).
48024
48025         Option -no-disk-cookies is also available.
48026
48027         Reviewed by Andreas Kling.
48028
48029         * QtTestBrowser/QtTestBrowser.pro:
48030         * QtTestBrowser/cookiejar.cpp: Added.
48031         * QtTestBrowser/cookiejar.h: Added.
48032         * QtTestBrowser/launcherwindow.cpp:
48033         * QtTestBrowser/launcherwindow.h:
48034         * QtTestBrowser/main.cpp:
48035
48036 2011-08-04  Adam Barth  <abarth@webkit.org>
48037
48038         model.js needs some unit testing
48039         https://bugs.webkit.org/show_bug.cgi?id=65730
48040
48041         Reviewed by Dimitri Glazkov.
48042
48043         These tests do not cover all the functions exported by the model
48044         module.  We'll need to add the remaining ones in the future.
48045
48046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
48047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
48048
48049 2011-08-04  Adam Barth  <abarth@webkit.org>
48050
48051         Another speculative fix for the "svn revision on Windows" problem.
48052
48053         * Scripts/webkitpy/common/checkout/scm/git.py:
48054
48055 2011-08-04  Mark Rowe  <mrowe@apple.com>
48056
48057         Future-proof Xcode configuration settings.
48058
48059         * DumpRenderTree/mac/Configurations/Base.xcconfig:
48060         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
48061         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
48062         * MiniBrowser/Configurations/Base.xcconfig:
48063         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
48064         * MiniBrowser/Configurations/DebugRelease.xcconfig:
48065         * TestWebKitAPI/Configurations/Base.xcconfig:
48066         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
48067         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
48068         * WebKitTestRunner/Configurations/Base.xcconfig:
48069         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
48070         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
48071
48072 2011-08-04  Adam Barth  <abarth@webkit.org>
48073
48074         Fancier debug logging.
48075
48076         * Scripts/webkitpy/layout_tests/controllers/manager.py:
48077
48078 2011-08-04  David Levin  <levin@chromium.org>
48079
48080         [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
48081         https://bugs.webkit.org/show_bug.cgi?id=65685
48082
48083         Reviewed by Dmitry Titov.
48084
48085         * DumpRenderTree/chromium/WebViewHost.cpp:
48086         (WebViewHost::WebViewHost): Intialize WTF threading before
48087         anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
48088         but in some cases code may use WTF without creating WebViewImpl and
48089         WTF code functionality may call WTF::currentThread, which requires
48090         this initialization now.
48091
48092 2011-08-04  Adam Barth  <abarth@webkit.org>
48093
48094         An educated guess at causing the Windows bots on build.webkit.org to
48095         find the SVN revision number.
48096
48097         * Scripts/webkitpy/layout_tests/controllers/manager.py:
48098         * Scripts/webkitpy/layout_tests/port/base.py:
48099
48100 2011-08-04  Adam Barth  <abarth@webkit.org>
48101
48102         More logging to help debug the "no SVN rev on Chromium Windows bots"
48103         bug.  My current theory is that we're trying to detect the SCM system
48104         in the wrong directory.
48105
48106         * Scripts/webkitpy/layout_tests/port/base.py:
48107
48108 2011-08-04  Dimitri Glazkov  <dglazkov@chromium.org>
48109
48110         Speed up webkit-patch optimize-expectations significantly by not collecting test files.
48111         https://bugs.webkit.org/show_bug.cgi?id=65697
48112
48113         I neglected to realize that collecting test names is not necessary for this operation.
48114
48115         Reviewed by Adam Barth.
48116
48117         * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
48118
48119 2011-08-04  Adam Barth  <abarth@webkit.org>
48120
48121         checkout_unittest.js should have better coverage of checkout.js
48122         https://bugs.webkit.org/show_bug.cgi?id=65671
48123
48124         Reviewed by Dimitri Glazkov.
48125
48126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48127             - Remove unused functions.
48128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
48129             - Test remaining public functions in the checkout module.
48130
48131 2011-08-04  Dmitry Lomov  <dslomov@google.com>
48132
48133         https://bugs.webkit.org/show_bug.cgi?id=65706
48134         Run run-unit-tests on release mode test bots.
48135         Reenabling after 61812 is fixed.
48136
48137         Reviewed by Adam Roben.
48138
48139         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
48140
48141 2011-08-04  Adam Barth  <abarth@webkit.org>
48142
48143         builders.js needs unit tests
48144         https://bugs.webkit.org/show_bug.cgi?id=65670
48145
48146         Reviewed by Dimitri Glazkov.
48147
48148         This test requires somewhat large test fixtures, but using real
48149         examples seemed better than trimming them down too much.
48150
48151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
48152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
48153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
48154             - Note: trac_unittests.js doesn't exist (yet!).
48155
48156 2011-08-04  Alexis Menard  <alexis.menard@openbossa.org>
48157
48158         [Qt] Make navigation actions properly usable in QML.
48159         https://bugs.webkit.org/show_bug.cgi?id=65624
48160
48161         Fix compilation after the introduction of QWebNavigationController.
48162
48163         Reviewed by Benjamin Poulain.
48164
48165         * MiniBrowser/qt/BrowserView.cpp:
48166         (BrowserView::navigationAction):
48167
48168 2011-08-04  Adam Barth  <abarth@webkit.org>
48169
48170         Another subtle bug due to lack of testing in main.js.  :(
48171
48172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48173
48174 2011-08-04  Adam Barth  <abarth@webkit.org>
48175
48176         Fix types.  Sadly, main.js has no test coverage.  (I need to think
48177         about how to test this part of the code.)
48178
48179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48180
48181 2011-08-04  Adam Barth  <abarth@webkit.org>
48182
48183         bugzilla.js is missing unit tests
48184         https://bugs.webkit.org/show_bug.cgi?id=65656
48185
48186         Reviewed by Adam Roben.
48187
48188         Testing makes perfect.
48189
48190         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
48191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
48192         (NetworkSimulator.prototype.runTest.get if):
48193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
48194
48195 2011-08-04  Adam Barth  <abarth@webkit.org>
48196
48197         Add missing license blocks to garden-o-matic
48198         https://bugs.webkit.org/show_bug.cgi?id=65654
48199
48200         Reviewed by Dimitri Glazkov.
48201
48202         This patch is entirely boilerplate.
48203
48204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
48205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
48206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
48207         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
48208         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48209         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
48210         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
48211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48212         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
48213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
48216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
48217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
48218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
48219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
48220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
48221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
48222
48223 2011-08-04  Adam Barth  <abarth@webkit.org>
48224
48225         garden-o-matic needs a way to mock out the network
48226         https://bugs.webkit.org/show_bug.cgi?id=65653
48227
48228         Reviewed by Dimitri Glazkov.
48229
48230         This patch introduces the net module, which is a useful mock point for
48231         abstracting away the network.  Future patches will use this
48232         infrastructure to test some currently untested code.
48233
48234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
48235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
48236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
48237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
48238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
48241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
48242         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
48243         (NetworkSimulator):
48244         (NetworkSimulator.prototype.scheduleCallback):
48245         (NetworkSimulator.prototype.runTest):
48246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
48247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
48248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
48249         * Scripts/webkitpy/tool/servers/gardeningserver.py:
48250
48251 2011-08-03  Adam Barth  <abarth@webkit.org>
48252
48253         Use failureInfo more pervasively in garden-o-matic
48254         https://bugs.webkit.org/show_bug.cgi?id=65650
48255
48256         Reviewed by Dimitri Glazkov.
48257
48258         These three variable appears in concert together many places.  This
48259         patch unifies the remaining uses into being failureInfo objects, which
48260         saves some marshalling.
48261
48262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48263         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
48264         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
48265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
48266         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
48267
48268 2011-08-03  Adam Barth  <abarth@webkit.org>
48269
48270         garden-o-matic should be able to update expecations from the details pane
48271         https://bugs.webkit.org/show_bug.cgi?id=65648
48272
48273         Reviewed by Dimitri Glazkov.
48274
48275         The new button queues up the updates, which get executed all at once.
48276
48277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48280
48281 2011-08-03  Adam Barth  <abarth@webkit.org>
48282
48283         Add UI to garden-o-matic for updating expectations
48284         https://bugs.webkit.org/show_bug.cgi?id=65644
48285
48286         Reviewed by Dimitri Glazkov.
48287
48288         The patch plumbs the UI back to the gardening server, but the gardening
48289         server endpoint is just a stub at this point.
48290
48291         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48295         * Scripts/webkitpy/tool/servers/gardeningserver.py:
48296         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
48297
48298 2011-08-03  Adam Barth  <abarth@webkit.org>
48299
48300         garden-o-matic details view should queue rebaselines for later execution
48301         https://bugs.webkit.org/show_bug.cgi?id=65636
48302
48303         Reviewed by Dimitri Glazkov.
48304
48305         This patch doesn't contain any confirmation UI, but we'll probably want
48306         that at some point.
48307
48308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48310         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48311         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48312
48313 2011-08-03  Kentaro Hara  <haraken@google.com>
48314
48315         Implement EventSender.scalePageBy()
48316         https://bugs.webkit.org/show_bug.cgi?id=58013
48317
48318         Reviewed by Darin Fisher.
48319
48320         Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
48321         and then sets a scroll position to (x, y). Enabled the tests that had been waiting
48322         for the implementation of EventSender.scalePageBy(f, x, y).
48323
48324         Tests: compositing/scaling/tiled-layer-recursion.html
48325                fast/repaint/scale-page-shrink.html
48326                fast/dom/Element/scale-page-client-rects.html
48327                fast/dom/Range/scale-page-client-rects.html
48328                fast/events/scroll-in-scaled-page-with-overflow-hidden.html
48329                fast/dom/Element/scale-page-bounding-client-rect.html
48330                fast/dom/Range/scale-page-bounding-client-rect.html
48331
48332         * DumpRenderTree/chromium/EventSender.cpp:
48333         (EventSender::EventSender): Added bindings for scalePageBy().
48334         (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
48335         * DumpRenderTree/chromium/EventSender.h:
48336         * DumpRenderTree/chromium/TestShell.cpp:
48337         (TestShell::resetTestController): Resets the scale factor to 1.
48338
48339 2011-08-03  David Levin  <levin@chromium.org>
48340
48341         Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
48342         https://bugs.webkit.org/show_bug.cgi?id=65652
48343
48344         Reviewed by Adam Barth.
48345
48346         * Scripts/webkitpy/style/checkers/cpp.py:
48347         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
48348
48349 2011-08-03  Filip Pizlo  <fpizlo@apple.com>
48350
48351         Adding Filip Pizlo to committer list.
48352
48353         Unreviewed.
48354
48355         * Scripts/webkitpy/common/config/committers.py:
48356
48357 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
48358
48359         Add "optimize-expectations" command to webkit-patch.
48360         https://bugs.webkit.org/show_bug.cgi?id=65633
48361
48362         For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
48363
48364         Reviewed by Adam Barth.
48365
48366         * Scripts/webkitpy/tool/commands/__init__.py: Added command.
48367         * Scripts/webkitpy/tool/commands/expectations.py: Added.
48368
48369 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
48370
48371         Allow multiple bug identifiers in test expectations.
48372         https://bugs.webkit.org/show_bug.cgi?id=65642
48373
48374         Reviewed by Adam Barth.
48375
48376         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
48377         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
48378
48379 2011-08-03  Dimitri Glazkov  <dglazkov@chromium.org>
48380
48381         Teach BuilderToPort to distinguish between Release and Debug builders.
48382         https://bugs.webkit.org/show_bug.cgi?id=65628
48383
48384         Reviewed by Adam Barth.
48385
48386         * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
48387         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
48388
48389 2011-08-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
48390
48391         [Qt] Fix running qmltests for WK2 in the bot
48392         https://bugs.webkit.org/show_bug.cgi?id=65621
48393
48394         Reviewed by Csaba Osztrogonác.
48395
48396         The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
48397         but now there's the case for WK2 UIProcess tests as well.
48398
48399         * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
48400
48401 2011-08-02  Dimitri Glazkov  <dglazkov@chromium.org>
48402
48403         Add a way to edit test expectations.
48404         https://bugs.webkit.org/show_bug.cgi?id=64922
48405
48406         Implements a TestExpectationsEditor, which provides a standard way to
48407         update and remove test expectations.
48408
48409         Reviewed by Adam Barth.
48410
48411         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
48412             added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
48413             enchilada.
48414         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
48415
48416 2011-08-03  Andreas Kling  <kling@webkit.org>
48417
48418         [Qt] MiniBrowser: Unbreak load progress indication.
48419         https://bugs.webkit.org/show_bug.cgi?id=65614
48420
48421         Reviewed by Kenneth Rohde Christiansen.
48422
48423         loadProgress() was renamed to loadProgressChanged().
48424
48425         * MiniBrowser/qt/BrowserWindow.cpp:
48426         (BrowserWindow::BrowserWindow):
48427         (BrowserWindow::onLoadProgressChanged):
48428         * MiniBrowser/qt/BrowserWindow.h:
48429
48430 2011-08-03  Martin Robinson  <mrobinson@igalia.com>
48431
48432         Build fix for WebKit2GTK+.
48433
48434         * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
48435         of the library dependencies of the injected bundle.
48436
48437 2011-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
48438
48439         [GTK] Install web and plugin processes in libexecdir instead of bindir
48440         https://bugs.webkit.org/show_bug.cgi?id=65600
48441
48442         Reviewed by Martin Robinson.
48443
48444         Set WEBKIT_EXEC_PATH environment variable to use web and plugin
48445         process from current directory instead of the intalled ones.
48446
48447         * MiniBrowser/gtk/GNUmakefile.am:
48448         * MiniBrowser/gtk/main.c:
48449         (main):
48450         * WebKitTestRunner/GNUmakefile.am:
48451         * WebKitTestRunner/gtk/main.cpp:
48452         (main):
48453
48454 2011-08-02  Anders Carlsson  <andersca@apple.com>
48455
48456         Add mac-lion platform to old-run-webkit-tests
48457         https://bugs.webkit.org/show_bug.cgi?id=65577
48458
48459         * Scripts/old-run-webkit-tests:
48460         * Scripts/webkitdirs.pm:
48461         (isLion):
48462
48463 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
48464
48465         Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
48466         https://bugs.webkit.org/show_bug.cgi?id=65554
48467
48468         Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
48469
48470         Reviewed by Adam Roben.
48471
48472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
48473
48474 2011-08-02  Jochen Eisinger  <jochen@chromium.org>
48475
48476         Implement WebPermissionClient::allowPlugins for layout tests
48477         https://bugs.webkit.org/show_bug.cgi?id=33991
48478
48479         Reviewed by Adam Barth.
48480
48481         * DumpRenderTree/chromium/LayoutTestController.cpp:
48482         (LayoutTestController::LayoutTestController):
48483         (LayoutTestController::setPluginsAllowed):
48484         * DumpRenderTree/chromium/LayoutTestController.h:
48485         * DumpRenderTree/chromium/WebPermissions.cpp:
48486         (WebPermissions::allowPlugins):
48487         (WebPermissions::setPluginsAllowed):
48488         (WebPermissions::reset):
48489         * DumpRenderTree/chromium/WebPermissions.h:
48490
48491 2011-08-02  Adam Barth  <abarth@webkit.org>
48492
48493         TestFailures unit tests leak a global variable
48494         https://bugs.webkit.org/show_bug.cgi?id=65500
48495
48496         Reviewed by Adam Roben.
48497
48498         qunit detects the leak if you check the "noglobals" box on run-unittests.html.
48499
48500         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
48501
48502 2011-08-02  Alexandru Chiculita  <achicu@adobe.com>
48503
48504         CSS Regions build bot should archive and upload output files
48505         https://bugs.webkit.org/show_bug.cgi?id=65200
48506
48507         Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
48508         upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
48509         a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
48510         in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
48511
48512         The "features" argument is now taken into account when determining the name of the archive on the server. That
48513         was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
48514
48515         Reviewed by Adam Roben.
48516
48517         * BuildSlaveSupport/build.webkit.org-config/config.json:
48518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
48519
48520 2011-08-02  Patrick Gansterer  <paroga@webkit.org>
48521
48522         Fix _win32_check_running_pid on 64bit windows python
48523         https://bugs.webkit.org/show_bug.cgi?id=64950
48524
48525         Reviewed by Adam Roben.
48526
48527         Use the correct types for the PROCESSENTRY32 struct.
48528         th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
48529         Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
48530         failure, when calling the Process32First function.
48531         This is covered by the executive unittest.
48532
48533         * Scripts/webkitpy/common/system/executive.py:
48534
48535 2011-08-01  Adam Barth  <abarth@webkit.org>
48536
48537         garden-o-matic should call optimize-baselines when rebaselining tests
48538         https://bugs.webkit.org/show_bug.cgi?id=65499
48539
48540         Reviewed by Dimitri Glazkov.
48541
48542         I took the opportunity to modernize this code to use some of our more
48543         powerful primitives from base.
48544
48545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
48546         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
48547         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
48548         * Scripts/webkitpy/tool/servers/gardeningserver.py:
48549         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
48550
48551 2011-08-01  Stephanie Lewis  <slewis@apple.com>
48552
48553         Finish reconfiguration started by Lucas Forschler
48554         Reconfigured slaves:
48555         Removed Leopard Intel Release (Build)
48556         Removed Leopard Intel Release (Tests)
48557         Remove apple-pixel-1
48558         Added Lion slaves from disabled Leopard slaves
48559
48560         Added builders:
48561         Lion Intel Release (Build)
48562         Lion Intel Debug (Build)
48563         Lion Intel Release (Tests)
48564         Lion Intel Release WK2 (Tests)
48565         Lion Intel Debug (Tests)
48566         Lion Intel Debug WK2 (Tests)
48567
48568         Added triggers:
48569         lion-intel-debug-tests
48570         lion-intel-debug-test-wk2
48571         lion-intel-release-tests
48572         lion-intel-release-tests-wk2
48573
48574         Removed trigger:
48575         leopard-intel-release-tests
48576
48577         Added PlatformSpecificScheduler:
48578         mac-lion
48579
48580         Added "mac-lion" to build.py and build_unitttest.py
48581
48582         Reviewed by Mark Rowe.
48583
48584         * BuildSlaveSupport/build.webkit.org-config/config.json:
48585         * Scripts/webkitpy/common/config/build.py:
48586         * Scripts/webkitpy/common/config/build_unittest.py:
48587
48588
48589 2011-08-01  Adam Barth  <abarth@webkit.org>
48590
48591         webkit-patch needs to be able to "optimize" the storage of baselines on disk
48592         https://bugs.webkit.org/show_bug.cgi?id=65418
48593
48594         Reviewed by Dimitri Glazkov.
48595
48596         If we're not careful when rebaselining tests, we can end up with lots
48597         of duplicate expected results files in the tree.  This patch adds a
48598         webkit-patch command that optimizes the storage of expected results on
48599         disk.
48600
48601         This command is similar to deduplicate-tests, except that it can move
48602         test results around rather than just remove duplicate results.
48603
48604         Unfortunately, this problem is very tricky because the baseline search
48605         structure is a hypergraph.  This patch include a huerstic optimizer
48606         that appears to work on a bunch of examples I've tried.  We'll likely
48607         need to refine it as gain experience.
48608
48609         * Scripts/webkitpy/common/system/filesystem.py:
48610         * Scripts/webkitpy/tool/commands/rebaseline.py:
48611
48612 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
48613
48614         Teach TestExpectationSerializer about parsed expectations.
48615         https://bugs.webkit.org/show_bug.cgi?id=65444
48616
48617         This is a bit largish in size, but the essentials are:
48618         * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
48619         * We now store original content of the expectation line on TestExpectationLine.
48620         * Lots of tests.
48621
48622         Reviewed by Adam Barth.
48623
48624         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
48625             populate macros correctly, also fixed an issue where we incorrectly returned an empty list
48626             for all configurations.
48627         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
48628         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
48629             refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
48630             changed to store and use TestExpectationLine.original_string.
48631         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
48632
48633 2011-08-01  Adam Barth  <abarth@webkit.org>
48634
48635         Remove unused functionality from gardeningserver
48636         https://bugs.webkit.org/show_bug.cgi?id=65479
48637
48638         Reviewed by Dimitri Glazkov.
48639
48640         We now handle these operations directly from the front-end.  That means
48641         they work even without the gardening server running!
48642
48643         Also, add some missing files to the list of static files.
48644
48645         * Scripts/webkitpy/tool/servers/gardeningserver.py:
48646         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
48647
48648 2011-08-01  Dimitri Glazkov  <dglazkov@chromium.org>
48649
48650         Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
48651         https://bugs.webkit.org/show_bug.cgi?id=65413
48652
48653         Reviewed by Adam Barth.
48654
48655         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
48656             existing code to use it.
48657         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
48658
48659 2011-08-01  Adam Barth  <abarth@webkit.org>
48660
48661         Refactor bugzilla.js for use by garden-o-matic
48662         https://bugs.webkit.org/show_bug.cgi?id=65450
48663
48664         Reviewed by Dimitri Glazkov.
48665
48666         This patch refactors bugzilla.js to use the AsynchronousCache and
48667         updates the style to use a module instead of an object.  This patch
48668         then fixes all the existing code that uses this class to use the new
48669         API style.
48670
48671         This main benefit of this patch is we remove the tricky manual caching
48672         and this code is now available to use in garden-o-matic (since the
48673         dependency on Utilities.js is now gone).
48674
48675         I ran all the unit tests and poked around in TestFailures a bit to see
48676         that everything seemed to be working properly.
48677
48678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
48679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
48680         (FailingTestsBugForm):
48681         (FailingTestsBugForm.prototype._createBugTitle):
48682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
48683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
48684         (FlakyTestBugForm):
48685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
48686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
48687         (NewBugForm):
48688         (NewBugForm.prototype.domElement):
48689         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
48690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
48691         (TestRelatedBugForm):
48692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
48693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
48694         (ViewController.prototype._displayBuilder.start):
48695         (ViewController.prototype._displayBuilder):
48696         (ViewController.prototype._domForAuxiliaryUIElements):
48697         (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
48698         (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
48699         (ViewController.prototype._domForPossiblyFlakyTests):
48700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
48701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
48703
48704 2011-08-01  Adam Barth  <abarth@webkit.org>
48705
48706         garden-o-matic shouldn't require local server to determine if compile failed
48707         https://bugs.webkit.org/show_bug.cgi?id=65446
48708
48709         Reviewed by Dimitri Glazkov.
48710
48711         This patch adds some basic bindings for the buildbot JSON API.  I
48712         wanted to use Buildbot.js an Builder.js from the original TestFailures,
48713         but they make a number of WebKit-specific assumptions.  We'll
48714         eventually need to reconcile these pieces of code.
48715
48716         I should really add tests for this code, but that will require me to
48717         build a better mock network.  I'll be happy to do that in a follow-up
48718         patch.
48719
48720         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
48721             - It's very unclear to me whether didFail is correct.  Supposedly
48722               the first entry here is the exit code of the step, which is 0 on
48723               success.  I suspect we'll need to improve this function over time.
48724         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48726         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
48727
48728 2011-08-01  Adam Barth  <abarth@webkit.org>
48729
48730         garden-o-matic should show all failures, even ones that it can't find a regression range for
48731         https://bugs.webkit.org/show_bug.cgi?id=65447
48732
48733         Reviewed by Dimitri Glazkov.
48734
48735         Previously, we just wouldn't display test failures that we couldn't
48736         identify a regression range for (or whose regression range had fallen
48737         off the page).  This patch just displays them at the end of the list,
48738         which is slightly (but not much) better.
48739
48740         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48741
48742 2011-08-01  Jeff Miller  <jeffm@apple.com>
48743
48744         Windows build fix after r92096.
48745
48746         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
48747         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
48748
48749 2011-07-31  Anders Carlsson  <andersca@apple.com>
48750
48751         DownloadDecideDestinationCrash WebKit2 API tests crashes
48752         https://bugs.webkit.org/show_bug.cgi?id=65442
48753
48754         Reviewed by Sam Weinig.
48755
48756         Copy the 18-characters.html file to the destination directory so we won't
48757         crash trying to make an URL for it.
48758
48759         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48760
48761 2011-07-31  Anders Carlsson  <andersca@apple.com>
48762
48763         Fix SpacebarScrolling WebKit2 API test
48764         https://bugs.webkit.org/show_bug.cgi?id=65431
48765
48766         Reviewed by Sam Weinig.
48767
48768         Add a way to do platform-specific bundle initialization, and use it to disable smooth
48769         scrolling. Also make it possible for a test to load the injected bundle without actually running
48770         a test from it.
48771
48772         * TestWebKitAPI/InjectedBundleController.cpp:
48773         (TestWebKitAPI::InjectedBundleController::initialize):
48774         * TestWebKitAPI/InjectedBundleController.h:
48775         * TestWebKitAPI/PlatformUtilities.cpp:
48776         (TestWebKitAPI::Util::createContextWithInjectedBundle):
48777         * TestWebKitAPI/PlatformUtilities.h:
48778         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
48779         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
48780         (TestWebKitAPI::TEST):
48781         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
48782         (TestWebKitAPI::InjectedBundleController::platformInitialize):
48783         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
48784         (TestWebKitAPI::InjectedBundleController::platformInitialize):
48785         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
48786
48787 2011-07-31  Dimitri Glazkov  <dglazkov@chromium.org>
48788
48789         Use set comparison to find duplicate or overlapping specifiers in test expectations.
48790         https://bugs.webkit.org/show_bug.cgi?id=65430
48791
48792         Reviewed by Adam Barth.
48793
48794         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
48795             of a set is wrong.
48796         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
48797             regressions.
48798
48799 2011-07-31  Xan Lopez  <xlopez@igalia.com>
48800
48801         Group dependencies CFLAGS together.
48802
48803         * GNUmakefile.am: ditto.
48804
48805 2011-07-31  Daniel Bates  <dbates@webkit.org>
48806
48807         Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
48808         (https://bugs.webkit.org/show_bug.cgi?id=65419).
48809
48810         * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
48811
48812 2011-07-30  Patrick Gansterer  <paroga@webkit.org>
48813
48814         Fix ports_unittest.py on native windows
48815         https://bugs.webkit.org/show_bug.cgi?id=64959
48816
48817         Reviewed by Adam Barth.
48818
48819         Replace WebKitPort.script_path with WebKitPort.script_shell_command.
48820         The latter includes the interpreter executable required on native windows.
48821
48822         * Scripts/webkitpy/common/config/ports_unittest.py:
48823
48824 2011-07-30  Adam Barth  <abarth@webkit.org>
48825
48826         Properly escape regular expressions.  (Maybe these shouldn't be regular
48827         expressions?)
48828
48829         * Scripts/webkitpy/tool/commands/rebaseline.py:
48830
48831 2011-07-30  Adam Barth  <abarth@webkit.org>
48832
48833         Add support for Win7 to garden-o-matic.
48834
48835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
48836         * Scripts/webkitpy/tool/commands/rebaseline.py:
48837
48838 2011-07-30  Adam Barth  <abarth@webkit.org>
48839
48840         garden-o-matic regression ranges expand after fast bots start passing
48841         https://bugs.webkit.org/show_bug.cgi?id=65406
48842
48843         Reviewed by Dimitri Glazkov.
48844
48845         Once the gardener has fixed a problem, the fast bots pick up the fix,
48846         which means we end up using the slow bots to compute the regression
48847         range.  Unfortunately, the slow bots give us large regression ranges,
48848         leading to this strange effect where the regression range quality
48849         degrades as fixes roll in.
48850
48851         This patch causes us to remember the previous regression ranges we've
48852         seen and to use that information in the future, as long as it's
48853         consistent with the new information we receive.
48854
48855         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48856
48857 2011-07-30  Adam Barth  <abarth@webkit.org>
48858
48859         garden-o-matic should have a Refresh button to update its display
48860         https://bugs.webkit.org/show_bug.cgi?id=65403
48861
48862         Reviewed by Dimitri Glazkov.
48863
48864         The refresh button should be faster and less disruptive than the browser's reload button.
48865
48866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
48867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
48868
48869 2011-07-30  Adam Barth  <abarth@webkit.org>
48870
48871         garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
48872         https://bugs.webkit.org/show_bug.cgi?id=65231
48873
48874         Reviewed by Dimitri Glazkov.
48875
48876         The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
48877
48878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
48879
48880 2011-07-30  Adam Barth  <abarth@webkit.org>
48881
48882         garden-o-matic should strikeout revisions that have been rolled out
48883         https://bugs.webkit.org/show_bug.cgi?id=65227
48884
48885         Reviewed by Dimitri Glazkov.
48886
48887         This helps gardeners keep track of which problems have been solved.
48888
48889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
48890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
48891         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
48892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
48893
48894 2011-07-30  Adam Barth  <abarth@webkit.org>
48895
48896         Add missing files to the server.
48897
48898         * Scripts/webkitpy/tool/servers/gardeningserver.py:
48899
48900 2011-07-29  Adam Barth  <abarth@webkit.org>
48901
48902         Actually import the logging module!
48903
48904         * Scripts/webkitpy/common/checkout/scm/git.py:
48905
48906 2011-07-29  Adam Barth  <abarth@webkit.org>
48907
48908         More debug logging.  Maybe we're running the git version of this
48909         function somehow?  (That would explain why it doesn't work!)
48910
48911         * Scripts/webkitpy/common/checkout/scm/git.py:
48912
48913 2011-07-29  Adam Barth  <abarth@webkit.org>
48914
48915         Add some temporary debug logging messages to try to understand why the
48916         windows bots can't figure out their current SVN revision.
48917
48918         * Scripts/webkitpy/common/checkout/scm/svn.py:
48919
48920 2011-07-29  Adam Barth  <abarth@webkit.org>
48921
48922         Chromium try servers should use downstream test_expectations
48923         https://bugs.webkit.org/show_bug.cgi?id=65390
48924
48925         Reviewed by Dirk Pranke.
48926
48927         Otherwise the try servers will report bogus failures.
48928
48929         * Scripts/webkitpy/layout_tests/port/chromium.py:
48930
48931 2011-07-29  Dimitri Glazkov  <dglazkov@chromium.org>
48932
48933         Fix an error in macro collapsing, refactor code to be pretty.
48934         https://bugs.webkit.org/show_bug.cgi?id=65387
48935
48936         My set math was wrong.
48937
48938         Reviewed by Adam Barth.
48939
48940         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
48941         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
48942
48943 2011-07-27  Ryuan Choi  <ryuan.choi@samsung.com>
48944
48945         Style bot complains about EFL-specific forward declaration naming.
48946         https://bugs.webkit.org/show_bug.cgi?id=64680
48947
48948         Exclude EFL-specific forward declarations from indentifiers with underscores checks.
48949
48950         Reviewed by Adam Barth.
48951
48952         * Scripts/webkitpy/style/checkers/cpp.py:
48953         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
48954
48955 2011-07-27  Adam Roben  <aroben@apple.com>
48956
48957         Use wacky !svn/bc URLs consistently in Leaks Viewer
48958
48959         This ensures that any resources loaded via relative URLs will still get pulled from the same
48960         revision of Subversion.
48961
48962         Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
48963
48964         Reviewed by David Kilzer.
48965
48966         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
48967         !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
48968         from Subversion.
48969
48970 2011-07-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
48971
48972         [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
48973         https://bugs.webkit.org/show_bug.cgi?id=65269
48974
48975         Reviewed by Kent Tamura.
48976
48977         WorkQueueItemEfl.h was being included by efl's
48978         LayoutTestControllerEfl.cpp, however the top-level
48979         LayoutTestController still included WorkQueueItem.h, causing a lot of
48980         type mismatches when running the WorkQueueItem code.
48981
48982         We can stick to the original WorkQueueItem header by making a few
48983         changes to EFL's LayoutTestController.
48984
48985         This should make tests such as
48986         fast/loader/non-deferred-substitute-load.html stop crashing.
48987
48988         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
48989         (LayoutTestController::queueLoad):
48990         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
48991         (LoadItem::invoke):
48992         (LoadHTMLStringItem::invoke):
48993         (ScriptItem::invoke):
48994         * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
48995
48996 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
48997
48998         Re-add unit tests I accidentally zapped in r91878.
48999
49000         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
49001
49002 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
49003
49004         Replace SpecificityCalculator with TestConfiguration-driven logic.
49005         https://bugs.webkit.org/show_bug.cgi?id=65206
49006
49007         Use our newly-acquired ability to expand modifiers into a set of
49008         matching TestConfiguration instances to calculate specificity and
49009         determine whether expectation applies to a given test configuration.
49010
49011         Also, store bug modifier on TestExpectationsLine.
49012
49013         Reviewed by Adam Barth.
49014
49015         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
49016             test configuration matching, removed a bunch of code.
49017         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
49018
49019
49020 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
49021
49022         Allow ports to specify their own test expectation specifier macros.
49023         https://bugs.webkit.org/show_bug.cgi?id=65291
49024
49025         Reviewed by Adam Barth.
49026
49027         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
49028         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
49029         * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
49030         * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
49031         * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
49032
49033 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
49034
49035         Allow TestConfigurationConverter report conversion errors.
49036         https://bugs.webkit.org/show_bug.cgi?id=65287
49037
49038         Also, fix a few miscellaneous testing issues.
49039
49040         Reviewed by Adam Barth.
49041
49042         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
49043         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
49044         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
49045             was created. 'default' is not a valid build type.
49046         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
49047
49048 2011-07-27  Dimitri Glazkov  <dglazkov@chromium.org>
49049
49050         Teach all ports about their test configurations.
49051         https://bugs.webkit.org/show_bug.cgi?id=65278
49052
49053         Each Port object should return a valid set of all TestConfiguration instances,
49054         available for this port.
49055
49056         Reviewed by Philippe Normand.
49057
49058         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
49059             since it is different for each port.
49060         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
49061         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
49062             all test configurations as a param.
49063         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
49064         * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
49065         * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
49066         * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
49067         * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
49068         * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
49069         * Scripts/webkitpy/layout_tests/port/win.py:
49070         * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
49071         * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
49072         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
49073         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
49074
49075 2011-07-27  Benjamin Poulain  <benjamin@webkit.org>
49076
49077         [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
49078         https://bugs.webkit.org/show_bug.cgi?id=62969
49079
49080         Reviewed by Andreas Kling.
49081
49082         Co-authored with Simon Hausmann  <simon.hausmann@nokia.com>
49083
49084         With the scene graph, the interface to have a window on screen is
49085         QSGCanvas. QGraphicsView is not used, and openGL is an enforced
49086         dependency.
49087
49088         Both the BrowserView and the WebKitTest runner are changed from
49089         QGraphicsView to QSGCanvas.
49090
49091         * MiniBrowser/qt/BrowserView.cpp:
49092         (BrowserView::BrowserView):
49093         (BrowserView::resizeEvent):
49094         (BrowserView::view):
49095         * MiniBrowser/qt/BrowserView.h:
49096         * MiniBrowser/qt/BrowserWindow.cpp:
49097         (BrowserWindow::BrowserWindow):
49098         (BrowserWindow::urlChanged):
49099         (BrowserWindow::~BrowserWindow):
49100         * MiniBrowser/qt/BrowserWindow.h:
49101         * MiniBrowser/qt/MiniBrowser.pro:
49102         * MiniBrowser/qt/main.cpp:
49103         (main):
49104         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
49105         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
49106         (WTR::WebView::WebView):
49107         (WTR::PlatformWebView::PlatformWebView):
49108         * WebKitTestRunner/qt/WebKitTestRunner.pro:
49109
49110 2011-07-27  Sheriff Bot  <webkit.review.bot@gmail.com>
49111
49112         Unreviewed, rolling out r91792.
49113         http://trac.webkit.org/changeset/91792
49114         https://bugs.webkit.org/show_bug.cgi?id=65242
49115
49116         It broke NRWT on Qt and GTK (Requested by Ossy_night on
49117         #webkit).
49118
49119         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
49120         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
49121         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
49122         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
49123         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
49124         * Scripts/webkitpy/layout_tests/port/test.py:
49125
49126 2011-07-26  Adam Barth  <abarth@webkit.org>
49127
49128         Switch to an older idiom that works on Python 2.5.
49129
49130         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
49131
49132 2011-07-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
49133
49134         Add an exception to coding style check for EFL port.
49135         https://bugs.webkit.org/show_bug.cgi?id=65162
49136
49137         Add an exception of whitespace/declaration for EFL port. Because,
49138         '*' operator is next to variable in EFL coding style.
49139
49140         Reviewed by Kent Tamura.
49141
49142         * Scripts/webkitpy/style/checker.py:
49143
49144 2011-07-26  Keith Kyzivat  <keith.kyzivat@nokia.com>
49145
49146         [Qt] Add option to turn on disk caching in QtTestBrowser
49147         https://bugs.webkit.org/show_bug.cgi?id=65007
49148
49149         Reviewed by Noam Rosenthal.
49150
49151         Add menu item and command line option to turn on disk caching in
49152         QtTestBrowser. Simple QNetworkDiskCache added to the page's
49153         QNetworkAccssManager.
49154
49155         * QtTestBrowser/launcherwindow.cpp:
49156         (LauncherWindow::initializeView):
49157         (LauncherWindow::createChrome):
49158         (LauncherWindow::setDiskCache):
49159         * QtTestBrowser/launcherwindow.h:
49160         (WindowOptions::WindowOptions):
49161         * QtTestBrowser/main.cpp:
49162         (LauncherApplication::handleUserOptions):
49163
49164 2011-07-26  Sadrul Habib Chowdhury  <sadrul@chromium.org>
49165
49166         Add support for download='filename' attribute in anchors.
49167         https://bugs.webkit.org/show_bug.cgi?id=64580
49168
49169         Reviewed by Adam Barth.
49170
49171         * DumpRenderTree/chromium/WebViewHost.cpp:
49172         (WebViewHost::loadURLExternally):
49173         * DumpRenderTree/chromium/WebViewHost.h:
49174
49175 2011-07-26  Dan Bernstein  <mitz@apple.com>
49176
49177         Rubber-stamped by Anders Carlsson.
49178
49179         Update DumpRenderTree and API tests for the pictograph font family preference.
49180
49181         * DumpRenderTree/mac/DumpRenderTree.mm:
49182         (resetDefaultsToConsistentValues):
49183         * DumpRenderTree/win/DumpRenderTree.cpp:
49184         (resetDefaultsToConsistentValues):
49185         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
49186         (TestWebKitAPI::TEST):
49187         * WebKitTestRunner/TestController.cpp:
49188         (WTR::TestController::resetStateToConsistentValues):
49189
49190 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
49191
49192         Replace SpecificityCalculator with TestConfiguration-driven logic.
49193         https://bugs.webkit.org/show_bug.cgi?id=65206
49194
49195         Use our newly-acquired ability to expand modifiers into a set of
49196         matching TestConfiguration instances to calculate specificity and
49197         determine whether expectation applies to a given test configuration.
49198
49199         Also, store bug modifier on TestExpectationsLine.
49200
49201         Reviewed by Adam Barth.
49202
49203         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
49204         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
49205         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
49206             test configuration matching, removed a bunch of code.
49207         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
49208         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
49209             was created. 'default' is not a valid build type.
49210         * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
49211
49212 2011-07-26  Adam Barth  <abarth@webkit.org>
49213
49214         Increase the information density in garden-o-matic
49215         https://bugs.webkit.org/show_bug.cgi?id=65141
49216
49217         Reviewed by Dimitri Glazkov.
49218
49219         This patch changes lets us show each revision on a single line,
49220         allowing use to show an entire day's worth of commits at once.
49221
49222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
49223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
49224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
49225
49226 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
49227
49228         TestConfigurationConverter should not barf on invalid specifiers.
49229         https://bugs.webkit.org/show_bug.cgi?id=65194
49230
49231         Reviewed by Adam Barth.
49232
49233         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
49234             made it return empty set whenever an invalid specifier is encountered.
49235         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
49236
49237 2011-07-26  Dimitri Glazkov  <dglazkov@chromium.org>
49238
49239         Introduce a way to convert between specifier lists and TestConfiguration sets.
49240         https://bugs.webkit.org/show_bug.cgi?id=65094
49241
49242         Add TestConfigurationConverter, a facility to convert:
49243         1) a set of specifiers into a set of TestConfiguration instances;
49244         2) a set of TestConfiguration instances into a list of sets of specifiers.
49245
49246         Reviewed by Adam Barth.
49247
49248         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
49249         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
49250
49251 2011-07-26  Alexandru Chiculita  <achicu@adobe.com>
49252
49253         CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
49254         https://bugs.webkit.org/show_bug.cgi?id=65171
49255
49256         Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
49257         of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
49258
49259         Reviewed by Adam Roben.
49260
49261         * BuildSlaveSupport/build.webkit.org-config/config.json:
49262         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
49263
49264 2011-07-26  Chris Rogers  <crogers@google.com>
49265
49266         Avoid outputting #EOF twice for web audio tests in chromium DRT
49267         https://bugs.webkit.org/show_bug.cgi?id=65201
49268
49269         Reviewed by Dirk Pranke.
49270
49271         * DumpRenderTree/chromium/TestShell.cpp:
49272         (TestShell::dump):
49273
49274 2011-07-26  Adam Barth  <abarth@webkit.org>
49275
49276         Windows bots on build.chromium.org can't figure out the head_svn_revision
49277         https://bugs.webkit.org/show_bug.cgi?id=65156
49278
49279         Reviewed by Tony Chang.
49280
49281         This patch is a bit of a guess as to the issue based on the
49282         investigation in https://bugs.webkit.org/show_bug.cgi?id=65148.  I'm
49283         not sure whether it will fix the issue, but it seems worth a try.
49284
49285         * Scripts/webkitpy/common/checkout/scm/svn.py:
49286
49287 2011-07-26  Carlos Garcia Campos  <cgarcia@igalia.com>
49288
49289         Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
49290
49291         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
49292         (getPreferredSizeMethod):
49293
49294 2011-07-26  MORITA Hajime  <morrita@google.com>
49295
49296         [Chromium][DRT] MockSpellCheck.cpp should be clang clean
49297         https://bugs.webkit.org/show_bug.cgi?id=65166
49298
49299         Reviewed by Kent Tamura.
49300
49301         * DumpRenderTree/chromium/MockSpellCheck.cpp:
49302         (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
49303
49304 2011-07-25  Patrick Gansterer  <paroga@webkit.org>
49305
49306         Ignore line endings in ChangeLogTests
49307         https://bugs.webkit.org/show_bug.cgi?id=64956
49308
49309         Reviewed by Adam Barth.
49310
49311         Split the lines of the ChangeLog text before comparing them.
49312         This fixes 3 tests on windows, since only the content importent.
49313
49314         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
49315         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
49316
49317 2011-07-25  Adam Barth  <abarth@webkit.org>
49318
49319         Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
49320         https://bugs.webkit.org/show_bug.cgi?id=65148
49321
49322         Reviewed by Tony Chang.
49323
49324         * Scripts/webkitpy/layout_tests/controllers/manager.py:
49325
49326 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49327
49328         Tweak whitespace wrapping to improve readability.
49329         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49330
49331 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49332
49333         Minor tweak to wrap label elements as atomic units.
49334
49335         * TestResultServer/static-dashboards/dashboard_base.js:
49336         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49337
49338 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49339
49340         always show flakiness details on the builder page
49341         https://bugs.webkit.org/show_bug.cgi?id=65139
49342
49343         Reviewed by Tony Chang.
49344
49345         In order to simplify the UI, we hide the flakiness details by default,
49346         but there's no actual use-case for this page without the flakiness details.
49347         So get rid of that option and always show the flakiness details.
49348
49349         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49350
49351 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49352
49353         simplify the UI of the header above the test list table
49354         https://bugs.webkit.org/show_bug.cgi?id=65136
49355
49356         Reviewed by Adam Barth.
49357
49358         Use checkboxes instead of links since this is really about which tests to include.
49359         Ends up using less text and put the checkboxes to the right of the header instead of below it.
49360
49361         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49362         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49363
49364 2011-07-25  Chris Rogers  <crogers@google.com>
49365
49366         Update new-run-webkit-tests to accomodate binary audio data
49367         https://bugs.webkit.org/show_bug.cgi?id=65135
49368
49369         Reviewed by Dirk Pranke.
49370
49371         * Scripts/webkitpy/layout_tests/port/chromium.py:
49372
49373 2011-07-25  Chris Rogers  <crogers@google.com>
49374
49375         Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
49376         https://bugs.webkit.org/show_bug.cgi?id=65039
49377
49378         Reviewed by Tony Chang.
49379
49380         * DumpRenderTree/chromium/LayoutTestController.cpp:
49381         (LayoutTestController::LayoutTestController):
49382         (LayoutTestController::setAudioData):
49383         * DumpRenderTree/chromium/LayoutTestController.h:
49384         (LayoutTestController::audioData):
49385         * DumpRenderTree/chromium/TestEventPrinter.cpp:
49386         (DRTPrinter::handleAudioHeader):
49387         (TestShellPrinter::handleAudioHeader):
49388         * DumpRenderTree/chromium/TestShell.cpp:
49389         (TestShell::dump):
49390
49391 2011-06-07  Martin Robinson  <mrobinson@igalia.com>
49392
49393         Reviewed by Gustavo Noronha Silva.
49394
49395         [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
49396         https://bugs.webkit.org/show_bug.cgi?id=62252
49397
49398         Add a new subclass of WebKitWebView that overrides the size request to
49399         return 1 pixel by 1 pixel. This ensure that it operates properly when
49400         not packed into a GtkScrolledWindow. Also construct the WebKitWebView
49401         with self-scrolling set to true.
49402
49403         * DumpRenderTree/gtk/DumpRenderTree.cpp:
49404         (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
49405         (createWebView): Ditto.
49406         (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
49407         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
49408         (self_scrolling_webkit_web_view_class_init):
49409         (self_scrolling_webkit_web_view_init):
49410         (self_scrolling_webkit_web_view_new):
49411         (sizeRequestMethod):
49412         (getPreferredSizeMethod):
49413         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
49414         * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
49415
49416 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49417
49418         by default hide tests that have passes for all recorded runs
49419         https://bugs.webkit.org/show_bug.cgi?id=65127
49420
49421         Reviewed by Adam Barth.
49422
49423         This is part of simplifying the default views of the dashboard to
49424         make it show less information for the common use cases.
49425
49426         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49427         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49428
49429 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49430
49431         stop generating expectations.json now that it's unused
49432         https://bugs.webkit.org/show_bug.cgi?id=65130
49433
49434         Reviewed by Adam Barth.
49435
49436         * Scripts/webkitpy/layout_tests/controllers/manager.py:
49437         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
49438         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
49439         * TestResultServer/handlers/menu.py:
49440         * TestResultServer/static-dashboards/dashboard_base.js:
49441         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49442
49443 2011-07-25  Ojan Vafai  <ojan@chromium.org>
49444
49445         don't show builders in the flakiness dashboard that have stopped running a given test suite
49446         https://bugs.webkit.org/show_bug.cgi?id=65126
49447
49448         Reviewed by Mihai Parparita.
49449
49450         * TestResultServer/static-dashboards/dashboard_base.js:
49451
49452 2011-07-25  Adam Barth  <abarth@webkit.org>
49453
49454         Overhaul garden-o-matic frontend to integrate revision history and failures
49455         https://bugs.webkit.org/show_bug.cgi?id=65089
49456
49457         Reviewed by Dimitri Glazkov.
49458
49459         This is a major overhaul of the garden-o-matic frontend.  The new UI
49460         integrates the revision history information with failures.  Failures
49461         appear in context adjacent to the revisions that caused them (which are
49462         highlighted).  Each buildbot receives a collumn to the left, which
49463         indicates which revisions that bot has tested and whether that bot
49464         showed the indicated failures.
49465
49466         Failures are selectable with checkboxes, and can then either be
49467         examined or rebaselined.
49468
49469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
49470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
49471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
49472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
49473         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
49474         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
49475         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
49476         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
49477         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
49478
49479 2011-07-25  Holger Hans Peter Freyther  <zecke@selfish.org>
49480
49481         [buildbot] Add Qt Linux MIPSEL Configuration
49482         https://bugs.webkit.org/show_bug.cgi?id=65116
49483
49484         Reviewed by Adam Roben.
49485
49486         Introduce a Qt Linux MIPS EL build slave. The configuration
49487         is a build only configuration.
49488
49489         * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
49490
49491 2011-07-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
49492
49493         [Qt][WK2] Add multi-point touch mocking to MiniBrowser
49494         https://bugs.webkit.org/show_bug.cgi?id=64374
49495
49496         Reviewed by Benjamin Poulain.
49497
49498         Each mouse button generate a touch point. The touch point stay
49499         virtually on screen if the mouse release happened while the Ctrl
49500         modifier was pressed.
49501
49502         * MiniBrowser/qt/MiniBrowserApplication.cpp:
49503         (MiniBrowserApplication::notify):
49504         * MiniBrowser/qt/MiniBrowserApplication.h:
49505
49506 2011-07-25  Balazs Kelemen  <kbalazs@webkit.org>
49507
49508         [Qt][WK2] Use NRWT for Qt-WK2
49509         https://bugs.webkit.org/show_bug.cgi?id=65097
49510
49511         Reviewed by Andreas Kling.
49512
49513         * Scripts/run-webkit-tests:
49514         (useNewRunWebKitTests):
49515
49516 2011-07-24  Sheriff Bot  <webkit.review.bot@gmail.com>
49517
49518         Unreviewed, rolling out r91635.
49519         http://trac.webkit.org/changeset/91635
49520         https://bugs.webkit.org/show_bug.cgi?id=65083
49521
49522         It broke the minimal build (Requested by Ossy___OFFLINE on
49523         #webkit).
49524
49525         * QtTestBrowser/launcherwindow.cpp:
49526         (LauncherWindow::initializeView):
49527         (LauncherWindow::createChrome):
49528         * QtTestBrowser/launcherwindow.h:
49529         (WindowOptions::WindowOptions):
49530         * QtTestBrowser/main.cpp:
49531         (LauncherApplication::handleUserOptions):
49532
49533 2011-07-24  Adam Barth  <abarth@webkit.org>
49534
49535         Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
49536
49537         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
49538         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
49539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
49540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
49541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
49542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
49543
49544 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
49545
49546         TestConfiguration should be hashable and comparable for equality.
49547         https://bugs.webkit.org/show_bug.cgi?id=65070
49548
49549         Reviewed by Adam Barth.
49550
49551         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
49552         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
49553
49554 2011-07-23  Dimitri Glazkov  <dglazkov@chromium.org>
49555
49556         Extract TestConfiguration from base and write a few unit tests to capture current behavior.
49557         https://bugs.webkit.org/show_bug.cgi?id=65066
49558
49559         Reviewed by Adam Barth.
49560
49561         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
49562         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
49563         * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
49564
49565 2011-07-23  Alok Priyadarshi  <alokp@chromium.org>
49566
49567         Switching off acceleration for small canvas broke gpu tests
49568         https://bugs.webkit.org/show_bug.cgi?id=65053
49569
49570         Reviewed by Stephen White.
49571
49572         * DumpRenderTree/chromium/WebPreferences.cpp:
49573         (WebPreferences::reset):
49574         (WebPreferences::applyTo):
49575         * DumpRenderTree/chromium/WebPreferences.h:
49576
49577 2011-07-23  Keith Kyzivat  <keith.kyzivat@nokia.com>
49578
49579         [Qt] Add option to turn on disk caching in QtTestBrowser
49580         https://bugs.webkit.org/show_bug.cgi?id=65007
49581
49582         Reviewed by Noam Rosenthal.
49583
49584         Add menu item and command line option to turn on disk caching in
49585         QtTestBrowser. Simple QNetworkDiskCache added to the page's
49586         QNetworkAccssManager.
49587
49588         * QtTestBrowser/launcherwindow.cpp:
49589         (LauncherWindow::initializeView):
49590         (LauncherWindow::createChrome):
49591         (LauncherWindow::setDiskCache):
49592         * QtTestBrowser/launcherwindow.h:
49593         (WindowOptions::WindowOptions):
49594         * QtTestBrowser/main.cpp:
49595         (LauncherApplication::handleUserOptions):
49596
49597 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49598
49599         Don't match 'DEBUG' when trying to filter BUG modifiers.
49600         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49601         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49602
49603 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49604
49605         Fix issue loading gtests since there's no g_expectations.
49606         Also, make filing a bug file a webkit.org bug, not a crbug since
49607         the link is only shown for layout tests.
49608         * TestResultServer/static-dashboards/dashboard_base.js:
49609         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49610
49611 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49612
49613         pull test expectations into the dashboard from wvn.webkit.org
49614         https://bugs.webkit.org/show_bug.cgi?id=65054
49615
49616         Reviewed by Adam Barth.
49617
49618         Now that svn.webkit.org supports cors headers, we can just grab the txt
49619         file from there instead of generating a JSON file that we upload
49620         to appengine. We'll stop generating the JSON file in a followup patch.
49621
49622         * TestResultServer/static-dashboards/dashboard_base.js:
49623         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49624         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49625
49626 2011-07-22  Adam Barth  <abarth@webkit.org>
49627
49628         Fix typo so the tool works on a case-sensitive file system.
49629
49630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
49631
49632 2011-07-22  Adam Barth  <abarth@webkit.org>
49633
49634         garden-o-matic should know what patches are landing
49635         https://bugs.webkit.org/show_bug.cgi?id=64978
49636
49637         Reviewed by Dimitri Glazkov.
49638
49639         This patch adds a display of the recently committed patches to
49640         garden-o-matic.  The UI needs iteration, but this patch establishes the
49641         plumbing.
49642
49643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
49644             - Teach trac how to extract more information from the commit log.
49645         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
49646             - Add a data attribute for storing the revision.
49647         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
49648             - Add a container for the recent commit history.
49649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
49650             - CSS for displaying non-ugly commit history.
49651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
49652             - Wire up trac to the UI container.
49653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
49654             - A basic, compact display for a list of commits.
49655
49656 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49657
49658         Fix bug when switching from layout-tests to another test-type if
49659         ToT webkit.org is the selected group.
49660         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49661
49662 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49663
49664         Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.
49665         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49666
49667 2011-07-22  Ojan Vafai  <ojan@chromium.org>
49668
49669         simplify the flakiness dashboard to only show modifiers/expectations for the current builder
49670         https://bugs.webkit.org/show_bug.cgi?id=65049
49671
49672         Reviewed by Tony Chang.
49673
49674         This communicates less information, but probably makes the dashboard more usable.
49675         Also make it show that bug lines that don't point to bug numbers still
49676         show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
49677         columns in any view. The data is still used, but only in the view that updates
49678         the test_expectations.txt file.
49679
49680         * TestResultServer/static-dashboards/dashboard_base.js:
49681         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49682         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49683
49684 2011-07-21  Ojan Vafai  <ojan@chromium.org>
49685
49686         hook in the rest of the bots to the dashboard now they run NRWT
49687         https://bugs.webkit.org/show_bug.cgi?id=64985
49688
49689         Reviewed by Adam Barth.
49690
49691         * TestResultServer/static-dashboards/builders.js:
49692
49693 2011-07-22  Alexey Proskuryakov  <ap@apple.com>
49694
49695         Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.
49696
49697         Unreviewed.
49698
49699         * Scripts/webkitpy/common/config/committers.py:
49700
49701 2011-07-22  Michal Pakula vel Rutka  <m.pakula@samsung.com>
49702
49703         [EFL] ewk_frame_hit_test_new enchancement
49704         https://bugs.webkit.org/show_bug.cgi?id=64260
49705
49706         Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
49707         Replacing Ewk_Hit_Test_Result_Context structure 'flags'
49708         in hit test output to by enum 'context'.
49709
49710         Reviewed by Antonio Gomes.
49711
49712         * EWebLauncher/main.c:
49713         (on_key_down):
49714
49715 2011-07-21  Adam Roben  <aroben@apple.com>
49716
49717         Fix typo in TestFailures
49718
49719         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
49720
49721 2011-07-21  Ojan Vafai  <ojan@chromium.org>
49722
49723         simplify gtest display now that we strip modifiers from the JSON
49724         https://bugs.webkit.org/show_bug.cgi?id=64990
49725
49726         Reviewed by Adam Barth.
49727
49728         Now that names are normalized, we can remove all the code that
49729         handles gtest name changes (e.g. for adding modifiers like DISABLED_).
49730         Instead, if you try to list a test with a modifier in it, we need
49731         to strip the modifier so we get the normalized value.
49732
49733         We also get rid of the concept of extra/missing expectations for gtests.
49734         In a patch soon, we'll stop showing extra/missing expectations from the UI
49735         entirely and only leave it for the special updating test_expectations.txt
49736         view of the dashboard, which doesn't apply to gtests.
49737
49738         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49739         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
49740
49741 2011-07-21  Adam Barth  <abarth@webkit.org>
49742
49743         Refactor Trac.js for use in garden-o-matic
49744         https://bugs.webkit.org/show_bug.cgi?id=64998
49745
49746         Reviewed by Adam Roben.
49747
49748         This patch refactors Trac.js to match the architecture and style of
49749         garden-o-matic.  I've also factored AsynchronousCache out of Trac (and
49750         moved it to base) because it was redundant with some other code we
49751         already had.
49752
49753         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
49754         (FailingTestsBugForm):
49755         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
49756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
49757         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
49758         (ViewController.prototype._displayBuilder.start):
49759         (ViewController.prototype._displayBuilder):
49760         (ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
49761         (ViewController.prototype._domForRegressionRange):
49762         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
49763         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
49764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
49765         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
49766         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
49767
49768 2011-07-21  Ojan Vafai  <ojan@chromium.org>
49769
49770         Fix issue throwing a 500 to the bots. We were modifying
49771         the dictionary during an iteration over it's keys and would get
49772         RuntimeError: dictionary changed size during iteration
49773
49774         * TestResultServer/model/jsonresults.py:
49775
49776 2011-07-21  Adam Barth  <abarth@webkit.org>
49777
49778         ORWT fails to consume some NRWT arguments
49779         https://bugs.webkit.org/show_bug.cgi?id=64988
49780
49781         Reviewed by Adam Roben.
49782
49783         * Scripts/old-run-webkit-tests:
49784
49785 2011-07-21  Adam Barth  <abarth@webkit.org>
49786
49787         Merge TestFailures and garden-o-matic unit tests harness
49788         https://bugs.webkit.org/show_bug.cgi?id=64984
49789
49790         Reviewed by Adam Roben.
49791
49792         One unit testing framework is better than two.
49793
49794         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
49795         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
49796
49797 2011-07-21  Adam Barth  <abarth@webkit.org>
49798
49799         Rubber-stamped by Adam Roben.
49800
49801         Move garden-o-matic files into the same directory as TestFailures to
49802         make it easier to integrate the codebases.
49803
49804         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
49805         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
49806         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
49807         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
49808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
49809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
49810         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
49811         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
49812         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
49813         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
49814         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
49815         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
49816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
49817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
49818         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
49819         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
49820         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
49821         * Scripts/webkitpy/tool/commands/gardenomatic.py:
49822         * Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
49823         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
49824         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
49825         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
49826         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
49827         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
49828         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
49829         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
49830         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
49831         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
49832         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
49833         * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
49834         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
49835         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
49836         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
49837         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
49838         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
49839         * Scripts/webkitpy/tool/servers/gardeningserver.py:
49840
49841 2011-07-19  Ojan Vafai  <ojan@chromium.org>
49842
49843         fix links on the flakiness dashboard
49844         https://bugs.webkit.org/show_bug.cgi?id=64832
49845
49846         Reviewed by Tony Chang.
49847
49848         Make them actual anchor tags and linkify the test name instead of
49849         adding an extra link. Also simplify the update view since we now
49850         show the linkified test name.
49851
49852         * TestResultServer/static-dashboards/flakiness_dashboard.html:
49853
49854 2011-07-21  Adam Barth  <abarth@webkit.org>
49855
49856         webkit.org builders should upload results to test-results AppEngine instance
49857         https://bugs.webkit.org/show_bug.cgi?id=64979
49858
49859         Reviewed by Adam Roben.
49860
49861         The master just needs to pass some flags to NRWT.  This patch also lets
49862         ORWT consume the flags (ignoring them) so we can pass the flags
49863         unconditionally.
49864
49865         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
49866         * Scripts/old-run-webkit-tests:
49867
49868 2011-07-21  Ojan Vafai  <ojan@chromium.org>
49869
49870         normalize gtest names in the result json
49871         https://bugs.webkit.org/show_bug.cgi?id=64971
49872
49873         Reviewed by Eric Seidel.
49874
49875         This will make the resulting JSON smaller and make the
49876         flakiness dashboard much more sane (e.g. we won't need to
49877         show you the FLAKY_ version and the normal version).
49878
49879         * TestResultServer/model/jsonresults.py:
49880         * TestResultServer/model/jsonresults_unittest.py:
49881
49882 2011-07-21  Eric Seidel  <eric@webkit.org>
49883
49884         Unreviewed.  Reenable ORWT for the --leaks bot.
49885         Something is still wrong with the leaks summarizing
49886         but I'm about to head out on vacation for 2 weeks,
49887         so it's best to just revert back to ORWT until I'm back.
49888
49889         * Scripts/run-webkit-tests:
49890         (usingLeaks):
49891         (useNewRunWebKitTests):
49892
49893 2011-07-21  Ojan Vafai  <ojan@chromium.org>
49894
49895         cleanup jsonresults.py style in preparation for making some changes
49896         https://bugs.webkit.org/show_bug.cgi?id=64968
49897
49898         Reviewed by Adam Barth.
49899
49900         No code changes. Unittest still passes. Mostly just removing
49901         useless comments and 80 character wrapping.
49902
49903         * TestResultServer/model/jsonresults.py:
49904         * TestResultServer/model/jsonresults_unittest.py:
49905
49906 2011-07-21  Adam Barth  <abarth@webkit.org>
49907
49908         Add missing column header.
49909
49910         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
49911
49912 2011-07-21  Eric Seidel  <eric@webkit.org>
49913
49914         Unreviewed.  Just fixing (and unittesting) a previous typo.
49915
49916         Fix typo in print_leaks_summary regexp which was causing
49917         leaks summarizing to fail on the --leaks bot.
49918
49919         * Scripts/webkitpy/layout_tests/port/mac.py:
49920         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
49921
49922 2011-07-21  Adam Barth  <abarth@webkit.org>
49923
49924         garden-o-matic should be able to rebaseline many tests at once
49925         https://bugs.webkit.org/show_bug.cgi?id=64963
49926
49927         Reviewed by Dimitri Glazkov.
49928
49929         This patch contains some UI for rebaselining tests in bulk.  I don't
49930         expect this UI to be the final UI, but the underlying infrastructure
49931         will be useful.
49932
49933         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
49934         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
49935         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
49936         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
49937         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
49938
49939 2011-07-21  Adam Barth  <abarth@webkit.org>
49940
49941         garden-o-matic has trouble when the same test fails in different ways on diffrent bots
49942         https://bugs.webkit.org/show_bug.cgi?id=64830
49943
49944         Unreviewed.  (Missing the patch is blocking me from fixing the tree.)
49945
49946         This patch is just some minor bug fixes.  One of the bugs results from
49947         the sadness of having two representations (a list and a space-separated
49948         string) for the set of failure types.
49949
49950         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
49951         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
49952         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
49953         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
49954
49955 2011-07-20  Ryosuke Niwa  <rniwa@webkit.org>
49956
49957         Buildbot marks a nrwt bot red when tests are missing results
49958         https://bugs.webkit.org/show_bug.cgi?id=64812
49959
49960         Reviewed by Adam Barth.
49961
49962         The bug was caused by multiple expressions matching on the single output.
49963         Fixed it by exiting the loop as soon as one expression matches.
49964
49965         Because the regular expression for 'failures' is most general,
49966         moved it to the end of the list to avoid it catching other cases.
49967
49968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
49969
49970 2011-07-20  Chang Shu  <cshu@webkit.org>
49971
49972         Adding myself to the reviewers list; No review needed.
49973
49974         * Scripts/webkitpy/common/config/committers.py:
49975
49976 2011-07-20  Eric Seidel  <eric@webkit.org>
49977
49978         new-run-webkit-tests --leaks does not restart DumpRenderTree often enough
49979         https://bugs.webkit.org/show_bug.cgi?id=64912
49980
49981         Reviewed by Adam Barth.
49982
49983         The bug was that set_default_option only works if the option's value
49984         is "None".  So I fixed --batch-size to default to None instead of 0
49985         (which kinda makes sense).
49986
49987         * Scripts/webkitpy/layout_tests/controllers/worker.py:
49988         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
49989
49990 2011-07-20  Eric Seidel  <eric@webkit.org>
49991
49992         Make kill-old-processes kill httpd on mac
49993         https://bugs.webkit.org/show_bug.cgi?id=64898
49994
49995         Reviewed by Adam Barth.
49996
49997         * BuildSlaveSupport/kill-old-processes:
49998          - The line endings seem to have flipped again,
49999            Thus making this diff gigantic.  The only line
50000            changed is the "httpd" line.  I suspect we'll need
50001            to set the line ending style from an svn checkout.
50002
50003 2011-07-20  Ojan Vafai  <ojan@chromium.org>
50004
50005         show a list of average test times in the treemap
50006         https://bugs.webkit.org/show_bug.cgi?id=64899
50007
50008         Reviewed by Adam Roben.
50009
50010         For now, you click a link and it replaces the treemap
50011         with a reverse sorted list of directories based on
50012         average test runtime within that directory.
50013
50014         To cut some of the noise, we don't show directories
50015         that only have one test in them or where the average
50016         runtime is less than 100ms.
50017
50018         * TestResultServer/static-dashboards/treemap.html:
50019
50020 2011-07-20  Eric Seidel  <eric@webkit.org>
50021
50022         Teach build.webkit.org how to identify leaks in NRWT output
50023         https://bugs.webkit.org/show_bug.cgi?id=64891
50024
50025         Reviewed by Adam Barth.
50026
50027         This was the last remaining piece blocking turning on
50028         NRWT for the leaks bot, so I did that in this change too.
50029         If for some reason we see trouble on the bots, I'll
50030         revert that part of this change.
50031
50032         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
50033         * Scripts/run-webkit-tests:
50034
50035 2011-07-20  Ojan Vafai  <ojan@chromium.org>
50036
50037         make the treemap display more human friendly
50038         https://bugs.webkit.org/show_bug.cgi?id=64896
50039
50040         Reviewed by Tony Chang.
50041
50042         * TestResultServer/static-dashboards/treemap.html:
50043
50044 2011-07-20  Eric Seidel  <eric@webkit.org>
50045
50046         Move HttpLock to using a FileSystem object
50047         https://bugs.webkit.org/show_bug.cgi?id=64885
50048
50049         Reviewed by Adam Barth.
50050
50051         I made a typo in my previous change, taking the value
50052         of read_text_file(pid_file) and setting it to lock_pid_file
50053         instead of current_pid.  Fixed now. :)
50054
50055         In order to test my new change I had to overhaul the unittests
50056         for this class to create a separate set of tests which work off
50057         of Mock objects instead of the real filesystem.
50058
50059         Since Executive doesn't yet wrap os.getpid() I added a FIXME
50060         in several places where we're currently calling os.getpid().  I
50061         felt adding Executive.getpid was outside of the scope of this change
50062         but once it exists some of this code will be much simpler to mock.
50063
50064         * Scripts/webkitpy/layout_tests/port/http_lock.py:
50065         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
50066         * Scripts/webkitpy/tool/mocktool.py:
50067
50068 2011-07-20  Adam Roben  <aroben@apple.com>
50069
50070         Fix typo in TestFailures's Bugzilla constants
50071
50072         This was preventing the "Version" field from being pre-filled when filing new bugs.
50073
50074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
50075
50076 2011-07-20  Eric Seidel  <eric@webkit.org>
50077
50078         Move HttpLock to using a FileSystem object
50079         https://bugs.webkit.org/show_bug.cgi?id=64885
50080
50081         Reviewed by Adam Barth.
50082
50083         There is no functional change here.  Just moving off
50084         of direct os.foo calls to their filesystem equivalent.
50085
50086         This makes it possible to now unittest HttpLock using a
50087         MockFileSystem instead of needing to talk to the filesystem directly.
50088
50089         This also will have changed any port test cases which were using a
50090         mock file system to now have an HttpLock based on a mock filesystem
50091         instead.  I saw no change in the unittests so it's possible
50092         we're not testing that configuration (or more likely that it "just works").
50093
50094         * Scripts/webkitpy/layout_tests/port/base.py:
50095         * Scripts/webkitpy/layout_tests/port/http_lock.py:
50096         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
50097
50098 2011-07-20  Adam Barth  <abarth@webkit.org>
50099
50100         NRWT results uses too much space per run
50101         https://bugs.webkit.org/show_bug.cgi?id=64845
50102
50103         Reviewed by Ojan Vafai.
50104
50105         Removing these files saves about 750K per build.
50106
50107         * Scripts/webkitpy/layout_tests/controllers/manager.py:
50108
50109 2011-07-20  Zan Dobersek  <zandobersek@gmail.com>
50110
50111         [Gtk] [NRWT] Xvfb produces a lot of stderr output
50112         https://bugs.webkit.org/show_bug.cgi?id=64669
50113
50114         Reviewed by Philippe Normand.
50115
50116         Redirect the stderr output of the driver's Xvfb process
50117         to /dev/null to suppress unneeded output.
50118
50119         * Scripts/webkitpy/layout_tests/port/gtk.py:
50120
50121 2011-07-19  Eric Seidel  <eric@webkit.org>
50122
50123         parse-malloc-history always exits 1, causing NRWT to fail
50124         https://bugs.webkit.org/show_bug.cgi?id=64835
50125
50126         Reviewed by Adam Barth.
50127
50128         ORWT just never checked the return code. :)
50129
50130         * Scripts/parse-malloc-history:
50131         (main):
50132         * Scripts/webkitpy/layout_tests/port/mac.py:
50133
50134 2011-07-19  Kevin Ollivier  <kevino@theolliviers.com>
50135
50136         [wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.
50137
50138         * waf/build/wxpresets.py:
50139
50140 2011-07-19  Eric Seidel  <eric@webkit.org>
50141
50142         new-run-webkit-tests should only enable MallocStackLogging for DRT
50143         https://bugs.webkit.org/show_bug.cgi?id=64792
50144
50145         Reviewed by Adam Barth.
50146
50147         The previous code would enable it for all servers launched
50148         by the port, which included Apache, the python websocket server
50149         as well as ImageDiff.  Now only DumpRenderTree will have
50150         MallocStackLogging enabled or the GuardMalloc library injected.
50151
50152         I also cleaned up the websocket_server code to use filesystem
50153         while I was in it.
50154
50155         I also made DRT restart every 1000 tests when running with
50156         --leaks enabled.  I believe this made the --leaks run slightly
50157         faster, but it still takes over an hour on my machine. :(
50158
50159         * Scripts/webkitpy/layout_tests/controllers/worker.py:
50160         * Scripts/webkitpy/layout_tests/port/base.py:
50161         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
50162         * Scripts/webkitpy/layout_tests/port/gtk.py:
50163         * Scripts/webkitpy/layout_tests/port/mac.py:
50164         * Scripts/webkitpy/layout_tests/port/qt.py:
50165         * Scripts/webkitpy/layout_tests/port/server_process.py:
50166         * Scripts/webkitpy/layout_tests/port/webkit.py:
50167         * Scripts/webkitpy/layout_tests/servers/http_server.py:
50168         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
50169
50170 2011-07-19  Ojan Vafai  <ojan@chromium.org>
50171
50172         remove the concept of platform fallbacks
50173         https://bugs.webkit.org/show_bug.cgi?id=64829
50174
50175         Reviewed by Adam Barth.
50176
50177         In the process, wrote tests for this code and fixed a pretty major
50178         bug (now covered by the test).
50179
50180         * TestResultServer/static-dashboards/flakiness_dashboard.html:
50181         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
50182
50183 2011-07-19  Ojan Vafai  <ojan@chromium.org>
50184
50185         cleanup some of the PLATFORM logic in the flakiness dashboard
50186         https://bugs.webkit.org/show_bug.cgi?id=64821
50187
50188         Reviewed by Adam Barth.
50189
50190         * TestResultServer/static-dashboards/flakiness_dashboard.html:
50191         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
50192
50193 2011-07-19  Ojan Vafai  <ojan@chromium.org>
50194
50195         cleanup some of the PLATFORM logic in the flakiness dashboard
50196         https://bugs.webkit.org/show_bug.cgi?id=64821
50197
50198         Reviewed by Adam Barth.
50199
50200         * TestResultServer/static-dashboards/flakiness_dashboard.html:
50201         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
50202
50203 2011-07-19  Dimitri Glazkov  <dglazkov@chromium.org>
50204
50205         Store line number on TestExpectationLine.
50206         https://bugs.webkit.org/show_bug.cgi?id=64800
50207
50208         Reviewed by Adam Barth.
50209
50210         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
50211
50212 2011-07-19  Ojan Vafai  <ojan@chromium.org>
50213
50214         fix flakiness dashboard for XP bots with XP in the name instead of WIN
50215         https://bugs.webkit.org/show_bug.cgi?id=64826
50216
50217         Reviewed by Mihai Parparita.
50218
50219         * TestResultServer/static-dashboards/flakiness_dashboard.html:
50220         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
50221
50222 2011-07-19  Cary Clark  <caryclark@google.com>
50223
50224         add myself to committers.py
50225         https://bugs.webkit.org/show_bug.cgi?id=64816
50226
50227         No review needed.
50228
50229         * Scripts/webkitpy/common/config/committers.py:
50230
50231 2011-07-19  Daniel Bates  <dbates@webkit.org>
50232
50233         Rename variable isEmptyTextPatch in svn-{apply, unapply}
50234         https://bugs.webkit.org/show_bug.cgi?id=64648
50235
50236         Reviewed by Adam Roben.
50237
50238         Rename the variable isEmptyTextPatch to hasTextChunks, which is
50239         more descriptive and makes its usage read well in control statements.
50240
50241         * Scripts/svn-apply:
50242         (patch):
50243         * Scripts/svn-unapply:
50244         (patch):
50245
50246 2011-07-19  Adam Roben  <aroben@apple.com>
50247
50248         Make TestFailures show existing bugs and a new bug link for flaky tests
50249
50250         Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
50251         flaky tests
50252         and
50253         <http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
50254         tests, but should
50255
50256         Reviewed by Sam Weinig.
50257
50258         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
50259         Added. This is what's used to file new bugs about flaky tests.
50260         (FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
50261         title, description, and URL.
50262
50263         (FlakyTestBugForm.prototype._createBugDescription):
50264         (FlakyTestBugForm.prototype._createBugTitle):
50265         These do what they say.
50266
50267         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
50268         Added. Tests of the above.
50269
50270         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
50271         (#failure-history > li):
50272         (#possibly-flaky-tests > li):
50273         (#failure-history > li, #possibly-flaky-tests > li):
50274         (#possibly-flaky-tests > li > :first-child):
50275         (.flakiness-examples-list):
50276         Styling to account for the new elements.
50277
50278         (.expandable):
50279         (.expanded > .expandable):
50280         Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
50281         transition properties because we can't transition to/from 'auto' (but really would like
50282         to!).
50283
50284         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
50285         (ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
50286         here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
50287         (ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
50288         argument instead of creating one ourselves.
50289         (ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
50290         an argument instead of just the number of analyzed builds. Put the examples list inside a
50291         container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
50292         with animating the height of the examples list; we don't do this anymore because it's hard
50293         to make it work correctly with the asynchronous loading of existing bugs. When we populate
50294         the examples list, also set up the new/existing bug UI.
50295
50296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
50297         FlakyTestBugForm.
50298
50299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
50300         Pull in FlakyTestBugForm and its tests.
50301
50302 2011-07-19  Ryosuke Niwa  <rniwa@webkit.org>
50303
50304         Buildbot marks a nrwt bot red when tests are missing results
50305         https://bugs.webkit.org/show_bug.cgi?id=64812
50306
50307         Reviewed by Tony Chang.
50308
50309         Added "missing results" label for tests that are missing results.
50310
50311         buildbot Now reports shows a label "X missing results" on a run when X tests were missing
50312         expected results on that run.
50313
50314         Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
50315
50316         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
50317
50318 2011-07-19  Adam Roben  <aroben@apple.com>
50319
50320         Extract some of FailingTestsBugForm's code into a base class
50321
50322         Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
50323         file bugs about flaky tests
50324
50325         Reviewed by Sam Weinig.
50326
50327         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
50328         Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
50329         TestRelatedBugForm.js.
50330
50331         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
50332         Moved some tests to TestRelatedBugForm_unittests.js.
50333
50334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
50335         (TestRelatedBugForm):
50336         (TestRelatedBugForm.prototype.domElement):
50337         (TestRelatedBugForm.prototype._computeOperatingSystem):
50338         (TestRelatedBugForm.prototype._computePlatform):
50339         Code came from FailingTestsBugForm.
50340
50341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
50342         Added. Tests came from FailingTestsBugForm_unittests.js
50343
50344         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
50345         Added. Code came from FailingTestsBugForm.js.
50346
50347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
50348         TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
50349         need to be pulled in early for parsing reasons.
50350
50351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
50352         Pull in TestRelatedBugForm and tests and WebKitBugzilla.
50353
50354 2011-07-19  Sam Weinig  <sam@webkit.org>
50355
50356         Remove obsolete Mac NRWT test bots
50357         https://bugs.webkit.org/show_bug.cgi?id=64806
50358
50359         Reviewed by Adam Roben.
50360
50361         Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
50362         which have been disconnected for some time and have been obsoleted by
50363         the main testers using NRWT.
50364
50365         * BuildSlaveSupport/build.webkit.org-config/config.json:
50366
50367 2011-07-19  Sam Weinig  <sam@webkit.org>
50368
50369         webkit-patch rebaseline crashes on use
50370         https://bugs.webkit.org/show_bug.cgi?id=64775
50371
50372         Reviewed by Adam Roben.
50373
50374         Fix incorrectly spelled attribute name.
50375
50376         * Scripts/webkitpy/common/net/layouttestresults.py:
50377         The attribute is test_name, not filename.
50378
50379         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
50380         Add test for tests_matching_failure_types.
50381
50382 2011-07-18  Eric Seidel  <eric@webkit.org>
50383
50384         new-run-webkit-tests should support --leaks
50385         https://bugs.webkit.org/show_bug.cgi?id=63832
50386
50387         Reviewed by Dirk Pranke.
50388
50389         This may not be sufficient to actually transition over the leaks bot,
50390         but this is a huge step in the right direction.
50391
50392         I had to make parse-malloc-history understand being passed more than
50393         one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
50394
50395         I removed some dead code relating to previous iterations of our crash detection.
50396
50397         I created a new class "LeakDetector" to encapsulate all this logic.
50398         Eventually we should consider pulling that class out of mac.py and
50399         sharing with other ports.  However given that ORWT has had
50400         --leaks support on Mac for almost 7 years and no other port has added
50401         it, leaves me to believe we're in no rush to move LeakDetector.
50402
50403         I've tested --leaks locally.  I suspect there are more bugs to shake out
50404         but it seems to work well enough to start.
50405
50406         I also added support for --guard-malloc, but have not tested it much.  It
50407         should be viewed as experimental at this time.
50408
50409         I also fixed various os.path uses to self._filesystem as I was reading
50410         through the various files to understand how best to fix this bug.
50411
50412         * Scripts/old-run-webkit-tests:
50413         (parseLeaksandPrintUniqueLeaks):
50414         * Scripts/parse-malloc-history:
50415         (main):
50416         * Scripts/webkitpy/common/system/crashlogs.py:
50417         * Scripts/webkitpy/layout_tests/controllers/manager.py:
50418         * Scripts/webkitpy/layout_tests/controllers/worker.py:
50419         * Scripts/webkitpy/layout_tests/port/base.py:
50420         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
50421         * Scripts/webkitpy/layout_tests/port/gtk.py:
50422         * Scripts/webkitpy/layout_tests/port/mac.py:
50423         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
50424         * Scripts/webkitpy/layout_tests/port/server_process.py:
50425         * Scripts/webkitpy/layout_tests/port/webkit.py:
50426         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
50427
50428 2011-07-19  Adam Barth  <abarth@webkit.org>
50429
50430         garden-o-matic should have a "Triage Failures" button for iterating over failures
50431         https://bugs.webkit.org/show_bug.cgi?id=64769
50432
50433         Reviewed by Eric Seidel.
50434
50435         This patch adds some global static state and refactors things a bit so
50436         that we can iterate over all the failures in the details pane.
50437
50438         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
50439             - Add a generic callback iterator to iterate through a series of
50440               callbacks. We use this to iterate through the failures we want to
50441               display the details of.
50442         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
50443             - Add a toolbar for the results summary and change the buttons to
50444               be real buttons.
50445         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
50446             - Make the detail pane 75% of the window.
50447             - Make the buttons pretty.
50448             - Allow the failure type badges to apply to the details pane as well.
50449         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
50450             - Restructure how we bring up the details pane so we can iterate
50451               through a bunch of failures.
50452             - Remove the transition between results details because it's
50453               annoying when you want to click through a bunch of failures.
50454         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
50455             - Add some more structure to the title bar for the results details
50456               so it's clearer which results we're currently displaying.
50457
50458 2011-07-19  Adam Barth  <abarth@webkit.org>
50459
50460         garden-o-matic should live update as conditions change on the buildbot
50461         https://bugs.webkit.org/show_bug.cgi?id=64646
50462
50463         Reviewed by Eric Seidel.
50464
50465         This patch causes the garden-o-matic display to update every 10 minutes
50466         to show the latest failures.  This patch required a moderately large
50467         refactoring of main.js to make the display incremental instead of
50468         all-at-once.
50469
50470         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
50471         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
50472         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
50473         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
50474
50475 2011-07-18  Tab Atkins  <jackalmage@gmail.com>
50476
50477         Tab Atkins is not in committers.py (as a non-committer)
50478         https://bugs.webkit.org/show_bug.cgi?id=64770
50479
50480         Reviewed by Eric Seidel.
50481
50482         * Scripts/webkitpy/common/config/committers.py:
50483
50484 2011-07-18  Ojan Vafai  <ojan@chromium.org>
50485
50486         Load ToT chromium bots by default in the flakiness dashboard
50487         https://bugs.webkit.org/show_bug.cgi?id=64756
50488
50489         Reviewed by Adam Barth.
50490
50491         For now, these are the most useful bots to look at. Eventually,
50492         we may want to load the build.webkit.org bots by default once
50493         most of the bots there upload results.
50494
50495         * TestResultServer/static-dashboards/dashboard_base.js:
50496
50497 2011-07-13  Jon Honeycutt  <jhoneycutt@apple.com>
50498
50499         Focus and selection events are not fired when a <select>'s selection
50500         changes
50501         https://bugs.webkit.org/show_bug.cgi?id=64504
50502         <rdar://problem/9319881>
50503
50504         Reviewed by Alice Liu.
50505
50506         * DumpRenderTree/AccessibilityController.h:
50507         Added m_notificationsEventHook for addNotificationListener().
50508         m_allEventsHook will now be used for setLogAccessibilityEvents().
50509
50510         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
50511         (AccessibilityController::AccessibilityController):
50512         Initialize m_notificationsEventHook.
50513         (AccessibilityController::~AccessibilityController):
50514         Turn off logging of all accessibility events. If
50515         m_notificationsEventHook is non-null, unhook it.
50516         (logEventProc):
50517         Add handling of EVENT_OBJECT_SELECTION.
50518         (AccessibilityController::setLogAccessibilityEvents):
50519         If the state of logging is not changing, return early. If we're turning
50520         off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
50521         hook for all events.
50522         (AccessibilityController::addNotificationListener):
50523         Use m_notificationsEventHook rather than m_allEventsHook.
50524
50525 2011-07-18  Eric Seidel  <eric@webkit.org>
50526
50527         webkit-patch apply-attachment does not work when not called from the root of the checkout
50528         https://bugs.webkit.org/show_bug.cgi?id=64751
50529
50530         Unreviewed.  Just updating unit test results after bug 64751.
50531
50532         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
50533         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
50534
50535 2011-07-18  Adam Barth  <abarth@webkit.org>
50536
50537         simplejson has trouble on chromium-linux
50538         https://bugs.webkit.org/show_bug.cgi?id=64757
50539
50540         Reviewed by Eric Seidel.
50541
50542         Use the native JSON, if available.
50543
50544         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
50545
50546 2011-07-18  Ojan Vafai  <ojan@chromium.org>
50547
50548         update the flakiness dashboard to understand the new platforms/formats in test_expectations
50549         https://bugs.webkit.org/show_bug.cgi?id=64743
50550
50551         Reviewed by Adam Barth.
50552
50553         The test expectations format changed a long time ago and the flakiness dashboard
50554         was never updated to match.
50555
50556         * TestResultServer/static-dashboards/dashboard_base.js:
50557         * TestResultServer/static-dashboards/flakiness_dashboard.html:
50558         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
50559         * TestResultServer/static-dashboards/timeline_explorer.html:
50560
50561 2011-07-18  Eric Seidel  <eric@webkit.org>
50562
50563         webkit-patch apply-attachment does not work when not called from the root of the checkout
50564         https://bugs.webkit.org/show_bug.cgi?id=64751
50565
50566         Reviewed by Adam Barth.
50567
50568         Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
50569         is a step that we run for most commands (as one of the earliest steps).
50570         EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
50571         the CWD to the checkout root.  This magically made a bunch of otherwise
50572         wrong code work.
50573
50574         When I realized that apply-attachment no longer worked as expected today,
50575         I went and fixed the bug, then realizing that we were not testing
50576         what the cwd was when running various commands.  I fixed our MockExecutive
50577         to always log what the cwd is and fixed a whole bunch of places
50578         where we needed to be setting the cwd.
50579
50580         Hopefully this will solve our cwd problems once and for-all, and webkit-patch
50581         will again correctly work when called from any directory (including outside
50582         of a webkit checkout).
50583
50584         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
50585         * Scripts/webkitpy/common/system/executive.py:
50586         * Scripts/webkitpy/common/system/workspace_unittest.py:
50587         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
50588         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
50589         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
50590         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
50591         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
50592         * Scripts/webkitpy/tool/bot/irc_command.py:
50593         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
50594         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
50595         * Scripts/webkitpy/tool/commands/download_unittest.py:
50596         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
50597         * Scripts/webkitpy/tool/commands/queues.py:
50598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
50599         * Scripts/webkitpy/tool/commands/queuestest.py:
50600         * Scripts/webkitpy/tool/mocktool.py:
50601         * Scripts/webkitpy/tool/servers/gardeningserver.py:
50602         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
50603         * Scripts/webkitpy/tool/steps/build.py:
50604         * Scripts/webkitpy/tool/steps/checkstyle.py:
50605         * Scripts/webkitpy/tool/steps/editchangelog.py:
50606         * Scripts/webkitpy/tool/steps/preparechangelog.py:
50607         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
50608         * Scripts/webkitpy/tool/steps/runtests.py:
50609         * Scripts/webkitpy/tool/steps/steps_unittest.py:
50610         * Scripts/webkitpy/tool/steps/update.py:
50611
50612 2011-07-18  Adam Barth  <abarth@webkit.org>
50613
50614         Increase information garden-o-matic information density by switching to a table
50615         https://bugs.webkit.org/show_bug.cgi?id=64642
50616
50617         Reviewed by Dimitri Glazkov.
50618
50619         The old layout couldn't handle the large number of failures we had
50620         today.  This patch switches garden-o-matic to a table-based layout,
50621         which can handle many more failures gracefully.  (I expect we'll need
50622         more UI iterations.)
50623
50624         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
50625         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
50626         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
50627         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
50628
50629 2011-07-18  Adam Barth  <abarth@webkit.org>
50630
50631         garden-o-matic should be able to determine when compile breaks
50632         https://bugs.webkit.org/show_bug.cgi?id=64190
50633
50634         Reviewed by Dimitri Glazkov.
50635
50636         This patch adds a red-ish box to the top of the page whenever there is
50637         a compile error on the bots.  The box automatically opens and closes as
50638         appropriate and links to the waterfall display.  In the future, we
50639         might want to compute a regression range.
50640
50641         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
50642             - Add the build-only bots to the config.  We use these to check
50643               whether the build failed, which is faster than waiting for the
50644               tester bots to cycle.
50645         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
50646             - Add DOM for the alert bar.
50647         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
50648             - CSS to support the alert bar.
50649         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
50650             - Wiring up events to poll the buildbot to see whether compile has
50651               failed.
50652         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
50653             - Infrastructure for fetching and parsing the buildbot status JSON
50654               blob.  This code could be better factored for testability.  :(
50655         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
50656             - UI for displaying compile errors.
50657         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
50658
50659 2011-07-18  Sheriff Bot  <webkit.review.bot@gmail.com>
50660
50661         Unreviewed, rolling out r91132 and r91135.
50662         http://trac.webkit.org/changeset/91132
50663         http://trac.webkit.org/changeset/91135
50664         https://bugs.webkit.org/show_bug.cgi?id=64681
50665
50666         Broke GTK and Chromium debug bots (Requested by rniwa on
50667         #webkit).
50668
50669         * DumpRenderTree/AccessibilityController.h:
50670         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
50671         (AccessibilityController::AccessibilityController):
50672         (AccessibilityController::~AccessibilityController):
50673         (logEventProc):
50674         (AccessibilityController::setLogAccessibilityEvents):
50675         (AccessibilityController::addNotificationListener):
50676
50677 2011-07-17  Philippe Normand  <pnormand@igalia.com>
50678
50679         test-webkitpy failing with Python 2.5
50680         https://bugs.webkit.org/show_bug.cgi?id=64594
50681
50682         Reviewed by Eric Seidel.
50683
50684         Updated simplejson to version 2.1.6 that fixes an issue when
50685         dumping slashes. Also use cgi.parse_qs instead of the urlparse
50686         version to be compatible with Python2.5. Verified the fix with
50687         test-webkitpy on python 2.5 and python 2.6.
50688
50689         * Scripts/webkitpy/thirdparty/simplejson/README.txt:
50690         * Scripts/webkitpy/thirdparty/simplejson/__init__.py:
50691         * Scripts/webkitpy/thirdparty/simplejson/_speedups.c:
50692         (json_PyOS_string_to_double):
50693         (_convertPyInt_AsSsize_t):
50694         (_convertPyInt_FromSsize_t):
50695         (ascii_escape_char):
50696         (ascii_escape_unicode):
50697         (ascii_escape_str):
50698         (raise_errmsg):
50699         (join_list_unicode):
50700         (join_list_string):
50701         (_build_rval_index_tuple):
50702         (scanstring_str):
50703         (scanstring_unicode):
50704         (py_scanstring):
50705         (py_encode_basestring_ascii):
50706         (scanner_dealloc):
50707         (scanner_traverse):
50708         (scanner_clear):
50709         (_parse_object_str):
50710         (_parse_object_unicode):
50711         (_parse_array_str):
50712         (_parse_array_unicode):
50713         (_parse_constant):
50714         (_match_number_str):
50715         (_match_number_unicode):
50716         (scan_once_str):
50717         (scan_once_unicode):
50718         (scanner_call):
50719         (scanner_new):
50720         (scanner_init):
50721         (encoder_new):
50722         (encoder_init):
50723         (encoder_call):
50724         (_encoded_const):
50725         (encoder_encode_float):
50726         (encoder_encode_string):
50727         (_steal_list_append):
50728         (encoder_listencode_obj):
50729         (encoder_listencode_dict):
50730         (encoder_listencode_list):
50731         (encoder_dealloc):
50732         (encoder_traverse):
50733         (encoder_clear):
50734         (init_speedups):
50735         * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
50736         * Scripts/webkitpy/thirdparty/simplejson/encoder.py:
50737         * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
50738         * Scripts/webkitpy/thirdparty/simplejson/scanner.py:
50739         * Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
50740         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
50741
50742 2011-07-17  Dimitri Glazkov  <dglazkov@chromium.org>
50743
50744         Rename ModifierMatcher to SpecificityCalculator.
50745         https://bugs.webkit.org/show_bug.cgi?id=64660
50746
50747         It's a little longer than before, but it is much clearer.
50748
50749         Reviewed by Adam Barth.
50750
50751         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted
50752             all callsites, also rewrote the comments.
50753         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites
50754             and renamed tests.
50755
50756 2011-07-15  Adam Barth  <abarth@webkit.org>
50757
50758         gardening server should proxy buildbot status for garden-o-matic
50759         https://bugs.webkit.org/show_bug.cgi?id=64588
50760
50761         Reviewed by Eric Seidel.
50762
50763         This information will be used to detect build breaks.  I took this
50764         opportunity to make ChromiumBuildBot non-static.
50765
50766         * Scripts/webkitpy/common/host.py:
50767         * Scripts/webkitpy/tool/commands/rebaseline.py:
50768         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
50769         * Scripts/webkitpy/tool/mocktool.py:
50770         * Scripts/webkitpy/tool/servers/gardeningserver.py:
50771         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
50772
50773 2011-07-15  Julien Chaffraix  <jchaffraix@webkit.org>
50774
50775         [NRWT] Add support for --no-http
50776         https://bugs.webkit.org/show_bug.cgi?id=64564
50777
50778         Reviewed by Dirk Pranke.
50779
50780         Added support for --no-http, which disables both HTTP and websockets tests.
50781         It also matches the old-run-webkit-tests behavior if --force is used.
50782
50783         * Scripts/webkitpy/layout_tests/controllers/manager.py:
50784         Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
50785         We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
50786         at the expectation file. Fixed the  _test_requires_lock function to use the same code path to determine
50787         what is worth have an HTTP lock as --no-http to avoid badness.
50788
50789         * Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that
50790         we do skip properly HTTP / websocket tests inside platform/.
50791
50792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
50793         Added tests that we properly skip all the tests.
50794
50795         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
50796         Added checks for the command line arguments.
50797
50798 2011-07-13  Jon Honeycutt  <jhoneycutt@apple.com>
50799
50800         Focus and selection events are not fired when a <select>'s selection
50801         changes
50802         https://bugs.webkit.org/show_bug.cgi?id=64504
50803         <rdar://problem/9319881>
50804
50805         Reviewed by Alice Liu.
50806
50807         * DumpRenderTree/AccessibilityController.h:
50808         Added m_notificationsEventHook for addNotificationListener().
50809         m_allEventsHook will now be used for setLogAccessibilityEvents().
50810
50811         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
50812         (AccessibilityController::AccessibilityController):
50813         Initialize m_notificationsEventHook.
50814         (AccessibilityController::~AccessibilityController):
50815         Turn off logging of all accessibility events. If
50816         m_notificationsEventHook is non-null, unhook it.
50817         (logEventProc):
50818         Add handling of EVENT_OBJECT_SELECTION.
50819         (AccessibilityController::setLogAccessibilityEvents):
50820         If the state of logging is not changing, return early. If we're turning
50821         off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
50822         hook for all events.
50823         (AccessibilityController::addNotificationListener):
50824         Use m_notificationsEventHook rather than m_allEventsHook.
50825
50826 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50827
50828         Refactor TestExpectationModel to use TestExpectationLine as data item.
50829         https://bugs.webkit.org/show_bug.cgi?id=64635
50830
50831         This is a bit largish in scope. Does the following things:
50832
50833         1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,
50834            and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
50835            needs to have any port knowledge.
50836
50837         2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,
50838            and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
50839            Now all expectations are added to the model in the same way!
50840
50841         3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.
50842
50843         Reviewed by Adam Barth.
50844
50845         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
50846
50847 2011-07-15  Adam Roben  <aroben@apple.com>
50848
50849         Teach TestFailures how to detect interrupted build steps
50850
50851         Fixes <http://webkit.org/b/64619> TestFailures page thinks all tests passed in
50852         http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401
50853
50854         Reviewed by Daniel Bates.
50855
50856         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
50857         (Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
50858         build step was interrupted. Treat it as an error (by returning a failureCount of -1).
50859
50860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
50861         Added a test for the above.
50862
50863         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
50864         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
50865         cache data that was afflicted by the above bug.
50866
50867 2011-07-15  Eric Seidel  <eric@webkit.org>
50868
50869         new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
50870         https://bugs.webkit.org/show_bug.cgi?id=64533
50871
50872         Reviewed by Adam Roben.
50873
50874         Blind removal of Chromium-specific code (now that Chromium does not use this file).
50875
50876         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
50877
50878 2011-07-15  Adam Roben  <aroben@apple.com>
50879
50880         Make TestFailures's list of possibly-flaky tests not so tall
50881
50882         Fixes <http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
50883         much room
50884
50885         Reviewed by Daniel Bates.
50886
50887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
50888         Removed a no-longer-used .flakiness-example-separator selector.
50889
50890         (#failure-history > li):
50891         (#possibly-flaky-tests > li):
50892         (#failure-history > li, #possibly-flaky-tests > li):
50893         Use a lot less padding for the possibly-flaky tests.
50894
50895 2011-07-15  Tony Chang  <tony@chromium.org>
50896
50897         [chromium] land linux selection color layout test
50898         https://bugs.webkit.org/show_bug.cgi?id=64631
50899
50900         Reviewed by Ojan Vafai.
50901
50902         I had removed this code in r76620 because I thought it wasn't used.
50903         Turns out there was a layout test in the chromium tree that never
50904         got migrated that used it.  Re-add the code and land the layout
50905         test (I will remove it from the chromium tree soon).
50906
50907         * DumpRenderTree/chromium/LayoutTestController.cpp:
50908         (LayoutTestController::LayoutTestController):
50909         (LayoutTestController::forceRedSelectionColors):
50910         * DumpRenderTree/chromium/LayoutTestController.h:
50911
50912 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50913
50914         Revert http://trac.webkit.org/changeset/91091, since Python 2.5
50915         does not support enumerate() start argument.
50916
50917         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
50918
50919 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50920
50921         Clean up test_expectations.py after refactorings.
50922         https://bugs.webkit.org/show_bug.cgi?id=64620
50923
50924         * Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with
50925           its sub-part, the actual expectation.
50926         * Renamed all references to options to modifier to eliminate dual terminology.
50927         * Made a bunch of parser constants and changed all callsites to use them.
50928         * Various other minor clean-ups.
50929
50930         Reviewed by Adam Barth.
50931
50932         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
50933         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
50934         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
50935
50936 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50937
50938         Move expectation parsing code to TestExpectationParser.
50939         https://bugs.webkit.org/show_bug.cgi?id=64605
50940
50941         This is a somewhat mechanical move, with two interesting bits:
50942
50943         1) TestExpectationParser.parse methods renamed to tokenize, to better
50944         reflect what they do
50945
50946         2) TestExpectationLine now carries all of its info, from tokens to parsed data,
50947         and even the list of tests that it matches (a line may refer to more than one test).
50948
50949         Reviewed by Adam Barth.
50950
50951         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods
50952             to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
50953             to "tokenize", changed callsites to use new code.
50954         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
50955
50956 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50957
50958         Switch to use Python enumerate function to enumerate line numbers.
50959         https://bugs.webkit.org/show_bug.cgi?id=64602
50960
50961         Reviewed by Adam Barth.
50962
50963         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
50964
50965 2011-07-15  Martin Robinson  <mrobinson@igalia.com>
50966
50967         Build fixes for WebKit2. Ensure that all generated sources are
50968         on nodist primaries, that they are on forward declared variables
50969         so that BUILT_SOURCES is calculated properly and that zlib is
50970         included during linking (for WOFF support).
50971
50972         * WebKitTestRunner/GNUmakefile.am:
50973
50974 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50975
50976         Store error and warning information on TestExpectationLine.
50977         https://bugs.webkit.org/show_bug.cgi?id=64565
50978
50979         Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
50980         from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.
50981
50982         Reviewed by Adam Barth.
50983
50984         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,
50985             converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
50986             this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.
50987         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
50988
50989 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
50990
50991         Plumb the use of TestExpectationLine deeper, clean up.
50992         https://bugs.webkit.org/show_bug.cgi?id=64559
50993
50994         Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
50995         also cleaning up names and remove an unused TestExpectations._get_options_list member.
50996
50997         Reviewed by Adam Barth.
50998
50999         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
51000
51001 2011-07-15  Dimitri Glazkov  <dglazkov@chromium.org>
51002
51003         Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
51004         https://bugs.webkit.org/show_bug.cgi?id=64554
51005
51006         This moves us toward the world where errors are collected on the expectations, which allows us to
51007         easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.
51008
51009         Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
51010         parsing.
51011
51012         Reviewed by Adam Barth.
51013
51014         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,
51015             changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.
51016         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
51017         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
51018
51019 2011-07-15  Adam Roben  <aroben@apple.com>
51020
51021         Rename TestFailureBugForm to FailingTestsBugForm
51022
51023         The new name will match better with a forthcoming FlakyTestBugForm class.
51024
51025         Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
51026         name
51027
51028         Reviewed by Daniel Bates.
51029
51030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
51031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
51032
51033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
51034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
51035         Updated for renames.
51036
51037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
51038         reordered <script>s to put files which others depend on for parsing first.
51039
51040 2011-07-15  Adam Barth  <abarth@webkit.org>
51041
51042         NRWT stores the Chromium revision number in full_results.json
51043         https://bugs.webkit.org/show_bug.cgi?id=64586
51044
51045         I have no earthly idea how to test this change.
51046
51047         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51048         * Scripts/webkitpy/layout_tests/port/base.py:
51049
51050 2011-07-14  Ojan Vafai  <ojan@chromium.org>
51051
51052         fix remaining style issues in the static-dashboards directory
51053         https://bugs.webkit.org/show_bug.cgi?id=64561
51054
51055         Reviewed by Adam Barth.
51056
51057         * TestResultServer/static-dashboards/aggregate_results.html:
51058         * TestResultServer/static-dashboards/builders.js:
51059         * TestResultServer/static-dashboards/dashboard_base.js:
51060         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
51061         * TestResultServer/static-dashboards/timeline_explorer.html:
51062         * TestResultServer/static-dashboards/treemap.html:
51063
51064 2011-07-14  Yuta Kitamura  <yutak@chromium.org>
51065
51066         WebSocket: Introduce pywebsocket-0.6b2
51067         https://bugs.webkit.org/show_bug.cgi?id=64534
51068
51069         Reviewed by Kent Tamura.
51070
51071         * Scripts/webkitpy/thirdparty/__init__.py:
51072
51073 2011-07-14  Dimitri Glazkov  <dglazkov@chromium.org>
51074
51075         Introduce TestExpectationsModel, split out of TestExpectations.
51076         https://bugs.webkit.org/show_bug.cgi?id=64531
51077
51078         This is a simple split-and-make-work refactoring, a first step among many.
51079
51080         Reviewed by Adam Barth.
51081
51082         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members
51083             out of TestExpectations and into TestExpectationsModel.
51084
51085 2011-07-14  Eric Seidel  <eric@webkit.org>
51086
51087         Move webkitpy off of loose mocks
51088         https://bugs.webkit.org/show_bug.cgi?id=64508
51089
51090         Unreviewed.  Fixing a test which fails under test-webkitpy --all (but not in a normal run).
51091
51092         * Scripts/webkitpy/common/checkout/scm/git.py:
51093
51094 2011-07-14  Adam Barth  <abarth@webkit.org>
51095
51096         garden-o-matic should have a "rebaseline" button
51097         https://bugs.webkit.org/show_bug.cgi?id=64446
51098
51099         Reviewed by Ojan Vafai.
51100
51101         This patch adds a basic Rebaseline button that copies the baselines
51102         displayed in the results pane into the appropriate directory in your
51103         working copy.
51104
51105         There are two main limitations:
51106
51107         1) There is no UI for actually committing the baselines.
51108
51109         2) The baselines are not optimized for redundancy (meaning you can have
51110            identical baselines in both chromium-mac and chromium-win).
51111
51112         * Scripts/webkitpy/tool/commands/rebaseline.py:
51113             - Turns out we need to create the directory for the baseline if it doesn't exist yet.
51114         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
51115             - Add an programatic API to call the server.
51116         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51117             - Add the rebaseline button itself.
51118         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51119             - Change the CSS so that the Rebaseline and Close buttons can
51120               appear in the normal order in the DOM.
51121         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51122             - Bind the event and translate the parameters.
51123             - Hide/show the rebaseline button, as appropriate.
51124         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51125             - Add some helpful utility functions for manipulating failure types.
51126         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51127
51128 2011-07-14  Ryosuke Niwa  <rniwa@webkit.org>
51129
51130         REGRESSION: webkit-patch roll-chromium-deps is broken
51131         https://bugs.webkit.org/show_bug.cgi?id=64568
51132
51133         Reviewed by Dirk Pranke
51134
51135         Use _filesystem.join.
51136
51137         * Scripts/webkitpy/common/checkout/checkout.py:
51138         * Scripts/webkitpy/common/checkout/checkout_unittests.py:
51139
51140 2011-07-14  Noam Rosenthal  <noam.rosenthal@nokia.com>
51141
51142         Adding myself to the reviewers list; No review needed.
51143
51144         * Scripts/webkitpy/common/config/committers.py:
51145
51146 2011-07-14  Adam Roben  <aroben@apple.com>
51147
51148         Don't use Element.prototype.classList in TestFailures
51149
51150         Safari 5 doesn't support it.
51151
51152         Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5
51153
51154         Reviewed by Daniel Bates.
51155
51156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
51157         (Element.prototype.hasStyleClass):
51158         (Element.prototype.addStyleClass):
51159         (Element.prototype.removeStyleClass):
51160         (Element.prototype.toggleStyleClass):
51161         Added these helper functions which simulate classList functionality.
51162
51163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:
51164         Added. Tests for the above.
51165
51166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
51167         (ViewController.prototype._domForPossiblyFlakyTests): Changed to use
51168         toggleStyleClass/hasStyleClass instead of classList.
51169
51170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
51171         Added Utilities_unittests.js, and reordered the tested files to be in
51172         roughly dependency order (i.e., the lowest-level files are imported
51173         and tested first).
51174
51175 2011-07-14  Eric Seidel  <eric@webkit.org>
51176
51177         NRWT doesn't store the svn revision in full_results.json on chromium-win
51178         https://bugs.webkit.org/show_bug.cgi?id=64492
51179
51180         Unreviewed.  Just fixing my test-webkitpy regression.
51181
51182         Fix the unit tests.  Unfortunately scm does not use a filesystem
51183         object so we can't control the result of detect_scm_system.
51184         When detect_scm_system would fail, we would log, which would
51185         cause all passing_run integration tests to fail.
51186
51187         * Scripts/webkitpy/common/checkout/scm/scm.py:
51188         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51189         * Scripts/webkitpy/layout_tests/port/base.py:
51190         * Scripts/webkitpy/layout_tests/port/test.py:
51191         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
51192
51193 2011-07-14  Eric Seidel  <eric@webkit.org>
51194
51195         NRWT doesn't store the svn revision in full_results.json on chromium-win
51196         https://bugs.webkit.org/show_bug.cgi?id=64492
51197
51198         Reviewed by Ojan Vafai.
51199
51200         This should fix the bug.  Unfortunately this code is currently
51201         impossible to test since it's impossible to mock detect_scm_system at the
51202         moment.  I started re-writing scm.detection.py to be mockable, but decided that
51203         was best left for another day.
51204
51205         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51206         * Scripts/webkitpy/layout_tests/port/base.py:
51207
51208 2011-07-14  Ojan Vafai  <ojan@chromium.org>
51209
51210         fix coding style of dashboard_base.js
51211         https://bugs.webkit.org/show_bug.cgi?id=64545
51212
51213         Reviewed by Adam Roben.
51214
51215         The code changes to the files other than dashboard_base.js
51216         are just fallout from renaming globals in dashboard_base.js.
51217
51218         * TestResultServer/static-dashboards/aggregate_results.html:
51219         * TestResultServer/static-dashboards/builders.js:
51220         * TestResultServer/static-dashboards/dashboard_base.js:
51221         * TestResultServer/static-dashboards/flakiness_dashboard.html:
51222         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
51223         * TestResultServer/static-dashboards/timeline_explorer.html:
51224         * TestResultServer/static-dashboards/treemap.html:
51225
51226 2011-07-14  Carlos Garcia Campos  <cgarcia@igalia.com>
51227
51228         Unreviewed. Fix WebKit2 GTK build after r90953.
51229
51230         * WebKitTestRunner/GNUmakefile.am:
51231
51232 2011-07-14  Adam Barth  <abarth@webkit.org>
51233
51234         garden-o-matic results pane should be more discoverable
51235         https://bugs.webkit.org/show_bug.cgi?id=64513
51236
51237         Reviewed by Eric Seidel.
51238
51239         This patch causes us to trigger the results pane on mouse clicks
51240         instead of mousein.  Also, handle the case of no results details more
51241         elegantly.
51242
51243         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51244         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51245             - Change the binding to "click".
51246         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51247             - Handle the "no results URLs" case explicitly instead of never
51248               calling the callback.
51249         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51250         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51251             - Show a message when there are no result details to show.
51252         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51253
51254 2011-07-14  Adam Barth  <abarth@webkit.org>
51255
51256         garden-o-matic should badge TIMEOUT failures
51257         https://bugs.webkit.org/show_bug.cgi?id=64435
51258
51259         Reviewed by Eric Seidel.
51260
51261         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51262         (.regression .what a[draggable].TIMEOUT::before):
51263             - Add TIMEOUT.
51264
51265 2011-07-14  Adam Barth  <abarth@webkit.org>
51266
51267         Fix Python exception blocking the commit-queue.
51268
51269         * Scripts/webkitpy/common/checkout/scm/git.py:
51270
51271 2011-07-13  Eric Seidel  <eric@webkit.org>
51272
51273         Move webkitpy off of loose mocks
51274         https://bugs.webkit.org/show_bug.cgi?id=64508
51275
51276         Reviewed by Adam Barth.
51277
51278         Using Mock has caused us more pain than help.
51279         It's possible that there was a cleaner way to use it
51280         (maybe Mock(class) instead of inheriting from it?).
51281         But for now, I've removed all uses of Mock from mocktool.py.
51282
51283         I also moved run_command into the only 3 files which call it
51284         instead of leaving the deprecated method in executive.py.
51285
51286         I changed various direct calls to os.* to use filesystem instead.
51287
51288         * Scripts/webkitpy/common/checkout/checkout.py:
51289         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
51290         * Scripts/webkitpy/common/checkout/scm/git.py:
51291         * Scripts/webkitpy/common/checkout/scm/scm.py:
51292         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
51293         * Scripts/webkitpy/common/checkout/scm/svn.py:
51294         * Scripts/webkitpy/common/system/executive.py:
51295         * Scripts/webkitpy/common/system/executive_unittest.py:
51296         * Scripts/webkitpy/tool/mocktool.py:
51297         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
51298         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
51299
51300 2011-07-13  Eric Seidel  <eric@webkit.org>
51301
51302         NRWT doesn't store the svn revision in full_results.json on chromium-win
51303         https://bugs.webkit.org/show_bug.cgi?id=64492
51304
51305         Reviewed by Adam Barth.
51306
51307         Add a warning message in the revision='' case to help us diagnose
51308         what's going wrong on the bot.
51309
51310         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51311
51312 2011-07-13  Dirk Pranke  <dpranke@chromium.org>
51313
51314         new-run-webkit-tests: print baseline search path as part of config output
51315         https://bugs.webkit.org/show_bug.cgi?id=64499
51316
51317         Reviewed by Eric Seidel.
51318
51319         * Scripts/webkitpy/layout_tests/controllers/manager.py:
51320         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
51321
51322 2011-07-13  Adam Barth  <abarth@webkit.org>
51323
51324         gardening server should have an API for parsing changelogs
51325         https://bugs.webkit.org/show_bug.cgi?id=64495
51326
51327         Reviewed by Eric Seidel.
51328
51329         This patch exposes much of the same information from CommitInfo in a
51330         dictionary form, which is easier to send over-the-wire as JSON to the
51331         frontend.
51332
51333         * Scripts/webkitpy/common/checkout/checkout.py:
51334         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
51335         * Scripts/webkitpy/tool/mocktool.py:
51336         * Scripts/webkitpy/tool/servers/gardeningserver.py:
51337         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
51338         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
51339
51340 2011-07-13  Eric Seidel  <eric@webkit.org>
51341
51342         REGRESSION: GitTestWithMock.test_create_patch fails
51343         https://bugs.webkit.org/show_bug.cgi?id=62945
51344
51345         Reviewed by Daniel Bates.
51346
51347         I was not able to reproduce the exact failure seen in the bug,
51348         however this test was failing on my machine for other reasons.
51349
51350         I went through and did an audit of our run_command usage, it's
51351         entirely in scm classes after this change.  (Not surprising given
51352         that scm.py was the second file ever created in webkit.py.)
51353
51354         The real bug I'm fixing here is that we were setting executive.should_log
51355         when the value had changed to executive._should_log.  Now we set the right one
51356         and the test works again.
51357
51358         * Scripts/webkitpy/common/checkout/checkout.py:
51359         * Scripts/webkitpy/common/checkout/scm/git.py:
51360         * Scripts/webkitpy/common/checkout/scm/scm.py:
51361         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
51362         * Scripts/webkitpy/common/checkout/scm/svn.py:
51363
51364 2011-07-13  Ilya Sherman  <isherman@chromium.org>
51365
51366         Fix WTF header guard style check
51367         https://bugs.webkit.org/show_bug.cgi?id=64488
51368
51369         Reviewed by David Levin.
51370
51371         * Scripts/webkitpy/style/checkers/cpp.py:
51372         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
51373
51374 2011-07-13  Ojan Vafai  <ojan@chromium.org>
51375
51376         bring flakiness_dashboard.html closer to webkit style
51377         https://bugs.webkit.org/show_bug.cgi?id=64477
51378
51379         Reviewed by Adam Barth.
51380
51381         * TestResultServer/static-dashboards/dashboard_base.js:
51382         Fix bad variable name that would hit only when running the tests.
51383         * TestResultServer/static-dashboards/flakiness_dashboard.html:
51384         No code/logic changes. All moving/removing brackets, indents and moving things
51385         to one line.
51386
51387 2011-07-13  Xan Lopez  <xlopez@igalia.com>
51388
51389         [GTK] Fix distcheck
51390
51391         Reviewed by Martin Robinson.
51392
51393         * WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.
51394
51395 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
51396
51397         Unreviewed fix. Add a "\n" to a printf that somehow got lost.
51398
51399         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
51400         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
51401
51402 2011-07-13  Joseph Pecoraro  <joepeck@webkit.org>
51403
51404         ApplicationCache Quota Output is Flakey
51405         https://bugs.webkit.org/show_bug.cgi?id=64410
51406
51407         Reviewed by Alexey Proskuryakov.
51408
51409         Unify the delegate logging for reaching application cache
51410         quotas. Truncate the space needed to the nearest 10000
51411         for less flakey test output. This also better supports
51412         printing NSUInteger on non-64 bit systems by casting to
51413         an unsigned long.
51414
51415         * DumpRenderTree/mac/UIDelegate.mm:
51416         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
51417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
51418         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
51419
51420 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
51421
51422         Remove unused TestExpectations._overrides.
51423         https://bugs.webkit.org/show_bug.cgi?id=64470
51424
51425         Reviewed by Adam Barth.
51426
51427         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
51428
51429 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
51430
51431         Introduce TestExpectationSerializer.list_to_string.
51432         https://bugs.webkit.org/show_bug.cgi?id=64462
51433
51434         Reviewed by Adam Barth.
51435
51436         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
51437         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
51438
51439 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
51440
51441         Consolidate expectations parsing code.
51442         https://bugs.webkit.org/show_bug.cgi?id=64460
51443
51444         Reviewed by Adam Barth.
51445
51446         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
51447
51448 2011-07-12  Brent Fulgham  <bfulgham@webkit.org>
51449
51450         Standardize WinCairo conditionalized code under PLATFORM macro.
51451         https://bugs.webkit.org/show_bug.cgi?id=64377
51452
51453         Reviewed by Maciej Stachowiak.
51454
51455         Update compile-time conditions that had previously used #ifdef
51456         of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
51457
51458         * DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
51459         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
51460           define of WIN_CAIRO=1.
51461         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
51462           WinCairo.vsprops to set (to match Release build).
51463
51464 2011-07-13  Dimitri Glazkov  <dglazkov@chromium.org>
51465
51466         Eliminate TestExpectationsFile.
51467         https://bugs.webkit.org/show_bug.cgi?id=64458
51468
51469         Turns out, we can just use a Python list.
51470
51471         Reviewed by Adam Barth.
51472
51473         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
51474             removed TestExpectationsFile.
51475         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
51476             since there's no more custom iterator machinery.
51477
51478 2011-07-13  Philippe Normand  <pnormand@igalia.com>
51479
51480         Unreviewed, added my other email addresses.
51481
51482         * Scripts/webkitpy/common/config/committers.py:
51483
51484 2011-07-13  Adam Barth  <abarth@webkit.org>
51485
51486         Folks should only be listed once.
51487
51488         * Scripts/webkitpy/common/config/committers.py:
51489
51490 2011-07-13  Philippe Normand  <pnormand@igalia.com>
51491
51492         Unreviewed, adding myself as Reviewer.
51493
51494         * Scripts/webkitpy/common/config/committers.py:
51495
51496 2011-07-13  Adam Barth  <abarth@webkit.org>
51497
51498         Fix flickering bug introduced by my previous patch.  I forgot to change
51499         the name of the class everywhere.
51500
51501         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51502
51503 2011-07-12  Philippe Normand  <pnormand@igalia.com>
51504
51505         [GTK] media/media-blocked-by-willsendrequest.html fails
51506         https://bugs.webkit.org/show_bug.cgi?id=63699
51507
51508         Reviewed by Martin Robinson.
51509
51510         * DumpRenderTree/gtk/DumpRenderTree.cpp:
51511         (willSendRequestCallback): Abort the request if explicitely asked
51512         by the LayoutTestController's willSendRequestReturnsNull() function.
51513
51514 2011-07-13  Adam Barth  <abarth@webkit.org>
51515
51516         Remove "Dismiss" button from garden-o-matic butterbar
51517         https://bugs.webkit.org/show_bug.cgi?id=64443
51518
51519         Reviewed by Dimitri Glazkov.
51520
51521         We don't have any persistent butter bar messages yet, so the dismiss
51522         button is premature (and fairly heavy, visually).
51523
51524         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51525         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51526
51527 2011-07-13  Adam Barth  <abarth@webkit.org>
51528
51529         Refine garden-o-matic status pane
51530         https://bugs.webkit.org/show_bug.cgi?id=64442
51531
51532         Reviewed by Dimitri Glazkov.
51533
51534         This patch makes two improvements to the status pane:
51535
51536         1) We only query the server for failure types that we're expecting.
51537            This dramatically reduces the number of HTTP requests, making
51538            loading the status pane faster.
51539
51540         2) The status pane now displays which test and which builder it is
51541            showing results for.
51542
51543         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
51544         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51545         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51546         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51547         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51548         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51549         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51550
51551 2011-07-13  Adam Barth  <abarth@webkit.org>
51552
51553         garden-o-matic should show test results
51554         https://bugs.webkit.org/show_bug.cgi?id=64440
51555
51556         Reviewed by Adam Roben.
51557
51558         This patch introduces the results detail pane, which appears at the
51559         bottom of the window and contains test results from the bots.
51560         Currently, you can activate the pane by mousing over one of the builder
51561         names associated with a failing test.
51562
51563         This is just a first iteration of the UI.  There's no way to resize or
51564         zoom in on elements of the details pane, and images likely aren't sized
51565         correctly, but it's a place to start.
51566
51567         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
51568             - Add constants for our data attributes so we don't typo them!
51569         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51570             - Add DOM structure for the details pane.
51571         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51572         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51573             - Bind events for showing and hiding the details pane.
51574         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51575             - Reduce the number of result types that we query for to avoid
51576               overfilling the details pane.  We'll probably need another
51577               solution here in the long-term.  For example, we could use tabs
51578               to pack more results into the pane.
51579         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51580         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
51581             - Now that we're using the config package during testing, we need
51582               to include it in the testing HTML.
51583         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51584         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51585             - Change the DOM structure of the results detail to make it fit
51586               nicely in the details pane (rather than flowing freely in the
51587               body, as it did before).
51588
51589 2011-07-13  Adam Roben  <aroben@apple.com>
51590
51591         Make TestFailures show every time a possibly-flaky test failed, but hide it by default
51592
51593         It's useful to be able to see every time a flaky test failed to see whether it failed the
51594         same way every time. But doing so takes a lot of space, so the list of failures is now
51595         collapsed by default and can be revealed using a disclosure triangle.
51596
51597         Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
51598         flaky tests as I would like, even though the page is already so long
51599
51600         Reviewed by Dimitri Glazkov.
51601
51602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
51603         (FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
51604         function. Now returns all failures for the given test.
51605
51606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
51607         Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
51608         more over time.
51609
51610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
51611         (LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
51612         that we no longer return passing builds for possibly-flaky tests.
51613
51614         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
51615         (.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
51616         flakiness examples small, too, since it can get quite long.
51617
51618         (.disclosure-triangle):
51619         (.expanded > .disclosure-triangle):
51620         Simple styles for the disclosure triangle.
51621
51622         (.flakiness-examples-list): Collapse the list by default.
51623
51624         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
51625         (ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
51626         _domForPossiblyFlakyTests.
51627         (ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
51628         of each test name, and the number of failures to the right. When the disclosure triangle is
51629         clicked for the first time, we build up the list of failures and expand the element. After
51630         that we just collapse or expand the element on subsequent clicks.
51631
51632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
51633         Pulled in new tests.
51634
51635 2011-07-13  Adam Roben  <aroben@apple.com>
51636
51637         Teach TestFailures to understand NRWT's output when it exits early due to too many failures
51638
51639         Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
51640         exits early
51641
51642         Reviewed by Dimitri Glazkov.
51643
51644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
51645         (Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
51646         it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
51647         line. Tightened up the regex that's used to parse the number of failing tests to require the
51648         leading number to be followed by whitespace so that we won't parse the "2011" in
51649         "2011-07-13" as a number of failures.
51650
51651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
51652         Added a test for the above.
51653
51654 2011-07-12  Dimitri Glazkov  <dglazkov@chromium.org>
51655
51656         Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
51657         https://bugs.webkit.org/show_bug.cgi?id=64386
51658
51659         This is the first step in converting TestExpectations to a real model.
51660         * TestExpectationsLine represents a line in the test_expectations.txt file, and
51661         * TestExpectationsFile represents the file, which is a collection of lines.
51662
51663         Reviewed by Adam Barth.
51664
51665         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
51666         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
51667         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
51668
51669 2011-07-13  Xan Lopez  <xlopez@igalia.com>
51670
51671         [GTK] Do not grab focus too early in DRT.
51672
51673         Reviewed by Gustavo Noronha.
51674
51675         It causes a layout to happen and a progress signal to be emitted
51676         since r90900, but at this point we don't have a
51677         LayoutTestController object and we'll eventually crash. Since we
51678         already grab focus at the beginning of runTest() this is
51679         redundant, so get rid of it to fix the crash.
51680
51681         * DumpRenderTree/gtk/DumpRenderTree.cpp:
51682         (main): remove call to grab_focus
51683
51684 2011-07-13  Sheriff Bot  <webkit.review.bot@gmail.com>
51685
51686         Unreviewed, rolling out r90893 and r90894.
51687         http://trac.webkit.org/changeset/90893
51688         http://trac.webkit.org/changeset/90894
51689         https://bugs.webkit.org/show_bug.cgi?id=64441
51690
51691         NRWT still doesn't work on qt-mac platform (Requested by Ossy
51692         on #webkit).
51693
51694         * Scripts/run-webkit-tests:
51695         (useNewRunWebKitTests):
51696
51697 2011-07-13  Csaba Osztrogonác  <ossy@webkit.org>
51698
51699         [Qt] NRWT should pick up the right httpd config file
51700         https://bugs.webkit.org/show_bug.cgi?id=64086
51701
51702         * Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.
51703         (useNewRunWebKitTests):
51704
51705 2011-07-12  Mark Rowe  <mrowe@apple.com>
51706
51707         Fix the 32-bit build.
51708
51709         * DumpRenderTree/mac/UIDelegate.mm:
51710         (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
51711         Cast the NSUInteger value to unsigned long to match the format specifier.
51712
51713 2011-07-12  Adam Barth  <abarth@webkit.org>
51714
51715         Improve garden-o-matic UI when the bots fail to report revision numbers
51716         https://bugs.webkit.org/show_bug.cgi?id=64427
51717
51718         Reviewed by Dimitri Glazkov.
51719
51720         At least Win (dbg)(2) seems to fail to report the SVN revision number
51721         in full_results.json.  This patch makes garden-o-matic more robust to
51722         missing revision numbers.
51723
51724         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51725         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51726         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51727         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51728         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51729
51730 2011-07-12  Adam Barth  <abarth@webkit.org>
51731
51732         Adjust garden-o-matic layout to use fewer lines
51733         https://bugs.webkit.org/show_bug.cgi?id=64422
51734
51735         Reviewed by Ojan Vafai.
51736
51737         This patch effectively merges the test name line with the list of
51738         builders on which the test fails.  Each test failure now occupies two
51739         lines instead of three.
51740
51741         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51742         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51743         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51744
51745 2011-07-12  Adam Barth  <abarth@webkit.org>
51746
51747         garden-o-matic should label tests failures of new tests as such
51748         https://bugs.webkit.org/show_bug.cgi?id=64421
51749
51750         Reviewed by Ojan Vafai.
51751
51752         Also, we shouldn't dim failures of new tests, even if we've only seen
51753         them once because they're likely to be real problems that need
51754         attention.
51755
51756         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
51757         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
51758         * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
51759         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51760         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51761         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51762         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51763         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
51764         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51765         * Scripts/webkitpy/tool/servers/gardeningserver.py:
51766
51767 2011-07-12  Adam Barth  <abarth@webkit.org>
51768
51769         garden-o-matic should display how many times we've seen a failure
51770         https://bugs.webkit.org/show_bug.cgi?id=64417
51771
51772         Reviewed by Ojan Vafai.
51773
51774         This patch adds some UI to display how many times we've seen a given
51775         failure, which can be helpful for determining whether that failure is a
51776         real failure or a flaky test.
51777
51778         When a failure has only been seen once (i.e., only a single run on a
51779         single bot), we set the opacity of to 50% to avoid distracting the
51780         gardener.
51781
51782         This patch also refactors the failure walker to have a simpler API
51783         internally by moving from an object-oriented paradigm to a functional
51784         paradigm.
51785
51786         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51787         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51788         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51789         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51790         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51791         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51792
51793 2011-07-12  Chris Rogers  <crogers@google.com>
51794
51795         Enable Web Audio for chromium DRT
51796         https://bugs.webkit.org/show_bug.cgi?id=64409
51797
51798         Reviewed by James Robinson.
51799
51800         * DumpRenderTree/chromium/TestShell.cpp:
51801         (TestShell::TestShell):
51802
51803 2011-07-12  Adam Barth  <abarth@webkit.org>
51804
51805         Tweak some UI in garden-o-matic now that the tree actually has a
51806         failure and I can see what this all looks like.
51807
51808         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
51809         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51810         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51811
51812 2011-07-12  Joseph Pecoraro  <joepeck@webkit.org>
51813
51814         Unreviewed. Skipping a few tests which fail due to differing output
51815            Unit tests shouldn't be hitting the disk anyway.  It's possible Config should move off of Port and onto Tool/Host directly.
51816         * Scripts/webkitpy/layout_tests/port/factory.py:
51817         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
51818         * Scripts/webkitpy/layout_tests/port/gtk.py:
51819         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
51820         * Scripts/webkitpy/layout_tests/port/mac.py:
51821         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
51822         * Scripts/webkitpy/layout_tests/port/qt.py:
51823         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
51824         * Scripts/webkitpy/layout_tests/port/webkit.py:
51825
51826 2011-07-12  Adam Roben  <aroben@apple.com>
51827
51828         Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot
51829
51830         Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
51831         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
51832
51833         Reviewed by Daniel Bates.
51834
51835         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
51836         (Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
51837         exit status but we didn't find any failure counts, assume that there was some error that
51838         caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).
51839
51840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
51841         Added a new test that shows that we get a failingTestCount of -1 when run-webkit-tests dies
51842         early.
51843         (runGetNumberOfFailingTestsTest): Moved most code here from the only pre-existing test in this
51844         file.
51845
51846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
51847         (LayoutTestResultsLoader.prototype.start): Bump the cache number so old cached data that was
51848         tainted by the bug fixed in this patch will be evicted.
51849
51850 2011-07-12  Adam Barth  <abarth@webkit.org>
51851
51852         cr-linux-ews complains about tests that aren't actually failing
51853         https://bugs.webkit.org/show_bug.cgi?id=64367
51854
51855         The underlying problem here is that full_results.json doesn't have
51856         enough information to determine whether a given test result was
51857         expected because whether an actual result is expected depends on
51858         whether full_results.json was generated duing a test run that included
51859         pixel tests.
51860
51861         The right long-term solution is to make full_results.json a complete
51862         description of what happened durning a test run.  In this patch
51863         however, to stop the spam, this patch makes the jsonresultsparser
51864         ignore pixel failures.
51865
51866         (I'm landing this patch unreviewed in order to stop the bots from
51867         spamming.  I'll happily address any review comments in a follow-up
51868         patch.)
51869
51870         * Scripts/webkitpy/common/net/resultsjsonparser.py:
51871         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
51872
51873 2011-07-12  Adam Barth  <abarth@webkit.org>
51874
51875         Re-work garden-o-matic UI to begin to look like the mocks
51876         https://bugs.webkit.org/show_bug.cgi?id=64334
51877
51878         Reviewed by Dimitri Glazkov.
51879
51880         This patch changes how we display failures to be more like the mock the
51881         dglazkov made. We now can display the same information much more
51882         compactly.
51883
51884         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
51885         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
51886         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
51887         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
51888         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
51889         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
51890         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
51891         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
51892         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
51893         * Scripts/webkitpy/tool/servers/gardeningserver.py:
51894
51895 2011-07-11  Adam Roben  <aroben@apple.com>
51896
51897         Extract TestFailures's bug-filing code into two new classes
51898
51899         Fixes <http://webkit.org/b/64300> TestFailures page's new-bug-filing code is a mess!
51900
51901         Reviewed by Darin Adler and Adam Barth.
51902
51903         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
51904         (Buildbot.prototype.resultsDirectoryURL): Changed to return a URI-encoded URL. Otherwise the
51905         URL isn't valid (and it's harder to mock this function).
51906
51907         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js:
51908         Added. Just tests the above change (for now).
51909
51910         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
51911         Added a license header, enclosed everything in a closure to avoid polluting the global
51912         namespace, changed the test name to actually describe the passing condition, and replaced
51913         uses of equals() with equal(). (The latter is the actual name of the function, and matches
51914         deepEqual, etc.)
51915
51916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Added.
51917         (NewBugForm): This class knows how to construct a <form> used for filing new bugs in
51918         Bugzilla based on some parameters.
51919         (NewBugForm.prototype.domElement): Creates and returns the <form> element. Code came from
51920         ViewController.prototype._domForNewAndExistingBugs.
51921
51922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
51923         Added. Tests the above code.
51924
51925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js: Added.
51926         (TestFailureBugForm): This class knows how to construct a <form> element used for filing new
51927         bugs specifically about test failures. Code came from
51928         ViewController.prototype._domForNewAndExistingBugs.
51929         (TestFailureBugForm.prototype.domElement): Slightly customizes the <form> element returned
51930         by NewBugForm.
51931         (TestFailureBugForm.prototype._computeOperatingSystem):
51932         (TestFailureBugForm.prototype._computePlatform):
51933         (TestFailureBugForm.prototype._createBugTitle):
51934         (TestFailureBugForm.prototype._failingResultsHTMLURL):
51935         (TestFailureBugForm.prototype._failingRevision):
51936         (TestFailureBugForm.prototype._passingRevision):
51937         (TestFailureBugForm.prototype._regressionRangeString):
51938         Code came from ViewController.prototype._domForNewAndExistingBugs. I broke it out into
51939         separate functions to break up the rat's nest a bit.
51940
51941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js:
51942         Added. Tests the above code.
51943
51944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
51945         (ViewController.prototype._domForNewAndExistingBugs): Moved code from here to
51946         TestFailureBugForm/NewBugForm, and changed this code to use a TestFailureBugForm.
51947
51948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
51949         NewBugForm/TestFailureBugForm.js.
51950
51951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
51952         Added new tests and required files.
51953
51954 2011-07-12  Adam Roben  <aroben@apple.com>
51955
51956         Test that no intermediate WTF::Strings are created when concatenating with string literals
51957
51958         Test for <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
51959         operator+ is suboptimal
51960
51961         Reviewed by Darin Adler.
51962
51963         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Added.
51964         (TestWebKitAPI::TEST): Test that a bunch of different string concatenation expressions don't
51965         create any intermediate WTF::Strings while they're being evaluated.
51966
51967         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
51968         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
51969         Added new file.
51970
51971 2011-07-12  Eric Seidel  <eric@webkit.org>
51972
51973         [Qt] NRWT should pick up the right httpd config file
51974         https://bugs.webkit.org/show_bug.cgi?id=64086
51975
51976         Reviewed by Adam Barth.
51977
51978         This is more fall-out from the Port class inappropriately encapsulating
51979         both platform and port knowledge.  We need to split out some of this
51980         platform knowledge into a separate class which can be better shared
51981         between ports.
51982
51983         The fix was to move all the _path_to_apache_config_file logic down
51984         into the WebKitPort baseclass so that all of the ports can find the
51985         right apache config file, regardless of what platform they may be running on.
51986
51987         I did not move this down into base.Port (even though I considered it).
51988         Chromium duplicates some of this logic, but since they have separate
51989         subclasses for each port-OS combination (e.g. ChromiumMac, ChromiumWin)
51990         they wouldn't notice the change.  Eventually we'll move this logic
51991         out of Port entirely, and then it will be shared by all ports.
51992
51993         I also cleaned up the http-config logic for ORWT while I was there,
51994         although since we're killing that code, I'm happy to revert that part
51995         of the change if changing it is viewed as needlessly risky.
51996
51997         During this cleanup, I noticed that no ports use the "default" httpd.conf
51998         which is left over from Mac OS X Tiger (and old linux distros) which used
51999         Apache 1.3.  I've removed httpd.conf (and associated support in ORWT) since
52000         we no longer support any ports which use this httpd.conf.
52001
52002         * Scripts/webkitperl/httpd.pm:
52003         (getHTTPDConfigPathForTestDirectory):
52004         * Scripts/webkitpy/layout_tests/port/base.py:
52005         * Scripts/webkitpy/layout_tests/port/gtk.py:
52006         * Scripts/webkitpy/layout_tests/port/mac.py:
52007         * Scripts/webkitpy/layout_tests/port/qt.py:
52008         * Scripts/webkitpy/layout_tests/port/webkit.py:
52009         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
52010         * Scripts/webkitpy/layout_tests/port/win.py:
52011         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
52012
52013 2011-07-11  Hironori Bono  <hbono@chromium.org>
52014
52015         Reviewed by Adam Roben.
52016
52017         Implement layoutTestController.setTextDirection for WebKit2 and Windows.
52018         https://bugs.webkit.org/show_bug.cgi?id=61931
52019
52020         This change implements layoutTextController.setTextDirection for WebKit2
52021         and Windows so we can run a layout test added by r87770 on them. Each
52022         implementation adds a wrapper function for Editor::setBaseWritingDirection()
52023         so LayoutTestController can call it.
52024
52025         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
52026         (LayoutTestController::setTextDirection): Implemented the binding function
52027         for layoutTestController.setTextDirection (Windows).
52028         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
52029         Added a binding function for layoutTestController.setTextDirection (WebKit2).
52030         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto.
52031         (WTR::LayoutTestController::setTextDirection):
52032         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto.
52033
52034 2011-07-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
52035
52036         [EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time.
52037         https://bugs.webkit.org/show_bug.cgi?id=64293
52038
52039         Reviewed by Kent Tamura.
52040
52041         gEcoreEvas was being destroyed after shutdownEfl() was called, so the
52042         call to ecore_evas_free() failed.
52043
52044         We now shut it down manually before shutdownEfl() is called.
52045
52046         * DumpRenderTree/efl/ImageDiff.cpp:
52047         (main): Destroy gEcoreEvas before shutting down the EFL.
52048
52049 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
52050
52051         Make Chromium Mac and Linux tests bot core builders
52052         https://bugs.webkit.org/show_bug.cgi?id=63196
52053
52054         Reviewed by Adam Barth.
52055
52056         Added Chromium Mac and Linux Release Tests bots core builders.
52057
52058         Also rearranged the order of bots so that test bots show up right next to
52059         respective builders.
52060
52061         * BuildSlaveSupport/build.webkit.org-config/config.json:
52062         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
52063         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
52064
52065 2011-07-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
52066
52067         [EFL] DRT: Add code related to font management.
52068         https://bugs.webkit.org/show_bug.cgi?id=63989
52069
52070         Reviewed by Kent Tamura.
52071
52072         The added files are responsible for managing fontconfig and adding the
52073         fonts required by some layout tests to fontconfig's path.
52074
52075         * DumpRenderTree/efl/FontManagement.cpp: Added.
52076         (getFontDirectories):
52077         (getFontFiles):
52078         (addFontDirectories):
52079         (addFontFiles):
52080         (addFontsToEnvironment):
52081         * DumpRenderTree/efl/FontManagement.h: Added.
52082
52083 2011-07-08  Dirk Pranke  <dpranke@chromium.org>
52084
52085         nrwt: linting fixes
52086         https://bugs.webkit.org/show_bug.cgi?id=64225
52087
52088         Reviewed by Eric Siedel.
52089
52090         Miscellaneous linting fixes. The most notable change is that
52091         we add public attributes for user, executive, filesystem, and
52092         options on the Port object, so we don't have to refer to the
52093         "protected" versions all over the place".
52094
52095         * Scripts/webkitpy/layout_tests/controllers/manager.py:
52096         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
52097         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
52098         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py:
52099         * Scripts/webkitpy/layout_tests/controllers/worker.py:
52100         * Scripts/webkitpy/layout_tests/port/base.py:
52101         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
52102
52103 2011-07-11  Ryosuke Niwa  <rniwa@webkit.org>
52104
52105         webkit-patch roll-chromium-deps no longer works
52106         https://bugs.webkit.org/show_bug.cgi?id=64324
52107
52108         Reviewed by James Robinson.
52109
52110         Lower the minimum commit message length to 10.
52111
52112         * Scripts/webkitpy/tool/steps/commit.py:
52113
52114 2011-07-11  Alice Boxhall  <aboxhall@chromium.org>
52115
52116         Convert json_results_generator.py to output version 4 JSON.
52117         https://bugs.webkit.org/show_bug.cgi?id=60869
52118
52119         Reviewed by Ojan Vafai.
52120
52121         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
52122         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
52123         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
52124
52125 2011-07-11  Martin Robinson  <mrobinson@igalia.com>
52126
52127         [GTK] [NRWT] Pixel tests do not work
52128         https://bugs.webkit.org/show_bug.cgi?id=64091
52129
52130         Reviewed by Eric Seidel.
52131
52132         Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
52133         path to the ImageDiff binary.
52134
52135         * Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
52136
52137 2011-07-11  Dirk Pranke  <dpranke@chromium.org>
52138
52139         Fix hang on win32 in a multiprocessing test that shouldn't have been running.
52140
52141         Unreviewed, build fix.
52142
52143         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
52144
52145 2011-07-11  Adam Roben  <aroben@apple.com>
52146
52147         Don't count leaks as test failures on TestFailures's front page
52148
52149         As a bonus, this patch adds our first unit test.
52150
52151         Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
52152         are failing on the Leaks bot than actually are
52153
52154         Reviewed by Adam Barth.
52155
52156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
52157         (Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
52158         failure counts.
52159
52160         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
52161         Added. Contains a simple test to show that leaks aren't counted as test failures.
52162
52163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
52164         Added. This is the test harness.
52165
52166 2011-06-14  Mike Stegeman  <mrstegeman@gmail.com>
52167
52168         [GTK] Add API to allow setting local storage database path
52169         https://bugs.webkit.org/show_bug.cgi?id=62091
52170
52171         Reviewed by Martin Robinson and Gustavo Noronha.
52172
52173         Expose the path of the localStorage databases through a setting
52174         to allow HTML5 localStorage to be persistent. New setting is:
52175         html5-local-storage-database-path
52176
52177         * DumpRenderTree/gtk/DumpRenderTree.cpp:
52178         (resetDefaultsToConsistentValues):
52179
52180 2011-07-11  Adam Barth  <abarth@webkit.org>
52181
52182         garden-o-matic should be able to rebaseline tests
52183         https://bugs.webkit.org/show_bug.cgi?id=64186
52184
52185         Reviewed by Eric Seidel.
52186
52187         This patch contains a simple HTTP server binding for the
52188         rebaseline-test command.  The frontend will appear in another patch.
52189
52190         * Scripts/webkitpy/tool/servers/gardeningserver.py:
52191         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
52192         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
52193
52194 2011-07-11  Adam Barth  <abarth@webkit.org>
52195
52196         Add some basic UI for showing regression ranges
52197         https://bugs.webkit.org/show_bug.cgi?id=64243
52198
52199         Reviewed by Eric Seidel.
52200
52201         This UI is all temporary.  It exists mostly just to have some buttons
52202         to click to exercise the code.
52203
52204         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
52205         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
52206         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
52207         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
52208         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
52209
52210 2011-07-11  Adam Barth  <abarth@webkit.org>
52211
52212         garden-o-matic should be able to determine which revisions caused a given failure
52213         https://bugs.webkit.org/show_bug.cgi?id=64189
52214
52215         Reviewed by Adam Roben.
52216
52217         Walking the failure history looking for failures turns out to be
52218         slightly tricky because the network requests are asynchronous.
52219         Currently we do all the fetches serially and our cache is unbounded.
52220         We'll probably optimize both those parameters eventually.
52221
52222         This patch also generalizes some functionality in the unit testing
52223         framework to make testing this sort of code easier.
52224
52225         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
52226         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
52227         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
52228
52229 2011-07-11  Adam Barth  <abarth@webkit.org>
52230
52231         Add a webkit-patch command for rebaselining an individual test
52232         https://bugs.webkit.org/show_bug.cgi?id=64246
52233
52234         Reviewed by Eric Seidel.
52235
52236         This patch introduces a command that's able to rebaseline a single
52237         test.  Currently, the command works only with the build.chromium.org
52238         buildbots, but extending it to work with the build.webkit.org bots
52239         shouldn't be that hard.
52240
52241         A complete rebaseling tool should also include an "optimize baselines"
52242         command (which moves/deletes baselines in order to reduce the number of
52243         expected results files), but that will come in a future patch.
52244
52245         Really BuilderToPort should be merged into builders.py, but I'm going
52246         to save that for a future patch as well.  (We need to stop shaving yaks
52247         at some point.)
52248
52249         * Scripts/webkitpy/tool/commands/rebaseline.py:
52250
52251 2011-07-11  Adam Barth  <abarth@webkit.org>
52252
52253         garden-o-matic should be able to roll out patches
52254         https://bugs.webkit.org/show_bug.cgi?id=64185
52255
52256         Reviewed by Eric Seidel.
52257
52258         This gardening server API is simply a binding to the rollout machinery
52259         already present in webkit-patch.
52260
52261         * Scripts/webkitpy/tool/commands/gardenomatic.py:
52262         * Scripts/webkitpy/tool/servers/gardeningserver.py:
52263         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
52264
52265 2011-07-11  Csaba Osztrogonác  <ossy@webkit.org>
52266
52267         [Qt][Mac] Unreviewed fix after r90746.
52268
52269         * Scripts/run-webkit-tests:
52270         (useNewRunWebKitTests): Really disable NRWT for qt-mac platform.
52271
52272 2011-07-11  Adam Roben  <aroben@apple.com>
52273
52274         Teach TestFailures that ORWT's results.html file might be missing due to all tests passing
52275
52276         There are three reasons why we might fail to fetch ORWT's results.html:
52277           - All tests passed, so no results.html was generated
52278           - Some error during the test run caused results.html not to be generated (e.g., ORWT
52279             timed out)
52280           - Some network error occurred when fetching results.html
52281
52282         We were failing to account for the first possibility in some cases. For test runs before
52283         r89610, we first check build.webkit.org/json to determine how many tests failed and whether
52284         ORWT exited early due to too many failures; if all tests passed then we don't fetch
52285         results.html at all. r89610 changed ORWT to put information in results.html about exiting
52286         early due to too many failures, so we no longer needed to check build.webkit.org/json to get
52287         that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
52288         still needed to check build.webkit.org/json to find out if all tests passed!
52289
52290         Now, for test runs after r89610, we check results.html first, and then check
52291         build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
52292         tests passing and the error cases.
52293
52294         Fixes <http://webkit.org/b/64280> TestFailures page can't pinpoint that r90699 caused 13
52295         tests to fail on Windows 7 Release (WebKit2 Tests)
52296
52297         Reviewed by David Kilzer.
52298
52299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
52300         (LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
52301         cached data will get evicted. We were marking builds where all tests passed as errors!
52302         (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
52303         parameters to the fetchAndParseResultsHTML helper function, and added a similar
52304         fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
52305         from later in the function). For test runs before r89610, we first check
52306         build.webkit.org/json then check results.html. For builds after r89610, we first check
52307         results.html and then check build.webkit.org/json if we couldn't fetch results.html.
52308
52309 2011-07-11  Csaba Osztrogonác  <ossy@webkit.org>
52310
52311         new-run-webkit-tests does not support qt-arm or qt-4.8 results
52312         https://bugs.webkit.org/show_bug.cgi?id=64071
52313
52314         [Qt] NRWT should pick up the right httpd config file
52315         https://bugs.webkit.org/show_bug.cgi?id=64086
52316
52317         Reviewed by Zoltán Herczeg.
52318
52319         * Scripts/run-webkit-tests: Disable NRWT for qt-mac, qt-arm and qt-4.8 platforms until fix.
52320         (useNewRunWebKitTests):
52321
52322 2011-07-11  Kenichi Ishibashi  <bashi@chromium.org>
52323
52324         Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files
52325         https://bugs.webkit.org/show_bug.cgi?id=64248
52326
52327         Reviewed by Kent Tamura.
52328
52329         * DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp.
52330         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto.
52331         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto.
52332         * GNUmakefile.am: Ditto.
52333
52334 2011-07-10  Kenichi Ishibashi  <bashi@chromium.org>
52335
52336         Let plugins participate in form submission
52337         https://bugs.webkit.org/show_bug.cgi?id=13061
52338
52339         Adds NPPVformValue support to the testing plugin.
52340
52341         Reviewed by Anders Carlsson.
52342
52343         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added FormValue.cpp
52344         * DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp: Added.
52345         (FormValue::FormValue): Ditto.
52346         (FormValue::NPP_GetValue): Ditto.
52347
52348 2011-07-11  Roland Steiner  <rolandsteiner@chromium.org>
52349
52350         Reviewed by Tony Chang.
52351
52352         Complete functions in filesystem.py
52353         https://bugs.webkit.org/show_bug.cgi?id=63528
52354
52355         - missing text file functions added
52356         - functions sorted
52357         - removed 'append' optional parameters (were unused)
52358         - adapted filesystem_mock in the same way
52359
52360         * Scripts/webkitpy/common/system/filesystem.py:
52361         * Scripts/webkitpy/common/system/filesystem_mock.py:
52362         * Scripts/webkitpy/common/system/filesystem_unittest.py:
52363
52364 2011-07-10  Adam Barth  <abarth@webkit.org>
52365
52366         Clean up style in fallback path calculation
52367         https://bugs.webkit.org/show_bug.cgi?id=64239
52368
52369         Reviewed by Daniel Bates.
52370
52371         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
52372         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
52373         * Scripts/webkitpy/layout_tests/port/mac.py:
52374         * Scripts/webkitpy/layout_tests/port/win.py:
52375
52376 2011-07-10  Balazs Kelemen  <kbalazs@webkit.org>
52377
52378         [Qt][WK2] Implement the rest of WTR::PlatformWebView
52379         https://bugs.webkit.org/show_bug.cgi?id=63630
52380
52381         Reviewed by Kenneth Rohde Christiansen.
52382
52383         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
52384         (WTR::PlatformWebView::windowFrame):
52385         (WTR::PlatformWebView::setWindowFrame):
52386
52387 2011-07-10  Mark Rowe  <mrowe@apple.com>
52388
52389         Teach build-webkit how to find the latest WebKitSystemInterface binary.
52390
52391         * Scripts/build-webkit:
52392
52393 2011-07-09  Adam Roben  <aroben@apple.com>
52394
52395         Teach TestFailures to abbreviate the examples of test flakiness
52396
52397         These lists can get quite long, and it's not really helpful in most cases to have soooooo
52398         many examples of flakiness.
52399
52400         Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
52401         long they're hard to navigate
52402
52403         Reviewed by Dan Bates.
52404
52405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
52406         (FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
52407         of examples, replace the middle items with a separator.
52408
52409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
52410         (.flakiness-example-separator): Added styles for the separator.
52411
52412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
52413         (ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
52414         the separator.
52415
52416 2011-07-09  Dirk Pranke  <dpranke@chromium.org>
52417
52418         nrwt: stack traces from worker-side exceptions aren't very useful inside test-webkitpy
52419         https://bugs.webkit.org/show_bug.cgi?id=64218
52420
52421         Reviewed by Eric Seidel.
52422
52423         Exceptions aren't picklable and can't be sent across the
52424         manager/worker message queue without losing information. NRWT
52425         handles this by turning the stack trace into a set of strings,
52426         and logging the strings when we receive an exception from the
52427         worker. However, when you are running tests and something
52428         crashes on the worker side, test-webkitpy prints the
52429         manager-side stack trace, which is just confusing and useless.
52430
52431         This patch changes the logic so that exceptions are passed
52432         through as-is when the worker and manager are in the same
52433         process (the --worker-model=inline option). This increases the
52434         code paths slightly but makes crashes much more useful.
52435
52436         * Scripts/webkitpy/layout_tests/controllers/manager.py:
52437         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
52438         * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
52439         * Scripts/webkitpy/layout_tests/controllers/worker.py:
52440         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
52441
52442 2011-07-09  Darin Fisher  <darin@chromium.org>
52443
52444         Eliminate bad dependency on gfx::Point.
52445         https://bugs.webkit.org/show_bug.cgi?id=64228
52446
52447         Reviewed by Kent Tamura.
52448
52449         * DumpRenderTree/chromium/EventSender.cpp:
52450         (initMouseEvent):
52451
52452 2011-07-08  Ojan Vafai  <ojan@chromium.org>
52453
52454         pull static dashboard files into the appengine server from the chromium repository
52455         https://bugs.webkit.org/show_bug.cgi?id=64208
52456
52457         Reviewed by Dirk Pranke.
52458
52459         These files belong in the WebKit repo since they are tied primarily to the webkit tests.
52460         They have some extra bits to support chromium's gtests, but that seems fine.
52461         Mainly, this will allow other WebKit hackers to hack on the dashboards.
52462
52463         As a nice side-effect, we can now push the dashboard files when we do appengine pushes
52464         instead of the weird thing we used to do of pulling them from the Chromium repository
52465         and storing them in the appengine datastore. This allows for cleaning up a lot of code
52466         and will likely make the dashboards load a bit faster.
52467
52468         The new JS files don't fully match WebKit style, but I'd like to clean that up in a
52469         followup patch if possible to maintain my sanity with this patch.
52470
52471         * TestResultServer/app.yaml:
52472         * TestResultServer/handlers/dashboardhandler.py: Removed.
52473         * TestResultServer/handlers/menu.py:
52474         * TestResultServer/main.py:
52475         * TestResultServer/model/dashboardfile.py: Removed.
52476         * TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
52477         * TestResultServer/static-dashboards/README.dygraph.txt: Added.
52478         * TestResultServer/static-dashboards/README.webtreemap.txt: Added.
52479         * TestResultServer/static-dashboards/aggregate_results.html: Added.
52480         * TestResultServer/static-dashboards/builders.js: Added.
52481         * TestResultServer/static-dashboards/dashboard_base.js: Added.
52482         * TestResultServer/static-dashboards/dygraph-combined.js: Added.
52483         * TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
52484         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
52485         * TestResultServer/static-dashboards/timeline_explorer.html: Added.
52486         * TestResultServer/static-dashboards/treemap.html: Added.
52487         * TestResultServer/static-dashboards/webtreemap.css: Added.
52488         * TestResultServer/static-dashboards/webtreemap.js: Added.
52489         * TestResultServer/stylesheets/dashboardfile.css: Removed.
52490         * TestResultServer/stylesheets/menu.css:
52491         * TestResultServer/templates/dashboardfilelist.html: Removed.
52492         * TestResultServer/templates/menu.html:
52493
52494 2011-07-08  Adam Roben  <aroben@apple.com>
52495
52496         Make TestFailures's list of flaky tests look more like the list of non-flaky tests
52497
52498         Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
52499
52500         Reviewed by Daniel Bates.
52501
52502         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
52503         (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
52504         tests.
52505         (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
52506         from here...
52507         (#failure-history > li): ...to here.
52508
52509         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
52510         (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
52511         styling purposes.
52512
52513 2011-07-08  Jeffrey Pfau  <jpfau@apple.com>
52514
52515         Unreviewed, add myself as committer.
52516
52517         * Scripts/webkitpy/common/config/committers.py:
52518
52519 2011-07-08  Adam Barth  <abarth@webkit.org>
52520
52521         TestResultsServer should keep old test results
52522         https://bugs.webkit.org/show_bug.cgi?id=64199
52523
52524         Reviewed by Ojan Vafai.
52525
52526         Having historical data will help us do failure archeology.
52527
52528         * TestResultServer/handlers/testfilehandler.py:
52529         * TestResultServer/model/testfile.py:
52530         * TestResultServer/templates/showfilelist.jsonp: Added.
52531
52532 2011-07-08  Adam Roben  <aroben@apple.com>
52533
52534         Remove commit-log-editor's dependency on Module::Load::Conditional
52535
52536         This module isn't available in Perl 5.8.8 (the version used on Leopard).
52537
52538         Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
52539         webkitpy.common.checkout.checkout_unittest failing on Leopard
52540
52541         Reviewed by Daniel Bates.
52542
52543         * Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of
52544         Module::Load::Conditional::can_load.
52545         (loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.
52546
52547 2011-07-08  Adam Roben  <aroben@apple.com>
52548
52549         Make checkout_unittest more robust against files moving around
52550
52551         Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
52552         Scripts directory
52553
52554         Reviewed by Adam Barth.
52555
52556         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
52557         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
52558         object and use it to get the path to the Scripts directory, rather than hard-coding the
52559         relative path from this file to Scripts.
52560
52561 2011-07-08  Adam Roben  <aroben@apple.com>
52562
52563         Make TestFailures remember that run-webkit-tests timed out, even across reloads
52564
52565         Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
52566         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
52567
52568         Reviewed by Daniel Bates.
52569
52570         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
52571         (LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
52572         When true, it indicates that there was an error retrieving the results for this build and
52573         that the errorCallback should be called.
52574
52575 2011-07-08  Adam Barth  <abarth@webkit.org>
52576
52577         Teach garden-o-matic how to display test results
52578         https://bugs.webkit.org/show_bug.cgi?id=64141
52579
52580         Reviewed by Ojan Vafai.
52581
52582         This patch includes basic infrastructure for probing build.chromium.org
52583         for test results.  We only handle text and image tests, not anything
52584         complicated like reftests.  Also, we're using the revision/build
52585         independent results store on the server, so we're avoiding that
52586         complication for now.
52587
52588         It's slightly hacky that we need to probe the server to see what kinds
52589         of results exist.  A better solution would be to add CORS support to
52590         the server or to use the local server to help.
52591
52592         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
52593         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
52594         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
52595         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
52596         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
52597         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
52598
52599 2011-07-08  Dirk Pranke  <dpranke@chromium.org>
52600
52601         REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
52602         https://bugs.webkit.org/show_bug.cgi?id=64092
52603
52604         Reviewed by Tony Chang.
52605
52606         The code was incorrectly creating empty shards in the
52607         shard_in_two case.
52608
52609         * Scripts/webkitpy/layout_tests/controllers/manager.py:
52610         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
52611
52612 2011-07-08  Adam Roben  <aroben@apple.com>
52613
52614         Teach buildbot to figure out how many webkitpy/webkitperl tests failed
52615
52616         Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
52617         tests failed when looking at build.webkit.org
52618
52619         Reviewed by Eric Seidel.
52620
52621         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
52622         (TestWithFailureCount): New class that represents a test build step which has an associated
52623         failure count. Eventually we should move more of our test classes to deriving from this.
52624         (TestWithFailureCount.countFailures): Method for subclasses to override to say how many
52625         failures occurred.
52626
52627         (TestWithFailureCount.commandComplete):
52628         (TestWithFailureCount.evaluateCommand):
52629         (TestWithFailureCount.getText):
52630         (TestWithFailureCount.getText2):
52631         These were all based on RunGtkAPITests.
52632
52633         (RunPythonTests): Changed to inherit from TestWithFailureCount.
52634         (RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
52635         failures.
52636         (RunPerlTests): Changed to inherit from TestWithFailureCount.
52637         (RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
52638         failures.
52639
52640 2011-07-08  Adam Roben  <aroben@apple.com>
52641
52642         Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
52643
52644         Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
52645         bots due to commit-log-editor errors
52646
52647         Reviewed by Adam Barth.
52648
52649         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
52650         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
52651         $CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
52652         commit-log-editor can find a value for the committer's email, and that the committer and
52653         author email addresses match, which will prevent commit-log-editor from inserting a "Patch
52654         by" line in the commit message.
52655
52656 2011-07-08  Andreas Kling  <kling@webkit.org>
52657
52658         [Qt][WK2] Views should expose QActions for basic navigation.
52659         https://bugs.webkit.org/show_bug.cgi?id=64174
52660
52661         Reviewed by Benjamin Poulain.
52662
52663         Bring the toolbar in Qt's MiniBrowser back to life.
52664
52665         * MiniBrowser/qt/BrowserView.cpp:
52666         (BrowserView::navigationAction):
52667         * MiniBrowser/qt/BrowserView.h:
52668         * MiniBrowser/qt/BrowserWindow.cpp:
52669         (BrowserWindow::BrowserWindow):
52670
52671 2011-07-08  Adam Roben  <aroben@apple.com>
52672
52673         Teach TestFailures how to find test names in commit-log-editor-style commit messages
52674
52675         TestFailures was relying on Trac turning the list of modified files in our commit messages
52676         into an HTML list. But Trac only does this when the list of modified files is indented.
52677         commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
52678         list, which was confusing TestFailures.
52679
52680         TestFailures now does much simpler parsing of the commit message (i.e., just a substring
52681         search) without relying at all on its structure.
52682
52683         Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
52684         fast/dom/HTMLProgressElement/progress-element-markup.html on Windows
52685
52686         Reviewed by David Kilzer.
52687
52688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
52689         (Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
52690         message, just return its text.
52691
52692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
52693         (ViewController.prototype._domForRegressionRange): Instead of searching for test names in
52694         each commit's list of modified files, just search for test names anywhere in the commit's
52695         message.
52696
52697 2011-07-08  Adam Barth  <abarth@webkit.org>
52698
52699         sheriffbot is too spammy in IRC
52700         https://bugs.webkit.org/show_bug.cgi?id=64153
52701
52702         Reviewed by Eric Seidel.
52703
52704         Reporting failures in IRC worked well when the tree was greener than it
52705         is today.  Nowadays, this feature mostly just results in spam about
52706         false positives.  If we reach a greener state, we can bring this code
52707         back.
52708
52709         (Another possibility is to restrict this feature to builder bots,
52710         rather than including testers, as we did before this patch.)
52711
52712         * Scripts/webkitpy/tool/commands/sheriffbot.py:
52713         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
52714
52715 2011-07-08  Adam Roben  <aroben@apple.com>
52716
52717         Ensure commit-log-editor adds a "Patch by" line when the author and committer are different
52718
52719         Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
52720         by" line. But some patches (like rollout patches) don't contain that line. Now we always add
52721         "Patch by" to the commit log regardless of the ChangeLog's contents.
52722
52723         Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
52724         should have been abarth@webkit.org
52725
52726         Reviewed by Anders Carlsson.
52727
52728         * Scripts/commit-log-editor:
52729         (createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
52730         before. If there is no "Reviewed by" line, try to put it just above the first modified file.
52731         If all else fails, put it at the end of the commit message.
52732         (patchAuthorshipString): Added. Code came from createCommitMessage.
52733
52734 2011-07-08  Herczeg Zoltan  <zherczeg@webkit.org>
52735
52736         Reviewed by Andreas Kling.
52737
52738         Adding myself as a reviewer.
52739
52740         * Scripts/webkitpy/common/config/committers.py:
52741
52742 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
52743
52744         [wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.
52745
52746         * wx/build: Removed.
52747         * wx/build/build_utils.py: Removed.
52748         * wx/build/settings.py: Removed.
52749         * wx/build/waf_extensions.py: Removed.
52750         * wx/build/wxpresets.py: Removed.
52751         * wx/packaging/build-mac-installer.py:
52752
52753 2011-07-07  Kevin Ollivier  <kevino@theolliviers.com>
52754
52755         [wx] Unreviewed build fix, more fixes for install name issues.
52756
52757         * wx/packaging/build-mac-installer.py:
52758
52759 2011-07-07  Dirk Pranke  <dpranke@chromium.org>
52760
52761         test-webkitpy fails on chromium win
52762         https://bugs.webkit.org/show_bug.cgi?id=64137
52763
52764         Reviewed by Eric Seidel.
52765
52766         test-webkitpy doesn't play nicely with the multiprocessing
52767         module on win32. An earlier change actually reenabled the tests
52768         on win32 by mistake.
52769
52770         This patch also fixes a few cases where path names will trip
52771         things up on win32 (e.g., by testing unix paths on windows).
52772         We do not lose any real coverage here with those fixes.
52773
52774         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
52775         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
52776         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
52777         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
52778
52779 2011-07-07  Leandro Pereira  <leandro@profusion.mobi>
52780
52781         [ImageDiff] Calculate/print difference right after reading baseline image.
52782         https://bugs.webkit.org/show_bug.cgi?id=64117
52783
52784         Reviewed by Kent Tamura.
52785
52786         Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
52787         it.  Whichever happens first.
52788
52789         * DumpRenderTree/efl/ImageDiff.cpp:
52790         (main):
52791
52792 2011-07-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
52793
52794         [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
52795         https://bugs.webkit.org/show_bug.cgi?id=64107
52796
52797         Reviewed by Kent Tamura.
52798
52799         The pointer is later managed by BitmapContext, but it was being
52800         de-refed and deleted earlier by our RefPtr, causing crashes in all
52801         pixel tests.
52802
52803         We now call leakRef() to make sure it is not removed when our
52804         createBitmapContextFromWebView goes out of context.
52805
52806         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
52807         (createBitmapContextFromWebView):
52808
52809 2011-07-07  Adam Roben  <aroben@apple.com>
52810
52811         Update TestFailures's title and header immediately upon navigation
52812
52813         Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks
52814
52815         Reviewed by Daniel Bates.
52816
52817         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
52818         (ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
52819         title.
52820         (ViewController.prototype._displayBuilder): Set the page's title and clear out any old
52821         content immediately instead of waiting for the first set of results for the history
52822         analyzer. As we receive new results from the analyzer we'll just clear out the main content
52823         area and replace it with the new info.
52824         (ViewController.prototype._displayTesters): Set the page's title and clear out any old
52825         content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
52826         in a little use of our removeAllChildren helper, too.
52827         (ViewController.prototype._setTitle): Added. Set's the page's title and the header text.
52828
52829 2011-07-07  Adam Roben  <aroben@apple.com>
52830
52831         Make Checkout use SCM's Executive instead of conjuring up its own
52832
52833         This will improve integration with the rest of webkitpy, particularly when invoked via
52834         webkit-patch.
52835
52836         Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
52837         Executive inappropriately
52838
52839         Reviewed by Adam Barth.
52840
52841         * Scripts/webkitpy/common/checkout/checkout.py:
52842         (Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
52843         our own use. SCM might have some super-special Executive that it uses under the covers, and
52844         we want to use it, too!
52845
52846         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
52847         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
52848         method to call through to Executive.run_command.
52849
52850 2011-07-07  Adam Roben  <aroben@apple.com>
52851
52852         Make Term/ReadKey.pm an optional dependency of commit-log-editor
52853
52854         When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
52855
52856         Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
52857         webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
52858         Term/ReadKey.pm module
52859
52860         Reviewed by Xan Lopez.
52861
52862         * Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
52863         Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
52864         that existing commit messages will be preserved. (Users can manually remove existing commit
52865         messages using git-reset.)
52866
52867 2011-07-07  Adam Roben  <aroben@apple.com>
52868
52869         Keep testing that commit messages containing Unicode are handled properly by webkitpy
52870
52871         Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
52872         correctly handle Unicode in commit messages
52873
52874         Reviewed by Eric Seidel.
52875
52876         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in
52877         places in the ChangeLog that will end up being included in the commit message.
52878
52879 2011-07-07  Andreas Kling  <kling@webkit.org>
52880
52881         [Qt][WK2] Remove Symbian code.
52882         https://bugs.webkit.org/show_bug.cgi?id=64101
52883
52884         Reviewed by Benjamin Poulain.
52885
52886         * MiniBrowser/qt/BrowserWindow.cpp:
52887         (BrowserWindow::BrowserWindow):
52888         (BrowserWindow::screenshot):
52889         * MiniBrowser/qt/MiniBrowser.pro:
52890         * MiniBrowser/qt/MiniBrowserApplication.h:
52891         (WindowOptions::WindowOptions):
52892
52893 2011-07-07  Andreas Kling  <kling@webkit.org>
52894
52895         [Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
52896         https://bugs.webkit.org/show_bug.cgi?id=64099
52897
52898         Reviewed by Benjamin Poulain.
52899
52900         * MiniBrowser/qt/BrowserWindow.cpp:
52901         (BrowserWindow::openFile):
52902         (BrowserWindow::screenshot):
52903         (BrowserWindow::loadURLListFromFile):
52904
52905 2011-07-07  Adam Roben  <aroben@apple.com>
52906
52907         Completely ignore too-many-failures builds in TestFailures in most circumstances
52908
52909         Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
52910         really use them to perform regression analysis. The only time we want to pay attention to
52911         too-many-failures builds is when we're trying to explain when the current bout of
52912         too-many-failures started.
52913
52914         Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
52915         in a build that didn't even run it (because it exited early due to too many failues)
52916
52917         Reviewed by David Kilzer.
52918
52919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
52920         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
52921         too-many-failures handling that would cause us to blame builds that didn't even run a given
52922         test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
52923         build was itself a too-many-failures build.
52924
52925 2011-07-07  Adam Roben  <aroben@apple.com>
52926
52927         Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
52928
52929         Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
52930         commit-log-editor's
52931
52932         Reviewed by David Kilzer.
52933
52934         * Scripts/webkitpy/common/checkout/checkout.py:
52935         (Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
52936         the modified ChangeLogs, to generate the commit message, rather than trying to generate one
52937         ourselves.
52938
52939         * Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
52940         to match commit-log-editor's format.
52941         (CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
52942         directories so we can see how the various entries get labeled in the commit message.
52943         (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
52944         instance that knows how to find commit-log-editor and pass it to our Checkout instance.
52945         Don't bother capturing output, since there shouldn't be any.
52946
52947 2011-07-07  Adam Roben  <aroben@apple.com>
52948
52949         Add a --print-log option to commit-log-editor
52950
52951         When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
52952         generates a commit message from those ChangeLogs, prints it to stdout, and exits.
52953
52954         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
52955         readable than commit-log-editor's
52956
52957         Reviewed by David Kilzer.
52958
52959         * Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
52960         option, which calls through to createCommitMessage, prints the result, and exits.
52961         (printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
52962         explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
52963
52964 2011-07-07  Adam Roben  <aroben@apple.com>
52965
52966         Extract commit-log-editor's commit-message-generation code into a separate function
52967
52968         As a bonus, we now skip a bunch of work in the case where we are generating a commit message
52969         for staged git changes.
52970
52971         Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
52972         readable than commit-log-editor's
52973
52974         Reviewed by David Kilzer.
52975
52976         * Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
52977         file so that it will be defined even if we aren't operating on an existing log message.
52978         Moved a bunch of top-level code to generate the commit message from here...
52979         (createCommitMessage): ...to here.
52980
52981 2011-07-07  Carlos Garcia Campos  <cgarcia@igalia.com>
52982
52983         [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
52984         https://bugs.webkit.org/show_bug.cgi?id=63988
52985
52986         Reviewed by Martin Robinson.
52987
52988         * MiniBrowser/gtk/BrowserWindow.c:
52989         (browserWindowConstructed):
52990         (decidePolicyForNavigationAction): Ignore the action if a link is
52991         clicked with the middle buttonm and open the link in a new window.
52992         (browserWindowPolicyClientInit):
52993
52994 2011-07-07  Adam Barth  <abarth@webkit.org>
52995
52996         Remove style_references.py
52997         https://bugs.webkit.org/show_bug.cgi?id=64070
52998
52999         Reviewed by Eric Seidel.
53000
53001         We never really adopted the _references design, and this file is a bit
53002         of an orphan at this point.
53003
53004         * Scripts/check-webkit-style:
53005         * Scripts/webkitpy/style/checker.py:
53006         * Scripts/webkitpy/style/checker_unittest.py:
53007         * Scripts/webkitpy/style/checkers/python.py:
53008         * Scripts/webkitpy/style/checkers/test_expectations.py:
53009         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
53010         * Scripts/webkitpy/style/main_unittest.py:
53011         * Scripts/webkitpy/style_references.py: Removed.
53012
53013 2011-07-07  Eric Seidel  <eric@webkit.org>
53014
53015         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
53016         https://bugs.webkit.org/show_bug.cgi?id=64056
53017
53018         Unreviewed.
53019
53020         I had written this unittest prior to landing my change, but
53021         had named it qt_unitest.py, so it wasn't running (nor was
53022         it added to my git repo).
53023
53024         Once I fixe the name of the unittest file, it was very easy
53025         to fix the error in webkit.py (which already had a FIXME).
53026
53027         * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
53028         * Scripts/webkitpy/layout_tests/port/webkit.py:
53029
53030 2011-07-07  Eric Seidel  <eric@webkit.org>
53031
53032         Unreviewed.  Add more debug logging about which test expectations we're using.
53033
53034         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
53035         * Scripts/webkitpy/layout_tests/port/webkit.py:
53036
53037 2011-07-06  Adam Barth  <abarth@webkit.org>
53038
53039         Remove unexpected_results.json
53040         https://bugs.webkit.org/show_bug.cgi?id=64065
53041
53042         Reviewed by Eric Seidel.
53043
53044         No one should be using this file any more.  This patch removes it from
53045         the face of the earth.  This patch also removes two NRWT-specific
53046         command line options that were implemented using
53047         unexpected_results.json.
53048
53049         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
53050         * Scripts/webkitpy/layout_tests/controllers/manager.py:
53051         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
53052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53053         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
53054         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
53055         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
53056
53057 2011-07-07  Adam Barth  <abarth@webkit.org>
53058
53059         REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
53060         https://bugs.webkit.org/show_bug.cgi?id=64067
53061
53062         Reviewed by Eric Seidel.
53063
53064         The author of r90520 forgot to change the chromium_gpu.py implemenation
53065         of this method as well.
53066
53067         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
53068
53069 2011-07-06  Eric Seidel  <eric@webkit.org>
53070
53071         Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
53072         https://bugs.webkit.org/show_bug.cgi?id=64056
53073
53074         Reviewed by Adam Barth.
53075
53076         This fixes the MacPort's version of baseline_search_path to include
53077         wk2 fallback like WebKitPort's does.  This also re-works the QtPort
53078         to set self._name (as other ports do) so that WebKitPort's default
53079         implementations will understand Qt operating system flavors correctly
53080         (including when running wk2 tests).
53081
53082         In trying to test this, I realized that nearly all of our port-tests
53083         use the default FileSystem(), User() and Executive() objects, which
53084         is really bad, because they expose details of your system in the unittest results!
53085
53086         Once I fixed many of the Port() calls to pass MockFileSystem(), then
53087         MacPort.test_tests_for_other_platforms started failing, and I had to
53088         teach MockFileSystem.glob how to handle directories to make it work again.
53089
53090         I removed the useless PortTestCase.test_baseline_search_path and replaced
53091         it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.
53092
53093         * Scripts/webkitpy/common/config/ports.py:
53094         * Scripts/webkitpy/common/system/filesystem_mock.py:
53095         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53096         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
53097         * Scripts/webkitpy/layout_tests/port/mac.py:
53098         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
53099         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
53100         * Scripts/webkitpy/layout_tests/port/qt.py:
53101         * Scripts/webkitpy/layout_tests/port/test_files.py:
53102         * Scripts/webkitpy/layout_tests/port/win.py:
53103         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
53104         * Scripts/webkitpy/tool/mocktool.py:
53105
53106 2011-07-06  Adam Barth  <abarth@webkit.org>
53107
53108         Wean rebaseline-server off unexpected_results.json
53109         https://bugs.webkit.org/show_bug.cgi?id=64063
53110
53111         Reviewed by Eric Seidel.
53112
53113         In the process of changing this code to use full_results.json, I
53114         noticed that the code was broken (because it wasn't tested).  This
53115         patch also adds test coverage for the broken code.
53116
53117         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
53118         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
53119         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
53120
53121 2011-07-06  Adam Barth  <abarth@webkit.org>
53122
53123         Wean resultsjsonparser off unexpected_results.json
53124         https://bugs.webkit.org/show_bug.cgi?id=64061
53125
53126         Reviewed by Eric Seidel.
53127
53128         We're about to delete unexpected_results.json, so we need to remove all
53129         the users.
53130
53131         * Scripts/webkitpy/common/config/ports.py:
53132         * Scripts/webkitpy/common/net/resultsjsonparser.py:
53133         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
53134         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
53135
53136 2011-07-06  Adam Barth  <abarth@webkit.org>
53137
53138         Cleanup result_summary.py
53139         https://bugs.webkit.org/show_bug.cgi?id=64057
53140
53141         Reviewed by Eric Seidel.
53142
53143         This class had a bunch of out-of-date docstrings that no longer make
53144         any sense.
53145
53146         * Scripts/webkitpy/layout_tests/models/result_summary.py:
53147
53148 2011-07-06  Adam Barth  <abarth@webkit.org>
53149
53150         Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
53151         patches can be landed by the commit-queue.
53152
53153         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
53154
53155 2011-07-06  Adam Barth  <abarth@webkit.org>
53156
53157         Normalize callers of logging.getLogger to use __name__
53158         https://bugs.webkit.org/show_bug.cgi?id=64054
53159
53160         Reviewed by Eric Seidel.
53161
53162         Most callers were already using __name__.  This patch makes everyone
53163         consistent.
53164
53165         * Scripts/webkitpy/common/checkout/diff_parser.py:
53166         * Scripts/webkitpy/common/checkout/scm/svn.py:
53167         * Scripts/webkitpy/common/net/statusserver.py:
53168         * Scripts/webkitpy/common/system/executive.py:
53169         * Scripts/webkitpy/common/system/file_lock.py:
53170         * Scripts/webkitpy/common/system/user.py:
53171         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
53172         * Scripts/webkitpy/layout_tests/models/result_summary.py:
53173         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
53174         * Scripts/webkitpy/layout_tests/port/chromium.py:
53175         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53176         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
53177         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
53178         * Scripts/webkitpy/layout_tests/port/gtk.py:
53179         * Scripts/webkitpy/layout_tests/port/http_lock.py:
53180         * Scripts/webkitpy/layout_tests/port/mac.py:
53181         * Scripts/webkitpy/layout_tests/port/qt.py:
53182         * Scripts/webkitpy/layout_tests/port/server_process.py:
53183         * Scripts/webkitpy/layout_tests/port/webkit.py:
53184         * Scripts/webkitpy/layout_tests/port/win.py:
53185         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
53186         * Scripts/webkitpy/layout_tests/servers/http_server.py:
53187         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
53188         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
53189         * Scripts/webkitpy/layout_tests/views/printing.py:
53190         * Scripts/webkitpy/python24/versioning.py:
53191         * Scripts/webkitpy/style/checker.py:
53192         * Scripts/webkitpy/style/checkers/test_expectations.py:
53193         * Scripts/webkitpy/style/patchreader.py:
53194         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
53195
53196 2011-07-06  Adam Barth  <abarth@webkit.org>
53197
53198         Move model classes out of layout_package and into models
53199         https://bugs.webkit.org/show_bug.cgi?id=64053
53200
53201         Reviewed by Eric Seidel.
53202
53203         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
53204         * Scripts/webkitpy/common/net/layouttestresults.py:
53205         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
53206         * Scripts/webkitpy/common/net/resultsjsonparser.py:
53207         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
53208         * Scripts/webkitpy/layout_tests/controllers/manager.py:
53209         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
53210         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
53211         * Scripts/webkitpy/layout_tests/controllers/worker.py:
53212         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
53213         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
53214         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
53215         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
53216         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
53217         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
53218         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
53219         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
53220         * Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
53221         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
53222         * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
53223         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
53224         * Scripts/webkitpy/layout_tests/models: Added.
53225         * Scripts/webkitpy/layout_tests/models/__init__.py: Added.
53226         * Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
53227         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
53228         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
53229         * Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
53230         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
53231         * Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
53232         * Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
53233         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
53234         * Scripts/webkitpy/layout_tests/port/chromium.py:
53235         * Scripts/webkitpy/layout_tests/views/printing.py:
53236         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
53237         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
53238         * Scripts/webkitpy/style_references.py:
53239         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
53240         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
53241         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
53242         * Scripts/webkitpy/tool/commands/queues_unittest.py:
53243         * Scripts/webkitpy/tool/commands/rebaseline.py:
53244
53245 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
53246
53247         nrwt: fix typo preventing http startup on windows
53248         https://bugs.webkit.org/show_bug.cgi?id=64050
53249
53250         Reviewed by Eric Siedel.
53251
53252         NRWT checks whether it needs to start the servers by looking
53253         for "/http/" in the test names. After r90520, the leading slash
53254         is not present, so the check isn't quite right.
53255
53256         * Scripts/webkitpy/layout_tests/controllers/manager.py:
53257         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
53258
53259 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
53260
53261         nrwt: remove --use-apache from the command line
53262         https://bugs.webkit.org/show_bug.cgi?id=63358
53263
53264         Reviewed by Adam Barth.
53265
53266         Re-land the fix in bug 63358 - the prior fix was flawed in that
53267         we were trying to start the http server during check_sys_deps()
53268         but not actually setting up the environment properly. This
53269         broken prior to this change, but exposed by it, since the patch
53270         changes the chromium port to call the base class's checks.
53271
53272         * Scripts/webkitpy/common/system/executive.py:
53273         * Scripts/webkitpy/layout_tests/port/base.py:
53274         * Scripts/webkitpy/layout_tests/port/chromium.py:
53275         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53276         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
53277         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
53278         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
53279         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
53280         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53281
53282 2011-07-06  Adam Barth  <abarth@webkit.org>
53283
53284         Move view-related code out of layout_package and into views
53285         https://bugs.webkit.org/show_bug.cgi?id=64051
53286
53287         Reviewed by Eric Seidel.
53288
53289         * Scripts/webkitpy/layout_tests/controllers/manager.py:
53290         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
53291         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
53292         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
53293         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
53294         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
53295         * Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
53296         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
53297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53298         * Scripts/webkitpy/layout_tests/views: Added.
53299         * Scripts/webkitpy/layout_tests/views/__init__.py: Added.
53300         * Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
53301         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
53302         * Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
53303         * Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
53304
53305 2011-07-06  Adam Barth  <abarth@webkit.org>
53306
53307         Add goofy comments to explain why we have these files.
53308
53309         * Scripts/webkitpy/layout_tests/controllers/__init__.py:
53310         * Scripts/webkitpy/layout_tests/layout_package/__init__.py:
53311
53312 2011-07-06  Adam Barth  <abarth@webkit.org>
53313
53314         Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
53315         https://bugs.webkit.org/show_bug.cgi?id=64048
53316
53317         Reviewed by Eric Seidel.
53318
53319         * Scripts/webkitpy/layout_tests/controllers: Added.
53320         * Scripts/webkitpy/layout_tests/controllers/__init__.py: Added.
53321         * Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
53322         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
53323         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
53324         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
53325         * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
53326         * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
53327         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
53328         * Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
53329         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
53330         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
53331         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
53332         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
53333         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
53334         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
53335         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
53336         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
53337         * Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
53338         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53339
53340 2011-07-06  Adam Barth  <abarth@webkit.org>
53341
53342         Attempt to fix unittest on Leopard.  Let's enumerate the keys in sorted
53343         order so the test results are predictable.
53344
53345         * Scripts/webkitpy/tool/bot/irc_command.py:
53346         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
53347
53348 2011-07-06  Dirk Pranke  <dpranke@chromium.org>
53349
53350         Reviewed by Eric Siedel.
53351
53352         nrwt: make the code be consistent about using test names instead of filenames or paths
53353
53354         https://bugs.webkit.org/show_bug.cgi?id=63597
53355
53356         It can be hard to figure out where in the code we're assuming
53357         test names are listed as unix-style relative filenames and where
53358         they are either absolute paths or relative paths following the
53359         host filesystem convention.
53360
53361         This patch changes things so that everything outside of the
53362         Port object uses (and must assume) unix-style relative
53363         filenames (with one exception, which is specifying host-local
53364         filenames as a list of test arguments on the command line).
53365
53366         This should make things clearer and more consistent, and also
53367         removes a lot of path conversion calls.
53368
53369         The changes in this patch outside of port/base.py are largely
53370         cosmetic changes of "filename" to "test". We add a few routines
53371         to the base Port implementation to manipulate test names to
53372         split them, figure out if we're referring to a directory of
53373         tests, etc.
53374
53375         * Scripts/webkitpy/common/net/layouttestresults.py:
53376         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
53377         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
53378         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
53379         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
53380         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
53381         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
53382         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
53383         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
53384         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
53385         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
53386         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
53387         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
53388         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
53389         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
53390         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
53391         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
53392         * Scripts/webkitpy/layout_tests/port/base.py:
53393         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
53394         * Scripts/webkitpy/layout_tests/port/chromium.py:
53395         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
53396         * Scripts/webkitpy/layout_tests/port/dryrun.py:
53397         * Scripts/webkitpy/layout_tests/port/test.py:
53398         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
53399         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
53400         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
53401         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
53402         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
53403         * Scripts/webkitpy/tool/commands/rebaseline.py:
53404         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
53405
53406 2011-07-06  Chris Guillory  <ctguil@chromium.org>
53407
53408         No review necessary.
53409
53410         Adding myself to committers list in committers.py.
53411         https://bugs.webkit.org/show_bug.cgi?id=63478
53412
53413         * Scripts/webkitpy/common/config/committers.py:
53414
53415 2011-07-06  Johnny Ding  <jnd@chromium.org>
53416
53417         https://bugs.webkit.org/show_bug.cgi?id=63857
53418         Implement createPopupMenu for Chromium DRT.
53419
53420         Reviewed by Tony Chang.
53421
53422         * DumpRenderTree/chromium/WebViewHost.cpp:
53423         (WebViewHost::createPopupMenu):
53424         (WebViewHost::~WebViewHost):
53425         * DumpRenderTree/chromium/WebViewHost.h:
53426
53427 2011-07-06  Mihai Parparita  <mihaip@chromium.org>
53428
53429         Unreviewed, rolling out r90503.
53430         http://trac.webkit.org/changeset/90503
53431         https://bugs.webkit.org/show_bug.cgi?id=63358
53432
53433         Makes Chromium Windows canary bots hang.
53434
53435         * Scripts/webkitpy/layout_tests/port/base.py:
53436         * Scripts/webkitpy/layout_tests/port/chromium.py:
53437         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53438         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
53439         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
53440         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
53441         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
53442         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53443
53444 2011-07-06  Adam Barth  <abarth@webkit.org>
53445
53446         Move buildbot URL in webkitpy to config.urls
53447         https://bugs.webkit.org/show_bug.cgi?id=64041
53448
53449         Reviewed by Eric Seidel.
53450
53451         This patch prepares for using the buildbot class to talk to the
53452         Chromium buildbots.
53453
53454         * Scripts/webkitpy/common/config/urls.py:
53455         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
53456         * Scripts/webkitpy/tool/commands/download_unittest.py:
53457         * Scripts/webkitpy/tool/commands/queries.py:
53458         * Scripts/webkitpy/tool/mocktool.py:
53459         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
53460
53461 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
53462
53463         [wx] Unreviewed build fix, add the correct path to the waf build settings.
53464
53465         * wx/packaging/build-win-installer.py:
53466
53467 2011-07-06  Adam Barth  <abarth@webkit.org>
53468
53469         Add missing include.
53470
53471         * Scripts/webkitpy/tool/bot/irc_command.py:
53472
53473 2011-07-06  Adam Barth  <abarth@webkit.org>
53474
53475         Add roll-chromium-deps command to sheriff-bot
53476         https://bugs.webkit.org/show_bug.cgi?id=64037
53477
53478         Reviewed by Eric Seidel.
53479
53480         Lo, and the DEPS were rolled on command.
53481
53482         * Scripts/webkitpy/tool/bot/irc_command.py:
53483         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
53484         * Scripts/webkitpy/tool/bot/sheriff.py:
53485         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
53486         * Scripts/webkitpy/tool/commands/roll.py:
53487         * Scripts/webkitpy/tool/commands/roll_unittest.py:
53488         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
53489
53490 2011-07-06  Eric Seidel  <eric@webkit.org>
53491
53492         Split Driver, DriverOutput and DriverInput out into a new driver.py file
53493         https://bugs.webkit.org/show_bug.cgi?id=64031
53494
53495         Reviewed by Adam Barth.
53496
53497         This ended up kinda large and I'm happy to break it up if desired.
53498
53499         As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
53500         out into its own driver.py file.
53501
53502         I also cleaned up how we import Port objects, by making port/__init__.py
53503         expose Port, Driver, DriverInput, and DriverOutput.  I removed exposure of
53504         some various test objects as they were causing circular dependencies.
53505         base.py is now an implementation detail of port.  No longer is "base" referenced
53506         anywhere in the code.
53507
53508         I also made Driver.__init__ non-virtual so that sub-classers could all share
53509         the data storage on Driver.  This more closely matches how other subclasses
53510         work throughout our python code.
53511
53512         Standard line-unwrapping and doc-string removal as I went through the code.
53513
53514         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
53515         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
53516         * Scripts/webkitpy/layout_tests/port/__init__.py:
53517         * Scripts/webkitpy/layout_tests/port/base.py:
53518         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
53519         * Scripts/webkitpy/layout_tests/port/chromium.py:
53520         * Scripts/webkitpy/layout_tests/port/driver.py: Added.
53521         * Scripts/webkitpy/layout_tests/port/dryrun.py:
53522         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
53523         * Scripts/webkitpy/layout_tests/port/test.py:
53524         * Scripts/webkitpy/layout_tests/port/webkit.py:
53525         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
53526         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
53527         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
53528
53529 2011-07-06  Adam Roben  <aroben@apple.com>
53530
53531         Clear TestFailures's getNumberOfFailingTests cache
53532
53533         Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
53534         have been cached by old versions of TestFailures.
53535
53536         Fixes <http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
53537         used it recently
53538
53539         Reviewed by Adam Barth.
53540
53541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
53542         (Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
53543         that must match the current version. Otherwise we'll ignore the cached data.
53544
53545 2011-06-24  Dirk Pranke  <dpranke@chromium.org>
53546
53547         Reviewed by Adam Barth.
53548
53549         nrwt: remove --use-apache from the command line
53550         https://bugs.webkit.org/show_bug.cgi?id=63358
53551
53552         This change removes the --use-apache command line argument. It
53553         was initially put in when we were trying to get the cygwin
53554         apache instance to work with Chromium win, but that code has
53555         bitrotted and doesn't work at all now.
53556
53557         Arguably we should remove all of the code to allow for a choice
53558         of web servers, but since we may still want to switch off of
53559         LigHTTPd at some point on Windows, I'll leave the rest in for
53560         now (or at least yank it in a different change.)
53561
53562         * Scripts/webkitpy/layout_tests/port/base.py:
53563         * Scripts/webkitpy/layout_tests/port/chromium.py:
53564         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
53565         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
53566         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
53567         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
53568
53569 2011-07-06  Dimitri Glazkov  <dglazkov@chromium.org>
53570
53571         garden-o-matic should use a favicon to indicate current state.
53572         https://bugs.webkit.org/show_bug.cgi?id=64027
53573
53574         Reviewed by Adam Barth.
53575
53576         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
53577         * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
53578         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
53579         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
53580         * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
53581
53582 2011-07-06  Daniel Bates  <dbates@rim.com>
53583
53584         Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing
53585         parameter to _fetch_file_from_results lamdba function.
53586
53587         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
53588
53589 2011-07-06  Kevin Ollivier  <kevino@theolliviers.com>
53590
53591         [wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.
53592
53593         * wx/packaging/build-mac-installer.py:
53594
53595 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53596
53597         [GTK] Only set env. variables in start when strictly needed
53598         https://bugs.webkit.org/show_bug.cgi?id=64026
53599
53600         Reviewed by Eric Seidel.
53601
53602         * Scripts/webkitpy/layout_tests/port/gtk.py: add a
53603         setup_environ_for_server method in GtkPort and set as many
53604         env. variables as possible there.
53605
53606 2011-07-06  Adam Roben  <aroben@apple.com>
53607
53608         Teach TestFailures how to load, parse, and interpret NRWT test results
53609
53610         Fixes <http://webkit.org/b/61877> TestFailures page doesn't show testers that use
53611         new-run-webkit-tests
53612
53613         Reviewed by Adam Barth.
53614
53615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
53616         (Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
53617         type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
53618         pixel tests at all currently).
53619         (Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
53620         of failing tests from the buildbot output. Make sure not to count "new passes" (a new
53621         category introduced by NRWT) as failures.
53622
53623         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
53624         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
53625         _fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
53626         to loading ORWT results.
53627         (LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
53628         parse the full_results.json file for the given build.
53629         (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
53630         Fixed a bug along the way where we were sometimes calling the error callback instead of the
53631         success callback when all tests passed.
53632
53633         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.
53634         (NRWTResultsParser): Do-nothing constructor.
53635         (NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
53636         JS string, then iterates over all the tests in the results data and builds up a data
53637         structure matching what ORWTResultsParser returns.
53638
53639         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
53640         (Array.prototype.contains):
53641         (String.prototype.contains):
53642         Added these simple helper functions.
53643
53644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
53645         NRWTResultsParser.js.
53646
53647 2011-07-06  Adam Roben  <aroben@apple.com>
53648
53649         Extract code to parse ORWT's results.html file into its own class
53650
53651         Prep work for fixing <http://webkit.org/b/61877> TestFailures page doesn't show testers that
53652         use new-run-webkit-tests
53653
53654         Reviewed by Adam Barth.
53655
53656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
53657         (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...
53658
53659         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.
53660         (ORWTResultsParser):
53661         (ORWTResultsParser.prototype.parse):
53662         ...to here.
53663
53664         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
53665         ORWTResultsParser.js.
53666
53667 2011-07-06  Eric Seidel  <eric@webkit.org>
53668
53669         Unreviewed.  Fix a unittest from hitting the network. :)
53670
53671         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
53672
53673 2011-07-06  Eric Seidel  <eric@webkit.org>
53674
53675         Unreviewed.  Fixing an exception in test-webkitpy, caused by bug 64006.
53676
53677         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
53678
53679 2011-07-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
53680
53681         Run an Xvfb instance to run the API tests on, like we do for the
53682         layout tests.
53683
53684         Reviewed by Xan Lopez.
53685
53686         * Scripts/run-gtk-tests:
53687
53688 2011-07-06  Daniel Bates  <dbates@webkit.org>
53689
53690         Make SCM unit tests faster
53691         https://bugs.webkit.org/show_bug.cgi?id=63883
53692
53693         Speeds up the SCM unit tests by a factor of 4. Currently, we create a
53694         mock SVN repo for each test_ method in SVNTest and GitTest and creating
53695         this repo is expensive.
53696
53697         Instead, it is significantly faster to create the mock SVN repo once
53698         and then perform a filesystem copy of it for each test_ method.
53699
53700         Note, Python 2.7's unittest module implements support for per class and
53701         per module setup and tear down methods which could be used to implement
53702         similar functionality. At the time of writing, test-webkitpy is designed
53703         to support Python 2.5. So, we can't take advantage of these Python 2.7
53704         features :(
53705
53706         Reviewed by Eric Seidel.
53707
53708         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
53709
53710 2011-07-06  Adam Barth  <abarth@webkit.org>
53711
53712         Remove unused parameter from _add_test in test_expectations.py
53713         https://bugs.webkit.org/show_bug.cgi?id=64008
53714
53715         Reviewed by Eric Seidel.
53716
53717         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
53718
53719 2011-07-06  Adam Barth  <abarth@webkit.org>
53720
53721         Use old-run-webkit-tests when --leaks is present
53722         https://bugs.webkit.org/show_bug.cgi?id=64012
53723
53724         Reviewed by Adam Roben.
53725
53726         We'll remove this branch once support of --leaks is added to
53727         new-run-webkit-tests.
53728
53729         * Scripts/run-webkit-tests:
53730
53731 2011-07-06  Benjamin Poulain  <benjamin@webkit.org>
53732
53733         [Qt] [WK2] Add touch mocking to Qt's MiniBrowser
53734         https://bugs.webkit.org/show_bug.cgi?id=63995
53735
53736         Reviewed by Andreas Kling.
53737
53738         The mouse events are intercepted through QCoreApplication::notify(),
53739         and fake touch events are generated for mouse events when necessary.
53740
53741         If touch events are received from the platform, we assume the current
53742         hardware has a touch screen and we stop generating fake events.
53743
53744         * MiniBrowser/qt/MiniBrowserApplication.cpp:
53745         (isTouchEvent):
53746         (isMouseEvent):
53747         (MiniBrowserApplication::MiniBrowserApplication):
53748         (MiniBrowserApplication::notify):
53749         * MiniBrowser/qt/MiniBrowserApplication.h:
53750
53751 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53752
53753         Reviewed by Gustavo Noronha.
53754
53755         * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
53756
53757 2011-07-06  Eric Seidel  <eric@webkit.org>
53758
53759         webkit-patch failure-reason does not understand NRWT results
53760         https://bugs.webkit.org/show_bug.cgi?id=64006
53761
53762         Reviewed by Adam Barth.
53763
53764         Adam Barth tells me failure-reason should be deleted soon,
53765         but aroben's fancy new TestFailures/ page doesn't work for
53766         NRWT yet, and I needed to know when
53767         third-party-cookie-relaxing started failing.
53768
53769         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
53770         * Scripts/webkitpy/tool/commands/queries.py:
53771
53772 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53773
53774         [GTK] Add missing environment variables in NWRT
53775         https://bugs.webkit.org/show_bug.cgi?id=64004
53776
53777         Reviewed by Gustavo Noronha Silva.
53778
53779         Add missing environment variables needed by the GTK+ port.
53780
53781         * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
53782
53783 2011-07-06  Adam Roben  <aroben@apple.com>
53784
53785         Make run-api-tests output intelligible on the bots
53786
53787         run-api-tests's output on the bots was very hard to read for two reasons:
53788           1) It was mixing its own output with gtest's
53789           2) It was using ANSI escape sequences to print colored text, but the bots don't support
53790              that
53791
53792         Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
53793         output will not be obscured. We still print "Timeout" messages even in verbose mode, since
53794         gtest doesn't have any native support for timeouts. Also, when our output is being
53795         redirected to a file, we don't print ANSI escape sequences.
53796
53797         Fixes <http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots
53798
53799         Reviewed by Sam Weinig.
53800
53801         * Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to
53802         use the colored function instead.
53803         (runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
53804         context that they aren't needed.
53805         (runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
53806         that for us. Also, use the new possiblyColored function instead of always coloring output.
53807         (possiblyColored): Added. When printing to a tty, returns the string with the appropriate
53808         ANSI color escape sequences added. Otherwise just returns the string unmodified.
53809
53810 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53811
53812         Reviewed by Gustavo Noronha.
53813
53814         Launch Xvfb (mostly) the same way we were launching it in the
53815         bots, for maximum compatibility.
53816
53817         * Scripts/webkitpy/layout_tests/port/gtk.py:
53818
53819 2011-07-06  Andreas Kling  <kling@webkit.org>
53820
53821         [Qt][WK2] Split Qt API into two different web views (touch and desktop)
53822         https://bugs.webkit.org/show_bug.cgi?id=63950
53823
53824         Co-authored with Benjamin Poulain <benjamin@webkit.org>.
53825
53826         Reviewed by Kenneth Rohde Christiansen.
53827
53828         Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.
53829
53830         The Qt MiniBrowser now defaults to QDesktopWebView but can be started
53831         in QTouchWebView mode by passing -touch on the command line.
53832
53833         A lot of functionality has been removed and/or disabled from
53834         MiniBrowser until we reintroduce the necessary API's.
53835
53836         * MiniBrowser/qt/BrowserView.cpp:
53837         (BrowserView::BrowserView):
53838         (BrowserView::~BrowserView):
53839         (BrowserView::load):
53840         (BrowserView::view):
53841         (BrowserView::touchWebView):
53842         (BrowserView::desktopWebView):
53843         * MiniBrowser/qt/BrowserView.h:
53844         * MiniBrowser/qt/BrowserWindow.cpp:
53845         (newPageFunction):
53846         (BrowserWindow::BrowserWindow):
53847         (BrowserWindow::webView):
53848         (BrowserWindow::newWindow):
53849         (BrowserWindow::showUserAgentDialog):
53850         (BrowserWindow::updateUserAgentList):
53851         * MiniBrowser/qt/BrowserWindow.h:
53852         * MiniBrowser/qt/MiniBrowserApplication.cpp:
53853         (MiniBrowserApplication::handleUserOptions):
53854         * MiniBrowser/qt/MiniBrowserApplication.h:
53855         (WindowOptions::WindowOptions):
53856         * MiniBrowser/qt/UrlLoader.cpp:
53857         (UrlLoader::UrlLoader):
53858         * MiniBrowser/qt/main.cpp:
53859         (main):
53860         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
53861         (WTR::WebView::wkView):
53862         (WTR::WebView::pageRef):
53863         (WTR::WebView::WebView):
53864         (WTR::PlatformWebView::page):
53865         (WTR::PlatformWebView::windowFrame):
53866         (WTR::PlatformWebView::setWindowFrame):
53867
53868 2011-07-06  Eric Seidel  <eric@webkit.org>
53869
53870         Unreviewed..
53871
53872         * Scripts/run-webkit-tests:
53873         (useNewRunWebKitTests):
53874          - Fix the pass-thru of --gtk and --qt for old-run-webkit-tests,
53875            it was previously broken by the existence of isGtk/isQt checks which
53876            removed the --gtk/--qt args from @ARGV.
53877
53878 2011-07-06  Eric Seidel  <eric@webkit.org>
53879
53880         new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
53881         https://bugs.webkit.org/show_bug.cgi?id=63983
53882
53883         Reviewed by Xan Lopez.
53884
53885         All WebKit ports want to use a 35s timeout.  Only chromium currently
53886         uses a 6s timeout.  Eventually we'll move all WebKit ports to 6s too
53887         to further speed up new-run-webkit-tests runs, but that's going to be a while.
53888
53889         * Scripts/webkitpy/layout_tests/port/mac.py:
53890         * Scripts/webkitpy/layout_tests/port/webkit.py:
53891         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
53892
53893 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53894
53895         Unreviewed.
53896
53897         NWRT actually seems to work locally, so it should work in the bots
53898         as long as we take care of the TIMEOUT issue (which is being fixed
53899         as I write this). Let's give this another shot and fix whatever
53900         breaks.
53901
53902         * Scripts/run-webkit-tests:
53903         (useNewRunWebKitTests):
53904
53905 2011-07-06  Xan Lopez  <xlopez@igalia.com>
53906
53907         Unreviewed.
53908
53909         Disable NWRT on GTK. At the very least it needs an updated exected
53910         results file since NWRT is more sensitive to timeouts, not sure
53911         what the exact problem is.
53912
53913         * Scripts/run-webkit-tests:
53914         (useNewRunWebKitTests):
53915
53916 2011-07-06  Adam Barth  <abarth@webkit.org>
53917
53918         Fix global variable leak detected by noglobals.
53919
53920         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
53921
53922 2011-07-06  Adam Barth  <abarth@webkit.org>
53923
53924         garden-o-matic shouldn't show flaky tests by default
53925         https://bugs.webkit.org/show_bug.cgi?id=63979
53926
53927         Reviewed by Ojan Vafai.
53928
53929         If any of the actual test results are PASS, the test is flaky and we
53930         can ignore it (at least for now).  If we get awesome at dealing with
53931         failing tests, we might want to tackle flaky tests by refering the user
53932         to the flakiness dashboard, which is way more awesome at dealing with
53933         flaky tests that this tool ever will be.
53934
53935         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
53936         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
53937
53938 2011-07-05  Adam Barth  <abarth@webkit.org>
53939
53940         garden-o-matic should list the failing tests
53941         https://bugs.webkit.org/show_bug.cgi?id=63978
53942
53943         Reviewed by Eric Seidel.
53944
53945         * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
53946         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
53947         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
53948         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
53949         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
53950         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
53951         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
53952         * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
53953         * Scripts/webkitpy/tool/servers/gardeningserver.py:
53954
53955
53956 2011-07-05  Eric Seidel  <eric@webkit.org>
53957
53958         Re-enable NRWT on Leopard now that bug 63973 is fixed.
53959
53960         Reviewed by Adam Barth.
53961
53962         I also made the should-enable expression a black-list instead
53963         of a white-list since every bot on build.webkit.org is
53964         now using NRWT except windows and WebKit2 bots.
53965
53966         * Scripts/run-webkit-tests:
53967         (useNewRunWebKitTests):
53968
53969 2011-07-05  Eric Seidel  <eric@webkit.org>
53970
53971         Perl string concat failure on Leopard (causes NRWT to fail)
53972         https://bugs.webkit.org/show_bug.cgi?id=63973
53973
53974         Reviewed by Daniel Bates.
53975
53976         Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
53977         thus the version parsing logic in webkitdirs.pm seems to fail.
53978
53979         Default to "3.0" instead of undef when we can't parse the version number.
53980         This should send us down the correct path for Leopard.
53981
53982         * Scripts/webkitdirs.pm:
53983         (determineBaseProductDir):
53984
53985 2011-07-05  Kevin Ollivier  <kevino@theolliviers.com>
53986
53987         [wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.
53988
53989         * waf/build/settings.py:
53990
53991 2011-07-05  Eric Seidel  <eric@webkit.org>
53992
53993         Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.
53994
53995         Reviewed by Adam Barth.
53996
53997         * Scripts/run-webkit-tests:
53998         (useNewRunWebKitTests):
53999
54000 2011-07-05  Eric Seidel  <eric@webkit.org>
54001
54002         Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.
54003
54004         Reviewed by Adam Barth.
54005
54006         * Scripts/run-webkit-tests:
54007         (runningOnBuildBot):
54008
54009 2011-07-05  Adam Barth  <abarth@webkit.org>
54010
54011         Add results_unittests.js to garden-o-matic
54012         https://bugs.webkit.org/show_bug.cgi?id=63971
54013
54014         Reviewed by Eric Seidel.
54015
54016         Adding these unit tests forced me to commit to an API for the results
54017         module.  I'm not sure if this is the API we'll end up with, but it's
54018         something not entirely unreasonable.
54019
54020         Also, I've changed results.js over to WebKit style, as discussed previously.
54021
54022         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
54023         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
54024         * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
54025         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
54026
54027 2011-07-05  Eric Seidel  <eric@webkit.org>
54028
54029         Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
54030
54031         Reviewed by Adam Barth.
54032
54033         * Scripts/run-webkit-tests:
54034
54035 2011-07-05  Adam Barth  <abarth@webkit.org>
54036
54037         Add first unit tests for garden-o-matic
54038         https://bugs.webkit.org/show_bug.cgi?id=63969
54039
54040         Reviewed by Eric Seidel.
54041
54042         I've also reformated base.js to match WebKit style, as discussed in the
54043         previous bug.
54044
54045         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
54046         * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
54047         * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
54048
54049 2011-07-05  Eric Seidel  <eric@webkit.org>
54050
54051         Move Qt, Gtk and Leopard to NRWT.
54052
54053         We'll roll out any of these if we see problems.
54054
54055         Reviewed by Adam Barth.
54056
54057         * Scripts/run-webkit-tests:
54058         (useNewRunWebKitTests):
54059
54060 2011-07-05  Adam Barth  <abarth@webkit.org>
54061
54062         garden-o-matic should understand which tests have unexpected failures
54063         https://bugs.webkit.org/show_bug.cgi?id=63965
54064
54065         Reviewed by Eric Seidel.
54066
54067         Currently, this code just logs the list of unexpected failures to the
54068         console.  A future patch will do something useful with this
54069         information.  A testing harness will also come in the next patch.
54070
54071         * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
54072         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
54073         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
54074         * Scripts/webkitpy/tool/servers/gardeningserver.py:
54075
54076 2011-07-05  Adam Barth  <abarth@webkit.org>
54077
54078         garden-o-matic should know how to fetch test results from the (NRWT) bots
54079         https://bugs.webkit.org/show_bug.cgi?id=63959
54080
54081         Reviewed by Eric Seidel.
54082
54083         Currently, this code just fetches the results and expectations JSON
54084         blob for Linux from the server and logs it to the console.
54085
54086         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
54087         * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
54088         * Scripts/webkitpy/tool/servers/gardeningserver.py:
54089
54090 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
54091
54092         Reviewed by Eric Seidel.
54093
54094         Python tests are failing on leopard
54095         https://bugs.webkit.org/show_bug.cgi?id=63842
54096
54097         Fix the missing flush() call that appears to be needed by the
54098         logging package in python 2.5. Also fix the regressions
54099         introduced in the run_webkit_test tests when we switched from
54100         thread to processes (since processes aren't available on 2.5).
54101
54102         Also fix a missing "from __future__ import with_statement' in
54103         testfilehandler (unreviewed).
54104
54105         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
54106         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
54107         * TestResultServer/handlers/testfilehandler.py:
54108
54109 2011-07-05  Eric Seidel  <eric@webkit.org>
54110
54111         Reviewed by Adam Barth.
54112
54113         re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
54114         now that we believe the stray http-server issue to be solved.
54115
54116         * Scripts/run-webkit-tests:
54117         (useNewRunWebKitTests):
54118
54119 2011-07-05  Adam Barth  <abarth@webkit.org>
54120
54121         Turns out we need to support numerals too because that's what jQuery
54122         uses by default.
54123
54124         * TestResultServer/handlers/testfilehandler.py:
54125
54126 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
54127
54128         nrwt: allow for multiple http shards
54129         https://bugs.webkit.org/show_bug.cgi?id=63116
54130
54131         Reviewed by Tony Chang.
54132
54133         This modifies the sharding logic to support multiple http
54134         shards, but for now we clamp to one shard until we can test
54135         perf impact and flakiness impact.
54136
54137         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54138         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
54139
54140 2011-07-05  Dirk Pranke  <dpranke@chromium.org>
54141
54142         Re-land nrwt: make sharding tests needing locks less hard-coded
54143         https://bugs.webkit.org/show_bug.cgi?id=63112
54144
54145         Reviewed by Ojan Vafai.
54146
54147         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54148         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
54149
54150 2011-07-05  Adam Barth  <abarth@webkit.org>
54151
54152         TestResultServer should support callback parameter for JSON
54153         https://bugs.webkit.org/show_bug.cgi?id=63961
54154
54155         Reviewed by Ojan Vafai.
54156
54157         This makes using jQuery.ajax so much more pleasant.
54158
54159         * TestResultServer/handlers/testfilehandler.py:
54160
54161 2011-07-05  Eric Seidel  <eric@webkit.org>
54162
54163         buildbot needs to understand whether NRWT exited early after having too many failures
54164         https://bugs.webkit.org/show_bug.cgi?id=63839
54165
54166         Reviewed by Adam Barth.
54167
54168         Fix-up the exited early messages printed by NRWT so that
54169         the buildbot can parse them as expected.
54170         It looks for lines using "if line.find('Exiting early') >= 0:"
54171
54172         I also plumbed the "early exit" status through to results.json
54173         in the form of an "interrupted" bool.  It was unclear to me
54174         if results.json already had enough information to compute this bool
54175         itself.  It's possible Ojan could come up with a better fix.
54176
54177         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54178         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
54179         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
54180         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
54181
54182 2011-07-05  Eric Seidel  <eric@webkit.org>
54183
54184         new-run-webkit-tests fails to start http server if one is already running
54185         https://bugs.webkit.org/show_bug.cgi?id=63956
54186
54187         Reviewed by Adam Barth.
54188
54189         * BuildSlaveSupport/kill-old-processes:
54190          - Removed ^M line endings and sorted the process names.
54191          - There are no functional changes to this file.
54192            (except that now that its using unix line endings it can be executed directly!)
54193         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
54194          - Change the name to 'httpd' to match old-run-webkit-test paths.
54195
54196 2011-07-05  Adam Barth  <abarth@webkit.org>
54197
54198         Add basic ajax support to garden-o-matic
54199         https://bugs.webkit.org/show_bug.cgi?id=63874
54200
54201         Reviewed by Eric Seidel.
54202
54203         This patch adds some basic infrastructure to garden-o-matic.
54204         Currently, the infrastructure is just used to make the "quit" command
54205         use Ajax, but in the future, this infrastructure will be used to do
54206         more sophistocated remote proceedure calls.
54207
54208         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
54209         * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
54210         * Scripts/webkitpy/tool/servers/gardeningserver.py:
54211         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
54212
54213 2011-07-05  Adam Barth  <abarth@webkit.org>
54214
54215         Add trivial garden-o-matic command (with server)
54216         https://bugs.webkit.org/show_bug.cgi?id=63872
54217
54218         Reviewed by Eric Seidel.
54219
54220         This patch adds a trivial "Hello, world" garden-o-matic command,
54221         complete with an HTTP server.  This command re-uses a bunch of code
54222         from the existing rebaseline-server command.  Over time, this command
54223         will grow to be a tool useful for gardening the WebKit tree.
54224
54225         * Scripts/webkitpy/tool/commands/__init__.py:
54226         * Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
54227         * Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
54228         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
54229         * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
54230         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
54231         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
54232
54233 2011-07-05  Adam Roben  <aroben@apple.com>
54234
54235         Make prepare-ChangeLog include modified Perl functions in its ChangeLog template
54236
54237         This is a very simple first cut. Functions must start with a line that starts with "sub "
54238         and end with a line that starts with a closing brace. No leading whitespace is allowed.
54239         Package names aren't parsed at all.
54240
54241         Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
54242         Perl files
54243
54244         Reviewed by David Kilzer.
54245
54246         * Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when
54247         searching for function line ranges. This is already done inside the get_function_line_ranges
54248         function.
54249         (get_function_line_ranges): Cleaned up coding style a little bit. Call
54250         get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
54251         unknown extension or no extension, read the shebang line to try to determine the script
54252         interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
54253         (get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
54254         lines starting with "sub " or "}".
54255
54256 2011-07-05  Adam Roben  <aroben@apple.com>
54257
54258         Clean up run-api-tests output on Windows
54259
54260         We were mixing run-api-tests output with gtest output, and the result was a mess.
54261
54262         Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows
54263
54264         Reviewed by Dan Bates.
54265
54266         * Scripts/run-api-tests:
54267         (runTest):
54268         (populateTests):
54269         Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
54270         except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
54271         the only Mac-specific thing in these functions. Some other platform-specific code was moved
54272         from here...
54273
54274         (prepareEnvironmentForRunningTestTool):
54275         (testToolPath):
54276         ...to here.
54277
54278 2011-07-04  Gavin Barraclough  <barraclough@apple.com>
54279
54280         Reviewed by Sam Weinig.
54281
54282         https://bugs.webkit.org/show_bug.cgi?id=16652
54283         Firefox and JavaScriptCore differ in Number.toString(integer)
54284
54285         Added forwarding header.
54286
54287         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
54288
54289 2011-07-04  Anders Carlsson  <andersca@apple.com>
54290
54291         Try to fix Qt build.
54292
54293         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
54294
54295 2011-07-04  Anders Carlsson  <andersca@apple.com>
54296
54297         NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
54298         https://bugs.webkit.org/show_bug.cgi?id=63915
54299         <rdar://problem/7124300>
54300
54301         Reviewed by Sam Weinig.
54302
54303         Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.
54304
54305         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
54306         (PluginTest::NPN_IdentifierIsString):
54307         (PluginTest::NPN_UTF8FromIdentifier):
54308         (PluginTest::NPN_IntFromIdentifier):
54309         (PluginTest::NPN_RetainObject):
54310         (PluginTest::NPN_ReleaseObject):
54311         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
54312         (PluginTest::Object::removeProperty):
54313         (PluginTest::Object::identifierIs):
54314         (PluginTest::Object::NP_RemoveProperty):
54315         (PluginTest::Object::npClass):
54316         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
54317         (NPRuntimeRemoveProperty::TestObject::TestObject):
54318         (NPRuntimeRemoveProperty::TestObject::hasProperty):
54319         (NPRuntimeRemoveProperty::TestObject::getProperty):
54320         (NPRuntimeRemoveProperty::TestObject::removeProperty):
54321         (NPRuntimeRemoveProperty::PluginObject::PluginObject):
54322         (NPRuntimeRemoveProperty::PluginObject::~PluginObject):
54323         (NPRuntimeRemoveProperty::PluginObject::hasMethod):
54324         (NPRuntimeRemoveProperty::PluginObject::invoke):
54325         (NPRuntimeRemoveProperty::PluginObject::hasProperty):
54326         (NPRuntimeRemoveProperty::PluginObject::getProperty):
54327         (NPRuntimeRemoveProperty::NPP_GetValue):
54328
54329 2011-07-04  Leandro Pereira  <leandro@profusion.mobi>
54330
54331         Reviewed by Kent Tamura.
54332
54333         [EFL] Add LayoutTestControllerEfl.
54334         https://bugs.webkit.org/show_bug.cgi?id=61974
54335
54336         Only the core features are implemented. Most functions are actually
54337         stubs and will be implemented as soon as its features are needed.
54338         Build system changes will be made as soon as DRT is completely
54339         upstreamed.
54340
54341         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added.
54342         (LayoutTestController::~LayoutTestController):
54343         (LayoutTestController::addDisallowedURL):
54344         (LayoutTestController::clearBackForwardList):
54345         (LayoutTestController::copyDecodedHostName):
54346         (LayoutTestController::copyEncodedHostName):
54347         (LayoutTestController::dispatchPendingLoadRequests):
54348         (LayoutTestController::display):
54349         (LayoutTestController::counterValueForElementById):
54350         (LayoutTestController::keepWebHistory):
54351         (LayoutTestController::computedStyleIncludingVisitedInfo):
54352         (LayoutTestController::nodesFromRect):
54353         (LayoutTestController::layerTreeAsText):
54354         (LayoutTestController::pageNumberForElementById):
54355         (LayoutTestController::numberOfPages):
54356         (LayoutTestController::pageProperty):
54357         (LayoutTestController::isPageBoxVisible):
54358         (LayoutTestController::pageSizeAndMarginsInPixels):
54359         (LayoutTestController::webHistoryItemCount):
54360         (LayoutTestController::workerThreadCount):
54361         (LayoutTestController::notifyDone):
54362         (LayoutTestController::pathToLocalResource):
54363         (LayoutTestController::queueLoad):
54364         (LayoutTestController::setAcceptsEditing):
54365         (LayoutTestController::setAlwaysAcceptCookies):
54366         (LayoutTestController::setCustomPolicyDelegate):
54367         (LayoutTestController::waitForPolicyDelegate):
54368         (LayoutTestController::setScrollbarPolicy):
54369         (LayoutTestController::addOriginAccessWhitelistEntry):
54370         (LayoutTestController::removeOriginAccessWhitelistEntry):
54371         (LayoutTestController::setMainFrameIsFirstResponder):
54372         (LayoutTestController::setTabKeyCyclesThroughElements):
54373         (LayoutTestController::setUseDashboardCompatibilityMode):
54374         (LayoutTestController::setUserStyleSheetEnabled):
54375         (LayoutTestController::setUserStyleSheetLocation):
54376         (LayoutTestController::setValueForUser):
54377         (LayoutTestController::setViewModeMediaFeature):
54378         (LayoutTestController::setWindowIsKey):
54379         (LayoutTestController::setSmartInsertDeleteEnabled):
54380         (waitToDumpWatchdogFired):
54381         (LayoutTestController::setWaitToDump):
54382         (LayoutTestController::windowCount):
54383         (LayoutTestController::setPrivateBrowsingEnabled):
54384         (LayoutTestController::setJavaScriptCanAccessClipboard):
54385         (LayoutTestController::setXSSAuditorEnabled):
54386         (LayoutTestController::setFrameFlatteningEnabled):
54387         (LayoutTestController::setSpatialNavigationEnabled):
54388         (LayoutTestController::setAllowUniversalAccessFromFileURLs):
54389         (LayoutTestController::setAllowFileAccessFromFileURLs):
54390         (LayoutTestController::setAuthorAndUserStylesEnabled):
54391         (LayoutTestController::setAutofilled):
54392         (LayoutTestController::disableImageLoading):
54393         (LayoutTestController::setMockDeviceOrientation):
54394         (LayoutTestController::setMockGeolocationPosition):
54395         (LayoutTestController::setMockGeolocationError):
54396         (LayoutTestController::setGeolocationPermission):
54397         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
54398         (LayoutTestController::addMockSpeechInputResult):
54399         (LayoutTestController::setIconDatabaseEnabled):
54400         (LayoutTestController::setJavaScriptProfilingEnabled):
54401         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
54402         (LayoutTestController::setPopupBlockingEnabled):
54403         (LayoutTestController::setPluginsEnabled):
54404         (LayoutTestController::elementDoesAutoCompleteForElementWithId):
54405         (LayoutTestController::execCommand):
54406         (LayoutTestController::findString):
54407         (LayoutTestController::isCommandEnabled):
54408         (LayoutTestController::setCacheModel):
54409         (LayoutTestController::setPersistentUserStyleSheetLocation):
54410         (LayoutTestController::clearPersistentUserStyleSheet):
54411         (LayoutTestController::clearAllApplicationCaches):
54412         (LayoutTestController::setApplicationCacheOriginQuota):
54413         (LayoutTestController::clearApplicationCacheForOrigin):
54414         (LayoutTestController::localStorageDiskUsageForOrigin):
54415         (LayoutTestController::originsWithApplicationCache):
54416         (LayoutTestController::applicationCacheDiskUsageForOrigin):
54417         (LayoutTestController::clearAllDatabases):
54418         (LayoutTestController::setDatabaseQuota):
54419         (LayoutTestController::originsWithLocalStorage):
54420         (LayoutTestController::deleteAllLocalStorage):
54421         (LayoutTestController::deleteLocalStorageForOrigin):
54422         (LayoutTestController::observeStorageTrackerNotifications):
54423         (LayoutTestController::syncLocalStorage):
54424         (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
54425         (LayoutTestController::goBack):
54426         (LayoutTestController::setDefersLoading):
54427         (LayoutTestController::setAppCacheMaximumSize):
54428         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
54429         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
54430         (LayoutTestController::sampleSVGAnimationForElementAtTime):
54431         (LayoutTestController::numberOfActiveAnimations):
54432         (LayoutTestController::suspendAnimations):
54433         (LayoutTestController::resumeAnimations):
54434         (LayoutTestController::overridePreference):
54435         (LayoutTestController::addUserScript):
54436         (LayoutTestController::addUserStyleSheet):
54437         (LayoutTestController::setDeveloperExtrasEnabled):
54438         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
54439         (LayoutTestController::showWebInspector):
54440         (LayoutTestController::closeWebInspector):
54441         (LayoutTestController::evaluateInWebInspector):
54442         (LayoutTestController::evaluateScriptInIsolatedWorld):
54443         (LayoutTestController::removeAllVisitedLinks):
54444         (LayoutTestController::callShouldCloseOnWebView):
54445         (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
54446         (LayoutTestController::apiTestGoToCurrentBackForwardItem):
54447         (LayoutTestController::setWebViewEditable):
54448         (LayoutTestController::markerTextForListItem):
54449         (LayoutTestController::authenticateSession):
54450         (LayoutTestController::setEditingBehavior):
54451         (LayoutTestController::abortModal):
54452         (LayoutTestController::hasSpellingMarker):
54453         (LayoutTestController::hasGrammarMarker):
54454         (LayoutTestController::dumpConfigurationForViewport):
54455         (LayoutTestController::setSerializeHTTPLoads):
54456         (LayoutTestController::setMinimumTimerInterval):
54457         (LayoutTestController::setTextDirection):
54458         (LayoutTestController::allowRoundingHacks):
54459
54460 2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>
54461
54462         Unreviewed, add myself as committer.
54463
54464         * Scripts/webkitpy/common/config/committers.py:
54465
54466 2011-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
54467
54468         Unreviewed, rolling out r90347.
54469         http://trac.webkit.org/changeset/90347
54470         https://bugs.webkit.org/show_bug.cgi?id=63886
54471
54472         Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
54473         (Requested by tkent on #webkit).
54474
54475         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
54476
54477 2011-07-03  Daniel Bates  <dbates@webkit.org>
54478
54479         Import Checkout in scm_unittests.py and logging in svn.py to fix
54480         Python missing global variable errors
54481
54482         Rubber-stamped by Adam Barth.
54483
54484         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
54485         * Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
54486
54487 2011-07-02  Gavin Barraclough  <barraclough@apple.com>
54488
54489         Reviewed by Sam Weinig.
54490
54491         https://bugs.webkit.org/show_bug.cgi?id=16652
54492         Firefox and JavaScriptCore differ in Number.toString(integer)
54493
54494         Added forwarding header.
54495
54496         * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
54497
54498 2011-04-02  Robert Hogan  <robert@webkit.org>
54499
54500         Reviewed by Benjamin Poulain.
54501
54502         [Qt] Support third-party cookie policy for Qt clients
54503         https://bugs.webkit.org/show_bug.cgi?id=45455
54504
54505         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
54506         (LayoutTestController::reset):
54507         (LayoutTestController::setAlwaysAcceptCookies):
54508         (LayoutTestController::setAlwaysBlockCookies):
54509         * DumpRenderTree/qt/LayoutTestControllerQt.h:
54510
54511 2011-07-03  Adam Barth  <abarth@webkit.org>
54512
54513         Factor ReflectionHandler out of the rebaseline server.  Just code motion.
54514
54515         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
54516         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
54517         * Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
54518
54519 2011-07-03  Adam Barth  <abarth@webkit.org>
54520
54521         Move the rebaseline server out of the commands package and into the
54522         (new) servers package.  This patch prepares for refactoring this code
54523         to share server infrastructure with the (forthcoming) garden-o-matic
54524         command.
54525
54526         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
54527         * Scripts/webkitpy/tool/servers/__init__.py: Added.
54528         * Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
54529         * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
54530         * Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
54531         * Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.
54532
54533 2011-07-01  Adam Barth  <abarth@webkit.org>
54534
54535         Fix typo in master.cfg, hoping to trigger a master restart.
54536
54537         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
54538
54539 2011-07-01  Adam Barth  <abarth@webkit.org>
54540
54541         Turn off new-run-webkit-tests and remove some debug logging.
54542
54543         * Scripts/run-webkit-tests:
54544         * Scripts/webkitpy/layout_tests/port/http_lock.py:
54545
54546 2011-07-01  Adam Barth  <abarth@webkit.org>
54547
54548         Add some more debug logging to try to understand why we're getting
54549         stuck acquring the HTTP lock.
54550
54551         * Scripts/webkitpy/layout_tests/port/http_lock.py:
54552
54553 2011-07-01  Adam Barth  <abarth@webkit.org>
54554
54555         Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
54556         https://bugs.webkit.org/show_bug.cgi?id=63854
54557
54558         Reviewed by Dirk Pranke.
54559
54560         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
54561
54562 2011-07-01  Eric Seidel  <eric@webkit.org>
54563
54564         new-run-webkit-tests results does not understand that mac uses test_expectations files
54565         https://bugs.webkit.org/show_bug.cgi?id=63838
54566
54567         Reviewed by Adam Barth.
54568
54569         We've decided to "enable" test_expectations for the Mac port for now.
54570         It makes the results.html results much more confusing to read, but at least they're
54571         no longer lying to us.
54572
54573         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54574         * Scripts/webkitpy/layout_tests/port/base.py:
54575         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
54576
54577 2011-07-01  Adam Barth  <abarth@webkit.org>
54578
54579         Temporarily disable waiting for ReportCrash to see how this code
54580         affects performance on the bots.
54581
54582         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54583         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
54584
54585 2011-07-01  Dmitry Lomov  <dslomov@google.com>
54586
54587         Reviewed by Adam Roben.
54588
54589         https://bugs.webkit.org/show_bug.cgi?id=63818
54590         Test bots shouldn't attempt to build TestWebKitAPI on Windows.
54591         TestWebKitAPI builds as a part of general webkit build and is a
54592         part of build products archive.
54593
54594         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
54595         * Scripts/run-api-tests:
54596
54597 2011-07-01  Adam Barth  <abarth@webkit.org>
54598
54599         We shouldn't wait for ReportCrash while the timeout is running
54600         https://bugs.webkit.org/show_bug.cgi?id=63837
54601
54602         Reviewed by Eric Seidel.
54603
54604         Instead, we should move this check to worker.py.
54605
54606         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
54607         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
54608
54609 2011-07-01  Adam Roben  <aroben@apple.com>
54610
54611         Stop setting unsafe headers on POSTs via XHR from TestFailures page
54612
54613         Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
54614         Inspector's console about unsafe headers
54615
54616         Reviewed by Dan Bates.
54617
54618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
54619         (fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
54620
54621 2011-07-01  Eric Seidel  <eric@webkit.org>
54622
54623         Reviewed by Adam Barth.
54624
54625         Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
54626         https://bugs.webkit.org/show_bug.cgi?id=63786
54627
54628         We're down to one bug blocking the "move to NRWT" bug:
54629         https://bugs.webkit.org/show_bug.cgi?id=34984
54630         so we're trying transitioning Snow Leopard to NRWT as an experiment.
54631
54632         If we run into any blocking issues we'll of course roll this back out
54633         (or anyone reading this should feel encouraged to).
54634
54635         * Scripts/run-webkit-tests:
54636
54637 2011-07-01  Adam Barth  <abarth@webkit.org>
54638
54639         Add a compat shim for --leaks.  Support for --leaks will be added in
54640         https://bugs.webkit.org/show_bug.cgi?id=63832.
54641
54642         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
54643
54644 2011-07-01  Adam Barth  <abarth@webkit.org>
54645
54646         Reviewed by Darin Adler.
54647
54648         ReportCrash destabilizes new-run-webkit-tests
54649         https://bugs.webkit.org/show_bug.cgi?id=63795
54650
54651         ReportCrash chews up too many system resources that it destablizes
54652         tests run concurrently.  This patch causes us to spin down all the
54653         worker processes when ReportCrash is running.
54654
54655         Also, this patch causes the master process to tell the user we're
54656         waiting for the crash reporter rather than having that be the worker's
54657         job.  This stops the user from getting spammed with too many "waiting
54658         for crash reporter" messages and also cleans up some minor UI issues
54659         with the meter.
54660
54661         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54662         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
54663         * Scripts/webkitpy/layout_tests/port/base.py:
54664         * Scripts/webkitpy/layout_tests/port/server_process.py:
54665
54666 2011-07-01  Adam Roben  <aroben@apple.com>
54667
54668         Teach webkitpy about the new format of our ChangeLog template
54669
54670         r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
54671         template. But webkitpy didn't know this, so the various rollout-related commands were
54672         leaving that line in the ChangeLog.
54673
54674         Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
54675         rollout are broken
54676
54677         Reviewed by Dan Bates.
54678
54679         * Scripts/webkitpy/common/checkout/changelog.py:
54680         (ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
54681         description and bug URL" line instead of the "Reviewed by" line as the first line of the
54682         ChangeLog template.
54683
54684         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
54685         (ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
54686         generates.
54687
54688 2011-07-01  Adam Roben  <aroben@apple.com>
54689
54690         Make TestFailures stop loading old builds once we've explained all current failures
54691
54692         We used to do this, but some refactoring in r90165 broke this logic.
54693
54694         Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
54695         builds back to the beginning of time
54696
54697         Reviewed by Dan Bates.
54698
54699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
54700         (LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
54701         all current failures have been explained.
54702
54703 2011-07-01  Adam Roben  <aroben@apple.com>
54704
54705         commit-log-editor reorders ChangeLog entries in unexpected ways
54706         https://bugs.webkit.org/show_bug.cgi?id=63804
54707
54708         Reviewed by Darin Adler.
54709
54710         commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
54711         commit message in order to make git-based tools, which expect the first line of the commit
54712         message to be a summary of the change, to work better. But this reordering of the ChangeLog
54713         entry was unpredictable and unexpected.
54714
54715         I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
54716         so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
54717         try to move them.
54718
54719         * Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
54720         line and try to move it down below the bug title and URL. The order of the text in the
54721         ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
54722         by" line in cases where the committer and author are not the same person.
54723
54724         * Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
54725
54726 2011-07-01  Mihnea Ovidenie  <mihnea@adobe.com>
54727
54728         Reviewed by Adam Roben.
54729
54730         [CSSRegions] Add build slave
54731         https://bugs.webkit.org/show_bug.cgi?id=62372
54732
54733         * BuildSlaveSupport/build.webkit.org-config/config.json:
54734         Add an entry for a release build of Mac.
54735
54736 2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>
54737
54738         Unreviewed, rolling out r90213.
54739         http://trac.webkit.org/changeset/90213
54740         https://bugs.webkit.org/show_bug.cgi?id=63792
54741
54742         The SL bot has an errant HTTP server holding port 8080
54743         (Requested by abarth on #webkit).
54744
54745         * Scripts/run-webkit-tests:
54746
54747 2011-07-01  Carlos Garcia Campos  <cgarcia@igalia.com>
54748
54749         Unreviewed. Fix WebKit2 GTK build after r90163.
54750
54751         * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
54752         (didCreatePage):
54753
54754 2011-07-01  Adam Barth  <abarth@webkit.org>
54755
54756         Exit faster when we get a keyboard interrupt.  Previously, we'd open
54757         Safari if you ^C NRWT after it found a failure.
54758
54759         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54760
54761 2011-07-01  Eric Seidel  <eric@webkit.org>
54762
54763         Reviewed by Adam Barth.
54764
54765         Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
54766         https://bugs.webkit.org/show_bug.cgi?id=63786
54767
54768         We're down to one bug blocking the "move to NRWT" bug:
54769         https://bugs.webkit.org/show_bug.cgi?id=34984
54770         so we're trying transitioning Snow Leopard to NRWT as an experiment.
54771
54772         If we run into any blocking issues we'll of course roll this back out
54773         (or anyone reading this should feel encouraged to).
54774
54775         * Scripts/run-webkit-tests:
54776
54777 2011-07-01  Sheriff Bot  <webkit.review.bot@gmail.com>
54778
54779         Unreviewed, rolling out r90192.
54780         http://trac.webkit.org/changeset/90192
54781         https://bugs.webkit.org/show_bug.cgi?id=63788
54782
54783         Appears to have caused NRWT on Chromium WebKit Vista to hang
54784         (Requested by abarth on #webkit).
54785
54786         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54787         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
54788
54789 2011-06-30  Adam Barth  <abarth@webkit.org>
54790
54791         Reviewed by Eric Seidel.
54792
54793         Remove the concept of "being wedged" from new-run-webkit-tests
54794         https://bugs.webkit.org/show_bug.cgi?id=63767
54795
54796         Worker processes shouldn't ever become wedged.  My understanding is
54797         that this code was originally motivated by the old threading-based
54798         design but no longer servers any purpose.
54799
54800         Note: If we actually have a problem with the test harness getting
54801         stuck, buildbot will kill us.
54802
54803         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54804         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
54805         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
54806
54807 2011-06-30  Adam Barth  <abarth@webkit.org>
54808
54809         The win32 implementation of fork is sad about forking test-webkitpy.
54810         Hopefully this will heal the bot.
54811
54812         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
54813
54814 2011-06-30  Eric Seidel  <eric@webkit.org>
54815
54816         Reviewed by Adam Barth.
54817
54818         Update new-run-webkit-tests now that the wk2 shared skipped list has moved
54819         https://bugs.webkit.org/show_bug.cgi?id=63780
54820
54821         The shared list was moved from mac-wk2 to wk2 as part of
54822         http://trac.webkit.org/changeset/90125.
54823
54824         * Scripts/webkitpy/layout_tests/port/webkit.py:
54825         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
54826
54827 2011-06-30  Kenichi Ishibashi  <bashi@chromium.org>
54828
54829         Reviewed by Darin Adler.
54830
54831         Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
54832         https://bugs.webkit.org/show_bug.cgi?id=62022
54833
54834         Adds XcodeProjectFileChecker to check removal of "developmentRegion".
54835
54836         * Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
54837         * Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
54838         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.
54839
54840 2011-06-30  Dirk Pranke  <dpranke@chromium.org>
54841
54842         Reviewed by Ojan Vafai.
54843
54844         nrwt: make sharding tests needing locks less hard-coded
54845         https://bugs.webkit.org/show_bug.cgi?id=63112
54846
54847         This change also changes the manager logic so that it will
54848         drop the server lock as soon as all of the shards requiring
54849         the lock have completed.
54850
54851         This change includes some minor namespace/import changes in the
54852         unit tests, and also makes the Manager a new-style object, which
54853         it should've been all along.
54854
54855         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54856         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
54857
54858 2011-06-30  Adam Barth  <abarth@webkit.org>
54859
54860         Reviewed by Eric Seidel.
54861
54862         Remove threaded mode from new-run-webkit-tests
54863         https://bugs.webkit.org/show_bug.cgi?id=63771
54864
54865         This mode is not used and is buggy.  Rather than carry around a bunch
54866         of unused buggy code, we should rip it out and focus on the
54867         multiprocess implementation.
54868
54869         * Scripts/webkitpy/common/system/executive.py:
54870         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
54871         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
54872         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
54873         * Scripts/webkitpy/layout_tests/port/base.py:
54874         * Scripts/webkitpy/layout_tests/port/chromium.py:
54875         * Scripts/webkitpy/layout_tests/port/mac.py:
54876         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
54877         * Scripts/webkitpy/layout_tests/port/server_process.py:
54878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
54879         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
54880
54881 2011-06-30  Adam Barth  <abarth@webkit.org>
54882
54883         Reviewed by Darin Adler.
54884
54885         Clean up output from new-run-webkit-tests
54886         https://bugs.webkit.org/show_bug.cgi?id=63759
54887
54888         Printing messages from the child process looks super ugly because of
54889         the way the pretty-printer works.  Printing a blank line first is a
54890         hack, but it makes things at least partially sane.
54891
54892         Also, handle the case where calling sample throws an exception.
54893
54894         * Scripts/webkitpy/layout_tests/port/server_process.py:
54895         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
54896
54897 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
54898
54899         Reviewed by Antonio Gomes.
54900
54901         [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
54902         https://bugs.webkit.org/show_bug.cgi?id=63489
54903
54904         Unskipped:
54905             loader/navigation-while-deferring-loads.html
54906
54907         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
54908         (LayoutTestController::goBack):
54909         (LayoutTestController::setDefersLoading):
54910         * DumpRenderTree/qt/LayoutTestControllerQt.h:
54911
54912 2011-06-30  Adam Barth  <abarth@webkit.org>
54913
54914         Reviewed by Dirk Pranke.
54915
54916         new-run-webkit-tests should stop when I ^C it
54917         https://bugs.webkit.org/show_bug.cgi?id=63763
54918
54919         It still doesn't stop fast enough, but at least with this patch it
54920         doesn't run more tests.
54921
54922         Also, I tweaked the UI that happens when there's a keyboard interrupt
54923         to not be amazingly ugly.  There's still a garbage "Te" left on the
54924         console, but that's a problem for another day.
54925
54926         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
54927
54928 2011-06-30  Adam Roben  <aroben@apple.com>
54929
54930         Make TestFailures never treat a too-many-failures build as a last-passing build for a test
54931
54932         Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
54933         the last passing build for a test, when in fact the test wasn't run due to too many failures
54934         causing old-run-webkit-tests to exit early
54935
54936         Reviewed by Anders Carlsson.
54937
54938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
54939         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
54940         failures in this build, assume that all the tests failed in the last build would have failed
54941         in this build, too, had they been run. Introduced some new local variables to reduce typing,
54942         and used them throughout.
54943
54944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
54945         (LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
54946         correctly remember whether old-run-webkit-tests exited early due to too many failures for
54947         builds older than r89610. Also removed an unused parameter while I was at it.
54948
54949 2011-06-30  Adam Roben  <aroben@apple.com>
54950
54951         Make TestFaiulres only load old-results directories as needed
54952
54953         Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly
54954
54955         Reviewed by Anders Carlsson.
54956
54957         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
54958         (Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
54959         calls through to _getBuildNamesFromResultsDirectory.
54960         (Builder.prototype.getOldBuildNames): Added. Just calls through to
54961         _getBuildNamesFromResultsDirectory.
54962         (Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
54963         takes the directory URL as an argument and only fetches that single URL.
54964
54965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
54966         (LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
54967         analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
54968         (LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
54969         changes are just indentation.) Now takes a callback to call when we've finished analyzing
54970         all builds in buildNames so that we can try to fetch more build names if needed.
54971
54972 2011-06-30  Mark Rowe  <mrowe@apple.com>
54973
54974         Reviewed by Anders Carlsson.
54975
54976         Update MiniBrowser and WebKitTestRunner to use the client version constants.
54977
54978         * MiniBrowser/gtk/BrowserWindow.c:
54979         (browserWindowLoaderClientInit):
54980         (browserWindowUIClientInit):
54981         * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
54982         (didCreatePage):
54983         (WKBundleInitialize):
54984         * MiniBrowser/gtk/main.c:
54985         (createWKContextWithInjectedBundle):
54986         * MiniBrowser/mac/AppDelegate.m:
54987         (-[BrowserAppDelegate init]):
54988         * MiniBrowser/mac/BrowserWindowController.m:
54989         (-[BrowserWindowController awakeFromNib]):
54990         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
54991         (WKBundleInitialize):
54992         * MiniBrowser/win/BrowserView.cpp:
54993         (BrowserView::create):
54994         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
54995         (WTR::InjectedBundle::initialize):
54996         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
54997         (WTR::InjectedBundlePage::InjectedBundlePage):
54998         * WebKitTestRunner/TestController.cpp:
54999         (WTR::TestController::createOtherPage):
55000         (WTR::TestController::initialize):
55001
55002 2011-06-30  Adam Roben  <aroben@apple.com>
55003
55004         Identify revisions that modified failing tests on TestFailures page
55005
55006         Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
55007         a failure by looking at commit logs
55008
55009         Reviewed by David Kilzer.
55010
55011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
55012         (.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
55013         revisions list, too.
55014
55015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
55016         (Trac): Initialize our memory cache.
55017         (Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
55018         then parses out the revision number, Trac's idea of the commit title, and the files modified
55019         by the commit. (To get the modified files, we rely on the commit message including a
55020         prepare-ChangeLog-style file list.)
55021         (Trac.prototype.logURL): Added a new formatAsRSS parameter.
55022
55023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
55024         (removePathExtension): Added. Returns a new string with the last dot and everything after it
55025         removed.
55026         (sorted): Added sortFunction parameter.
55027         (Node.prototype.removeAllChildren): Added. Does what it says.
55028
55029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55030         (ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
55031         (ViewController.prototype._domForRegressionRange): Changed argument order to match
55032         _domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
55033         which revisions modified the failing tests and displays the suspect revisions in a list.
55034
55035 2011-06-30  Eric Seidel  <eric@webkit.org>
55036
55037         Reviewed by Adam Barth.
55038
55039         Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
55040         https://bugs.webkit.org/show_bug.cgi?id=63743
55041
55042         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
55043         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
55044
55045 2011-06-30  Martin Robinson  <mrobinson@igalia.com>
55046
55047         Reviewed by Anders Carlsson.
55048
55049         [GTK] Crash observed with nspluginwrapper and flash
55050         https://bugs.webkit.org/show_bug.cgi?id=62249
55051
55052         Added a TestNetscapePlugin test which verifies that WebKit properly
55053         handles situations where InvalidateRect is called with a null instance.
55054
55055         * DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added.
55056         (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument):
55057         (CallInvalidateRectWithNullNPPArgument::NPP_New):
55058         * GNUmakefile.am: Add the new file to sources list.
55059
55060 2011-06-30  Eric Seidel  <eric@webkit.org>
55061
55062         Reviewed by Adam Barth.
55063
55064         Remove redundant tests in TestFailuresTest
55065         https://bugs.webkit.org/show_bug.cgi?id=63742
55066
55067         These tests are all already covered by TestFailuresTest.test_loads.
55068         I also added the missing "T" from TestFailuresest. :)
55069
55070         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
55071
55072 2011-06-30  Adam Barth  <abarth@webkit.org>
55073
55074         Reviewed by Eric Seidel.
55075
55076         REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist
55077         https://bugs.webkit.org/show_bug.cgi?id=63494
55078
55079         This patch does two things:
55080
55081         1) Refactor diff_image to return the image diff instead of writing the
55082         diff to a file.  This fixes a bunch of hacks and disentangles a bunch
55083         of code.
55084
55085         2) When there's a checksum mismatch but not image diff, we no longer
55086         report an IMAGE failure to results.html.  That fixes the bug in
55087         question because results.html won't try to link to a non-existent image
55088         diff.
55089
55090         * Scripts/webkitpy/common/system/executive_mock.py:
55091         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
55092         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55093         * Scripts/webkitpy/layout_tests/port/base.py:
55094         * Scripts/webkitpy/layout_tests/port/chromium.py:
55095         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
55096         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
55097         * Scripts/webkitpy/layout_tests/port/test.py:
55098         * Scripts/webkitpy/layout_tests/port/webkit.py:
55099         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
55100         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
55101
55102 2011-06-28  Hans Wennborg  <hans@chromium.org>
55103
55104         Reviewed by Tony Chang.
55105
55106         IndexedDB: Prepare for running layout tests with LevelDB
55107         https://bugs.webkit.org/show_bug.cgi?id=63593
55108
55109         The TestShell must always provide a temporary folder for LevelDB,
55110         not just when the backing store type is overridden.
55111
55112         * DumpRenderTree/chromium/LayoutTestController.cpp:
55113         (LayoutTestController::setOverrideIndexedDBBackingStore):
55114         (LayoutTestController::clearAllDatabases):
55115         * DumpRenderTree/chromium/LayoutTestController.h:
55116         * DumpRenderTree/chromium/TestShell.cpp:
55117         (TestShell::TestShell):
55118         * DumpRenderTree/chromium/TestShell.h:
55119
55120 2011-06-30  Zsolt Fehér  <h490267@stud.u-szeged.hu>
55121
55122         Reviewed by Csaba Osztrogonác.
55123
55124         [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
55125         qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
55126         https://bugs.webkit.org/show_bug.cgi?id=61785
55127
55128         * Scripts/old-run-webkit-tests:
55129
55130 2011-06-30  Adam Roben  <aroben@apple.com>
55131
55132         Use a colon to separate test names from failure info on TestFailures
55133
55134         This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
55135         failure info itself includes parentheses.
55136
55137         Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
55138         double parentheses
55139
55140         Reviewed by Darin Adler.
55141
55142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55143         (ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
55144         info in parentheses.
55145
55146 2011-06-30  Adam Roben  <aroben@apple.com>
55147
55148         Robustify PersistentCache against cached data that contains the string ': '
55149
55150         Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
55151         passing a bad string to JSON.parse
55152
55153         Reviewed by Darin Adler.
55154
55155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:
55156         (PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
55157         using indexOf and substring. (String.prototype.split always splits on all instances of the
55158         separator.)
55159
55160 2011-06-30  Adam Roben  <aroben@apple.com>
55161
55162         Include the crashing symbol in crash logs links on TestFailures
55163
55164         Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
55165         the crashing symbol (like links in results.html do)
55166
55167         Reviewed by David Kilzer.
55168
55169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
55170         (LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
55171         crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
55172         it now returns more than just the test names. Specifically, it now looks for crash log links
55173         and extracts the crashing symbol name from them. Updated callers of parseResultTable to
55174         match its new behavior. Changed to store the crashing symbol along with the failure type in
55175         the data we pass to the callback for tests which crashed.
55176
55177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
55178         (code): Make <code> elements a little smaller because their contents can be quite long.
55179
55180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55181         (ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
55182         <code> element in the link, if there is a crashing symbol.
55183
55184 2011-06-30  Adam Roben  <aroben@apple.com>
55185
55186         Use objects instead of strings to represent a test result in TestFailures code
55187
55188         This will eventually allow us to store more than just the type of failure for each test.
55189         (E.g., we can store the name of the crashing symbol for tests which crashed.)
55190
55191         Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
55192         include the crashing symbol (like links in results.html do)
55193
55194         Reviewed by David Kilzer.
55195
55196         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
55197         (Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
55198         instead of just a failureType string.
55199
55200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
55201         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
55202         testResult-like object for passing tests.
55203         (FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
55204         objects.
55205
55206         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
55207         (LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
55208         so we can throw away cached data that's in an old format. Store a testResult object for each
55209         test instead of just its failure type.
55210
55211         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55212         (ViewController.prototype._domForFailedTest):
55213         (ViewController.prototype._domForFailureDiagnosis):
55214         Changed to expect testResult objects instead of failureType strings.
55215
55216 2011-06-30  Adam Roben  <aroben@apple.com>
55217
55218         Show full commit logs when visiting Trac from TestFailures page
55219
55220         Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
55221         should show full commit logs
55222
55223         Reviewed by David Kilzer.
55224
55225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
55226         (Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
55227         verbose=on to the log URL to tell Trac to show full commit logs.
55228
55229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55230         (ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
55231
55232 2011-06-30  Adam Roben  <aroben@apple.com>
55233
55234         Add a link to file a bug about TestFailures to the TestFailures page
55235
55236         Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
55237         about TestFailures itself
55238
55239         Reviewed by Anders Carlsson.
55240
55241         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
55242         (aside): Added some styles for the new link. It is positioned in the upper-right and
55243         hopefully not to glaringly obvious.
55244
55245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55246         (ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
55247
55248         (ViewController.prototype._displayBuilder):
55249         (ViewController.prototype._displayTesters):
55250         Modify the main content element instead of the entire body, as there are other things in the
55251         body that we want to preserve.
55252
55253         (ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
55254         that contains a link to file a bug about the TestFailures page.
55255
55256 2011-06-30  Adam Roben  <aroben@apple.com>
55257
55258         Ignore callbacks that correspond to old navigations of the TestFailures page
55259
55260         Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
55261         navigations
55262
55263         Reviewed by Anders Carlsson.
55264
55265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
55266         (LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
55267         callback returns false, stop fetching more data.
55268
55269         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55270         (ViewController): Initialize new _navigationID member. This member is used to assign each
55271         navigation by the user a unique ID.
55272         (ViewController.prototype.parseHash): Increment the navigation ID.
55273
55274         (ViewController.prototype._displayBuilder):
55275         (ViewController.prototype._displayTesters):
55276         At the start of these functions, record the current navigation ID. Bail out from callbacks
55277         if the navigation ID has changed, indicating that the user has navigated elsewhere.
55278
55279 2011-06-30  Carlos Garcia Campos  <cgarcia@igalia.com>
55280
55281         Reviewed by Martin Robinson.
55282
55283         [GTK] Add back/forward menu to MiniBrowser toolbar
55284         https://bugs.webkit.org/show_bug.cgi?id=63445
55285
55286         * MiniBrowser/gtk/BrowserWindow.c:
55287         (browser_window_init): Use a GtkMenuToolButton for navigation
55288         widgets.
55289         (browserWindowConstructed): Get the page BackForwardList.
55290         (browserWindowHistoryItemActivated): Go to activated history item.
55291         (browserWindowHistoryItemSelected): Show the url of currently
55292         selected history item in the statusbar.
55293         (createGtkActionFromBackForwardItem): Create a GtkAction from a
55294         WKBackForwardListItemRef.
55295         (browserWindowCreateMenuItemFromBackForwardItem): Create a
55296         GtkMenuItem from a WKBackForwardListItemRef.
55297         (browserWindowCreateBackForwardMenu): Create a GtkMenu with the
55298         given history items.
55299         (browserWindowUpdateNavigationActions): Update navigation widgets
55300         sensitivity and history menus.
55301         (didChangeBackForwardList): Call
55302         browserWindowUpdateNavigationActions().
55303         (browserWindowLoaderClientInit): Add didChangeBackForwardList
55304         callback.
55305
55306 2011-06-30  Dmitry Lomov  <dslomov@google.com>
55307
55308         Reviewed by Adam Roben.
55309
55310         https://bugs.webkit.org/show_bug.cgi?id=63660
55311         This enables unit-tests step on Windows and MacOS SnowLeopard.
55312
55313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
55314
55315 2011-06-30  Balazs Kelemen  <kbalazs@webkit.org>
55316
55317         Reviewed by Kenneth Rohde Christiansen.
55318
55319         [Qt][WK2] Implement the rest of WTR::PlatformWebView
55320         https://bugs.webkit.org/show_bug.cgi?id=63630
55321
55322         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
55323         (WTR::PlatformWebView::windowFrame):
55324         (WTR::PlatformWebView::setWindowFrame):
55325
55326 2011-06-29  Dirk Pranke  <dpranke@chromium.org>
55327
55328         Reviewed by Adam Barth.
55329
55330         test-webkitpy is spamming lots of messages about updating test expectations
55331         https://bugs.webkit.org/show_bug.cgi?id=63680
55332
55333         This patch changes the passing_run() function to capture the
55334         output to stdout and stderr and assert that it is empty, and
55335         also specifies --no-new-test-results by default to avoid getting
55336         "generating baseline" messages for the expected-missing results.
55337
55338         Also check that we are logging messages when we generate new
55339         baselines.
55340
55341         Also fix a minor bug in the way test_tolerance() was
55342         checking for whether the tests were passing or not.
55343
55344         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
55345
55346 2011-06-29  Yuta Kitamura  <yutak@chromium.org>
55347
55348         Reviewed by Kent Tamura.
55349
55350         DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
55351         https://bugs.webkit.org/show_bug.cgi?id=63532
55352
55353         LayoutTestController::overridePreference() will be used to change the value of
55354         the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
55355         we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
55356         at least we need to reset preference values in DumpRenderTree every time we start
55357         a new test because preference values changed in some test should not be leaked
55358         to the next test.
55359
55360         * DumpRenderTree/chromium/LayoutTestController.cpp:
55361         (LayoutTestController::overridePreference):
55362         The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
55363         * DumpRenderTree/chromium/WebPreferences.cpp:
55364         (WebPreferences::reset):
55365         Set the default value. This will be called from TestShell::resetTestController().
55366         (WebPreferences::applyTo):
55367         * DumpRenderTree/chromium/WebPreferences.h:
55368         * DumpRenderTree/mac/DumpRenderTree.mm:
55369         (resetDefaultsToConsistentValues): Set the default value.
55370         * DumpRenderTree/win/DumpRenderTree.cpp:
55371         (resetDefaultsToConsistentValues): Ditto.
55372
55373 2011-06-29  Kenichi Ishibashi  <bashi@chromium.org>
55374
55375         Reviewed by Adam Barth.
55376
55377         check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
55378         https://webkit.org/b/57360
55379
55380         Modify the regular expression to match https scheme.
55381
55382         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
55383         * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
55384
55385 2011-06-29  Adam Barth  <abarth@webkit.org>
55386
55387         Reviewed by Eric Seidel.
55388
55389         new-run-webkit-tests: images page switch actual and expected images before they're loaded
55390         https://bugs.webkit.org/show_bug.cgi?id=63199
55391
55392         We now preload the images and keep the DOM nodes in memory instead of
55393         going back to the MemoryCache all the time.  (Also, remove some nutty
55394         </img> HTML.)
55395
55396         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55397
55398 2011-06-29  Adam Barth  <abarth@webkit.org>
55399
55400         Reviewed by Eric Seidel.
55401
55402         new-run-webkit-tests should tell you when it creates new expectations
55403         https://bugs.webkit.org/show_bug.cgi?id=63675
55404
55405         Unforunately, this patch creates a bunch of test-webkitpy spam because
55406         we don't understand how Python logging works well enough to stop the
55407         spam.  :(
55408
55409         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
55410
55411 2011-06-29  Eric Seidel  <eric@webkit.org>
55412
55413         Reviewed by Adam Barth.
55414
55415         Refactor WebKitDriver.run_test into smaller pieces
55416         https://bugs.webkit.org/show_bug.cgi?id=63673
55417
55418         There is no functional change here.  Just moving code around.
55419         This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess
55420
55421         * Scripts/webkitpy/layout_tests/port/webkit.py:
55422
55423 2011-06-29  Eric Seidel  <eric@webkit.org>
55424
55425         Reviewed by Adam Barth.
55426
55427         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
55428         https://bugs.webkit.org/show_bug.cgi?id=63501
55429
55430         Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
55431         the rebaselineserver unit tests.  Also fixed nits brought up by Dirk after previous landing.
55432
55433         The goal was to add support for wk2 skipped lists.
55434         However, I found that our skipped list computation was a
55435         manual hack (which only worked for the mac port).
55436
55437         So I fixed a FIXME to move the skipped list finding
55438         into WebKitPort instead of MacPort.
55439         Doing so required the concept of a "port_name", since previously
55440         the only name accessible from a port object was name()
55441         which includes many things beyond "mac" or "chromium", etc.
55442
55443         Eventually I believe we'll want to re-think the way that we pass
55444         in a port_name argument to Port subclasses and expect them to parse
55445         it.  But for now I just added a cls.port_name variable which contains
55446         the static information needed to compute wk2 names as well as
55447         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
55448
55449         In order to test my new _skipped_file_search_paths method, I
55450         fixed another FIXME by making it return relative paths.
55451
55452         I also fixed the test_expectations_path code in WebKitPort to use port_name.
55453         It was using name() which would return PORT-VERSION so MacPort was overriding
55454         it to use just PORT.  After fixing test_expectations_path to use port_name
55455         (and making it aware of webkit2) I was able to remove the MacPort implementation.
55456
55457         * Scripts/webkitpy/layout_tests/port/base.py:
55458          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
55459          - Document that real_name() seems to have no purpose.
55460         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
55461          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
55462         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
55463          - Add _parse_port_name.
55464         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
55465          - Add _parse_port_name.
55466         * Scripts/webkitpy/layout_tests/port/gtk.py:
55467         * Scripts/webkitpy/layout_tests/port/mac.py:
55468          - Move Skipped-file finding code down to WebKitPort
55469         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
55470         * Scripts/webkitpy/layout_tests/port/qt.py:
55471         * Scripts/webkitpy/layout_tests/port/webkit.py:
55472         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55473
55474 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
55475
55476         Unreviewed, rolling out r90070.
55477         http://trac.webkit.org/changeset/90070
55478         https://bugs.webkit.org/show_bug.cgi?id=63676
55479
55480         Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
55481         #webkit).
55482
55483         * Scripts/webkitpy/layout_tests/port/base.py:
55484         * Scripts/webkitpy/layout_tests/port/chromium.py:
55485         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
55486         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
55487         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
55488         * Scripts/webkitpy/layout_tests/port/gtk.py:
55489         * Scripts/webkitpy/layout_tests/port/mac.py:
55490         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
55491         * Scripts/webkitpy/layout_tests/port/qt.py:
55492         * Scripts/webkitpy/layout_tests/port/webkit.py:
55493         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55494         * Scripts/webkitpy/layout_tests/port/win.py:
55495         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
55496
55497 2011-06-29  Adam Barth  <abarth@webkit.org>
55498
55499         Reviewed by Eric Seidel.
55500
55501         new-run-webkit-tests doesn't support sample-on-timeout
55502         https://bugs.webkit.org/show_bug.cgi?id=56731
55503
55504         * Scripts/webkitpy/layout_tests/port/server_process.py:
55505         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
55506         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55507
55508 2011-06-29  Eric Seidel  <eric@webkit.org>
55509
55510         Reviewed by Adam Barth.
55511
55512         Simplify skipped file finding in preparation for adding wk2 skipped list fallback
55513         https://bugs.webkit.org/show_bug.cgi?id=63501
55514
55515         The goal was to add support for wk2 skipped lists.
55516         However, I found that our skipped list computation was a
55517         manual hack (which only worked for the mac port).
55518
55519         So I fixed a FIXME to move the skipped list finding
55520         into WebKitPort instead of MacPort.
55521         Doing so required the concept of a "port_name", since previously
55522         the only name accessible from a port object was name()
55523         which includes many things beyond "mac" or "chromium", etc.
55524
55525         Eventually I believe we'll want to re-think the way that we pass
55526         in a port_name argument to Port subclasses and expect them to parse
55527         it.  But for now I just added a cls.port_name variable which contains
55528         the static information needed to compute wk2 names as well as
55529         compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
55530
55531         In order to test my new _skipped_file_search_paths method, I
55532         fixed another FIXME by making it return relative paths.
55533
55534         I also fixed the test_expectations_path code in WebKitPort to use port_name.
55535         It was using name() which would return PORT-VERSION so MacPort was overriding
55536         it to use just PORT.  After fixing test_expectations_path to use port_name
55537         (and making it aware of webkit2) I was able to remove the MacPort implementation.
55538
55539         * Scripts/webkitpy/layout_tests/port/base.py:
55540          - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
55541          - Document that real_name() seems to have no purpose.
55542         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
55543          - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
55544         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
55545          - Add _parse_port_name.
55546         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
55547          - Add _parse_port_name.
55548         * Scripts/webkitpy/layout_tests/port/gtk.py:
55549         * Scripts/webkitpy/layout_tests/port/mac.py:
55550          - Move Skipped-file finding code down to WebKitPort
55551         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
55552         * Scripts/webkitpy/layout_tests/port/qt.py:
55553         * Scripts/webkitpy/layout_tests/port/webkit.py:
55554         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55555
55556 2011-06-29  Adam Barth  <abarth@webkit.org>
55557
55558         Reviewed by Dirk Pranke.
55559
55560         new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
55561         https://bugs.webkit.org/show_bug.cgi?id=38063
55562
55563         This patch changes new-run-webkit-tests to match old-run-webkit-tests
55564         in generating new expected results when the expected results are
55565         missing.
55566
55567         There are still a couple details that are different:
55568
55569         1) Image baselines aren't generated unless you run with -p.
55570         2) Render tree dumps are places in the cross-platform directory instead
55571         of the platform-specific directory.
55572
55573         I'm inclined to deal with both of these issues in follow-up patches.
55574
55575         * Scripts/webkitpy/common/net/layouttestresults.py:
55576         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
55577         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
55578         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
55579         * Scripts/webkitpy/layout_tests/port/test.py:
55580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55581         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
55582
55583 2011-06-29  Adam Roben  <aroben@apple.com>
55584
55585         Teach TestFailures to detect possibly flaky tests and list them separately
55586
55587         Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
55588         arbitrary revisions for breaking flaky tests
55589
55590         Reviewed by Dan Bates.
55591
55592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
55593         (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
55594         from various builds (in reverse-chronological order).
55595         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
55596         monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
55597         (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
55598         given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
55599         and puts them in an array in reverse-chronological order.
55600         (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
55601         to be possibly flaky.
55602
55603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
55604         (LayoutTestHistoryAnalyzer): Initialize new members.
55605         (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
55606         properties: history and possiblyFlaky. history holds the data this function used to pass to
55607         the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
55608         flakiness. Updated documentation comment to match.
55609         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
55610         FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
55611         removed from the failure history, since when they started failing is no longer meaningful.
55612         We tell our caller to keep calling until all current failures have been explained and we've
55613         gone through 5 builds without any new flaky tests being identified.
55614
55615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
55616         (sorted): New helper function to return a sorted copy of an array.
55617         (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
55618         that matches the predicate.
55619
55620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55621         (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
55622         the analyzer. Now puts the list of possibly flaky tests after the failure history.
55623         (ViewController.prototype._domForFailedTest): Moved some code from here...
55624         (ViewController.prototype._domForFailureDiagnosis): ...to here.
55625         (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
55626         possibly flaky tests and examples of their flakiness and returns it.
55627
55628         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
55629         FlakyLayoutTestDetector.js.
55630
55631 2011-06-29  Eric Seidel  <eric@webkit.org>
55632
55633         Adam says cowboys don't review (or unit test).
55634
55635         * Scripts/webkitpy/tool/commands/download.py:
55636
55637 2011-06-29  Eric Seidel  <eric@webkit.org>
55638
55639         Reviewed by Adam Barth.
55640
55641         Make port/config.py mockable for easier unit testing
55642         https://bugs.webkit.org/show_bug.cgi?id=63661
55643
55644         Fix an exception from the unit tests.
55645
55646         * Scripts/webkitpy/layout_tests/port/config.py:
55647
55648 2011-06-29  Brent Fulgham  <bfulgham@webkit.org>
55649
55650         Unreviewed build correction.
55651
55652         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
55653         Link against zlib1.dll, not the static zlib.lib.
55654
55655 2011-06-29  Eric Seidel  <eric@webkit.org>
55656
55657         Reviewed by Adam Barth.
55658
55659         Make port/config.py mockable for easier unit testing
55660         https://bugs.webkit.org/show_bug.cgi?id=63661
55661
55662         Right now config.py leaks real system paths for
55663         webkit_base_dir due to using __file__.  This patch
55664         adds a filsystem.py wrapper around __file__ so that
55665         we don't have to jump through hoops in webkit_unittest.py
55666         to avoid leaking local paths to the unit test results.
55667
55668         There are probably many more places where we should now
55669         use filesystem.path_for_module, but starting with just this one.
55670
55671         * Scripts/webkitpy/common/system/filesystem.py:
55672         * Scripts/webkitpy/common/system/filesystem_mock.py:
55673         * Scripts/webkitpy/layout_tests/port/config.py:
55674         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55675         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
55676
55677 2011-06-29  Eric Seidel  <eric@webkit.org>
55678
55679         Reviewed by Adam Barth.
55680
55681         Remove duplicate methods in filesystem.py
55682         https://bugs.webkit.org/show_bug.cgi?id=63658
55683
55684         Looks like there was a bad merge at some point.
55685
55686         I also removed a bunch of redundant docstrings.
55687
55688         * Scripts/webkitpy/common/system/filesystem.py:
55689
55690 2011-06-29  Adam Barth  <abarth@webkit.org>
55691
55692         Reviewed by Eric Seidel.
55693
55694         Pass --no-new-test-results to NRWT on build.webkit.org
55695         https://bugs.webkit.org/show_bug.cgi?id=63653
55696
55697         This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
55698
55699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
55700
55701 2011-06-29  Xan Lopez  <xlopez@igalia.com>
55702
55703         Reviewed by Adam Barth.
55704
55705         [GTK] overlapping drag&drop tests fail on NRWT
55706         https://bugs.webkit.org/show_bug.cgi?id=57640
55707
55708         Make a GTK test driver that spawns one Xvfb instance per
55709         thread. This avoids bad interactions in DnD tests between threads.
55710
55711         * Scripts/webkitpy/layout_tests/port/gtk.py:
55712
55713 2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>
55714
55715         Unreviewed, rolling out r89888.
55716         http://trac.webkit.org/changeset/89888
55717         https://bugs.webkit.org/show_bug.cgi?id=63609
55718
55719          "Seems to be causing merging issues on the dashboard, e.g.
55720         http://test-
55721         results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
55722         (Requested by aboxhall on #webkit).
55723
55724         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
55725         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
55726         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
55727
55728 2011-06-29  Philippe Normand  <pnormand@igalia.com>
55729
55730         Reviewed by Martin Robinson.
55731
55732         [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
55733         https://bugs.webkit.org/show_bug.cgi?id=63624
55734
55735         * Scripts/webkitpy/common/system/executive.py: In some cases the
55736         ps output lines can contain one or more leading white-spaces, so
55737         strip it before splitting the pid and command name.
55738
55739 2011-06-29  Noel Gordon  <noel.gordon@gmail.com>
55740
55741         Reviewed by Kent Tamura.
55742
55743         [Chromium] [DRT] ImageDiff should compile in VS2010
55744         https://bugs.webkit.org/show_bug.cgi?id=63614
55745
55746         * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
55747
55748 2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>
55749
55750         Reviewed by Kenneth Rohde Christiansen.
55751
55752         [Qt] DRT support for setInteractiveFormValidationEnabled
55753         https://bugs.webkit.org/show_bug.cgi?id=63496
55754
55755         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
55756         (WebCore::DumpRenderTree::DumpRenderTree):
55757
55758 2011-06-28  Eric Seidel  <eric@webkit.org>
55759
55760         Reviewed by Adam Barth.
55761
55762         Make new-run-webkit-tests -2 actually use WebKitTestRunner
55763         https://bugs.webkit.org/show_bug.cgi?id=63572
55764
55765         new-run-webkit-tests -2 works with this change.  However a zillion
55766         tests fail since it can't find the right skipped lists for wk2.
55767         The Skipped-list fixing is covered in bug 63501.
55768
55769         * Scripts/webkitpy/layout_tests/port/gtk.py:
55770         * Scripts/webkitpy/layout_tests/port/qt.py:
55771         * Scripts/webkitpy/layout_tests/port/webkit.py:
55772
55773 2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>
55774
55775         Reviewed by Adam Roben.
55776
55777         Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
55778         https://bugs.webkit.org/show_bug.cgi?id=63500
55779
55780         Added google-mac-3 and google-mac-4.
55781
55782         * BuildSlaveSupport/build.webkit.org-config/config.json:
55783
55784 2011-06-28  Eric Seidel  <eric@webkit.org>
55785
55786         Reviewed by Dirk Pranke.
55787
55788         Remove webkitpy's tiger support now that WebKit no longer supports tiger
55789         https://bugs.webkit.org/show_bug.cgi?id=63568
55790
55791         I don't think our support actually fully worked anyway.  Regardless
55792         tiger is dead now (thankfully)!
55793
55794         I also unwrapped some short lines and added a couple FIXMEs while
55795         touring the code.
55796
55797         No new tests, only removing old ones which tested our Tiger support.
55798
55799         * Scripts/webkitpy/layout_tests/port/base.py:
55800         * Scripts/webkitpy/layout_tests/port/builders.py:
55801         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
55802         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
55803         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
55804         * Scripts/webkitpy/layout_tests/port/mac.py:
55805         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
55806         * Scripts/webkitpy/tool/commands/rebaseline.py:
55807         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
55808
55809 2011-06-28  Eric Seidel  <eric@webkit.org>
55810
55811         Unreviewed, just fixing a typo.
55812
55813         Fix misspellings of "thead" to "thread".
55814
55815         * Scripts/webkitpy/common/checkout/scm/git.py:
55816         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55817
55818 2011-06-28  Eric Seidel  <eric@webkit.org>
55819
55820         Reviewed by Tony Chang.
55821
55822         new-run-webkit-tests needs a --webkit-test-runner option
55823         https://bugs.webkit.org/show_bug.cgi?id=63439
55824
55825         This was accidentally fixed in bug 63501 as well.
55826         The root problem here was that the webkit unit tests were not using
55827         enough mocks.  I've fixed them here to use more mocks
55828         which should unbreak windows.
55829
55830         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55831
55832 2011-06-28  Eric Seidel  <eric@webkit.org>
55833
55834         Reviewed by Tony Chang.
55835
55836         new-run-webkit-tests should not run mthml tests when MHTML support is disabled
55837         https://bugs.webkit.org/show_bug.cgi?id=63549
55838
55839         This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
55840         I happen to go looking for what code was deciding that .mht was a supported
55841         extension, found test_files.py and then removed some redundant doc-strings and
55842         if branching.
55843
55844         * Scripts/webkitpy/layout_tests/port/test_files.py:
55845         * Scripts/webkitpy/layout_tests/port/webkit.py:
55846         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55847
55848 2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>
55849
55850         Reviewed by Tony Chang.
55851
55852         Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
55853         https://bugs.webkit.org/show_bug.cgi?id=63514
55854
55855         - change write_text_file to write_binary_file
55856         - check that text_path and binary_path are actually existant files
55857         - change cleanup block from 'except' to 'finally'
55858
55859         * Scripts/webkitpy/common/system/filesystem_unittest.py:
55860
55861 2011-06-28  Adam Roben  <aroben@apple.com>
55862
55863         Roll out r89924 and r89925
55864
55865         I didn't mean to commit them!
55866
55867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
55868         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
55869         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
55870
55871 2011-06-27  Adam Barth  <abarth@webkit.org>
55872
55873         Reviewed by Eric Seidel.
55874
55875         NRWT should wait for ReportCrash
55876         https://bugs.webkit.org/show_bug.cgi?id=63495
55877
55878         When a test crashes on Mac, ReportCrash confuses us into thinking the
55879         test times out.
55880
55881         I'm not sure how to test this in a meaningful way in our current test
55882         harness...
55883
55884         * Scripts/webkitpy/common/system/crashlogs.py:
55885         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
55886         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55887         * Scripts/webkitpy/layout_tests/port/base.py:
55888         * Scripts/webkitpy/layout_tests/port/mac.py:
55889         * Scripts/webkitpy/layout_tests/port/server_process.py:
55890         * Scripts/webkitpy/tool/commands/queries.py:
55891
55892 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
55893
55894         Unreviewed, rolling out r89881.
55895         http://trac.webkit.org/changeset/89881
55896         https://bugs.webkit.org/show_bug.cgi?id=63513
55897
55898         Makes Qt massively slow (Requested by abarth on #webkit).
55899
55900         * Scripts/webkitpy/common/system/crashlogs.py:
55901         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
55902         * Scripts/webkitpy/common/system/executive.py:
55903         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55904         * Scripts/webkitpy/layout_tests/port/base.py:
55905         * Scripts/webkitpy/layout_tests/port/mac.py:
55906         * Scripts/webkitpy/layout_tests/port/server_process.py:
55907         * Scripts/webkitpy/tool/commands/queries.py:
55908
55909 2011-06-27  Alice Boxhall  <aboxhall@chromium.org>
55910
55911         Reviewed by Ojan Vafai.
55912
55913         Convert json_results_generator.py to output version 4 JSON.
55914         https://bugs.webkit.org/show_bug.cgi?id=60869
55915
55916         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
55917         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
55918         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
55919
55920 2011-06-27  Adam Barth  <abarth@webkit.org>
55921
55922         Reviewed by Eric Seidel.
55923
55924         NRWT should wait for ReportCrash
55925         https://bugs.webkit.org/show_bug.cgi?id=63495
55926
55927         When a test crashes on Mac, ReportCrash confuses us into thinking the
55928         test times out.
55929
55930         I'm not sure how to test this in a meaningful way in our current test
55931         harness...
55932
55933         * Scripts/webkitpy/common/system/crashlogs.py:
55934         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
55935         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55936         * Scripts/webkitpy/layout_tests/port/base.py:
55937         * Scripts/webkitpy/layout_tests/port/mac.py:
55938         * Scripts/webkitpy/layout_tests/port/server_process.py:
55939         * Scripts/webkitpy/tool/commands/queries.py:
55940
55941 2011-06-27  Adam Barth  <abarth@webkit.org>
55942
55943         Reviewed by Eric Seidel.
55944
55945         new-run-webkit-tests should upload crash logs
55946         https://bugs.webkit.org/show_bug.cgi?id=55907
55947
55948         NRWT used to have a different name for crash logs.  I've changed the
55949         name to patch ORWT.
55950
55951         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
55952         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
55953
55954 2011-06-27  Eric Seidel  <eric@webkit.org>
55955
55956         Reviewed by Adam Barth.
55957
55958         new-run-webkit-tests needs a --webkit-test-runner option
55959         https://bugs.webkit.org/show_bug.cgi?id=63439
55960
55961         NRWT doesn't actually know how to run with the WebKitTestRunner yet
55962         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
55963
55964         There is a bunch of other little cleanup in this patch which I added as I
55965         took a tour through all of our hard-coded DumpRenderTree strings.
55966
55967         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
55968         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
55969         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
55970         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
55971         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
55972         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
55973         * Scripts/webkitpy/layout_tests/port/config.py:
55974          - build_dumprendertree had no business in this class, removed it.
55975          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
55976          - Exposed _script_path as script_path() (this probably belongs elsewhere).
55977         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
55978          - Moved these tests to webkit_unittests.
55979         * Scripts/webkitpy/layout_tests/port/webkit.py:
55980          - Now respects the --webkit-test-runner option.
55981          - setup_test_run is empty in base.py too, no need to override it.
55982         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
55983          - Test the new hotness.
55984          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
55985            I think this code is still hitting disk during the unit tests. :(
55986         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55987          - Add the option.
55988         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
55989          - Remove optional args option.
55990         * Scripts/webkitpy/tool/commands/commandtest.py:
55991          - Remove optional args option.
55992         * Scripts/webkitpy/tool/commands/queues_unittest.py:
55993          - Remove optional args option.
55994
55995 2011-06-27  Adam Barth  <abarth@webkit.org>
55996
55997         Reviewed by Dirk Pranke.
55998
55999         new-run-webkit-tests does not report stderr output
56000         https://bugs.webkit.org/show_bug.cgi?id=37739
56001
56002         Almost all the infrastructure appears to be in place to report stderr
56003         in results.html.  We just need to wire up a bool to tell results.html
56004         to create the hyperlink.
56005
56006         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
56007         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
56008         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
56009         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
56010         * Scripts/webkitpy/layout_tests/port/base.py:
56011
56012 2011-06-27  Adam Barth  <abarth@webkit.org>
56013
56014         Reviewed by Dirk Pranke.
56015
56016         webkitpy unit tests should have more descriptive names than just "Test"
56017         https://bugs.webkit.org/show_bug.cgi?id=63479
56018
56019         Luckily we kept these classes in separate namespaces in the harness so
56020         we were actually running them all even though they had the same name.
56021
56022         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
56023         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
56024         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
56025
56026 2011-06-27  Greg Simon  <gregsimon@chromium.org>
56027
56028         No review necessary.
56029
56030         Add email addr to contributor list
56031         https://bugs.webkit.org/show_bug.cgi?id=63478
56032
56033         * Scripts/webkitpy/common/config/committers.py:
56034
56035 2011-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
56036
56037         Unreviewed, rolling out r89834.
56038         http://trac.webkit.org/changeset/89834
56039         https://bugs.webkit.org/show_bug.cgi?id=63476
56040
56041         Broke test-webkitpy (Requested by abarth on #webkit).
56042
56043         * Scripts/webkitpy/common/net/layouttestresults.py:
56044         * Scripts/webkitpy/common/system/outputcapture.py:
56045         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
56046         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
56047         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
56048         * Scripts/webkitpy/layout_tests/port/base.py:
56049         * Scripts/webkitpy/layout_tests/port/config.py:
56050         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
56051         * Scripts/webkitpy/layout_tests/port/webkit.py:
56052         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
56053         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
56054         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
56055         * Scripts/webkitpy/tool/commands/commandtest.py:
56056         * Scripts/webkitpy/tool/commands/queues_unittest.py:
56057
56058 2011-06-27  Jeff Miller  <jeffm@apple.com>
56059
56060         Reviewed by Adam Roben.
56061
56062         Stop copying obsolete WebKit libraries on Windows
56063         https://bugs.webkit.org/show_bug.cgi?id=63474
56064
56065         Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
56066
56067         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
56068         * MiniBrowser/MiniBrowserPostBuild.cmd:
56069         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
56070
56071 2011-06-27  Ryosuke Niwa  <rniwa@webkit.org>
56072
56073         Add Wyatt Carss to the list of non-committer contributors.
56074
56075         * Scripts/webkitpy/common/config/committers.py:
56076
56077 2011-06-27  Adam Barth  <abarth@webkit.org>
56078
56079         Reviewed by Eric Seidel.
56080
56081         webkitpy should understand crash logs
56082         https://bugs.webkit.org/show_bug.cgi?id=63468
56083
56084         We're planning to use this functionality to upload crash logs along
56085         with test results for new-run-webkit-tests.
56086
56087         * Scripts/webkitpy/common/system/crashlog.py: Added.
56088         * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
56089         * Scripts/webkitpy/common/system/executive.py:
56090         * Scripts/webkitpy/common/system/executive_unittest.py:
56091         * Scripts/webkitpy/common/system/filesystem.py:
56092         * Scripts/webkitpy/common/system/filesystem_mock.py:
56093         * Scripts/webkitpy/tool/commands/queries.py:
56094
56095 2011-06-27  Adam Roben  <aroben@apple.com>
56096
56097         Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
56098         failures
56099
56100         Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
56101         old-run-webkit-tests exited early after reload
56102
56103         Reviewed by Anders Carlsson.
56104
56105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
56106         (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
56107         old-run-webkit-tests exited early due to too many failures in PersistentCache.
56108
56109 2011-06-27  Adam Roben  <aroben@apple.com>
56110
56111         Make TestFailures load build names from build.webkit.org/old-results too
56112
56113         Build results are periodically moved from results to old-results. This change makes those
56114         builds still visible to TestFailures.
56115
56116         Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
56117         have been moved to build.webkit.org/old-results
56118
56119         Reviewed by Anders Carlsson.
56120
56121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56122         (Builder.prototype.getBuildNames): Extracted code to parse build names from a
56123         build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
56124         we now only include directory entries whose names are parseable as build names (since
56125         old-results sometimes contains other random files/directories from who knows what). We now
56126         fetch both results and old-results (with a FIXME about loading old-results on demand),
56127         extract build names from each, and concatenate the two sets of names.
56128
56129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
56130         (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
56131         parseable, rather than throwing an exception.
56132
56133 2011-06-26  Adam Roben  <aroben@apple.com>
56134
56135         Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
56136
56137         It seems silly to have a whole generic cache just to store a single object.
56138
56139         Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
56140         need one
56141
56142         Reviewed by Anders Carlsson.
56143
56144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
56145         (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
56146         (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
56147         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
56148         no-longer-needed history argument.
56149
56150 2011-06-26  Adam Roben  <aroben@apple.com>
56151
56152         Move some inappropriate code out of Builder
56153
56154         Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
56155         isn't really about a builder
56156
56157         Reviewed by Anders Carlsson.
56158
56159         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56160         (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
56161         called by other objects.
56162
56163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
56164         Added. Code came from Builder.
56165         (LayoutTestHistoryAnalyzer):
56166         (LayoutTestHistoryAnalyzer.prototype.start):
56167         (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
56168
56169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
56170         Added. Code came from Builder.
56171         (LayoutTestResultsLoader):
56172         (LayoutTestResultsLoader.prototype.start):
56173
56174         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56175         (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
56176
56177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
56178         scripts.
56179
56180 2011-05-17  Nat Duca  <nduca@chromium.org>
56181
56182         Reviewed by James Robinson.
56183
56184         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
56185         https://bugs.webkit.org/show_bug.cgi?id=58408
56186
56187         * DumpRenderTree/chromium/WebViewHost.cpp:
56188         (WebViewHost::paintInvalidatedRegion):
56189
56190 2011-06-27  Eric Seidel  <eric@webkit.org>
56191
56192         Reviewed by Adam Barth.
56193
56194         new-run-webkit-tests needs a --webkit-test-runner option
56195         https://bugs.webkit.org/show_bug.cgi?id=63439
56196
56197         NRWT doesn't actually know how to run with the WebKitTestRunner yet
56198         but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
56199
56200         There is a bunch of other little cleanup in this patch which I added as I
56201         took a tour through all of our hard-coded DumpRenderTree strings.
56202
56203         * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
56204         * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
56205         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
56206         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
56207         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
56208         * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
56209         * Scripts/webkitpy/layout_tests/port/config.py:
56210          - build_dumprendertree had no business in this class, removed it.
56211          - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
56212          - Exposed _script_path as script_path() (this probably belongs elsewhere).
56213         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
56214          - Moved these tests to webkit_unittests.
56215         * Scripts/webkitpy/layout_tests/port/webkit.py:
56216          - Now respects the --webkit-test-runner option.
56217          - setup_test_run is empty in base.py too, no need to override it.
56218         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
56219          - Test the new hotness.
56220          - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
56221            I think this code is still hitting disk during the unit tests. :(
56222         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
56223          - Add the option.
56224         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
56225          - Remove optional args option.
56226         * Scripts/webkitpy/tool/commands/commandtest.py:
56227          - Remove optional args option.
56228         * Scripts/webkitpy/tool/commands/queues_unittest.py:
56229          - Remove optional args option.
56230
56231 2011-06-27  Chang Shu  <cshu@webkit.org>
56232
56233         Reviewed by Darin Adler.
56234
56235         [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
56236         https://bugs.webkit.org/show_bug.cgi?id=63457
56237
56238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
56239         (WTR::InjectedBundle::beginTesting):
56240
56241 2011-06-27  Raphael Kubo da Costa  <kubo@profusion.mobi>
56242
56243         Reviewed by Kent Tamura.
56244
56245         [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
56246         It will be plugged into the build system as soon as the rest of the
56247         DRT code is fully upstreamed.
56248         https://bugs.webkit.org/show_bug.cgi?id=63086
56249
56250         * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
56251         (onConsoleMessage):
56252         (onJavaScriptAlert):
56253         (onJavaScriptConfirm):
56254         (onJavaScriptPrompt):
56255         (drtViewTiledAdd):
56256         * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
56257
56258 2011-06-27  Leandro Pereira  <leandro@profusion.mobi>
56259
56260         Reviewed by Kent Tamura.
56261
56262         [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
56263         with support files.
56264         Build system changes will be made as soon as the whole DumpRenderTree
56265         is upstreamed.
56266         https://bugs.webkit.org/show_bug.cgi?id=61962
56267
56268         * DumpRenderTree/efl/EventSender.cpp: Added.
56269         (setEvasModifiers):
56270         (translateMouseButtonNumber):
56271         (sendMouseEvent):
56272         (sendClick):
56273         (scheduleAsynchronousClickCallback):
56274         (updateClickCount):
56275         (modifierFromJSValue):
56276         (modifiersFromJSValue):
56277         (mouseDownCallback):
56278         (mouseUpCallback):
56279         (mouseMoveToCallback):
56280         (evasMouseEventFromHorizontalAndVerticalOffsets):
56281         (mouseScrollByCallback):
56282         (continuousMouseScrollByCallback):
56283         (keyPadNameFromJSValue):
56284         (keyNameFromJSValue):
56285         (keyDownCallback):
56286         (scalePageByCallback):
56287         (getClass):
56288         (makeEventSender):
56289         * DumpRenderTree/efl/EventSender.h: Added.
56290
56291 2011-06-27  Eric Seidel  <eric@webkit.org>
56292
56293         Reviewed by Adam Barth.
56294
56295         Remove evil uses of hasattr
56296         https://bugs.webkit.org/show_bug.cgi?id=63430
56297
56298         For some reason these classes believe that they may be called with
56299         various flavors of "option" elements and so carefully check to make
56300         sure that the options element has their option before checking it.
56301
56302         We had a set_option_default method which was never called, so I made it
56303         do what callsites seemed to want it to do and replaced 3 callers
56304         who previously used hasattr manually to use set_option_default instead.
56305
56306         * Scripts/webkitpy/layout_tests/port/base.py:
56307         * Scripts/webkitpy/layout_tests/port/webkit.py:
56308
56309 2011-06-27  Kent Tamura  <tkent@chromium.org>
56310
56311         Reviewed by Hajime Morita.
56312
56313         [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
56314         https://bugs.webkit.org/show_bug.cgi?id=63427
56315
56316         ~WebViewHost() navigates to about:blank, so it calls some
56317         callbacks and LayoutTestController functions.
56318
56319         * DumpRenderTree/chromium/TestShell.h:
56320          Move m_printer upper and move m_webViewHost lower.
56321
56322 2011-06-27  Adam Barth  <abarth@webkit.org>
56323
56324         Reviewed by Eric Seidel.
56325
56326         Move server config files to webkitpy.layout_tests.servers
56327         https://bugs.webkit.org/show_bug.cgi?id=63436
56328
56329         The config files belong with the servers.
56330
56331         * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
56332         * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
56333         * Scripts/webkitpy/layout_tests/servers/http_server.py:
56334         * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
56335         * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
56336
56337 2011-06-27  Adam Barth  <abarth@webkit.org>
56338
56339         Reviewed by Eric Seidel.
56340
56341         Move websocket_server and http_server to webkitpy.layout_package.servers
56342         https://bugs.webkit.org/show_bug.cgi?id=63434
56343
56344         These classes do not represent ports.  They represent servers.
56345
56346         * Scripts/new-run-webkit-httpd:
56347         * Scripts/new-run-webkit-websocketserver:
56348         * Scripts/webkitpy/layout_tests/port/base.py:
56349         * Scripts/webkitpy/layout_tests/port/chromium.py:
56350         * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
56351         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
56352         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
56353         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
56354         * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
56355         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
56356         * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
56357         * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
56358         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
56359         * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
56360
56361 2011-06-27  Eric Seidel  <eric@webkit.org>
56362
56363         Reviewed by Adam Barth.
56364
56365         Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
56366         https://bugs.webkit.org/show_bug.cgi?id=63428
56367
56368         * Scripts/webkitpy/layout_tests/port/chromium.py:
56369         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
56370
56371 2011-06-27  Adam Barth  <abarth@webkit.org>
56372
56373         Reviewed by Eric Seidel.
56374
56375         Move apache_http_server.py to webkitpy.layout_package.servers
56376         https://bugs.webkit.org/show_bug.cgi?id=63433
56377
56378         The apache_http_server.py is a server, not a port.
56379
56380         * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
56381         * Scripts/webkitpy/layout_tests/port/base.py:
56382         * Scripts/webkitpy/layout_tests/servers: Added.
56383         * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
56384         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
56385
56386 2011-06-27  Adam Barth  <abarth@webkit.org>
56387
56388         Reviewed by Eric Seidel.
56389
56390         Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
56391         https://bugs.webkit.org/show_bug.cgi?id=63432
56392
56393         This code isn't in the dependency cone of new-run-webkit-tests. It's
56394         unclear what it's final home should be, but this patch moves it out of
56395         layout_tests to simply the package.
56396
56397         * Scripts/rebaseline-chromium-webkit-tests:
56398         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
56399         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
56400         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
56401         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
56402
56403 2011-06-27  Adam Barth  <abarth@webkit.org>
56404
56405         Reviewed by Eric Seidel.
56406
56407         Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
56408         https://bugs.webkit.org/show_bug.cgi?id=63429
56409
56410         This package as nothing to do with the layout_tests package.
56411
56412         * Scripts/update-webgl-conformance-tests:
56413         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
56414         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
56415         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
56416         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
56417
56418 2011-06-27  Adam Barth  <abarth@webkit.org>
56419
56420         Reviewed by Eric Seidel.
56421
56422         Move deduplicate_tests.py into webkitpy.to_be_moved
56423         https://bugs.webkit.org/show_bug.cgi?id=63426
56424
56425         deduplicate_tests.py doesn't haven anything to do with layout tests.
56426         It's really a separate script.  This patch moves it to the (new)
56427         to_be_moved package so that it doesn't distract us when working on NRWT.
56428
56429         * Scripts/deduplicate-tests:
56430         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
56431         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
56432         * Scripts/webkitpy/test/main.py:
56433         * Scripts/webkitpy/to_be_moved: Added.
56434         * Scripts/webkitpy/to_be_moved/__init__.py: Added.
56435         * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
56436         * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
56437
56438 2011-06-26  Adam Barth  <abarth@webkit.org>
56439
56440         Rubber-stamped by Eric Seidel.
56441
56442         Remove empty directory.
56443
56444         * Scripts/webkitpy/layout_tests/test_types: Removed.
56445
56446 2011-06-25  Naoki Takano  <honten@chromium.org>
56447
56448         Reviewed by Eric Seidel.
56449
56450         Change my entry from contributors to committers.
56451         https://bugs.webkit.org/show_bug.cgi?id=63043
56452
56453         * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
56454
56455 2011-06-25  Adam Barth  <abarth@webkit.org>
56456
56457         Reviewed by Eric Seidel.
56458
56459         [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
56460         https://bugs.webkit.org/show_bug.cgi?id=63394
56461
56462         * DumpRenderTree/chromium/LayoutTestController.cpp:
56463         (LayoutTestController::queueLoad):
56464
56465 2011-06-25  Brent Fulgham  <bfulgham@webkit.org>
56466
56467         Unreviewed build correction after r89426.
56468
56469         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
56470           Link with Cairo DLL for new functionality.
56471         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
56472           code for snprintf.
56473
56474 2011-06-25  Dimitri Glazkov  <dglazkov@chromium.org>
56475
56476         Reviewed by Adam Barth.
56477
56478         run-bindings-tests does not work on Chromium Windows.
56479         https://bugs.webkit.org/show_bug.cgi?id=63382
56480
56481         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
56482
56483 2011-06-25  Dan Bernstein  <mitz@apple.com>
56484
56485         Try to fix the Qt and Chromium builds.
56486
56487         * DumpRenderTree/chromium/LayoutTestController.cpp:
56488         (LayoutTestController::setEncodedAudioData):
56489         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
56490
56491 2011-06-24  Dan Bernstein  <mitz@apple.com>
56492
56493         Reviewed by Anders Carlsson.
56494
56495         Add an option to enable legacy rounding hacks
56496         https://bugs.webkit.org/show_bug.cgi?id=63363
56497
56498         Added layoutTestController.allowRoundingHacks() and implemented it
56499         on OS X.
56500
56501         * DumpRenderTree/LayoutTestController.cpp:
56502         (allowRoundingHacksCallback):
56503         (LayoutTestController::staticFunctions):
56504         * DumpRenderTree/LayoutTestController.h:
56505         * DumpRenderTree/chromium/LayoutTestController.cpp:
56506         (LayoutTestController::allowRoundingHacks):
56507         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
56508         (LayoutTestController::allowRoundingHacks):
56509         * DumpRenderTree/mac/DumpRenderTree.mm:
56510         (resetWebViewToConsistentStateBeforeTesting):
56511         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
56512         (LayoutTestController::allowRoundingHacks):
56513         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
56514         (LayoutTestController::allowRoundingHacks):
56515         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
56516         (LayoutTestController::allowRoundingHacks):
56517         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
56518         (LayoutTestController::allowRoundingHacks):
56519
56520 2011-06-24  Adam Roben  <aroben@apple.com>
56521
56522         Include the directory containing the failing tests in titles of bugs filed from TestFailures
56523         when all the tests won't fit
56524
56525         Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
56526         which tests are failing
56527
56528         Reviewed by David Kilzer.
56529
56530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
56531         (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
56532         that ends in a path separator.
56533
56534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56535         (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
56536         in the title, first try to include the longest common prefix of the test names, then, if
56537         that's still too long or there's no common prefix, fall back to not including any
56538         information about which tests are failing.
56539
56540 2011-06-24  Adam Roben  <aroben@apple.com>
56541
56542         Include links to Trac in bugs filed from TestFailures
56543
56544         Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
56545         Trac for suspect revisions
56546
56547         Reviewed by David Kilzer.
56548
56549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
56550         (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
56551         Trac.
56552
56553         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56554         (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
56555         include a link to Trac for it in the first sentence of the description. Otherwise include a
56556         link to the suspect range after the list of failing tests.
56557
56558 2011-06-24  Nat Duca  <nduca@chromium.org>
56559
56560         Unreviewed, rolling out r89694.
56561         http://trac.webkit.org/changeset/89694
56562         https://bugs.webkit.org/show_bug.cgi?id=58408
56563
56564         Test shell still not ready for animate changes.
56565
56566         * DumpRenderTree/chromium/WebViewHost.cpp:
56567         (WebViewHost::paintInvalidatedRegion):
56568
56569 2011-06-24  Adam Roben  <aroben@apple.com>
56570
56571         Fix typos introduced in r89696
56572
56573         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56574         (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
56575         callback, since that's what it expects.
56576
56577 2011-06-24  Adam Roben  <aroben@apple.com>
56578
56579         Make TestFailures correctly remember whether old-run-webkit-tests exited early
56580
56581         Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
56582         completion after reload
56583
56584         Reviewed by David Kilzer.
56585
56586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56587         (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
56588         in the PeristentCache, store an object that contains both the number of failures and whether
56589         old-run-webkit-tests exited early.
56590
56591 2011-06-24  Adam Roben  <aroben@apple.com>
56592
56593         Add links to regression ranges in Trac to the TestFailures page
56594
56595         Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
56596         links to regression ranges in Trac
56597
56598         Reviewed by David Kilzer.
56599
56600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
56601         (Trac): This new class represents a particular instance of Trac for a single project.
56602         (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
56603         repository path between the two specified revisions
56604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56605         (ViewController): Added new trac argument.
56606         (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
56607         passed/failed builds from here...
56608         (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
56609         Trac if there are multiple suspect revisions.
56610
56611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
56612         Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
56613
56614 2011-05-17  Nat Duca  <nduca@chromium.org>
56615
56616         Reviewed by James Robinson.
56617
56618         [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
56619         https://bugs.webkit.org/show_bug.cgi?id=58408
56620
56621         * DumpRenderTree/chromium/WebViewHost.cpp:
56622         (WebViewHost::paintInvalidatedRegion):
56623
56624 2011-06-24  Dominic Cooney   <dominicc@chromium.org>
56625
56626         Reviewed by Dimitri Glazkov.
56627
56628         Convert shadow DOM-related tests to use window.internals
56629         https://bugs.webkit.org/show_bug.cgi?id=61671
56630
56631         Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
56632         removeShadowRoot from layoutTestController; these have been
56633         replaced by equivalents in window.internals instead.
56634
56635         * DumpRenderTree/LayoutTestController.cpp:
56636         (LayoutTestController::staticFunctions):
56637         * DumpRenderTree/LayoutTestController.h:
56638         * DumpRenderTree/chromium/LayoutTestController.cpp:
56639         (LayoutTestController::LayoutTestController):
56640         * DumpRenderTree/chromium/LayoutTestController.h:
56641         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
56642         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
56643         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
56644         * DumpRenderTree/qt/LayoutTestControllerQt.h:
56645         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
56646         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
56647         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
56648         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
56649         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
56650
56651 2011-06-24  Csaba Osztrogonác  <ossy@webkit.org>
56652
56653         Reviewed by Dirk Schulze.
56654
56655         Make run-bindings-tests remove its temporary directories.
56656         https://bugs.webkit.org/show_bug.cgi?id=63320
56657
56658         * Scripts/run-bindings-tests:
56659
56660 2011-06-23  MORITA Hajime  <morrita@google.com>
56661
56662         Reviewed by Kent Tamura.
56663
56664         [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
56665         https://bugs.webkit.org/show_bug.cgi?id=63216
56666
56667         Deleted m_webViewHost which looks leaked.
56668
56669         * DumpRenderTree/chromium/TestShell.h:
56670         * DumpRenderTree/chromium/TestShell.cpp:
56671         (TestShell::~TestShell):
56672
56673 2011-06-24  Carlos Garcia Campos  <cgarcia@igalia.com>
56674
56675         Unreviewed. Fix WebKit2 GTK build.
56676
56677         * WebKitTestRunner/GNUmakefile.am:
56678
56679 2011-06-23  Ryuan Choi  <ryuan.choi@samsung.com>
56680
56681         Unreviewed, add myself as committer.
56682
56683         * Scripts/webkitpy/common/config/committers.py:
56684
56685 2011-06-23  Nat Duca  <nduca@chromium.org>
56686
56687         Unreviewed, add myself as committer.
56688
56689         * Scripts/webkitpy/common/config/committers.py:
56690
56691 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
56692
56693         Reviewed by Tony Chang.
56694
56695         nrwt: move http locking code into manager
56696         https://bugs.webkit.org/show_bug.cgi?id=63103
56697
56698         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
56699         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
56700
56701 2011-06-23  Alok Priyadarshi  <alokp@chromium.org>
56702
56703         Reviewed by James Robinson.
56704
56705         [chromium] Add support for running layout tests with accelerated rendering
56706         https://bugs.webkit.org/show_bug.cgi?id=63274
56707
56708         * Scripts/webkitpy/layout_tests/port/chromium.py:
56709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
56710
56711 2011-06-23  Adam Roben  <aroben@apple.com>
56712
56713         Avoid fetching JSON data when possible on TestFailures page to determine if
56714         old-run-webkit-tests exited early
56715
56716         As of r89610, results.html includes information about whether old-run-webkit-tests exited
56717         early, so we don't need to look at JSON data to get this information for builds newer than
56718         that.
56719
56720         Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
56721         which is slow and limits history to the last build master restart
56722
56723         Reviewed by David Kilzer.
56724
56725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56726         (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
56727         function. If we're dealing with a build that has early-exit information in results.html,
56728         don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
56729         the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
56730         (as before).
56731
56732 2011-06-23  Eric Seidel  <eric@webkit.org>
56733
56734         Reviewed by Adam Barth.
56735
56736         sheriffbot can no longer restart
56737         https://bugs.webkit.org/show_bug.cgi?id=63221
56738
56739         Fixed and unit tested.
56740
56741         * Scripts/webkitpy/tool/bot/queueengine.py:
56742         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
56743         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
56744
56745 2011-06-23  Martin Robinson  <mrobinson@igalia.com>
56746
56747         Reviewed by Xan Lopez.
56748
56749         [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
56750         https://bugs.webkit.org/show_bug.cgi?id=63287
56751
56752         Send the path to the TestNetscapePlugin to the WKTR via an environment variable
56753         so that the plugin loads properly.
56754
56755         * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
56756         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
56757         (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
56758         of the work for getting an environment variable and converting it to UTF-8.
56759         (WTR::TestController::initializeInjectedBundlePath): Use the helper.
56760         (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
56761
56762 2011-06-23  Adam Roben  <aroben@apple.com>
56763
56764         Record whether old-run-webkit-tests aborted early in results.html
56765
56766         Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
56767         old-run-webkit-tests stopped running tests early
56768
56769         Reviewed by David Kilzer.
56770
56771         * Scripts/old-run-webkit-tests:
56772         (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
56773         Added a <style> element with some styles for the new message. If we stopped running early,
56774         put the reason why at the top of results.html.
56775         (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
56776         $stoppedRunningEarlyMessage global.
56777
56778 2011-06-23  Adam Roben  <aroben@apple.com>
56779
56780         Cache some of the TestFailures page's data in localStorage
56781
56782         This makes reloading TestFailures much faster. Right now we only store the number of failing
56783         tests and the list of failing tests for each build. We may choose to store more later, but
56784         it's easy to run up against quota limits.
56785
56786         Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
56787         APIs (or similar) to improve loading performance
56788
56789         Reviewed by David Kilzer.
56790
56791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56792         (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
56793         (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
56794         fetching data to the callback.
56795         (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
56796         store the tests in the cache just before calling the callback. (The previous code in this
56797         function relied on being able to modify the tests object after storing it in the cache and
56798         having the cached version be updated. This worked while it was a non-serialized cache, but
56799         PersistentCache uses serialization.)
56800
56801         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
56802         (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
56803         values, and stores the date that each value was initially stored along with it. This is
56804         later used for pruning the cache.
56805         (PersistentCache.contains): Checks whether the key exists in localStorage.
56806         (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
56807         value out of it.
56808         (PersistentCache.set): Serialize the value, add the date to it, and store it in
56809         localStorage. If this fails due to quota limits, empty the whole cache and try again.
56810         (PersistentCache.prune): Delete any cached data that is deemed old enough.
56811         (PersistentCache._addDateToJSONString): Prepend the current date to the string.
56812         (PersistentCache._emptyCache): Delete everything from localStorage.
56813         (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
56814         return them.
56815
56816         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56817         (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
56818         we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
56819         where we'd never show the new bug link for tests for which we couldn't determine a passing
56820         revision.
56821
56822         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
56823         PersistentCache.js.
56824
56825 2011-06-23  Adam Roben  <aroben@apple.com>
56826
56827         Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
56828
56829         One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
56830         contain titles that are so long they are rejected by Bugzilla
56831
56832         Reviewed by David Kilzer.
56833
56834         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
56835         (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
56836         using a query string on the URL. If the search query is very long, using a query string can
56837         cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
56838         (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
56839
56840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
56841         (.new-bug-form): Hide the form that we secretly use to file a new bug.
56842
56843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
56844         (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
56845         query parameters to the URL. Otherwise, send them as the body of the request along with the
56846         appropriate headers.
56847         (getResource): Now just calls through to fetchResource.
56848         (urlEncodedQueryParameters): Added. Moved some code here...
56849         (addQueryParametersToURL): ...from here.
56850
56851         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56852         (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
56853         number of failing tests if mentioning all the tests would make the title too long. Improved
56854         the description for large numbers of failures by listing the tests one-per-line instead of
56855         just having them be comma-separated, which was hard to read. Use a form to file the new bug
56856         instead of a link so that we can POST the form data. (Using a URL with a query string can
56857         result in the URL being too long.) The new bug link now just submits the form.
56858
56859 2011-06-23  Adam Roben  <aroben@apple.com>
56860
56861         Show closed bugs on the TestFailures page in addition to open ones
56862
56863         Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
56864
56865         Reviewed by David Kilzer.
56866
56867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
56868         (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
56869         returned data.
56870         (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
56871         the associated bug is still open.
56872
56873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
56874         (addQueryParametersToURL): Add a missing semicolon.
56875         (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
56876         object and appends each of the values stored within.
56877
56878         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
56879         (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
56880         bugs will be included in the results. Split the returned bugs into two sets: those which are
56881         open, and those which are closed. Put the open bugs at the top level of the list, and the
56882         closed bugs in a second level.
56883
56884 2011-06-23  Adam Roben  <aroben@apple.com>
56885
56886         Don't count new tests as failures on the TestFailures page
56887
56888         Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
56889         they aren't
56890
56891         Reviewed by Anders Carlsson.
56892
56893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
56894         (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
56895         of failures.
56896
56897 2011-06-23  Dirk Pranke  <dpranke@chromium.org>
56898
56899         Reviewed by Eric Seidel.
56900
56901         nrwt: make TestInput objects printable
56902         https://bugs.webkit.org/show_bug.cgi?id=63225
56903
56904         This makes debugging slighlty easier.
56905
56906         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
56907
56908 2011-06-22  Daniel Bates  <dbates@webkit.org>
56909
56910         Reviewed by Adam Barth.
56911
56912         test-webkitpy --all errors out because scm_unittest.py can't find module checkout
56913         https://bugs.webkit.org/show_bug.cgi?id=62943
56914
56915         Remove "from .checkout import Checkout" from scm_unittest.py since it's included
56916         by Scripts/webkitpy/common/checkout/__init__.py.
56917
56918         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
56919
56920 2011-06-22  Dominic Cooney  <dominicc@chromium.org>
56921
56922         Reviewed by Mark Rowe.
56923
56924         Add window.internals to WebKit2's WebKitTestRunner.
56925         https://bugs.webkit.org/show_bug.cgi?id=61073
56926
56927         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
56928         * WebKitTestRunner/Configurations/Base.xcconfig:
56929         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
56930         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
56931         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
56932         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
56933         (WTR::InjectedBundlePage::didClearWindowForFrame):
56934         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
56935         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
56936
56937 2011-06-22  Eric Seidel  <eric@webkit.org>
56938
56939         Reviewed by Adam Barth.
56940
56941         Make sheriff-bot rollout messages a little nicer
56942         https://bugs.webkit.org/show_bug.cgi?id=63107
56943
56944         itertools.chain.from_iterable is new in 2.6,
56945         use itertools.chain(*list) for 2.5 compat.
56946
56947         * Scripts/webkitpy/tool/bot/irc_command.py:
56948
56949 2011-06-22  Eric Seidel  <eric@webkit.org>
56950
56951         Reviewed by Adam Barth.
56952
56953         Make sheriff-bot robust against exceptions from commands
56954         https://bugs.webkit.org/show_bug.cgi?id=63211
56955
56956         sheriff-bot was acting strange this afternoon.
56957         We don't know if this will fix the cause, but
56958         at least it adds some unit tests and catches
56959         one possible cause.
56960
56961         * Scripts/webkitpy/tool/bot/sheriffircbot.py:
56962         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
56963
56964 2011-06-22  Mark Rowe  <mrowe@apple.com>
56965
56966         Reviewed by David Levin.
56967
56968         <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
56969
56970         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
56971         be relative to the built products directory rather than using a hard-coded path. Remove the
56972         explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
56973         as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
56974         rather than in the .xcodeproj directly.
56975
56976 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
56977
56978         Reviewed by Ojan Vafai.
56979
56980         new-run-webkit-tests: remove obsolete port.shut_down_http_server method
56981         https://bugs.webkit.org/show_bug.cgi?id=59993
56982
56983         * Scripts/webkitpy/layout_tests/port/base.py:
56984         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
56985         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
56986         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
56987         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
56988         * Scripts/webkitpy/layout_tests/port/gtk.py:
56989         * Scripts/webkitpy/layout_tests/port/mac.py:
56990         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
56991         * Scripts/webkitpy/layout_tests/port/qt.py:
56992         * Scripts/webkitpy/layout_tests/port/win.py:
56993
56994 2011-06-22  Luke Macpherson   <macpherson@chromium.org>
56995
56996         Reviewed by Andreas Kling.
56997
56998         Move macpherson from contributor list to committer list.
56999         https://bugs.webkit.org/show_bug.cgi?id=63179
57000
57001         * Scripts/webkitpy/common/config/committers.py:
57002         Move macpherson from contributor list to committer list.
57003
57004 2011-06-22  David Levin  <levin@chromium.org>
57005
57006         Reviewed by Adam Barth.
57007
57008         check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
57009         https://bugs.webkit.org/show_bug.cgi?id=63204
57010
57011         * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
57012           with similar code for the parameter checking.
57013         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
57014           those done for single lines since they don't make sense in that case (variable decls look like function decls).
57015           Removed some redundant comments (one of which was slightly wrong).
57016           Added checks for the new functionality and minor other test changes.
57017
57018 2011-06-22  Nate Chapin  <japhet@chromium.org>
57019
57020         Reviewed by Adam Barth.
57021
57022         Add libsoup to libWebCoreInternals build.
57023         https://bugs.webkit.org/show_bug.cgi?id=62066
57024
57025         * GNUmakefile.am:
57026
57027 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
57028
57029         Reviewed by Tony Chang.
57030
57031         nrwt: handle missing httpd cleanly
57032         https://bugs.webkit.org/show_bug.cgi?id=62027
57033
57034         We had reverted the change in r89414, so this adds it back in
57035         (modifying check_sys_deps() in port/base.py to check for an
57036         installed web server).
57037
57038         This change then fixes the change in r89414 to stub out the
57039         check_sys_deps() in the test port so that the unit tests run correctly.
57040
57041         * Scripts/webkitpy/layout_tests/port/base.py:
57042         * Scripts/webkitpy/layout_tests/port/test.py:
57043
57044 2011-06-22  David Levin  <levin@chromium.org>
57045
57046         Reviewed by Adam Barth.
57047
57048         check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
57049         https://bugs.webkit.org/show_bug.cgi?id=63188
57050
57051         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
57052         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
57053
57054 2011-06-22  Tony Chang  <tony@chromium.org>
57055
57056         Reviewed by Ojan Vafai.
57057
57058         Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
57059         https://bugs.webkit.org/show_bug.cgi?id=62891
57060
57061         * BuildSlaveSupport/build.webkit.org-config/config.json:
57062
57063 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
57064
57065         Reviewed by Ojan Vafai.
57066
57067         nrwt: don't look for http lock when running the test port
57068         https://bugs.webkit.org/show_bug.cgi?id=63158
57069
57070         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
57071         * Scripts/webkitpy/layout_tests/port/test.py:
57072
57073 2011-06-22  Balazs Kelemen  <kbalazs@webkit.org>
57074
57075         Reviewed by Andreas Kling.
57076
57077         [Qt][WK2] Set up plugin tests
57078         https://bugs.webkit.org/show_bug.cgi?id=63066
57079
57080         * WebKitTestRunner/qt/TestControllerQt.cpp:
57081         (WTR::TestController::initializeTestPluginDirectory):
57082         Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
57083         of the test plugin like DRT does.
57084
57085 2011-06-22  Eric Seidel  <eric@webkit.org>
57086
57087         Reviewed by Ojan Vafai.
57088
57089         Make sheriff-bot rollout messages a little nicer
57090         https://bugs.webkit.org/show_bug.cgi?id=63107
57091
57092         It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
57093         into urls myself.  So I have now fixed its "preparing" message to include a url.
57094
57095         I also figured that I should make the messages mention all of the responsible parties
57096         so that rollouts are never surprises.  If you're in the channel and were involved
57097         in a patch, you will see if someone is using sheriff-bot to rollout a patch.
57098
57099         As part of doing this I also changed (and tested) _parse_args to fail-fast
57100         when given invalid args.
57101
57102         * Scripts/webkitpy/tool/bot/irc_command.py:
57103         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
57104         * Scripts/webkitpy/tool/bot/sheriff.py:
57105         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
57106
57107 2011-06-22  Dirk Pranke  <dpranke@chromium.org>
57108
57109         Reviewed by Tony Chang.
57110
57111         run-webkit-websocketserver fails to stop websocket server
57112         https://bugs.webkit.org/show_bug.cgi?id=63123
57113
57114         There's a ten-character change in new-run-webkit-websocketserver
57115         that fixes the actual bug, and then we update the code in
57116         new-run-webkit-httpd to do the actual stop call, and add more tests
57117         (refactoring the existing test code so that it is shared).
57118
57119         * Scripts/new-run-webkit-httpd:
57120         * Scripts/new-run-webkit-websocketserver:
57121         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
57122
57123 2011-06-22  Adam Roben  <aroben@apple.com>
57124
57125         Add links to existing bugs related to failing tests on TestFailures page
57126
57127         I changed the layout of the page a little to make it easier to read with all the new
57128         information. Passing/failing revisions have been moved down below the list of tests to be
57129         closer to the existing bugs and the new bug link. And each set of tests and its relevant
57130         information is in a light gray box.
57131
57132         Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
57133         possible
57134
57135         Reviewed by Darin Adler.
57136
57137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
57138         (Bugzilla): This new class represents a single Bugzilla instance.
57139         (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
57140         passing the resulting bug titles and URLs to the callback when complete. If called multiple
57141         times with the same query before the query returns, caches the callbacks so that only one
57142         query is sent over the wire. When the query completes, all pending callbacks are called.
57143
57144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
57145         (#failure-history): Reduce the margin/padding on the top-level list a bit.
57146         (#failure-history > li): Put each set of tests in a gray box, and indent most information
57147         inside the box.
57148         (.test-list): Unindent the list of failing tests so it is visually at the top level.
57149         (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
57150         each box isn't a big empty space.
57151         (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
57152         quite long.
57153
57154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
57155         (addQueryParametersToURL): New function extracted from
57156         ViewController.prototype._domForNewAndExistingBugs.
57157
57158         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
57159         (ViewController): Take and store an optional Bugzilla instance.
57160         (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
57161         purposes and move the list of failing tests above all other information. Only show bug
57162         information once we've determined the most-recent passing revision for a set of tests. It's
57163         not that useful to file a new bug before this information has been determined, and searching
57164         for existing bugs before we've figured out which tests started failing at the same time
57165         would end up giving you information about a bunch of unrelated tests.
57166         (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
57167         returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
57168         instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
57169         failing tests, and adds links to the bugs when the search completes.
57170
57171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
57172         Bugzilla instance for bugs.webkit.org to the ViewController.
57173
57174 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
57175
57176         Reviewed by Martin Robinson.
57177
57178         [GTK] Apply current view settings to newly created views in GtkLauncher
57179         https://bugs.webkit.org/show_bug.cgi?id=63142
57180
57181         * GtkLauncher/main.c:
57182         (createWebViewCb):
57183
57184 2011-06-22  Carlos Garcia Campos  <cgarcia@igalia.com>
57185
57186         Reviewed by Martin Robinson.
57187
57188         [GTK] Use GOption to parse main arguments in GtkLauncher
57189         https://bugs.webkit.org/show_bug.cgi?id=63060
57190
57191         Instead of getting the settings from the view, create a new
57192         settings object not associated with any view so that we can parse
57193         the command line arguments before creating the view. It will also
57194         allows to use the same settings for more than one view if we
57195         eventually support passing more than one uri from the command
57196         line.
57197
57198         * GtkLauncher/main.c:
57199         (parseOptionEntryCallback): Make this function static. Also use
57200         g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
57201         of atoi/atof to provide better error messages. And always fill the
57202         error struct when the function fails.
57203         (getOptionEntriesFromWebKitWebSettings): Use an array of
57204         GOptionEntry structs instead of a GArray, since that is what
57205         g_option_group_add_entries() expects and the array size doesn't
57206         change.
57207         (addWebSettingsGroupToContext): Helper function to add the
57208         websettings group to the option context.
57209         (main): Create the option context to parse command line arguments.
57210
57211 2011-06-22  Martin Robinson  <mrobinson@igalia.com>
57212
57213         Reviewed by Adam Roben.
57214
57215         [GTK] Implement pixel dump support for WebKitTestRunner
57216         https://bugs.webkit.org/show_bug.cgi?id=58242
57217
57218         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
57219         * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
57220         * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
57221         * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
57222         * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
57223         file so that we can share it across platforms.
57224         (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
57225         * WebKitTestRunner/TestInvocation.h: Updated method list.
57226         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
57227         * WebKitTestRunner/cg/TestInvocationCG.cpp:
57228         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
57229
57230 2011-06-22  Sheriff Bot  <webkit.review.bot@gmail.com>
57231
57232         Unreviewed, rolling out r89414.
57233         http://trac.webkit.org/changeset/89414
57234         https://bugs.webkit.org/show_bug.cgi?id=63130
57235
57236         It broke webkitpy tests (Requested by Ossy on #webkit).
57237
57238         * Scripts/webkitpy/layout_tests/port/base.py:
57239
57240 2011-06-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
57241
57242         Reviewed by Dirk Pranke.
57243
57244         [NRWT] Print error message when there is no httpd present on the system
57245         https://bugs.webkit.org/show_bug.cgi?id=62027
57246
57247         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57248
57249 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
57250
57251         Unreviewed, build fix.
57252         Fix crashes in new-run-webkit-tests resulting from the
57253         change to the http_server logic in r89400. Python 2.5
57254         on Mac 10.5 has some weird error paths.
57255
57256         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57257         * Scripts/webkitpy/common/system/executive.py:
57258
57259 2011-06-21  MORITA Hajime  <morrita@google.com>
57260
57261         Unreviewed, rolling out r89401 and r89403.
57262         http://trac.webkit.org/changeset/89401
57263         http://trac.webkit.org/changeset/89403
57264         https://bugs.webkit.org/show_bug.cgi?id=62970
57265
57266         Breaks mac build and mistakenly enables the spellcheck API
57267
57268         * Scripts/build-webkit:
57269         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
57270
57271 2011-06-21  Kent Tamura  <tkent@chromium.org>
57272
57273         [Mac] Sort Xcode project files.
57274
57275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
57276
57277 2011-06-20  MORITA Hajime  <morrita@google.com>
57278
57279         Reviewed by Kent Tamura.
57280
57281         Spellcheck API should be build-able.
57282         https://bugs.webkit.org/show_bug.cgi?id=62970
57283
57284         * Scripts/build-webkit:
57285
57286 2011-06-21  Dirk Pranke  <dpranke@chromium.org>
57287
57288         Reviewed by Tony Chang.
57289
57290         nrwt: attempt #3 at fixing server startup/shutdown
57291         https://bugs.webkit.org/show_bug.cgi?id=62829
57292
57293         Attempt yet again to make starting and stopping servers
57294         reliable. It turns out that apache has races between when the
57295         ctl process exists and when it writes/removes the pid file.
57296         This change accounts for the races.
57297
57298         * Scripts/new-run-webkit-httpd:
57299         * Scripts/webkitpy/common/system/executive.py:
57300         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57301         * Scripts/webkitpy/layout_tests/port/base.py:
57302         * Scripts/webkitpy/layout_tests/port/http_server.py:
57303         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57304         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
57305         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
57306         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57307
57308 2011-06-21  Dmitry Lomov  <dslomov@google.com>
57309
57310         Reviewed by Adam Roben.
57311
57312         https://bugs.webkit.org/show_bug.cgi?id=63080
57313         Unit-tests step on test-only bot is broken.
57314         Removing the step until run-api-tests is fixed.
57315
57316         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
57317
57318 2011-06-20  Dmitry Lomov  <dslomov@google.com>
57319
57320         Reviewed by David Levin.
57321
57322         https://bugs.webkit.org/show_bug.cgi?id=63017
57323         "Unit tests" step on bots should provide more information in case of failure.
57324
57325         * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
57326
57327 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
57328
57329         Reviewed by Ojan Vafai.
57330
57331         new-run-webkit-tests: order shards by name, not number of tests
57332         https://bugs.webkit.org/show_bug.cgi?id=62753
57333
57334         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
57335
57336 2011-06-20  Dirk Pranke  <dpranke@chromium.org>
57337
57338         Reviewed by Ojan Vafai.
57339
57340         we should only log the test names to the tests_run.txt files during layout_tests
57341         https://bugs.webkit.org/show_bug.cgi?id=62751
57342
57343         * Scripts/old-run-webkit-tests:
57344         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
57345
57346 2011-06-20  Eric Seidel  <eric@webkit.org>
57347
57348         Reviewed by Adam Barth.
57349
57350         commit-queue/ews-bots should run run-bindings-tests for every patch
57351         https://bugs.webkit.org/show_bug.cgi?id=63010
57352
57353         * Scripts/webkitpy/common/config/ports.py:
57354         * Scripts/webkitpy/tool/commands/download_unittest.py:
57355         * Scripts/webkitpy/tool/steps/runtests.py:
57356         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
57357         * Scripts/webkitpy/tool/steps/steps_unittest.py:
57358
57359 2011-06-20  Chang Shu  <cshu@webkit.org>
57360
57361         Reviewed by Adam Barth.
57362
57363         fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
57364         https://bugs.webkit.org/show_bug.cgi?id=53676
57365
57366         * WebKitTestRunner/TestController.cpp:
57367         (WTR::TestController::initialize):
57368
57369 2011-06-20  Eric Seidel  <eric@webkit.org>
57370
57371         Reviewed by Adam Barth.
57372
57373         buildbots should run run-bindings-tests
57374         https://bugs.webkit.org/show_bug.cgi?id=63001
57375
57376         run-bindings-tests takes 2.4 seconds on my machine, so
57377         I expect this will not be noticeable on the bots.
57378
57379         I also removed tiger-specific checks since Tiger is no
57380         longer a supported platform for webkit.
57381
57382         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
57383
57384 2011-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
57385
57386         Unreviewed. Fix WebKit2 GTK build after r89249.
57387
57388         * GtkLauncher/main.c:
57389         (main):
57390
57391 2011-06-20  Pavel Feldman  <pfeldman@chromium.org>
57392
57393         Reviewed by Yury Semikhatsky.
57394
57395         Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
57396         https://bugs.webkit.org/show_bug.cgi?id=62994
57397
57398         * DumpRenderTree/LayoutTestController.cpp:
57399         (closeWebInspectorCallback):
57400         (LayoutTestController::staticFunctions):
57401         * DumpRenderTree/LayoutTestController.h:
57402         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
57403         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
57404         * DumpRenderTree/chromium/LayoutTestController.cpp:
57405         (LayoutTestController::LayoutTestController):
57406         * DumpRenderTree/chromium/LayoutTestController.h:
57407         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
57408         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
57409         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
57410         * DumpRenderTree/qt/LayoutTestControllerQt.h:
57411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
57412         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
57413         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
57414         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
57415         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
57416
57417 2011-06-20  Lukasz Slachciak  <l.slachciak@samsung.com>
57418
57419         Reviewed by Martin Robinson.
57420
57421         [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
57422         https://bugs.webkit.org/show_bug.cgi?id=55308
57423
57424         * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
57425         (parseOptionEntryCallback): Callback for parsing option entry.
57426         (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
57427         list of option entries.
57428         (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
57429         (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
57430         (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
57431         (parseAdditionalOptions): Help function parsing additional commandline options.
57432         (main): Added call to parseAdditionalOptions.
57433
57434 2011-06-20  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
57435
57436         Reviewed by Andreas Kling.
57437
57438         [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
57439         https://bugs.webkit.org/show_bug.cgi?id=62869
57440
57441         Add QFont include to fix "incomlete type QFont" error.
57442
57443         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
57444
57445 2011-06-19  Adam Bergkvist  <adam.bergkvist@ericsson.com>
57446
57447         Reviewed by Martin Robinson.
57448
57449         [GTK] Enable Media Stream feature and make it default on
57450         https://bugs.webkit.org/show_bug.cgi?id=60394
57451
57452         * Scripts/build-webkit:
57453
57454 2011-06-19  Sheriff Bot  <webkit.review.bot@gmail.com>
57455
57456         Unreviewed, rolling out r89198.
57457         http://trac.webkit.org/changeset/89198
57458         https://bugs.webkit.org/show_bug.cgi?id=62953
57459
57460         Chromium breakage on "Linux Tests" (Requested by senorblanco
57461         on #webkit).
57462
57463         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
57464         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
57465         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
57466
57467 2011-06-18  Daniel Bates  <dbates@webkit.org>
57468
57469         Reviewed by Eric Seidel.
57470
57471         Git.push_local_commits_to_server() should use passed username and
57472         password when we don't have cached credentials
57473         https://bugs.webkit.org/show_bug.cgi?id=62941
57474
57475         Fixes a issue where Git.push_local_commits_to_server() would always look
57476         for cached credentials regardless of whether a username and password
57477         were passed as arguments. Instead, if given both a username and password
57478         then we shouldn't look for cached credentials (since we were explicitly given
57479         credentials).
57480
57481         * Scripts/webkitpy/common/checkout/scm/git.py:
57482         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
57483
57484 2011-06-18  Daniel Bates  <dbates@rim.com>
57485
57486         Rubber-stamped by Eric Seidel.
57487
57488         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
57489         https://bugs.webkit.org/show_bug.cgi?id=62767
57490
57491         Part 3 of 3
57492
57493         Remove the command-line option --skip-build now that the master BuildBot has been restarted
57494         following <http://trac.webkit.org/changeset/89138>.
57495
57496         Instead, specify --no-build to get analogous functionality.
57497
57498         * Scripts/run-javascriptcore-tests:
57499
57500 2011-06-18  Dirk Pranke  <dpranke@chromium.org>
57501
57502         Reviewed by Tony Chang.
57503
57504         new-run-webkit-tests: fix test sorting
57505         https://bugs.webkit.org/show_bug.cgi?id=58691
57506
57507         This changes the sorting to use a "natural" sort order such that
57508         foo2.html sorts before foo13.html, and sorts the tests so
57509         that all the tests in a directory are run before any test in a
57510         subdirectory.
57511
57512         This change also adds a split() method to the filesystem since
57513         that is needed to cluster files into a directory otherwise.
57514
57515         * Scripts/webkitpy/common/system/filesystem.py:
57516         * Scripts/webkitpy/common/system/filesystem_mock.py:
57517         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
57518         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
57519
57520 2011-06-18  Evan Martin  <evan@chromium.org>
57521
57522         Reviewed by Darin Adler.
57523
57524         Compiler warning in double->int conversion in TestNetscapePlugIn
57525         https://bugs.webkit.org/show_bug.cgi?id=51554
57526
57527         This code is providing a JS API for removing a property by numeric ID.
57528         We get it from JS as a double, and must convert it to an int before using it.
57529
57530         Test: LayoutTests/plugins/npruntime/remove-property.html
57531
57532         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
57533         (NPRuntimeRemoveProperty::TestObject::invoke):
57534
57535 2011-06-18  Patrick Gansterer  <paroga@webkit.org>
57536
57537         Reviewed by Eric Seidel.
57538
57539         Don't exit webkit-patch when running on Win32 python
57540         https://bugs.webkit.org/show_bug.cgi?id=55811
57541
57542         Most of the basic actions work in the meantime,
57543         so let people play with in on Win32 now.
57544
57545         * Scripts/webkit-patch:
57546
57547 2011-06-18  Alice Boxhall  <aboxhall@chromium.org>
57548
57549         Reviewed by Ojan Vafai.
57550
57551         Convert json_results_generator.py to output version 4 JSON.
57552         https://bugs.webkit.org/show_bug.cgi?id=60869
57553
57554         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
57555         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
57556         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
57557
57558 2011-06-18  Berend-Jan Wever  <skylined@chromium.org>
57559
57560         Reviewed by Eric Seidel.
57561
57562         Some names with spaces are incorrectly reported as not containing spaces
57563         while running prepare-ChangeLog
57564         https://bugs.webkit.org/show_bug.cgi?id=55572
57565
57566         * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
57567           non-alphanumeric characters in names.
57568
57569 2011-06-18  Michael Saboff  <msaboff@apple.com>
57570
57571         Reviewed by Eric Seidel.
57572
57573         Enhancement: New Script to Format malloc_history output as tree
57574         https://bugs.webkit.org/show_bug.cgi?id=56378
57575
57576         New script to process malloc_history output to tree format.
57577
57578         * Scripts/malloc-tree: Added.
57579
57580 2011-06-17  Dmitry Lomov  <dslomov@google.com>
57581
57582         Reviewed by Daniel Bates.
57583
57584         https://bugs.webkit.org/show_bug.cgi?id=62918
57585         Pass configuration to UnitTests step in master.cfg
57586
57587         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
57588
57589 2011-06-17  Leandro Pereira  <leandro@profusion.mobi>
57590
57591         Reviewed by Eric Seidel.
57592
57593         [EFL] Add Evas-based ImageDiff implementation.
57594         https://bugs.webkit.org/show_bug.cgi?id=61942
57595
57596         Build system changes will be performed as soon as the complete
57597         DumpRenderTree implementation is upstreamed.
57598
57599         * DumpRenderTree/efl/ImageDiff.cpp: Added.
57600         (pixelFromImageData):
57601         (differenceImageFromDifferenceBuffer):
57602         (computeDistanceBetweenPixelComponents):
57603         (calculatePixelDifference):
57604         (calculateDifference):
57605         (getTemporaryFile):
57606         (printImage):
57607         (printImageDifferences):
57608         (resizeEcoreEvasIfNeeded):
57609         (readImageFromStdin):
57610         (parseCommandLineOptions):
57611         (shutdownEfl):
57612         (abortWithErrorMessage):
57613         (initEfl):
57614         (main):
57615
57616 2011-06-17  Tony Chang  <tony@chromium.org>
57617
57618         Reviewed by Dirk Pranke.
57619
57620         [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
57621         https://bugs.webkit.org/show_bug.cgi?id=62907
57622
57623         This fixes a bug where the ImageDiff on the user's machine doesn't
57624         match the logic used on the Chromium buildbots.  This has the downside
57625         of requiring that the Chromium ImageDiff is built, but it turns out
57626         that even with --tolerance 0, the CG ImageDiff will allow small pixel
57627         differences through.
57628
57629         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
57630
57631 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
57632
57633         [WinCairo] Unreviewed build correction.
57634
57635         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
57636         Update WinCairo property sheet to link against the Cairo DLL,
57637         now that we are using a more recent Cairo build.
57638
57639 2011-06-17  Brent Fulgham  <bfulgham@webkit.org>
57640
57641         Reviewed by Brian Weinstein.
57642
57643         Create a simple example of using the COM-based C++ listeners.
57644         A new onclick event is attached (via C++) to the WebKit logo
57645         in the default test pattern displayed on startup.  Clicking on
57646         the logo causes a message box to be displayed.
57647         https://bugs.webkit.org/show_bug.cgi?id=61885
57648
57649         * WinLauncher/DOMDefaultImpl.h: Added.  Stub implementation of
57650           the WebScriptObject and DOMEventListener.
57651         * WinLauncher/WinLauncher.cpp:
57652         (SimpleEventListener::SimpleEventListener): Example implementation
57653           of a simple DOM event listener.
57654         (SimpleEventListener::handleEvent):
57655         (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
57656          to bind a C++ method to the 'onclick' event for the WebKit logo.
57657         (_tWinMain):
57658         * WinLauncher/WinLauncher.h:
57659         * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
57660
57661 2011-06-17  Chang Shu  <cshu@webkit.org>
57662
57663         Reviewed by Andreas Kling.
57664
57665         [Qt] [WK2] Support undo/redo in MiniBrowser
57666         https://bugs.webkit.org/show_bug.cgi?id=62809
57667
57668         * MiniBrowser/qt/BrowserWindow.cpp:
57669         (BrowserWindow::BrowserWindow):
57670
57671 2011-06-17  Daniel Bates  <dbates@rim.com>
57672
57673         Rubber-stamped by Eric Seidel.
57674
57675         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
57676         https://bugs.webkit.org/show_bug.cgi?id=62767
57677
57678         Part 2 of 3
57679
57680         Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
57681         command line option instead of --skip-build.
57682
57683         We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
57684         master buildbot picks up the change.
57685
57686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
57687
57688 2011-06-17  Daniel Bates  <dbates@rim.com>
57689
57690         Rubber-stamped by Eric Seidel.
57691
57692         Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
57693         https://bugs.webkit.org/show_bug.cgi?id=62767
57694
57695         Part 1 of 3
57696
57697         Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
57698         run-javascriptcore-tests. Also, add a remark about these options to the usage message
57699         printed by run-javascriptcore-tests.
57700
57701         We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
57702
57703         * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
57704           of $showHelp.
57705
57706 2011-06-17  Joone Hur  <joone.hur@collabora.co.uk>
57707
57708         Reviewed by Martin Robinson.
57709
57710         [GTK] Replace GdkRectangle by cairo_rectangle_int_t
57711         https://bugs.webkit.org/show_bug.cgi?id=60687
57712
57713         Replace GdkRectangle by cairo_rectangle_int_t.
57714
57715         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
57716         (createBitmapContextFromWebView):
57717         * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
57718         (firstRectForCharacterRangeCallback):
57719
57720 2011-06-16  Dmitry Lomov  <dslomov@google.com>
57721
57722         Reviewed by David Levin.
57723
57724         https://bugs.webkit.org/show_bug.cgi?id=62603
57725         Run run-api-tests on bots in debug mode.
57726         Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
57727
57728         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
57729
57730 2011-06-16  Leandro Pereira  <leandro@profusion.mobi>
57731
57732         Reviewed by Eric Seidel.
57733
57734         [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
57735         WorkQueueItem.
57736         They will be plugged into the build system once the EFL's DRT is
57737         fully upstreamed.
57738         https://bugs.webkit.org/show_bug.cgi?id=61958
57739
57740         * DumpRenderTree/efl: Added.
57741         * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
57742         (GCController::collect):
57743         (GCController::collectOnAlternateThread):
57744         (GCController::getJSObjectCount):
57745         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
57746         (createBitmapContextFromWebView):
57747         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
57748         (LoadItem::invoke):
57749         (LoadHTMLStringItem::invoke):
57750         (ReloadItem::invoke):
57751         (ScriptItem::invoke):
57752         (BackForwardItem::invoke):
57753         * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
57754         (WorkQueueItem::~WorkQueueItem):
57755         (LoadItem::LoadItem):
57756         (LoadHTMLStringItem::LoadHTMLStringItem):
57757         (ScriptItem::ScriptItem):
57758         (LoadingScriptItem::LoadingScriptItem):
57759         (LoadingScriptItem::invoke):
57760         (NonLoadingScriptItem::NonLoadingScriptItem):
57761         (NonLoadingScriptItem::invoke):
57762         (BackForwardItem::BackForwardItem):
57763         (BackItem::BackItem):
57764         (ForwardItem::ForwardItem):
57765
57766 2011-06-16  Kevin Ollivier  <kevino@theolliviers.com>
57767
57768         [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
57769         preference like the perl scripts do.
57770
57771         * waf/build/build_utils.py:
57772         * waf/build/settings.py:
57773
57774 2011-06-16  Tommy Widenflycht  <tommyw@google.com>
57775
57776         Reviewed by Tony Gentilcore.
57777
57778         MediaStream API: Runtime enabled features
57779         https://bugs.webkit.org/show_bug.cgi?id=62798
57780
57781         Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
57782
57783         * DumpRenderTree/chromium/TestShell.cpp:
57784         (TestShell::TestShell):
57785
57786 2011-06-16  Torsten Kurbad  <gentoo@tk-webart.de>
57787
57788         Reviewed by Eric Seidel.
57789
57790         Add support for sys.platform == 'linux3' by relaxing
57791         conditional statements and/or extending lookup dicts.
57792         This way, Linux kernels >=3.0-rc1 get supported in the
57793         build process.
57794         https://bugs.webkit.org/show_bug.cgi?id=62730
57795
57796         * Scripts/webkitpy/common/system/executive.py:
57797         * Scripts/webkitpy/common/system/file_lock.py:
57798         * Scripts/webkitpy/common/system/path_unittest.py:
57799         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
57800         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
57801         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
57802         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
57803         * Scripts/webkitpy/layout_tests/port/factory.py:
57804         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
57805         * Scripts/webkitpy/layout_tests/port/qt.py:
57806         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
57807
57808 2011-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
57809
57810         Unreviewed, rolling out r88796.
57811         http://trac.webkit.org/changeset/88796
57812         https://bugs.webkit.org/show_bug.cgi?id=62790
57813
57814         It made fast/dom/nodesFromRect-basic.html time out on Qt,
57815         64-bit, debug mode (Requested by Ossy on #webkit).
57816
57817         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
57818         (LayoutTestController::nodesFromRect):
57819         * DumpRenderTree/qt/LayoutTestControllerQt.h:
57820         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
57821         (PlainTextController::plainText):
57822         * DumpRenderTree/qt/PlainTextControllerQt.h:
57823
57824 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57825
57826         Unreviewed, build fix.
57827
57828         Revert the patches in r88995 and r88999; the http servers don't
57829         seem to be shutting down reliably.
57830
57831         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57832         * Scripts/webkitpy/layout_tests/port/base.py:
57833         * Scripts/webkitpy/layout_tests/port/http_server.py:
57834         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57835         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
57836         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
57837         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57838
57839 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57840
57841         Unreviewed, build fix.
57842
57843         Add some debugging messages to triage problems introduced in
57844         r88995.
57845
57846         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57847
57848 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57849
57850         Reviewed by Tony Chang.
57851
57852         nrwt: should clean up stale server processes from a previous run
57853         https://bugs.webkit.org/show_bug.cgi?id=62615
57854
57855         This change fixes cases where NRWT might start a server and then
57856         exit, leaving the server still running. Now NRWT should detect
57857         this case and clean up on the next run, without shutting down
57858         any processes it didn't start.
57859
57860         This change also fixes a bug in executive.kill_process on UNIX
57861         where zombies weren't being handled properly.
57862
57863         * Scripts/webkitpy/common/system/executive.py:
57864         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57865         * Scripts/webkitpy/layout_tests/port/base.py:
57866         * Scripts/webkitpy/layout_tests/port/http_server.py:
57867         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57868         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
57869         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57870
57871 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57872
57873         Reviewed by Tony Chang.
57874
57875         nrwt: fix http, websocket server startup, shutdown
57876         https://bugs.webkit.org/show_bug.cgi?id=62180
57877
57878         This change refactors all of the server-related code to
57879         have consistent semantics. It pushes the start()/stop()
57880         logic into the base class and adds four much smaller routines
57881         for specialization:
57882         _prepare_config() - for optionally writing config files etc.
57883             to disk prior to starting the server
57884         _remove_stale_log_files()
57885         _spawn_process() - the actual launch of the subprocess
57886         _cleanup_after_stop() - and custom cleanup code
57887
57888         Prior to this change the three server implementations were
57889         fairly inconsistent, leading to lots of weirdness on the bots
57890         with servers being left around, etc.
57891
57892         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57893         * Scripts/webkitpy/layout_tests/port/http_server.py:
57894         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57895         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57896
57897 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57898
57899         Reviewed by Tony Chang.
57900
57901         webkitpy: clean up code prior to functional changes for server startup/shutdown
57902         https://bugs.webkit.org/show_bug.cgi?id=62256
57903
57904         This patch does a bunch of minor cleanup of the code, but there
57905         should be no functional changes except that all of the modules
57906         will now use the same exception type. Other changes include
57907         removing unused code paths and functions, pushing 'name' and
57908         'pid_file' into the base class of the server objects, and using
57909         the Filesystem object instead of the codecs, tempfile, and
57910         shutils modules.
57911
57912         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57913         * Scripts/webkitpy/layout_tests/port/http_server.py:
57914         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
57915         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57916
57917 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57918
57919         Reviewed by Tony Chang.
57920
57921         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
57922         https://bugs.webkit.org/show_bug.cgi?id=62251
57923
57924         shut_down_http_server() was a total hack that was only used by
57925         new-run-webkit-httpd, so I've moved the code there and switched
57926         to using executive.kill_process() for the common case. The
57927         method itself will be removed in the patch on bug 59993.
57928
57929         * Scripts/new-run-webkit-httpd:
57930         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
57931         * Scripts/webkitpy/layout_tests/port/http_server.py:
57932         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
57933         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
57934
57935 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57936
57937         Unreviewed, build fix.
57938
57939         Fix test-webkitpy failure introduced in r88986.
57940
57941         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
57942
57943 2011-06-15  Dirk Pranke  <dpranke@chromium.org>
57944
57945         Reviewed by Eric Seidel.
57946
57947         NRWT: doesn't support webarchives, has stale skipping logic.
57948         https://bugs.webkit.org/show_bug.cgi?id=58293
57949
57950         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
57951         * Scripts/webkitpy/layout_tests/port/base.py:
57952         * Scripts/webkitpy/layout_tests/port/webkit.py:
57953
57954 2011-06-15  Jeremy Orlow  <jorlow@webkit.org>
57955
57956         Change my email to @webkit.org
57957
57958         * Scripts/webkitpy/common/config/committers.py:
57959
57960 2011-06-15  Nikolas Zimmermann  <nzimmermann@rim.com>
57961
57962         Reviewed by David Hyatt.
57963
57964         CSS 2.1: Support replaced elements with relative intrinsic sizes
57965         https://bugs.webkit.org/show_bug.cgi?id=15849
57966
57967         CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
57968         https://bugs.webkit.org/show_bug.cgi?id=53099
57969
57970         Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
57971
57972         * Scripts/old-run-webkit-tests:
57973         * Scripts/webkitpy/layout_tests/port/test_files.py:
57974
57975 2011-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
57976
57977         Reviewed by Martin Robinson.
57978
57979         [GTK] Add a statusbar to MiniBrowser
57980         https://bugs.webkit.org/show_bug.cgi?id=62634
57981
57982         It shows the url of the current hovered link.
57983
57984         * MiniBrowser/gtk/BrowserWindow.c:
57985         (browserWindowConstructed): Create the GtkSatusbar.
57986         (mouseDidMoveOverElement): Update statusbar text.
57987         (browserWindowUIClientInit): Add implementation for
57988         mouseDidMoveOverElement().
57989         * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
57990         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
57991         (mouseDidMoveOverElement): Pass the url of the current hovered
57992         link to the UI process.
57993         (didCreatePage): Set the UI client adding an implementation for
57994         mouseDidMoveOverElement().
57995         (WKBundleInitialize):
57996         * MiniBrowser/gtk/main.c:
57997         (createWKContextWithInjectedBundle): Create a global context with
57998         the injected bundle.
57999         (loadURI): Use the global context.
58000         (main):
58001
58002 2011-06-14  Lucas Forschler  <lforschler@apple.com>
58003
58004         Reviewed by Stephanie Lewis.
58005
58006         https://bugs.webkit.org/show_bug.cgi?id=62495
58007         Bug 62495 - combine windows and mac kill-old-processes script
58008         Add a platform agnostic script.  Remove the recently added mac flavor.
58009         Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
58010
58011         * BuildSlaveSupport/kill-old-processes: Added.
58012         * BuildSlaveSupport/mac: Removed.
58013         * BuildSlaveSupport/mac/kill-old-processes: Removed.
58014
58015 2011-06-14  Dirk Pranke  <dpranke@chromium.org>
58016
58017         Reviewed by Tony Chang.
58018
58019         nrwt: handle worker exceptions cleanly
58020         https://bugs.webkit.org/show_bug.cgi?id=62614
58021
58022         This change modifiers new-run-webkit-tests to handle exceptions
58023         raised by worker threads better, by:
58024         - capturing the worker's stack and logging it in the manager
58025         - propagating the worker's exception in the caller correctly
58026         - attempting to cancel the workers and clean up even when
58027           we get an unexpected exception
58028
58029         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
58030         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
58031         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
58032         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
58033
58034 2011-06-14  Qi Zhang  <qi.2.zhang@nokia.com>
58035
58036         Reviewed by Laszlo Gombos.
58037
58038         [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
58039         https://bugs.webkit.org/show_bug.cgi?id=62227
58040
58041         QtWebkit does not yet support different CacheModels. This change will
58042         expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
58043
58044         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
58045         (LayoutTestController::setCacheModel):
58046         * DumpRenderTree/qt/LayoutTestControllerQt.h:
58047
58048 2011-06-14  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
58049
58050         Reviewed by Andreas Kling.
58051
58052         [Qt] tst_QWebFrame::overloadedSlots() fails
58053         https://bugs.webkit.org/show_bug.cgi?id=37319
58054
58055         Since we don't implictly convert 'document' object to QWebElement
58056         in metacalls anymore, change the controller to expect QVariantMap instead.
58057
58058         The method plainText() was updated to use QVariantMap as well to let the bridge
58059         do the conversion directly for us.
58060
58061         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
58062         (LayoutTestController::nodesFromRect):
58063         * DumpRenderTree/qt/LayoutTestControllerQt.h:
58064         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
58065         (PlainTextController::plainText):
58066         * DumpRenderTree/qt/PlainTextControllerQt.h:
58067
58068 2011-06-14  Andras Becsi  <abecsi@webkit.org>
58069
58070         Reviewed by Csaba Osztrogonác.
58071
58072         Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
58073         https://bugs.webkit.org/show_bug.cgi?id=62630
58074
58075         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
58076         (NPP_New): remove dead variable 'forceCarbon'
58077
58078 2011-06-13  Hayato Ito  <hayato@chromium.org>
58079
58080         Reviewed by Ojan Vafai.
58081
58082         [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
58083         https://bugs.webkit.org/show_bug.cgi?id=59188
58084
58085         A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
58086         WebKitDriver should always return an actual hash value if DRT returns that.
58087
58088         No tests since I'll add sample reftests to make sure mismatch reftests work later,
58089         which should be in a separate patch.
58090
58091         * Scripts/webkitpy/layout_tests/port/webkit.py:
58092
58093 2011-06-13  Kent Tamura  <tkent@chromium.org>
58094
58095         [Chromium-win] Fix two wrong assertions exposed by r88757.
58096
58097         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
58098         (WebThemeEngineDRTWin::paintTrackbar):
58099
58100 2011-06-13  Alexey Proskuryakov  <ap@apple.com>
58101
58102         Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
58103         and commit queue happy.
58104
58105         * Scripts/webkitpy/common/config/committers.py:
58106
58107 2011-06-13  Chris Rogers  <crogers@google.com>
58108
58109         Unreviewed build fix.
58110
58111         Build fix to chromium DRT until we can rebaseline some tests
58112         https://bugs.webkit.org/show_bug.cgi?id=62608
58113
58114         * DumpRenderTree/chromium/TestShell.cpp:
58115         (TestShell::TestShell):
58116
58117 2011-06-13  Chris Rogers  <crogers@google.com>
58118
58119         Reviewed by Dirk Pranke.
58120
58121         Add Web Audio support to chromium DRT
58122         https://bugs.webkit.org/show_bug.cgi?id=62306
58123
58124         * DumpRenderTree/chromium/LayoutTestController.cpp:
58125         (LayoutTestController::LayoutTestController):
58126         (LayoutTestController::reset):
58127         (LayoutTestController::setEncodedAudioData):
58128         * DumpRenderTree/chromium/LayoutTestController.h:
58129         (LayoutTestController::encodedAudioData):
58130         (LayoutTestController::shouldDumpAsAudio):
58131         (LayoutTestController::setShouldDumpAsAudio):
58132         * DumpRenderTree/chromium/TestEventPrinter.cpp:
58133         (DRTPrinter::handleAudioHeader):
58134         (TestShellPrinter::handleAudioHeader):
58135         * DumpRenderTree/chromium/TestEventPrinter.h:
58136         * DumpRenderTree/chromium/TestShell.cpp:
58137         (TestShell::TestShell):
58138         (TestShell::dump):
58139
58140 2011-06-13  Jaehun Lim  <ljaehun.lim@samsung.com>
58141
58142         Reviewed by Eric Seidel.
58143
58144         [EFL] Add load error handler to EWebLauncher
58145         https://bugs.webkit.org/show_bug.cgi?id=62347
58146
58147         Add a handler function of "load,error" to EWebLauncher.
58148         EWebLauncher now displays a simple error page on load errors.
58149
58150         * EWebLauncher/main.c:
58151         (on_load_error):
58152         (browserCreate):
58153
58154 2011-06-13  Martin Robinson  <mrobinson@igalia.com>
58155
58156         Reviewed by Eric Seidel.
58157
58158         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
58159         https://bugs.webkit.org/show_bug.cgi?id=62385
58160
58161         Remove duplicate TestNetscapePlugIn implementation. Having two copies
58162         of this code makes keeping it in sync much more difficult. The files are
58163         almost identical and this change ports the X11 changes to main.cpp.
58164
58165         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
58166         (NPP_New): Do not set the plugin as windowless always. Doing this breaks
58167         some results on Qt and this seems to be unnecessary for the moment.
58168         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
58169         (handleEventX11): Use the handler to properly convert the keycode. Do not print
58170         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
58171         it should not be in the results.
58172         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
58173         XP_UNIX block is first by guarding against using a null instance.
58174         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
58175         the XP_UNIX define for Linux.
58176         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
58177         * GNUmakefile.am: Update source list.
58178
58179 2011-06-13  Sheriff Bot  <webkit.review.bot@gmail.com>
58180
58181         Unreviewed, rolling out r88671.
58182         http://trac.webkit.org/changeset/88671
58183         https://bugs.webkit.org/show_bug.cgi?id=62591
58184
58185         "didn't work" (Requested by dpranke on #webkit).
58186
58187         * Scripts/new-run-webkit-httpd:
58188         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
58189         * Scripts/webkitpy/layout_tests/port/http_server.py:
58190         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
58191         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
58192         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
58193         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
58194
58195 2011-06-13  Nate Chapin  <japhet@chromium.org>
58196
58197         Reviewed by Darin Fisher.
58198
58199         New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
58200
58201         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
58202
58203 2011-06-13  Dirk Pranke  <dpranke@chromium.org>
58204
58205         Reviewed by Tony Chang.
58206
58207         webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
58208         https://bugs.webkit.org/show_bug.cgi?id=62251
58209
58210         shut_down_http_server() was a total hack that was only used by
58211         new-run-webkit-httpd, so I've moved the code there and switched
58212         to using executive.kill_process() for the common case. The
58213         method itself will be removed in the patch on bug 59993.
58214
58215         * Scripts/new-run-webkit-httpd:
58216         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
58217         * Scripts/webkitpy/layout_tests/port/http_server.py:
58218         * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
58219         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
58220
58221 2011-06-13  Tony Chang  <tony@chromium.org>
58222
58223         Reviewed by Dimitri Glazkov.
58224
58225         rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
58226         https://bugs.webkit.org/show_bug.cgi?id=62578
58227
58228         * Scripts/build-webkit:
58229
58230 2011-06-13  Tony Chang  <tony@chromium.org>
58231
58232         Reviewed by Adam Barth.
58233
58234         rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
58235         https://bugs.webkit.org/show_bug.cgi?id=62545
58236
58237         * Scripts/build-webkit:
58238
58239 2011-06-13  Carlos Garcia Campos  <cgarcia@igalia.com>
58240
58241         Reviewed by Martin Robinson.
58242
58243         [GTK] Export an API similar to WebKit1
58244         https://bugs.webkit.org/show_bug.cgi?id=57820
58245
58246         Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
58247         code, but linking to libwebkit2gtk.
58248
58249         * GNUmakefile.am:
58250         * GtkLauncher/main.c:
58251         (createBrowser):
58252         (main):
58253
58254 2011-06-12  MORITA Hajime  <morrita@google.com>
58255
58256         Unreviewed, rolling out r88625.
58257         http://trac.webkit.org/changeset/88625
58258         https://bugs.webkit.org/show_bug.cgi?id=61073
58259
58260         Breaks SL Webkit2 Tests
58261
58262         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
58263         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
58264         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
58265         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
58266         (WTR::InjectedBundlePage::didClearWindowForFrame):
58267         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
58268
58269 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
58270
58271         Reviewed by Antonio Gomes.
58272
58273         [Qt] LayoutTestController needs setTextDirection implementation
58274         https://bugs.webkit.org/show_bug.cgi?id=62442
58275
58276         Implements LayoutController.setTextDirection.
58277
58278         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
58279         (LayoutTestController::setTextDirection):
58280         * DumpRenderTree/qt/LayoutTestControllerQt.h:
58281
58282 2011-06-12  Dominic Cooney  <dominicc@chromium.org>
58283
58284         Reviewed by Hajime Morita.
58285
58286         Add window.internals to WebKit2's WebKitTestRunner.
58287         https://bugs.webkit.org/show_bug.cgi?id=61073
58288
58289         Test: fast/harness/internals-object.html
58290
58291         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
58292         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
58293         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
58294         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
58295         (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
58296         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
58297
58298 2011-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>
58299
58300         Unreviewed, rolling out r88616.
58301         http://trac.webkit.org/changeset/88616
58302         https://bugs.webkit.org/show_bug.cgi?id=62517
58303
58304         It broke editing/text-iterator/findString.html (Requested by
58305         tonikitoo on #webkit).
58306
58307         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
58308         * DumpRenderTree/qt/LayoutTestControllerQt.h:
58309
58310 2011-06-12  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
58311
58312         Reviewed by Antonio Gomes.
58313
58314         [Qt] LayoutTestController needs setTextDirection implementation
58315         https://bugs.webkit.org/show_bug.cgi?id=62442
58316
58317         Implements LayoutController.setTextDirection.
58318
58319         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
58320         (LayoutTestController::setTextDirection):
58321         * DumpRenderTree/qt/LayoutTestControllerQt.h:
58322
58323 2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>
58324
58325         Reviewed by Ojan Vafai.
58326
58327         new-run-webkit-tests: 'images' links on results.html don't work
58328         https://bugs.webkit.org/show_bug.cgi?id=62194
58329
58330         Use relative path when generating images-diffs.html
58331
58332         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
58333         Added _output_testname.
58334
58335 2011-06-10  Lucas Forschler  <lforschler@apple.com>
58336
58337         Reviewed by Stephanie Lewis.
58338
58339         Script to kill old processes on Mac.
58340         This matches the windows version.
58341         https://bugs.webkit.org/show_bug.cgi?id=62479
58342
58343         * BuildSlaveSupport/mac: Added.
58344         * BuildSlaveSupport/mac/kill-old-processes: Added.
58345
58346 2011-06-10  Adam Barth  <abarth@webkit.org>
58347
58348         Reviewed by James Robinson.
58349
58350         When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
58351         https://bugs.webkit.org/show_bug.cgi?id=62489
58352
58353         * Scripts/webkitpy/tool/bot/sheriff.py:
58354         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
58355
58356 2011-06-10  Tony Chang  <tony@chromium.org>
58357
58358         Reviewed by Ojan Vafai.
58359
58360         add a compile guard ENABLE(FLEXBOX)
58361         https://bugs.webkit.org/show_bug.cgi?id=62049
58362
58363         * Scripts/build-webkit:
58364
58365 2011-06-10  Mark Rowe  <mrowe@apple.com>
58366
58367         Reviewed by Dimitri Glazkov.
58368
58369         <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
58370
58371         Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
58372         header file.
58373
58374         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
58375         * DumpRenderTree/mac/Configurations/Base.xcconfig:
58376
58377 2011-06-09  Csaba Osztrogonác  <ossy@webkit.org>
58378
58379         Unreviewed rolling out r88471, because it broke plugin tests on Qt.
58380
58381         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
58382         (handleEventX11):
58383         (NPP_GetValue):
58384         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
58385         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
58386         (webkit_test_plugin_new_instance):
58387         (webkit_test_plugin_destroy_instance):
58388         (webkit_test_plugin_set_window):
58389         (executeScript):
58390         (webkit_test_plugin_new_stream):
58391         (webkit_test_plugin_destroy_stream):
58392         (webkit_test_plugin_stream_as_file):
58393         (webkit_test_plugin_write_ready):
58394         (webkit_test_plugin_write):
58395         (webkit_test_plugin_print):
58396         (keyEventToChar):
58397         (webkit_test_plugin_handle_event):
58398         (webkit_test_plugin_url_notify):
58399         (webkit_test_plugin_get_value):
58400         (webkit_test_plugin_set_value):
58401         (NP_GetMIMEDescription):
58402         (NP_Initialize):
58403         (NP_Shutdown):
58404         (NP_GetValue):
58405         * GNUmakefile.am:
58406
58407 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
58408
58409         Reviewed by Eric Seidel.
58410
58411         [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
58412         https://bugs.webkit.org/show_bug.cgi?id=55603
58413
58414         Add callbacks to support hasMarkedText and markedRange and also clean up existing
58415         TextInputController support.
58416
58417         * DumpRenderTree/gtk/TextInputController.cpp:
58418         (setMarkedTextCallback): Accept parameters in terms of start and length, instead
58419         of start and end. This matches the other ports. Do not use GLib style early returns.
58420         (hasMarkedTextCallback): Added.
58421         (markedRangeCallback): Added.
58422         (insertTextCallback): Cleanup as described above.
58423         (unmarkTextCallback): Cleanup as described above.
58424         (firstRectForCharacterRangeCallback): Cleanup as described above.
58425         (selectedRangeCallback): Cleanup as described above.
58426
58427 2011-06-09  Dirk Pranke  <dpranke@chromium.org>
58428
58429         Reviewed by Tony Chang.
58430
58431         nrwt: support webaudio in chromium driver
58432         https://bugs.webkit.org/show_bug.cgi?id=62226
58433
58434         * Scripts/webkitpy/layout_tests/port/chromium.py:
58435
58436 2011-06-09  Dan Bernstein  <mitz@apple.com>
58437
58438         Reviewed by Anders Carlsson.
58439
58440         Added a test for Vector::reverse()
58441         https://bugs.webkit.org/show_bug.cgi?id=62393
58442
58443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
58444         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
58445         (TestWebKitAPI::TEST):
58446         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
58447
58448 2011-06-09  Martin Robinson  <mrobinson@igalia.com>
58449
58450         Reviewed by Andreas Kling.
58451
58452         [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
58453         https://bugs.webkit.org/show_bug.cgi?id=62385
58454
58455         Remove duplicate TestNetscapePlugIn implementation. Having two copies
58456         of this code makes keeping it in sync much more difficult. The files are
58457         almost identical and this change ports the X11 changes to main.cpp.
58458
58459         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
58460         (keyEventToChar): Added this helper which converts a X11 keycode into a char.
58461         (handleEventX11): Use the handler to properly convert the keycode. Do not print
58462         adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
58463         it should not be in the results.
58464         (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
58465         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
58466         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
58467         * GNUmakefile.am: Update source list.
58468
58469 2011-06-09  Noel Gordon  <noel.gordon@gmail.com>
58470
58471         Reviewed by Tony Chang.
58472
58473         Test plugin should support event logging on the windows port.
58474         https://bugs.webkit.org/show_bug.cgi?id=61721
58475
58476         The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
58477         calls to mean the plugin handled the event.
58478
58479         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
58480         (handleEventWin): Return 0 for each event on windows.
58481
58482 2011-06-09  Chang Shu  <cshu@webkit.org>
58483
58484         Reviewed by Andreas Kling.
58485
58486         [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
58487         https://bugs.webkit.org/show_bug.cgi?id=62381
58488
58489         Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
58490         QWKPagePrivate::isViewFocused() will check it later.
58491
58492         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
58493         (WTR::PlatformWebView::PlatformWebView):
58494
58495 2011-06-09  Robert Hogan  <robert@webkit.org>
58496
58497         Reviewed by Andreas Kling.
58498
58499         Teach Qt about window.internals
58500         https://bugs.webkit.org/show_bug.cgi?id=61074
58501
58502         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
58503         (WebCore::DumpRenderTree::initJSObjects):
58504
58505 2011-06-09  Eric Seidel  <eric@webkit.org>
58506
58507         Reviewed by Adam Barth.
58508
58509         Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
58510         https://bugs.webkit.org/show_bug.cgi?id=62362
58511
58512         The mac bots are failing inspector tests.  We don't know why yet.
58513         So for now, turning run-webkit-tests off for the mac-ews.
58514
58515         Also noticed that due to the wrong variable name the cr-linux
58516         bots weren't running tests!
58517
58518         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
58519
58520 2011-06-09  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
58521
58522         Reviewed by Csaba Osztrogonac.
58523
58524         [Qt][WK2] Canvas tests make css2.1 ones failing
58525         https://bugs.webkit.org/show_bug.cgi?id=53427
58526
58527         Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
58528         Since the Qt port should eventually go to QRawFont, this issue will be resolved
58529         in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
58530         needed for the workaround.
58531
58532         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
58533         (WTR::LayoutTestController::platformInitialize):
58534
58535 2011-06-09  Mario Sanchez Prada  <msanchez@igalia.com>
58536
58537         Reviewed by Chris Fleizach.
58538
58539         [GTK] Provide a way in DRT to check the platform name
58540         https://bugs.webkit.org/show_bug.cgi?id=56855
58541
58542         Patch for adding 'platformName' static property to DRT's
58543         LayoutController and provide platform specific implementations.
58544
58545         In principle, this feature will be only of interest for writing
58546         accessibility tests, so that's why it's only implemented in the
58547         Mac, Gtk and Win platforms.
58548
58549         * DumpRenderTree/LayoutTestController.h: New method platformName().
58550         * DumpRenderTree/LayoutTestController.cpp:
58551         (getPlatformNameCallback): New callback for 'platformName'.
58552         (LayoutTestController::staticValues): New static property.
58553
58554         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
58555         (LayoutTestController::platformName): Implemented.
58556
58557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
58558         (LayoutTestController::platformName): Implemented.
58559
58560         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
58561         (LayoutTestController::platformName): Implemented.
58562
58563 2011-06-08  Mike Lawther  <mikelawther@chromium.org>
58564
58565         Reviewed by James Robinson.
58566
58567         Add mikelawther to committers.py
58568         https://bugs.webkit.org/show_bug.cgi?id=62354
58569
58570         * Scripts/webkitpy/common/config/committers.py:
58571
58572 2011-06-08  Kent Tamura  <tkent@chromium.org>
58573
58574         [Chromium] Fix a typo.
58575
58576         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
58577         (WebThemeControlDRTWin::draw):
58578
58579 2011-06-08  Kent Tamura  <tkent@chromium.org>
58580
58581         Reviewed by Hajime Morita.
58582
58583         [Chromium] Support vertical sliders in Windows DRT
58584         https://bugs.webkit.org/show_bug.cgi?id=62352
58585
58586         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
58587         (WebThemeControlDRTWin::draw):
58588           Paint VerticalSliderThumbType and VerticalSliderTrackType.
58589         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
58590           Add VerticalSliderTrackType and VerticalSliderThumbType.
58591         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
58592         (WebThemeEngineDRTWin::paintTrackbar):
58593           Convert Windows identifiers to the internal identifiers for vertical sliders.
58594
58595 2011-06-08  Ojan Vafai  <ojan@chromium.org>
58596
58597         Reviewed by Tony Chang.
58598
58599         add a short-flag for --experimental-fully-parallel
58600         https://bugs.webkit.org/show_bug.cgi?id=62321
58601
58602         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
58603
58604 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
58605
58606         Reviewed by Tony Chang.
58607
58608         new-run-webkit-tests: don't turn the tree red when there are new passes
58609         https://bugs.webkit.org/show_bug.cgi?id=62311
58610
58611         Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
58612         to match commandComplete.
58613
58614         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
58615
58616 2011-06-08  Tom Hudson  <tomhudson@google.com>
58617
58618         Reviewed by Mihai Parparita.
58619
58620         Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
58621         https://bugs.webkit.org/show_bug.cgi?id=60964
58622
58623         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
58624         Add 'Sort tests by metric' link.
58625         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
58626         (disableSorting): Activate 'Sort tests by metric' link.
58627         (enableSorting): Deactivate 'Sort tests by metric' link.
58628         (selectDirectory): Call enableSorting()/disableSorting() depending
58629         on currently selected failure type, and sort tests if requested.
58630         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
58631         New .disabled-control class for deactivated links.
58632
58633 2011-06-08  Tom Sepez  <tsepez@chromium.org>
58634
58635         Reviewed by Adam Barth.
58636
58637         Add web permissions callbacks for mixed content blocking.
58638         https://bugs.webkit.org/show_bug.cgi?id=61946
58639
58640         * DumpRenderTree/chromium/LayoutTestController.cpp:
58641         (LayoutTestController::setAllowDisplayOfInsecureContent):
58642         (LayoutTestController::setAllowRunningOfInsecureContent):
58643         (LayoutTestController::overridePreference):
58644         * DumpRenderTree/chromium/WebPermissions.cpp:
58645         (WebPermissions::allowDisplayingInsecureContent):
58646         (WebPermissions::allowRunningInsecureContent):
58647         (WebPermissions::setDisplayingInsecureContentAllowed):
58648         (WebPermissions::setRunningInsecureContentAllowed):
58649         (WebPermissions::reset):
58650         * DumpRenderTree/chromium/WebPermissions.h:
58651
58652 2011-06-08  Dirk Pranke  <dpranke@chromium.org>
58653
58654         Reviewed by Tony Chang.
58655
58656         webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
58657         https://bugs.webkit.org/show_bug.cgi?id=62259
58658
58659         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
58660
58661 2011-06-08  Ryosuke Niwa  <rniwa@webkit.org>
58662
58663         Reviewed by Tony Chang.
58664
58665         new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
58666         https://bugs.webkit.org/show_bug.cgi?id=62303
58667
58668         Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
58669
58670         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
58671
58672 2011-06-08  Greg Simon  <gregsimon@chromium.org>
58673
58674         Reviewed by Dimitri Glazkov.
58675
58676         Control Indexeddb backends from LayoutTestController
58677         https://bugs.webkit.org/show_bug.cgi?id=61000
58678
58679         * DumpRenderTree/chromium/LayoutTestController.cpp:
58680         (LayoutTestController::LayoutTestController):
58681         (LayoutTestController::setOverrideIndexedDBBackingStore):
58682         (LayoutTestController::clearAllDatabases):
58683         * DumpRenderTree/chromium/LayoutTestController.h:
58684
58685 2011-06-08  Andreas Kling  <kling@webkit.org>
58686
58687         Add Pierre Rossi to contributors list for EZ-CC.
58688
58689         * Scripts/webkitpy/common/config/committers.py:
58690
58691 2011-06-08  Ilya Sherman  <isherman@chromium.org>
58692
58693         Reviewed by Andreas Kling.
58694
58695         Add Ilya Sherman to list of committers
58696         https://bugs.webkit.org/show_bug.cgi?id=62270
58697
58698         * Scripts/webkitpy/common/config/committers.py:
58699
58700 2011-06-07  Ryosuke Niwa  <rniwa@webkit.org>
58701
58702         Reviewed by Tony Chang.
58703
58704         new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
58705         https://bugs.webkit.org/show_bug.cgi?id=62178
58706
58707         Added commandComplete and evaluateCommand for NewRunWebKitTests class
58708         to parse new-run-webkit-tests' results.
58709
58710         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
58711
58712 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
58713
58714         Reviewed by Eric Seidel.
58715
58716         webkitpy: add a popen() call to executive
58717         https://bugs.webkit.org/show_bug.cgi?id=62179
58718
58719         This change adds a popen() wrapper call to the Executive object.
58720         This will allow other webkitpy scripts that currently call
58721         subprocess directly to use Executive, instead.
58722
58723         No additional tests are necessary (the existing tests cover the code).
58724
58725         * Scripts/webkitpy/common/system/executive.py:
58726
58727 2011-06-07  Sam Weinig  <sam@webkit.org>
58728
58729         Reviewed by Anders Carlsson.
58730
58731         Remove repeated IPC traffic from SetRenderTreeSize message
58732         https://bugs.webkit.org/show_bug.cgi?id=62244
58733
58734         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
58735         (WTR::InjectedBundlePage::InjectedBundlePage):
58736         Add stub for didLayoutForFrame.
58737
58738 2011-06-07  Dirk Pranke  <dpranke@chromium.org>
58739
58740         Reviewed by Tony Chang.
58741
58742         rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
58743         https://bugs.webkit.org/show_bug.cgi?id=62241
58744
58745         * Scripts/webkitpy/layout_tests/port/chromium.py:
58746
58747 2011-06-07  Adam Barth  <abarth@webkit.org>
58748
58749         Rubber-stamped by Eric Seidel.
58750
58751         Enable tests on the mac-ews
58752
58753         When we bring the mac-ews back up, we're going to try running tests!
58754
58755         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
58756
58757 2011-06-07  Dmitry Lomov  <dslomov@google.com>
58758
58759         Reviewed by David Levin.
58760
58761         https://bugs.webkit.org/show_bug.cgi?id=62215
58762         Allow comparisons with 0 in LIKELY and UNLIKELY macros.
58763
58764         * Scripts/webkitpy/style/checkers/cpp.py:
58765         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
58766
58767 2011-06-07  Nico Weber  <thakis@chromium.org>
58768
58769         Reviewed by Dimitri Glazkov.
58770
58771         [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
58772         https://bugs.webkit.org/show_bug.cgi?id=62210
58773
58774         The change to TestEventPrinter fixes a latent bug, because
58775         objects are deleted through the TestEventPrinter type, but none
58776         of the subclasses have destructors or non-POD members.
58777
58778         The changes to NotificationPresenter and WebViewHost do _not_ to fix a
58779         real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
58780         discussed at http://codereview.chromium.org/7094005/, we prefer making
58781         leaf class destructors virtual over making the leaf classes final.
58782
58783         * DumpRenderTree/chromium/NotificationPresenter.cpp:
58784         (NotificationPresenter::~NotificationPresenter):
58785         * DumpRenderTree/chromium/NotificationPresenter.h:
58786         * DumpRenderTree/chromium/TestEventPrinter.cpp:
58787         (TestEventPrinter::~TestEventPrinter):
58788         * DumpRenderTree/chromium/TestEventPrinter.h:
58789         * DumpRenderTree/chromium/WebViewHost.h:
58790
58791 2011-06-06  Ryosuke Niwa  <rniwa@webkit.org>
58792
58793         Reviewed by Dirk Pranke.
58794
58795         [chromium] Chromium bots on build.webkit.org don't upload results.html
58796         https://bugs.webkit.org/show_bug.cgi?id=61961
58797
58798         Don't fix the path on chromium port erroneously.
58799
58800         * BuildSlaveSupport/test-result-archive:
58801
58802 2011-06-06  Martin Robinson  <mrobinson@igalia.com>
58803
58804         Fix the GTK+ build by ensuring that the autogenerated sources
58805         necessary for libWebCoreInternals are recorded in a predeclared
58806         variable before assigning to BUILT_SOURCES.
58807
58808         * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
58809
58810 2011-06-06  Yong Li  <yoli@rim.com>
58811
58812         Reviewed by Eric Seidel.
58813
58814         https://bugs.webkit.org/show_bug.cgi?id=62097
58815         Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
58816
58817         * Scripts/webkitpy/style/checkers/cpp.py:
58818         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
58819
58820 2011-06-06  Xan Lopez  <xlopez@igalia.com>
58821
58822         Reviewed by Martin Robinson.
58823
58824         [GTK] Enable feature/symbol detection in NWRT/GTK
58825         https://bugs.webkit.org/show_bug.cgi?id=62136
58826
58827         Disable feature detection through DRT, since we don't support it,
58828         and set the libwebcore patch correctly so that symbol detection
58829         through 'nm' works.
58830
58831         * Scripts/webkitpy/layout_tests/port/gtk.py:
58832
58833 2011-06-06  Shishir Agrawal  <shishir@chromium.org>
58834
58835         Reviewed by Tony Gentilcore.
58836
58837         Add a "prerender" state for page visibility.
58838         https://bugs.webkit.org/show_bug.cgi?id=62062
58839
58840         * DumpRenderTree/chromium/LayoutTestController.cpp:
58841         (LayoutTestController::setPageVisibility):
58842
58843 2011-06-06  Csaba Osztrogonác  <ossy@webkit.org>
58844
58845         [Qt] Implement download feature for QtTestBrowser
58846         https://bugs.webkit.org/show_bug.cgi?id=61865
58847
58848         Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
58849
58850         * QtTestBrowser/launcherwindow.cpp:
58851         (LauncherWindow::LauncherWindow):
58852         * QtTestBrowser/launcherwindow.h:
58853
58854 2011-06-06  Barát Tibor  <Barat.Tibor@stud.u-szeged.hu>
58855
58856         Reviewed by Csaba Osztrogonác.
58857
58858         [Qt] Implement download feature for QtTestBrowser
58859         https://bugs.webkit.org/show_bug.cgi?id=61865
58860
58861         * QtTestBrowser/launcherwindow.cpp:
58862         (LauncherWindow::LauncherWindow):
58863         (LauncherWindow::downloadRequest):
58864         (LauncherWindow::fileDownloadFinished):
58865         * QtTestBrowser/launcherwindow.h:
58866
58867 2011-06-04  Dominic Cooney  <dominicc@chromium.org>
58868
58869         Reviewed by Dimitri Glazkov.
58870
58871         Make DumpRenderTree initialize window.internals.
58872         https://bugs.webkit.org/show_bug.cgi?id=61076
58873
58874         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
58875         * DumpRenderTree/win/FrameLoadDelegate.cpp:
58876         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
58877
58878 2011-06-06  Alexandru Chiculita  <achicu@adobe.com>
58879
58880         Reviewed by Kent Tamura.
58881
58882         Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
58883         https://bugs.webkit.org/show_bug.cgi?id=61628
58884
58885         * Scripts/build-webkit:
58886
58887 2011-06-06  Mihnea Ovidenie  <mihnea@adobe.com>
58888
58889         Reviewed by Kent Tamura.
58890
58891         Add ENABLE(CSS_REGIONS) guard for CSS Regions support
58892         https://bugs.webkit.org/show_bug.cgi?id=61631
58893
58894         * Scripts/build-webkit:
58895
58896 2011-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
58897
58898         Unreviewed. Fix the GTK+ build.
58899
58900         * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
58901
58902 2011-06-05  Alexey Proskuryakov  <ap@apple.com>
58903
58904         Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
58905         works properly).
58906
58907         * Scripts/webkitpy/common/config/committers.py:
58908
58909 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
58910
58911         [wx] Unreviewed build fix. Update git branch build dir handling to match what other
58912         WebKit scripts expect, so other scripts work properly with wx.
58913
58914         * waf/build/build_utils.py:
58915         * waf/build/settings.py:
58916
58917 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
58918
58919         [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
58920         to build on Mac.
58921
58922         * waf/build/settings.py:
58923         * wx/install-unix-extras:
58924
58925 2011-06-04  Kevin Ollivier  <kevino@theolliviers.com>
58926
58927         [wx] Unreviewed build fixes for recent trunk changes.
58928
58929         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
58930         (LayoutTestController::setTextDirection):
58931         * waf/build/settings.py:
58932
58933 2011-06-04  Martin Robinson  <mrobinson@igalia.com>
58934
58935         Fix the GTK+ build.
58936
58937         * GNUmakefile.am: Add some missing newline escape.
58938
58939 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
58940
58941         Try to fix the GTK+ bulid.
58942
58943         * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
58944         source list.
58945
58946 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
58947
58948         Reviewed by Adam Barth.
58949
58950         nrwt: should skip chromium test expectation overrides on upstream bots
58951         https://bugs.webkit.org/show_bug.cgi?id=61888
58952
58953         * Scripts/webkitpy/layout_tests/port/chromium.py:
58954         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
58955
58956 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
58957
58958         Reviewed by Ojan Vafai.
58959
58960         new-run-webkit-tests: minor logging, code cleanup
58961         https://bugs.webkit.org/show_bug.cgi?id=62055
58962
58963         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
58964         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
58965
58966 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
58967
58968         Try to fix the build failure on the GTK+ 32-bit Release bot.
58969
58970         * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
58971
58972 2011-05-31  Martin Robinson  <mrobinson@igalia.com>
58973
58974         Reviewed by Ryosuke Niwa.
58975
58976         [GTK] Support smart replace for the pasteboard
58977         https://bugs.webkit.org/show_bug.cgi?id=61734
58978
58979         Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
58980         This is required to produce consistent test results.
58981
58982         * DumpRenderTree/gtk/DumpRenderTree.cpp:
58983         (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
58984         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
58985         (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
58986         methods which calls into DumpRenderTreeSupportGtk.
58987
58988 2011-06-03  Martin Robinson  <mrobinson@igalia.com>
58989
58990         Reviewed by Dimitri Glazkov.
58991
58992         Teach Gtk build about window.internals
58993         https://bugs.webkit.org/show_bug.cgi?id=61071
58994
58995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
58996         (webViewWindowObjectCleared): Inject the new internals object when the
58997         window object clears.
58998         * GNUmakefile.am: Add new source files and includes necessary for window.internals.
58999         Also do a little bit of cleanup.
59000
59001 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
59002
59003         Reviewed by Tony Chang.
59004
59005         Worker may not be stopped after LT.
59006         https://bugs.webkit.org/show_bug.cgi?id=61847
59007
59008         Re-submit a variant of the first fix for this bug. It's possible
59009         that actually calling cleanup() in the worker threads was taking
59010         too long and we triggered the assertions in the manager thread.
59011
59012         I've bumped up the timeout in the manager and added better
59013         diagnostics. I also cleaned up the cleanup() code a bit because
59014         there was some unnecessary if-checks.
59015
59016         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
59017         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
59018
59019 2011-06-03  Dirk Pranke  <dpranke@chromium.org>
59020
59021         Reviewed by Tony Chang.
59022
59023         nrwt: fix duplicate logging regression
59024         https://bugs.webkit.org/show_bug.cgi?id=61981
59025
59026         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59027
59028 2011-06-03  Robert Kroeger  <rjkroege@chromium.org>
59029
59030         Reviewed by Adam Barth.
59031
59032         Modified addTouchPoint to correctly re-use touchPoint id values starting
59033         from the lowest not-un-use touchPoint id as is done by the embedder
59034         APIs. (Fixes BUGCR36415)
59035
59036         https://bugs.webkit.org/show_bug.cgi?id=62016
59037
59038         * DumpRenderTree/chromium/EventSender.cpp:
59039         (EventSender::addTouchPoint):
59040
59041 2011-06-03  Cary Clark  <caryclark@google.com>
59042
59043         Reviewed by Eric Seidel.
59044
59045         Draw DRT scroll bar thumb with CG when WebKit renders with Skia
59046         https://bugs.webkit.org/show_bug.cgi?id=61534
59047
59048         Skia on Mac uses Skia to render WebKit, and CG
59049         to render UI elements. The CG elements need a
59050         transcribed graphics context that preserves the
59051         canvas matrix, and the canvas clip.
59052
59053         The SkiaBitLocker utility class sets up a CGContext
59054         from the SkCanvas, locks the bitmap's bits, and
59055         releases the lock when the class goes out of scope.
59056
59057         The SkiaBitLocker implementation is described by
59058         this patch:
59059         http://codereview.chromium.org/7031006/
59060
59061         When WebKit uses Skia for rendering, the WebCanvas
59062         is an SkCanvas. Create an equivalent CGContext to
59063         draw the scrollbar thumb.
59064
59065         As the Chrome Mac port does not yet use Skia, this
59066         patch has no effect and requires no tests.
59067
59068         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
59069         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
59070
59071 2011-06-03  Andras Becsi  <abecsi@webkit.org>
59072
59073         Unreviewed build fix.
59074
59075         Fix typo.
59076
59077         * Scripts/old-run-webkit-tests:
59078
59079 2011-06-03  Andras Becsi  <abecsi@webkit.org>
59080
59081         Reviewed by Csaba Osztrogonác.
59082
59083         Print error message when there is no httpd present on the system
59084         https://bugs.webkit.org/show_bug.cgi?id=61939
59085
59086         * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
59087         * Scripts/webkitperl/httpd.pm:
59088
59089 2011-06-03  Mikhail Naganov  <mnaganov@chromium.org>
59090
59091         Reviewed by Yury Semikhatsky.
59092
59093         Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
59094         https://bugs.webkit.org/show_bug.cgi?id=61533
59095
59096         Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
59097
59098         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
59099         (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
59100         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
59101         * DumpRenderTree/chromium/LayoutTestController.cpp:
59102         (LayoutTestController::LayoutTestController):
59103         (LayoutTestController::setJavaScriptProfilingEnabled):
59104         * DumpRenderTree/chromium/LayoutTestController.h:
59105         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
59106         (LayoutTestController::setJavaScriptProfilingEnabled):
59107         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
59108         (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
59109         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
59110
59111 2011-06-02  Dirk Pranke  <dpranke@chromium.org>
59112
59113         Reviewed by Tony Chang.
59114
59115         NRWT needs a way to log to a file without including backspaces without needing --verbose
59116         https://bugs.webkit.org/show_bug.cgi?id=60328
59117
59118         This change modifies NRWT so that if it can tell if it is
59119         writing to a terminal, it will overwrite any messages printed
59120         in the 'one-line-progress' and 'updates' print options, and if
59121         not (or if --verbose was specified) the messages will be printed
59122         without backspaces.
59123
59124         If the overwriting updates are disabled, one-line-progress will
59125         only print every 10 seconds instead of on every update. This
59126         ensures that we still get updates once in a while while the
59127         tests are running, even if we're not in --verbose mode. Note
59128         that one-line-progress will now still be printed in --verbose,
59129         since it's useful as long as you're not flooded with the
59130         updates.
59131
59132         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
59133         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59134         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
59135
59136 2011-06-02  Martin Robinson  <mrobinson@igalia.com>
59137
59138         Reviewed by Gustavo Noronha Silva.
59139
59140         [GTK] autogen.sh is run twice for each buld on the bots
59141         https://bugs.webkit.org/show_bug.cgi?id=61951
59142
59143         * Scripts/webkitdirs.pm: Only check the previous autotools arguments
59144         for the WebKit project. This prevents build-jsc runs from forcing subsequent
59145         build-webkit runs to re-rerun autogen.sh.
59146
59147 2011-06-02  Sheriff Bot  <webkit.review.bot@gmail.com>
59148
59149         Unreviewed, rolling out r87946.
59150         http://trac.webkit.org/changeset/87946
59151         https://bugs.webkit.org/show_bug.cgi?id=61965
59152
59153         Cause NRWT to break (Requested by abarth|gardener on #webkit).
59154
59155         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
59156
59157 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
59158
59159         Reviewed by Darin Adler.
59160
59161         Add build logistics and plumbing for window.internals object.
59162         https://bugs.webkit.org/show_bug.cgi?id=60313
59163
59164         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
59165         * DumpRenderTree/chromium/TestShell.cpp:
59166         (TestShell::bindJSObjectsToWindow): Added injection code.
59167         * DumpRenderTree/mac/FrameLoadDelegate.mm:
59168         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
59169
59170 2011-06-02  Hao Zheng  <zhenghao@chromium.org>
59171
59172         Reviewed by Dirk Pranke.
59173
59174         Call cleanup() explicitly at the end of worker.run().
59175         https://bugs.webkit.org/show_bug.cgi?id=61847
59176
59177         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
59178
59179 2011-06-02  Dimitri Glazkov  <dglazkov@chromium.org>
59180
59181         Unreviewed, rolling out r87926.
59182         http://trac.webkit.org/changeset/87926
59183         https://bugs.webkit.org/show_bug.cgi?id=60313
59184
59185         Fails to find WebCoreTestSupport.dylib on bots.
59186
59187         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
59188         * DumpRenderTree/chromium/TestShell.cpp:
59189         (TestShell::bindJSObjectsToWindow):
59190         * DumpRenderTree/mac/FrameLoadDelegate.mm:
59191         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
59192
59193 2011-05-21  Dimitri Glazkov  <dglazkov@chromium.org>
59194
59195         Reviewed by Darin Adler.
59196
59197         Add build logistics and plumbing for window.internals object.
59198         https://bugs.webkit.org/show_bug.cgi?id=60313
59199
59200         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
59201         * DumpRenderTree/chromium/TestShell.cpp:
59202         (TestShell::bindJSObjectsToWindow): Added injection code.
59203         * DumpRenderTree/mac/FrameLoadDelegate.mm:
59204         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
59205
59206 2011-06-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
59207
59208         Reviewed by Eric Seidel.
59209
59210         Adjust efl coding style to more efl directories
59211         https://bugs.webkit.org/show_bug.cgi?id=61903
59212
59213         * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
59214
59215 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
59216
59217         Reviewed by Tony Chang.
59218
59219         old-run-webkit-tests: add support for audio files
59220         https://bugs.webkit.org/show_bug.cgi?id=57992
59221
59222         * Scripts/old-run-webkit-tests:
59223
59224 2011-06-01  Jochen Eisinger  <jochen@chromium.org>
59225
59226         Reviewed by Adam Barth.
59227
59228         Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
59229         https://bugs.webkit.org/show_bug.cgi?id=34314
59230
59231         * DumpRenderTree/DumpRenderTree.gypi:
59232         * DumpRenderTree/chromium/LayoutTestController.cpp:
59233         (LayoutTestController::LayoutTestController):
59234         (LayoutTestController::setImagesAllowed):
59235         (LayoutTestController::setStorageAllowed):
59236         * DumpRenderTree/chromium/LayoutTestController.h:
59237         * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
59238         (WebPermissions::WebPermissions):
59239         (WebPermissions::~WebPermissions):
59240         (WebPermissions::allowImages):
59241         (WebPermissions::allowStorage):
59242         (WebPermissions::setImagesAllowed):
59243         (WebPermissions::setStorageAllowed):
59244         (WebPermissions::reset):
59245         * DumpRenderTree/chromium/WebPermissions.h:
59246
59247 2011-06-01  Noel Gordon  <noel.gordon@gmail.com>
59248
59249         Reviewed by Tony Chang.
59250
59251         Test plugin should support event logging on the windows port.
59252         https://bugs.webkit.org/show_bug.cgi?id=61721
59253
59254         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
59255         (handleEventWin): Well, handle them.
59256
59257 2011-06-01  Daniel Cheng  <dcheng@chromium.org>
59258
59259         Reviewed by Tony Chang.
59260
59261         [chromium] Use correct file name for dragging out images.
59262         https://bugs.webkit.org/show_bug.cgi?id=24887
59263
59264         * DumpRenderTree/chromium/EventSender.cpp:
59265         (EventSender::EventSender):
59266         (EventSender::dumpFilenameBeingDragged):
59267         * DumpRenderTree/chromium/EventSender.h:
59268
59269 2011-06-01  Dirk Pranke  <dpranke@chromium.org>
59270
59271         Reviewed by Tony Chang.
59272
59273         nrwt: make webaudio work w/o content-length header
59274         https://bugs.webkit.org/show_bug.cgi?id=61819
59275
59276         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59277         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
59278         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
59279         * Scripts/webkitpy/layout_tests/port/webkit.py:
59280
59281 2011-06-01  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
59282
59283         Reviewed by Andreas Kling.
59284
59285         [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
59286         https://bugs.webkit.org/show_bug.cgi?id=61802
59287
59288         Add command line parameter and menu item to MiniBrowser application
59289         enabling use of QGLWidget for browser viewport.
59290
59291         * MiniBrowser/qt/BrowserWindow.cpp:
59292         (BrowserWindow::BrowserWindow):
59293         (BrowserWindow::toggleGLViewport):
59294         * MiniBrowser/qt/BrowserWindow.h:
59295         * MiniBrowser/qt/MiniBrowserApplication.cpp:
59296         (MiniBrowserApplication::handleUserOptions):
59297         * MiniBrowser/qt/MiniBrowserApplication.h:
59298         (WindowOptions::WindowOptions):
59299
59300 2011-06-01  Martin Robinson  <mrobinson@igalia.com>
59301
59302         Reviewed by Xan Lopez.
59303
59304         Print out autogen arguments when they differ from the last set, to help
59305         with debugging build issues.
59306
59307         * Scripts/webkitdirs.pm: Print out previous and current build arguments
59308         when they differ.
59309
59310 2011-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
59311
59312         Reviewed by Martin Robinson.
59313
59314         [GTK] run-launcher should run MiniBrowser in WebKit2
59315         https://bugs.webkit.org/show_bug.cgi?id=61858
59316
59317         * Scripts/run-launcher: Check whether -2 command line option has
59318         been passed and run MiniBrowser instead of GtkLauncher.
59319
59320 2011-05-31  Hao Zheng  <zhenghao@chromium.org>
59321
59322         Reviewed by Dirk Pranke.
59323
59324         Fix exception in verbose printing mode.
59325         https://bugs.webkit.org/show_bug.cgi?id=61723
59326
59327         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59328
59329 2011-05-31  Yong Li  <yoli@rim.com>
59330
59331         Reviewed by Eric Seidel.
59332
59333         https://bugs.webkit.org/show_bug.cgi?id=54807
59334         We have been assuming plain bitfields (like "int a : 31") are always signed integers.
59335         However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
59336         bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
59337         http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
59338         Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
59339         always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
59340         rule we should have in order to make our code independent from compilers and compiler flags.
59341
59342         * Scripts/webkitpy/style/checkers/cpp.py:
59343
59344 2011-05-31  Hironori Bono  <hbono@chromium.org>
59345
59346         Reviewed by Eric Seidel.
59347
59348         Add a JavaScript function layoutTestController.setTextDirection().
59349         https://bugs.webkit.org/show_bug.cgi?id=50952
59350
59351         This change adds a new JavaScript function setTextDirection() to the
59352         LayoutTestController class of Safari and Chrome to write layout tests
59353         that changes the text direction of an editable element.
59354
59355         * DumpRenderTree/LayoutTestController.cpp:
59356         (setTextDirectionCallback):
59357         (LayoutTestController::staticFunctions):
59358         * DumpRenderTree/LayoutTestController.h:
59359         * DumpRenderTree/chromium/LayoutTestController.cpp:
59360         (LayoutTestController::LayoutTestController):
59361         (LayoutTestController::setTextDirection):
59362         * DumpRenderTree/chromium/LayoutTestController.h:
59363         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
59364         (LayoutTestController::setTextDirection):
59365         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
59366         (LayoutTestController::setTextDirection):
59367         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
59368         (LayoutTestController::setTextDirection):
59369
59370 2011-05-31  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
59371
59372         Reviewed by Simon Hausmann.
59373
59374         [Qt] User-agent list of Qt test browsers is very outdated
59375         https://bugs.webkit.org/show_bug.cgi?id=61531
59376
59377         The user can edit the user-agent manually, so there's no need to have
59378         a super complete and up to date list, but it's nice to have it
59379         minimally updated.
59380
59381         * MiniBrowser/qt/useragentlist.txt:
59382         * QtTestBrowser/useragentlist.txt:
59383
59384 2011-03-30  Martin Robinson  <mrobinson@igalia.com>
59385
59386         Reviewed by Adam Roben.
59387
59388         [GTK] [WebKit2] Implement a basic WebKitTestRunner
59389         https://bugs.webkit.org/show_bug.cgi?id=57068
59390
59391         Add an implementation of WebKitTestRunner for GTK+.
59392
59393         * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
59394         * Scripts/old-run-webkit-tests: Ditto.
59395         * Scripts/run-launcher: Ditto.
59396         * Scripts/webkitdirs.pm: Ditto.
59397         * WebKitTestRunner/GNUmakefile.am: Added.
59398         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
59399         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
59400         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
59401         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
59402         * WebKitTestRunner/PlatformWebView.h:
59403         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
59404         * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
59405         * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
59406         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
59407         * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
59408         (main): Added.
59409
59410 2011-05-31  Dirk Pranke  <dpranke@chromium.org>
59411
59412         Reviewed by Tony Chang.
59413
59414         new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
59415         https://bugs.webkit.org/show_bug.cgi?id=60241
59416
59417         * Scripts/new-run-webkit-tests:
59418
59419 2011-05-31  Eric Seidel  <eric@webkit.org>
59420
59421         Reviewed by David Kilzer.
59422
59423         webkitpy should create zips with zip -9
59424         https://bugs.webkit.org/show_bug.cgi?id=61789
59425
59426         Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
59427
59428         * Scripts/webkitpy/common/system/workspace.py:
59429         * Scripts/webkitpy/common/system/workspace_unittest.py:
59430
59431 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
59432
59433         Reviewed by Csaba Osztrogonác.
59434
59435         [Qt] Implement find feature for QtTestBrowser
59436         https://bugs.webkit.org/show_bug.cgi?id=61425
59437
59438         Buildfix for --minimal and CONFIG+=qt_minimal build.
59439
59440         * QtTestBrowser/launcherwindow.cpp:
59441         (LauncherWindow::LauncherWindow):
59442         (LauncherWindow::createChrome):
59443         * QtTestBrowser/launcherwindow.h:
59444
59445 2011-05-31  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
59446
59447         Reviewed by Csaba Osztrogonác.
59448
59449         [Qt] Implement find feature for QtTestBrowser
59450         https://bugs.webkit.org/show_bug.cgi?id=61425
59451
59452         * QtTestBrowser/launcherwindow.cpp:
59453         (LauncherWindow::LauncherWindow):
59454         (LauncherWindow::createChrome):
59455         (LauncherWindow::showFindBar):
59456         (LauncherWindow::find):
59457         * QtTestBrowser/launcherwindow.h:
59458
59459 2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>
59460
59461         Reviewed by Martin Robinson.
59462
59463         [GTK] Implement JavaScript dialogs in MiniBrowser
59464         https://bugs.webkit.org/show_bug.cgi?id=61725
59465
59466         * MiniBrowser/gtk/BrowserWindow.c:
59467         (WKStringGetCString): Helper function to get a UTF-8 c string from
59468         a WKStringRef.
59469         (WKURLGetCString): Helper function to get a UTF-8 c string from a
59470         WKURLRef.
59471         (browserWindowUpdateURL): Update to use WKURLGetCString.
59472         (didReceiveTitleForFrame): Update to use WKStringGetCString.
59473         (createMessageDialog): Create a GtkMessageDialog.
59474         (runJavaScriptAlert):
59475         (runJavaScriptConfirm):
59476         (runJavaScriptPrompt):
59477         (browserWindowUIClientInit):
59478
59479 2011-05-29  Yuta Kitamura  <yutak@chromium.org>
59480
59481         Reviewed by Kent Tamura.
59482
59483         WebSocket closing handshake
59484         https://bugs.webkit.org/show_bug.cgi?id=35721
59485
59486         * Scripts/webkitpy/thirdparty/__init__.py:
59487         Pull in pywebsocket 0.6b1. We need to update pywebsocket
59488         to get the right behavior of closing handshake.
59489
59490 2011-05-29  Daniel Bates  <dbates@rim.com>
59491
59492         Reviewed by David Kilzer.
59493
59494         REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
59495         https://bugs.webkit.org/show_bug.cgi?id=61162
59496
59497         Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
59498         that omits a line count. In particular, the chunk range regular expression does
59499         not match a chunk range line that omits a line count. GNU diff(1) will omit the
59500         line count in the chunk range if the line count is exactly 1. For example, appending
59501         a new line to the end of an existing file F that contains exactly one line of text will
59502         be represented in a diff with a chunk range line that omits the line count for F.
59503
59504         * Scripts/VCSUtils.pm:
59505           (parseChunkRange): Added.
59506         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
59507         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
59508           - Added unit test "Git: Append new line to the end of an existing file".
59509
59510 2011-05-28  Adam Barth  <abarth@webkit.org>
59511
59512         Reviewed by Eric Seidel.
59513
59514         EWS builds patches that fail to build twice, which seems useless and slows down the bots
59515         https://bugs.webkit.org/show_bug.cgi?id=55585
59516
59517         This patch switches all the early warning system bots over to the new
59518         PatchAnalysisTask-based infrastructure.  This patch makes these bots
59519         more efficient (in the case where patches fail to build) and paves the
59520         way for running tests on these bots!
59521
59522         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
59523         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
59524         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
59525         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
59526         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
59527         * Scripts/webkitpy/tool/commands/queues.py:
59528
59529 2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>
59530
59531         Reviewed by Kent Tamura.
59532
59533         Add bashi as a committer.
59534
59535         https://bugs.webkit.org/show_bug.cgi?id=61685
59536
59537         * Scripts/webkitpy/common/config/committers.py:
59538
59539 2011-05-27  Adam Barth  <abarth@webkit.org>
59540
59541         Reviewed by Eric Seidel.
59542
59543         When checking whether the tree is red, the EWS posts a link to the wrong log
59544         https://bugs.webkit.org/show_bug.cgi?id=61072
59545
59546         We need to cache the original script error because that contains the
59547         failure log we want to upload.  If we don't cache that script error,
59548         self._script_error will get overwritten when we sanity check the clean
59549         tree (and it also has test failures).
59550
59551         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
59552             - This testing approach is slightly goofy.  We'd like to use
59553               assertRaisesRegexp, but that's not available until Python 2.7.
59554         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
59555
59556 2011-05-27  Jochen Eisinger  <jochen@chromium.org>
59557
59558         Reviewed by Adam Barth.
59559
59560         Add layoutTestController.setStorageAllowed() to control whether access
59561         to the localStorage API is enabled via the WebPermissionClient
59562         https://bugs.webkit.org/show_bug.cgi?id=61581
59563
59564         * DumpRenderTree/chromium/LayoutTestController.cpp:
59565         (LayoutTestController::LayoutTestController):
59566         (LayoutTestController::setStorageAllowed):
59567         * DumpRenderTree/chromium/LayoutTestController.h:
59568         * DumpRenderTree/chromium/TestShell.cpp:
59569         (TestShell::TestShell):
59570         (TestShell::createNewWindow):
59571         * DumpRenderTree/chromium/TestShell.h:
59572         * DumpRenderTree/chromium/WebPermissions.h: Added.
59573         (WebPermissions::WebPermissions):
59574         (WebPermissions::allowStorage):
59575         (WebPermissions::setStorageAllowed):
59576         (WebPermissions::reset):
59577
59578 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
59579
59580         Reviewed by Eric Seidel.
59581
59582         NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
59583         https://bugs.webkit.org/show_bug.cgi?id=60326
59584
59585         This patch removes a lot of the complexity from the
59586         metered_stream implementation that was unnecessary since there
59587         was only one caller and the logic could be coordinated better.
59588
59589         There should be no functional changes in this patch, just code
59590         getting deleted and cleaned up.
59591
59592         * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
59593         * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
59594         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59595         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
59596
59597 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
59598
59599         Reviewed by Eric Seidel.
59600
59601         NRWT: minor cleanup in printing module
59602         https://bugs.webkit.org/show_bug.cgi?id=60329
59603
59604         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59605
59606 2011-05-27  Steve Lacey  <sjl@chromium.org>
59607
59608         Reviewed by David Levin.
59609
59610         Add sjl@chromium.org as a committer.
59611
59612         https://bugs.webkit.org/show_bug.cgi?id=61672
59613
59614         * Scripts/webkitpy/common/config/committers.py:
59615
59616 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
59617
59618         Reviewed by Adam Barth.
59619
59620         NRWT: remove --print detailed-progress
59621         https://bugs.webkit.org/show_bug.cgi?id=60324
59622
59623         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
59624         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59625         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
59626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
59627
59628 2011-05-27  Dirk Pranke  <dpranke@chromium.org>
59629
59630         Reviewed by Ojan Vafai.
59631
59632         NRWT: debug messages from the workers are being logged twice
59633         https://bugs.webkit.org/show_bug.cgi?id=60428
59634
59635         It looks like when the workers are run in separate processes
59636         we end up getting two copies of every log message they print.
59637         This has to do with the multiprocessing module on UNIX cloning
59638         the log configuration in a way I wasn't expecting, and so two
59639         log handlers end up getting registered.
59640
59641         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
59642         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
59643         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
59644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
59645
59646 2011-05-27  Adam Roben  <aroben@apple.com>
59647
59648         Always decode tester names from location.hash
59649
59650         When navigating directly to a tester-specific URL (e.g.,
59651         <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
59652         with a URL-encoded tester name in the page, and then the encoded name could make its way
59653         into Bugzilla bugs. Bad!
59654
59655         Reviewed by David Kilzer.
59656
59657         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
59658         (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
59659         decodeURIComponent before trying to use it.
59660
59661 2011-05-27  Adam Roben  <aroben@apple.com>
59662
59663         Remove testing code that snuck into r87528
59664
59665         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
59666         (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
59667
59668 2011-05-27  Adam Roben  <aroben@apple.com>
59669
59670         Add links to TestFailures to easily file bugs about failing tests
59671
59672         Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
59673         links to file bugs for failing tests
59674
59675         Reviewed by David Kilzer.
59676
59677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
59678         (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
59679         for a particular build.
59680         (Builder.prototype._getFailingTests): Use resultsPageURL.
59681
59682         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
59683         (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
59684         failures.
59685         (ViewController.prototype._domForBuildName): Use resultsPageURL.
59686         (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
59687         new bug link. The bug has a title, description, and URL already filled in for you!
59688
59689 2011-05-27  Sheriff Bot  <webkit.review.bot@gmail.com>
59690
59691         Unreviewed, rolling out r87464.
59692         http://trac.webkit.org/changeset/87464
59693         https://bugs.webkit.org/show_bug.cgi?id=61643
59694
59695         client-close/server-close tests are flaky on Chromium Mac and
59696         Windows (Requested by aklein on #webkit).
59697
59698         * Scripts/webkitpy/thirdparty/__init__.py:
59699
59700 2011-05-27  Alexey Proskuryakov  <ap@apple.com>
59701
59702         Added Douglas Davidson to contributors list for easier CC'ing.
59703
59704         * Scripts/webkitpy/common/config/committers.py:
59705
59706 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
59707
59708         Reviewed by Adam Barth.
59709
59710         Fix worldID and destinationDomain argument names
59711         https://bugs.webkit.org/show_bug.cgi?id=61571
59712
59713         As part of working on r87423, I noticed a couple of inconsistencies in
59714         argument names:
59715         - We would use worldId in .h files but worldID in .cpp files.
59716           Standardize on the latter
59717         - SecurityOrigin::addOriginAccessWhitelistEntry would take a
59718           destinationDomains argument, even though the actual parameter was for
59719           a single domain (renamed to be singular).
59720
59721         * DumpRenderTree/LayoutTestController.h:
59722         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
59723         (LayoutTestController::evaluateScriptInIsolatedWorld):
59724
59725 2011-05-26  Yuta Kitamura  <yutak@chromium.org>
59726
59727         Reviewed by Kent Tamura.
59728
59729         WebSocket closing handshake
59730         https://bugs.webkit.org/show_bug.cgi?id=35721
59731
59732         * Scripts/webkitpy/thirdparty/__init__.py:
59733         Pull in pywebsocket 0.6b1. We need to update pywebsocket
59734         to get the right behavior of closing handshake.
59735
59736 2011-05-26  Qi Zhang  <qi.2.zhang@nokia.com>
59737
59738         Reviewed by Andreas Kling.
59739
59740         WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
59741         https://bugs.webkit.org/show_bug.cgi?id=42676
59742
59743         Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
59744
59745         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
59746         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
59747         (WTR::InjectedBundle::beginTesting):
59748         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
59749         (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
59750         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
59751
59752 2011-05-26  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
59753
59754         Reviewed by Andreas Kling.
59755
59756         [Qt] QtTestBrowser "Switch User Agent" dialog is broken
59757         https://bugs.webkit.org/show_bug.cgi?id=61527
59758
59759         The setMaximumHeight() call is unecessary and breaks the dialog at
59760         least on my setup.
59761
59762         * QtTestBrowser/launcherwindow.cpp:
59763         (LauncherWindow::showUserAgentDialog):
59764
59765 2011-05-02  Robert Hogan  <robert@webkit.org>
59766
59767         Reviewed by Adam Roben.
59768
59769         [Qt] Allow popup windows from plugins when initiated by a user gesture
59770
59771         https://bugs.webkit.org/show_bug.cgi?id=41292
59772
59773         Support parameters introduced in plugin-initiate-popup-window.html
59774
59775         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
59776         (webkit_test_plugin_new_instance):
59777         (webkit_test_plugin_handle_event):
59778
59779 2011-05-26  Mihai Parparita  <mihaip@chromium.org>
59780
59781         Reviewed by Adam Barth.
59782
59783         Support cross-origin XMLHttpRequest in isolated worlds
59784         https://bugs.webkit.org/show_bug.cgi?id=59843
59785
59786         Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
59787
59788         * DumpRenderTree/chromium/LayoutTestController.cpp:
59789         (LayoutTestController::LayoutTestController):
59790         (LayoutTestController::setIsolatedWorldSecurityOrigin):
59791         * DumpRenderTree/chromium/LayoutTestController.h:
59792
59793 2011-05-25  Brian Weinstein  <bweinstein@apple.com>
59794
59795         Reviewed by Adam Roben.
59796
59797         WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
59798         https://bugs.webkit.org/show_bug.cgi?id=61474
59799         <rdar://problem/9468337>
59800
59801         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
59802         (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
59803
59804 2011-05-26  Andreas Kling  <kling@webkit.org>
59805
59806         Unreviewed, correct address to webkit-committers mailing list.
59807
59808         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
59809
59810 2011-05-25  Adam Roben  <aroben@apple.com>
59811
59812         Don't assume that builds finish in the order they were started
59813
59814         Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
59815         build when one slave is taking a long time to finish a build
59816
59817         Reviewed by Antti Koivisto.
59818
59819         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
59820         (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
59821         newer than the oldest in-progress build are also themselves in progress. Just check whether
59822         each build is actually in progress (as signified by its presence in the currentBuilds set).
59823
59824 2011-05-25  Adam Roben  <aroben@apple.com>
59825
59826         Correctly detect cases where only a single test failed/crashed/timed out
59827
59828         Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
59829         failing test
59830
59831         Reviewed by Darin Adler.
59832
59833         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
59834         (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
59835         will be singular when only a single test fails/crashes/times out.
59836
59837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
59838         (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
59839         failed/crashed/timed out.
59840
59841 2011-05-26  Tom Hudson  <tomhudson@google.com>
59842
59843         Reviewed by Tony Chang.
59844
59845         Add flags to Chromium ImageDiff to write image comparison metrics on
59846         stdout.
59847         https://bugs.webkit.org/show_bug.cgi?id=60569
59848
59849         * DumpRenderTree/chromium/ImageDiff.cpp:
59850         (Image::createFromStdin): Fix spelling.
59851         (maxOf3): New function to do 3-way maximum.
59852         (getRedComponent): Extract red component from ABGR packed encoding.
59853         (getGreenComponent): Extract green component from ABGR packed encoding.
59854         (getBlueComponent): Extract blue component from ABGR packed encoding.
59855         (weightedPercentageDifferent): Determine % of pixels different in two
59856         images multiplied by intensity difference of each pixel.
59857         (printHelp): Document new arguments.
59858         (compareImages): Parameterize.
59859         (untestedCompareImages): Parameterize.
59860         (diffImages): Parameterize; write results on stdout if requested.
59861         (main): Parse new arguments.
59862
59863 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
59864
59865         Reviewed by Simon Hausmann.
59866
59867         WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
59868         https://bugs.webkit.org/show_bug.cgi?id=42697
59869
59870         Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
59871
59872         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
59873         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
59874         (WTR::InjectedBundle::beginTesting):
59875         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
59876         (WTR::LayoutTestController::setPrivateBrowsingEnabled):
59877         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
59878
59879 2011-05-25  Jon Honeycutt  <jhoneycutt@apple.com>
59880
59881         REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
59882         https://bugs.webkit.org/show_bug.cgi?id=61428
59883         <rdar://problem/9457006>
59884
59885         Reviewed by Adam Roben.
59886
59887         The crash occurs when Flash posts a message to a window that it
59888         creates, and in processing the message, it calls NPN_Evaluate to
59889         evaluate JavaScript that removes the plug-in from the page. Flash then
59890         crashes when we return to Flash code.
59891
59892         This test emulates that behavior.
59893
59894         * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
59895         (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
59896         Initialize member vars.
59897         (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
59898         Remove our custom property from the message window, and destroy it.
59899         (CallJSThatDestroysPlugin::NPP_Destroy):
59900         Set m_isDestroyed, log that the plug-in was destroyed, and notify the
59901         layout test controller that we're done.
59902         (wndProc):
59903         Get the PluginTest object, and call its runTest() function.
59904         (CallJSThatDestroysPlugin::NPP_New):
59905         Setup the test: register a class for the message-only window, create
59906         it, and post a message to it to run the test.
59907         (CallJSThatDestroysPlugin::runTest):
59908         Execute JS that removes the plug-in from the page, and if we're not
59909         destroyed, log a success message.
59910
59911         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
59912         Add new test to project.
59913
59914 2011-05-25  Tony Chang  <tony@chromium.org>
59915
59916         Reviewed by Adam Barth.
59917
59918         webkitpy's NetworkTransaction shouldn't use mechanize
59919         https://bugs.webkit.org/show_bug.cgi?id=61450
59920
59921         mechanize.HTTPError is just an alias for urllib2.HTTPError, so
59922         use urllib2 directly.  Re-add NetworkTransaction to
59923         test_results_uploader.py (reverting r87124).
59924
59925         * Scripts/webkitpy/common/net/networktransaction.py:
59926         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
59927
59928 2011-05-25  Kevin Ollivier  <kevino@theolliviers.com>
59929
59930         [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
59931         until the port begins using those export macros.
59932
59933         * DumpRenderTree/chromium/config.h:
59934
59935 2011-05-25  Sheriff Bot  <webkit.review.bot@gmail.com>
59936
59937         Unreviewed, rolling out r87257.
59938         http://trac.webkit.org/changeset/87257
59939         https://bugs.webkit.org/show_bug.cgi?id=61457
59940
59941         This broke layout tests, see bug 61431. (Requested by
59942         hwennborg on #webkit).
59943
59944         * DumpRenderTree/chromium/LayoutTestController.cpp:
59945         (LayoutTestController::LayoutTestController):
59946         (LayoutTestController::clearAllDatabases):
59947         * DumpRenderTree/chromium/LayoutTestController.h:
59948
59949 2011-05-25  Qi Zhang  <qi.2.zhang@nokia.com>
59950
59951         Reviewed by Andreas Kling.
59952
59953         [Qt] fast/css/disabled-author-styles.html failed
59954         https://bugs.webkit.org/show_bug.cgi?id=61438
59955
59956         Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
59957
59958         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
59959         (WebCore::WebPage::resetSettings):
59960         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
59961         (LayoutTestController::setAuthorAndUserStylesEnabled):
59962         * DumpRenderTree/qt/LayoutTestControllerQt.h:
59963
59964 2011-05-25  Adam Roben  <aroben@apple.com>
59965
59966         Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
59967
59968         Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
59969         started exiting early due to too many crashes, timeouts, or failures
59970
59971         Reviewed by David Kilzer.
59972
59973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
59974         (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
59975         run-webkit-tests exits early due to too many failures, pass that information in another
59976         argument to the callback.
59977         (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
59978         the new structure of the object passed to the callback.
59979         (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
59980         getNumberOfFailingTests and to pass that along to our own callbacks.
59981         (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
59982         from _getFailingTests and to store that value in the history object.
59983
59984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
59985         (.info): Added.
59986
59987         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
59988         (ViewController.prototype._displayBuilder): Updated for change in structure to the history
59989         object and to add a note when run-webkit-tests exited early due to too many failures.
59990         (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
59991         latestBuildInfos since each entry now contains more than just the tester and failure count.
59992         Now displays a message for testers where the latest build exited early due to too many
59993         failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
59994         store that value in latestBuildInfos.
59995
59996 2011-05-24  Keishi Hattori  <keishi@webkit.org>
59997
59998         Reviewed by Kent Tamura.
59999
60000         Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
60001         https://bugs.webkit.org/show_bug.cgi?id=61273
60002
60003         * Scripts/build-webkit: Added INPUT_COLOR feature flag.
60004
60005 2011-05-24  Greg Simon  <gregsimon@chromium.org>
60006
60007         Reviewed by Dimitri Glazkov.
60008
60009         Control Indexeddb backends from LayoutTestController
60010         https://bugs.webkit.org/show_bug.cgi?id=61000
60011
60012         * DumpRenderTree/chromium/LayoutTestController.cpp:
60013         (LayoutTestController::LayoutTestController):
60014         (LayoutTestController::setOverrideIndexedDBBackingStore):
60015         (LayoutTestController::clearAllDatabases):
60016         * DumpRenderTree/chromium/LayoutTestController.h:
60017
60018 2011-05-24  Robert Hogan  <robert@webkit.org>
60019
60020         Reviewed by Ryosuke Niwa.
60021
60022         [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
60023         https://bugs.webkit.org/show_bug.cgi?id=61393
60024
60025         * DumpRenderTree/qt/EventSenderQt.h:
60026         * DumpRenderTree/qt/EventSenderQt.cpp:
60027         (getModifiers): static function for interpreting modifiers
60028         (EventSender::mouseDown): Respect keyboard modifiers
60029         (EventSender::keyDown): use new static function
60030         (EventSender::sendOrQueueEvent): whitespace fix
60031
60032 2011-05-24  Jay Civelli  <jcivelli@chromium.org>
60033
60034         Reviewed by Adam Barth.
60035
60036         Adding MHTML reading support.
60037         https://bugs.webkit.org/show_bug.cgi?id=7168
60038
60039         * Scripts/build-webkit:
60040         * Scripts/old-run-webkit-tests:
60041         * Scripts/webkitperl/features.pm:
60042         * Scripts/webkitpy/layout_tests/port/test_files.py:
60043         * Scripts/webkitpy/layout_tests/port/webkit.py:
60044
60045 2011-05-24  Stephen White  <senorblanco@chromium.org>
60046
60047         Reviewed by Kenneth Russell.
60048
60049         Remove most style checks on Source/ThirdParty/glu, since it doesn't
60050         follow WebKit style.
60051         https://bugs.webkit.org/show_bug.cgi?id=61365
60052
60053         * Scripts/webkitpy/style/checker.py:
60054
60055 2011-05-24  Adam Roben  <aroben@apple.com>
60056
60057         Don't allow forcing builds through the build.webkit.org web interface
60058
60059         Someone has been forcing bogus builds.
60060
60061         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
60062
60063 2011-05-24  Qi Zhang  <qi.2.zhang@nokia.com>
60064
60065         Reviewed by Adam Roben.
60066
60067         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
60068         https://bugs.webkit.org/show_bug.cgi?id=42669
60069
60070         Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
60071         layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
60072         Because that case changed the setting.
60073
60074         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
60075         (WTR::InjectedBundle::beginTesting):
60076
60077 2011-05-24  Csaba Osztrogonác  <ossy@webkit.org>
60078
60079         Reviewed by Kenneth Rohde Christiansen.
60080
60081         [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
60082         https://bugs.webkit.org/show_bug.cgi?id=61052
60083
60084         * Scripts/old-run-webkit-tests:
60085
60086 2011-05-24  Adam Roben  <aroben@apple.com>
60087
60088         Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
60089
60090         Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
60091         that don't have any failing tests, which isn't useful
60092
60093         Reviewed by David Kilzer.
60094
60095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
60096         (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
60097         instead of name strings.
60098         (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
60099         builder names into an array of builders.
60100
60101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
60102         (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
60103         the most recently completed build, or -1 if there is no such build.
60104         (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
60105         in the given build, or -1 if the number could not be determined. Some of this code came from
60106         _getFailingTests.
60107         (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
60108         (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
60109         getNumberOfFailingTests functions.
60110
60111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
60112         (ViewController.prototype._displayTesters): Get the current number of test failures for each
60113         tester and show it in the list. Omit testers that have no failures at all. We keep the
60114         testers and failure counts in an array and sort it before displaying the current data, as
60115         the order in which data will be fetched is unpredictable.
60116
60117 2011-05-23  Tony Chang  <tony@chromium.org>
60118
60119         Reviewed by Ojan Vafai.
60120
60121         [nrwt] don't use NetworkTranslation when uploading results
60122         https://bugs.webkit.org/show_bug.cgi?id=61315
60123
60124         This avoids autoinstalling mechanize.  It didn't matter anyway
60125         because test_results_uploader.py wasn't using mechanize to make the
60126         request so NetworkTransaction::run wasn't doing anything extra
60127         (it only matters if it catches mechanize.HTTPError).
60128
60129         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
60130
60131 2011-05-23  Tony Chang  <tony@chromium.org>
60132
60133         Reviewed by Dirk Pranke.
60134
60135         [chromium] fix the rebaseline tool to work with Linux GPU failures
60136         https://bugs.webkit.org/show_bug.cgi?id=61312
60137
60138         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
60139
60140 2011-05-23  Darin Adler  <darin@apple.com>
60141
60142         Ignore generated .pyc files in a directory full of python code.
60143
60144         * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
60145
60146 2011-05-23  Adam Barth  <abarth@webkit.org>
60147
60148         Reviewed by Eric Seidel.
60149
60150         sheriffbot should give more details about the failures in IRC
60151         https://bugs.webkit.org/show_bug.cgi?id=61233
60152
60153         With this patch, sheriffbot will annonce the set of failing tests,
60154         which might help folks triage the problem.
60155
60156         * Scripts/webkitpy/tool/commands/sheriffbot.py:
60157         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
60158
60159 2011-05-23  Sheriff Bot  <webkit.review.bot@gmail.com>
60160
60161         Unreviewed, rolling out r87078.
60162         http://trac.webkit.org/changeset/87078
60163         https://bugs.webkit.org/show_bug.cgi?id=61294
60164
60165         Patch contains errors and seems likely to break a bunch of
60166         bots (Requested by abarth on #webkit).
60167
60168         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
60169         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
60170         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
60171
60172 2011-05-23  Alice Boxhall  <aboxhall@chromium.org>
60173
60174         Reviewed by Ojan Vafai.
60175
60176         Convert json_results_generator.py to output version 4 JSON.
60177         https://bugs.webkit.org/show_bug.cgi?id=60869
60178
60179         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
60180         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
60181         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
60182
60183 2011-05-23  Patrick Gansterer  <paroga@webkit.org>
60184
60185         Reviewed by Adam Barth.
60186
60187         Move generation of shell_command from port to executive
60188         https://bugs.webkit.org/show_bug.cgi?id=61251
60189
60190         After move it's possible to use the code in other places too.
60191
60192         * Scripts/webkitpy/common/config/ports.py:
60193         * Scripts/webkitpy/common/system/executive.py:
60194
60195 2011-05-23  Qi Zhang  <qi.2.zhang@nokia.com>
60196
60197         Reviewed by Darin Adler.
60198
60199         WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
60200         https://bugs.webkit.org/show_bug.cgi?id=42669
60201
60202         Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
60203
60204         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
60205         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
60206         (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
60207         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
60208
60209 2011-05-22  Robert Hogan  <robert@webkit.org>
60210
60211         Reviewed by Kenneth Rohde Christiansen.
60212
60213         Fix policyDelegate in Qt DRT
60214         https://bugs.webkit.org/show_bug.cgi?id=61247
60215
60216         Use the 'policy delegate' implemented in FrameLoaderClient
60217         for layout tests. The partial implementation in DumpRenderTreeQt
60218         is redundant, so remove it.
60219
60220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
60221         (WebCore::WebPage::acceptNavigationRequest):
60222         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
60223         (LayoutTestController::waitForPolicyDelegate):
60224
60225 2011-05-22  Patrick Gansterer  <paroga@webkit.org>
60226
60227         Reviewed by Darin Adler.
60228
60229         Use double quotes for filename arguments
60230         https://bugs.webkit.org/show_bug.cgi?id=61250
60231
60232         Windows does not support single quotes on the command line,
60233         so replace them with double quotes.
60234
60235         * Scripts/prepare-ChangeLog:
60236
60237 2011-05-20  Simon Fraser  <simon.fraser@apple.com>
60238
60239         Reviewed by Sam Weinig.
60240
60241         WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
60242         https://bugs.webkit.org/show_bug.cgi?id=42550
60243
60244         Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
60245
60246         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
60247         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
60248         Copy the code for pausing animations, FIXME comments and all.
60249         (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
60250         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
60251
60252 2011-05-20  Alok Priyadarshi  <alokp@chromium.org>
60253
60254         Reviewed by Stephen White.
60255
60256         Adding myself to the committers list.
60257
60258         * Scripts/webkitpy/common/config/committers.py:
60259
60260 2011-05-19  Adam Roben  <aroben@apple.com>
60261
60262         Test that the WebKit2 UI process doesn't crash when starting a download
60263
60264         Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
60265         (preceded by assertion) in fastMalloc when downloading a file
60266
60267         Reviewed by Darin Adler.
60268
60269         * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
60270
60271         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
60272         (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
60273         (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
60274         started, cancel the download, and return a bogus string.
60275
60276         (TestWebKitAPI::setContextDownloadClient):
60277         (TestWebKitAPI::setPagePolicyClient):
60278         Simple helper functions.
60279
60280         (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
60281         our policy client, and run until we know that the download was started. If we haven't
60282         crashed, we win!
60283
60284         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60285         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
60286         * TestWebKitAPI/win/copy-resources.cmd:
60287         Added new files.
60288
60289 2011-05-20  Kent Tamura  <tkent@chromium.org>
60290
60291         Reviewed by Ryosuke Niwa.
60292
60293         Fix style errors in DumpRenderTree/chromium/.
60294         https://bugs.webkit.org/show_bug.cgi?id=61172
60295
60296         * DumpRenderTree/chromium/CppBoundClass.cpp:
60297         (CppBoundClass::getAsCppVariant):
60298         (CppBoundClass::bindToJavascript):
60299         * DumpRenderTree/chromium/CppBoundClass.h:
60300         (CppBoundClass::GetterCallback::~GetterCallback):
60301         (CppBoundClass::CppBoundClass):
60302         (CppBoundClass::Callback::~Callback):
60303         (CppBoundClass::MemberCallback::MemberCallback):
60304         (CppBoundClass::MemberCallback::~MemberCallback):
60305         (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
60306         (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
60307         * DumpRenderTree/chromium/CppVariant.h:
60308         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
60309         (DRTDevToolsAgent::~DRTDevToolsAgent):
60310         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
60311         (DRTDevToolsClient::sendFrontendLoaded):
60312         * DumpRenderTree/chromium/DRTDevToolsClient.h:
60313         * DumpRenderTree/chromium/DumpRenderTree.cpp:
60314         (main):
60315         * DumpRenderTree/chromium/EventSender.cpp:
60316         (SavedEvent::SavedEvent):
60317         (EventSender::EventSender):
60318         (EventSender::keyDown):
60319         * DumpRenderTree/chromium/EventSender.h:
60320         * DumpRenderTree/chromium/ImageDiff.cpp:
60321         (Image::Image):
60322         * DumpRenderTree/chromium/LayoutTestController.cpp:
60323         (LayoutTestController::LayoutTestController):
60324         (LayoutTestController::WorkQueue::reset):
60325         (WorkItemBackForward::WorkItemBackForward):
60326         (WorkItemLoadingScript::WorkItemLoadingScript):
60327         (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
60328         (WorkItemLoad::WorkItemLoad):
60329         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
60330         (LayoutTestController::pathToLocalResource):
60331         * DumpRenderTree/chromium/LayoutTestController.h:
60332         (LayoutTestController::WorkItem::~WorkItem):
60333         (LayoutTestController::WorkQueue::WorkQueue):
60334         * DumpRenderTree/chromium/MockSpellCheck.cpp:
60335         (MockSpellCheck::MockSpellCheck):
60336         (MockSpellCheck::~MockSpellCheck):
60337         * DumpRenderTree/chromium/MockSpellCheck.h:
60338         * DumpRenderTree/chromium/NotificationPresenter.h:
60339         (NotificationPresenter::NotificationPresenter):
60340         * DumpRenderTree/chromium/Task.cpp:
60341         (WebTask::WebTask):
60342         * DumpRenderTree/chromium/Task.h:
60343         (TaskList::TaskList):
60344         * DumpRenderTree/chromium/TestEventPrinter.cpp:
60345         (DRTPrinter::DRTPrinter):
60346         (TestShellPrinter::TestShellPrinter):
60347         * DumpRenderTree/chromium/TestNavigationController.cpp:
60348         (TestNavigationEntry::TestNavigationEntry):
60349         (TestNavigationEntry::~TestNavigationEntry):
60350         (TestNavigationController::TestNavigationController):
60351         (TestNavigationController::reload):
60352         (TestNavigationController::loadEntry):
60353         (TestNavigationController::didNavigateToEntry):
60354         * DumpRenderTree/chromium/TestNavigationController.h:
60355         (TestShellExtraData::TestShellExtraData):
60356         * DumpRenderTree/chromium/TestShell.cpp:
60357         (dumpHistoryItem):
60358         * DumpRenderTree/chromium/TestShell.h:
60359         (TestParams::TestParams):
60360         * DumpRenderTree/chromium/TestShellWin.cpp:
60361         (TestShell::waitTestFinished):
60362         * DumpRenderTree/chromium/TestWebWorker.h:
60363         (TestWebWorker::startWorkerContext):
60364         (TestWebWorker::terminateWorkerContext):
60365         (TestWebWorker::postMessageToWorkerContext):
60366         (TestWebWorker::clientDestroyed):
60367         (TestWebWorker::postMessageToWorkerObject):
60368         (TestWebWorker::postExceptionToWorkerObject):
60369         (TestWebWorker::postConsoleMessageToWorkerObject):
60370         (TestWebWorker::confirmMessageFromWorkerObject):
60371         (TestWebWorker::reportPendingActivity):
60372         (TestWebWorker::workerContextClosed):
60373         (TestWebWorker::~TestWebWorker):
60374         * DumpRenderTree/chromium/TextInputController.cpp:
60375         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
60376         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
60377         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
60378         (WebThemeEngineDRTWin::paintButton):
60379         (WebThemeEngineDRTWin::paintMenuList):
60380         (WebThemeEngineDRTWin::paintTrackbar):
60381         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
60382         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
60383         * DumpRenderTree/chromium/WebViewHost.cpp:
60384         (WebViewHost::navigate):
60385         (WebViewHost::updateSessionHistory):
60386         (WebViewHost::paintInvalidatedRegion):
60387         * DumpRenderTree/chromium/WebViewHost.h:
60388
60389 2011-05-19  Dmitry Lomov  <dslomov@google.com>
60390
60391         Reviewed by Adam Roben.
60392
60393         Detect hangs in run-api-tests
60394         https://bugs.webkit.org/show_bug.cgi?id=48043
60395
60396         * Scripts/run-api-tests: Added test timeouts
60397
60398 2011-05-19  Dmitry Lomov  <dslomov@google.com>
60399
60400         Reviewed by Adam Roben.
60401
60402         run-api-tests should run one test per process
60403         https://bugs.webkit.org/show_bug.cgi?id=61088
60404
60405         * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
60406         return code, and parsing GTest output format.
60407
60408 2011-05-15  Robert Hogan  <robert@webkit.org>
60409
60410         Reviewed by Antonio Gomes.
60411
60412         [Qt][GTK] plugins/get-url-with-javascript-url.html fails
60413         https://bugs.webkit.org/show_bug.cgi?id=60834
60414         Fix unix test plugin for plugins/get-url-with-javascript-url.html
60415
60416         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60417         (webkit_test_plugin_new_stream):
60418         (webkit_test_plugin_write_ready):
60419         (webkit_test_plugin_write):
60420
60421 2011-05-19  Sheriff Bot  <webkit.review.bot@gmail.com>
60422
60423         Unreviewed, rolling out r86869, r86873, r86875, and r86877.
60424         http://trac.webkit.org/changeset/86869
60425         http://trac.webkit.org/changeset/86873
60426         http://trac.webkit.org/changeset/86875
60427         http://trac.webkit.org/changeset/86877
60428         https://bugs.webkit.org/show_bug.cgi?id=61139
60429
60430         broke builds and debug DRT (Requested by rniwa on #webkit).
60431
60432         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60433         * DumpRenderTree/chromium/TestShell.cpp:
60434         (TestShell::bindJSObjectsToWindow):
60435         * DumpRenderTree/mac/FrameLoadDelegate.mm:
60436         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
60437
60438 2011-05-18  Dimitri Glazkov  <dglazkov@chromium.org>
60439
60440         Reviewed by Darin Adler.
60441
60442         Add build logistics and plumbing for window.internals object.
60443         https://bugs.webkit.org/show_bug.cgi?id=60313
60444
60445         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
60446         * DumpRenderTree/chromium/TestShell.cpp:
60447         (TestShell::bindJSObjectsToWindow): Added injection code.
60448         * DumpRenderTree/mac/FrameLoadDelegate.mm:
60449         (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
60450
60451 2011-05-19  Zsolt Fehér  <h490267@stud.u-szeged.hu>
60452
60453         Reviewed by Csaba Osztrogonác.
60454
60455         [Qt] Implement eventSender.scalePageBy
60456         https://bugs.webkit.org/show_bug.cgi?id=60015
60457
60458         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
60459         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
60460         * DumpRenderTree/qt/EventSenderQt.cpp:
60461         (EventSender::scalePageBy):
60462         * DumpRenderTree/qt/EventSenderQt.h:
60463
60464 2011-05-19  Kenichi Ishibashi  <bashi@chromium.org>
60465
60466         Reviewed by Kent Tamura.
60467
60468         [Chromium] IME candidate window appears wrong position in an iframe
60469         https://bugs.webkit.org/show_bug.cgi?id=61023
60470
60471         Call the focused frame's firstRectForCharacterRange() instead of the
60472         main frame so that DRT behaves as the same as Chromium.
60473
60474         * DumpRenderTree/chromium/TextInputController.cpp:
60475         (TextInputController::firstRectForCharacterRange):
60476
60477 2011-05-18  Adam Roben  <aroben@apple.com>
60478
60479         Add a new page to build.webkit.org to help find when tests started failing
60480
60481         The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
60482         right now, but already shows some useful information. It's somewhat similar to webkit-patch
60483         failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
60484         little more convenient than either of them, though, because it's all done in the browser
60485         (and thus it's easy to go directly to the relevant test results).
60486
60487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
60488         (Buildbot): This class represents a Buildbot server.
60489         (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
60490         (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
60491         (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
60492         callback.
60493         (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
60494         be implemented by a derived class that understands this server's build naming scheme.
60495         (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
60496         particular build.
60497
60498         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
60499         (Builder): This class represents one builder on the buildbot.
60500         (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
60501         (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
60502         information about a particular test failure.
60503         (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
60504         information about when tests started failing.
60505         (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
60506         particular build.
60507         (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
60508         callback.
60509         (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
60510         extracts all the failing tests listed in it, passing them to the callback.
60511         (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
60512         build, merges them into the build history, and calls the callback telling it whether the
60513         next build should be fetched to provide more information.
60514
60515         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
60516         Added. Just some simple styles.
60517
60518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
60519         (createDefinitionList): Takes an array of pairs and turns them into a DL element.
60520         (getResource): Wrapper around XMLHttpRequest.
60521         (Array.prototype.findFirst): Finds the first element matching the given predicate and
60522         returns it.
60523         (Array.prototype.last): Returns the last element of the array.
60524
60525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
60526         (ViewController): This class contains the main logic for displaying the page.
60527         (ViewController.loaded): Just calls through to parseHash.
60528         (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
60529         shows the list of all testers so one can be chosen. This function is called when the page
60530         loads and whenever we get a hashchange event.
60531         (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
60532         as it is fetched. The display ends up grouping tests by when they started failing.
60533         (ViewController._displayTesters): Gets the list of testers and displays it.
60534
60535         (ViewController._domForBuildName):
60536         (ViewController._domForFailedTest):
60537         Helper functions to create descriptions and links for a particular build or failed test.
60538
60539         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
60540         (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
60541         (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
60542
60543         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
60544         loads all the files and sets up a ViewController, which does the rest.
60545
60546         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
60547         page.
60548
60549 2011-05-18  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
60550
60551         Reviewed by Csaba Osztrogonác.
60552
60553         [Qt] Implement layoutTestController.setValueForUser()
60554         https://bugs.webkit.org/show_bug.cgi?id=60956
60555
60556         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
60557         (LayoutTestController::setValueForUser):
60558         * DumpRenderTree/qt/LayoutTestControllerQt.h:
60559
60560 2011-05-16  Robert Hogan  <robert@webkit.org>
60561
60562         Reviewed by Kenneth Rohde Christiansen.
60563
60564         plugins/invalidate_rect.html fails on linux ports
60565
60566         - Make the unix test netscape plugin recognize the onPaintEvent
60567           and windowedPlugin parameters.
60568
60569         https://bugs.webkit.org/show_bug.cgi?id=54051
60570
60571         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
60572         (handleEventX11):
60573         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
60574         (LayoutTestController::displayInvalidatedRegion):
60575         * DumpRenderTree/qt/LayoutTestControllerQt.h:
60576         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60577         (webkit_test_plugin_new_instance):
60578         (webkit_test_plugin_handle_event):
60579
60580 2011-05-17  Tony Chang  <tony@chromium.org>
60581
60582         Reviewed by Ojan Vafai.
60583
60584         [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
60585         https://bugs.webkit.org/show_bug.cgi?id=60895
60586
60587         Update the tools to handle the move.  Lucid 32 results now go in
60588         chromium-linux-x86 and the default platform on Linux is now x86_64.
60589
60590         * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
60591         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
60592         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
60593         * Scripts/webkitpy/layout_tests/port/base.py: ditto
60594         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
60595         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
60596         * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
60597         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
60598         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
60599
60600 2011-05-17  Adam Roben  <aroben@apple.com>
60601
60602         Make run-api-tests work on Windows when there are spaces in the path
60603
60604         Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
60605         spaces in the path to TestWebKitAPI.exe
60606
60607         Reviewed by David Levin.
60608
60609         * Scripts/run-api-tests:
60610         (runTestTool): Use the "direct object" form of system() to avoid having the path to
60611         TestWebKitAPI.exe be split by the shell.
60612
60613 2011-05-16  Ian Henderson  <ianh@apple.com>
60614
60615         Reviewed by Joseph Pecoraro.
60616
60617         Page::goToItem doesn't work while loading is deferred
60618         https://bugs.webkit.org/show_bug.cgi?id=60412
60619
60620         Add setDefersLoading and goBack methods to LayoutTestController.  We
60621         need to use goBack() instead of history.back() because the latter goes
60622         through NavigationScheduler, hence doesn't exhibit the bug.
60623
60624         * DumpRenderTree/LayoutTestController.cpp:
60625         (goBackCallback):
60626         (setDefersLoadingCallback):
60627         (LayoutTestController::staticFunctions):
60628         * DumpRenderTree/LayoutTestController.h:
60629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
60630         (LayoutTestController::goBack):
60631         (LayoutTestController::setDefersLoading):
60632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
60633         (LayoutTestController::goBack):
60634         (LayoutTestController::setDefersLoading):
60635         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
60636         (LayoutTestController::goBack):
60637         (LayoutTestController::setDefersLoading):
60638         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
60639         (LayoutTestController::goBack):
60640         (LayoutTestController::setDefersLoading):
60641
60642 2011-05-16  Sam Weinig  <sam@webkit.org>
60643
60644         Reviewed by Anders Carlsson.
60645
60646         TestWebKitAPI should build with clang if it can
60647         https://bugs.webkit.org/show_bug.cgi?id=60918
60648
60649         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
60650         Update CompilerVersion.xcconfig to match others.
60651
60652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60653         Add CompilerVersion.xcconfig to the project.
60654
60655         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
60656         (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
60657         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
60658         (TestWebKitAPI::didSameDocumentNavigationForFrame):
60659         Add some casts to quiet warnings from clang.
60660
60661 2011-05-16  Dirk Pranke  <dpranke@chromium.org>
60662
60663         Reviewed by David Levin.
60664
60665         add dpranke as a reviewer
60666         https://bugs.webkit.org/show_bug.cgi?id=60919
60667
60668         * Scripts/webkitpy/common/config/committers.py:
60669
60670 2011-05-16  Robert Hogan  <robert@webkit.org>
60671
60672         Reviewed by Anders Carlsson.
60673
60674         [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
60675
60676         https://bugs.webkit.org/show_bug.cgi?id=60838
60677
60678         The unix test plugin needs to call the test's NPP_URLNotify
60679         rather than the browsers.
60680
60681         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60682         (webkit_test_plugin_url_notify):
60683
60684 2011-05-16  Brent Fulgham  <bfulgham@webkit.org>
60685
60686         Rubber-stamped by Adam Roben.
60687
60688         Adding myself as a reviewer.
60689         * Scripts/webkitpy/common/config/committers.py:
60690
60691 2011-05-16  Sam Weinig  <sam@webkit.org>
60692
60693         Fix typo pointed out by Dave Levin.
60694
60695         * TestWebKitAPI/PlatformUtilities.h:
60696         (TestWebKitAPI::Util::assertWKStringEqual):
60697         Strig -> String.
60698
60699 2011-05-16  Sam Weinig  <sam@webkit.org>
60700
60701         Reviewed by David Levin.
60702
60703         Convert api tester over to using gtest expectations directly
60704         https://bugs.webkit.org/show_bug.cgi?id=60862
60705
60706         * TestWebKitAPI/PlatformUtilities.cpp:
60707         (TestWebKitAPI::Util::toSTD):
60708         * TestWebKitAPI/PlatformUtilities.h:
60709         (TestWebKitAPI::Util::assertWKStrigEqual):
60710         Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
60711         the implementation of the macro simpler.
60712
60713         * TestWebKitAPI/Test.h:
60714         Remove TEST_ASSERT forwarder.
60715
60716         [Test changes elided]
60717
60718 2011-05-16  David Kilzer  <ddkilzer@apple.com>
60719
60720         <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
60721         <rdar://problem/9446430>
60722
60723         Reviewed by Mark Rowe.
60724
60725         * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
60726         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
60727         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
60728
60729 2011-05-16  Jon Lee  <jonlee@apple.com>
60730
60731         Reviewed by Simon Fraser.
60732
60733         Can't horizontally scroll iframes and overflow because wheel events are always accepted
60734         https://bugs.webkit.org/show_bug.cgi?id=60779
60735
60736         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
60737         (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
60738
60739 2011-05-16  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
60740
60741         Reviewed by Csaba Osztrogonác.
60742
60743         [Qt] Tools.pro misses include(common.pri)
60744         https://bugs.webkit.org/show_bug.cgi?id=60883
60745
60746         It includes features.pri, which depends on common.pri (the build is
60747         not broken today with the default options, but this is the right
60748         thing to do).
60749
60750         * Tools.pro:
60751
60752 2011-05-15  Dominic Cooney  <dominicc@chromium.org>
60753
60754         Unreviewed: adding myself to committers.py.
60755
60756         * Scripts/webkitpy/common/config/committers.py:
60757
60758 2011-05-15  Daniel Bates  <dbates@webkit.org>
60759
60760         Reviewed by Chris Jerdonek.
60761
60762         svn-apply can't handle Git diff that only changes executable bit
60763         https://bugs.webkit.org/show_bug.cgi?id=60848
60764
60765         Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
60766         that only has an executable bit change.
60767
60768         * Scripts/VCSUtils.pm:
60769           - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
60770         (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
60771         fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
60772         * Scripts/svn-apply:
60773         (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
60774         * Scripts/svn-unapply:
60775         (patch): Ditto.
60776         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
60777           - Updated expected results for test cases to account for numTextChunks.
60778           - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
60779           - Added test case "Git: file that only has an executable bit change".
60780         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
60781           - Updated expected results for test cases to account for numTextChunks.
60782
60783 2011-05-15  Sam Weinig  <sam@webkit.org>
60784
60785         Fix windows build.
60786
60787         * TestWebKitAPI/win/main.cpp:
60788         (main):
60789
60790 2011-05-15  Sam Weinig  <sam@webkit.org>
60791
60792         Reviewed by David Levin.
60793
60794         Make API tester more gtest friendly
60795         https://bugs.webkit.org/show_bug.cgi?id=60859
60796
60797         * Scripts/run-api-tests:
60798         Numerous changes:
60799         - Remove logic to run tests one at a time.
60800         - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
60801           the test runner and allow gtest to print it for us.
60802         - Forward stdout from the test tool to stdout, even in non-verbose runs.
60803         - Run test tool from the current working directory instead of the root webkit
60804           directory.
60805
60806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
60807         Move plist to be with other bundle sources.
60808
60809         * TestWebKitAPI/TestsController.cpp:
60810         (TestWebKitAPI::TestsController::TestsController):
60811         (TestWebKitAPI::TestsController::run):
60812         * TestWebKitAPI/TestsController.h:
60813         * TestWebKitAPI/mac/main.mm:
60814         Simplify TestController down to a single run function. We should consider removing the class
60815         entirely at some point.
60816
60817 2011-05-15  Sheriff Bot  <webkit.review.bot@gmail.com>
60818
60819         Unreviewed, rolling out r86504.
60820         http://trac.webkit.org/changeset/86504
60821         https://bugs.webkit.org/show_bug.cgi?id=60853
60822
60823         "Broke Qt EventSender in editing/selection tests" (Requested
60824         by mwenge on #webkit).
60825
60826         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
60827         (WebCore::WebPage::WebPage):
60828         (WebCore::DumpRenderTree::DumpRenderTree):
60829         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
60830         (WebCore::DumpRenderTree::initJSObjects):
60831         * DumpRenderTree/qt/DumpRenderTreeQt.h:
60832         (WebCore::DumpRenderTree::eventSender):
60833         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60834         (webkit_test_plugin_new_instance):
60835         (webkit_test_plugin_set_window):
60836         (webkit_test_plugin_handle_event):
60837
60838 2011-05-12  Robert Hogan  <robert@webkit.org>
60839
60840         Reviewed by Benjamin Poulain.
60841
60842         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
60843
60844         The support for this test added to the unix test plugin here
60845         may allow other platforms to pass it (nearly everyone
60846         skips it). On Qt it required a bit of trickiness with
60847         the page's EventSender object to get it working fully though,
60848         so only unskipping Qt here.
60849
60850         https://bugs.webkit.org/show_bug.cgi?id=60722
60851
60852         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
60853         (WebCore::WebPage::WebPage):
60854         (WebCore::WebPage::eventSender):
60855         (WebCore::DumpRenderTree::DumpRenderTree):
60856         (WebCore::DumpRenderTree::initJSObjects):
60857         (WebCore::DumpRenderTree::createWindow):
60858         * DumpRenderTree/qt/DumpRenderTreeQt.h:
60859         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60860         (webkit_test_plugin_new_instance):
60861         (webkit_test_plugin_set_window):
60862         (webkit_test_plugin_handle_event):
60863
60864 2011-05-14  Arno Renevier  <arno@renevier.net>
60865
60866         Reviewed by Martin Robinson.
60867
60868         make run-gtk-tests executable
60869         https://bugs.webkit.org/show_bug.cgi?id=59278
60870
60871         * Scripts/run-gtk-tests:
60872
60873 2011-05-14  Anders Carlsson  <andersca@apple.com>
60874
60875         Reviewed by Kevin Decker.
60876
60877         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
60878         https://bugs.webkit.org/show_bug.cgi?id=60823
60879         <rdar://problem/9430386>
60880
60881         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
60882
60883         * DumpRenderTree/DumpRenderTree.gypi:
60884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60885         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
60886         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
60887         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
60888         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
60889         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
60890         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
60891         * GNUmakefile.am:
60892
60893 2011-05-14  Sheriff Bot  <webkit.review.bot@gmail.com>
60894
60895         Unreviewed, rolling out r86476.
60896         http://trac.webkit.org/changeset/86476
60897         https://bugs.webkit.org/show_bug.cgi?id=60832
60898
60899         It made plugins/get-url-notify-with-url-that-fails-to-
60900         load.html crash on GTK (Requested by Ossy on #webkit).
60901
60902         * DumpRenderTree/DumpRenderTree.gypi:
60903         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60904         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
60905         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
60906         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
60907         * GNUmakefile.am:
60908
60909 2011-05-13  Anders Carlsson  <andersca@apple.com>
60910
60911         Reviewed by Sam Weinig.
60912
60913         NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
60914         https://bugs.webkit.org/show_bug.cgi?id=60823
60915         <rdar://problem/9430386>
60916
60917         Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
60918
60919         * DumpRenderTree/DumpRenderTree.gypi:
60920         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60921         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
60922         (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
60923         (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
60924         (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
60925         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
60926         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
60927         * GNUmakefile.am:
60928
60929 2011-05-13  Anders Carlsson  <andersca@apple.com>
60930
60931         Build fix.
60932
60933         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
60934
60935 2011-05-13  Anders Carlsson  <andersca@apple.com>
60936
60937         Reviewed by Sam Weinig.
60938
60939         NPN_GetURL with a javascript: URL doesn't send back the result in the stream
60940         https://bugs.webkit.org/show_bug.cgi?id=60810
60941
60942         Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
60943
60944         * DumpRenderTree/DumpRenderTree.gypi:
60945         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
60946         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
60947         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
60948         * GNUmakefile.am:
60949         Add files.
60950
60951         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
60952         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
60953         Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
60954
60955         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
60956         (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
60957         (GetURLWithJavaScriptURL::NPP_New):
60958         (GetURLWithJavaScriptURL::NPP_NewStream):
60959         (GetURLWithJavaScriptURL::NPP_DestroyStream):
60960         (GetURLWithJavaScriptURL::NPP_WriteReady):
60961         (GetURLWithJavaScriptURL::NPP_Write):
60962         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
60963         (NPP_NewStream):
60964         (NPP_WriteReady):
60965         (NPP_Write):
60966         (NPP_URLNotify):
60967         call the PluginTest NPP wrappers.
60968
60969 2011-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>
60970
60971         Unreviewed, rolling out r86447.
60972         http://trac.webkit.org/changeset/86447
60973         https://bugs.webkit.org/show_bug.cgi?id=60809
60974
60975         "Broke some uses of EventSender object on Qt" (Requested by
60976         mwenge on #webkit).
60977
60978         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
60979         (WebCore::WebPage::WebPage):
60980         (WebCore::DumpRenderTree::DumpRenderTree):
60981         (WebCore::DumpRenderTree::initJSObjects):
60982         (WebCore::DumpRenderTree::createWindow):
60983         * DumpRenderTree/qt/DumpRenderTreeQt.h:
60984         (WebCore::DumpRenderTree::eventSender):
60985         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
60986         (webkit_test_plugin_new_instance):
60987         (webkit_test_plugin_set_window):
60988         (webkit_test_plugin_handle_event):
60989
60990 2011-05-13  Robert Hogan  <robert@webkit.org>
60991
60992         Reviewed by Benjamin Poulain.
60993
60994         [Qt] fix http/tests/plugins/plugin-document-has-focus.html
60995
60996         The support for this test added to the unix test plugin here
60997         may allow other platforms to pass it (nearly everyone
60998         skips it). On Qt it required a bit of trickiness with
60999         the page's EventSender object to get it working fully though,
61000         so only unskipping Qt here.
61001
61002         https://bugs.webkit.org/show_bug.cgi?id=60722
61003
61004         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
61005         (WebCore::WebPage::WebPage):
61006         (WebCore::WebPage::eventSender):
61007         (WebCore::DumpRenderTree::DumpRenderTree):
61008         (WebCore::DumpRenderTree::initJSObjects):
61009         (WebCore::DumpRenderTree::createWindow):
61010         * DumpRenderTree/qt/DumpRenderTreeQt.h:
61011         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
61012         (webkit_test_plugin_new_instance):
61013         (webkit_test_plugin_set_window):
61014         (webkit_test_plugin_handle_event):
61015
61016 2011-05-13  Adam Roben  <aroben@apple.com>
61017
61018         Exclude the Leopard NRWT bot from the core builder set
61019
61020         Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
61021
61022         Reviewed by Darin Adler.
61023
61024         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
61025         (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
61026         in the core builder set.
61027
61028         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
61029         (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
61030         regexps.
61031
61032 2011-05-13  Adam Roben  <aroben@apple.com>
61033
61034         Group all the NRWT bots together
61035
61036         This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
61037         bots are experimental, it seems best not to clutter up the non-experimental bots with
61038         experimental ones.
61039
61040         Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
61041         on build.webkit.org
61042
61043         Reviewed by Dan Bernstein.
61044
61045         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
61046         Chromium testers, which also use new-run-webkit-tests.
61047
61048 2011-05-13  Adam Roben  <aroben@apple.com>
61049
61050         Add a plugin test that dumps the plugin window's rect
61051
61052         Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
61053         (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
61054
61055         Reviewed by Dan Bernstein.
61056
61057         * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
61058         (DumpWindowRect::DumpWindowRect): Just call up to the base class.
61059         (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
61060         harness window and log it.
61061
61062         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
61063
61064 2011-05-13  Adam Roben  <aroben@apple.com>
61065
61066         Move code required for most tests of plugin window geometry into a base class
61067
61068         WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
61069         having all the trickiness in a shared base class, writing new window geometry tests will be
61070         much easier.
61071
61072         Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
61073
61074         Reviewed by Anders Carlsson.
61075
61076         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
61077         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
61078         WindowGeometryTest base class. Most of the code from this class was moved to the new base
61079         class.
61080         (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
61081         This is called by the base class when it is safe to check the window's geometry. Note that
61082         the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
61083         just vestigial code from an earlier version of this test.
61084
61085         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
61086         WindowGeometryTest class.
61087
61088         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
61089         WindowRegionIsSetToClipRect.
61090         (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
61091         We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
61092         Subclasses can implement that function to perform their own tests.
61093
61094         * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
61095
61096 2011-05-13  Zoltan Herczeg  <zherczeg@webkit.org>
61097
61098         Reviewed by Csaba Osztrogonác.
61099
61100         Missing 2nd #EOF if WebProcess is killed.
61101         https://bugs.webkit.org/show_bug.cgi?id=60761
61102
61103         If the WebProcess is killed, only one #EOF is yielded
61104         by WebKitTestRunner. However, run-webkit-test wait for
61105         a second #EOF, which signals the finishing of pixel dump.
61106         Since this never happens, run-webkit-test waits forever.
61107
61108         * WebKitTestRunner/TestInvocation.cpp:
61109         (WTR::TestInvocation::dump):
61110         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
61111         * WebKitTestRunner/TestInvocation.h:
61112
61113 2011-05-13  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
61114
61115         Reviewed by Csaba Osztrogonác.
61116
61117         [NRWT] chromium-linux tests shouldn't run on other platforms
61118         https://bugs.webkit.org/show_bug.cgi?id=60162
61119
61120         Remove _tests_for_other_platforms defs because r82753
61121         implemented it properly in the baseclass in webkit.py.
61122
61123         * Scripts/webkitpy/layout_tests/port/gtk.py:
61124         * Scripts/webkitpy/layout_tests/port/qt.py:
61125         * Scripts/webkitpy/layout_tests/port/win.py:
61126
61127 2011-05-12  Ryuan Choi  <ryuan.choi@samsung.com>
61128
61129         Reviewed by Antonio Gomes.
61130
61131         [EFL] Remove unused option of EWeblauncher
61132         https://bugs.webkit.org/show_bug.cgi?id=60747
61133
61134         Remove sudo-workaround option.
61135         This option is not used and make other option wrong.
61136
61137         * EWebLauncher/main.c:
61138
61139 2011-05-12  Lucas Forschler  <lforschler@apple.com>
61140
61141         Reviewed by Stephanie Lewis.
61142
61143         Fix config.json to address missing WK2 builder/tester config.
61144         Fix naming of machines (xserve not macpro)
61145
61146         * BuildSlaveSupport/build.webkit.org-config/config.json:
61147
61148 2011-05-12  Lucas Forschler  <lforschler@apple.com>
61149
61150         Reviewed by Stephanie Lewis.
61151
61152         Add SnowLeopard Debug builder and Test bot.
61153         apple-xserve-8 = SL Debug Tester.
61154         apple-xserve-9 = SL Debug Builder.
61155
61156         * BuildSlaveSupport/build.webkit.org-config/config.json:
61157
61158 2011-05-12  Adam Barth  <abarth@webkit.org>
61159
61160         This patch disables sheriffbot's bug postings.  He's just been way too
61161         spammy recently due to test flakiness.
61162
61163         * Scripts/webkitpy/tool/commands/sheriffbot.py:
61164         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
61165
61166 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
61167
61168         Reviewed by Anders Carlsson.
61169
61170         After relaunching an unresponsive web process, web page stops responding to mouse movement
61171         https://bugs.webkit.org/show_bug.cgi?id=60669
61172         <rdar://problem/9409934>
61173
61174         This test follows the steps needed to reproduce this bug:
61175         1) Hang the web process
61176         2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
61177         3) Kill and restart the WebProcess
61178         4) Move the mouse
61179
61180         We are testing that we receive mouse move events after the WebProcess has restarted.
61181
61182         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
61183         (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
61184         (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
61185         (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
61186         (TestWebKitAPI::setPageLoaderClient):
61187         (TestWebKitAPI::TEST):
61188         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
61189         (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
61190         (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
61191         * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
61192
61193         * TestWebKitAPI/PlatformWebView.h:
61194         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
61195         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
61196         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
61197         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
61198
61199         Add new files.
61200         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61201         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
61202         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
61203         * TestWebKitAPI/win/copy-resources.cmd:
61204
61205 2011-05-12  Tomasz Morawski  <t.morawski@samsung.com>
61206
61207         Reviewed by Antonio Gomes.
61208
61209         [EFL] Added initialization/shutdown for ecore_file library
61210         https://bugs.webkit.org/show_bug.cgi?id=60457
61211
61212         Added initialization and shuthown for ecore_file library and replaced
61213         realpath function to ecore_file_realpath.
61214
61215         * EWebLauncher/main.c:
61216         (quit):
61217         (findThemePath):
61218         (main):
61219
61220 2011-05-12  Young Han Lee  <joybro@company100.net>
61221
61222         Reviewed by Kenneth Rohde Christiansen.
61223
61224         [Qt] Implement layoutTestController.layerTreeAsText()
61225         https://bugs.webkit.org/show_bug.cgi?id=60367
61226
61227         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61228         (LayoutTestController::layerTreeAsText):
61229         * DumpRenderTree/qt/LayoutTestControllerQt.h:
61230
61231 2011-05-11  Eric Seidel  <eric@webkit.org>
61232
61233         Reviewed by David Levin.
61234
61235         Teach validate-committer-lists how to validate committers bugzilla_email()
61236         https://bugs.webkit.org/show_bug.cgi?id=60651
61237
61238         It turns out we currently have 9 committers with invalid values for their
61239         bugzilla_email field (meaning we don't know what email is their bugzilla account).
61240         "Alexander Kellett" <lypanov@mac.com>
61241         "Andre Boule" <aboule@apple.com>
61242         "Cameron McCormack" <cam@webkit.org>
61243         "Chris Petersen" <cpetersen@apple.com>
61244         "Eli Fidler" <eli@staikos.net>
61245         "Matt Lilek" <webkit@mattlilek.com>
61246         "Pierre d'Herbemont" <pdherbemont@free.fr>
61247         "Scott Violet" <sky@chromium.org>
61248         "Adam Treat" <treat@kde.org>
61249
61250         Most of those haven't committed in a very long time, so it's not suprising
61251         that we haven't noticed that their bugzilla emails are bogus.
61252
61253         * Scripts/validate-committer-lists:
61254         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
61255         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
61256
61257 2011-05-11  Dmitry Lomov  <dslomov@google.com>
61258
61259         Reviewed by David Levin.
61260
61261         https://bugs.webkit.org/show_bug.cgi?id=59561
61262         Switch TestWebKitAPI to GTest
61263
61264         Fixes Makefiles and WinCairo build as well
61265
61266         * Makefile:
61267         * Scripts/build-api-tests:
61268         * Scripts/run-api-tests:
61269         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
61270         * TestWebKitAPI/Test.h:
61271         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61272         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
61273         (TestWebKitAPI::TEST):
61274         * TestWebKitAPI/TestsController.cpp:
61275         (TestWebKitAPI::TestsController::TestsController):
61276         (TestWebKitAPI::TestsController::dumpTestNames):
61277         (TestWebKitAPI::TestsController::runTestNamed):
61278         (TestWebKitAPI::TestsController::runAllTests):
61279         * TestWebKitAPI/TestsController.h:
61280         * TestWebKitAPI/mac/main.mm:
61281         (main):
61282
61283 2011-05-11  Eric Seidel  <eric@webkit.org>
61284
61285         Reviewed by Alexey Proskuryakov.
61286
61287         Add Luke Macpherson to committers.py as a Contributor
61288         https://bugs.webkit.org/show_bug.cgi?id=60639
61289
61290         * Scripts/webkitpy/common/config/committers.py:
61291
61292 2011-05-11  Noam Rosenthal  <noam.rosenthal@nokia.com>
61293
61294         Reviewed by Kenneth Rohde Christiansen.
61295
61296         [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
61297         https://bugs.webkit.org/show_bug.cgi?id=60439
61298
61299         Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
61300
61301         * Scripts/build-webkit:
61302
61303 2011-05-11  Brian Weinstein  <bweinstein@apple.com>
61304
61305         Reviewed by Adam Roben.
61306
61307         REGRESSION (r86161): WKPreferences API test failing on Windows
61308         https://bugs.webkit.org/show_bug.cgi?id=60658
61309
61310         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
61311         (TestWebKitAPI::TEST):
61312
61313 2011-05-11  Alice Boxhall  <aboxhall@chromium.org>
61314
61315         Reviewed by Ojan Vafai.
61316
61317         Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
61318         https://bugs.webkit.org/show_bug.cgi?id=60521
61319
61320         First steps towards making the results JSON all hierarchical.
61321
61322         * TestResultServer/model/jsonresults.py:
61323         * TestResultServer/model/jsonresults_unittest.py:
61324
61325 2011-05-11  Kevin Ollivier  <kevino@theolliviers.com>
61326
61327         [wx] Build fix, adding new LayoutTestController method stubs.
61328
61329         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
61330         (LayoutTestController::localStorageDiskUsageForOrigin):
61331         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61332
61333 2011-05-11  Jessie Berlin  <jberlin@apple.com>
61334
61335         Reviewed by Darin Adler.
61336
61337         [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
61338         about the usage for both the origin overall and the database in question.
61339         https://bugs.webkit.org/show_bug.cgi?id=60573
61340
61341         * WebKitTestRunner/TestController.cpp:
61342         (WTR::exceededDatabaseQuota):
61343
61344 2011-05-10  Stephen White  <senorblanco@chromium.org>
61345
61346         Reviewed by David Levin.
61347
61348         Adding myself as a reviewer.
61349         https://bugs.webkit.org/show_bug.cgi?id=60587
61350
61351         * Scripts/webkitpy/common/config/committers.py:
61352
61353 2011-05-11  Eric Seidel  <eric@webkit.org>
61354
61355         Reviewed by Csaba Osztrogonác.
61356
61357         queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
61358         https://bugs.webkit.org/show_bug.cgi?id=60614
61359
61360         AppEngine has a result limit of 1000.  We hit that when trying
61361         to find out how many patches the style-queue (and other queues)
61362         have passed in the last 30 days.  So lets display 1000+ instead
61363         of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
61364
61365         I also made the status pages show "never" instead of just "ago" when we
61366         haven't seen a pass or boot message in the last 1000 messages.
61367
61368         * QueueStatusServer/handlers/queuestatus.py:
61369         * QueueStatusServer/templates/queuestatus.html:
61370
61371 2011-05-11  Adam Barth  <abarth@webkit.org>
61372
61373         Reviewed by Eric Seidel.
61374
61375         sheriffbot shouldn't spam bugs when it can't figure out who to blame
61376         https://bugs.webkit.org/show_bug.cgi?id=60613
61377
61378         This patch limits the number of bugs sheriffbot will spam to three.
61379         Ideally, we'd come up with some smarter huerstics, but hopefully this
61380         will cut down on the bugmail spam for slow bots.
61381
61382         * Scripts/webkitpy/tool/commands/sheriffbot.py:
61383
61384 2011-05-10  Eric Seidel  <eric@webkit.org>
61385
61386         Reviewed by Adam Barth.
61387
61388         EWS bots should be robust against test-webkitpy hangs
61389         https://bugs.webkit.org/show_bug.cgi?id=60579
61390
61391         Added a killAfterTimeout subroutine, which takes a child_pid
61392         and timeout, and will setup a watchdog process to kill that child
61393         after the timeout.  killAfterTimeout will waitpid on the child.
61394
61395         * EWSTools/start-queue.sh:
61396
61397 2011-05-10  MORITA Hajime  <morrita@google.com>
61398
61399         Unreviewed, moved myself to the reviewers list.
61400
61401         * Scripts/webkitpy/common/config/committers.py:
61402
61403 2011-05-10  Anton D'Auria  <adauria@apple.com>
61404
61405         Reviewed by David Levin.
61406
61407         StorageTracker should report actual local storage usage on disk
61408         https://bugs.webkit.org/show_bug.cgi?id=60558
61409
61410         * DumpRenderTree/LayoutTestController.cpp:
61411         (localStorageDiskUsageForOriginCallback):
61412         (LayoutTestController::staticFunctions):
61413         * DumpRenderTree/LayoutTestController.h:
61414         * DumpRenderTree/chromium/LayoutTestController.cpp:
61415         (LayoutTestController::LayoutTestController):
61416         (LayoutTestController::localStorageDiskUsageForOrigin):
61417         * DumpRenderTree/chromium/LayoutTestController.h:
61418         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
61419         (LayoutTestController::localStorageDiskUsageForOrigin):
61420         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
61421         (LayoutTestController::localStorageDiskUsageForOrigin):
61422         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61423         (LayoutTestController::localStorageDiskUsageForOrigin):
61424         * DumpRenderTree/qt/LayoutTestControllerQt.h:
61425         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
61426         (LayoutTestController::localStorageDiskUsageForOrigin):
61427
61428 2011-05-10  Anton D'Auria  <adauria@apple.com>
61429
61430         Reviewed by Alexey Proskuryakov.
61431
61432         Add ApplicationCache API to get disk usage per origin
61433         https://bugs.webkit.org/show_bug.cgi?id=57127
61434
61435         Added test that loads two frames with ~15Kb image, checks usage,
61436         deletes app cache, verifies usage is 0.
61437
61438         * DumpRenderTree/LayoutTestController.cpp:
61439         (applicationCacheDiskUsageForOriginCallback):
61440         (LayoutTestController::staticFunctions):
61441         * DumpRenderTree/LayoutTestController.h:
61442         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
61443         (LayoutTestController::LayoutTestController):
61444         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61445         * DumpRenderTree/chromium/LayoutTestController.h:
61446         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
61447         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61448         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
61449         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61450         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
61451         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61452         * DumpRenderTree/qt/LayoutTestControllerQt.h:
61453         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
61454         (LayoutTestController::applicationCacheDiskUsageForOrigin):
61455
61456 2011-05-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
61457
61458         Unreviewed, adding Rafael Antognolli as a committer.
61459
61460         * Scripts/webkitpy/common/config/committers.py:
61461
61462 2011-05-10  Chris Evans  <cevans@chromium.org>
61463
61464         Reviewed by Adam Barth.
61465
61466         Add WebCore::Setting to block displaying and/or running insecure content on secure pages
61467         https://bugs.webkit.org/show_bug.cgi?id=58378
61468
61469         * DumpRenderTree/chromium/LayoutTestController.cpp:
61470         (LayoutTestController::LayoutTestController):
61471         (LayoutTestController::setAllowDisplayOfInsecureContent):
61472         (LayoutTestController::setAllowRunningOfInsecureContent):
61473         * DumpRenderTree/chromium/LayoutTestController.h:
61474         * DumpRenderTree/chromium/WebPreferences.cpp:
61475         (WebPreferences::reset):
61476         (WebPreferences::applyTo):
61477         * DumpRenderTree/chromium/WebPreferences.h:
61478         Add plumbing for new settings to Chromium DRT.
61479
61480 2011-05-10  Enrica Casucci  <enrica@apple.com>
61481
61482         Reviewed by Beth Dakin.
61483
61484         Added my name to the reviewers list and removed my name from
61485         to committer-only list.
61486
61487         * Scripts/webkitpy/common/config/committers.py:
61488
61489 2011-05-10  David Levin  <levin@chromium.org>
61490
61491         Reviewed by Shinichiro Hamaji.
61492
61493         check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
61494         https://bugs.webkit.org/show_bug.cgi?id=60466
61495
61496         * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
61497         * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
61498           that property was removed.
61499         * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
61500           filtering for errors.
61501         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
61502           verify that the line filtering is turned off.
61503         * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
61504           and remove the unused file_path parameter.
61505         * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
61506           line filtering is turned off (and fix test_no_error).
61507         * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
61508           of errors based on the lines changed in the patch.
61509         * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
61510           the filtering.
61511
61512 2011-05-10  Adam Roben  <aroben@apple.com>
61513
61514         Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
61515
61516         Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
61517         platform/win/plugins/window-geometry-initialized-before-set-window.html and
61518         platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
61519         (WebKit2 Tests)
61520
61521         Reviewed by Anders Carlsson.
61522
61523         * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
61524         (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
61525         WindowedPluginTest::testHarnessWindow function.
61526
61527         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
61528         (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
61529         its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
61530         turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
61531         created for.
61532
61533         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
61534         (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
61535         WindowedPluginTest, and initialized new members.
61536         (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
61537         to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
61538         (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
61539         then clean up and tell the test harness we're done.
61540         (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
61541         from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
61542         (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
61543         if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
61544         window becomes visible.
61545         (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
61546         if it was hidden at the start of the test.
61547         (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
61548         This should cause our window to become visible and our window region to get set. When we get
61549         a WM_WINDOWPOSCHANGED message, we can finally finish the test.
61550         (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
61551         (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
61552         "startTest".
61553         (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
61554
61555         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
61556         (WindowedPluginTest::testHarnessWindow):
61557         * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
61558         Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
61559
61560 2011-05-10  Csaba Osztrogonác  <ossy@webkit.org>
61561
61562         Reviewed by Kenneth Rohde Christiansen.
61563
61564         [Qt] Add new qt-4.8 platform for layout testing
61565         https://bugs.webkit.org/show_bug.cgi?id=60544
61566
61567         * Scripts/old-run-webkit-tests:
61568         * Scripts/webkitdirs.pm:
61569
61570 2011-05-09  Sheriff Bot  <webkit.review.bot@gmail.com>
61571
61572         Unreviewed, rolling out r86108.
61573         http://trac.webkit.org/changeset/86108
61574         https://bugs.webkit.org/show_bug.cgi?id=60533
61575
61576         Broke makefile based builds and Cairo (Requested by weinig on
61577         #webkit).
61578
61579         * Scripts/build-api-tests:
61580         * Scripts/run-api-tests:
61581         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
61582         * TestWebKitAPI/Test.h:
61583         (TestWebKitAPI::Test::~Test):
61584         (TestWebKitAPI::Test::name):
61585         (TestWebKitAPI::Test::Register::Register):
61586         (TestWebKitAPI::Test::Register::create):
61587         (TestWebKitAPI::Test::Test):
61588         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61589         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
61590         (TestWebKitAPI::TEST):
61591         * TestWebKitAPI/TestsController.cpp:
61592         (TestWebKitAPI::TestsController::TestsController):
61593         (TestWebKitAPI::TestsController::dumpTestNames):
61594         (TestWebKitAPI::TestsController::runTestNamed):
61595         (TestWebKitAPI::TestsController::testFailed):
61596         (TestWebKitAPI::TestsController::registerCreateTestFunction):
61597         * TestWebKitAPI/TestsController.h:
61598         * TestWebKitAPI/mac/main.mm:
61599         (main):
61600
61601 2011-05-09  Hayato Ito  <hayato@chromium.org>
61602
61603         Reviewed by Ojan Vafai.
61604
61605         Skip reftests if pixel tests are disabled.
61606
61607         https://bugs.webkit.org/show_bug.cgi?id=59078
61608
61609         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
61610         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
61611         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
61612         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
61613
61614 2011-05-09  Chang Shu  <cshu@webkit.org>
61615
61616         Reviewed by Kenneth Rohde Christiansen.
61617
61618         [Qt] DumpRenderTreeQt needs an implementation of unmarkText
61619         https://bugs.webkit.org/show_bug.cgi?id=60499
61620
61621         The implementation is similar to gtk.
61622
61623         * DumpRenderTree/qt/TextInputControllerQt.cpp:
61624         (TextInputController::unmarkText):
61625         * DumpRenderTree/qt/TextInputControllerQt.h:
61626
61627 2011-05-09  James Robinson  <jamesr@chromium.org>
61628
61629         Reviewed by Eric Seidel.
61630
61631         [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
61632         https://bugs.webkit.org/show_bug.cgi?id=60520
61633
61634         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
61635
61636 2011-05-09  Dmitry Lomov  <dslomov@google.com>
61637
61638         Reviewed by Sam Weinig.
61639
61640         Switch TestWebKitAPI to GTest
61641         https://bugs.webkit.org/show_bug.cgi?id=59561
61642
61643         * Scripts/build-api-tests:
61644         * Scripts/run-api-tests:
61645         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
61646         * TestWebKitAPI/Test.h:
61647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
61648         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
61649         (TestWebKitAPI::TEST):
61650         * TestWebKitAPI/TestsController.cpp:
61651         (TestWebKitAPI::TestsController::TestsController):
61652         (TestWebKitAPI::TestsController::dumpTestNames):
61653         (TestWebKitAPI::TestsController::runTestNamed):
61654         (TestWebKitAPI::TestsController::runAllTests):
61655         * TestWebKitAPI/TestsController.h:
61656         * TestWebKitAPI/mac/main.mm:
61657         (main):
61658
61659 2011-05-09  Igor Oliveira  <igor.oliveira@openbossa.org>
61660
61661         Reviewed by Andreas Kling.
61662
61663         [Qt] DRT eventSender.addTouchPoint method is not setting the start position
61664         https://bugs.webkit.org/show_bug.cgi?id=60487
61665
61666         When adding a new touch point, the start position of this point needs to be set.
61667
61668         * DumpRenderTree/qt/EventSenderQt.cpp:
61669         (EventSender::addTouchPoint):
61670
61671 2011-05-09  Robert Hogan  <robert@webkit.org>
61672
61673         Reviewed by Adam Roben.
61674
61675         https://bugs.webkit.org/show_bug.cgi?id=57137
61676
61677         Unskip plugins/embed-prefers-plugins-for-images.html
61678
61679         Add image/png mime-type to test netscape plugin on Unix.
61680
61681         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
61682         (NP_GetMIMEDescription):
61683
61684 2011-05-09  Alice Boxhall  <aboxhall@chromium.org>
61685
61686         Reviewed by Ojan Vafai.
61687
61688         Pull jsonresults_unittest test cases out into separate test methods.
61689         https://bugs.webkit.org/show_bug.cgi?id=60418
61690
61691         * TestResultServer/model/jsonresults_unittest.py:
61692
61693 2011-05-09  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
61694
61695         Reviewed by Andreas Kling.
61696
61697         [Qt] fix fast/dom/Geolocation/window-close-crash.html
61698         https://bugs.webkit.org/show_bug.cgi?id=60458
61699
61700         Update all pages with Mock position/error/permission.
61701
61702         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61703         (LayoutTestController::setGeolocationPermission):
61704         (LayoutTestController::setMockGeolocationError):
61705         (LayoutTestController::setMockGeolocationPosition):
61706
61707 2011-05-09  Shishir Agrawal  <shishir@chromium.org>
61708
61709         Reviewed by Tony Gentilcore.
61710
61711         Implement Page Visibility API.
61712         https://bugs.webkit.org/show_bug.cgi?id=54181
61713
61714         * DumpRenderTree/LayoutTestController.cpp:
61715         (setPageVisibilityCallback):
61716         (resetPageVisibilityCallback):
61717         (LayoutTestController::staticFunctions):
61718         * DumpRenderTree/LayoutTestController.h:
61719         (LayoutTestController::setPageVisibility):
61720         (LayoutTestController::resetPageVisibility):
61721         * DumpRenderTree/chromium/LayoutTestController.cpp:
61722         (LayoutTestController::LayoutTestController):
61723         (LayoutTestController::resetPageVisibility):
61724         (LayoutTestController::setPageVisibility):
61725         * DumpRenderTree/chromium/LayoutTestController.h:
61726
61727 2011-05-07  Adam Barth  <abarth@webkit.org>
61728
61729         Reviewed by Eric Seidel.
61730
61731         Testing EWS spins on patches with a large number of failures
61732         https://bugs.webkit.org/show_bug.cgi?id=60441
61733
61734         In cases where the tree has a small number of persistent failures but a
61735         patch has a large number of failures, we weren't believing any results.
61736         That lead to us retrying the patch forever while we waited for
61737         trustworthy results that would never come.
61738
61739         This patch loosens the semantics of unexpected_failures to return a
61740         subset (rather than the exact set) of unexpected failures.  In the case
61741         where the tree has a bounded number of failures and the patch has an
61742         unbounded number of failures, we can accurately compute such a subset
61743         and reject the patch.
61744
61745         * Scripts/webkitpy/tool/bot/expectedfailures.py:
61746         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
61747         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
61748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
61749         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
61750
61751 2011-05-07  Joe Mason  <jmason@rim.com>
61752
61753         Reviewed by Daniel Bates.
61754
61755         FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
61756         https://bugs.webkit.org/show_bug.cgi?id=52211
61757
61758         Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
61759         (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
61760
61761         * DumpRenderTree/chromium/WebViewHost.cpp:
61762         (WebViewHost::willPerformClientRedirect):
61763         (WebViewHost::didStartProvisionalLoad):
61764         * DumpRenderTree/mac/FrameLoadDelegate.mm:
61765         (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
61766
61767 2011-05-07  Daniel Bates  <dbates@webkit.org>
61768
61769         Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
61770         <http://trac.webkit.org/changeset/86007> (bug #60438).
61771
61772         * Scripts/old-run-webkit-tests:
61773           - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
61774             file local variable.
61775
61776 2011-05-07  Pratik Solanki  <psolanki@apple.com>
61777
61778         Reviewed by Darin Adler.
61779
61780         Remove references to Tiger in scripts
61781         https://bugs.webkit.org/show_bug.cgi?id=60438
61782
61783         Remove isTiger() and all of the code that depends on it.
61784
61785         * Scripts/build-webkit:
61786         * Scripts/ensure-valid-python:
61787         * Scripts/gdb-safari:
61788         * Scripts/webkitdirs.pm:
61789
61790 2011-05-06  David Grogan  <dgrogan@chromium.org>
61791
61792         Reviewed by Eric Seidel.
61793
61794         update link to message about mac 64bit git binaries
61795         https://bugs.webkit.org/show_bug.cgi?id=60411
61796
61797         The original message implied (correctly, at-the-time) that
61798         http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
61799         binaries. The new message notes that they do. This might prevent someone
61800         else from spending a few minutes confused.
61801
61802         * Scripts/webkitpy/common/checkout/scm/git.py:
61803
61804 2011-05-06  Dirk Pranke  <dpranke@chromium.org>
61805
61806         Reviewed by Ojan Vafai.
61807
61808         new-run-webkit-tests: crashes in race with crashing DRT
61809         https://bugs.webkit.org/show_bug.cgi?id=60238
61810
61811         This fixes a race where if we wrote the URL to DRT and
61812         DRT crashed immediately, we could get a broken pipe
61813         error back during the write() and not handle it correctly,
61814         causing NRWT to also crash.
61815
61816         * Scripts/webkitpy/layout_tests/port/server_process.py:
61817         * Scripts/webkitpy/layout_tests/port/webkit.py:
61818
61819 2011-05-06  Adam Barth  <abarth@webkit.org>
61820
61821         Reviewed by Eric Seidel.
61822
61823         Add a --skip-integrationtests mode to test-webkitpy
61824         https://bugs.webkit.org/show_bug.cgi?id=60354
61825
61826         These two test suites account for 2/3 of test-webkitpy's running time
61827         because they're not actually unit tests.  They're integration tests.
61828         This patch adds the ability to skip integration tests by passing a
61829         command line argument to test-webkitpy.  The buildbots will continue to
61830         run these integration tests to make sure they don't regress.  This
61831         option is for use by developers when working on parts of the code that
61832         are well-covered by unit tests.
61833
61834         * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
61835         * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
61836         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
61837         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
61838         * Scripts/webkitpy/test/main.py:
61839
61840 2011-05-06  Adam Barth  <abarth@webkit.org>
61841
61842         Reviewed by Eric Seidel.
61843
61844         The results.zip generated by the Chromium EWS are too big
61845         https://bugs.webkit.org/show_bug.cgi?id=60352
61846
61847         Currently results.zip created by the Chromium EWS bot contain roughly
61848         1000 tests that we expect to fail.  These test results are not helpful
61849         to contributors.
61850
61851         There are several approaches to solving this problem:
61852
61853         1) We could be more selective about which files to include in the zip.
61854         2) We could ask new-run-webkit-tests not to generate results for
61855            expected failures.
61856         3) We could ask new-run-webkit-tests not to run tests that we expect to
61857            fail.
61858
61859         This patch takes approach (3).  Currently, we're ignoring the outcome
61860         of failing tests anyway, so there's not much point in actually running
61861         them.  As a side benefit, this will speed up the test run by about 6%.
61862         In the future, we might revisit this decision and choose another
61863         approach.
61864
61865         * Scripts/webkitpy/common/config/ports.py:
61866         * Scripts/webkitpy/common/config/ports_unittest.py:
61867
61868 2011-05-06  Gabor Rapcsanyi  <rgabor@webkit.org>
61869
61870         Reviewed by Csaba Osztrogonác.
61871
61872         [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
61873
61874         * Scripts/old-run-webkit-tests:
61875
61876 2011-05-06  Adam Barth  <abarth@webkit.org>
61877
61878         Reviewed by Ojan Vafai.
61879
61880         Add an option to NRWT to skip failing tests
61881         https://bugs.webkit.org/show_bug.cgi?id=60295
61882
61883         This option is similar to the way old-run-webkit-tests works.  We're
61884         planning to use this option on the testing EWS bots because they don't
61885         use information from failing tests yet.
61886
61887         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
61888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
61889         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
61890
61891 2011-05-04  Philippe Normand  <pnormand@igalia.com>
61892
61893         Reviewed by Dimitri Glazkov.
61894
61895         Implement LayoutTestController::pseudoShadowId()
61896         https://bugs.webkit.org/show_bug.cgi?id=60034
61897
61898         shadowPseudoId support in the various LayoutTestController
61899         implementations.
61900
61901         * DumpRenderTree/LayoutTestController.cpp:
61902         (shadowPseudoIdCallback):
61903         (LayoutTestController::staticFunctions):
61904         * DumpRenderTree/LayoutTestController.h:
61905         * DumpRenderTree/chromium/LayoutTestController.cpp:
61906         (LayoutTestController::LayoutTestController):
61907         (LayoutTestController::shadowPseudoId):
61908         * DumpRenderTree/chromium/LayoutTestController.h:
61909         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
61910         (LayoutTestController::shadowPseudoId):
61911         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
61912         (LayoutTestController::shadowPseudoId):
61913         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61914         (LayoutTestController::shadowPseudoId):
61915         * DumpRenderTree/qt/LayoutTestControllerQt.h:
61916         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
61917         (LayoutTestController::shadowPseudoId):
61918         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
61919         (LayoutTestController::shadowPseudoId):
61920         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
61921         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
61922         (WTR::LayoutTestController::shadowPseudoId):
61923         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
61924
61925 2011-05-06  Adam Barth  <abarth@webkit.org>
61926
61927         EWS can't reject patches
61928         https://bugs.webkit.org/show_bug.cgi?id=60345
61929
61930         We're supposed to use patch.id() for the attachment ID, silly.
61931
61932         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
61933         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
61934
61935 2011-05-05  Steve Lacey  <sjl@chromium.org>
61936
61937         Reviewed by Ojan Vafai.
61938
61939         Fix generation of results html file by passing relative path to scm
61940         methods.
61941         Generate diff images for results html file.
61942
61943         https://bugs.webkit.org/show_bug.cgi?id=60086
61944
61945         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
61946         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
61947
61948 2011-05-05  Andy Estes  <aestes@apple.com>
61949
61950         Reviewed by Daniel Bates.
61951
61952         update-webkit should handle Internal using a different VCS than OpenSource.
61953         https://bugs.webkit.org/show_bug.cgi?id=60310
61954
61955         isGit() and isSVN() cache their results, so Internal will always be
61956         updated using the VCS commands used for OpenSource. If Internal uses a
61957         different VCS, this will fail. Fix this by calling isGitDirectory() and
61958         isSVNDirectory() instead, which do not cache their results.
61959
61960         * Scripts/update-webkit:
61961
61962 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
61963
61964         Reviewed by Ojan Vafai.
61965
61966         nrwt: revamp integration tests incl. tests for servers
61967         https://bugs.webkit.org/show_bug.cgi?id=59985
61968
61969         This change adds the ability to run "integration tests" that
61970         depend on (and affect) the local environment on your machine.
61971         These tests can be run manually by invoking python on the
61972         test file in question and passing the '-i' flag, but are
61973         not run automatically as part of test-webkitpy.
61974
61975         Integration tests are identified by being methods named as
61976         "integration_test_*" instead of "test_*", and we use a
61977         custom TestLoader instead of the default one provided by
61978         unittest.
61979
61980         This change also adds a protected "_default_to_apache" method
61981         to the port object so we can do the right thing when starting
61982         and stopping web servers with less mechanism.
61983
61984         * Scripts/webkitpy/layout_tests/port/base.py:
61985         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
61986         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
61987         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
61988         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
61989         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
61990
61991 2011-05-05  Adam Roben  <aroben@apple.com>
61992
61993         Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
61994
61995         DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
61996         most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
61997         alpha channel will even get filled with zeros (like when ::GradientFill is used). To
61998         safeguard against this, we fill the alpha channel with constant full opacity after the
61999         WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
62000         just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
62001         channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
62002         results need an alpha channel, too.)
62003
62004         Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
62005         generated due to alpha channel weirdness
62006
62007         Reviewed by Sam Weinig.
62008
62009         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
62010         (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
62011         constant full opacity.
62012         (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
62013         in a CGContext or cairo_surface.
62014
62015 2011-05-05  Adam Roben  <aroben@apple.com>
62016
62017         Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
62018
62019         Passing true tells the test harness to dump pixels even though we're not dumping a render
62020         tree.
62021
62022         Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
62023         WebKitTestRunner doesn't result in pixel results being generated
62024
62025         Reviewed by Sam Weinig.
62026
62027         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
62028         argument to dumpAsText.
62029
62030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
62031         (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
62032
62033         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
62034         (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
62035
62036         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
62037
62038         * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
62039         developers.
62040
62041 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
62042
62043         Reviewed by Ojan Vafai.
62044
62045         new-run-webkit-tests: merge os, version fields in test config
62046         https://bugs.webkit.org/show_bug.cgi?id=60004
62047
62048         This change removes the 'o/s' field from the TestConfiguration
62049         object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
62050         the expectations file to macros that expand to the version names
62051         for each platform.
62052
62053         This means that you can once again put any subset of the
62054         operating system versions on a single line, e.g.:
62055           BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
62056
62057         This change will break any existing test_expectations.txt
62058         file that uses the "OS-VERSION" macros, which are no longer
62059         needed. It turns out they were never needed, as just VERSION
62060         by itself was sufficient. The test_expectations.txt file should
62061         be updated accordingly prior to landing this change.
62062
62063         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
62064         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
62065         * Scripts/webkitpy/layout_tests/port/base.py:
62066
62067 2011-05-05  Tony Chang  <tony@chromium.org>
62068
62069         Reviewed by Adam Barth.
62070
62071         [chromium] switch from Lucida to free fonts for Hindi and Thai
62072         https://bugs.webkit.org/show_bug.cgi?id=60287
62073
62074         The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
62075         packages on Lucid. There are actually multiple Thai fonts in the
62076         package, so I just picked one.
62077
62078         * DumpRenderTree/chromium/TestShellGtk.cpp:
62079         (setupFontconfig):
62080
62081 2011-05-05  Tony Chang  <tony@chromium.org>
62082
62083         Reviewed by Ojan Vafai.
62084
62085         [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
62086         https://bugs.webkit.org/show_bug.cgi?id=60290
62087
62088         It used to be that google-chrome-32 was hardy32, google-chrome-64 was
62089         hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
62090         lucid64.  Because of that, google-chrome-64 used to skip the
62091         chromium-linux-x86_64 results since they were more incorrect.
62092
62093         Now that we're switching to lucid for google-chrome, we want
62094         google-chrome-64 to fall back to chromium-linux-x86_64.
62095
62096         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
62097
62098 2011-05-05  Dirk Pranke  <dpranke@chromium.org>
62099
62100         Reviewed by Ojan Vafai.
62101
62102         new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
62103         https://bugs.webkit.org/show_bug.cgi?id=60002
62104
62105         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
62106         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
62107         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
62108         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
62109         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
62110         * Scripts/webkitpy/style/checkers/test_expectations.py:
62111
62112 2011-05-05  Eric Seidel  <eric@webkit.org>
62113
62114         Reviewed by Adam Barth.
62115
62116         commit-queue should reject patches which fail ewses
62117         https://bugs.webkit.org/show_bug.cgi?id=47534
62118
62119         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
62120         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62121         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62122
62123 2011-05-05  Chang Shu  <cshu@webkit.org>
62124
62125         Reviewed by Andreas Kling.
62126
62127         [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
62128         https://bugs.webkit.org/show_bug.cgi?id=59638
62129
62130         1. Call QGraphicsWKView constructor with pageGroupRef.
62131         2. Disable setFontFamily calls as it breaks Qt test fonts.
62132
62133         * WebKitTestRunner/TestController.cpp:
62134         (WTR::TestController::resetStateToConsistentValues):
62135         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
62136         (WTR::WebView::WebView):
62137         (WTR::PlatformWebView::PlatformWebView):
62138
62139 2011-05-05  Joseph Pecoraro  <joepeck@webkit.org>
62140
62141         Reviewed by David Kilzer.
62142
62143         Add --only-webkit option to build-webkit
62144         https://bugs.webkit.org/show_bug.cgi?id=60245
62145
62146         * Scripts/build-webkit: If --only-webkit was specified
62147         just build the WebKit project, and not its dependencies.
62148
62149 2011-05-05  Jeff Miller  <jeffm@apple.com>
62150
62151         Reviewed by Darin Adler.
62152
62153         Add didNotHandleWheelEvent callback to WKPageUIClient
62154         https://bugs.webkit.org/show_bug.cgi?id=60203
62155
62156         * MiniBrowser/gtk/BrowserWindow.c:
62157         (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
62158         * MiniBrowser/mac/BrowserWindowController.m:
62159         (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
62160         * MiniBrowser/win/BrowserView.cpp:
62161         (BrowserView::create): Stub out didNotHandleWheelEvent callback.
62162         * WebKitTestRunner/TestController.cpp:
62163         (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
62164         (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
62165
62166 2011-05-04  Eric Seidel  <eric@webkit.org>
62167
62168         Reviewed by Adam Barth.
62169
62170         Add more missing imports from scm refactor
62171         https://bugs.webkit.org/show_bug.cgi?id=60239
62172
62173         * Scripts/webkitpy/common/checkout/scm/git.py:
62174         * Scripts/webkitpy/common/checkout/scm/svn.py:
62175
62176 2011-05-04  Eric Seidel  <eric@webkit.org>
62177
62178         Reviewed by Adam Barth.
62179
62180         sheriff-bot is having more exception trouble
62181         https://bugs.webkit.org/show_bug.cgi?id=60233
62182
62183         A webpage-forced build was causing SB to throw an exception.
62184         We've long had this bug, but we just didn't notice it until now.
62185
62186         In debugging this I found we fetch an absurd amount of data now
62187         that we use buildbot's json (instead of xmlrpc), so I added
62188         the filter=1 parameter to reduce it a little.  That required
62189         me to handle the case where filter=1 would strip
62190         result=0 in some cases (it's unclear why it does that).
62191
62192         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
62193         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
62194
62195 2011-05-04  Cris Neckar  <cdn@chromium.org>
62196
62197         Unreviewed, Adding Cris Neckar as a committer
62198
62199         * Scripts/webkitpy/common/config/committers.py:
62200
62201 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
62202
62203         Reviewed by Laszlo Gombos.
62204
62205         [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
62206         https://bugs.webkit.org/show_bug.cgi?id=59462
62207
62208         * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.
62209
62210 2011-05-04  Eric Seidel  <eric@webkit.org>
62211
62212         Reviewed by Adam Barth.
62213
62214         The testing EWS bots should upload layout-test-results.zip to bugs after failures
62215         https://bugs.webkit.org/show_bug.cgi?id=60223
62216
62217         This required sharing a bit of code between the commit-queue
62218         (which already knew how to do this) and the new EWS testing bots.
62219
62220         In the process I also cleaned up EWS testing a little and
62221         removed some dead code from the commit-queue.
62222
62223         * Scripts/webkitpy/common/config/committervalidator.py:
62224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62225         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62226         * Scripts/webkitpy/tool/commands/queues.py:
62227         * Scripts/webkitpy/tool/commands/queues_unittest.py:
62228
62229 2011-05-04  James Kozianski  <koz@chromium.org>
62230
62231         Reviewed by Eric Seidel.
62232
62233         Add method to make a Port able to retrieve TestOutputSets from its builders.
62234         https://bugs.webkit.org/show_bug.cgi?id=58211
62235
62236         This will be used in the new rebaseline script - TestOutputs are
62237         potential new baselines.
62238
62239         * Scripts/webkitpy/common/config/urls.py:
62240         * Scripts/webkitpy/layout_tests/port/base.py:
62241         * Scripts/webkitpy/layout_tests/port/chromium.py:
62242         * Scripts/webkitpy/layout_tests/port/factory.py:
62243         * Scripts/webkitpy/layout_tests/port/webkit.py:
62244
62245 2011-05-04  Eric Seidel  <eric@webkit.org>
62246
62247         Reviewed by Ojan Vafai.
62248
62249         sheriff-bot can't parse results.html
62250         https://bugs.webkit.org/show_bug.cgi?id=60196
62251
62252         The problem was that the NRWT bots are currently core
62253         and so sheriff-bot was trying to diagnose failures on
62254         them.  It was trying to parse their results.html file
62255         and BeautifulSoup was throwing an exception.
62256
62257         It seems our version of BeautifulSoup was quite old
62258         and unable to handle <script> tags correctly.
62259         This moves us to 3.2 which doesn't seem to have this bug.
62260
62261         * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
62262
62263 2011-05-04  Adam Barth  <abarth@webkit.org>
62264
62265         Reviewed by Eric Seidel.
62266
62267         Make the EWS test logging less verbose
62268         https://bugs.webkit.org/show_bug.cgi?id=60201
62269
62270         This should help us generate less than a hundred MB of logs per hour.
62271
62272         * Scripts/webkitpy/common/config/ports.py:
62273         * Scripts/webkitpy/common/config/ports_unittest.py:
62274
62275 2011-05-04  Tao Bai  <michaelbai@chromium.org>
62276
62277         Reviewed by David Kilzer.
62278
62279         Populate touch-icon url to FrameLoaderClient
62280         https://bugs.webkit.org/show_bug.cgi?id=59143
62281
62282         Disable touch icon by default.
62283
62284         * Scripts/build-webkit:
62285
62286 2011-05-04  Justin Novosad  <junov@chromium.org>
62287
62288         Reviewed by Kenneth Russell.
62289
62290         [Chromium] Add gpu acceleration flags to DumpRenderTree
62291         https://bugs.webkit.org/show_bug.cgi?id=60168
62292         Adding support for command line flags
62293         enable-accelerated-2d-canvas an
62294         enable-accelerated-drawing in DumpRenderTree.
62295
62296         * DumpRenderTree/chromium/DumpRenderTree.cpp:
62297         (main):
62298         * DumpRenderTree/chromium/TestShell.cpp:
62299         (TestShell::TestShell):
62300         (TestShell::resetWebSettings):
62301         * DumpRenderTree/chromium/TestShell.h:
62302         (TestShell::setLegacyAccelerated2dCanvasEnabled):
62303         (TestShell::setAcceleratedDrawingEnabled):
62304         * DumpRenderTree/chromium/WebPreferences.cpp:
62305         (WebPreferences::reset):
62306         (WebPreferences::applyTo):
62307         * DumpRenderTree/chromium/WebPreferences.h:
62308
62309 2011-05-04  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
62310
62311         Reviewed by Csaba Osztrogonác.
62312
62313         [Qt] run-qtwebkit-tests misses exec bit
62314         https://bugs.webkit.org/show_bug.cgi?id=60188
62315
62316         Also removing an unecessary import (mostly to let this bugfix goes
62317         through the system, as this is just a chmod).
62318
62319         * Scripts/run-qtwebkit-tests:
62320
62321 2011-05-04  Adam Barth  <abarth@webkit.org>
62322
62323         Fix import of ircproxy module to actually import the module.  I don't
62324         really understand how this code could have worked before.
62325
62326         * Scripts/webkitpy/common/host.py:
62327
62328 2011-05-04  Siddharth Mathur  <siddharth.mathur@nokia.com>
62329
62330         Reviewed by Andreas Kling.
62331
62332         [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
62333         https://bugs.webkit.org/show_bug.cgi?id=60172
62334
62335         * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
62336         (BrowserWindow::BrowserWindow):
62337
62338 2011-05-04  Mihai Parparita  <mihaip@chromium.org>
62339
62340         Reviewed by Ojan Vafai.
62341
62342         [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
62343         https://bugs.webkit.org/show_bug.cgi?id=60088
62344
62345         Makes --new-baseline put new baselines into the first entry in the
62346         baseline search path, including any additional directories passed in via
62347         --additional-platform-directory.
62348
62349         Simplifies baseline_path() by making it return the first entry in the
62350         baseline search path instead of requiring each port to have an
62351         implementation (should not result in any behavior change).
62352
62353         * Scripts/webkitpy/layout_tests/port/base.py:
62354         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
62355         * Scripts/webkitpy/layout_tests/port/chromium.py:
62356         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
62357         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
62358         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
62359         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
62360         * Scripts/webkitpy/layout_tests/port/mac.py:
62361         * Scripts/webkitpy/layout_tests/port/test.py:
62362         * Scripts/webkitpy/layout_tests/port/webkit.py:
62363
62364 2011-05-04  Adam Barth  <abarth@webkit.org>
62365
62366         Reviewed by Eric Seidel.
62367
62368         Fix circular dependency in webkitpy
62369         https://bugs.webkit.org/show_bug.cgi?id=60075
62370
62371         These functions don't belong in bugzilla.py.  They only exist there
62372         because they are old.  Really, these functions shouldn't be free
62373         functions at all, but that's a patch for another day.
62374
62375         * Scripts/webkitpy/common/checkout/changelog.py:
62376         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
62377         * Scripts/webkitpy/common/checkout/checkout.py:
62378         * Scripts/webkitpy/common/config/urls.py:
62379         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
62380         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
62381         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
62382         * Scripts/webkitpy/style/checkers/changelog.py:
62383         * Scripts/webkitpy/tool/bot/irc_command.py:
62384         * Scripts/webkitpy/tool/bot/sheriff.py:
62385         * Scripts/webkitpy/tool/commands/upload.py:
62386
62387 2011-05-03  Pratik Solanki  <psolanki@apple.com>
62388
62389         Reviewed by Dan Bernstein.
62390
62391         https://bugs.webkit.org/show_bug.cgi?id=60141
62392         Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
62393
62394         * Scripts/build-webkit:
62395
62396 2011-05-03  Mihai Parparita  <mihaip@chromium.org>
62397
62398         Reviewed by Ojan Vafai.
62399
62400         Update rebaseline queue server to handle hierarchical test results
62401         https://bugs.webkit.org/show_bug.cgi?id=60063
62402
62403         Update test result parsing done by the rebaseline queue server to handle
62404         the hierarchical test result output that is generated as of r85254.
62405
62406         * RebaselineQueueServer/templates/builder-queue-edit.html:
62407
62408 2011-05-03  Eric Seidel  <eric@webkit.org>
62409
62410         Reviewed by Adam Roben.
62411
62412         webkit-patch post-commits HEAD^.. throws an exception
62413         https://bugs.webkit.org/show_bug.cgi?id=60027
62414
62415         * Scripts/webkitpy/common/checkout/scm/git.py:
62416
62417 2011-05-03  Luiz Agostini  <luiz.agostini@openbossa.org>
62418
62419         Reviewed by Kenneth Rohde Christiansen.
62420
62421         [Qt] Layout tests may timeout if loadFinished receives false
62422         https://bugs.webkit.org/show_bug.cgi?id=60064
62423
62424         When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
62425         then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
62426         a response is ignored, like it should be for 204 responses. It is a problem for creating
62427         tests for 204 responses for example.
62428
62429         This change has been tested and it causes no regressions in layout tests.
62430
62431         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
62432         (LayoutTestController::maybeDump):
62433
62434 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
62435
62436         Unreviewed, rolling out r85659.
62437         http://trac.webkit.org/changeset/85659
62438         https://bugs.webkit.org/show_bug.cgi?id=59977
62439
62440         restarting isn't working correctly
62441
62442         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
62443         * Scripts/webkitpy/layout_tests/port/http_server.py:
62444         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
62445         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
62446
62447 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
62448
62449         Reviewed by Ojan Vafai.
62450
62451         new-run-webkit-tests: fix http server startup/shutdown
62452
62453         Previous versions of the code had three problems that made startup
62454         and shutdown flaky. The first is that it would throw exceptions
62455         if it couldn't delete stale log files, which was overly
62456         paranoid. The second is that some of the exceptions weren't
62457         defined properly. The third, and most important, is that it was
62458         using urllib to check if ports were available, which was leaving
62459         sockets in a half-closed state, and keeping ports from being
62460         reused. By switching to raw sockets, we are able to now reliably
62461         restart.
62462
62463         This change also switches the code to using Executives to stop
62464         processes, which will let us delete a bunch of code in the
62465         port/* implementations and fix a weird layering problem in a
62466         subsequent patch.
62467
62468         https://bugs.webkit.org/show_bug.cgi?id=59977
62469
62470         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
62471         * Scripts/webkitpy/layout_tests/port/http_server.py:
62472         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
62473         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
62474
62475 2011-05-03  Dirk Pranke  <dpranke@chromium.org>
62476
62477         Reviewed by Adam Barth.
62478
62479         fix failing printing_unittest on win32
62480         https://bugs.webkit.org/show_bug.cgi?id=59963
62481
62482         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
62483
62484 2011-05-03  Adam Roben  <aroben@apple.com>
62485
62486         Fix most strict PassOwnPtr violations on Windows
62487
62488         Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
62489         enabled
62490
62491         Reviewed by Anders Carlsson.
62492
62493         * WebKitAPITest/Test.h: Use adoptPtr.
62494
62495 2011-05-03  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
62496
62497         Reviewed by Andreas Kling.
62498
62499         Add myself to the committers list.
62500
62501         * Scripts/webkitpy/common/config/committers.py:
62502
62503 2011-05-03  James Robinson  <jamesr@chromium.org>
62504
62505         Reviewed by Kenneth Russell.
62506
62507         [chromium] Layout test animations/3d/replace-filling-transform.html failing
62508         https://bugs.webkit.org/show_bug.cgi?id=59839
62509
62510         Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
62511
62512         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
62513
62514 2011-05-03  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
62515
62516         Unreviewed, rolling out r85471.
62517         http://trac.webkit.org/changeset/85471
62518         https://bugs.webkit.org/show_bug.cgi?id=59922
62519
62520         The rule of thumb in EFL is that you init in all the places
62521         you use it. So, if in your application you call ecore_evas_*
62522         functions, you have to call ecore_evas_init() first.
62523
62524         * EWebLauncher/main.c: always call *_init() functions when you use
62525         that namespace.
62526         (quit):
62527         (main):
62528
62529 2011-05-02  Ojan Vafai  <ojan@chromium.org>
62530
62531         Reviewed by Tony Chang.
62532
62533         remove no longer used method
62534         https://bugs.webkit.org/show_bug.cgi?id=59981
62535
62536         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
62537         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
62538
62539 2011-05-02  Ojan Vafai  <ojan@chromium.org>
62540
62541         Reviewed by Tony Chang.
62542
62543         add image toggling behavior from old-run-webkit-tests
62544         https://bugs.webkit.org/show_bug.cgi?id=59978
62545
62546         Output -diffs.html files. This matches old-run-webkit-tests.
62547         In theory, we could use data urls in the results.html file, but
62548         data urls don't currently have access to local files.
62549
62550         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
62551
62552 2011-05-02  Tony Chang  <tony@chromium.org>
62553
62554         Reviewed by Ojan Vafai.
62555
62556         [nrwt] remove some obsolete references to .checksum files
62557         https://bugs.webkit.org/show_bug.cgi?id=59971
62558
62559         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
62560         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
62561         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
62562         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
62563         * Scripts/webkitpy/layout_tests/port/test.py:
62564         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
62565
62566 2011-05-02  Adam Roben  <aroben@apple.com>
62567
62568         Take advantage of implicit nullptr_t -> PassOwnPtr conversion
62569
62570         Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
62571         doesn't work, but should
62572
62573         Reviewed by Adam Barth.
62574
62575         * DumpRenderTree/chromium/CppBoundClass.h:
62576         * DumpRenderTree/chromium/WebViewHost.cpp:
62577
62578 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
62579
62580         Reviewed by Xan Lopez.
62581
62582         [GTK] Compiler warning in Tools/MiniBrowser/main.c
62583         https://bugs.webkit.org/show_bug.cgi?id=59986
62584
62585         Remove a compiler warning.
62586
62587         * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
62588         from complaining.
62589
62590 2011-05-02  Adam Barth  <abarth@webkit.org>
62591
62592         Reviewed by Eric Seidel.
62593
62594         Add runtests_unittest.py
62595         https://bugs.webkit.org/show_bug.cgi?id=59955
62596
62597         I forgot to add this file in a previous patch.
62598
62599         * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
62600
62601 2011-05-02  Adam Barth  <abarth@webkit.org>
62602
62603         Change the testing EWS to log failures explicitly to avoid an infinite loop.
62604
62605         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62606
62607 2011-05-02  Adrienne Walker  <enne@google.com>
62608
62609         Unreviewed, fix misspelled contributor name.
62610
62611         * Scripts/webkitpy/common/config/committers.py:
62612
62613 2011-05-02  Adam Barth  <abarth@webkit.org>
62614
62615         Reviewed by Eric Seidel.
62616
62617         cr-linux-ews should run tests
62618         https://bugs.webkit.org/show_bug.cgi?id=59272
62619
62620         This patch turns on testing for the cr-linux-ews.  Yay!
62621
62622         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
62623         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62624         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62625         * Scripts/webkitpy/tool/steps/runtests.py:
62626         * Scripts/webkitpy/tool/steps/steps_unittest.py:
62627
62628 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
62629
62630         Incorporate a review comment that I mistakenly omitted from my last commit.
62631
62632         * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
62633
62634 2011-05-02  Adam Barth  <abarth@webkit.org>
62635
62636         Reviewed by Eric Seidel.
62637
62638         EWS should report the list of unexpected failures
62639         https://bugs.webkit.org/show_bug.cgi?id=59923
62640
62641         We cache the results of the first layout test results run on the task
62642         so the EWS can grab them later.  Another option is to include them in
62643         the exception that's thrown, but this approach seemed slightly more
62644         aesthetic.
62645
62646         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
62647         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
62648
62649 2011-05-02  Adam Barth  <abarth@webkit.org>
62650
62651         Reviewed by Eric Seidel.
62652
62653         Add base case for a test-running EWS
62654         https://bugs.webkit.org/show_bug.cgi?id=59920
62655
62656         Later I will subclass this to run the Chromium Linux EWS.
62657
62658         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
62659         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62660         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62661
62662 2011-05-02  Anders Carlsson  <andersca@apple.com>
62663
62664         Build fix.
62665
62666         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
62667         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
62668
62669 2011-05-02  Nico Weber  <thakis@chromium.org>
62670
62671         Reviewed by Mihai Parparita.
62672
62673         Add --no-webkit2 to the output of "build-webkit -h"
62674         https://bugs.webkit.org/show_bug.cgi?id=59942
62675
62676         * Scripts/build-webkit:
62677
62678 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
62679
62680         Reviewed by Xan Lopez.
62681
62682         [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
62683         https://bugs.webkit.org/show_bug.cgi?id=59943
62684
62685         Disable the Ubuntu overlay scrollbar while testing, by injecting the
62686         LIBOVERLAY_SCROLLBAR=0 environment variable.
62687
62688         * Scripts/old-run-webkit-tests:
62689
62690 2011-05-02  Martin Robinson  <mrobinson@igalia.com>
62691
62692         Reviewed by Eric Seidel.
62693
62694         [GTK] editing/selection/select-out-of-editable.html failing after r83967
62695         https://bugs.webkit.org/show_bug.cgi?id=58667
62696
62697         Do not trigger mouse down events when the EventSender knows that a mouse button is
62698         already down. These type of situations can confuse Xvfb and cause dragging failures.
62699
62700         * DumpRenderTree/gtk/EventSender.cpp:
62701         (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
62702         is already down. This can interfere with drags in Xvfb.
62703
62704 2011-05-02  Zsolt Fehér  <h490267@stud.u-szeged.hu>
62705
62706         Reviewed by Csaba Osztrogonác.
62707
62708         DRT sideeffect revealed by r71268.
62709         https://bugs.webkit.org/show_bug.cgi?id=48958
62710
62711         Reset QWebSettings::ZoomTextOnly attribute before all tests.
62712
62713         Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
62714         PageZoomFactor too. It should be done before resetsettings()
62715         to guarantee resetting QWebSettings::ZoomTextOnly correctly.
62716
62717         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
62718         (WebCore::WebPage::resetSettings):
62719         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
62720
62721 2011-05-02  Sheriff Bot  <webkit.review.bot@gmail.com>
62722
62723         Unreviewed, rolling out r85469.
62724         http://trac.webkit.org/changeset/85469
62725         https://bugs.webkit.org/show_bug.cgi?id=59928
62726
62727         Broke  webkitpy-tests on Windows 7, GTK and Qt. (Requested by
62728         bbandix on #webkit).
62729
62730         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
62731         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62732         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62733
62734 2011-05-02  Tomasz Morawski  <t.morawski@samsung.com>
62735
62736         Reviewed by Kenneth Rohde Christiansen.
62737
62738         Cleanup EFL initialization/shutdown in the EWebLauncher
62739         https://bugs.webkit.org/show_bug.cgi?id=59922
62740
62741         Removed ecore_evas_init and edje_init form main function due to they
62742         are also called in the ewk_init. Moved ewk_shutdown to quit function.
62743
62744         * EWebLauncher/main.c:
62745         (quit):
62746         (main):
62747
62748 2011-05-02  Adam Barth  <abarth@webkit.org>
62749
62750         Reviewed by Eric Seidel.
62751
62752         Add base case for a test-running EWS
62753         https://bugs.webkit.org/show_bug.cgi?id=59920
62754
62755         Later I will subclass this to run the Chromium Linux EWS.
62756
62757         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
62758         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
62759         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
62760
62761 2011-05-02  Adam Barth  <abarth@webkit.org>
62762
62763         Reviewed by Eric Seidel.
62764
62765         Add the ability to skip python and perl unit tests on EC2
62766         https://bugs.webkit.org/show_bug.cgi?id=59918
62767
62768         * Scripts/webkitpy/common/config/ports.py:
62769             - This is slightly ugly, but it's useful...
62770         * Scripts/webkitpy/common/config/ports_unittest.py:
62771         * Scripts/webkitpy/tool/mocktool.py:
62772         * Scripts/webkitpy/tool/steps/runtests.py:
62773
62774 2011-05-02  Adam Barth  <abarth@webkit.org>
62775
62776         Reviewed by Eric Seidel.
62777
62778         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
62779
62780 2011-04-29  Kevin Ollivier  <kevino@theolliviers.com>
62781
62782         [wx] Unreviewed build fix, add new directory to the build.
62783
62784         * waf/build/settings.py:
62785
62786 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
62787
62788         Reviewed by Martin Robinson.
62789
62790         [GTK] Implement UI client in minibrowser
62791         https://bugs.webkit.org/show_bug.cgi?id=58416
62792
62793         It also allows to open more than one minibrowser window from the
62794         command line.
62795
62796         * MiniBrowser/gtk/BrowserWindow.c:
62797         (browserWindowFinalize):
62798         (browser_window_init):
62799         (browserWindowConstructed):
62800         (createNewPage):
62801         (showPage):
62802         (closePage):
62803         (runJavaScriptAlert):
62804         (browserWindowUIClientInit):
62805         * MiniBrowser/gtk/main.c:
62806         (loadURI):
62807         (main):
62808
62809 2011-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
62810
62811         Reviewed by Martin Robinson.
62812
62813         [GTK] Implement page loader client in MiniBrowser
62814         https://bugs.webkit.org/show_bug.cgi?id=58024
62815
62816         A new class BrowserWindow has been added to implement the page
62817         loader client. It makes supporting multiple windows easier. Window
62818         title and url entry are now updated during the loading process.
62819
62820         * MiniBrowser/gtk/BrowserWindow.c: Added.
62821         (activateUriEntryCallback):
62822         (goBackCallback):
62823         (goForwardCallback):
62824         (browserWindowFinalize):
62825         (browserWindowGetProperty):
62826         (browserWindowSetProperty):
62827         (browser_window_init):
62828         (browserWindowConstructed):
62829         (browser_window_class_init):
62830         (browserWindowUpdateTitle):
62831         (browserWindowSetTitle):
62832         (browserWindowSetLoadProgress):
62833         (browserWindowUpdateURL):
62834         (didStartProvisionalLoadForFrame):
62835         (didReceiveServerRedirectForProvisionalLoadForFrame):
62836         (didFailProvisionalLoadWithErrorForFrame):
62837         (didCommitLoadForFrame):
62838         (didFinishDocumentLoadForFrame):
62839         (didFinishLoadForFrame):
62840         (didFailLoadWithErrorForFrame):
62841         (didReceiveTitleForFrame):
62842         (didFirstLayoutForFrame):
62843         (didFirstVisuallyNonEmptyLayoutForFrame):
62844         (didRemoveFrameFromHierarchy):
62845         (didStartProgress):
62846         (didChangeProgress):
62847         (didFinishProgress):
62848         (didBecomeUnresponsive):
62849         (didBecomeResponsive):
62850         (browserWindowLoaderClientInit):
62851         (browser_window_new):
62852         (browser_window_get_view):
62853         * MiniBrowser/gtk/BrowserWindow.h: Added.
62854         * MiniBrowser/gtk/GNUmakefile.am:
62855         * MiniBrowser/gtk/main.c:
62856         (createWindow):
62857
62858 2011-04-28  Stephanie Lewis  <slewis@apple.com>
62859
62860         Reviewed by Mark Rowe.
62861
62862         http://bugs.webkit.org/show_bug.cgi?id=59743
62863         <rdar://problem/9040413> Add an install target for production builds.
62864
62865         * DumpRenderTree/mac/PerlSupport/Makefile:
62866
62867 2011-04-28  Adam Roben  <aroben@apple.com>
62868
62869         Stop and restart ATSServer before each test run on Leopard
62870
62871         This is to work around an ATSServer leak that eventually causes tests
62872         to fail.
62873
62874         Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
62875         fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
62876         (due to ATSServer leak)
62877
62878         Reviewed by Dan Bernstein.
62879
62880         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
62881         (StopATSServer):
62882         (StartATSServer):
62883         Added these new commands to stop and start ATSServer.
62884
62885         (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
62886
62887 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
62888
62889         Reviewed by Adam Roben.
62890
62891         add Leopard NRWT bot to the scheduler
62892         https://bugs.webkit.org/show_bug.cgi?id=59766
62893
62894         * BuildSlaveSupport/build.webkit.org-config/config.json:
62895
62896 2011-04-28  Sam Weinig  <sam@webkit.org>
62897
62898         Fix WebKitTestRunner build.
62899
62900         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
62901         The Derived Sources target needs a product name.
62902
62903 2011-04-28  Sam Weinig  <sam@webkit.org>
62904
62905         Reviewed by Mark Rowe.
62906
62907         Add install support for WebKitTestRunner.
62908         <rdar://problem/9349055>
62909
62910         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
62911         Add missing CompilerVersion.xcconfig.
62912
62913         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
62914         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
62915         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
62916         Add install path and tell it not to skip installation.
62917
62918         Add missing CompilerVersion.xcconfig.
62919
62920 2011-04-28  David Levin  <levin@chromium.org>
62921
62922         Reviewed by Adam Barth.
62923
62924         Remove IMAGE_RESIZER related code.
62925         https://bugs.webkit.org/show_bug.cgi?id=59735
62926
62927         * Scripts/build-webkit:
62928
62929 2011-04-28  Sam Weinig  <sam@webkit.org>
62930
62931         Reviewed by Adam Roben.
62932
62933         Make reading skipped files from additional platform
62934         directories work in WebKit2 mode.
62935
62936         * Scripts/old-run-webkit-tests:
62937         (buildPlatformTestHierarchy): Simplify logic to always use the first
62938         and last platforms in the build hierarchy as the test hierarchy, and to
62939         insert the WebKit2 platform in the middle if it exists. Yum.
62940
62941 2011-04-28  Adam Barth  <abarth@webkit.org>
62942
62943         Reviewed by Eric Seidel.
62944
62945         Remove WML
62946         https://bugs.webkit.org/show_bug.cgi?id=59678
62947
62948         Remove build system integration and test harness integration for WML.
62949
62950         * Scripts/build-webkit:
62951         * Scripts/old-run-webkit-tests:
62952         * Scripts/webkitperl/features.pm:
62953         * Scripts/webkitpy/layout_tests/port/webkit.py:
62954         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
62955
62956 2011-04-28  Ojan Vafai  <ojan@chromium.org>
62957
62958         Reviewed by Mihai Parparita.
62959
62960         use a hierarchical data structure to store results json
62961         https://bugs.webkit.org/show_bug.cgi?id=59736
62962
62963         Instead of a map from test name to results dict, we now store a hierarchical
62964         data structure.
62965
62966         Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
62967         New:
62968         { foo: {
62969             bar: {
62970               baz.html: results_dict,
62971               baz2.html: results_dict } } }
62972
62973         This cut ~52% of the size of times_ms.json. I expect it will cut
62974         30-40% of full_results.json and unexpected_results.json.
62975
62976         * Scripts/webkitpy/common/net/resultsjsonparser.py:
62977         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
62978         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
62979         Using os.sep was just wrong since relative_test_filename canonicalizes separators.
62980         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
62981         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
62982         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
62983         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
62984         Instead of plumbing through the change to all of the rebaselineserver
62985         python and JS, just convert to the old format after reading in the json.
62986
62987 2011-04-28  Eric Seidel  <eric@webkit.org>
62988
62989         Reviewed by Adam Barth.
62990
62991         EWS Bubbles should show commit-queue position when patch is in the commit-queue
62992         https://bugs.webkit.org/show_bug.cgi?id=59744
62993
62994         Add target="_top" to the bubble links.  This was
62995         forgotten when I moved from using an onclick to a normal link.
62996
62997         * QueueStatusServer/templates/statusbubble.html:
62998
62999 2011-04-28  Eric Seidel  <eric@webkit.org>
63000
63001         Reviewed by Adam Barth.
63002
63003         EWS bubbles should show "submit to ews" button if they've not been processed
63004         https://bugs.webkit.org/show_bug.cgi?id=59751
63005
63006         * QueueStatusServer/handlers/statusbubble.py:
63007         * QueueStatusServer/handlers/submittoews.py:
63008         * QueueStatusServer/templates/statusbubble.html:
63009         * QueueStatusServer/templates/submittoews.html:
63010
63011 2011-04-28  Eric Seidel  <eric@webkit.org>
63012
63013         Reviewed by Adam Barth.
63014
63015         EWS Bubbles should show commit-queue position when patch is in the commit-queue
63016         https://bugs.webkit.org/show_bug.cgi?id=59744
63017
63018         This was actually just a 2 line change to statusbubble.py.
63019         I also cleaned up statusbubble.html a little while I was there
63020         (the links are now actual <a> tags and have hover).
63021
63022         * QueueStatusServer/handlers/statusbubble.py:
63023         * QueueStatusServer/templates/statusbubble.html:
63024
63025 2011-04-28  Dirk Pranke  <dpranke@chromium.org>
63026
63027         Reviewed by Eric Seidel.
63028
63029         add a mac leopard release NRWT bot
63030         https://bugs.webkit.org/show_bug.cgi?id=59733
63031
63032         * BuildSlaveSupport/build.webkit.org-config/config.json:
63033
63034 2011-04-28  Ojan Vafai  <ojan@chromium.org>
63035
63036         Avoid crashing when running new-run-webkit-tests outside of
63037         version control.
63038
63039         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
63040
63041 2011-04-28  Xan Lopez  <xlopez@igalia.com>
63042
63043         Unreviewed build fix.
63044
63045         * GNUmakefile.am:
63046
63047 2011-04-28  Ojan Vafai  <ojan@chromium.org>
63048
63049         Reviewed by Eric Seidel.
63050
63051         fix python printing test
63052         https://bugs.webkit.org/show_bug.cgi?id=59719
63053
63054         Now that we run scm commands in summarize_results, --verbose prints
63055         debug logging to stderr.
63056
63057         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
63058
63059 2011-04-28  Ojan Vafai  <ojan@chromium.org>
63060
63061         Reviewed by Tony Chang.
63062
63063         link to tests at a specific revision in the results.html file
63064         https://bugs.webkit.org/show_bug.cgi?id=59711
63065
63066         * Scripts/webkitpy/common/checkout/scm.py:
63067         Add a method to get the head svn revision.
63068         * Scripts/webkitpy/common/checkout/scm_unittest.py:
63069         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
63070         Include the svn revision in the results json.
63071
63072 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
63073
63074         Reviewed by Sam Weinig.
63075
63076         [GTK] Remove WKURLCreateWithURL()
63077         https://bugs.webkit.org/show_bug.cgi?id=59691
63078
63079         Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
63080
63081         * MiniBrowser/gtk/main.c:
63082         (activateUriEntryCallback):
63083         (main):
63084
63085 2011-04-28  Carlos Garcia Campos  <cgarcia@igalia.com>
63086
63087         Reviewed by Martin Robinson.
63088
63089         [GTK] WKView should be a GtkWidget
63090         https://bugs.webkit.org/show_bug.cgi?id=59603
63091
63092         Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
63093
63094         * MiniBrowser/gtk/main.c:
63095         (createWindow):
63096         (main):
63097
63098 2011-04-28  Gabor Rapcsanyi  <rgabor@webkit.org>
63099
63100         Reviewed by Csaba Osztrogonác.
63101
63102         [Qt] Add ARM specific Skipped list
63103         https://bugs.webkit.org/show_bug.cgi?id=59680
63104
63105         * Scripts/old-run-webkit-tests:
63106         * Scripts/webkitdirs.pm:
63107
63108 2011-04-27  Eric Seidel  <eric@webkit.org>
63109
63110         Reviewed by Adam Barth.
63111
63112         error_log.txt should include PHP errors
63113         https://bugs.webkit.org/show_bug.cgi?id=59643
63114
63115         Turns out this was really easy after I finally learned
63116         enough about PHP to do it...
63117
63118         I'm adding this in hopes of better tracking down
63119         our random http failures.
63120
63121         * Scripts/webkitperl/httpd.pm:
63122
63123 2011-04-27  David Levin  <levin@chromium.org>
63124
63125         Reviewed by Adam Barth.
63126
63127         check-webkit-style should flags spacing errors for braces on the same line.
63128         https://bugs.webkit.org/show_bug.cgi?id=59665
63129
63130         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
63131         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
63132           and fixed some test cases to not trigger this error since it isn't what they are verifying.
63133
63134 2011-04-27  David Levin  <levin@chromium.org>
63135
63136         Reviewed by Adam Barth.
63137
63138         check-webkit-style error for spaces after periods in a comment has a bad error
63139         message and warns about end of line spaces.
63140         https://bugs.webkit.org/show_bug.cgi?id=59663
63141
63142         * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
63143         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
63144         and changed the error messages.
63145
63146 2011-04-27  Ojan Vafai  <ojan@chromium.org>
63147
63148         remove assertion now that platform/mac-tiger no longer exists
63149         https://bugs.webkit.org/show_bug.cgi?id=59660
63150
63151         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
63152
63153 2011-04-27  Ojan Vafai  <ojan@chromium.org>
63154
63155         Reviewed by Eric Seidel.
63156
63157         remove test that didn't make sense
63158         https://bugs.webkit.org/show_bug.cgi?id=59658
63159
63160         It was artifically saying the test wasn't expected to pass,
63161         but the expectations string was empty. The case of unexpected
63162         passes with a real expectations string is tested later in the
63163         same test.
63164
63165         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
63166
63167 2011-04-27  Sam Weinig  <sam@webkit.org>
63168
63169         Reviewed by Adam Roben.
63170
63171         WebKit2 needs to notify the client when a plugin fails to initialize
63172         https://bugs.webkit.org/show_bug.cgi?id=59657
63173
63174         * MiniBrowser/mac/BrowserWindowController.m:
63175         (-[BrowserWindowController awakeFromNib]):
63176         * WebKitTestRunner/TestController.cpp:
63177         (WTR::TestController::initialize):
63178         Add stubs.
63179
63180 2011-04-26  Sam Weinig  <sam@webkit.org>
63181
63182         Reviewed by David Levin.
63183
63184         Add a few more missing options to new-run-webkit-tests
63185         https://bugs.webkit.org/show_bug.cgi?id=59567
63186
63187         Add support for:
63188             --threaded
63189             --gc-between-tests
63190             --complex-text
63191
63192         * Scripts/webkitpy/layout_tests/port/webkit.py:
63193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
63194         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
63195
63196 2011-04-27  Mark Rowe  <mrowe@apple.com>
63197
63198         Build fix.
63199
63200         Fix an OwnPtr-related issue that was missed before the strictness was turned on.
63201
63202         * WebKitTestRunner/TestController.cpp:
63203         (WTR::TestController::runTest):
63204
63205 2011-04-27  Ojan Vafai  <ojan@chromium.org>
63206
63207         Forgot to upload the new times_ms.json file after splitting
63208         it out from full_results.json.
63209
63210         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
63211
63212 2011-04-27  Ojan Vafai  <ojan@chromium.org>
63213
63214         Fix snafu in generating the JSON for the chromium tests.
63215
63216         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
63217
63218 2011-04-27  Ojan Vafai  <ojan@chromium.org>
63219
63220         Fix bad merge. This broke the chromium tests generating JSON files.
63221         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
63222
63223 2011-04-27  Mark Rowe  <mrowe@apple.com>
63224
63225         Rubber-stamped by Geoff Garen.
63226
63227         Don't look for results in a location that no longer exists.
63228
63229         * Scripts/old-run-webkit-tests:
63230
63231 2011-04-27  Adrienne Walker  <enne@google.com>
63232
63233         Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
63234
63235         * Scripts/webkitpy/common/config/committers.py:
63236
63237 2011-04-22  Ojan Vafai  <ojan@chromium.org>
63238
63239         Reviewed by Tony Chang.
63240
63241         only include failures in full_results.json
63242         https://bugs.webkit.org/show_bug.cgi?id=59256
63243
63244         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
63245
63246 2011-04-22  Ojan Vafai  <ojan@chromium.org>
63247
63248         Reviewed by Adam Roben.
63249
63250         move times into their own json file
63251         https://bugs.webkit.org/show_bug.cgi?id=59239
63252
63253         The test runtimes are the only case where we need an entry for
63254         every test that was run, including passing tests. Move them into
63255         their own json file so we can prune the other json files to only
63256         include failing tests.
63257
63258         Use a trie-like data structure to hold the tests to avoid including
63259         full test paths. This cuts 52% of the filesize. The end result is ~700k
63260         pre-gzip.
63261
63262         * Scripts/webkitpy/common/net/resultsjsonparser.py:
63263         Exclude times from the parsed TestResults.
63264         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
63265         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
63266         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
63267         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
63268
63269 2011-04-27  Anders Carlsson  <andersca@apple.com>
63270
63271         More casts and more clang++ build fixes.
63272
63273         * DumpRenderTree/mac/DumpRenderTree.mm:
63274         (createWebViewAndOffscreenWindow):
63275         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
63276         (TestWebKitAPI::PlatformWebView::PlatformWebView):
63277         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
63278         (WTR::PlatformWebView::PlatformWebView):
63279
63280 2011-04-27  Tony Chang  <tony@chromium.org>
63281
63282         Reviewed by Ojan Vafai.
63283
63284         lazily autoinstall thirdparty python libraries
63285         https://bugs.webkit.org/show_bug.cgi?id=55723
63286
63287         This helps by only having pywebsocket installed when the bots run.  It
63288         doesn't help much for devs since webkit-patch pulls in almost everything.
63289
63290         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
63291         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
63292         * Scripts/webkitpy/common/net/networktransaction.py:
63293         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
63294         * Scripts/webkitpy/common/net/statusserver.py:
63295         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
63296         * Scripts/webkitpy/thirdparty/__init__.py: Add an import hook so we can install based on
63297             the import command rather than just installing everything.
63298         * Scripts/webkitpy/thirdparty/__init___unittest.py: Added.
63299
63300 2011-04-27  Girish Ramakrishnan  <girish@forwardbias.in>
63301
63302         Add my IRC nick.
63303
63304         * Scripts/webkitpy/common/config/committers.py:
63305
63306 2011-04-27  Eric Seidel  <eric@webkit.org>
63307
63308         Reviewed by Mihai Parparita.
63309
63310         sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
63311         https://bugs.webkit.org/show_bug.cgi?id=59545
63312
63313         To do this, I needed a way to look up contributors by irc-name
63314         (since anyone in #webkit who might use this command may not be a committer).
63315         To lookup contributors, I had to make Contributor a real object.
63316         Which led me to redesign parts of committers.py...
63317         and finally fix one spot in changelog.py where we wanted to be
63318         looking up contributors and not committers.
63319
63320         Overall a pretty simple fix, once you wade through the yak-hair.
63321
63322         This may not prevent *all* possible ways that bugs would get assigned
63323         to webkit.review.bot.  If we don't recognize the requester we will
63324         go through the previous code path (which shouldn't change the assignee
63325         on the bug from the default as far as I can tell).
63326
63327         * Scripts/webkitpy/common/checkout/changelog.py:
63328         * Scripts/webkitpy/common/config/committers.py:
63329         * Scripts/webkitpy/common/config/committers_unittest.py:
63330         * Scripts/webkitpy/tool/bot/irc_command.py:
63331         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
63332
63333 2011-04-27  Yi Shen  <yi.4.shen@nokia.com>
63334
63335         Reviewed by Kenneth Rohde Christiansen.
63336
63337         [Qt] Upstream Symbian platform plugin
63338         https://bugs.webkit.org/show_bug.cgi?id=58435
63339
63340         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
63341
63342         * Scripts/webkitpy/style/checker.py:
63343         * Scripts/webkitpy/style/checker_unittest.py:
63344
63345 2011-04-27  Jeff Miller  <jeffm@apple.com>
63346
63347         Correct my IRC nickname.
63348
63349         * Scripts/webkitpy/common/config/committers.py:
63350
63351 2011-04-27  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
63352
63353         Reviewed by Darin Adler.
63354
63355         Change the email used on bugzilla
63356         https://bugs.webkit.org/show_bug.cgi?id=59582
63357
63358         * Scripts/webkitpy/common/config/committers.py:
63359
63360 2011-04-27  James Kozianski  <koz@chromium.org>
63361
63362         Reviewed by Ojan Vafai.
63363
63364         Extract map from port to builder name.
63365         https://bugs.webkit.org/show_bug.cgi?id=58301
63366
63367         * Scripts/webkitpy/layout_tests/port/__init__.py:
63368         * Scripts/webkitpy/layout_tests/port/builders.py: Added.
63369         * Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
63370         * Scripts/webkitpy/layout_tests/port/factory.py:
63371
63372 2011-04-27  Ryuan Choi  <ryuan.choi@samsung.com>
63373
63374         Reviewed by Martin Robinson.
63375
63376         [GTK] Add proxy support to GtkLauncher
63377         https://bugs.webkit.org/show_bug.cgi?id=58852
63378
63379         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
63380
63381         * GNUmakefile.am:
63382         * GtkLauncher/main.c:
63383         (main):
63384
63385 2011-04-27  Annie Sullivan  <sullivan@chromium.org>
63386
63387         Reviewed by David Levin.
63388
63389         Adding myself as a Chromium contributor to committers.py.
63390
63391         https://bugs.webkit.org/show_bug.cgi?id=59576
63392
63393         * Scripts/webkitpy/common/config/committers.py:
63394
63395 2011-04-26  David Grogan  <dgrogan@chromium.org>
63396
63397         Reviewed by David Levin.
63398
63399         Adding myself to Chromium contributors list in committers.py
63400         https://bugs.webkit.org/show_bug.cgi?id=59565
63401
63402         * Scripts/webkitpy/common/config/committers.py:
63403
63404 2011-04-26  Chang Shu  <cshu@webkit.org>
63405
63406         Reviewed by Laszlo Gombos.
63407
63408         WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
63409         https://bugs.webkit.org/show_bug.cgi?id=42544
63410
63411         Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
63412
63413         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
63414         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
63415         (WTR::InjectedBundle::beginTesting):
63416         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
63417         (WTR::LayoutTestController::addOriginAccessWhitelistEntry):
63418         (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
63419         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
63420
63421 2011-04-26  Chris Fleizach  <cfleizach@apple.com>
63422
63423         Reviewed by Adele Peterson.
63424
63425         AX: Add more text marker routines to DRT
63426         https://bugs.webkit.org/show_bug.cgi?id=58949
63427
63428         Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
63429         stringForMarkerRange.
63430
63431         * DumpRenderTree/AccessibilityUIElement.cpp:
63432         (nextTextMarkerCallback):
63433         (previousTextMarkerCallback):
63434         (stringForTextMarkerRangeCallback):
63435         (AccessibilityUIElement::previousTextMarker):
63436         (AccessibilityUIElement::nextTextMarker):
63437         (AccessibilityUIElement::stringForTextMarkerRange):
63438         (AccessibilityUIElement::getJSClass):
63439         * DumpRenderTree/AccessibilityUIElement.h:
63440         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
63441         (AccessibilityUIElement::previousTextMarker):
63442         (AccessibilityUIElement::nextTextMarker):
63443         (AccessibilityUIElement::stringForTextMarkerRange):
63444
63445 2011-04-26  Dan Bernstein  <mitz@apple.com>
63446
63447         Build fix.
63448
63449         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
63450         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
63451         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
63452
63453 2011-04-26  Kevin Ollivier  <kevino@theolliviers.com>
63454
63455         Rubberstamped by Eric Seidel.
63456
63457         Enable waf to be used to build other ports
63458         https://bugs.webkit.org/show_bug.cgi?id=58213
63459
63460         * Scripts/build-webkit:
63461         * Scripts/webkitdirs.pm:
63462         * waf: Added.
63463         * waf/build: Added.
63464         * waf/build/build_utils.py: Added.
63465         * waf/build/settings.py: Added.
63466         * waf/build/waf_extensions.py: Added.
63467         * waf/build/wxpresets.py: Added.
63468
63469 2011-04-26  Sam Weinig  <sam@webkit.org>
63470
63471         Reviewed by David Hyatt.
63472
63473         Remove Datagrid from the tree
63474         https://bugs.webkit.org/show_bug.cgi?id=59543
63475
63476         * Scripts/build-webkit:
63477         Remove feature.
63478
63479         * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
63480         * iExploder/iexploder-1.7.2/src/html-tags/webkit:
63481         Remove from fuzzer.
63482
63483 2011-04-26  Brent Fulgham  <bfulgham@webkit.org>
63484
63485         Reviewed by Adam Roben.
63486
63487         Update WinLauncher with command-line arguments to allow the
63488         transparency to be tested.  Use --transparent to create a
63489         transparent view.  Use --desktop to have the view fill the
63490         desktop area of the screen.
63491         https://bugs.webkit.org/show_bug.cgi?id=58300
63492
63493         * WinLauncher/WinLauncher.cpp:
63494         (usesLayeredWebView): New method to indicate that the
63495         program is running with layered windows (alpha-blended
63496         transparent windows).
63497         (shouldUseFullDesktop): New method to indicate that the
63498         program is running across the full desktop (less any
63499         task bars.)
63500         (resizeSubViews): Layered window mode doesn't have any
63501         winapi child windows, so this routine is exited early
63502         for that case.
63503         (subclassForLayeredWindow): Subclass the window so we can
63504         override its defaut message loop.
63505         (computeFullDesktopFrame): Convenience function to get the
63506         desktop region and update the frame dimensions appropriately.
63507         (_tWinMain): Updated to accept the new '--transparent' and
63508         '--desktop' arguments.
63509         (InitInstance): Modified to exit early for the transparent
63510         background case.  WebKit will construct our primary window (with
63511         appropriate settings) so we don't need to create one ourselves.
63512         (WndProc):
63513         (TransparentWndProc): New message loop for transparent windows,
63514         since they need special handling to support dragging.
63515
63516 2011-04-26  Alexandre MAzari  <amazari@igalia.com>
63517
63518         Reviewed by Xan Lopez.
63519
63520         [Gtk] Implement LayoutTestController::setPluginsEnabled
63521         https://bugs.webkit.org/show_bug.cgi?id=59184
63522
63523         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
63524         (LayoutTestController::setPluginsEnabled):
63525
63526 2011-04-26  Chang Shu  <cshu@webkit.org>
63527
63528         Reviewed by Laszlo Gombos.
63529
63530         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
63531         https://bugs.webkit.org/show_bug.cgi?id=57572
63532
63533         Remove the unnecessary code that updates preference.
63534
63535         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
63536         (WTR::InjectedBundle::beginTesting):
63537         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
63538         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
63539
63540 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
63541
63542         Reviewed by Eric Seidel.
63543
63544         [GTK] accessibility/aria-combobox-expected.txt
63545         https://bugs.webkit.org/show_bug.cgi?id=59399
63546
63547         Implement isExpanded(), as it's used in the layout test.
63548
63549         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
63550         (AccessibilityUIElement::isExpanded): Implemented.
63551
63552 2011-04-26  Adrienne Walker  <enne@google.com>
63553
63554         Reviewed by Kent Tamura.
63555
63556         [chromium] Fix memory leak in DRT due to OwnPtr<T*>
63557         https://bugs.webkit.org/show_bug.cgi?id=59489
63558
63559         * DumpRenderTree/chromium/WebViewHost.h:
63560
63561 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
63562
63563         Reviewed by Eric Seidel.
63564
63565         [GTK] Implement isChecked in DRT
63566         https://bugs.webkit.org/show_bug.cgi?id=59385
63567
63568         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
63569         (AccessibilityUIElement::isChecked): Implemented.
63570
63571 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
63572
63573         Unreviewed, rolling out r84949.
63574         http://trac.webkit.org/changeset/84949
63575         https://bugs.webkit.org/show_bug.cgi?id=58852
63576
63577         Broke GTK+ compilation
63578
63579         * GtkLauncher/main.c:
63580         (main):
63581
63582 2011-04-26  Eric Seidel  <eric@webkit.org>
63583
63584         Reviewed by Mihai Parparita.
63585
63586         sheriff-bot should have a create-bug command
63587         https://bugs.webkit.org/show_bug.cgi?id=59491
63588
63589         This patch has some stderr unittest spew, but I will
63590         fix it after my live demo.
63591
63592         * Scripts/webkitpy/tool/bot/irc_command.py:
63593         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
63594         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
63595
63596 2011-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
63597
63598         Reviewed by Martin Robinson.
63599
63600         [GTK] Add proxy support to GtkLauncher
63601         https://bugs.webkit.org/show_bug.cgi?id=58852
63602
63603         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
63604
63605         * GtkLauncher/main.c:
63606         (main):
63607
63608 2011-04-26  Dan Bernstein  <mitz@apple.com>
63609
63610         Reviewed by Mark Rowe.
63611
63612         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
63613
63614         * DumpRenderTree/mac/Configurations/Base.xcconfig:
63615         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
63616         * MiniBrowser/Configurations/Base.xcconfig:
63617         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
63618         * TestWebKitAPI/Configurations/Base.xcconfig:
63619         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
63620         * WebKitTestRunner/Configurations/Base.xcconfig:
63621         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
63622
63623 2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>
63624
63625         Reviewed by David Levin.
63626
63627         Adding myself as a Chromium contributors to committers.py.
63628
63629         https://bugs.webkit.org/show_bug.cgi?id=59444
63630
63631         * Scripts/webkitpy/common/config/committers.py:
63632
63633 2011-04-26  Adam Barth  <abarth@webkit.org>
63634
63635         Reviewed by Eric Seidel.
63636
63637         DumpRenderTree/chromium should play nice with strict OwnPtrs
63638         https://bugs.webkit.org/show_bug.cgi?id=59458
63639
63640         All these changes are pretty straight forward.
63641
63642         * DumpRenderTree/chromium/CppBoundClass.cpp:
63643         (GetterPropertyCallback::GetterPropertyCallback):
63644         (CppBoundClass::bindGetterCallback):
63645         * DumpRenderTree/chromium/CppBoundClass.h:
63646         (CppBoundClass::bindProperty):
63647         (CppBoundClass::bindFallbackCallback):
63648         (CppBoundClass::bindFallbackMethod):
63649         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
63650         (DRTDevToolsClient::DRTDevToolsClient):
63651         * DumpRenderTree/chromium/TestEventPrinter.cpp:
63652         (TestEventPrinter::createDRTPrinter):
63653         (TestEventPrinter::createTestShellPrinter):
63654         * DumpRenderTree/chromium/TestEventPrinter.h:
63655         * DumpRenderTree/chromium/TestShell.cpp:
63656         (TestShell::TestShell):
63657         (TestShell::createMainWindow):
63658         (TestShell::createDRTDevToolsClient):
63659         * DumpRenderTree/chromium/WebViewHost.cpp:
63660         (WebViewHost::geolocationClientMock):
63661         (WebViewHost::speechInputController):
63662         (WebViewHost::deviceOrientationClientMock):
63663         (WebViewHost::reset):
63664         (WebViewHost::navigate):
63665         (WebViewHost::setPendingExtraData):
63666         (WebViewHost::canvas):
63667         * DumpRenderTree/chromium/WebViewHost.h:
63668
63669 2011-04-26  Adam Roben  <aroben@apple.com>
63670
63671         Make DRT/win log loading errors the same way DRT/mac does
63672
63673         Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
63674         http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
63675
63676         Reviewed by Alexey Proskuryakov.
63677
63678         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
63679         (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
63680         <rdar://problem/5064234>, which has long since been fixed, and then made this function match
63681         -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
63682
63683 2011-04-26  Dan Bernstein  <mitz@apple.com>
63684
63685         REGRESSION (84876): build-webkit produces an error message
63686         https://bugs.webkit.org/show_bug.cgi?id=59460
63687
63688         * Scripts/webkitdirs.pm:
63689
63690 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
63691
63692         Reviewed by Eric Seidel.
63693
63694         Fix timestamp comparison in check-for-weak-vtables-and-externals
63695         https://bugs.webkit.org/show_bug.cgi?id=59416
63696
63697         We should only re-run the check-for-weak-vtables-and-externals script
63698         if the executable is more recent than the last run.
63699
63700         * Scripts/check-for-weak-vtables-and-externals:
63701
63702 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
63703
63704         Reviewed by Csaba Osztrogonác.
63705
63706         [Qt] Implement LayoutTestController::setAutofilled
63707         https://bugs.webkit.org/show_bug.cgi?id=59439
63708
63709         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
63710         (LayoutTestController::setAutofilled):
63711         * DumpRenderTree/qt/LayoutTestControllerQt.h:
63712
63713 2011-04-25  Dan Bernstein  <mitz@apple.com>
63714
63715         Reviewed by Mark Rowe.
63716
63717         Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
63718
63719         * Scripts/webkitdirs.pm:
63720
63721 2011-04-25  Sam Weinig  <sam@webkit.org>
63722
63723         Reviewed by Adam Roben.
63724
63725         Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
63726         https://bugs.webkit.org/show_bug.cgi?id=56090
63727
63728         Make LeaksViewer work with versions of browsers that don't support message
63729         passing of cyclic structures.
63730
63731         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
63732         (LeaksParser.this._worker.onmessage):
63733         (LeaksParser):
63734         (LeaksParser.prototype.addLeaksFile):
63735         Use LeaksParserImpl directly if we don't support passing cyclic structures.
63736
63737         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
63738         (LeaksParserImpl):
63739         (LeaksParserImpl.prototype.addLeaksFile):
63740         (LeaksParserImpl.prototype._incorporateLeaks):
63741         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
63742         (onmessage):
63743         Factor out LeaksParser implementation into LeaksParserImpl.js.
63744
63745         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
63746         (workersSupportCyclicStructures):
63747         Add function to detect if workers support passing cyclic structures.
63748
63749         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
63750         Add LeaksParserImpl.js include.
63751
63752 2011-04-25  Jeff Miller  <jeffm@apple.com>
63753
63754         Reviewed by Timothy Hatcher.
63755
63756         Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
63757         https://bugs.webkit.org/show_bug.cgi?id=59373
63758
63759         * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
63760
63761 2011-04-25  Andrew Scherkus  <scherkus@chromium.org>
63762
63763         Reviewed by Dimitri Glazkov.
63764
63765         Adding a few Chromium contributors to committers.py.
63766
63767         https://bugs.webkit.org/show_bug.cgi?id=59327
63768
63769         * Scripts/webkitpy/common/config/committers.py:
63770
63771 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
63772
63773         Reviewed by Dimitri Glazkov.
63774
63775         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
63776         https://bugs.webkit.org/show_bug.cgi?id=59284
63777
63778         Chromium DRT over-refcounted the NPObject wrappers it used to
63779         marshal shadowRoot nodes back to tests (WebBindings::makeNode
63780         births NPObjects with referenceCount == 1). This masked the GC bug
63781         59284 in tests by making shadowRoot nodes live forever.
63782
63783         * DumpRenderTree/chromium/LayoutTestController.cpp:
63784         (LayoutTestController::shadowRoot):
63785         (LayoutTestController::ensureShadowRoot):
63786
63787 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
63788
63789         [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
63790         and update the URL for downloading waf.
63791
63792         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
63793         (LayoutTestController::ensureShadowRoot):
63794         (LayoutTestController::removeShadowRoot):
63795         * Scripts/webkitdirs.pm:
63796
63797 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
63798
63799         Unreviewed, rolling out r84627.
63800         http://trac.webkit.org/changeset/84627
63801         https://bugs.webkit.org/show_bug.cgi?id=59271
63802
63803         It broke Symbian build (Requested by Ossy on #webkit).
63804
63805         * Scripts/webkitpy/style/checker.py:
63806         * Scripts/webkitpy/style/checker_unittest.py:
63807
63808 2011-04-22  Dirk Pranke  <dpranke@chromium.org>
63809
63810         Reviewed by Adam Barth.
63811
63812         rebaseline-chromium-webkit-tests: clean up output
63813         https://bugs.webkit.org/show_bug.cgi?id=59240
63814
63815         This change dramatically changes the output the tool provides
63816         by default. The previous output (more or less) is still there
63817         in -v / verbose / debug mode, but the default output is
63818         way terser and more readable. It mostly says which files are
63819         updated, which are duplicates, and which are not found in an
63820         archive. Feedback desired :).
63821
63822         This change also adds a scm.exists() method to the SCM object
63823         so that we can cleanly figure out what we're doing while
63824         rebaselining.
63825
63826         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
63827         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
63828         * Scripts/webkitpy/common/system/filesystem_mock.py:
63829         * Scripts/webkitpy/common/checkout/scm.py:
63830         * Scripts/webkitpy/common/checkout/scm_unittest.py:
63831
63832 2011-04-22  Ilya Sherman  <isherman@chromium.org>
63833
63834         Reviewed by Alexey Proskuryakov.
63835
63836         Add Ilya Sherman (isherman@chromium.org) to the list of contributors
63837         https://bugs.webkit.org/show_bug.cgi?id=59231
63838
63839         * Scripts/webkitpy/common/config/committers.py:
63840
63841 2011-04-22  Yuta Kitamura  <yutak@chromium.org>
63842
63843         Reviewed by Ojan Vafai.
63844
63845         new-run-webkit-tests: Exception raised when stderr contains binary data
63846         https://bugs.webkit.org/show_bug.cgi?id=59083
63847
63848         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
63849         Use write_binary_file() instead of write_text_file().
63850
63851 2011-04-22  Chang Shu  <cshu@webkit.org>
63852
63853         Reviewed by Kenneth Rohde Christiansen.
63854
63855         WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
63856         https://bugs.webkit.org/show_bug.cgi?id=42536
63857
63858         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
63859         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
63860         (WTR::LayoutTestController::setFrameFlatteningEnabled):
63861         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
63862
63863 2011-04-22  Adam Barth  <abarth@webkit.org>
63864
63865         Reviewed by Eric Seidel.
63866
63867         CommitQueue should remember the expected failures from patch to patch
63868         https://bugs.webkit.org/show_bug.cgi?id=59253
63869
63870         Previously, we stored the set of expected failures on the task object,
63871         which meant the commit-queue forgot about them after each patch.  This
63872         patch moves them to the CommitQueue object so they will have a longer
63873         lifetime.
63874
63875         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
63876         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
63877         * Scripts/webkitpy/tool/commands/queues.py:
63878
63879 2011-04-22  Sam Weinig  <sam@webkit.org>
63880
63881         Reviewed by Brian Weinstein.
63882
63883         WebKit2: Implement JavaScript unresponsiveness timer/callbacks
63884         https://bugs.webkit.org/show_bug.cgi?id=59248
63885
63886         Stub out shouldInterruptJavaScript callbacks.
63887
63888         * MiniBrowser/mac/BrowserWindowController.m:
63889         (-[BrowserWindowController awakeFromNib]):
63890         * MiniBrowser/win/BrowserView.cpp:
63891         (BrowserView::create):
63892         * WebKitTestRunner/TestController.cpp:
63893         (WTR::TestController::createOtherPage):
63894         (WTR::TestController::initialize):
63895
63896 2011-04-22  Daniel Bates  <dbates@webkit.org>
63897
63898         Reviewed by Csaba Osztrogonác.
63899
63900         webkit-patch land hangs if svn prompts for credentials
63901         https://bugs.webkit.org/show_bug.cgi?id=31500
63902
63903         Make has_authorization_for_realm() return True only if there exists a credentials file
63904         that contains either the word "password" or "passtype". We assume that these words don't
63905         coincide with the actual credential data (e.g. a person's username is "password").
63906
63907         * Scripts/webkitpy/common/checkout/scm.py:
63908         * Scripts/webkitpy/common/checkout/scm_unittest.py:
63909           - Added test cases:
63910             test_has_authorization_for_realm_using_credentials_with_passtype(),
63911             test_has_authorization_for_realm_using_credentials_with_password(),
63912             test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
63913           - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
63914             to better describe what it's testing.
63915           - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
63916             and return the result of calling has_authorization_for_realm() so that the caller can
63917             assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
63918             better reflect its new purpose.
63919
63920 2011-04-22  Adam Barth  <abarth@webkit.org>
63921
63922         Remove double-negative.  (Sorry this was bugging me.)
63923
63924         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
63925
63926 2011-04-22  Adam Barth  <abarth@webkit.org>
63927
63928         Reviewed by Eric Seidel.
63929
63930         Factor LayoutTestResultsReader out of CommitQueue
63931         https://bugs.webkit.org/show_bug.cgi?id=59244
63932
63933         This code will be shared with the EWS when they start running tests.
63934
63935         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
63936         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
63937         * Scripts/webkitpy/tool/commands/queues.py:
63938         * Scripts/webkitpy/tool/commands/queues_unittest.py:
63939
63940 2011-04-22  Eric Seidel  <eric@webkit.org>
63941
63942         Reviewed by Dimitri Glazkov.
63943
63944         webkit-patch rebaseline is broken
63945         https://bugs.webkit.org/show_bug.cgi?id=59207
63946
63947         My recent changes to how LayoutTestResults.results_from_string
63948         uncovered a bug in our use of urllib2.
63949         We now are treating the return value from _fetch_results_html()
63950         (which returns urllib2.openurl()) as a string.  That's incorrect,
63951         the return value is a file-like object (which auto-converts to a
63952         string in most cases).
63953
63954         I've updated our urllib2-using code to correctly call .read() on the
63955         resulting object before treating it like a string.
63956         Unfortunately there is no easy way to test this mis-understanding
63957         of the openurl() semantics.
63958
63959         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
63960
63961 2011-04-22  Adam Barth  <abarth@webkit.org>
63962
63963         Reviewed by Eric Seidel.
63964
63965         Factor PatchAnalysis task out of CommitQueueTask
63966         https://bugs.webkit.org/show_bug.cgi?id=59220
63967
63968         This is a first step towards teaching the EWS to run tests.
63969
63970         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
63971         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
63972         * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
63973
63974 2011-04-22  Philippe Normand  <pnormand@igalia.com>
63975
63976         Reviewed by Martin Robinson.
63977
63978         [GTK] DRT: implement eventSender.scalePageBy
63979         https://bugs.webkit.org/show_bug.cgi?id=59082
63980
63981         * DumpRenderTree/gtk/EventSender.cpp:
63982         (scalePageByCallback): scalePageBy() support.
63983
63984 2011-04-21  Eric Seidel  <eric@webkit.org>
63985
63986         Reviewed by Adam Barth.
63987
63988         LayoutTestResults should know how to handle NRWT json files
63989         https://bugs.webkit.org/show_bug.cgi?id=59168
63990
63991         LayoutTestResults was originally created to be a parallel
63992         to existing NRWT architecture for dealing with results files.
63993         But then it turns out that NRWT has no such architecture. :(
63994         So this patch writes the necessary code to handle reading
63995         full_results.json and unexpected_results.json files from
63996         NRWT layout-test-results directories.
63997
63998         LayoutTestResults has thus morphed from being ORWT-only to
63999         supporting both ORWT and NRWT.  It's possible at some future
64000         point that other pieces of the NRWT architecture will learn
64001         how to read JSON files in which case this can go away.
64002
64003         This is all done for making it possible for the commit-queue
64004         to run the tests using NWRT and be able to understand the results
64005         (for flaky test reporting, etc.)
64006
64007         * Scripts/webkitpy/common/net/layouttestresults.py:
64008         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
64009         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
64010         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
64011         * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
64012         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
64013
64014 2011-04-22  Yi Shen  <yi.4.shen@nokia.com>
64015
64016         Reviewed by Kenneth Rohde Christiansen.
64017
64018         [Qt] Upstream Symbian platform plugin
64019         https://bugs.webkit.org/show_bug.cgi?id=58435
64020
64021         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
64022
64023         * Scripts/webkitpy/style/checker.py:
64024         * Scripts/webkitpy/style/checker_unittest.py:
64025
64026 2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>
64027
64028         Reviewed by Csaba Osztrogonác.
64029
64030         [Qt][WK2] Qt should use the mac-wk2 skipped list
64031         https://bugs.webkit.org/show_bug.cgi?id=58536
64032
64033         * Scripts/old-run-webkit-tests:
64034
64035 2011-04-21  Tony Chang  <tony@chromium.org>
64036
64037         Reviewed by Mihai Parparita.
64038
64039         Remove find-mismatched-layout-test-results since it's not needed in a
64040         checksum free world.
64041         https://bugs.webkit.org/show_bug.cgi?id=59156
64042
64043         * Scripts/find-mismatched-layout-test-results: Removed.
64044
64045 2011-04-21  Brent Fulgham  <bfulgham@webkit.org>
64046
64047         Reviewed by Martin Robinson.
64048
64049         Teach build-webkit and update-webkit that the WinCairo port does
64050         not need the non-redistributable WebKitSupportLibraries.zip file.
64051         Also append the _Cairo_CFLite label to the build target for the
64052         default (no argument) case when building with '--wincairo'
64053
64054         https://bugs.webkit.org/show_bug.cgi?id=58801
64055
64056         * Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
64057           doesn't exist.
64058         * Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
64059           'Release' build target when passed the '--wincairo' flag.
64060         * Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
64061           doesn't exist.
64062
64063 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
64064
64065         Reviewed by Eric Seidel.
64066
64067         new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
64068         https://bugs.webkit.org/show_bug.cgi?id=58758
64069
64070         Since worker_mixin is now only used by worker, there's no point
64071         in having it split across two files.
64072
64073         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
64074         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
64075         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
64076         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
64077         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
64078         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
64079
64080 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
64081
64082         Reviewed by Tony Chang.
64083
64084         new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
64085         https://bugs.webkit.org/show_bug.cgi?id=58756
64086
64087         Since worker_mixin is now only used by worker, there's no point
64088         in having it split across two files.
64089
64090         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
64091         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
64092
64093 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
64094
64095         Reviewed by Tony Chang.
64096
64097         new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
64098         https://bugs.webkit.org/show_bug.cgi?id=58754
64099
64100         test_runner hasn't been a great name for some time, since all of
64101         the test running is actually done in worker and
64102         single_test_runner. Rename to manager to match the terminology
64103         elsewhere.
64104
64105         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
64106         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
64107         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
64108         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
64109         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
64110         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
64111
64112 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
64113
64114         Reviewed by Tony Chang.
64115
64116         new-run-webkit-tests: obsolete old threading code, part 2
64117         https://bugs.webkit.org/show_bug.cgi?id=58753
64118
64119         This merges the test_runner2 code back into test_runner since
64120         there's only a single type of test runner now.
64121
64122         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64123         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
64124         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
64125
64126 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
64127
64128         Reviewed by Adam Roben.
64129
64130         Add a feature define to allow <details> and <summary> to be disabled
64131         https://bugs.webkit.org/show_bug.cgi?id=59118
64132         <rdar://problem/9257045>
64133
64134         * Scripts/build-webkit:
64135         * Tools.pro:
64136
64137 2011-04-21  Adam Barth  <abarth@webkit.org>
64138
64139         Reviewed by Eric Seidel.
64140
64141         webkit-patch upload should assign the bug to you
64142         https://bugs.webkit.org/show_bug.cgi?id=33699
64143
64144         This patch only re-assigns the bug if it is currently unassigned.  We
64145         can be more aggressive in the future if people want us to be more
64146         agressive.
64147
64148         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
64149         * Scripts/webkitpy/tool/commands/upload_unittest.py:
64150         * Scripts/webkitpy/tool/mocktool.py:
64151         * Scripts/webkitpy/tool/steps/postdiff.py:
64152
64153 2011-04-21  Ojan Vafai  <ojan@chromium.org>
64154
64155         Reviewed by Tony Chang.
64156
64157         move json_results.html over to LayoutTests/fast/harness
64158         https://bugs.webkit.org/show_bug.cgi?id=59154
64159
64160         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64161
64162 2011-04-21  Adam Barth  <abarth@webkit.org>
64163
64164         Reviewed by Eric Seidel.
64165
64166         ValidateChangeLogs doesn't work on SVN
64167         https://bugs.webkit.org/show_bug.cgi?id=59115
64168
64169         svn-create-patch lies about the diff in the working copy by moving
64170         ChangeLog entries to the top of the diff.  That's fine on most cases,
64171         but causes problems for ValidateChangeLogs, which is trying validate
64172         the where the ChangeLog entry appears.
64173
64174         I haven't added a test for this change because I couldn't figure out
64175         how to write one.  The issue is more of an integration issue, which
64176         we're not really set up to test in our unit testing framework.  If this
64177         patch had worked around the output from svn-create-patch, then I could
64178         have tested that we behave correctly on sample svn-create-patch output,
64179         but, in this case, I've removed the dependency on svn-create-patch.  I
64180         could test that we behave correctly on "svn diff" output, but we
64181         already have those tests.
64182
64183         * Scripts/webkitpy/tool/commands/download_unittest.py:
64184         * Scripts/webkitpy/tool/mocktool.py:
64185         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
64186
64187 2011-04-21  Tony Chang  <tony@chromium.org>
64188
64189         Reviewed by Ojan Vafai.
64190
64191         old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
64192         https://bugs.webkit.org/show_bug.cgi?id=58402
64193
64194         * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
64195         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
64196         * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
64197         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
64198         * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
64199         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64200
64201 2011-04-21  Ojan Vafai  <ojan@chromium.org>
64202
64203         Reviewed by Tony Chang.
64204
64205         final tests for results.html file
64206         https://bugs.webkit.org/show_bug.cgi?id=59150
64207
64208         This gets us close to 100% code coverage. Once this is
64209         checked in, I'll move this file over to LayoutTests/fast/harness
64210         and make it a proper layout test.
64211
64212         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64213         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
64214
64215 2011-04-21  Ojan Vafai  <ojan@chromium.org>
64216
64217         Reviewed by Tony Chang.
64218
64219         only expand visible rows
64220         https://bugs.webkit.org/show_bug.cgi?id=59130
64221
64222         For the chromium port, where there are many expected failures,
64223         expanding all of them is quite slow. Only expand the visible ones.
64224         This makes the default case. Also, make the expanding async to
64225         avoid totally killing the process.
64226
64227         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64228         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
64229
64230 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
64231
64232         [GTK] DRT: implement eventSender.scalePageBy
64233         https://bugs.webkit.org/show_bug.cgi?id=59082
64234
64235         Rolling out r84507 since it broke many GTK+ tests.
64236
64237         * DumpRenderTree/gtk/EventSender.cpp:
64238
64239 2011-04-21  Sam Weinig  <sam@webkit.org>
64240
64241         Reviewed by Simon Fraser.
64242
64243         Add way to garbage collect between each test when running layout tests
64244         https://bugs.webkit.org/show_bug.cgi?id=59126
64245
64246         * DumpRenderTree/mac/DumpRenderTree.mm:
64247         (initializeGlobalsFromCommandLineOptions):
64248         (runTest):
64249         * Scripts/old-run-webkit-tests:
64250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
64251         (WTR::InjectedBundle::didReceiveMessage):
64252         * WebKitTestRunner/TestController.cpp:
64253         (WTR::TestController::TestController):
64254         (WTR::TestController::initialize):
64255         (WTR::TestController::resetStateToConsistentValues):
64256         * WebKitTestRunner/TestController.h:
64257
64258 2011-04-21  Ojan Vafai  <ojan@chromium.org>
64259
64260         Reviewed by Mihai Parparita.
64261
64262         fix another innocuous JS error in expand/collapseAllExpectations
64263         https://bugs.webkit.org/show_bug.cgi?id=59122
64264
64265         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64266         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
64267
64268 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64269
64270         Reviewed by Tony Chang.
64271
64272         put unexpected passes into their own table
64273         https://bugs.webkit.org/show_bug.cgi?id=59016
64274
64275         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64276
64277 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64278
64279         Reviewed by Tony Chang.
64280
64281         initial set of tests for new results.html file
64282         https://bugs.webkit.org/show_bug.cgi?id=59031
64283
64284         Also, fix the bugs (mostly innocuous JS errors) the tests found.
64285
64286         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64287         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
64288
64289 2011-04-21  Philippe Normand  <pnormand@igalia.com>
64290
64291         Reviewed by Martin Robinson.
64292
64293         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
64294         https://bugs.webkit.org/show_bug.cgi?id=59086
64295
64296         callShouldCloseOnWebView() implementation.
64297
64298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
64299         (LayoutTestController::callShouldCloseOnWebView):
64300
64301 2011-04-21  Philippe Normand  <pnormand@igalia.com>
64302
64303         Reviewed by Martin Robinson.
64304
64305         [GTK] DRT: implement eventSender.scalePageBy
64306         https://bugs.webkit.org/show_bug.cgi?id=59082
64307
64308         * DumpRenderTree/gtk/EventSender.cpp:
64309         (scalePageByCallback): scalePageBy() support.
64310
64311 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
64312
64313         Reviewed by Dimitri Glazkov.
64314
64315         layoutTestController can create and destroy shadow DOM
64316         https://bugs.webkit.org/show_bug.cgi?id=59058
64317
64318         Chromium, Mac, GTK and Qt DRT; and WK2 test runner.
64319
64320         * DumpRenderTree/LayoutTestController.cpp:
64321         (ensureShadowRootCallback):
64322         (removeShadowRootCallback):
64323         (LayoutTestController::staticFunctions):
64324         * DumpRenderTree/LayoutTestController.h:
64325         * DumpRenderTree/chromium/LayoutTestController.cpp:
64326         (LayoutTestController::LayoutTestController):
64327         (LayoutTestController::ensureShadowRoot):
64328         (LayoutTestController::removeShadowRoot):
64329         * DumpRenderTree/chromium/LayoutTestController.h:
64330         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
64331         (LayoutTestController::ensureShadowRoot):
64332         (LayoutTestController::removeShadowRoot):
64333         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
64334         (LayoutTestController::shadowRoot):
64335         (LayoutTestController::ensureShadowRoot):
64336         (LayoutTestController::removeShadowRoot):
64337         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
64338         (LayoutTestController::ensureShadowRoot):
64339         (LayoutTestController::removeShadowRoot):
64340         * DumpRenderTree/qt/LayoutTestControllerQt.h:
64341         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
64342         (LayoutTestController::ensureShadowRoot):
64343         (LayoutTestController::removeShadowRoot):
64344         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
64345         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
64346         (WTR::LayoutTestController::shadowRoot):
64347         (WTR::LayoutTestController::ensureShadowRoot):
64348         (WTR::LayoutTestController::removeShadowRoot):
64349         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
64350
64351 2011-04-20  Dirk Pranke  <dpranke@chromium.org>
64352
64353         Reviewed by Eric Seidel.
64354
64355         new-run-webkit-tests: handle ctrl-c more cleanly
64356         https://bugs.webkit.org/show_bug.cgi?id=58849
64357
64358         * Scripts/new-run-webkit-tests:
64359         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
64360
64361 2011-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
64362
64363         Unreviewed, rolling out r84431.
64364         http://trac.webkit.org/changeset/84431
64365         https://bugs.webkit.org/show_bug.cgi?id=59061
64366
64367         Breaks for folks who don't have editbugs (Requested by abarth
64368         on #webkit).
64369
64370         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
64371         * Scripts/webkitpy/tool/commands/upload_unittest.py:
64372         * Scripts/webkitpy/tool/mocktool.py:
64373         * Scripts/webkitpy/tool/steps/postdiff.py:
64374
64375 2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>
64376
64377         Unreviewed.
64378
64379         Adding myself to committers.py.
64380
64381         * Scripts/webkitpy/common/config/committers.py:
64382
64383 2011-04-20  Adam Barth  <abarth@webkit.org>
64384
64385         Reviewed by Eric Seidel.
64386
64387         webkit-patch upload should assign the bug to you
64388         https://bugs.webkit.org/show_bug.cgi?id=33699
64389
64390         This patch only re-assigns the bug if it is currently unassigned.  We
64391         can be more aggressive in the future if people want us to be more
64392         agressive.
64393
64394         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
64395         * Scripts/webkitpy/tool/commands/upload_unittest.py:
64396         * Scripts/webkitpy/tool/mocktool.py:
64397         * Scripts/webkitpy/tool/steps/postdiff.py:
64398
64399 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
64400
64401         Reviewed by Csaba Osztrogonác.
64402
64403         Modify builder.html template to allow easy access
64404         to list more builds on the builder's page.
64405
64406         https://bugs.webkit.org/show_bug.cgi?id=59008
64407
64408         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
64409
64410 2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>
64411
64412         Reviewed by Csaba Osztrogonác.
64413
64414         Add the default template for builder page.
64415
64416         https://bugs.webkit.org/show_bug.cgi?id=59008
64417
64418         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
64419
64420 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64421
64422         Reviewed by Eric Seidel.
64423
64424         move page generation into a single function
64425         https://bugs.webkit.org/show_bug.cgi?id=59027
64426
64427         Now executing the script doesn't create any state. We should then
64428         be able to write tests for this by setting custom results data.
64429
64430         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64431
64432 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64433
64434         Reviewed by Eric Seidel.
64435
64436         move global state into a shared object
64437         https://bugs.webkit.org/show_bug.cgi?id=59023
64438
64439         This makes the code more testable.
64440
64441         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64442
64443 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64444
64445         Reviewed by Tony Chang.
64446
64447         move global state into a shared object
64448         https://bugs.webkit.org/show_bug.cgi?id=59023
64449
64450         This makes the code more testable.
64451
64452         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64453
64454 2011-04-20  Ojan Vafai  <ojan@chromium.org>
64455
64456         Reviewed by Eric Seidel.
64457
64458         add expandAll/collapseAll links
64459         https://bugs.webkit.org/show_bug.cgi?id=59011
64460
64461         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64462
64463 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
64464
64465         [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
64466
64467         * Scripts/webkitdirs.pm:
64468         * wx/build/build_utils.py:
64469         * wx/build/settings.py:
64470         * wx/install-unix-extras:
64471         * wx/packaging/build-mac-installer.py:
64472         * wx/packaging/build-win-installer.py:
64473
64474 2011-04-20  Adam Roben  <aroben@apple.com>
64475
64476         Replace old-run-webkit-tests's win-7 platform with win-7sp0
64477
64478         It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
64479         version of Windows we cared about, so its results should just go in win. But now that
64480         Windows 7 SP1 exists (and has different results for some tests), we need a place to store
64481         results for Windows 7 without SP1 (and older versions of Windows).
64482
64483         Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
64484         differences from Windows 7 "SP0"
64485
64486         Reviewed by David Kilzer.
64487
64488         * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
64489         will just use "win".
64490
64491         * Scripts/webkitdirs.pm:
64492         (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
64493
64494 2011-04-20  Adam Roben  <aroben@apple.com>
64495
64496         Teach webkitdirs::winVersion about build numbers
64497
64498         The build number isn't currently used, but soon will be.
64499
64500         As a bonus, winVersion now works on non-Cygwin variants of Perl!
64501
64502         Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
64503         SP1
64504
64505         Reviewed by Anders Carlsson.
64506
64507         * Scripts/webkitdirs.pm:
64508         (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
64509         (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
64510         number. Parse the version number into a hash, similar to how osXVersion() works.
64511
64512         (isWindows7):
64513         (isWindowsVista):
64514         (isWindowsXP):
64515         Updated for changes to winVersion().
64516
64517 2011-04-20  W. James MacLean  <wjmaclean@chromium.org>
64518
64519         Reviewed by Kenneth Russell.
64520
64521         Add support for composite-to-texture to DumpRenderTree.
64522         https://bugs.webkit.org/show_bug.cgi?id=58675
64523
64524         * DumpRenderTree/chromium/DumpRenderTree.cpp:
64525         (main):
64526         * DumpRenderTree/chromium/TestShell.cpp:
64527         (TestShell::TestShell):
64528         (TestShell::resetWebSettings):
64529         * DumpRenderTree/chromium/TestShell.h:
64530         (TestShell::setCompositeToTexture):
64531         * DumpRenderTree/chromium/WebPreferences.cpp:
64532         (WebPreferences::reset):
64533         (WebPreferences::applyTo):
64534         * DumpRenderTree/chromium/WebPreferences.h:
64535
64536 2011-04-19  Eric Seidel  <eric@webkit.org>
64537
64538         Reviewed by Adam Barth.
64539
64540         The commit-queue is confused when non-layout tests fail
64541         https://bugs.webkit.org/show_bug.cgi?id=58955
64542
64543         As seen in http://queues.webkit.org/results/8474435
64544
64545         It fails to create an archive of the layout test results
64546         and then throws an exception.
64547
64548         I've fixed this by making it catch the exception as well
64549         as made it so it never calls that path in the common case.
64550
64551         I've updated MockFileSystem to understand rmtree's affect on
64552         directories as well as files.
64553
64554         * Scripts/webkitpy/common/system/filesystem_mock.py:
64555         * Scripts/webkitpy/common/system/workspace.py:
64556         * Scripts/webkitpy/tool/commands/queues.py:
64557         * Scripts/webkitpy/tool/commands/queues_unittest.py:
64558         * Scripts/webkitpy/tool/mocktool.py:
64559
64560 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64561
64562         Fix check for whether a failure is expected to deal with
64563         flaky tests and FAIL expectations.
64564         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64565
64566 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64567
64568         Reviewed by Eric Seidel.
64569
64570         don't show missing text results for tests that only dump image results
64571         https://bugs.webkit.org/show_bug.cgi?id=58931
64572
64573         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64574         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64575
64576 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64577
64578         Reviewed by Eric Seidel.
64579
64580         don't show failures table if there are only new tests
64581         https://bugs.webkit.org/show_bug.cgi?id=58929
64582
64583         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64584
64585 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64586
64587         Reviewed by Eric Seidel.
64588
64589         don't show failures table if there are only new tests
64590         https://bugs.webkit.org/show_bug.cgi?id=58929
64591
64592         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64593
64594 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64595
64596         Fix unittest failures from http://trac.webkit.org/changeset/84294.
64597
64598         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
64599         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
64600
64601 2011-04-18  Ojan Vafai  <ojan@chromium.org>
64602
64603         Reviewed by Eric Seidel.
64604
64605         switch new-run-webkit-tests to using the new results file
64606         https://bugs.webkit.org/show_bug.cgi?id=58861
64607
64608         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
64609         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
64610         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64611
64612 2011-04-19  Renata Hodovan  <reni@webkit.org>
64613
64614         Reviewed by Eric Seidel.
64615
64616         Move the alignment related macros from Vector.h to new Alignment.h.
64617         https://bugs.webkit.org/show_bug.cgi?id=56000
64618
64619         Adding the new file to the forwarding headers of Tools.
64620
64621         * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
64622
64623 2011-04-19  Kevin Ollivier  <kevino@theolliviers.com>
64624
64625         [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
64626
64627         * wx/packaging/build-win-installer.py:
64628         * wx/packaging/wxWebKitInstaller.iss.in:
64629
64630 2011-04-19  Adam Roben  <aroben@apple.com>
64631
64632         Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
64633
64634         * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
64635         accelerated compositing is disabled.
64636
64637 2011-04-19  Ojan Vafai  <ojan@chromium.org>
64638
64639         Remove accidentally committed debug code.
64640         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64641
64642 2011-04-19  Brent Fulgham  <bfulgham@webkit.org>
64643
64644         Unreviewed build correction.
64645
64646         Avoid duplicate stub implementation of test routine
64647         for WinCairo build.
64648
64649         * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
64650         WinCairo from using this stub.
64651
64652 2011-04-18  Ojan Vafai  <ojan@chromium.org>
64653
64654         Reviewed by Eric Seidel.
64655
64656         make results file work with audio and reftests
64657         https://bugs.webkit.org/show_bug.cgi?id=58860
64658
64659         Also fix bug with timeout tests and store a bit in the JSON
64660         for new image tests instead of loading the image result to check if it's there.
64661
64662         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64663         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64664
64665 2011-04-19  Jer Noble  <jer.noble@apple.com>
64666
64667         Reviewed by Adam Roben.
64668
64669         REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
64670         https://bugs.webkit.org/show_bug.cgi?id=58890
64671
64672         Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
64673         Defaults to false.
64674
64675         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
64676         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
64677         (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
64678         (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
64679         (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
64680         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
64681         (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
64682         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
64683         (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
64684         (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
64685
64686 2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
64687
64688         Reviewed by Andreas Kling.
64689
64690         [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
64691         https://bugs.webkit.org/show_bug.cgi?id=35086
64692
64693         fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
64694         a DRT sideeffect problem, because the resetSettings didn't set
64695         the default value of LocalContentCanAccessFileUrls.
64696
64697         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
64698         (WebCore::WebPage::resetSettings):
64699
64700 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
64701
64702         Reviewed by Martin Robinson.
64703
64704         [GTK] Need support for dumping focus rectangles in pixel results
64705         https://bugs.webkit.org/show_bug.cgi?id=53647
64706
64707         Dump the selection rect if it has been requested.
64708
64709         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
64710         (createBitmapContextFromWebView):
64711
64712 2011-04-18  Eric Seidel  <eric@webkit.org>
64713
64714         Reviewed by Adam Barth.
64715
64716         test-webkitpy should run the ActiveWorkItems tests
64717         https://bugs.webkit.org/show_bug.cgi?id=58859
64718
64719         Also make the unit tests pass. :)
64720
64721         * QueueStatusServer/model/activeworkitems.py:
64722         * QueueStatusServer/model/queue.py:
64723         * QueueStatusServer/model/workitems.py:
64724
64725 2011-04-18  Eric Seidel  <eric@webkit.org>
64726
64727         Reviewed by Adam Barth.
64728
64729         queues.webkit.org should show trailing-days pass counts for queues
64730         https://bugs.webkit.org/show_bug.cgi?id=58812
64731
64732         This lets us see if each bot is pulling its own weight or not.
64733         Before I wrote this patch our suspicious was that one of the
64734         cq bots was doing most of the work.  Turns out they're actually
64735         pretty even in their recent pass counts.
64736
64737         * QueueStatusServer/handlers/queuestatus.py:
64738         * QueueStatusServer/index.yaml:
64739         * QueueStatusServer/templates/queuestatus.html:
64740
64741 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
64742
64743         Reviewed by Eric Seidel.
64744
64745         new-run-webkit-tests: obsolete old threading code, part 1
64746         https://bugs.webkit.org/show_bug.cgi?id=58752
64747
64748         This patch removes support for the 'old-inline' and
64749         'old-threads' worker models, and deletes the corresponding code.
64750         Now that the new code is stable, this stuff is no longer
64751         necessary.
64752
64753         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
64754         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
64755         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
64756         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64757         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
64758         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64759
64760 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
64761
64762         Reviewed by Eric Seidel.
64763
64764         new-run-webkit-tests: add an --additional-drt-flag option
64765         https://bugs.webkit.org/show_bug.cgi?id=58680
64766
64767         NRWT has a bunch of command line flags that exist to pass
64768         custom flags to DRT, especially on chromium. It would be nice
64769         if there was a generic mechanism to pass through flags so we
64770         didn't have all the custom ones.
64771
64772         * Scripts/webkitpy/layout_tests/port/chromium.py:
64773         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
64774         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
64775         * Scripts/webkitpy/layout_tests/port/test.py:
64776         * Scripts/webkitpy/layout_tests/port/webkit.py:
64777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
64778
64779 2011-04-05  Jer Noble  <jer.noble@apple.com>
64780
64781         Reviewed by Sam Weinig.
64782
64783         WebKit2: WKTR should support WebKit2 full screen APIs
64784         https://bugs.webkit.org/show_bug.cgi?id=56318
64785
64786         Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
64787         WKTR to test the LayoutTest/fullscreen/ tests.
64788
64789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
64790         (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
64791         (WTR::InjectedBundlePage::supportsFullScreen): Added.
64792         (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
64793         (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
64794         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
64795         * WebKitTestRunner/TestController.cpp:
64796         (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
64797
64798 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
64799
64800         Reviewed by Tony Chang.
64801
64802         new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
64803         https://bugs.webkit.org/show_bug.cgi?id=58388
64804
64805         * Scripts/webkitpy/layout_tests/port/chromium.py:
64806
64807 2011-04-18  Evan Martin  <evan@chromium.org>
64808
64809         Reviewed by Eric Seidel.
64810
64811         [chromium] expose title direction to webkit client
64812         https://bugs.webkit.org/show_bug.cgi?id=58823
64813
64814         * DumpRenderTree/chromium/LayoutTestController.cpp:
64815         (LayoutTestController::LayoutTestController):
64816         (LayoutTestController::reset):
64817         * DumpRenderTree/chromium/LayoutTestController.h:
64818         (LayoutTestController::setTitleTextDirection):
64819         Add member and setter to let us stash the title direction at load time.
64820
64821         * DumpRenderTree/chromium/WebViewHost.cpp:
64822         (WebViewHost::didReceiveTitle):
64823         * DumpRenderTree/chromium/WebViewHost.h:
64824         Adapt to new API; push the title into layoutTestController when we
64825         receive it.
64826
64827 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
64828
64829         Unreviewed.
64830
64831         Re-land r84112. It was rolled out in r84127 but it didn't need
64832         to be. Only r84111 actually broke things.
64833
64834         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
64835         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64836
64837 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
64838
64839         Reviewed by Tony Chang.
64840
64841         new-run-webkit-tests: don't run more processes than necessary
64842         https://bugs.webkit.org/show_bug.cgi?id=58751
64843
64844         Previously NRWT would start up 1 process for each processor on
64845         the machine by default, which was a waste if we were only
64846         running a few shards of tests.
64847
64848         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
64849         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
64850         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64851
64852 2011-04-18  Ojan Vafai  <ojan@chromium.org>
64853
64854         Reviewed by Eric Seidel.
64855
64856         include links to actual.png files for new pixel tests
64857         https://bugs.webkit.org/show_bug.cgi?id=58831
64858
64859         Load image elements to confirm whether the files exist.
64860         Image elements will load without being appended to the DOM.
64861
64862         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64863
64864 2011-04-18  Ojan Vafai  <ojan@chromium.org>
64865
64866         Reviewed by Eric Seidel.
64867
64868         add a zoomed view for pixel results to the new results html file
64869         https://bugs.webkit.org/show_bug.cgi?id=58827
64870
64871         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64872
64873 2011-04-18  Ojan Vafai  <ojan@chromium.org>
64874
64875         Reviewed by Eric Seidel.
64876
64877         add labels to results html page
64878         https://bugs.webkit.org/show_bug.cgi?id=58803
64879
64880         -fix iframe size to be the size of the png results
64881         -fix a bunch of aesthetic nits
64882         -fix some incorrectly styled code
64883
64884         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
64885
64886 2011-04-18  Chang Shu  <cshu@webkit.org>
64887
64888         Reviewed by Eric Seidel.
64889
64890         WebKitTestRunner needs layoutTestController.pathToLocalResource
64891         https://bugs.webkit.org/show_bug.cgi?id=42541
64892
64893         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
64894         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
64895         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
64896         (WTR::LayoutTestController::pathToLocalResource):
64897         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
64898         (WTR::LayoutTestController::pathToLocalResource):
64899         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
64900         (WTR::LayoutTestController::pathToLocalResource):
64901
64902 2011-04-18  Timothy Hatcher  <timothy@apple.com>
64903
64904         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
64905         now that all localized strings in WebKit/win use WEB_UI_STRING.
64906
64907         https://webkit.org/b/58747
64908
64909         Reviewed by Dan Bernstein.
64910
64911         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
64912
64913 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
64914
64915         Reviewed by Adam Roben.
64916
64917         [WIN] Use WCHAR instead of TCHAR
64918         https://bugs.webkit.org/show_bug.cgi?id=58755
64919
64920         We always use the UNICODE versions of windows functions, so
64921         the usage of TCHAR makes no sense and mixing them is bad style.
64922
64923         * WinLauncher/PrintWebUIDelegate.cpp:
64924           Also fix various style issues (including indentation and removal of ugly C-casts).
64925         * WinLauncher/WinLauncher.cpp:
64926
64927 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
64928
64929         Reviewed by Andreas Kling.
64930
64931         Add layoutTestController.shadowRoot to Qt DRT.
64932         https://bugs.webkit.org/show_bug.cgi?id=58759
64933
64934         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
64935         (LayoutTestController::shadowRoot): Added.
64936         * DumpRenderTree/qt/LayoutTestControllerQt.h:
64937
64938 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
64939
64940         Unreviewed, rolling out r84111.
64941         http://trac.webkit.org/changeset/84111
64942         https://bugs.webkit.org/show_bug.cgi?id=58771
64943
64944         Chromium linux layout tests are broken. (Requested by loislo2
64945         on #webkit).
64946
64947         * Scripts/webkitpy/layout_tests/port/chromium.py:
64948         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
64949         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
64950
64951 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
64952
64953         Unreviewed, rolling out r84112.
64954         http://trac.webkit.org/changeset/84112
64955         https://bugs.webkit.org/show_bug.cgi?id=58770
64956
64957         Chromium linux layout tests are broken. (Requested by loislo2
64958         on #webkit).
64959
64960         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
64961         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
64962
64963 2011-04-17  Daniel Bates  <dbates@webkit.org>
64964
64965         Reviewed by Eric Seidel and Adam Barth.
64966
64967         webkit-patch land hangs if svn prompts for credentials
64968         https://bugs.webkit.org/show_bug.cgi?id=31500
64969
64970         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
64971
64972         * Scripts/webkitpy/common/checkout/scm.py:
64973           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
64974           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
64975             for argument realm; modified call sites as needed.
64976           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
64977           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
64978           - Modified Git._commit_on_branch() to take optional username and password argument.
64979           - Modified Git.push_local_commits_to_server() to take optional username and password
64980             argument and to call has_authorization_for_realm().
64981         * Scripts/webkitpy/common/checkout/scm_unittest.py:
64982           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
64983           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
64984             SVN.has_authorization_for_realm().
64985         * Scripts/webkitpy/common/net/credentials.py:
64986           - Modified Credentials.read_credentials() to call User.prompt_password() instead
64987             of using getpass.getpass() directly.
64988         * Scripts/webkitpy/common/system/user.py:
64989           - Added User.prompt_password().
64990         * Scripts/webkitpy/tool/steps/commit.py:
64991           - Modified Commit.run() to prompt for a password if needed.
64992
64993 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
64994
64995         Reviewed by Ojan Vafai.
64996
64997         new-run-webkit-tests: save stderr into the layout-test-results dir
64998         https://bugs.webkit.org/show_bug.cgi?id=58690
64999
65000         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
65001         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
65002
65003 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
65004
65005         Reviewed by Ojan Vafai.
65006
65007         new-run-webkit-tests: read stderr from chromium DRT separately
65008         https://bugs.webkit.org/show_bug.cgi?id=58708
65009
65010         * Scripts/webkitpy/layout_tests/port/chromium.py:
65011         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
65012         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
65013
65014 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
65015
65016         Reviewed by Adam Barth.
65017
65018         Rename PLATFORM(CA) to USE(CA)
65019         https://bugs.webkit.org/show_bug.cgi?id=58742
65020
65021         * DumpRenderTree/mac/DumpRenderTree.mm:
65022         (resetDefaultsToConsistentValues):
65023
65024 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
65025
65026         Reviewed by Adam Barth.
65027
65028         Rename PLATFORM(CG) to USE(CG)
65029         https://bugs.webkit.org/show_bug.cgi?id=58729
65030
65031         * DumpRenderTree/PixelDumpSupport.cpp:
65032         * DumpRenderTree/chromium/WebViewHost.cpp:
65033         (WebViewHost::paintRect):
65034         * DumpRenderTree/config.h:
65035         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
65036         (createBitmapContextFromWebView):
65037         * TestWebKitAPI/PlatformWebView.h:
65038         * WebKitTestRunner/config.h:
65039         * WebKitTestRunner/win/TestInvocationWin.cpp:
65040
65041 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
65042
65043         Reviewed by Eric Seidel.
65044
65045         Rename PLATFORM(CAIRO) to USE(CAIRO)
65046         https://bugs.webkit.org/show_bug.cgi?id=55192
65047
65048         * DumpRenderTree/PixelDumpSupport.cpp:
65049         * DumpRenderTree/config.h:
65050         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
65051         (createBitmapContextFromWebView):
65052         * WebKitTestRunner/config.h:
65053
65054 2011-04-16  Ojan Vafai  <ojan@chromium.org>
65055
65056         Reviewed by Eric Seidel.
65057
65058         show diffs+test inline in the results page
65059         https://bugs.webkit.org/show_bug.cgi?id=58723
65060
65061         Put each row in it's own tbody and sort based on tbodies. That way
65062         we can append the results to the tbody inline as another table row.
65063
65064         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65065
65066 2011-04-16  Ojan Vafai  <ojan@chromium.org>
65067
65068         Reviewed by Eric Seidel.
65069
65070         handle new tests in the new results html file
65071         https://bugs.webkit.org/show_bug.cgi?id=58715
65072
65073         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65074
65075 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
65076
65077         Reviewed by Ojan Vafai.
65078
65079         old-run-webkit-tests: save the list of tests actually run to a file
65080         https://bugs.webkit.org/show_bug.cgi?id=58692
65081
65082         * Scripts/old-run-webkit-tests:
65083
65084 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
65085
65086         Reviewed by Ojan Vafai.
65087
65088         fix MockFileSystem.abspath() on windows
65089         https://bugs.webkit.org/show_bug.cgi?id=58713
65090
65091         The existing code was borked on Windows if a path was passed
65092         in using a drive letter (e.g., "d:\foo.txt"), and would go
65093         into an infinite recursive loop. While win paths shouldn't
65094         normally be passed into the mock filesystem, this just
65095         bulletproofs things a bit (note that "/foo.txt" is considered
65096         an absolute path on windows python as well.
65097
65098         * Scripts/webkitpy/common/system/filesystem_mock.py:
65099
65100 2011-04-15  Ojan Vafai  <ojan@chromium.org>
65101
65102         Reviewed by Eric Seidel.
65103
65104         show stderr files and httpd log files
65105         https://bugs.webkit.org/show_bug.cgi?id=58714
65106
65107         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65108         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65109
65110 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
65111
65112         Reviewed by James Robinson.
65113
65114         Add a flag to guard Page Visibility API changes.
65115         https://bugs.webkit.org/show_bug.cgi?id=58464
65116
65117         * Scripts/build-webkit:
65118
65119 2011-04-15  Chang Shu  <cshu@webkit.org>
65120
65121         Reviewed by Alexey Proskuryakov.
65122
65123         When a message with url embedded is added to console, the "file:" scheme
65124         and path should be stripped.
65125         https://bugs.webkit.org/show_bug.cgi?id=58665
65126
65127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
65128         (WTR::lastFileURLPathComponent):
65129         (WTR::InjectedBundlePage::willAddMessageToConsole):
65130
65131 2011-04-15  Jeff Miller  <jeffm@apple.com>
65132
65133         Reviewed by Sam Weinig.
65134
65135         Add takeFocus callback to WKPageUIClient
65136         https://bugs.webkit.org/show_bug.cgi?id=58686
65137
65138         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
65139
65140         * MiniBrowser/mac/BrowserWindowController.m:
65141         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
65142         * MiniBrowser/win/BrowserView.cpp:
65143         (BrowserView::create): Added empty takeFocus entry.
65144         * WebKitTestRunner/TestController.cpp:
65145         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
65146         (WTR::TestController::initialize): Added empty takeFocus entry.
65147
65148 2011-04-15  Ojan Vafai  <ojan@chromium.org>
65149
65150         Reviewed by Eric Seidel.
65151
65152         only show pretty-diff/wdiff if they were generated
65153         https://bugs.webkit.org/show_bug.cgi?id=58682
65154
65155         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65156         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65157         * Scripts/webkitpy/layout_tests/port/base.py:
65158
65159 2011-04-15  Andreas Kling  <kling@webkit.org>
65160
65161         Reviewed by Antonio Gomes.
65162
65163         [Qt] DRT: Default custom policy delegate decision should be Ignore.
65164
65165         If layoutTestController.setCustomPolicyDelegate() is called with only
65166         one argument, the second ("permissive") should default to false.
65167
65168         * DumpRenderTree/qt/LayoutTestControllerQt.h:
65169
65170 2011-04-15  Ojan Vafai  <ojan@chromium.org>
65171
65172         Reviewed by Eric Seidel.
65173
65174         fix path to layout test in new results file
65175         https://bugs.webkit.org/show_bug.cgi?id=58618
65176
65177         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65178         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65179
65180 2011-04-15  Ojan Vafai  <ojan@chromium.org>
65181
65182         Reviewed by Eric Seidel.
65183
65184         fix sorting in new results file
65185         https://bugs.webkit.org/show_bug.cgi?id=58616
65186
65187         -Fix the custom sort to return -1, 0, 1 instead of true/false.
65188         -Secondary sort by test name when sort values are equal.
65189         -Sort by test name by default.
65190
65191         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65192
65193 2011-04-15  Dmitry Lomov  <dslomov@google.com>
65194
65195         Reviewed by David Levin.
65196
65197         check-webkit-style shouldn't complain about not including a primary header file
65198         if none exists
65199         https://bugs.webkit.org/show_bug.cgi?id=39514
65200
65201         * Scripts/webkitpy/style/checkers/cpp.py:
65202         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
65203
65204 2011-04-15  Eric Seidel  <eric@webkit.org>
65205
65206         Reviewed by Mihai Parparita.
65207
65208         queues.webkit.org should display when a bot last rebooted
65209         https://bugs.webkit.org/show_bug.cgi?id=58562
65210
65211         There is more repeated code here than I would like.  I fear
65212         my django-fu isn't quite up to snuff.
65213
65214         * QueueStatusServer/handlers/queuestatus.py:
65215         * QueueStatusServer/templates/queuestatus.html:
65216
65217 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
65218
65219         Reviewed by Adam Barth.
65220
65221         Remove dependency on chromium skia::PlatformCanvas
65222         https://bugs.webkit.org/show_bug.cgi?id=57563
65223
65224         Fixed compile error on Mac when using Core Graphics.
65225
65226         * DumpRenderTree/chromium/WebViewHost.cpp:
65227         (WebViewHost::paintRect):
65228
65229 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
65230
65231         Reviewed by James Robinson.
65232
65233         Remove dependency on chromium skia::PlatformCanvas
65234         https://bugs.webkit.org/show_bug.cgi?id=57563
65235
65236         * DumpRenderTree/chromium/TestShell.cpp:
65237         (makeCanvasOpaque):
65238         (TestShell::dumpImage):
65239         * DumpRenderTree/chromium/TestShell.h:
65240         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
65241         (WebThemeControlDRTWin::WebThemeControlDRTWin):
65242         (WebThemeControlDRTWin::draw):
65243         (WebThemeControlDRTWin::drawTextField):
65244         (WebThemeControlDRTWin::drawProgressBar):
65245         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
65246         * DumpRenderTree/chromium/WebViewHost.cpp:
65247         (WebViewHost::canvas):
65248         * DumpRenderTree/chromium/WebViewHost.h:
65249
65250 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
65251
65252         Reviewed by Laszlo Gombos.
65253
65254         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
65255         https://bugs.webkit.org/show_bug.cgi?id=58007
65256
65257         Adds flag to start the test browsers maximized.
65258         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
65259         suit.
65260         Also fixes some ToggleFullScreen issues so that prior window state is
65261         restored.
65262
65263         * MiniBrowser/qt/BrowserWindow.cpp:
65264         (BrowserWindow::BrowserWindow):
65265         (BrowserWindow::toggleFullScreenMode):
65266         * MiniBrowser/qt/MiniBrowserApplication.cpp:
65267         (MiniBrowserApplication::handleUserOptions):
65268         * MiniBrowser/qt/MiniBrowserApplication.h:
65269         (WindowOptions::WindowOptions):
65270         * QtTestBrowser/launcherwindow.cpp:
65271         (LauncherWindow::init):
65272         (LauncherWindow::toggleFullScreenMode):
65273         * QtTestBrowser/launcherwindow.h:
65274         (WindowOptions::WindowOptions):
65275         * QtTestBrowser/main.cpp:
65276         (LauncherApplication::handleUserOptions):
65277
65278 2011-04-14  Ojan Vafai  <ojan@chromium.org>
65279
65280         Reviewed by Eric Seidel.
65281
65282         add checkbox to only show unexpected results to new results file
65283         https://bugs.webkit.org/show_bug.cgi?id=58606
65284
65285         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65286
65287 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
65288
65289         Reviewed by Martin Robinson.
65290
65291         [WinCairo] Implement ImageDiff Logic.
65292         http://bugs.webkit.org/show_bug.cgi?id=58486
65293
65294         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
65295         (strtof):
65296         (readFromData):
65297         (createImageFromStdin):
65298         (releaseMallocBuffer):
65299         (createDifferenceImage):
65300         (imageHasAlpha):
65301         (writeToData):
65302         (main):
65303         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
65304           ImageDiffCairo.cpp (excluding from Apple builds).
65305         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
65306           new ImageDiffWinCairoCommon.vsprops file.
65307         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
65308           new ImageDiffWinCairoCommon.vsprops file.
65309         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
65310         * Scripts/old-run-webkit-tests: Make sure proper executable
65311           is built and executed for WinCairo port.
65312
65313 2011-04-14  Ojan Vafai  <ojan@chromium.org>
65314
65315         Reviewed by Eric Seidel.
65316
65317         only show expected failure type for ports that use an expectations file
65318         https://bugs.webkit.org/show_bug.cgi?id=58588
65319
65320         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65321         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65322
65323 2011-04-14  Eric Seidel  <eric@webkit.org>
65324
65325         Reviewed by Adam Barth.
65326
65327         commit-queue fails to catch IOError when results.html is missing
65328         https://bugs.webkit.org/show_bug.cgi?id=58589
65329
65330         * Scripts/webkitpy/tool/commands/queues.py:
65331         * Scripts/webkitpy/tool/commands/queues_unittest.py:
65332
65333 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
65334
65335         [wx] Unreviewed build fix for Mac installation script.
65336
65337         * wx/packaging/build-mac-installer.py:
65338
65339 2011-04-14  Ojan Vafai  <ojan@chromium.org>
65340
65341         Reviewed by Tony Chang.
65342
65343         sort columns in the new json_results.html file
65344         https://bugs.webkit.org/show_bug.cgi?id=58581
65345
65346         Also fix padding on TDs and the path to layout tests.
65347
65348         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
65349
65350 2011-04-14  Eric Seidel  <eric@webkit.org>
65351
65352         Reviewed by Dimitri Glazkov.
65353
65354         queues.webkit.org should display when a bot last passed a patch
65355         https://bugs.webkit.org/show_bug.cgi?id=58546
65356
65357         I am suspicious that some of our commit-queue instances are never
65358         actually passing anything.
65359
65360         This will let us know if those bots are never passing patches.
65361
65362         * QueueStatusServer/handlers/queuestatus.py:
65363         * QueueStatusServer/index.yaml:
65364         * QueueStatusServer/templates/queuestatus.html:
65365
65366 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
65367
65368         Reviewed by Adam Roben.
65369
65370         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
65371         https://bugs.webkit.org/show_bug.cgi?id=58545
65372
65373         Remove platform-specific overrides; the default behavior should
65374         be working everywhere now, I think.
65375
65376         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
65377         * Scripts/webkitpy/layout_tests/port/mac.py:
65378
65379 2011-04-14  Eric Seidel  <eric@webkit.org>
65380
65381         Reviewed by Adam Barth.
65382
65383         commit-queues are hitting an exception trying to land when the tree is red
65384         https://bugs.webkit.org/show_bug.cgi?id=58558
65385
65386         Just an un-tested (and thus broken) code path from yesterday's changes.
65387
65388         * Scripts/webkitpy/common/net/layouttestresults.py:
65389         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
65390         * Scripts/webkitpy/tool/commands/queues.py:
65391         * Scripts/webkitpy/tool/commands/queues_unittest.py:
65392
65393 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
65394
65395         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
65396
65397         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
65398         (LayoutTestController::shadowRoot):
65399         * wx/build/wxpresets.py:
65400
65401 2011-04-14  Victoria Kirst  <vrk@google.com>
65402
65403         Reviewed by James Robinson.
65404
65405         [chromium] Failing GPU video tests
65406         https://bugs.webkit.org/show_bug.cgi?id=57926
65407
65408         Added/updated GPU directory names for rebaseline tool.
65409
65410         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
65411
65412 2011-04-13  Daniel Bates  <dbates@rim.com>
65413
65414         Reviewed by Adam Barth.
65415
65416         Perl unit test removeEOL.pl should print test case name on failure
65417         https://bugs.webkit.org/show_bug.cgi?id=58513
65418
65419         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
65420           second argument of Test::Simple::ok().
65421
65422 2011-04-13  Kent Tamura  <tkent@chromium.org>
65423
65424         Reviewed by Eric Seidel.
65425
65426         gdb-safari should pass arguments to safari.
65427         https://bugs.webkit.org/show_bug.cgi?id=58439
65428
65429         We can do:
65430           gdb-safari --debug LayoutTests/.../foo.html
65431
65432         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
65433
65434 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65435
65436         Unreviewed, build fix.
65437         https://bugs.webkit.org/show_bug.cgi?id=52763
65438
65439         r83799 broke test-webkitpy because it assumed we always have
65440         access to a real filesystem (we don't during the unit tests).
65441         Stubbing out the copy for now but we might need a better
65442         solution at some point.
65443
65444         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65445
65446 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65447
65448         Reviewed by Tony Chang.
65449
65450         new-run-webkit-tests --run-singly option is busted
65451         https://bugs.webkit.org/show_bug.cgi?id=55909
65452
65453         Python's broken lexical scoping strikes again :(.
65454
65455         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
65456         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
65457
65458 2011-04-13  Ojan Vafai  <ojan@chromium.org>
65459
65460         Reviewed by Eric Seidel.
65461
65462         generated unexpected_results.html from unexpected_results.json
65463         https://bugs.webkit.org/show_bug.cgi?id=52763
65464
65465         Eventually, we'll merge this with results.html and have a single richer results page.
65466         For now, I just want to get something checked in that we can iterate on.
65467
65468         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
65469         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65470
65471 2011-04-13  Eric Seidel  <eric@webkit.org>
65472
65473         Reviewed by Adam Barth.
65474
65475         Up the failure limit to allow the commit-queue to actually land when the tree is red
65476         https://bugs.webkit.org/show_bug.cgi?id=58499
65477
65478         This change increases the --exit-after-N-failures limit used by the commit-queue
65479         from 1 to 10.  This will cause the code added in bug 58494 to actually get
65480         exercised and the queues should start being able to land when the trees are red.
65481
65482         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
65483         only unit test to actually detect this change!  Since we don't actually
65484         run on leopard anymore, I removed the hack code and repurposed the test.
65485
65486         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
65487         * Scripts/webkitpy/tool/steps/runtests.py:
65488         * Scripts/webkitpy/tool/steps/steps_unittest.py:
65489
65490 2011-04-13  Eric Seidel  <eric@webkit.org>
65491
65492         Reviewed by Adam Barth.
65493
65494         commit-queue should be able to land when tree is red
65495         https://bugs.webkit.org/show_bug.cgi?id=58494
65496
65497         There is some yak hair on my hands, I will admit.
65498
65499         This change is mostly about adding an ExpectedFailures
65500         class to track when the bots are red and we should be
65501         ignoring failures when landing from the commit-queue.
65502
65503         However, to make intelligent decisions about patches we
65504         need to know whether the run hit the --exit-after-N-failures limit
65505         or not.  Right now that information is not saved off in results.html
65506         so we have to pull the information from RunTests.
65507
65508         I've plumbed the --exit-after-N-failures information into
65509         LayoutTestResults for now to make the ExpectedFailures code cleaner.
65510
65511         As a result of adding all these additional calls to delegate.layout_test_results()
65512         I broke some of our flaky test detection tests and had to re-write them
65513         to not depend on the number of layout_test_results code.
65514
65515         At the same time I updated the commit-queue to use the newer filesystem
65516         API (to allow us to use MockFileSystem) which required further changes
65517         to the layout tests.  Changes were required in either case, since
65518         we're now calling layout_test_results() in more cases, which previously
65519         would try and hit the disk (until I moved it to use tool.filesystem).
65520
65521         I should note that *all* of this code is disabled for now, since our
65522         --exit-after-N-failures limit is currently 1!  (Thus were always in the
65523         case where we can't actually tell if the layout test results are legit.)
65524         I will up that limit in a second patch (which may require a couple more unit test tweaks).
65525
65526         * Scripts/webkitpy/common/net/layouttestresults.py:
65527         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
65528         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
65529         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
65530         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
65531         * Scripts/webkitpy/tool/commands/queues.py:
65532         * Scripts/webkitpy/tool/commands/queues_unittest.py:
65533         * Scripts/webkitpy/tool/commands/queuestest.py:
65534         * Scripts/webkitpy/tool/steps/runtests.py:
65535
65536 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
65537
65538         Unreviewed build correction.
65539
65540         * TestWebKitAPI/PlatformWebView.h: Limit include of
65541           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
65542
65543 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
65544
65545         Reviewed by Eric Seidel.
65546
65547         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
65548         https://bugs.webkit.org/show_bug.cgi?id=58489
65549
65550         r83743 added --additional-platform-directory to old-run-webkit-tests,
65551         rename the equivalent flag in new-run-webkit-tests to be consistent.
65552
65553         * Scripts/webkitpy/layout_tests/port/base.py:
65554         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
65555         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
65556         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
65557
65558 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
65559
65560         Reviewed by Eric Seidel.
65561
65562         Rebaseline queue server
65563         https://bugs.webkit.org/show_bug.cgi?id=57891
65564
65565         Adds a simple rebaseline queue server (meant to run at
65566         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
65567         builders and their failing tests, and allows those tests to be added to
65568         a per-builer rebaseline queue.
65569
65570         A subsequent change will add a mode to NRWT (and/or a wrapper script)
65571         for pulling the tests to be rebaselined from the server and running them
65572         with --reset-results (the initial use-case is for the GPU hardware bots,
65573         which do not have checked-in baselines, therefore there is no need for a
65574         check-in step yet).
65575
65576         * RebaselineQueueServer/app.yaml: Added.
65577         * RebaselineQueueServer/handlers/__init__.py: Added.
65578         * RebaselineQueueServer/handlers/builderqueue.py: Added.
65579         * RebaselineQueueServer/handlers/pages.py: Added.
65580         * RebaselineQueueServer/index.yaml: Added.
65581         * RebaselineQueueServer/main.py: Added.
65582         * RebaselineQueueServer/model/__init__.py: Added.
65583         * RebaselineQueueServer/model/queueentry.py: Added.
65584         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
65585         * RebaselineQueueServer/static/styles.css: Added.
65586         * RebaselineQueueServer/templates/builder-picker.html: Added.
65587         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
65588         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
65589         * RebaselineQueueServer/templates/home.html: Added.
65590
65591 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65592
65593         Reviewed by Mihai Parparita.
65594
65595         nrwt: enable multiple processes by default on Chromium Win.
65596         https://bugs.webkit.org/show_bug.cgi?id=55163
65597
65598         Re-land r79268; it should be more stable now and will hopefully
65599         work.
65600
65601         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
65602         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
65603
65604 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65605
65606         Reviewed by Ojan Vafai.
65607
65608         new-run-webkit-tests: configure logging in child processes properly
65609         https://bugs.webkit.org/show_bug.cgi?id=58296
65610
65611         Logging propagated properly from manager to worker processes on
65612         Unix but not on Windows; this fixes that.
65613
65614         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
65615         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
65616
65617 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65618
65619         Reviewed by Ojan Vafai.
65620
65621         new-run-webkit-tests: suppress extraneous pretty patch warnings
65622         https://bugs.webkit.org/show_bug.cgi?id=58295
65623
65624         NRWT wasn't being careful about when it logged messages from
65625         PrettyPatch not being available; it should only log during
65626         check_build(), and be silent otherwise. This was causing us to
65627         get multiple errors at runtime, which was confusing.
65628
65629         * Scripts/webkitpy/layout_tests/port/base.py:
65630         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
65631         * Scripts/webkitpy/layout_tests/port/chromium.py:
65632
65633 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
65634
65635         Reviewed by Jian Li.
65636
65637         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
65638         https://bugs.webkit.org/show_bug.cgi?id=58461
65639
65640         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
65641
65642 2011-04-13  Tony Chang  <tony@chromium.org>
65643
65644         Unreviewed, fix NRWT.  Stack:
65645
65646             return super(ChromiumPort, self).results_directory(self)
65647         TypeError: results_directory() takes exactly 1 argument (2 given)
65648
65649         * Scripts/webkitpy/layout_tests/port/chromium.py:
65650
65651 2011-04-13  Adam Roben  <aroben@apple.com>
65652
65653         Teach ORWT about extra platform-specific directories to be searched before the default ones
65654
65655         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
65656         platform-specific results
65657
65658         Reviewed by Anders Carlsson.
65659
65660         * Scripts/old-run-webkit-tests:
65661         (top-level): Added @additionalPlatformDirectories and hooked up
65662         --additional-platform-directories to populate it.
65663         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
65664         list (after filtering out any of the additional directories that don't exist).
65665
65666 2011-04-13  Lucas Forschler  <lforschler@apple.com>
65667
65668         Reviewed by Adam Roben.
65669
65670         Add the /T command to taskkill.exe.
65671         This will kill spawned child processes.
65672
65673         * BuildSlaveSupport/win/kill-old-processes:
65674
65675 2011-04-13  Lucas Forschler  <lforschler@apple.com>
65676
65677         Reviewed by Adam Roben.
65678
65679         Sort kill list alphabeticaly.
65680         Fixed capitalization on VcBuildHelper.
65681
65682         * BuildSlaveSupport/win/kill-old-processes:
65683
65684 2011-04-13  Lucas Forschler  <lforschler@apple.com>
65685
65686         Reviewed by Adam Roben.
65687
65688         https://bugs.webkit.org/show_bug.cgi?id=58384
65689         Update kill-old-processes to include a few new ones.
65690
65691         * BuildSlaveSupport/win/kill-old-processes:
65692
65693 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
65694
65695         Reviewed by Martin Robinson.
65696
65697         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
65698         https://bugs.webkit.org/show_bug.cgi?id=58297
65699
65700         Do not disable flash specifically when built with GTK+ 3 -
65701         PluginPackage should do the right thing while loading plugins.
65702
65703         * GtkLauncher/main.c:
65704         (main):
65705
65706 2011-04-12  Kent Tamura  <tkent@chromium.org>
65707
65708         Reviewed by Dimitri Glazkov.
65709
65710         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
65711         https://bugs.webkit.org/show_bug.cgi?id=57426
65712
65713         * DumpRenderTree/chromium/WebPreferences.cpp:
65714         (WebPreferences::applyTo): Disable the validation message timer.
65715
65716 2011-04-12  James Kozianski  <koz@chromium.org>
65717
65718         Unreviewed.
65719
65720         Adding myself to committers.py.
65721
65722         * Scripts/webkitpy/common/config/committers.py:
65723
65724 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
65725
65726         Unreviewed build correction for WinCairo bot after r83639.
65727         https://bugs.webkit.org/show_bug.cgi?id=51790
65728
65729         Correct typo for the new "update-webkit-wincairo-libs" script.
65730
65731         * Scripts/build-webkit: Incorrectly calling the
65732           update-webkit-cairo-libs which does not exist.
65733
65734 2011-04-12  Alice Liu  <alice.liu@apple.com>
65735
65736         Reviewed by Jon Honeycutt.
65737
65738         A change that should have been part of http://trac.webkit.org/changeset/83628
65739
65740         * DumpRenderTree/win/DumpRenderTree.cpp:
65741         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
65742
65743 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
65744
65745         Reviewed by Tony Chang.
65746
65747         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
65748         https://bugs.webkit.org/show_bug.cgi?id=58272
65749
65750         NRWT was interpreting the --results-directory cmd line arg as
65751         relative to the build directory, not the current working
65752         directory (ORWT uses the latter, which is much more intuitive).
65753
65754         This patch fixes the base case, but includes an override for
65755         Chromium that is needed until the bots can be updated.
65756
65757         * Scripts/webkitpy/layout_tests/port/base.py:
65758         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
65759         * Scripts/webkitpy/layout_tests/port/chromium.py:
65760         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
65761         * Scripts/webkitpy/layout_tests/port/test.py:
65762         * Scripts/webkitpy/layout_tests/port/webkit.py:
65763         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
65764         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
65765
65766 2011-04-12  Philippe Normand  <pnormand@igalia.com>
65767
65768         Unreviewed, roll out r83621 as it broke the GTK build.
65769
65770         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
65771         https://bugs.webkit.org/show_bug.cgi?id=58333
65772
65773         * Scripts/build-jsc:
65774         * Scripts/build-webkit:
65775
65776 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
65777
65778         Reviewed by Adam Roben.
65779
65780         Patch to download the WinCairo dependancies as part of build-webkit.
65781         https://bugs.webkit.org/show_bug.cgi?id=51790
65782
65783         This patch downloads the dependancies from
65784             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
65785         checking the modification timestamp etc.
65786
65787         * Tools/Scripts/build-webkit
65788         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
65789           flag, and to update WinCairo dependencies when used.
65790         * Tools/Scripts/update-webkit-cairo-libs: added
65791         * Tools/Scripts/update-webkit-dependency: added
65792         * Tools/Scripts/update-webkit-auxiliary-libs
65793
65794 2011-04-12  Jeff Miller  <jeffm@apple.com>
65795
65796         Reviewed by Adam Roben.
65797
65798         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
65799         https://bugs.webkit.org/show_bug.cgi?id=56020
65800
65801         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
65802         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
65803         which would generate two characters for every keypress (for example).  I didn't bother doing this for
65804         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
65805
65806         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
65807
65808         * MiniBrowser/win/main.cpp:
65809         (shouldTranslateMessage): Added.
65810         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
65811         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
65812         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
65813         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
65814         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
65815         (TestWebKitAPI::runAndWatchForWMChar): Added.
65816         (TestWebKitAPI::TEST): Added.
65817         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
65818         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
65819         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
65820         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
65821         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
65822         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
65823
65824 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
65825
65826         Reviewed by Tony Chang.
65827
65828         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
65829         https://bugs.webkit.org/show_bug.cgi?id=58290
65830
65831         This is some preliminary refactoring for bug 58272.
65832
65833         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
65834         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
65835         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
65836         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
65837         * Scripts/webkitpy/layout_tests/port/test.py:
65838         * Scripts/webkitpy/layout_tests/port/chromium.py:
65839         * Scripts/webkitpy/layout_tests/port/base.py:
65840         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
65841
65842 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
65843
65844         Reviewed by Eric Seidel.
65845
65846         webkitpy: fix mock_filesystem abspath to handle relative paths
65847         and add filesystem.chdir() and filesystem.getcwd() to be able
65848         to test this and mock it out.
65849
65850         https://bugs.webkit.org/show_bug.cgi?id=58288
65851
65852         * Scripts/webkitpy/common/system/filesystem.py:
65853         * Scripts/webkitpy/common/system/filesystem_mock.py:
65854         * Scripts/webkitpy/common/system/filesystem_unittest.py:
65855
65856 2011-04-12  Alice Liu  <alice.liu@apple.com>
65857
65858         Reviewed by Sam Weinig.
65859
65860         https://bugs.webkit.org/show_bug.cgi?id=58292
65861         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
65862
65863         * DumpRenderTree/mac/DumpRenderTree.mm:
65864         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
65865
65866 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
65867
65868         Reviewed by Eric Seidel.
65869
65870         [Qt] Enable JIT build for SH4 platforms.
65871         https://bugs.webkit.org/show_bug.cgi?id=58317
65872
65873
65874         * DumpRenderTree/qt/DumpRenderTree.pro:
65875         * QtTestBrowser/QtTestBrowser.pro:
65876         * Scripts/webkitdirs.pm:
65877
65878 2011-04-12  Tony Chang  <tony@chromium.org>
65879
65880         Reviewed by Andreas Kling.
65881
65882         [Qt] embed checksums in PNGs written by Qt-DRT
65883         https://bugs.webkit.org/show_bug.cgi?id=58173
65884
65885         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
65886         (WebCore::DumpRenderTree::dump):
65887
65888 2011-04-12  Eric Seidel  <eric@webkit.org>
65889
65890         Reviewed by Adam Barth.
65891
65892         commit-queue should upload failure diffs when tests fail
65893         https://bugs.webkit.org/show_bug.cgi?id=58348
65894
65895         This change was mostly just plumbing.  We were already saving
65896         this information for flaky test reporting.  I just made it possible
65897         for normal failures to report archives as well.
65898
65899         I did a little abstraction work to try and share some code between
65900         flakytestreporter.py and this new code.  There is still more we could do.
65901
65902         In making this change I also went through and updated the various
65903         places we have urls hard-coded in our python and pointed them at
65904         common.config.urls.
65905
65906         * Scripts/webkitpy/common/checkout/scm.py:
65907         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
65908         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
65909         * Scripts/webkitpy/common/net/statusserver.py:
65910         * Scripts/webkitpy/layout_tests/port/base.py:
65911         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
65912         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
65913         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
65914         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
65915         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
65916         * Scripts/webkitpy/tool/commands/queues.py:
65917
65918 2011-04-12  Daniel Bates  <dbates@rim.com>
65919
65920         Rubber-stamped by Eric Seidel.
65921
65922         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
65923         with Windows line endings
65924         https://bugs.webkit.org/show_bug.cgi?id=53625
65925
65926         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
65927         applied to an SCM checkout on a Windows file system and vice-versa.
65928
65929         This issue manifests itself due to custom SCM settings as well as differences in
65930         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
65931         into svn-apply/unapply to compensate for differences in line endings by converting
65932         the line endings in a patch to match the line endings in the target file (if it exists).
65933
65934         * Scripts/VCSUtils.pm:
65935           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
65936             content read from the specified file handle. Obviously, this heuristic will not work
65937             for files with mixed line endings, but I don't envision such files to be the norm. If
65938             this turns out to be an issue then we can improve the heuristic.
65939           - Added firstEOLInFile().
65940           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
65941             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
65942             endings in the diff instead of the line endings in the target file.
65943           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
65944             re-used in parseDiff().
65945         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
65946           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
65947           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
65948         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
65949         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
65950
65951 2011-04-12  Sam Weinig  <sam@webkit.org>
65952
65953         Reviewed by Adam Roben.
65954
65955         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
65956         https://bugs.webkit.org/show_bug.cgi?id=58336
65957
65958         * WebKitTestRunner/TestController.cpp:
65959         (WTR::TestController::resetStateToConsistentValues):
65960         Remove cache clearing as that is causing tests to crash on Windows 7.
65961
65962 2011-04-11  Sam Weinig  <sam@webkit.org>
65963
65964         Reviewed by Anders Carlsson.
65965
65966         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
65967         <rdar://problem/8981346>
65968         https://bugs.webkit.org/show_bug.cgi?id=54159
65969
65970         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
65971         (WTR::InjectedBundlePage::InjectedBundlePage):
65972         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
65973         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
65974         (WTR::InjectedBundlePage::decidePolicyForResponse):
65975         (WTR::InjectedBundlePage::unableToImplementPolicy):
65976         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
65977         Add short-circuited policy client which matches WebKit1.
65978
65979         * WebKitTestRunner/TestController.cpp:
65980         (WTR::TestController::resetStateToConsistentValues):
65981         Clear the cache between tests to ensure consistent results.
65982
65983 2011-04-11  George Guo  <George.Guo@nokia.com>
65984
65985         Reviewed by Eric Seidel.
65986
65987         prepare-ChangeLog support email input but -h did not show the option
65988         https://bugs.webkit.org/show_bug.cgi?id=58164
65989
65990         Add email option to -h to improve the usability
65991
65992         * Scripts/prepare-ChangeLog:
65993
65994 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
65995
65996         Reviewed by Eric Carlson.
65997
65998         Rename MediaControls to MediaControlRootElement.
65999         https://bugs.webkit.org/show_bug.cgi?id=58250
66000
66001         * Scripts/do-webcore-rename: Documented the renaming.
66002
66003 2011-04-11  Sam Weinig  <sam@webkit.org>
66004
66005         Fix Windows build.
66006
66007         * MiniBrowser/win/BrowserView.cpp:
66008         (BrowserView::create):
66009
66010 2011-04-11  Sam Weinig  <sam@webkit.org>
66011
66012         Reviewed by Anders Carlsson.
66013
66014         Move focus management out of WebKit via  the UIClient
66015         <rdar://problem/8784068>
66016         https://bugs.webkit.org/show_bug.cgi?id=58278
66017
66018         * MiniBrowser/mac/BrowserWindowController.m:
66019         (-[BrowserWindowController awakeFromNib]):
66020         * WebKitTestRunner/TestController.cpp:
66021         (WTR::TestController::createOtherPage):
66022         (WTR::TestController::initialize):
66023         Add stubs for new UIClient functions.
66024
66025 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
66026
66027         Reviewed by Eric Seidel.
66028
66029         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
66030         https://bugs.webkit.org/show_bug.cgi?id=53605
66031
66032         Add an implementation of the PlainTextController for the GTK+ DRT.
66033
66034         * DumpRenderTree/gtk/DumpRenderTree.cpp:
66035         (addControllerToWindow): Added this helper method.
66036         (webViewWindowObjectCleared): Use the new helper to add EventSender
66037         and the PlainTextController to the window object.
66038         * GNUmakefile.am: Added PlainTextController source files.
66039         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
66040         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
66041         until that functionality exists somewhere in the WebKitGTK+ stack.
66042         * DumpRenderTree/gtk/PlainTextController.h: Added.
66043
66044 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
66045
66046         Unreviewed.
66047
66048         Adding my IRC nick.
66049
66050         * Scripts/webkitpy/common/config/committers.py:
66051
66052 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
66053
66054         Reviewed by Adam Roben.
66055
66056         new-run-webkit-tests: fix crash when running under windows cmd.exe
66057         https://bugs.webkit.org/show_bug.cgi?id=58197
66058
66059         We would intermittently crash when running NRWT directly under
66060         cmd.exe on windows because we were sharing the stdin file
66061         descriptor between the python process and the http server.
66062         cmd.exe really didn't like that, and there was no reason to
66063         share the descriptor, so we now use a PIPE instead.
66064
66065         * Scripts/webkitpy/layout_tests/port/http_server.py:
66066
66067 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
66068
66069         Reviewed by Ojan Vafai.
66070
66071         new-run-webkit-tests: add unit tests for Port.diff_image()
66072         https://bugs.webkit.org/show_bug.cgi?id=58196
66073
66074         Add the unit tests for the fix in bug 58195.
66075
66076         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
66077         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
66078         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
66079
66080 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
66081
66082         Reviewed by Tony Chang.
66083
66084         new-run-webkit-tests: implement support for audio, take two
66085         https://bugs.webkit.org/show_bug.cgi?id=58195
66086
66087         Attempt to re-land the fix for bug 58101 (which was initially
66088         landed in r83330, but rolled out). This is the same patch but
66089         fixes crashes in Port.diff_image() caused by the change for
66090         empty image files being None instead of ''.
66091
66092         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
66093         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
66094         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
66095         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
66096         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
66097         * Scripts/webkitpy/layout_tests/port/base.py:
66098         * Scripts/webkitpy/layout_tests/port/chromium.py:
66099         * Scripts/webkitpy/layout_tests/port/dryrun.py:
66100         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
66101         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
66102         * Scripts/webkitpy/layout_tests/port/test.py:
66103         * Scripts/webkitpy/layout_tests/port/webkit.py:
66104
66105 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
66106
66107         Reviewed by Xan Lopez.
66108
66109         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
66110         https://bugs.webkit.org/show_bug.cgi?id=57854
66111
66112         Implement missing features in GTK's DRT.
66113
66114         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
66115         (indexRangeInTable): New helper function to get the range string
66116         for the current cell inside the parent table, either from the
66117         point of view of rows or columns.
66118         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
66119         the new helper function indexRangeInTable().
66120         (AccessibilityUIElement::columnIndexRange): Ditto.
66121
66122 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
66123
66124         Reviewed by Chris Fleizach.
66125
66126         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
66127         https://bugs.webkit.org/show_bug.cgi?id=57826
66128
66129         Implement missing feature in GTK's DRT.
66130
66131         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
66132         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
66133         relying on the analogous function from the AtkTable interface.
66134
66135 2011-04-05  Timothy Hatcher  <timothy@apple.com>
66136
66137         Fix the extract-localizable-strings script errors that started after
66138         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
66139
66140         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
66141
66142 2011-04-11  Tony Chang  <tony@chromium.org>
66143
66144         Reviewed by Eric Seidel.
66145
66146         fix crc computation on 64 bit machines
66147         https://bugs.webkit.org/show_bug.cgi?id=58243
66148
66149         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
66150
66151         * DumpRenderTree/CyclicRedundancyCheck.cpp:
66152         (makeCrcTable):
66153         (computeCrc):
66154         * DumpRenderTree/CyclicRedundancyCheck.h:
66155         * DumpRenderTree/PixelDumpSupport.cpp:
66156         (appendIntToVector):
66157         (convertChecksumToPNGComment):
66158
66159 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
66160
66161         Reviewed by Eric Seidel.
66162
66163         Require no undefined symbols during compilation.
66164
66165         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
66166         https://bugs.webkit.org/show_bug.cgi?id=54896
66167
66168         Add -Wl,--no-undefined to catch missing symbols early.
66169
66170         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
66171         * WebKitTestRunner/qt/WebKitTestRunner.pro:
66172
66173 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
66174
66175         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
66176
66177         * wx/build/settings.py:
66178
66179 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
66180
66181         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
66182
66183         * wx/build/settings.py:
66184
66185 2011-04-10  David Levin  <levin@chromium.org>
66186
66187         Reviewed by Dimitri Glazkov.
66188
66189         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
66190         https://bugs.webkit.org/show_bug.cgi?id=58201
66191
66192         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
66193         and filed bug 58202.
66194
66195 2011-04-09  David Levin  <levin@chromium.org>
66196
66197         Unreviewed, rolling out r83394.
66198         http://trac.webkit.org/changeset/83394
66199         https://bugs.webkit.org/show_bug.cgi?id=53625
66200
66201         Patch was incorrect as noted in the bug.
66202
66203         * Scripts/svn-apply:
66204
66205 2011-04-09  David Levin  <levin@chromium.org>
66206
66207         Reviewed by Adam Barth.
66208
66209         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
66210         https://bugs.webkit.org/show_bug.cgi?id=53625
66211
66212         * Scripts/svn-apply: Ensure that the portions of patches
66213         which are for vcproj/vsprops files has DOS line endings.
66214
66215 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
66216
66217         Reviewed by Tony Chang.
66218
66219         It looks like NRWT has not been stopping DRT/TestShell
66220         instances properly on windows, probably for a long time.
66221         This would go a long way to explaining why we often have
66222         processes lying around :)
66223
66224         https://bugs.webkit.org/show_bug.cgi?id=57807
66225
66226         * Scripts/webkitpy/layout_tests/port/chromium.py:
66227         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
66228
66229 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
66230
66231         Reviewed by Laszlo Gombos.
66232
66233         [Qt] Don't link against fontconfig or X11 if embedded
66234         https://bugs.webkit.org/show_bug.cgi?id=58104
66235
66236         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
66237         * QtTestBrowser/QtTestBrowser.pro: ditto
66238         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
66239         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
66240
66241 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
66242
66243         http/tests/loading/preload-append-scan.php is failing on Windows
66244         https://bugs.webkit.org/show_bug.cgi?id=58178
66245
66246         Reviewed by Brian Weinstein.
66247
66248         * DumpRenderTree/win/DumpRenderTree.cpp:
66249         (lastPathComponent):
66250         Use CFURL API to find the last path component, rather than
66251         PathFindFileName(), because the latter will include the query string.
66252
66253 2011-04-08  Jian Li  <jianli@chromium.org>
66254
66255         Unreviewed, rolling out r83327, r83330 since these patches are very
66256         likely to break chromium webkit mac10.6 builders.
66257
66258         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
66259         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
66260         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
66261         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
66262         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
66263         * Scripts/webkitpy/layout_tests/port/base.py:
66264         * Scripts/webkitpy/layout_tests/port/chromium.py:
66265         * Scripts/webkitpy/layout_tests/port/dryrun.py:
66266         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
66267         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
66268         * Scripts/webkitpy/layout_tests/port/test.py:
66269         * Scripts/webkitpy/layout_tests/port/webkit.py:
66270
66271 2011-04-08  Vincent Scheib  <scheib@chromium.org>
66272
66273         Reviewed by Eric Seidel.
66274
66275         add chromium-gpu-linux-x86_64 to the recognized list of ports
66276         https://bugs.webkit.org/show_bug.cgi?id=58099
66277
66278         Add chromium-gpu-linux-x86_64 to fix assert.
66279
66280         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
66281
66282 2011-04-08  Alpha Lam  <hclam@chromium.org>
66283
66284         Unreviewed, rolling out r83335.
66285         http://trac.webkit.org/changeset/83335
66286         https://bugs.webkit.org/show_bug.cgi?id=53556
66287
66288         GTK and QT bots are broken
66289
66290         * Scripts/build-webkit:
66291
66292 2011-04-07  Anna Cavender  <annacc@chromium.org>
66293
66294         Reviewed by Eric Carlson.
66295
66296         Setup ENABLE(TRACK) feature define
66297         https://bugs.webkit.org/show_bug.cgi?id=53556
66298
66299         * Scripts/build-webkit:
66300
66301 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
66302
66303         Reviewed by Adam Roben.
66304
66305         new-run-webkit-tests: configure a NRWT test bot for Mac SL
66306         https://bugs.webkit.org/show_bug.cgi?id=58114
66307
66308         This change removes the old new-run-webkit-tests entry and
66309         updates it for a new test-only bot.
66310
66311         * BuildSlaveSupport/build.webkit.org-config/config.json:
66312
66313 2011-04-08  Dominic Cooney  <dominicc@google.com>
66314
66315         Reviewed by Adam Roben.
66316
66317         Make layoutTestController.shadowRoot return null, not undefined,
66318         when its argument is invalid.
66319         https://bugs.webkit.org/show_bug.cgi?id=58121
66320
66321         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
66322         (LayoutTestController::shadowRoot):
66323         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66324         (WTR::LayoutTestController::shadowRoot):
66325
66326 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
66327
66328         Reviewed by Adam Roben.
66329
66330         Locate NSTD.EXE in 64-bit Windows
66331         https://bugs.webkit.org/show_bug.cgi?id=57847
66332
66333         * Scripts/old-run-webkit-tests:
66334
66335 2011-04-08  Adam Roben  <aroben@apple.com>
66336
66337         Qt build fix
66338
66339         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
66340
66341 2011-04-07  Adam Roben  <aroben@apple.com>
66342
66343         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
66344
66345         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
66346         plugin
66347
66348         Reviewed by Anders Carlsson.
66349
66350         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
66351         (pluginLogWithArguments): Moved code to format and log the message here...
66352         (pluginLog): ...from here.
66353
66354         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
66355
66356         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
66357         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
66358
66359         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
66360
66361         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
66362         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
66363         to begin.
66364         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
66365         constructor.
66366         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
66367         can be used to invoke our setWillBeDestroyed function.
66368         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
66369         anything unexpected happens).
66370         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
66371         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
66372         NPP_SetWindow was *not* called during destruction.
66373         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
66374         method, setWillBeDestroyed.
66375         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
66376         object.
66377
66378         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
66379         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
66380         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
66381         * GNUmakefile.am:
66382         Added new test.
66383
66384         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
66385         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
66386
66387 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
66388
66389         Reviewed by Martin Robinson.
66390
66391         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
66392         https://bugs.webkit.org/show_bug.cgi?id=58039
66393
66394         Implement missing functions in GTK's DRT.
66395
66396         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
66397         (AccessibilityUIElement::increment): Implemented.
66398         (AccessibilityUIElement::decrement): Implemented.
66399
66400 2011-04-08  Dominic Cooney  <dominicc@google.com>
66401
66402         Reviewed by Kent Tamura.
66403
66404         Make WK2 layoutTestController.shadowRoot return undefined, not
66405         null, when its argument is not an element.
66406         https://bugs.webkit.org/show_bug.cgi?id=58121
66407
66408         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66409         (WTR::LayoutTestController::shadowRoot):
66410
66411 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
66412
66413         Reviewed by Mihai Parparita.
66414
66415         Change reference port for Mac GPU baselines from
66416         Leopard to SnowLeopard, XP to Win7, and Linux-x86
66417         to Linux x86-64.
66418
66419         https://bugs.webkit.org/show_bug.cgi?id=58099
66420
66421         * Scripts/webkitpy/layout_tests/port/chromium.py:
66422
66423 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
66424
66425         Revert ENABLE_TRACK patch due to compile failures.
66426
66427         * Scripts/build-webkit:
66428
66429 2011-04-07  Tony Chang  <tony@chromium.org>
66430
66431         Reviewed by Eric Seidel.
66432
66433         update DRT to embed checksums in png files
66434         https://bugs.webkit.org/show_bug.cgi?id=57871
66435
66436         We insert the bytes for the comment in printPNG rather than at encode
66437         time because each platform does its own PNG encoding (either using CG
66438         or cairo).  Putting this in pringPNG avoids having to duplicate this
66439         code, although it's not as clean as doing it at encoding time.
66440
66441         We insert the comment right after the IHDR chunk of the PNG.
66442
66443         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
66444         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
66445         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
66446         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
66447         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
66448         * DumpRenderTree/PixelDumpSupport.cpp:
66449         (dumpWebViewAsPixelsAndCompareWithExpected):
66450         (convertChecksumToPNGComment): Generate the bytes to insert.
66451         (printPNG): Insert the png comment before the first IDAT section.
66452         * DumpRenderTree/PixelDumpSupport.h:
66453         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
66454         (printPNG):
66455         (dumpBitmap):
66456         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
66457         (printPNG):
66458         (dumpBitmap):
66459         * DumpRenderTree/win/DumpRenderTree.vcproj:
66460         * GNUmakefile.am:
66461
66462 2011-04-07  Jeff Miller  <jeffm@apple.com>
66463
66464         Reviewed by Adam Roben.
66465
66466         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
66467         https://bugs.webkit.org/show_bug.cgi?id=58058
66468
66469         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
66470         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
66471
66472 2011-04-07  Chang Shu  <cshu@webkit.org>
66473
66474         Reviewed by Darin Adler.
66475
66476         WebKitTestRunner needs layoutTestController.isPageBoxVisible
66477         https://bugs.webkit.org/show_bug.cgi?id=42695
66478
66479         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66480         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66481         (WTR::LayoutTestController::isPageBoxVisible):
66482         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
66483
66484 2011-04-07  Adam Roben  <aroben@apple.com>
66485
66486         Build fix
66487
66488         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
66489
66490 2011-04-07  Adam Roben  <aroben@apple.com>
66491
66492         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
66493
66494         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
66495         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
66496         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
66497         be overridden by subclasses to provide extra URLs before we call up to the base class (after
66498         which adding more URLs is no longer possible).
66499
66500         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
66501         bot results page
66502
66503         Reviewed by John Sullivan.
66504
66505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
66506         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
66507         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
66508         method is never called for MasterShellCommands.
66509         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
66510         with this method (which is).
66511
66512 2011-04-07  Adam Roben  <aroben@apple.com>
66513
66514         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
66515
66516         This matches how most of our other build steps work, so is good just for improving
66517         consistency between build steps. It should also make it possible for
66518         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
66519         trying to do this in finished() after we had called up to the base class, but that was
66520         apparently too late to add more URLs.)
66521
66522         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
66523         results page
66524
66525         Reviewed by John Sullivan.
66526
66527         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
66528         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
66529         call setText to get the right text to show up for this step. This matches how most of our
66530         other build steps work.
66531         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
66532         This is how most of our other build steps work.
66533         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
66534         function, to match the base class.
66535
66536 2011-04-07  Adam Barth  <abarth@webkit.org>
66537
66538         Reviewed by Maciej Stachowiak.
66539
66540         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
66541         https://bugs.webkit.org/show_bug.cgi?id=58022
66542
66543         Previously, we were ignoring the args variable!  This patch fixes the
66544         regression introduced in http://trac.webkit.org/changeset/82771.
66545
66546         * Scripts/webkitpy/tool/commands/download_unittest.py:
66547         * Scripts/webkitpy/tool/mocktool.py:
66548         * Scripts/webkitpy/tool/steps/checkstyle.py:
66549
66550 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
66551
66552         Reviewed by Adam Barth.
66553
66554         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
66555         https://bugs.webkit.org/show_bug.cgi?id=58017
66556
66557         * Scripts/webkitpy/common/checkout/scm.py:
66558         * Scripts/webkitpy/common/checkout/scm_unittest.py:
66559
66560 2011-04-06  Chang Shu  <cshu@webkit.org>
66561
66562         Reviewed by Darin Adler.
66563
66564         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
66565         https://bugs.webkit.org/show_bug.cgi?id=57984
66566
66567         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66568         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66569         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
66570         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
66571
66572 2011-04-06  Chris Rogers  <crogers@google.com>
66573
66574         Reviewed by Tony Chang.
66575
66576         Add web audio support to DumpRenderTree (mac port)
66577         https://bugs.webkit.org/show_bug.cgi?id=57969
66578
66579         * DumpRenderTree/LayoutTestController.cpp:
66580         (LayoutTestController::LayoutTestController):
66581         (setEncodedAudioDataCallback):
66582         (LayoutTestController::staticFunctions):
66583         * DumpRenderTree/LayoutTestController.h:
66584         (LayoutTestController::dumpAsAudio):
66585         (LayoutTestController::setDumpAsAudio):
66586         (LayoutTestController::encodedAudioData):
66587         (LayoutTestController::setEncodedAudioData):
66588         * DumpRenderTree/mac/DumpRenderTree.mm:
66589         (dumpAudio):
66590         (dump):
66591
66592 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
66593
66594         Reviewed by Kenneth Rohde Christiansen.
66595
66596         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
66597         https://bugs.webkit.org/show_bug.cgi?id=56086
66598
66599         Add the missing method.
66600
66601         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
66602         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
66603         * DumpRenderTree/qt/DumpRenderTreeQt.h:
66604         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
66605         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
66606
66607 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
66608
66609         Reviewed by David Levin.
66610
66611         Add QUOTA build flag for unified quota API
66612         https://bugs.webkit.org/show_bug.cgi?id=57918
66613
66614         * Scripts/build-webkit: Added QUOTA build flag
66615
66616 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
66617
66618         Reviewed by Tony Chang.
66619
66620         Adjust the apple webkit port's default timeout to match
66621         old-run-webkit-tests at 35 seconds.
66622
66623         https://bugs.webkit.org/show_bug.cgi?id=37738
66624
66625         * Scripts/webkitpy/layout_tests/port/mac.py:
66626
66627 2011-04-06  Scott Cameron  <sccameron@rim.com>
66628
66629         Reviewed by Eric Seidel.
66630
66631         Remove global variable $httpdPath and replace with the return value of
66632         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
66633         https://bugs.webkit.org/show_bug.cgi?id=53499
66634
66635         * Scripts/run-iexploder-tests:
66636         * Scripts/webkitperl/httpd.pm:
66637
66638 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
66639
66640         Reviewed by Darin Adler.
66641
66642         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
66643
66644         https://bugs.webkit.org/show_bug.cgi?id=27551
66645
66646         * DumpRenderTree/config.h:
66647         * WebKitAPITest/config.h:
66648         * WebKitTestRunner/config.h:
66649
66650 2011-04-06  Tony Chang  <tony@chromium.org>
66651
66652         Reviewed by Darin Adler.
66653
66654         teach run-webkit-tests to read checksums from png files
66655         https://bugs.webkit.org/show_bug.cgi?id=57993
66656
66657         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
66658           no .checksum and look for the checksum in there.
66659
66660 2011-04-06  David Dorwin  <ddorwin@chromium.org>
66661
66662         Reviewed by David Levin.
66663
66664         Enable fullscreen layout tests for Chromium
66665         https://bugs.webkit.org/show_bug.cgi?id=55726
66666
66667         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
66668
66669         * DumpRenderTree/chromium/WebPreferences.cpp:
66670         (WebPreferences::applyTo):
66671
66672 2011-04-06  Adam Roben  <aroben@apple.com>
66673
66674         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
66675
66676         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
66677
66678         Reviewed by David Kilzer.
66679
66680         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
66681         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
66682         build's results directory here...
66683         (ExtractTestResults.finished): ...from here.
66684         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
66685         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
66686         leaks" link to point to Leaks Viewer for this build.
66687         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
66688         but it seemed good to add for consistency with BuildAndTestFactory.
66689         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
66690         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
66691         that we'll get a "view leaks" link.
66692
66693 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
66694
66695         Reviewed by Eric Seidel.
66696
66697         [Gtk] plugins/set-status.html fails
66698         https://bugs.webkit.org/show_bug.cgi?id=57844
66699
66700         Allow an empty status text to be dumped.
66701
66702         * DumpRenderTree/gtk/DumpRenderTree.cpp:
66703         (webViewStatusBarTextChanged):
66704
66705 2011-04-06  Chang Shu  <cshu@webkit.org>
66706
66707         Reviewed by Darin Adler.
66708
66709         WebKitTestRunner needs layoutTestController.pageNumberForElementById
66710         https://bugs.webkit.org/show_bug.cgi?id=42329
66711
66712         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66713         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66714         (WTR::LayoutTestController::pageNumberForElementById):
66715         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
66716
66717 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
66718
66719         Reviewed by Martin Robinson.
66720
66721         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
66722         https://bugs.webkit.org/show_bug.cgi?id=57932
66723
66724         Some Layout tests have invalid URIs that do not generate valid
66725         SoupURI instances. Do not try to free those NULL SoupURIs.
66726
66727         * DumpRenderTree/gtk/DumpRenderTree.cpp:
66728         (willSendRequestCallback):
66729
66730 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
66731
66732         Reviewed by Andreas Kling.
66733
66734         ORWT shouldn't generate diff files for tests without expected files
66735         https://bugs.webkit.org/show_bug.cgi?id=57846
66736
66737         * Scripts/old-run-webkit-tests:
66738
66739 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
66740
66741         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
66742         to deps.
66743
66744         * wx/install-unix-extras:
66745
66746 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
66747
66748         Unreviewed, rolling out r82978, r82999, and r83001.
66749         http://trac.webkit.org/changeset/82978
66750         http://trac.webkit.org/changeset/82999
66751         http://trac.webkit.org/changeset/83001
66752         https://bugs.webkit.org/show_bug.cgi?id=57913
66753
66754         Does not work in Python 2.5 (Requested by abarth on #webkit).
66755
66756         * Scripts/webkitpy/common/system/executive.py:
66757         * Scripts/webkitpy/common/system/executive_unittest.py:
66758
66759 2011-04-05  Chang Shu  <cshu@webkit.org>
66760
66761         Reviewed by Darin Adler.
66762
66763         WebKitTestRunner needs layoutTestController.numberOfPages
66764         https://bugs.webkit.org/show_bug.cgi?id=42694
66765
66766         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66767         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66768         (WTR::LayoutTestController::numberOfPages):
66769         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
66770
66771 2011-04-05  Tony Chang  <tony@chromium.org>
66772
66773         Reviewed by Mihai Parparita.
66774
66775         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
66776         https://bugs.webkit.org/show_bug.cgi?id=57889
66777
66778         * Scripts/webkitpy/layout_tests/port/chromium.py:
66779         * Scripts/webkitpy/layout_tests/port/test.py:
66780         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
66781
66782 2011-04-05  Adam Barth  <abarth@webkit.org>
66783
66784         Silly with statement, from the future!
66785
66786         * Scripts/webkitpy/common/system/executive.py:
66787
66788 2011-04-05  Adam Barth  <abarth@webkit.org>
66789
66790         Reviewed by Tony Chang.
66791
66792         Don't use Exception.message because it's deprecated
66793         https://bugs.webkit.org/show_bug.cgi?id=57892
66794
66795         Suppress the warning for now.  When we move to Python 3, we might need
66796         to something more dramatic.
66797
66798         * Scripts/webkitpy/common/system/executive.py:
66799
66800 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
66801
66802         Reviewed by Ojan Vafai.
66803
66804         Add builders.js to dashboard file list
66805         https://bugs.webkit.org/show_bug.cgi?id=57899
66806
66807         Add file added by http://crrev.com/80538 to dashboard file list.
66808
66809         * TestResultServer/handlers/dashboardhandler.py:
66810
66811 2011-04-05  MORITA Hajime  <morrita@google.com>
66812
66813         Reviewed by Adam Barth.
66814
66815         webkit-patch should print git's stderr when git svn dcommit fail
66816         http://webkit.org/b/57861
66817
66818         * Scripts/webkitpy/common/checkout/scm.py:
66819
66820 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
66821
66822         Reviewed by Tony Chang.
66823
66824         Add --baseline-search-path to NRWT
66825         https://bugs.webkit.org/show_bug.cgi?id=56233
66826
66827         Add NRWT option to specify additional directories to look for baselines
66828         (will be used by hardware GPU bots which will have local per-bot
66829         expectations for some tests)
66830
66831         * Scripts/webkitpy/common/system/filesystem_mock.py:
66832         * Scripts/webkitpy/layout_tests/port/base.py:
66833         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
66834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
66835
66836 2011-04-05  Adam Roben  <aroben@apple.com>
66837
66838         Strip off /results.html from results URLs before trying to load leaks files from them
66839
66840         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
66841         files, rather than pointing to the directory that contains them. This is more convenient for
66842         people browsing build.webkit.org, but confused Leaks Viewer.
66843
66844         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
66845         list don't work
66846
66847         Reviewed by Joseph Pecoraro.
66848
66849         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
66850         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
66851
66852 2011-04-05  Carol Szabo  <carol@webkit.org>
66853
66854         Unreviewed.
66855
66856         Updated my info in committers.py
66857
66858         Scripts\webkitpy\common\config\committers.py
66859
66860 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
66861
66862         Reviewed by Laszlo Gombos.
66863
66864         [Qt] Make WebKitLibraries optional for building QtWebKit
66865         https://bugs.webkit.org/show_bug.cgi?id=57542
66866
66867         * Scripts/build-webkit:
66868
66869 2011-04-05  Chang Shu  <cshu@webkit.org>
66870
66871         Reviewed by Laszlo Gombos.
66872
66873         [Qt] MiniBrowser defaultUrl does not work
66874         https://bugs.webkit.org/show_bug.cgi?id=57021
66875
66876         Match the behavior and coding of MiniBrowser to QtTestBrowser.
66877         * MiniBrowser/qt/main.cpp:
66878         (main):
66879
66880 2011-04-05  Jade Han  <jade.han@nokia.com>
66881
66882         Reviewed by Laszlo Gombos.
66883
66884         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
66885         https://bugs.webkit.org/show_bug.cgi?id=54977
66886
66887         This change is a preparation to enable building webkit2 for Symbian.
66888         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
66889
66890         * Tools.pro:
66891
66892 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
66893
66894         Reviewed by Andreas Kling.
66895
66896         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
66897         https://bugs.webkit.org/show_bug.cgi?id=57832
66898
66899         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
66900
66901         * MiniBrowser/qt/UrlLoader.cpp:
66902         (UrlLoader::UrlLoader):
66903
66904 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
66905
66906         [Qt] Linux Release minimal build fix after r82919.
66907
66908         * MiniBrowser/qt/BrowserWindow.cpp:
66909         (BrowserWindow::loadURLListFromFile):
66910         * QtTestBrowser/launcherwindow.cpp:
66911         (LauncherWindow::loadURLListFromFile):
66912
66913 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
66914
66915         Reviewed by Andreas Kling.
66916
66917         [Qt] Make URL loader accessible from testbrowser's menus
66918         https://bugs.webkit.org/show_bug.cgi?id=57823
66919
66920         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
66921
66922         * MiniBrowser/qt/BrowserWindow.cpp:
66923         (BrowserWindow::BrowserWindow):
66924         (BrowserWindow::loadURLListFromFile):
66925         (BrowserWindow::~BrowserWindow):
66926         * MiniBrowser/qt/BrowserWindow.h:
66927         * QtTestBrowser/launcherwindow.cpp:
66928         (LauncherWindow::LauncherWindow):
66929         (LauncherWindow::~LauncherWindow):
66930         (LauncherWindow::createChrome):
66931         (LauncherWindow::loadURLListFromFile):
66932         * QtTestBrowser/launcherwindow.h:
66933
66934 2011-04-04  Sam Weinig  <sam@webkit.org>
66935
66936         Reviewed by Brian Weinstein.
66937
66938         Remove duplicate API from WKContext
66939         <rdar://problem/8727879>
66940         https://bugs.webkit.org/show_bug.cgi?id=57815
66941
66942         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
66943         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
66944         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
66945         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
66946
66947 2011-04-04  Tony Chang  <tony@chromium.org>
66948
66949         Reviewed by Ojan Vafai.
66950
66951         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
66952         https://bugs.webkit.org/show_bug.cgi?id=57783
66953
66954         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
66955         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
66956
66957 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
66958
66959         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
66960         from WebKitBuild.
66961
66962         * Scripts/webkitdirs.pm:
66963
66964 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
66965
66966         Reviewed by Gustavo Noronha Silva.
66967
66968         [GTK] WebGL support
66969         https://bugs.webkit.org/show_bug.cgi?id=31517
66970
66971         Add support to the DRT for turning on WebGL when a layout tests requests it.
66972
66973         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
66974         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
66975
66976 2011-04-04  Chang Shu  <cshu@webkit.org>
66977
66978         Reviewed by Darin Adler.
66979
66980         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
66981         https://bugs.webkit.org/show_bug.cgi?id=57572
66982
66983         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66984         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
66985         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
66986         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
66987
66988 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
66989
66990         Reviewed by Csaba Osztrogonác.
66991
66992         [Qt] DumpRenderTree breaks compilation in some uClibc environments
66993         https://bugs.webkit.org/show_bug.cgi?id=57602
66994
66995         * DumpRenderTree/qt/main.cpp:
66996         (get_backtrace):
66997
66998 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
66999
67000         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
67001
67002         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
67003         (LayoutTestController::shadowRoot):
67004
67005 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
67006
67007         Unreviewed, fix exception in rebaseline tool.
67008
67009         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
67010
67011 2011-04-02  Beth Dakin  <bdakin@apple.com>
67012
67013         Rubber-stamped by Geoff Garen.
67014
67015         For Dan!
67016         * DumpRenderTree/mac/DumpRenderTree.mm:
67017         (resetWebViewToConsistentStateBeforeTesting):
67018
67019 2011-04-02  Beth Dakin  <bdakin@apple.com>
67020
67021         Rubber-stamped by Geoff Garen.
67022
67023         Need to reset the scale, much like zoom.
67024         * DumpRenderTree/mac/DumpRenderTree.mm:
67025         (resetWebViewToConsistentStateBeforeTesting):
67026
67027 2011-04-02  Sam Weinig  <sam@webkit.org>
67028
67029         Reviewed by Beth Dakin.
67030
67031         https://bugs.webkit.org/show_bug.cgi?id=57605
67032         Frame::pageScaleFactor() should not affect getBoundingClientRect() or
67033         getClientRects()
67034         -and corresponding-
67035         <rdar://problem/9194541>
67036
67037         Add DRT support for the scaleWebView SPI.
67038         * DumpRenderTree/mac/EventSendingController.mm:
67039         (+[EventSendingController isSelectorExcludedFromWebScript:]):
67040         (+[EventSendingController webScriptNameForSelector:]):
67041         (-[EventSendingController scalePageBy:atX:andY:]):
67042         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
67043         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
67044         (WTR::EventSendingController::scalePageBy):
67045         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
67046         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
67047         (WTR::InjectedBundlePage::reset):
67048
67049 2011-04-02  Dominic Cooney  <dominicc@google.com>
67050
67051         Reviewed by Martin Robinson.
67052
67053         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
67054         https://bugs.webkit.org/show_bug.cgi?id=57551
67055
67056         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
67057         (LayoutTestController::shadowRoot):
67058
67059 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
67060
67061         Reviewed by Eric Seidel.
67062
67063         Remove AbstractStep._run_script and move script names to ports.py
67064         https://bugs.webkit.org/show_bug.cgi?id=57704
67065
67066         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
67067
67068         * Scripts/webkitpy/common/config/ports.py:
67069         * Scripts/webkitpy/tool/commands/download_unittest.py:
67070         * Scripts/webkitpy/tool/commands/roll_unittest.py:
67071         * Scripts/webkitpy/tool/commands/upload_unittest.py:
67072         * Scripts/webkitpy/tool/steps/abstractstep.py:
67073         * Scripts/webkitpy/tool/steps/checkstyle.py:
67074         * Scripts/webkitpy/tool/steps/preparechangelog.py:
67075         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
67076         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
67077
67078 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
67079
67080         Reviewed by Eric Seidel.
67081
67082         Emulate shebang on Win32
67083         https://bugs.webkit.org/show_bug.cgi?id=55927
67084
67085         Scripts on Windows work only if they are called with the explicit interpreter.
67086         Read the first line of scripts to detect the correct executable.
67087
67088         * Scripts/webkitpy/common/config/ports.py:
67089         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
67090         * Scripts/webkitpy/common/system/executive_unittest.py:
67091
67092 2011-04-01  Adam Barth  <abarth@webkit.org>
67093
67094         Reviewed by Eric Seidel.
67095
67096         apos entities shouldn't show up in ChangeLogs when using webkit-patch
67097         https://bugs.webkit.org/show_bug.cgi?id=57692
67098
67099         Previously, we were using BeautifulSoup to process XML from
67100         bugs.webkit.org, but that's incorrect.  We should be using
67101         BeautifulStoneSoup to process the XML.  We were getting the &apos;
67102         entity wrong because &apos; is an XML entity but not an HTML entity.
67103
67104         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
67105         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
67106
67107 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
67108
67109         Unreviewed, rolling out r82721.
67110         http://trac.webkit.org/changeset/82721
67111         https://bugs.webkit.org/show_bug.cgi?id=57687
67112
67113         This patch introduced assertion failures on the GTK+ bots.
67114         (Requested by mrobinson on #webkit).
67115
67116         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
67117         (LayoutTestController::shadowRoot):
67118
67119 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
67120
67121         Unreviewed buildfix.
67122
67123         [Qt][WK2] Build Webkit2 using "-2" option on Qt
67124         https://bugs.webkit.org/show_bug.cgi?id=55074
67125
67126         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
67127         (The isWK2() function removes it from @ARGV, but not from @options.)
67128
67129 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
67130
67131         Reviewed by Csaba Osztrogonác.
67132
67133         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
67134         https://bugs.webkit.org/show_bug.cgi?id=57666
67135
67136         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
67137
67138 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
67139
67140         Reviewed by Adam Barth.
67141
67142         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
67143
67144         We apparently never implemented the code to skip tests based on
67145         what was compiled into DRT. Also, change the logic used to skip
67146         platform directories to match what old-run-webkit-tests does:
67147         skip every test not in a directory in the baseline search path.
67148
67149         https://bugs.webkit.org/show_bug.cgi?id=57662
67150
67151         * Scripts/webkitpy/layout_tests/port/mac.py:
67152         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
67153         * Scripts/webkitpy/layout_tests/port/webkit.py:
67154
67155 2011-03-29  Mark Rowe  <mrowe@apple.com>
67156
67157         Reviewed by Jon Honeycutt.
67158
67159         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
67160
67161         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
67162
67163         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
67164         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
67165         * Scripts/webkitpy/layout_tests/port/mac.py:
67166         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
67167
67168 2011-04-01  Chang Shu  <cshu@webkit.org>
67169
67170         Reviewed by Csaba Osztrogonác.
67171
67172         [Qt][WK2] Build Webkit2 using "-2" option on Qt
67173         https://bugs.webkit.org/show_bug.cgi?id=55074
67174
67175         * Scripts/build-webkit:
67176
67177 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
67178
67179         Reviewed by Tony Chang.
67180
67181         new-run-webkit-tests: remove spurious port version override in webkit.py
67182         base.py provides a default implementation so this is just
67183         breaking things.
67184
67185         https://bugs.webkit.org/show_bug.cgi?id=57667
67186
67187         * Scripts/webkitpy/layout_tests/port/webkit.py:
67188         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
67189
67190 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
67191
67192         Reviewed by Adam Roben.
67193
67194         Make view results on waterfall direct link to results.html
67195         https://bugs.webkit.org/show_bug.cgi?id=57671
67196
67197         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
67198         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
67199
67200 2011-04-01  Sam Weinig  <sam@webkit.org>
67201
67202         Fix windows build.
67203
67204         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
67205         (TestWebKitAPI::TEST):
67206         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
67207         (TestWebKitAPI::flushMessages):
67208
67209 2011-04-01  Sam Weinig  <sam@webkit.org>
67210
67211         Reviewed by Adam Roben.
67212
67213         Add adoptWK to WKRetainPtr.h
67214         https://bugs.webkit.org/show_bug.cgi?id=57670
67215
67216         * TestWebKitAPI/PlatformUtilities.h:
67217         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
67218         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
67219         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
67220         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
67221         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
67222         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
67223         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
67224         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
67225         (TestWebKitAPI::createSessionStateContainingFormData):
67226         * WebKitTestRunner/StringFunctions.h:
67227         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
67228
67229 2011-04-01  Sam Weinig  <sam@webkit.org>
67230
67231         Reviewed by Adam Roben.
67232
67233         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
67234
67235         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67236         (WTR::LayoutTestController::shadowRoot):
67237         Make judicious use of adoptWK().
67238
67239 2011-04-01  Sam Weinig  <sam@webkit.org>
67240
67241         Reviewed by Timothy Hatcher.
67242
67243         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
67244
67245         * Scripts/extract-localizable-strings:
67246
67247 2011-04-01  Anders Carlsson  <andersca@apple.com>
67248
67249         Reviewed by Sam Weinig.
67250
67251         Shockwave plug-in doesn't accept mouse events
67252         https://bugs.webkit.org/show_bug.cgi?id=57653
67253         <rdar://problem/8483273>
67254
67255         Add a plug-in test.
67256
67257         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
67258         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
67259         (PluginTest::indicateTestFailure):
67260         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
67261
67262         (PluginTest::NPN_ConvertPoint):
67263         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
67264         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
67265         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
67266         Call indicateTestFailure.
67267
67268         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
67269         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
67270         (ConvertPoint::ConvertPoint):
67271         (ConvertPoint::testConvert):
67272         (ConvertPoint::NPP_New):
67273
67274 2011-04-01  Dominic Cooney  <dominicc@google.com>
67275
67276         Reviewed by Martin Robinson.
67277
67278         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
67279         https://bugs.webkit.org/show_bug.cgi?id=57551
67280
67281         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
67282         (LayoutTestController::shadowRoot):
67283
67284 2011-04-01  Sam Weinig  <sam@webkit.org>
67285
67286         Reviewed by Anders Carlsson.
67287
67288         WebKitTestRunner needs layoutTestController.shadowRoot
67289         https://bugs.webkit.org/show_bug.cgi?id=57661
67290
67291         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
67292         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67293         (WTR::LayoutTestController::shadowRoot):
67294         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
67295         Implement layoutTestController.shadowRoot for WebKit2.
67296
67297 2011-04-01  Chang Shu  <cshu@webkit.org>
67298
67299         Reviewed by Darin Adler.
67300
67301         WebKitTestRunner needs layoutTestController.setDatabaseQuota
67302         https://bugs.webkit.org/show_bug.cgi?id=57568
67303
67304         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
67305         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67306         (WTR::LayoutTestController::setDatabaseQuota):
67307         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
67308
67309 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
67310
67311         Reviewed by Tony Chang.
67312
67313         This patch completes the cleanup of
67314         rebaseline-chromium-webkit-tests to work with all of the
67315         variants of a platform (we can now rebaseline gpu- and non-gpu
67316         files at the same time).
67317
67318         When the rebaselining is complete, any lines declared as
67319         REBASELINE in the expectations file that matches a test that was
67320         actually rebaselined will be deleted, even if only one of the
67321         variants was actually rebaselined. This may cause odd problems,
67322         but is better than where we're at today.
67323
67324         This change removes the -g flag and deprecates -w. The -g flag is gone
67325         because GPU baselines are handled just like any other variant.
67326         The -w flag is deprecated because this tool now only works
67327         against the canaries, since that's the only place we have a full
67328         set of bots. It will be trivial to change this to
67329         build.webkit.org if we decide that's where we want them to be.
67330
67331         Also, this patch deletes a lot of cruft that is no longer needed
67332         in the test_expectations code and the port-specific code.
67333
67334         https://bugs.webkit.org/show_bug.cgi?id=55191
67335
67336         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
67337         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
67338         * Scripts/webkitpy/layout_tests/port/base.py:
67339         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
67340         * Scripts/webkitpy/layout_tests/port/chromium.py:
67341         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
67342         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
67343         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
67344         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
67345         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
67346         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
67347         * Scripts/webkitpy/layout_tests/port/mac.py:
67348         * Scripts/webkitpy/layout_tests/port/test.py:
67349         * Scripts/webkitpy/layout_tests/port/webkit.py:
67350         * Scripts/webkitpy/layout_tests/port/win.py:
67351         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
67352         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
67353
67354 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
67355
67356         Reviewed by Adam Barth.
67357
67358         rebaseline-chromium-webkit-tests does not work correctly with
67359         version-specific baselines. This patch updates the tool to use
67360         all of the version-specific bots on the canaries, and will now
67361         attempt to rebaseline all of the versions by default, although
67362         it will not update both GPU and CPU versions.
67363
67364         Also, it will no longer modify the test_expectations.txt file
67365         *at all*. You will have to manually delete the REBASELINE lines
67366         after running the tool and determining that it did what you
67367         wanted it to do. This should be fixed in a separate bug - see
67368         webkit bug #55191.
67369
67370         https://bugs.webkit.org/show_bug.cgi?id=55608
67371
67372         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
67373         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
67374         * Scripts/webkitpy/layout_tests/port/chromium.py:
67375         * Scripts/webkitpy/layout_tests/port/test.py:
67376         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
67377         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
67378
67379 2011-03-31  Tony Chang  <tony@chromium.org>
67380
67381         Reviewed by Ojan Vafai.
67382
67383         [chromium] update the rebaseline tool to know about pngs with checksums
67384         https://bugs.webkit.org/show_bug.cgi?id=57481
67385
67386         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
67387         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
67388
67389 2011-04-01  Adam Roben  <aroben@apple.com>
67390
67391         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
67392
67393         Previously, we were getting the revision of the first revision that triggered a build.
67394         Choosing the last revision would have been more accurate. But got_revision is what is used
67395         everywhere else on build.webkit.org, and should work even when there were no changes that
67396         triggered a build (e.g., if someone clicked the Force Build button).
67397
67398         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
67399         recent builds list
67400
67401         Reviewed by Anders Carlsson.
67402
67403         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
67404         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
67405         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
67406
67407         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
67408         (Array.prototype.first): Added this helper function to return the first element in an array
67409         that matches the given predicate, or null if no such element exists.
67410
67411 2011-03-31  Adam Roben  <aroben@apple.com>
67412
67413         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
67414
67415         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
67416
67417         Reviewed by Darin Adler.
67418
67419         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
67420         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
67421         URL on its own line.
67422
67423         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
67424         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
67425         progression, and added a new test that uses a short bug URL while I was at it.
67426
67427 2011-04-01  Adam Roben  <aroben@apple.com>
67428
67429         Mark .vcproj/.vsprops/.sln files as being Windows-only
67430
67431         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
67432
67433         Reviewed by Anders Carlsson.
67434
67435         * Scripts/webkitpy/common/config/build.py:
67436         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
67437         directories as Windows-only.
67438
67439         * Scripts/webkitpy/common/config/build_unittest.py:
67440         (ShoulBuildTest): Added test cases for the above.
67441
67442 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
67443
67444         Reviewed by Laszlo Gombos.
67445
67446         [Qt] Build MiniBrowser for Symbian
67447         https://bugs.webkit.org/show_bug.cgi?id=56319
67448
67449         Have MiniBrowser reference it's own copy of useragentlist.txt instead
67450         of copying QtTestBrowser's.
67451         Remove Tools/MiniBrowser/DerivedSources.pro
67452         This reduces complexity in the Tools scripts due to Symbian limitations.
67453
67454         * DerivedSources.pro:
67455         * MiniBrowser/DerivedSources.pro: Removed.
67456         * MiniBrowser/MiniBrowser.qrc:
67457         * MiniBrowser/qt/MiniBrowser.pro:
67458         * Scripts/webkitdirs.pm:
67459
67460 2011-03-31  Chang Shu  <cshu@webkit.org>
67461
67462         Reviewed by Darin Adler.
67463
67464         WebKitTestRunner needs layoutTestController.clearAllDatabases
67465         https://bugs.webkit.org/show_bug.cgi?id=42540
67466
67467         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
67468         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
67469         (WTR::InjectedBundle::beginTesting):
67470         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67471         (WTR::LayoutTestController::clearAllDatabases):
67472         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
67473
67474 2011-03-31  Chang Shu  <cshu@webkit.org>
67475
67476         Reviewed by Darin Adler.
67477
67478         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
67479         https://bugs.webkit.org/show_bug.cgi?id=42692
67480
67481         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
67482
67483 2011-03-31  Darin Adler  <darin@apple.com>
67484
67485         Reviewed by Sam Weinig.
67486
67487         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
67488         https://bugs.webkit.org/show_bug.cgi?id=57573
67489
67490         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
67491         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
67492         Removed fake definitions of keyDown and contextClick.
67493
67494         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
67495         (WTR::operator==): Added. So we can compare two WKPoint structs.
67496         (WTR::parseModifier): Added.
67497         (WTR::parseModifierArray): Added.
67498         (WTR::EventSendingController::EventSendingController): Initialize the
67499         new data members.
67500         (WTR::EventSendingController::mouseDown): Added. Calls
67501         WKBundlePageSimulateMouseDown.
67502         (WTR::EventSendingController::mouseUp): Added. Calls
67503         WKBundlePageSimulateMouseUp.
67504         (WTR::EventSendingController::mouseMoveTo): Added. Calls
67505         WKBundlePageSimulateMouseMotion.
67506         (WTR::EventSendingController::leapForward): Added.
67507         (WTR::EventSendingController::updateClickCount): Added. Used by the
67508         mouseDown/Up functions to create a click count.
67509
67510         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
67511         for the changes above.
67512
67513 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
67514
67515         Reviewed by Martin Robinson.
67516
67517         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
67518         https://bugs.webkit.org/show_bug.cgi?id=57362
67519
67520         Do not generate DRT output if willSendRequestReturnsNull is set.
67521
67522         * DumpRenderTree/gtk/DumpRenderTree.cpp:
67523         (willSendRequestCallback):
67524
67525 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
67526
67527         Reviewed by Martin Robinson.
67528
67529         Implement MiniBrowser for Gtk port.
67530         https://bugs.webkit.org/show_bug.cgi?id=48512
67531
67532         Initial implementation of the Gtk MiniBrowser.
67533
67534         * MiniBrowser/gtk/GNUmakefile.am: Added.
67535         * MiniBrowser/gtk/main.c: Added.
67536         (activateUriEntryCallback):
67537         (destroyCallback):
67538         (goBackCallback):
67539         (goForwardCallback):
67540         (createToolbar):
67541         (createWebView):
67542         (createWindow):
67543         (argumentToURL):
67544         (main):
67545
67546 2011-03-30  Dominic Cooney  <dominicc@google.com>
67547
67548         Reviewed by Dimitri Glazkov.
67549
67550         Adds layoutTestController.shadowRoot accessor to Mac DRT.
67551         https://bugs.webkit.org/show_bug.cgi?id=57415
67552
67553         * DumpRenderTree/LayoutTestController.cpp:
67554         (shadowRootCallback):
67555         (LayoutTestController::staticFunctions):
67556         * DumpRenderTree/LayoutTestController.h:
67557         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
67558         (LayoutTestController::shadowRoot):
67559         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
67560         (LayoutTestController::shadowRoot):
67561
67562 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
67563
67564         Reviewed by Chris Marrin.
67565
67566         Update fast/canvas tests to avoid dumping the render tree when possible
67567         https://bugs.webkit.org/show_bug.cgi?id=57493
67568
67569         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
67570           accelerated drawing and accelerated drawing for canvas
67571
67572 2011-03-30  Adam Roben  <aroben@apple.com>
67573
67574         Stop ignoring leaks in CGGradientCreateWithColorStops
67575
67576         Fixes <rdar://problem/7888547>.
67577
67578         Rubber-stamped by John Sullivan.
67579
67580         * Scripts/old-run-webkit-tests:
67581         (countAndPrintLeaks): Removed some code to ignore those leaks.
67582
67583 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
67584
67585         Reviewed by Alexey Proskuryakov.
67586
67587         Add some dynamic annotations to JavaScriptCore/wtf
67588         https://bugs.webkit.org/show_bug.cgi?id=53747
67589
67590         By using these annotations we can improve the precision of finding
67591         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
67592         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
67593
67594         These files don't add new functionality, so don't need extra tests.
67595
67596         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
67597
67598 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
67599
67600         Reviewed by Adam Roben.
67601
67602         Share most vsprops between Release and Production builds in releaseproduction.vsprops
67603         https://bugs.webkit.org/show_bug.cgi?id=57508
67604
67605         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
67606         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
67607         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
67608         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
67609         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
67610         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
67611         * DumpRenderTree/win/ImageDiffProduction.vsprops:
67612         * DumpRenderTree/win/ImageDiffRelease.vsprops:
67613         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
67614         * FindSafari/FindSafariProduction.vsprops:
67615         * FindSafari/FindSafariRelease.vsprops:
67616         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
67617         * FindSafari/FindSafariReleasePGO.vsprops:
67618         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
67619         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
67620         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
67621         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
67622         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
67623         * WebKitAPITest/WebKitAPITestProduction.vsprops:
67624         * WebKitAPITest/WebKitAPITestRelease.vsprops:
67625         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
67626         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
67627         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
67628         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
67629         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
67630         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
67631         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
67632         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
67633         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
67634         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
67635         * WinLauncher/WinLauncherProduction.vsprops:
67636         * WinLauncher/WinLauncherRelease.vsprops:
67637         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
67638         * record-memory-win/record-memory-winProduction.vsprops:
67639         * record-memory-win/record-memory-winRelease.vsprops:
67640         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
67641
67642 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
67643
67644         Reviewed by Adam Roben.
67645
67646         Update Windows production build logic for new production configurations
67647         https://bugs.webkit.org/show_bug.cgi?id=57494
67648
67649         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
67650         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
67651         * DumpRenderTree/win/ImageDiffProduction.vsprops:
67652         * FindSafari/FindSafariProduction.vsprops:
67653         * FindSafari/FindSafariReleasePGO.vsprops:
67654         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
67655         * WebKitAPITest/WebKitAPITestProduction.vsprops:
67656         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
67657         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
67658         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
67659         * WinLauncher/WinLauncherProduction.vsprops:
67660         * record-memory-win/record-memory-winProduction.vsprops:
67661
67662 2011-03-30  Robert Hogan  <robert@webkit.org>
67663
67664         Reviewed by Antonio Gomes.
67665
67666         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
67667         Unskip http/tests/navigation/go-back-to-error-page.html
67668
67669         Also add the location of DumpRenderTreeSupportQt.h
67670         to DRT's include paths.
67671
67672         https://bugs.webkit.org/show_bug.cgi?id=52614
67673
67674         * DumpRenderTree/qt/DumpRenderTree.pro:
67675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
67676         * DumpRenderTree/qt/DumpRenderTreeQt.h:
67677         * DumpRenderTree/qt/GCControllerQt.cpp:
67678         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
67679         (LayoutTestController::queueLoadHTMLString):
67680         * DumpRenderTree/qt/LayoutTestControllerQt.h:
67681         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
67682         * DumpRenderTree/qt/TextInputControllerQt.cpp:
67683         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
67684         (LoadAlternateHTMLStringItem::invoke):
67685         * DumpRenderTree/qt/WorkQueueItemQt.h:
67686         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
67687         * QtTestBrowser/QtTestBrowser.pro:
67688         * QtTestBrowser/launcherwindow.h:
67689
67690 2011-03-30  Adam Barth  <abarth@webkit.org>
67691
67692         Reviewed by Adam Roben.
67693
67694         SheriffBot rollouts take too long
67695         https://bugs.webkit.org/show_bug.cgi?id=57498
67696
67697         We used to build before landing rollouts via the commit-queue to
67698         prevent further breakage, but now that our individual commit-queue
67699         machines are slower, building takes too long.  I can't remember the
67700         last time a rollout broke compile.  It seems like just landing the
67701         patch is the better trade-off.
67702
67703         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
67704         * Scripts/webkitpy/tool/commands/queues_unittest.py:
67705
67706 2011-03-30  Adam Barth  <abarth@webkit.org>
67707
67708         Remove platform/chromium-mac-snowleopard
67709         https://bugs.webkit.org/show_bug.cgi?id=57486
67710
67711         This directory no longer exists, so we can remove it from the fallback
67712         chain.
67713
67714         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
67715
67716 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
67717
67718         Reviewed by Adam Roben.
67719
67720         Rename Windows configuration Release_LTCG to Production for clarity
67721         https://bugs.webkit.org/show_bug.cgi?id=57465
67722
67723         * DumpRenderTree/DumpRenderTree.sln:
67724         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
67725         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
67726         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
67727         * DumpRenderTree/win/DumpRenderTree.vcproj:
67728         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
67729         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
67730         * DumpRenderTree/win/ImageDiff.vcproj:
67731         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
67732         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
67733         * FindSafari/FindSafari.vcproj:
67734         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
67735         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
67736         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
67737         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
67738         * MiniBrowser/MiniBrowser.vcproj:
67739         * Scripts/webkitdirs.pm:
67740         * TestWebKitAPI/win/TestWebKitAPI.sln:
67741         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
67742         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
67743         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
67744         * WebKitAPITest/WebKitAPITest.vcproj:
67745         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
67746         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
67747         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
67748         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
67749         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
67750         * WebKitTestRunner/WebKitTestRunner.sln:
67751         * WebKitTestRunner/win/InjectedBundle.vcproj:
67752         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
67753         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
67754         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
67755         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
67756         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
67757         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
67758         * WinLauncher/WinLauncher.vcproj:
67759         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
67760         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
67761         * record-memory-win/record-memory-win.vcproj:
67762         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
67763         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
67764
67765 2011-03-30  MORITA Hajime  <morrita@google.com>
67766
67767         Reviewed by Dimitri Glazkov.
67768
67769         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
67770         https://bugs.webkit.org/show_bug.cgi?id=56573
67771
67772         Added LayoutTestController.shadowRoot() to Chromium DRT.
67773
67774         * DumpRenderTree/chromium/LayoutTestController.cpp:
67775         (LayoutTestController::LayoutTestController):
67776         (LayoutTestController::shadowRoot):
67777         * DumpRenderTree/chromium/LayoutTestController.h:
67778
67779 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
67780
67781         Reviewed by Kent Tamura.
67782
67783         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
67784         https://bugs.webkit.org/show_bug.cgi?id=57430
67785
67786         * DumpRenderTree/chromium/LayoutTestController.cpp:
67787         (LayoutTestController::LayoutTestController):
67788         (LayoutTestController::setPluginsEnabled):
67789         * DumpRenderTree/chromium/LayoutTestController.h:
67790
67791 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
67792
67793         Reviewed by Adam Barth.
67794
67795         make webkit-patch upload respect -d
67796         https://bugs.webkit.org/show_bug.cgi?id=57425
67797
67798         * Scripts/webkitpy/common/checkout/scm.py:
67799         * Scripts/webkitpy/tool/steps/commit.py:
67800
67801 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
67802
67803         Reviewed by Adam Barth.
67804
67805         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
67806         https://bugs.webkit.org/show_bug.cgi?id=57429
67807
67808         * Scripts/webkitpy/common/checkout/scm.py:
67809
67810 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
67811
67812         Unreviewed, rolling out r82383.
67813         http://trac.webkit.org/changeset/82383
67814         https://bugs.webkit.org/show_bug.cgi?id=57417
67815
67816         "nrwt isn't shutting down cleanly" (Requested by dpranke on
67817         #webkit).
67818
67819         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
67820         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
67821         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
67822
67823 2011-03-29  Kent Tamura  <tkent@chromium.org>
67824
67825         Reviewed by Dimitri Glazkov.
67826
67827         Make validation message bubble testable
67828         https://bugs.webkit.org/show_bug.cgi?id=57290
67829
67830         * DumpRenderTree/mac/DumpRenderTree.mm:
67831         (createWebViewAndOffscreenWindow): Change a setting so that validation
67832           bubbles isn't hidden automatically.
67833
67834 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
67835
67836         Reviewed by Ojan Vafai.
67837
67838         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
67839
67840         It's a bit unclear whether multiple threads or multiple
67841         processes will be a better model on windows. This change will
67842         test threads for now while we're still working out the bugs in
67843         multiple-processes.
67844
67845         https://bugs.webkit.org/show_bug.cgi?id=57410
67846
67847         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
67848         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
67849         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
67850
67851 2011-03-29  David Levin  <levin@chromium.org>
67852
67853         Reviewed by Shinichiro Hamaji.
67854
67855         check-webkit-style confused by two ChangeLog entries in a row from same user
67856         https://bugs.webkit.org/show_bug.cgi?id=57250
67857
67858         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
67859         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
67860         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
67861           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
67862           checking more than that would be very messey.
67863         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
67864         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
67865
67866 2011-03-29  Kent Tamura  <tkent@chromium.org>
67867
67868         Reviewed by Dimitri Glazkov.
67869
67870         [Mac] Enable interactive-validation tests on Mac DRT
67871         https://bugs.webkit.org/show_bug.cgi?id=57308
67872
67873         * DumpRenderTree/mac/DumpRenderTree.mm:
67874         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
67875
67876 2011-03-29  Chang Shu  <cshu@webkit.org>
67877
67878         Reviewed by Kenneth Rohde Christiansen.
67879
67880         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
67881         https://bugs.webkit.org/show_bug.cgi?id=42692
67882
67883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
67884         (WTR::InjectedBundle::beginTesting):
67885         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67886         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
67887         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
67888
67889 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
67890
67891         Reviewed by Xan Lopez.
67892
67893         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
67894         https://bugs.webkit.org/show_bug.cgi?id=57067
67895
67896         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
67897         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
67898         update DRT and pixel results as hundreds of results will need to be updated.
67899
67900         * DumpRenderTree/gtk/DumpRenderTree.cpp:
67901         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
67902         by overriding the theme RC/CSS files.
67903
67904 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
67905
67906         Reviewed by Adam Roben.
67907
67908         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
67909         https://bugs.webkit.org/show_bug.cgi?id=57394
67910
67911         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
67912         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
67913         the IDE. To avoid this, add a separate vsprops file for each project configuration that
67914         contains the required inherited property sheets.
67915
67916         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
67917         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
67918         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
67919         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
67920         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
67921         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
67922         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
67923         * DumpRenderTree/win/DumpRenderTree.vcproj:
67924         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
67925         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
67926         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
67927         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
67928         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
67929         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
67930         * DumpRenderTree/win/ImageDiff.vcproj:
67931         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
67932         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
67933         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
67934         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
67935         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
67936         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
67937         * FindSafari/FindSafari.vcproj:
67938         * FindSafari/FindSafariDebug.vsprops: Added.
67939         * FindSafari/FindSafariDebugAll.vsprops: Added.
67940         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
67941         * FindSafari/FindSafariRelease.vsprops: Added.
67942         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
67943         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
67944         * FindSafari/FindSafariReleasePGO.vsprops: Added.
67945         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
67946         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
67947         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
67948         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
67949         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
67950         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
67951         * MiniBrowser/MiniBrowser.vcproj:
67952         * WebKitAPITest/WebKitAPITest.vcproj:
67953         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
67954         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
67955         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
67956         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
67957         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
67958         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
67959         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
67960         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
67961         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
67962         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
67963         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
67964         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
67965         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
67966         * WebKitTestRunner/win/InjectedBundle.vcproj:
67967         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
67968         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
67969         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
67970         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
67971         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
67972         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
67973         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
67974         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
67975         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
67976         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
67977         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
67978         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
67979         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
67980         * WinLauncher/WinLauncher.vcproj:
67981         * WinLauncher/WinLauncherDebug.vsprops: Added.
67982         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
67983         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
67984         * WinLauncher/WinLauncherRelease.vsprops: Added.
67985         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
67986         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
67987         * record-memory-win/record-memory-win.vcproj:
67988         * record-memory-win/record-memory-winDebug.vsprops: Added.
67989         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
67990         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
67991         * record-memory-win/record-memory-winRelease.vsprops: Added.
67992         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
67993         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
67994
67995 2011-03-29  Adam Barth  <abarth@webkit.org>
67996
67997         Reviewed by Darin Adler.
67998
67999         test_runner2.py can crash due to undefined variable
68000         https://bugs.webkit.org/show_bug.cgi?id=57356
68001
68002         Replace reference to undefined variable with a variable that's actually
68003         defined.  AFAICT, there's no way to test this code.
68004
68005         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
68006
68007 2011-03-29  Tony Chang  <tony@chromium.org>
68008
68009         Reviewed by Eric Seidel.
68010
68011         cleanup rebaseline-chromium-webkit-tests
68012         https://bugs.webkit.org/show_bug.cgi?id=57375
68013
68014         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
68015             - Split _extract_and_add_new_baselines into 3 functions
68016             - Reduce the amount of line wrapping (the file already has lines
68017               over 80 col, so may as well try to make the file consistent)
68018             - Remove unnecessary ()s
68019
68020 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
68021
68022         Reviewed by Adam Roben.
68023
68024         Make WinCairo a core builder.
68025         https://bugs.webkit.org/show_bug.cgi?id=57373
68026
68027         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
68028         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
68029
68030 2011-03-29  Timothy Hatcher  <timothy@apple.com>
68031
68032         Update update-webkit-localizable-strings to understand that WebKit and
68033         WebKit2 strings go in WebCore.
68034
68035         Also make extract-localizable-strings optionally use an exclude file. No individual
68036         warnings are produced about unlocalized strings when there is no exclude file. This
68037         is needed for WebCore, since there are too many bare strings.
68038
68039         https://webkit.org/b/57354
68040
68041         Reviewed by Sam Weinig.
68042
68043         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
68044         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
68045
68046 2011-03-29  Darin Adler  <darin@apple.com>
68047
68048         Reviewed by Adam Roben.
68049
68050         WebKit2 bundle page needs to offer generated file hooks
68051         https://bugs.webkit.org/show_bug.cgi?id=57279
68052
68053         (Land missing part of the original patch after r82289.)
68054
68055         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
68056         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
68057
68058 2011-03-29  Tony Chang  <tony@chromium.org>
68059
68060         Reviewed by Ojan Vafai.
68061
68062         [chromium] NRWT should be able to read checksums from png comments
68063         https://bugs.webkit.org/show_bug.cgi?id=57280
68064
68065         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
68066             from a file.
68067         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
68068         * Scripts/webkitpy/common/system/filesystem_mock.py:
68069         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
68070             if the -checksum.txt file doesn't exist, try looking in the png.
68071         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
68072         * Scripts/webkitpy/layout_tests/port/test.py:
68073         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
68074             2k for a png comment with the checksum
68075         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
68076
68077 2011-03-29  Philippe Normand  <pnormand@igalia.com>
68078
68079         Rubber-stamped by Gustavo Noronha Silva.
68080
68081         [GTK] http/tests/uri/username-with-no-hostname.html fails
68082         https://bugs.webkit.org/show_bug.cgi?id=57325
68083
68084         * DumpRenderTree/gtk/DumpRenderTree.cpp:
68085         (willSendRequestCallback): URI host value check done case-insensitively.
68086
68087 2011-03-29  Philippe Normand  <pnormand@igalia.com>
68088
68089         Reviewed by Martin Robinson.
68090
68091         [GTK] http/tests/uri/username-with-no-hostname.html fails
68092         https://bugs.webkit.org/show_bug.cgi?id=57325
68093
68094         * DumpRenderTree/gtk/DumpRenderTree.cpp:
68095         (willSendRequestCallback): Check URI before submitting the request
68096         to WebCore.
68097
68098 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
68099
68100         Reviewed by Ojan Vafai.
68101
68102         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
68103         https://bugs.webkit.org/show_bug.cgi?id=57303
68104
68105         * DumpRenderTree/chromium/EventSender.cpp:
68106         (EventSender::doDragDrop):
68107         (EventSender::beginDragWithFiles):
68108
68109 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
68110
68111         Reviewed by Andreas Kling.
68112
68113         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
68114         https://bugs.webkit.org/show_bug.cgi?id=57314
68115
68116         Provide possibility to print loaded urls to the standard output.
68117
68118         * MiniBrowser/qt/BrowserWindow.cpp:
68119         (BrowserWindow::BrowserWindow):
68120         (BrowserWindow::printURL):
68121         * MiniBrowser/qt/BrowserWindow.h:
68122         * MiniBrowser/qt/MiniBrowserApplication.cpp:
68123         (MiniBrowserApplication::handleUserOptions):
68124         * MiniBrowser/qt/MiniBrowserApplication.h:
68125         (WindowOptions::WindowOptions):
68126         * QtTestBrowser/launcherwindow.cpp:
68127         (LauncherWindow::initializeView):
68128         (LauncherWindow::printURL):
68129         (LauncherWindow::cloneWindow):
68130         * QtTestBrowser/launcherwindow.h:
68131         (WindowOptions::WindowOptions):
68132         * QtTestBrowser/main.cpp:
68133         (LauncherApplication::handleUserOptions):
68134
68135 2011-03-29  Gabor Loki  <loki@webkit.org>
68136
68137         Rubber-stamped by Csaba Osztrogonác.
68138
68139         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
68140         https://bugs.webkit.org/show_bug.cgi?id=56918
68141
68142         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
68143
68144 2011-03-28  Gabor Loki  <loki@webkit.org>
68145
68146         Reviewed by Csaba Osztrogonác.
68147
68148         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
68149         https://bugs.webkit.org/show_bug.cgi?id=56918
68150
68151         * Scripts/build-jsc:
68152         * Scripts/webkitdirs.pm:
68153
68154 2011-03-28  Andrew Foster  <andrewf@chromium.org>
68155
68156         Reviewed by Ojan Vafai.
68157
68158         webkit-patch should be more intelligent about whether a bug applies to a patch
68159         Create a new function, parse_bug_id_from_changelog() which determines
68160         that a bug is related to a patch by parsing the output generated from
68161         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
68162         the description of a patch.
68163         https://bugs.webkit.org/show_bug.cgi?id=56989
68164
68165         * Scripts/webkitpy/common/checkout/api.py:
68166         * Scripts/webkitpy/common/checkout/changelog.py:
68167         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
68168         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
68169         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
68170         * Scripts/webkitpy/style/checkers/changelog.py:
68171         * Scripts/webkitpy/tool/commands/upload.py:
68172
68173 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
68174
68175         Revert accidentally commited change.
68176
68177         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
68178         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
68179
68180 2011-03-28  Tony Chang  <tony@chromium.org>
68181
68182         Reviewed by Adam Barth.
68183
68184         [chromium] have DRT write the png checksum into a png comment
68185         https://bugs.webkit.org/show_bug.cgi?id=57255
68186
68187         * DumpRenderTree/chromium/TestShell.cpp:
68188         (TestShell::dumpImage):
68189
68190 2011-03-28  Adele Peterson  <adele@apple.com>
68191
68192         Removing Qt stub, since it doesn't use the same header as the others.
68193
68194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
68195
68196 2011-03-28  Adele Peterson  <adele@apple.com>
68197
68198         Added a few more stubs.
68199
68200         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
68201         (LayoutTestController::hasGrammarMarker):
68202         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
68203         (LayoutTestController::hasGrammarMarker):
68204         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
68205         (LayoutTestController::hasGrammarMarker):
68206
68207 2011-03-28  Adele Peterson  <adele@apple.com>
68208
68209         Build fix.
68210
68211         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
68212         (LayoutTestController::hasGrammarMarker):
68213
68214 2011-03-28  Adele Peterson  <adele@apple.com>
68215
68216         Reviewed by Eric Seidel.
68217
68218         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
68219         https://bugs.webkit.org/show_bug.cgi?id=57173
68220
68221         * DumpRenderTree/LayoutTestController.cpp:
68222         (hasGrammarMarkerCallback): Added.
68223         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
68224         * DumpRenderTree/LayoutTestController.h:
68225         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
68226         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
68227
68228 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
68229
68230         Reviewed by Benjamin Poulain.
68231
68232         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
68233         https://bugs.webkit.org/show_bug.cgi?id=57087
68234
68235         Trivial typo fix after r82082.
68236
68237         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
68238         (WTR::activateFonts):
68239
68240 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
68241
68242         Reviewed by Andreas Kling.
68243
68244         Add myself to the committers list.
68245
68246         * Scripts/webkitpy/common/config/committers.py:
68247
68248 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
68249
68250         Reviewed by Sam Weinig.
68251
68252         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
68253         to link against WebKit.framework for now.
68254
68255         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
68256
68257 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
68258
68259         Reviewed by Andreas Kling.
68260
68261         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
68262         https://bugs.webkit.org/show_bug.cgi?id=57087
68263
68264         Disable QT_ASCII_CAST_WARNINGS for applications.
68265
68266         * DumpRenderTree/qt/DumpRenderTree.pro:
68267         * DumpRenderTree/qt/ImageDiff.pro:
68268         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
68269         * MiniBrowser/qt/MiniBrowser.pro:
68270         * QtTestBrowser/QtTestBrowser.pro:
68271         * WebKitTestRunner/qt/WebKitTestRunner.pro:
68272
68273 2011-03-28  Andreas Kling  <kling@webkit.org>
68274
68275         Reviewed by Kenneth Rohde Christiansen.
68276
68277         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
68278         https://bugs.webkit.org/show_bug.cgi?id=57224
68279
68280         * QtTestBrowser/mainwindow.cpp:
68281         (MainWindow::buildUI):
68282         (MainWindow::onTitleChanged):
68283         * QtTestBrowser/mainwindow.h:
68284
68285 2011-03-27  Jer Noble  <jer.noble@apple.com>
68286
68287         Reviewed by Maciej Stachowiak.
68288
68289         Full Screen: disable keyboard access by default
68290         https://bugs.webkit.org/show_bug.cgi?id=56684
68291
68292         Accept the withKeyboard parameter to supportsFullScreenForElement.
68293
68294         * DumpRenderTree/mac/UIDelegate.mm:
68295         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
68296
68297 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
68298
68299         Reviewed by David Levin.
68300
68301         check-webkit-style should check ChangeLog for a valid bug number
68302         https://bugs.webkit.org/show_bug.cgi?id=57184
68303
68304         * Scripts/webkitpy/style/checker.py:
68305         * Scripts/webkitpy/style/checker_unittest.py:
68306         * Scripts/webkitpy/style/checkers/changelog.py: Added.
68307         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
68308
68309 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
68310
68311         Reviewed by Andreas Kling.
68312
68313         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
68314         https://bugs.webkit.org/show_bug.cgi?id=57087
68315
68316         Use explicit conversion for string to avoid depending on the default codec
68317         installed by the user code.
68318
68319         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
68320         (WTR::activateFonts):
68321
68322 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
68323
68324         Revert inadvertantly committed changes.
68325
68326         * Scripts/old-run-webkit-tests:
68327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
68328
68329 2011-03-26  Andreas Kling  <kling@webkit.org>
68330
68331         Reviewed by Kenneth Rohde Christiansen.
68332
68333         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
68334         https://bugs.webkit.org/show_bug.cgi?id=57162
68335
68336         * QtTestBrowser/QtTestBrowser.qrc:
68337         * QtTestBrowser/favicon.png: Added.
68338         * QtTestBrowser/locationedit.cpp:
68339         (defaultPageIcon):
68340         (LocationEdit::LocationEdit):
68341         (LocationEdit::setPageIcon):
68342         (LocationEdit::resizeEvent):
68343         (LocationEdit::updateInternalGeometry):
68344         * QtTestBrowser/locationedit.h:
68345         * QtTestBrowser/mainwindow.cpp:
68346         (MainWindow::buildUI):
68347         (MainWindow::onIconChanged):
68348         (MainWindow::onLoadStarted):
68349         * QtTestBrowser/mainwindow.h:
68350
68351 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
68352
68353         Reviewed by Xan Lopez.
68354
68355         [GTK] Force DumpRenderTree to use 96 DPI
68356         https://bugs.webkit.org/show_bug.cgi?id=56866
68357
68358         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
68359         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
68360
68361         * DumpRenderTree/gtk/DumpRenderTree.cpp:
68362         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
68363         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
68364         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
68365
68366 2011-03-25  Andy Estes  <aestes@apple.com>
68367
68368         Reviewed by Adele Peterson.
68369
68370         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
68371         https://bugs.webkit.org/show_bug.cgi?id=49016
68372
68373         TestNetscapePlugIn needs to register support for an image MIME type so
68374         we can test that the embed tag prefers plug-ins to render image MIME
68375         types.
68376
68377         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
68378         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
68379         (NP_GetMIMEDescription): Ditto.
68380         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
68381
68382 2011-03-25  Jessie Berlin  <jberlin@apple.com>
68383
68384         Reviewed by Sam Weinig.
68385
68386         WebKit2: Need to be able to set and get the Cookie Storage Policy.
68387         https://bugs.webkit.org/show_bug.cgi?id=50780
68388
68389         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
68390
68391         The test is named "CookieManager" so that we can eventually exercise more of the
68392         CookieManager functionality in the test.
68393
68394         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
68395         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
68396         Assert that the policy returned is equal to the policy set in
68397         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
68398         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
68399         Set the policy to something different than the user's policy and get the policy again.
68400         (TestWebKitAPI::didFinishLoadForFrame):
68401         Get the user's policy so that it can be restored at the end of the test.
68402         (TestWebKitAPI::TEST):
68403         Load about:blank so that the Web Process gets instatiated (needed to get the
68404         CookieManager).
68405
68406         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
68407         Add CookieManager.cpp.
68408
68409 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
68410
68411         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
68412
68413         * wx/build/settings.py:
68414
68415 2011-03-24  Ilya Sherman  <isherman@chromium.org>
68416
68417         Reviewed by Adam Roben.
68418
68419         Implement layoutTestController.setAutoFilled in DRT on Windows
68420         https://bugs.webkit.org/show_bug.cgi?id=56828
68421
68422         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
68423         (LayoutTestController::setAutofilled): Implemented.
68424
68425 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
68426
68427         Unreviewed build correction.
68428
68429         Correct vsprops file for Debug variant of the CFLite build.
68430         Disable a CFNETWORK-specific test when building for CFLite.
68431
68432         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
68433         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
68434
68435 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
68436
68437         Reviewed by Adam Barth.
68438
68439         fix regressions introduced in 81908 - there were a couple of
68440         code paths that only fired under python 2.5 that I missed.
68441
68442         Also change a couple of 'python' references to sys.executable
68443         in order to handle runing test-webkitpy with a binary other than
68444         something called 'python'.
68445
68446         https://bugs.webkit.org/show_bug.cgi?id=57063
68447
68448         * Scripts/webkitpy/layout_tests/port/mac.py:
68449         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
68450         * Scripts/webkitpy/test/cat.py:
68451         * Scripts/webkitpy/test/echo.py:
68452
68453 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
68454
68455         Unreviewed build correction.
68456
68457         Add a stub implementation of the TestInvocation dumping logic.
68458         Update project files to reflect new file.
68459
68460         * WebKitTestRunner/cairo: Added.
68461         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
68462         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
68463         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
68464
68465 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
68466
68467         Reviewed by Tony Chang.
68468
68469         new-run-webkit-tests: clean up worker model defaults. This
68470         changes the default behavior to 'threads' instead of
68471         'old-threads', and clarifies that chromium-win-* and
68472         chromium-mac-leopard are exceptions.
68473
68474         https://bugs.webkit.org/show_bug.cgi?id=56971
68475
68476         * Scripts/webkitpy/layout_tests/port/base.py:
68477         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
68478         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
68479         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
68480         * Scripts/webkitpy/layout_tests/port/test.py:
68481         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
68482
68483 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
68484
68485         Reviewed by Darin Adler.
68486
68487         Media Stream API: fix the order of the options in build-webkit.
68488         https://bugs.webkit.org/show_bug.cgi?id=56949
68489
68490         Fix the order of the options in build-webkit.
68491
68492         * Scripts/build-webkit:
68493
68494 2011-03-23  Adam Klein  <adamk@chromium.org>
68495
68496         Reviewed by Mihai Parparita.
68497
68498         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
68499         https://bugs.webkit.org/show_bug.cgi?id=56884
68500
68501         This option will be utilized by Chromium's ui_tests to allow
68502         referencing js-test-resources from a layout test over HTTP.
68503
68504         * Scripts/new-run-webkit-httpd:
68505         Added --layout_tests_dir option.
68506         * Scripts/webkitpy/layout_tests/port/http_server.py:
68507         Plumbed through as layout_tests_dir param.
68508
68509 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
68510
68511         Reviewed by Mihai Parparita.
68512
68513         new-run-webkit-tests: run tests in ascending alphabetical order per
68514         dir. This is a second attempt at the fix; the first attempt, in
68515         r81597, broke the behavior on the old-inline and old-threads
68516         worker models.
68517
68518         https://bugs.webkit.org/show_bug.cgi?id=56760
68519
68520         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
68521         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
68522         * Scripts/webkitpy/layout_tests/port/test.py:
68523         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
68524
68525 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
68526
68527         Reviewed by Martin Robinson.
68528
68529         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
68530         https://bugs.webkit.org/show_bug.cgi?id=56953
68531
68532         Print the string for the detail of 'property-change' signal.
68533
68534         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
68535         (axObjectEventListener): Print the detail string.
68536
68537 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
68538
68539         Reviewed by Pavel Feldman.
68540
68541         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
68542         https://bugs.webkit.org/show_bug.cgi?id=56843
68543
68544         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
68545         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
68546
68547 2011-03-22  Eric Seidel  <eric@webkit.org>
68548
68549         Reviewed by Adam Barth.
68550
68551         Teach update-webkit about gyp
68552         https://bugs.webkit.org/show_bug.cgi?id=56881
68553
68554         This makes it possible for someone who builds from Xcode
68555         to just run update-webkit --gyp and have the project files
68556         generated after update automatically.
68557
68558         I also added a stand-alone "generate-project-files" script
68559         wrapping Source/gyp/configure.  This makes running gyp simpler
68560         since most people will not have gyp or Source/gyp in their path.
68561
68562         * Scripts/build-webkit:
68563         * Scripts/generate-project-files: Added.
68564         * Scripts/update-webkit:
68565
68566 2011-03-22  Anton D'Auria  <adauria@apple.com>
68567
68568         Reviewed by Alexey Proskuryakov.
68569
68570         Add +[WebApplicationCache getOriginsWithCache]
68571         https://bugs.webkit.org/show_bug.cgi?id=56722
68572
68573         * DumpRenderTree/LayoutTestController.cpp:
68574         (originsWithApplicationCacheCallback):
68575         (LayoutTestController::staticFunctions):
68576         * DumpRenderTree/LayoutTestController.h:
68577         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
68578         (LayoutTestController::originsWithApplicationCache):
68579         * DumpRenderTree/chromium/LayoutTestController.h:
68580         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
68581         (LayoutTestController::originsWithApplicationCache):
68582         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
68583         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
68584         (LayoutTestController::originsWithApplicationCache):
68585         (LayoutTestController::originsWithLocalStorage):
68586         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
68587         (LayoutTestController::originsWithApplicationCache):
68588         * DumpRenderTree/qt/LayoutTestControllerQt.h:
68589         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
68590         (LayoutTestController::originsWithApplicationCache):
68591         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
68592         (LayoutTestController::originsWithApplicationCache):
68593
68594 2011-03-22  Eric Seidel  <eric@webkit.org>
68595
68596         Reviewed by Adam Barth.
68597
68598         Add support to build-webkit for building with gyp-generated project files
68599         https://bugs.webkit.org/show_bug.cgi?id=56877
68600
68601         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
68602         Eventually we'll want to support gyp-generated projects in a more general manner.
68603
68604         * Scripts/build-webkit:
68605
68606 2011-03-22  David Kilzer  <ddkilzer@apple.com>
68607
68608         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
68609
68610         Reviewed by Joseph Pecoraro.
68611
68612         * Scripts/build-webkit: Updated usage statement to include
68613         --dsym.
68614         * Scripts/webkitdirs.pm: Added $generateDsym variable.
68615         (generateDsym): Added. Call determineGenerateDsym() and
68616         return $generateDsym.
68617         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
68618         $generateDsym.
68619         (argumentsForXcode): Added.  Returns additional arguments for
68620         xcodebuild based on command-line switches.
68621         (XcodeOptions): Updated to include argumentsForXcode() in the
68622         array returned.
68623
68624 2011-03-22  Adam Roben  <aroben@apple.com>
68625
68626         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
68627
68628         These bots are consistently green again.
68629
68630         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
68631         core builders
68632
68633         Rubber-stamped by Antti Koivisto.
68634
68635         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
68636         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
68637
68638         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
68639         (BuildBotTest.test_builder_name_regexps): Updated expectations.
68640
68641 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
68642
68643         Unreviewed, rolling out r81597.
68644         http://trac.webkit.org/changeset/81597
68645         https://bugs.webkit.org/show_bug.cgi?id=56801
68646
68647         Change results in lots of unexpected flaky on the dashboard.
68648         (Requested by pfeldman on #webkit).
68649
68650         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
68651         * Scripts/webkitpy/layout_tests/port/test.py:
68652         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
68653
68654 2011-03-21  Sam Weinig  <sam@webkit.org>
68655
68656         Fix failing tests on the WebKit2 bots.
68657
68658         * WebKitTestRunner/TestController.cpp:
68659         (WTR::TestController::resetStateToConsistentValues):
68660
68661 2011-03-21  Daniel Sievers  <sievers@google.com>
68662
68663         Reviewed by Simon Fraser.
68664
68665         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
68666         https://bugs.webkit.org/show_bug.cgi?id=56139
68667
68668         * DumpRenderTree/chromium/DumpRenderTree.cpp:
68669         (main):
68670         * DumpRenderTree/chromium/LayoutTestController.cpp:
68671         (LayoutTestController::LayoutTestController):
68672         (LayoutTestController::layerTreeAsText):
68673         * DumpRenderTree/chromium/LayoutTestController.h:
68674         (LayoutTestController::setShowDebugLayerTree):
68675         * DumpRenderTree/chromium/TestShell.cpp:
68676         (TestShell::runFileTest):
68677         (TestShell::dump):
68678         * DumpRenderTree/chromium/TestShell.h:
68679         (TestParams::TestParams):
68680
68681 2011-03-21  Adam Roben  <aroben@apple.com>
68682
68683         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
68684
68685         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
68686         output as plain text
68687
68688         Reviewed by David Kilzer.
68689
68690         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
68691         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
68692         to the master.
68693         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
68694         since we're running on the build master, not the slave. Instead, turn the raw source of
68695         actual.html which the build slave uploaded into an HTML log.
68696
68697 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
68698
68699         Reviewed by Mihai Parparita.
68700
68701         new-run-webkit-tests: run tests in ascending alphabetical order per dir
68702         https://bugs.webkit.org/show_bug.cgi?id=56760
68703
68704         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
68705         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
68706         * Scripts/webkitpy/layout_tests/port/test.py:
68707
68708 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
68709
68710         Reviewed by Steve Block.
68711
68712         Media Stream API patch 0: adding compilation guards.
68713         https://bugs.webkit.org/show_bug.cgi?id=56458
68714
68715         Adding options to enable the media stream API feature in Chromium.
68716
68717         * Scripts/build-webkit:
68718
68719 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
68720
68721         Reviewed by Laszlo Gombos.
68722
68723         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
68724         https://bugs.webkit.org/show_bug.cgi?id=56323
68725
68726         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
68727         "--stdout" or "--stderr" option.
68728
68729         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
68730         (WebCore::DumpRenderTree::~DumpRenderTree):
68731         (WebCore::DumpRenderTree::processArgsLine):
68732         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
68733         * DumpRenderTree/qt/DumpRenderTreeQt.h:
68734         (WebCore::DumpRenderTree::setRedirectOutputFileName):
68735         (WebCore::DumpRenderTree::setRedirectErrorFileName):
68736         * DumpRenderTree/qt/main.cpp:
68737         (isOption):
68738         (takeOptionValue):
68739         (printUsage):
68740         (main):
68741
68742 2011-03-21  Adam Roben  <aroben@apple.com>
68743
68744         Fix exceptions on the buildbot due to my last change
68745
68746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
68747         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
68748
68749 2011-03-21  Adam Roben  <aroben@apple.com>
68750
68751         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
68752
68753         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
68754         output as plain text
68755
68756         Reviewed by Darin Adler.
68757
68758         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
68759         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
68760         logs.
68761         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
68762         the build master. This will correctly treat it as HTML.
68763
68764 2011-03-20  Bill Budge  <bbudge@chromium.org>
68765
68766         Reviewed by Adam Barth.
68767
68768         Rename ThreadSafeShared to ThreadSafeRefCounted
68769         https://bugs.webkit.org/show_bug.cgi?id=56714
68770
68771         No new tests. Exposes no new functionality.
68772
68773         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
68774         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
68775         * Scripts/do-webcore-rename:
68776
68777 2011-03-19  Anton D'Auria  <adauria@apple.com>
68778
68779         Reviewed by Dan Bernstein.
68780
68781         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
68782         https://bugs.webkit.org/show_bug.cgi?id=56719
68783
68784         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
68785         (LayoutTestController::clearApplicationCacheForOrigin):
68786
68787 2011-03-19  Anton D'Auria  <adauria@apple.com>
68788
68789         Reviewed by Alexey Proskuryakov.
68790
68791         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
68792         https://bugs.webkit.org/show_bug.cgi?id=56415
68793
68794         * DumpRenderTree/LayoutTestController.cpp:
68795         (clearApplicationCacheForOriginCallback):
68796         (LayoutTestController::staticFunctions):
68797         * DumpRenderTree/LayoutTestController.h:
68798         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
68799         (LayoutTestController::LayoutTestController):
68800         (LayoutTestController::clearAllApplicationCaches):
68801         (LayoutTestController::clearApplicationCacheForOrigin):
68802         * DumpRenderTree/chromium/LayoutTestController.h:
68803         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
68804         (LayoutTestController::clearApplicationCacheForOrigin):
68805         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
68806         (LayoutTestController::clearApplicationCacheForOrigin):
68807         * DumpRenderTree/qt/LayoutTestControllerQt.h:
68808         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
68809         (LayoutTestController::clearApplicationCacheForOrigin):
68810         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
68811         (LayoutTestController::clearApplicationCacheForOrigin):
68812
68813 2011-03-18  Dan Bernstein  <mitz@apple.com>
68814
68815         Revised build fix for r81135.
68816
68817         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
68818         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
68819
68820 2011-03-18  Adam Roben  <aroben@apple.com>
68821
68822         Windows build fix
68823
68824         * WebKitTestRunner/config.h: Add a missing #endif.
68825
68826 2011-03-18  Andreas Kling  <kling@webkit.org>
68827
68828         Unbreak Qt build after r81494.
68829
68830         * WebKitTestRunner/qt/TestInvocationQt.cpp:
68831         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
68832
68833 2011-03-18  Sam Weinig  <sam@webkit.org>
68834
68835         Fix windows build. This was really Adam Roben's fault. I swear!
68836
68837         * WebKitTestRunner/config.h:
68838
68839 2011-03-18  Sam Weinig  <sam@webkit.org>
68840
68841         Reviewed by Adam Roben.
68842
68843         Pixel tests don't work in WebKitTestRunner on Windows
68844         https://bugs.webkit.org/show_bug.cgi?id=56630
68845
68846         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
68847         built-in snapshotting instead of using the window server on the Mac.
68848
68849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
68850         (WTR::InjectedBundle::InjectedBundle):
68851         (WTR::InjectedBundle::didReceiveMessage):
68852         (WTR::InjectedBundle::beginTesting):
68853         (WTR::InjectedBundle::done):
68854         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
68855         (WTR::InjectedBundle::setPixelResult):
68856         (WTR::InjectedBundle::shouldDumpPixels):
68857         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
68858         (WTR::InjectedBundlePage::dump):
68859         Take the snapshot in the bundle and send it to the UIProcess for dumping.
68860
68861         * WebKitTestRunner/TestInvocation.cpp:
68862         (WTR::TestInvocation::invoke):
68863         (WTR::TestInvocation::dump):
68864         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
68865         * WebKitTestRunner/TestInvocation.h:
68866         * WebKitTestRunner/cg: Added.
68867         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
68868         (WTR::createCGContextFromImage):
68869         (WTR::computeMD5HashStringForContext):
68870         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
68871         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
68872         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
68873
68874         * WebKitTestRunner/win/TestInvocationWin.cpp:
68875         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
68876         Keep stub for Cairo build.
68877
68878         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
68879         Add CG configuration.
68880
68881         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
68882         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
68883         Add new files.
68884
68885 2011-03-18  Adam Roben  <aroben@apple.com>
68886
68887         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
68888
68889         Rubber-stamped by Simon Fraser.
68890
68891         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
68892         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
68893         overflow-y:overlay so that the scrollbar doesn't overlay the content.
68894
68895 2011-03-18  Adam Roben  <aroben@apple.com>
68896
68897         Don't ellipsize long or indented function names in Leaks Viewer
68898
68899         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
68900         scrollbar
68901
68902         Reviewed by Simon Fraser.
68903
68904         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
68905         (.data-grid .data-container):
68906         (.data-grid td > div, .data-grid th > div):
68907         Allow the contents to extend to the right.
68908
68909 2011-03-18  Adam Roben  <aroben@apple.com>
68910
68911         Fix some leaks in DRT seen on the leaks bot
68912
68913         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
68914         setWillSendRequestClearHeaderCallback in DRT are leaky
68915
68916         Reviewed by Alexey Proskuryakov.
68917
68918         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
68919
68920         * DumpRenderTree/LayoutTestController.cpp:
68921         (addURLToRedirectCallback):
68922         (setWillSendRequestClearHeaderCallback):
68923         Use OwnArrayPtr to cause the strings to be deleted.
68924
68925 2011-03-18  Adam Roben  <aroben@apple.com>
68926
68927         Fix a NSURLCredential leak seen on the leaks bot
68928
68929         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
68930         connection:didReceiveAuthenticationChallenge:] is leaky
68931
68932         Reviewed by John Sullivan.
68933
68934         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
68935         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
68936         cause the NSURLCredential to be released.
68937
68938 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
68939
68940         Unreviewed.
68941
68942         Remove unnecessary brackets around my email address.
68943
68944         * Scripts/webkitpy/common/config/committers.py:
68945
68946 2011-03-18  Adam Roben  <aroben@apple.com>
68947
68948         Remove some files I accidentally added in r81454
68949
68950         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
68951         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
68952
68953 2011-03-18  Adam Roben  <aroben@apple.com>
68954
68955         Ignore an NSNumberFormatter leak on SnowLeopard
68956
68957         * Scripts/old-run-webkit-tests:
68958         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
68959         getObjectValue:forString:errorDescription:].
68960
68961 2011-03-18  Adam Roben  <aroben@apple.com>
68962
68963         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
68964
68965         Rubber-stamped by Mark Rowe.
68966
68967         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
68968         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
68969         released.
68970
68971 2011-03-17  Adam Roben  <aroben@apple.com>
68972
68973         Address a review comment I missed in r81445
68974
68975         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
68976         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
68977         leaked bytes to speed up searching on long lines.
68978
68979 2011-03-17  Adam Roben  <aroben@apple.com>
68980
68981         Mark leaky builds orange, even if all regression tests passed
68982
68983         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
68984         build.webkit.org when all tests pass even though there are still leaks
68985
68986         Reviewed by Dan Bernstein.
68987
68988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
68989         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
68990         be marked orange if this build step generates warnings.
68991
68992 2011-03-17  Adam Roben  <aroben@apple.com>
68993
68994         Allow values in Leaks Viewer to be shown as percentages
68995
68996         Double-clicking on a column will toggle between showing percentages and showing real values.
68997
68998         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
68999         number of leaked bytes in Leaks Viewer
69000
69001         Reviewed by Joe Pecoraro.
69002
69003         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
69004         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
69005         node's totalTime, which is used in calculating percentages.
69006
69007         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
69008         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
69009         showing them as percentages.
69010
69011 2011-03-17  Adam Roben  <aroben@apple.com>
69012
69013         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
69014
69015         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
69016         the number of leaked allocations. And the new Average column shows the average number of
69017         leaked bytes per call.
69018
69019         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
69020         just how many allocations
69021
69022         Reviewed by Joe Pecoraro.
69023
69024         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
69025         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
69026         line and store it with the leak stack.
69027         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
69028         properties.
69029         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
69030         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
69031         .numberOfCalls now holds the number of leaked allocations.
69032
69033         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
69034         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
69035         appear.
69036         (monkeyPatchInspectorObjects): Format the values as bytes.
69037
69038 2011-03-17  Adam Roben  <aroben@apple.com>
69039
69040         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
69041
69042         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
69043         regression tests
69044
69045         Reviewed by James Robinson.
69046
69047         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
69048         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
69049         is always populated, even when all regression tests pass.
69050
69051 2011-03-10  Hayato Ito  <hayato@chromium.org>
69052
69053         Reviewed by Tony Chang.
69054
69055         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
69056
69057         https://bugs.webkit.org/show_bug.cgi?id=56076
69058
69059         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
69060
69061 2011-03-17  Adam Roben  <aroben@apple.com>
69062
69063         Skip a compositing-sensitive test when accelerated compositing is disabled
69064
69065         Reviewed by Sam Weinig.
69066
69067         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
69068         accelerated compositing is disabled.
69069
69070 2011-03-17  Adam Roben  <aroben@apple.com>
69071
69072         Start using PlatformSpecificScheduler for the Mac builders
69073
69074         The current set of file/directory patterns should work for Mac builders. We may discover
69075         that there are more files and directories we can exclude from the Mac builds, but they can
69076         be added later.
69077
69078         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
69079
69080         Reviewed by Mark Rowe.
69081
69082         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
69083         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
69084
69085         * Scripts/webkitpy/common/config/build.py:
69086         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
69087         cleaned up patterns a little bit.
69088
69089         * Scripts/webkitpy/common/config/build_unittest.py:
69090         (ShouldBuildTest): Fixed some expected results.
69091         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
69092         platforms.
69093
69094 2011-03-17  Jeff Miller  <jeffm@apple.com>
69095
69096         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
69097
69098         *.mode*
69099         *.pbxuser
69100         *.perspective*
69101         project.xcworkspace
69102         xcuserdata
69103
69104         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
69105         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
69106         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
69107         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
69108         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
69109
69110 2011-03-17  Adam Roben  <aroben@apple.com>
69111
69112         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
69113
69114         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
69115         mac-wk2
69116
69117         Reviewed by Anders Carlsson.
69118
69119         * Scripts/old-run-webkit-tests:
69120         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
69121         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
69122         we're running in WebKit2 mode.
69123
69124 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
69125
69126         Reviewed by Yury Semikhatsky.
69127
69128         Web Inspector: Clean up Inspector strings.
69129         https://bugs.webkit.org/show_bug.cgi?id=56557
69130
69131         Modify the script to deal correctly with "\xNN" escapes, and to
69132         check strings in Chromium's DevTools.js.
69133
69134         * Scripts/check-inspector-strings:
69135
69136 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
69137
69138         Reviewed by Benjamin Poulain.
69139
69140         Update autoinstall to install mechanize 0.2.4
69141         https://bugs.webkit.org/show_bug.cgi?id=56499
69142
69143         Newer versions of mechanize support HTTPS proxies, which is necessary
69144         for people using webkit-patch behind firewalls.
69145
69146         * Scripts/webkitpy/common/system/autoinstall.py:
69147         * Scripts/webkitpy/thirdparty/__init__.py:
69148
69149 2011-03-16  Sam Weinig  <sam@webkit.org>
69150
69151         Reviewed by Adam Roben.
69152
69153         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
69154         https://bugs.webkit.org/show_bug.cgi?id=56541
69155
69156         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
69157         (WTR::InjectedBundlePage::willSendRequestForFrame):
69158         Check for an empty host in addition to a null host.  This bug was introduced
69159         when porting off of the KURL code and onto the WKURLRef version.
69160
69161 2011-03-16  Sam Weinig  <sam@webkit.org>
69162
69163         Reviewed by Adam Roben.
69164
69165         Add Lucas Forschler to the list of WebKit committers.
69166
69167         * Scripts/webkitpy/common/config/committers.py:
69168
69169 2011-03-16  Sam Weinig  <sam@webkit.org>
69170
69171         Reviewed upon and dictated through Adam Roben.
69172
69173         Escape crashing function names in results.html. This fixes an issue
69174         when a crash involves a type with templates.
69175
69176         * Scripts/old-run-webkit-tests:
69177
69178 2011-03-16  Daniel Sievers  <sievers@google.com>
69179
69180         Reviewed by James Robinson.
69181
69182         Add setting to always force compositing mode
69183         https://bugs.webkit.org/show_bug.cgi?id=56156
69184
69185         * DumpRenderTree/chromium/DumpRenderTree.cpp:
69186         (main):
69187         * DumpRenderTree/chromium/TestShell.cpp:
69188         (TestShell::TestShell):
69189         (TestShell::resetWebSettings):
69190         * DumpRenderTree/chromium/TestShell.h:
69191         (TestShell::setForceCompositingMode):
69192         * DumpRenderTree/chromium/WebPreferences.cpp:
69193         (WebPreferences::reset):
69194         (WebPreferences::applyTo):
69195         * DumpRenderTree/chromium/WebPreferences.h:
69196
69197 2011-03-15  Hayato Ito  <hayato@chromium.org>
69198
69199         Reviewed by Ojan Vafai.
69200
69201         Ignore files that will be used by reftests in old-run-webkit-tests.
69202
69203         https://bugs.webkit.org/show_bug.cgi?id=55936
69204
69205         * Scripts/old-run-webkit-tests:
69206
69207 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
69208
69209         Reviewed by Adam Roben.
69210
69211         Function relativeScriptsDir doesn't return the correct relative
69212         Scripts directory.
69213
69214         * Scripts/webkitdirs.pm:
69215         (relativeScriptsDir): Ensure we use the directory that contains
69216         webkitdirs.pm, not the one that contains the original script that
69217         was invoked.
69218
69219 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
69220
69221         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
69222         fix to link against the Security framework after recent WebKitSystemInterface changes.
69223
69224         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
69225         (LayoutTestController::originsWithLocalStorage):
69226         * wx/build/settings.py:
69227         * wx/build/waf_extensions.py:
69228
69229 2011-03-15  Sam Weinig  <sam@webkit.org>
69230
69231         Reviewed by Darin Adler.
69232
69233         Add script to convert a patch to a prettypatch and show in the default browser
69234         https://bugs.webkit.org/show_bug.cgi?id=56416
69235
69236         This can be used either like
69237             $ svn-create-patch | show-pretty-diff
69238         or
69239             $ show-pretty-diff patch.diff
69240
69241         * Scripts/show-pretty-diff: Added.
69242
69243 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
69244
69245         Rubber-stamped by Adam Roben.
69246
69247         Adding myself as a reviewer.
69248
69249         * Scripts/webkitpy/common/config/committers.py:
69250
69251 2011-03-15  Anders Carlsson  <andersca@apple.com>
69252
69253         Try to fix the Windows build.
69254
69255         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
69256         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
69257
69258 2011-03-15  Anders Carlsson  <andersca@apple.com>
69259
69260         Reviewed by Sam Weinig.
69261
69262         Make sure that NP_Shutdown is always the last NPP function called
69263         https://bugs.webkit.org/show_bug.cgi?id=56391
69264
69265         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
69266
69267         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
69268         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
69269         (PluginTest::PluginTest):
69270         (PluginTest::NP_Shutdown):
69271         (PluginTest::registerNPShutdownFunction):
69272         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
69273         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
69274         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
69275         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
69276         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
69277         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
69278         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
69279         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
69280         (NPDeallocateCalledBeforeNPShutdown::shutdown):
69281         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
69282         (NP_Shutdown):
69283         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
69284         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
69285         * GNUmakefile.am:
69286
69287 2011-03-15  Ilya Sherman  <isherman@chromium.org>
69288
69289         Reviewed by Tony Chang.
69290
69291         Autofilled form elements are assigned fixed background color but not text color
69292         https://bugs.webkit.org/show_bug.cgi?id=48382
69293
69294         * DumpRenderTree/LayoutTestController.cpp:
69295         (setAutofilledCallback): Added.
69296         (LayoutTestController::staticFunctions):
69297         * DumpRenderTree/LayoutTestController.h:
69298         * DumpRenderTree/chromium/LayoutTestController.cpp:
69299         (LayoutTestController::LayoutTestController):
69300         (LayoutTestController::setAutofilled): Added.
69301         * DumpRenderTree/chromium/LayoutTestController.h:
69302         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69303         (LayoutTestController::setAutofilled): Added.
69304         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
69305         (LayoutTestController::setAutofilled): Added.
69306         (LayoutTestController::setValueForUser): Style tweak.
69307         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
69308         (LayoutTestController::setAutofilled): Added (stub).
69309         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
69310         (LayoutTestController::setAutofilled): Added (stub).
69311
69312 2011-03-15  Dan Bernstein  <mitz@apple.com>
69313
69314         Build fix after r81135.
69315
69316         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
69317
69318 2011-03-15  Dan Bernstein  <mitz@apple.com>
69319
69320         Build fix after r81135.
69321
69322         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
69323         * WebKitTestRunner/mac/TestControllerMac.mm:
69324         * WebKitTestRunner/mac/TestInvocationMac.mm:
69325         * WebKitTestRunner/mac/main.mm:
69326
69327 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
69328
69329         Reviewed by Adam Barth.
69330
69331         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
69332         https://bugs.webkit.org/show_bug.cgi?id=56349
69333
69334         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
69335         on platforms where we use it. Copied from DumpRenderTree.pro.
69336
69337 2011-03-15  Dan Bernstein  <mitz@apple.com>
69338
69339         Build fix after r81135.
69340
69341         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
69342         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
69343
69344 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
69345
69346         Reviewed by Darin Adler.
69347
69348         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
69349         info into the headers rather than in export symbol definition files, but disable it on
69350         all platforms initially so we can deal with port build issues one port at a time.
69351
69352         https://bugs.webkit.org/show_bug.cgi?id=27551
69353
69354         * DumpRenderTree/cg/ImageDiffCG.cpp:
69355         * DumpRenderTree/chromium/config.h:
69356         * DumpRenderTree/config.h:
69357         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
69358         * TestWebKitAPI/TestWebKitAPIPrefix.h:
69359         * WebKitAPITest/HostWindow.cpp:
69360         * WebKitAPITest/TestsController.cpp:
69361         * WebKitAPITest/config.h: Added.
69362         * WebKitAPITest/main.cpp:
69363         * WebKitAPITest/tests/WebViewDestruction.cpp:
69364         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
69365         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
69366         * WebKitTestRunner/InjectedBundle/GCController.cpp:
69367         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
69368         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
69369         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
69370         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
69371         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
69372         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
69373         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
69374         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
69375         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
69376         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
69377         * WebKitTestRunner/TestController.cpp:
69378         * WebKitTestRunner/TestInvocation.cpp:
69379         * WebKitTestRunner/config.h: Added.
69380         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
69381         * WebKitTestRunner/qt/TestControllerQt.cpp:
69382         * WebKitTestRunner/qt/TestInvocationQt.cpp:
69383         * WebKitTestRunner/qt/main.cpp:
69384         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
69385         * WebKitTestRunner/win/TestControllerWin.cpp:
69386         * WebKitTestRunner/win/TestInvocationWin.cpp:
69387         * WebKitTestRunner/win/main.cpp:
69388         * wx/build/settings.py:
69389
69390 2011-03-15  Hayato Ito  <hayato@chromium.org>
69391
69392         Reviewed by Shinichiro Hamaji.
69393
69394         [NRWT] Add support for reftests to new-run-webkit-tests.
69395
69396         https://bugs.webkit.org/show_bug.cgi?id=55457
69397
69398         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
69399         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
69400         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
69401         * Scripts/webkitpy/layout_tests/port/base.py:
69402         * Scripts/webkitpy/layout_tests/port/dryrun.py:
69403         * Scripts/webkitpy/layout_tests/port/test.py:
69404         * Scripts/webkitpy/layout_tests/port/test_files.py:
69405         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
69406
69407 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
69408
69409         Reviewed by Martin Robinson.
69410
69411         [GTK] Fix compilation warning after r80892
69412         https://bugs.webkit.org/show_bug.cgi?id=56302
69413
69414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69415         (LayoutTestController::originsWithLocalStorage):
69416
69417 2011-03-15  Robert Hogan  <robert@webkit.org>
69418
69419         Reviewed by Adam Barth.
69420
69421         Document the qmakearg argument, and hint how to build webkit2 on Qt
69422         https://bugs.webkit.org/show_bug.cgi?id=56326
69423
69424         * Scripts/build-webkit: add --qmakearg to build-webkit --help
69425
69426 2011-03-15  Adam Roben  <aroben@apple.com>
69427
69428         Make Windows 7 Release (Tests) a core builder
69429
69430         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
69431         give it a few more days of greenness first.
69432
69433         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
69434
69435         Reviewed by Sam Weinig.
69436
69437         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
69438         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
69439
69440         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
69441         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
69442         Updated the core regexps to match the buildbot module. Updated the expected results to match
69443         the current set of core builders.
69444
69445 2011-03-14  Adam Roben  <aroben@apple.com>
69446
69447         Add forgotten file from r81116
69448
69449         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
69450
69451 2011-03-14  Sam Weinig  <sam@webkit.org>
69452
69453         Reviewed by Adam Roben.
69454
69455         about:blank fake responses don't get serialized when sent the UIProcess
69456         <rdar://problem/9108119>
69457         https://bugs.webkit.org/show_bug.cgi?id=56357
69458
69459         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
69460         (TestWebKitAPI::decidePolicyForResponse):
69461         (TestWebKitAPI::TEST):
69462         Add test that loads of about:blank have a response with a MIMEType of text/html.
69463
69464         * TestWebKitAPI/PlatformUtilities.h:
69465         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
69466         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
69467         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
69468         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
69469         Add helper to get the MIMEType from a WKURLResponse.
69470
69471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69472         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
69473         Add new files.
69474
69475 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
69476
69477         Reviewed by Kenneth Rohde Christiansen.
69478
69479         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
69480         https://bugs.webkit.org/show_bug.cgi?id=56006
69481
69482         * QtTestBrowser/launcherwindow.cpp:
69483         (LauncherWindow::initializeView):
69484         * QtTestBrowser/main.cpp:
69485         (LauncherApplication::handleUserOptions):
69486
69487 2011-03-14  James Kozianski  <koz@chromium.org>
69488
69489         Reviewed by Ojan Vafai.
69490
69491         Add method to make BuildBot return test outputs
69492         https://bugs.webkit.org/show_bug.cgi?id=54374
69493
69494         The Builder.latest_cached_build will be used by the new rebaseline
69495         script to determine the build to use baselines from.
69496
69497         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
69498         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
69499
69500 2011-03-14  Adam Roben  <aroben@apple.com>
69501
69502         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
69503
69504         Reviewed by Sam Weinig.
69505
69506         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
69507         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
69508         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
69509         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
69510         ensure the web process is initialized, then ask the bundle to run the test and assert that
69511         it succeeded.
69512
69513         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
69514         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
69515         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
69516         handle a given URL.
69517         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
69518         URL type cannot be handled).
69519         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
69520         result.
69521
69522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69523         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
69524         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
69525         Added new files to the project.
69526
69527 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
69528
69529         Unreviewed, rolling out r81094.
69530         http://trac.webkit.org/changeset/81094
69531         https://bugs.webkit.org/show_bug.cgi?id=56355
69532
69533         Broke the chromium DRT related build. (Requested by dave_levin
69534         on #webkit).
69535
69536         * DumpRenderTree/chromium/DumpRenderTree.cpp:
69537         (main):
69538         * DumpRenderTree/chromium/LayoutTestController.cpp:
69539         (LayoutTestController::LayoutTestController):
69540         (LayoutTestController::layerTreeAsText):
69541         * DumpRenderTree/chromium/LayoutTestController.h:
69542         * DumpRenderTree/chromium/TestShell.cpp:
69543         (TestShell::runFileTest):
69544         (TestShell::dump):
69545         * DumpRenderTree/chromium/TestShell.h:
69546         (TestParams::TestParams):
69547
69548 2011-03-14  Daniel Sievers  <sievers@google.com>
69549
69550         Reviewed by Simon Fraser.
69551
69552         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
69553         https://bugs.webkit.org/show_bug.cgi?id=56139
69554
69555         * DumpRenderTree/chromium/DumpRenderTree.cpp:
69556         (main):
69557         * DumpRenderTree/chromium/LayoutTestController.cpp:
69558         (LayoutTestController::LayoutTestController):
69559         (LayoutTestController::layerTreeAsText):
69560         * DumpRenderTree/chromium/LayoutTestController.h:
69561         (LayoutTestController::setShowDebugLayerTree):
69562         * DumpRenderTree/chromium/TestShell.cpp:
69563         (TestShell::runFileTest):
69564         (TestShell::dump):
69565         * DumpRenderTree/chromium/TestShell.h:
69566         (TestParams::TestParams):
69567
69568 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
69569
69570         Reviewed by Adam Roben.
69571
69572         [Qt][WK2]Unbreak InjectedBundle on Qt
69573         https://bugs.webkit.org/show_bug.cgi?id=54109
69574
69575         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
69576         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
69577         API's instead of KURL to analyze the URL.
69578         * WebKitTestRunner/StringFunctions.h:
69579         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
69580         in the WebKitTestRunner project.
69581         (WTR::toWK): Use adoptWK.
69582         (WTR::operator<<): Added helper for printing a WKURL.
69583         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
69584         against WebCore.
69585
69586 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
69587
69588         Reviewed by Kenneth Rohde Christiansen.
69589
69590         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
69591         https://bugs.webkit.org/show_bug.cgi?id=56321
69592
69593         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
69594         to the list of exceptions for WebKit2 C API headers.
69595
69596 2011-03-14  Adam Roben  <aroben@apple.com>
69597
69598         Show the list of recent leaky builds in reverse chronological order
69599
69600         Previously they were being shown in a deterministic but surprising order based on
69601         lexicographically sorting the build offsets (-1, -10, -2, -3...).
69602
69603         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
69604
69605         Reviewed by Darin Adler.
69606
69607         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
69608         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
69609         callback.
69610
69611 2011-03-14  Adam Roben  <aroben@apple.com>
69612
69613         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
69614
69615         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
69616         analyze
69617
69618         Reviewed by David Kilzer and Joe Pecoraro.
69619
69620         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
69621         (#url-prompt): Made this a bit taller to make room for the list of builds.
69622
69623         (#recent-builds-loading-indicator):
69624         (#recent-builds-list):
69625         Added styles for the build list and loading indicator.
69626
69627         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
69628         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
69629         it. This will unescape it.
69630         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
69631         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
69632         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
69633         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
69634         prompt UI.
69635         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
69636         now also used when a recent build is clicked.
69637
69638         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
69639         (RecentBuildsLoader): Store the callback.
69640         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
69641         builder. Find the revision number, leak count, and results URL for each one. Pass the
69642         resulting info to our callback.
69643
69644         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
69645         (range): Added this helper function to return an array containing the integers [0, n).
69646
69647         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
69648         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
69649
69650 2011-03-14  Mark Rowe  <mrowe@apple.com>
69651
69652         Reviewed by Adam Roben.
69653
69654         Fix two memory leaks within LayoutTestController's storage support.
69655
69656         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
69657         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
69658         by JSStringCreateWithCFString.
69659         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
69660         allocate.
69661
69662 2011-03-14  Mark Rowe  <mrowe@apple.com>
69663
69664         Reviewed by Oliver Hunt.
69665
69666         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
69667
69668         * DumpRenderTree/LayoutTestController.cpp:
69669         (LayoutTestController::staticFunctions): Remove duplicate entries.
69670
69671 2011-03-14  Alice Liu  <alice.liu@apple.com>
69672
69673         Reviewed by Dan Bernstein.
69674
69675         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
69676
69677         * DumpRenderTree/mac/PerlSupport/Makefile:
69678         Add whitespace when joining "-arch" with the architectures passed in as arguments.
69679
69680 2011-03-14  Daniel Bates  <dbates@rim.com>
69681
69682         https://bugs.webkit.org/show_bug.cgi?id=55438
69683         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
69684         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
69685
69686         * Scripts/build-webkit:
69687
69688 2011-03-14  Daniel Bates  <dbates@rim.com>
69689
69690         Reviewed by David Kilzer.
69691
69692         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
69693         https://bugs.webkit.org/show_bug.cgi?id=55438
69694
69695         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
69696         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
69697         CMake arguments for feature defines.
69698
69699         * Scripts/build-webkit:
69700           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
69701           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
69702           - Sorted forward declarations.
69703           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
69704             Modified call sites as needed.
69705         * Scripts/webkitdirs.pm:
69706           - Added cleanCMakeGeneratedProject() to clean a CMake build.
69707           - Added buildCMakeGeneratedProject() to build using generated build system.
69708           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
69709           - Added generateBuildSystemFromCMakeProject() to generate the build system from
69710             a CMake project.
69711           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
69712
69713 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
69714
69715         Reviewed by Steve Block.
69716
69717         Detach Geolocation from Frame when Page destroyed.
69718         https://bugs.webkit.org/show_bug.cgi?id=52877
69719
69720         Extend the layout test controller to expose the number of pending
69721         geolocation requests, so that we can test that the requests have
69722         been cancelled on page close.
69723
69724         * DumpRenderTree/LayoutTestController.cpp:
69725         (numberOfPendingGeolocationPermissionRequestsCallback):
69726         (LayoutTestController::staticFunctions):
69727         * DumpRenderTree/LayoutTestController.h:
69728         * DumpRenderTree/chromium/LayoutTestController.cpp:
69729         (LayoutTestController::LayoutTestController):
69730         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69731         * DumpRenderTree/chromium/LayoutTestController.h:
69732         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69733         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69734         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
69735         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69736         * DumpRenderTree/mac/UIDelegate.h:
69737         * DumpRenderTree/mac/UIDelegate.mm:
69738         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
69739         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
69740         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69741         * DumpRenderTree/qt/LayoutTestControllerQt.h:
69742         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
69743         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69744         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
69745         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
69746
69747
69748 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
69749
69750         Unreviewed. Modify my email address in committers.py.
69751
69752         * Scripts/webkitpy/common/config/committers.py:
69753
69754 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
69755
69756         Reviewed by Kenneth Rohde Christiansen.
69757
69758         [Qt] QtLauncher does not load the same set of fonts as the DRT
69759         https://bugs.webkit.org/show_bug.cgi?id=34959
69760
69761         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
69762         When this option is used the webkit fonts are loaded the same
69763         as they are in DumpRenderTree.  This option can be used on
69764         QtTestBrowser and run-launcher.  It can only be used
69765         on Linux systems with FcInit and is configured as such.
69766
69767         * QtTestBrowser/launcherwindow.h:
69768         (WindowOptions::WindowOptions):
69769         * QtTestBrowser/main.cpp:
69770         (initWebKitTestFonts):
69771         (launcherMain):
69772         (LauncherApplication::handleUserOptions):
69773
69774 2011-03-12  Dan Bernstein  <mitz@apple.com>
69775
69776         Reviewed by Mark Rowe.
69777
69778         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
69779         DumpRenderTree is being built for.
69780
69781         * DumpRenderTree/mac/PerlSupport/Makefile:
69782
69783 2011-03-12  Dan Bernstein  <mitz@apple.com>
69784
69785         Suggested by Mark Rowe.
69786
69787         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
69788         as they were before r80915.
69789
69790 2011-03-12  Anders Carlsson  <andersca@apple.com>
69791
69792         Reviewed by Sam Weinig.
69793
69794         Should be able to download a PDF to the Downloads folder
69795         https://bugs.webkit.org/show_bug.cgi?id=56256
69796
69797         * MiniBrowser/mac/BrowserWindowController.m:
69798         (-[BrowserWindowController awakeFromNib]):
69799         * WebKitTestRunner/TestController.cpp:
69800         (WTR::TestController::createOtherPage):
69801         (WTR::TestController::initialize):
69802         Update for API changes.
69803
69804 2011-03-11  Anton D'Auria  <adauria@apple.com>
69805
69806         Reviewed and landed by Brady Eidson.
69807
69808         https://bugs.webkit.org/show_bug.cgi?id=51878
69809         Add WebKit1 API to view and delete local storage
69810
69811         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
69812
69813         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
69814         * DumpRenderTree/LayoutTestController.cpp:
69815         (syncLocalStorageCallback):
69816         (observeStorageTrackerNotificationsCallback):
69817         (deleteAllLocalStorageCallback):
69818         (deleteLocalStorageForOriginCallback):
69819         (originsWithLocalStorageCallback):
69820         (LayoutTestController::staticFunctions):
69821         * DumpRenderTree/LayoutTestController.h:
69822         * DumpRenderTree/StorageTrackerDelegate.h: Added.
69823         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
69824         (-[StorageTrackerDelegate init]):
69825         (-[StorageTrackerDelegate logNotifications:controller:]):
69826         (-[StorageTrackerDelegate originModified:]):
69827         (-[StorageTrackerDelegate dealloc]):
69828         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
69829         * DumpRenderTree/chromium/LayoutTestController.cpp:
69830         (LayoutTestController::LayoutTestController):
69831         (LayoutTestController::deleteAllLocalStorage):
69832         (LayoutTestController::originsWithLocalStorage):
69833         (LayoutTestController::deleteLocalStorageForOrigin):
69834         (observeStorageTrackerNotifications):
69835         (syncLocalStorage):
69836         * DumpRenderTree/chromium/LayoutTestController.h:
69837         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
69838         (LayoutTestController::originsWithLocalStorage):
69839         (LayoutTestController::deleteAllLocalStorage):
69840         (LayoutTestController::deleteLocalStorageForOrigin):
69841         (LayoutTestController::observeStorageTrackerNotifications):
69842         (LayoutTestController::syncLocalStorage):
69843         * DumpRenderTree/mac/DumpRenderTree.mm:
69844         (resetDefaultsToConsistentValues):
69845         (allocateGlobalControllers):
69846         (releaseGlobalControllers):
69847         * DumpRenderTree/mac/DumpRenderTreeMac.h:
69848         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
69849         (LayoutTestController::syncLocalStorage):
69850         (LayoutTestController::observeStorageTrackerNotifications):
69851         (LayoutTestController::deleteAllLocalStorage):
69852         (LayoutTestController::originsWithLocalStorage):
69853         (LayoutTestController::deleteLocalStorageForOrigin):
69854         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
69855         (LayoutTestController::originsWithLocalStorage):
69856         (LayoutTestController::deleteAllLocalStorage):
69857         (LayoutTestController::deleteLocalStorageForOrigin):
69858         (LayoutTestController::observeStorageTrackerNotifications):
69859         (LayoutTestController::syncLocalStorage):
69860         * DumpRenderTree/qt/LayoutTestControllerQt.h:
69861         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
69862         (LayoutTestController::clearAllApplicationCaches):
69863         (LayoutTestController::syncLocalStorage):
69864         (LayoutTestController::observeStorageTrackerNotifications):
69865         (LayoutTestController::clearAllDatabases):
69866         (LayoutTestController::deleteAllLocalStorage):
69867         (LayoutTestController::originsWithLocalStorage):
69868         (LayoutTestController::deleteLocalStorageForOrigin):
69869         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
69870         (LayoutTestController::syncLocalStorage):
69871         (LayoutTestController::observeStorageTrackerNotifications):
69872         (LayoutTestController::clearAllDatabases):
69873         (LayoutTestController::deleteAllLocalStorage):
69874         (LayoutTestController::originsWithLocalStorage):
69875         (LayoutTestController::deleteLocalStorageForOrigin):
69876
69877 2011-03-11  Jessie Berlin  <jberlin@apple.com>
69878
69879         Reviewed by Adam Roben.
69880
69881         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
69882         Process has finished launching.
69883         https://bugs.webkit.org/show_bug.cgi?id=56208
69884
69885         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
69886         (TestWebKitAPI::TEST):
69887         Test that calling WKContextClearResourceCaches works with both options when called before
69888         the Web Process is valid.
69889
69890         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
69891         Add the new test.
69892         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
69893         Ditto.
69894
69895 2011-03-11  Adam Roben  <aroben@apple.com>
69896
69897         Make it possible to view all leaks from a build at once in Leaks Viewer
69898
69899         You can now give Leaks Viewer the URL of a build results page (e.g.,
69900         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
69901         will load all the leaks files from that build.
69902
69903         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
69904         files from a particular build at once, rather than one at a time
69905
69906         Reviewed by David Kilzer.
69907
69908         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
69909         (LeaksLoader): Initialize our properties.
69910         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
69911         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
69912         from that page.
69913         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
69914         so it can provide feedback. Then load each one and pass it to the client.
69915         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
69916         it into a DOM, pull out all the links to leaks files, and load each one.
69917
69918         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
69919         (LeaksParser): Initialize our worker.
69920         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
69921
69922         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
69923         This code mostly came from Worker.js.
69924         (LeaksParserWorker): Initialize our profile.
69925         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
69926         profile.
69927         (LeaksParserWorker.prototype._parseLeaks):
69928         (LeaksParserWorker.prototype._createNode):
69929         (LeaksParserWorker.prototype._incorporateLeaks):
69930         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
69931         version of createProfile which adds to this.profile instead of making a new profile each
69932         time.
69933         (onmessage): Parse the file and send back the new profile.
69934
69935         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
69936         (#loading-indicator):
69937         (#spinner):
69938         (#loading-indicator-label):
69939         Tweaked styles to accomodate a longer label.
69940
69941         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
69942         (LeaksViewer.loaded): Set up a loader and parser.
69943
69944         (LeaksViewer.get filesLeftToParse):
69945         (LeaksViewer.set filesLeftToParse):
69946         Added these simple accessors.
69947
69948         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
69949         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
69950         the parser.
69951         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
69952         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
69953         _loadLeaksFromURL function).
69954         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
69955         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
69956         loading indicator, including the number of files being loaded.
69957         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
69958         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
69959         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
69960         _loadingIndicatorText.
69961
69962         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
69963         (getResource): Moved here from LeaksViewer.js.
69964
69965         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
69966         LeaksParserWorker.js.
69967
69968         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
69969         files, added a #loading-indicator-label element, and tweaked the prompt wording.
69970
69971 2011-03-11  Adam Roben  <aroben@apple.com>
69972
69973         Don't trigger a build when build.webkit.org's HTML files are modified
69974
69975         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
69976
69977         Reviewed by Dan Bernstein.
69978
69979         * Scripts/webkitpy/common/config/build.py:
69980         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
69981         directories that shouldn't trigger builds. Re-sorted the list.
69982
69983         * Scripts/webkitpy/common/config/build_unittest.py:
69984         (ShouldBuildTest): Added a test to cover the above change.
69985
69986 2011-03-11  Adam Roben  <aroben@apple.com>
69987
69988         Roll out r80848
69989
69990         It was accidentally committed.
69991
69992         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
69993         (LeaksViewer._loadLeaksFromURL):
69994
69995 2011-03-11  Tony Chang  <tony@chromium.org>
69996
69997         Reviewed by Ojan Vafai.
69998
69999         kill hung lighttpd processes on the chromium win bot
70000         https://bugs.webkit.org/show_bug.cgi?id=56152
70001
70002         Sometimes this process doesn't exit and it holds on to
70003         a log file that we can't delete or copy, causing the tests
70004         to go red.
70005
70006         * BuildSlaveSupport/win/kill-old-processes:
70007
70008 2011-03-11  Ilya Sherman  <isherman@chromium.org>
70009
70010         Reviewed by Kent Tamura.
70011
70012         [Chromium] missing HTMLInputElement::setValueForUser() to tests
70013         https://bugs.webkit.org/show_bug.cgi?id=55854
70014
70015         * DumpRenderTree/chromium/LayoutTestController.cpp:
70016         (LayoutTestController::LayoutTestController):
70017         (LayoutTestController::setValueForUser): Added.
70018         * DumpRenderTree/chromium/LayoutTestController.h:
70019
70020 2011-03-10  Peter Kasting  <pkasting@google.com>
70021
70022         Reviewed by Dimitri Glazkov.
70023
70024         Clean up some gross code in TestShellWin.cpp.  No functional change.
70025         https://bugs.webkit.org/show_bug.cgi?id=56048
70026
70027         * DumpRenderTree/chromium/TestShellWin.cpp:
70028         (checkLayoutTestSystemDependencies):
70029
70030 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
70031
70032         Reviewed by Laszlo Gombos.
70033
70034         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
70035
70036         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
70037         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
70038
70039 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
70040
70041         Reviewed by Kenneth Rohde Christiansen.
70042
70043         [EFL] Make single backing store the default for EWebLauncher
70044         https://bugs.webkit.org/show_bug.cgi?id=55753
70045
70046         Set single backing store the default for EWebLauncher.
70047
70048         * EWebLauncher/main.c:
70049         (main):
70050
70051 2011-03-10  Adam Roben  <aroben@apple.com>
70052
70053         Ignore errors from files being held open when creating a test result archive
70054
70055         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
70056         fails to delete the results directory
70057
70058         Reviewed by Mark Rowe.
70059
70060         * BuildSlaveSupport/test-result-archive:
70061         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
70062         thrown when a process is holding a file open.
70063
70064 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
70065
70066         Unreviewed, rolling out r80701.
70067         http://trac.webkit.org/changeset/80701
70068         https://bugs.webkit.org/show_bug.cgi?id=56126
70069
70070         fast/dom/Geolocation/window-close-crash.html fails on Snow
70071         Leopard release builds (Requested by mihaip on #webkit).
70072
70073         * DumpRenderTree/LayoutTestController.cpp:
70074         (LayoutTestController::staticFunctions):
70075         * DumpRenderTree/LayoutTestController.h:
70076         * DumpRenderTree/chromium/LayoutTestController.cpp:
70077         (LayoutTestController::LayoutTestController):
70078         * DumpRenderTree/chromium/LayoutTestController.h:
70079         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70080         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
70081         * DumpRenderTree/mac/UIDelegate.h:
70082         * DumpRenderTree/mac/UIDelegate.mm:
70083         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70084         * DumpRenderTree/qt/LayoutTestControllerQt.h:
70085         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
70086         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70087
70088 2011-03-10  Philippe Normand  <pnormand@igalia.com>
70089
70090         Reviewed by Gustavo Noronha Silva.
70091
70092         [GTK] run-gtk-tests doesn't fail if a test crashes
70093         https://bugs.webkit.org/show_bug.cgi?id=56089
70094
70095         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
70096         even if a test crashes. So run the tests individually and if a
70097         test fails remember its exit code so run-gtk-test fails too, if
70098         required.
70099
70100 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
70101
70102         Reviewed by Dmitry Titov.
70103
70104         Detach Geolocation from Frame when Page destroyed.
70105         https://bugs.webkit.org/show_bug.cgi?id=52877
70106
70107         Extend the layout test controller to expose the number of pending
70108         geolocation requests, so that we can test that the requests have
70109         been cancelled on page close.
70110
70111         * DumpRenderTree/LayoutTestController.cpp:
70112         (numberOfPendingGeolocationPermissionRequestsCallback):
70113         (LayoutTestController::staticFunctions):
70114         * DumpRenderTree/LayoutTestController.h:
70115         * DumpRenderTree/chromium/LayoutTestController.cpp:
70116         (LayoutTestController::LayoutTestController):
70117         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70118         * DumpRenderTree/chromium/LayoutTestController.h:
70119         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70120         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70121         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
70122         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70123         * DumpRenderTree/mac/UIDelegate.h:
70124         * DumpRenderTree/mac/UIDelegate.mm:
70125         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
70126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70127         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70128         * DumpRenderTree/qt/LayoutTestControllerQt.h:
70129         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
70130         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70131         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70132         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70133
70134
70135 2011-03-09  Adam Roben  <aroben@apple.com>
70136
70137         Hide Leaks Viewer's URL prompt by default
70138
70139         We will show it as needed. I think I left it visible by default by accident after doing some
70140         testing.
70141
70142         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
70143         URL is passed as a query parameter, but does
70144
70145         Reviewed by Simon Fraser.
70146
70147         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
70148
70149 2011-03-09  Adam Roben  <aroben@apple.com>
70150
70151         Don't use Element.classList or box-shadow in Leaks Viewer
70152
70153         They aren't supported by Safari 5. Luckily we have substitutes for them!
70154
70155         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
70156
70157         Reviewed by Simon Fraser.
70158
70159         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
70160         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
70161
70162         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
70163         (LeaksViewer.urlPromptButtonClicked):
70164         (LeaksViewer._displayURLPrompt):
70165         (LeaksViewer._setLoadingIndicatorHidden):
70166         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
70167
70168 2011-03-09  Adam Roben  <aroben@apple.com>
70169
70170         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
70171
70172         Rubber-stamped by David Kilzer.
70173
70174         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
70175
70176 2011-03-09  Adam Roben  <aroben@apple.com>
70177
70178         Add a Leaks Viewer tool to build.webkit.org
70179
70180         This tool parses leaks from the files generated by the leaks bot and displays them in a
70181         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
70182         code).
70183
70184         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
70185         be passed to the tool via the "url" query parameter.
70186
70187         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
70188         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
70189         Inspector's Heavy profile view. But it's still pretty useful as-is.
70190
70191         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
70192
70193         Reviewed by Darin Adler.
70194
70195         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
70196         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
70197         (#url-prompt): This is the prompt itself.
70198
70199         (#loading-indicator):
70200         (#loading-indicator > img):
70201         These show a spinner in the bottom-right when we're loading a leaks file.
70202
70203         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
70204         as percentages.
70205
70206         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
70207         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
70208         URL if one wasn't given to us as a query parameter).
70209
70210         (LeaksViewer.get loading):
70211         (LeaksViewer.set loading):
70212         (LeaksViewer.get url):
70213         (LeaksViewer.set url):
70214         Pretty simple accessors.
70215
70216         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
70217         prompt.
70218         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
70219         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
70220         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
70221         the profile to the Web Inspector code once it's been created.
70222         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
70223         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
70224         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
70225         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
70226
70227         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
70228         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
70229         (ProfilerAgent.getProfile): Store the callback.
70230         (ProfilerAgent.profileReady): Call the callback.
70231         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
70232         count and total leak counts as real values, not percentages or milliseconds.
70233
70234         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
70235         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
70236         (parseLeaks): Extract call stacks out of a leaks file.
70237         (createNode): Helper function to create a new empty profile node.
70238         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
70239         WebInspector.ProfileView.
70240
70241         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
70242
70243 2011-03-09  Dan Bernstein  <mitz@apple.com>
70244
70245         Reviewed by Adam Roben.
70246
70247         Combine multiple --ignore-tests values
70248         https://bugs.webkit.org/show_bug.cgi?id=56016
70249
70250         * Scripts/old-run-webkit-tests:
70251
70252 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
70253
70254         Reviewed by David Levin.
70255
70256         Adding myself to the committer file.
70257
70258         * Scripts/webkitpy/common/config/committers.py:
70259
70260 2011-03-08  Jessie Berlin  <jberlin@apple.com>
70261
70262         Rubber-stamped by Adam Roben.
70263
70264         Fix two leaks I introduced into the API tests.
70265
70266         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
70267         (TestWebKitAPI::TEST):
70268
70269 2011-03-08  Jessie Berlin  <jberlin@apple.com>
70270
70271         Reviewed by Anders Carlsson.
70272
70273         Crash in CFNetwork visiting google.com
70274         https://bugs.webkit.org/show_bug.cgi?id=55958
70275
70276         Add a test for not trying to copy a null CFURLResponse.
70277
70278         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
70279         (TestWebKitAPI::TEST):
70280         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
70281
70282 2011-03-08  Hayato Ito  <hayato@chromium.org>
70283
70284         Reviewed by Ojan Vafai.
70285
70286         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
70287
70288         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
70289
70290         https://bugs.webkit.org/show_bug.cgi?id=55450
70291
70292         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
70293
70294 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
70295
70296         Reviewed by Martin Robinson.
70297
70298         [GTK] Add layoutTestController.setValueForUser() after r80412
70299         https://bugs.webkit.org/show_bug.cgi?id=55862
70300
70301         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70302         (LayoutTestController::setValueForUser): Implement setValueForUser()
70303
70304 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
70305
70306         Reviewed by Adam Barth.
70307
70308         Add script_shell_command to WebKitPort
70309         https://bugs.webkit.org/show_bug.cgi?id=55925
70310
70311         Add a central place where we generate the shell command from the script name.
70312         This function will be used later to detect the correct script interpreter on Win32.
70313
70314         * Scripts/webkitpy/common/config/ports.py:
70315         * Scripts/webkitpy/layout_tests/port/base.py:
70316         * Scripts/webkitpy/tool/steps/abstractstep.py:
70317         * Scripts/webkitpy/tool/steps/preparechangelog.py:
70318
70319 2011-03-07  Ojan Vafai  <ojan@chromium.org>
70320
70321         Reviewed by Adam Barth.
70322
70323         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
70324         https://bugs.webkit.org/show_bug.cgi?id=55749
70325
70326         * Scripts/webkitpy/tool/commands/upload.py:
70327         * Scripts/webkitpy/tool/commands/upload_unittest.py:
70328         * Scripts/webkitpy/tool/steps/__init__.py:
70329         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
70330         * Scripts/webkitpy/tool/steps/options.py:
70331
70332 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
70333
70334         Reviewed by David Levin.
70335
70336         Add support for DataTransferItems
70337         https://bugs.webkit.org/show_bug.cgi?id=55115
70338
70339         Enable data transfer items in DRT.
70340
70341         * DumpRenderTree/chromium/TestShell.cpp:
70342         (TestShell::TestShell):
70343
70344 2011-03-06  Ojan Vafai  <ojan@chromium.org>
70345
70346         Reviewed by Tony Chang.
70347
70348         [test dashboard] pull treemap files
70349         https://bugs.webkit.org/show_bug.cgi?id=55852
70350
70351         * TestResultServer/handlers/dashboardhandler.py:
70352
70353 2011-03-03  Hayato Ito  <hayato@chromium.org>
70354
70355         Reviewed by Mihai Parparita.
70356
70357         [NRWT] Clear output image file used by DumpRenderTree to make sure the
70358         previous image should not be used in the ChromiumDriver.
70359
70360         Also make sure that output image from the ChromiumDriver should be ''
70361         (empty string) if a test crashes for consistency with the WebKitDriver
70362         implementation.
70363
70364         https://bugs.webkit.org/show_bug.cgi?id=55746
70365
70366         * Scripts/webkitpy/layout_tests/port/chromium.py:
70367
70368 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
70369
70370         Reviewed by Martin Robinson.
70371
70372         [Gtk] fast/js/navigator-language.html fails locally
70373         https://bugs.webkit.org/show_bug.cgi?id=55880
70374
70375         Add LANG variable to the clean environment when running
70376         old-run-webkit-tests script.
70377
70378         * Scripts/old-run-webkit-tests:
70379
70380 2011-03-07  Tony Chang  <tony@chromium.org>
70381
70382         Reviewed by Mihai Parparita.
70383
70384         [Chromium] Find .checksum files without .pngs and vice-versa
70385         https://bugs.webkit.org/show_bug.cgi?id=55236
70386
70387         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
70388             mismatched results.
70389
70390 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
70391
70392         Reviewed by Beth Dakin.
70393
70394         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
70395         https://bugs.webkit.org/show_bug.cgi?id=55706
70396
70397         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
70398
70399         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
70400         (AccessibilityController::focusedElement):
70401            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
70402            because it could change at any time.
70403         (AccessibilityController::rootElement):
70404
70405 2011-03-07  Sam Weinig  <sam@webkit.org>
70406
70407         Reviewed by Anders Carlsson.
70408
70409         Add unableToImplementPolicy callback for WebKit2 policy client
70410         <rdar://problem/9071902>
70411         https://bugs.webkit.org/show_bug.cgi?id=55884
70412
70413         * MiniBrowser/mac/BrowserWindowController.m:
70414         (-[BrowserWindowController awakeFromNib]):
70415         Update policy client initialization struct for new member.
70416
70417 2011-03-07  Sam Weinig  <sam@webkit.org>
70418
70419         Reviewed by Anders Carlsson.
70420
70421         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
70422         https://bugs.webkit.org/show_bug.cgi?id=55827
70423
70424         * MiniBrowser/mac/BrowserWindowController.m:
70425         (decidePolicyForResponse):
70426         (-[BrowserWindowController awakeFromNib]):
70427         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
70428         (TestWebKitAPI::decidePolicyForResponse):
70429         (TestWebKitAPI::TEST):
70430         Update tools for new name.
70431
70432 2011-03-06  Daniel Bates  <dbates@rim.com>
70433
70434         Reviewed by Eric Seidel and David Kilzer.
70435
70436         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
70437         https://bugs.webkit.org/show_bug.cgi?id=55503
70438
70439         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
70440         in checkForJavaSDK().
70441
70442         Also, remove extraneous space in function prototype for unlinkZeroFiles.
70443
70444         * Scripts/build-webkit:
70445
70446 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
70447
70448         Reviewed by Sam Weinig.
70449
70450         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
70451
70452         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
70453         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
70454             by willSendRequestForFrame. The API expects a retained reference to the URL request.
70455
70456 2011-03-05  Ilya Sherman  <isherman@chromium.org>
70457
70458         Reviewed by Darin Adler.
70459
70460         HTMLInputElement::setValue() should schedule change event when the element is focused
70461         In service of https://code.google.com/p/chromium/issues/detail?id=42716
70462         https://bugs.webkit.org/show_bug.cgi?id=53160
70463
70464         * DumpRenderTree/LayoutTestController.cpp:
70465         (setValueForUserCallback):
70466         (LayoutTestController::staticFunctions):
70467         * DumpRenderTree/LayoutTestController.h:
70468         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70469         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
70470         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
70471         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
70472         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70473         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
70474         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
70475         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
70476         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70477         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
70478
70479 2011-03-04  Mark Rowe  <mrowe@apple.com>
70480
70481         Reviewed by Alexey Proskuryakov.
70482
70483         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
70484
70485         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
70486
70487         * DumpRenderTree/mac/CheckedMalloc.cpp:
70488         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
70489         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
70490         and then restore the initial protection flags when we're done.
70491
70492 2011-03-04  Evan Martin  <evan@chromium.org>
70493
70494         Reviewed by Tony Chang.
70495
70496         [gdb] pretty-print KURL in gdb
70497         https://bugs.webkit.org/show_bug.cgi?id=55788
70498
70499         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
70500         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
70501         pretty-printing.
70502
70503 2011-03-03  Timothy Hatcher  <timothy@apple.com>
70504
70505         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
70506
70507         Reviewed by Darin Adler.
70508
70509         * TestWebKitAPI/JavaScriptTest.cpp:
70510         (TestWebKitAPI::javaScriptCallback):
70511         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
70512         (TestWebKitAPI::didRunJavaScript):
70513         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
70514         (TestWebKitAPI::nullJavaScriptCallback):
70515         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
70516         (TestWebKitAPI::didRunJavaScript):
70517
70518 2011-03-03  Timothy Hatcher  <timothy@apple.com>
70519
70520         Make run-api-tests show failed if a test fails.
70521
70522         https://webkit.org/b/55725
70523
70524         Reviewed by Sam Weinig.
70525
70526         * Scripts/run-api-tests:
70527         (runTest): Remove "my" from the nested $result assignment so the
70528         check outside the condition sees the real result.
70529
70530 2011-03-02  MORITA Hajime  <morrita@google.com>
70531
70532         Reviewed by Kent Tamura.
70533
70534         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
70535         https://bugs.webkit.org/show_bug.cgi?id=55434
70536
70537         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
70538         and passed the object webkit_support::PostDelayedTask directly.
70539
70540         Note that the change keeps postTask() as is because it has a
70541         semantics taht webkit_support::PostDelayedTask() has; It jumps to
70542         the main thread.
70543
70544         * DumpRenderTree/chromium/Task.cpp:
70545         (postDelayedTask):
70546         * DumpRenderTree/chromium/Task.h:
70547         (WebTask::Run):
70548
70549 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
70550
70551         Reviewed by Kenneth Rohde Christiansen.
70552
70553         [QT] Implement mock client-based geolocation for layout testing
70554         https://bugs.webkit.org/show_bug.cgi?id=54334
70555
70556         Implement testing for Client-Based geolocation for QtWebkit.
70557
70558         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
70559         (WebCore::DumpRenderTree::DumpRenderTree):
70560         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70561         (LayoutTestController::reset):
70562         (LayoutTestController::setGeolocationPermission):
70563         (LayoutTestController::setMockGeolocationError):
70564         (LayoutTestController::setMockGeolocationPosition):
70565
70566 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
70567
70568         Unreviewed, rolling out r80237.
70569         http://trac.webkit.org/changeset/80237
70570         https://bugs.webkit.org/show_bug.cgi?id=55714
70571
70572         Windows bots aren't ready to be core (Requested by aroben on
70573         #webkit).
70574
70575         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
70576         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
70577
70578 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
70579
70580         Reviewed by Tony Chang.
70581
70582         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
70583         https://bugs.webkit.org/show_bug.cgi?id=55694
70584
70585         Fixes for interruptions in NRWT:
70586         - Make TestRunInterruptedException be pickleable correctly (the base
70587           Exception class defines a __reduce__ that does not include the reason)
70588         - Fix ordering of returned arguments from TestRunner2._run_tests
70589           (interrupted and keyboard_interrupted were reversed)
70590         - Fix cancel_workers callsites (was using old name).
70591         - In handle_exception re-raise actual exception instance that was thrown
70592
70593         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
70594         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
70595         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
70596         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
70597
70598 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
70599
70600         Unreviewed.
70601
70602         Adding myself as a committer.
70603
70604         * Scripts/webkitpy/common/config/committers.py:
70605
70606 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
70607
70608         Reviewed by Mihai Parparita.
70609
70610         Teach sheriffbot to answer whois commands
70611         https://bugs.webkit.org/show_bug.cgi?id=55687
70612
70613         * Scripts/webkitpy/tool/bot/irc_command.py:
70614         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
70615         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
70616
70617 2011-03-03  Victoria Kirst  <vrk@google.com>
70618
70619         Reviewed by Eric Carlson.
70620
70621         Enable media tests in chromium-gpu/test_expectations
70622         https://bugs.webkit.org/show_bug.cgi?id=53608
70623
70624         Add media folder to the list of GPU test paths.
70625
70626         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
70627
70628 2011-03-03  Adam Roben  <aroben@apple.com>
70629
70630         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
70631
70632         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
70633         incorrect parsing of absolute Windows-style file: URLs
70634
70635         Reviewed by Tim Hatcher.
70636
70637         * WebKitTestRunner/TestInvocation.cpp:
70638         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
70639         <http://webkit.org/b/55683>.
70640
70641 2011-03-03  Tony Chang  <tony@chromium.org>
70642
70643         Reviewed by Dimitri Glazkov.
70644
70645         [chromium] Run kill-old-processes on the chromium-win bot too
70646         https://bugs.webkit.org/show_bug.cgi?id=55630
70647
70648         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
70649         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
70650
70651 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
70652
70653         Reviewed by Martin Robinson.
70654
70655         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
70656         https://bugs.webkit.org/show_bug.cgi?id=53960
70657
70658         * DumpRenderTree/gtk/EventSender.cpp:
70659         (sendClick):
70660         (scheduleAsynchronousClickCallback):
70661
70662 2011-03-03  Adam Roben  <aroben@apple.com>
70663
70664         Look for Windows-style paths when checking whether a test is an Inspector test
70665
70666         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
70667         out or crash on Windows 7 Release (WebKit2 Tests)
70668
70669         Reviewed by Darin Adler.
70670
70671         * WebKitTestRunner/TestInvocation.cpp:
70672         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
70673         Windows.
70674
70675 2011-03-03  Adam Roben  <aroben@apple.com>
70676
70677         Make Windows 7 Release (Tests) a core builder
70678
70679         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
70680         give it a few more days of greenness first.
70681
70682         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
70683
70684         Reviewed by Andreas Kling.
70685
70686         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
70687         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
70688
70689         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
70690         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
70691         Updated the core regexps to match the buildbot module. Updated the expected results to match
70692         the current set of core builders.
70693
70694 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
70695
70696         Reviewed by Andreas Kling.
70697
70698         Adding myself as a reviewer.
70699
70700         * Scripts/webkitpy/common/config/committers.py:
70701
70702 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
70703
70704         Reviewed by Xan Lopez.
70705
70706         [GTK] Extended application cache database API and added unit tests file.
70707         https://bugs.webkit.org/show_bug.cgi?id=55335
70708
70709         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
70710         of webkit_application_cache_set_maximum_size due to API exposal.
70711
70712 2011-03-02  Ojan Vafai  <ojan@chromium.org>
70713
70714         Reviewed by Adam Barth.
70715
70716         make webkit-patch upload work for security bugs
70717         https://bugs.webkit.org/show_bug.cgi?id=55655
70718
70719         The problem is that we shell out to prepare-ChangeLog,
70720         which does not authenticate with bugzilla. All it needs from
70721         bugzilla is the bug title though. We just pass it through from
70722         webkit-patch instead.
70723
70724         * Scripts/prepare-ChangeLog:
70725         * Scripts/webkitpy/common/net/bugzilla/bug.py:
70726         * Scripts/webkitpy/tool/steps/preparechangelog.py:
70727
70728 2011-03-01  Ojan Vafai  <ojan@chromium.org>
70729
70730         Reviewed by Tony Chang.
70731
70732         [test-dashboard] make gtest JSON match layout-tests JSON
70733         https://bugs.webkit.org/show_bug.cgi?id=55556
70734
70735         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
70736         Make this code match.
70737
70738         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
70739
70740 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
70741
70742         Reviewed by Tony Chang.
70743
70744         NRWT - implement Linux Hardy 64-bit port support. This involves
70745         adding support for non-'x86' architectures and updating the
70746         "deduplicate_tests" script to correctly understand that
70747         port.name() is not always equal to basename(port.baseline_path()).
70748
70749         This change introduces two new port names: 'chromium-linux-x86'
70750         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
70751         flag will cause the code to determine which one to use at
70752         runtime, just like we currently do with 'chromium-win'.
70753
70754         https://bugs.webkit.org/show_bug.cgi?id=55535
70755
70756         * Scripts/webkitpy/common/system/executive_mock.py:
70757           Handle 'return_stderr' keyword arg to run_command()
70758         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
70759         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
70760         * Scripts/webkitpy/layout_tests/port/base.py:
70761         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
70762         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
70763         * Scripts/webkitpy/layout_tests/port/factory.py:
70764         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
70765
70766 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
70767
70768         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
70769         update symlinks accordingly.
70770
70771         * wx/packaging/build-mac-installer.py:
70772
70773 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
70774
70775         Unreviewed, rolling out r80139.
70776         http://trac.webkit.org/changeset/80139
70777         https://bugs.webkit.org/show_bug.cgi?id=55620
70778
70779         failing and crashing tests on Snow Leopard bot (Requested by
70780         mihaip1 on #webkit).
70781
70782         * DumpRenderTree/LayoutTestController.cpp:
70783         (LayoutTestController::staticFunctions):
70784         * DumpRenderTree/LayoutTestController.h:
70785         * DumpRenderTree/chromium/LayoutTestController.cpp:
70786         (LayoutTestController::LayoutTestController):
70787         * DumpRenderTree/chromium/LayoutTestController.h:
70788         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70789         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
70790         * DumpRenderTree/mac/UIDelegate.h:
70791         * DumpRenderTree/mac/UIDelegate.mm:
70792         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70793         * DumpRenderTree/qt/LayoutTestControllerQt.h:
70794         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
70795         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70796
70797 2011-03-02  Adam Roben  <aroben@apple.com>
70798
70799         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
70800
70801         This matches DumpRenderTree on Windows.
70802
70803         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
70804         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
70805         in WebKit2
70806
70807         Reviewed by Beth Dakin.
70808
70809         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
70810         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
70811         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
70812
70813 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
70814
70815         Reviewed by David Levin.
70816
70817         Add feature define for data transfer items
70818         https://bugs.webkit.org/show_bug.cgi?id=55510
70819
70820         * Scripts/build-webkit:
70821
70822 2011-03-02  Adam Roben  <aroben@apple.com>
70823
70824         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
70825
70826         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
70827         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
70828         the former location, but was getting lucky on some SnowLeopard machines because symlinks
70829         were being created there pointing into DiagnosticReports. For machines without these
70830         symlinks, crash logs were not getting captured.
70831
70832         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
70833         SnowLeopard machines
70834
70835         Reviewed by Eric Seidel.
70836
70837         * Scripts/old-run-webkit-tests:
70838         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
70839
70840 2011-03-02  Adam Roben  <aroben@apple.com>
70841
70842         Don't try to capture crash logs on platforms that haven't implemented that feature
70843
70844         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
70845         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
70846
70847         Reviewed by Joseph Pecoraro.
70848
70849         * Scripts/old-run-webkit-tests:
70850         (captureSavedCrashLog): Bail if we don't have a crash log glob.
70851         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
70852         strictly required to fix bug 55504, but seems worthwhile.
70853
70854 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
70855
70856         Reviewed by Dmitry Titov.
70857
70858         Detach Geolocation from Frame when Page destroyed.
70859         https://bugs.webkit.org/show_bug.cgi?id=52877
70860
70861         Extend the layout test controller to expose the number of pending
70862         geolocation requests, so that we can test that the requests have
70863         been cancelled on page close.
70864
70865         * DumpRenderTree/LayoutTestController.cpp:
70866         (numberOfPendingGeolocationPermissionRequestsCallback):
70867         (LayoutTestController::staticFunctions):
70868         * DumpRenderTree/LayoutTestController.h:
70869         * DumpRenderTree/chromium/LayoutTestController.cpp:
70870         (LayoutTestController::LayoutTestController):
70871         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70872         * DumpRenderTree/chromium/LayoutTestController.h:
70873         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
70874         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70875         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
70876         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70877         * DumpRenderTree/mac/UIDelegate.h:
70878         * DumpRenderTree/mac/UIDelegate.mm:
70879         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
70880         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
70881         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70882         * DumpRenderTree/qt/LayoutTestControllerQt.h:
70883         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
70884         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70885         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
70886         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
70887
70888
70889 2011-03-01  Kent Tamura  <tkent@chromium.org>
70890
70891         Reviewed by Dimitri Glazkov.
70892
70893         Assertion fails when a form validation bubble appears
70894         https://bugs.webkit.org/show_bug.cgi?id=55550
70895
70896         Test: fast/forms/interactive-validation-attach-assertion.html
70897
70898         * DumpRenderTree/chromium/WebPreferences.cpp:
70899         (WebPreferences::applyTo): Enable the interactive validation feature by
70900           default. This matches to Chromium browser.
70901
70902 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
70903
70904         Reviewed by Kent Tamura.
70905
70906         Remove efl port style exception of Webcore/JavaScriptCore
70907         https://bugs.webkit.org/show_bug.cgi?id=55549
70908
70909         WebCore and JavaScriptCore need to adhere WebKit coding style.
70910
70911         * Scripts/webkitpy/style/checker.py:
70912
70913 2011-03-01  Tony Chang  <tony@chromium.org>
70914
70915         Reviewed by Ojan Vafai.
70916
70917         [chromium] clean up temp files on chromium-mac builder too
70918         https://bugs.webkit.org/show_bug.cgi?id=55525
70919
70920         * BuildSlaveSupport/chromium/remove-crash-logs:
70921
70922 2011-02-28  Ojan Vafai  <ojan@chromium.org>
70923
70924         Reviewed by Tony Chang.
70925
70926         wrap json in a function call to afford cross-domain loading
70927         https://bugs.webkit.org/show_bug.cgi?id=55353
70928
70929         Also delete the code that compacts the JSON. It turns out this
70930         breaks the rebaseline tool and is probably a premature optimization anyways.
70931
70932         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
70933         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
70934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
70935         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
70936
70937 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
70938
70939         Unreviewed, rolling out r80079.
70940         http://trac.webkit.org/changeset/80079
70941         https://bugs.webkit.org/show_bug.cgi?id=55547
70942
70943         "Broke the Win debug build?" (Requested by dcheng on #webkit).
70944
70945         * Scripts/build-webkit:
70946
70947 2011-03-01  Mark Rowe  <mrowe@apple.com>
70948
70949         Reviewed by Sam Weinig.
70950
70951         Update verification scripts to handle WebKit2.
70952
70953         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
70954         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
70955         WebKit2.
70956
70957 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
70958
70959         Reviewed by David Levin.
70960
70961         Add feature define for data transfer items
70962         https://bugs.webkit.org/show_bug.cgi?id=55510
70963
70964         * Scripts/build-webkit:
70965
70966 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
70967
70968         Reviewed by Timothy Hatcher.
70969
70970         All Console Messages should be passed to ChromeClients.
70971         https://bugs.webkit.org/show_bug.cgi?id=54926
70972
70973         Update DumpRenderTree's UIDelegate to use the new console message delegate.
70974
70975         * DumpRenderTree/mac/UIDelegate.mm:
70976         (-[UIDelegate webView:addMessageToConsole:withSource:]):
70977
70978 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
70979
70980         Reviewed by Adam Barth.
70981
70982         Tragically, we stopped running the python unit tests
70983         on Chromium Win just as I was getting them to be green.
70984         This patch turns them back on.
70985
70986         https://bugs.webkit.org/show_bug.cgi?id=55521
70987
70988         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
70989
70990 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
70991
70992         Reviewed by Adam Roben.
70993
70994         Disable
70995         webkitpy.common.system.executive_unittest.ExecutiveTest.\
70996            test_kill_all fails on win until it can be properly triaged.
70997
70998         https://bugs.webkit.org/show_bug.cgi?id=54790
70999
71000         * Scripts/webkitpy/common/system/executive_unittest.py:
71001
71002     2011-03-01  Helder Correia  <helder@sencha.com>
71003
71004             Unreviewed. Add myself to committers.py.
71005
71006             * Scripts/webkitpy/common/config/committers.py:
71007
71008 2011-03-01  Adam Roben  <aroben@apple.com>
71009
71010         Give up if a crash log for the web process is taking too long to be saved on Windows
71011
71012         This should keep the bots from getting stuck while waiting for a crash log, if writing a
71013         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
71014
71015         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
71016         to be saved for the web process
71017
71018         Reviewed by Steve Falkenburg.
71019
71020         * WebKitTestRunner/win/TestControllerWin.cpp:
71021         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
71022         Generalized the code slightly to handle the optional object to wait on.
71023         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
71024         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
71025         prevent us from waiting forever.
71026
71027 2011-03-01  Adam Roben  <aroben@apple.com>
71028
71029         Give WebKitLauncherWin's PDB file a name different from WebKit's
71030
71031         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
71032         fighting over the same PDB file, meaning that one of them was going to lose and not have
71033         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
71034
71035         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
71036         runs (due to missing symbols)
71037
71038         Reviewed by David Kilzer.
71039
71040         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
71041         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
71042
71043 2011-03-01  Adam Roben  <aroben@apple.com>
71044
71045         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
71046
71047         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
71048         --exit-after-n-crashes-or-timeouts limit
71049
71050         Reviewed by David Kilzer.
71051
71052         * Scripts/old-run-webkit-tests:
71053         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
71054         the number of tests that caused the web process to crash when exiting early.
71055
71056 2011-03-01  Adam Roben  <aroben@apple.com>
71057
71058         Save a crash log when the web process crashes
71059
71060         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
71061         until it has finished crashing, which guarantees that the crash log will have had time to be
71062         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
71063         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
71064
71065         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
71066         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
71067
71068         Reviewed by Sam Weinig.
71069
71070         * Scripts/old-run-webkit-tests:
71071         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
71072         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
71073         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
71074         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
71075         WebProces_*.crash files when the web process crashes.
71076
71077         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
71078         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
71079         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
71080         along to platformInitialize.
71081
71082         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
71083
71084         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
71085         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
71086
71087         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
71088         (WTR::InjectedBundle::platformInitialize):
71089         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
71090         (WTR::InjectedBundle::platformInitialize):
71091         Updated function signature.
71092
71093         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
71094         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
71095         webProcessCrashingEvent, then lets the crash continue as normal.
71096
71097         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
71098         event we should use to tell the UI process we're crashing from the initializationUserData,
71099         and get a handle to that event.
71100
71101         * WebKitTestRunner/TestController.cpp:
71102         (WTR::TestController::TestController): Initialize new members.
71103         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
71104         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
71105         when a crash log is being saved on Windows. Exit right away if specified. (This is the
71106         default.)
71107
71108         * WebKitTestRunner/TestController.h: Added new members.
71109
71110         * WebKitTestRunner/win/TestControllerWin.cpp:
71111         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
71112         us it's crashing.
71113         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
71114         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
71115         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
71116         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
71117         so the test harness will know the web process has crashed and not try to kill us, then wait
71118         for the web process to finish crashing so a crash log will have time to be saved.
71119         (WTR::toWK): Simple hepler function.
71120         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
71121         process should use to tell us it is crashing in the context's initialization user data.
71122
71123 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
71124
71125         Reviewed by Tony Gentilcore.
71126
71127         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
71128         https://bugs.webkit.org/show_bug.cgi?id=55476
71129
71130         Chromium Win uses BuildAndTestFactory, not TestFactory.
71131
71132         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
71133
71134 2011-03-01  Adam Roben  <aroben@apple.com>
71135
71136         Test that the WebKit2 responsiveness timer doesn't fire too early
71137
71138         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
71139         early on Windows
71140
71141         Reviewed by Anders Carlsson.
71142
71143         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
71144
71145         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
71146         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
71147         (TestWebKitAPI::didFinishLoadForFrame):
71148         (TestWebKitAPI::processDidBecomeUnresponsive):
71149         (TestWebKitAPI::setInjectedBundleClient):
71150         (TestWebKitAPI::setPageLoaderClient):
71151         Simple helper functions.
71152
71153         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
71154         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
71155         the responsiveness timer to start, but the web process should unpause before it has a chance
71156         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
71157
71158         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
71159         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
71160         Call up to the base class.
71161         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
71162         pause, sleep for 0.5 seconds, then send back a message saying we paused.
71163
71164         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
71165         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
71166         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
71167         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
71168
71169         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
71170         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
71171         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
71172         Added new files.
71173
71174 2011-03-01  Andras Becsi  <abecsi@webkit.org>
71175
71176         Reviewed by Csaba Osztrogonác.
71177
71178         [Qt] Clean up the project files and move common options to WebKit.pri.
71179
71180         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
71181
71182
71183 2011-03-01  Adam Roben  <aroben@apple.com>
71184
71185         Skip another multiprocessing test on Windows
71186
71187         It is sometimes failing (and may be leaving child Python processes around).
71188         <http://webkit.org/b/55087> tracks the failure.
71189
71190         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
71191         (FuncitonTests.test_get__processes): Skip this test on Windows.
71192
71193 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
71194
71195         Reviewed by Pavel Feldman.
71196
71197         Web Inspector: reduce inspector tests flakiness.
71198         https://bugs.webkit.org/show_bug.cgi?id=55401
71199
71200         * DumpRenderTree/chromium/TestShell.cpp:
71201         (TestShell::runFileTest):
71202         * DumpRenderTree/chromium/WebPreferences.cpp:
71203         (WebPreferences::reset):
71204
71205 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
71206
71207         Reviewed by James Robinson.
71208
71209         NRWT should still upload results when it exits early due to too many failures
71210         https://bugs.webkit.org/show_bug.cgi?id=55432
71211
71212         Only keyboard interrupts should prevent results from being uploaded.
71213
71214         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
71215         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
71216
71217 2011-02-28  Alice Liu  <alice.liu@apple.com>
71218
71219         Reviewed by Adam Roben and Gavin Barraclough.
71220
71221         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
71222         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
71223
71224         * TestWebKitAPI/InjectedBundleController.h:
71225         (TestWebKitAPI::InjectedBundleController::bundle):
71226         * TestWebKitAPI/PlatformWebView.h:
71227         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
71228         (TestWebKitAPI::didFinishLoadForFrame):
71229         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
71230         (TestWebKitAPI::setPageLoaderClient):
71231         (TestWebKitAPI::TEST):
71232         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
71233         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
71234         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
71235         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
71236         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
71237         (TestWebKitAPI::PlatformWebView::simulateRightClick):
71238         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
71239         (TestWebKitAPI::PlatformWebView::simulateRightClick):
71240
71241         Added files to:
71242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
71243         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
71244         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
71245
71246 2011-02-28  Adam Roben  <aroben@apple.com>
71247
71248         Start running InjectedBundle API tests on Windows
71249
71250         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
71251
71252         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
71253
71254         Reviewed by Darin Adler.
71255
71256         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
71257         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
71258         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
71259         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
71260         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
71261         These are just extracted from TestWebKitAPI.vcproj.
71262
71263         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
71264         up the DLL's filename.
71265
71266         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
71267         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
71268         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
71269
71270         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
71271         "all" configuration.
71272
71273         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
71274         injected bundle tests. Let VS resort things.
71275
71276         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
71277
71278 2011-02-28  Adam Roben  <aroben@apple.com>
71279
71280         Add a test for the paint rect passed via WM_PAINT to windowless plugins
71281
71282         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
71283         Large portions of pages with plugins paint black
71284
71285         Reviewed by Anders Carlsson.
71286
71287         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
71288         (PluginTest::NPP_HandleEvent):
71289         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
71290         Added NPP_HandleEvent. Just returns 0 at this level.
71291
71292         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
71293         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
71294         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
71295         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
71296         WM_PAINT has the expected coordinates.
71297
71298         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
71299         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
71300         else.
71301
71302         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
71303         resort things.
71304
71305         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
71306         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
71307         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
71308         webView:didFinishLoadForFrame:] in DumpRenderTree.
71309
71310         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
71311         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
71312         can start running.
71313
71314 2011-02-28  Adam Roben  <aroben@apple.com>
71315
71316         Tell MiniBrowser's WKViews that they're in a window
71317
71318         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
71319
71320         Reviewed by Anders Carlsson.
71321
71322         * MiniBrowser/win/BrowserView.cpp:
71323         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
71324
71325 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
71326
71327         Reviewed by Csaba Osztrogonác.
71328
71329         The new QML tests require QML_IMPORT_PATH variable to be set in order to
71330         load the proper plugin.
71331
71332         * Scripts/run-qtwebkit-tests:
71333
71334 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
71335
71336         Unreviewed, fix spelling mistake.
71337
71338         hardware-accelated => hardware-accelerated.
71339
71340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
71341
71342 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
71343
71344         Reviewed by Andreas Kling.
71345
71346         Made sure that the build-webkit --qmake argument is always respected.
71347
71348         Previously, it would be respected during the build, but not during
71349         the early feature detection. The build would also fail if qmake was
71350         not in your path, even if you specified --qmake with a valid qmake
71351         binary.
71352
71353         [Qt] WebKit patches required to work with a modularized version of Qt
71354         https://bugs.webkit.org/show_bug.cgi?id=53916
71355
71356         * Scripts/build-webkit:
71357         * Scripts/webkitdirs.pm:
71358
71359 2011-02-27  Ojan Vafai  <ojan@chromium.org>
71360
71361         Fix failing tests from http://trac.webkit.org/changeset/79837.
71362
71363         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
71364         This was just a mistake that would break if someone tried printing with this configuration.
71365         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
71366         Method signature changed. Didn't notice that this method was being calling in a unittest.
71367
71368 2011-02-24  Hayato Ito  <hayato@chromium.org>
71369
71370         Reviewed by Eric Seidel.
71371
71372         [NRWT] Remove test_types/* classes.
71373
71374         This is the last patch in the series of efforts which tried to remove test_types classes.
71375         A single_test_runner module will take over responsibilities of test_type classes.
71376
71377         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
71378
71379         https://bugs.webkit.org/show_bug.cgi?id=55123
71380
71381         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
71382         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
71383         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
71384         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
71385         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
71386         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
71387         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
71388         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
71389         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
71390         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
71391
71392 2011-02-25  Ojan Vafai  <ojan@chromium.org>
71393
71394         Reviewed by Tony Chang.
71395
71396         Change results.json format to the one used by unexpected_results.json
71397         https://bugs.webkit.org/show_bug.cgi?id=52267
71398
71399         Also add runtimes in milliseconds to the JSON and make the output format more compact.
71400         Named the file full_results.json to avoid conflicting with the results.json
71401         file the test-results server currently serves up.
71402
71403         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
71404         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
71405         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
71406         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
71407         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
71408         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
71409
71410 2011-02-27  Adam Roben  <aroben@apple.com>
71411
71412         Followup fix to r79827
71413
71414         * DumpRenderTree/win/UIDelegate.cpp:
71415         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
71416         lastPathComponent. This matches what we did here before r79827, and matches Mac.
71417
71418 2011-02-27  Dan Bernstein  <mitz@apple.com>
71419
71420         Reviewed by Adam Roben.
71421
71422         Make bisect-builds print a trac link for the regression range
71423         https://bugs.webkit.org/show_bug.cgi?id=55331
71424
71425         * Scripts/bisect-builds:
71426
71427 2011-02-27  Adam Roben  <aroben@apple.com>
71428
71429         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
71430
71431         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
71432         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
71433         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
71434
71435         Reviewed by Anders Carlsson.
71436
71437         * DumpRenderTree/win/EditingDelegate.cpp:
71438         (indexOfFirstWordCharacter):
71439         (wordLength):
71440         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
71441
71442 2011-02-27  Adam Roben  <aroben@apple.com>
71443
71444         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
71445
71446         This matches Mac. (In fact, the code was ported from Mac!)
71447
71448         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
71449         match Mac
71450
71451         Reviewed by Anders Carlsson.
71452
71453         * DumpRenderTree/win/DumpRenderTree.cpp:
71454         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
71455         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
71456         _drt_descriptionSuitableForTestResult].
71457         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
71458
71459         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
71460
71461         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
71462         DumpRenderTree.cpp.
71463
71464 2011-02-27  Adam Roben  <aroben@apple.com>
71465
71466         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
71467
71468         This makes Bugzilla autocompletion work correctly.
71469
71470         * Scripts/webkitpy/common/config/committers.py:
71471
71472 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
71473
71474         Reviewed by Andreas Kling.
71475
71476         [Qt] fast/loader/user-stylesheet-fast-path.html fails
71477         https://bugs.webkit.org/show_bug.cgi?id=50911
71478
71479         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
71480         (LayoutTestController::setUserStyleSheetLocation):
71481         Use QUrl::fromEncoded since the passed string is already encoded.
71482
71483 2011-02-27  Adam Roben  <aroben@apple.com>
71484
71485         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
71486
71487         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
71488         is different from old-run-webkit-test's. Because of this, the path to the crash log file
71489         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
71490         details.
71491
71492         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
71493         --results-directory path is used (like on the test slaves)
71494
71495         Reviewed by Dan Bernstein.
71496
71497         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
71498         made $testResultsDirectory an absolute path.
71499
71500 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
71501
71502         Reviewed by Adam Barth.
71503
71504         m_dumpAccessibilityNotifications should be initialized.
71505         https://bugs.webkit.org/show_bug.cgi?id=54874
71506
71507         * DumpRenderTree/chromium/AccessibilityController.cpp:
71508         (AccessibilityController::AccessibilityController):
71509
71510 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
71511
71512         Reviewed by Pavel Feldman.
71513
71514         DumpRenderTree should reset frame opener between tests.
71515         https://bugs.webkit.org/show_bug.cgi?id=54874
71516
71517         Added clearOpener() calls between tests.
71518         Some tests are using window.open() to change current window location.
71519         This changes window.opener property whose nullity is checked before
71520         showing xml viewer.
71521
71522         * DumpRenderTree/chromium/TestShell.cpp:
71523         (TestShell::resetTestController):
71524         * DumpRenderTree/gtk/DumpRenderTree.cpp:
71525         (resetDefaultsToConsistentValues):
71526         * DumpRenderTree/mac/DumpRenderTree.mm:
71527         (resetWebViewToConsistentStateBeforeTesting):
71528         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
71529         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
71530         * DumpRenderTree/win/DumpRenderTree.cpp:
71531         (resetWebViewToConsistentStateBeforeTesting):
71532         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
71533         (WTR::InjectedBundlePage::reset):
71534
71535 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
71536
71537         Reviewed by Andreas Kling.
71538
71539         [Qt] Fix the focus in MiniBrowser.
71540         https://bugs.webkit.org/show_bug.cgi?id=55288
71541
71542         Give focus to the web view when a load starts.
71543
71544         * MiniBrowser/qt/BrowserWindow.cpp:
71545         (BrowserWindow::urlChanged):
71546
71547 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
71548
71549         Reviewed by Adam Barth.
71550
71551         [EFL] Add coding style exceptions for EFL port
71552         https://bugs.webkit.org/show_bug.cgi?id=54733
71553
71554         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
71555         underscore-sparated values. But, style checking rule have found parameter_name errors
71556         in efl directories so far.
71557
71558         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
71559
71560 2011-02-26  David Levin  <levin@chromium.org>
71561
71562         Reviewed by Darin Adler.
71563
71564         check-webkit-style should check for spaces after periods in comments
71565         https://bugs.webkit.org/show_bug.cgi?id=55253
71566
71567         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
71568         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
71569           and fixed the name of one related test.
71570
71571 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
71572
71573         Reviewed by Andreas Kling.
71574
71575         Make it possible to test the targetdensity-dpi support
71576         https://bugs.webkit.org/show_bug.cgi?id=55142
71577
71578         Test the viewport meta tag feature targetdensity-dpi by
71579         adding extra arguments to dumpConfigurationForViewport
71580
71581         Add the new arguments to the shared header and all
71582         implementation.
71583
71584         * DumpRenderTree/LayoutTestController.cpp:
71585         (dumpConfigurationForViewportCallback):
71586         * DumpRenderTree/LayoutTestController.h:
71587         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
71588         (LayoutTestController::dumpConfigurationForViewport):
71589         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
71590         (LayoutTestController::dumpConfigurationForViewport):
71591         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
71592         (LayoutTestController::dumpConfigurationForViewport):
71593         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
71594         (LayoutTestController::dumpConfigurationForViewport):
71595         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
71596         (LayoutTestController::dumpConfigurationForViewport):
71597         * DumpRenderTree/qt/LayoutTestControllerQt.h:
71598
71599 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
71600
71601         Unreviewed, rolling out r79764.
71602         http://trac.webkit.org/changeset/79764
71603         https://bugs.webkit.org/show_bug.cgi?id=55295
71604
71605         "broke Chromium builds" (Requested by rniwa on #webkit).
71606
71607         * DumpRenderTree/chromium/TestShell.cpp:
71608         (TestShell::resetTestController):
71609         * DumpRenderTree/gtk/DumpRenderTree.cpp:
71610         (resetDefaultsToConsistentValues):
71611         * DumpRenderTree/mac/DumpRenderTree.mm:
71612         (resetWebViewToConsistentStateBeforeTesting):
71613         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
71614         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
71615         * DumpRenderTree/win/DumpRenderTree.cpp:
71616         (resetWebViewToConsistentStateBeforeTesting):
71617         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
71618         (WTR::InjectedBundlePage::reset):
71619
71620 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
71621
71622         Reviewed by David Kilzer.
71623
71624         https://bugs.webkit.org/show_bug.cgi?id=48781
71625
71626         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
71627
71628         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
71629         should paint the default broken image when an image fails to load or decode.
71630
71631         * DumpRenderTree/LayoutTestController.cpp:
71632         (LayoutTestController::LayoutTestController):
71633         (setShouldPaintBrokenImageCallback):
71634         (LayoutTestController::staticFunctions):
71635         (LayoutTestController::setShouldPaintBrokenImage):
71636         * DumpRenderTree/LayoutTestController.h:
71637         (LayoutTestController::shouldPaintBrokenImage):
71638         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
71639         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
71640
71641 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
71642
71643         Reviewed by Pavel Feldman.
71644
71645         DumpRenderTree should reset frame opener between tests.
71646         https://bugs.webkit.org/show_bug.cgi?id=54874
71647
71648         Added clearOpener() calls between tests.
71649         Some tests are using window.open() to change current window location.
71650         This changes window.opener property whose nullity is checked before
71651         showing xml viewer.
71652
71653         * DumpRenderTree/chromium/TestShell.cpp:
71654         (TestShell::resetTestController):
71655         * DumpRenderTree/gtk/DumpRenderTree.cpp:
71656         (resetDefaultsToConsistentValues):
71657         * DumpRenderTree/mac/DumpRenderTree.mm:
71658         (resetWebViewToConsistentStateBeforeTesting):
71659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
71660         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
71661         * DumpRenderTree/win/DumpRenderTree.cpp:
71662         (resetWebViewToConsistentStateBeforeTesting):
71663         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
71664         (WTR::InjectedBundlePage::reset):
71665
71666 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
71667
71668         Reviewed by Kenneth Rohde Christiansen.
71669
71670         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
71671         https://bugs.webkit.org/show_bug.cgi?id=54809
71672
71673         * EWebLauncher/main.c: Handling -f option added.
71674         (on_key_down):
71675         (browserCreate):
71676         (main):
71677
71678 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
71679
71680         Unreviewed, rolling out r79324.
71681         http://trac.webkit.org/changeset/79324
71682         https://bugs.webkit.org/show_bug.cgi?id=55260
71683
71684         Leopard Debug is once again running out of address space while
71685         linking (Requested by aroben on #webkit).
71686
71687         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
71688         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
71689
71690 2011-02-25  Tony Chang  <tony@chromium.org>
71691
71692         Reviewed by James Robinson.
71693
71694         Clean up temp files left by crashing DRTs on chromium-win
71695         https://bugs.webkit.org/show_bug.cgi?id=55182
71696
71697         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
71698         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
71699
71700 2011-02-25  Adam Roben  <aroben@apple.com>
71701
71702         Double-check that modifying the registry worked
71703
71704         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
71705         still return a successful exit code. So we double-check here that the value we tried to
71706         write to the registry was really written.
71707
71708         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
71709         logs on Windows Vista/7
71710
71711         Reviewed by Darin Adler.
71712
71713         * Scripts/old-run-webkit-tests:
71714         (writeRegistryString): After trying to write the string value, check that it was really
71715         written.
71716
71717 2011-02-25  Adam Roben  <aroben@apple.com>
71718
71719         Set the 32-bit post-mortem debugger on 64-bit OSes
71720
71721         The post-mortem debugger is controlled by some registry values in
71722         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
71723         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
71724         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
71725         WebKitTestRunner are 32-bit, we want to use the latter location.
71726
71727         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
71728         64-bit apps, but should set it for 32-bit apps instead
71729
71730         Reviewed by Darin Adler.
71731
71732         * Scripts/old-run-webkit-tests:
71733         (readRegistryString):
71734         (writeRegistryString):
71735         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
71736         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
71737         Passing --wow32 on a 32-bit OS will not have any effect.
71738
71739 2011-02-25  Adam Roben  <aroben@apple.com>
71740
71741         Clean up code to set up crash log saving on Windows
71742
71743         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
71744
71745         Reviewed by David Kilzer.
71746
71747         * Scripts/old-run-webkit-tests:
71748         (readRegistryString):
71749         (writeRegistryString):
71750         Moved code to read strings from and write strings to the registry here...
71751
71752         (setUpWindowsCrashLogSaving): ...from here.
71753
71754 2011-02-25  Adam Roben  <aroben@apple.com>
71755
71756         Work around Cygwin's crash-suppression behavior
71757
71758         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
71759         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
71760         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
71761         when our test apps launch to work around Cygwin's behavior.
71762
71763         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
71764         debugger) when launched from Cygwin 1.7
71765
71766         Reviewed by Darin Adler.
71767
71768         * DumpRenderTree/win/DumpRenderTree.cpp:
71769         (main):
71770         * TestWebKitAPI/win/main.cpp:
71771         (main):
71772         * WebKitAPITest/main.cpp:
71773         (main):
71774         * WebKitTestRunner/win/TestControllerWin.cpp:
71775         (WTR::TestController::platformInitialize):
71776         Call ::SetErrorMode(0) to undo Cygwin's folly.
71777
71778 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
71779
71780         Reviewed by Andreas Kling.
71781
71782         [Qt] Revert the support for QNAM affined to a different thread.
71783         https://bugs.webkit.org/show_bug.cgi?id=55149
71784
71785         Qt 4.8 will have QNAM use its own thread internally by default,
71786         no need to keep this complexity in WebKit.
71787
71788         This mainly reverts:
71789         http://trac.webkit.org/changeset/73710
71790         http://trac.webkit.org/changeset/73712
71791
71792         * QtTestBrowser/launcherwindow.cpp:
71793         (LauncherWindow::~LauncherWindow):
71794         (LauncherWindow::initializeView):
71795         (LauncherWindow::createChrome):
71796         * QtTestBrowser/launcherwindow.h:
71797         (WindowOptions::WindowOptions):
71798         * QtTestBrowser/webpage.cpp:
71799         (WebPage::WebPage):
71800         * QtTestBrowser/webpage.h:
71801
71802 2011-02-24  Adam Barth  <abarth@webkit.org>
71803
71804         Reviewed by Eric Seidel.
71805
71806         Add a script for creating gypi files
71807         https://bugs.webkit.org/show_bug.cgi?id=55113
71808
71809         This is a trivial script to create gypi files from the source code in
71810         the current directory.
71811
71812         * Scripts/make-gypi: Added.
71813
71814 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
71815
71816         Unreviewed, rolling out r79628.
71817         http://trac.webkit.org/changeset/79628
71818         https://bugs.webkit.org/show_bug.cgi?id=55195
71819
71820         "broke chromium win tests" (Requested by dpranke on #webkit).
71821
71822         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
71823         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
71824
71825 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
71826
71827         Reviewed by Mihai Parparita.
71828
71829         rebaseline-chromium-webkit-tests can't handle GPU variants
71830         https://bugs.webkit.org/show_bug.cgi?id=55002
71831
71832         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
71833         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
71834
71835 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
71836
71837         Reviewed by Mihai Parparita.
71838
71839         nrwt: log command used to start web server to --verbose
71840
71841         https://bugs.webkit.org/show_bug.cgi?id=55188
71842
71843         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
71844         * Scripts/webkitpy/layout_tests/port/http_server.py:
71845
71846 2011-02-24  Victoria Kirst  <vrk@google.com>
71847
71848         Reviewed by Mihai Parparita.
71849
71850         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
71851         https://bugs.webkit.org/show_bug.cgi?id=55089
71852
71853         This adds an alias into the media/ directory so that http/tests/media
71854         tests can access the media resources when running in an httpd process.
71855
71856         * Scripts/webkitperl/httpd.pm:
71857         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
71858         * Scripts/webkitpy/layout_tests/port/http_server.py:
71859
71860 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
71861
71862         Reviewed by Mihai Parparita.
71863
71864         nrwt: enable multiple processes by default on Chromium Win.
71865
71866         https://bugs.webkit.org/show_bug.cgi?id=55163
71867
71868         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
71869         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
71870
71871 2011-02-24  Sam Weinig  <sam@webkit.org>
71872
71873         Attempt to fix Qt.
71874
71875         * WebKitTestRunner/TestInvocation.cpp:
71876
71877 2011-02-24  James Robinson  <jamesr@chromium.org>
71878
71879         Unreviewed, rolling out r79598.
71880         http://trac.webkit.org/changeset/79598
71881         https://bugs.webkit.org/show_bug.cgi?id=55089
71882
71883         Appears to be causing trouble with httpd on windows
71884
71885         * Scripts/webkitperl/httpd.pm:
71886         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
71887         * Scripts/webkitpy/layout_tests/port/http_server.py:
71888
71889 2011-02-24  Sam Weinig  <sam@webkit.org>
71890
71891         Reviewed by Darin Adler.
71892
71893         Add basic pixel testing support to WebKitTestRunner
71894         https://bugs.webkit.org/show_bug.cgi?id=55161
71895
71896         * Scripts/old-run-webkit-tests:
71897         Don't print color space information when using WebKitTestRunner since
71898         we don't need to change the screen.
71899
71900         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
71901         (WTR::InjectedBundle::initialize):
71902         Add call to initializePlatformDefaults.
71903
71904         (WTR::InjectedBundle::done):
71905         Return a dictionary on completion with both the text output and pixel dump override.
71906
71907         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
71908         Add declaration for initializePlatformDefaults.
71909
71910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
71911         (WTR::LayoutTestController::LayoutTestController):
71912         (WTR::LayoutTestController::dumpAsText):
71913         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
71914         (WTR::LayoutTestController::shouldDumpPixels):
71915         Make setting dumpAsText override the dump pixels preference.
71916
71917         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
71918         (WTR::InjectedBundle::initializePlatformDefaults):
71919         Set platform defaults matching DumpRenderTree.
71920
71921         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
71922         (WTR::InjectedBundle::initializePlatformDefaults):
71923         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
71924         (WTR::InjectedBundle::initializePlatformDefaults):
71925         Add stubs for initializePlatformDefaults.
71926
71927         * WebKitTestRunner/TestController.cpp:
71928         (WTR::TestController::runTest):
71929         (WTR::TestController::runTestingServerLoop):
71930         (WTR::TestController::run):
71931         Parse expected pixel results out of stdin and setup the invocation with it.
71932
71933         * WebKitTestRunner/TestInvocation.cpp:
71934         (WTR::TestInvocation::TestInvocation):
71935         Initialize new members.
71936
71937         (WTR::TestInvocation::~TestInvocation):
71938         (WTR::TestInvocation::setIsPixelTest):
71939         (WTR::sizeWebViewForCurrentTest):
71940         (WTR::TestInvocation::invoke):
71941         (WTR::TestInvocation::dump):
71942         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
71943         * WebKitTestRunner/TestInvocation.h:
71944         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
71945
71946         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
71947         (WTR::PlatformWebView::PlatformWebView):
71948         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
71949
71950         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
71951         (WTR::createCGContextFromPlatformView):
71952         (WTR::computeMD5HashStringForContext):
71953         (WTR::dumpBitmap):
71954         (WTR::forceRepaintFunction):
71955         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
71956         Add mac specific pixel dumping support. Right now, we always pull pixels
71957         from the window server.
71958
71959         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
71960         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
71961         * WebKitTestRunner/qt/WebKitTestRunner.pro:
71962         * WebKitTestRunner/win/InjectedBundle.vcproj:
71963         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
71964         Add new files.
71965
71966 2011-02-24  Chang Shu  <cshu@webkit.org>
71967
71968         Reviewed by Kenneth Rohde Christiansen.
71969
71970         [Qt] Launch MiniBrowser if the test run is WebKit2.
71971         https://bugs.webkit.org/show_bug.cgi?id=55145
71972
71973         * Scripts/old-run-webkit-tests:
71974         * Scripts/run-launcher:
71975         * Scripts/webkitdirs.pm:
71976
71977 2011-02-24  Victoria Kirst  <vrk@google.com>
71978
71979         Reviewed by Mihai Parparita.
71980
71981         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
71982         https://bugs.webkit.org/show_bug.cgi?id=55089
71983
71984         This adds an alias into the media/ directory so that http/tests/media
71985         tests can access the media resources when running in an httpd process.
71986
71987         * Scripts/webkitperl/httpd.pm:
71988         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
71989         * Scripts/webkitpy/layout_tests/port/http_server.py:
71990
71991 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
71992
71993         Unreviewed, rolling out r79570.
71994         http://trac.webkit.org/changeset/79570
71995         https://bugs.webkit.org/show_bug.cgi?id=54874
71996
71997         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
71998         was not updated
71999
72000         * DumpRenderTree/chromium/TestShell.cpp:
72001         (TestShell::resetTestController):
72002         * DumpRenderTree/gtk/DumpRenderTree.cpp:
72003         (resetDefaultsToConsistentValues):
72004         * DumpRenderTree/mac/DumpRenderTree.mm:
72005         (resetWebViewToConsistentStateBeforeTesting):
72006         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
72007         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
72008         * DumpRenderTree/win/DumpRenderTree.cpp:
72009         (resetWebViewToConsistentStateBeforeTesting):
72010         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
72011         (WTR::InjectedBundlePage::reset):
72012
72013 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
72014
72015         Reviewed by Laszlo Gombos.
72016
72017         [Qt] add android 2.2 user agent to QtTestBrowser
72018         https://bugs.webkit.org/show_bug.cgi?id=55085
72019
72020         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
72021         * QtTestBrowser/useragentlist.txt:
72022
72023 2011-02-24  Adam Roben  <aroben@apple.com>
72024
72025         Change FrameLoadDelegate to support any number of delegates with delayed work to process
72026
72027         This makes our behavior match Mac more closely, and allows us to remove an incorrect
72028         assertion that was firing during some tests. (The assertion was claiming that there was
72029         never more than one delegate with delayed work to process, but that was not the case.)
72030
72031         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
72032         when running http/tests/navigation/back-twice-without-commit.html
72033
72034         Reviewed by Eric Carlson.
72035
72036         * DumpRenderTree/win/FrameLoadDelegate.cpp:
72037         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
72038         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
72039         single delegate may have multiple performSelector requests).
72040         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
72041         assertion that the timer firing is the shared process work timer. Instead of using the
72042         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
72043         work to process a chance to process their work.
72044         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
72045         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
72046         Vector so our processWork function will be called when the timer fires.
72047
72048 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
72049
72050         Reviewed by Alexey Proskuryakov.
72051
72052         DumpRenderTree should reset frame opener between tests.
72053         https://bugs.webkit.org/show_bug.cgi?id=54874
72054
72055         Added clearOpener() calls between tests.
72056         Some tests are using window.open() to change current window location.
72057         This changes window.opener property whose nullity is checked before
72058         showing xml viewer.
72059
72060         * DumpRenderTree/chromium/TestShell.cpp:
72061         (TestShell::resetTestController):
72062         * DumpRenderTree/gtk/DumpRenderTree.cpp:
72063         (resetDefaultsToConsistentValues):
72064         * DumpRenderTree/mac/DumpRenderTree.mm:
72065         (resetWebViewToConsistentStateBeforeTesting):
72066         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
72067         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
72068         * DumpRenderTree/win/DumpRenderTree.cpp:
72069         (resetWebViewToConsistentStateBeforeTesting):
72070         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
72071         (WTR::InjectedBundlePage::reset):
72072
72073 2011-02-24  Adam Roben  <aroben@apple.com>
72074
72075         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
72076
72077         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
72078         but did
72079
72080         Reviewed by Anders Carlsson.
72081
72082         * Scripts/webkitpy/common/config/build.py:
72083         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
72084         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
72085
72086         * Scripts/webkitpy/common/config/build_unittest.py:
72087         (ShouldBuildTest): Added some more tests.
72088
72089 2011-02-24  Andras Becsi  <abecsi@webkit.org>
72090
72091         Reviewed by Laszlo Gombos.
72092
72093         [Qt] MinGW build fails to link
72094         https://bugs.webkit.org/show_bug.cgi?id=55050
72095
72096         Prepend the libraries of subcomponents instead of appending them
72097         to fix the library order according to the dependency of the libraries
72098
72099         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
72100         * WebKitTestRunner/qt/WebKitTestRunner.pro:
72101
72102 2011-02-24  Gabor Loki  <loki@webkit.org>
72103
72104         Reviewed by Csaba Osztrogonác.
72105
72106         [Qt] Remove ARMv5 Release buildbot.
72107
72108         Remove ARMv5 Release buildbot, because there is very little difference
72109         between ARMv5 and ARMv7 Release bots, and there is also very little
72110         interest in ARMv5 build slave (compared to ARMv7).
72111
72112         * BuildSlaveSupport/build.webkit.org-config/config.json:
72113         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
72114
72115 2011-02-22  Ojan Vafai  <ojan@chromium.org>
72116
72117         Reviewed by Tony Chang.
72118
72119         fix revision number finding when creating git patches
72120         https://bugs.webkit.org/show_bug.cgi?id=55024
72121
72122         HEAD~n does not walk merge commits correctly. git log however does.
72123
72124         * Scripts/webkitpy/common/checkout/scm.py:
72125         * Scripts/webkitpy/common/checkout/scm_unittest.py:
72126
72127 2011-02-23  Kenneth Russell  <kbr@google.com>
72128
72129         Unreviewed, rolling out r79387.
72130         https://bugs.webkit.org/show_bug.cgi?id=54885
72131
72132         Reapply the code changes from r79038 since they weren't the root
72133         cause of the test timeouts.
72134
72135         * DumpRenderTree/chromium/WebViewHost.cpp:
72136         (WebViewHost::reset):
72137
72138 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
72139
72140         Reviewed by Laszlo Gombos.
72141
72142         [Qt] Make sure Symbian binary UIDs are unique
72143
72144         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
72145         QtTestBrowser.pro by changing the UID.
72146
72147 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
72148
72149         Reviewed by Darin Adler.
72150
72151         Rename PLATFORM(CF) to USE(CF)
72152         https://bugs.webkit.org/show_bug.cgi?id=53540
72153
72154         * DumpRenderTree/config.h:
72155
72156 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
72157
72158         Reviewed by Ojan Vafai.
72159
72160         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
72161         https://bugs.webkit.org/show_bug.cgi?id=55016
72162
72163         * Scripts/webkitpy/layout_tests/port/base.py:
72164         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
72165         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
72166         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72167         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
72168         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
72169         * Scripts/webkitpy/layout_tests/port/mac.py:
72170         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
72171         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
72172         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
72173
72174 2011-02-23  Tony Chang  <tony@chromium.org>
72175
72176         Reviewed by Kent Tamura.
72177
72178         [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
72179         https://bugs.webkit.org/show_bug.cgi?id=55004
72180
72181         * DumpRenderTree/chromium/DumpRenderTree.cpp:
72182         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
72183         (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
72184         (main): Use a C++ object to ensure that TearDownTestEnvironment
72185             gets called when --check-layout-test-sys-deps is called
72186
72187 2011-02-23  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
72188
72189         Reviewed by Anders Carlsson.
72190
72191         [Qt] [Qt] check webkit style fails in qt/tests
72192         https://bugs.webkit.org/show_bug.cgi?id=54998
72193
72194         check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
72195
72196         * Scripts/webkitpy/style/checker.py:
72197
72198 2011-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
72199
72200         Reviewed by Pavel Feldman.
72201
72202         DumpRenderTree should dump as text if test path contains "dumpAsText/"
72203         https://bugs.webkit.org/show_bug.cgi?id=54873
72204
72205         * DumpRenderTree/chromium/LayoutTestController.h:
72206         (LayoutTestController::setShouldDumpAsText):
72207         (LayoutTestController::setShouldGeneratePixelResults):
72208         * DumpRenderTree/chromium/TestShell.cpp:
72209         (TestShell::runFileTest):
72210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
72211         (shouldDumpAsText):
72212         (dump):
72213         (runTest):
72214         * DumpRenderTree/mac/DumpRenderTree.mm:
72215         (shouldDumpAsText):
72216         (runTest):
72217         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
72218         (WebCore::isDumpAsTextTest):
72219         (WebCore::DumpRenderTree::open):
72220         * DumpRenderTree/win/DumpRenderTree.cpp:
72221         (shouldDumpAsText):
72222         (runTest):
72223         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
72224         (WTR::InjectedBundlePage::dump):
72225
72226 2011-02-22  Kenneth Russell  <kbr@google.com>
72227
72228         Reviewed by James Robinson.
72229
72230         Many tests started timing out on the chrome mac canaries around r79035
72231         https://bugs.webkit.org/show_bug.cgi?id=54885
72232
72233         Revert the code changes, but not the Chromium DEPS roll, from
72234         r79038 to see whether this clears up the timing-out tests. Was not
72235         able to reproduce the timeouts locally with a Release mode build
72236         of DRT (on Snow Leopard).
72237
72238         * DumpRenderTree/chromium/WebViewHost.cpp:
72239         (WebViewHost::reset):
72240
72241 2011-02-22  Dirk Pranke  <dpranke@chromium.org>
72242
72243         Reviewed by James Robinson.
72244
72245         nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
72246         https://bugs.webkit.org/show_bug.cgi?id=55009
72247
72248         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
72249
72250 2011-02-18  Mihai Parparita  <mihaip@chromium.org>
72251
72252         Reviewed by Ojan Vafai.
72253
72254         Default to 500 for --exit-after-n-failures
72255         https://bugs.webkit.org/show_bug.cgi?id=54773
72256
72257         Make 500 the default value for --exit-after-n-failures (ORWT bots
72258         already default to this as of r75726). Similarly, change the default for
72259         --exit-after-n-crashes-or-timeouts to 20.
72260
72261         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
72262
72263 2011-02-02  Martin Robinson  <mrobinson@igalia.com>
72264
72265         Reviewed by Xan Lopez.
72266
72267         [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
72268         https://bugs.webkit.org/show_bug.cgi?id=53603
72269
72270         Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
72271         to DumpRenderTreeSupportGtk for this functionality.
72272
72273         * DumpRenderTree/gtk/DumpRenderTree.cpp:
72274         (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
72275         false when reseting values between tests.
72276         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
72277         (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
72278         with the appropriate value.
72279
72280 2011-02-22  Adam Roben  <aroben@apple.com>
72281
72282         Don't trigger a Windows build when the top-level ChangeLog changes
72283
72284         r79320 is an example of a change that shouldn't have built on Windows, but did, because of
72285         this bug.
72286
72287         Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
72288         shouldn't
72289
72290         Reviewed by Anders Carlsson.
72291
72292         * Scripts/webkitpy/common/config/build.py:
72293         (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
72294         ChangeLog, and re-sorted it in the list.
72295
72296         * Scripts/webkitpy/common/config/build_unittest.py:
72297         (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
72298
72299 2011-02-22  Sheriff Bot  <webkit.review.bot@gmail.com>
72300
72301         Unreviewed, rolling out r78691.
72302         http://trac.webkit.org/changeset/78691
72303         https://bugs.webkit.org/show_bug.cgi?id=54956
72304
72305         Leopard Debug is successfully building again (Requested by
72306         aroben on #webkit).
72307
72308         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
72309         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
72310
72311 2011-02-22  Ilya Tikhonovsky  <loislo@chromium.org>
72312
72313         Reviewed by Pavel Feldman.
72314
72315         Web Inspector: flakyness of inspector tests.
72316         https://bugs.webkit.org/show_bug.cgi?id=54729
72317
72318         As far as we have the protocol with sequence numbers we can simplify test harness support
72319         and drop out chomium specific methods.
72320
72321         * DumpRenderTree/DumpRenderTree.gypi:
72322         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
72323         (DRTDevToolsAgent::sendMessageToInspectorFrontend):
72324         (DRTDevToolsAgent::runtimePropertyChanged):
72325         (DRTDevToolsAgent::asyncCall):
72326         (DRTDevToolsAgent::call):
72327         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
72328         * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
72329         * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
72330         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
72331         (DRTDevToolsClient::sendMessageToBackend):
72332         (DRTDevToolsClient::asyncCall):
72333         (DRTDevToolsClient::call):
72334         * DumpRenderTree/chromium/DRTDevToolsClient.h:
72335
72336 2011-02-22  Andras Becsi  <abecsi@webkit.org>
72337
72338         Reviewed by Laszlo Gombos.
72339
72340         [Qt] Redesign the build system
72341         https://bugs.webkit.org/show_bug.cgi?id=51339
72342
72343         Part 2.
72344
72345         Build WebCore as a static library, compile the WebKit API and WebKit2 API
72346         in a final step and link to WebKit2, WebCore and JSC libraries to fix
72347         linking issues resulting from stripped away symbols.
72348
72349         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
72350
72351 2011-02-21  Lukasz Slachciak  <l.slachciak@samsung.com>
72352
72353         Reviewed by Antonio Gomes.
72354
72355         [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
72356         https://bugs.webkit.org/show_bug.cgi?id=54806
72357
72358         * EWebLauncher/main.c:
72359         (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
72360
72361 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
72362
72363         Reviewed by Kent Tamura.
72364
72365         nrwt: revert behavior on 10.5 to "old-threads". It's possible
72366         that r79062 has introduced a bunch of flakiness, although I
72367         can't explain why right now. This change should restore the
72368         old behavior, and then we can look at the build logs to see
72369         if the tests stop timing out or being flaky.
72370
72371         https://bugs.webkit.org/show_bug.cgi?id=54925
72372
72373         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72374         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
72375         * Scripts/webkitpy/layout_tests/port/mac.py:
72376         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
72377
72378 2011-02-21  Dirk Pranke  <dpranke@chromium.org>
72379
72380         Reviewed by Dimitri Glazkov.
72381
72382         nrwt: fix typo causing us to try and repeatedly shut down the servers
72383         https://bugs.webkit.org/show_bug.cgi?id=54904
72384
72385         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
72386
72387 2011-02-21  Alejandro G. Castro  <alex@igalia.com>
72388
72389         Reviewed by Csaba Osztrogonác.
72390
72391         REGRESSION(r79157):
72392         plugins/get-url-with-javascript-destroying-plugin.html make the
72393         next test crash
72394         https://bugs.webkit.org/show_bug.cgi?id=54863
72395
72396         * GNUmakefile.am:
72397
72398 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
72399
72400         Reviewed by Ojan Vafai.
72401
72402         test-webkitpy: stop skipping a bunch of tests on win32
72403         https://bugs.webkit.org/show_bug.cgi?id=54788
72404
72405         * Scripts/webkitpy/common/net/testoutputset_unittest.py:
72406         * Scripts/webkitpy/test/main.py:
72407
72408 2011-02-20  Dirk Pranke  <dpranke@chromium.org>
72409
72410         Reviewed by Ojan Vafai.
72411
72412         Fix various bugs related to handling of dir separators and real
72413         vs. fake filesystems that were causing test-webkitpy to fail
72414         tests on win32. These bugs have a variety of causes but are
72415         lumped together because they should be easy to review.
72416
72417         https://bugs.webkit.org/show_bug.cgi?id=54700
72418
72419         * Scripts/webkitpy/common/net/testoutput.py:
72420           Here we were using os.path.sep but not escaping it prior to
72421           using in a regexp, which  caused bad things on win32.
72422         * Scripts/webkitpy/common/net/testoutput_unittest.py:
72423           Same here.
72424         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
72425           Here we were using the native filesystem instead of the mock
72426           filesystem, making some tests unnecessarily platform dependent.
72427           Also we weren't setting the default configuration for the
72428           TestChromiumWinPort.
72429         * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
72430           Here we *shouldn't* use os.path.join(), just so the code becomes
72431           less platform dependent.
72432         * Scripts/webkitpy/style/checker.py:
72433           Here we should be using os.path.sep instead of "/"; the tests
72434           require the native filesystem.
72435         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
72436           Here the underlying code is using os.path.sep, so we probably
72437           should as well.
72438         * Scripts/webkitpy/style/test_expectations_unittest.py:
72439           Here we should be using the filesystem hanging of the port
72440           object (which is the mocked filesystem) rather than the native
72441           one.
72442
72443 2011-02-20  Anders Carlsson  <andersca@apple.com>
72444
72445         Reviewed by Maciej Stachowiak.
72446
72447         Crash when a plug-in requests a javascript: url that destroys the plug-in
72448         https://bugs.webkit.org/show_bug.cgi?id=54837
72449         <rdar://problem/9005475>
72450
72451         Add new plug-in test.
72452
72453         * DumpRenderTree/DumpRenderTree.gypi:
72454         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
72455         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
72456         (PluginTest::NPN_GetURL):
72457         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
72458         * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
72459         (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
72460         (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
72461         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
72462         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
72463
72464 2011-02-19  Patrick Gansterer  <paroga@webkit.org>
72465
72466         Reviewed by Andreas Kling.
72467
72468         Make WinCE a core builder
72469         https://bugs.webkit.org/show_bug.cgi?id=54801
72470
72471         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
72472         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
72473
72474 2011-02-19  Lukasz Slachciak  <l.slachciak@samsung.com>
72475
72476         Reviewed by Andreas Kling.
72477
72478         Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
72479         https://webkit.org/b/54778
72480
72481         * Scripts/webkitdirs.pm:
72482
72483 2011-02-18  David Levin  <levin@chromium.org>
72484
72485         Reviewed by Eric Seidel.
72486
72487         check-webkit-style: Misses brace style error when the line with the { has a } in it.
72488         https://bugs.webkit.org/show_bug.cgi?id=54769
72489
72490         * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace
72491           to only look after the last open brace, so that the open brace in this line
72492           "} else {" will still be able to trigger the error.
72493         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
72494
72495 2011-02-18  Zan Dobersek  <zandobersek@gmail.com>
72496
72497         Reviewed by Martin Robinson.
72498
72499         [Gtk] Re-enable meter tag support
72500         https://bugs.webkit.org/show_bug.cgi?id=54762
72501
72502         Meter tag is supported on the Gtk port, enable it by default.
72503
72504         * Scripts/build-webkit:
72505
72506 2011-02-18  David Levin  <levin@chromium.org>
72507
72508         Reviewed by Eric Seidel.
72509
72510         check-webkit-style falsely complains about WebKitGTK+ public headers
72511         https://bugs.webkit.org/show_bug.cgi?id=54650
72512
72513         * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
72514         * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API
72515           to the chromium directory (and improved the checks slightly).
72516         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
72517
72518 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72519
72520         Reviewed by James Robinson.
72521
72522         new-run-webkit-tests: enable multiple processes by default on
72523         mac. This change removes the artificial restrictions we placed
72524         on the # of child processes we used with the old threading
72525         model, and switches to the new message-based model and multiple
72526         processes, where available. If multiple processes are not
72527         available (Leopard / Python 2.5), then we use the 'inline' model
72528         instead of the 'old-threads' model on the 'mac' port or one
72529         process on the 'chromium-mac' port. We need additional testing
72530         to see if the new 'threads' model works reliably and is worth
72531         supporting, or if we should just live with things being slightly
72532         slow.
72533
72534         https://bugs.webkit.org/show_bug.cgi?id=54596
72535
72536         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72537         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
72538         * Scripts/webkitpy/layout_tests/port/mac.py:
72539         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
72540         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
72541
72542 2011-02-18  Andrew Wilson  <atwilson@chromium.org>
72543
72544         Unreviewed, rolling out r79047.
72545         http://trac.webkit.org/changeset/79047
72546         https://bugs.webkit.org/show_bug.cgi?id=54596
72547
72548         Broke canary bots - please watch the canaries the next time
72549         you land this
72550
72551         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72552         * Scripts/webkitpy/layout_tests/port/mac.py:
72553
72554 2011-02-18  Emil A Eklund  <eae@chromium.org>
72555
72556         Reviewed by Darin Adler.
72557
72558         Crash in EventHandler::sendContextMenuEventForKey
72559         https://bugs.webkit.org/show_bug.cgi?id=54495
72560
72561         Add support for the context menu key (VK_APPS) to EventSender for
72562         platforms that support the key.
72563
72564         * DumpRenderTree/chromium/EventSender.cpp:
72565         (EventSender::keyDown):
72566         * DumpRenderTree/gtk/EventSender.cpp:
72567         (keyDownCallback):
72568         * DumpRenderTree/qt/EventSenderQt.cpp:
72569         (EventSender::keyDown):
72570         * DumpRenderTree/win/EventSender.cpp:
72571         (keyDownCallback):
72572
72573 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72574
72575         Reviewed by Ojan Vafai.
72576
72577         new-run-webkit-tests: enable multiple processes by default on mac
72578         https://bugs.webkit.org/show_bug.cgi?id=54596
72579
72580         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72581         * Scripts/webkitpy/layout_tests/port/mac.py:
72582
72583 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72584
72585         Reviewed by Adam Roben.
72586
72587         Skip pretty patch unit tests if ruby isn't installed.
72588
72589         https://bugs.webkit.org/show_bug.cgi?id=54699
72590
72591         * Scripts/webkitpy/common/prettypatch_unittest.py:
72592
72593 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72594
72595         Reviewed by Adam Roben.
72596
72597         Skip mac.test_skipped_file_paths() when running on win32; the
72598         test has hardcoded '/' directory separators and since it's a
72599         port-specific test and we have coverage on other ports it's not
72600         worth it to make the test more generic.
72601
72602         https://bugs.webkit.org/show_bug.cgi?id=54698
72603
72604         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
72605
72606 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72607
72608         Reviewed by Adam Roben.
72609
72610         Fix webkitpy.layout_tests.port.config_unittest to work on Win32.
72611
72612         https://bugs.webkit.org/show_bug.cgi?id=54703
72613
72614         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
72615
72616 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72617
72618         Reviewed by Adam Roben.
72619
72620         Change the default port we're mocking out on win32 when we
72621         run mock_drt_unittest. Normally we'd default to the
72622         port-specific default, but that would be "win", which doesn't
72623         currently work.
72624
72625         https://bugs.webkit.org/show_bug.cgi?id=54708
72626
72627         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
72628
72629 2011-02-18  Kenneth Russell  <kbr@google.com>
72630
72631         Reviewed by James Robinson.
72632
72633         [chromium] Clean up initialization of minimum timer interval
72634         https://bugs.webkit.org/show_bug.cgi?id=54772
72635
72636         Use new GetForegroundTabTimerInterval function in webkit_support
72637         to reset the minimum timer interval before each test.
72638
72639         * DumpRenderTree/chromium/WebViewHost.cpp:
72640         (WebViewHost::reset):
72641
72642 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72643
72644         Reviewed by Adam Roben.
72645
72646         r78494 fixed the chromium_win unittest failing under win32,
72647         but not cygwin. This fixes cygwin as well.
72648
72649         https://bugs.webkit.org/show_bug.cgi?id=54652
72650
72651         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
72652
72653 2011-02-18  Dirk Pranke  <dpranke@chromium.org>
72654
72655         Reviewed by Ojan Vafai, Mihai Parparita.
72656
72657         new-run-webkit-tests: r78522 made it impossible to create a
72658         'chromium-win' or 'chromium-mac' port; they would always get the
72659         version tacked on to the end. It turns out that we actually need
72660         to be able to create these ports in order for
72661         rebaseline-chromium-webkit-tests to work correctly given the
72662         broken coverage of our layout bots. As soon as we get SL and
72663         Win 7 bots running reliably on the canaries, we can get rid of
72664         this change. Note that we only need to change the chromium_mac
72665         and win ports because linux doesn't yet use versions and that
72666         script doesn't work with non-chromium ports.
72667
72668         Also, this change fixes a bug where we were using
72669         "platform/chromium-win-win7" and
72670         "platform/chromium-mac-snowleopard" as the baseline dirs for
72671         Win 7 and SL; we should've been using the generic directories
72672         instead since they are the newest versions of the os's.
72673
72674         https://bugs.webkit.org/show_bug.cgi?id=54691
72675
72676         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
72677         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
72678         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
72679         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
72680         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
72681
72682 2011-02-16  MORITA Hajime  <morrita@google.com>
72683
72684         Reviewed by Kent Tamura.
72685
72686         [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
72687         http://webkit.org/b/53899
72688
72689         Replaced static invocation wrappers with MethodTask objects,
72690         which are removed on WebViewHost destructor.
72691
72692         * DumpRenderTree/chromium/WebViewHost.cpp:
72693         (WebViewHost::requestCheckingOfText):
72694         (WebViewHost::scheduleAnimation):
72695         (WebViewHost::closeWidgetSoon):
72696         * DumpRenderTree/chromium/WebViewHost.h:
72697         (WebViewHost::HostMethodTask::HostMethodTask):
72698         (WebViewHost::HostMethodTask::runIfValid):
72699         (WebViewHost::taskList):
72700
72701 2011-02-07  Hayato Ito  <hayato@chromium.org>
72702
72703         Reviewed by Ojan Vafai.
72704
72705         Get rid of code which writes test results from test_type's
72706         compare_output() method.
72707         Writing test results now happens in single_test_runner, using
72708         newly introduced test_result_writer module.
72709
72710         Subsequent patches will eliminate test_type/* classes.
72711
72712         https://bugs.webkit.org/show_bug.cgi?id=53908
72713
72714         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
72715         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
72716         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
72717         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
72718         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
72719
72720 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
72721
72722         Reviewed by Adam Roben.
72723
72724         Add blacklist of remaining webkitpy/* modules that fail on
72725         Win32, so that test-webkitpy will at least run cleanly.
72726
72727         https://bugs.webkit.org/show_bug.cgi?id=54709
72728
72729         * Scripts/webkitpy/layout_tests/test/main.py:
72730
72731 2011-02-17  Simon Fraser  <simon.fraser@apple.com>
72732
72733         Reviewed by Sam Weinig.
72734
72735         Set a preference to ensure that scrollbars are in a predictable
72736         state for DRT.
72737
72738         * DumpRenderTree/mac/DumpRenderTree.mm:
72739         (resetDefaultsToConsistentValues):
72740
72741 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
72742
72743         Reviewed by Adam Roben.
72744
72745         test-webkitpy doesn't work with the multiprocessing module on win32
72746         or cygwin, so we skip it for now.
72747
72748         https://bugs.webkit.org/show_bug.cgi?id=54520
72749
72750         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
72751         * Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py:
72752
72753 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
72754
72755         Reviewed by Adam Roben.
72756
72757         Fix version, baseline_search_path for chromium-win-win7. Also
72758         fix chromium_win_unittests, and fix port_testcase.make_port()
72759         to correctly use the options passed into it and only set
72760         results_directory() if necessary.
72761
72762         https://bugs.webkit.org/show_bug.cgi?id=54652
72763
72764         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
72765         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
72766         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
72767
72768 2011-02-17  Dirk Pranke  <dpranke@chromium.org>
72769
72770         Reviewed by Ojan Vafai.
72771
72772         Fix a hang in new-run-webkit-tests when run with
72773         --dry-run --worker-model=processes
72774
72775         https://bugs.webkit.org/show_bug.cgi?id=54595
72776
72777         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
72778         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
72779
72780 2011-02-17  Kevin Ollivier  <kevino@theolliviers.com>
72781
72782         [wx] Build fixes after recent changes.
72783
72784         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
72785         (LayoutTestController::setMinimumTimerInterval):
72786         * wx/build/settings.py:
72787
72788 2011-02-17  Csaba Osztrogonác  <ossy@webkit.org>
72789
72790         Reviewed by Andreas Kling.
72791
72792         [Qt] ImageDiff sometimes hangs
72793         https://bugs.webkit.org/show_bug.cgi?id=54641
72794
72795         * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison.
72796         (main):
72797
72798 2011-02-17  Peter Varga  <pvarga@webkit.org>
72799
72800         Reviewed by Csaba Osztrogonác.
72801
72802         The run-sunspider --v8-suite doesn't work
72803         https://bugs.webkit.org/show_bug.cgi?id=54660
72804
72805         * Scripts/run-sunspider:
72806
72807 2011-02-17  Gabor Rapcsanyi  <rgabor@webkit.org>
72808
72809         Reviewed by Csaba Osztrogonác.
72810
72811         [NRWT] Fix environment setup on Qt port.
72812         https://bugs.webkit.org/show_bug.cgi?id=54549
72813
72814         * Scripts/webkitpy/layout_tests/port/qt.py:
72815
72816 2011-02-16  Yael Aharon  <yael.aharon@nokia.com>
72817
72818         Reviewed by Andreas Kling.
72819
72820         [Qt] Enable tiled backing store by default in MiniBrowser.
72821         https://bugs.webkit.org/show_bug.cgi?id=54581
72822
72823         Instead of a flag to turn it on, a new flag is defined to turn
72824         tiled backing store off.
72825
72826         * MiniBrowser/qt/MiniBrowserApplication.cpp:
72827         (MiniBrowserApplication::handleUserOptions):
72828         * MiniBrowser/qt/MiniBrowserApplication.h:
72829         (WindowOptions::WindowOptions):
72830
72831 2011-02-16  Eric Seidel  <eric@webkit.org>
72832
72833         Reviewed by Mihai Parparita.
72834
72835         flaky test archive uploads are always 22 bytes long
72836         https://bugs.webkit.org/show_bug.cgi?id=54593
72837
72838         Speculative fix for the 22-bytes bug.
72839
72840         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
72841
72842 2011-02-16  Anna Cavender  <annacc@chromium.org>
72843
72844         Reviewed by Mihai Parparita.
72845
72846         http/tests/media should be served over HTTP (not from local file)
72847         https://bugs.webkit.org/show_bug.cgi?id=54028
72848
72849         Removed special file:// treatment of http/tests/media
72850
72851         * Scripts/old-run-webkit-tests:
72852         * Scripts/webkitpy/layout_tests/port/base.py:
72853
72854 2011-02-16  Mihai Parparita  <mihaip@chromium.org>
72855
72856         Reviewed by Ojan Vafai.
72857
72858         ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
72859         https://bugs.webkit.org/show_bug.cgi?id=54609
72860
72861         r78737 rolled over ChangeLogs, and webkit-patch complains when landing
72862         patches such as this one that are the first to add an entry to the
72863         ChangeLog (since they don't see a second date line to know where the
72864         entry ends).
72865
72866         * Scripts/webkitpy/common/checkout/changelog.py:
72867         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
72868
72869 == Rolled over to ChangeLog-2011-02-16 ==